Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Wed Nov 3 07:55:51 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 )

Change subject: gbproxy: Move BSSGP decoding into its own function and use it
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/2/src/gb_proxy.c 
File src/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/2/src/gb_proxy.c@1043 
PS2, Line 1043: 	rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx);
> so we don't need 2 TLVs anymore? or where they never needed?
They were never needed. The second one is only used to handle RIM messages which can have multiple (src/dst) RIM_ROUTING_INFO IEs. It doesn't matter for parsing here since we don't need to look at those.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7
Gerrit-Change-Number: 26062
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Nov 2021 07:55:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211103/c3085bd2/attachment.htm>


More information about the gerrit-log mailing list