This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 7: (3 comments) https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h File include/osmocom/msc/mncc.h: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h@166 PS7, Line 166: uint8_t gcr[16]; > looks like we want a header file in libosmocore for 29. […] Depending of the content, encoded GCR may have different length. We could define some maximum, but I don't think it's strictly necessary. https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c@529 PS7, Line 529: if (msg != NULL && (rc = osmo_enc_gcr(gcr_msg, gcr)) > 0) { > why should msg be null? Because msgb_alloc() may theoretically return NULL. https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c@530 PS7, Line 530: memcpy(&setup.gcr[0], gcr_msg->data, rc); > why this double copy? simply pass &setup. […] Because osmo_enc_gcr() accepts a 'struct msgb' pointer. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 02 Nov 2021 18:07:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211102/c28492c8/attachment.htm>