Change in osmo-ci[master]: lint: checkpatch.pl: break exclude loop early

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Nov 2 13:40:22 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25964 )

Change subject: lint: checkpatch.pl: break exclude loop early
......................................................................

lint: checkpatch.pl: break exclude loop early

When running the linter on a patch with lots of files changed, and lots
of exclude files, this makes a big difference. On my machine, running an
osmo-iuh patch with 1580 files changed, and the high amount of asn1c
related excludes, the time for linting is reduced from 50s to 25s.

This should be acceptable, since typically we change only few files.

Change-Id: I6fb41dec25ecc1f2df7242ae041a8685a696c3fd
---
M lint/checkpatch/checkpatch.pl
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl
index 06e6e36..e31a61f 100755
--- a/lint/checkpatch/checkpatch.pl
+++ b/lint/checkpatch/checkpatch.pl
@@ -2813,6 +2813,7 @@
 		foreach (@exclude) {
 			if ($realfile =~ m@$_@) {
 				$skipme = 1;
+				last; # break out of the loop
 			}
 		}
 		if ($skipme) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25964
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6fb41dec25ecc1f2df7242ae041a8685a696c3fd
Gerrit-Change-Number: 25964
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211102/b8ac12dc/attachment.htm>


More information about the gerrit-log mailing list