Change in osmo-hnodeb[master]: main.c: Drop commented out code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Nov 2 12:00:31 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25998 )

Change subject: main.c: Drop commented out code
......................................................................

main.c: Drop commented out code

We can always get it back from git history if necessary, let's drop it.

Change-Id: I6ea1e3b8692cc6e162962d2e812eb1342c100251
---
M src/osmo-hnodeb/main.c
1 file changed, 0 insertions(+), 67 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c
index ae9403d..a9c26bf 100644
--- a/src/osmo-hnodeb/main.c
+++ b/src/osmo-hnodeb/main.c
@@ -81,38 +81,6 @@
 
 struct msgb *rua_new_udt(struct msgb *inmsg);
 
-#if 0
-static int hnb_ue_de_register_tx(struct hnb *hnb)
-{
-	struct msgb *msg;
-	int rc;
-	uint32_t ctx_id;
-
-	UEDe_Register_t dereg;
-	UEDe_RegisterIEs_t dereg_ies;
-	memset(&dereg_ies, 0, sizeof(dereg_ies));
-
-	asn1_u24_to_bitstring(&dereg_ies.context_ID, &ctx_id, hnb->ctx_id);
-	dereg_ies.cause.present = Cause_PR_radioNetwork;
-	dereg_ies.cause.choice.radioNetwork = CauseRadioNetwork_connection_with_UE_lost;
-
-	memset(&dereg, 0, sizeof(dereg));
-	rc = hnbap_encode_uede_registeries(&dereg, &dereg_ies);
-	OSMO_ASSERT(rc == 0);
-
-	msg = hnbap_generate_initiating_message(ProcedureCode_id_UEDe_Register,
-						Criticality_ignore,
-						&asn_DEF_UEDe_Register,
-						&dereg);
-
-	ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_UEDe_Register, &dereg);
-
-	msgb_sctp_ppid(msg) = IUH_PPI_HNBAP;
-
-	return osmo_wqueue_enqueue(&hnb->wqueue, msg);
-}
-#endif
-
 int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str)
 {
 	struct msgb *msg;
@@ -848,41 +816,6 @@
 	}
 	sctp_sock_init(g_hnb.wqueue.bfd.fd);
 
-#if 0
-	/* some hard-coded message generation.  Doesn't make sense from
-	 * a protocol point of view but enables to look at the encoded
-	 * results in wireshark for manual verification */
-	{
-		struct msgb *msg, *rua;
-		const uint8_t nas[] = { 0, 1, 2, 3 };
-		const uint8_t ik[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 };
-
-		msg = ranap_new_msg_dt(0, nas, sizeof(nas));
-		rua = rua_new_udt(msg);
-		osmo_wqueue_enqueue(&g_hnb.wqueue, rua);
-
-		msg = ranap_new_msg_sec_mod_cmd(ik, ik, RANAP_KeyStatus_new);
-		rua = rua_new_udt(msg);
-		osmo_wqueue_enqueue(&g_hnb.wqueue, rua);
-
-		msg = ranap_new_msg_iu_rel_cmd()
-		rua = rua_new_udt(msg);
-		osmo_wqueue_enqueue(&g_hnb.wqueue, rua);
-
-		msg = ranap_new_msg_paging_cmd("901990123456789", NULL, 0, 0);
-		rua = rua_new_udt(msg);
-		osmo_wqueue_enqueue(&g_hnb.wqueue, rua);
-
-		msg = ranap_new_msg_rab_assign_voice(1, 0x01020304, 0x1020);
-		rua = rua_new_udt(msg);
-		osmo_wqueue_enqueue(&g_hnb.wqueue, rua);
-
-		msg = ranap_new_msg_rab_assign_data(2, 0x01020304, 0x11223344);
-		rua = rua_new_udt(msg);
-		osmo_wqueue_enqueue(&g_hnb.wqueue, rua);
-	}
-#endif
-
 	while (1) {
 		rc = osmo_select_main(0);
 		if (rc < 0)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I6ea1e3b8692cc6e162962d2e812eb1342c100251
Gerrit-Change-Number: 25998
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211102/4e32b289/attachment.htm>


More information about the gerrit-log mailing list