This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 2: (3 comments) Letting other decide on whether they accept the current proposal as it is now. https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h@1439 PS1, Line 1439: CHAN_COUNTS2_N > A more usual naming would be '_CHAN_COUNTS2_NUM'. Ack https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h@1448 PS1, Line 1448: typedef unsigned int chan_counts_t [CHAN_COUNTS1_N][CHAN_COUNTS2_N][_GSM_LCHAN_MAX]; > it'll be quite a bit of effort to change this. […] I wouldn't call it a personal preference, it's having a way to pass a data structure in an easy way which is later easier to extend instead of having to pass a 3 dimensional array or a pointer to some 3dimensional array mapped memory. It also gets rid of typedefs for not simple types, which is what the linux kernel style guide states. https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c@1961 PS1, Line 1961: chan_counts_t bts_counts; > well, we usually use 'struct foo' or 'enum foo', but this typedef (used to pinpoint the array sizes) […] If you had struct chan_counts, none of this would be an issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 02 Nov 2021 10:52:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211102/e9710082/attachment.htm>