Change in osmo-bts[master]: measurement: pass *mr to lchan_bs_pwr_ctrl()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Nov 2 10:45:40 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26049 )

Change subject: measurement: pass *mr to lchan_bs_pwr_ctrl()
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/measurement.c 
File src/common/measurement.c:

https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/measurement.c@957 
PS4, Line 957: 	if (mr && mr->meas_valid == 0) /* 0 = valid */
I've seen this clarification several times already: mr->meas_valid == 0) /* 0 = valid */
Please add a static inline boor meas_is_valid(mr);


https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/power_control.c 
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/power_control.c@338 
PS4, Line 338: 	if (ctrl_interval_skip_block(params, state))
not entirely relaed to this patch, but I just noticed that if we don'tn receive proper meas result, then we don't decrease the period counter, which is wrong imho. We should ideally keep decreasing it, and if it reaches 0 when meas is invalid, then keep it at 1 to make it trigger next time we recieve a MR.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26049
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I937117cf26fb718d57920382f6972390ad498c51
Gerrit-Change-Number: 26049
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Nov 2021 10:45:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211102/b9fd5dfc/attachment.htm>


More information about the gerrit-log mailing list