This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py@87 PS1, Line 87: card_is_uicc = probe_card(card, ['UICC']) > why does the 'UICC' get passed in a list? […] It gets passed in a list because in theory the function can do more than one test in one go. Its also possible to ask ['UICC', 'SIM'] = Is this a UICC card with SIM functionality? Unfortunately I noticed that I did not need the possibility to ask for both at once. Regarding the card model I think we should try to drop it - we could keep the file as compatibility layer for pySim-prog and pySim-read, but in pySim-shell we should try to use the SimCardCommands class directly. Thats what we already do by using the private _scc object in the card object, which is not nice because _scc is ment to be a private property of the card. I think the only special functions of the card object we use is the verify_adm method, which may be different for each card. This is not much and can separated, so that the pySim-shell and the old code can use it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 01 Nov 2021 13:38:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211101/18df0c97/attachment.htm>