This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25976 ) Change subject: heighbor_ident: add/del neighbor cells via ctrl interface ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc File doc/manuals/chapters/control.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc@148 PS5, Line 148: FIXME: add variables defined in src/ctrl/control_if.c? > that line already existed before hand. […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c File src/osmo-bsc/neighbor_ident_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c@48 PS5, Line 48: return 1; > it is unusual in osmocom code to return positive integers in error case. […] Its indeed a bit odd, however I have oriented myself here on the verify_ functions in other code locations. I don't know why we use a different scheme for the control interface... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Gerrit-Change-Number: 25976 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 01 Nov 2021 11:28:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211101/f0b7bb02/attachment.htm>