This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25971 ) Change subject: constify lchan_state_is() ...................................................................... constify lchan_state_is() An upcoming patch would rather pass a const struct gsm_lchan*. See I2fb48c549186db812b1e9d6b735a92e80f27b8d3. Related: OS#4878 Change-Id: I523cbf04e77f43924c3f09094d56f815d3de640d --- M include/osmocom/bsc/lchan_fsm.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h index e7a06d5..fa0d299 100644 --- a/include/osmocom/bsc/lchan_fsm.h +++ b/include/osmocom/bsc/lchan_fsm.h @@ -72,7 +72,7 @@ return lchan->fi ? osmo_fsm_inst_state_name(lchan->fi) : "NULL"; } -static inline bool lchan_state_is(struct gsm_lchan *lchan, uint32_t state) +static inline bool lchan_state_is(const struct gsm_lchan *lchan, uint32_t state) { return (!lchan->fi && state == LCHAN_ST_UNUSED) || (lchan->fi && lchan->fi->state == state); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I523cbf04e77f43924c3f09094d56f815d3de640d Gerrit-Change-Number: 25971 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211101/a1d887d6/attachment.htm>