From noreply at opensuse.org Mon Nov 1 00:39:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 01 Nov 2021 00:39:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <617f3758a92bf_11002ae3d3bb2600874213@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 219s] intention of the Shared Library Policy is to allow parallel installation of [ 219s] multiple versions of the same shared library, hard dependencies likely make [ 219s] that impossible. Please remove this dependency and instead move it to the [ 219s] runtime uses of your library. [ 219s] [ 219s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 219s] The package contains an init script or systemd service file but lacks the [ 219s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 219s] [ 219s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 219s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 219s] This package contains a library and provides no %post scriptlet containing a [ 219s] call to ldconfig. [ 219s] [ 219s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 219s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 219s] This package contains a library and provides no %postun scriptlet containing a [ 219s] call to ldconfig. [ 219s] [ 219s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 219s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 219s] [ 219s] ### VM INTERACTION START ### [ 223s] [ 212.302888] sysrq: SysRq : Power Off [ 223s] [ 212.307398] reboot: Power down [ 223s] ### VM INTERACTION END ### [ 223s] [ 223s] old-cirrus1 failed "build osmo-iuh.spec" at Mon Nov 1 00:39:27 UTC 2021. [ 223s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 1 00:39:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 01 Nov 2021 00:39:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <617f3758f35b2_11002ae3d3bb2600874388@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 180s] intention of the Shared Library Policy is to allow parallel installation of [ 180s] multiple versions of the same shared library, hard dependencies likely make [ 180s] that impossible. Please remove this dependency and instead move it to the [ 180s] runtime uses of your library. [ 180s] [ 180s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 180s] The package contains an init script or systemd service file but lacks the [ 180s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 180s] [ 180s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 180s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 180s] This package contains a library and provides no %post scriptlet containing a [ 180s] call to ldconfig. [ 180s] [ 180s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 180s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 180s] This package contains a library and provides no %postun scriptlet containing a [ 180s] call to ldconfig. [ 180s] [ 180s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 180s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 180s] [ 180s] ### VM INTERACTION START ### [ 183s] [ 174.278214] sysrq: Power Off [ 183s] [ 174.285844] reboot: Power down [ 183s] ### VM INTERACTION END ### [ 183s] [ 183s] lamb16 failed "build osmo-iuh.spec" at Mon Nov 1 00:39:31 UTC 2021. [ 183s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 1 00:41:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 01 Nov 2021 00:41:01 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <617f37afbf09d_11002ae3d3bb260087472@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 554s] # we create a symlink at ./srcfile.adoc pointing at [ 554s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 554s] # is like basename from coreutils, and . is WD. [ 554s] if ! [ -f test-usermanual.adoc ]; then \ [ 554s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 554s] fi [ 554s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 554s] # in ... [ 554s] TEXINPUTS=".." \ [ 554s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 554s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 554s] a2x: resource files: [] [ 554s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 554s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 554s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 554s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 554s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 554s] make[1]: *** [Makefile:363: all] Error 2 [ 554s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 554s] dh_auto_build: error: make -j1 returned exit code 2 [ 554s] make: *** [debian/rules:5: binary] Error 25 [ 554s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 554s] ### VM INTERACTION START ### [ 555s] Powering off. [ 555s] [ 536.030382] reboot: Power down [ 556s] ### VM INTERACTION END ### [ 556s] [ 556s] lamb57 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111010026.dsc" at Mon Nov 1 00:40:57 UTC 2021. [ 556s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 1 00:41:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 01 Nov 2021 00:41:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <617f37ce9f62c_11002ae3d3bb26008748be@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 305s] intention of the Shared Library Policy is to allow parallel installation of [ 305s] multiple versions of the same shared library, hard dependencies likely make [ 305s] that impossible. Please remove this dependency and instead move it to the [ 305s] runtime uses of your library. [ 305s] [ 305s] osmo-iuh.aarch64: W: suse-missing-rclink osmo-hnbgw [ 305s] The package contains an init script or systemd service file but lacks the [ 305s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 305s] [ 305s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 305s] libosmo-rua0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 305s] This package contains a library and provides no %post scriptlet containing a [ 305s] call to ldconfig. [ 305s] [ 305s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 305s] libosmo-rua0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 305s] This package contains a library and provides no %postun scriptlet containing a [ 305s] call to ldconfig. [ 305s] [ 305s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 305s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 305s] [ 305s] ### VM INTERACTION START ### [ 308s] [ 295.147250] sysrq: SysRq : Power Off [ 308s] [ 295.148798] reboot: Power down [ 308s] ### VM INTERACTION END ### [ 308s] [ 308s] obs-arm-9 failed "build osmo-iuh.spec" at Mon Nov 1 00:41:33 UTC 2021. [ 308s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 1 03:46:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 01 Nov 2021 03:46:20 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <617f632373db2_11002ae3d3bb26008937a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 1689s] intention of the Shared Library Policy is to allow parallel installation of [ 1689s] multiple versions of the same shared library, hard dependencies likely make [ 1689s] that impossible. Please remove this dependency and instead move it to the [ 1689s] runtime uses of your library. [ 1689s] [ 1689s] osmo-iuh.armv7hl: W: suse-missing-rclink osmo-hnbgw [ 1689s] The package contains an init script or systemd service file but lacks the [ 1689s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 1689s] [ 1689s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 1689s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 1689s] This package contains a library and provides no %post scriptlet containing a [ 1689s] call to ldconfig. [ 1689s] [ 1689s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 1689s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 1689s] This package contains a library and provides no %postun scriptlet containing a [ 1689s] call to ldconfig. [ 1689s] [ 1689s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 1689s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 1689s] [ 1689s] ### VM INTERACTION START ### [ 1693s] [ 1633.407505] sysrq: SysRq : Power Off [ 1693s] [ 1633.458355] reboot: Power down [ 1694s] ### VM INTERACTION END ### [ 1694s] [ 1694s] obs-arm-6 failed "build osmo-iuh.spec" at Mon Nov 1 03:46:09 UTC 2021. [ 1694s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Nov 1 09:43:45 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 09:43:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 to look at the new patch set (#4). Change subject: BSC_Tests: set band in f_TC_fh_params_set ...................................................................... BSC_Tests: set band in f_TC_fh_params_set The function f_TC_fh_params_set sets frequency hopping parameters. The ARFCN is also part of those parameters. However, this function does not set the respective band for the ARFCN that it configurs. This results in an invalid setting at the BSC that might cause unexpected behavior. Lets make sure we configure the band parameter correctly before setting the ARFCN Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647 Related: SYS#5369 --- M bsc/BSC_Tests.ttcn 1 file changed, 39 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/25828/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647 Gerrit-Change-Number: 25828 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 09:43:57 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 09:43:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 ) Change subject: BSC_Tests: set band in f_TC_fh_params_set ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn at 8579 PS3, Line 8579: var GsmBandArfcn arfcn_ := valueof(ts_GsmBandArfcn(arfcn.arfcn, arfcn.pcs, false)); > Could you please explain why you're doing this? I guess this has something to do with the 'uplink' a [?] I am doing this because it is not possible to use ts_GsmBandArfcn from inside the function definition: private function f_TC_fh_params_unset(in FHParamsTrx fhp, uint8_t bts_nr := 0, uint8_t trx_nr := 0, GsmBandArfcn arfcn := {pcs := false, arfcn := 871}) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn at 8581 PS3, Line 8581: select (arfcn_) { > The 'case' statements should be inline with the 'select', similar to 'switch' in C. [?] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828/3/bsc/BSC_Tests.ttcn at 8582 PS3, Line 8582: ? > Not critical, but this argument can be omitted here (and below) because '?' is the default value. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647 Gerrit-Change-Number: 25828 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 01 Nov 2021 09:43:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 09:49:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Nov 2021 09:49:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 ) Change subject: BSC_Tests: set band in f_TC_fh_params_set ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647 Gerrit-Change-Number: 25828 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 01 Nov 2021 09:49:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 10:37:00 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 10:37:00 +0000 Subject: Change in osmo-bsc[master]: neighbor_ident: add comment about Neighbor Address Resolution Service In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25977 ) Change subject: neighbor_ident: add comment about Neighbor Address Resolution Service ...................................................................... neighbor_ident: add comment about Neighbor Address Resolution Service The Neighbor Address Resolution Service is using the control interface API as well. Lets add a comment to indicate that this service is not related to the normal control interface. Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852 --- M src/osmo-bsc/neighbor_ident.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/neighbor_ident.c b/src/osmo-bsc/neighbor_ident.c index c66d3ac..44b0b43 100644 --- a/src/osmo-bsc/neighbor_ident.c +++ b/src/osmo-bsc/neighbor_ident.c @@ -489,6 +489,7 @@ struct ctrl_handle *neighbor_controlif_setup(struct gsm_network *net) { + /* See also osmobsc-usermanual.pdf, section 14.1 Neighbor Address Resolution Service */ return ctrl_interface_setup_dynip2(net, net->neigh_ctrl.addr, net->neigh_ctrl.port, NULL, _LAST_CTRL_NODE_NEIGHBOR); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852 Gerrit-Change-Number: 25977 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:12:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 11:12:19 +0000 Subject: Change in simtrace2[master]: firmware: add bootloader update "app" In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26026 ) Change subject: firmware: add bootloader update "app" ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/simtrace2/+/26026/3/firmware/Makefile File firmware/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/26026/3/firmware/Makefile at 248 PS3, Line 248: EXTRA_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(EXTRA_OBJECTS)) > tbh, I'm not following exactly what you are doing here in detail without further analysis, but it lo [?] As the commit message states the bl binary gets embedded into the updater firmware, this is what those changes do. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3 Gerrit-Change-Number: 26026 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Nov 2021 11:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:22:48 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 1 Nov 2021 11:22:48 +0000 Subject: Change in osmo-bsc[master]: constify lchan_state_is() In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25971 ) Change subject: constify lchan_state_is() ...................................................................... constify lchan_state_is() An upcoming patch would rather pass a const struct gsm_lchan*. See I2fb48c549186db812b1e9d6b735a92e80f27b8d3. Related: OS#4878 Change-Id: I523cbf04e77f43924c3f09094d56f815d3de640d --- M include/osmocom/bsc/lchan_fsm.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h index e7a06d5..fa0d299 100644 --- a/include/osmocom/bsc/lchan_fsm.h +++ b/include/osmocom/bsc/lchan_fsm.h @@ -72,7 +72,7 @@ return lchan->fi ? osmo_fsm_inst_state_name(lchan->fi) : "NULL"; } -static inline bool lchan_state_is(struct gsm_lchan *lchan, uint32_t state) +static inline bool lchan_state_is(const struct gsm_lchan *lchan, uint32_t state) { return (!lchan->fi && state == LCHAN_ST_UNUSED) || (lchan->fi && lchan->fi->state == state); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I523cbf04e77f43924c3f09094d56f815d3de640d Gerrit-Change-Number: 25971 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:23:09 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 1 Nov 2021 11:23:09 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 to look at the new patch set (#2). Change subject: refactor lchan counting ...................................................................... refactor lchan counting Add chan_counts_for_trx() and chan_counts_for_bts(). Drop bts_count_free_ts() and trx_count_free_ts(). Rationale: The bts_count_free_ts() and trx_count_free_ts() always returned the number of free lchans, not timeslots. Hence, passing the pchan type as argument never really matched the semantics. Especially, when looking for free SDCCH, there is no clear match on a gsm_phys_chan_config enum value: SDCCH8_SACCH8C, CCCH_SDCCH4, CCCH_SDCCH4_CBCH, SDCCH8_SACCH8C_CBCH? -- GSM_LCHAN_SDCCH is clear. ==> Rather count free lchans by enum gsm_chan_t. Counting lchans of distinct types required separate iterations for each lchan type. ==> Rather compose an array of counts for all types, in one go. I need to count the amount of free SDCCH lchans in an upcoming patch to implement the performance indicator allAvailableAllocatedSDCCH (cumulate time for which no SDCCH are available). To implement allAvailableAllocated{SDCCH,TCH}, I need a count of both the used as well as the total lchans for a type: it does not make sense to flag "all available allocated" if none are ever available. To properly count dynamic ts, I need the maximum total that can be possible at any time. And to count currently free lchans, I need the current total. This may seem counter intuitive, but consider, e.g.: - Obviously, if a cell has only static TCH/F timeslots, it does not make sense to flag that all available TCH/H are occupied, because no TCH/H are available ever. Just stating this as contrast to dyn TS. - If a cell has OSMO_DYN timeslots, I *do* want to flag that all TCH/H are occupied when all dyn timeslots are fully occupied. - If those OSMO_DYN however are all used as TCH/F, the current total of TCH/H becomes zero, and it seems like TCH/H should not be considered. - To count the nr of currently free lchans, I need the currently possible total of lchans and the nr of occupied lchans. So return both a maximum total and a current total of lchans. In above example, the maximum total shows that there would be TCH/H possible. BTW, it would be nice to keep a chan_counts array on trx, bts and bsc level and update as channels are allocated and released, instead of counting them all over periodically. But it's less error prone this way. Related: SYS#4878 Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/bts_trx.h A include/osmocom/bsc/chan_counts.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx.c A src/osmo-bsc/chan_counts.c M src/osmo-bsc/handover_decision_2.c 10 files changed, 219 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/25972/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:25:09 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 11:25:09 +0000 Subject: Change in simtrace2[master]: firmware: increase reset delay before usb reattach In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26028 ) Change subject: firmware: increase reset delay before usb reattach ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/simtrace2/+/26028/3/firmware/libcommon/source/usb.c File firmware/libcommon/source/usb.c: https://gerrit.osmocom.org/c/simtrace2/+/26028/3/firmware/libcommon/source/usb.c at 693 PS3, Line 693: mdelay(500); > are we sure this doesn't make us run into the watchdog? I don't see how, the apps are loaded immediately by calling their reset handler functions from the bl reset handler, and those apps then initialize the WD with a 2s timeout before calling this function, there is nothing that should be blocking this long here, and after returning the wd gets reset while waiting until usb is initialized. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36 Gerrit-Change-Number: 26028 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 11:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:26:24 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 1 Nov 2021 11:26:24 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 2: (2 comments) Shifted things around a bit and fixed a few patch errors (unrelated changes that shouldn't have been in the patch). Using a typedef to fixate the array dimensions is still my favorite solution. I wouldn't generally allow typedefs, so in this case i would delete the linter -1, instead of disabling the linter test. https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h at 1448 PS1, Line 1448: typedef unsigned int chan_counts_t [CHAN_COUNTS1_N][CHAN_COUNTS2_N][_GSM_LCHAN_MAX]; > I'd go for the struct with the multidimensional array inside it. [?] it'll be quite a bit of effort to change this. With array-in-a-struct there's still the problem with functions working on only the third or second dimension. With a struct, how would you solve chan_counts_dim3_add()? I find that moving to a struct makes things more complex, and it seems there is no benefit besides personal preference? https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c at 1974 PS1, Line 1974: free_tchf = bts_counts[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; > Yes please, a getter like you wrote, and with some minimal description like "Remember to call bts_co [?] i don't see the point for such a getter function. it makes for literally the same code except punctuation and braces. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Nov 2021 11:26:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:28:24 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 11:28:24 +0000 Subject: Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25976 ) Change subject: heighbor_ident: add/del neighbor cells via ctrl interface ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc File doc/manuals/chapters/control.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc at 148 PS5, Line 148: FIXME: add variables defined in src/ctrl/control_if.c? > that line already existed before hand. [?] Done https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c File src/osmo-bsc/neighbor_ident_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c at 48 PS5, Line 48: return 1; > it is unusual in osmocom code to return positive integers in error case. [?] Its indeed a bit odd, however I have oriented myself here on the verify_ functions in other code locations. I don't know why we use a different scheme for the control interface... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Gerrit-Change-Number: 25976 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 11:28:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:28:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 11:28:41 +0000 Subject: Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 to look at the new patch set (#6). Change subject: heighbor_ident: add/del neighbor cells via ctrl interface ...................................................................... heighbor_ident: add/del neighbor cells via ctrl interface The VTY allows flexible control over the neighbor cell information via the neighbor command, which can be found in the configure terminal under the bts node. Lets add pendant of this command on the control interface as well. Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Related: SYS#5641 --- M doc/manuals/chapters/control.adoc M include/osmocom/bsc/neighbor_ident.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_ctrl_commands.c A src/osmo-bsc/neighbor_ident_ctrl.c M src/osmo-bsc/neighbor_ident_vty.c M tests/ctrl_test_runner.py 7 files changed, 958 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/25976/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Gerrit-Change-Number: 25976 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 11:28:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 11:28:41 +0000 Subject: Change in osmo-bsc[master]: control.adoc: comment out fixme note References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26052 ) Change subject: control.adoc: comment out fixme note ...................................................................... control.adoc: comment out fixme note The fixme note: "FIXME: add variables defined in src/ctrl/control_if.c?" is not directed at the reader of the manual. It should stay in the source, but it should not be visible in the pdf. Lets comment it out. Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 --- M doc/manuals/chapters/control.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/26052/1 diff --git a/doc/manuals/chapters/control.adoc b/doc/manuals/chapters/control.adoc index 9193646..b57c31c 100644 --- a/doc/manuals/chapters/control.adoc +++ b/doc/manuals/chapters/control.adoc @@ -148,4 +148,4 @@ NOTE: The bsic-number () can also be set to "any" if no explcit bsic shall be given -FIXME: add variables defined in src/ctrl/control_if.c? +//FIXME: add variables defined in src/ctrl/control_if.c? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 Gerrit-Change-Number: 26052 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:02:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:02:52 +0000 Subject: Change in simtrace2[master]: firmware: add bootloader update "app" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26026 ) Change subject: firmware: add bootloader update "app" ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3 Gerrit-Change-Number: 26026 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Nov 2021 12:02:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:03:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:03:54 +0000 Subject: Change in simtrace2[master]: firmware: add bootloader update "app" In-Reply-To: References: Message-ID: laforge has uploaded a new patch set (#4) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/26026 ) Change subject: firmware: add bootloader update "app" ...................................................................... firmware: add bootloader update "app" This bl updater can be flashed as app and will update the bootloader and then delete itself before resetting the sam3, so the device will end up in the newly updated dfu bootloader afterwards, without having to press the bootloader button or requring any other manual interaction, ready to receive a new application image. Building the blupdater requires a previously built dfu-flash bootloader bin file that will then be embedded into the app during building. Related: OS#1704 Related: SYS5061 Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3 --- M Makefile M firmware/Makefile A firmware/apps/blupdate/Makefile A firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld 5 files changed, 192 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/26/26026/4 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3 Gerrit-Change-Number: 26026 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:04:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:04:19 +0000 Subject: Change in simtrace2[master]: firmware: add bootloader update "app" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26026 ) Change subject: firmware: add bootloader update "app" ...................................................................... Patch Set 4: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3 Gerrit-Change-Number: 26026 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Nov 2021 12:04:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:04:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:04:21 +0000 Subject: Change in simtrace2[master]: firmware: add bootloader update "app" In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26026 ) Change subject: firmware: add bootloader update "app" ...................................................................... firmware: add bootloader update "app" This bl updater can be flashed as app and will update the bootloader and then delete itself before resetting the sam3, so the device will end up in the newly updated dfu bootloader afterwards, without having to press the bootloader button or requring any other manual interaction, ready to receive a new application image. Building the blupdater requires a previously built dfu-flash bootloader bin file that will then be embedded into the app during building. Related: OS#1704 Related: SYS5061 Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3 --- M Makefile M firmware/Makefile A firmware/apps/blupdate/Makefile A firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld 5 files changed, 192 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/Makefile b/Makefile index b15f38d..9951e54 100644 --- a/Makefile +++ b/Makefile @@ -8,16 +8,23 @@ endef $(eval $(call RULES,simtrace,dfu)) +$(eval $(call RULES,simtrace,blupdate)) $(eval $(call RULES,simtrace,trace)) $(eval $(call RULES,simtrace,cardem)) $(eval $(call RULES,qmod,dfu)) +$(eval $(call RULES,qmod,blupdate)) $(eval $(call RULES,qmod,cardem)) $(eval $(call RULES,ngff_cardem,dfu)) +$(eval $(call RULES,ngff_cardem,blupdate)) $(eval $(call RULES,ngff_cardem,trace)) $(eval $(call RULES,ngff_cardem,cardem)) -fw-clean: fw-simtrace-dfu-clean fw-simtrace-trace-clean fw-simtrace-cardem-clean fw-qmod-dfu-clean fw-qmod-cardem-clean -fw: fw-simtrace-dfu fw-simtrace-trace fw-simtrace-cardem fw-qmod-dfu fw-qmod-cardem fw-ngff_cardem-dfu fw-ngff_cardem-trace fw-ngff_cardem-cardem +fw-clean: fw-simtrace-dfu-clean fw-simtrace-blupdate-clean fw-simtrace-trace-clean fw-simtrace-cardem-clean \ + fw-qmod-dfu-clean fw-qmod-blupdate-clean fw-qmod-cardem-clean \ + fw-ngff_cardem-dfu-clean fw-ngff_cardem-blupdate-clean fw-ngff_cardem-trace-clean fw-ngff_cardem-cardem-clean +fw: fw-simtrace-dfu fw-simtrace-blupdate fw-simtrace-trace fw-simtrace-cardem \ + fw-qmod-dfu fw-qmod-blupdate fw-qmod-cardem \ + fw-ngff_cardem-dfu fw-ngff_cardem-blupdate fw-ngff_cardem-trace fw-ngff_cardem-cardem utils: (cd host && \ diff --git a/firmware/Makefile b/firmware/Makefile index bfe2c9d..810c7f3 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -245,12 +245,13 @@ define RULES C_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(C_OBJECTS)) ASM_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(ASM_OBJECTS)) +EXTRA_OBJECTS_$(1) = $(addprefix $(OBJ)/$(1)_, $(EXTRA_OBJECTS)) -$(1): $$(ASM_OBJECTS_$(1)) $$(C_OBJECTS_$(1)) - $(SILENT)$(CC) $(CFLAGS) $(LDFLAGS) $(LD_OPTIONAL) -T"libboard/common/resources/$(CHIP)/$$@.ld" -Wl,-Map,$(OUTPUT)-$$@.map -o $(OUTPUT)-$$@.elf $$^ $(LIBS) - $(SILENT)$(NM) $(OUTPUT)-$$@.elf >$(OUTPUT)-$$@.elf.txt - $(SILENT)$(OBJCOPY) -O binary $(OUTPUT)-$$@.elf $(OUTPUT)-$$@.bin - $(SILENT)$(SIZE) $$^ $(OUTPUT)-$$@.elf +build_$(1): $$(ASM_OBJECTS_$(1)) $$(C_OBJECTS_$(1)) $$(EXTRA_OBJECTS_$(1)) + $(SILENT)$(CC) $(CFLAGS) $(LDFLAGS) $(LD_OPTIONAL) -T"libboard/common/resources/$(CHIP)/$(1).ld" -Wl,-Map,$(OUTPUT)-$(1).map -o $(OUTPUT)-$(1).elf $$^ $(LIBS) + $(SILENT)$(NM) $(OUTPUT)-$(1).elf >$(OUTPUT)-$(1).elf.txt + $(SILENT)$(OBJCOPY) -O binary $(OUTPUT)-$(1).elf $(OUTPUT)-$(1).bin + $(SILENT)$(SIZE) $$^ $(OUTPUT)-$(1).elf $$(C_OBJECTS_$(1)): $(OBJ)/$(1)_%.o: %.c Makefile $(OBJ) $(BIN) @echo [COMPILING $$<] @@ -258,13 +259,34 @@ $$(ASM_OBJECTS_$(1)): $(OBJ)/$(1)_%.o: %.S Makefile $(OBJ) $(BIN) @echo [ASSEMBLING $$@] - $(SILENT)@$(CC) $(ASFLAGS) -DENVIRONMENT_$(1) -DENVIRONMENT=\"$(1)\" -c -o $$@ $$< + $(SILENT)$(CC) $(ASFLAGS) -DENVIRONMENT_$(1) -DENVIRONMENT=\"$(1)\" -c -o $$@ $$< debug_$(1): $(1) $(GDB) -x "$(BOARD_LIB)/resources/gcc/$(BOARD)_$(1).gdb" -ex "reset" -readnow -se $(OUTPUT)-$(1).elf endef -$(foreach MEMORY, $(MEMORIES), $(eval $(call RULES,$(MEMORY)))) +ALL_MEMORIES = dfu flash ram +$(foreach MEMORY, $(ALL_MEMORIES), $(eval $(call RULES,$(MEMORY)))) + +# files with those names do exist.. +.PHONY: ram +.PHONY: dfu +.PHONY: flash +ram: build_ram +dfu: build_dfu +ifeq ($(APP), blupdate) + $(info updating updater section with padded bootloader file..) + $(SILENT)dd if=/dev/zero bs=16384 count=1 of=$(BIN)/$(BOARD)-dfu-flash-padded.bin + $(SILENT)dd if=$(BIN)/$(BOARD)-dfu-flash.bin conv=notrunc of=$(BIN)/$(BOARD)-dfu-flash-padded.bin + $(SILENT)$(OBJCOPY) --update-section .blupdate=bin/$(BOARD)-dfu-flash-padded.bin bin/$(BOARD)-blupdate-dfu.elf + $(SILENT)$(OBJCOPY) -O binary bin/$(BOARD)-blupdate-dfu.elf bin/$(BOARD)-blupdate-dfu.bin +endif +flash: build_flash +#alternate way of embedding: obj file +#ifeq ($(APP), dfu) +# $(info bootloader bin file to obj..) +# $(SILENT)$(OBJCOPY) --rename-section .data=.fwupdate -I binary -O elf32-littlearm bin/$(BOARD)-dfu-flash.bin $(OBJ)/flash_fwupdate.o +#endif program: openocd -f openocd/openocd.cfg -c "init" -c "halt" -c "flash write_bank 0 ./bin/project-flash.bin 0" -c "reset" -c "shutdown" diff --git a/firmware/apps/blupdate/Makefile b/firmware/apps/blupdate/Makefile new file mode 100644 index 0000000..4f1d377 --- /dev/null +++ b/firmware/apps/blupdate/Makefile @@ -0,0 +1,12 @@ + +C_FILES += $(C_LIBUSB_DFU) + +# Trace level used for compilation +# (can be overridden by adding TRACE_LEVEL=#number to the command-line) +# TRACE_LEVEL_DEBUG 5 +# TRACE_LEVEL_INFO 4 +# TRACE_LEVEL_WARNING 3 +# TRACE_LEVEL_ERROR 2 +# TRACE_LEVEL_FATAL 1 +# TRACE_LEVEL_NO_TRACE 0 +TRACE_LEVEL ?= 3 diff --git a/firmware/apps/blupdate/main.c b/firmware/apps/blupdate/main.c new file mode 100644 index 0000000..330d040 --- /dev/null +++ b/firmware/apps/blupdate/main.c @@ -0,0 +1,134 @@ +/* SIMtrace 2 firmware USB DFU bootloader + * + * (C) 2015-2017 by Harald Welte + * (C) 2018-2019 by sysmocom -s.f.m.c. GmbH, Author: Kevin Redon + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +#include "board.h" +#include "core_cm3.h" +#include "flashd.h" +#include "utils.h" +#include "usb/device/dfu/dfu.h" +#include "usb/common/dfu/usb_dfu.h" +#include "manifest.h" +#include "USBD_HAL.h" + +#include + +/* actual section content must be replaced with the padded bootloader by running objcopy! */ +const uint32_t bl_update_data[BOARD_DFU_BOOT_SIZE / sizeof(uint32_t)] __attribute__((section(".fwupdate"))) = { 0xFF }; + +unsigned int g_unique_id[4]; +/* remember if the watchdog has been configured in the main loop so we can kick it in the ISR */ +static bool watchdog_configured = false; + +extern uint32_t _end; +extern uint32_t _srelocate; +extern uint32_t _etext; + +void DFURT_SwitchToDFU(void) +{ +} +void USBDFU_Runtime_RequestHandler(const USBGenericRequest *request) +{ +} +int USBDFU_handle_dnload(uint8_t altif, unsigned int offset, uint8_t *data, unsigned int len) +{ + return 0; +} +int USBDFU_handle_upload(uint8_t altif, unsigned int offset, uint8_t *data, unsigned int req_len) +{ + return 0; +} +int USBDFU_OverrideEnterDFU(void) +{ + return 0; +} + +__attribute__((section(".ramfunc"), noinline)) static uint32_t flash_wait_ready() +{ + Efc *efc = EFC; + uint32_t dwStatus; + + do { + dwStatus = efc->EEFC_FSR; + } while ((dwStatus & EEFC_FSR_FRDY) != EEFC_FSR_FRDY); + return (dwStatus & (EEFC_FSR_FLOCKE | EEFC_FSR_FCMDE)); +} + +__attribute__((section(".ramfunc"), noinline)) static void flash_cmd(uint32_t dwCommand, uint32_t dwArgument) +{ + Efc *efc = EFC; + uint32_t dwStatus; + efc->EEFC_FCR = EEFC_FCR_FKEY(0x5A) | EEFC_FCR_FARG(dwArgument) | EEFC_FCR_FCMD(dwCommand); +} + +__attribute__((section(".ramfunc"), noinline, noreturn)) static void erase_first_app_sector() +{ + /* page 64 */ + uint32_t first_app_page = (BOARD_DFU_BOOT_SIZE / IFLASH_PAGE_SIZE); + uint32_t *first_app_address = (uint32_t *)(IFLASH_ADDR + first_app_page * IFLASH_PAGE_SIZE + 0); + +#if 1 + /* overwrite first app sector so we don't keep booting this */ + for (int i = 0; i < IFLASH_PAGE_SIZE / 4; i++) + first_app_address[i] = 0xffffffff; + + flash_cmd(EFC_FCMD_EWP, first_app_page); +#else + /* why does erasing the whole flash with a protected bootloader not work at all? */ + flash_cmd(EFC_FCMD_EA, 0); +#endif + flash_wait_ready(); + for (;;) + NVIC_SystemReset(); +} + +#define MAX_USB_ITER BOARD_MCK / 72 // This should be around a second +extern int main(void) +{ + uint8_t isUsbConnected = 0; + unsigned int i = 0; + uint32_t reset_cause = (RSTC->RSTC_SR & RSTC_SR_RSTTYP_Msk) >> RSTC_SR_RSTTYP_Pos; + + /* Enable watchdog for 2000ms, with no window */ + WDT_Enable(WDT, WDT_MR_WDRSTEN | WDT_MR_WDDBGHLT | WDT_MR_WDIDLEHLT | (WDT_GetPeriod(2000) << 16) | + WDT_GetPeriod(2000)); + watchdog_configured = true; + + EEFC_ReadUniqueID(g_unique_id); + + printf("\n\r\n\r"); + printf("bootloader updater %s for board %s\n\r" + "(C) 2010-2017 by Harald Welte, 2018-2019 by Kevin Redon\n\r", + manifest_revision, manifest_board); + + /* clear g_dfu on power-up reset */ + memset(g_dfu, 0, sizeof(*g_dfu)); + + TRACE_INFO("USB init...\n\r"); + /* Signal USB reset by disabling the pull-up on USB D+ for at least 10 ms */ + USBD_Disconnect(); + + /* Initialize the flash to be able to write it, using the IAP ROM code */ + FLASHD_Initialize(BOARD_MCK, 1); + + __disable_irq(); + FLASHD_Unlock(IFLASH_ADDR, IFLASH_ADDR + IFLASH_SIZE - 1, 0, 0); + FLASHD_Write(IFLASH_ADDR, bl_update_data, BOARD_DFU_BOOT_SIZE); + + erase_first_app_sector(); +} diff --git a/firmware/libboard/common/resources/sam3s4/dfu.ld b/firmware/libboard/common/resources/sam3s4/dfu.ld index db747fa..7d896c6 100644 --- a/firmware/libboard/common/resources/sam3s4/dfu.ld +++ b/firmware/libboard/common/resources/sam3s4/dfu.ld @@ -101,6 +101,14 @@ *(.ARM.exidx) } + .blupdate : + { + . = ALIGN(4); + _blupdate_start = .; + KEEP(*(.fwupdate .fwupdate.*)); + _blupdate_end = .; + } > rom + . = ALIGN(4); _etext = .; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I53dea57bba790a2ab3245d9483e0ff1c8d19d5e3 Gerrit-Change-Number: 26026 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:04:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:04:33 +0000 Subject: Change in simtrace2[master]: firmware: remove usb pullup that dates back to simtrace1 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26027 ) Change subject: firmware: remove usb pullup that dates back to simtrace1 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d Gerrit-Change-Number: 26027 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 12:04:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:04:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:04:39 +0000 Subject: Change in simtrace2[master]: firmware: increase reset delay before usb reattach In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26028 ) Change subject: firmware: increase reset delay before usb reattach ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36 Gerrit-Change-Number: 26028 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 12:04:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:06:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:06:00 +0000 Subject: Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25976 ) Change subject: heighbor_ident: add/del neighbor cells via ctrl interface ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Gerrit-Change-Number: 25976 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Nov 2021 12:06:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:06:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 12:06:15 +0000 Subject: Change in osmo-bsc[master]: control.adoc: comment out fixme note In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26052 ) Change subject: control.adoc: comment out fixme note ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 Gerrit-Change-Number: 26052 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 12:06:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:32:21 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 1 Nov 2021 12:32:21 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > > Well maybe then the question is why are you using rate_ctr and not stat_items here, it really confuses me. > > At least at first sight, I agree. The resulting metric computed by this new code base renders a single value which matches better a state_item than a rate_ctr. Any particular argument to go for rate_ctr, Neels? The decision to use a rate_ctr is based on discussion with the customer, and it also makes a lot of sence in practice. Logically, a stat_item is not actually a good choice. We can of course report the total time of all-allocated, and thus get for example the complete amount of seconds that all SDCCH channels were allocated since osmo-bsc started. But it's not interesting to get an arbitrary amount of time of all-allocated since forever; instead, it is important to qualify in which period of elapsed time this amount was accumulated. A rate_ctr is well suited since it also provides the "per time" aspect. All rate_ctr stats reflect a number-of-events-per-time. For all_allocated, it is the number of seconds that all channels were allocated per a given amount of time. For example, if the VTY shows all_allocated:sdcch of 10/min, it means all channels were allocated for 10 seconds of the last minute. For a stat item, getting this "per time" part is a complex problem. When reporting as a stat_item, we open a new dimension of options: The spec defines different reporting periods, suggesting at least the options of 5 minutes, 15 minutes, 30 minutes, 60 minutes. We could periodically clear the stat item based on user config. The customer requesting this feature already implements these reporting periods outside of osmo-bsc, based on stats received from osmo-bsc. So instead of introducing these reporting periods to osmo-bsc and choose some method of adding a per-time aspect to stat_item, it is best to just trigger a count for each second of all-allocated-channels. > simply a counter value changing over time. When I started on it, I thought it would take half an hour. When thinking about the exact implementation, the options and complexity unfolded... This patch is the result that ensures correct counts with minimal complexity. > So I'm not really following on why you need all this infrastructure sorry, I would appreciate if your criticism could be qualified as well as constructive. What do you mean by "all this"? What do you suggest instead? > this all looks super complicated for no reason (I'm able to see). Maybe someone else can also shed some light on it. It's straightforward: The aim is to report for how many seconds per given time period all channels of a type were allocated. To achieve that, we need to count free/allocated lchans. When a count reveals that all chans of type X are allocated, we set a flag to true. Based on that flag, a time counter increments. The flag-per-time counter is generalized API (time_cc). In order to periodically report that time counter to stats, an osmo_timer is involved. I am open to simplifications, if possible. There are some additional options to configure time_cc with different granularity, and to allow tweaking the counter precision vs response time. These options aren't strictly necessary. I think they make sense to keep time_cc generally useful. > So the question remains: Should the result be exposed as rate_ctr or as stat_item? We could do both, in fact. All the complex parts are already implemented and working correctly. Next to the rate_ctr, we can just add a stat_item to time_cc, and publish the time count as stat item. But then we need to define the time periods and exact meaning of the stat_item values. I encourage you to practically imagine the solution and you should see how the problem is not as trivial as it sounds at first. It is easy to add the stat_item, as soon as it is clear which value the stat_item should reflect. We already have a value implemented that counts all seconds where all channels were allocated since osmo-bsc started. But does it make sense to publish that as stat_item? Here are the various ideas I had before we decided for a rate_ctr as the simplest and most effective solution: " I am thinking about the allAvailable{TCH,SDCCH}AllocatedTime indicators: In 3GPP TS 52.402, there is a defined Granularity Period, which is configurable, and suggested to have at least the settings of 5, 15, 30, 60 minutes. The allAvailableXxxAllocatedTime indicators are defined as cumulative counter (CC), which I interpret as the number of seconds that all channels of the given kind were occupied. A "problem" is that the meaning of this cumulative value depends on the Granularity Period. For example, if the granularity period is 30 minutes, a cumulative value of 5 minutes for "all channels allocated" means that the cell was congested roughly 17% of the time. If the granularity period is only 5 minutes, then the exact same value means 100% congestion. So it appears to me that it is less confusing / more meaningful to report the value in % of time? Looking at details of how to implement this, it appears that we need to first introduce this concept of a Granularity Period to our statistics API. We have a stats reporter interval, which is usually a lot shorter than 5 minutes. Also this interval so far only affects the times at which an independently defined value will become reported. IIUC we so far don't have any values that are dependent on the reporting interval itself, where some cumulative counter value gets reset to zero whenever a reporting period has elapsed. Here are my ideas to implement such cumulative counters: variant 1: Internally, we clearly define a Granularity Period, as described in the spec. Let's say it is set to 5 minutes. This Granularity Period is implemented completely independently from the stats reporting period. At first, the cumulative counter is zero. For the next 5 minutes, we add up the times (in seconds) where all channels were occupied. When the five minutes have elapsed, we "push" the cumulative value to a stat item and reset the counter. So only one value will be published in a stat item every 5 minutes, and the value does not change while we are busy accumulating the counter value for the next 5 minutes. This seems most spec conforming. But this also seems kind of low resolution / slowly responsive. The 5 minute period would be independent from the stat reporting period, i.e. there would be N stat reporting periods where the stat does not change at all, e.g. for 5 minutes, and only then would we get a sum of the last 5 minutes, again staying fixed on the dashboard for the next 5 minutes. variant 2: We have two rate counters, one incrementing for each second where all channels were occupied (A), one incrementing for each second where at least one channel was still available (B). These get reported continuously and also degrade as rate counters do. Comparing one to the other, e.g. A / (A + B), gives a continuous indication of congestion rate. So the value will gradually rise and fall as the seconds pass, and we don't have to wait five minutes to see that congestion has occured. variant 2b: It should actually suffice to have only one rate counter incrementing for each second where all channels were occupied. Since rate counters implicitly count events per second, per minute, per hour, we can see that e.g. a rate of 60 per minute means that we have been continuously congested for the last minute. variant 3: We introduce a new kind of cumulative stat item which gets reset to zero whenever a stat reporting period has elapsed. We have two such stat items, one counting the seconds congested (A), one counting seconds not congested (B), and a meaningful statistic comes from comparing A to A+B. (the reporting period may then fluctuate without ill effects) variant 3b: Such new cumulative stat item as in 3 may always implicitly report percent compared to the elapsed reporting period. variant 3c: just use a normal stat item, and introduce some callback function that can be set up to clear the stat item to zero every time the stat report has been sent out. For variant 2 (rate counters), we don't need to introduce configuration of a granularity period, nor invent a new kind of stat item. But this is also the farthest away from how the performance indicator is defined in the spec. We could also implement mutiple variants. To me it would make sense to implement both variant 1 and 2b, to have a most spec conforming stat item that reports less frequently, as well as a "running congestion counter" as a rate counter that continuously shows a curve of congestion seen per time. " -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 01 Nov 2021 12:32:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 12:49:10 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 12:49:10 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: execute test cases for BS power control on TRX1 In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908 ) Change subject: BTS_Tests: execute test cases for BS power control on TRX1 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied3e38986690850f0323d4db072cf59b6975587e Gerrit-Change-Number: 25908 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 01 Nov 2021 12:49:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 13:35:22 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 13:35:22 +0000 Subject: Change in simtrace2[master]: firmware: remove usb pullup that dates back to simtrace1 In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26027 to look at the new patch set (#5). Change subject: firmware: remove usb pullup that dates back to simtrace1 ...................................................................... firmware: remove usb pullup that dates back to simtrace1 All the parts are DNP and never existed on the simtrace2 with sam3; the sam3 has internal pullups that are part of the usb peripheral. Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d --- M firmware/apps/dfu/main.c M firmware/libboard/octsimtest/include/board.h M firmware/libboard/sam3p256/include/board.h M firmware/libboard/simtrace/include/board.h M firmware/libcommon/source/usb.c 5 files changed, 0 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/27/26027/5 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d Gerrit-Change-Number: 26027 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 13:35:22 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 13:35:22 +0000 Subject: Change in simtrace2[master]: firmware: increase reset delay before usb reattach In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26028 to look at the new patch set (#5). Change subject: firmware: increase reset delay before usb reattach ...................................................................... firmware: increase reset delay before usb reattach The previous value was way too low and led to reenumeration issues when switching from app to bl because the hosts are fairly lenient and feature long delays until they accept disappearing devices as gone for good instead of ignoring a presuambly flaky usb cable or connection. Related: SYS5061 Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36 --- M firmware/apps/dfu/main.c M firmware/libcommon/source/usb.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/28/26028/5 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36 Gerrit-Change-Number: 26028 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 13:35:22 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 13:35:22 +0000 Subject: Change in simtrace2[master]: firmware: drop cref printing In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26029 to look at the new patch set (#5). Change subject: firmware: drop cref printing ...................................................................... firmware: drop cref printing No one reads this, no one wants to know this. Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198 --- M firmware/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/29/26029/5 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198 Gerrit-Change-Number: 26029 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 13:35:22 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 13:35:22 +0000 Subject: Change in simtrace2[master]: add our default clang-format file In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26030 to look at the new patch set (#3). Change subject: add our default clang-format file ...................................................................... add our default clang-format file Change-Id: I77aab70400bdbb46cbdd83e428e2a28ebf29b8dd --- A .clang-format 1 file changed, 563 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/30/26030/3 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77aab70400bdbb46cbdd83e428e2a28ebf29b8dd Gerrit-Change-Number: 26030 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 13:35:24 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 1 Nov 2021 13:35:24 +0000 Subject: Change in simtrace2[master]: jenkins: build bootloader updater References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26053 ) Change subject: jenkins: build bootloader updater ...................................................................... jenkins: build bootloader updater Change-Id: I8b2023921a67b0e8945d8f24e4c8076de3e12acf --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/53/26053/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 40015f7..8e81820 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -28,11 +28,11 @@ export LD_LIBRARY_PATH="$inst/lib" BUILDS="" -BUILDS+="simtrace/dfu simtrace/trace simtrace/cardem " -BUILDS+="qmod/dfu qmod/cardem " -BUILDS+="owhw/dfu owhw/cardem " +BUILDS+="simtrace/dfu simtrace/blupdate simtrace/trace simtrace/cardem " +BUILDS+="qmod/dfu qmod/blupdate qmod/cardem " +BUILDS+="owhw/dfu owhw/blupdate owhw/cardem " BUILDS+="octsimtest/cardem " -BUILDS+="ngff_cardem/dfu ngff_cardem/cardem ngff_cardem/trace " +BUILDS+="ngff_cardem/dfu ngff_cardem/blupdate ngff_cardem/cardem ngff_cardem/trace " cd $TOPDIR/firmware for build in $BUILDS; do -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I8b2023921a67b0e8945d8f24e4c8076de3e12acf Gerrit-Change-Number: 26053 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 13:38:50 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 13:38:50 +0000 Subject: Change in pysim[master]: pySim-shell: add method to probe for UICC In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26043/1/pySim-shell.py at 87 PS1, Line 87: card_is_uicc = probe_card(card, ['UICC']) > why does the 'UICC' get passed in a list? [?] It gets passed in a list because in theory the function can do more than one test in one go. Its also possible to ask ['UICC', 'SIM'] = Is this a UICC card with SIM functionality? Unfortunately I noticed that I did not need the possibility to ask for both at once. Regarding the card model I think we should try to drop it - we could keep the file as compatibility layer for pySim-prog and pySim-read, but in pySim-shell we should try to use the SimCardCommands class directly. Thats what we already do by using the private _scc object in the card object, which is not nice because _scc is ment to be a private property of the card. I think the only special functions of the card object we use is the verify_adm method, which may be different for each card. This is not much and can separated, so that the pySim-shell and the old code can use it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 13:38:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 14:14:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Nov 2021 14:14:09 +0000 Subject: Change in osmo-bts[master]: [overpower] Turn it on and off depending on DL RxQual In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25899 ) Change subject: [overpower] Turn it on and off depending on DL RxQual ...................................................................... Patch Set 7: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa812d4661ee17c4cd4a8c4ae4bd3e94c1a2e6cc Gerrit-Change-Number: 25899 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 01 Nov 2021 14:14:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 14:17:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 14:17:55 +0000 Subject: Change in simtrace2[master]: firmware: remove usb pullup that dates back to simtrace1 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26027 ) Change subject: firmware: remove usb pullup that dates back to simtrace1 ...................................................................... firmware: remove usb pullup that dates back to simtrace1 All the parts are DNP and never existed on the simtrace2 with sam3; the sam3 has internal pullups that are part of the usb peripheral. Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d --- M firmware/apps/dfu/main.c M firmware/libboard/octsimtest/include/board.h M firmware/libboard/sam3p256/include/board.h M firmware/libboard/simtrace/include/board.h M firmware/libcommon/source/usb.c 5 files changed, 0 insertions(+), 32 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c index d5a6fa6..4813881 100644 --- a/firmware/apps/dfu/main.c +++ b/firmware/apps/dfu/main.c @@ -342,16 +342,7 @@ TRACE_INFO("USB init...\n\r"); /* Signal USB reset by disabling the pull-up on USB D+ for at least 10 ms */ USBD_Disconnect(); -#ifdef PIN_USB_PULLUP - const Pin usb_dp_pullup = PIN_USB_PULLUP; - PIO_Configure(&usb_dp_pullup, 1); - PIO_Set(&usb_dp_pullup); -#endif mdelay(50); -#ifdef PIN_USB_PULLUP - PIO_Clear(&usb_dp_pullup); -#endif - USBDFU_Initialize(&dfu_descriptors); while (USBD_GetState() < USBD_STATE_CONFIGURED) { diff --git a/firmware/libboard/octsimtest/include/board.h b/firmware/libboard/octsimtest/include/board.h index 530f27b..697619c 100644 --- a/firmware/libboard/octsimtest/include/board.h +++ b/firmware/libboard/octsimtest/include/board.h @@ -87,11 +87,6 @@ /* SPI flash write protect pin (active low, pulled low) */ #define PIN_SPI_WP {PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} -/** Pin configuration to control USB pull-up on D+ - * @details the USB pull-up on D+ is enable by default on the board but can be disabled by setting PA16 high - */ -#define PIN_USB_PULLUP {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} - /** USB definitions */ /* OpenMoko SIMtrace 2 USB vendor ID */ #define BOARD_USB_VENDOR_ID USB_VENDOR_OPENMOKO diff --git a/firmware/libboard/sam3p256/include/board.h b/firmware/libboard/sam3p256/include/board.h index 58e8a24..06cfdce 100644 --- a/firmware/libboard/sam3p256/include/board.h +++ b/firmware/libboard/sam3p256/include/board.h @@ -135,11 +135,6 @@ #define PIN_SPI_WP {PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} #endif -/** Pin configuration to control USB pull-up on D+ - * @details the USB pull-up on D+ is enable by default on the board but can be disabled by setting PA16 high - */ -#define PIN_USB_PULLUP {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} - /** USB definitions */ /* OpenMoko SIMtrace 2 USB vendor ID */ #define BOARD_USB_VENDOR_ID USB_VENDOR_OPENMOKO diff --git a/firmware/libboard/simtrace/include/board.h b/firmware/libboard/simtrace/include/board.h index be18f64..6e4cd98 100644 --- a/firmware/libboard/simtrace/include/board.h +++ b/firmware/libboard/simtrace/include/board.h @@ -134,11 +134,6 @@ /* SPI flash write protect pin (active low, pulled low) */ #define PIN_SPI_WP {PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} -/** Pin configuration to control USB pull-up on D+ - * @details the USB pull-up on D+ is enable by default on the board but can be disabled by setting PA16 high - */ -#define PIN_USB_PULLUP {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} - /** USB definitions */ /* OpenMoko SIMtrace 2 USB vendor ID */ #define BOARD_USB_VENDOR_ID USB_VENDOR_OPENMOKO diff --git a/firmware/libcommon/source/usb.c b/firmware/libcommon/source/usb.c index e75646e..0868263 100644 --- a/firmware/libcommon/source/usb.c +++ b/firmware/libcommon/source/usb.c @@ -689,16 +689,8 @@ { unsigned int i; /* Signal USB reset by disabling the pull-up on USB D+ for at least 10 ms */ -#ifdef PIN_USB_PULLUP - const Pin usb_dp_pullup = PIN_USB_PULLUP; - PIO_Configure(&usb_dp_pullup, 1); - PIO_Set(&usb_dp_pullup); -#endif USBD_HAL_Suspend(); mdelay(20); -#ifdef PIN_USB_PULLUP - PIO_Clear(&usb_dp_pullup); -#endif USBD_HAL_Activate(); // Get std USB driver -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I04a703a2eba6ff1dc64692c089213389d0c1066d Gerrit-Change-Number: 26027 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 14:17:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 14:17:56 +0000 Subject: Change in simtrace2[master]: firmware: increase reset delay before usb reattach In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26028 ) Change subject: firmware: increase reset delay before usb reattach ...................................................................... firmware: increase reset delay before usb reattach The previous value was way too low and led to reenumeration issues when switching from app to bl because the hosts are fairly lenient and feature long delays until they accept disappearing devices as gone for good instead of ignoring a presuambly flaky usb cable or connection. Related: SYS5061 Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36 --- M firmware/apps/dfu/main.c M firmware/libcommon/source/usb.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c index 4813881..48ba879 100644 --- a/firmware/apps/dfu/main.c +++ b/firmware/apps/dfu/main.c @@ -342,7 +342,7 @@ TRACE_INFO("USB init...\n\r"); /* Signal USB reset by disabling the pull-up on USB D+ for at least 10 ms */ USBD_Disconnect(); - mdelay(50); + mdelay(500); USBDFU_Initialize(&dfu_descriptors); while (USBD_GetState() < USBD_STATE_CONFIGURED) { diff --git a/firmware/libcommon/source/usb.c b/firmware/libcommon/source/usb.c index 0868263..d86fc92 100644 --- a/firmware/libcommon/source/usb.c +++ b/firmware/libcommon/source/usb.c @@ -690,7 +690,7 @@ unsigned int i; /* Signal USB reset by disabling the pull-up on USB D+ for at least 10 ms */ USBD_HAL_Suspend(); - mdelay(20); + mdelay(500); USBD_HAL_Activate(); // Get std USB driver -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9b8c8bf794ad5b94fc7ea2a01d1ebf4e36862c36 Gerrit-Change-Number: 26028 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 14:17:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 14:17:56 +0000 Subject: Change in simtrace2[master]: firmware: drop cref printing In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26029 ) Change subject: firmware: drop cref printing ...................................................................... firmware: drop cref printing No one reads this, no one wants to know this. Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198 --- M firmware/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/Makefile b/firmware/Makefile index 810c7f3..f6e8316 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -205,7 +205,7 @@ endif ASFLAGS = -mcpu=cortex-m3 -mthumb -Wall -g $(OPTIMIZATION) $(INCLUDES) -D$(CHIP) -D__ASSEMBLY__ -LDFLAGS = -mcpu=cortex-m3 -mthumb -Wl,--cref -Wl,--check-sections -Wl,--gc-sections -Wl,--entry=ResetException -Wl,--unresolved-symbols=report-all -Wl,--warn-common -Wl,--no-undefined $(LIB) +LDFLAGS = -mcpu=cortex-m3 -mthumb -Wl,--check-sections -Wl,--gc-sections -Wl,--entry=ResetException -Wl,--unresolved-symbols=report-all -Wl,--warn-common -Wl,--no-undefined $(LIB) ifeq ("$(USE_CLANG)","0") LDFLAGS += -Wl,--warn-section-align -Wl,--print-memory-usage endif -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie2281e207164f82d8ee29bd596a5593c22aaf198 Gerrit-Change-Number: 26029 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 14:17:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 1 Nov 2021 14:17:57 +0000 Subject: Change in simtrace2[master]: add our default clang-format file In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26030 ) Change subject: add our default clang-format file ...................................................................... add our default clang-format file Change-Id: I77aab70400bdbb46cbdd83e428e2a28ebf29b8dd --- A .clang-format 1 file changed, 563 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/.clang-format b/.clang-format new file mode 100644 index 0000000..5d4791c --- /dev/null +++ b/.clang-format @@ -0,0 +1,563 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# clang-format configuration file. Intended for clang-format >= 4. +# +# For more information, see: +# +# Documentation/process/clang-format.rst +# https://clang.llvm.org/docs/ClangFormat.html +# https://clang.llvm.org/docs/ClangFormatStyleOptions.html +# +--- +AccessModifierOffset: -4 +AlignAfterOpenBracket: Align +AlignConsecutiveAssignments: false +AlignConsecutiveDeclarations: false +#AlignEscapedNewlines: Left # Unknown to clang-format-4.0 +AlignOperands: true +AlignTrailingComments: false +AllowAllParametersOfDeclarationOnNextLine: false +AllowShortBlocksOnASingleLine: false +AllowShortCaseLabelsOnASingleLine: false +AllowShortFunctionsOnASingleLine: None +AllowShortIfStatementsOnASingleLine: false +AllowShortLoopsOnASingleLine: false +AlwaysBreakAfterDefinitionReturnType: None +AlwaysBreakAfterReturnType: None +AlwaysBreakBeforeMultilineStrings: false +AlwaysBreakTemplateDeclarations: false +BinPackArguments: true +BinPackParameters: true +BraceWrapping: + AfterClass: false + AfterControlStatement: false + AfterEnum: false + AfterFunction: true + AfterNamespace: true + AfterObjCDeclaration: false + AfterStruct: false + AfterUnion: false + #AfterExternBlock: false # Unknown to clang-format-5.0 + BeforeCatch: false + BeforeElse: false + IndentBraces: false + #SplitEmptyFunction: true # Unknown to clang-format-4.0 + #SplitEmptyRecord: true # Unknown to clang-format-4.0 + #SplitEmptyNamespace: true # Unknown to clang-format-4.0 +BreakBeforeBinaryOperators: None +BreakBeforeBraces: Custom +#BreakBeforeInheritanceComma: false # Unknown to clang-format-4.0 +BreakBeforeTernaryOperators: false +BreakConstructorInitializersBeforeComma: false +#BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0 +BreakAfterJavaFieldAnnotations: false +BreakStringLiterals: false +ColumnLimit: 120 +CommentPragmas: '^ IWYU pragma:' +#CompactNamespaces: false # Unknown to clang-format-4.0 +ConstructorInitializerAllOnOneLineOrOnePerLine: false +ConstructorInitializerIndentWidth: 8 +ContinuationIndentWidth: 8 +Cpp11BracedListStyle: false +DerivePointerAlignment: false +DisableFormat: false +ExperimentalAutoDetectBinPacking: false +#FixNamespaceComments: false # Unknown to clang-format-4.0 + +# Taken from: +# git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' include/ \ +# | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$, - '\1'," \ +# | sort | uniq +ForEachMacros: + - 'apei_estatus_for_each_section' + - 'ata_for_each_dev' + - 'ata_for_each_link' + - '__ata_qc_for_each' + - 'ata_qc_for_each' + - 'ata_qc_for_each_raw' + - 'ata_qc_for_each_with_internal' + - 'ax25_for_each' + - 'ax25_uid_for_each' + - '__bio_for_each_bvec' + - 'bio_for_each_bvec' + - 'bio_for_each_bvec_all' + - 'bio_for_each_integrity_vec' + - '__bio_for_each_segment' + - 'bio_for_each_segment' + - 'bio_for_each_segment_all' + - 'bio_list_for_each' + - 'bip_for_each_vec' + - 'bitmap_for_each_clear_region' + - 'bitmap_for_each_set_region' + - 'blkg_for_each_descendant_post' + - 'blkg_for_each_descendant_pre' + - 'blk_queue_for_each_rl' + - 'bond_for_each_slave' + - 'bond_for_each_slave_rcu' + - 'bpf_for_each_spilled_reg' + - 'btree_for_each_safe128' + - 'btree_for_each_safe32' + - 'btree_for_each_safe64' + - 'btree_for_each_safel' + - 'card_for_each_dev' + - 'cgroup_taskset_for_each' + - 'cgroup_taskset_for_each_leader' + - 'cpufreq_for_each_entry' + - 'cpufreq_for_each_entry_idx' + - 'cpufreq_for_each_valid_entry' + - 'cpufreq_for_each_valid_entry_idx' + - 'css_for_each_child' + - 'css_for_each_descendant_post' + - 'css_for_each_descendant_pre' + - 'device_for_each_child_node' + - 'displayid_iter_for_each' + - 'dma_fence_chain_for_each' + - 'do_for_each_ftrace_op' + - 'drm_atomic_crtc_for_each_plane' + - 'drm_atomic_crtc_state_for_each_plane' + - 'drm_atomic_crtc_state_for_each_plane_state' + - 'drm_atomic_for_each_plane_damage' + - 'drm_client_for_each_connector_iter' + - 'drm_client_for_each_modeset' + - 'drm_connector_for_each_possible_encoder' + - 'drm_for_each_bridge_in_chain' + - 'drm_for_each_connector_iter' + - 'drm_for_each_crtc' + - 'drm_for_each_crtc_reverse' + - 'drm_for_each_encoder' + - 'drm_for_each_encoder_mask' + - 'drm_for_each_fb' + - 'drm_for_each_legacy_plane' + - 'drm_for_each_plane' + - 'drm_for_each_plane_mask' + - 'drm_for_each_privobj' + - 'drm_mm_for_each_hole' + - 'drm_mm_for_each_node' + - 'drm_mm_for_each_node_in_range' + - 'drm_mm_for_each_node_safe' + - 'flow_action_for_each' + - 'for_each_acpi_dev_match' + - 'for_each_active_dev_scope' + - 'for_each_active_drhd_unit' + - 'for_each_active_iommu' + - 'for_each_aggr_pgid' + - 'for_each_available_child_of_node' + - 'for_each_bio' + - 'for_each_board_func_rsrc' + - 'for_each_bvec' + - 'for_each_card_auxs' + - 'for_each_card_auxs_safe' + - 'for_each_card_components' + - 'for_each_card_dapms' + - 'for_each_card_pre_auxs' + - 'for_each_card_prelinks' + - 'for_each_card_rtds' + - 'for_each_card_rtds_safe' + - 'for_each_card_widgets' + - 'for_each_card_widgets_safe' + - 'for_each_cgroup_storage_type' + - 'for_each_child_of_node' + - 'for_each_clear_bit' + - 'for_each_clear_bit_from' + - 'for_each_cmsghdr' + - 'for_each_compatible_node' + - 'for_each_component_dais' + - 'for_each_component_dais_safe' + - 'for_each_comp_order' + - 'for_each_console' + - 'for_each_cpu' + - 'for_each_cpu_and' + - 'for_each_cpu_not' + - 'for_each_cpu_wrap' + - 'for_each_dapm_widgets' + - 'for_each_dev_addr' + - 'for_each_dev_scope' + - 'for_each_dma_cap_mask' + - 'for_each_dpcm_be' + - 'for_each_dpcm_be_rollback' + - 'for_each_dpcm_be_safe' + - 'for_each_dpcm_fe' + - 'for_each_drhd_unit' + - 'for_each_dss_dev' + - 'for_each_dtpm_table' + - 'for_each_efi_memory_desc' + - 'for_each_efi_memory_desc_in_map' + - 'for_each_element' + - 'for_each_element_extid' + - 'for_each_element_id' + - 'for_each_endpoint_of_node' + - 'for_each_evictable_lru' + - 'for_each_fib6_node_rt_rcu' + - 'for_each_fib6_walker_rt' + - 'for_each_free_mem_pfn_range_in_zone' + - 'for_each_free_mem_pfn_range_in_zone_from' + - 'for_each_free_mem_range' + - 'for_each_free_mem_range_reverse' + - 'for_each_func_rsrc' + - 'for_each_hstate' + - 'for_each_if' + - 'for_each_iommu' + - 'for_each_ip_tunnel_rcu' + - 'for_each_irq_nr' + - 'for_each_link_codecs' + - 'for_each_link_cpus' + - 'for_each_link_platforms' + - 'for_each_lru' + - 'for_each_matching_node' + - 'for_each_matching_node_and_match' + - 'for_each_member' + - 'for_each_memcg_cache_index' + - 'for_each_mem_pfn_range' + - '__for_each_mem_range' + - 'for_each_mem_range' + - '__for_each_mem_range_rev' + - 'for_each_mem_range_rev' + - 'for_each_mem_region' + - 'for_each_migratetype_order' + - 'for_each_msi_entry' + - 'for_each_msi_entry_safe' + - 'for_each_msi_vector' + - 'for_each_net' + - 'for_each_net_continue_reverse' + - 'for_each_netdev' + - 'for_each_netdev_continue' + - 'for_each_netdev_continue_rcu' + - 'for_each_netdev_continue_reverse' + - 'for_each_netdev_feature' + - 'for_each_netdev_in_bond_rcu' + - 'for_each_netdev_rcu' + - 'for_each_netdev_reverse' + - 'for_each_netdev_safe' + - 'for_each_net_rcu' + - 'for_each_new_connector_in_state' + - 'for_each_new_crtc_in_state' + - 'for_each_new_mst_mgr_in_state' + - 'for_each_new_plane_in_state' + - 'for_each_new_private_obj_in_state' + - 'for_each_node' + - 'for_each_node_by_name' + - 'for_each_node_by_type' + - 'for_each_node_mask' + - 'for_each_node_state' + - 'for_each_node_with_cpus' + - 'for_each_node_with_property' + - 'for_each_nonreserved_multicast_dest_pgid' + - 'for_each_of_allnodes' + - 'for_each_of_allnodes_from' + - 'for_each_of_cpu_node' + - 'for_each_of_pci_range' + - 'for_each_old_connector_in_state' + - 'for_each_old_crtc_in_state' + - 'for_each_old_mst_mgr_in_state' + - 'for_each_oldnew_connector_in_state' + - 'for_each_oldnew_crtc_in_state' + - 'for_each_oldnew_mst_mgr_in_state' + - 'for_each_oldnew_plane_in_state' + - 'for_each_oldnew_plane_in_state_reverse' + - 'for_each_oldnew_private_obj_in_state' + - 'for_each_old_plane_in_state' + - 'for_each_old_private_obj_in_state' + - 'for_each_online_cpu' + - 'for_each_online_node' + - 'for_each_online_pgdat' + - 'for_each_pci_bridge' + - 'for_each_pci_dev' + - 'for_each_pci_msi_entry' + - 'for_each_pcm_streams' + - 'for_each_physmem_range' + - 'for_each_populated_zone' + - 'for_each_possible_cpu' + - 'for_each_present_cpu' + - 'for_each_prime_number' + - 'for_each_prime_number_from' + - 'for_each_process' + - 'for_each_process_thread' + - 'for_each_prop_codec_conf' + - 'for_each_prop_dai_codec' + - 'for_each_prop_dai_cpu' + - 'for_each_prop_dlc_codecs' + - 'for_each_prop_dlc_cpus' + - 'for_each_prop_dlc_platforms' + - 'for_each_property_of_node' + - 'for_each_registered_fb' + - 'for_each_requested_gpio' + - 'for_each_requested_gpio_in_range' + - 'for_each_reserved_mem_range' + - 'for_each_reserved_mem_region' + - 'for_each_rtd_codec_dais' + - 'for_each_rtd_components' + - 'for_each_rtd_cpu_dais' + - 'for_each_rtd_dais' + - 'for_each_set_bit' + - 'for_each_set_bit_from' + - 'for_each_set_clump8' + - 'for_each_sg' + - 'for_each_sg_dma_page' + - 'for_each_sg_page' + - 'for_each_sgtable_dma_page' + - 'for_each_sgtable_dma_sg' + - 'for_each_sgtable_page' + - 'for_each_sgtable_sg' + - 'for_each_sibling_event' + - 'for_each_subelement' + - 'for_each_subelement_extid' + - 'for_each_subelement_id' + - '__for_each_thread' + - 'for_each_thread' + - 'for_each_unicast_dest_pgid' + - 'for_each_vsi' + - 'for_each_wakeup_source' + - 'for_each_zone' + - 'for_each_zone_zonelist' + - 'for_each_zone_zonelist_nodemask' + - 'fwnode_for_each_available_child_node' + - 'fwnode_for_each_child_node' + - 'fwnode_graph_for_each_endpoint' + - 'gadget_for_each_ep' + - 'genradix_for_each' + - 'genradix_for_each_from' + - 'hash_for_each' + - 'hash_for_each_possible' + - 'hash_for_each_possible_rcu' + - 'hash_for_each_possible_rcu_notrace' + - 'hash_for_each_possible_safe' + - 'hash_for_each_rcu' + - 'hash_for_each_safe' + - 'hctx_for_each_ctx' + - 'hlist_bl_for_each_entry' + - 'hlist_bl_for_each_entry_rcu' + - 'hlist_bl_for_each_entry_safe' + - 'hlist_for_each' + - 'hlist_for_each_entry' + - 'hlist_for_each_entry_continue' + - 'hlist_for_each_entry_continue_rcu' + - 'hlist_for_each_entry_continue_rcu_bh' + - 'hlist_for_each_entry_from' + - 'hlist_for_each_entry_from_rcu' + - 'hlist_for_each_entry_rcu' + - 'hlist_for_each_entry_rcu_bh' + - 'hlist_for_each_entry_rcu_notrace' + - 'hlist_for_each_entry_safe' + - 'hlist_for_each_entry_srcu' + - '__hlist_for_each_rcu' + - 'hlist_for_each_safe' + - 'hlist_nulls_for_each_entry' + - 'hlist_nulls_for_each_entry_from' + - 'hlist_nulls_for_each_entry_rcu' + - 'hlist_nulls_for_each_entry_safe' + - 'i3c_bus_for_each_i2cdev' + - 'i3c_bus_for_each_i3cdev' + - 'ide_host_for_each_port' + - 'ide_port_for_each_dev' + - 'ide_port_for_each_present_dev' + - 'idr_for_each_entry' + - 'idr_for_each_entry_continue' + - 'idr_for_each_entry_continue_ul' + - 'idr_for_each_entry_ul' + - 'in_dev_for_each_ifa_rcu' + - 'in_dev_for_each_ifa_rtnl' + - 'inet_bind_bucket_for_each' + - 'inet_lhash2_for_each_icsk_rcu' + - 'key_for_each' + - 'key_for_each_safe' + - 'klp_for_each_func' + - 'klp_for_each_func_safe' + - 'klp_for_each_func_static' + - 'klp_for_each_object' + - 'klp_for_each_object_safe' + - 'klp_for_each_object_static' + - 'kunit_suite_for_each_test_case' + - 'kvm_for_each_memslot' + - 'kvm_for_each_vcpu' + - 'list_for_each' + - 'list_for_each_codec' + - 'list_for_each_codec_safe' + - 'list_for_each_continue' + - 'list_for_each_entry' + - 'list_for_each_entry_continue' + - 'list_for_each_entry_continue_rcu' + - 'list_for_each_entry_continue_reverse' + - 'list_for_each_entry_from' + - 'list_for_each_entry_from_rcu' + - 'list_for_each_entry_from_reverse' + - 'list_for_each_entry_lockless' + - 'list_for_each_entry_rcu' + - 'list_for_each_entry_reverse' + - 'list_for_each_entry_safe' + - 'list_for_each_entry_safe_continue' + - 'list_for_each_entry_safe_from' + - 'list_for_each_entry_safe_reverse' + - 'list_for_each_entry_srcu' + - 'list_for_each_prev' + - 'list_for_each_prev_safe' + - 'list_for_each_safe' + - 'llist_for_each' + - 'llist_for_each_entry' + - 'llist_for_each_entry_safe' + - 'llist_for_each_safe' + - 'mci_for_each_dimm' + - 'media_device_for_each_entity' + - 'media_device_for_each_intf' + - 'media_device_for_each_link' + - 'media_device_for_each_pad' + - 'nanddev_io_for_each_page' + - 'netdev_for_each_lower_dev' + - 'netdev_for_each_lower_private' + - 'netdev_for_each_lower_private_rcu' + - 'netdev_for_each_mc_addr' + - 'netdev_for_each_uc_addr' + - 'netdev_for_each_upper_dev_rcu' + - 'netdev_hw_addr_list_for_each' + - 'nft_rule_for_each_expr' + - 'nla_for_each_attr' + - 'nla_for_each_nested' + - 'nlmsg_for_each_attr' + - 'nlmsg_for_each_msg' + - 'nr_neigh_for_each' + - 'nr_neigh_for_each_safe' + - 'nr_node_for_each' + - 'nr_node_for_each_safe' + - 'of_for_each_phandle' + - 'of_property_for_each_string' + - 'of_property_for_each_u32' + - 'pci_bus_for_each_resource' + - 'pcl_for_each_chunk' + - 'pcl_for_each_segment' + - 'pcm_for_each_format' + - 'ping_portaddr_for_each_entry' + - 'plist_for_each' + - 'plist_for_each_continue' + - 'plist_for_each_entry' + - 'plist_for_each_entry_continue' + - 'plist_for_each_entry_safe' + - 'plist_for_each_safe' + - 'pnp_for_each_card' + - 'pnp_for_each_dev' + - 'protocol_for_each_card' + - 'protocol_for_each_dev' + - 'queue_for_each_hw_ctx' + - 'radix_tree_for_each_slot' + - 'radix_tree_for_each_tagged' + - 'rb_for_each' + - 'rbtree_postorder_for_each_entry_safe' + - 'rdma_for_each_block' + - 'rdma_for_each_port' + - 'rdma_umem_for_each_dma_block' + - 'resource_list_for_each_entry' + - 'resource_list_for_each_entry_safe' + - 'rhl_for_each_entry_rcu' + - 'rhl_for_each_rcu' + - 'rht_for_each' + - 'rht_for_each_entry' + - 'rht_for_each_entry_from' + - 'rht_for_each_entry_rcu' + - 'rht_for_each_entry_rcu_from' + - 'rht_for_each_entry_safe' + - 'rht_for_each_from' + - 'rht_for_each_rcu' + - 'rht_for_each_rcu_from' + - '__rq_for_each_bio' + - 'rq_for_each_bvec' + - 'rq_for_each_segment' + - 'scsi_for_each_prot_sg' + - 'scsi_for_each_sg' + - 'sctp_for_each_hentry' + - 'sctp_skb_for_each' + - 'shdma_for_each_chan' + - '__shost_for_each_device' + - 'shost_for_each_device' + - 'sk_for_each' + - 'sk_for_each_bound' + - 'sk_for_each_entry_offset_rcu' + - 'sk_for_each_from' + - 'sk_for_each_rcu' + - 'sk_for_each_safe' + - 'sk_nulls_for_each' + - 'sk_nulls_for_each_from' + - 'sk_nulls_for_each_rcu' + - 'snd_array_for_each' + - 'snd_pcm_group_for_each_entry' + - 'snd_soc_dapm_widget_for_each_path' + - 'snd_soc_dapm_widget_for_each_path_safe' + - 'snd_soc_dapm_widget_for_each_sink_path' + - 'snd_soc_dapm_widget_for_each_source_path' + - 'tb_property_for_each' + - 'tcf_exts_for_each_action' + - 'udp_portaddr_for_each_entry' + - 'udp_portaddr_for_each_entry_rcu' + - 'usb_hub_for_each_child' + - 'v4l2_device_for_each_subdev' + - 'v4l2_m2m_for_each_dst_buf' + - 'v4l2_m2m_for_each_dst_buf_safe' + - 'v4l2_m2m_for_each_src_buf' + - 'v4l2_m2m_for_each_src_buf_safe' + - 'virtio_device_for_each_vq' + - 'while_for_each_ftrace_op' + - 'xa_for_each' + - 'xa_for_each_marked' + - 'xa_for_each_range' + - 'xa_for_each_start' + - 'xas_for_each' + - 'xas_for_each_conflict' + - 'xas_for_each_marked' + - 'xbc_array_for_each_value' + - 'xbc_for_each_key_value' + - 'xbc_node_for_each_array_value' + - 'xbc_node_for_each_child' + - 'xbc_node_for_each_key_value' + - 'zorro_for_each_dev' + - 'for_each_line' + - 'for_each_non_empty_line' + +#IncludeBlocks: Preserve # Unknown to clang-format-5.0 +IncludeCategories: + - Regex: '.*' + Priority: 1 +IncludeIsMainRegex: '(Test)?$' +IndentCaseLabels: false +#IndentPPDirectives: None # Unknown to clang-format-5.0 +IndentWidth: 8 +IndentWrappedFunctionNames: false +JavaScriptQuotes: Leave +JavaScriptWrapImports: true +KeepEmptyLinesAtTheStartOfBlocks: false +MacroBlockBegin: '' +MacroBlockEnd: '' +MaxEmptyLinesToKeep: 1 +NamespaceIndentation: None +#ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0 +ObjCBlockIndentWidth: 8 +ObjCSpaceAfterProperty: true +ObjCSpaceBeforeProtocolList: true + +# Taken from git's rules +#PenaltyBreakAssignment: 10 # Unknown to clang-format-4.0 +PenaltyBreakBeforeFirstCallParameter: 30 +PenaltyBreakComment: 10 +PenaltyBreakFirstLessLess: 0 +PenaltyBreakString: 10 +PenaltyExcessCharacter: 100 +PenaltyReturnTypeOnItsOwnLine: 60 + +PointerAlignment: Right +ReflowComments: false +SortIncludes: false +#SortUsingDeclarations: false # Unknown to clang-format-4.0 +SpaceAfterCStyleCast: false +SpaceAfterTemplateKeyword: true +SpaceBeforeAssignmentOperators: true +#SpaceBeforeCtorInitializerColon: true # Unknown to clang-format-5.0 +#SpaceBeforeInheritanceColon: true # Unknown to clang-format-5.0 +SpaceBeforeParens: ControlStatements +#SpaceBeforeRangeBasedForLoopColon: true # Unknown to clang-format-5.0 +SpaceInEmptyParentheses: false +SpacesBeforeTrailingComments: 1 +SpacesInAngles: false +SpacesInContainerLiterals: false +SpacesInCStyleCastParentheses: false +SpacesInParentheses: false +SpacesInSquareBrackets: false +Standard: Cpp03 +TabWidth: 8 +UseTab: Always +... -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77aab70400bdbb46cbdd83e428e2a28ebf29b8dd Gerrit-Change-Number: 26030 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 14:29:35 2021 From: gerrit-no-reply at lists.osmocom.org (roox) Date: Mon, 1 Nov 2021 14:29:35 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-b... References: Message-ID: roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26054 ) Change subject: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions ...................................................................... osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions * Remove deprecated configuration options: 'osmotrx timing-advance-loop' is deprecated, Timing Advance loop is now active by default 'osmotrx ms-power-loop <-127-127>' is deprecated, MS Power Control is now managed by BSC * Adjust 'ipa unit-id' (1801 -> 6969) to match the one from the example osmo-bsc.cfg * Set clock advance values to known working values: + 'osmotrx fn-advance' -> 20 + 'osmotrx rts-advance' -> 5 * Set 'nominal-tx-power' since the calypso-bts tranceiver does not support NOMTXPOWER Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9 --- M doc/examples/trx/osmo-bts-trx-calypso.cfg 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/54/26054/1 diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg b/doc/examples/trx/osmo-bts-trx-calypso.cfg index 3f2e778..d6cc43a 100644 --- a/doc/examples/trx/osmo-bts-trx-calypso.cfg +++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg @@ -1,6 +1,6 @@ ! ! OsmoBTS configuration example for CalypsoBTS -! http://osmocom.org/projects/baseband/wiki/CalypsoBTS +! https://osmocom.org/projects/baseband/wiki/CalypsoBTS !! ! log stderr @@ -24,14 +24,15 @@ instance 0 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 - osmotrx timing-advance-loop - osmotrx ms-power-loop -65 osmotrx legacy-setbsic + osmotrx fn-advance 20 + osmotrx rts-advance 5 bts 0 oml remote-ip 127.0.0.1 - ipa unit-id 1801 0 + ipa unit-id 6969 0 gsmtap-sapi pdtch gsmtap-sapi ccch band 900 trx 0 phy 0 instance 0 + nominal-tx-power 23 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9 Gerrit-Change-Number: 26054 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 16:13:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Nov 2021 16:13:19 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-b... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26054 ) Change subject: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9 Gerrit-Change-Number: 26054 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 01 Nov 2021 16:13:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 16:17:33 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 16:17:33 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... commands: do not check SW manually, use send_apdu_checksw() The transport layer provides a method send_apdu_checksw to send APDUs and to be sure the SW is the expected one. Given that, there is no need to verify the SW manually. The exception of send_apdu_checksw will catch the problem and also display the SW in a human readable form. Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Related: OS#5275 --- M pySim/commands.py 1 file changed, 6 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/26055/1 diff --git a/pySim/commands.py b/pySim/commands.py index 805fe61..dbe7e51 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -145,12 +145,9 @@ while chunk_offset < length: chunk_len = min(255, length-chunk_offset) pdu = self.cla_byte + 'b0%04x%02x' % (offset + chunk_offset, chunk_len) - data,sw = self._tp.send_apdu(pdu) - if sw == '9000': - total_data += data - chunk_offset += chunk_len - else: - raise ValueError('Failed to read (offset %d)' % (offset)) + data, sw = self._tp.send_apdu_checksw(pdu) + total_data += data + chunk_offset += chunk_len return total_data, sw def update_binary(self, ef, data:str, offset:int=0, verify:bool=False, conserve:bool=False): @@ -172,19 +169,14 @@ self.select_path(ef) total_data = '' - total_sw = "9000" chunk_offset = 0 while chunk_offset < data_length: chunk_len = min(255, data_length - chunk_offset) # chunk_offset is bytes, but data slicing is hex chars, so we need to multiply by 2 pdu = self.cla_byte + 'd6%04x%02x' % (offset + chunk_offset, chunk_len) + data[chunk_offset*2 : (chunk_offset+chunk_len)*2] - chunk_data, chunk_sw = self._tp.send_apdu(pdu) - if chunk_sw == total_sw: - total_data += chunk_data - chunk_offset += chunk_len - else: - total_sw = chunk_sw - raise ValueError('Failed to write chunk (chunk_offset %d, chunk_len %d)' % (chunk_offset, chunk_len)) + chunk_data, chunk_sw = self._tp.send_apdu_checksw(pdu) + total_data += chunk_data + chunk_offset += chunk_len if verify: self.verify_binary(ef, data, offset) return total_data, total_sw -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 16:37:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 16:37:36 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26055 to look at the new patch set (#2). Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... commands: do not check SW manually, use send_apdu_checksw() The transport layer provides a method send_apdu_checksw to send APDUs and to be sure the SW is the expected one. Given that, there is no need to verify the SW manually. The exception of send_apdu_checksw will catch the problem and also display the SW in a human readable form. Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Related: OS#5275 --- M pySim/commands.py 1 file changed, 7 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/26055/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 17:59:39 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Nov 2021 17:59:39 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: set band in f_TC_fh_params_set In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 ) Change subject: BSC_Tests: set band in f_TC_fh_params_set ...................................................................... BSC_Tests: set band in f_TC_fh_params_set The function f_TC_fh_params_set sets frequency hopping parameters. The ARFCN is also part of those parameters. However, this function does not set the respective band for the ARFCN that it configurs. This results in an invalid setting at the BSC that might cause unexpected behavior. Lets make sure we configure the band parameter correctly before setting the ARFCN Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647 Related: SYS#5369 --- M bsc/BSC_Tests.ttcn 1 file changed, 39 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index ee4dac2..ad8f666 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -8439,7 +8439,7 @@ /* Hopping parameters per a transceiver */ private type record FHParamsTrx { - GsmArfcn arfcn, + GsmBandArfcn arfcn, FHParamsTs ts[8] }; @@ -8448,8 +8448,10 @@ runs on test_CT return FHParamsTrx { var FHParamsTrx fhp; - /* Generate a random ARFCN, including ARFCN 0 */ - fhp.arfcn := f_rnd_int(3); + /* Generate a random ARFCN in the range of 0 - 3. This ARFCN will + * fall in the GSM900 band. */ + fhp.arfcn.arfcn := f_rnd_int(3); + fhp.arfcn.pcs := false; for (var integer tn := 0; tn < 8; tn := tn + 1) { if (not match(tn, tr_tn)) { @@ -8488,7 +8490,7 @@ tr_maio_hsn := tr_HsnMaio(fhp.ts[tn].hsn, fhp.ts[tn].maio); tr_cd := tr_ChanDescH1(cd.chan_nr, tr_maio_hsn); } else { - tr_cd := tr_ChanDescH0(cd.chan_nr, fhp.arfcn); + tr_cd := tr_ChanDescH0(cd.chan_nr, fhp.arfcn.arfcn); } if (not match(cd, tr_cd)) { @@ -8533,7 +8535,7 @@ } /* Take ARFCN of the TRX itself into account */ - full_mask[fhp.arfcn] := '1'B; + full_mask[fhp.arfcn.arfcn] := '1'B; /* Compose a bit-mask for the given timeslot number */ for (var integer i := 0; i < lengthof(fhp.ts[tn].ma); i := i + 1) { @@ -8570,15 +8572,41 @@ return { len := ma_mask_len, ma := ma_mask }; } +/* Configure the appropriate band for a given arfcn, exc */ +private function f_TC_set_band_by_arfcn(integer bts_nr, GsmBandArfcn arfcn) runs on test_CT +{ + var charstring band; + var GsmBandArfcn arfcn_ := valueof(ts_GsmBandArfcn(arfcn.arfcn, arfcn.pcs, false)); + + select (arfcn_) { + case (tr_GsmBandArfcn((259..293), false, ?)) { band := "GSM450"; } + case (tr_GsmBandArfcn((306..340), false, ?)) { band := "GSM480"; } + case (tr_GsmBandArfcn((438..511), false, ?)) { band := "GSM750"; } + case (tr_GsmBandArfcn((128..251), false, ?)) { band := "GSM850"; } + case (tr_GsmBandArfcn((0..124), false, ?)) { band := "GSM900"; } + case (tr_GsmBandArfcn((955..1023), false, ?)) { band := "GSM900"; } + case (tr_GsmBandArfcn((512..885), false, ?)) { band := "DCS1800"; } + case (tr_GsmBandArfcn((512..810), true, ?)) { band := "PCS1900"; } + case else { return; } + } + + f_vty_enter_cfg_bts(BSCVTY, bts_nr); + f_vty_transceive(BSCVTY, "band " & band); + f_vty_transceive(BSCVTY, "end"); +} + /* Configure the hopping parameters in accordance with the given record */ private function f_TC_fh_params_set(in FHParamsTrx fhp, uint8_t bts_nr := 0, uint8_t trx_nr := 0) runs on test_CT { + + f_TC_set_band_by_arfcn(bts_nr, fhp.arfcn); + /* Enter the configuration node for the given BTS/TRX numbers */ f_vty_enter_cfg_trx(BSCVTY, bts_nr, trx_nr); - f_vty_transceive(BSCVTY, "arfcn " & int2str(fhp.arfcn)); + f_vty_transceive(BSCVTY, "arfcn " & int2str(fhp.arfcn.arfcn)); for (var integer tn := 0; tn < lengthof(fhp.ts); tn := tn + 1) { f_vty_transceive(BSCVTY, "timeslot " & int2str(tn)); @@ -8609,12 +8637,15 @@ private function f_TC_fh_params_unset(in FHParamsTrx fhp, uint8_t bts_nr := 0, uint8_t trx_nr := 0, - GsmArfcn arfcn := 871) + GsmBandArfcn arfcn := {pcs := false, arfcn := 871}) runs on test_CT { + + f_TC_set_band_by_arfcn(bts_nr, arfcn); + /* Enter the configuration node for the given BTS/TRX numbers */ f_vty_enter_cfg_trx(BSCVTY, bts_nr, trx_nr); - f_vty_transceive(BSCVTY, "arfcn " & int2str(arfcn)); + f_vty_transceive(BSCVTY, "arfcn " & int2str(arfcn.arfcn)); for (var integer tn := 0; tn < lengthof(fhp.ts); tn := tn + 1) { f_vty_transceive(BSCVTY, "timeslot " & int2str(tn)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I447e4145c68c62b11b818e28f0081c19e9107647 Gerrit-Change-Number: 25828 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 18:29:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Nov 2021 18:29:59 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py at 148 PS2, Line 148: data, sw = self._tp.send_apdu_checksw(pdu) I would wrap this block into additional try/catch: try: data, sw = self._tp.send_apdu_checksw(pdu) total_data += data chunk_offset += chunk_len except Exception as e: raise ValueError('Failed to read (offset %d)' % (offset)) from e Note 'from e' in the last line. This way, if send_apdu_checksw() raises an exception, it would get equipped with the contextual information. See https://docs.python.org/3/tutorial/errors.html#exception-chaining. https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py at 177 PS2, Line 177: chunk_data, chunk_sw = self._tp.send_apdu_checksw(pdu) Same here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 18:29:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 1 23:28:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Nov 2021 23:28:24 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26056 ) Change subject: doc/manuals: add documentation for interference reporting ...................................................................... doc/manuals: add documentation for interference reporting Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Related: SYS#5313 --- A doc/manuals/chapters/interf_meas.adoc M doc/manuals/osmobsc-usermanual.adoc 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/56/26056/1 diff --git a/doc/manuals/chapters/interf_meas.adoc b/doc/manuals/chapters/interf_meas.adoc new file mode 100644 index 0000000..b3b2e42 --- /dev/null +++ b/doc/manuals/chapters/interf_meas.adoc @@ -0,0 +1,44 @@ +== Interference reporting + +According to 3GPP 48.058, section 6.1, the BTS shall periodically report the +interference levels on *idle* channels using the "Radio resource indication" +procedure. This is done by sending the `RF RESource INDication` message, +which is specified in sections 8.6.1 and 9.3.21. + +// TODO: BSC -> MSC reporting (3GPP TS 48.008, section 3.1.3) + +=== Interference reporting parameters + +The interference band is calculated by the BTS based on the `Interference level +Boundaries` and the `Averaging period`. These parameters are sent by the BSC +over the A-bis/OML, and can be configured via the VTY interface. + +Below are the default values for them: + +---- +network + bts 0 + interference-meas avg-period 6 <1> + interference-meas level-bounds -85 <2> -91 -97 -103 -109 -115 <3> +---- +<1> Averaging period (`Intave`) in SACCH multiframe periods (480ms). +<2> Interference level boundary `0` (in dBm). +<3> Interference level boundary `X5` (in dBm). + +The `Intave` parameter defines the averaging period, so with the default value +of 6 SACCH multiframe periods the BTS is instructed to report interference +levels approximately every 3 seconds. Before reporting to the BSC, the BTS +maps each interference level (in dBm) to one of the 5 bands using the given +boundaries. + +---- +-85 dBm -91 dBm -97 dBm -103 dBm -109 dBm -115 dBm + | | | | | | + +----------+----------+----------+----------+----------+ + | band 1 | band 2 | band 3 | band 4 | band 5 | + +----------+----------+----------+----------+----------+ +---- + +// FIXME: what happens if a value is below -115 dBm or above -85 dBm +// TODO: document PDCH interference reporting +// TODO: dynamic timeslot handling diff --git a/doc/manuals/osmobsc-usermanual.adoc b/doc/manuals/osmobsc-usermanual.adoc index 120fe2c..0afa015 100644 --- a/doc/manuals/osmobsc-usermanual.adoc +++ b/doc/manuals/osmobsc-usermanual.adoc @@ -26,6 +26,8 @@ include::{srcdir}/chapters/power_control.adoc[] +include::{srcdir}/chapters/interf_meas.adoc[] + include::{srcdir}/chapters/handover.adoc[] include::{srcdir}/chapters/smscb.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 00:33:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:33:30 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61808768d0ada_4be72abbd99885e01830c8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 67s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 67s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 67s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 67s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 67s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 67s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 67s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 67s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 67s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 67s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 67s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 67s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 67s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 67s] make -C firmware BOARD=simtrace APP=blupdate [ 67s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 67s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 67s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 67s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 67s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 67s] dh_auto_build: make -j1 returned exit code 2 [ 67s] make: *** [debian/rules:16: build] Error 2 [ 67s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 67s] ### VM INTERACTION START ### [ 70s] [ 60.656045] sysrq: Power Off [ 70s] [ 60.656821] reboot: Power down [ 70s] ### VM INTERACTION END ### [ 70s] [ 70s] obs-arm-11 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:33:21 UTC 2021. [ 70s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:34:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:34:21 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <618087a1752a0_4be72abbd99885e018339e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 112s] 628 184 0 812 32c obj/simtrace/dfu_led.o [ 112s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 112s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 112s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 112s] 229 0 0 229 e5 obj/simtrace/dfu_board_simtrace.o [ 112s] 941 0 1 942 3ae obj/simtrace/dfu_main.o [ 112s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 112s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 112s] 1029 24 532 1585 631 obj/simtrace/dfu_dfu_driver.o [ 112s] 13144 0 11440 24584 6008 bin/simtrace-dfu-dfu.elf [ 112s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 112s] make -C firmware BOARD=simtrace APP=blupdate [ 112s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 112s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 112s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 112s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 112s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 112s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 112s] dh_auto_build: make -j1 returned exit code 2 [ 112s] debian/rules:16: recipe for target 'build' failed [ 112s] make: *** [build] Error 2 [ 112s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 112s] ### VM INTERACTION START ### [ 115s] [ 102.059678] sysrq: Power Off [ 115s] [ 102.060705] reboot: Power down [ 115s] ### VM INTERACTION END ### [ 115s] [ 115s] obs-arm-8 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:34:12 UTC 2021. [ 115s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:35:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:35:12 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_11/aarch64 In-Reply-To: References: Message-ID: <618087dee3cb6_4be72abbd99885e0183423@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 134s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 134s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 134s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 134s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 134s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 134s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 134s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 134s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 134s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 134s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 134s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 134s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 134s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 134s] make -C firmware BOARD=simtrace APP=blupdate [ 134s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 134s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 134s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 134s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 134s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 134s] dh_auto_build: error: make -j1 returned exit code 2 [ 134s] make: *** [debian/rules:16: build] Error 25 [ 134s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 134s] ### VM INTERACTION START ### [ 138s] [ 119.004300] sysrq: Power Off [ 138s] [ 119.005301] reboot: Power down [ 138s] ### VM INTERACTION END ### [ 138s] [ 138s] obs-arm-9 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:35:11 UTC 2021. [ 138s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:36:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:36:03 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <618087f9a7bb7_4be72abbd99885e01835f3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 160s] intention of the Shared Library Policy is to allow parallel installation of [ 160s] multiple versions of the same shared library, hard dependencies likely make [ 160s] that impossible. Please remove this dependency and instead move it to the [ 160s] runtime uses of your library. [ 160s] [ 160s] osmo-iuh.aarch64: W: suse-missing-rclink osmo-hnbgw [ 160s] The package contains an init script or systemd service file but lacks the [ 160s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 160s] [ 160s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 160s] libosmo-rua0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 160s] This package contains a library and provides no %post scriptlet containing a [ 160s] call to ldconfig. [ 160s] [ 160s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 160s] libosmo-rua0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 160s] This package contains a library and provides no %postun scriptlet containing a [ 160s] call to ldconfig. [ 160s] [ 160s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 160s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 160s] [ 160s] ### VM INTERACTION START ### [ 163s] [ 155.817206] sysrq: SysRq : Power Off [ 163s] [ 155.817791] reboot: Power down [ 163s] ### VM INTERACTION END ### [ 163s] [ 163s] obs-arm-11 failed "build osmo-iuh.spec" at Tue Nov 2 00:36:00 UTC 2021. [ 163s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:38:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:38:53 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_11/i586 In-Reply-To: References: Message-ID: <618088adb860a_4be72abbd99885e01839fe@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 217s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 217s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 217s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 217s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 217s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 217s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 217s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 217s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 217s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 217s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 217s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 217s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 217s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 217s] make -C firmware BOARD=simtrace APP=blupdate [ 217s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 217s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 217s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 217s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 217s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 217s] dh_auto_build: error: make -j1 returned exit code 2 [ 217s] make: *** [debian/rules:16: build] Error 25 [ 217s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 217s] ### VM INTERACTION START ### [ 220s] [ 190.064802] sysrq: Power Off [ 220s] [ 190.069963] reboot: Power down [ 220s] ### VM INTERACTION END ### [ 220s] [ 220s] hci-cnode1-e5 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:38:37 UTC 2021. [ 220s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:40:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:40:01 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <618088ec34243_4be72abbd99885e018425c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 101s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 101s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 101s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 101s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 101s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 101s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 101s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 101s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 101s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 101s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 101s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 101s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 101s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 101s] make -C firmware BOARD=simtrace APP=blupdate [ 101s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 101s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 101s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 101s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 101s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 101s] dh_auto_build: make -j1 returned exit code 2 [ 101s] make: *** [debian/rules:16: build] Error 2 [ 101s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 101s] ### VM INTERACTION START ### [ 104s] [ 97.115091] sysrq: Power Off [ 104s] [ 97.125214] reboot: Power down [ 104s] ### VM INTERACTION END ### [ 104s] [ 104s] goat09 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:39:54 UTC 2021. [ 104s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:40:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:40:18 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <6180890b51711_4be72abbd99885e01844cf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 107s] 340 0 0 340 154 obj/simtrace/dfu_board_lowlevel.o [ 107s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 107s] 660 184 0 844 34c obj/simtrace/dfu_led.o [ 107s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 107s] 1270 0 1033 2303 8ff obj/simtrace/dfu_uart_console.o [ 107s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 107s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 107s] 925 0 1 926 39e obj/simtrace/dfu_main.o [ 107s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 107s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 107s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 107s] 13188 0 11440 24628 6034 bin/simtrace-dfu-dfu.elf [ 107s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 107s] make -C firmware BOARD=simtrace APP=blupdate [ 107s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 107s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 107s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 107s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 107s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 107s] dh_auto_build: error: make -j1 returned exit code 2 [ 107s] make: *** [debian/rules:16: build] Error 25 [ 107s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 107s] ### VM INTERACTION START ### [ 110s] [ 98.244658] sysrq: Power Off [ 110s] [ 98.249196] reboot: Power down [ 110s] ### VM INTERACTION END ### [ 110s] [ 110s] sheep85 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:40:07 UTC 2021. [ 110s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:40:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:40:52 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618089253f10e_4be72abbd99885e01845e7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Unstable/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 145s] 336 0 4 340 154 obj/simtrace/dfu_board_lowlevel.o [ 145s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 145s] 656 184 0 840 348 obj/simtrace/dfu_led.o [ 145s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 145s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 145s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 145s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 145s] 909 0 20 929 3a1 obj/simtrace/dfu_main.o [ 145s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 145s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 145s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 145s] 13176 0 11444 24620 602c bin/simtrace-dfu-dfu.elf [ 145s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 145s] make -C firmware BOARD=simtrace APP=blupdate [ 145s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 145s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 145s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 145s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 145s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 145s] dh_auto_build: error: make -j1 returned exit code 2 [ 145s] make: *** [debian/rules:16: build] Error 25 [ 145s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 145s] ### VM INTERACTION START ### [ 148s] [ 109.554710] sysrq: Power Off [ 148s] [ 109.562526] reboot: Power down [ 148s] ### VM INTERACTION END ### [ 148s] [ 148s] goat17 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:40:41 UTC 2021. [ 148s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:42:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:42:51 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586 In-Reply-To: References: Message-ID: <618089a188464_4be72abbd99885e018496c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 138s] 628 184 0 812 32c obj/simtrace/dfu_led.o [ 138s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 138s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 138s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 138s] 229 0 0 229 e5 obj/simtrace/dfu_board_simtrace.o [ 138s] 941 0 1 942 3ae obj/simtrace/dfu_main.o [ 138s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 138s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 138s] 1029 24 532 1585 631 obj/simtrace/dfu_dfu_driver.o [ 138s] 13144 0 11440 24584 6008 bin/simtrace-dfu-dfu.elf [ 138s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 138s] make -C firmware BOARD=simtrace APP=blupdate [ 138s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 138s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 138s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 138s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 138s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 138s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 138s] dh_auto_build: make -j1 returned exit code 2 [ 138s] debian/rules:16: recipe for target 'build' failed [ 138s] make: *** [build] Error 2 [ 138s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 138s] ### VM INTERACTION START ### [ 141s] [ 114.910606] sysrq: Power Off [ 141s] [ 114.936143] reboot: Power down [ 141s] ### VM INTERACTION END ### [ 141s] [ 141s] lamb18 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:42:44 UTC 2021. [ 141s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:43:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:43:25 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <618089bc4e8a6_4be72abbd99885e0185458@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 77s] 628 184 0 812 32c obj/simtrace/dfu_led.o [ 77s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 77s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 77s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 77s] 229 0 0 229 e5 obj/simtrace/dfu_board_simtrace.o [ 77s] 941 0 1 942 3ae obj/simtrace/dfu_main.o [ 77s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 77s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 77s] 1029 24 532 1585 631 obj/simtrace/dfu_dfu_driver.o [ 77s] 13144 0 11440 24584 6008 bin/simtrace-dfu-dfu.elf [ 77s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 77s] make -C firmware BOARD=simtrace APP=blupdate [ 77s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 77s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 77s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 77s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 77s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 77s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 77s] dh_auto_build: make -j1 returned exit code 2 [ 77s] debian/rules:16: recipe for target 'build' failed [ 77s] make: *** [build] Error 2 [ 77s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 77s] ### VM INTERACTION START ### [ 80s] [ 69.336347] sysrq: Power Off [ 80s] [ 69.338986] reboot: Power down [ 80s] ### VM INTERACTION END ### [ 80s] [ 80s] old-cirrus2 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:43:22 UTC 2021. [ 80s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:45:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:45:41 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <61808a523031a_4be72abbd99885e018619d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 258s] 340 0 0 340 154 obj/simtrace/dfu_board_lowlevel.o [ 258s] 1270 0 1033 2303 8ff obj/simtrace/dfu_uart_console.o [ 258s] 660 184 0 844 34c obj/simtrace/dfu_led.o [ 258s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 258s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 258s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 258s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 258s] 925 0 1 926 39e obj/simtrace/dfu_main.o [ 258s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 258s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 258s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 258s] 13188 0 11440 24628 6034 bin/simtrace-dfu-dfu.elf [ 258s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 258s] make -C firmware BOARD=simtrace APP=blupdate [ 258s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 258s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 258s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 258s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 258s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 258s] dh_auto_build: error: make -j1 returned exit code 2 [ 258s] make: *** [debian/rules:16: build] Error 25 [ 258s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 258s] ### VM INTERACTION START ### [ 261s] [ 234.372393] sysrq: Power Off [ 261s] [ 234.448899] reboot: Power down [ 261s] ### VM INTERACTION END ### [ 262s] [ 262s] old-atreju2 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:45:29 UTC 2021. [ 262s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:45:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:45:58 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61808a5358911_4be72abbd99885e0186214@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 211s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 211s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 211s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 211s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 211s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 211s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 211s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 211s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 211s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 211s] 13112 0 11440 24552 5fe8 bin/simtrace-dfu-dfu.elf [ 211s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 211s] make -C firmware BOARD=simtrace APP=blupdate [ 211s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 211s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 211s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 211s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 211s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 211s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 211s] dh_auto_build: make -j1 returned exit code 2 [ 211s] debian/rules:16: recipe for target 'build' failed [ 211s] make: *** [build] Error 2 [ 211s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 211s] ### VM INTERACTION START ### [ 214s] [ 195.126496] sysrq: Power Off [ 214s] [ 195.151405] reboot: Power down [ 214s] ### VM INTERACTION END ### [ 214s] [ 214s] lamb56 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:45:45 UTC 2021. [ 214s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:46:15 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:46:15 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61808a71eaa47_4be72abbd99885e018633@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 292s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 292s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 292s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 292s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 292s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 292s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 292s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 292s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 292s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 292s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 292s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 292s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 292s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 292s] make -C firmware BOARD=simtrace APP=blupdate [ 292s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 292s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 292s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 292s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 292s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 292s] dh_auto_build: make -j1 returned exit code 2 [ 292s] make: *** [debian/rules:16: build] Error 2 [ 292s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 292s] ### VM INTERACTION START ### [ 295s] [ 274.644221] sysrq: Power Off [ 295s] [ 274.693089] reboot: Power down [ 295s] ### VM INTERACTION END ### [ 295s] [ 296s] lamb02 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:46:02 UTC 2021. [ 296s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:50:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:50:13 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_11/x86_64 In-Reply-To: References: Message-ID: <61808b61da218_4be72abbd99885e01877bc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 465s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 465s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 465s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 465s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 465s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 465s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 465s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 465s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 465s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 465s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 465s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 465s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 465s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 465s] make -C firmware BOARD=simtrace APP=blupdate [ 465s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 465s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 465s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 465s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 465s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 465s] dh_auto_build: error: make -j1 returned exit code 2 [ 465s] make: *** [debian/rules:16: build] Error 25 [ 465s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 465s] ### VM INTERACTION START ### [ 468s] [ 409.750570] sysrq: Power Off [ 468s] [ 409.757932] reboot: Power down [ 468s] ### VM INTERACTION END ### [ 468s] [ 468s] old-atreju5 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:50:00 UTC 2021. [ 468s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:52:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:52:46 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61808bf9a8260_4be72abbd99885e0188874@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 225s] intention of the Shared Library Policy is to allow parallel installation of [ 225s] multiple versions of the same shared library, hard dependencies likely make [ 225s] that impossible. Please remove this dependency and instead move it to the [ 225s] runtime uses of your library. [ 225s] [ 225s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 225s] The package contains an init script or systemd service file but lacks the [ 225s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 225s] [ 225s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 225s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 225s] This package contains a library and provides no %post scriptlet containing a [ 225s] call to ldconfig. [ 225s] [ 225s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 225s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 225s] This package contains a library and provides no %postun scriptlet containing a [ 225s] call to ldconfig. [ 225s] [ 225s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 225s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 225s] [ 225s] ### VM INTERACTION START ### [ 228s] [ 217.666094] sysrq: SysRq : Power Off [ 228s] [ 217.684835] reboot: Power down [ 228s] ### VM INTERACTION END ### [ 228s] [ 228s] goat01 failed "build osmo-iuh.spec" at Tue Nov 2 00:52:34 UTC 2021. [ 228s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:54:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:54:28 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_10/i586 In-Reply-To: References: Message-ID: <61808c5220b01_4be72abbd99885e0189245@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 242s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 242s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 242s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 242s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 242s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 242s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 242s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 242s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 242s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 242s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 242s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 242s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 242s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 242s] make -C firmware BOARD=simtrace APP=blupdate [ 242s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 242s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 242s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 242s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 242s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 242s] dh_auto_build: make -j1 returned exit code 2 [ 242s] make: *** [debian/rules:16: build] Error 2 [ 242s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 242s] ### VM INTERACTION START ### [ 245s] [ 193.647053] sysrq: Power Off [ 245s] [ 193.667250] reboot: Power down [ 246s] ### VM INTERACTION END ### [ 246s] [ 246s] cloud114 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:54:25 UTC 2021. [ 246s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:54:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:54:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61808c707846b_4be72abbd99885e018935d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 191s] intention of the Shared Library Policy is to allow parallel installation of [ 191s] multiple versions of the same shared library, hard dependencies likely make [ 191s] that impossible. Please remove this dependency and instead move it to the [ 191s] runtime uses of your library. [ 191s] [ 191s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 191s] The package contains an init script or systemd service file but lacks the [ 191s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 191s] [ 191s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 191s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 191s] This package contains a library and provides no %post scriptlet containing a [ 191s] call to ldconfig. [ 191s] [ 191s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 191s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 191s] This package contains a library and provides no %postun scriptlet containing a [ 191s] call to ldconfig. [ 191s] [ 191s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 191s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 191s] [ 191s] ### VM INTERACTION START ### [ 194s] [ 183.910136] sysrq: Power Off [ 194s] [ 183.915301] reboot: Power down [ 194s] ### VM INTERACTION END ### [ 194s] [ 194s] lamb16 failed "build osmo-iuh.spec" at Tue Nov 2 00:54:34 UTC 2021. [ 194s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:57:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:57:18 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <61808d0664d76_4be72abbd99885e01897a9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 182s] 340 0 0 340 154 obj/simtrace/dfu_board_lowlevel.o [ 182s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 182s] 660 184 0 844 34c obj/simtrace/dfu_led.o [ 182s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 182s] 1270 0 1033 2303 8ff obj/simtrace/dfu_uart_console.o [ 182s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 182s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 182s] 925 0 1 926 39e obj/simtrace/dfu_main.o [ 182s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 182s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 182s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 182s] 3700 0 1368 5068 13cc bin/simtrace-dfu-dfu.elf [ 182s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 182s] make -C firmware BOARD=simtrace APP=blupdate [ 182s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 182s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 182s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 182s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 182s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 182s] dh_auto_build: error: make -j1 returned exit code 2 [ 182s] make: *** [debian/rules:16: build] Error 25 [ 182s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 182s] ### VM INTERACTION START ### [ 185s] [ 173.873284] sysrq: Power Off [ 185s] [ 173.880144] reboot: Power down [ 185s] ### VM INTERACTION END ### [ 185s] [ 185s] goat01 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:57:06 UTC 2021. [ 185s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:58:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:58:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61808d264c00d_4be72abbd99885e01900a4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 231s] # we create a symlink at ./srcfile.adoc pointing at [ 231s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 231s] # is like basename from coreutils, and . is WD. [ 231s] if ! [ -f test-usermanual.adoc ]; then \ [ 231s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 231s] fi [ 231s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 231s] # in ... [ 231s] TEXINPUTS=".." \ [ 231s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 232s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 232s] a2x: resource files: [] [ 232s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 232s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 232s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 232s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 232s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 232s] make[1]: *** [Makefile:363: all] Error 2 [ 232s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 232s] dh_auto_build: error: make -j1 returned exit code 2 [ 232s] make: *** [debian/rules:5: binary] Error 25 [ 232s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 232s] ### VM INTERACTION START ### [ 233s] Powering off. [ 233s] [ 221.344837] reboot: Power down [ 233s] ### VM INTERACTION END ### [ 233s] [ 233s] goat17 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111020026.dsc" at Tue Nov 2 00:58:03 UTC 2021. [ 233s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 00:58:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 00:58:26 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61808d3fea212_4be72abbd99885e0190114@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 193s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 193s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 193s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 193s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 193s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 193s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 193s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 193s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 193s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 193s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 193s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 193s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 193s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 193s] make -C firmware BOARD=simtrace APP=blupdate [ 193s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 193s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 193s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 193s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 193s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 193s] dh_auto_build: error: make -j1 returned exit code 2 [ 193s] make: *** [debian/rules:16: build] Error 25 [ 193s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 193s] ### VM INTERACTION START ### [ 196s] [ 165.543485] sysrq: Power Off [ 196s] [ 165.571940] reboot: Power down [ 196s] ### VM INTERACTION END ### [ 196s] [ 196s] goat01 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 00:58:21 UTC 2021. [ 196s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 01:03:15 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 01:03:15 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61808e6d2a67b_4be72abbd99885e0191611@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Raspbian_10/armv7l Package network:osmocom:nightly/simtrace2 failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 228s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 228s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 228s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 228s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 228s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 228s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 228s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 228s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 228s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 228s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 228s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 228s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 228s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 228s] make -C firmware BOARD=simtrace APP=blupdate [ 228s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 228s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 228s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 228s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 228s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 228s] dh_auto_build: make -j1 returned exit code 2 [ 228s] make: *** [debian/rules:16: build] Error 2 [ 228s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 228s] ### VM INTERACTION START ### [ 232s] [ 194.516188] sysrq: SysRq : Power Off [ 232s] [ 194.519290] reboot: Power down [ 233s] ### VM INTERACTION END ### [ 233s] [ 233s] obs-arm-6 failed "build simtrace2_0.7.0.163.23eb.202111020026.dsc" at Tue Nov 2 01:03:00 UTC 2021. [ 233s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 01:21:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 01:21:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <618092882305c_4be72abbd99885e019761a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 1031s] intention of the Shared Library Policy is to allow parallel installation of [ 1031s] multiple versions of the same shared library, hard dependencies likely make [ 1031s] that impossible. Please remove this dependency and instead move it to the [ 1031s] runtime uses of your library. [ 1031s] [ 1031s] osmo-iuh.armv7hl: W: suse-missing-rclink osmo-hnbgw [ 1031s] The package contains an init script or systemd service file but lacks the [ 1031s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 1031s] [ 1031s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 1031s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 1031s] This package contains a library and provides no %post scriptlet containing a [ 1031s] call to ldconfig. [ 1031s] [ 1031s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 1031s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 1031s] This package contains a library and provides no %postun scriptlet containing a [ 1031s] call to ldconfig. [ 1031s] [ 1031s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 1031s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 1031s] [ 1031s] ### VM INTERACTION START ### [ 1036s] [ 1018.608257] sysrq: SysRq : Power Off [ 1036s] [ 1018.615053] reboot: Power down [ 1037s] ### VM INTERACTION END ### [ 1037s] [ 1037s] armbuild02 failed "build osmo-iuh.spec" at Tue Nov 2 01:20:54 UTC 2021. [ 1037s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 03:30:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 03:30:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6180b0e314846_4be72abbd99885e02079b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 498s] # is like basename from coreutils, and . is WD. [ 498s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 498s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 498s] fi [ 498s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 498s] # in /usr/share/osmo-gsm-manuals. [ 498s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 498s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 498s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 498s] a2x: resource files: [] [ 498s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 498s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 498s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 498s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 498s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 498s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 498s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 498s] make[1]: *** [Makefile:394: all] Error 2 [ 498s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 498s] dh_auto_build: error: make -j1 returned exit code 2 [ 498s] make: *** [debian/rules:45: build] Error 25 [ 498s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 498s] ### VM INTERACTION START ### [ 499s] Powering off. [ 499s] [ 421.254912] reboot: Power down [ 500s] ### VM INTERACTION END ### [ 500s] [ 500s] cloud108 failed "build osmo-sgsn_1.7.1.dsc" at Tue Nov 2 03:30:22 UTC 2021. [ 500s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 08:19:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 08:19:45 +0000 Subject: Change in osmo-hnodeb[master]: populated debian/changelog to avoid build failures References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26057 ) Change subject: populated debian/changelog to avoid build failures ...................................................................... populated debian/changelog to avoid build failures An empty debian/changelog is illegal and makes dpkg-buildpackage fail. This in turn causes our nightly builds to fail like this + git -C ./debian commit -m 'auto-commit: debian: depend on osmocom-nightly (= 1.0.0.202111020026)' . [master 83b1eb7] auto-commit: debian: depend on osmocom-nightly (= 1.0.0.202111020026) 1 file changed, 3 insertions(+), 3 deletions(-) + dch -b -v .202111020026 -m 'Snapshot build' dch: warning: debian/changelog(l0): found end of file where expected first heading dch: error: fatal error occurred while parsing debian/changelog Build step 'Execute shell' marked build as failure Sending e-mails to: jenkins-notifications at lists.osmocom.org Finished: FAILURE Change-Id: Ic0c1fcd34a40355691f39224d9a473951b0f3d8e --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26057/1 diff --git a/debian/changelog b/debian/changelog index e69de29..8e9a94d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -0,0 +1,6 @@ +osmo-hnodeb (0.0.0) unstable; urgency=medium + + * Initial debian package + + -- Harald Welte Mon, 01 Nov 2021 16:13:40 +0200 + -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic0c1fcd34a40355691f39224d9a473951b0f3d8e Gerrit-Change-Number: 26057 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 08:20:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 08:20:44 +0000 Subject: Change in osmo-hnodeb[master]: populated debian/changelog to avoid build failures In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26057 ) Change subject: populated debian/changelog to avoid build failures ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic0c1fcd34a40355691f39224d9a473951b0f3d8e Gerrit-Change-Number: 26057 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 02 Nov 2021 08:20:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 08:21:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 08:21:52 +0000 Subject: Change in osmo-hnodeb[master]: populated debian/changelog to avoid build failures In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26057 ) Change subject: populated debian/changelog to avoid build failures ...................................................................... populated debian/changelog to avoid build failures An empty debian/changelog is illegal and makes dpkg-buildpackage fail. This in turn causes our nightly builds to fail like this + git -C ./debian commit -m 'auto-commit: debian: depend on osmocom-nightly (= 1.0.0.202111020026)' . [master 83b1eb7] auto-commit: debian: depend on osmocom-nightly (= 1.0.0.202111020026) 1 file changed, 3 insertions(+), 3 deletions(-) + dch -b -v .202111020026 -m 'Snapshot build' dch: warning: debian/changelog(l0): found end of file where expected first heading dch: error: fatal error occurred while parsing debian/changelog Build step 'Execute shell' marked build as failure Sending e-mails to: jenkins-notifications at lists.osmocom.org Finished: FAILURE Change-Id: Ic0c1fcd34a40355691f39224d9a473951b0f3d8e --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index e69de29..8e9a94d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -0,0 +1,6 @@ +osmo-hnodeb (0.0.0) unstable; urgency=medium + + * Initial debian package + + -- Harald Welte Mon, 01 Nov 2021 16:13:40 +0200 + -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic0c1fcd34a40355691f39224d9a473951b0f3d8e Gerrit-Change-Number: 26057 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 08:24:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 08:24:37 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-b... In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26054 ) Change subject: osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions ...................................................................... osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions * Remove deprecated configuration options: 'osmotrx timing-advance-loop' is deprecated, Timing Advance loop is now active by default 'osmotrx ms-power-loop <-127-127>' is deprecated, MS Power Control is now managed by BSC * Adjust 'ipa unit-id' (1801 -> 6969) to match the one from the example osmo-bsc.cfg * Set clock advance values to known working values: + 'osmotrx fn-advance' -> 20 + 'osmotrx rts-advance' -> 5 * Set 'nominal-tx-power' since the calypso-bts tranceiver does not support NOMTXPOWER Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9 --- M doc/examples/trx/osmo-bts-trx-calypso.cfg 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg b/doc/examples/trx/osmo-bts-trx-calypso.cfg index 3f2e778..d6cc43a 100644 --- a/doc/examples/trx/osmo-bts-trx-calypso.cfg +++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg @@ -1,6 +1,6 @@ ! ! OsmoBTS configuration example for CalypsoBTS -! http://osmocom.org/projects/baseband/wiki/CalypsoBTS +! https://osmocom.org/projects/baseband/wiki/CalypsoBTS !! ! log stderr @@ -24,14 +24,15 @@ instance 0 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 - osmotrx timing-advance-loop - osmotrx ms-power-loop -65 osmotrx legacy-setbsic + osmotrx fn-advance 20 + osmotrx rts-advance 5 bts 0 oml remote-ip 127.0.0.1 - ipa unit-id 1801 0 + ipa unit-id 6969 0 gsmtap-sapi pdtch gsmtap-sapi ccch band 900 trx 0 phy 0 instance 0 + nominal-tx-power 23 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69436b914cf1bec57f9fe7acea4a896e7c46b3a9 Gerrit-Change-Number: 26054 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 08:27:57 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 08:27:57 +0000 Subject: Change in osmo-hnodeb[master]: debian/changelog: add initial References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26058 ) Change subject: debian/changelog: add initial ...................................................................... debian/changelog: add initial Fix currently failing Osmocom_OBS_{next,nightly} jenkins jobs, which run dch inside the git tree and fail on the empty debian/changelog. Fix for: dch: error: fatal error occurred while parsing debian/changelog Related: SYS#5516 Related: https://jenkins.osmocom.org/jenkins/job/Osmocom_OBS_nightly/1051/console Change-Id: I2be336860f1b936d292d3bacc3dad9cedabd646a --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/58/26058/1 diff --git a/debian/changelog b/debian/changelog index e69de29..3604f2e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -0,0 +1,7 @@ +osmo-hnodeb (0.1.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Add project skeleton + * Initial commit + + -- Oliver Smith Tue, 02 Nov 2021 09:06:04 +0100 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2be336860f1b936d292d3bacc3dad9cedabd646a Gerrit-Change-Number: 26058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 08:29:28 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 08:29:28 +0000 Subject: Change in osmo-hnodeb[master]: debian/changelog: add initial In-Reply-To: References: Message-ID: osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26058 ) Change subject: debian/changelog: add initial ...................................................................... Abandoned Harald submitted a similar patch -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2be336860f1b936d292d3bacc3dad9cedabd646a Gerrit-Change-Number: 26058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 08:29:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:29:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <6180f713cc531_4be72abbd99885e02419ec@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 48s] checking for gcc option to produce PIC... -fPIC -DPIC [ 48s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 48s] checking if gcc static flag -static works... no [ 48s] checking if gcc supports -c -o file.o... yes [ 48s] checking if gcc supports -c -o file.o... (cached) yes [ 48s] checking whether the gcc linker (/usr/i586-suse-linux/bin/ld) supports shared libraries... yes [ 48s] checking whether -lc should be explicitly linked in... no [ 48s] checking dynamic linker characteristics... GNU/Linux ld.so [ 48s] checking how to hardcode library paths into programs... immediate [ 48s] checking whether stripping libraries is possible... yes [ 48s] checking if libtool supports shared libraries... yes [ 48s] checking whether to build shared libraries... yes [ 48s] checking whether to build static libraries... yes [ 48s] checking for pkg-config... /usr/bin/pkg-config [ 48s] checking for i586-suse-linux-gnu-pkg-config... /usr/bin/i586-suse-linux-gnu-pkg-config [ 48s] checking pkg-config is at least version 0.20... yes [ 48s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 48s] error: Bad exit status from /var/tmp/rpm-tmp.VyObXe (%build) [ 48s] [ 48s] [ 48s] RPM build errors: [ 48s] Bad exit status from /var/tmp/rpm-tmp.VyObXe (%build) [ 48s] ### VM INTERACTION START ### [ 51s] [ 43.507190][ T418] sysrq: Power Off [ 51s] [ 43.514123][ T16] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] lamb23 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:29:50 UTC 2021. [ 51s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:30:32 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:30:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6180f732739bd_4be72abbd99885e02420e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 203s] # we create a symlink at ./srcfile.adoc pointing at [ 203s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 203s] # is like basename from coreutils, and . is WD. [ 203s] if ! [ -f test-usermanual.adoc ]; then \ [ 203s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 203s] fi [ 203s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 203s] # in ... [ 203s] TEXINPUTS=".." \ [ 203s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 203s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 203s] a2x: resource files: [] [ 203s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 203s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 203s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 203s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 203s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 203s] make[1]: *** [Makefile:363: all] Error 2 [ 203s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 203s] dh_auto_build: error: make -j1 returned exit code 2 [ 203s] make: *** [debian/rules:5: binary] Error 25 [ 203s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 203s] ### VM INTERACTION START ### [ 204s] Powering off. [ 204s] [ 193.650968] reboot: Power down [ 204s] ### VM INTERACTION END ### [ 204s] [ 204s] goat01 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111020822.dsc" at Tue Nov 2 08:30:26 UTC 2021. [ 204s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:31:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:31:06 +0000 Subject: Build failure of network:osmocom:nightly/binutils-arm-osmo-eabi in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <6180f75291c40_4be72abbd99885e0242130@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/binutils-arm-osmo-eabi/xUbuntu_21.10/x86_64 Package network:osmocom:nightly/binutils-arm-osmo-eabi failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly binutils-arm-osmo-eabi Last lines of build log: [ 81s] 502 | ((long (*) (bfd *, arelent **, asymbol **)) _bfd_n1) [ 81s] | ^ [ 81s] ./bfd.h:5851:3: note: in expansion of macro '_bfd_nodynamic_canonicalize_dynamic_reloc' [ 81s] 5851 | NAME##_canonicalize_dynamic_reloc [ 81s] | ^~~~ [ 81s] ../../bfd/ihex.c:994:3: note: in expansion of macro 'BFD_JUMP_TABLE_DYNAMIC' [ 81s] 994 | BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic), [ 81s] | ^~~~~~~~~~~~~~~~~~~~~~ [ 81s] cc1: all warnings being treated as errors [ 81s] make[5]: *** [Makefile:1517: ihex.lo] Error 1 [ 81s] make[5]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 81s] make[4]: *** [Makefile:1555: all-recursive] Error 1 [ 81s] make[4]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 81s] make[3]: *** [Makefile:1066: all] Error 2 [ 81s] make[3]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 81s] make[2]: *** [Makefile:3331: all-bfd] Error 2 [ 81s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 81s] make[1]: *** [Makefile:850: all] Error 2 [ 81s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 81s] dh_auto_build: error: cd build && make -j8 returned exit code 2 [ 81s] make: *** [debian/rules:43: build] Error 25 [ 81s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 81s] ### VM INTERACTION START ### [ 84s] [ 78.147623] sysrq: Power Off [ 84s] [ 78.150517] reboot: Power down [ 85s] ### VM INTERACTION END ### [ 85s] [ 85s] goat17 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Tue Nov 2 08:30:56 UTC 2021. [ 85s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:31:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:31:40 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <6180f78a812ce_4be72abbd99885e024223c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 44s] 628 184 0 812 32c obj/simtrace/dfu_led.o [ 44s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 44s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 44s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 44s] 229 0 0 229 e5 obj/simtrace/dfu_board_simtrace.o [ 44s] 941 0 1 942 3ae obj/simtrace/dfu_main.o [ 44s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 44s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 44s] 1029 24 532 1585 631 obj/simtrace/dfu_dfu_driver.o [ 44s] 13144 0 11440 24584 6008 bin/simtrace-dfu-dfu.elf [ 44s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 44s] make -C firmware BOARD=simtrace APP=blupdate [ 44s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 44s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 44s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 44s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 44s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 44s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 44s] dh_auto_build: make -j1 returned exit code 2 [ 44s] debian/rules:16: recipe for target 'build' failed [ 44s] make: *** [build] Error 2 [ 44s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 44s] ### VM INTERACTION START ### [ 47s] [ 41.558021] sysrq: Power Off [ 47s] [ 41.562104] reboot: Power down [ 47s] ### VM INTERACTION END ### [ 47s] [ 47s] goat11 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:31:34 UTC 2021. [ 47s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:31:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:31:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <6180f78b2937_4be72abbd99885e02423f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 55s] checking for gcc option to produce PIC... -fPIC -DPIC [ 55s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 55s] checking if gcc static flag -static works... no [ 55s] checking if gcc supports -c -o file.o... yes [ 55s] checking if gcc supports -c -o file.o... (cached) yes [ 55s] checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes [ 55s] checking whether -lc should be explicitly linked in... no [ 55s] checking dynamic linker characteristics... GNU/Linux ld.so [ 55s] checking how to hardcode library paths into programs... immediate [ 55s] checking whether stripping libraries is possible... yes [ 55s] checking if libtool supports shared libraries... yes [ 55s] checking whether to build shared libraries... yes [ 55s] checking whether to build static libraries... yes [ 55s] checking for pkg-config... /usr/bin/pkg-config [ 55s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 55s] checking pkg-config is at least version 0.20... yes [ 55s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 55s] error: Bad exit status from /var/tmp/rpm-tmp.0r7uJB (%build) [ 55s] [ 55s] [ 55s] RPM build errors: [ 55s] Bad exit status from /var/tmp/rpm-tmp.0r7uJB (%build) [ 55s] ### VM INTERACTION START ### [ 59s] [ 48.782900] sysrq: Power Off [ 59s] [ 48.806005] reboot: Power down [ 59s] ### VM INTERACTION END ### [ 59s] [ 59s] lamb03 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:31:45 UTC 2021. [ 59s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:32:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:32:14 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <6180f7a98a076_4be72abbd99885e02424c7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 39s] checking for gcc option to produce PIC... -fPIC -DPIC [ 39s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 39s] checking if gcc static flag -static works... no [ 39s] checking if gcc supports -c -o file.o... yes [ 39s] checking if gcc supports -c -o file.o... (cached) yes [ 39s] checking whether the gcc linker (/usr/armv7hl-suse-linux-gnueabi/bin/ld) supports shared libraries... yes [ 39s] checking whether -lc should be explicitly linked in... no [ 39s] checking dynamic linker characteristics... GNU/Linux ld.so [ 39s] checking how to hardcode library paths into programs... immediate [ 39s] checking whether stripping libraries is possible... yes [ 39s] checking if libtool supports shared libraries... yes [ 39s] checking whether to build shared libraries... yes [ 39s] checking whether to build static libraries... yes [ 39s] checking for pkg-config... /usr/bin/pkg-config [ 39s] checking for armv7hl-suse-linux-gnueabi-pkg-config... /usr/bin/armv7hl-suse-linux-gnueabi-pkg-config [ 39s] checking pkg-config is at least version 0.20... yes [ 39s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 39s] error: Bad exit status from /var/tmp/rpm-tmp.lQLZfx (%build) [ 39s] [ 39s] [ 39s] RPM build errors: [ 39s] Bad exit status from /var/tmp/rpm-tmp.lQLZfx (%build) [ 39s] ### VM INTERACTION START ### [ 43s] [ 33.293636][ T384] sysrq: Power Off [ 43s] [ 33.295219][ T15] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] obs-arm-11 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:32:06 UTC 2021. [ 43s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:32:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:32:31 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586 In-Reply-To: References: Message-ID: <6180f7a9dce7d_4be72abbd99885e02425c0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 68s] 628 184 0 812 32c obj/simtrace/dfu_led.o [ 68s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 68s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 68s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 68s] 229 0 0 229 e5 obj/simtrace/dfu_board_simtrace.o [ 68s] 941 0 1 942 3ae obj/simtrace/dfu_main.o [ 68s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 68s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 68s] 1029 24 532 1585 631 obj/simtrace/dfu_dfu_driver.o [ 68s] 13144 0 11440 24584 6008 bin/simtrace-dfu-dfu.elf [ 68s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 68s] make -C firmware BOARD=simtrace APP=blupdate [ 68s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 68s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 68s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 68s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 68s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 68s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 68s] dh_auto_build: make -j1 returned exit code 2 [ 68s] debian/rules:16: recipe for target 'build' failed [ 68s] make: *** [build] Error 2 [ 68s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 68s] ### VM INTERACTION START ### [ 71s] [ 63.463947] sysrq: Power Off [ 71s] [ 63.468536] reboot: Power down [ 71s] ### VM INTERACTION END ### [ 71s] [ 71s] sheep87 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:32:18 UTC 2021. [ 71s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:32:48 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6180f7cdb312f_4be72abbd99885e0242780@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 93s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 93s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 93s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 93s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 93s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 93s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 93s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 93s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 93s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 93s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 93s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 93s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 93s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 93s] make -C firmware BOARD=simtrace APP=blupdate [ 93s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 93s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 93s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 93s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 93s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 93s] dh_auto_build: error: make -j1 returned exit code 2 [ 93s] make: *** [debian/rules:16: build] Error 25 [ 93s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 93s] ### VM INTERACTION START ### [ 96s] [ 86.895979] sysrq: Power Off [ 96s] [ 86.900639] reboot: Power down [ 96s] ### VM INTERACTION END ### [ 96s] [ 96s] sheep88 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:32:46 UTC 2021. [ 96s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:05 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <6180f7ce29af_4be72abbd99885e024286@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 86s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 86s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 86s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 86s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 86s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 86s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 86s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 86s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 86s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 86s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 86s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 86s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 86s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 86s] make -C firmware BOARD=simtrace APP=blupdate [ 86s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 86s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 86s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 86s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 86s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 86s] dh_auto_build: make -j1 returned exit code 2 [ 86s] make: *** [debian/rules:16: build] Error 2 [ 86s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 86s] ### VM INTERACTION START ### [ 89s] [ 81.492719] sysrq: Power Off [ 89s] [ 81.497738] reboot: Power down [ 89s] ### VM INTERACTION END ### [ 89s] [ 89s] sheep86 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:32:50 UTC 2021. [ 89s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:05 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <6180f7ce87d09_4be72abbd99885e02430b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 67s] 340 0 0 340 154 obj/simtrace/dfu_board_lowlevel.o [ 67s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 67s] 660 184 0 844 34c obj/simtrace/dfu_led.o [ 67s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 67s] 1270 0 1033 2303 8ff obj/simtrace/dfu_uart_console.o [ 67s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 67s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 67s] 925 0 1 926 39e obj/simtrace/dfu_main.o [ 67s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 67s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 67s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 67s] 13188 0 11440 24628 6034 bin/simtrace-dfu-dfu.elf [ 67s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 67s] make -C firmware BOARD=simtrace APP=blupdate [ 67s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 67s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 67s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 67s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 67s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 67s] dh_auto_build: error: make -j1 returned exit code 2 [ 67s] make: *** [debian/rules:16: build] Error 25 [ 67s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 67s] ### VM INTERACTION START ### [ 70s] [ 63.023255] sysrq: Power Off [ 70s] [ 63.026836] reboot: Power down [ 70s] ### VM INTERACTION END ### [ 70s] [ 70s] goat09 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:33:03 UTC 2021. [ 70s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:22 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <6180f7e7e1f15_4be72abbd99885e0243187@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 143s] intention of the Shared Library Policy is to allow parallel installation of [ 143s] multiple versions of the same shared library, hard dependencies likely make [ 143s] that impossible. Please remove this dependency and instead move it to the [ 143s] runtime uses of your library. [ 143s] [ 143s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 143s] The package contains an init script or systemd service file but lacks the [ 143s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 143s] [ 143s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 143s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 143s] This package contains a library and provides no %post scriptlet containing a [ 143s] call to ldconfig. [ 143s] [ 143s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 143s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 143s] This package contains a library and provides no %postun scriptlet containing a [ 143s] call to ldconfig. [ 143s] [ 143s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 143s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 143s] [ 143s] ### VM INTERACTION START ### [ 146s] [ 139.754328] sysrq: Power Off [ 146s] [ 139.757988] reboot: Power down [ 146s] ### VM INTERACTION END ### [ 146s] [ 146s] sheep88 failed "build osmo-iuh.spec" at Tue Nov 2 08:33:09 UTC 2021. [ 146s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:39 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <6180f7e85b0c3_4be72abbd99885e02432d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 22s] checking for gcc option to produce PIC... -fPIC -DPIC [ 22s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 22s] checking if gcc static flag -static works... no [ 22s] checking if gcc supports -c -o file.o... yes [ 22s] checking if gcc supports -c -o file.o... (cached) yes [ 22s] checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes [ 22s] checking whether -lc should be explicitly linked in... no [ 22s] checking dynamic linker characteristics... GNU/Linux ld.so [ 22s] checking how to hardcode library paths into programs... immediate [ 22s] checking whether stripping libraries is possible... yes [ 22s] checking if libtool supports shared libraries... yes [ 22s] checking whether to build shared libraries... yes [ 22s] checking whether to build static libraries... yes [ 22s] checking for pkg-config... /usr/bin/pkg-config [ 22s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 22s] checking pkg-config is at least version 0.20... yes [ 22s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 23s] error: Bad exit status from /var/tmp/rpm-tmp.YzX1aj (%build) [ 23s] [ 23s] [ 23s] RPM build errors: [ 23s] Bad exit status from /var/tmp/rpm-tmp.YzX1aj (%build) [ 23s] ### VM INTERACTION START ### [ 26s] [ 21.718097][ T417] sysrq: Power Off [ 26s] [ 21.721017][ T149] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] goat03 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:33:25 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:39 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_10/x86_64 In-Reply-To: References: Message-ID: <6180f7e88accd_4be72abbd99885e02433a2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 120s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 120s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 120s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 120s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 120s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 120s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 120s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 120s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 120s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 120s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 120s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 120s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 120s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 120s] make -C firmware BOARD=simtrace APP=blupdate [ 120s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 120s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 120s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 120s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 120s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 120s] dh_auto_build: make -j1 returned exit code 2 [ 120s] make: *** [debian/rules:16: build] Error 2 [ 120s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 120s] ### VM INTERACTION START ### [ 123s] [ 111.374553] sysrq: Power Off [ 123s] [ 111.382501] reboot: Power down [ 123s] ### VM INTERACTION END ### [ 123s] [ 123s] lamb17 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:33:26 UTC 2021. [ 123s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:56 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <6180f80218f93_4be72abbd99885e02434f3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 46s] checking for gcc option to produce PIC... -fPIC -DPIC [ 46s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 46s] checking if gcc static flag -static works... no [ 47s] checking if gcc supports -c -o file.o... yes [ 47s] checking if gcc supports -c -o file.o... (cached) yes [ 47s] checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes [ 47s] checking whether -lc should be explicitly linked in... no [ 47s] checking dynamic linker characteristics... GNU/Linux ld.so [ 47s] checking how to hardcode library paths into programs... immediate [ 47s] checking whether stripping libraries is possible... yes [ 47s] checking if libtool supports shared libraries... yes [ 47s] checking whether to build shared libraries... yes [ 47s] checking whether to build static libraries... yes [ 47s] checking for pkg-config... /usr/bin/pkg-config [ 47s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 47s] checking pkg-config is at least version 0.20... yes [ 47s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 47s] error: Bad exit status from /var/tmp/rpm-tmp.Kyhz96 (%build) [ 47s] [ 47s] [ 47s] RPM build errors: [ 47s] Bad exit status from /var/tmp/rpm-tmp.Kyhz96 (%build) [ 47s] ### VM INTERACTION START ### [ 50s] [ 41.546272] sysrq: SysRq : Power Off [ 50s] [ 41.551015] reboot: Power down [ 50s] ### VM INTERACTION END ### [ 50s] [ 50s] lamb18 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:33:47 UTC 2021. [ 50s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:56 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <6180f8025feee_4be72abbd99885e02435cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 132s] 340 0 0 340 154 obj/simtrace/dfu_board_lowlevel.o [ 132s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 132s] 660 184 0 844 34c obj/simtrace/dfu_led.o [ 132s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 132s] 1270 0 1033 2303 8ff obj/simtrace/dfu_uart_console.o [ 132s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 132s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 132s] 925 0 1 926 39e obj/simtrace/dfu_main.o [ 132s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 132s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 132s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 132s] 3700 0 1368 5068 13cc bin/simtrace-dfu-dfu.elf [ 132s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 132s] make -C firmware BOARD=simtrace APP=blupdate [ 132s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 133s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 133s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 133s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 133s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 133s] dh_auto_build: error: make -j1 returned exit code 2 [ 133s] make: *** [debian/rules:16: build] Error 25 [ 133s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 133s] ### VM INTERACTION START ### [ 136s] [ 124.132871] sysrq: Power Off [ 136s] [ 124.139824] reboot: Power down [ 136s] ### VM INTERACTION END ### [ 136s] [ 136s] lamb15 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:33:52 UTC 2021. [ 136s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:33:56 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_10/i586 In-Reply-To: References: Message-ID: <6180f802d4bc9_4be72abbd99885e0243674@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 122s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 122s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 122s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 122s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 122s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 122s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 122s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 122s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 122s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 122s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 122s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 122s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 122s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 122s] make -C firmware BOARD=simtrace APP=blupdate [ 122s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 122s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 122s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 122s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 122s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 122s] dh_auto_build: make -j1 returned exit code 2 [ 122s] make: *** [debian/rules:16: build] Error 2 [ 122s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 122s] ### VM INTERACTION START ### [ 125s] [ 114.284077] sysrq: Power Off [ 125s] [ 114.289472] reboot: Power down [ 126s] ### VM INTERACTION END ### [ 126s] [ 126s] lamb61 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:33:44 UTC 2021. [ 126s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:34:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:34:30 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6180f82173951_4be72abbd99885e02437db@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 109s] checking for gcc option to produce PIC... -fPIC -DPIC [ 109s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 109s] checking if gcc static flag -static works... no [ 109s] checking if gcc supports -c -o file.o... yes [ 109s] checking if gcc supports -c -o file.o... (cached) yes [ 109s] checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes [ 109s] checking whether -lc should be explicitly linked in... no [ 109s] checking dynamic linker characteristics... GNU/Linux ld.so [ 109s] checking how to hardcode library paths into programs... immediate [ 109s] checking whether stripping libraries is possible... yes [ 109s] checking if libtool supports shared libraries... yes [ 109s] checking whether to build shared libraries... yes [ 109s] checking whether to build static libraries... yes [ 109s] checking for pkg-config... /usr/bin/pkg-config [ 109s] checking for x86_64-redhat-linux-gnu-pkg-config... /usr/bin/x86_64-redhat-linux-gnu-pkg-config [ 109s] checking pkg-config is at least version 0.20... yes [ 109s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 109s] error: Bad exit status from /var/tmp/rpm-tmp.ye8wmj (%build) [ 109s] [ 109s] [ 109s] RPM build errors: [ 109s] Bad exit status from /var/tmp/rpm-tmp.ye8wmj (%build) [ 109s] ### VM INTERACTION START ### [ 111s] Powering off. [ 111s] [ 95.909143] reboot: Power down [ 111s] ### VM INTERACTION END ### [ 111s] [ 111s] lamb53 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:34:18 UTC 2021. [ 111s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:34:47 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <6180f83fca5d8_4be72abbd99885e02438dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 148s] 340 0 0 340 154 obj/simtrace/dfu_board_lowlevel.o [ 148s] 1270 0 1033 2303 8ff obj/simtrace/dfu_uart_console.o [ 148s] 660 184 0 844 34c obj/simtrace/dfu_led.o [ 148s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 148s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 148s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 148s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 148s] 925 0 1 926 39e obj/simtrace/dfu_main.o [ 148s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 148s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 148s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 148s] 13188 0 11440 24628 6034 bin/simtrace-dfu-dfu.elf [ 148s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 148s] make -C firmware BOARD=simtrace APP=blupdate [ 148s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 148s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 148s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 148s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 148s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 148s] dh_auto_build: error: make -j1 returned exit code 2 [ 148s] make: *** [debian/rules:16: build] Error 25 [ 148s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 148s] ### VM INTERACTION START ### [ 151s] [ 139.030835] sysrq: Power Off [ 151s] [ 139.050576] reboot: Power down [ 151s] ### VM INTERACTION END ### [ 151s] [ 152s] lamb02 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:34:37 UTC 2021. [ 152s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:35:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:35:04 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <6180f840a2af6_4be72abbd99885e024392d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 130s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 130s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 130s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 130s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 130s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 130s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 130s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 130s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 130s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 130s] 13112 0 11440 24552 5fe8 bin/simtrace-dfu-dfu.elf [ 130s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 130s] make -C firmware BOARD=simtrace APP=blupdate [ 130s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 130s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 130s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 130s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 130s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 130s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 130s] dh_auto_build: make -j1 returned exit code 2 [ 130s] debian/rules:16: recipe for target 'build' failed [ 130s] make: *** [build] Error 2 [ 130s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 130s] ### VM INTERACTION START ### [ 133s] [ 120.974495] sysrq: Power Off [ 133s] [ 120.993083] reboot: Power down [ 133s] ### VM INTERACTION END ### [ 133s] [ 133s] cloud115 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:35:02 UTC 2021. [ 133s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:35:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:35:55 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_11/i586 In-Reply-To: References: Message-ID: <6180f87db773a_4be72abbd99885e0244137@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 142s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 142s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 142s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 142s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 142s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 142s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 142s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 142s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 142s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 142s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 142s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 142s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 142s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 142s] make -C firmware BOARD=simtrace APP=blupdate [ 142s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 142s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 142s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 142s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 142s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 142s] dh_auto_build: error: make -j1 returned exit code 2 [ 142s] make: *** [debian/rules:16: build] Error 25 [ 142s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 142s] ### VM INTERACTION START ### [ 145s] [ 131.624690] sysrq: Power Off [ 146s] [ 131.639726] reboot: Power down [ 146s] ### VM INTERACTION END ### [ 146s] [ 146s] lamb21 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:35:40 UTC 2021. [ 146s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:36:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:36:29 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6180f89748ba7_4be72abbd99885e024424a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Unstable/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 77s] 336 0 4 340 154 obj/simtrace/dfu_board_lowlevel.o [ 77s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 77s] 656 184 0 840 348 obj/simtrace/dfu_led.o [ 77s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 77s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 77s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 77s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 77s] 909 0 20 929 3a1 obj/simtrace/dfu_main.o [ 77s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 77s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 77s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 77s] 13176 0 11444 24620 602c bin/simtrace-dfu-dfu.elf [ 77s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 77s] make -C firmware BOARD=simtrace APP=blupdate [ 77s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 77s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 77s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 77s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 77s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 77s] dh_auto_build: error: make -j1 returned exit code 2 [ 77s] make: *** [debian/rules:16: build] Error 25 [ 77s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 77s] ### VM INTERACTION START ### [ 80s] [ 70.945460] sysrq: Power Off [ 80s] [ 70.949190] reboot: Power down [ 80s] ### VM INTERACTION END ### [ 80s] [ 80s] goat09 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:36:12 UTC 2021. [ 80s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:36:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:36:46 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <6180f8b658a15_4be72abbd99885e0244446@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_21.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 85s] 340 0 0 340 154 obj/simtrace/dfu_board_lowlevel.o [ 85s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 85s] 660 184 0 844 34c obj/simtrace/dfu_led.o [ 85s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 85s] 1270 0 1033 2303 8ff obj/simtrace/dfu_uart_console.o [ 85s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 85s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 85s] 925 0 1 926 39e obj/simtrace/dfu_main.o [ 85s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 85s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 85s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 85s] 3700 0 1368 5068 13cc bin/simtrace-dfu-dfu.elf [ 85s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 85s] make -C firmware BOARD=simtrace APP=blupdate [ 85s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 85s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 85s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 85s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 85s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 85s] dh_auto_build: error: make -j1 returned exit code 2 [ 85s] make: *** [debian/rules:16: build] Error 25 [ 85s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 85s] ### VM INTERACTION START ### [ 88s] [ 80.168636] sysrq: Power Off [ 88s] [ 80.172632] reboot: Power down [ 88s] ### VM INTERACTION END ### [ 88s] [ 88s] sheep87 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:36:45 UTC 2021. [ 88s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:37:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:37:20 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <6180f8d52c19e_4be72abbd99885e02446a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 249s] intention of the Shared Library Policy is to allow parallel installation of [ 249s] multiple versions of the same shared library, hard dependencies likely make [ 249s] that impossible. Please remove this dependency and instead move it to the [ 249s] runtime uses of your library. [ 249s] [ 249s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 249s] The package contains an init script or systemd service file but lacks the [ 249s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 249s] [ 249s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 249s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 249s] This package contains a library and provides no %post scriptlet containing a [ 249s] call to ldconfig. [ 249s] [ 249s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 249s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 250s] This package contains a library and provides no %postun scriptlet containing a [ 250s] call to ldconfig. [ 250s] [ 250s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 250s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 250s] [ 250s] ### VM INTERACTION START ### [ 253s] [ 242.291055] sysrq: SysRq : Power Off [ 253s] [ 242.296445] reboot: Power down [ 253s] ### VM INTERACTION END ### [ 253s] [ 253s] lamb04 failed "build osmo-iuh.spec" at Tue Nov 2 08:37:10 UTC 2021. [ 253s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:37:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:37:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <6180f8d56f237_4be72abbd99885e02447a6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 99s] #define VERSION "UNKNOWN" [ 99s] #define STDC_HEADERS 1 [ 99s] #define HAVE_SYS_TYPES_H 1 [ 99s] #define HAVE_SYS_STAT_H 1 [ 99s] #define HAVE_STDLIB_H 1 [ 99s] #define HAVE_STRING_H 1 [ 99s] #define HAVE_MEMORY_H 1 [ 99s] #define HAVE_STRINGS_H 1 [ 99s] #define HAVE_INTTYPES_H 1 [ 99s] #define HAVE_STDINT_H 1 [ 99s] #define HAVE_UNISTD_H 1 [ 99s] #define HAVE_DLFCN_H 1 [ 99s] #define LT_OBJDIR ".libs/" [ 99s] [ 99s] configure: exit 1 [ 99s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu --libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 99s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 99s] make[1]: *** [override_dh_auto_configure] Error 2 [ 99s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 99s] debian/rules:45: recipe for target 'build' failed [ 99s] make: *** [build] Error 2 [ 99s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 99s] ### VM INTERACTION START ### [ 102s] [ 95.415641] sysrq: Power Off [ 102s] [ 95.419412] reboot: Power down [ 102s] ### VM INTERACTION END ### [ 102s] [ 102s] goat13 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:37:27 UTC 2021. [ 102s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:38:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:38:11 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_11/x86_64 In-Reply-To: References: Message-ID: <6180f8f62ec39_4be72abbd99885e0245020@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 129s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 129s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 129s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 129s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 129s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 129s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 129s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 129s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 129s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 129s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 129s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 129s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 129s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 129s] make -C firmware BOARD=simtrace APP=blupdate [ 129s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 129s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 129s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 129s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 129s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 129s] dh_auto_build: error: make -j1 returned exit code 2 [ 129s] make: *** [debian/rules:16: build] Error 25 [ 129s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 129s] ### VM INTERACTION START ### [ 133s] [ 118.629650] sysrq: Power Off [ 133s] [ 118.635591] reboot: Power down [ 133s] ### VM INTERACTION END ### [ 133s] [ 133s] lamb10 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:37:58 UTC 2021. [ 133s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:38:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:38:11 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_10/aarch64 In-Reply-To: References: Message-ID: <6180f8f684031_4be72abbd99885e02451d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_10/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 111s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 111s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 111s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 111s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 111s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 111s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 111s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 111s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 111s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 111s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 111s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 111s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 111s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 111s] make -C firmware BOARD=simtrace APP=blupdate [ 111s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 111s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 111s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 111s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 111s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 111s] dh_auto_build: make -j1 returned exit code 2 [ 111s] make: *** [debian/rules:16: build] Error 2 [ 111s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 111s] ### VM INTERACTION START ### [ 114s] [ 99.662136] sysrq: Power Off [ 114s] [ 99.662765] reboot: Power down [ 114s] ### VM INTERACTION END ### [ 114s] [ 114s] obs-arm-10 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:38:04 UTC 2021. [ 114s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:39:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:39:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <6180f94cec78a_4be72abbd99885e02453f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 39s] checking for gcc option to produce PIC... -fPIC -DPIC [ 39s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 39s] checking if gcc static flag -static works... no [ 39s] checking if gcc supports -c -o file.o... yes [ 39s] checking if gcc supports -c -o file.o... (cached) yes [ 39s] checking whether the gcc linker (/usr/aarch64-suse-linux/bin/ld) supports shared libraries... yes [ 39s] checking whether -lc should be explicitly linked in... no [ 39s] checking dynamic linker characteristics... GNU/Linux ld.so [ 39s] checking how to hardcode library paths into programs... immediate [ 39s] checking whether stripping libraries is possible... yes [ 39s] checking if libtool supports shared libraries... yes [ 39s] checking whether to build shared libraries... yes [ 39s] checking whether to build static libraries... yes [ 39s] checking for pkg-config... /usr/bin/pkg-config [ 39s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config [ 39s] checking pkg-config is at least version 0.20... yes [ 39s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 39s] error: Bad exit status from /var/tmp/rpm-tmp.K4Ru3N (%build) [ 39s] [ 39s] [ 39s] RPM build errors: [ 39s] Bad exit status from /var/tmp/rpm-tmp.K4Ru3N (%build) [ 39s] ### VM INTERACTION START ### [ 43s] [ 32.933513][ T385] sysrq: Power Off [ 43s] [ 32.934141][ T15] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] obs-arm-11 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:39:06 UTC 2021. [ 43s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:40:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:40:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_9.0/i586 In-Reply-To: References: Message-ID: <6180f9a985fac_4be72abbd99885e02454bf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_9.0/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 107s] #define VERSION "UNKNOWN" [ 107s] #define STDC_HEADERS 1 [ 107s] #define HAVE_SYS_TYPES_H 1 [ 107s] #define HAVE_SYS_STAT_H 1 [ 107s] #define HAVE_STDLIB_H 1 [ 107s] #define HAVE_STRING_H 1 [ 107s] #define HAVE_MEMORY_H 1 [ 107s] #define HAVE_STRINGS_H 1 [ 107s] #define HAVE_INTTYPES_H 1 [ 107s] #define HAVE_STDINT_H 1 [ 107s] #define HAVE_UNISTD_H 1 [ 107s] #define HAVE_DLFCN_H 1 [ 107s] #define LT_OBJDIR ".libs/" [ 107s] [ 107s] configure: exit 1 [ 107s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu --libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 107s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 107s] make[1]: *** [override_dh_auto_configure] Error 2 [ 107s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 107s] debian/rules:45: recipe for target 'build' failed [ 107s] make: *** [build] Error 2 [ 107s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 107s] ### VM INTERACTION START ### [ 110s] [ 103.793254] sysrq: Power Off [ 110s] [ 103.797510] reboot: Power down [ 110s] ### VM INTERACTION END ### [ 110s] [ 110s] goat11 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:40:43 UTC 2021. [ 110s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:41:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:41:18 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_11/aarch64 In-Reply-To: References: Message-ID: <6180f9c3b0ab1_4be72abbd99885e02455d9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_11/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 163s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 163s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 163s] 652 184 0 836 344 obj/simtrace/dfu_led.o [ 163s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 163s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 163s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 163s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 163s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 163s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 163s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 163s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 163s] 13008 0 11440 24448 5f80 bin/simtrace-dfu-dfu.elf [ 163s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 163s] make -C firmware BOARD=simtrace APP=blupdate [ 163s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 163s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 163s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 163s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 163s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 164s] dh_auto_build: error: make -j1 returned exit code 2 [ 164s] make: *** [debian/rules:16: build] Error 25 [ 164s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 164s] ### VM INTERACTION START ### [ 167s] [ 146.412965] sysrq: Power Off [ 167s] [ 146.441242] reboot: Power down [ 167s] ### VM INTERACTION END ### [ 167s] [ 167s] obs-arm-9 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:41:02 UTC 2021. [ 167s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:41:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:41:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <6180f9c3e3ad4_4be72abbd99885e02456a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 275s] #define PACKAGE_URL "" [ 275s] #define PACKAGE "osmo-hnodeb" [ 275s] #define VERSION "UNKNOWN" [ 275s] #define STDC_HEADERS 1 [ 275s] #define HAVE_SYS_TYPES_H 1 [ 275s] #define HAVE_SYS_STAT_H 1 [ 275s] #define HAVE_STDLIB_H 1 [ 275s] #define HAVE_STRING_H 1 [ 275s] #define HAVE_MEMORY_H 1 [ 275s] #define HAVE_STRINGS_H 1 [ 275s] #define HAVE_INTTYPES_H 1 [ 275s] #define HAVE_STDINT_H 1 [ 275s] #define HAVE_UNISTD_H 1 [ 275s] #define HAVE_DLFCN_H 1 [ 275s] #define LT_OBJDIR ".libs/" [ 275s] [ 275s] configure: exit 1 [ 275s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 275s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 275s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 275s] make: *** [debian/rules:45: build] Error 2 [ 275s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 276s] ### VM INTERACTION START ### [ 279s] [ 265.335505] sysrq: Power Off [ 279s] [ 265.344498] reboot: Power down [ 279s] ### VM INTERACTION END ### [ 279s] [ 279s] lamb03 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:41:03 UTC 2021. [ 279s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:42:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:42:43 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <6180fa2465c9d_4be72abbd99885e0245913@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 285s] 628 184 0 812 32c obj/simtrace/dfu_led.o [ 285s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 285s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 285s] 104 0 0 104 68 obj/simtrace/dfu_sim_switch.o [ 285s] 229 0 0 229 e5 obj/simtrace/dfu_board_simtrace.o [ 285s] 941 0 1 942 3ae obj/simtrace/dfu_main.o [ 285s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 285s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 285s] 1029 24 532 1585 631 obj/simtrace/dfu_dfu_driver.o [ 285s] 13144 0 11440 24584 6008 bin/simtrace-dfu-dfu.elf [ 285s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 285s] make -C firmware BOARD=simtrace APP=blupdate [ 285s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 285s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 285s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 285s] Makefile:11: recipe for target 'fw-simtrace-blupdate' failed [ 285s] make[1]: *** [fw-simtrace-blupdate] Error 2 [ 285s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 285s] dh_auto_build: make -j1 returned exit code 2 [ 285s] debian/rules:16: recipe for target 'build' failed [ 285s] make: *** [build] Error 2 [ 285s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 285s] ### VM INTERACTION START ### [ 288s] [ 250.191613] sysrq: Power Off [ 288s] [ 250.221473] reboot: Power down [ 288s] ### VM INTERACTION END ### [ 288s] [ 288s] obs-arm-1 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:42:36 UTC 2021. [ 288s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:43:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:43:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_10/i586 In-Reply-To: References: Message-ID: <6180fa3d558a7_4be72abbd99885e0246067@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_10/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 301s] #define PACKAGE_URL "" [ 301s] #define PACKAGE "osmo-hnodeb" [ 301s] #define VERSION "UNKNOWN" [ 301s] #define STDC_HEADERS 1 [ 301s] #define HAVE_SYS_TYPES_H 1 [ 301s] #define HAVE_SYS_STAT_H 1 [ 301s] #define HAVE_STDLIB_H 1 [ 301s] #define HAVE_STRING_H 1 [ 301s] #define HAVE_MEMORY_H 1 [ 301s] #define HAVE_STRINGS_H 1 [ 301s] #define HAVE_INTTYPES_H 1 [ 301s] #define HAVE_STDINT_H 1 [ 301s] #define HAVE_UNISTD_H 1 [ 301s] #define HAVE_DLFCN_H 1 [ 301s] #define LT_OBJDIR ".libs/" [ 301s] [ 301s] configure: exit 1 [ 301s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 301s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 301s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 301s] make: *** [debian/rules:45: build] Error 2 [ 301s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 301s] ### VM INTERACTION START ### [ 304s] [ 278.401179] sysrq: Power Off [ 304s] [ 278.404668] reboot: Power down [ 304s] ### VM INTERACTION END ### [ 304s] [ 304s] cloud114 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:43:02 UTC 2021. [ 304s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:43:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:43:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <6180fa3de68c7_4be72abbd99885e024614f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 70s] checking for gcc option to produce PIC... -fPIC -DPIC [ 71s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 71s] checking if gcc static flag -static works... no [ 71s] checking if gcc supports -c -o file.o... yes [ 71s] checking if gcc supports -c -o file.o... (cached) yes [ 71s] checking whether the gcc linker (/usr/aarch64-suse-linux/bin/ld) supports shared libraries... yes [ 71s] checking whether -lc should be explicitly linked in... no [ 71s] checking dynamic linker characteristics... GNU/Linux ld.so [ 71s] checking how to hardcode library paths into programs... immediate [ 71s] checking whether stripping libraries is possible... yes [ 71s] checking if libtool supports shared libraries... yes [ 71s] checking whether to build shared libraries... yes [ 71s] checking whether to build static libraries... yes [ 71s] checking for pkg-config... /usr/bin/pkg-config [ 71s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config [ 71s] checking pkg-config is at least version 0.20... yes [ 71s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 71s] error: Bad exit status from /var/tmp/rpm-tmp.Gg3PJq (%build) [ 71s] [ 71s] [ 71s] RPM build errors: [ 71s] Bad exit status from /var/tmp/rpm-tmp.Gg3PJq (%build) [ 71s] ### VM INTERACTION START ### [ 74s] [ 59.916422] sysrq: SysRq : Power Off [ 74s] [ 59.917860] reboot: Power down [ 74s] ### VM INTERACTION END ### [ 74s] [ 74s] obs-arm-9 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:43:31 UTC 2021. [ 74s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:44:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:44:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <6180fa5cb55fe_4be72abbd99885e024628@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 271s] #define PACKAGE_URL "" [ 271s] #define PACKAGE "osmo-hnodeb" [ 271s] #define VERSION "UNKNOWN" [ 271s] #define STDC_HEADERS 1 [ 271s] #define HAVE_SYS_TYPES_H 1 [ 271s] #define HAVE_SYS_STAT_H 1 [ 271s] #define HAVE_STDLIB_H 1 [ 271s] #define HAVE_STRING_H 1 [ 271s] #define HAVE_MEMORY_H 1 [ 271s] #define HAVE_STRINGS_H 1 [ 271s] #define HAVE_INTTYPES_H 1 [ 271s] #define HAVE_STDINT_H 1 [ 271s] #define HAVE_UNISTD_H 1 [ 271s] #define HAVE_DLFCN_H 1 [ 271s] #define LT_OBJDIR ".libs/" [ 271s] [ 271s] configure: exit 1 [ 271s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 271s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 271s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 271s] make: *** [debian/rules:45: build] Error 2 [ 271s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 271s] ### VM INTERACTION START ### [ 272s] Powering off. [ 272s] [ 260.719625] reboot: Power down [ 272s] ### VM INTERACTION END ### [ 272s] [ 272s] sheep88 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:44:05 UTC 2021. [ 272s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:44:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:44:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6180fa7b3b4e4_4be72abbd99885e024631f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 179s] checking for gcc option to produce PIC... -fPIC -DPIC [ 179s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 179s] checking if gcc static flag -static works... no [ 180s] checking if gcc supports -c -o file.o... yes [ 180s] checking if gcc supports -c -o file.o... (cached) yes [ 180s] checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes [ 180s] checking whether -lc should be explicitly linked in... no [ 180s] checking dynamic linker characteristics... GNU/Linux ld.so [ 180s] checking how to hardcode library paths into programs... immediate [ 180s] checking whether stripping libraries is possible... yes [ 180s] checking if libtool supports shared libraries... yes [ 180s] checking whether to build shared libraries... yes [ 180s] checking whether to build static libraries... yes [ 180s] checking for pkg-config... /usr/bin/pkg-config [ 180s] checking for aarch64-redhat-linux-gnu-pkg-config... /usr/bin/aarch64-redhat-linux-gnu-pkg-config [ 180s] checking pkg-config is at least version 0.20... yes [ 180s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 180s] error: Bad exit status from /var/tmp/rpm-tmp.wR6fRc (%build) [ 180s] [ 180s] [ 180s] RPM build errors: [ 180s] Bad exit status from /var/tmp/rpm-tmp.wR6fRc (%build) [ 180s] ### VM INTERACTION START ### [ 181s] Powering off. [ 181s] [ 156.877533] reboot: Power down [ 182s] ### VM INTERACTION END ### [ 182s] [ 182s] obs-arm-8 failed "build osmo-hnodeb.spec" at Tue Nov 2 08:44:24 UTC 2021. [ 182s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:44:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:44:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <6180fa99db279_4be72abbd99885e024643b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 134s] #define VERSION "UNKNOWN" [ 134s] #define STDC_HEADERS 1 [ 134s] #define HAVE_SYS_TYPES_H 1 [ 134s] #define HAVE_SYS_STAT_H 1 [ 134s] #define HAVE_STDLIB_H 1 [ 134s] #define HAVE_STRING_H 1 [ 134s] #define HAVE_MEMORY_H 1 [ 134s] #define HAVE_STRINGS_H 1 [ 134s] #define HAVE_INTTYPES_H 1 [ 134s] #define HAVE_STDINT_H 1 [ 134s] #define HAVE_UNISTD_H 1 [ 134s] #define HAVE_DLFCN_H 1 [ 134s] #define LT_OBJDIR ".libs/" [ 134s] [ 134s] configure: exit 1 [ 134s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 134s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 134s] make[1]: *** [override_dh_auto_configure] Error 2 [ 134s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 134s] debian/rules:45: recipe for target 'build' failed [ 134s] make: *** [build] Error 2 [ 134s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 134s] ### VM INTERACTION START ### [ 137s] [ 130.041348] sysrq: Power Off [ 137s] [ 130.045151] reboot: Power down [ 137s] ### VM INTERACTION END ### [ 137s] [ 137s] goat07 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:44:57 UTC 2021. [ 137s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:45:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:45:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_10/x86_64 In-Reply-To: References: Message-ID: <6180fab3a2747_4be72abbd99885e0246549@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_10/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 268s] #define PACKAGE_URL "" [ 268s] #define PACKAGE "osmo-hnodeb" [ 268s] #define VERSION "UNKNOWN" [ 268s] #define STDC_HEADERS 1 [ 268s] #define HAVE_SYS_TYPES_H 1 [ 268s] #define HAVE_SYS_STAT_H 1 [ 268s] #define HAVE_STDLIB_H 1 [ 268s] #define HAVE_STRING_H 1 [ 268s] #define HAVE_MEMORY_H 1 [ 268s] #define HAVE_STRINGS_H 1 [ 268s] #define HAVE_INTTYPES_H 1 [ 268s] #define HAVE_STDINT_H 1 [ 268s] #define HAVE_UNISTD_H 1 [ 268s] #define HAVE_DLFCN_H 1 [ 268s] #define LT_OBJDIR ".libs/" [ 268s] [ 268s] configure: exit 1 [ 268s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 268s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 268s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 268s] make: *** [debian/rules:45: build] Error 2 [ 268s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 268s] ### VM INTERACTION START ### [ 272s] [ 256.573041] sysrq: Power Off [ 272s] [ 256.577788] reboot: Power down [ 272s] ### VM INTERACTION END ### [ 272s] [ 272s] lamb22 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:45:25 UTC 2021. [ 272s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:47:32 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:47:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <6180fb2d1b380_4be72abbd99885e0246664@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 278s] #define PACKAGE_URL "" [ 278s] #define PACKAGE "osmo-hnodeb" [ 278s] #define VERSION "UNKNOWN" [ 278s] #define STDC_HEADERS 1 [ 278s] #define HAVE_SYS_TYPES_H 1 [ 278s] #define HAVE_SYS_STAT_H 1 [ 278s] #define HAVE_STDLIB_H 1 [ 278s] #define HAVE_STRING_H 1 [ 278s] #define HAVE_MEMORY_H 1 [ 278s] #define HAVE_STRINGS_H 1 [ 278s] #define HAVE_INTTYPES_H 1 [ 278s] #define HAVE_STDINT_H 1 [ 278s] #define HAVE_UNISTD_H 1 [ 278s] #define HAVE_DLFCN_H 1 [ 278s] #define LT_OBJDIR ".libs/" [ 278s] [ 278s] configure: exit 1 [ 278s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 278s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 278s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 278s] make: *** [debian/rules:45: build] Error 2 [ 278s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 278s] ### VM INTERACTION START ### [ 279s] Powering off. [ 279s] [ 265.869798] reboot: Power down [ 279s] ### VM INTERACTION END ### [ 279s] [ 279s] sheep86 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:47:15 UTC 2021. [ 279s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:48:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:48:23 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <6180fb6bd838d_4be72abbd99885e02467db@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 249s] #define PACKAGE_URL "" [ 249s] #define PACKAGE "osmo-hnodeb" [ 249s] #define VERSION "UNKNOWN" [ 249s] #define STDC_HEADERS 1 [ 249s] #define HAVE_SYS_TYPES_H 1 [ 249s] #define HAVE_SYS_STAT_H 1 [ 249s] #define HAVE_STDLIB_H 1 [ 249s] #define HAVE_STRING_H 1 [ 249s] #define HAVE_MEMORY_H 1 [ 249s] #define HAVE_STRINGS_H 1 [ 249s] #define HAVE_INTTYPES_H 1 [ 249s] #define HAVE_STDINT_H 1 [ 249s] #define HAVE_UNISTD_H 1 [ 249s] #define HAVE_DLFCN_H 1 [ 249s] #define LT_OBJDIR ".libs/" [ 249s] [ 249s] configure: exit 1 [ 249s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 249s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 249s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 249s] make: *** [debian/rules:45: build] Error 2 [ 249s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 249s] ### VM INTERACTION START ### [ 252s] [ 241.888747] sysrq: Power Off [ 252s] [ 241.896290] reboot: Power down [ 252s] ### VM INTERACTION END ### [ 252s] [ 252s] sheep83 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:48:09 UTC 2021. [ 252s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:48:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:48:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <6180fb86442f6_4be72abbd99885e0246928@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 391s] intention of the Shared Library Policy is to allow parallel installation of [ 391s] multiple versions of the same shared library, hard dependencies likely make [ 391s] that impossible. Please remove this dependency and instead move it to the [ 391s] runtime uses of your library. [ 391s] [ 391s] osmo-iuh.aarch64: W: suse-missing-rclink osmo-hnbgw [ 391s] The package contains an init script or systemd service file but lacks the [ 391s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 391s] [ 391s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 391s] libosmo-rua0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 391s] This package contains a library and provides no %post scriptlet containing a [ 391s] call to ldconfig. [ 391s] [ 391s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 391s] libosmo-rua0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 391s] This package contains a library and provides no %postun scriptlet containing a [ 391s] call to ldconfig. [ 391s] [ 391s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 391s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 391s] [ 391s] ### VM INTERACTION START ### [ 395s] [ 380.851192] sysrq: SysRq : Power Off [ 395s] [ 380.902868] reboot: Power down [ 395s] ### VM INTERACTION END ### [ 395s] [ 395s] obs-arm-8 failed "build osmo-iuh.spec" at Tue Nov 2 08:48:42 UTC 2021. [ 395s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:50:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:50:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6180fbc5d52dc_4be72abbd99885e02470f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 388s] #define PACKAGE_URL "" [ 388s] #define PACKAGE "osmo-hnodeb" [ 388s] #define VERSION "UNKNOWN" [ 388s] #define STDC_HEADERS 1 [ 388s] #define HAVE_SYS_TYPES_H 1 [ 388s] #define HAVE_SYS_STAT_H 1 [ 388s] #define HAVE_STDLIB_H 1 [ 388s] #define HAVE_STRING_H 1 [ 388s] #define HAVE_MEMORY_H 1 [ 388s] #define HAVE_STRINGS_H 1 [ 388s] #define HAVE_INTTYPES_H 1 [ 388s] #define HAVE_STDINT_H 1 [ 388s] #define HAVE_UNISTD_H 1 [ 388s] #define HAVE_DLFCN_H 1 [ 388s] #define LT_OBJDIR ".libs/" [ 388s] [ 388s] configure: exit 1 [ 388s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 388s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 388s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 388s] make: *** [debian/rules:45: build] Error 2 [ 388s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 388s] ### VM INTERACTION START ### [ 389s] Powering off. [ 389s] [ 372.609016] reboot: Power down [ 389s] ### VM INTERACTION END ### [ 389s] [ 389s] lamb23 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:49:48 UTC 2021. [ 389s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:50:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:50:56 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_10/aarch64 In-Reply-To: References: Message-ID: <6180fc01416b9_4be72abbd99885e02471d1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_10/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 378s] #define PACKAGE_URL "" [ 378s] #define PACKAGE "osmo-hnodeb" [ 378s] #define VERSION "UNKNOWN" [ 378s] #define STDC_HEADERS 1 [ 378s] #define HAVE_SYS_TYPES_H 1 [ 378s] #define HAVE_SYS_STAT_H 1 [ 378s] #define HAVE_STDLIB_H 1 [ 378s] #define HAVE_STRING_H 1 [ 378s] #define HAVE_MEMORY_H 1 [ 378s] #define HAVE_STRINGS_H 1 [ 378s] #define HAVE_INTTYPES_H 1 [ 378s] #define HAVE_STDINT_H 1 [ 378s] #define HAVE_UNISTD_H 1 [ 378s] #define HAVE_DLFCN_H 1 [ 378s] #define LT_OBJDIR ".libs/" [ 378s] [ 378s] configure: exit 1 [ 378s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 378s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 378s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 378s] make: *** [debian/rules:45: build] Error 2 [ 378s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 378s] ### VM INTERACTION START ### [ 381s] [ 358.273278] sysrq: Power Off [ 381s] [ 358.381045] reboot: Power down [ 381s] ### VM INTERACTION END ### [ 381s] [ 381s] obs-arm-9 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:50:51 UTC 2021. [ 381s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:52:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:52:55 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <6180fc7923779_4be72abbd99885e02472f5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_21.10/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 406s] #define PACKAGE_URL "" [ 406s] #define PACKAGE "osmo-hnodeb" [ 406s] #define VERSION "UNKNOWN" [ 406s] #define STDC_HEADERS 1 [ 406s] #define HAVE_SYS_TYPES_H 1 [ 406s] #define HAVE_SYS_STAT_H 1 [ 406s] #define HAVE_STDLIB_H 1 [ 406s] #define HAVE_STRING_H 1 [ 406s] #define HAVE_MEMORY_H 1 [ 406s] #define HAVE_STRINGS_H 1 [ 406s] #define HAVE_INTTYPES_H 1 [ 406s] #define HAVE_STDINT_H 1 [ 406s] #define HAVE_UNISTD_H 1 [ 406s] #define HAVE_DLFCN_H 1 [ 406s] #define LT_OBJDIR ".libs/" [ 406s] [ 406s] configure: exit 1 [ 406s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 406s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 406s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 406s] make: *** [debian/rules:45: build] Error 2 [ 406s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 406s] ### VM INTERACTION START ### [ 407s] Powering off. [ 407s] [ 391.106670] reboot: Power down [ 407s] ### VM INTERACTION END ### [ 407s] [ 407s] lamb02 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:52:38 UTC 2021. [ 407s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:53:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:53:46 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_11/aarch64 In-Reply-To: References: Message-ID: <6180fcb3ccb87_4be72abbd99885e0247418@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_11/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 238s] #define PACKAGE_URL "" [ 238s] #define PACKAGE "osmo-hnodeb" [ 238s] #define VERSION "UNKNOWN" [ 238s] #define STDC_HEADERS 1 [ 238s] #define HAVE_SYS_TYPES_H 1 [ 238s] #define HAVE_SYS_STAT_H 1 [ 238s] #define HAVE_STDLIB_H 1 [ 238s] #define HAVE_STRING_H 1 [ 238s] #define HAVE_MEMORY_H 1 [ 238s] #define HAVE_STRINGS_H 1 [ 238s] #define HAVE_INTTYPES_H 1 [ 238s] #define HAVE_STDINT_H 1 [ 238s] #define HAVE_UNISTD_H 1 [ 238s] #define HAVE_DLFCN_H 1 [ 238s] #define LT_OBJDIR ".libs/" [ 238s] [ 238s] configure: exit 1 [ 238s] dh_auto_configure: error: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 238s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 238s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 238s] make: *** [debian/rules:45: build] Error 2 [ 238s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 238s] ### VM INTERACTION START ### [ 239s] Powering off. [ 239s] [ 222.436826] reboot: Power down [ 239s] ### VM INTERACTION END ### [ 239s] [ 239s] obs-arm-10 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:53:29 UTC 2021. [ 239s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:53:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:53:46 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_11/x86_64 In-Reply-To: References: Message-ID: <6180fcb428137_4be72abbd99885e02475b3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_11/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 385s] #define PACKAGE_URL "" [ 385s] #define PACKAGE "osmo-hnodeb" [ 385s] #define VERSION "UNKNOWN" [ 385s] #define STDC_HEADERS 1 [ 385s] #define HAVE_SYS_TYPES_H 1 [ 385s] #define HAVE_SYS_STAT_H 1 [ 385s] #define HAVE_STDLIB_H 1 [ 385s] #define HAVE_STRING_H 1 [ 385s] #define HAVE_MEMORY_H 1 [ 385s] #define HAVE_STRINGS_H 1 [ 385s] #define HAVE_INTTYPES_H 1 [ 385s] #define HAVE_STDINT_H 1 [ 385s] #define HAVE_UNISTD_H 1 [ 385s] #define HAVE_DLFCN_H 1 [ 385s] #define LT_OBJDIR ".libs/" [ 385s] [ 385s] configure: exit 1 [ 385s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 385s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 385s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 385s] make: *** [debian/rules:45: build] Error 2 [ 385s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 385s] ### VM INTERACTION START ### [ 386s] Powering off. [ 386s] [ 368.907906] reboot: Power down [ 386s] ### VM INTERACTION END ### [ 386s] [ 386s] lamb62 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:53:31 UTC 2021. [ 386s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:55:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:55:11 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_11/i586 In-Reply-To: References: Message-ID: <6180fd0d2223f_4be72abbd99885e0248234@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_11/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 501s] #define PACKAGE_URL "" [ 501s] #define PACKAGE "osmo-hnodeb" [ 501s] #define VERSION "UNKNOWN" [ 501s] #define STDC_HEADERS 1 [ 501s] #define HAVE_SYS_TYPES_H 1 [ 501s] #define HAVE_SYS_STAT_H 1 [ 501s] #define HAVE_STDLIB_H 1 [ 501s] #define HAVE_STRING_H 1 [ 501s] #define HAVE_MEMORY_H 1 [ 501s] #define HAVE_STRINGS_H 1 [ 501s] #define HAVE_INTTYPES_H 1 [ 501s] #define HAVE_STDINT_H 1 [ 501s] #define HAVE_UNISTD_H 1 [ 501s] #define HAVE_DLFCN_H 1 [ 501s] #define LT_OBJDIR ".libs/" [ 501s] [ 501s] configure: exit 1 [ 501s] dh_auto_configure: error: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 501s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 501s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 501s] make: *** [debian/rules:45: build] Error 2 [ 501s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 501s] ### VM INTERACTION START ### [ 502s] Powering off. [ 502s] [ 484.456636] reboot: Power down [ 502s] ### VM INTERACTION END ### [ 502s] [ 502s] lamb02 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 08:55:02 UTC 2021. [ 502s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 08:55:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 08:55:45 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <6180fd2da01e7_4be72abbd99885e024849d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Raspbian_10/armv7l Package network:osmocom:nightly/simtrace2 failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 192s] 336 0 0 336 150 obj/simtrace/dfu_board_lowlevel.o [ 192s] 1230 0 1033 2263 8d7 obj/simtrace/dfu_uart_console.o [ 192s] 624 184 0 808 328 obj/simtrace/dfu_led.o [ 192s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 192s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 192s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 192s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 192s] 929 0 1 930 3a2 obj/simtrace/dfu_main.o [ 192s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 192s] 640 104 72 816 330 obj/simtrace/dfu_dfu_desc.o [ 192s] 1045 24 532 1601 641 obj/simtrace/dfu_dfu_driver.o [ 192s] 13032 0 11440 24472 5f98 bin/simtrace-dfu-dfu.elf [ 192s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 192s] make -C firmware BOARD=simtrace APP=blupdate [ 192s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 192s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 192s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 192s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 192s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 192s] dh_auto_build: make -j1 returned exit code 2 [ 192s] make: *** [debian/rules:16: build] Error 2 [ 192s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 192s] ### VM INTERACTION START ### [ 195s] [ 170.778431] sysrq: SysRq : Power Off [ 195s] [ 170.789656] reboot: Power down [ 196s] ### VM INTERACTION END ### [ 196s] [ 196s] armbuild02 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 08:55:30 UTC 2021. [ 196s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:01:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:01:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <6180fe95d5441_4be72abbd99885e024924f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 83s] checking for gcc option to produce PIC... -fPIC -DPIC [ 83s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 83s] checking if gcc static flag -static works... no [ 83s] checking if gcc supports -c -o file.o... yes [ 83s] checking if gcc supports -c -o file.o... (cached) yes [ 83s] checking whether the gcc linker (/usr/armv7hl-suse-linux-gnueabi/bin/ld) supports shared libraries... yes [ 84s] checking whether -lc should be explicitly linked in... no [ 84s] checking dynamic linker characteristics... GNU/Linux ld.so [ 84s] checking how to hardcode library paths into programs... immediate [ 84s] checking whether stripping libraries is possible... yes [ 84s] checking if libtool supports shared libraries... yes [ 84s] checking whether to build shared libraries... yes [ 84s] checking whether to build static libraries... yes [ 84s] checking for pkg-config... /usr/bin/pkg-config [ 84s] checking for armv7hl-suse-linux-gnueabi-pkg-config... /usr/bin/armv7hl-suse-linux-gnueabi-pkg-config [ 84s] checking pkg-config is at least version 0.20... yes [ 84s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 84s] error: Bad exit status from /var/tmp/rpm-tmp.WgMYYv (%build) [ 84s] [ 84s] [ 84s] RPM build errors: [ 84s] Bad exit status from /var/tmp/rpm-tmp.WgMYYv (%build) [ 84s] ### VM INTERACTION START ### [ 87s] [ 72.656196] sysrq: SysRq : Power Off [ 87s] [ 72.657765] reboot: Power down [ 88s] ### VM INTERACTION END ### [ 88s] [ 88s] armbuild24 failed "build osmo-hnodeb.spec" at Tue Nov 2 09:01:30 UTC 2021. [ 88s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:04:32 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:04:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <6180ff2cd7253_4be72abbd99885e024947@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 142s] #define VERSION "UNKNOWN" [ 142s] #define STDC_HEADERS 1 [ 142s] #define HAVE_SYS_TYPES_H 1 [ 142s] #define HAVE_SYS_STAT_H 1 [ 142s] #define HAVE_STDLIB_H 1 [ 142s] #define HAVE_STRING_H 1 [ 142s] #define HAVE_MEMORY_H 1 [ 142s] #define HAVE_STRINGS_H 1 [ 142s] #define HAVE_INTTYPES_H 1 [ 142s] #define HAVE_STDINT_H 1 [ 142s] #define HAVE_UNISTD_H 1 [ 142s] #define HAVE_DLFCN_H 1 [ 142s] #define LT_OBJDIR ".libs/" [ 142s] [ 142s] configure: exit 1 [ 142s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=${prefix}/lib/aarch64-linux-gnu --libexecdir=${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 142s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 142s] make[1]: *** [override_dh_auto_configure] Error 2 [ 142s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 142s] debian/rules:45: recipe for target 'build' failed [ 142s] make: *** [build] Error 2 [ 142s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 142s] ### VM INTERACTION START ### [ 145s] [ 130.082337] sysrq: Power Off [ 145s] [ 130.083007] reboot: Power down [ 145s] ### VM INTERACTION END ### [ 145s] [ 145s] obs-arm-10 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 09:04:15 UTC 2021. [ 145s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:23:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:23:31 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <6181039d8e8fd_4be72abbd99885e0251515@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 1316s] intention of the Shared Library Policy is to allow parallel installation of [ 1316s] multiple versions of the same shared library, hard dependencies likely make [ 1316s] that impossible. Please remove this dependency and instead move it to the [ 1316s] runtime uses of your library. [ 1316s] [ 1316s] osmo-iuh.armv7hl: W: suse-missing-rclink osmo-hnbgw [ 1316s] The package contains an init script or systemd service file but lacks the [ 1316s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 1316s] [ 1316s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 1316s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 1316s] This package contains a library and provides no %post scriptlet containing a [ 1316s] call to ldconfig. [ 1316s] [ 1316s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 1316s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 1316s] This package contains a library and provides no %postun scriptlet containing a [ 1316s] call to ldconfig. [ 1316s] [ 1316s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 1316s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 1316s] [ 1316s] ### VM INTERACTION START ### [ 1319s] [ 1299.864149] sysrq: SysRq : Power Off [ 1319s] [ 1299.866660] reboot: Power down [ 1320s] ### VM INTERACTION END ### [ 1320s] [ 1320s] armbuild01 failed "build osmo-iuh.spec" at Tue Nov 2 09:23:18 UTC 2021. [ 1320s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:38:15 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:38:15 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181071f66ad0_4be72abbd99885e0255739@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 277s] # we create a symlink at ./srcfile.adoc pointing at [ 277s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 277s] # is like basename from coreutils, and . is WD. [ 277s] if ! [ -f test-usermanual.adoc ]; then \ [ 277s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 277s] fi [ 277s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 277s] # in ... [ 277s] TEXINPUTS=".." \ [ 277s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 277s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 277s] a2x: resource files: [] [ 277s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 277s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 277s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 277s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 277s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 277s] make[1]: *** [Makefile:363: all] Error 2 [ 277s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 277s] dh_auto_build: error: make -j1 returned exit code 2 [ 277s] make: *** [debian/rules:5: binary] Error 25 [ 277s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 277s] ### VM INTERACTION START ### [ 278s] Powering off. [ 278s] [ 262.959258] reboot: Power down [ 278s] ### VM INTERACTION END ### [ 278s] [ 278s] sheep85 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Tue Nov 2 09:38:02 UTC 2021. [ 278s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 09:42:32 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 2 Nov 2021 09:42:32 +0000 Subject: Change in simtrace2[master]: firmware: add missing usb strings to blupdate that prevented building it References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26059 ) Change subject: firmware: add missing usb strings to blupdate that prevented building it ...................................................................... firmware: add missing usb strings to blupdate that prevented building it Change-Id: I8d0d9bf98748d475427d9b0c78f2e0532ee4bca1 --- A firmware/apps/blupdate/usb_strings.txt 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/59/26059/1 diff --git a/firmware/apps/blupdate/usb_strings.txt b/firmware/apps/blupdate/usb_strings.txt new file mode 100644 index 0000000..f652071 --- /dev/null +++ b/firmware/apps/blupdate/usb_strings.txt @@ -0,0 +1,6 @@ +sysmocom - s.f.m.c. GmbH +PRODUCT_STRING +bootloader updater +RAM +Flash (Application Partition) +Flash (Bootloader Partition) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I8d0d9bf98748d475427d9b0c78f2e0532ee4bca1 Gerrit-Change-Number: 26059 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 09:41:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:41:39 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181080e9890d_4be72abbd99885e0261679@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 487s] # we create a symlink at ./srcfile.adoc pointing at [ 487s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 487s] # is like basename from coreutils, and . is WD. [ 487s] if ! [ -f test-usermanual.adoc ]; then \ [ 487s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 487s] fi [ 487s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 487s] # in ... [ 487s] TEXINPUTS=".." \ [ 487s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 487s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 487s] a2x: resource files: [] [ 487s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 487s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 487s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 488s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 488s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 488s] make[1]: *** [Makefile:363: all] Error 2 [ 488s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 488s] dh_auto_build: error: make -j1 returned exit code 2 [ 488s] make: *** [debian/rules:5: binary] Error 25 [ 488s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 488s] ### VM INTERACTION START ### [ 489s] Powering off. [ 489s] [ 467.610328] reboot: Power down [ 489s] ### VM INTERACTION END ### [ 489s] [ 489s] lamb01 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111020822.dsc" at Tue Nov 2 09:41:32 UTC 2021. [ 489s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:41:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:41:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181080f17bee_4be72abbd99885e026185c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 203s] # is like basename from coreutils, and . is WD. [ 203s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 203s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 203s] fi [ 203s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 203s] # in /usr/share/osmo-gsm-manuals. [ 203s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 203s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 203s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 203s] a2x: resource files: [] [ 203s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 203s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 203s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 203s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 203s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 203s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 203s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 203s] make[1]: *** [Makefile:377: all] Error 2 [ 203s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 203s] dh_auto_build: error: make -j1 returned exit code 2 [ 203s] make: *** [debian/rules:45: build] Error 25 [ 203s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 203s] ### VM INTERACTION START ### [ 204s] Powering off. [ 204s] [ 193.271012] reboot: Power down [ 204s] ### VM INTERACTION END ### [ 204s] [ 204s] goat11 failed "build osmo-gbproxy_0.1.2.dsc" at Tue Nov 2 09:41:41 UTC 2021. [ 204s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:41:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:41:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181080f55a36_4be72abbd99885e0261929@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 208s] # is like basename from coreutils, and . is WD. [ 208s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 208s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 208s] fi [ 208s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 208s] # in /usr/share/osmo-gsm-manuals. [ 208s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 208s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 208s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 208s] a2x: resource files: [] [ 208s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 208s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 208s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 208s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 208s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 208s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 208s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 208s] make[1]: *** [Makefile:368: all] Error 2 [ 208s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 208s] dh_auto_build: error: make -j1 returned exit code 2 [ 208s] make: *** [debian/rules:45: build] Error 25 [ 208s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 208s] ### VM INTERACTION START ### [ 210s] Powering off. [ 210s] [ 198.459313] reboot: Power down [ 210s] ### VM INTERACTION END ### [ 210s] [ 210s] goat05 failed "build osmo-cbc_0.2.2.dsc" at Tue Nov 2 09:41:47 UTC 2021. [ 210s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:41:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:41:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181080f8d4e5_4be72abbd99885e02620d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 207s] # is like basename from coreutils, and . is WD. [ 207s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 207s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 207s] fi [ 207s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 207s] # in /usr/share/osmo-gsm-manuals. [ 207s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 207s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 207s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 207s] a2x: resource files: [] [ 207s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 207s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 207s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 207s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 207s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 207s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 207s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 207s] make[1]: *** [Makefile:327: all] Error 2 [ 207s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 207s] dh_auto_build: error: make -j1 returned exit code 2 [ 207s] make: *** [debian/rules:12: build] Error 25 [ 207s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 207s] ### VM INTERACTION START ### [ 208s] Powering off. [ 208s] [ 197.437563] reboot: Power down [ 208s] ### VM INTERACTION END ### [ 208s] [ 208s] goat05 failed "build osmo-sip-connector_1.5.1.dsc" at Tue Nov 2 09:41:51 UTC 2021. [ 208s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:42:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:42:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810810421b4_4be72abbd99885e02621c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 239s] # we create a symlink at ./srcfile.adoc pointing at [ 239s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 239s] # is like basename from coreutils, and . is WD. [ 239s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 239s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 239s] fi [ 239s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 239s] # in /usr/share/osmo-gsm-manuals. [ 239s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 239s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 239s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 239s] a2x: resource files: [] [ 239s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 239s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 239s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 239s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 239s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 239s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 239s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 239s] dh_auto_build: error: make -j1 returned exit code 2 [ 239s] make: *** [debian/rules:12: build] Error 25 [ 239s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 239s] ### VM INTERACTION START ### [ 240s] Powering off. [ 240s] [ 230.400429] reboot: Power down [ 241s] ### VM INTERACTION END ### [ 241s] [ 241s] goat07 failed "build osmo-pcu_0.9.1.dsc" at Tue Nov 2 09:42:18 UTC 2021. [ 241s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:43:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:43:38 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181084f28507_4be72abbd99885e02624ba@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 305s] # is like basename from coreutils, and . is WD. [ 305s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 305s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 305s] fi [ 305s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 305s] # in /usr/share/osmo-gsm-manuals. [ 305s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 305s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 305s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 305s] a2x: resource files: [] [ 305s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 305s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 305s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 305s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 305s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 305s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 305s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 305s] make[1]: *** [Makefile:452: all] Error 2 [ 305s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 305s] dh_auto_build: error: make -j1 returned exit code 2 [ 305s] make: *** [debian/rules:6: build] Error 25 [ 305s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 305s] ### VM INTERACTION START ### [ 306s] Powering off. [ 306s] [ 294.847175] reboot: Power down [ 306s] ### VM INTERACTION END ### [ 306s] [ 306s] goat15 failed "build osmo-trx_1.3.1.dsc" at Tue Nov 2 09:43:31 UTC 2021. [ 306s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:44:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:44:29 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810887d4f44_4be72abbd99885e02628fe@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 366s] # is like basename from coreutils, and . is WD. [ 366s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 366s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 366s] fi [ 366s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 366s] # in /usr/share/osmo-gsm-manuals. [ 366s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 366s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 366s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 366s] a2x: resource files: [] [ 366s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 366s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 366s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 367s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 367s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 367s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 367s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 367s] make[1]: *** [Makefile:392: all] Error 2 [ 367s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 367s] dh_auto_build: error: make -j1 returned exit code 2 [ 367s] make: *** [debian/rules:15: build] Error 25 [ 367s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 367s] ### VM INTERACTION START ### [ 368s] Powering off. [ 368s] [ 350.071402] reboot: Power down [ 368s] ### VM INTERACTION END ### [ 368s] [ 368s] old-atreju2 failed "build osmo-ggsn_1.7.1.dsc" at Tue Nov 2 09:44:26 UTC 2021. [ 368s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:45:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:45:37 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181098c4b87d_4be72abbd99885e02660e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 419s] # is like basename from coreutils, and . is WD. [ 419s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 419s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 419s] fi [ 419s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 419s] # in /usr/share/osmo-gsm-manuals. [ 419s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 419s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 419s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 419s] a2x: resource files: [] [ 419s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 419s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 419s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 419s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 419s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 419s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 419s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 419s] make[1]: *** [Makefile:410: all] Error 2 [ 419s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 419s] dh_auto_build: error: make -j1 returned exit code 2 [ 419s] make: *** [debian/rules:7: build] Error 25 [ 419s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 419s] ### VM INTERACTION START ### [ 420s] Powering off. [ 420s] [ 400.846459] reboot: Power down [ 420s] ### VM INTERACTION END ### [ 420s] [ 420s] lamb19 failed "build osmo-hlr_1.3.1.dsc" at Tue Nov 2 09:45:25 UTC 2021. [ 420s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:46:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:46:28 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181098f2668c_4be72abbd99885e026636e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 469s] # is like basename from coreutils, and . is WD. [ 469s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 469s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 469s] fi [ 469s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 469s] # in /usr/share/osmo-gsm-manuals. [ 469s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 469s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 469s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 469s] a2x: resource files: [] [ 469s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 469s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 469s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 469s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 469s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 469s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 469s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 469s] make[1]: *** [Makefile:403: all] Error 2 [ 469s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 469s] dh_auto_build: error: make -j1 returned exit code 2 [ 469s] make: *** [debian/rules:12: build] Error 25 [ 469s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 469s] ### VM INTERACTION START ### [ 471s] Powering off. [ 471s] [ 449.991731] reboot: Power down [ 471s] ### VM INTERACTION END ### [ 471s] [ 471s] lamb14 failed "build libosmo-sccp_1.4.0.dsc" at Tue Nov 2 09:46:13 UTC 2021. [ 471s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:46:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:46:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181098fbd11f_4be72abbd99885e0266651@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 480s] # is like basename from coreutils, and . is WD. [ 480s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 480s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 480s] fi [ 480s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 480s] # in /usr/share/osmo-gsm-manuals. [ 480s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 480s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 480s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 480s] a2x: resource files: [] [ 480s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 480s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 480s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 480s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 480s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 480s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 480s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 480s] make[1]: *** [Makefile:371: all] Error 2 [ 480s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 480s] dh_auto_build: error: make -j1 returned exit code 2 [ 480s] make: *** [debian/rules:12: build] Error 25 [ 480s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 480s] ### VM INTERACTION START ### [ 481s] Powering off. [ 481s] [ 455.709129] reboot: Power down [ 481s] ### VM INTERACTION END ### [ 481s] [ 481s] lamb59 failed "build osmo-bts_1.3.3.dsc" at Tue Nov 2 09:46:30 UTC 2021. [ 481s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:47:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:47:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181099113fd1_4be72abbd99885e02668f6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 521s] # is like basename from coreutils, and . is WD. [ 521s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 521s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 521s] fi [ 521s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 521s] # in /usr/share/osmo-gsm-manuals. [ 521s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 521s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 521s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 521s] a2x: resource files: [] [ 521s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 521s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 521s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 521s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 521s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 521s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 521s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 521s] make[1]: *** [Makefile:387: all] Error 2 [ 521s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 521s] dh_auto_build: error: make -j1 returned exit code 2 [ 521s] make: *** [debian/rules:12: build] Error 25 [ 521s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 521s] ### VM INTERACTION START ### [ 522s] Powering off. [ 522s] [ 502.580505] reboot: Power down [ 522s] ### VM INTERACTION END ### [ 522s] [ 522s] lamb21 failed "build osmo-remsim_0.2.4.dsc" at Tue Nov 2 09:47:12 UTC 2021. [ 522s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:51:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:51:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810a2be5f2f_4be72abbd99885e0269177@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 279s] # is like basename from coreutils, and . is WD. [ 279s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 279s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 279s] fi [ 279s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 279s] # in /usr/share/osmo-gsm-manuals. [ 279s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 279s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 279s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 279s] a2x: resource files: [] [ 279s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 279s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 279s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 279s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 279s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 279s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 279s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 279s] make[1]: *** [Makefile:377: all] Error 2 [ 279s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 279s] dh_auto_build: error: make -j1 returned exit code 2 [ 279s] make: *** [debian/rules:45: build] Error 25 [ 279s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 279s] ### VM INTERACTION START ### [ 280s] Powering off. [ 280s] [ 265.209497] reboot: Power down [ 280s] ### VM INTERACTION END ### [ 280s] [ 280s] sheep86 failed "build osmo-smlc_0.2.0.dsc" at Tue Nov 2 09:51:11 UTC 2021. [ 280s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:54:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:54:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810ae2a93d3_4be72abbd99885e0273350@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 937s] # is like basename from coreutils, and . is WD. [ 937s] if ! [ -f osmomgw-usermanual.adoc ]; then \ [ 937s] ln -s osmomgw-usermanual.adoc osmomgw-usermanual.adoc; \ [ 937s] fi [ 937s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 937s] # in /usr/share/osmo-gsm-manuals. [ 937s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 937s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomgw-usermanual.adoc [ 938s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 938s] a2x: resource files: [] [ 938s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 938s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 938s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 938s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 938s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 938s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 938s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 938s] make[1]: *** [Makefile:423: all] Error 2 [ 938s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 938s] dh_auto_build: error: make -j1 returned exit code 2 [ 938s] make: *** [debian/rules:17: build] Error 25 [ 938s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 938s] ### VM INTERACTION START ### [ 939s] Powering off. [ 939s] [ 863.127076] reboot: Power down [ 939s] ### VM INTERACTION END ### [ 939s] [ 939s] lamb04 failed "build osmo-mgw_1.8.1.dsc" at Tue Nov 2 09:54:07 UTC 2021. [ 939s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 09:55:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 09:55:07 +0000 Subject: Change in simtrace2[master]: firmware: add missing usb strings to blupdate that prevented building it In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26059 ) Change subject: firmware: add missing usb strings to blupdate that prevented building it ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I8d0d9bf98748d475427d9b0c78f2e0532ee4bca1 Gerrit-Change-Number: 26059 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Nov 2021 09:55:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 09:55:32 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:55:32 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810b208bdfe_4be72abbd99885e0273523@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 532s] # is like basename from coreutils, and . is WD. [ 532s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 532s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 532s] fi [ 532s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 532s] # in /usr/share/osmo-gsm-manuals. [ 532s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 532s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 532s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 532s] a2x: resource files: [] [ 532s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 532s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 532s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 532s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 532s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 532s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 532s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 532s] make[1]: *** [Makefile:391: all] Error 2 [ 532s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 532s] dh_auto_build: error: make -j1 returned exit code 2 [ 532s] make: *** [debian/rules:9: build] Error 25 [ 532s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 532s] ### VM INTERACTION START ### [ 533s] Powering off. [ 533s] [ 518.640535] reboot: Power down [ 533s] ### VM INTERACTION END ### [ 533s] [ 533s] sheep81 failed "build osmo-iuh_1.0.0.dsc" at Tue Nov 2 09:55:30 UTC 2021. [ 533s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:59:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:59:13 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810c0e17e82_4be72abbd99885e02743f6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 271s] # is like basename from coreutils, and . is WD. [ 271s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 271s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 271s] fi [ 271s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 271s] # in /usr/share/osmo-gsm-manuals. [ 271s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 271s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 271s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 271s] a2x: resource files: [] [ 271s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 271s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 271s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 271s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 271s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 271s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 271s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 271s] make[1]: *** [Makefile:388: all] Error 2 [ 271s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 271s] dh_auto_build: error: make -j1 returned exit code 2 [ 271s] make: *** [debian/rules:45: build] Error 25 [ 271s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 271s] ### VM INTERACTION START ### [ 272s] Powering off. [ 272s] [ 258.616763] reboot: Power down [ 272s] ### VM INTERACTION END ### [ 272s] [ 272s] hci-cnode1-e5 failed "build osmo-bsc_1.7.2.dsc" at Tue Nov 2 09:58:57 UTC 2021. [ 272s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 09:59:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 09:59:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810c0f7d732_4be72abbd99885e0274470@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 217s] # is like basename from coreutils, and . is WD. [ 217s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 217s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 217s] fi [ 217s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 217s] # in /usr/share/osmo-gsm-manuals. [ 217s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 217s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 217s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 217s] a2x: resource files: [] [ 217s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 217s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 217s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 217s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 217s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 217s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 217s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 217s] make[1]: *** [Makefile:402: all] Error 2 [ 217s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 217s] dh_auto_build: error: make -j1 returned exit code 2 [ 217s] make: *** [debian/rules:45: build] Error 25 [ 217s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 217s] ### VM INTERACTION START ### [ 219s] Powering off. [ 219s] [ 207.528771] reboot: Power down [ 219s] ### VM INTERACTION END ### [ 219s] [ 219s] goat07 failed "build osmo-msc_1.7.1.dsc" at Tue Nov 2 09:59:21 UTC 2021. [ 219s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 10:02:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 10:02:37 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61810cc07c875_4be72abbd99885e0275232@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 396s] # is like basename from coreutils, and . is WD. [ 396s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 396s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 396s] fi [ 396s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 396s] # in /usr/share/osmo-gsm-manuals. [ 396s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 396s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 396s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 396s] a2x: resource files: [] [ 396s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 396s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 396s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 396s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 396s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 396s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 396s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 396s] make[1]: *** [Makefile:394: all] Error 2 [ 396s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 396s] dh_auto_build: error: make -j1 returned exit code 2 [ 396s] make: *** [debian/rules:45: build] Error 25 [ 396s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 396s] ### VM INTERACTION START ### [ 397s] Powering off. [ 397s] [ 378.976554] reboot: Power down [ 397s] ### VM INTERACTION END ### [ 397s] [ 397s] lamb13 failed "build osmo-sgsn_1.7.1.dsc" at Tue Nov 2 10:02:30 UTC 2021. [ 397s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 10:30:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 10:30:40 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <6181136e331fa_4be72abbd99885e0280422@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 504s] #define PACKAGE_URL "" [ 504s] #define PACKAGE "osmo-hnodeb" [ 504s] #define VERSION "UNKNOWN" [ 504s] #define STDC_HEADERS 1 [ 504s] #define HAVE_SYS_TYPES_H 1 [ 504s] #define HAVE_SYS_STAT_H 1 [ 504s] #define HAVE_STDLIB_H 1 [ 504s] #define HAVE_STRING_H 1 [ 504s] #define HAVE_MEMORY_H 1 [ 504s] #define HAVE_STRINGS_H 1 [ 504s] #define HAVE_INTTYPES_H 1 [ 504s] #define HAVE_STDINT_H 1 [ 504s] #define HAVE_UNISTD_H 1 [ 504s] #define HAVE_DLFCN_H 1 [ 504s] #define LT_OBJDIR ".libs/" [ 504s] [ 504s] configure: exit 1 [ 504s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 504s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 504s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 504s] make: *** [debian/rules:45: build] Error 2 [ 504s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 504s] ### VM INTERACTION START ### [ 506s] [ 484.094118] sysrq: SysRq : Power Off [ 506s] [ 484.096583] reboot: Power down [ 507s] ### VM INTERACTION END ### [ 507s] [ 507s] armbuild21 failed "build osmo-hnodeb_0.0.0.202111020822.dsc" at Tue Nov 2 10:30:21 UTC 2021. [ 507s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:35:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 10:35:33 +0000 Subject: Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 ) Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c at 958 PS4, Line 958: if (dtxu_used) { Am I wrong are are we using dtxu_used uninitialized under some circumstances? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2 Gerrit-Change-Number: 26047 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:35:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:39:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 10:39:11 +0000 Subject: Change in osmo-bts[master]: measurement: get rid of *le in lchan_meas_handle_sacch() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26051 ) Change subject: measurement: get rid of *le in lchan_meas_handle_sacch() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 Gerrit-Change-Number: 26051 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:40:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 10:40:34 +0000 Subject: Change in osmo-bts[master]: measurement: pass *mr to repeated_dl_facch_active_decision() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26048 ) Change subject: measurement: pass *mr to repeated_dl_facch_active_decision() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idbf5f95d632aa2270c49b351ad5561ca2182bf9a Gerrit-Change-Number: 26048 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:40:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:45:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 10:45:40 +0000 Subject: Change in osmo-bts[master]: measurement: pass *mr to lchan_bs_pwr_ctrl() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26049 ) Change subject: measurement: pass *mr to lchan_bs_pwr_ctrl() ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/measurement.c at 957 PS4, Line 957: if (mr && mr->meas_valid == 0) /* 0 = valid */ I've seen this clarification several times already: mr->meas_valid == 0) /* 0 = valid */ Please add a static inline boor meas_is_valid(mr); https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/power_control.c at 338 PS4, Line 338: if (ctrl_interval_skip_block(params, state)) not entirely relaed to this patch, but I just noticed that if we don'tn receive proper meas result, then we don't decrease the period counter, which is wrong imho. We should ideally keep decreasing it, and if it reaches 0 when meas is invalid, then keep it at 1 to make it trigger next time we recieve a MR. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937117cf26fb718d57920382f6972390ad498c51 Gerrit-Change-Number: 26049 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:50:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:50:01 +0000 Subject: Change in simtrace2[master]: firmware: add missing usb strings to blupdate that prevented building it In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26059 ) Change subject: firmware: add missing usb strings to blupdate that prevented building it ...................................................................... firmware: add missing usb strings to blupdate that prevented building it Change-Id: I8d0d9bf98748d475427d9b0c78f2e0532ee4bca1 --- A firmware/apps/blupdate/usb_strings.txt 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/firmware/apps/blupdate/usb_strings.txt b/firmware/apps/blupdate/usb_strings.txt new file mode 100644 index 0000000..f652071 --- /dev/null +++ b/firmware/apps/blupdate/usb_strings.txt @@ -0,0 +1,6 @@ +sysmocom - s.f.m.c. GmbH +PRODUCT_STRING +bootloader updater +RAM +Flash (Application Partition) +Flash (Bootloader Partition) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I8d0d9bf98748d475427d9b0c78f2e0532ee4bca1 Gerrit-Change-Number: 26059 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:52:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:52:49 +0000 Subject: Change in osmo-bsc[master]: control.adoc: improve description of command bts.N.send-new-system-in... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26003 ) Change subject: control.adoc: improve description of command bts.N.send-new-system-informations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I48bdb7fd991dac2d5112440c879d0ded5b726715 Gerrit-Change-Number: 26003 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:52:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:52:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:52:52 +0000 Subject: Change in osmo-bsc[master]: control.adoc: improve description of command bts.N.send-new-system-in... In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26003 ) Change subject: control.adoc: improve description of command bts.N.send-new-system-informations ...................................................................... control.adoc: improve description of command bts.N.send-new-system-informations Change-Id: I48bdb7fd991dac2d5112440c879d0ded5b726715 Related: SYS#5641 --- M doc/manuals/chapters/control.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/manuals/chapters/control.adoc b/doc/manuals/chapters/control.adoc index 2585126..c2d7a82 100644 --- a/doc/manuals/chapters/control.adoc +++ b/doc/manuals/chapters/control.adoc @@ -32,7 +32,7 @@ |bts.N.location-area-code|RW|No|""|Set/Get LAC (value between (0, 65535)). |bts.N.cell-identity|RW|No|""|Set/Get Cell Identity (value between (0, 65535)). |bts.N.apply-configuration|WO|No|Ignored|Restart BTS via OML. -|bts.N.send-new-system-informations|WO|No|Ignored|Regenerate System Information messages for given BTS. +|bts.N.send-new-system-informations|WO|No|Ignored|Regenerate and resend System Information messages for given BTS. |bts.N.channel-load|RO|No|",,"|See <> for details. |bts.N.oml-connection-state|RO|No|"connected", "disconnected", "degraded"|Indicate the status of OML connection of BTS. |bts.N.oml-uptime|RO|No||Return OML link uptime in seconds. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I48bdb7fd991dac2d5112440c879d0ded5b726715 Gerrit-Change-Number: 26003 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:52:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 10:52:54 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 2: (3 comments) Letting other decide on whether they accept the current proposal as it is now. https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h at 1439 PS1, Line 1439: CHAN_COUNTS2_N > A more usual naming would be '_CHAN_COUNTS2_NUM'. Ack https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h at 1448 PS1, Line 1448: typedef unsigned int chan_counts_t [CHAN_COUNTS1_N][CHAN_COUNTS2_N][_GSM_LCHAN_MAX]; > it'll be quite a bit of effort to change this. [?] I wouldn't call it a personal preference, it's having a way to pass a data structure in an easy way which is later easier to extend instead of having to pass a 3 dimensional array or a pointer to some 3dimensional array mapped memory. It also gets rid of typedefs for not simple types, which is what the linux kernel style guide states. https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/src/osmo-bsc/abis_rsl.c at 1961 PS1, Line 1961: chan_counts_t bts_counts; > well, we usually use 'struct foo' or 'enum foo', but this typedef (used to pinpoint the array sizes) [?] If you had struct chan_counts, none of this would be an issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:52:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:53:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:53:19 +0000 Subject: Change in osmo-bsc[master]: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25996 ) Change subject: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id97bc0d31a358db6221c385761773fb48670c921 Gerrit-Change-Number: 25996 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:53:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:53:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:53:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: execute test cases for BS power control on TRX1 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908 ) Change subject: BTS_Tests: execute test cases for BS power control on TRX1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied3e38986690850f0323d4db072cf59b6975587e Gerrit-Change-Number: 25908 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:53:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:54:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:54:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: execute test cases for BS power control on TRX1 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908 ) Change subject: BTS_Tests: execute test cases for BS power control on TRX1 ...................................................................... BTS_Tests: execute test cases for BS power control on TRX1 Otherwise they fail, because BS power control is normally not permitted on the BCCH carrier (unless it's in power saving mode). Change-Id: Ied3e38986690850f0323d4db072cf59b6975587e Related: SYS#4918 --- M bts/BTS_Tests.ttcn 1 file changed, 14 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 2e35ce9..7476a0c 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2673,26 +2673,28 @@ testcase TC_rsl_bs_pwr_static_ass() runs on test_CT { var ConnHdlr vc_conn; var ConnHdlrPars pars; + f_init(); - for (var integer tn := 1; tn <= 4; tn := tn+1) { - pars := valueof(t_Pars(t_RslChanNr_Bm(tn), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_rsl_bs_pwr_static_ass), pars, - pcu_comp := false, trxc_comp := true); - vc_conn.done; - } + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_rsl_bs_pwr_static_ass), pars, + pcu_comp := false, trxc_comp := true); + vc_conn.done; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } testcase TC_rsl_bs_pwr_static_power_control() runs on test_CT { var ConnHdlr vc_conn; var ConnHdlrPars pars; + f_init(); - for (var integer tn := 1; tn <= 4; tn := tn+1) { - pars := valueof(t_Pars(t_RslChanNr_Bm(tn), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_rsl_bs_pwr_static_power_control), pars, - pcu_comp := false, trxc_comp := true); - vc_conn.done; - } + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_rsl_bs_pwr_static_power_control), pars, + pcu_comp := false, trxc_comp := true); + vc_conn.done; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied3e38986690850f0323d4db072cf59b6975587e Gerrit-Change-Number: 25908 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:54:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:54:59 +0000 Subject: Change in osmo-bts[master]: [overpower] Turn it on and off depending on DL RxQual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25899 ) Change subject: [overpower] Turn it on and off depending on DL RxQual ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa812d4661ee17c4cd4a8c4ae4bd3e94c1a2e6cc Gerrit-Change-Number: 25899 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 10:54:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:55:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:55:47 +0000 Subject: Change in simtrace2[master]: jenkins: build bootloader updater In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26053 ) Change subject: jenkins: build bootloader updater ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I8b2023921a67b0e8945d8f24e4c8076de3e12acf Gerrit-Change-Number: 26053 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Nov 2021 10:55:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 10:55:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 10:55:50 +0000 Subject: Change in simtrace2[master]: jenkins: build bootloader updater In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26053 ) Change subject: jenkins: build bootloader updater ...................................................................... jenkins: build bootloader updater Change-Id: I8b2023921a67b0e8945d8f24e4c8076de3e12acf --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 40015f7..8e81820 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -28,11 +28,11 @@ export LD_LIBRARY_PATH="$inst/lib" BUILDS="" -BUILDS+="simtrace/dfu simtrace/trace simtrace/cardem " -BUILDS+="qmod/dfu qmod/cardem " -BUILDS+="owhw/dfu owhw/cardem " +BUILDS+="simtrace/dfu simtrace/blupdate simtrace/trace simtrace/cardem " +BUILDS+="qmod/dfu qmod/blupdate qmod/cardem " +BUILDS+="owhw/dfu owhw/blupdate owhw/cardem " BUILDS+="octsimtest/cardem " -BUILDS+="ngff_cardem/dfu ngff_cardem/cardem ngff_cardem/trace " +BUILDS+="ngff_cardem/dfu ngff_cardem/blupdate ngff_cardem/cardem ngff_cardem/trace " cd $TOPDIR/firmware for build in $BUILDS; do -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I8b2023921a67b0e8945d8f24e4c8076de3e12acf Gerrit-Change-Number: 26053 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:05:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:05:38 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > Patch Set 1: > For all_allocated, it is the number of seconds that all channels were allocated per a given amount of time. For example, if the VTY shows all_allocated:sdcch of 10/min, it means all channels were allocated for 10 seconds of the last minute. For a stat item, getting this "per time" part is a complex problem. Thanks, this is the kind of example I was asking for on my first comments in order to understand better what you want to achieve. > > So I'm not really following on why you need all this infrastructure sorry, > > I would appreciate if your criticism could be qualified as well as constructive. > What do you mean by "all this"? What do you suggest instead? Maybe the problem is that I don't see this may be the correct way to go here. I have the feeling we are adding too much counting complexity inside our code base, where this can be simply be submitted over time as a osmo_stat item counter, and let whatever system the customer uses to plot the data over time (eg using grafana or some custom statsd/python scripts) and see when the all_allocated:sdcch incremented over time. So that's what I'm suggesting. Let's let other specialized systems do this kind of stuff instead of bloating our code base. I'm not blocking this if still others think it is a good idea to have this merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:05:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:11:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:11:56 +0000 Subject: Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:11:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:14:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:14:38 +0000 Subject: Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25976 ) Change subject: heighbor_ident: add/del neighbor cells via ctrl interface ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Gerrit-Change-Number: 25976 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 02 Nov 2021 11:14:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:16:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:16:07 +0000 Subject: Change in osmo-bsc[master]: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25996 ) Change subject: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id97bc0d31a358db6221c385761773fb48670c921 Gerrit-Change-Number: 25996 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:16:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:20:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:20:27 +0000 Subject: Change in osmo-bts[master]: [overpower] Turn it on and off depending on DL RxQual In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25899 ) Change subject: [overpower] Turn it on and off depending on DL RxQual ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/25899/7/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/25899/7/src/common/measurement.c at 994 PS7, Line 994: if (mr && mr->meas_valid == 0) { /* 0 = valid */ same again, some meas_is_valid() helper here would be a lot clearer. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa812d4661ee17c4cd4a8c4ae4bd3e94c1a2e6cc Gerrit-Change-Number: 25899 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:20:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:29:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:29:15 +0000 Subject: Change in osmo-hnodeb[master]: Import hnb-test from osmo-iuh.git In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 to look at the new patch set (#4). Change subject: Import hnb-test from osmo-iuh.git ...................................................................... Import hnb-test from osmo-iuh.git Import from osmo-iuh.git Change-Id Iba106dcc18e3d429b4b9808610a44ac29b798172, with minimal renaming of s/hnb_test/hnb/ and required mangling to have it compile and run. Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 --- M configure.ac M contrib/jenkins.sh M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/ranap.h A include/osmocom/hnodeb/rua.h M src/osmo-hnodeb/Makefile.am A src/osmo-hnodeb/debug.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/ranap.c A src/osmo-hnodeb/rua.c 11 files changed, 1,381 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/95/25995/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 Gerrit-Change-Number: 25995 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:33:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:33:54 +0000 Subject: Change in osmo-hnodeb[master]: Import hnb-test from osmo-iuh.git In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 to look at the new patch set (#5). Change subject: Import hnb-test from osmo-iuh.git ...................................................................... Import hnb-test from osmo-iuh.git Import from osmo-iuh.git Change-Id Iba106dcc18e3d429b4b9808610a44ac29b798172, with minimal renaming of s/hnb_test/hnb/ and required mangling to have it compile and run. Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 --- M configure.ac M contrib/jenkins.sh M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/ranap.h A include/osmocom/hnodeb/rua.h M src/osmo-hnodeb/Makefile.am A src/osmo-hnodeb/debug.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/ranap.c A src/osmo-hnodeb/rua.c 11 files changed, 1,383 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/95/25995/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 Gerrit-Change-Number: 25995 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:41:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:41:27 +0000 Subject: Change in osmo-hnodeb[master]: configure: link against libsctp In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26035 to look at the new patch set (#2). Change subject: configure: link against libsctp ...................................................................... configure: link against libsctp osmo-hnodeb calls sctp_recvmsg directly, which is provided by libsctp. Hence, we need to depend and link on it. Change-Id: I793d6fe8601cf9a8dd72bf6884b469204b513c11 --- M configure.ac M src/osmo-hnodeb/Makefile.am 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/35/26035/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I793d6fe8601cf9a8dd72bf6884b469204b513c11 Gerrit-Change-Number: 26035 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:41:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:41:27 +0000 Subject: Change in osmo-hnodeb[master]: Import hnb-test from osmo-iuh.git In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 to look at the new patch set (#6). Change subject: Import hnb-test from osmo-iuh.git ...................................................................... Import hnb-test from osmo-iuh.git Import from osmo-iuh.git Change-Id Iba106dcc18e3d429b4b9808610a44ac29b798172, with minimal renaming of s/hnb_test/hnb/ and required mangling to have it compile and run. Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 --- M configure.ac M contrib/jenkins.sh M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/ranap.h A include/osmocom/hnodeb/rua.h M src/osmo-hnodeb/Makefile.am A src/osmo-hnodeb/debug.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/ranap.c A src/osmo-hnodeb/rua.c 11 files changed, 1,383 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/95/25995/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 Gerrit-Change-Number: 25995 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:47:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:47:47 +0000 Subject: Change in osmo-hnodeb[master]: Import hnb-test from osmo-iuh.git In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 ) Change subject: Import hnb-test from osmo-iuh.git ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 Gerrit-Change-Number: 25995 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:47:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:47:54 +0000 Subject: Change in osmo-hnodeb[master]: Import hnb-test from osmo-iuh.git In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 ) Change subject: Import hnb-test from osmo-iuh.git ...................................................................... Patch Set 6: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 Gerrit-Change-Number: 25995 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:47:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:47:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:47:59 +0000 Subject: Change in osmo-hnodeb[master]: configure: link against libsctp In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26035 ) Change subject: configure: link against libsctp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I793d6fe8601cf9a8dd72bf6884b469204b513c11 Gerrit-Change-Number: 26035 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:47:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:48:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:48:02 +0000 Subject: Change in osmo-hnodeb[master]: configure: link against libsctp In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26035 ) Change subject: configure: link against libsctp ...................................................................... configure: link against libsctp osmo-hnodeb calls sctp_recvmsg directly, which is provided by libsctp. Hence, we need to depend and link on it. Change-Id: I793d6fe8601cf9a8dd72bf6884b469204b513c11 --- M configure.ac M src/osmo-hnodeb/Makefile.am 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 649cf55..171f998 100644 --- a/configure.ac +++ b/configure.ac @@ -44,6 +44,16 @@ dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) +old_LIBS=$LIBS +AC_SEARCH_LIBS([sctp_recvmsg], [sctp], [ + AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) + AC_SUBST(HAVE_LIBSCTP, [1]) + if test -n "$ac_lib"; then + AC_SUBST(LIBSCTP_LIBS, [-l$ac_lib]) + fi + ], [ + AC_MSG_ERROR([sctp_recvmsg not found in searched libs])]) +LIBS=$old_LIBS PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 2ec8b24..8807436 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -37,4 +37,5 @@ $(COVERAGE_LDFLAGS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ + $(LIBSCTP_LIBS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I793d6fe8601cf9a8dd72bf6884b469204b513c11 Gerrit-Change-Number: 26035 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:48:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:48:03 +0000 Subject: Change in osmo-hnodeb[master]: Import hnb-test from osmo-iuh.git In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 ) Change subject: Import hnb-test from osmo-iuh.git ...................................................................... Import hnb-test from osmo-iuh.git Import from osmo-iuh.git Change-Id Iba106dcc18e3d429b4b9808610a44ac29b798172, with minimal renaming of s/hnb_test/hnb/ and required mangling to have it compile and run. Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 --- M configure.ac M contrib/jenkins.sh M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/ranap.h A include/osmocom/hnodeb/rua.h M src/osmo-hnodeb/Makefile.am A src/osmo-hnodeb/debug.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/ranap.c A src/osmo-hnodeb/rua.c 11 files changed, 1,383 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/configure.ac b/configure.ac index 171f998..5b4ca8b 100644 --- a/configure.ac +++ b/configure.ac @@ -55,6 +55,7 @@ AC_MSG_ERROR([sctp_recvmsg not found in searched libs])]) LIBS=$old_LIBS +PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) @@ -62,6 +63,10 @@ PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.7.0) +PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.7.0) +PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.7.0) + dnl checks for header files AC_HEADER_STDC diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 85042d8..7001013 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -34,6 +34,7 @@ osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp osmo-build-dep.sh libasn1c +osmo-build-dep.sh osmo-iuh # Additional configure options and depends CONFIG="" @@ -51,12 +52,12 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize --enable-external-tests --enable-werror $CONFIG +./configure --enable-sanitize --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" \ - DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ + DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 189ef37..9f8963a 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,3 +1,5 @@ noinst_HEADERS = \ hnodeb.h \ + ranap.h \ + rua.h \ $(NULL) diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 6f70f09..ef11ab7 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -1 +1,104 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ #pragma once + +#include +#include +#include +#include + +enum { + DMAIN, + DHNBAP, + DRUA, + DRANAP, +}; +extern const struct log_info hnb_log_info; + +/* 25.467 Section 7.1 */ +#define IUH_DEFAULT_SCTP_PORT 29169 +#define RNA_DEFAULT_SCTP_PORT 25471 + +#define IUH_PPI_RUA 19 +#define IUH_PPI_HNBAP 20 +#define IUH_PPI_SABP 31 +#define IUH_PPI_RNA 42 +#define IUH_PPI_PUA 55 + +#define IUH_MSGB_SIZE 2048 + +struct umts_cell_id { + uint16_t mcc; /*!< Mobile Country Code */ + uint16_t mnc; /*!< Mobile Network Code */ + uint16_t lac; /*!< Locaton Area Code */ + uint16_t rac; /*!< Routing Area Code */ + uint16_t sac; /*!< Service Area Code */ + uint32_t cid; /*!< Cell ID */ +}; + +struct ue_context { + /*! Entry in the HNB-global list of UE */ + struct llist_head list; + /*! Unique Context ID for this UE */ + uint32_t context_id; + char imsi[16+1]; +}; + +struct hnb_chan { + int is_ps; + uint32_t conn_id; + char *imsi; +}; + +struct hnb { + const char *gw_addr; + uint16_t gw_port; + /*! SCTP listen socket for incoming connections */ + struct osmo_fd conn_fd; + + /*! SCTP socket + write queue for Iuh to this specific HNB */ + struct osmo_wqueue wqueue; + /*! copied from HNB-Identity-Info IE */ + char identity_info[256]; + /*! copied from Cell Identity IE */ + struct umts_cell_id id; + + /*! SCTP stream ID for HNBAP */ + uint16_t hnbap_stream; + /*! SCTP stream ID for RUA */ + uint16_t rua_stream; + + uint16_t rnc_id; + + uint32_t ctx_id; + + int ues; + + struct { + struct hnb_chan *chan; + } cs; +}; + +void hnb_rx_iu_release(struct hnb *hnb); +void hnb_rx_paging(struct hnb *hnb, const char *imsi); +void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len); +void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); + +extern struct hnb g_hnb; diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h new file mode 100644 index 0000000..f68006f --- /dev/null +++ b/include/osmocom/hnodeb/ranap.h @@ -0,0 +1,26 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +struct ranap_message_s; +#include + +void hnb_rua_dt_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); +void hnb_rua_cl_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); diff --git a/include/osmocom/hnodeb/rua.h b/include/osmocom/hnodeb/rua.h new file mode 100644 index 0000000..28d0a1a --- /dev/null +++ b/include/osmocom/hnodeb/rua.h @@ -0,0 +1,27 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +struct hnb; + +void hnb_rua_dt_handle(struct hnb *hnb, struct ANY *in); +void hnb_rua_cl_handle(struct hnb *hnb, struct ANY *in); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 8807436..9f09a0a 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -6,6 +6,7 @@ AM_CFLAGS = \ -Wall \ + $(LIBASN1C_CFLAGS) \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ @@ -14,6 +15,9 @@ $(COVERAGE_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ + $(LIBOSMORUA_CFLAGS) \ + $(LIBOSMORANAP_CFLAGS) \ + $(LIBOSMOHNBAP_CFLAGS) \ $(NULL) AM_LDFLAGS = \ @@ -26,9 +30,13 @@ osmo_hnodeb_SOURCES = \ main.c \ + debug.c \ + ranap.c \ + rua.c \ $(NULL) osmo_hnodeb_LDADD = \ + $(LIBASN1C_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOVTY_LIBS) \ @@ -37,5 +45,8 @@ $(COVERAGE_LDFLAGS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ + $(LIBOSMORUA_LIBS) \ + $(LIBOSMORANAP_LIBS) \ + $(LIBOSMOHNBAP_LIBS) \ $(LIBSCTP_LIBS) \ $(NULL) diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c new file mode 100644 index 0000000..69c369e --- /dev/null +++ b/src/osmo-hnodeb/debug.c @@ -0,0 +1,50 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#include + +#include + +static const struct log_info_cat log_cat[] = { + [DMAIN] = { + .name = "DMAIN", .loglevel = LOGL_INFO, .enabled = 1, + .color = "", + .description = "Main program", + }, + [DHNBAP] = { + .name = "DHNBAP", .loglevel = LOGL_DEBUG, .enabled = 1, + .color = "", + .description = "Home Node B Application Part", + }, + [DRANAP] = { + .name = "RANAP", .loglevel = LOGL_DEBUG, .enabled = 1, + .color = "", + .description = "RAN Application Part", + }, + [DRUA] = { + .name = "RUA", .loglevel = LOGL_DEBUG, .enabled = 1, + .color = "", + .description = "RANAP User Adaptation", + }, +}; + +const struct log_info hnb_log_info = { + .cat = log_cat, + .num_cat = ARRAY_SIZE(log_cat), +}; diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 96d9136..9a2aaf9 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -1,4 +1,5 @@ -/* (C) 2021 by sysmocom - s.f.m.c. GmbH +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH * Author: Pau Espin Pedrol * All Rights Reserved * @@ -19,7 +20,992 @@ #include "config.h" +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include + +#include +#include +#include +#include "asn1helpers.h" +#include + +#include + +#include + +#include + +#include +#include +#include +#include + +#include +#include +#include + +static void *tall_hnb_ctx; + +struct hnb g_hnb = { + .gw_addr = "127.0.0.1", + .gw_port = IUH_DEFAULT_SCTP_PORT, +}; + +struct msgb *rua_new_udt(struct msgb *inmsg); + +#if 0 +static int hnb_ue_de_register_tx(struct hnb *hnb) +{ + struct msgb *msg; + int rc; + uint32_t ctx_id; + + UEDe_Register_t dereg; + UEDe_RegisterIEs_t dereg_ies; + memset(&dereg_ies, 0, sizeof(dereg_ies)); + + asn1_u24_to_bitstring(&dereg_ies.context_ID, &ctx_id, hnb->ctx_id); + dereg_ies.cause.present = Cause_PR_radioNetwork; + dereg_ies.cause.choice.radioNetwork = CauseRadioNetwork_connection_with_UE_lost; + + memset(&dereg, 0, sizeof(dereg)); + rc = hnbap_encode_uede_registeries(&dereg, &dereg_ies); + OSMO_ASSERT(rc == 0); + + msg = hnbap_generate_initiating_message(ProcedureCode_id_UEDe_Register, + Criticality_ignore, + &asn_DEF_UEDe_Register, + &dereg); + + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_UEDe_Register, &dereg); + + msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; + + return osmo_wqueue_enqueue(&hnb->wqueue, msg); +} +#endif + +static int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str) +{ + struct msgb *msg; + int rc, imsi_len; + + uint8_t imsi_buf[16]; + + HNBAP_UERegisterRequest_t request_out; + HNBAP_UERegisterRequestIEs_t request; + memset(&request, 0, sizeof(request)); + + request.uE_Identity.present = HNBAP_UE_Identity_PR_iMSI; + + imsi_len = ranap_imsi_encode(imsi_buf, sizeof(imsi_buf), imsi_str); + OCTET_STRING_fromBuf(&request.uE_Identity.choice.iMSI, (const char*)imsi_buf, imsi_len); + + request.registration_Cause = HNBAP_Registration_Cause_normal; + request.uE_Capabilities.access_stratum_release_indicator = HNBAP_Access_stratum_release_indicator_rel_6; + request.uE_Capabilities.csg_capability = HNBAP_CSG_Capability_not_csg_capable; + + memset(&request_out, 0, sizeof(request_out)); + rc = hnbap_encode_ueregisterrequesties(&request_out, &request); + OSMO_ASSERT(rc == 0); + + msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_UERegister, + HNBAP_Criticality_reject, + &asn_DEF_HNBAP_UERegisterRequest, + &request_out); + + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_UERegisterRequest, &request_out); + + msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; + + return osmo_wqueue_enqueue(&hnb->wqueue, msg); +} + +static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) +{ + int rc; + HNBAP_HNBRegisterAcceptIEs_t accept; + + rc = hnbap_decode_hnbregisteraccepties(&accept, in); + if (rc < 0) { + } + + hnb->rnc_id = accept.rnc_id; + printf("HNB Register accept with RNC ID %u\n", hnb->rnc_id); + + hnbap_free_hnbregisteraccepties(&accept); + return 0; +} + +static int hnb_rx_ue_register_acc(struct hnb *hnb, ANY_t *in) +{ + int rc; + uint32_t ctx_id; + HNBAP_UERegisterAcceptIEs_t accept; + char imsi[16]; + + rc = hnbap_decode_ueregisteraccepties(&accept, in); + if (rc < 0) { + return rc; + } + + if (accept.uE_Identity.present != HNBAP_UE_Identity_PR_iMSI) { + printf("Wrong type in UE register accept\n"); + return -1; + } + + ctx_id = asn1bitstr_to_u24(&accept.context_ID); + + ranap_bcd_decode(imsi, sizeof(imsi), accept.uE_Identity.choice.iMSI.buf, + accept.uE_Identity.choice.iMSI.size); + printf("UE Register accept for IMSI %s, context %u\n", imsi, ctx_id); + + hnb->ctx_id = ctx_id; + hnbap_free_ueregisteraccepties(&accept); + + return 0; +} + +static struct msgb *gen_nas_id_resp() +{ + uint8_t id_resp[] = { + GSM48_PDISC_MM, + GSM48_MT_MM_ID_RESP, + /* IMEISV */ + 0x09, /* len */ + 0x03, /* first digit (0000) + even (0) + id IMEISV (011) */ + 0x31, 0x91, 0x06, 0x00, 0x28, 0x47, 0x11, /* digits */ + 0xf2, /* filler (1111) + last digit (0010) */ + }; + + return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); +} + +static struct msgb *gen_nas_tmsi_realloc_compl() +{ + uint8_t id_resp[] = { + GSM48_PDISC_MM, + GSM48_MT_MM_TMSI_REALL_COMPL, + }; + + return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); +} + +static struct msgb *gen_nas_auth_resp(uint8_t *sres) +{ + uint8_t id_resp[] = { + GSM48_PDISC_MM, + 0x80 | GSM48_MT_MM_AUTH_RESP, /* simulate sequence nr 2 */ + 0x61, 0xb5, 0x69, 0xf5 /* hardcoded SRES */ + }; + + memcpy(id_resp + 2, sres, 4); + + return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); +} + +static int hnb_tx_dt(struct hnb *hnb, struct msgb *txm) +{ + struct hnb_chan *chan; + struct msgb *rua; + + chan = hnb->cs.chan; + if (!chan) { + printf("hnb_nas_tx_tmsi_realloc_compl(): No CS channel established yet.\n"); + return -1; + } + + rua = rua_new_dt(chan->is_ps, chan->conn_id, txm); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + return 0; +} + +static struct tlv_parsed *parse_mm(struct gsm48_hdr *gh, int len) +{ + static struct tlv_parsed tp; + int parse_res; + + len -= (const char *)&gh->data[0] - (const char *)gh; + + OSMO_ASSERT(gsm48_hdr_pdisc(gh) == GSM48_PDISC_MM); + + parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); + if (parse_res <= 0) { + uint8_t msg_type = gsm48_hdr_msg_type(gh); + printf("Error parsing MM message 0x%hhx: %d\n", msg_type, parse_res); + return NULL; + } + + return &tp; +} + +int hnb_nas_rx_lu_accept(struct gsm48_hdr *gh, int len, int *sent_tmsi) +{ + printf(" :D Location Update Accept :D\n"); + struct gsm48_loc_area_id *lai; + + lai = (struct gsm48_loc_area_id *)&gh->data[0]; + + struct osmo_location_area_id laid; + gsm48_decode_lai2(lai, &laid); + printf("LU: mcc %s mnc %s lac %hd\n", + osmo_mcc_name(laid.plmn.mcc), osmo_mnc_name(laid.plmn.mnc, laid.plmn.mnc_3_digits), + laid.lac); + + struct tlv_parsed tp; + int parse_res; + + len -= (const char *)&gh->data[0] - (const char *)gh; + parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); + if (parse_res <= 0) { + printf("Error parsing Location Update Accept message: %d\n", parse_res); + return -1; + } + + if (TLVP_PRESENT(&tp, GSM48_IE_MOBILE_ID)) { + uint8_t type = TLVP_VAL(&tp, GSM48_IE_NAME_SHORT)[0] & 0x0f; + if (type == GSM_MI_TYPE_TMSI) + *sent_tmsi = 1; + else *sent_tmsi = 0; + } + return 0; +} + +void hnb_nas_rx_mm_info(struct gsm48_hdr *gh, int len) +{ + printf(" :) MM Info :)\n"); + struct tlv_parsed *tp = parse_mm(gh, len); + if (!tp) + return; + + if (TLVP_PRESENT(tp, GSM48_IE_NAME_SHORT)) { + char name[128] = {0}; + gsm_7bit_decode_n(name, 127, + TLVP_VAL(tp, GSM48_IE_NAME_SHORT)+1, + (TLVP_LEN(tp, GSM48_IE_NAME_SHORT)-1)*8/7); + printf("Info: Short Network Name: %s\n", name); + } + + if (TLVP_PRESENT(tp, GSM48_IE_NAME_LONG)) { + char name[128] = {0}; + gsm_7bit_decode_n(name, 127, + TLVP_VAL(tp, GSM48_IE_NAME_LONG)+1, + (TLVP_LEN(tp, GSM48_IE_NAME_LONG)-1)*8/7); + printf("Info: Long Network Name: %s\n", name); + } +} + +static int hnb_nas_rx_auth_req(struct hnb *hnb, struct gsm48_hdr *gh, + int len) +{ + struct gsm48_auth_req *ar; + + len -= (const char *)&gh->data[0] - (const char *)gh; + + if (len < sizeof(*ar)) { + printf("GSM48 Auth Req does not fit.\n"); + return -1; + } + + printf(" :) Authentication Request :)\n"); + + ar = (struct gsm48_auth_req*) &gh->data[0]; + int seq = ar->key_seq; + + /* Generate SRES from *HARDCODED* Ki for Iuh testing */ + struct osmo_auth_vector vec; + /* Ki 000102030405060708090a0b0c0d0e0f */ + struct osmo_sub_auth_data auth = { + .type = OSMO_AUTH_TYPE_GSM, + .algo = OSMO_AUTH_ALG_COMP128v1, + .u.gsm.ki = { + 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, + 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, + 0x0e, 0x0f + }, + }; + + memset(&vec, 0, sizeof(vec)); + osmo_auth_gen_vec(&vec, &auth, ar->rand); + + printf("seq %d rand %s", + seq, osmo_hexdump(ar->rand, sizeof(ar->rand))); + printf(" --> sres %s\n", + osmo_hexdump(vec.sres, 4)); + + return hnb_tx_dt(hnb, gen_nas_auth_resp(vec.sres)); +} + +void hnb_tx_iu_release_req(struct hnb *hnb) +{ + RANAP_Cause_t cause = { + .present = RANAP_Cause_PR_radioNetwork, + .choice.transmissionNetwork = RANAP_CauseRadioNetwork_release_due_to_UE_generated_signalling_connection_release, + }; + hnb_tx_dt(hnb, ranap_new_msg_iu_rel_req(&cause)); +} + +void hnb_tx_iu_release_compl(struct hnb *hnb) +{ + hnb_tx_dt(hnb, ranap_new_msg_iu_rel_compl()); +} + +static int hnb_nas_rx_mm(struct hnb *hnb, struct gsm48_hdr *gh, int len) +{ + struct hnb_chan *chan; + + chan = hnb->cs.chan; + if (!chan) { + printf("hnb_nas_rx_mm(): No CS channel established yet.\n"); + return -1; + } + + OSMO_ASSERT(!chan->is_ps); + + uint8_t msg_type = gsm48_hdr_msg_type(gh); + int sent_tmsi; + + switch (msg_type) { + case GSM48_MT_MM_ID_REQ: + return hnb_tx_dt(hnb, gen_nas_id_resp()); + + case GSM48_MT_MM_LOC_UPD_ACCEPT: + if (hnb_nas_rx_lu_accept(gh, len, &sent_tmsi)) + return -1; + if (sent_tmsi) + return hnb_tx_dt(hnb, gen_nas_tmsi_realloc_compl()); + else + return 0; + + case GSM48_MT_MM_LOC_UPD_REJECT: + printf("Received Location Update Reject\n"); + return 0; + + case GSM48_MT_MM_INFO: + hnb_nas_rx_mm_info(gh, len); + hnb_tx_iu_release_req(hnb); + return 0; + + case GSM48_MT_MM_AUTH_REQ: + return hnb_nas_rx_auth_req(hnb, gh, len); + + default: + printf("04.08 message type not handled by hnb-test: 0x%x\n", + msg_type); + return 0; + } + +} + +void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len) +{ + int rc; + printf("got %d bytes: %s\n", len, osmo_hexdump(data, len)); + + // nas_pdu == '05 08 12' ==> IMEI Identity request + // '05 04 0d' ==> LU reject + + struct gsm48_hdr *gh = data; + if (len < sizeof(*gh)) { + printf("hnb_nas_rx_dtap(): NAS PDU is too short: %d. Ignoring.\n", + len); + return; + } + uint8_t pdisc = gsm48_hdr_pdisc(gh); + + switch (pdisc) { + case GSM48_PDISC_MM: + rc = hnb_nas_rx_mm(hnb, gh, len); + if (rc != 0) + printf("Error receiving MM message: %d\n", rc); + return; + default: + printf("04.08 discriminator not handled by hnb-test: %d\n", + pdisc); + return; + } +} + +void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg) +{ + printf(" :) Security Mode Command :)\n"); + /* not caring about encryption yet, just pass 0 for No Encryption. */ + hnb_tx_dt(hnb, ranap_new_msg_sec_mod_compl(ip_alg, 0)); +} + +void hnb_rx_iu_release(struct hnb *hnb) +{ + hnb_tx_iu_release_compl(hnb); +} + +void hnb_rx_paging(struct hnb *hnb, const char *imsi) +{ + printf(" :) Paging Request for %s :)\n", imsi); + /* TODO reply */ +} + +int hnb_hnbap_rx(struct hnb *hnb, struct msgb *msg) +{ + HNBAP_HNBAP_PDU_t _pdu, *pdu = &_pdu; + asn_dec_rval_t dec_ret; + int rc; + + memset(pdu, 0, sizeof(*pdu)); + dec_ret = aper_decode(NULL, &asn_DEF_HNBAP_HNBAP_PDU, (void **) &pdu, + msg->data, msgb_length(msg), 0, 0); + if (dec_ret.code != RC_OK) { + LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); + return -EINVAL; + } + + if (pdu->present != HNBAP_HNBAP_PDU_PR_successfulOutcome) { + printf("Unexpected HNBAP message received\n"); + } + + switch (pdu->choice.successfulOutcome.procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: + /* Get HNB id and send UE Register request */ + rc = hnb_rx_hnb_register_acc(hnb, &pdu->choice.successfulOutcome.value); + break; + case HNBAP_ProcedureCode_id_UERegister: + rc = hnb_rx_ue_register_acc(hnb, &pdu->choice.successfulOutcome.value); + break; + default: + rc = -ENOSPC; + break; + } + + return rc; +} + +extern void direct_transfer_nas_pdu_print(ANY_t *in); + +int hnb_rua_rx(struct hnb *hnb, struct msgb *msg) +{ + RUA_RUA_PDU_t _pdu, *pdu = &_pdu; + asn_dec_rval_t dec_ret; + + memset(pdu, 0, sizeof(*pdu)); + dec_ret = aper_decode(NULL, &asn_DEF_RUA_RUA_PDU, (void **) &pdu, + msg->data, msgb_length(msg), 0, 0); + if (dec_ret.code != RC_OK) { + LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); + return -EINVAL; + } + + switch (pdu->present) { + case RUA_RUA_PDU_PR_successfulOutcome: + printf("RUA_RUA_PDU_PR_successfulOutcome\n"); + break; + case RUA_RUA_PDU_PR_initiatingMessage: + printf("RUA_RUA_PDU_PR_initiatingMessage\n"); + break; + case RUA_RUA_PDU_PR_NOTHING: + printf("RUA_RUA_PDU_PR_NOTHING\n"); + break; + case RUA_RUA_PDU_PR_unsuccessfulOutcome: + printf("RUA_RUA_PDU_PR_unsuccessfulOutcome\n"); + break; + default: + printf("Unexpected RUA message received\n"); + break; + } + + switch (pdu->choice.successfulOutcome.procedureCode) { + case RUA_ProcedureCode_id_ConnectionlessTransfer: + printf("RUA rx Connectionless Transfer\n"); + hnb_rua_cl_handle(hnb, &pdu->choice.successfulOutcome.value); + break; + case RUA_ProcedureCode_id_Connect: + printf("RUA rx Connect\n"); + break; + case RUA_ProcedureCode_id_DirectTransfer: + printf("RUA rx DirectTransfer\n"); + hnb_rua_dt_handle(hnb, &pdu->choice.successfulOutcome.value); + break; + case RUA_ProcedureCode_id_Disconnect: + printf("RUA rx Disconnect\n"); + break; + case RUA_ProcedureCode_id_ErrorIndication: + printf("RUA rx ErrorIndication\n"); + break; + case RUA_ProcedureCode_id_privateMessage: + printf("RUA rx privateMessage\n"); + break; + default: + printf("RUA rx unknown message\n"); + break; + } + + return 0; +} + +static int hnb_read_cb(struct osmo_fd *fd) +{ + struct hnb *hnb = fd->data; + struct sctp_sndrcvinfo sinfo; + struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); + int flags = 0; + int rc; + + if (!msg) + return -ENOMEM; + + rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), + NULL, NULL, &sinfo, &flags); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); + /* FIXME: clean up after disappeared HNB */ + close(fd->fd); + osmo_fd_unregister(fd); + return rc; + } else if (rc == 0) { + LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); + close(fd->fd); + osmo_fd_unregister(fd); + fd->fd = -1; + + return -1; + } else { + msgb_put(msg, rc); + } + + if (flags & MSG_NOTIFICATION) { + LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); + msgb_free(msg); + return 0; + } + + sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); + + switch (sinfo.sinfo_ppid) { + case IUH_PPI_HNBAP: + printf("HNBAP message received\n"); + rc = hnb_hnbap_rx(hnb, msg); + break; + case IUH_PPI_RUA: + printf("RUA message received\n"); + rc = hnb_rua_rx(hnb, msg); + break; + case IUH_PPI_SABP: + case IUH_PPI_RNA: + case IUH_PPI_PUA: + LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + default: + LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + } + + msgb_free(msg); + return rc; +} + +static int hnb_write_cb(struct osmo_fd *fd, struct msgb *msg) +{ + /* struct hnb *ctx = fd->data; */ + struct sctp_sndrcvinfo sinfo = { + .sinfo_ppid = htonl(msgb_sctp_ppid(msg)), + .sinfo_stream = 0, + }; + int rc; + + printf("Sending: %s\n", osmo_hexdump(msgb_data(msg), msgb_length(msg))); + rc = sctp_send(fd->fd, msgb_data(msg), msgb_length(msg), + &sinfo, 0); + /* we don't need to msgb_free(), write_queue does this for us */ + return rc; +} + +static void hnb_send_register_req(struct hnb *hnb) +{ + HNBAP_HNBRegisterRequest_t request_out; + struct msgb *msg; + int rc; + uint16_t lac, sac; + uint8_t rac; + uint32_t cid; + uint8_t plmn[] = {0x09, 0xf1, 0x99}; + char identity[50] = "ATestHNB@"; + + HNBAP_HNBRegisterRequestIEs_t request; + memset(&request, 0, sizeof(request)); + + lac = 0xc0fe; + sac = 0xabab; + rac = 0x42; + cid = 0xadceaab; + + asn1_u16_to_str(&request.lac, &lac, lac); + asn1_u16_to_str(&request.sac, &sac, sac); + asn1_u8_to_str(&request.rac, &rac, rac); + asn1_u28_to_bitstring(&request.cellIdentity, &cid, cid); + + request.hnB_Identity.hNB_Identity_Info.buf = (uint8_t*) identity; + request.hnB_Identity.hNB_Identity_Info.size = strlen(identity); + + request.plmNidentity.buf = plmn; + request.plmNidentity.size = 3; + + + + memset(&request_out, 0, sizeof(request_out)); + rc = hnbap_encode_hnbregisterrequesties(&request_out, &request); + if (rc < 0) { + printf("Could not encode HNB register request IEs\n"); + } + + msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBRegister, + HNBAP_Criticality_reject, + &asn_DEF_HNBAP_HNBRegisterRequest, + &request_out); + + + msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; + + osmo_wqueue_enqueue(&hnb->wqueue, msg); +} + +static void hnb_send_deregister_req(struct hnb *hnb) +{ + struct msgb *msg; + int rc; + + HNBAP_HNBDe_RegisterIEs_t request; + memset(&request, 0, sizeof(request)); + + request.cause.present = HNBAP_Cause_PR_misc; + request.cause.choice.misc = HNBAP_CauseMisc_o_and_m_intervention; + + HNBAP_HNBDe_Register_t request_out; + memset(&request_out, 0, sizeof(request_out)); + rc = hnbap_encode_hnbde_registeries(&request_out, &request); + if (rc < 0) { + printf("Could not encode HNB deregister request IEs\n"); + } + + msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBDe_Register, + HNBAP_Criticality_reject, + &asn_DEF_HNBAP_HNBDe_Register, + &request_out); + + msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; + + osmo_wqueue_enqueue(&hnb->wqueue, msg); +} + +static struct vty_app_info vty_info = { + .name = "OsmohNodeB", + .version = "0", +}; + +static int sctp_sock_init(int fd) +{ + struct sctp_event_subscribe event; + int rc; + + /* subscribe for all events */ + memset((uint8_t *)&event, 1, sizeof(event)); + rc = setsockopt(fd, IPPROTO_SCTP, SCTP_EVENTS, + &event, sizeof(event)); + + return rc; +} + +#define HNBAP_STR "HNBAP related commands\n" +#define HNB_STR "HomeNodeB commands\n" +#define UE_STR "User Equipment commands\n" +#define RANAP_STR "RANAP related commands\n" +#define CSPS_STR "Circuit Switched\n" "Packet Switched\n" + +DEFUN(hnb_register, hnb_register_cmd, + "hnbap hnb register", HNBAP_STR HNB_STR "Send HNB-REGISTER REQUEST") +{ + hnb_send_register_req(&g_hnb); + + return CMD_SUCCESS; +} + +DEFUN(hnb_deregister, hnb_deregister_cmd, + "hnbap hnb deregister", HNBAP_STR HNB_STR "Send HNB-DEREGISTER REQUEST") +{ + hnb_send_deregister_req(&g_hnb); + + return CMD_SUCCESS; +} + +DEFUN(ue_register, ue_register_cmd, + "hnbap ue register IMSI", HNBAP_STR UE_STR "Send UE-REGISTER REQUEST") +{ + hnb_ue_register_tx(&g_hnb, argv[0]); + + return CMD_SUCCESS; +} + +DEFUN(asn_dbg, asn_dbg_cmd, + "asn-debug (1|0)", "Enable or disable libasn1c debugging") +{ + asn_debug = atoi(argv[0]); + + return CMD_SUCCESS; +} + +DEFUN(ranap_reset, ranap_reset_cmd, + "ranap reset (cs|ps)", RANAP_STR "Send RANAP RESET\n" CSPS_STR) +{ + int is_ps = 0; + struct msgb *msg, *rua; + + RANAP_Cause_t cause = { + .present = RANAP_Cause_PR_transmissionNetwork, + .choice.transmissionNetwork = RANAP_CauseTransmissionNetwork_signalling_transport_resource_failure, + }; + + if (!strcmp(argv[0], "ps")) + is_ps = 1; + + msg = ranap_new_msg_reset(is_ps, &cause); + rua = rua_new_udt(msg); + //msgb_free(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + return CMD_SUCCESS; +} + + +enum my_vty_nodes { + CHAN_NODE = _LAST_OSMOVTY_NODE, +}; + +static struct cmd_node chan_node = { + CHAN_NODE, + "%s(chan)> ", + 1, +}; + + +static struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi) +{ + uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST, + 0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57, + /* len, IMSI/type, IMSI-------------------------------- */ + 0x08, 0x29, 0x26, 0x24, 0x10, 0x32, 0x54, 0x76, 0x98, + 0x33, 0x03, 0x57, 0x18 , 0xb2 }; + uint8_t plmn_id[] = { 0x09, 0x01, 0x99 }; + RANAP_GlobalRNC_ID_t rnc_id = { + .rNC_ID = 23, + .pLMNidentity.buf = plmn_id, + .pLMNidentity.size = sizeof(plmn_id), + }; + + /* FIXME: patch imsi */ + /* Note: the Mobile Identitiy IE's IMSI data has the identity type and + * an even/odd indicator bit encoded in the first octet. So the first + * octet looks like this: + * + * 8 7 6 5 | 4 | 3 2 1 + * IMSI-digit | even/odd | type + * + * followed by the remaining IMSI digits. + * If digit count is even (bit 4 == 0), that first high-nibble is 0xf. + * (derived from Iu pcap Location Update Request msg and TS 25.413) + * + * TODO I'm only 90% sure about this + */ + + return ranap_new_msg_initial_ue(conn_id, is_ps, &rnc_id, lu, sizeof(lu)); +} + +DEFUN(chan, chan_cmd, + "channel (cs|ps) lu imsi IMSI", + "Open a new Signalling Connection\n" + "To Circuit-Switched CN\n" + "To Packet-Switched CN\n" + "Performing a Location Update\n" + ) +{ + struct hnb_chan *chan; + struct msgb *msg, *rua; + static uint16_t conn_id = 42; + + chan = talloc_zero(tall_hnb_ctx, struct hnb_chan); + if (!strcmp(argv[0], "ps")) + chan->is_ps = 1; + chan->imsi = talloc_strdup(chan, argv[1]); + chan->conn_id = conn_id; + conn_id++; + + msg = gen_initue_lu(chan->is_ps, chan->conn_id, chan->imsi); + rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); + + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + vty->index = chan; + vty->node = CHAN_NODE; + + if (!chan->is_ps) + g_hnb.cs.chan = chan; + + + return CMD_SUCCESS; +} + +static void hnb_vty_init(void) +{ + install_element_ve(&asn_dbg_cmd); + install_element_ve(&hnb_register_cmd); + install_element_ve(&hnb_deregister_cmd); + install_element_ve(&ue_register_cmd); + install_element_ve(&ranap_reset_cmd); + install_element_ve(&chan_cmd); + + install_node(&chan_node, NULL); +} + +static void handle_options(int argc, char **argv) +{ + while (1) { + int idx = 0, c; + static const struct option long_options[] = { + { "ues", 1, 0, 'u' }, + { "gw-addr", 1, 0, 'g' }, + { 0, 0, 0, 0 }, + }; + + c = getopt_long(argc, argv, "u:g:", long_options, &idx); + + if (c == -1) + break; + + switch (c) { + case 'u': + g_hnb.ues = atoi(optarg); + break; + case 'g': + g_hnb.gw_addr = optarg; + break; + } + } +} + int main(int argc, char **argv) { - return 0; + int rc; + + tall_hnb_ctx = talloc_named_const(NULL, 0, "hnb_context"); + + msgb_talloc_ctx_init(tall_hnb_ctx, 0); + talloc_asn1_ctx = talloc_named_const(tall_hnb_ctx, 0, "asn1_context"); + + rc = osmo_init_logging2(tall_hnb_ctx, &hnb_log_info); + if (rc < 0) + exit(1); + + ranap_set_log_area(DRANAP); + + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); + log_set_use_color(osmo_stderr_target, 0); + log_set_print_category(osmo_stderr_target, 0); + log_set_print_category_hex(osmo_stderr_target, 0); + + vty_init(&vty_info); + hnb_vty_init(); + + rc = telnet_init_dynif(NULL, NULL, vty_get_bind_addr(), 2324); + if (rc < 0) { + perror("Error binding VTY port"); + exit(1); + } + + handle_options(argc, argv); + + osmo_wqueue_init(&g_hnb.wqueue, 16); + g_hnb.wqueue.bfd.data = &g_hnb; + g_hnb.wqueue.read_cb = hnb_read_cb; + g_hnb.wqueue.write_cb = hnb_write_cb; + + rc = osmo_sock_init_ofd(&g_hnb.wqueue.bfd, AF_INET, SOCK_STREAM, + IPPROTO_SCTP, g_hnb.gw_addr, + g_hnb.gw_port, OSMO_SOCK_F_CONNECT); + if (rc < 0) { + perror("Error connecting to Iuh port"); + exit(1); + } + sctp_sock_init(g_hnb.wqueue.bfd.fd); + +#if 0 + /* some hard-coded message generation. Doesn't make sense from + * a protocol point of view but enables to look at the encoded + * results in wireshark for manual verification */ + { + struct msgb *msg, *rua; + const uint8_t nas[] = { 0, 1, 2, 3 }; + const uint8_t ik[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 }; + + msg = ranap_new_msg_dt(0, nas, sizeof(nas)); + rua = rua_new_udt(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + msg = ranap_new_msg_sec_mod_cmd(ik, ik, RANAP_KeyStatus_new); + rua = rua_new_udt(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + msg = ranap_new_msg_iu_rel_cmd() + rua = rua_new_udt(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + msg = ranap_new_msg_paging_cmd("901990123456789", NULL, 0, 0); + rua = rua_new_udt(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + msg = ranap_new_msg_rab_assign_voice(1, 0x01020304, 0x1020); + rua = rua_new_udt(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + msg = ranap_new_msg_rab_assign_data(2, 0x01020304, 0x11223344); + rua = rua_new_udt(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + } +#endif + + while (1) { + rc = osmo_select_main(0); + if (rc < 0) + exit(3); + } + + /* not reached */ + exit(0); } diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c new file mode 100644 index 0000000..a6a92cc --- /dev/null +++ b/src/osmo-hnodeb/ranap.c @@ -0,0 +1,107 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#include + +#include +#include +#include + +#include + +static const char *printstr(OCTET_STRING_t *s) +{ + return osmo_hexdump((const unsigned char*)s->buf, s->size); +} + +#define PP(octet_string_t) \ + printf(#octet_string_t " = %s\n",\ + printstr(&octet_string_t)) + +void hnb_rua_dt_handle_ranap(struct hnb *hnb, + struct ranap_message_s *ranap_msg) +{ + int len; + uint8_t *data; + RANAP_PermittedIntegrityProtectionAlgorithms_t *algs; + RANAP_IntegrityProtectionAlgorithm_t *first_alg; + + printf("rx ranap_msg->procedureCode %d\n", + ranap_msg->procedureCode); + + switch (ranap_msg->procedureCode) { + case RANAP_ProcedureCode_id_DirectTransfer: + printf("rx DirectTransfer: presence = %hx\n", + ranap_msg->msg.directTransferIEs.presenceMask); + PP(ranap_msg->msg.directTransferIEs.nas_pdu); + + len = ranap_msg->msg.directTransferIEs.nas_pdu.size; + data = ranap_msg->msg.directTransferIEs.nas_pdu.buf; + + hnb_nas_rx_dtap(hnb, data, len); + return; + + case RANAP_ProcedureCode_id_SecurityModeControl: + printf("rx SecurityModeControl: presence = %hx\n", + ranap_msg->msg.securityModeCommandIEs.presenceMask); + + /* Just pick the first available IP alg, don't care about + * encryption (yet?) */ + algs = &ranap_msg->msg.securityModeCommandIEs.integrityProtectionInformation.permittedAlgorithms; + if (algs->list.count < 1) { + printf("Security Mode Command: No permitted algorithms.\n"); + return; + } + first_alg = *algs->list.array; + + hnb_rx_secmode_cmd(hnb, *first_alg); + return; + + case RANAP_ProcedureCode_id_Iu_Release: + hnb_rx_iu_release(hnb); + return; + } +} + +void hnb_rua_cl_handle_ranap(struct hnb *hnb, + struct ranap_message_s *ranap_msg) +{ + char imsi[16]; + + printf("rx ranap_msg->procedureCode %d\n", + ranap_msg->procedureCode); + + switch (ranap_msg->procedureCode) { + case RANAP_ProcedureCode_id_Paging: + if (ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.present == RANAP_PermanentNAS_UE_ID_PR_iMSI) { + ranap_bcd_decode(imsi, sizeof(imsi), + ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.choice.iMSI.buf, + ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.choice.iMSI.size); + } else imsi[0] = '\0'; + + printf("rx Paging: presence=%hx domain=%ld IMSI=%s\n", + ranap_msg->msg.pagingIEs.presenceMask, + ranap_msg->msg.pagingIEs.cN_DomainIndicator, + imsi + ); + + hnb_rx_paging(hnb, imsi); + return; + } +} diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c new file mode 100644 index 0000000..3db9de7 --- /dev/null +++ b/src/osmo-hnodeb/rua.c @@ -0,0 +1,61 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#include + +#include +#include + +#include +#include + + +void hnb_rua_dt_handle(struct hnb *hnb, ANY_t *in) +{ + RUA_DirectTransferIEs_t ies; + int rc; + + rc = rua_decode_directtransferies(&ies, in); + if (rc < 0) { + printf("failed to decode RUA DT IEs\n"); + return; + } + + rc = ranap_cn_rx_co(hnb_rua_dt_handle_ranap, hnb, ies.ranaP_Message.buf, ies.ranaP_Message.size); + + /* FIXME: what to do with the asn1c-allocated memory */ + rua_free_directtransferies(&ies); +} + +void hnb_rua_cl_handle(struct hnb *hnb, ANY_t *in) +{ + RUA_ConnectionlessTransferIEs_t ies; + int rc; + + rc = rua_decode_connectionlesstransferies(&ies, in); + if (rc < 0) { + printf("failed to decode RUA CL IEs\n"); + return; + } + + rc = ranap_cn_rx_cl(hnb_rua_cl_handle_ranap, hnb, ies.ranaP_Message.buf, ies.ranaP_Message.size); + + /* FIXME: what to do with the asn1c-allocated memory */ + rua_free_connectionlesstransferies(&ies); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I36fd4aa5d39222371bd36e9f540b91e36a26de43 Gerrit-Change-Number: 25995 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:48:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:48:46 +0000 Subject: Change in osmo-hnodeb[master]: Move existing vty code to its own vty.c/h file In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25997 to look at the new patch set (#2). Change subject: Move existing vty code to its own vty.c/h file ...................................................................... Move existing vty code to its own vty.c/h file Change-Id: I88107e9ed03ff8f807b57a3ea0d189fd70864861 --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/main.c A src/osmo-hnodeb/vty.c 6 files changed, 195 insertions(+), 123 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/97/25997/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I88107e9ed03ff8f807b57a3ea0d189fd70864861 Gerrit-Change-Number: 25997 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:54:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:54:38 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: ping -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 02 Nov 2021 11:54:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:55:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:55:20 +0000 Subject: Change in osmo-iuh[master]: RFC: WIP: Fix compilation warnings In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/25886 ) Change subject: RFC: WIP: Fix compilation warnings ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/25886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I36b6dc391af58334ab87986e76a0b63c4c3dfffa Gerrit-Change-Number: 25886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:55:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:55:51 +0000 Subject: Change in osmo-hnodeb[master]: Move existing vty code to its own vty.c/h file In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25997 ) Change subject: Move existing vty code to its own vty.c/h file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I88107e9ed03ff8f807b57a3ea0d189fd70864861 Gerrit-Change-Number: 25997 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:55:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:56:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:56:11 +0000 Subject: Change in osmo-hnodeb[master]: Move hnbap related code to hnbap.c/h In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26000 ) Change subject: Move hnbap related code to hnbap.c/h ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I8356421169bebe1d411b05b19241ea639dc3f733 Gerrit-Change-Number: 26000 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:56:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:56:13 +0000 Subject: Change in osmo-hnodeb[master]: Move hnbap related code to hnbap.c/h In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26000 ) Change subject: Move hnbap related code to hnbap.c/h ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I8356421169bebe1d411b05b19241ea639dc3f733 Gerrit-Change-Number: 26000 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:56:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:57:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:57:49 +0000 Subject: Change in osmo-hnodeb[master]: Move protocol related code in main.c to related proto files In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 ) Change subject: Move protocol related code in main.c to related proto files ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I771b3d3f61207137477eed2b316a5f670fb79ef2 Gerrit-Change-Number: 26002 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:57:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:57:52 +0000 Subject: Change in osmo-hnodeb[master]: Move protocol related code in main.c to related proto files In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 ) Change subject: Move protocol related code in main.c to related proto files ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I771b3d3f61207137477eed2b316a5f670fb79ef2 Gerrit-Change-Number: 26002 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:57:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:58:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:58:08 +0000 Subject: Change in osmo-hnodeb[master]: More work on main.c to add osmocom functionalitites In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26013 ) Change subject: More work on main.c to add osmocom functionalitites ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I61a5ee2e100f79cef7e42dbd981e308597c30900 Gerrit-Change-Number: 26013 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:58:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:58:12 +0000 Subject: Change in osmo-hnodeb[master]: More work on main.c to add osmocom functionalitites In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26013 ) Change subject: More work on main.c to add osmocom functionalitites ...................................................................... Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I61a5ee2e100f79cef7e42dbd981e308597c30900 Gerrit-Change-Number: 26013 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:58:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:58:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:58:35 +0000 Subject: Change in osmo-hnodeb[master]: Set up Iuh conn params through VTY In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26014 ) Change subject: Set up Iuh conn params through VTY ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id5a17742643e8f02c22228e3055bcc213423a416 Gerrit-Change-Number: 26014 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:58:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:58:38 +0000 Subject: Change in osmo-hnodeb[master]: Set up Iuh conn params through VTY In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26014 ) Change subject: Set up Iuh conn params through VTY ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id5a17742643e8f02c22228e3055bcc213423a416 Gerrit-Change-Number: 26014 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:58:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:59:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:59:00 +0000 Subject: Change in osmo-hnodeb[master]: use osmo_stream_cli to manage sctp Iuh conn In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26018 ) Change subject: use osmo_stream_cli to manage sctp Iuh conn ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9d884231577aa47af22cd6319130ca5c9e595d61 Gerrit-Change-Number: 26018 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:59:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:59:02 +0000 Subject: Change in osmo-hnodeb[master]: use osmo_stream_cli to manage sctp Iuh conn In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26018 ) Change subject: use osmo_stream_cli to manage sctp Iuh conn ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9d884231577aa47af22cd6319130ca5c9e595d61 Gerrit-Change-Number: 26018 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:59:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:59:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:59:19 +0000 Subject: Change in osmo-hnodeb[master]: Configure HNB-Identity over VTY and use it in HnbRegisterRequest In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26022 ) Change subject: Configure HNB-Identity over VTY and use it in HnbRegisterRequest ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ida47bbb85b5438a2ec9805005bc2ab834c79b765 Gerrit-Change-Number: 26022 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:59:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:59:21 +0000 Subject: Change in osmo-hnodeb[master]: Configure HNB-Identity over VTY and use it in HnbRegisterRequest In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26022 ) Change subject: Configure HNB-Identity over VTY and use it in HnbRegisterRequest ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ida47bbb85b5438a2ec9805005bc2ab834c79b765 Gerrit-Change-Number: 26022 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:59:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:59:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:59:48 +0000 Subject: Change in osmo-hnodeb[master]: Allocate g_hnb as a pointer, move code to hnb.c/h In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 ) Change subject: Allocate g_hnb as a pointer, move code to hnb.c/h ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5ec61d2a72d55d182e1498939209b30b6e652467 Gerrit-Change-Number: 26001 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:59:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:59:50 +0000 Subject: Change in osmo-hnodeb[master]: Allocate g_hnb as a pointer, move code to hnb.c/h In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 ) Change subject: Allocate g_hnb as a pointer, move code to hnb.c/h ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5ec61d2a72d55d182e1498939209b30b6e652467 Gerrit-Change-Number: 26001 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:59:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 11:59:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 11:59:57 +0000 Subject: Change in osmo-hnodeb[master]: Move protocol related code in main.c to related proto files In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 ) Change subject: Move protocol related code in main.c to related proto files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I771b3d3f61207137477eed2b316a5f670fb79ef2 Gerrit-Change-Number: 26002 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 11:59:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:07 +0000 Subject: Change in osmo-hnodeb[master]: Use osmocom logging in non-main files In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017 ) Change subject: Use osmocom logging in non-main files ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I649b17803aeffd20354aa76dde61094959f08e43 Gerrit-Change-Number: 26017 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 12:00:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:14 +0000 Subject: Change in osmo-hnodeb[master]: Configure PLMN over VTY and use it in HnbRegisterRequest In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26020 ) Change subject: Configure PLMN over VTY and use it in HnbRegisterRequest ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d67aa547d5496fe1407744e1dde07d2a41df500 Gerrit-Change-Number: 26020 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 12:00:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:18 +0000 Subject: Change in osmo-hnodeb[master]: Configure CI, LAC, RAC, SAC over VTY and use it in HnbRegisterRequest In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 ) Change subject: Configure CI,LAC,RAC,SAC over VTY and use it in HnbRegisterRequest ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I06f21758e361b7d4d7141086d758893bee434e5c Gerrit-Change-Number: 26021 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 12:00:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:31 +0000 Subject: Change in osmo-hnodeb[master]: Move existing vty code to its own vty.c/h file In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25997 ) Change subject: Move existing vty code to its own vty.c/h file ...................................................................... Move existing vty code to its own vty.c/h file Change-Id: I88107e9ed03ff8f807b57a3ea0d189fd70864861 --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/main.c A src/osmo-hnodeb/vty.c 6 files changed, 195 insertions(+), 123 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 9f8963a..339f8a3 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -2,4 +2,5 @@ hnodeb.h \ ranap.h \ rua.h \ + vty.h \ $(NULL) diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index ef11ab7..e36311e 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -19,6 +19,8 @@ */ #pragma once +#include + #include #include #include @@ -101,4 +103,10 @@ void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len); void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); +int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str); +void hnb_send_register_req(struct hnb *hnb); +void hnb_send_deregister_req(struct hnb *hnb); +struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi); + +extern void *tall_hnb_ctx; extern struct hnb g_hnb; diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h new file mode 100644 index 0000000..7e3f29f --- /dev/null +++ b/include/osmocom/hnodeb/vty.h @@ -0,0 +1,31 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#pragma once + +#include +#include +#include + +enum hnb_vty_nodes { + CHAN_NODE = _LAST_OSMOVTY_NODE, +}; + +void hnb_vty_init(void); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 9f09a0a..d1cd3ec 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -33,6 +33,7 @@ debug.c \ ranap.c \ rua.c \ + vty.c \ $(NULL) osmo_hnodeb_LDADD = \ diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 9a2aaf9..ae9403d 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -54,7 +54,6 @@ #include #include #include -#include "asn1helpers.h" #include #include @@ -70,9 +69,10 @@ #include #include +#include #include -static void *tall_hnb_ctx; +void *tall_hnb_ctx; struct hnb g_hnb = { .gw_addr = "127.0.0.1", @@ -113,7 +113,7 @@ } #endif -static int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str) +int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str) { struct msgb *msg; int rc, imsi_len; @@ -649,7 +649,7 @@ return rc; } -static void hnb_send_register_req(struct hnb *hnb) +void hnb_send_register_req(struct hnb *hnb) { HNBAP_HNBRegisterRequest_t request_out; struct msgb *msg; @@ -698,7 +698,7 @@ osmo_wqueue_enqueue(&hnb->wqueue, msg); } -static void hnb_send_deregister_req(struct hnb *hnb) +void hnb_send_deregister_req(struct hnb *hnb) { struct msgb *msg; int rc; @@ -744,79 +744,8 @@ return rc; } -#define HNBAP_STR "HNBAP related commands\n" -#define HNB_STR "HomeNodeB commands\n" -#define UE_STR "User Equipment commands\n" -#define RANAP_STR "RANAP related commands\n" -#define CSPS_STR "Circuit Switched\n" "Packet Switched\n" -DEFUN(hnb_register, hnb_register_cmd, - "hnbap hnb register", HNBAP_STR HNB_STR "Send HNB-REGISTER REQUEST") -{ - hnb_send_register_req(&g_hnb); - - return CMD_SUCCESS; -} - -DEFUN(hnb_deregister, hnb_deregister_cmd, - "hnbap hnb deregister", HNBAP_STR HNB_STR "Send HNB-DEREGISTER REQUEST") -{ - hnb_send_deregister_req(&g_hnb); - - return CMD_SUCCESS; -} - -DEFUN(ue_register, ue_register_cmd, - "hnbap ue register IMSI", HNBAP_STR UE_STR "Send UE-REGISTER REQUEST") -{ - hnb_ue_register_tx(&g_hnb, argv[0]); - - return CMD_SUCCESS; -} - -DEFUN(asn_dbg, asn_dbg_cmd, - "asn-debug (1|0)", "Enable or disable libasn1c debugging") -{ - asn_debug = atoi(argv[0]); - - return CMD_SUCCESS; -} - -DEFUN(ranap_reset, ranap_reset_cmd, - "ranap reset (cs|ps)", RANAP_STR "Send RANAP RESET\n" CSPS_STR) -{ - int is_ps = 0; - struct msgb *msg, *rua; - - RANAP_Cause_t cause = { - .present = RANAP_Cause_PR_transmissionNetwork, - .choice.transmissionNetwork = RANAP_CauseTransmissionNetwork_signalling_transport_resource_failure, - }; - - if (!strcmp(argv[0], "ps")) - is_ps = 1; - - msg = ranap_new_msg_reset(is_ps, &cause); - rua = rua_new_udt(msg); - //msgb_free(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - - return CMD_SUCCESS; -} - - -enum my_vty_nodes { - CHAN_NODE = _LAST_OSMOVTY_NODE, -}; - -static struct cmd_node chan_node = { - CHAN_NODE, - "%s(chan)> ", - 1, -}; - - -static struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi) +struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi) { uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST, 0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57, @@ -848,52 +777,6 @@ return ranap_new_msg_initial_ue(conn_id, is_ps, &rnc_id, lu, sizeof(lu)); } -DEFUN(chan, chan_cmd, - "channel (cs|ps) lu imsi IMSI", - "Open a new Signalling Connection\n" - "To Circuit-Switched CN\n" - "To Packet-Switched CN\n" - "Performing a Location Update\n" - ) -{ - struct hnb_chan *chan; - struct msgb *msg, *rua; - static uint16_t conn_id = 42; - - chan = talloc_zero(tall_hnb_ctx, struct hnb_chan); - if (!strcmp(argv[0], "ps")) - chan->is_ps = 1; - chan->imsi = talloc_strdup(chan, argv[1]); - chan->conn_id = conn_id; - conn_id++; - - msg = gen_initue_lu(chan->is_ps, chan->conn_id, chan->imsi); - rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); - - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - - vty->index = chan; - vty->node = CHAN_NODE; - - if (!chan->is_ps) - g_hnb.cs.chan = chan; - - - return CMD_SUCCESS; -} - -static void hnb_vty_init(void) -{ - install_element_ve(&asn_dbg_cmd); - install_element_ve(&hnb_register_cmd); - install_element_ve(&hnb_deregister_cmd); - install_element_ve(&ue_register_cmd); - install_element_ve(&ranap_reset_cmd); - install_element_ve(&chan_cmd); - - install_node(&chan_node, NULL); -} - static void handle_options(int argc, char **argv) { while (1) { diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c new file mode 100644 index 0000000..ccca6d0 --- /dev/null +++ b/src/osmo-hnodeb/vty.c @@ -0,0 +1,148 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include + +#include +#include +#include +#include + +#include + +#include +#include + +#include +#include + +static struct cmd_node chan_node = { + CHAN_NODE, + "%s(chan)> ", + 1, +}; + +#define HNBAP_STR "HNBAP related commands\n" +#define HNB_STR "HomeNodeB commands\n" +#define UE_STR "User Equipment commands\n" +#define RANAP_STR "RANAP related commands\n" +#define CSPS_STR "Circuit Switched\n" "Packet Switched\n" + +DEFUN(hnb_register, hnb_register_cmd, + "hnbap hnb register", HNBAP_STR HNB_STR "Send HNB-REGISTER REQUEST") +{ + hnb_send_register_req(&g_hnb); + + return CMD_SUCCESS; +} + +DEFUN(hnb_deregister, hnb_deregister_cmd, + "hnbap hnb deregister", HNBAP_STR HNB_STR "Send HNB-DEREGISTER REQUEST") +{ + hnb_send_deregister_req(&g_hnb); + + return CMD_SUCCESS; +} + +DEFUN(ue_register, ue_register_cmd, + "hnbap ue register IMSI", HNBAP_STR UE_STR "Send UE-REGISTER REQUEST") +{ + hnb_ue_register_tx(&g_hnb, argv[0]); + + return CMD_SUCCESS; +} + +DEFUN(asn_dbg, asn_dbg_cmd, + "asn-debug (1|0)", "Enable or disable libasn1c debugging") +{ + asn_debug = atoi(argv[0]); + + return CMD_SUCCESS; +} + +DEFUN(ranap_reset, ranap_reset_cmd, + "ranap reset (cs|ps)", RANAP_STR "Send RANAP RESET\n" CSPS_STR) +{ + int is_ps = 0; + struct msgb *msg, *rua; + + RANAP_Cause_t cause = { + .present = RANAP_Cause_PR_transmissionNetwork, + .choice.transmissionNetwork = RANAP_CauseTransmissionNetwork_signalling_transport_resource_failure, + }; + + if (!strcmp(argv[0], "ps")) + is_ps = 1; + + msg = ranap_new_msg_reset(is_ps, &cause); + rua = rua_new_udt(msg); + //msgb_free(msg); + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + return CMD_SUCCESS; +} + +DEFUN(chan, chan_cmd, + "channel (cs|ps) lu imsi IMSI", + "Open a new Signalling Connection\n" + "To Circuit-Switched CN\n" + "To Packet-Switched CN\n" + "Performing a Location Update\n" + ) +{ + struct hnb_chan *chan; + struct msgb *msg, *rua; + static uint16_t conn_id = 42; + + chan = talloc_zero(tall_hnb_ctx, struct hnb_chan); + if (!strcmp(argv[0], "ps")) + chan->is_ps = 1; + chan->imsi = talloc_strdup(chan, argv[1]); + chan->conn_id = conn_id; + conn_id++; + + msg = gen_initue_lu(chan->is_ps, chan->conn_id, chan->imsi); + rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); + + osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + + vty->index = chan; + vty->node = CHAN_NODE; + + if (!chan->is_ps) + g_hnb.cs.chan = chan; + + + return CMD_SUCCESS; +} + +void hnb_vty_init(void) +{ + install_element_ve(&asn_dbg_cmd); + install_element_ve(&hnb_register_cmd); + install_element_ve(&hnb_deregister_cmd); + install_element_ve(&ue_register_cmd); + install_element_ve(&ranap_reset_cmd); + install_element_ve(&chan_cmd); + + install_node(&chan_node, NULL); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I88107e9ed03ff8f807b57a3ea0d189fd70864861 Gerrit-Change-Number: 25997 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:31 +0000 Subject: Change in osmo-hnodeb[master]: main.c: Drop commented out code In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25998 ) Change subject: main.c: Drop commented out code ...................................................................... main.c: Drop commented out code We can always get it back from git history if necessary, let's drop it. Change-Id: I6ea1e3b8692cc6e162962d2e812eb1342c100251 --- M src/osmo-hnodeb/main.c 1 file changed, 0 insertions(+), 67 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index ae9403d..a9c26bf 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -81,38 +81,6 @@ struct msgb *rua_new_udt(struct msgb *inmsg); -#if 0 -static int hnb_ue_de_register_tx(struct hnb *hnb) -{ - struct msgb *msg; - int rc; - uint32_t ctx_id; - - UEDe_Register_t dereg; - UEDe_RegisterIEs_t dereg_ies; - memset(&dereg_ies, 0, sizeof(dereg_ies)); - - asn1_u24_to_bitstring(&dereg_ies.context_ID, &ctx_id, hnb->ctx_id); - dereg_ies.cause.present = Cause_PR_radioNetwork; - dereg_ies.cause.choice.radioNetwork = CauseRadioNetwork_connection_with_UE_lost; - - memset(&dereg, 0, sizeof(dereg)); - rc = hnbap_encode_uede_registeries(&dereg, &dereg_ies); - OSMO_ASSERT(rc == 0); - - msg = hnbap_generate_initiating_message(ProcedureCode_id_UEDe_Register, - Criticality_ignore, - &asn_DEF_UEDe_Register, - &dereg); - - ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_UEDe_Register, &dereg); - - msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; - - return osmo_wqueue_enqueue(&hnb->wqueue, msg); -} -#endif - int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str) { struct msgb *msg; @@ -848,41 +816,6 @@ } sctp_sock_init(g_hnb.wqueue.bfd.fd); -#if 0 - /* some hard-coded message generation. Doesn't make sense from - * a protocol point of view but enables to look at the encoded - * results in wireshark for manual verification */ - { - struct msgb *msg, *rua; - const uint8_t nas[] = { 0, 1, 2, 3 }; - const uint8_t ik[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 }; - - msg = ranap_new_msg_dt(0, nas, sizeof(nas)); - rua = rua_new_udt(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - - msg = ranap_new_msg_sec_mod_cmd(ik, ik, RANAP_KeyStatus_new); - rua = rua_new_udt(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - - msg = ranap_new_msg_iu_rel_cmd() - rua = rua_new_udt(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - - msg = ranap_new_msg_paging_cmd("901990123456789", NULL, 0, 0); - rua = rua_new_udt(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - - msg = ranap_new_msg_rab_assign_voice(1, 0x01020304, 0x1020); - rua = rua_new_udt(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - - msg = ranap_new_msg_rab_assign_data(2, 0x01020304, 0x11223344); - rua = rua_new_udt(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); - } -#endif - while (1) { rc = osmo_select_main(0); if (rc < 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6ea1e3b8692cc6e162962d2e812eb1342c100251 Gerrit-Change-Number: 25998 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:32 +0000 Subject: Change in osmo-hnodeb[master]: Move rua related code to rua.c/h In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/25999 ) Change subject: Move rua related code to rua.c/h ...................................................................... Move rua related code to rua.c/h Change-Id: Ibefe952fe1b642cab5c4abe36383a7ebb05f39c3 --- M include/osmocom/hnodeb/rua.h M src/osmo-hnodeb/main.c M src/osmo-hnodeb/rua.c 3 files changed, 66 insertions(+), 64 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/include/osmocom/hnodeb/rua.h b/include/osmocom/hnodeb/rua.h index 28d0a1a..9d7cc12 100644 --- a/include/osmocom/hnodeb/rua.h +++ b/include/osmocom/hnodeb/rua.h @@ -23,5 +23,4 @@ struct hnb; -void hnb_rua_dt_handle(struct hnb *hnb, struct ANY *in); -void hnb_rua_cl_handle(struct hnb *hnb, struct ANY *in); +int hnb_rua_rx(struct hnb *hnb, struct msgb *msg); diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index a9c26bf..0fcb909 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -476,66 +476,6 @@ extern void direct_transfer_nas_pdu_print(ANY_t *in); -int hnb_rua_rx(struct hnb *hnb, struct msgb *msg) -{ - RUA_RUA_PDU_t _pdu, *pdu = &_pdu; - asn_dec_rval_t dec_ret; - - memset(pdu, 0, sizeof(*pdu)); - dec_ret = aper_decode(NULL, &asn_DEF_RUA_RUA_PDU, (void **) &pdu, - msg->data, msgb_length(msg), 0, 0); - if (dec_ret.code != RC_OK) { - LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); - return -EINVAL; - } - - switch (pdu->present) { - case RUA_RUA_PDU_PR_successfulOutcome: - printf("RUA_RUA_PDU_PR_successfulOutcome\n"); - break; - case RUA_RUA_PDU_PR_initiatingMessage: - printf("RUA_RUA_PDU_PR_initiatingMessage\n"); - break; - case RUA_RUA_PDU_PR_NOTHING: - printf("RUA_RUA_PDU_PR_NOTHING\n"); - break; - case RUA_RUA_PDU_PR_unsuccessfulOutcome: - printf("RUA_RUA_PDU_PR_unsuccessfulOutcome\n"); - break; - default: - printf("Unexpected RUA message received\n"); - break; - } - - switch (pdu->choice.successfulOutcome.procedureCode) { - case RUA_ProcedureCode_id_ConnectionlessTransfer: - printf("RUA rx Connectionless Transfer\n"); - hnb_rua_cl_handle(hnb, &pdu->choice.successfulOutcome.value); - break; - case RUA_ProcedureCode_id_Connect: - printf("RUA rx Connect\n"); - break; - case RUA_ProcedureCode_id_DirectTransfer: - printf("RUA rx DirectTransfer\n"); - hnb_rua_dt_handle(hnb, &pdu->choice.successfulOutcome.value); - break; - case RUA_ProcedureCode_id_Disconnect: - printf("RUA rx Disconnect\n"); - break; - case RUA_ProcedureCode_id_ErrorIndication: - printf("RUA rx ErrorIndication\n"); - break; - case RUA_ProcedureCode_id_privateMessage: - printf("RUA rx privateMessage\n"); - break; - default: - printf("RUA rx unknown message\n"); - break; - } - - return 0; -} - static int hnb_read_cb(struct osmo_fd *fd) { struct hnb *hnb = fd->data; diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 3db9de7..0839c0d 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -17,6 +17,9 @@ * along with this program. If not, see . * */ + +#include + #include #include @@ -26,7 +29,7 @@ #include -void hnb_rua_dt_handle(struct hnb *hnb, ANY_t *in) +static void hnb_rua_dt_handle(struct hnb *hnb, ANY_t *in) { RUA_DirectTransferIEs_t ies; int rc; @@ -43,7 +46,7 @@ rua_free_directtransferies(&ies); } -void hnb_rua_cl_handle(struct hnb *hnb, ANY_t *in) +static void hnb_rua_cl_handle(struct hnb *hnb, ANY_t *in) { RUA_ConnectionlessTransferIEs_t ies; int rc; @@ -59,3 +62,63 @@ /* FIXME: what to do with the asn1c-allocated memory */ rua_free_connectionlesstransferies(&ies); } + +int hnb_rua_rx(struct hnb *hnb, struct msgb *msg) +{ + RUA_RUA_PDU_t _pdu, *pdu = &_pdu; + asn_dec_rval_t dec_ret; + + memset(pdu, 0, sizeof(*pdu)); + dec_ret = aper_decode(NULL, &asn_DEF_RUA_RUA_PDU, (void **) &pdu, + msg->data, msgb_length(msg), 0, 0); + if (dec_ret.code != RC_OK) { + LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); + return -EINVAL; + } + + switch (pdu->present) { + case RUA_RUA_PDU_PR_successfulOutcome: + printf("RUA_RUA_PDU_PR_successfulOutcome\n"); + break; + case RUA_RUA_PDU_PR_initiatingMessage: + printf("RUA_RUA_PDU_PR_initiatingMessage\n"); + break; + case RUA_RUA_PDU_PR_NOTHING: + printf("RUA_RUA_PDU_PR_NOTHING\n"); + break; + case RUA_RUA_PDU_PR_unsuccessfulOutcome: + printf("RUA_RUA_PDU_PR_unsuccessfulOutcome\n"); + break; + default: + printf("Unexpected RUA message received\n"); + break; + } + + switch (pdu->choice.successfulOutcome.procedureCode) { + case RUA_ProcedureCode_id_ConnectionlessTransfer: + printf("RUA rx Connectionless Transfer\n"); + hnb_rua_cl_handle(hnb, &pdu->choice.successfulOutcome.value); + break; + case RUA_ProcedureCode_id_Connect: + printf("RUA rx Connect\n"); + break; + case RUA_ProcedureCode_id_DirectTransfer: + printf("RUA rx DirectTransfer\n"); + hnb_rua_dt_handle(hnb, &pdu->choice.successfulOutcome.value); + break; + case RUA_ProcedureCode_id_Disconnect: + printf("RUA rx Disconnect\n"); + break; + case RUA_ProcedureCode_id_ErrorIndication: + printf("RUA rx ErrorIndication\n"); + break; + case RUA_ProcedureCode_id_privateMessage: + printf("RUA rx privateMessage\n"); + break; + default: + printf("RUA rx unknown message\n"); + break; + } + + return 0; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/25999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ibefe952fe1b642cab5c4abe36383a7ebb05f39c3 Gerrit-Change-Number: 25999 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:33 +0000 Subject: Change in osmo-hnodeb[master]: Move hnbap related code to hnbap.c/h In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26000 ) Change subject: Move hnbap related code to hnbap.c/h ...................................................................... Move hnbap related code to hnbap.c/h Change-Id: I8356421169bebe1d411b05b19241ea639dc3f733 --- M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnbap.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am A src/osmo-hnodeb/hnbap.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 7 files changed, 261 insertions(+), 197 deletions(-) Approvals: pespin: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 339f8a3..f6c91b4 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,4 +1,5 @@ noinst_HEADERS = \ + hnbap.h \ hnodeb.h \ ranap.h \ rua.h \ diff --git a/include/osmocom/hnodeb/hnbap.h b/include/osmocom/hnodeb/hnbap.h new file mode 100644 index 0000000..22f6d25 --- /dev/null +++ b/include/osmocom/hnodeb/hnbap.h @@ -0,0 +1,31 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +struct hnb; +struct msg; + +int hnb_hnbap_rx(struct hnb *hnb, struct msgb *msg); + +int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str); +void hnb_send_register_req(struct hnb *hnb); +void hnb_send_deregister_req(struct hnb *hnb); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index e36311e..b283145 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -103,9 +103,6 @@ void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len); void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); -int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str); -void hnb_send_register_req(struct hnb *hnb); -void hnb_send_deregister_req(struct hnb *hnb); struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi); extern void *tall_hnb_ctx; diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index d1cd3ec..1162944 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -31,6 +31,7 @@ osmo_hnodeb_SOURCES = \ main.c \ debug.c \ + hnbap.c \ ranap.c \ rua.c \ vty.c \ diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c new file mode 100644 index 0000000..7e54004 --- /dev/null +++ b/src/osmo-hnodeb/hnbap.c @@ -0,0 +1,226 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include + +#include + +#include +#include + +#include +#include + +#include /* ranap_bcd_decode() */ + +#include +#include + +static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) +{ + int rc; + HNBAP_HNBRegisterAcceptIEs_t accept; + + rc = hnbap_decode_hnbregisteraccepties(&accept, in); + if (rc < 0) { + } + + hnb->rnc_id = accept.rnc_id; + printf("HNB Register accept with RNC ID %u\n", hnb->rnc_id); + + hnbap_free_hnbregisteraccepties(&accept); + return 0; +} + +static int hnb_rx_ue_register_acc(struct hnb *hnb, ANY_t *in) +{ + int rc; + uint32_t ctx_id; + HNBAP_UERegisterAcceptIEs_t accept; + char imsi[16]; + + rc = hnbap_decode_ueregisteraccepties(&accept, in); + if (rc < 0) { + return rc; + } + + if (accept.uE_Identity.present != HNBAP_UE_Identity_PR_iMSI) { + printf("Wrong type in UE register accept\n"); + return -1; + } + + ctx_id = asn1bitstr_to_u24(&accept.context_ID); + + ranap_bcd_decode(imsi, sizeof(imsi), accept.uE_Identity.choice.iMSI.buf, + accept.uE_Identity.choice.iMSI.size); + printf("UE Register accept for IMSI %s, context %u\n", imsi, ctx_id); + + hnb->ctx_id = ctx_id; + hnbap_free_ueregisteraccepties(&accept); + + return 0; +} + +int hnb_hnbap_rx(struct hnb *hnb, struct msgb *msg) +{ + HNBAP_HNBAP_PDU_t _pdu, *pdu = &_pdu; + asn_dec_rval_t dec_ret; + int rc; + + memset(pdu, 0, sizeof(*pdu)); + dec_ret = aper_decode(NULL, &asn_DEF_HNBAP_HNBAP_PDU, (void **) &pdu, + msg->data, msgb_length(msg), 0, 0); + if (dec_ret.code != RC_OK) { + LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); + return -EINVAL; + } + + if (pdu->present != HNBAP_HNBAP_PDU_PR_successfulOutcome) { + printf("Unexpected HNBAP message received\n"); + } + + switch (pdu->choice.successfulOutcome.procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: + /* Get HNB id and send UE Register request */ + rc = hnb_rx_hnb_register_acc(hnb, &pdu->choice.successfulOutcome.value); + break; + case HNBAP_ProcedureCode_id_UERegister: + rc = hnb_rx_ue_register_acc(hnb, &pdu->choice.successfulOutcome.value); + break; + default: + rc = -ENOSPC; + break; + } + + return rc; +} + +int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str) +{ + struct msgb *msg; + int rc, imsi_len; + + uint8_t imsi_buf[16]; + + HNBAP_UERegisterRequest_t request_out; + HNBAP_UERegisterRequestIEs_t request; + memset(&request, 0, sizeof(request)); + + request.uE_Identity.present = HNBAP_UE_Identity_PR_iMSI; + + imsi_len = ranap_imsi_encode(imsi_buf, sizeof(imsi_buf), imsi_str); + OCTET_STRING_fromBuf(&request.uE_Identity.choice.iMSI, (const char*)imsi_buf, imsi_len); + + request.registration_Cause = HNBAP_Registration_Cause_normal; + request.uE_Capabilities.access_stratum_release_indicator = HNBAP_Access_stratum_release_indicator_rel_6; + request.uE_Capabilities.csg_capability = HNBAP_CSG_Capability_not_csg_capable; + + memset(&request_out, 0, sizeof(request_out)); + rc = hnbap_encode_ueregisterrequesties(&request_out, &request); + OSMO_ASSERT(rc == 0); + + msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_UERegister, + HNBAP_Criticality_reject, + &asn_DEF_HNBAP_UERegisterRequest, + &request_out); + + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_UERegisterRequest, &request_out); + + msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; + + return osmo_wqueue_enqueue(&hnb->wqueue, msg); +} + +void hnb_send_register_req(struct hnb *hnb) +{ + HNBAP_HNBRegisterRequest_t request_out; + struct msgb *msg; + int rc; + uint16_t lac, sac; + uint8_t rac; + uint32_t cid; + uint8_t plmn[] = {0x09, 0xf1, 0x99}; + char identity[50] = "ATestHNB@"; + + HNBAP_HNBRegisterRequestIEs_t request; + memset(&request, 0, sizeof(request)); + + lac = 0xc0fe; + sac = 0xabab; + rac = 0x42; + cid = 0xadceaab; + + asn1_u16_to_str(&request.lac, &lac, lac); + asn1_u16_to_str(&request.sac, &sac, sac); + asn1_u8_to_str(&request.rac, &rac, rac); + asn1_u28_to_bitstring(&request.cellIdentity, &cid, cid); + + request.hnB_Identity.hNB_Identity_Info.buf = (uint8_t*) identity; + request.hnB_Identity.hNB_Identity_Info.size = strlen(identity); + + request.plmNidentity.buf = plmn; + request.plmNidentity.size = 3; + + + + memset(&request_out, 0, sizeof(request_out)); + rc = hnbap_encode_hnbregisterrequesties(&request_out, &request); + if (rc < 0) { + printf("Could not encode HNB register request IEs\n"); + } + + msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBRegister, + HNBAP_Criticality_reject, + &asn_DEF_HNBAP_HNBRegisterRequest, + &request_out); + + + msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; + + osmo_wqueue_enqueue(&hnb->wqueue, msg); +} + +void hnb_send_deregister_req(struct hnb *hnb) +{ + struct msgb *msg; + int rc; + + HNBAP_HNBDe_RegisterIEs_t request; + memset(&request, 0, sizeof(request)); + + request.cause.present = HNBAP_Cause_PR_misc; + request.cause.choice.misc = HNBAP_CauseMisc_o_and_m_intervention; + + HNBAP_HNBDe_Register_t request_out; + memset(&request_out, 0, sizeof(request_out)); + rc = hnbap_encode_hnbde_registeries(&request_out, &request); + if (rc < 0) { + printf("Could not encode HNB deregister request IEs\n"); + } + + msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBDe_Register, + HNBAP_Criticality_reject, + &asn_DEF_HNBAP_HNBDe_Register, + &request_out); + + msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; + + osmo_wqueue_enqueue(&hnb->wqueue, msg); +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 0fcb909..3abfc7c 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -51,8 +51,6 @@ #include -#include -#include #include #include @@ -67,6 +65,7 @@ #include #include +#include #include #include #include @@ -81,87 +80,6 @@ struct msgb *rua_new_udt(struct msgb *inmsg); -int hnb_ue_register_tx(struct hnb *hnb, const char *imsi_str) -{ - struct msgb *msg; - int rc, imsi_len; - - uint8_t imsi_buf[16]; - - HNBAP_UERegisterRequest_t request_out; - HNBAP_UERegisterRequestIEs_t request; - memset(&request, 0, sizeof(request)); - - request.uE_Identity.present = HNBAP_UE_Identity_PR_iMSI; - - imsi_len = ranap_imsi_encode(imsi_buf, sizeof(imsi_buf), imsi_str); - OCTET_STRING_fromBuf(&request.uE_Identity.choice.iMSI, (const char*)imsi_buf, imsi_len); - - request.registration_Cause = HNBAP_Registration_Cause_normal; - request.uE_Capabilities.access_stratum_release_indicator = HNBAP_Access_stratum_release_indicator_rel_6; - request.uE_Capabilities.csg_capability = HNBAP_CSG_Capability_not_csg_capable; - - memset(&request_out, 0, sizeof(request_out)); - rc = hnbap_encode_ueregisterrequesties(&request_out, &request); - OSMO_ASSERT(rc == 0); - - msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_UERegister, - HNBAP_Criticality_reject, - &asn_DEF_HNBAP_UERegisterRequest, - &request_out); - - ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_UERegisterRequest, &request_out); - - msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; - - return osmo_wqueue_enqueue(&hnb->wqueue, msg); -} - -static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) -{ - int rc; - HNBAP_HNBRegisterAcceptIEs_t accept; - - rc = hnbap_decode_hnbregisteraccepties(&accept, in); - if (rc < 0) { - } - - hnb->rnc_id = accept.rnc_id; - printf("HNB Register accept with RNC ID %u\n", hnb->rnc_id); - - hnbap_free_hnbregisteraccepties(&accept); - return 0; -} - -static int hnb_rx_ue_register_acc(struct hnb *hnb, ANY_t *in) -{ - int rc; - uint32_t ctx_id; - HNBAP_UERegisterAcceptIEs_t accept; - char imsi[16]; - - rc = hnbap_decode_ueregisteraccepties(&accept, in); - if (rc < 0) { - return rc; - } - - if (accept.uE_Identity.present != HNBAP_UE_Identity_PR_iMSI) { - printf("Wrong type in UE register accept\n"); - return -1; - } - - ctx_id = asn1bitstr_to_u24(&accept.context_ID); - - ranap_bcd_decode(imsi, sizeof(imsi), accept.uE_Identity.choice.iMSI.buf, - accept.uE_Identity.choice.iMSI.size); - printf("UE Register accept for IMSI %s, context %u\n", imsi, ctx_id); - - hnb->ctx_id = ctx_id; - hnbap_free_ueregisteraccepties(&accept); - - return 0; -} - static struct msgb *gen_nas_id_resp() { uint8_t id_resp[] = { @@ -440,40 +358,6 @@ /* TODO reply */ } -int hnb_hnbap_rx(struct hnb *hnb, struct msgb *msg) -{ - HNBAP_HNBAP_PDU_t _pdu, *pdu = &_pdu; - asn_dec_rval_t dec_ret; - int rc; - - memset(pdu, 0, sizeof(*pdu)); - dec_ret = aper_decode(NULL, &asn_DEF_HNBAP_HNBAP_PDU, (void **) &pdu, - msg->data, msgb_length(msg), 0, 0); - if (dec_ret.code != RC_OK) { - LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); - return -EINVAL; - } - - if (pdu->present != HNBAP_HNBAP_PDU_PR_successfulOutcome) { - printf("Unexpected HNBAP message received\n"); - } - - switch (pdu->choice.successfulOutcome.procedureCode) { - case HNBAP_ProcedureCode_id_HNBRegister: - /* Get HNB id and send UE Register request */ - rc = hnb_rx_hnb_register_acc(hnb, &pdu->choice.successfulOutcome.value); - break; - case HNBAP_ProcedureCode_id_UERegister: - rc = hnb_rx_ue_register_acc(hnb, &pdu->choice.successfulOutcome.value); - break; - default: - rc = -ENOSPC; - break; - } - - return rc; -} - extern void direct_transfer_nas_pdu_print(ANY_t *in); static int hnb_read_cb(struct osmo_fd *fd) @@ -557,83 +441,6 @@ return rc; } -void hnb_send_register_req(struct hnb *hnb) -{ - HNBAP_HNBRegisterRequest_t request_out; - struct msgb *msg; - int rc; - uint16_t lac, sac; - uint8_t rac; - uint32_t cid; - uint8_t plmn[] = {0x09, 0xf1, 0x99}; - char identity[50] = "ATestHNB@"; - - HNBAP_HNBRegisterRequestIEs_t request; - memset(&request, 0, sizeof(request)); - - lac = 0xc0fe; - sac = 0xabab; - rac = 0x42; - cid = 0xadceaab; - - asn1_u16_to_str(&request.lac, &lac, lac); - asn1_u16_to_str(&request.sac, &sac, sac); - asn1_u8_to_str(&request.rac, &rac, rac); - asn1_u28_to_bitstring(&request.cellIdentity, &cid, cid); - - request.hnB_Identity.hNB_Identity_Info.buf = (uint8_t*) identity; - request.hnB_Identity.hNB_Identity_Info.size = strlen(identity); - - request.plmNidentity.buf = plmn; - request.plmNidentity.size = 3; - - - - memset(&request_out, 0, sizeof(request_out)); - rc = hnbap_encode_hnbregisterrequesties(&request_out, &request); - if (rc < 0) { - printf("Could not encode HNB register request IEs\n"); - } - - msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBRegister, - HNBAP_Criticality_reject, - &asn_DEF_HNBAP_HNBRegisterRequest, - &request_out); - - - msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; - - osmo_wqueue_enqueue(&hnb->wqueue, msg); -} - -void hnb_send_deregister_req(struct hnb *hnb) -{ - struct msgb *msg; - int rc; - - HNBAP_HNBDe_RegisterIEs_t request; - memset(&request, 0, sizeof(request)); - - request.cause.present = HNBAP_Cause_PR_misc; - request.cause.choice.misc = HNBAP_CauseMisc_o_and_m_intervention; - - HNBAP_HNBDe_Register_t request_out; - memset(&request_out, 0, sizeof(request_out)); - rc = hnbap_encode_hnbde_registeries(&request_out, &request); - if (rc < 0) { - printf("Could not encode HNB deregister request IEs\n"); - } - - msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBDe_Register, - HNBAP_Criticality_reject, - &asn_DEF_HNBAP_HNBDe_Register, - &request_out); - - msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; - - osmo_wqueue_enqueue(&hnb->wqueue, msg); -} - static struct vty_app_info vty_info = { .name = "OsmohNodeB", .version = "0", diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index ccca6d0..a1bb885 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -32,6 +32,7 @@ #include #include +#include #include #include -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I8356421169bebe1d411b05b19241ea639dc3f733 Gerrit-Change-Number: 26000 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:34 +0000 Subject: Change in osmo-hnodeb[master]: Allocate g_hnb as a pointer, move code to hnb.c/h In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 ) Change subject: Allocate g_hnb as a pointer, move code to hnb.c/h ...................................................................... Allocate g_hnb as a pointer, move code to hnb.c/h Change-Id: I5ec61d2a72d55d182e1498939209b30b6e652467 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am A src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 5 files changed, 178 insertions(+), 127 deletions(-) Approvals: pespin: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index b283145..261fc3a 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -97,6 +97,8 @@ struct hnb_chan *chan; } cs; }; +struct hnb *hnb_alloc(void *tall_ctx); +int hnb_connect(struct hnb *hnb); void hnb_rx_iu_release(struct hnb *hnb); void hnb_rx_paging(struct hnb *hnb, const char *imsi); @@ -106,4 +108,4 @@ struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi); extern void *tall_hnb_ctx; -extern struct hnb g_hnb; +extern struct hnb *g_hnb; diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 1162944..7353cd8 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -32,6 +32,7 @@ main.c \ debug.c \ hnbap.c \ + hnb.c \ ranap.c \ rua.c \ vty.c \ diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c new file mode 100644 index 0000000..335fd3a --- /dev/null +++ b/src/osmo-hnodeb/hnb.c @@ -0,0 +1,161 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include + +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include + +static int sctp_sock_init(int fd) +{ + struct sctp_event_subscribe event; + int rc; + + /* subscribe for all events */ + memset((uint8_t *)&event, 1, sizeof(event)); + rc = setsockopt(fd, IPPROTO_SCTP, SCTP_EVENTS, + &event, sizeof(event)); + + return rc; +} + +static int hnb_read_cb(struct osmo_fd *fd) +{ + struct hnb *hnb = fd->data; + struct sctp_sndrcvinfo sinfo; + struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); + int flags = 0; + int rc; + + if (!msg) + return -ENOMEM; + + rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), + NULL, NULL, &sinfo, &flags); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); + /* FIXME: clean up after disappeared HNB */ + close(fd->fd); + osmo_fd_unregister(fd); + return rc; + } else if (rc == 0) { + LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); + close(fd->fd); + osmo_fd_unregister(fd); + fd->fd = -1; + + return -1; + } else { + msgb_put(msg, rc); + } + + if (flags & MSG_NOTIFICATION) { + LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); + msgb_free(msg); + return 0; + } + + sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); + + switch (sinfo.sinfo_ppid) { + case IUH_PPI_HNBAP: + printf("HNBAP message received\n"); + rc = hnb_hnbap_rx(hnb, msg); + break; + case IUH_PPI_RUA: + printf("RUA message received\n"); + rc = hnb_rua_rx(hnb, msg); + break; + case IUH_PPI_SABP: + case IUH_PPI_RNA: + case IUH_PPI_PUA: + LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + default: + LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + } + + msgb_free(msg); + return rc; +} + +static int hnb_write_cb(struct osmo_fd *fd, struct msgb *msg) +{ + /* struct hnb *ctx = fd->data; */ + struct sctp_sndrcvinfo sinfo = { + .sinfo_ppid = htonl(msgb_sctp_ppid(msg)), + .sinfo_stream = 0, + }; + int rc; + + printf("Sending: %s\n", osmo_hexdump(msgb_data(msg), msgb_length(msg))); + rc = sctp_send(fd->fd, msgb_data(msg), msgb_length(msg), + &sinfo, 0); + /* we don't need to msgb_free(), write_queue does this for us */ + return rc; +} + +struct hnb *hnb_alloc(void *tall_ctx) +{ + struct hnb *hnb; + hnb = talloc_zero(tall_ctx, struct hnb); + if (!hnb) + return NULL; + + hnb->gw_addr = "127.0.0.1", + hnb->gw_port = IUH_DEFAULT_SCTP_PORT, + + osmo_wqueue_init(&hnb->wqueue, 16); + hnb->wqueue.bfd.data = hnb; + hnb->wqueue.read_cb = hnb_read_cb; + hnb->wqueue.write_cb = hnb_write_cb; + + return hnb; +} + +int hnb_connect(struct hnb *hnb) +{ + int rc; + rc = osmo_sock_init_ofd(&hnb->wqueue.bfd, AF_INET, SOCK_STREAM, + IPPROTO_SCTP, hnb->gw_addr, + hnb->gw_port, OSMO_SOCK_F_CONNECT); + if (rc < 0) + return rc; + sctp_sock_init(hnb->wqueue.bfd.fd); + return 0; +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 3abfc7c..dc662aa 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -28,20 +28,11 @@ #include #include -#include -#include -#include -#include -#include - #include #include #include #include -#include #include -#include -#include #include #include @@ -72,11 +63,7 @@ #include void *tall_hnb_ctx; - -struct hnb g_hnb = { - .gw_addr = "127.0.0.1", - .gw_port = IUH_DEFAULT_SCTP_PORT, -}; +struct hnb *g_hnb; struct msgb *rua_new_udt(struct msgb *inmsg); @@ -130,7 +117,7 @@ } rua = rua_new_dt(chan->is_ps, chan->conn_id, txm); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + osmo_wqueue_enqueue(&hnb->wqueue, rua); return 0; } @@ -360,105 +347,11 @@ extern void direct_transfer_nas_pdu_print(ANY_t *in); -static int hnb_read_cb(struct osmo_fd *fd) -{ - struct hnb *hnb = fd->data; - struct sctp_sndrcvinfo sinfo; - struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); - int flags = 0; - int rc; - - if (!msg) - return -ENOMEM; - - rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), - NULL, NULL, &sinfo, &flags); - if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); - /* FIXME: clean up after disappeared HNB */ - close(fd->fd); - osmo_fd_unregister(fd); - return rc; - } else if (rc == 0) { - LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); - close(fd->fd); - osmo_fd_unregister(fd); - fd->fd = -1; - - return -1; - } else { - msgb_put(msg, rc); - } - - if (flags & MSG_NOTIFICATION) { - LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); - msgb_free(msg); - return 0; - } - - sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); - - switch (sinfo.sinfo_ppid) { - case IUH_PPI_HNBAP: - printf("HNBAP message received\n"); - rc = hnb_hnbap_rx(hnb, msg); - break; - case IUH_PPI_RUA: - printf("RUA message received\n"); - rc = hnb_rua_rx(hnb, msg); - break; - case IUH_PPI_SABP: - case IUH_PPI_RNA: - case IUH_PPI_PUA: - LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", - sinfo.sinfo_ppid); - rc = 0; - break; - default: - LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", - sinfo.sinfo_ppid); - rc = 0; - break; - } - - msgb_free(msg); - return rc; -} - -static int hnb_write_cb(struct osmo_fd *fd, struct msgb *msg) -{ - /* struct hnb *ctx = fd->data; */ - struct sctp_sndrcvinfo sinfo = { - .sinfo_ppid = htonl(msgb_sctp_ppid(msg)), - .sinfo_stream = 0, - }; - int rc; - - printf("Sending: %s\n", osmo_hexdump(msgb_data(msg), msgb_length(msg))); - rc = sctp_send(fd->fd, msgb_data(msg), msgb_length(msg), - &sinfo, 0); - /* we don't need to msgb_free(), write_queue does this for us */ - return rc; -} - static struct vty_app_info vty_info = { .name = "OsmohNodeB", .version = "0", }; -static int sctp_sock_init(int fd) -{ - struct sctp_event_subscribe event; - int rc; - - /* subscribe for all events */ - memset((uint8_t *)&event, 1, sizeof(event)); - rc = setsockopt(fd, IPPROTO_SCTP, SCTP_EVENTS, - &event, sizeof(event)); - - return rc; -} - struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi) { @@ -509,10 +402,10 @@ switch (c) { case 'u': - g_hnb.ues = atoi(optarg); + g_hnb->ues = atoi(optarg); break; case 'g': - g_hnb.gw_addr = optarg; + g_hnb->gw_addr = optarg; break; } } @@ -538,6 +431,8 @@ log_set_print_category(osmo_stderr_target, 0); log_set_print_category_hex(osmo_stderr_target, 0); + g_hnb = hnb_alloc(tall_hnb_ctx); + vty_init(&vty_info); hnb_vty_init(); @@ -549,19 +444,11 @@ handle_options(argc, argv); - osmo_wqueue_init(&g_hnb.wqueue, 16); - g_hnb.wqueue.bfd.data = &g_hnb; - g_hnb.wqueue.read_cb = hnb_read_cb; - g_hnb.wqueue.write_cb = hnb_write_cb; - - rc = osmo_sock_init_ofd(&g_hnb.wqueue.bfd, AF_INET, SOCK_STREAM, - IPPROTO_SCTP, g_hnb.gw_addr, - g_hnb.gw_port, OSMO_SOCK_F_CONNECT); + rc = hnb_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); exit(1); } - sctp_sock_init(g_hnb.wqueue.bfd.fd); while (1) { rc = osmo_select_main(0); diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index a1bb885..b8dc7da 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -51,7 +51,7 @@ DEFUN(hnb_register, hnb_register_cmd, "hnbap hnb register", HNBAP_STR HNB_STR "Send HNB-REGISTER REQUEST") { - hnb_send_register_req(&g_hnb); + hnb_send_register_req(g_hnb); return CMD_SUCCESS; } @@ -59,7 +59,7 @@ DEFUN(hnb_deregister, hnb_deregister_cmd, "hnbap hnb deregister", HNBAP_STR HNB_STR "Send HNB-DEREGISTER REQUEST") { - hnb_send_deregister_req(&g_hnb); + hnb_send_deregister_req(g_hnb); return CMD_SUCCESS; } @@ -67,7 +67,7 @@ DEFUN(ue_register, ue_register_cmd, "hnbap ue register IMSI", HNBAP_STR UE_STR "Send UE-REGISTER REQUEST") { - hnb_ue_register_tx(&g_hnb, argv[0]); + hnb_ue_register_tx(g_hnb, argv[0]); return CMD_SUCCESS; } @@ -97,7 +97,7 @@ msg = ranap_new_msg_reset(is_ps, &cause); rua = rua_new_udt(msg); //msgb_free(msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + osmo_wqueue_enqueue(&g_hnb->wqueue, rua); return CMD_SUCCESS; } @@ -124,13 +124,13 @@ msg = gen_initue_lu(chan->is_ps, chan->conn_id, chan->imsi); rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); - osmo_wqueue_enqueue(&g_hnb.wqueue, rua); + osmo_wqueue_enqueue(&g_hnb->wqueue, rua); vty->index = chan; vty->node = CHAN_NODE; if (!chan->is_ps) - g_hnb.cs.chan = chan; + g_hnb->cs.chan = chan; return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5ec61d2a72d55d182e1498939209b30b6e652467 Gerrit-Change-Number: 26001 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:35 +0000 Subject: Change in osmo-hnodeb[master]: Move protocol related code in main.c to related proto files In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 ) Change subject: Move protocol related code in main.c to related proto files ...................................................................... Move protocol related code in main.c to related proto files Change-Id: I771b3d3f61207137477eed2b316a5f670fb79ef2 --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/nas.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/main.c A src/osmo-hnodeb/nas.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 11 files changed, 389 insertions(+), 339 deletions(-) Approvals: pespin: Looks good to me, approved; Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index f6c91b4..197568c 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,6 +1,7 @@ noinst_HEADERS = \ hnbap.h \ hnodeb.h \ + nas.h \ ranap.h \ rua.h \ vty.h \ diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 261fc3a..50432d1 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -100,12 +100,5 @@ struct hnb *hnb_alloc(void *tall_ctx); int hnb_connect(struct hnb *hnb); -void hnb_rx_iu_release(struct hnb *hnb); -void hnb_rx_paging(struct hnb *hnb, const char *imsi); -void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len); -void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); - -struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi); - extern void *tall_hnb_ctx; extern struct hnb *g_hnb; diff --git a/include/osmocom/hnodeb/nas.h b/include/osmocom/hnodeb/nas.h new file mode 100644 index 0000000..f6a7976 --- /dev/null +++ b/include/osmocom/hnodeb/nas.h @@ -0,0 +1,24 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#pragma once + +struct hnb; +void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len); diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h index f68006f..df756b1 100644 --- a/include/osmocom/hnodeb/ranap.h +++ b/include/osmocom/hnodeb/ranap.h @@ -19,8 +19,15 @@ */ #pragma once +struct hnb; struct ranap_message_s; #include +void hnb_rx_iu_release(struct hnb *hnb); +void hnb_rx_paging(struct hnb *hnb, const char *imsi); +void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); + void hnb_rua_dt_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); void hnb_rua_cl_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); +void hnb_tx_iu_release_req(struct hnb *hnb); +struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi); diff --git a/include/osmocom/hnodeb/rua.h b/include/osmocom/hnodeb/rua.h index 9d7cc12..52221be 100644 --- a/include/osmocom/hnodeb/rua.h +++ b/include/osmocom/hnodeb/rua.h @@ -22,5 +22,7 @@ #include struct hnb; +struct msgb; int hnb_rua_rx(struct hnb *hnb, struct msgb *msg); +int hnb_tx_dt(struct hnb *hnb, struct msgb *txm); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 7353cd8..139b6b0 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -33,6 +33,7 @@ debug.c \ hnbap.c \ hnb.c \ + nas.c \ ranap.c \ rua.c \ vty.c \ diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index dc662aa..9c7a548 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -33,28 +33,12 @@ #include #include #include -#include -#include #include #include #include -#include - -#include -#include - -#include - -#include - -#include - -#include -#include -#include -#include +#include /* ranap_set_log_area() */ #include #include @@ -65,326 +49,11 @@ void *tall_hnb_ctx; struct hnb *g_hnb; -struct msgb *rua_new_udt(struct msgb *inmsg); - -static struct msgb *gen_nas_id_resp() -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - GSM48_MT_MM_ID_RESP, - /* IMEISV */ - 0x09, /* len */ - 0x03, /* first digit (0000) + even (0) + id IMEISV (011) */ - 0x31, 0x91, 0x06, 0x00, 0x28, 0x47, 0x11, /* digits */ - 0xf2, /* filler (1111) + last digit (0010) */ - }; - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct msgb *gen_nas_tmsi_realloc_compl() -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - GSM48_MT_MM_TMSI_REALL_COMPL, - }; - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct msgb *gen_nas_auth_resp(uint8_t *sres) -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - 0x80 | GSM48_MT_MM_AUTH_RESP, /* simulate sequence nr 2 */ - 0x61, 0xb5, 0x69, 0xf5 /* hardcoded SRES */ - }; - - memcpy(id_resp + 2, sres, 4); - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static int hnb_tx_dt(struct hnb *hnb, struct msgb *txm) -{ - struct hnb_chan *chan; - struct msgb *rua; - - chan = hnb->cs.chan; - if (!chan) { - printf("hnb_nas_tx_tmsi_realloc_compl(): No CS channel established yet.\n"); - return -1; - } - - rua = rua_new_dt(chan->is_ps, chan->conn_id, txm); - osmo_wqueue_enqueue(&hnb->wqueue, rua); - return 0; -} - -static struct tlv_parsed *parse_mm(struct gsm48_hdr *gh, int len) -{ - static struct tlv_parsed tp; - int parse_res; - - len -= (const char *)&gh->data[0] - (const char *)gh; - - OSMO_ASSERT(gsm48_hdr_pdisc(gh) == GSM48_PDISC_MM); - - parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); - if (parse_res <= 0) { - uint8_t msg_type = gsm48_hdr_msg_type(gh); - printf("Error parsing MM message 0x%hhx: %d\n", msg_type, parse_res); - return NULL; - } - - return &tp; -} - -int hnb_nas_rx_lu_accept(struct gsm48_hdr *gh, int len, int *sent_tmsi) -{ - printf(" :D Location Update Accept :D\n"); - struct gsm48_loc_area_id *lai; - - lai = (struct gsm48_loc_area_id *)&gh->data[0]; - - struct osmo_location_area_id laid; - gsm48_decode_lai2(lai, &laid); - printf("LU: mcc %s mnc %s lac %hd\n", - osmo_mcc_name(laid.plmn.mcc), osmo_mnc_name(laid.plmn.mnc, laid.plmn.mnc_3_digits), - laid.lac); - - struct tlv_parsed tp; - int parse_res; - - len -= (const char *)&gh->data[0] - (const char *)gh; - parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); - if (parse_res <= 0) { - printf("Error parsing Location Update Accept message: %d\n", parse_res); - return -1; - } - - if (TLVP_PRESENT(&tp, GSM48_IE_MOBILE_ID)) { - uint8_t type = TLVP_VAL(&tp, GSM48_IE_NAME_SHORT)[0] & 0x0f; - if (type == GSM_MI_TYPE_TMSI) - *sent_tmsi = 1; - else *sent_tmsi = 0; - } - return 0; -} - -void hnb_nas_rx_mm_info(struct gsm48_hdr *gh, int len) -{ - printf(" :) MM Info :)\n"); - struct tlv_parsed *tp = parse_mm(gh, len); - if (!tp) - return; - - if (TLVP_PRESENT(tp, GSM48_IE_NAME_SHORT)) { - char name[128] = {0}; - gsm_7bit_decode_n(name, 127, - TLVP_VAL(tp, GSM48_IE_NAME_SHORT)+1, - (TLVP_LEN(tp, GSM48_IE_NAME_SHORT)-1)*8/7); - printf("Info: Short Network Name: %s\n", name); - } - - if (TLVP_PRESENT(tp, GSM48_IE_NAME_LONG)) { - char name[128] = {0}; - gsm_7bit_decode_n(name, 127, - TLVP_VAL(tp, GSM48_IE_NAME_LONG)+1, - (TLVP_LEN(tp, GSM48_IE_NAME_LONG)-1)*8/7); - printf("Info: Long Network Name: %s\n", name); - } -} - -static int hnb_nas_rx_auth_req(struct hnb *hnb, struct gsm48_hdr *gh, - int len) -{ - struct gsm48_auth_req *ar; - - len -= (const char *)&gh->data[0] - (const char *)gh; - - if (len < sizeof(*ar)) { - printf("GSM48 Auth Req does not fit.\n"); - return -1; - } - - printf(" :) Authentication Request :)\n"); - - ar = (struct gsm48_auth_req*) &gh->data[0]; - int seq = ar->key_seq; - - /* Generate SRES from *HARDCODED* Ki for Iuh testing */ - struct osmo_auth_vector vec; - /* Ki 000102030405060708090a0b0c0d0e0f */ - struct osmo_sub_auth_data auth = { - .type = OSMO_AUTH_TYPE_GSM, - .algo = OSMO_AUTH_ALG_COMP128v1, - .u.gsm.ki = { - 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, - 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, - 0x0e, 0x0f - }, - }; - - memset(&vec, 0, sizeof(vec)); - osmo_auth_gen_vec(&vec, &auth, ar->rand); - - printf("seq %d rand %s", - seq, osmo_hexdump(ar->rand, sizeof(ar->rand))); - printf(" --> sres %s\n", - osmo_hexdump(vec.sres, 4)); - - return hnb_tx_dt(hnb, gen_nas_auth_resp(vec.sres)); -} - -void hnb_tx_iu_release_req(struct hnb *hnb) -{ - RANAP_Cause_t cause = { - .present = RANAP_Cause_PR_radioNetwork, - .choice.transmissionNetwork = RANAP_CauseRadioNetwork_release_due_to_UE_generated_signalling_connection_release, - }; - hnb_tx_dt(hnb, ranap_new_msg_iu_rel_req(&cause)); -} - -void hnb_tx_iu_release_compl(struct hnb *hnb) -{ - hnb_tx_dt(hnb, ranap_new_msg_iu_rel_compl()); -} - -static int hnb_nas_rx_mm(struct hnb *hnb, struct gsm48_hdr *gh, int len) -{ - struct hnb_chan *chan; - - chan = hnb->cs.chan; - if (!chan) { - printf("hnb_nas_rx_mm(): No CS channel established yet.\n"); - return -1; - } - - OSMO_ASSERT(!chan->is_ps); - - uint8_t msg_type = gsm48_hdr_msg_type(gh); - int sent_tmsi; - - switch (msg_type) { - case GSM48_MT_MM_ID_REQ: - return hnb_tx_dt(hnb, gen_nas_id_resp()); - - case GSM48_MT_MM_LOC_UPD_ACCEPT: - if (hnb_nas_rx_lu_accept(gh, len, &sent_tmsi)) - return -1; - if (sent_tmsi) - return hnb_tx_dt(hnb, gen_nas_tmsi_realloc_compl()); - else - return 0; - - case GSM48_MT_MM_LOC_UPD_REJECT: - printf("Received Location Update Reject\n"); - return 0; - - case GSM48_MT_MM_INFO: - hnb_nas_rx_mm_info(gh, len); - hnb_tx_iu_release_req(hnb); - return 0; - - case GSM48_MT_MM_AUTH_REQ: - return hnb_nas_rx_auth_req(hnb, gh, len); - - default: - printf("04.08 message type not handled by hnb-test: 0x%x\n", - msg_type); - return 0; - } - -} - -void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len) -{ - int rc; - printf("got %d bytes: %s\n", len, osmo_hexdump(data, len)); - - // nas_pdu == '05 08 12' ==> IMEI Identity request - // '05 04 0d' ==> LU reject - - struct gsm48_hdr *gh = data; - if (len < sizeof(*gh)) { - printf("hnb_nas_rx_dtap(): NAS PDU is too short: %d. Ignoring.\n", - len); - return; - } - uint8_t pdisc = gsm48_hdr_pdisc(gh); - - switch (pdisc) { - case GSM48_PDISC_MM: - rc = hnb_nas_rx_mm(hnb, gh, len); - if (rc != 0) - printf("Error receiving MM message: %d\n", rc); - return; - default: - printf("04.08 discriminator not handled by hnb-test: %d\n", - pdisc); - return; - } -} - -void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg) -{ - printf(" :) Security Mode Command :)\n"); - /* not caring about encryption yet, just pass 0 for No Encryption. */ - hnb_tx_dt(hnb, ranap_new_msg_sec_mod_compl(ip_alg, 0)); -} - -void hnb_rx_iu_release(struct hnb *hnb) -{ - hnb_tx_iu_release_compl(hnb); -} - -void hnb_rx_paging(struct hnb *hnb, const char *imsi) -{ - printf(" :) Paging Request for %s :)\n", imsi); - /* TODO reply */ -} - -extern void direct_transfer_nas_pdu_print(ANY_t *in); - static struct vty_app_info vty_info = { .name = "OsmohNodeB", .version = "0", }; - -struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi) -{ - uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST, - 0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57, - /* len, IMSI/type, IMSI-------------------------------- */ - 0x08, 0x29, 0x26, 0x24, 0x10, 0x32, 0x54, 0x76, 0x98, - 0x33, 0x03, 0x57, 0x18 , 0xb2 }; - uint8_t plmn_id[] = { 0x09, 0x01, 0x99 }; - RANAP_GlobalRNC_ID_t rnc_id = { - .rNC_ID = 23, - .pLMNidentity.buf = plmn_id, - .pLMNidentity.size = sizeof(plmn_id), - }; - - /* FIXME: patch imsi */ - /* Note: the Mobile Identitiy IE's IMSI data has the identity type and - * an even/odd indicator bit encoded in the first octet. So the first - * octet looks like this: - * - * 8 7 6 5 | 4 | 3 2 1 - * IMSI-digit | even/odd | type - * - * followed by the remaining IMSI digits. - * If digit count is even (bit 4 == 0), that first high-nibble is 0xf. - * (derived from Iu pcap Location Update Request msg and TS 25.413) - * - * TODO I'm only 90% sure about this - */ - - return ranap_new_msg_initial_ue(conn_id, is_ps, &rnc_id, lu, sizeof(lu)); -} - static void handle_options(int argc, char **argv) { while (1) { diff --git a/src/osmo-hnodeb/nas.c b/src/osmo-hnodeb/nas.c new file mode 100644 index 0000000..163f458 --- /dev/null +++ b/src/osmo-hnodeb/nas.c @@ -0,0 +1,268 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include +#include +#include + +#include +#include +#include +#include +#include + +#include + +#include +#include +#include +#include + +static struct msgb *gen_nas_id_resp() +{ + uint8_t id_resp[] = { + GSM48_PDISC_MM, + GSM48_MT_MM_ID_RESP, + /* IMEISV */ + 0x09, /* len */ + 0x03, /* first digit (0000) + even (0) + id IMEISV (011) */ + 0x31, 0x91, 0x06, 0x00, 0x28, 0x47, 0x11, /* digits */ + 0xf2, /* filler (1111) + last digit (0010) */ + }; + + return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); +} + +static struct msgb *gen_nas_tmsi_realloc_compl() +{ + uint8_t id_resp[] = { + GSM48_PDISC_MM, + GSM48_MT_MM_TMSI_REALL_COMPL, + }; + + return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); +} + +static struct msgb *gen_nas_auth_resp(uint8_t *sres) +{ + uint8_t id_resp[] = { + GSM48_PDISC_MM, + 0x80 | GSM48_MT_MM_AUTH_RESP, /* simulate sequence nr 2 */ + 0x61, 0xb5, 0x69, 0xf5 /* hardcoded SRES */ + }; + + memcpy(id_resp + 2, sres, 4); + + return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); +} + +static struct tlv_parsed *parse_mm(struct gsm48_hdr *gh, int len) +{ + static struct tlv_parsed tp; + int parse_res; + + len -= (const char *)&gh->data[0] - (const char *)gh; + + OSMO_ASSERT(gsm48_hdr_pdisc(gh) == GSM48_PDISC_MM); + + parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); + if (parse_res <= 0) { + uint8_t msg_type = gsm48_hdr_msg_type(gh); + printf("Error parsing MM message 0x%hhx: %d\n", msg_type, parse_res); + return NULL; + } + + return &tp; +} + +int hnb_nas_rx_lu_accept(struct gsm48_hdr *gh, int len, int *sent_tmsi) +{ + printf(" :D Location Update Accept :D\n"); + struct gsm48_loc_area_id *lai; + + lai = (struct gsm48_loc_area_id *)&gh->data[0]; + + struct osmo_location_area_id laid; + gsm48_decode_lai2(lai, &laid); + printf("LU: mcc %s mnc %s lac %hd\n", + osmo_mcc_name(laid.plmn.mcc), osmo_mnc_name(laid.plmn.mnc, laid.plmn.mnc_3_digits), + laid.lac); + + struct tlv_parsed tp; + int parse_res; + + len -= (const char *)&gh->data[0] - (const char *)gh; + parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); + if (parse_res <= 0) { + printf("Error parsing Location Update Accept message: %d\n", parse_res); + return -1; + } + + if (TLVP_PRESENT(&tp, GSM48_IE_MOBILE_ID)) { + uint8_t type = TLVP_VAL(&tp, GSM48_IE_NAME_SHORT)[0] & 0x0f; + if (type == GSM_MI_TYPE_TMSI) + *sent_tmsi = 1; + else *sent_tmsi = 0; + } + return 0; +} + +void hnb_nas_rx_mm_info(struct gsm48_hdr *gh, int len) +{ + printf(" :) MM Info :)\n"); + struct tlv_parsed *tp = parse_mm(gh, len); + if (!tp) + return; + + if (TLVP_PRESENT(tp, GSM48_IE_NAME_SHORT)) { + char name[128] = {0}; + gsm_7bit_decode_n(name, 127, + TLVP_VAL(tp, GSM48_IE_NAME_SHORT)+1, + (TLVP_LEN(tp, GSM48_IE_NAME_SHORT)-1)*8/7); + printf("Info: Short Network Name: %s\n", name); + } + + if (TLVP_PRESENT(tp, GSM48_IE_NAME_LONG)) { + char name[128] = {0}; + gsm_7bit_decode_n(name, 127, + TLVP_VAL(tp, GSM48_IE_NAME_LONG)+1, + (TLVP_LEN(tp, GSM48_IE_NAME_LONG)-1)*8/7); + printf("Info: Long Network Name: %s\n", name); + } +} + +static int hnb_nas_rx_auth_req(struct hnb *hnb, struct gsm48_hdr *gh, + int len) +{ + struct gsm48_auth_req *ar; + + len -= (const char *)&gh->data[0] - (const char *)gh; + + if (len < sizeof(*ar)) { + printf("GSM48 Auth Req does not fit.\n"); + return -1; + } + + printf(" :) Authentication Request :)\n"); + + ar = (struct gsm48_auth_req*) &gh->data[0]; + int seq = ar->key_seq; + + /* Generate SRES from *HARDCODED* Ki for Iuh testing */ + struct osmo_auth_vector vec; + /* Ki 000102030405060708090a0b0c0d0e0f */ + struct osmo_sub_auth_data auth = { + .type = OSMO_AUTH_TYPE_GSM, + .algo = OSMO_AUTH_ALG_COMP128v1, + .u.gsm.ki = { + 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, + 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, + 0x0e, 0x0f + }, + }; + + memset(&vec, 0, sizeof(vec)); + osmo_auth_gen_vec(&vec, &auth, ar->rand); + + printf("seq %d rand %s", + seq, osmo_hexdump(ar->rand, sizeof(ar->rand))); + printf(" --> sres %s\n", + osmo_hexdump(vec.sres, 4)); + + return hnb_tx_dt(hnb, gen_nas_auth_resp(vec.sres)); +} + +static int hnb_nas_rx_mm(struct hnb *hnb, struct gsm48_hdr *gh, int len) +{ + struct hnb_chan *chan; + + chan = hnb->cs.chan; + if (!chan) { + printf("hnb_nas_rx_mm(): No CS channel established yet.\n"); + return -1; + } + + OSMO_ASSERT(!chan->is_ps); + + uint8_t msg_type = gsm48_hdr_msg_type(gh); + int sent_tmsi; + + switch (msg_type) { + case GSM48_MT_MM_ID_REQ: + return hnb_tx_dt(hnb, gen_nas_id_resp()); + + case GSM48_MT_MM_LOC_UPD_ACCEPT: + if (hnb_nas_rx_lu_accept(gh, len, &sent_tmsi)) + return -1; + if (sent_tmsi) + return hnb_tx_dt(hnb, gen_nas_tmsi_realloc_compl()); + else + return 0; + + case GSM48_MT_MM_LOC_UPD_REJECT: + printf("Received Location Update Reject\n"); + return 0; + + case GSM48_MT_MM_INFO: + hnb_nas_rx_mm_info(gh, len); + hnb_tx_iu_release_req(hnb); + return 0; + + case GSM48_MT_MM_AUTH_REQ: + return hnb_nas_rx_auth_req(hnb, gh, len); + + default: + printf("04.08 message type not handled by hnb-test: 0x%x\n", + msg_type); + return 0; + } + +} + +void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len) +{ + int rc; + printf("got %d bytes: %s\n", len, osmo_hexdump(data, len)); + + // nas_pdu == '05 08 12' ==> IMEI Identity request + // '05 04 0d' ==> LU reject + + struct gsm48_hdr *gh = data; + if (len < sizeof(*gh)) { + printf("hnb_nas_rx_dtap(): NAS PDU is too short: %d. Ignoring.\n", + len); + return; + } + uint8_t pdisc = gsm48_hdr_pdisc(gh); + + switch (pdisc) { + case GSM48_PDISC_MM: + rc = hnb_nas_rx_mm(hnb, gh, len); + if (rc != 0) + printf("Error receiving MM message: %d\n", rc); + return; + default: + printf("04.08 discriminator not handled by hnb-test: %d\n", + pdisc); + return; + } +} diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c index a6a92cc..8f1b9c0 100644 --- a/src/osmo-hnodeb/ranap.c +++ b/src/osmo-hnodeb/ranap.c @@ -18,11 +18,15 @@ * */ #include +#include #include #include #include +#include +#include +#include #include static const char *printstr(OCTET_STRING_t *s) @@ -105,3 +109,67 @@ return; } } + +struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi) +{ + uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST, + 0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57, + /* len, IMSI/type, IMSI-------------------------------- */ + 0x08, 0x29, 0x26, 0x24, 0x10, 0x32, 0x54, 0x76, 0x98, + 0x33, 0x03, 0x57, 0x18 , 0xb2 }; + uint8_t plmn_id[] = { 0x09, 0x01, 0x99 }; + RANAP_GlobalRNC_ID_t rnc_id = { + .rNC_ID = 23, + .pLMNidentity.buf = plmn_id, + .pLMNidentity.size = sizeof(plmn_id), + }; + + /* FIXME: patch imsi */ + /* Note: the Mobile Identitiy IE's IMSI data has the identity type and + * an even/odd indicator bit encoded in the first octet. So the first + * octet looks like this: + * + * 8 7 6 5 | 4 | 3 2 1 + * IMSI-digit | even/odd | type + * + * followed by the remaining IMSI digits. + * If digit count is even (bit 4 == 0), that first high-nibble is 0xf. + * (derived from Iu pcap Location Update Request msg and TS 25.413) + * + * TODO I'm only 90% sure about this + */ + + return ranap_new_msg_initial_ue(conn_id, is_ps, &rnc_id, lu, sizeof(lu)); +} + +void hnb_tx_iu_release_req(struct hnb *hnb) +{ + RANAP_Cause_t cause = { + .present = RANAP_Cause_PR_radioNetwork, + .choice.transmissionNetwork = RANAP_CauseRadioNetwork_release_due_to_UE_generated_signalling_connection_release, + }; + hnb_tx_dt(hnb, ranap_new_msg_iu_rel_req(&cause)); +} + +void hnb_tx_iu_release_compl(struct hnb *hnb) +{ + hnb_tx_dt(hnb, ranap_new_msg_iu_rel_compl()); +} + +void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg) +{ + printf(" :) Security Mode Command :)\n"); + /* not caring about encryption yet, just pass 0 for No Encryption. */ + hnb_tx_dt(hnb, ranap_new_msg_sec_mod_compl(ip_alg, 0)); +} + +void hnb_rx_iu_release(struct hnb *hnb) +{ + hnb_tx_iu_release_compl(hnb); +} + +void hnb_rx_paging(struct hnb *hnb, const char *imsi) +{ + printf(" :) Paging Request for %s :)\n", imsi); + /* TODO reply */ +} diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 0839c0d..229df30 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -24,10 +24,26 @@ #include #include +#include #include #include +int hnb_tx_dt(struct hnb *hnb, struct msgb *txm) +{ + struct hnb_chan *chan; + struct msgb *rua; + + chan = hnb->cs.chan; + if (!chan) { + printf("hnb_nas_tx_tmsi_realloc_compl(): No CS channel established yet.\n"); + return -1; + } + + rua = rua_new_dt(chan->is_ps, chan->conn_id, txm); + osmo_wqueue_enqueue(&hnb->wqueue, rua); + return 0; +} static void hnb_rua_dt_handle(struct hnb *hnb, ANY_t *in) { diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index b8dc7da..114f1c0 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -33,6 +33,7 @@ #include #include +#include #include #include -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I771b3d3f61207137477eed2b316a5f670fb79ef2 Gerrit-Change-Number: 26002 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:35 +0000 Subject: Change in osmo-hnodeb[master]: main.c: Fix cap in naming for vty_info.name In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26012 ) Change subject: main.c: Fix cap in naming for vty_info.name ...................................................................... main.c: Fix cap in naming for vty_info.name It was decided the program name is OsmoHNodeB, and we already use that one everywhere. Change-Id: I8ce83aa17ad7dd3ec991e4d7d9cca01dc1bf4681 --- M src/osmo-hnodeb/main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 9c7a548..b2ce276 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -50,7 +50,7 @@ struct hnb *g_hnb; static struct vty_app_info vty_info = { - .name = "OsmohNodeB", + .name = "OsmoHNodeB", .version = "0", }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I8ce83aa17ad7dd3ec991e4d7d9cca01dc1bf4681 Gerrit-Change-Number: 26012 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:36 +0000 Subject: Change in osmo-hnodeb[master]: More work on main.c to add osmocom functionalitites In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26013 ) Change subject: More work on main.c to add osmocom functionalitites ...................................................................... More work on main.c to add osmocom functionalitites Change-Id: I61a5ee2e100f79cef7e42dbd981e308597c30900 --- M src/osmo-hnodeb/main.c 1 file changed, 205 insertions(+), 15 deletions(-) Approvals: pespin: Looks good to me, approved; Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index b2ce276..cbf606d 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -37,6 +37,9 @@ #include #include #include +#include +#include +#include #include /* ranap_set_log_area() */ @@ -46,44 +49,191 @@ #include #include +static const char * const osmohnodeb_copyright = + "OsmoHNodeB - Osmocom 3G Home NodeB implementation\r\n" + "Copyright (C) 2015 by Daniel Willmann \r\n" + "Based on initial work (hnb-test) by Daniel Willmann\r\n" + "Contributions by Pau Espin Pedrol\r\n\r\n" + "License AGPLv3+: GNU AGPL version 3 or later \r\n" + "This is free software: you are free to change and redistribute it.\r\n" + "There is NO WARRANTY, to the extent permitted by law.\r\n"; + void *tall_hnb_ctx; struct hnb *g_hnb; +static struct { + const char *database_name; + const char *config_file; + int daemonize; + const char *mncc_sock_path; +} hnb_cmdline_config = { + .database_name = NULL, + .config_file = "osmo-hnodeb.cfg", +}; + static struct vty_app_info vty_info = { .name = "OsmoHNodeB", - .version = "0", + .version = PACKAGE_VERSION, }; +static void print_usage() +{ + printf("Usage: osmo-hnodeb\n"); +} + +static void print_help() +{ + printf("Some useful options:\n"); + printf(" -h --help This text.\n"); + printf(" -d option --debug=DCC:DMM:DRR: Enable debugging.\n"); + printf(" -D --daemonize Fork the process into a background daemon.\n"); + printf(" -c --config-file filename The config file to use.\n"); + printf(" -s --disable-color\n"); + printf(" -T --timestamp Prefix every log line with a timestamp.\n"); + printf(" -V --version Print the version of OsmoHNodeB.\n"); + printf(" -e --log-level number Set a global loglevel.\n"); + + printf("\nVTY reference generation:\n"); + printf(" --vty-ref-mode MODE VTY reference generation mode (e.g. 'expert').\n"); + printf(" --vty-ref-xml Generate the VTY reference XML output and exit.\n"); +} + +static void handle_long_options(const char *prog_name, const int long_option) +{ + static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT; + + switch (long_option) { + case 1: + vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg); + if (vty_ref_mode < 0) { + fprintf(stderr, "%s: Unknown VTY reference generation " + "mode '%s'\n", prog_name, optarg); + exit(2); + } + break; + case 2: + fprintf(stderr, "Generating the VTY reference in mode '%s' (%s)\n", + get_value_string(vty_ref_gen_mode_names, vty_ref_mode), + get_value_string(vty_ref_gen_mode_desc, vty_ref_mode)); + vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode) vty_ref_mode); + exit(0); + default: + fprintf(stderr, "%s: error parsing cmdline options\n", prog_name); + exit(2); + } +} + static void handle_options(int argc, char **argv) { while (1) { int idx = 0, c; + static int long_option = 0; static const struct option long_options[] = { + {"help", 0, 0, 'h'}, + {"debug", 1, 0, 'd'}, + {"daemonize", 0, 0, 'D'}, + {"config-file", 1, 0, 'c'}, + {"disable-color", 0, 0, 's'}, + {"timestamp", 0, 0, 'T'}, + {"version", 0, 0, 'V' }, + {"log-level", 1, 0, 'e'}, + {"vty-ref-mode", 1, &long_option, 1}, + {"vty-ref-xml", 0, &long_option, 2}, { "ues", 1, 0, 'u' }, { "gw-addr", 1, 0, 'g' }, { 0, 0, 0, 0 }, }; - c = getopt_long(argc, argv, "u:g:", long_options, &idx); + c = getopt_long(argc, argv, "hd:Dc:sTVe:u:g:", long_options, &idx); if (c == -1) break; switch (c) { + case 'h': + print_usage(); + print_help(); + exit(0); + case 0: + handle_long_options(argv[0], long_option); + break; + case 'd': + log_parse_category_mask(osmo_stderr_target, optarg); + break; + case 'D': + hnb_cmdline_config.daemonize = 1; + break; + case 'c': + hnb_cmdline_config.config_file = optarg; + break; + case 's': + log_set_use_color(osmo_stderr_target, 0); + break; + case 'T': + log_set_print_timestamp(osmo_stderr_target, 1); + break; + case 'V': + print_version(1); + exit(0); + break; + case 'e': + log_set_log_level(osmo_stderr_target, atoi(optarg)); + break; case 'u': g_hnb->ues = atoi(optarg); break; case 'g': g_hnb->gw_addr = optarg; break; + default: + /* catch unknown options *as well as* missing arguments. */ + fprintf(stderr, "Error in command line options. Exiting.\n"); + exit(-1); } } } +static void signal_handler(int signum) +{ + fprintf(stdout, "signal %u received\n", signum); + + switch (signum) { + case SIGINT: + case SIGTERM: + /* If SIGTERM was already sent before, just terminate immediately. */ + if (osmo_select_shutdown_requested()) + exit(-1); + osmo_select_shutdown_request(); + break; + case SIGABRT: + /* in case of abort, we want to obtain a talloc report and + * then run default SIGABRT handler, who will generate coredump + * and abort the process. abort() should do this for us after we + * return, but program wouldn't exit if an external SIGABRT is + * received. + */ + talloc_report(tall_vty_ctx, stderr); + talloc_report_full(tall_hnb_ctx, stderr); + signal(SIGABRT, SIG_DFL); + raise(SIGABRT); + break; + case SIGUSR1: + talloc_report(tall_vty_ctx, stderr); + talloc_report_full(tall_hnb_ctx, stderr); + break; + default: + break; + } +} + int main(int argc, char **argv) { int rc; + /* Track the use of talloc NULL memory contexts */ + talloc_enable_null_tracking(); + tall_hnb_ctx = talloc_named_const(NULL, 0, "hnb_context"); msgb_talloc_ctx_init(tall_hnb_ctx, 0); @@ -95,36 +245,76 @@ ranap_set_log_area(DRANAP); - log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); - log_set_use_color(osmo_stderr_target, 0); - log_set_print_category(osmo_stderr_target, 0); - log_set_print_category_hex(osmo_stderr_target, 0); + vty_info.copyright = osmohnodeb_copyright; + vty_info.tall_ctx = tall_hnb_ctx; + vty_init(&vty_info); + logging_vty_add_cmds(); + osmo_talloc_vty_add_cmds(); + osmo_cpu_sched_vty_init(tall_hnb_ctx); g_hnb = hnb_alloc(tall_hnb_ctx); - - vty_init(&vty_info); hnb_vty_init(); - rc = telnet_init_dynif(NULL, NULL, vty_get_bind_addr(), 2324); + handle_options(argc, argv); + + + rc = vty_read_config_file(hnb_cmdline_config.config_file, NULL); + if (rc < 0) { + fprintf(stderr, "Failed to parse the config file: '%s'\n", + hnb_cmdline_config.config_file); + exit(1); + } + + rc = telnet_init_dynif(tall_hnb_ctx, g_hnb, vty_get_bind_addr(), OSMO_VTY_PORT_HNODEB); if (rc < 0) { perror("Error binding VTY port"); exit(1); } - handle_options(argc, argv); - rc = hnb_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); exit(1); } - while (1) { - rc = osmo_select_main(0); - if (rc < 0) - exit(3); + signal(SIGINT, &signal_handler); + signal(SIGTERM, &signal_handler); + signal(SIGABRT, &signal_handler); + signal(SIGUSR1, &signal_handler); + signal(SIGUSR2, &signal_handler); + osmo_init_ignore_signals(); + + if (hnb_cmdline_config.daemonize) { + rc = osmo_daemonize(); + if (rc < 0) { + perror("Error during daemonize"); + return 6; + } } + while (!osmo_select_shutdown_done()) { + osmo_select_main_ctx(0); + } + + log_fini(); + + /** + * Report the heap state of root context, then free, + * so both ASAN and Valgrind are happy... + */ + talloc_report_full(tall_hnb_ctx, stderr); + talloc_free(tall_hnb_ctx); + + /* FIXME: VTY code still uses NULL-context */ + talloc_free(tall_vty_ctx); + + /** + * Report the heap state of NULL context, then free, + * so both ASAN and Valgrind are happy... + */ + talloc_report_full(NULL, stderr); + talloc_disable_null_tracking(); + /* not reached */ exit(0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I61a5ee2e100f79cef7e42dbd981e308597c30900 Gerrit-Change-Number: 26013 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:37 +0000 Subject: Change in osmo-hnodeb[master]: Set up Iuh conn params through VTY In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26014 ) Change subject: Set up Iuh conn params through VTY ...................................................................... Set up Iuh conn params through VTY Change-Id: Id5a17742643e8f02c22228e3055bcc213423a416 --- M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 5 files changed, 146 insertions(+), 19 deletions(-) Approvals: pespin: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 50432d1..effd1b8 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -70,8 +70,12 @@ }; struct hnb { - const char *gw_addr; - uint16_t gw_port; + struct { + char *local_addr; + uint16_t local_port; + char *remote_addr; + uint16_t remote_port; + } iuh; /*! SCTP listen socket for incoming connections */ struct osmo_fd conn_fd; @@ -91,8 +95,6 @@ uint32_t ctx_id; - int ues; - struct { struct hnb_chan *chan; } cs; diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h index 7e3f29f..7144d3f 100644 --- a/include/osmocom/hnodeb/vty.h +++ b/include/osmocom/hnodeb/vty.h @@ -25,7 +25,10 @@ #include enum hnb_vty_nodes { - CHAN_NODE = _LAST_OSMOVTY_NODE, + HNODEB_NODE = _LAST_OSMOVTY_NODE, + IUH_NODE, + CHAN_NODE, }; void hnb_vty_init(void); +int hnb_vty_go_parent(struct vty *vty); diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 335fd3a..85ca937 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -137,8 +137,10 @@ if (!hnb) return NULL; - hnb->gw_addr = "127.0.0.1", - hnb->gw_port = IUH_DEFAULT_SCTP_PORT, + hnb->iuh.local_addr = NULL; + hnb->iuh.local_port = 0; + hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); + hnb->iuh.remote_port = IUH_DEFAULT_SCTP_PORT; osmo_wqueue_init(&hnb->wqueue, 16); hnb->wqueue.bfd.data = hnb; @@ -151,9 +153,14 @@ int hnb_connect(struct hnb *hnb) { int rc; - rc = osmo_sock_init_ofd(&hnb->wqueue.bfd, AF_INET, SOCK_STREAM, - IPPROTO_SCTP, hnb->gw_addr, - hnb->gw_port, OSMO_SOCK_F_CONNECT); + + LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", + hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); + + rc = osmo_sock_init2_ofd(&hnb->wqueue.bfd, AF_INET, SOCK_STREAM, IPPROTO_SCTP, + hnb->iuh.local_addr, hnb->iuh.local_port, + hnb->iuh.remote_addr, hnb->iuh.remote_port, + OSMO_SOCK_F_BIND |OSMO_SOCK_F_CONNECT); if (rc < 0) return rc; sctp_sock_init(hnb->wqueue.bfd.fd); diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index cbf606d..3376d8e 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -75,6 +75,7 @@ static struct vty_app_info vty_info = { .name = "OsmoHNodeB", .version = PACKAGE_VERSION, + .go_parent_cb = hnb_vty_go_parent, }; static void print_usage() @@ -140,12 +141,10 @@ {"log-level", 1, 0, 'e'}, {"vty-ref-mode", 1, &long_option, 1}, {"vty-ref-xml", 0, &long_option, 2}, - { "ues", 1, 0, 'u' }, - { "gw-addr", 1, 0, 'g' }, { 0, 0, 0, 0 }, }; - c = getopt_long(argc, argv, "hd:Dc:sTVe:u:g:", long_options, &idx); + c = getopt_long(argc, argv, "hd:Dc:sTVe:", long_options, &idx); if (c == -1) break; @@ -180,12 +179,6 @@ case 'e': log_set_log_level(osmo_stderr_target, atoi(optarg)); break; - case 'u': - g_hnb->ues = atoi(optarg); - break; - case 'g': - g_hnb->gw_addr = optarg; - break; default: /* catch unknown options *as well as* missing arguments. */ fprintf(stderr, "Error in command line options. Exiting.\n"); diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 114f1c0..4d665f8 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -37,6 +37,119 @@ #include #include +int hnb_vty_go_parent(struct vty *vty) +{ + switch (vty->node) { + case IUH_NODE: + vty->node = HNODEB_NODE; + vty->index = g_hnb; + break; + case HNODEB_NODE: + vty->node = CONFIG_NODE; + vty->index = g_hnb; + break; + case CONFIG_NODE: + vty->node = ENABLE_NODE; + vty->index = NULL; + break; + default: + vty->node = CONFIG_NODE; + vty->index = NULL; + break; + } + + return vty->node; +} + +static struct cmd_node hnodeb_node = { + HNODEB_NODE, + "%s(config-hnodeb)# ", + 1, +}; + +#define HNODEB_STR "Configure the HNodeB\n" + +DEFUN(cfg_hnodeb, + cfg_hnodeb_cmd, + "hnodeb", HNODEB_STR) +{ + OSMO_ASSERT(g_hnb); + vty->index = g_hnb; + vty->node = HNODEB_NODE; + + return CMD_SUCCESS; +} + +static struct cmd_node iuh_node = { + IUH_NODE, + "%s(config-iuh)# ", + 1, +}; + +DEFUN(cfg_hnodeb_iuh, + cfg_hnodeb_iuh_cmd, + "iuh", "Configure Iuh options\n") +{ + OSMO_ASSERT(g_hnb); + vty->index = g_hnb; + vty->node = IUH_NODE; + + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_iuh_local_ip, cfg_hnodeb_iuh_local_ip_cmd, + "local-ip " VTY_IPV46_CMD, + "Bind Iuh connection on local IP address\n" + "Local interface IPv4 address\n" + "Local interface IPv6 address\n") +{ + osmo_talloc_replace_string(g_hnb, &g_hnb->iuh.local_addr, argv[0]); + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_iuh_local_port, cfg_hnodeb_iuh_local_port_cmd, + "local-port <1-65535>", + "Bind Iuh connection on local SCTP port\n" + "Local interface port\n") +{ + g_hnb->iuh.local_port = atoi(argv[0]); + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_iuh_remote_ip, cfg_hnodeb_iuh_remote_ip_cmd, + "remote-ip " VTY_IPV46_CMD, + "Connect to HNBGW over Iuh on remote IP address\n" + "Remote interface IPv4 address\n" + "Remote interface IPv6 address\n") +{ + osmo_talloc_replace_string(g_hnb, &g_hnb->iuh.remote_addr, argv[0]); + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_iuh_remote_port, cfg_hnodeb_iuh_remote_port_cmd, + "remote-port <1-65535>", + "Connect to HNBGW over Iuh on remote SCTP port\n" + "Remote interface port (default: "OSMO_STRINGIFY_VAL(IUH_DEFAULT_SCTP_PORT) ")\n") +{ + g_hnb->iuh.remote_port = atoi(argv[0]); + return CMD_SUCCESS; +} + + +static int config_write_hnodeb(struct vty *vty) +{ + vty_out(vty, "hnodeb%s", VTY_NEWLINE); + vty_out(vty, " iuh%s", VTY_NEWLINE); + if (g_hnb->iuh.local_addr) + vty_out(vty, " local-ip %s%s", g_hnb->iuh.local_addr, VTY_NEWLINE); + if (g_hnb->iuh.local_port) + vty_out(vty, " local-port %u%s", g_hnb->iuh.local_port, VTY_NEWLINE); + vty_out(vty, " remote-ip %s%s", g_hnb->iuh.remote_addr, VTY_NEWLINE); + vty_out(vty, " remote-port %u%s", g_hnb->iuh.remote_port, VTY_NEWLINE); + return CMD_SUCCESS; +} + + static struct cmd_node chan_node = { CHAN_NODE, "%s(chan)> ", @@ -139,6 +252,15 @@ void hnb_vty_init(void) { + install_element(CONFIG_NODE, &cfg_hnodeb_cmd); + install_node(&hnodeb_node, config_write_hnodeb); + install_element(HNODEB_NODE, &cfg_hnodeb_iuh_cmd); + install_node(&iuh_node, NULL); + install_element(IUH_NODE, &cfg_hnodeb_iuh_local_ip_cmd); + install_element(IUH_NODE, &cfg_hnodeb_iuh_local_port_cmd); + install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_ip_cmd); + install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_port_cmd); + install_element_ve(&asn_dbg_cmd); install_element_ve(&hnb_register_cmd); install_element_ve(&hnb_deregister_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id5a17742643e8f02c22228e3055bcc213423a416 Gerrit-Change-Number: 26014 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:38 +0000 Subject: Change in osmo-hnodeb[master]: Drop unused fields in struct hnb In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26015 ) Change subject: Drop unused fields in struct hnb ...................................................................... Drop unused fields in struct hnb Change-Id: Ia981d99bf521eb8b79bdf8d7f81ca50f6cdeba8c --- M include/osmocom/hnodeb/hnodeb.h 1 file changed, 0 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index effd1b8..864892a 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -46,23 +46,6 @@ #define IUH_MSGB_SIZE 2048 -struct umts_cell_id { - uint16_t mcc; /*!< Mobile Country Code */ - uint16_t mnc; /*!< Mobile Network Code */ - uint16_t lac; /*!< Locaton Area Code */ - uint16_t rac; /*!< Routing Area Code */ - uint16_t sac; /*!< Service Area Code */ - uint32_t cid; /*!< Cell ID */ -}; - -struct ue_context { - /*! Entry in the HNB-global list of UE */ - struct llist_head list; - /*! Unique Context ID for this UE */ - uint32_t context_id; - char imsi[16+1]; -}; - struct hnb_chan { int is_ps; uint32_t conn_id; @@ -76,20 +59,8 @@ char *remote_addr; uint16_t remote_port; } iuh; - /*! SCTP listen socket for incoming connections */ - struct osmo_fd conn_fd; - /*! SCTP socket + write queue for Iuh to this specific HNB */ struct osmo_wqueue wqueue; - /*! copied from HNB-Identity-Info IE */ - char identity_info[256]; - /*! copied from Cell Identity IE */ - struct umts_cell_id id; - - /*! SCTP stream ID for HNBAP */ - uint16_t hnbap_stream; - /*! SCTP stream ID for RUA */ - uint16_t rua_stream; uint16_t rnc_id; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ia981d99bf521eb8b79bdf8d7f81ca50f6cdeba8c Gerrit-Change-Number: 26015 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:39 +0000 Subject: Change in osmo-hnodeb[master]: hnb: Move wqueue to .iuh, add wrapper to use it In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26016 ) Change subject: hnb: Move wqueue to .iuh, add wrapper to use it ...................................................................... hnb: Move wqueue to .iuh, add wrapper to use it Change-Id: I38498858fc315ad3d57644d7b905f5393f43e884 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnbap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 5 files changed, 27 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 864892a..fb0c0fb 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -58,9 +58,9 @@ uint16_t local_port; char *remote_addr; uint16_t remote_port; + /*! SCTP socket + write queue for Iuh to this specific HNB */ + struct osmo_wqueue wqueue; } iuh; - /*! SCTP socket + write queue for Iuh to this specific HNB */ - struct osmo_wqueue wqueue; uint16_t rnc_id; @@ -73,5 +73,7 @@ struct hnb *hnb_alloc(void *tall_ctx); int hnb_connect(struct hnb *hnb); +int hnb_iuh_send(struct hnb *hnb, struct msgb *msg); + extern void *tall_hnb_ctx; extern struct hnb *g_hnb; diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 85ca937..145c021 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -49,7 +49,7 @@ return rc; } -static int hnb_read_cb(struct osmo_fd *fd) +static int hnb_iuh_read_cb(struct osmo_fd *fd) { struct hnb *hnb = fd->data; struct sctp_sndrcvinfo sinfo; @@ -114,7 +114,7 @@ return rc; } -static int hnb_write_cb(struct osmo_fd *fd, struct msgb *msg) +static int hnb_iuh_write_cb(struct osmo_fd *fd, struct msgb *msg) { /* struct hnb *ctx = fd->data; */ struct sctp_sndrcvinfo sinfo = { @@ -142,10 +142,10 @@ hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); hnb->iuh.remote_port = IUH_DEFAULT_SCTP_PORT; - osmo_wqueue_init(&hnb->wqueue, 16); - hnb->wqueue.bfd.data = hnb; - hnb->wqueue.read_cb = hnb_read_cb; - hnb->wqueue.write_cb = hnb_write_cb; + osmo_wqueue_init(&hnb->iuh.wqueue, 16); + hnb->iuh.wqueue.bfd.data = hnb; + hnb->iuh.wqueue.read_cb = hnb_iuh_read_cb; + hnb->iuh.wqueue.write_cb = hnb_iuh_write_cb; return hnb; } @@ -157,12 +157,21 @@ LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); - rc = osmo_sock_init2_ofd(&hnb->wqueue.bfd, AF_INET, SOCK_STREAM, IPPROTO_SCTP, + rc = osmo_sock_init2_ofd(&hnb->iuh.wqueue.bfd, AF_INET, SOCK_STREAM, IPPROTO_SCTP, hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port, OSMO_SOCK_F_BIND |OSMO_SOCK_F_CONNECT); if (rc < 0) return rc; - sctp_sock_init(hnb->wqueue.bfd.fd); + sctp_sock_init(hnb->iuh.wqueue.bfd.fd); return 0; } + +int hnb_iuh_send(struct hnb *hnb, struct msgb *msg) +{ + int rc; + rc = osmo_wqueue_enqueue(&hnb->iuh.wqueue, msg); + if (rc < 0) + msgb_free(msg); + return rc; +} diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 7e54004..7cd9cd6 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -145,7 +145,7 @@ msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; - return osmo_wqueue_enqueue(&hnb->wqueue, msg); + return hnb_iuh_send(hnb, msg); } void hnb_send_register_req(struct hnb *hnb) @@ -194,7 +194,7 @@ msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; - osmo_wqueue_enqueue(&hnb->wqueue, msg); + hnb_iuh_send(hnb, msg); } void hnb_send_deregister_req(struct hnb *hnb) @@ -222,5 +222,5 @@ msgb_sctp_ppid(msg) = IUH_PPI_HNBAP; - osmo_wqueue_enqueue(&hnb->wqueue, msg); + hnb_iuh_send(hnb, msg); } diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 229df30..d7352b6 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -41,7 +41,7 @@ } rua = rua_new_dt(chan->is_ps, chan->conn_id, txm); - osmo_wqueue_enqueue(&hnb->wqueue, rua); + hnb_iuh_send(hnb, rua); return 0; } diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 4d665f8..989b7e8 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -211,7 +211,7 @@ msg = ranap_new_msg_reset(is_ps, &cause); rua = rua_new_udt(msg); //msgb_free(msg); - osmo_wqueue_enqueue(&g_hnb->wqueue, rua); + hnb_iuh_send(g_hnb, rua); return CMD_SUCCESS; } @@ -238,7 +238,7 @@ msg = gen_initue_lu(chan->is_ps, chan->conn_id, chan->imsi); rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); - osmo_wqueue_enqueue(&g_hnb->wqueue, rua); + hnb_iuh_send(g_hnb, rua); vty->index = chan; vty->node = CHAN_NODE; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I38498858fc315ad3d57644d7b905f5393f43e884 Gerrit-Change-Number: 26016 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:40 +0000 Subject: Change in osmo-hnodeb[master]: Use osmocom logging in non-main files In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017 ) Change subject: Use osmocom logging in non-main files ...................................................................... Use osmocom logging in non-main files Change-Id: I649b17803aeffd20354aa76dde61094959f08e43 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnbap.c M src/osmo-hnodeb/nas.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c 7 files changed, 64 insertions(+), 58 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index fb0c0fb..9da6044 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -31,6 +31,7 @@ DHNBAP, DRUA, DRANAP, + DNAS, }; extern const struct log_info hnb_log_info; diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index 69c369e..f50d8b0 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -23,25 +23,30 @@ static const struct log_info_cat log_cat[] = { [DMAIN] = { - .name = "DMAIN", .loglevel = LOGL_INFO, .enabled = 1, + .name = "DMAIN", .loglevel = LOGL_NOTICE, .enabled = 1, .color = "", .description = "Main program", }, [DHNBAP] = { - .name = "DHNBAP", .loglevel = LOGL_DEBUG, .enabled = 1, - .color = "", + .name = "DHNBAP", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;33m", .description = "Home Node B Application Part", }, [DRANAP] = { - .name = "RANAP", .loglevel = LOGL_DEBUG, .enabled = 1, - .color = "", + .name = "RANAP", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;34m", .description = "RAN Application Part", }, [DRUA] = { - .name = "RUA", .loglevel = LOGL_DEBUG, .enabled = 1, - .color = "", + .name = "RUA", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;35m", .description = "RANAP User Adaptation", }, + [DNAS] = { + .name = "NAS", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;32m", + .description = "Non-Access Stratum", + }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 145c021..9a86019 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -89,11 +89,11 @@ switch (sinfo.sinfo_ppid) { case IUH_PPI_HNBAP: - printf("HNBAP message received\n"); + LOGP(DHNBAP, LOGL_INFO, "HNBAP message received\n"); rc = hnb_hnbap_rx(hnb, msg); break; case IUH_PPI_RUA: - printf("RUA message received\n"); + LOGP(DRUA, LOGL_INFO, "RUA message received\n"); rc = hnb_rua_rx(hnb, msg); break; case IUH_PPI_SABP: @@ -123,7 +123,7 @@ }; int rc; - printf("Sending: %s\n", osmo_hexdump(msgb_data(msg), msgb_length(msg))); + LOGP(DMAIN, LOGL_DEBUG, "Sending: %s\n", osmo_hexdump(msgb_data(msg), msgb_length(msg))); rc = sctp_send(fd->fd, msgb_data(msg), msgb_length(msg), &sinfo, 0); /* we don't need to msgb_free(), write_queue does this for us */ diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 7cd9cd6..eaa51a4 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -43,7 +43,7 @@ } hnb->rnc_id = accept.rnc_id; - printf("HNB Register accept with RNC ID %u\n", hnb->rnc_id); + LOGP(DHNBAP, LOGL_INFO, "HNB Register accept with RNC ID %u\n", hnb->rnc_id); hnbap_free_hnbregisteraccepties(&accept); return 0; @@ -62,7 +62,7 @@ } if (accept.uE_Identity.present != HNBAP_UE_Identity_PR_iMSI) { - printf("Wrong type in UE register accept\n"); + LOGP(DHNBAP, LOGL_ERROR, "Wrong type in UE register accept\n"); return -1; } @@ -70,7 +70,7 @@ ranap_bcd_decode(imsi, sizeof(imsi), accept.uE_Identity.choice.iMSI.buf, accept.uE_Identity.choice.iMSI.size); - printf("UE Register accept for IMSI %s, context %u\n", imsi, ctx_id); + LOGP(DHNBAP, LOGL_INFO, "UE Register accept for IMSI %s, context %u\n", imsi, ctx_id); hnb->ctx_id = ctx_id; hnbap_free_ueregisteraccepties(&accept); @@ -93,7 +93,7 @@ } if (pdu->present != HNBAP_HNBAP_PDU_PR_successfulOutcome) { - printf("Unexpected HNBAP message received\n"); + LOGP(DHNBAP, LOGL_ERROR, "Unexpected HNBAP message received\n"); } switch (pdu->choice.successfulOutcome.procedureCode) { @@ -183,7 +183,7 @@ memset(&request_out, 0, sizeof(request_out)); rc = hnbap_encode_hnbregisterrequesties(&request_out, &request); if (rc < 0) { - printf("Could not encode HNB register request IEs\n"); + LOGP(DHNBAP, LOGL_ERROR, "Could not encode HNB register request IEs\n"); } msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBRegister, @@ -212,7 +212,7 @@ memset(&request_out, 0, sizeof(request_out)); rc = hnbap_encode_hnbde_registeries(&request_out, &request); if (rc < 0) { - printf("Could not encode HNB deregister request IEs\n"); + LOGP(DHNBAP, LOGL_ERROR, "Could not encode HNB deregister request IEs\n"); } msg = hnbap_generate_initiating_message(HNBAP_ProcedureCode_id_HNBDe_Register, diff --git a/src/osmo-hnodeb/nas.c b/src/osmo-hnodeb/nas.c index 163f458..293c46e 100644 --- a/src/osmo-hnodeb/nas.c +++ b/src/osmo-hnodeb/nas.c @@ -87,7 +87,7 @@ parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); if (parse_res <= 0) { uint8_t msg_type = gsm48_hdr_msg_type(gh); - printf("Error parsing MM message 0x%hhx: %d\n", msg_type, parse_res); + LOGP(DNAS, LOGL_ERROR, "Error parsing MM message 0x%hhx: %d\n", msg_type, parse_res); return NULL; } @@ -96,14 +96,14 @@ int hnb_nas_rx_lu_accept(struct gsm48_hdr *gh, int len, int *sent_tmsi) { - printf(" :D Location Update Accept :D\n"); + LOGP(DNAS, LOGL_INFO, " :D Location Update Accept :D\n"); struct gsm48_loc_area_id *lai; lai = (struct gsm48_loc_area_id *)&gh->data[0]; struct osmo_location_area_id laid; gsm48_decode_lai2(lai, &laid); - printf("LU: mcc %s mnc %s lac %hd\n", + LOGP(DNAS, LOGL_INFO, "LU: mcc %s mnc %s lac %hd\n", osmo_mcc_name(laid.plmn.mcc), osmo_mnc_name(laid.plmn.mnc, laid.plmn.mnc_3_digits), laid.lac); @@ -113,7 +113,7 @@ len -= (const char *)&gh->data[0] - (const char *)gh; parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); if (parse_res <= 0) { - printf("Error parsing Location Update Accept message: %d\n", parse_res); + LOGP(DNAS, LOGL_ERROR, "Error parsing Location Update Accept message: %d\n", parse_res); return -1; } @@ -128,7 +128,7 @@ void hnb_nas_rx_mm_info(struct gsm48_hdr *gh, int len) { - printf(" :) MM Info :)\n"); + LOGP(DNAS, LOGL_INFO, " :) MM Info :)\n"); struct tlv_parsed *tp = parse_mm(gh, len); if (!tp) return; @@ -138,7 +138,7 @@ gsm_7bit_decode_n(name, 127, TLVP_VAL(tp, GSM48_IE_NAME_SHORT)+1, (TLVP_LEN(tp, GSM48_IE_NAME_SHORT)-1)*8/7); - printf("Info: Short Network Name: %s\n", name); + LOGP(DNAS, LOGL_INFO, "Info: Short Network Name: %s\n", name); } if (TLVP_PRESENT(tp, GSM48_IE_NAME_LONG)) { @@ -146,7 +146,7 @@ gsm_7bit_decode_n(name, 127, TLVP_VAL(tp, GSM48_IE_NAME_LONG)+1, (TLVP_LEN(tp, GSM48_IE_NAME_LONG)-1)*8/7); - printf("Info: Long Network Name: %s\n", name); + LOGP(DNAS, LOGL_INFO, "Info: Long Network Name: %s\n", name); } } @@ -158,11 +158,11 @@ len -= (const char *)&gh->data[0] - (const char *)gh; if (len < sizeof(*ar)) { - printf("GSM48 Auth Req does not fit.\n"); + LOGP(DNAS, LOGL_ERROR, "GSM48 Auth Req does not fit.\n"); return -1; } - printf(" :) Authentication Request :)\n"); + LOGP(DNAS, LOGL_INFO, " :) Authentication Request :)\n"); ar = (struct gsm48_auth_req*) &gh->data[0]; int seq = ar->key_seq; @@ -183,9 +183,9 @@ memset(&vec, 0, sizeof(vec)); osmo_auth_gen_vec(&vec, &auth, ar->rand); - printf("seq %d rand %s", + LOGP(DNAS, LOGL_DEBUG, "seq %d rand %s", seq, osmo_hexdump(ar->rand, sizeof(ar->rand))); - printf(" --> sres %s\n", + LOGP(DNAS, LOGL_DEBUG, " --> sres %s\n", osmo_hexdump(vec.sres, 4)); return hnb_tx_dt(hnb, gen_nas_auth_resp(vec.sres)); @@ -197,7 +197,7 @@ chan = hnb->cs.chan; if (!chan) { - printf("hnb_nas_rx_mm(): No CS channel established yet.\n"); + LOGP(DNAS, LOGL_ERROR, "hnb_nas_rx_mm(): No CS channel established yet.\n"); return -1; } @@ -219,7 +219,7 @@ return 0; case GSM48_MT_MM_LOC_UPD_REJECT: - printf("Received Location Update Reject\n"); + LOGP(DNAS, LOGL_INFO, "Received Location Update Reject\n"); return 0; case GSM48_MT_MM_INFO: @@ -231,7 +231,7 @@ return hnb_nas_rx_auth_req(hnb, gh, len); default: - printf("04.08 message type not handled by hnb-test: 0x%x\n", + LOGP(DNAS, LOGL_INFO, "04.08 message type not handled by hnb-test: 0x%x\n", msg_type); return 0; } @@ -241,14 +241,14 @@ void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len) { int rc; - printf("got %d bytes: %s\n", len, osmo_hexdump(data, len)); + LOGP(DNAS, LOGL_INFO, "got %d bytes: %s\n", len, osmo_hexdump(data, len)); // nas_pdu == '05 08 12' ==> IMEI Identity request // '05 04 0d' ==> LU reject struct gsm48_hdr *gh = data; if (len < sizeof(*gh)) { - printf("hnb_nas_rx_dtap(): NAS PDU is too short: %d. Ignoring.\n", + LOGP(DNAS, LOGL_ERROR, "hnb_nas_rx_dtap(): NAS PDU is too short: %d. Ignoring.\n", len); return; } @@ -258,10 +258,10 @@ case GSM48_PDISC_MM: rc = hnb_nas_rx_mm(hnb, gh, len); if (rc != 0) - printf("Error receiving MM message: %d\n", rc); + LOGP(DNAS, LOGL_ERROR, "Error receiving MM message: %d\n", rc); return; default: - printf("04.08 discriminator not handled by hnb-test: %d\n", + LOGP(DNAS, LOGL_NOTICE, "04.08 discriminator not handled by hnb-test: %d\n", pdisc); return; } diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c index 8f1b9c0..fae87b7 100644 --- a/src/osmo-hnodeb/ranap.c +++ b/src/osmo-hnodeb/ranap.c @@ -35,7 +35,7 @@ } #define PP(octet_string_t) \ - printf(#octet_string_t " = %s\n",\ + LOGP(DRANAP, LOGL_INFO, #octet_string_t " = %s\n",\ printstr(&octet_string_t)) void hnb_rua_dt_handle_ranap(struct hnb *hnb, @@ -46,12 +46,12 @@ RANAP_PermittedIntegrityProtectionAlgorithms_t *algs; RANAP_IntegrityProtectionAlgorithm_t *first_alg; - printf("rx ranap_msg->procedureCode %d\n", + LOGP(DRANAP, LOGL_INFO, "rx ranap_msg->procedureCode %d\n", ranap_msg->procedureCode); switch (ranap_msg->procedureCode) { case RANAP_ProcedureCode_id_DirectTransfer: - printf("rx DirectTransfer: presence = %hx\n", + LOGP(DRANAP, LOGL_INFO, "rx DirectTransfer: presence = %hx\n", ranap_msg->msg.directTransferIEs.presenceMask); PP(ranap_msg->msg.directTransferIEs.nas_pdu); @@ -62,14 +62,14 @@ return; case RANAP_ProcedureCode_id_SecurityModeControl: - printf("rx SecurityModeControl: presence = %hx\n", + LOGP(DRANAP, LOGL_INFO, "rx SecurityModeControl: presence = %hx\n", ranap_msg->msg.securityModeCommandIEs.presenceMask); /* Just pick the first available IP alg, don't care about * encryption (yet?) */ algs = &ranap_msg->msg.securityModeCommandIEs.integrityProtectionInformation.permittedAlgorithms; if (algs->list.count < 1) { - printf("Security Mode Command: No permitted algorithms.\n"); + LOGP(DRANAP, LOGL_INFO, "Security Mode Command: No permitted algorithms.\n"); return; } first_alg = *algs->list.array; @@ -88,7 +88,7 @@ { char imsi[16]; - printf("rx ranap_msg->procedureCode %d\n", + LOGP(DRANAP, LOGL_INFO, "rx ranap_msg->procedureCode %d\n", ranap_msg->procedureCode); switch (ranap_msg->procedureCode) { @@ -99,7 +99,7 @@ ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.choice.iMSI.size); } else imsi[0] = '\0'; - printf("rx Paging: presence=%hx domain=%ld IMSI=%s\n", + LOGP(DRANAP, LOGL_INFO, "rx Paging: presence=%hx domain=%ld IMSI=%s\n", ranap_msg->msg.pagingIEs.presenceMask, ranap_msg->msg.pagingIEs.cN_DomainIndicator, imsi @@ -158,7 +158,7 @@ void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg) { - printf(" :) Security Mode Command :)\n"); + LOGP(DRANAP, LOGL_INFO, " :) Security Mode Command :)\n"); /* not caring about encryption yet, just pass 0 for No Encryption. */ hnb_tx_dt(hnb, ranap_new_msg_sec_mod_compl(ip_alg, 0)); } @@ -170,6 +170,6 @@ void hnb_rx_paging(struct hnb *hnb, const char *imsi) { - printf(" :) Paging Request for %s :)\n", imsi); + LOGP(DRANAP, LOGL_INFO, " :) Paging Request for %s :)\n", imsi); /* TODO reply */ } diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index d7352b6..0dd8c3a 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -36,7 +36,7 @@ chan = hnb->cs.chan; if (!chan) { - printf("hnb_nas_tx_tmsi_realloc_compl(): No CS channel established yet.\n"); + LOGP(DRUA, LOGL_INFO, "hnb_nas_tx_tmsi_realloc_compl(): No CS channel established yet.\n"); return -1; } @@ -52,7 +52,7 @@ rc = rua_decode_directtransferies(&ies, in); if (rc < 0) { - printf("failed to decode RUA DT IEs\n"); + LOGP(DRUA, LOGL_INFO, "failed to decode RUA DT IEs\n"); return; } @@ -69,7 +69,7 @@ rc = rua_decode_connectionlesstransferies(&ies, in); if (rc < 0) { - printf("failed to decode RUA CL IEs\n"); + LOGP(DRUA, LOGL_INFO, "failed to decode RUA CL IEs\n"); return; } @@ -94,45 +94,45 @@ switch (pdu->present) { case RUA_RUA_PDU_PR_successfulOutcome: - printf("RUA_RUA_PDU_PR_successfulOutcome\n"); + LOGP(DRUA, LOGL_INFO, "RUA_RUA_PDU_PR_successfulOutcome\n"); break; case RUA_RUA_PDU_PR_initiatingMessage: - printf("RUA_RUA_PDU_PR_initiatingMessage\n"); + LOGP(DRUA, LOGL_INFO, "RUA_RUA_PDU_PR_initiatingMessage\n"); break; case RUA_RUA_PDU_PR_NOTHING: - printf("RUA_RUA_PDU_PR_NOTHING\n"); + LOGP(DRUA, LOGL_INFO, "RUA_RUA_PDU_PR_NOTHING\n"); break; case RUA_RUA_PDU_PR_unsuccessfulOutcome: - printf("RUA_RUA_PDU_PR_unsuccessfulOutcome\n"); + LOGP(DRUA, LOGL_INFO, "RUA_RUA_PDU_PR_unsuccessfulOutcome\n"); break; default: - printf("Unexpected RUA message received\n"); + LOGP(DRUA, LOGL_INFO, "Unexpected RUA message received\n"); break; } switch (pdu->choice.successfulOutcome.procedureCode) { case RUA_ProcedureCode_id_ConnectionlessTransfer: - printf("RUA rx Connectionless Transfer\n"); + LOGP(DRUA, LOGL_INFO, "RUA rx Connectionless Transfer\n"); hnb_rua_cl_handle(hnb, &pdu->choice.successfulOutcome.value); break; case RUA_ProcedureCode_id_Connect: - printf("RUA rx Connect\n"); + LOGP(DRUA, LOGL_INFO, "RUA rx Connect\n"); break; case RUA_ProcedureCode_id_DirectTransfer: - printf("RUA rx DirectTransfer\n"); + LOGP(DRUA, LOGL_INFO, "RUA rx DirectTransfer\n"); hnb_rua_dt_handle(hnb, &pdu->choice.successfulOutcome.value); break; case RUA_ProcedureCode_id_Disconnect: - printf("RUA rx Disconnect\n"); + LOGP(DRUA, LOGL_INFO, "RUA rx Disconnect\n"); break; case RUA_ProcedureCode_id_ErrorIndication: - printf("RUA rx ErrorIndication\n"); + LOGP(DRUA, LOGL_INFO, "RUA rx ErrorIndication\n"); break; case RUA_ProcedureCode_id_privateMessage: - printf("RUA rx privateMessage\n"); + LOGP(DRUA, LOGL_INFO, "RUA rx privateMessage\n"); break; default: - printf("RUA rx unknown message\n"); + LOGP(DRUA, LOGL_INFO, "RUA rx unknown message\n"); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I649b17803aeffd20354aa76dde61094959f08e43 Gerrit-Change-Number: 26017 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:40 +0000 Subject: Change in osmo-hnodeb[master]: use osmo_stream_cli to manage sctp Iuh conn In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26018 ) Change subject: use osmo_stream_cli to manage sctp Iuh conn ...................................................................... use osmo_stream_cli to manage sctp Iuh conn Let's use already available functionality to handle the conn for us. This is specially useful since we gain a connect_cb. Change-Id: I9d884231577aa47af22cd6319130ca5c9e595d61 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/hnb.c 2 files changed, 45 insertions(+), 53 deletions(-) Approvals: pespin: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 9da6044..cca7f35 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -59,8 +59,7 @@ uint16_t local_port; char *remote_addr; uint16_t remote_port; - /*! SCTP socket + write queue for Iuh to this specific HNB */ - struct osmo_wqueue wqueue; + struct osmo_stream_cli *client; } iuh; uint16_t rnc_id; @@ -72,6 +71,7 @@ } cs; }; struct hnb *hnb_alloc(void *tall_ctx); +void hnb_free(struct hnb *hnb); int hnb_connect(struct hnb *hnb); int hnb_iuh_send(struct hnb *hnb, struct msgb *msg); diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 9a86019..e77f1aa 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -36,22 +36,10 @@ #include #include -static int sctp_sock_init(int fd) +static int hnb_iuh_read_cb(struct osmo_stream_cli *conn) { - struct sctp_event_subscribe event; - int rc; - - /* subscribe for all events */ - memset((uint8_t *)&event, 1, sizeof(event)); - rc = setsockopt(fd, IPPROTO_SCTP, SCTP_EVENTS, - &event, sizeof(event)); - - return rc; -} - -static int hnb_iuh_read_cb(struct osmo_fd *fd) -{ - struct hnb *hnb = fd->data; + struct osmo_fd *fd = osmo_stream_cli_get_ofd(conn); + struct hnb *hnb = osmo_stream_cli_get_data(conn); struct sctp_sndrcvinfo sinfo; struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); int flags = 0; @@ -65,15 +53,11 @@ if (rc < 0) { LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); /* FIXME: clean up after disappeared HNB */ - close(fd->fd); - osmo_fd_unregister(fd); + osmo_stream_cli_close(conn); return rc; } else if (rc == 0) { LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); - close(fd->fd); - osmo_fd_unregister(fd); - fd->fd = -1; - + osmo_stream_cli_close(conn); return -1; } else { msgb_put(msg, rc); @@ -114,42 +98,48 @@ return rc; } -static int hnb_iuh_write_cb(struct osmo_fd *fd, struct msgb *msg) +static int hnb_iuh_connect_cb(struct osmo_stream_cli *cli) { - /* struct hnb *ctx = fd->data; */ - struct sctp_sndrcvinfo sinfo = { - .sinfo_ppid = htonl(msgb_sctp_ppid(msg)), - .sinfo_stream = 0, - }; - int rc; - - LOGP(DMAIN, LOGL_DEBUG, "Sending: %s\n", osmo_hexdump(msgb_data(msg), msgb_length(msg))); - rc = sctp_send(fd->fd, msgb_data(msg), msgb_length(msg), - &sinfo, 0); - /* we don't need to msgb_free(), write_queue does this for us */ - return rc; + LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); + return 0; } struct hnb *hnb_alloc(void *tall_ctx) { struct hnb *hnb; + struct osmo_stream_cli *cli; + hnb = talloc_zero(tall_ctx, struct hnb); if (!hnb) return NULL; - hnb->iuh.local_addr = NULL; + hnb->iuh.local_addr = talloc_strdup(hnb, "0.0.0.0"); hnb->iuh.local_port = 0; hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); hnb->iuh.remote_port = IUH_DEFAULT_SCTP_PORT; - osmo_wqueue_init(&hnb->iuh.wqueue, 16); - hnb->iuh.wqueue.bfd.data = hnb; - hnb->iuh.wqueue.read_cb = hnb_iuh_read_cb; - hnb->iuh.wqueue.write_cb = hnb_iuh_write_cb; + cli = osmo_stream_cli_create(hnb); + OSMO_ASSERT(cli); + hnb->iuh.client = cli; + osmo_stream_cli_set_nodelay(cli, true); + osmo_stream_cli_set_proto(cli, IPPROTO_SCTP); + osmo_stream_cli_set_reconnect_timeout(cli, 5); + osmo_stream_cli_set_connect_cb(cli, hnb_iuh_connect_cb); + osmo_stream_cli_set_read_cb(cli, hnb_iuh_read_cb); + osmo_stream_cli_set_data(cli, hnb); return hnb; } +void hnb_free(struct hnb *hnb) +{ + if (hnb->iuh.client) { + osmo_stream_cli_destroy(hnb->iuh.client); + hnb->iuh.client = NULL; + } + talloc_free(hnb); +} + int hnb_connect(struct hnb *hnb) { int rc; @@ -157,21 +147,23 @@ LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); - rc = osmo_sock_init2_ofd(&hnb->iuh.wqueue.bfd, AF_INET, SOCK_STREAM, IPPROTO_SCTP, - hnb->iuh.local_addr, hnb->iuh.local_port, - hnb->iuh.remote_addr, hnb->iuh.remote_port, - OSMO_SOCK_F_BIND |OSMO_SOCK_F_CONNECT); - if (rc < 0) - return rc; - sctp_sock_init(hnb->iuh.wqueue.bfd.fd); + osmo_stream_cli_set_addrs(hnb->iuh.client, (const char**)&hnb->iuh.remote_addr, 1); + osmo_stream_cli_set_port(hnb->iuh.client, hnb->iuh.remote_port); + osmo_stream_cli_set_local_addrs(hnb->iuh.client, (const char**)&hnb->iuh.local_addr, 1); + osmo_stream_cli_set_local_port(hnb->iuh.client, hnb->iuh.local_port); + rc = osmo_stream_cli_open(hnb->iuh.client); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", + hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); + /* we don't return error in here because osmo_stream_cli_open() + will continue to retry (due to timeout being explicitly set with + osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */ + } return 0; } int hnb_iuh_send(struct hnb *hnb, struct msgb *msg) { - int rc; - rc = osmo_wqueue_enqueue(&hnb->iuh.wqueue, msg); - if (rc < 0) - msgb_free(msg); - return rc; + osmo_stream_cli_send(hnb->iuh.client, msg); + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9d884231577aa47af22cd6319130ca5c9e595d61 Gerrit-Change-Number: 26018 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:41 +0000 Subject: Change in osmo-hnodeb[master]: Send HnbRegisterRequest when HnodeB connects on Iuh In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26019 ) Change subject: Send HnbRegisterRequest when HnodeB connects on Iuh ...................................................................... Send HnbRegisterRequest when HnodeB connects on Iuh Change-Id: I901fd456221a3bdc3f4f95b7fd3b9484c7830f24 --- M src/osmo-hnodeb/hnb.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index e77f1aa..d7dde7b 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -98,9 +98,12 @@ return rc; } -static int hnb_iuh_connect_cb(struct osmo_stream_cli *cli) +static int hnb_iuh_connect_cb(struct osmo_stream_cli *conn) { LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); + struct hnb *hnb = osmo_stream_cli_get_data(conn); + + hnb_send_register_req(hnb); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I901fd456221a3bdc3f4f95b7fd3b9484c7830f24 Gerrit-Change-Number: 26019 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:41 +0000 Subject: Change in osmo-hnodeb[master]: Configure PLMN over VTY and use it in HnbRegisterRequest In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26020 ) Change subject: Configure PLMN over VTY and use it in HnbRegisterRequest ...................................................................... Configure PLMN over VTY and use it in HnbRegisterRequest Change-Id: I6d67aa547d5496fe1407744e1dde07d2a41df500 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnbap.c M src/osmo-hnodeb/vty.c 4 files changed, 62 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index cca7f35..77430d6 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -25,6 +25,7 @@ #include #include #include +#include enum { DMAIN, @@ -54,6 +55,7 @@ }; struct hnb { + struct osmo_plmn_id plmn; struct { char *local_addr; uint16_t local_port; diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index d7dde7b..b0628e5 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -116,6 +116,11 @@ if (!hnb) return NULL; + hnb->plmn = (struct osmo_plmn_id){ + .mcc = 1, + .mnc = 1, + }; + hnb->iuh.local_addr = talloc_strdup(hnb, "0.0.0.0"); hnb->iuh.local_port = 0; hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index eaa51a4..58fec85 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -156,7 +156,7 @@ uint16_t lac, sac; uint8_t rac; uint32_t cid; - uint8_t plmn[] = {0x09, 0xf1, 0x99}; + uint8_t plmn[3]; char identity[50] = "ATestHNB@"; HNBAP_HNBRegisterRequestIEs_t request; @@ -175,10 +175,9 @@ request.hnB_Identity.hNB_Identity_Info.buf = (uint8_t*) identity; request.hnB_Identity.hNB_Identity_Info.size = strlen(identity); + osmo_plmn_to_bcd(plmn, &hnb->plmn); request.plmNidentity.buf = plmn; - request.plmNidentity.size = 3; - - + request.plmNidentity.size = sizeof(plmn); memset(&request_out, 0, sizeof(request_out)); rc = hnbap_encode_hnbregisterrequesties(&request_out, &request); diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 989b7e8..f4623ad 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -68,6 +68,7 @@ }; #define HNODEB_STR "Configure the HNodeB\n" +#define CODE_CMD_STR "Code commands\n" DEFUN(cfg_hnodeb, cfg_hnodeb_cmd, @@ -80,6 +81,52 @@ return CMD_SUCCESS; } +DEFUN_USRATTR(cfg_hnodeb_ncc, + cfg_hnodeb_ncc_cmd, + 0, + "network country code <1-999>", + "Set the GSM network country code\n" + "Country commands\n" + CODE_CMD_STR + "Network Country Code to use\n") +{ + struct hnb *hnb = (struct hnb *)vty->index; + uint16_t mcc; + + if (osmo_mcc_from_str(argv[0], &mcc)) { + vty_out(vty, "%% Error decoding MCC: %s%s", argv[0], VTY_NEWLINE); + return CMD_WARNING; + } + + hnb->plmn.mcc = mcc; + + return CMD_SUCCESS; +} + +DEFUN_USRATTR(cfg_hnodeb_mnc, + cfg_hnodeb_mnc_cmd, + 0, + "mobile network code <0-999>", + "Set the GSM mobile network code\n" + "Network Commands\n" + CODE_CMD_STR + "Mobile Network Code to use\n") +{ + struct hnb *hnb = (struct hnb *)vty->index; + uint16_t mnc; + bool mnc_3_digits; + + if (osmo_mnc_from_str(argv[0], &mnc, &mnc_3_digits)) { + vty_out(vty, "%% Error decoding MNC: %s%s", argv[0], VTY_NEWLINE); + return CMD_WARNING; + } + + hnb->plmn.mnc = mnc; + hnb->plmn.mnc_3_digits = mnc_3_digits; + + return CMD_SUCCESS; +} + static struct cmd_node iuh_node = { IUH_NODE, "%s(config-iuh)# ", @@ -139,6 +186,9 @@ static int config_write_hnodeb(struct vty *vty) { vty_out(vty, "hnodeb%s", VTY_NEWLINE); + vty_out(vty, " network country code %s%s", osmo_mcc_name(g_hnb->plmn.mcc), VTY_NEWLINE); + vty_out(vty, " mobile network code %s%s", + osmo_mnc_name(g_hnb->plmn.mnc, g_hnb->plmn.mnc_3_digits), VTY_NEWLINE); vty_out(vty, " iuh%s", VTY_NEWLINE); if (g_hnb->iuh.local_addr) vty_out(vty, " local-ip %s%s", g_hnb->iuh.local_addr, VTY_NEWLINE); @@ -254,6 +304,8 @@ { install_element(CONFIG_NODE, &cfg_hnodeb_cmd); install_node(&hnodeb_node, config_write_hnodeb); + install_element(HNODEB_NODE, &cfg_hnodeb_ncc_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_mnc_cmd); install_element(HNODEB_NODE, &cfg_hnodeb_iuh_cmd); install_node(&iuh_node, NULL); install_element(IUH_NODE, &cfg_hnodeb_iuh_local_ip_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d67aa547d5496fe1407744e1dde07d2a41df500 Gerrit-Change-Number: 26020 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:42 +0000 Subject: Change in osmo-hnodeb[master]: Configure CI, LAC, RAC, SAC over VTY and use it in HnbRegisterRequest In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 ) Change subject: Configure CI,LAC,RAC,SAC over VTY and use it in HnbRegisterRequest ...................................................................... Configure CI,LAC,RAC,SAC over VTY and use it in HnbRegisterRequest Change-Id: I06f21758e361b7d4d7141086d758893bee434e5c --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/hnbap.c M src/osmo-hnodeb/vty.c 3 files changed, 69 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 77430d6..a82c662 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -56,6 +56,10 @@ struct hnb { struct osmo_plmn_id plmn; + uint16_t cell_identity; + uint16_t lac; + uint8_t rac; + uint16_t sac; struct { char *local_addr; uint16_t local_port; diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 58fec85..167ec50 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -162,15 +162,10 @@ HNBAP_HNBRegisterRequestIEs_t request; memset(&request, 0, sizeof(request)); - lac = 0xc0fe; - sac = 0xabab; - rac = 0x42; - cid = 0xadceaab; - - asn1_u16_to_str(&request.lac, &lac, lac); - asn1_u16_to_str(&request.sac, &sac, sac); - asn1_u8_to_str(&request.rac, &rac, rac); - asn1_u28_to_bitstring(&request.cellIdentity, &cid, cid); + asn1_u16_to_str(&request.lac, &lac, hnb->lac); + asn1_u16_to_str(&request.sac, &sac, hnb->sac); + asn1_u8_to_str(&request.rac, &rac, hnb->rac); + asn1_u28_to_bitstring(&request.cellIdentity, &cid, hnb->cell_identity); request.hnB_Identity.hNB_Identity_Info.buf = (uint8_t*) identity; request.hnB_Identity.hNB_Identity_Info.size = strlen(identity); diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index f4623ad..1adc7ba 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -27,6 +27,8 @@ #include #include +#include + #include #include @@ -127,6 +129,57 @@ return CMD_SUCCESS; } +DEFUN_USRATTR(cfg_hnodeb_ci, + cfg_hnodeb_ci_cmd, + 0, + "cell_identity <0-65535>", + "Set the Cell identity of this HnodeB\n" "Cell Identity\n") +{ + struct hnb *hnb = (struct hnb *)vty->index; + hnb->cell_identity = atoi(argv[0]); + return CMD_SUCCESS; +} + +DEFUN_USRATTR(cfg_hnodeb_lac, + cfg_hnodeb_lac_cmd, + 0, + "location_area_code <0-65535>", + "Set the Location Area Code (LAC) of this HnodeB\n" "LAC\n") +{ + struct hnb *hnb = (struct hnb *)vty->index; + int lac = atoi(argv[0]); + + if (lac == GSM_LAC_RESERVED_DETACHED || lac == GSM_LAC_RESERVED_ALL_BTS) { + vty_out(vty, "%% LAC %d is reserved by GSM 04.08%s", + lac, VTY_NEWLINE); + return CMD_WARNING; + } + hnb->lac = lac; + return CMD_SUCCESS; +} + +DEFUN_USRATTR(cfg_hnodeb_rac, + cfg_hnodeb_rac_cmd, + 0, + "routing_area_code <0-255>", + "Set the Routing Area Code (RAC) of this HnodeB\n" "RAC\n") +{ + struct hnb *hnb = (struct hnb *)vty->index; + hnb->rac = atoi(argv[0]); + return CMD_SUCCESS; +} + +DEFUN_USRATTR(cfg_hnodeb_sac, + cfg_hnodeb_sac_cmd, + 0, + "service_area_code <0-255>", + "Set the Service Area Code (RAC) of this HnodeB\n" "SAC\n") +{ + struct hnb *hnb = (struct hnb *)vty->index; + hnb->sac = atoi(argv[0]); + return CMD_SUCCESS; +} + static struct cmd_node iuh_node = { IUH_NODE, "%s(config-iuh)# ", @@ -189,6 +242,10 @@ vty_out(vty, " network country code %s%s", osmo_mcc_name(g_hnb->plmn.mcc), VTY_NEWLINE); vty_out(vty, " mobile network code %s%s", osmo_mnc_name(g_hnb->plmn.mnc, g_hnb->plmn.mnc_3_digits), VTY_NEWLINE); + vty_out(vty, " cell_identity %u%s", g_hnb->cell_identity, VTY_NEWLINE); + vty_out(vty, " location_area_code %u%s", g_hnb->lac, VTY_NEWLINE); + vty_out(vty, " routing_area_code %u%s", g_hnb->rac, VTY_NEWLINE); + vty_out(vty, " service_area_code %u%s", g_hnb->sac, VTY_NEWLINE); vty_out(vty, " iuh%s", VTY_NEWLINE); if (g_hnb->iuh.local_addr) vty_out(vty, " local-ip %s%s", g_hnb->iuh.local_addr, VTY_NEWLINE); @@ -306,6 +363,10 @@ install_node(&hnodeb_node, config_write_hnodeb); install_element(HNODEB_NODE, &cfg_hnodeb_ncc_cmd); install_element(HNODEB_NODE, &cfg_hnodeb_mnc_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_ci_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_lac_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_rac_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_sac_cmd); install_element(HNODEB_NODE, &cfg_hnodeb_iuh_cmd); install_node(&iuh_node, NULL); install_element(IUH_NODE, &cfg_hnodeb_iuh_local_ip_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I06f21758e361b7d4d7141086d758893bee434e5c Gerrit-Change-Number: 26021 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:44 +0000 Subject: Change in osmo-hnodeb[master]: Configure HNB-Identity over VTY and use it in HnbRegisterRequest In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26022 ) Change subject: Configure HNB-Identity over VTY and use it in HnbRegisterRequest ...................................................................... Configure HNB-Identity over VTY and use it in HnbRegisterRequest Change-Id: Ida47bbb85b5438a2ec9805005bc2ab834c79b765 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnbap.c M src/osmo-hnodeb/vty.c 4 files changed, 17 insertions(+), 3 deletions(-) Approvals: pespin: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index a82c662..5d6d088 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -55,6 +55,7 @@ }; struct hnb { + char *identity; /* HNB-Identity */ struct osmo_plmn_id plmn; uint16_t cell_identity; uint16_t lac; diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index b0628e5..34ff426 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -116,6 +116,7 @@ if (!hnb) return NULL; + hnb->identity = talloc_strdup(hnb, "OsmoHNodeB"); hnb->plmn = (struct osmo_plmn_id){ .mcc = 1, .mnc = 1, diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 167ec50..bcddfb3 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -157,7 +157,6 @@ uint8_t rac; uint32_t cid; uint8_t plmn[3]; - char identity[50] = "ATestHNB@"; HNBAP_HNBRegisterRequestIEs_t request; memset(&request, 0, sizeof(request)); @@ -167,8 +166,8 @@ asn1_u8_to_str(&request.rac, &rac, hnb->rac); asn1_u28_to_bitstring(&request.cellIdentity, &cid, hnb->cell_identity); - request.hnB_Identity.hNB_Identity_Info.buf = (uint8_t*) identity; - request.hnB_Identity.hNB_Identity_Info.size = strlen(identity); + request.hnB_Identity.hNB_Identity_Info.buf = (uint8_t*) hnb->identity; + request.hnB_Identity.hNB_Identity_Info.size = strlen(hnb->identity); osmo_plmn_to_bcd(plmn, &hnb->plmn); request.plmNidentity.buf = plmn; diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 1adc7ba..714e00d 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -83,6 +83,17 @@ return CMD_SUCCESS; } +DEFUN_USRATTR(cfg_hnodeb_identity, + cfg_hnodeb_identity_cmd, + 0, + "identity TEXT", + "Set the HNB-identity of this HnodeB\n" "HNB-Identity\n") +{ + struct hnb *hnb = (struct hnb *)vty->index; + osmo_talloc_replace_string(g_hnb, &hnb->identity, argv[0]); + return CMD_SUCCESS; +} + DEFUN_USRATTR(cfg_hnodeb_ncc, cfg_hnodeb_ncc_cmd, 0, @@ -239,6 +250,7 @@ static int config_write_hnodeb(struct vty *vty) { vty_out(vty, "hnodeb%s", VTY_NEWLINE); + vty_out(vty, " identity %s%s", g_hnb->identity, VTY_NEWLINE); vty_out(vty, " network country code %s%s", osmo_mcc_name(g_hnb->plmn.mcc), VTY_NEWLINE); vty_out(vty, " mobile network code %s%s", osmo_mnc_name(g_hnb->plmn.mnc, g_hnb->plmn.mnc_3_digits), VTY_NEWLINE); @@ -361,6 +373,7 @@ { install_element(CONFIG_NODE, &cfg_hnodeb_cmd); install_node(&hnodeb_node, config_write_hnodeb); + install_element(HNODEB_NODE, &cfg_hnodeb_identity_cmd); install_element(HNODEB_NODE, &cfg_hnodeb_ncc_cmd); install_element(HNODEB_NODE, &cfg_hnodeb_mnc_cmd); install_element(HNODEB_NODE, &cfg_hnodeb_ci_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ida47bbb85b5438a2ec9805005bc2ab834c79b765 Gerrit-Change-Number: 26022 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:45 +0000 Subject: Change in osmo-hnodeb[master]: Generate proper rnc_id and plmn in LuRequest In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26023 ) Change subject: Generate proper rnc_id and plmn in LuRequest ...................................................................... Generate proper rnc_id and plmn in LuRequest Change-Id: Ib40b5eb96b7cc13c424076a4ca725019514d52af --- M include/osmocom/hnodeb/ranap.h M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/vty.c 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h index df756b1..7864c69 100644 --- a/include/osmocom/hnodeb/ranap.h +++ b/include/osmocom/hnodeb/ranap.h @@ -30,4 +30,4 @@ void hnb_rua_dt_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); void hnb_rua_cl_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); void hnb_tx_iu_release_req(struct hnb *hnb); -struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi); +struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi); diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c index fae87b7..3dd759f 100644 --- a/src/osmo-hnodeb/ranap.c +++ b/src/osmo-hnodeb/ranap.c @@ -110,16 +110,17 @@ } } -struct msgb *gen_initue_lu(int is_ps, uint32_t conn_id, const char *imsi) +struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi) { uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST, 0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57, /* len, IMSI/type, IMSI-------------------------------- */ 0x08, 0x29, 0x26, 0x24, 0x10, 0x32, 0x54, 0x76, 0x98, 0x33, 0x03, 0x57, 0x18 , 0xb2 }; - uint8_t plmn_id[] = { 0x09, 0x01, 0x99 }; + uint8_t plmn_id[3]; + osmo_plmn_to_bcd(plmn_id, &hnb->plmn); RANAP_GlobalRNC_ID_t rnc_id = { - .rNC_ID = 23, + .rNC_ID = g_hnb->rnc_id, .pLMNidentity.buf = plmn_id, .pLMNidentity.size = sizeof(plmn_id), }; diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 714e00d..61a3f4c 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -354,7 +354,7 @@ chan->conn_id = conn_id; conn_id++; - msg = gen_initue_lu(chan->is_ps, chan->conn_id, chan->imsi); + msg = gen_initue_lu(g_hnb, chan->is_ps, chan->conn_id, chan->imsi); rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); hnb_iuh_send(g_hnb, rua); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib40b5eb96b7cc13c424076a4ca725019514d52af Gerrit-Change-Number: 26023 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:45 +0000 Subject: Change in osmo-hnodeb[master]: hnb.c: Fix memleak in hnb_iuh_read_cb In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032 ) Change subject: hnb.c: Fix memleak in hnb_iuh_read_cb ...................................................................... hnb.c: Fix memleak in hnb_iuh_read_cb Port from osmo-iuh.git Change-Id I6ecbce6aab11e1382ff9f71d901e1c6ac145f835. Change-Id: If5d5d41693e26f485aa5372129dccf0dcfb7fa6c --- M src/osmo-hnodeb/hnb.c 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 34ff426..420095d 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -54,19 +54,20 @@ LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); /* FIXME: clean up after disappeared HNB */ osmo_stream_cli_close(conn); - return rc; + goto free_ret; } else if (rc == 0) { LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); osmo_stream_cli_close(conn); - return -1; + rc = -1; + goto free_ret; } else { msgb_put(msg, rc); } if (flags & MSG_NOTIFICATION) { LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); - msgb_free(msg); - return 0; + rc = 0; + goto free_ret; } sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); @@ -94,6 +95,7 @@ break; } +free_ret: msgb_free(msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If5d5d41693e26f485aa5372129dccf0dcfb7fa6c Gerrit-Change-Number: 26032 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:00:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 12:00:46 +0000 Subject: Change in osmo-hnodeb[master]: ranap: Fix compiler warnings passing func callback In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26034 ) Change subject: ranap: Fix compiler warnings passing func callback ...................................................................... ranap: Fix compiler warnings passing func callback Fixes following warning types: "passing argument 1 of ?ranap_cn_rx_co? from incompatible pointer type [-Wincompatible-pointer-types]" Change-Id: If80b57a8d36c28dee7db28cb36a88ed41e0a7328 --- M include/osmocom/hnodeb/ranap.h M src/osmo-hnodeb/ranap.c 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h index 7864c69..15e0609 100644 --- a/include/osmocom/hnodeb/ranap.h +++ b/include/osmocom/hnodeb/ranap.h @@ -27,7 +27,7 @@ void hnb_rx_paging(struct hnb *hnb, const char *imsi); void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); -void hnb_rua_dt_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); -void hnb_rua_cl_handle_ranap(struct hnb *hnb, struct ranap_message_s *ranap_msg); +void hnb_rua_dt_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg); +void hnb_rua_cl_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg); void hnb_tx_iu_release_req(struct hnb *hnb); struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi); diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c index 3dd759f..b5b7b9c 100644 --- a/src/osmo-hnodeb/ranap.c +++ b/src/osmo-hnodeb/ranap.c @@ -38,9 +38,9 @@ LOGP(DRANAP, LOGL_INFO, #octet_string_t " = %s\n",\ printstr(&octet_string_t)) -void hnb_rua_dt_handle_ranap(struct hnb *hnb, - struct ranap_message_s *ranap_msg) +void hnb_rua_dt_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg) { + struct hnb *hnb = (struct hnb *)ctx; int len; uint8_t *data; RANAP_PermittedIntegrityProtectionAlgorithms_t *algs; @@ -83,9 +83,9 @@ } } -void hnb_rua_cl_handle_ranap(struct hnb *hnb, - struct ranap_message_s *ranap_msg) +void hnb_rua_cl_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg) { + struct hnb *hnb = (struct hnb *)ctx; char imsi[16]; LOGP(DRANAP, LOGL_INFO, "rx ranap_msg->procedureCode %d\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If80b57a8d36c28dee7db28cb36a88ed41e0a7328 Gerrit-Change-Number: 26034 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 12:46:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 12:46:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 ) Change subject: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() ...................................................................... Patch Set 2: Code-Review+1 Describing in the commit message why it was done like this would be useful. But it looks correct and I think you know what you are doing. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I235027c2b53b8f2ae975e25eb7c38b1959668d6f Gerrit-Change-Number: 25949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 02 Nov 2021 12:46:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:14:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 13:14:08 +0000 Subject: Change in osmo-pcu[master]: bts: Fix misleading log line in bts_rcv_rach() References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26060 ) Change subject: bts: Fix misleading log line in bts_rcv_rach() ...................................................................... bts: Fix misleading log line in bts_rcv_rach() If it's not single block packets access, then it's one phase packet access. TS 44.018 Table 9.1.8.1: """ One phase packet access with request for single timeslot uplink transmission; one PDCH is needed. """ Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 --- M src/bts.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/26060/1 diff --git a/src/bts.cpp b/src/bts.cpp index 50df92e..bd1366e 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -900,8 +900,8 @@ if (chan_req.single_block) LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation\n"); else if (bts->pcu->vty.force_two_phase) { - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation, " - "but we force two phase access\n"); + LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single TS uplink transmission " + "(one phase packet access), but we force two phase access\n"); chan_req.single_block = true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 Gerrit-Change-Number: 26060 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:14:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 13:14:08 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used ...................................................................... tbf_ul: Document context where tbf_alloc_ul_ccch() is used It can be seen that this function properly passes single=true to tbf_alloc_ul_tbf(). Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 --- M src/tbf_ul.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/61/26061/1 diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 74b2636..c98fddb 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -168,7 +168,8 @@ return tbf; } -/* Alloc a UL TBF to be assigned over CCCH */ +/* Alloc a UL TBF to be assigned over CCCH. Used by request of a "One phase +/* packet access", where MS requested only 1 PDCH TS (TS 44.018 Table 9.1.8.1). */ struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_ccch(struct gprs_rlcmac_bts *bts, struct GprsMs *ms) { struct gprs_rlcmac_ul_tbf *tbf; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:19:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 13:19:43 +0000 Subject: Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 ) Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c at 958 PS4, Line 958: if (dtxu_used) { > Am I wrong are are we using dtxu_used uninitialized under some circumstances? You're right. This is actually a fault of https://gerrit.osmocom.org/c/osmo-bts/+/26046, so I'll fix that patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2 Gerrit-Change-Number: 26047 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:23:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 13:23:44 +0000 Subject: Change in osmo-bts[master]: measurement: pass *mr to lchan_bs_pwr_ctrl() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26049 ) Change subject: measurement: pass *mr to lchan_bs_pwr_ctrl() ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/measurement.c at 957 PS4, Line 957: if (mr && mr->meas_valid == 0) /* 0 = valid */ > I've seen this clarification several times already: mr->meas_valid == 0) /* 0 = valid */ [?] Makes sense, yes. I would even add it to libosmocore. https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/26049/4/src/common/power_control.c at 338 PS4, Line 338: if (ctrl_interval_skip_block(params, state)) > not entirely relaed to this patch, but I just noticed that if we don'tn receive proper meas result, [?] Agree, thanks for pointing this out! I will add a test case and try to fix this when I have time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937117cf26fb718d57920382f6972390ad498c51 Gerrit-Change-Number: 26049 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:23:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:27:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 13:27:54 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: I am not really familiar with the BSC's approach to VAMOS, so leaving it up to Neels. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 02 Nov 2021 13:27:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:30:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 13:30:17 +0000 Subject: Change in osmo-iuh[master]: hnb-test: Fix memleak in hnb_read_cb In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26031 ) Change subject: hnb-test: Fix memleak in hnb_read_cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6ecbce6aab11e1382ff9f71d901e1c6ac145f835 Gerrit-Change-Number: 26031 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 02 Nov 2021 13:30:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:32:21 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 13:32:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 ) Change subject: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > Describing in the commit message why it was done like this would be useful. But it looks correct and I think you know what you are doing. TBH, I am not 100% confident here. This patch just mimics what the other test cases do... I spoke with Neels, and he said it looks good to him (despite he did not see a big difference), but he left no feedback here at all. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I235027c2b53b8f2ae975e25eb7c38b1959668d6f Gerrit-Change-Number: 25949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 02 Nov 2021 13:32:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:33:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 13:33:56 +0000 Subject: Change in osmo-iuh[master]: hnb-test: Fix memleak in hnb_read_cb In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26031 ) Change subject: hnb-test: Fix memleak in hnb_read_cb ...................................................................... hnb-test: Fix memleak in hnb_read_cb Change-Id: I6ecbce6aab11e1382ff9f71d901e1c6ac145f835 --- M src/tests/hnb-test.c 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tests/hnb-test.c b/src/tests/hnb-test.c index 02af4d9..2c73fed 100644 --- a/src/tests/hnb-test.c +++ b/src/tests/hnb-test.c @@ -583,22 +583,22 @@ /* FIXME: clean up after disappeared HNB */ close(fd->fd); osmo_fd_unregister(fd); - return rc; + goto free_ret; } else if (rc == 0) { LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); close(fd->fd); osmo_fd_unregister(fd); fd->fd = -1; - - return -1; + rc = -1; + goto free_ret; } else { msgb_put(msg, rc); } if (flags & MSG_NOTIFICATION) { LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); - msgb_free(msg); - return 0; + rc = 0; + goto free_ret; } sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); @@ -626,6 +626,7 @@ break; } +free_ret: msgb_free(msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6ecbce6aab11e1382ff9f71d901e1c6ac145f835 Gerrit-Change-Number: 26031 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:34:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 13:34:38 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo.sh: exclude asn1c generated In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25963 ) Change subject: lint: checkpatch_osmo.sh: exclude asn1c generated ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7437d888b433fec8a444e4d7c285fff47d16c0c7 Gerrit-Change-Number: 25963 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:34:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:35:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 13:35:14 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch.pl: break exclude loop early In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25964 ) Change subject: lint: checkpatch.pl: break exclude loop early ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6fb41dec25ecc1f2df7242ae041a8685a696c3fd Gerrit-Change-Number: 25964 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:35:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:36:28 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 2 Nov 2021 13:36:28 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 ) Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... gbproxy: Move BSSGP decoding into its own function and use it This code was copied in BSS and SGSN PTP receive functions and also in the functions that extract the inner PDU-in-error from the STATUS PDU. Use a central function for less code duplication and better maintainability. This also fixes TTCN3 test TC_status_ptp_ul_tlli the c&p omitted the special handling of UL/DL unitdata. Related: OS#4892 Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 --- M src/gb_proxy.c 1 file changed, 27 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/62/26062/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 7333e80..066d262 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -380,6 +380,29 @@ return gbprox_relay2peer(msg, sgsn_bvc, sig_bvci ? 0 : sgsn_bvc->bvci); } +static int gbproxy_decode_bssgp(const struct bssgp_normal_hdr *bgph, int msg_len, struct tlv_parsed *tp, const char *log_pfx) +{ + int rc; + + /* UL_UNITDATA has a different header than all other uplink PDUs */ + if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA || bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) { + const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) bgph; + if (msg_len < sizeof(*budh)) + return -OSMO_TLVP_ERR_MAND_IE_MISSING; + rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, budh->pdu_type, budh->data, + msg_len - sizeof(*budh), 0, 0, DGPRS, log_pfx); + /* populate TLLI from the fixed headser into the TLV-parsed array so later code + * doesn't have to worry where the TLLI came from */ + tp->lv[BSSGP_IE_TLLI].len = 4; + tp->lv[BSSGP_IE_TLLI].val = (const uint8_t *) &budh->tlli; + } else { + rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, bgph->pdu_type, bgph->data, + msg_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx); + } + + return rc; +} + static int gbproxy_tlli_from_status_pdu(struct tlv_parsed *tp, uint32_t *tlli, char *log_pfx); /* Receive an incoming PTP message from a BSS-side NS-VC */ @@ -419,21 +442,7 @@ return tx_status(nse, ns_bvci, BSSGP_CAUSE_UNKNOWN_BVCI, &ns_bvci, msg); } - /* UL_UNITDATA has a different header than all other uplink PDUs */ - if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA) { - const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) msgb_bssgph(msg); - if (msgb_bssgp_len(msg) < sizeof(*budh)) - return tx_status(nse, ns_bvci, BSSGP_CAUSE_INV_MAND_INF, NULL, msg); - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, budh->data, - msgb_bssgp_len(msg) - sizeof(*budh), 0, 0, DGPRS, log_pfx); - /* populate TLLI from the fixed headser into the TLV-parsed array so later code - * doesn't have to worry where the TLLI came from */ - tp.lv[BSSGP_IE_TLLI].len = 4; - tp.lv[BSSGP_IE_TLLI].val = (const uint8_t *) &budh->tlli; - } else { - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, bgph->data, - msgb_bssgp_len(msg) - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - } + rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &tp, log_pfx); if (rc < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_BSS)); return tx_status_from_tlvp(nse, rc, msg); @@ -567,21 +576,7 @@ return tx_status(nse, ns_bvci, BSSGP_CAUSE_BVCI_BLOCKED, &ns_bvci, msg); } - /* DL_UNITDATA has a different header than all other uplink PDUs */ - if (bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) { - const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) msgb_bssgph(msg); - if (msgb_bssgp_len(msg) < sizeof(*budh)) - return tx_status(nse, ns_bvci, BSSGP_CAUSE_INV_MAND_INF, NULL, msg); - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, budh->data, - msgb_bssgp_len(msg) - sizeof(*budh), 0, 0, DGPRS, log_pfx); - /* populate TLLI from the fixed headser into the TLV-parsed array so later code - * doesn't have to worry where the TLLI came from */ - tp.lv[BSSGP_IE_TLLI].len = 4; - tp.lv[BSSGP_IE_TLLI].val = (const uint8_t *) &budh->tlli; - } else { - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, bgph->data, - msgb_bssgp_len(msg) - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - } + rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &tp, log_pfx); if (rc < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_BSS)); return tx_status_from_tlvp(nse, rc, msg); @@ -1017,9 +1012,7 @@ struct tlv_parsed tp_inner[2]; /* TODO: Parse partial messages as well */ - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp_inner, ARRAY_SIZE(tp_inner), bgph->pdu_type, bgph->data, - pdu_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); if (rc < 0) return rc; @@ -1047,9 +1040,7 @@ struct tlv_parsed tp_inner[2]; /* TODO: Parse partial messages as well */ - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp_inner, ARRAY_SIZE(tp_inner), bgph->pdu_type, bgph->data, - pdu_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); if (rc < 0) return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:36:28 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 2 Nov 2021 13:36:28 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Increase correct counter when BSSGP decode from SGSN fails References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26063 ) Change subject: gbproxy: Increase correct counter when BSSGP decode from SGSN fails ...................................................................... gbproxy: Increase correct counter when BSSGP decode from SGSN fails Change-Id: I8936cee105c933987c9af1fac3c91dc26864325b --- M src/gb_proxy.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/63/26063/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 066d262..ca8f998 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -578,7 +578,7 @@ rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &tp, log_pfx); if (rc < 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_BSS)); + rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_SGSN)); return tx_status_from_tlvp(nse, rc, msg); } /* hack to get both msg + tlv_parsed passed via osmo_fsm_inst_dispatch */ -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I8936cee105c933987c9af1fac3c91dc26864325b Gerrit-Change-Number: 26063 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:36:29 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 2 Nov 2021 13:36:29 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 ) Change subject: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp ...................................................................... gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp Change-Id: I7965a4b68866c619159c524a63e051b0d9cbe80f --- M src/gb_proxy.c 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/64/26064/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index ca8f998..c42e872 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -1009,18 +1009,18 @@ int pdu_len = TLVP_LEN(&tp[0], BSSGP_IE_PDU_IN_ERROR); const uint8_t *pdu_data = TLVP_VAL(&tp[0], BSSGP_IE_PDU_IN_ERROR); struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; - struct tlv_parsed tp_inner[2]; + struct tlv_parsed tp_inner; /* TODO: Parse partial messages as well */ - rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); if (rc < 0) return rc; - if (TLVP_PRESENT(&tp_inner[0], BSSGP_IE_TLLI)) { - *tlli = osmo_load32be(TLVP_VAL(&tp_inner[0], BSSGP_IE_TLLI)); - } else if (TLVP_PRESENT(&tp_inner[0], BSSGP_IE_TMSI)) { + if (TLVP_PRESENT(&tp_inner, BSSGP_IE_TLLI)) { + *tlli = osmo_load32be(TLVP_VAL(&tp_inner, BSSGP_IE_TLLI)); + } else if (TLVP_PRESENT(&tp_inner, BSSGP_IE_TMSI)) { /* we treat the TMSI like a TLLI and extract the NRI from it */ - *tlli = osmo_load32be(TLVP_VAL(&tp_inner[0], BSSGP_IE_TMSI)); + *tlli = osmo_load32be(TLVP_VAL(&tp_inner, BSSGP_IE_TMSI)); /* Convert the TMSI into a FOREIGN TLLI so it is routed appropriately */ *tlli = gprs_tmsi2tlli(*tlli, TLLI_FOREIGN); } else { @@ -1037,15 +1037,15 @@ int pdu_len = TLVP_LEN(&tp[0], BSSGP_IE_PDU_IN_ERROR); const uint8_t *pdu_data = TLVP_VAL(&tp[0], BSSGP_IE_PDU_IN_ERROR); struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; - struct tlv_parsed tp_inner[2]; + struct tlv_parsed tp_inner; /* TODO: Parse partial messages as well */ - rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); if (rc < 0) return rc; - if (TLVP_PRESENT(&tp_inner[0], BSSGP_IE_BVCI)) - *bvci = ntohs(tlvp_val16_unal(&tp_inner[0], BSSGP_IE_BVCI)); + if (TLVP_PRESENT(&tp_inner, BSSGP_IE_BVCI)) + *bvci = ntohs(tlvp_val16_unal(&tp_inner, BSSGP_IE_BVCI)); else return -ENOENT; -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I7965a4b68866c619159c524a63e051b0d9cbe80f Gerrit-Change-Number: 26064 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:36:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 13:36:50 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch.pl: break exclude loop early In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25964 ) Change subject: lint: checkpatch.pl: break exclude loop early ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6fb41dec25ecc1f2df7242ae041a8685a696c3fd Gerrit-Change-Number: 25964 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:36:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:36:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 13:36:53 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch.pl: break exclude loop early In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25964 ) Change subject: lint: checkpatch.pl: break exclude loop early ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6fb41dec25ecc1f2df7242ae041a8685a696c3fd Gerrit-Change-Number: 25964 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:36:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:38:32 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 2 Nov 2021 13:38:32 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Correctly extract TLLI from DL/UL unitdata In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26037 ) Change subject: gbproxy: Correctly extract TLLI from DL/UL unitdata ...................................................................... Patch Set 1: You're right. I fixed it differently in https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 There I factor out the function decoding BSSGP and reuse that here and in other places where this code originally came from. -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I76896f2eee588c9a286b87b69b5b58232759a6d5 Gerrit-Change-Number: 26037 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:39:01 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 2 Nov 2021 13:39:01 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Correctly extract TLLI from DL/UL unitdata In-Reply-To: References: Message-ID: daniel has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26037 ) Change subject: gbproxy: Correctly extract TLLI from DL/UL unitdata ...................................................................... Abandoned Replaced-By: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I76896f2eee588c9a286b87b69b5b58232759a6d5 Gerrit-Change-Number: 26037 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:40:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 13:40:22 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo.sh: exclude asn1c generated In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25963 ) Change subject: lint: checkpatch_osmo.sh: exclude asn1c generated ...................................................................... lint: checkpatch_osmo.sh: exclude asn1c generated Does not make a noticable speed difference on a typical patch with few changed files, but makes linting on big patches with ~1000 files and lots of asn1c generated files in the repository significantly slower. The next patch will optimize that case. Change-Id: I7437d888b433fec8a444e4d7c285fff47d16c0c7 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 91e9abe..f9cc74f 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -1,6 +1,7 @@ #!/bin/sh -e SCRIPT_DIR="$(dirname "$(realpath "$0")")" -PROJECT="$(basename "$(git rev-parse --show-toplevel)")" +PROJECT_DIR="$(git rev-parse --show-toplevel)" +PROJECT="$(basename "$PROJECT_DIR")" exclude_paths_common() { # Stdout and stderr of regression tests @@ -9,6 +10,21 @@ echo '--exclude ^debian/changelog$' } +exclude_paths_common_asn1c() { + local pattern="^ \* Generated by asn1c-" + local files="$(find -name '*.c' -o -name '*.h' | cut -d / -f 2-)" + local i + + if [ -z "$files" ]; then + return + fi + + for i in $(grep -l "$pattern" $files); do + # Example: --exclude ^include/osmocom/sabp/SABP_Data-Coding-Scheme.h$ + echo '--exclude ^'$i'$' + done +} + exclude_paths_project() { case "$PROJECT" in libosmocore) @@ -56,8 +72,11 @@ # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) +cd "$PROJECT_DIR" + $SCRIPT_DIR/checkpatch.pl \ $(exclude_paths_common) \ + $(exclude_paths_common_asn1c) \ $(exclude_paths_project) \ --ignore ASSIGN_IN_IF \ --ignore AVOID_EXTERNS \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7437d888b433fec8a444e4d7c285fff47d16c0c7 Gerrit-Change-Number: 25963 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:40:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 13:40:22 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch.pl: break exclude loop early In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25964 ) Change subject: lint: checkpatch.pl: break exclude loop early ...................................................................... lint: checkpatch.pl: break exclude loop early When running the linter on a patch with lots of files changed, and lots of exclude files, this makes a big difference. On my machine, running an osmo-iuh patch with 1580 files changed, and the high amount of asn1c related excludes, the time for linting is reduced from 50s to 25s. This should be acceptable, since typically we change only few files. Change-Id: I6fb41dec25ecc1f2df7242ae041a8685a696c3fd --- M lint/checkpatch/checkpatch.pl 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index 06e6e36..e31a61f 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -2813,6 +2813,7 @@ foreach (@exclude) { if ($realfile =~ m@$_@) { $skipme = 1; + last; # break out of the loop } } if ($skipme) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6fb41dec25ecc1f2df7242ae041a8685a696c3fd Gerrit-Change-Number: 25964 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:45:09 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 2 Nov 2021 13:45:09 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Increase correct counter when BSSGP decode from SGSN fails In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26063 ) Change subject: gbproxy: Increase correct counter when BSSGP decode from SGSN fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I8936cee105c933987c9af1fac3c91dc26864325b Gerrit-Change-Number: 26063 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Tue, 02 Nov 2021 13:45:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:49:31 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 2 Nov 2021 13:49:31 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 ) Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/1/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/1/src/gb_proxy.c at 387 PS1, Line 387: /* UL_UNITDATA has a different header than all other uplink PDUs */ the comment is missing DL_UNITDATA or just write UNITDATA -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 13:49:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:53:03 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 13:53:03 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add builddep: autoconf-archive References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add builddep: autoconf-archive ...................................................................... d/control, spec: add builddep: autoconf-archive Apparently this is needed to build the package. We have it in few other Osmocom projects as build dependency too, others seem to ship related m4 macros directly in a m4 dir. Fix for: configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. Related: SYS#5516 Change-Id: If9ff232844d72094fb883700185ae152ca40493d --- M contrib/osmo-hnodeb.spec.in M debian/control 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/65/26065/1 diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index 4dbb670..27a7c4f 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -24,6 +24,7 @@ Group: Hardware/Mobile URL: https://osmocom.org/projects/osmohnodeb Source: %{name}-%{version}.tar.xz +BuildRequires: autoconf-archive BuildRequires: automake >= 1.9 BuildRequires: libtool >= 2 BuildRequires: pkgconfig >= 0.20 diff --git a/debian/control b/debian/control index a7316db..b311115 100644 --- a/debian/control +++ b/debian/control @@ -6,6 +6,7 @@ dh-autoreconf, autotools-dev, autoconf, + autoconf-archive, automake, libtool, pkg-config, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:53:04 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 13:53:04 +0000 Subject: Change in osmo-hnodeb[master]: rpm spec: fix invalid file paths References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 ) Change subject: rpm spec: fix invalid file paths ...................................................................... rpm spec: fix invalid file paths Fix for: File not found: /home/abuild/rpmbuild/BUILDROOT/osmo-hnodeb-0.0.0.202111021358-1.1.arm/usr/share/doc/packages/osmo-hnodeb/examples/osmo-hnodeb/*/osmo-hnodeb*.cfg File not found: /home/abuild/rpmbuild/BUILDROOT/osmo-hnodeb-0.0.0.202111021358-1.1.arm/usr/share/doc/packages/osmo-hnodeb/README With this patch applied, the deb and rpm packages build successfully now (verified in own OBS namespace). Related: SYS#5516 Change-Id: I3c728489d38272d8477da5050f407708b8c4289b --- M contrib/osmo-hnodeb.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/66/26066/1 diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index 27a7c4f..f3a7275 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -79,12 +79,11 @@ %files %license COPYING -%doc AUTHORS README +%doc AUTHORS README.md %{_bindir}/osmo-hnodeb %dir %{_docdir}/%{name}/examples %dir %{_docdir}/%{name}/examples/osmo-hnodeb %{_docdir}/%{name}/examples/osmo-hnodeb/osmo-hnodeb.cfg -%{_docdir}/%{name}/examples/osmo-hnodeb/*/osmo-hnodeb*.cfg %dir %{_sysconfdir}/osmocom %config(noreplace) %{_sysconfdir}/osmocom/osmo-hnodeb.cfg %{_unitdir}/%{name}.service -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I3c728489d38272d8477da5050f407708b8c4289b Gerrit-Change-Number: 26066 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:53:04 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 13:53:04 +0000 Subject: Change in osmo-hnodeb[master]: gitignore: add src/osmo-hnodeb/osmo-hnodeb References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 ) Change subject: gitignore: add src/osmo-hnodeb/osmo-hnodeb ...................................................................... gitignore: add src/osmo-hnodeb/osmo-hnodeb Change-Id: I6bfb0b0696b8910c3f095390d6634f49baeebb14 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/67/26067/1 diff --git a/.gitignore b/.gitignore index 0518b6f..635f5ed 100644 --- a/.gitignore +++ b/.gitignore @@ -45,6 +45,8 @@ tags /deps +src/osmo-hnodeb/osmo-hnodeb + #tests tests/testsuite.dir tests/*/*_test -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6bfb0b0696b8910c3f095390d6634f49baeebb14 Gerrit-Change-Number: 26067 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 13:53:25 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 2 Nov 2021 13:53:25 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 to look at the new patch set (#2). Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... gbproxy: Move BSSGP decoding into its own function and use it This code was copied in BSS and SGSN PTP receive functions and also in the functions that extract the inner PDU-in-error from the STATUS PDU. Use a central function for less code duplication and better maintainability. This also fixes TTCN3 test TC_status_ptp_ul_tlli the c&p omitted the special handling of UL/DL unitdata. Related: OS#4892 Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 --- M src/gb_proxy.c 1 file changed, 27 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/62/26062/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:09:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 15:09:01 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 ) Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:09:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:10:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 15:10:18 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 ) Change subject: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I7965a4b68866c619159c524a63e051b0d9cbe80f Gerrit-Change-Number: 26064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:10:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:27:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 15:27:02 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 ) Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/2/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/2/src/gb_proxy.c at 1043 PS2, Line 1043: rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); so we don't need 2 TLVs anymore? or where they never needed? -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:27:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:27:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 15:27:42 +0000 Subject: Change in osmo-hnodeb[master]: gitignore: add src/osmo-hnodeb/osmo-hnodeb In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 ) Change subject: gitignore: add src/osmo-hnodeb/osmo-hnodeb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6bfb0b0696b8910c3f095390d6634f49baeebb14 Gerrit-Change-Number: 26067 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:27:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:27:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 15:27:59 +0000 Subject: Change in osmo-hnodeb[master]: rpm spec: fix invalid file paths In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 ) Change subject: rpm spec: fix invalid file paths ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I3c728489d38272d8477da5050f407708b8c4289b Gerrit-Change-Number: 26066 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:27:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:42:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 15:42:49 +0000 Subject: Change in osmo-hnodeb[master]: rpm spec: fix invalid file paths In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 ) Change subject: rpm spec: fix invalid file paths ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I3c728489d38272d8477da5050f407708b8c4289b Gerrit-Change-Number: 26066 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:42:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:43:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 15:43:00 +0000 Subject: Change in osmo-hnodeb[master]: gitignore: add src/osmo-hnodeb/osmo-hnodeb In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 ) Change subject: gitignore: add src/osmo-hnodeb/osmo-hnodeb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6bfb0b0696b8910c3f095390d6634f49baeebb14 Gerrit-Change-Number: 26067 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:43:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:43:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 15:43:57 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 ) Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:43:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 15:44:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Nov 2021 15:44:50 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 ) Change subject: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I7965a4b68866c619159c524a63e051b0d9cbe80f Gerrit-Change-Number: 26064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 15:44:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 15:46:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 15:46:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61815d7eb81ed_4be72abbd99885e040958d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 406s] # we create a symlink at ./srcfile.adoc pointing at [ 406s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 406s] # is like basename from coreutils, and . is WD. [ 406s] if ! [ -f test-usermanual.adoc ]; then \ [ 406s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 406s] fi [ 406s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 406s] # in ... [ 406s] TEXINPUTS=".." \ [ 406s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 406s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 406s] a2x: resource files: [] [ 406s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 406s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 406s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 406s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 406s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 406s] make[1]: *** [Makefile:363: all] Error 2 [ 406s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 406s] dh_auto_build: error: make -j1 returned exit code 2 [ 406s] make: *** [debian/rules:5: binary] Error 25 [ 406s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 407s] ### VM INTERACTION START ### [ 408s] Powering off. [ 408s] [ 388.222537] reboot: Power down [ 408s] ### VM INTERACTION END ### [ 408s] [ 408s] lamb02 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111020822.dsc" at Tue Nov 2 15:46:33 UTC 2021. [ 408s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:01:54 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 16:01:54 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... add chreq:successful_ rate counters Related: SYS#4878 Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c 5 files changed, 60 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/68/26068/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 68654f2..68e7cfe 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -27,6 +27,13 @@ BTS_CTR_CHREQ_ATTEMPTED_OTHER, BTS_CTR_CHREQ_ATTEMPTED_UNKNOWN, BTS_CTR_CHREQ_SUCCESSFUL, + BTS_CTR_CHREQ_SUCCESSFUL_EMERG, + BTS_CTR_CHREQ_SUCCESSFUL_CALL, + BTS_CTR_CHREQ_SUCCESSFUL_LOCATION_UPD, + BTS_CTR_CHREQ_SUCCESSFUL_PAG, + BTS_CTR_CHREQ_SUCCESSFUL_PDCH, + BTS_CTR_CHREQ_SUCCESSFUL_OTHER, + BTS_CTR_CHREQ_SUCCESSFUL_UNKNOWN, BTS_CTR_CHREQ_NO_CHANNEL, BTS_CTR_CHREQ_MAX_DELAY_EXCEEDED, BTS_CTR_CHAN_RF_FAIL, diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index cb56028..6a60f06 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -617,6 +617,8 @@ struct lchan_activate_info { enum lchan_activate_for activ_for; + /* If activ_for == ACTIVATE_FOR_MS_CHANNEL_REQUEST, the original CHREQ reason. */ + enum gsm_chreq_reason_t chreq_reason; struct gsm_subscriber_connection *for_conn; struct channel_mode_and_rate ch_mode_rate; struct gsm_encr encr; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0e2ffc6..5745f33 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2091,6 +2091,7 @@ gsm_chreq_name(rqd->reason), rqd->ref.ra, rqd->ta); info = (struct lchan_activate_info){ .activ_for = ACTIVATE_FOR_MS_CHANNEL_REQUEST, + .chreq_reason = rqd->reason, .ch_mode_rate = { .chan_mode = GSM48_CMODE_SIGN, .chan_rate = CH_RATE_SDCCH, @@ -2149,8 +2150,32 @@ /* send IMMEDIATE ASSIGN CMD on RSL to BTS (to send on CCCH to MS) */ rc = rsl_imm_assign_cmd(bts, sizeof(*ia)+ia->mob_alloc_len, (uint8_t *) ia); - if (!rc) + if (!rc) { rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL)); + switch (lchan->activate.info.chreq_reason) { + case GSM_CHREQ_REASON_EMERG: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); + break; + case GSM_CHREQ_REASON_CALL: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_CALL)); + break; + case GSM_CHREQ_REASON_LOCATION_UPD: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_LOCATION_UPD)); + break; + case GSM_CHREQ_REASON_PAG: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PAG)); + break; + case GSM_CHREQ_REASON_PDCH: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PDCH)); + break; + case GSM_CHREQ_REASON_OTHER: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_OTHER)); + break; + default: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_UNKNOWN)); + break; + } + } return rc; } diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 21ee01a..28059bb 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -849,6 +849,27 @@ [BTS_CTR_CHREQ_SUCCESSFUL] = \ { "chreq:successful", "Successful channel requests (immediate assign sent)" }, + [BTS_CTR_CHREQ_SUCCESSFUL_EMERG] = \ + { "chreq:successful_emerg", + "Sent Immediate Assignment for EMERG" }, + [BTS_CTR_CHREQ_SUCCESSFUL_CALL] = \ + { "chreq:successful_call", + "Sent Immediate Assignment for CALL" }, + [BTS_CTR_CHREQ_SUCCESSFUL_LOCATION_UPD] = \ + { "chreq:successful_location_upd", + "Sent Immediate Assignment for LOCATION_UPD" }, + [BTS_CTR_CHREQ_SUCCESSFUL_PAG] = \ + { "chreq:successful_pag", + "Sent Immediate Assignment for PAG" }, + [BTS_CTR_CHREQ_SUCCESSFUL_PDCH] = \ + { "chreq:successful_pdch", + "Sent Immediate Assignment for PDCH" }, + [BTS_CTR_CHREQ_SUCCESSFUL_OTHER] = \ + { "chreq:successful_other", + "Sent Immediate Assignment for OTHER" }, + [BTS_CTR_CHREQ_SUCCESSFUL_UNKNOWN] = \ + { "chreq:successful_unknown", + "Sent Immediate Assignment for UNKNOWN" }, [BTS_CTR_CHREQ_NO_CHANNEL] = \ { "chreq:no_channel", "Sent to MS no channel available" }, diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 2f62487..72cea5f 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -627,6 +627,10 @@ lchan->release.requested = false; lchan->activate.info = *info; + /* To avoid confusion, invalidate info.chreq_reason value if it isn't for a CHREQ */ + if (lchan->activate.info.activ_for != ACTIVATE_FOR_MS_CHANNEL_REQUEST) + lchan->activate.info.chreq_reason = -1; + lchan->activate.concluded = false; lchan_fsm_state_chg(LCHAN_ST_WAIT_TS_READY); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:01:55 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 16:01:55 +0000 Subject: Change in osmo-bsc[master]: drop unused gsm48_tx_mm_serv_ack() References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26069 ) Change subject: drop unused gsm48_tx_mm_serv_ack() ...................................................................... drop unused gsm48_tx_mm_serv_ack() Related: SYS#4878 Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea --- M include/osmocom/bsc/gsm_04_08_rr.h M src/osmo-bsc/gsm_08_08.c 2 files changed, 0 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/26069/1 diff --git a/include/osmocom/bsc/gsm_04_08_rr.h b/include/osmocom/bsc/gsm_04_08_rr.h index 5ddee7f..1f50ef9 100644 --- a/include/osmocom/bsc/gsm_04_08_rr.h +++ b/include/osmocom/bsc/gsm_04_08_rr.h @@ -33,9 +33,6 @@ int gsm48_lchan_modify(struct gsm_lchan *lchan, uint8_t mode); int gsm48_rx_rr_modif_ack(struct msgb *msg); int gsm48_parse_meas_rep(struct gsm_meas_rep *rep, struct msgb *msg); -int gsm48_tx_mm_serv_ack(struct gsm_subscriber_connection *conn); -int gsm48_tx_mm_serv_rej(struct gsm_subscriber_connection *conn, - enum gsm48_reject_value value); struct msgb *gsm48_create_mm_serv_rej(enum gsm48_reject_value value); struct msgb *gsm48_create_loc_upd_rej(uint8_t cause); diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 91c90fe..1715533 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -101,23 +101,6 @@ msgb_free(resp); } -/* 9.2.5 CM service accept */ -int gsm48_tx_mm_serv_ack(struct gsm_subscriber_connection *conn) -{ - struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 SERV ACK"); - struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); - - msg->lchan = conn->lchan; - - gh->proto_discr = GSM48_PDISC_MM; - gh->msg_type = GSM48_MT_MM_CM_SERV_ACC; - - DEBUGP(DMM, "-> CM SERVICE ACK\n"); - - gscon_submit_rsl_dtap(conn, msg, 0, 0); - return 0; -} - static bool is_cm_service_for_emerg(struct msgb *msg) { struct gsm48_service_request *cm; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea Gerrit-Change-Number: 26069 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:01:55 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 16:01:55 +0000 Subject: Change in osmo-bsc[master]: cosmetic tweaks on handover counting code References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26070 ) Change subject: cosmetic tweaks on handover counting code ...................................................................... cosmetic tweaks on handover counting code I was a bit confused that grep did not find HO counters being used, so let's add some comments to better explain and provide a grep hook. Related: SYS#4878 Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 --- M src/osmo-bsc/handover_fsm.c 1 file changed, 25 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/26070/1 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 255478f..e61262f 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -108,10 +108,13 @@ rate_ctr_inc(rate_ctr_group_get_ctr(conn->network->bts_unknown_ctrs, counter)); \ } while(0) +/* Count handover result on both bts and bsc level. + * Call with 'counter' being the counter name without the "BSC_"/"BTS_" part, + * e.g. ho_count(conn_get_bts(conn), CTR_HANDOVER_ATTEMPTED); */ #define ho_count(bts, counter) do { \ - ho_count_bsc(BSC_##counter); \ - ho_count_bts(bts, BTS_##counter); \ -} while(0) + ho_count_bsc(BSC_##counter); \ + ho_count_bts(bts, BTS_##counter); \ + } while(0) static uint8_t g_next_ho_ref = 1; @@ -748,6 +751,23 @@ lchan_activate(ho->new_lchan, &info); } +/* Create functions result_counter_{BSC,BTS}_{HANDOVER,...}(), to evaluate the handover result and return + * BSC_CTR_HANDOVER_ATTEMPTED, + * BSC_CTR_HANDOVER_COMPLETED, + * BSC_CTR_HANDOVER_STOPPED, + * BSC_CTR_HANDOVER_NO_CHANNEL, + * BSC_CTR_HANDOVER_TIMEOUT, + * BSC_CTR_HANDOVER_FAILED, + * BSC_CTR_HANDOVER_ERROR, + * or + * BTS_CTR_HANDOVER_ATTEMPTED, + * BTS_CTR_HANDOVER_COMPLETED, + * BTS_CTR_HANDOVER_STOPPED, + * BTS_CTR_HANDOVER_NO_CHANNEL, + * BTS_CTR_HANDOVER_TIMEOUT, + * BTS_CTR_HANDOVER_FAILED, + * BTS_CTR_HANDOVER_ERROR, + */ #define FUNC_RESULT_COUNTER(obj, name) \ static int result_counter_##obj##_##name(enum handover_result result) \ { \ @@ -773,6 +793,7 @@ FUNC_RESULT_COUNTER(BSC, INTRA_BSC_HO) FUNC_RESULT_COUNTER(BSC, INTER_BSC_HO_IN) +/* INTRA_BSC_HO_OUT does not have a NO_CHANNEL result, so can't do this with FUNC_RESULT_COUNTER() macro. */ static int result_counter_BSC_INTER_BSC_HO_OUT(enum handover_result result) { switch (result) { case HO_RESULT_OK: @@ -810,6 +831,7 @@ FUNC_RESULT_COUNTER(BTS, INTRA_BSC_HO) FUNC_RESULT_COUNTER(BTS, INTER_BSC_HO_IN) +/* INTRA_BSC_HO_OUT does not have a NO_CHANNEL result, so can't do this with FUNC_RESULT_COUNTER() macro. */ static int result_counter_BTS_INTER_BSC_HO_OUT(enum handover_result result) { switch (result) { case HO_RESULT_OK: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 Gerrit-Change-Number: 26070 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:01:55 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 16:01:55 +0000 Subject: Change in osmo-bsc[master]: tweak intra-bsc ho counter descriptions References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26071 ) Change subject: tweak intra-bsc ho counter descriptions ...................................................................... tweak intra-bsc ho counter descriptions Related: SYS#4878 Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 --- M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/26071/1 diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index 7176809..ccba4a6 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -35,13 +35,13 @@ [BSC_CTR_ASSIGNMENT_FAILED] = {"assignment:failed", "Received Assignment Failure message"}, [BSC_CTR_ASSIGNMENT_ERROR] = {"assignment:error", "Assignment failed for other reason"}, - [BSC_CTR_HANDOVER_ATTEMPTED] = {"handover:attempted", "Intra-BSC handover attempts"}, - [BSC_CTR_HANDOVER_COMPLETED] = {"handover:completed", "Intra-BSC handover completed"}, + [BSC_CTR_HANDOVER_ATTEMPTED] = {"handover:attempted", "Handover attempts"}, + [BSC_CTR_HANDOVER_COMPLETED] = {"handover:completed", "Handover completed"}, [BSC_CTR_HANDOVER_STOPPED] = {"handover:stopped", "Connection ended during HO"}, [BSC_CTR_HANDOVER_NO_CHANNEL] = {"handover:no_channel", "Failure to allocate lchan for HO"}, [BSC_CTR_HANDOVER_TIMEOUT] = {"handover:timeout", "Handover timed out"}, [BSC_CTR_HANDOVER_FAILED] = {"handover:failed", "Received Handover Fail messages"}, - [BSC_CTR_HANDOVER_ERROR] = {"handover:error", "Re-assignment failed for other reason"}, + [BSC_CTR_HANDOVER_ERROR] = {"handover:error", "Handover failed for other reason"}, [BSC_CTR_INTRA_CELL_HO_ATTEMPTED] = {"intra_cell_ho:attempted", "Intra-Cell handover attempts"}, [BSC_CTR_INTRA_CELL_HO_COMPLETED] = {"intra_cell_ho:completed", "Intra-Cell handover completed"}, @@ -49,15 +49,15 @@ [BSC_CTR_INTRA_CELL_HO_NO_CHANNEL] = {"intra_cell_ho:no_channel", "Failure to allocate lchan for HO"}, [BSC_CTR_INTRA_CELL_HO_TIMEOUT] = {"intra_cell_ho:timeout", "Handover timed out"}, [BSC_CTR_INTRA_CELL_HO_FAILED] = {"intra_cell_ho:failed", "Received Handover Fail messages"}, - [BSC_CTR_INTRA_CELL_HO_ERROR] = {"intra_cell_ho:error", "Re-assignment failed for other reason"}, + [BSC_CTR_INTRA_CELL_HO_ERROR] = {"intra_cell_ho:error", "Intra-cell handover failed for other reason"}, - [BSC_CTR_INTRA_BSC_HO_ATTEMPTED] = {"intra_bsc_ho:attempted", "Intra-BSC handover attempts"}, - [BSC_CTR_INTRA_BSC_HO_COMPLETED] = {"intra_bsc_ho:completed", "Intra-BSC handover completed"}, + [BSC_CTR_INTRA_BSC_HO_ATTEMPTED] = {"intra_bsc_ho:attempted", "Intra-BSC inter-cell handover attempts"}, + [BSC_CTR_INTRA_BSC_HO_COMPLETED] = {"intra_bsc_ho:completed", "Intra-BSC inter-cell handover completed"}, [BSC_CTR_INTRA_BSC_HO_STOPPED] = {"intra_bsc_ho:stopped", "Connection ended during HO"}, [BSC_CTR_INTRA_BSC_HO_NO_CHANNEL] = {"intra_bsc_ho:no_channel", "Failure to allocate lchan for HO"}, [BSC_CTR_INTRA_BSC_HO_TIMEOUT] = {"intra_bsc_ho:timeout", "Handover timed out"}, [BSC_CTR_INTRA_BSC_HO_FAILED] = {"intra_bsc_ho:failed", "Received Handover Fail messages"}, - [BSC_CTR_INTRA_BSC_HO_ERROR] = {"intra_bsc_ho:error", "Re-assignment failed for other reason"}, + [BSC_CTR_INTRA_BSC_HO_ERROR] = {"intra_bsc_ho:error", "Intra-BSC inter-cell HO failed for other reason"}, [BSC_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = {"interbsc_ho_out:attempted", "Attempts to handover to remote BSS"}, diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 28059bb..ee2e791 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1146,10 +1146,10 @@ [BTS_CTR_INTRA_BSC_HO_ATTEMPTED] = \ { "intra_bsc_ho:attempted", - "Intra-BSC handover attempts" }, + "Intra-BSC inter-cell handover attempts" }, [BTS_CTR_INTRA_BSC_HO_COMPLETED] = \ { "intra_bsc_ho:completed", - "Intra-BSC handover completed" }, + "Intra-BSC inter-cell handover completed" }, [BTS_CTR_INTRA_BSC_HO_STOPPED] = \ { "intra_bsc_ho:stopped", "Connection ended during HO" }, @@ -1164,7 +1164,7 @@ "Received Handover Fail messages" }, [BTS_CTR_INTRA_BSC_HO_ERROR] = \ { "intra_bsc_ho:error", - "Re-assignment failed for other reason" }, + "Intra-BSC inter-cell HO failed for other reason" }, [BTS_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = \ { "interbsc_ho_out:attempted", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 Gerrit-Change-Number: 26071 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:01:56 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 16:01:56 +0000 Subject: Change in osmo-bsc[master]: implement incoming_intra_bsc_ho:* rate counters References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26072 ) Change subject: implement incoming_intra_bsc_ho:* rate counters ...................................................................... implement incoming_intra_bsc_ho:* rate counters We have lots of counters for intra-BSC handover *away from* a given BTS, but still missing are counters indicating how many handovers *targeted* a given BTS. Also count incoming HO. Related: SYS#4878 Related: Iba229313d73fa20266f6d4eac5820579fb14c604 (osmo-ttcn3-hacks) Change-Id: Id9f2c6e2865ebe680879018fff08d283ce24c983 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/handover_fsm.c 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/26072/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 68e7cfe..7e73acd 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -131,6 +131,13 @@ BTS_CTR_INTRA_BSC_HO_TIMEOUT, BTS_CTR_INTRA_BSC_HO_FAILED, BTS_CTR_INTRA_BSC_HO_ERROR, + BTS_CTR_INCOMING_INTRA_BSC_HO_ATTEMPTED, + BTS_CTR_INCOMING_INTRA_BSC_HO_COMPLETED, + BTS_CTR_INCOMING_INTRA_BSC_HO_STOPPED, + BTS_CTR_INCOMING_INTRA_BSC_HO_NO_CHANNEL, + BTS_CTR_INCOMING_INTRA_BSC_HO_TIMEOUT, + BTS_CTR_INCOMING_INTRA_BSC_HO_FAILED, + BTS_CTR_INCOMING_INTRA_BSC_HO_ERROR, BTS_CTR_INTER_BSC_HO_OUT_ATTEMPTED, BTS_CTR_INTER_BSC_HO_OUT_COMPLETED, BTS_CTR_INTER_BSC_HO_OUT_STOPPED, diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index ee2e791..83adcc4 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1166,6 +1166,28 @@ { "intra_bsc_ho:error", "Intra-BSC inter-cell HO failed for other reason" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_ATTEMPTED] = \ + { "incoming_intra_bsc_ho:attempted", + "Incoming intra-BSC inter-cell handover attempts" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_COMPLETED] = \ + { "incoming_intra_bsc_ho:completed", + "Incoming intra-BSC inter-cell handover completed" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_STOPPED] = \ + { "incoming_intra_bsc_ho:stopped", + "Connection ended during HO" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_NO_CHANNEL] = \ + { "incoming_intra_bsc_ho:no_channel", + "Failure to allocate lchan for HO" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_TIMEOUT] = \ + { "incoming_intra_bsc_ho:timeout", + "Handover timed out" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_FAILED] = \ + { "incoming_intra_bsc_ho:failed", + "Received Handover Fail messages" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_ERROR] = \ + { "incoming_intra_bsc_ho:error", + "Incoming intra-BSC inter-cell HO failed for other reason" }, + [BTS_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = \ { "interbsc_ho_out:attempted", "Attempts to handover to remote BSS" }, diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index e61262f..8556ff9 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -387,6 +387,7 @@ } else { ho_count(bts, CTR_INTRA_BSC_HO_ATTEMPTED); ho_fsm_update_id(fi, "intraBSC"); + ho_count_bts(ho->new_bts, BTS_CTR_INCOMING_INTRA_BSC_HO_ATTEMPTED); } if (!ho->new_lchan) { @@ -829,6 +830,7 @@ FUNC_RESULT_COUNTER(BTS, HANDOVER) FUNC_RESULT_COUNTER(BTS, INTRA_CELL_HO) FUNC_RESULT_COUNTER(BTS, INTRA_BSC_HO) +FUNC_RESULT_COUNTER(BTS, INCOMING_INTRA_BSC_HO) FUNC_RESULT_COUNTER(BTS, INTER_BSC_HO_IN) /* INTRA_BSC_HO_OUT does not have a NO_CHANNEL result, so can't do this with FUNC_RESULT_COUNTER() macro. */ @@ -1020,6 +1022,9 @@ ho_count_bsc(result_counter_bsc(ho->scope, result)); ho_count_bts(bts, result_counter_BTS_HANDOVER(result)); ho_count_bts(bts, result_counter_bts(ho->scope, result)); + /* For inter-cell HO, also increment the "INCOMING" counters on the target BTS. */ + if (ho->scope & HO_INTRA_BSC) + ho_count_bts(ho->new_bts, result_counter_BTS_INCOMING_INTRA_BSC_HO(result)); if (ho->scope & HO_INTER_BSC_IN && conn->fast_return.last_eutran_plmn_valid) { /* From outside local BSC and with Last EUTRAN PLMN Id => SRVCC */ ho_count_bsc(result_counter_BSC_SRVCC(result)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f2c6e2865ebe680879018fff08d283ce24c983 Gerrit-Change-Number: 26072 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:09:21 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 16:09:21 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > Let's let other specialized systems do this kind of stuff instead of bloating our code base. I'm not blocking this if still others think it is a good idea to have this merged. Let's identify which bloat can be removed. Maybe I'm not seeing it because I wrote the code? The only simplification that I see is hardcoding time_cc to a granularity period of one second, and not allowing a round threshold / forget-sum config. Switching to a stat_item per se does not remove any of this code at all. Most of this is about keeping track of a flag over time. Oh, you mean we should just export the flag as 0 or 1, and not count it over time at all? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 16:09:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 16:07:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:07:05 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618164bc28917_4be72abbd99885e04130e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 397s] # we create a symlink at ./srcfile.adoc pointing at [ 397s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 397s] # is like basename from coreutils, and . is WD. [ 397s] if ! [ -f test-usermanual.adoc ]; then \ [ 397s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 397s] fi [ 397s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 397s] # in ... [ 397s] TEXINPUTS=".." \ [ 397s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 397s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 397s] a2x: resource files: [] [ 397s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 397s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 397s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 397s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 397s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 397s] make[1]: *** [Makefile:363: all] Error 2 [ 397s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 397s] dh_auto_build: error: make -j1 returned exit code 2 [ 397s] make: *** [debian/rules:5: binary] Error 25 [ 397s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 397s] ### VM INTERACTION START ### [ 399s] Powering off. [ 399s] [ 379.411775] reboot: Power down [ 399s] ### VM INTERACTION END ### [ 399s] [ 399s] lamb59 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Tue Nov 2 16:06:52 UTC 2021. [ 399s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:15:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:15:52 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618164ca1aff9_4be72abbd99885e04153d3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 289s] # is like basename from coreutils, and . is WD. [ 289s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 289s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 289s] fi [ 289s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 289s] # in /usr/share/osmo-gsm-manuals. [ 289s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 289s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 289s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 289s] a2x: resource files: [] [ 289s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 289s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 289s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 289s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 289s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 289s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 289s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 289s] make[1]: *** [Makefile:392: all] Error 2 [ 289s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 289s] dh_auto_build: error: make -j1 returned exit code 2 [ 289s] make: *** [debian/rules:15: build] Error 25 [ 289s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 289s] ### VM INTERACTION START ### [ 290s] Powering off. [ 290s] [ 275.676435] reboot: Power down [ 290s] ### VM INTERACTION END ### [ 290s] [ 290s] sheep86 failed "build osmo-ggsn_1.7.1.dsc" at Tue Nov 2 16:15:49 UTC 2021. [ 290s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:18:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:18:08 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618164cd584cf_4be72abbd99885e04157a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 204s] | ^~~~~ [ 204s] mgcp_client.c:745:67: error: invalid type argument of unary '*' (have 'int') [ 204s] 745 | osmo_sock_get_name2(fd->fd), errno, strerror(errno), [ 204s] | ^~~~~ [ 204s] mgcp_client.c: In function 'mgcp_client_connect': [ 204s] mgcp_client.c:848:83: error: invalid type argument of unary '*' (have 'int') [ 204s] 848 | mgcp->actual.remote_addr, mgcp->actual.remote_port, strerror(errno)); [ 204s] | ^~~~~ [ 204s] mgcp_client.c:848:83: error: invalid type argument of unary '*' (have 'int') [ 204s] 848 | mgcp->actual.remote_addr, mgcp->actual.remote_port, strerror(errno)); [ 204s] | ^~~~~ [ 204s] make[4]: *** [Makefile:507: mgcp_client.lo] Error 1 [ 204s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libosmo-mgcp-client' [ 204s] make[3]: *** [Makefile:408: all-recursive] Error 1 [ 204s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 204s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 204s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 204s] make[1]: *** [Makefile:423: all] Error 2 [ 204s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 204s] dh_auto_build: error: make -j1 returned exit code 2 [ 204s] make: *** [debian/rules:17: build] Error 25 [ 204s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 204s] ### VM INTERACTION START ### [ 205s] Powering off. [ 205s] [ 194.633929] reboot: Power down [ 205s] ### VM INTERACTION END ### [ 205s] [ 205s] goat01 failed "build osmo-mgw_1.8.1.dsc" at Tue Nov 2 16:17:54 UTC 2021. [ 205s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:17:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:17:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618164cc15cde_4be72abbd99885e04155a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 373s] # is like basename from coreutils, and . is WD. [ 373s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 373s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 373s] fi [ 373s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 373s] # in /usr/share/osmo-gsm-manuals. [ 373s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 373s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 373s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 373s] a2x: resource files: [] [ 373s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 373s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 373s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 373s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 373s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 373s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 373s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 373s] make[1]: *** [Makefile:327: all] Error 2 [ 373s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 373s] dh_auto_build: error: make -j1 returned exit code 2 [ 373s] make: *** [debian/rules:12: build] Error 25 [ 373s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 373s] ### VM INTERACTION START ### [ 374s] Powering off. [ 374s] [ 354.775015] reboot: Power down [ 374s] ### VM INTERACTION END ### [ 374s] [ 374s] old-cirrus1 failed "build osmo-sip-connector_1.5.1.dsc" at Tue Nov 2 16:17:23 UTC 2021. [ 374s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:18:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:18:08 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618164cd826d8_4be72abbd99885e0415853@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 205s] # is like basename from coreutils, and . is WD. [ 205s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 205s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 205s] fi [ 205s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 205s] # in /usr/share/osmo-gsm-manuals. [ 205s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 205s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 205s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 205s] a2x: resource files: [] [ 205s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 205s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 205s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 205s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 205s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 205s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 205s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 205s] make[1]: *** [Makefile:368: all] Error 2 [ 205s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 205s] dh_auto_build: error: make -j1 returned exit code 2 [ 205s] make: *** [debian/rules:45: build] Error 25 [ 205s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 205s] ### VM INTERACTION START ### [ 206s] Powering off. [ 206s] [ 194.983272] reboot: Power down [ 206s] ### VM INTERACTION END ### [ 206s] [ 206s] goat13 failed "build osmo-cbc_0.2.2.dsc" at Tue Nov 2 16:17:55 UTC 2021. [ 206s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:18:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 16:18:37 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: IIUC what's needed is an stat_item, a "struct timepsec start" storing the last date, and some time function setting the stat_item to timespecsub(now(),start). And setting start to {0,0} to set it to zero or keep last value or whatever. Am I missing something here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 16:18:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 16:18:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:18:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61816500a8306_4be72abbd99885e041598d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 432s] # we create a symlink at ./srcfile.adoc pointing at [ 432s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 432s] # is like basename from coreutils, and . is WD. [ 432s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 432s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 432s] fi [ 432s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 432s] # in /usr/share/osmo-gsm-manuals. [ 432s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 432s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 432s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 432s] a2x: resource files: [] [ 432s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 432s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 432s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 432s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 432s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 432s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 432s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 432s] dh_auto_build: error: make -j1 returned exit code 2 [ 432s] make: *** [debian/rules:12: build] Error 25 [ 432s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 432s] ### VM INTERACTION START ### [ 433s] Powering off. [ 433s] [ 414.183178] reboot: Power down [ 434s] ### VM INTERACTION END ### [ 434s] [ 434s] lamb06 failed "build osmo-pcu_0.9.1.dsc" at Tue Nov 2 16:18:25 UTC 2021. [ 434s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:18:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:18:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618165014afc4_4be72abbd99885e04162b4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 449s] # is like basename from coreutils, and . is WD. [ 449s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 449s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 449s] fi [ 449s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 449s] # in /usr/share/osmo-gsm-manuals. [ 449s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 449s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 449s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 449s] a2x: resource files: [] [ 449s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 449s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 449s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 449s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 449s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 449s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 449s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 449s] make[1]: *** [Makefile:377: all] Error 2 [ 449s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 449s] dh_auto_build: error: make -j1 returned exit code 2 [ 449s] make: *** [debian/rules:45: build] Error 25 [ 449s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 449s] ### VM INTERACTION START ### [ 450s] Powering off. [ 450s] [ 390.990415] reboot: Power down [ 450s] ### VM INTERACTION END ### [ 450s] [ 450s] lamb04 failed "build osmo-gbproxy_0.1.2.dsc" at Tue Nov 2 16:18:35 UTC 2021. [ 450s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:18:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:18:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61816500db6e0_4be72abbd99885e0416017@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 237s] # is like basename from coreutils, and . is WD. [ 237s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 237s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 237s] fi [ 237s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 237s] # in /usr/share/osmo-gsm-manuals. [ 237s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 237s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 237s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 237s] a2x: resource files: [] [ 237s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 237s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 237s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 237s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 237s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 237s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 237s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 237s] make[1]: *** [Makefile:410: all] Error 2 [ 237s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 237s] dh_auto_build: error: make -j1 returned exit code 2 [ 237s] make: *** [debian/rules:7: build] Error 25 [ 237s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 237s] ### VM INTERACTION START ### [ 238s] Powering off. [ 238s] [ 227.069977] reboot: Power down [ 238s] ### VM INTERACTION END ### [ 238s] [ 238s] goat09 failed "build osmo-hlr_1.3.1.dsc" at Tue Nov 2 16:18:29 UTC 2021. [ 238s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:18:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:18:59 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61816501aaf18_4be72abbd99885e041633b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 466s] # is like basename from coreutils, and . is WD. [ 466s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 466s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 466s] fi [ 466s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 466s] # in /usr/share/osmo-gsm-manuals. [ 466s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 466s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 466s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 466s] a2x: resource files: [] [ 466s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 466s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 466s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 466s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 466s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 466s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 466s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 466s] make[1]: *** [Makefile:371: all] Error 2 [ 466s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 466s] dh_auto_build: error: make -j1 returned exit code 2 [ 466s] make: *** [debian/rules:12: build] Error 25 [ 466s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 466s] ### VM INTERACTION START ### [ 467s] Powering off. [ 467s] [ 421.973358] reboot: Power down [ 467s] ### VM INTERACTION END ### [ 467s] [ 467s] cloud108 failed "build osmo-bts_1.3.3.dsc" at Tue Nov 2 16:18:53 UTC 2021. [ 467s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:19:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:19:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61816539d0ca4_4be72abbd99885e0416448@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 517s] # is like basename from coreutils, and . is WD. [ 517s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 517s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 517s] fi [ 517s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 517s] # in /usr/share/osmo-gsm-manuals. [ 517s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 517s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 517s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 517s] a2x: resource files: [] [ 517s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 517s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 517s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 517s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 517s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 517s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 517s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 517s] make[1]: *** [Makefile:387: all] Error 2 [ 517s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 517s] dh_auto_build: error: make -j1 returned exit code 2 [ 517s] make: *** [debian/rules:12: build] Error 25 [ 517s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 518s] ### VM INTERACTION START ### [ 519s] Powering off. [ 519s] [ 466.208474] reboot: Power down [ 519s] ### VM INTERACTION END ### [ 519s] [ 519s] cloud121 failed "build osmo-remsim_0.2.4.dsc" at Tue Nov 2 16:19:48 UTC 2021. [ 519s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:21:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:21:49 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618165b7d5a22_4be72abbd99885e0417728@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 420s] # is like basename from coreutils, and . is WD. [ 420s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 420s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 420s] fi [ 420s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 420s] # in /usr/share/osmo-gsm-manuals. [ 420s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 420s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 420s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 420s] a2x: resource files: [] [ 420s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 420s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 420s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 420s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 420s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 420s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 420s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 420s] make[1]: *** [Makefile:403: all] Error 2 [ 420s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 420s] dh_auto_build: error: make -j1 returned exit code 2 [ 420s] make: *** [debian/rules:12: build] Error 25 [ 420s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 420s] ### VM INTERACTION START ### [ 421s] Powering off. [ 421s] [ 402.422191] reboot: Power down [ 422s] ### VM INTERACTION END ### [ 422s] [ 422s] lamb03 failed "build libosmo-sccp_1.4.0.dsc" at Tue Nov 2 16:21:39 UTC 2021. [ 422s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:24:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:24:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618166696f39f_4be72abbd99885e04182c7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 510s] # is like basename from coreutils, and . is WD. [ 510s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 510s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 510s] fi [ 510s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 510s] # in /usr/share/osmo-gsm-manuals. [ 510s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 510s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 510s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 510s] a2x: resource files: [] [ 510s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 510s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 510s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 510s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 510s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 510s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 510s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 510s] make[1]: *** [Makefile:452: all] Error 2 [ 510s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 510s] dh_auto_build: error: make -j1 returned exit code 2 [ 510s] make: *** [debian/rules:6: build] Error 25 [ 510s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 510s] ### VM INTERACTION START ### [ 511s] Powering off. [ 511s] [ 491.811814] reboot: Power down [ 512s] ### VM INTERACTION END ### [ 512s] [ 512s] lamb19 failed "build osmo-trx_1.3.1.dsc" at Tue Nov 2 16:24:51 UTC 2021. [ 512s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:29:11 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 16:29:11 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > IIUC what's needed is an stat_item, a "struct timepsec start" storing the last date, and some time function setting the stat_item to timespecsub(now(),start). And setting start to {0,0} to set it to zero or keep last value or whatever. Am I missing something here? The situation, that all channels are allocated, often fluctuates rapidly. A channel is released, flag goes false. That last free channel is allocated again, flag goes true. In order to determine how much time exactly all channels were allocated, you can't just remember a point in time and report the difference. This code remembers when the flag went true and counts the time until it goes false. Repeat that, and this code sums up those times where the flag was true. Sounds like that is what you are trying to describe with the timespec start? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 16:29:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 16:29:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:29:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181679239bf4_4be72abbd99885e0418996@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 427s] # is like basename from coreutils, and . is WD. [ 427s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 427s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 427s] fi [ 427s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 427s] # in /usr/share/osmo-gsm-manuals. [ 427s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 427s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 427s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 427s] a2x: resource files: [] [ 427s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 427s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 427s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 427s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 427s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 427s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 427s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 427s] make[1]: *** [Makefile:388: all] Error 2 [ 427s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 427s] dh_auto_build: error: make -j1 returned exit code 2 [ 427s] make: *** [debian/rules:45: build] Error 25 [ 427s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 428s] ### VM INTERACTION START ### [ 429s] Powering off. [ 429s] [ 410.185773] reboot: Power down [ 429s] ### VM INTERACTION END ### [ 429s] [ 429s] lamb15 failed "build osmo-bsc_1.7.2.dsc" at Tue Nov 2 16:29:33 UTC 2021. [ 429s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:30:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:30:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618167b0bef8a_4be72abbd99885e0419093@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 471s] # is like basename from coreutils, and . is WD. [ 471s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 471s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 471s] fi [ 471s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 471s] # in /usr/share/osmo-gsm-manuals. [ 471s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 471s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 472s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 472s] a2x: resource files: [] [ 472s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 472s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 472s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 472s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 472s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 472s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 472s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 472s] make[1]: *** [Makefile:377: all] Error 2 [ 472s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 472s] dh_auto_build: error: make -j1 returned exit code 2 [ 472s] make: *** [debian/rules:45: build] Error 25 [ 472s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 472s] ### VM INTERACTION START ### [ 473s] Powering off. [ 473s] [ 436.942503] reboot: Power down [ 473s] ### VM INTERACTION END ### [ 473s] [ 473s] lamb01 failed "build osmo-smlc_0.2.0.dsc" at Tue Nov 2 16:30:14 UTC 2021. [ 473s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:34:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:34:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618168c1d101d_4be72abbd99885e0420255@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 747s] # is like basename from coreutils, and . is WD. [ 747s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 747s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 747s] fi [ 747s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 747s] # in /usr/share/osmo-gsm-manuals. [ 747s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 747s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 747s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 747s] a2x: resource files: [] [ 747s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 747s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 747s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 747s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 747s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 747s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 747s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 747s] make[1]: *** [Makefile:391: all] Error 2 [ 747s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 747s] dh_auto_build: error: make -j1 returned exit code 2 [ 747s] make: *** [debian/rules:9: build] Error 25 [ 747s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 747s] ### VM INTERACTION START ### [ 748s] Powering off. [ 748s] [ 727.078112] reboot: Power down [ 748s] ### VM INTERACTION END ### [ 748s] [ 748s] lamb04 failed "build osmo-iuh_1.0.0.dsc" at Tue Nov 2 16:34:48 UTC 2021. [ 748s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:42:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:42:13 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61816a8036167_4be72abbd99885e04219b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 412s] # is like basename from coreutils, and . is WD. [ 412s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 412s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 412s] fi [ 412s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 412s] # in /usr/share/osmo-gsm-manuals. [ 412s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 412s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 412s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 412s] a2x: resource files: [] [ 412s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 412s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 412s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 412s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 412s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 412s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 412s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 412s] make[1]: *** [Makefile:394: all] Error 2 [ 412s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 412s] dh_auto_build: error: make -j1 returned exit code 2 [ 412s] make: *** [debian/rules:45: build] Error 25 [ 412s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 412s] ### VM INTERACTION START ### [ 413s] Powering off. [ 413s] [ 394.288775] reboot: Power down [ 413s] ### VM INTERACTION END ### [ 413s] [ 413s] lamb10 failed "build osmo-sgsn_1.7.1.dsc" at Tue Nov 2 16:42:03 UTC 2021. [ 413s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 16:43:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 16:43:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61816abeb016e_4be72abbd99885e04220cf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 474s] # is like basename from coreutils, and . is WD. [ 474s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 474s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 474s] fi [ 474s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 474s] # in /usr/share/osmo-gsm-manuals. [ 474s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 474s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 474s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 474s] a2x: resource files: [] [ 474s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 474s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 474s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 474s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 474s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 474s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 474s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 474s] make[1]: *** [Makefile:402: all] Error 2 [ 474s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 474s] dh_auto_build: error: make -j1 returned exit code 2 [ 474s] make: *** [debian/rules:45: build] Error 25 [ 474s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 474s] ### VM INTERACTION START ### [ 476s] Powering off. [ 476s] [ 433.224601] reboot: Power down [ 476s] ### VM INTERACTION END ### [ 476s] [ 476s] cloud114 failed "build osmo-msc_1.7.1.dsc" at Tue Nov 2 16:43:05 UTC 2021. [ 476s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 2 16:45:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 16:45:21 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: { struct timespec last; struct timer_list timer; } 1- Last channel is allocated: * clock_gettime(last); timer_schedule(cb_func); 2- cb_func triggers: * clock_gettime(now), osmo_stat_item_add(st, now - last); last = now; timer_schedule(cb_func); 3- A channel is freed: * if (time_is_pending(timer)) { clock_gettime(now), osmo_stat_item_add(st, now - last); timer_stop(timer); } "counting" is not even needed, the timer_is_pending() is enough to see if it is counting or not. Is there a problem with this approach? AFAIU this would track time even if its under granularity of the timer. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 16:45:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:03:21 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Nov 2021 17:03:21 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... Patch Set 2: I keep getting new missing build depends. packages generated from the patchset have been uploaded here: https://build.opensuse.org/package/show/home:osmith42/osmo-hnodeb So if this passes, it is good to go (will take some time as it builds dependencies too, until then it shows unresolvable/blocked). Otherwise I'll fix it up tomorrow. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Nov 2021 17:03:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:20:23 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 17:20:23 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: this is pretty much exactly what this code is doing. (except you seem to be forgetting the detail that you also need to remember the time when cb_func last added to the counter.) There are two additions which i already mentioned: In addition, this code allows defining the precision: count seconds? count minutes? milliseconds? And in addition, this code allows defining the "rounding" behavior. Should we report the first increment already at the first millisecond, or at half a second, or stay with reporting 0 until 0.9999s of true flag. It makes a big difference in resulting statistics: if all channels are allocated for short fractions of a second, you may never notice that channels were ever exhausted. Because I can't fathom the users' preferences here, I made things configurable by T timers. These additions may be feature creep. I could invest more time to remove these features. Is it worth it? Then there is still the question of how to report the counter to statistics. I still find a rate counter more useful than a stat item. From the point of view of a user's evaluation of statistics, there seems to be not much of a difference between stat item and rate counter. But on the VTY I can trivially see the percentage of exhausted channels because we display counters per second, per minute, per hour. If I see 1/sec, 30/min, 35/hour, then I immediately know that currently all channels are exhausted, this was so for half the time in the last minute, but this situation apparently just started recently because there were only few seconds of the last hour of exhaustion. If you argue for a stat item instead then let's hear the argument for it. I'm not convinced that a simple incrementing value in a stat item has any benefits over a rate counter. If I see a value of 12345 it only tells me that since whenever osmo-bsc started, there were 12k seconds of channel exhaustion. It says nothing about now or recent events, and requires elaborate evaluation (e.g. elastic search statistics engine) to make any use of; IOW you need to watch it change over time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 17:20:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:26:41 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 2 Nov 2021 17:26:41 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > (except you seem to be forgetting the detail that you also need to remember the time when cb_func last added to the counter.) scratch that, you didn't forget it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 17:26:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:39:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 17:39:18 +0000 Subject: Change in osmo-sip-connector[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/25980 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/25980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Iaff46732948f8f5d03e42f17c35cbac8a80af49b Gerrit-Change-Number: 25980 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Nov 2021 17:39:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:40:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 17:40:53 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 7: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Comment-Date: Tue, 02 Nov 2021 17:40:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:42 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 to look at the new patch set (#2). Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used ...................................................................... tbf_ul: Document context where tbf_alloc_ul_ccch() is used It can be seen that this function properly passes single=true to tbf_alloc_ul_tbf(). Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 --- M src/tbf_ul.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/61/26061/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:43 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... bts: Rename 11bit RACH request counter This way it fits better the structure where the general one counts all rachs, and 11bit only the 11 bits. More per-type splitting will be done in follow-up commits where new types are added. Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 --- M src/bts.cpp M src/bts.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/73/26073/1 diff --git a/src/bts.cpp b/src/bts.cpp index bd1366e..4ce036b 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -136,7 +136,7 @@ { "pch:requests", "PCH requests sent "}, { "pch:requests:timeout", "PCH requests timeout "}, { "rach:requests", "RACH requests received"}, - { "11bit_rach:requests", "11BIT_RACH requests received"}, + { "rach:requests:11bit", "11BIT_RACH requests received"}, { "spb:uplink_first_segment", "First seg of UL SPB "}, { "spb:uplink_second_segment", "Second seg of UL SPB "}, { "spb:downlink_first_segment", "First seg of DL SPB "}, @@ -880,7 +880,7 @@ bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS); if (rip->is_11bit) - bts_do_rate_ctr_inc(bts, CTR_11BIT_RACH_REQUESTS); + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_11BIT); /* Determine full frame number */ uint32_t Fn = bts_rfn_to_fn(bts, rip->rfn); diff --git a/src/bts.h b/src/bts.h index d9a86eb..63f80a8 100644 --- a/src/bts.h +++ b/src/bts.h @@ -128,7 +128,7 @@ CTR_PCH_REQUESTS, CTR_PCH_REQUESTS_TIMEDOUT, CTR_RACH_REQUESTS, - CTR_11BIT_RACH_REQUESTS, + CTR_RACH_REQUESTS_11BIT, CTR_SPB_UL_FIRST_SEGMENT, CTR_SPB_UL_SECOND_SEGMENT, CTR_SPB_DL_FIRST_SEGMENT, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:44 +0000 Subject: Change in osmo-pcu[master]: bts: Introduce new RACH req counters for one/two phase access References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26074 ) Change subject: bts: Introduce new RACH req counters for one/two phase access ...................................................................... bts: Introduce new RACH req counters for one/two phase access These new counters allow the user to find out which kind of access are MS requesting. Related: SYS#4878 Change-Id: Id87c3a53d3acee92499987c843130e358f54742c --- M src/bts.cpp M src/bts.h M tests/tbf/TbfTest.err 3 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/74/26074/1 diff --git a/src/bts.cpp b/src/bts.cpp index 4ce036b..3678335 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -137,6 +137,8 @@ { "pch:requests:timeout", "PCH requests timeout "}, { "rach:requests", "RACH requests received"}, { "rach:requests:11bit", "11BIT_RACH requests received"}, + { "rach:requests:one_phase", "One phase packet access with request for single TS UL"}, /* TS 52.402 B.2.1.49 */ + { "rach:requests:two_phase", "Single block packet request for two phase packet access"}, /* TS 52.402 B.2.1.49 */ { "spb:uplink_first_segment", "First seg of UL SPB "}, { "spb:uplink_second_segment", "Second seg of UL SPB "}, { "spb:downlink_first_segment", "First seg of DL SPB "}, @@ -897,12 +899,17 @@ if (rc) /* Send RR Immediate Assignment Reject */ goto send_imm_ass_rej; - if (chan_req.single_block) + if (chan_req.single_block) { + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_2_PHASE); LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation\n"); - else if (bts->pcu->vty.force_two_phase) { + } else { + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_1_PHASE); LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single TS uplink transmission " - "(one phase packet access), but we force two phase access\n"); - chan_req.single_block = true; + "(one phase packet access)\n"); + if (bts->pcu->vty.force_two_phase) { + LOGP(DRLCMAC, LOGL_DEBUG, "Forcing two phase access\n"); + chan_req.single_block = true; + } } /* TODO: handle Radio Priority (see 3GPP TS 44.060, table 11.2.5a.5) */ diff --git a/src/bts.h b/src/bts.h index 63f80a8..e080349 100644 --- a/src/bts.h +++ b/src/bts.h @@ -129,6 +129,8 @@ CTR_PCH_REQUESTS_TIMEDOUT, CTR_RACH_REQUESTS, CTR_RACH_REQUESTS_11BIT, + CTR_RACH_REQUESTS_1_PHASE, + CTR_RACH_REQUESTS_2_PHASE, CTR_SPB_UL_FIRST_SEGMENT, CTR_SPB_UL_SECOND_SEGMENT, CTR_SPB_DL_FIRST_SEGMENT, diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 26ba446..27be4f0 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1719,6 +1719,7 @@ === start test_tbf_single_phase === Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -2445,6 +2446,7 @@ DL_ASS_TBF(UL-TFI_0){SEND_ASS}: Deallocated Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654275 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7104,6 +7106,7 @@ === end test_tbf_epdan_out_of_rx_window === === start test_immediate_assign_rej_multi_block === MS requests Uplink resource on CCCH/RACH: ra=0x78 (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7131,6 +7134,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=0 USF=0 MS requests Uplink resource on CCCH/RACH: ra=0x79 (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7158,6 +7162,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=1 USF=1 MS requests Uplink resource on CCCH/RACH: ra=0x7a (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7185,6 +7190,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=2 USF=2 MS requests Uplink resource on CCCH/RACH: ra=0x7b (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7212,6 +7218,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=3 USF=3 MS requests Uplink resource on CCCH/RACH: ra=0x7c (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7239,6 +7246,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=4 USF=4 MS requests Uplink resource on CCCH/RACH: ra=0x7d (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7266,6 +7274,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=5 USF=5 MS requests Uplink resource on CCCH/RACH: ra=0x7e (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7293,6 +7302,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=6 USF=6 MS requests Uplink resource on CCCH/RACH: ra=0x7f (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id87c3a53d3acee92499987c843130e358f54742c Gerrit-Change-Number: 26074 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:44 +0000 Subject: Change in osmo-pcu[master]: bts: Improve logging to clarify RACH req is for 2 phase access References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26075 ) Change subject: bts: Improve logging to clarify RACH req is for 2 phase access ...................................................................... bts: Improve logging to clarify RACH req is for 2 phase access Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd --- M src/bts.cpp M tests/tbf/TbfTest.err 2 files changed, 23 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/26075/1 diff --git a/src/bts.cpp b/src/bts.cpp index 3678335..b3bd37d 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -901,7 +901,8 @@ if (chan_req.single_block) { bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_2_PHASE); - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation\n"); + LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation " + "(two phase packet access)\n"); } else { bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_1_PHASE); LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single TS uplink transmission " diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 27be4f0..a8fd741 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1801,7 +1801,7 @@ === end test_tbf_single_phase === === start test_tbf_two_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -1900,7 +1900,7 @@ === end test_tbf_two_phase === === start test_tbf_ra_update_rach === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2065,7 +2065,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) Scheduled Ack/Nack polling on FN=2654309, TS=7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) msg block (BSN 0, CS-4): 0f 01 00 29 52 41 55 5f 41 43 43 45 50 54 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 00 MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654245 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654348 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=1 @@ -2164,7 +2164,7 @@ === end test_tbf_ra_update_rach === === start test_tbf_dl_flow_and_rach_two_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2272,7 +2272,7 @@ UL_ASS_TBF(UL-TFI_0){NONE}: Deallocated DL_ASS_TBF(UL-TFI_0){SEND_ASS}: Deallocated MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654224 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654327 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2337,7 +2337,7 @@ === end test_tbf_dl_flow_and_rach_two_phase === === start test_tbf_dl_flow_and_rach_single_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2509,7 +2509,7 @@ === end test_tbf_dl_flow_and_rach_single_phase === === start test_tbf_dl_reuse === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -3686,7 +3686,7 @@ === end test_tbf_ws === === start test_tbf_egprs_two_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -3793,7 +3793,7 @@ === end test_tbf_egprs_two_phase === === start test_tbf_egprs_two_phase_spb === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -6746,7 +6746,7 @@ === end test_tbf_egprs_spb_dl === === start test_tbf_puan_urbb_len === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -6935,7 +6935,7 @@ === end test_tbf_update_ws === === start test_tbf_li_decoding === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -7331,14 +7331,14 @@ === end test_immediate_assign_rej_multi_block === === start test_immediate_assign_rej_single_block === MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) No PDCH available. No PDCH resource for single block allocation Tx Immediate Assignment Reject on AGCH === end test_immediate_assign_rej_single_block === === start test_tbf_egprs_two_phase_puan === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -8645,35 +8645,35 @@ === end test_packet_access_rej_epdan === === start test_packet_access_rej_prr === MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=52 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x71 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=56 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x72 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=60 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=65 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x74 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=69 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x75 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=73 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x76 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=78 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x77 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=82 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Detected FN jump! 2654167 -> 52 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd Gerrit-Change-Number: 26075 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:45 +0000 Subject: Change in osmo-pcu[master]: bts: Count RACH Request with unexpected content References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26076 ) Change subject: bts: Count RACH Request with unexpected content ...................................................................... bts: Count RACH Request with unexpected content Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b --- M src/bts.cpp M src/bts.h 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/26076/1 diff --git a/src/bts.cpp b/src/bts.cpp index b3bd37d..f158b0b 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -139,6 +139,7 @@ { "rach:requests:11bit", "11BIT_RACH requests received"}, { "rach:requests:one_phase", "One phase packet access with request for single TS UL"}, /* TS 52.402 B.2.1.49 */ { "rach:requests:two_phase", "Single block packet request for two phase packet access"}, /* TS 52.402 B.2.1.49 */ + { "rach:requests:unexpected", "RACH Request with unexpected content received"}, { "spb:uplink_first_segment", "First seg of UL SPB "}, { "spb:uplink_second_segment", "Second seg of UL SPB "}, { "spb:downlink_first_segment", "First seg of DL SPB "}, @@ -896,8 +897,11 @@ /* Parse [EGPRS Packet] Channel Request from RACH.ind */ rc = parse_rach_ind(rip, &chan_req); - if (rc) /* Send RR Immediate Assignment Reject */ + if (rc) { + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_UNEXPECTED); + /* Send RR Immediate Assignment Reject */ goto send_imm_ass_rej; + } if (chan_req.single_block) { bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_2_PHASE); diff --git a/src/bts.h b/src/bts.h index e080349..fe43447 100644 --- a/src/bts.h +++ b/src/bts.h @@ -131,6 +131,7 @@ CTR_RACH_REQUESTS_11BIT, CTR_RACH_REQUESTS_1_PHASE, CTR_RACH_REQUESTS_2_PHASE, + CTR_RACH_REQUESTS_UNEXPECTED, CTR_SPB_UL_FIRST_SEGMENT, CTR_SPB_UL_SECOND_SEGMENT, CTR_SPB_DL_FIRST_SEGMENT, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b Gerrit-Change-Number: 26076 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:45 +0000 Subject: Change in osmo-pcu[master]: bts: Add counters for successful 1, 2 phase pkt access References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26077 ) Change subject: bts: Add counters for successful 1,2 phase pkt access ...................................................................... bts: Add counters for successful 1,2 phase pkt access These counters relate to succPDTCHAssProcsPerCause (B.2.1.50 Successful Packet Channel Assignment Procedures, per cause). Related: SYS#4878 Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 --- M src/bts.cpp M src/bts.h 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/26077/1 diff --git a/src/bts.cpp b/src/bts.cpp index f158b0b..9fcacca 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -145,6 +145,8 @@ { "spb:downlink_first_segment", "First seg of DL SPB "}, { "spb:downlink_second_segment","Second seg of DL SPB "}, { "immediate:assignment_UL", "Immediate Assign UL "}, + { "immediate:assignment_ul:one_phase", "Immediate Assign UL (one phase packet access)"}, /* TS 52.402 B.2.1.50 */ + { "immediate:assignment_ul:two_phase", "Immediate Assign UL (two phase packet access)"}, /* TS 52.402 B.2.1.50 */ { "immediate:assignment_rej", "Immediate Assign Rej "}, { "immediate:assignment_DL", "Immediate Assign DL "}, { "channel:request_description","Channel Request Desc "}, @@ -937,6 +939,7 @@ sb_fn = sba->fn; LOGP(DRLCMAC, LOGL_DEBUG, "Allocated a single block at " "SBFn=%u TRX=%u TS=%u\n", sb_fn, pdch->trx->trx_no, pdch->ts_no); + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_2_PHASE); } else { GprsMs *ms = bts_alloc_ms(bts, 0, chan_req.egprs_mslot_class); tbf = tbf_alloc_ul_ccch(bts, ms); @@ -948,6 +951,7 @@ tbf->set_ta(ta); pdch = &tbf->trx->pdch[tbf->first_ts]; usf = tbf->m_usf[pdch->ts_no]; + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_1_PHASE); } trx = pdch->trx; diff --git a/src/bts.h b/src/bts.h index fe43447..7fdab40 100644 --- a/src/bts.h +++ b/src/bts.h @@ -137,6 +137,8 @@ CTR_SPB_DL_FIRST_SEGMENT, CTR_SPB_DL_SECOND_SEGMENT, CTR_IMMEDIATE_ASSIGN_UL_TBF, + CTR_IMMEDIATE_ASSIGN_UL_TBF_1_PHASE, + CTR_IMMEDIATE_ASSIGN_UL_TBF_2_PHASE, CTR_IMMEDIATE_ASSIGN_REJ, CTR_IMMEDIATE_ASSIGN_DL_TBF, CTR_CHANNEL_REQUEST_DESCRIPTION, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 Gerrit-Change-Number: 26077 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:45 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... pdch::rcv_resource_request(): Use local var to store bts pointer Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 --- M src/pdch.cpp 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/26078/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 5d8658a..c65c699 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -613,15 +613,16 @@ { struct gprs_rlcmac_sba *sba; int rc; + struct gprs_rlcmac_bts *bts = trx->bts; if (request->ID.UnionType) { struct gprs_rlcmac_ul_tbf *ul_tbf = NULL; struct pdch_ulc_node *item; uint32_t tlli = request->ID.u.TLLI; - GprsMs *ms = bts_ms_by_tlli(bts(), tlli, GSM_RESERVED_TMSI); + GprsMs *ms = bts_ms_by_tlli(bts, tlli, GSM_RESERVED_TMSI); if (!ms) { - ms = bts_alloc_ms(bts(), 0, 0); /* ms class updated later */ + ms = bts_alloc_ms(bts, 0, 0); /* ms class updated later */ ms_set_tlli(ms, tlli); } @@ -707,9 +708,9 @@ ms_set_egprs_ms_class(ms, egprs_ms_class); } - ul_tbf = tbf_alloc_ul_pacch(bts(), ms, trx_no()); + ul_tbf = tbf_alloc_ul_pacch(bts, ms, trx_no()); if (!ul_tbf) { - handle_tbf_reject(bts(), ms, trx_no(), ts_no); + handle_tbf_reject(bts, ms, trx_no(), ts_no); goto return_unref; } @@ -738,7 +739,7 @@ if (request->ID.u.Global_TFI.UnionType) { struct gprs_rlcmac_dl_tbf *dl_tbf; int8_t tfi = request->ID.u.Global_TFI.u.DOWNLINK_TFI; - dl_tbf = bts_dl_tbf_by_tfi(bts(), tfi, trx_no(), ts_no); + dl_tbf = bts_dl_tbf_by_tfi(bts, tfi, trx_no(), ts_no); if (!dl_tbf) { LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown downlink TFI=%d\n", tfi); return; @@ -751,7 +752,7 @@ } else { struct gprs_rlcmac_ul_tbf *ul_tbf; int8_t tfi = request->ID.u.Global_TFI.u.UPLINK_TFI; - ul_tbf = bts_ul_tbf_by_tfi(bts(), tfi, trx_no(), ts_no); + ul_tbf = bts_ul_tbf_by_tfi(bts, tfi, trx_no(), ts_no); if (!ul_tbf) { LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown uplink TFI=%d\n", tfi); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:45 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26079 ) Change subject: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() ...................................................................... tbf_ul: Improve documentation of tbf_alloc_ul_pacch() Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d --- M src/tbf_ul.cpp 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/26079/1 diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index d6936e1..8e25c20 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -151,7 +151,12 @@ return tbf; } -/* Alloc a UL TBF to be assigned over PACCH */ +/* Alloc a UL TBF to be assigned over PACCH. Called when an MS requests to + * create a new UL TBF during the end of life of a previous UL TBF (or an SBA). + * In summary, this TBF is allocated as a consequence of receiving a "Pkt + * Resource Req" or "Pkt Ctrl Ack" from the MS. + * See TS 44.060 9.3.2.4.2 "Non-extended uplink TBF mode". + */ gprs_rlcmac_ul_tbf *tbf_alloc_ul_pacch(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx) { struct gprs_rlcmac_ul_tbf *tbf; @@ -162,6 +167,7 @@ /* Caller will most probably send a Imm Ass Reject after return */ return NULL; } + /* Contention resolution is considered to be done since TLLI is known in MS: */ tbf->m_contention_resolution_done = 1; osmo_fsm_inst_dispatch(tbf->state_fsm.fi, TBF_EV_ASSIGN_ADD_PACCH, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d Gerrit-Change-Number: 26079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:51:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:51:46 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Add counter for successful contention resolution procedures This counter is related to succPDTCHSeizures, (3GPP TS 52.402 B.2.1.51 Successful PDTCH seizures). The relevant event when the first RLC block on the PDCH from the MS is received is the fact that contention resolution is considered as done in the network side. Hence, name the counter that way to ease interpretation. Related: SYS#4878 Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c --- M src/bts.cpp M src/bts.h M src/pdch.cpp M src/tbf_ul.cpp 4 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/26080/1 diff --git a/src/bts.cpp b/src/bts.cpp index 9fcacca..b5d0c13 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -147,6 +147,7 @@ { "immediate:assignment_UL", "Immediate Assign UL "}, { "immediate:assignment_ul:one_phase", "Immediate Assign UL (one phase packet access)"}, /* TS 52.402 B.2.1.50 */ { "immediate:assignment_ul:two_phase", "Immediate Assign UL (two phase packet access)"}, /* TS 52.402 B.2.1.50 */ + { "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */ { "immediate:assignment_rej", "Immediate Assign Rej "}, { "immediate:assignment_DL", "Immediate Assign DL "}, { "channel:request_description","Channel Request Desc "}, diff --git a/src/bts.h b/src/bts.h index 7fdab40..38e9fe7 100644 --- a/src/bts.h +++ b/src/bts.h @@ -139,6 +139,7 @@ CTR_IMMEDIATE_ASSIGN_UL_TBF, CTR_IMMEDIATE_ASSIGN_UL_TBF_1_PHASE, CTR_IMMEDIATE_ASSIGN_UL_TBF_2_PHASE, + CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS, CTR_IMMEDIATE_ASSIGN_REJ, CTR_IMMEDIATE_ASSIGN_DL_TBF, CTR_CHANNEL_REQUEST_DESCRIPTION, diff --git a/src/pdch.cpp b/src/pdch.cpp index c65c699..6d74a95 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -650,6 +650,8 @@ "MS requests UL TBF throguh SBA\n", fn); ms_set_ta(ms, sba->ta); sba_free(sba); + /* MS seized the PDCH answering on the SBA: */ + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS); break; case PDCH_ULC_NODE_TBF_POLL: if (item->tbf_poll.poll_tbf->direction != GPRS_RLCMAC_UL_TBF) { diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 8e25c20..59b75a1 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -328,6 +328,8 @@ /* now we must set this flag, so we are allowed to assign downlink * TBF on PACCH. it is only allowed when TLLI is acknowledged. */ m_contention_resolution_done = 1; + + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS); } /*! \brief receive data from PDCH/L1 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 17:59:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 17:59:11 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 7: (3 comments) https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h File include/osmocom/msc/mncc.h: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h at 166 PS7, Line 166: uint8_t gcr[16]; looks like we want a header file in libosmocore for 29.205 with some LEN define for 16? https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c at 529 PS7, Line 529: if (msg != NULL && (rc = osmo_enc_gcr(gcr_msg, gcr)) > 0) { why should msg be null? https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c at 530 PS7, Line 530: memcpy(&setup.gcr[0], gcr_msg->data, rc); why this double copy? simply pass &setup.gcr[0] to osmo_enc_gcr -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 17:59:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:04:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:04:29 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c at 2155 PS1, Line 2155: switch (lchan->activate.info.chreq_reason) { Just raising the topic: I often have the feeling these long chunks of code affect readability of the usual flow of the code. I'd argue it be far more clean to wrap all this into 1 function lchan_rate_ctr_inc(lchan) and move it somewhere else (lchan.c?) Because usually nobody cares about this when reading the code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:04:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:05:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:05:13 +0000 Subject: Change in osmo-bsc[master]: drop unused gsm48_tx_mm_serv_ack() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26069 ) Change subject: drop unused gsm48_tx_mm_serv_ack() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea Gerrit-Change-Number: 26069 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:05:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:06:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:06:09 +0000 Subject: Change in osmo-bsc[master]: cosmetic tweaks on handover counting code In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26070 ) Change subject: cosmetic tweaks on handover counting code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 Gerrit-Change-Number: 26070 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:06:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:07:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:07:00 +0000 Subject: Change in osmo-bsc[master]: tweak intra-bsc ho counter descriptions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26071 ) Change subject: tweak intra-bsc ho counter descriptions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 Gerrit-Change-Number: 26071 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:07:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:07:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 18:07:44 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 7: (3 comments) https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h File include/osmocom/msc/mncc.h: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/include/osmocom/msc/mncc.h at 166 PS7, Line 166: uint8_t gcr[16]; > looks like we want a header file in libosmocore for 29. [?] Depending of the content, encoded GCR may have different length. We could define some maximum, but I don't think it's strictly necessary. https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c at 529 PS7, Line 529: if (msg != NULL && (rc = osmo_enc_gcr(gcr_msg, gcr)) > 0) { > why should msg be null? Because msgb_alloc() may theoretically return NULL. https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c at 530 PS7, Line 530: memcpy(&setup.gcr[0], gcr_msg->data, rc); > why this double copy? simply pass &setup. [?] Because osmo_enc_gcr() accepts a 'struct msgb' pointer. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:07:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:08:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:08:04 +0000 Subject: Change in osmo-bsc[master]: implement incoming_intra_bsc_ho:* rate counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26072 ) Change subject: implement incoming_intra_bsc_ho:* rate counters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f2c6e2865ebe680879018fff08d283ce24c983 Gerrit-Change-Number: 26072 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:08:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:14:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:14:59 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 7: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c at 529 PS7, Line 529: if (msg != NULL && (rc = osmo_enc_gcr(gcr_msg, gcr)) > 0) { > Because msgb_alloc() may theoretically return NULL. But that "msg" is passed from another function right? then it should be checked before calling this function. Furthermore, you are already doing above: "struct gsm48_hdr *gh = msgb_l3(msg)" So this check makes no sense here. EDIT: Oh, I think you wanted to do "gcr_msg != NULL" here! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:14:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:24:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:24:00 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: Well the question would then be: Can one still use the same external tools (grafana, elastic search, etc) with rate_ctr? I'm not sure how are those exported over statsd. In general I think the main difference on how we see it, is that your focus is to have it look nice when using VTY, while my point is that it should in first place be usable for external tools. Moreover, I have the feeling you are just abusing the rate_ctr infrastructure with some logic just to get some output in VTY which you can understand (rate_ctr is aimed at tick events, not counting time). I think we should go into the direction of doing the least possible to output data and then let other tools/technologies to the thing. That being said, I'm happy to hear opinions from others, I'm open to comments and I'll accept whatever the consensus ends up being. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:24:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:29:21 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 18:29:21 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/25982/7/src/libmsc/gsm_04_08_cc.c at 529 PS7, Line 529: if (msg != NULL && (rc = osmo_enc_gcr(gcr_msg, gcr)) > 0) { > But that "msg" is passed from another function right? then it should be checked before calling this [?] Oh, this is a very nice catch! Thanks! In an earlier version of this patch I had the scoped msgb named 'msg', and the decided to avoid using the same name, but then forgot to do s/msg/gcr_msg/ here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:30:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Nov 2021 18:30:23 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, keith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 to look at the new patch set (#8). Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... mncc: rework passing GCR over the MNCC interface Using *unpacked* 'struct osmo_gcr_parsed' in the MNCC PDUs makes the protocol even more complicated than it currently is, and moreover complicates implementing MNCCv8 in the ttcn3-sip-test. Replace 'struct osmo_gcr_parsed' in 'struct gsm_mncc' with a fixed-length buffer, which is supposed to hold the Global Call Reference encoded as per 3GPP TS 29.205. Indicate presence of GCR using the MNCC_F_GCR flag. Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Fixes: I705c860e51637b4537cad65a330ecbaaca96dd5b Related: OS#5164, OS#5282 --- M include/osmocom/msc/mncc.h M src/libmsc/gsm_04_08_cc.c M tests/mncc/mncc_test.ok 3 files changed, 34 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/82/25982/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 2 18:41:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Nov 2021 18:41:43 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Nov 2021 18:41:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 2 22:49:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 22:49:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c0a312e21_4be72abbd99885e05003a2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 253s] # we create a symlink at ./srcfile.adoc pointing at [ 253s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 253s] # is like basename from coreutils, and . is WD. [ 253s] if ! [ -f test-usermanual.adoc ]; then \ [ 253s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 253s] fi [ 253s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 253s] # in ... [ 253s] TEXINPUTS=".." \ [ 253s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 253s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 253s] a2x: resource files: [] [ 253s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 253s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 253s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 253s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 253s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 253s] make[1]: *** [Makefile:363: all] Error 2 [ 253s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 253s] dh_auto_build: error: make -j1 returned exit code 2 [ 253s] make: *** [debian/rules:5: binary] Error 25 [ 253s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 253s] ### VM INTERACTION START ### [ 254s] Powering off. [ 254s] [ 242.198099] reboot: Power down [ 254s] ### VM INTERACTION END ### [ 254s] [ 254s] goat03 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Tue Nov 2 22:49:33 UTC 2021. [ 254s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 22:52:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 22:52:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c13937b5e_4be72abbd99885e0500822@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 395s] # we create a symlink at ./srcfile.adoc pointing at [ 395s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 395s] # is like basename from coreutils, and . is WD. [ 395s] if ! [ -f test-usermanual.adoc ]; then \ [ 395s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 395s] fi [ 395s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 395s] # in ... [ 395s] TEXINPUTS=".." \ [ 395s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 395s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 395s] a2x: resource files: [] [ 395s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 395s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 395s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 395s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 395s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 395s] make[1]: *** [Makefile:363: all] Error 2 [ 395s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 395s] dh_auto_build: error: make -j1 returned exit code 2 [ 395s] make: *** [debian/rules:5: binary] Error 25 [ 395s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 395s] ### VM INTERACTION START ### [ 396s] Powering off. [ 396s] [ 376.839137] reboot: Power down [ 396s] ### VM INTERACTION END ### [ 396s] [ 396s] lamb15 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111020822.dsc" at Tue Nov 2 22:52:07 UTC 2021. [ 396s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 22:59:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 22:59:22 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c2de33095_4be72abbd99885e050282e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Unstable/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 228s] 336 0 4 340 154 obj/simtrace/dfu_board_lowlevel.o [ 228s] 8 0 0 8 8 obj/simtrace/dfu_boardver_adc.o [ 228s] 656 184 0 840 348 obj/simtrace/dfu_led.o [ 228s] 28 16 0 44 2c obj/simtrace/dfu_manifest.o [ 228s] 1254 0 1033 2287 8ef obj/simtrace/dfu_uart_console.o [ 228s] 225 0 0 225 e1 obj/simtrace/dfu_board_simtrace.o [ 228s] 108 0 0 108 6c obj/simtrace/dfu_sim_switch.o [ 228s] 909 0 20 929 3a1 obj/simtrace/dfu_main.o [ 228s] 244 0 0 244 f4 obj/simtrace/dfu_dfu.o [ 228s] 636 104 72 812 32c obj/simtrace/dfu_dfu_desc.o [ 228s] 1053 24 532 1609 649 obj/simtrace/dfu_dfu_driver.o [ 228s] 13176 0 11444 24620 602c bin/simtrace-dfu-dfu.elf [ 228s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 228s] make -C firmware BOARD=simtrace APP=blupdate [ 228s] make[2]: Entering directory '/usr/src/packages/BUILD/firmware' [ 228s] make[2]: *** No rule to make target 'apps/blupdate/usb_strings.txt', needed by 'apps/blupdate/usb_strings.txt.patched'. Stop. [ 228s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 228s] make[1]: *** [Makefile:11: fw-simtrace-blupdate] Error 2 [ 228s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 228s] dh_auto_build: error: make -j1 returned exit code 2 [ 228s] make: *** [debian/rules:16: build] Error 25 [ 228s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 228s] ### VM INTERACTION START ### [ 231s] [ 213.734707] sysrq: Power Off [ 231s] [ 213.741729] reboot: Power down [ 231s] ### VM INTERACTION END ### [ 231s] [ 231s] lamb08 failed "build simtrace2_0.7.0.163.23eb.202111020822.dsc" at Tue Nov 2 22:59:08 UTC 2021. [ 231s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:00:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:00:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c3184b32b_4be72abbd99885e05029d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 267s] # is like basename from coreutils, and . is WD. [ 267s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 267s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 267s] fi [ 267s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 267s] # in /usr/share/osmo-gsm-manuals. [ 267s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 267s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 267s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 267s] a2x: resource files: [] [ 267s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 267s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 267s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 267s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 267s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 267s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 267s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 267s] make[1]: *** [Makefile:327: all] Error 2 [ 267s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 267s] dh_auto_build: error: make -j1 returned exit code 2 [ 267s] make: *** [debian/rules:12: build] Error 25 [ 267s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 267s] ### VM INTERACTION START ### [ 268s] Powering off. [ 268s] [ 257.361280] reboot: Power down [ 268s] ### VM INTERACTION END ### [ 268s] [ 268s] goat11 failed "build osmo-sip-connector_1.5.1.dsc" at Tue Nov 2 23:00:20 UTC 2021. [ 268s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:03:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:03:03 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c3adbd4be_4be72abbd99885e050349b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 418s] # is like basename from coreutils, and . is WD. [ 418s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 418s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 418s] fi [ 418s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 418s] # in /usr/share/osmo-gsm-manuals. [ 418s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 418s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 418s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 418s] a2x: resource files: [] [ 418s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 418s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 418s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 418s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 418s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 418s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 418s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 418s] make[1]: *** [Makefile:377: all] Error 2 [ 418s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 418s] dh_auto_build: error: make -j1 returned exit code 2 [ 418s] make: *** [debian/rules:45: build] Error 25 [ 418s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 418s] ### VM INTERACTION START ### [ 419s] Powering off. [ 419s] [ 399.046683] reboot: Power down [ 419s] ### VM INTERACTION END ### [ 419s] [ 419s] lamb15 failed "build osmo-gbproxy_0.1.2.dsc" at Tue Nov 2 23:02:54 UTC 2021. [ 419s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:04:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:04:11 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c3f460a8f_4be72abbd99885e05049ba@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 487s] # is like basename from coreutils, and . is WD. [ 487s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 487s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 487s] fi [ 487s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 487s] # in /usr/share/osmo-gsm-manuals. [ 487s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 487s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 487s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 487s] a2x: resource files: [] [ 487s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 487s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 487s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 487s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 487s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 487s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 487s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 487s] make[1]: *** [Makefile:392: all] Error 2 [ 487s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 487s] dh_auto_build: error: make -j1 returned exit code 2 [ 487s] make: *** [debian/rules:15: build] Error 25 [ 487s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 487s] ### VM INTERACTION START ### [ 489s] Powering off. [ 489s] [ 463.436673] reboot: Power down [ 489s] ### VM INTERACTION END ### [ 489s] [ 489s] lamb19 failed "build osmo-ggsn_1.7.1.dsc" at Tue Nov 2 23:04:05 UTC 2021. [ 489s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:05:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:05:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c443cd504_4be72abbd99885e050577f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 319s] # is like basename from coreutils, and . is WD. [ 319s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 319s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 319s] fi [ 319s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 319s] # in /usr/share/osmo-gsm-manuals. [ 319s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 319s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 319s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 319s] a2x: resource files: [] [ 319s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 319s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 319s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 319s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 319s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 319s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 319s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 319s] make[1]: *** [Makefile:371: all] Error 2 [ 319s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 319s] dh_auto_build: error: make -j1 returned exit code 2 [ 319s] make: *** [debian/rules:12: build] Error 25 [ 319s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 319s] ### VM INTERACTION START ### [ 320s] Powering off. [ 320s] [ 302.090513] reboot: Power down [ 320s] ### VM INTERACTION END ### [ 320s] [ 320s] sheep85 failed "build osmo-bts_1.3.3.dsc" at Tue Nov 2 23:05:16 UTC 2021. [ 320s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:09:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:09:00 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c51749534_4be72abbd99885e0506782@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 500s] # is like basename from coreutils, and . is WD. [ 500s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 500s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 500s] fi [ 500s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 501s] # in /usr/share/osmo-gsm-manuals. [ 501s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 501s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 501s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 501s] a2x: resource files: [] [ 501s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 501s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 501s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 501s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 501s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 501s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 501s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 501s] make[1]: *** [Makefile:403: all] Error 2 [ 501s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 501s] dh_auto_build: error: make -j1 returned exit code 2 [ 501s] make: *** [debian/rules:12: build] Error 25 [ 501s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 501s] ### VM INTERACTION START ### [ 502s] Powering off. [ 502s] [ 454.732947] reboot: Power down [ 503s] ### VM INTERACTION END ### [ 503s] [ 503s] cloud126 failed "build libosmo-sccp_1.4.0.dsc" at Tue Nov 2 23:08:50 UTC 2021. [ 503s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:09:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:09:00 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c517a8a60_4be72abbd99885e050681c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 529s] # is like basename from coreutils, and . is WD. [ 529s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 529s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 529s] fi [ 529s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 529s] # in /usr/share/osmo-gsm-manuals. [ 529s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 529s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 529s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 529s] a2x: resource files: [] [ 529s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 529s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 529s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 529s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 529s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 529s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 529s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 529s] make[1]: *** [Makefile:387: all] Error 2 [ 529s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 529s] dh_auto_build: error: make -j1 returned exit code 2 [ 529s] make: *** [debian/rules:12: build] Error 25 [ 529s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 529s] ### VM INTERACTION START ### [ 530s] Powering off. [ 530s] [ 508.010569] reboot: Power down [ 531s] ### VM INTERACTION END ### [ 531s] [ 531s] lamb05 failed "build osmo-remsim_0.2.4.dsc" at Tue Nov 2 23:08:45 UTC 2021. [ 531s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:09:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:09:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c5559b7b5_4be72abbd99885e05072ac@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 537s] | ^~~~~ [ 537s] mgcp_client.c:745:67: error: invalid type argument of unary '*' (have 'int') [ 537s] 745 | osmo_sock_get_name2(fd->fd), errno, strerror(errno), [ 537s] | ^~~~~ [ 537s] mgcp_client.c: In function 'mgcp_client_connect': [ 537s] mgcp_client.c:848:83: error: invalid type argument of unary '*' (have 'int') [ 537s] 848 | mgcp->actual.remote_addr, mgcp->actual.remote_port, strerror(errno)); [ 537s] | ^~~~~ [ 537s] mgcp_client.c:848:83: error: invalid type argument of unary '*' (have 'int') [ 537s] 848 | mgcp->actual.remote_addr, mgcp->actual.remote_port, strerror(errno)); [ 537s] | ^~~~~ [ 537s] make[4]: *** [Makefile:507: mgcp_client.lo] Error 1 [ 537s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libosmo-mgcp-client' [ 537s] make[3]: *** [Makefile:408: all-recursive] Error 1 [ 537s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 537s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 537s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 537s] make[1]: *** [Makefile:423: all] Error 2 [ 537s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 537s] dh_auto_build: error: make -j1 returned exit code 2 [ 537s] make: *** [debian/rules:17: build] Error 25 [ 537s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 537s] ### VM INTERACTION START ### [ 538s] Powering off. [ 538s] [ 511.661043] reboot: Power down [ 538s] ### VM INTERACTION END ### [ 538s] [ 538s] lamb53 failed "build osmo-mgw_1.8.1.dsc" at Tue Nov 2 23:09:35 UTC 2021. [ 538s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:10:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:10:59 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c58e703d8_4be72abbd99885e05073c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 588s] # is like basename from coreutils, and . is WD. [ 588s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 588s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 588s] fi [ 588s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 588s] # in /usr/share/osmo-gsm-manuals. [ 588s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 588s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 588s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 588s] a2x: resource files: [] [ 588s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 588s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 588s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 588s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 588s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 588s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 588s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 588s] make[1]: *** [Makefile:410: all] Error 2 [ 588s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 588s] dh_auto_build: error: make -j1 returned exit code 2 [ 588s] make: *** [debian/rules:7: build] Error 25 [ 588s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 588s] ### VM INTERACTION START ### [ 589s] Powering off. [ 589s] [ 522.743410] reboot: Power down [ 589s] ### VM INTERACTION END ### [ 589s] [ 589s] cloud111 failed "build osmo-hlr_1.3.1.dsc" at Tue Nov 2 23:10:46 UTC 2021. [ 589s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:11:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:11:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c5cc2c4df_4be72abbd99885e050764a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 668s] # is like basename from coreutils, and . is WD. [ 668s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 668s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 668s] fi [ 668s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 668s] # in /usr/share/osmo-gsm-manuals. [ 668s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 668s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 668s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 668s] a2x: resource files: [] [ 668s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 668s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 668s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 668s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 668s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 668s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 668s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 668s] make[1]: *** [Makefile:368: all] Error 2 [ 668s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 668s] dh_auto_build: error: make -j1 returned exit code 2 [ 668s] make: *** [debian/rules:45: build] Error 25 [ 668s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 668s] ### VM INTERACTION START ### [ 669s] Powering off. [ 669s] [ 587.970436] reboot: Power down [ 670s] ### VM INTERACTION END ### [ 670s] [ 670s] cloud108 failed "build osmo-cbc_0.2.2.dsc" at Tue Nov 2 23:11:45 UTC 2021. [ 670s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:12:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:12:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c5eaed8e6_4be72abbd99885e050786@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 978s] # we create a symlink at ./srcfile.adoc pointing at [ 978s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 978s] # is like basename from coreutils, and . is WD. [ 978s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 978s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 978s] fi [ 978s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 978s] # in /usr/share/osmo-gsm-manuals. [ 978s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 978s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 978s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 978s] a2x: resource files: [] [ 978s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 978s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 978s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 978s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 978s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 978s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 978s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 978s] dh_auto_build: error: make -j1 returned exit code 2 [ 978s] make: *** [debian/rules:12: build] Error 25 [ 978s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 978s] ### VM INTERACTION START ### [ 979s] Powering off. [ 979s] [ 915.523024] reboot: Power down [ 979s] ### VM INTERACTION END ### [ 979s] [ 979s] lamb61 failed "build osmo-pcu_0.9.1.dsc" at Tue Nov 2 23:12:20 UTC 2021. [ 979s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:12:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:12:58 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c60a9876e_4be72abbd99885e050808b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 211s] # is like basename from coreutils, and . is WD. [ 211s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 211s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 211s] fi [ 211s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 211s] # in /usr/share/osmo-gsm-manuals. [ 211s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 211s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 211s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 211s] a2x: resource files: [] [ 211s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 211s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 211s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 211s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 211s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 211s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 211s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 211s] make[1]: *** [Makefile:377: all] Error 2 [ 211s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 211s] dh_auto_build: error: make -j1 returned exit code 2 [ 211s] make: *** [debian/rules:45: build] Error 25 [ 211s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 211s] ### VM INTERACTION START ### [ 212s] Powering off. [ 212s] [ 202.066391] reboot: Power down [ 212s] ### VM INTERACTION END ### [ 212s] [ 212s] goat13 failed "build osmo-smlc_0.2.0.dsc" at Tue Nov 2 23:12:40 UTC 2021. [ 212s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:13:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:13:49 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c642cf5cf_4be72abbd99885e050822e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 1055s] # is like basename from coreutils, and . is WD. [ 1055s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 1055s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 1055s] fi [ 1055s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1055s] # in /usr/share/osmo-gsm-manuals. [ 1055s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1055s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 1055s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 1055s] a2x: resource files: [] [ 1055s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1055s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 1055s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1055s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 1055s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1055s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 1055s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1055s] make[1]: *** [Makefile:452: all] Error 2 [ 1055s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1055s] dh_auto_build: error: make -j1 returned exit code 2 [ 1055s] make: *** [debian/rules:6: build] Error 25 [ 1055s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1055s] ### VM INTERACTION START ### [ 1057s] Powering off. [ 1057s] [ 980.065397] reboot: Power down [ 1057s] ### VM INTERACTION END ### [ 1057s] [ 1057s] lamb04 failed "build osmo-trx_1.3.1.dsc" at Tue Nov 2 23:13:39 UTC 2021. [ 1057s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:14:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:14:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c64347c82_4be72abbd99885e0508316@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 241s] # is like basename from coreutils, and . is WD. [ 241s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 241s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 241s] fi [ 241s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 241s] # in /usr/share/osmo-gsm-manuals. [ 241s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 241s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 241s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 241s] a2x: resource files: [] [ 241s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 241s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 241s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 241s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 241s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 241s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 241s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 241s] make[1]: *** [Makefile:388: all] Error 2 [ 241s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 241s] dh_auto_build: error: make -j1 returned exit code 2 [ 241s] make: *** [debian/rules:45: build] Error 25 [ 241s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 241s] ### VM INTERACTION START ### [ 242s] Powering off. [ 242s] [ 232.159084] reboot: Power down [ 242s] ### VM INTERACTION END ### [ 242s] [ 242s] goat05 failed "build osmo-bsc_1.7.2.dsc" at Tue Nov 2 23:13:51 UTC 2021. [ 242s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:21:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:21:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c823eaf7_4be72abbd99885e0509083@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 727s] # is like basename from coreutils, and . is WD. [ 727s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 727s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 727s] fi [ 727s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 727s] # in /usr/share/osmo-gsm-manuals. [ 727s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 727s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 727s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 727s] a2x: resource files: [] [ 727s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 727s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 727s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 727s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 727s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 727s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 727s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 727s] make[1]: *** [Makefile:391: all] Error 2 [ 727s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 727s] dh_auto_build: error: make -j1 returned exit code 2 [ 727s] make: *** [debian/rules:9: build] Error 25 [ 727s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 727s] ### VM INTERACTION START ### [ 729s] Powering off. [ 729s] [ 680.094425] reboot: Power down [ 729s] ### VM INTERACTION END ### [ 729s] [ 729s] cloud111 failed "build osmo-iuh_1.0.0.dsc" at Tue Nov 2 23:21:43 UTC 2021. [ 729s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:29:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:29:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181c9ca8ca7e_4be72abbd99885e051005f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 414s] # is like basename from coreutils, and . is WD. [ 414s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 414s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 414s] fi [ 414s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 414s] # in /usr/share/osmo-gsm-manuals. [ 414s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 414s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 414s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 414s] a2x: resource files: [] [ 414s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 414s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 414s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 414s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 414s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 414s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 414s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 414s] make[1]: *** [Makefile:394: all] Error 2 [ 414s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 414s] dh_auto_build: error: make -j1 returned exit code 2 [ 414s] make: *** [debian/rules:45: build] Error 25 [ 414s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 414s] ### VM INTERACTION START ### [ 415s] Powering off. [ 415s] [ 395.716444] reboot: Power down [ 415s] ### VM INTERACTION END ### [ 415s] [ 415s] lamb55 failed "build osmo-sgsn_1.7.1.dsc" at Tue Nov 2 23:28:59 UTC 2021. [ 415s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 2 23:29:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 02 Nov 2021 23:29:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181ca026b01e_4be72abbd99885e05102af@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 454s] # is like basename from coreutils, and . is WD. [ 454s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 454s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 454s] fi [ 454s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 454s] # in /usr/share/osmo-gsm-manuals. [ 454s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 454s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 454s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 454s] a2x: resource files: [] [ 454s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 454s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 454s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 454s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 454s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 454s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 454s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 454s] make[1]: *** [Makefile:402: all] Error 2 [ 454s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 454s] dh_auto_build: error: make -j1 returned exit code 2 [ 454s] make: *** [debian/rules:45: build] Error 25 [ 454s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 454s] ### VM INTERACTION START ### [ 455s] Powering off. [ 455s] [ 430.028867] reboot: Power down [ 456s] ### VM INTERACTION END ### [ 456s] [ 456s] cloud111 failed "build osmo-msc_1.7.1.dsc" at Tue Nov 2 23:29:32 UTC 2021. [ 456s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:34:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:34:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <6181d92054532_4be72abbd99885e051673f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 22s] checking for gcc option to produce PIC... -fPIC -DPIC [ 22s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 22s] checking if gcc static flag -static works... no [ 22s] checking if gcc supports -c -o file.o... yes [ 22s] checking if gcc supports -c -o file.o... (cached) yes [ 22s] checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes [ 22s] checking whether -lc should be explicitly linked in... no [ 22s] checking dynamic linker characteristics... GNU/Linux ld.so [ 22s] checking how to hardcode library paths into programs... immediate [ 22s] checking whether stripping libraries is possible... yes [ 22s] checking if libtool supports shared libraries... yes [ 22s] checking whether to build shared libraries... yes [ 22s] checking whether to build static libraries... yes [ 22s] checking for pkg-config... /usr/bin/pkg-config [ 22s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 22s] checking pkg-config is at least version 0.20... yes [ 22s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 22s] error: Bad exit status from /var/tmp/rpm-tmp.pWeXVt (%build) [ 22s] [ 22s] [ 22s] RPM build errors: [ 22s] Bad exit status from /var/tmp/rpm-tmp.pWeXVt (%build) [ 22s] ### VM INTERACTION START ### [ 25s] [ 21.585758][ T416] sysrq: Power Off [ 25s] [ 21.588995][ T7] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] goat19 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:34:16 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:35:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:35:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <6181d97e66988_4be72abbd99885e051701c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 24s] checking for gcc option to produce PIC... -fPIC -DPIC [ 24s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 24s] checking if gcc static flag -static works... no [ 24s] checking if gcc supports -c -o file.o... yes [ 24s] checking if gcc supports -c -o file.o... (cached) yes [ 24s] checking whether the gcc linker (/usr/i586-suse-linux/bin/ld) supports shared libraries... yes [ 24s] checking whether -lc should be explicitly linked in... no [ 24s] checking dynamic linker characteristics... GNU/Linux ld.so [ 24s] checking how to hardcode library paths into programs... immediate [ 24s] checking whether stripping libraries is possible... yes [ 24s] checking if libtool supports shared libraries... yes [ 24s] checking whether to build shared libraries... yes [ 24s] checking whether to build static libraries... yes [ 24s] checking for pkg-config... /usr/bin/pkg-config [ 24s] checking for i586-suse-linux-gnu-pkg-config... /usr/bin/i586-suse-linux-gnu-pkg-config [ 24s] checking pkg-config is at least version 0.20... yes [ 24s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 24s] error: Bad exit status from /var/tmp/rpm-tmp.i9Jxza (%build) [ 24s] [ 24s] [ 24s] RPM build errors: [ 24s] Bad exit status from /var/tmp/rpm-tmp.i9Jxza (%build) [ 24s] ### VM INTERACTION START ### [ 28s] [ 23.100396][ T418] sysrq: Power Off [ 28s] [ 23.104531][ T7] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] goat01 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:35:35 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:36:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:36:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <6181d998d7c3a_4be72abbd99885e051712e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 57s] checking for gcc option to produce PIC... -fPIC -DPIC [ 57s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 57s] checking if gcc static flag -static works... no [ 57s] checking if gcc supports -c -o file.o... yes [ 57s] checking if gcc supports -c -o file.o... (cached) yes [ 57s] checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes [ 57s] checking whether -lc should be explicitly linked in... no [ 57s] checking dynamic linker characteristics... GNU/Linux ld.so [ 57s] checking how to hardcode library paths into programs... immediate [ 57s] checking whether stripping libraries is possible... yes [ 57s] checking if libtool supports shared libraries... yes [ 57s] checking whether to build shared libraries... yes [ 57s] checking whether to build static libraries... yes [ 57s] checking for pkg-config... /usr/bin/pkg-config [ 57s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 57s] checking pkg-config is at least version 0.20... yes [ 57s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 57s] error: Bad exit status from /var/tmp/rpm-tmp.CD2iA7 (%build) [ 57s] [ 57s] [ 57s] RPM build errors: [ 57s] Bad exit status from /var/tmp/rpm-tmp.CD2iA7 (%build) [ 57s] ### VM INTERACTION START ### [ 61s] [ 44.600285] sysrq: SysRq : Power Off [ 61s] [ 44.603978] reboot: Power down [ 61s] ### VM INTERACTION END ### [ 61s] [ 61s] cloud115 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:36:14 UTC 2021. [ 61s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:36:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:36:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <6181d9b7b5c16_4be72abbd99885e05172da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 94s] intention of the Shared Library Policy is to allow parallel installation of [ 94s] multiple versions of the same shared library, hard dependencies likely make [ 94s] that impossible. Please remove this dependency and instead move it to the [ 94s] runtime uses of your library. [ 94s] [ 94s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 94s] The package contains an init script or systemd service file but lacks the [ 94s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 94s] [ 94s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 94s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 94s] This package contains a library and provides no %post scriptlet containing a [ 94s] call to ldconfig. [ 94s] [ 94s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 94s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 94s] This package contains a library and provides no %postun scriptlet containing a [ 94s] call to ldconfig. [ 94s] [ 94s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 94s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 94s] [ 94s] ### VM INTERACTION START ### [ 97s] [ 92.514525] sysrq: SysRq : Power Off [ 97s] [ 92.517348] reboot: Power down [ 97s] ### VM INTERACTION END ### [ 97s] [ 97s] goat05 failed "build osmo-iuh.spec" at Wed Nov 3 00:36:46 UTC 2021. [ 97s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:38:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:38:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <6181da1346491_4be72abbd99885e0517363@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 121s] checking for gcc option to produce PIC... -fPIC -DPIC [ 121s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 121s] checking if gcc static flag -static works... no [ 121s] checking if gcc supports -c -o file.o... yes [ 121s] checking if gcc supports -c -o file.o... (cached) yes [ 121s] checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m elf_x86_64) supports shared libraries... yes [ 121s] checking whether -lc should be explicitly linked in... no [ 121s] checking dynamic linker characteristics... GNU/Linux ld.so [ 121s] checking how to hardcode library paths into programs... immediate [ 121s] checking whether stripping libraries is possible... yes [ 121s] checking if libtool supports shared libraries... yes [ 121s] checking whether to build shared libraries... yes [ 121s] checking whether to build static libraries... yes [ 121s] checking for pkg-config... /usr/bin/pkg-config [ 121s] checking for x86_64-suse-linux-gnu-pkg-config... /usr/bin/x86_64-suse-linux-gnu-pkg-config [ 121s] checking pkg-config is at least version 0.20... yes [ 121s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 122s] error: Bad exit status from /var/tmp/rpm-tmp.A9Ieg8 (%build) [ 122s] [ 122s] [ 122s] RPM build errors: [ 122s] Bad exit status from /var/tmp/rpm-tmp.A9Ieg8 (%build) [ 122s] ### VM INTERACTION START ### [ 125s] [ 61.719051] sysrq: Power Off [ 125s] [ 61.753242] reboot: Power down [ 125s] ### VM INTERACTION END ### [ 126s] [ 126s] cloud119 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:38:07 UTC 2021. [ 126s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:38:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:38:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6181da13a47ad_4be72abbd99885e0517486@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 431s] # we create a symlink at ./srcfile.adoc pointing at [ 431s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 431s] # is like basename from coreutils, and . is WD. [ 431s] if ! [ -f test-usermanual.adoc ]; then \ [ 431s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 431s] fi [ 431s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 431s] # in ... [ 431s] TEXINPUTS=".." \ [ 431s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 431s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 431s] a2x: resource files: [] [ 431s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 431s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 431s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 431s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 431s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 431s] make[1]: *** [Makefile:363: all] Error 2 [ 431s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 431s] dh_auto_build: error: make -j1 returned exit code 2 [ 431s] make: *** [debian/rules:5: binary] Error 25 [ 431s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 431s] ### VM INTERACTION START ### [ 432s] Powering off. [ 432s] [ 413.049484] reboot: Power down [ 433s] ### VM INTERACTION END ### [ 433s] [ 433s] lamb52 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111030026.dsc" at Wed Nov 3 00:38:09 UTC 2021. [ 433s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:41:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:41:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <6181daaa8e509_4be72abbd99885e051775a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 290s] intention of the Shared Library Policy is to allow parallel installation of [ 290s] multiple versions of the same shared library, hard dependencies likely make [ 290s] that impossible. Please remove this dependency and instead move it to the [ 290s] runtime uses of your library. [ 290s] [ 290s] osmo-iuh.x86_64: W: suse-missing-rclink osmo-hnbgw [ 290s] The package contains an init script or systemd service file but lacks the [ 290s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 290s] [ 290s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 290s] libosmo-rua0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 290s] This package contains a library and provides no %post scriptlet containing a [ 290s] call to ldconfig. [ 290s] [ 290s] libosmo-hnbap0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 290s] libosmo-rua0.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 290s] This package contains a library and provides no %postun scriptlet containing a [ 290s] call to ldconfig. [ 290s] [ 290s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 290s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 290s] [ 290s] ### VM INTERACTION START ### [ 293s] [ 280.103731] sysrq: Power Off [ 293s] [ 280.117036] reboot: Power down [ 293s] ### VM INTERACTION END ### [ 293s] [ 293s] cloud138 failed "build osmo-iuh.spec" at Wed Nov 3 00:40:51 UTC 2021. [ 293s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:41:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:41:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_9.0/i586 In-Reply-To: References: Message-ID: <6181dac4309f2_4be72abbd99885e05178d6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_9.0/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 106s] #define VERSION "UNKNOWN" [ 106s] #define STDC_HEADERS 1 [ 106s] #define HAVE_SYS_TYPES_H 1 [ 106s] #define HAVE_SYS_STAT_H 1 [ 106s] #define HAVE_STDLIB_H 1 [ 106s] #define HAVE_STRING_H 1 [ 106s] #define HAVE_MEMORY_H 1 [ 106s] #define HAVE_STRINGS_H 1 [ 106s] #define HAVE_INTTYPES_H 1 [ 106s] #define HAVE_STDINT_H 1 [ 106s] #define HAVE_UNISTD_H 1 [ 106s] #define HAVE_DLFCN_H 1 [ 106s] #define LT_OBJDIR ".libs/" [ 106s] [ 106s] configure: exit 1 [ 106s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu --libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 106s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 106s] make[1]: *** [override_dh_auto_configure] Error 2 [ 106s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 106s] debian/rules:45: recipe for target 'build' failed [ 106s] make: *** [build] Error 2 [ 106s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 106s] ### VM INTERACTION START ### [ 109s] [ 103.135701] sysrq: Power Off [ 109s] [ 103.139757] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] goat17 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:41:10 UTC 2021. [ 109s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:41:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:41:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <6181dae3346bd_4be72abbd99885e051792d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 83s] checking for gcc option to produce PIC... -fPIC -DPIC [ 83s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 83s] checking if gcc static flag -static works... no [ 83s] checking if gcc supports -c -o file.o... yes [ 83s] checking if gcc supports -c -o file.o... (cached) yes [ 83s] checking whether the gcc linker (/usr/aarch64-suse-linux/bin/ld) supports shared libraries... yes [ 84s] checking whether -lc should be explicitly linked in... no [ 84s] checking dynamic linker characteristics... GNU/Linux ld.so [ 84s] checking how to hardcode library paths into programs... immediate [ 84s] checking whether stripping libraries is possible... yes [ 84s] checking if libtool supports shared libraries... yes [ 84s] checking whether to build shared libraries... yes [ 84s] checking whether to build static libraries... yes [ 84s] checking for pkg-config... /usr/bin/pkg-config [ 84s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config [ 84s] checking pkg-config is at least version 0.20... yes [ 84s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 84s] error: Bad exit status from /var/tmp/rpm-tmp.kx8Ve9 (%build) [ 84s] [ 84s] [ 84s] RPM build errors: [ 84s] Bad exit status from /var/tmp/rpm-tmp.kx8Ve9 (%build) [ 84s] ### VM INTERACTION START ### [ 87s] [ 67.216329][ T385] sysrq: Power Off [ 87s] [ 67.218571][ T206] reboot: Power down [ 87s] ### VM INTERACTION END ### [ 87s] [ 87s] obs-arm-8 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:41:52 UTC 2021. [ 87s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:42:32 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:42:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6181db0216fe_4be72abbd99885e05180e4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 101s] checking for gcc option to produce PIC... -fPIC -DPIC [ 101s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 101s] checking if gcc static flag -static works... no [ 101s] checking if gcc supports -c -o file.o... yes [ 101s] checking if gcc supports -c -o file.o... (cached) yes [ 101s] checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes [ 101s] checking whether -lc should be explicitly linked in... no [ 101s] checking dynamic linker characteristics... GNU/Linux ld.so [ 101s] checking how to hardcode library paths into programs... immediate [ 101s] checking whether stripping libraries is possible... yes [ 101s] checking if libtool supports shared libraries... yes [ 101s] checking whether to build shared libraries... yes [ 101s] checking whether to build static libraries... yes [ 101s] checking for pkg-config... /usr/bin/pkg-config [ 101s] checking for x86_64-redhat-linux-gnu-pkg-config... /usr/bin/x86_64-redhat-linux-gnu-pkg-config [ 101s] checking pkg-config is at least version 0.20... yes [ 101s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 101s] error: Bad exit status from /var/tmp/rpm-tmp.QcdeM8 (%build) [ 101s] [ 101s] [ 101s] RPM build errors: [ 101s] Bad exit status from /var/tmp/rpm-tmp.QcdeM8 (%build) [ 101s] ### VM INTERACTION START ### [ 102s] Powering off. [ 102s] [ 82.191077] reboot: Power down [ 102s] ### VM INTERACTION END ### [ 102s] [ 102s] cloud130 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:42:30 UTC 2021. [ 102s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:42:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:42:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <6181db20c7ce4_4be72abbd99885e0518195@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 196s] #define VERSION "UNKNOWN" [ 196s] #define STDC_HEADERS 1 [ 196s] #define HAVE_SYS_TYPES_H 1 [ 196s] #define HAVE_SYS_STAT_H 1 [ 196s] #define HAVE_STDLIB_H 1 [ 196s] #define HAVE_STRING_H 1 [ 196s] #define HAVE_MEMORY_H 1 [ 196s] #define HAVE_STRINGS_H 1 [ 196s] #define HAVE_INTTYPES_H 1 [ 196s] #define HAVE_STDINT_H 1 [ 196s] #define HAVE_UNISTD_H 1 [ 196s] #define HAVE_DLFCN_H 1 [ 196s] #define LT_OBJDIR ".libs/" [ 196s] [ 196s] configure: exit 1 [ 196s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu --libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 196s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 196s] make[1]: *** [override_dh_auto_configure] Error 2 [ 196s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 196s] debian/rules:45: recipe for target 'build' failed [ 196s] make: *** [build] Error 2 [ 196s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 196s] ### VM INTERACTION START ### [ 199s] [ 176.409344] sysrq: Power Off [ 199s] [ 176.413030] reboot: Power down [ 199s] ### VM INTERACTION END ### [ 199s] [ 199s] cloud117 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:42:38 UTC 2021. [ 199s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:43:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:43:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_10/i586 In-Reply-To: References: Message-ID: <6181db21e8ecb_4be72abbd99885e051833c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_10/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 246s] #define PACKAGE_URL "" [ 246s] #define PACKAGE "osmo-hnodeb" [ 246s] #define VERSION "UNKNOWN" [ 246s] #define STDC_HEADERS 1 [ 246s] #define HAVE_SYS_TYPES_H 1 [ 246s] #define HAVE_SYS_STAT_H 1 [ 246s] #define HAVE_STDLIB_H 1 [ 246s] #define HAVE_STRING_H 1 [ 246s] #define HAVE_MEMORY_H 1 [ 246s] #define HAVE_STRINGS_H 1 [ 246s] #define HAVE_INTTYPES_H 1 [ 246s] #define HAVE_STDINT_H 1 [ 246s] #define HAVE_UNISTD_H 1 [ 246s] #define HAVE_DLFCN_H 1 [ 246s] #define LT_OBJDIR ".libs/" [ 246s] [ 246s] configure: exit 1 [ 246s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 246s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 246s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 246s] make: *** [debian/rules:45: build] Error 2 [ 246s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 246s] ### VM INTERACTION START ### [ 249s] [ 236.812437] sysrq: Power Off [ 249s] [ 236.815589] reboot: Power down [ 249s] ### VM INTERACTION END ### [ 249s] [ 249s] old-atreju2 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:43:04 UTC 2021. [ 249s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:43:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:43:23 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <6181db3bf355c_4be72abbd99885e05184d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 147s] checking for gcc option to produce PIC... -fPIC -DPIC [ 147s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 147s] checking if gcc static flag -static works... no [ 147s] checking if gcc supports -c -o file.o... yes [ 147s] checking if gcc supports -c -o file.o... (cached) yes [ 147s] checking whether the gcc linker (/usr/armv7hl-suse-linux-gnueabi/bin/ld) supports shared libraries... yes [ 147s] checking whether -lc should be explicitly linked in... no [ 147s] checking dynamic linker characteristics... GNU/Linux ld.so [ 147s] checking how to hardcode library paths into programs... immediate [ 147s] checking whether stripping libraries is possible... yes [ 147s] checking if libtool supports shared libraries... yes [ 147s] checking whether to build shared libraries... yes [ 147s] checking whether to build static libraries... yes [ 147s] checking for pkg-config... /usr/bin/pkg-config [ 147s] checking for armv7hl-suse-linux-gnueabi-pkg-config... /usr/bin/armv7hl-suse-linux-gnueabi-pkg-config [ 147s] checking pkg-config is at least version 0.20... yes [ 147s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 148s] error: Bad exit status from /var/tmp/rpm-tmp.TYf1ZP (%build) [ 148s] [ 148s] [ 148s] RPM build errors: [ 148s] Bad exit status from /var/tmp/rpm-tmp.TYf1ZP (%build) [ 148s] ### VM INTERACTION START ### [ 151s] [ 103.278956][ T384] sysrq: Power Off [ 151s] [ 103.279533][ T207] reboot: Power down [ 151s] ### VM INTERACTION END ### [ 151s] [ 151s] obs-arm-11 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:43:18 UTC 2021. [ 151s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:43:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:43:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <6181db5b25002_4be72abbd99885e0518636@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 75s] checking for gcc option to produce PIC... -fPIC -DPIC [ 75s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 75s] checking if gcc static flag -static works... no [ 75s] checking if gcc supports -c -o file.o... yes [ 75s] checking if gcc supports -c -o file.o... (cached) yes [ 75s] checking whether the gcc linker (/usr/aarch64-suse-linux/bin/ld) supports shared libraries... yes [ 75s] checking whether -lc should be explicitly linked in... no [ 75s] checking dynamic linker characteristics... GNU/Linux ld.so [ 75s] checking how to hardcode library paths into programs... immediate [ 75s] checking whether stripping libraries is possible... yes [ 75s] checking if libtool supports shared libraries... yes [ 75s] checking whether to build shared libraries... yes [ 75s] checking whether to build static libraries... yes [ 75s] checking for pkg-config... /usr/bin/pkg-config [ 75s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config [ 75s] checking pkg-config is at least version 0.20... yes [ 75s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 75s] error: Bad exit status from /var/tmp/rpm-tmp.epwjGb (%build) [ 75s] [ 75s] [ 75s] RPM build errors: [ 75s] Bad exit status from /var/tmp/rpm-tmp.epwjGb (%build) [ 75s] ### VM INTERACTION START ### [ 79s] [ 59.441051] sysrq: SysRq : Power Off [ 79s] [ 59.513961] reboot: Power down [ 79s] ### VM INTERACTION END ### [ 79s] [ 79s] obs-arm-8 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:43:51 UTC 2021. [ 79s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:44:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:44:48 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <6181db9947932_4be72abbd99885e05187a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 258s] #define PACKAGE_URL "" [ 258s] #define PACKAGE "osmo-hnodeb" [ 258s] #define VERSION "UNKNOWN" [ 258s] #define STDC_HEADERS 1 [ 258s] #define HAVE_SYS_TYPES_H 1 [ 258s] #define HAVE_SYS_STAT_H 1 [ 258s] #define HAVE_STDLIB_H 1 [ 258s] #define HAVE_STRING_H 1 [ 258s] #define HAVE_MEMORY_H 1 [ 258s] #define HAVE_STRINGS_H 1 [ 258s] #define HAVE_INTTYPES_H 1 [ 258s] #define HAVE_STDINT_H 1 [ 258s] #define HAVE_UNISTD_H 1 [ 258s] #define HAVE_DLFCN_H 1 [ 258s] #define LT_OBJDIR ".libs/" [ 258s] [ 258s] configure: exit 1 [ 258s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 258s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 258s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 258s] make: *** [debian/rules:45: build] Error 2 [ 258s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 258s] ### VM INTERACTION START ### [ 261s] [ 248.570714] sysrq: Power Off [ 261s] [ 248.576276] reboot: Power down [ 261s] ### VM INTERACTION END ### [ 261s] [ 261s] old-atreju4 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:44:31 UTC 2021. [ 261s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:45:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:45:40 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_10/x86_64 In-Reply-To: References: Message-ID: <6181dbb8f2977_4be72abbd99885e05188f5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_10/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 140s] #define PACKAGE_URL "" [ 140s] #define PACKAGE "osmo-hnodeb" [ 140s] #define VERSION "UNKNOWN" [ 140s] #define STDC_HEADERS 1 [ 140s] #define HAVE_SYS_TYPES_H 1 [ 140s] #define HAVE_SYS_STAT_H 1 [ 140s] #define HAVE_STDLIB_H 1 [ 140s] #define HAVE_STRING_H 1 [ 140s] #define HAVE_MEMORY_H 1 [ 140s] #define HAVE_STRINGS_H 1 [ 140s] #define HAVE_INTTYPES_H 1 [ 140s] #define HAVE_STDINT_H 1 [ 140s] #define HAVE_UNISTD_H 1 [ 140s] #define HAVE_DLFCN_H 1 [ 140s] #define LT_OBJDIR ".libs/" [ 140s] [ 140s] configure: exit 1 [ 140s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 140s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 140s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 140s] make: *** [debian/rules:45: build] Error 2 [ 140s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 140s] ### VM INTERACTION START ### [ 143s] [ 134.256834] sysrq: Power Off [ 143s] [ 134.260659] reboot: Power down [ 143s] ### VM INTERACTION END ### [ 143s] [ 143s] goat05 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:45:31 UTC 2021. [ 143s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:46:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:46:31 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <6181dbf1cbc4f_4be72abbd99885e05189a3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 201s] intention of the Shared Library Policy is to allow parallel installation of [ 201s] multiple versions of the same shared library, hard dependencies likely make [ 201s] that impossible. Please remove this dependency and instead move it to the [ 201s] runtime uses of your library. [ 201s] [ 201s] osmo-iuh.aarch64: W: suse-missing-rclink osmo-hnbgw [ 201s] The package contains an init script or systemd service file but lacks the [ 201s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 201s] [ 201s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 201s] libosmo-rua0.aarch64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 201s] This package contains a library and provides no %post scriptlet containing a [ 201s] call to ldconfig. [ 201s] [ 201s] libosmo-hnbap0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 [ 201s] libosmo-rua0.aarch64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosmo-rua.so.0.0.0 [ 201s] This package contains a library and provides no %postun scriptlet containing a [ 201s] call to ldconfig. [ 201s] [ 201s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 201s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 201s] [ 201s] ### VM INTERACTION START ### [ 207s] [ 166.073963] sysrq: SysRq : Power Off [ 207s] [ 166.074568] reboot: Power down [ 207s] ### VM INTERACTION END ### [ 207s] [ 207s] obs-arm-10 failed "build osmo-iuh.spec" at Wed Nov 3 00:46:26 UTC 2021. [ 207s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:47:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:47:22 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <6181dc2f283f2_4be72abbd99885e0519059@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 182s] #define VERSION "UNKNOWN" [ 182s] #define STDC_HEADERS 1 [ 182s] #define HAVE_SYS_TYPES_H 1 [ 182s] #define HAVE_SYS_STAT_H 1 [ 182s] #define HAVE_STDLIB_H 1 [ 182s] #define HAVE_STRING_H 1 [ 182s] #define HAVE_MEMORY_H 1 [ 182s] #define HAVE_STRINGS_H 1 [ 182s] #define HAVE_INTTYPES_H 1 [ 182s] #define HAVE_STDINT_H 1 [ 182s] #define HAVE_UNISTD_H 1 [ 182s] #define HAVE_DLFCN_H 1 [ 182s] #define LT_OBJDIR ".libs/" [ 182s] [ 182s] configure: exit 1 [ 182s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=${prefix}/lib/aarch64-linux-gnu --libexecdir=${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 182s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 182s] make[1]: *** [override_dh_auto_configure] Error 2 [ 182s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 182s] debian/rules:45: recipe for target 'build' failed [ 182s] make: *** [build] Error 2 [ 182s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 182s] ### VM INTERACTION START ### [ 186s] [ 135.348685] sysrq: Power Off [ 186s] [ 135.349241] reboot: Power down [ 186s] ### VM INTERACTION END ### [ 186s] [ 186s] obs-arm-11 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:47:15 UTC 2021. [ 186s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:49:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:49:04 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <6181dc882e922_4be72abbd99885e05192f8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 284s] #define PACKAGE_URL "" [ 284s] #define PACKAGE "osmo-hnodeb" [ 284s] #define VERSION "UNKNOWN" [ 284s] #define STDC_HEADERS 1 [ 284s] #define HAVE_SYS_TYPES_H 1 [ 284s] #define HAVE_SYS_STAT_H 1 [ 284s] #define HAVE_STDLIB_H 1 [ 284s] #define HAVE_STRING_H 1 [ 284s] #define HAVE_MEMORY_H 1 [ 284s] #define HAVE_STRINGS_H 1 [ 284s] #define HAVE_INTTYPES_H 1 [ 284s] #define HAVE_STDINT_H 1 [ 284s] #define HAVE_UNISTD_H 1 [ 284s] #define HAVE_DLFCN_H 1 [ 284s] #define LT_OBJDIR ".libs/" [ 284s] [ 284s] configure: exit 1 [ 284s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 284s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 284s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 284s] make: *** [debian/rules:45: build] Error 2 [ 284s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 284s] ### VM INTERACTION START ### [ 285s] Powering off. [ 285s] [ 271.335914] reboot: Power down [ 285s] ### VM INTERACTION END ### [ 285s] [ 285s] sheep86 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:48:47 UTC 2021. [ 285s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:49:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:49:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <6181dca6ba539_4be72abbd99885e0519386@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 134s] #define VERSION "UNKNOWN" [ 134s] #define STDC_HEADERS 1 [ 134s] #define HAVE_SYS_TYPES_H 1 [ 134s] #define HAVE_SYS_STAT_H 1 [ 134s] #define HAVE_STDLIB_H 1 [ 134s] #define HAVE_STRING_H 1 [ 134s] #define HAVE_MEMORY_H 1 [ 134s] #define HAVE_STRINGS_H 1 [ 134s] #define HAVE_INTTYPES_H 1 [ 134s] #define HAVE_STDINT_H 1 [ 134s] #define HAVE_UNISTD_H 1 [ 134s] #define HAVE_DLFCN_H 1 [ 134s] #define LT_OBJDIR ".libs/" [ 134s] [ 134s] configure: exit 1 [ 134s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 134s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 134s] make[1]: *** [override_dh_auto_configure] Error 2 [ 134s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 134s] debian/rules:45: recipe for target 'build' failed [ 134s] make: *** [build] Error 2 [ 134s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 134s] ### VM INTERACTION START ### [ 138s] [ 130.338644] sysrq: Power Off [ 138s] [ 130.342462] reboot: Power down [ 138s] ### VM INTERACTION END ### [ 138s] [ 138s] goat09 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:49:14 UTC 2021. [ 138s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:50:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:50:12 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6181dcc61a3f9_4be72abbd99885e051949a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 141s] checking for gcc option to produce PIC... -fPIC -DPIC [ 141s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 141s] checking if gcc static flag -static works... no [ 141s] checking if gcc supports -c -o file.o... yes [ 141s] checking if gcc supports -c -o file.o... (cached) yes [ 141s] checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes [ 141s] checking whether -lc should be explicitly linked in... no [ 141s] checking dynamic linker characteristics... GNU/Linux ld.so [ 141s] checking how to hardcode library paths into programs... immediate [ 141s] checking whether stripping libraries is possible... yes [ 141s] checking if libtool supports shared libraries... yes [ 141s] checking whether to build shared libraries... yes [ 141s] checking whether to build static libraries... yes [ 141s] checking for pkg-config... /usr/bin/pkg-config [ 141s] checking for aarch64-redhat-linux-gnu-pkg-config... /usr/bin/aarch64-redhat-linux-gnu-pkg-config [ 141s] checking pkg-config is at least version 0.20... yes [ 141s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 141s] error: Bad exit status from /var/tmp/rpm-tmp.9VBl45 (%build) [ 141s] [ 141s] [ 141s] RPM build errors: [ 141s] Bad exit status from /var/tmp/rpm-tmp.9VBl45 (%build) [ 141s] ### VM INTERACTION START ### [ 143s] Powering off. [ 143s] [ 110.802787] reboot: Power down [ 143s] ### VM INTERACTION END ### [ 143s] [ 143s] obs-arm-8 failed "build osmo-hnodeb.spec" at Wed Nov 3 00:50:08 UTC 2021. [ 143s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:50:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:50:29 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_11/x86_64 In-Reply-To: References: Message-ID: <6181dce030909_4be72abbd99885e051967e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_11/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 361s] #define PACKAGE_URL "" [ 361s] #define PACKAGE "osmo-hnodeb" [ 361s] #define VERSION "UNKNOWN" [ 361s] #define STDC_HEADERS 1 [ 361s] #define HAVE_SYS_TYPES_H 1 [ 361s] #define HAVE_SYS_STAT_H 1 [ 361s] #define HAVE_STDLIB_H 1 [ 361s] #define HAVE_STRING_H 1 [ 361s] #define HAVE_MEMORY_H 1 [ 361s] #define HAVE_STRINGS_H 1 [ 361s] #define HAVE_INTTYPES_H 1 [ 361s] #define HAVE_STDINT_H 1 [ 361s] #define HAVE_UNISTD_H 1 [ 361s] #define HAVE_DLFCN_H 1 [ 361s] #define LT_OBJDIR ".libs/" [ 361s] [ 361s] configure: exit 1 [ 361s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 361s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 361s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 361s] make: *** [debian/rules:45: build] Error 2 [ 361s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 361s] ### VM INTERACTION START ### [ 362s] Powering off. [ 362s] [ 345.459560] reboot: Power down [ 362s] ### VM INTERACTION END ### [ 362s] [ 362s] old-cirrus2 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:50:25 UTC 2021. [ 362s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:51:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:51:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <6181dd1e2a11a_4be72abbd99885e0519896@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 452s] #define PACKAGE_URL "" [ 452s] #define PACKAGE "osmo-hnodeb" [ 452s] #define VERSION "UNKNOWN" [ 452s] #define STDC_HEADERS 1 [ 452s] #define HAVE_SYS_TYPES_H 1 [ 452s] #define HAVE_SYS_STAT_H 1 [ 452s] #define HAVE_STDLIB_H 1 [ 452s] #define HAVE_STRING_H 1 [ 452s] #define HAVE_MEMORY_H 1 [ 452s] #define HAVE_STRINGS_H 1 [ 452s] #define HAVE_INTTYPES_H 1 [ 452s] #define HAVE_STDINT_H 1 [ 452s] #define HAVE_UNISTD_H 1 [ 452s] #define HAVE_DLFCN_H 1 [ 452s] #define LT_OBJDIR ".libs/" [ 452s] [ 452s] configure: exit 1 [ 452s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 452s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 452s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 452s] make: *** [debian/rules:45: build] Error 2 [ 452s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 452s] ### VM INTERACTION START ### [ 453s] Powering off. [ 453s] [ 425.504334] reboot: Power down [ 453s] ### VM INTERACTION END ### [ 453s] [ 453s] cloud102 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:51:33 UTC 2021. [ 453s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:52:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:52:28 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <6181dd5b45d21_4be72abbd99885e052005d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_21.10/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 265s] #define PACKAGE_URL "" [ 265s] #define PACKAGE "osmo-hnodeb" [ 265s] #define VERSION "UNKNOWN" [ 265s] #define STDC_HEADERS 1 [ 265s] #define HAVE_SYS_TYPES_H 1 [ 265s] #define HAVE_SYS_STAT_H 1 [ 265s] #define HAVE_STDLIB_H 1 [ 265s] #define HAVE_STRING_H 1 [ 265s] #define HAVE_MEMORY_H 1 [ 265s] #define HAVE_STRINGS_H 1 [ 265s] #define HAVE_INTTYPES_H 1 [ 265s] #define HAVE_STDINT_H 1 [ 265s] #define HAVE_UNISTD_H 1 [ 265s] #define HAVE_DLFCN_H 1 [ 265s] #define LT_OBJDIR ".libs/" [ 265s] [ 265s] configure: exit 1 [ 265s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 265s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 265s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 265s] make: *** [debian/rules:45: build] Error 2 [ 265s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 265s] ### VM INTERACTION START ### [ 266s] Powering off. [ 266s] [ 255.266838] reboot: Power down [ 266s] ### VM INTERACTION END ### [ 266s] [ 266s] sheep85 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:52:20 UTC 2021. [ 266s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:53:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:53:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <6181dd935afc0_4be72abbd99885e05201a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 359s] #define PACKAGE_URL "" [ 359s] #define PACKAGE "osmo-hnodeb" [ 359s] #define VERSION "UNKNOWN" [ 359s] #define STDC_HEADERS 1 [ 359s] #define HAVE_SYS_TYPES_H 1 [ 359s] #define HAVE_SYS_STAT_H 1 [ 359s] #define HAVE_STDLIB_H 1 [ 359s] #define HAVE_STRING_H 1 [ 359s] #define HAVE_MEMORY_H 1 [ 359s] #define HAVE_STRINGS_H 1 [ 359s] #define HAVE_INTTYPES_H 1 [ 359s] #define HAVE_STDINT_H 1 [ 359s] #define HAVE_UNISTD_H 1 [ 359s] #define HAVE_DLFCN_H 1 [ 359s] #define LT_OBJDIR ".libs/" [ 359s] [ 359s] configure: exit 1 [ 359s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 359s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 359s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 359s] make: *** [debian/rules:45: build] Error 2 [ 359s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 359s] ### VM INTERACTION START ### [ 362s] [ 341.192452] sysrq: Power Off [ 362s] [ 341.205246] reboot: Power down [ 362s] ### VM INTERACTION END ### [ 362s] [ 362s] cloud107 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:53:34 UTC 2021. [ 362s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:53:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:53:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_10/aarch64 In-Reply-To: References: Message-ID: <6181ddb2111ea_4be72abbd99885e0520228@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_10/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 336s] #define PACKAGE_URL "" [ 336s] #define PACKAGE "osmo-hnodeb" [ 336s] #define VERSION "UNKNOWN" [ 336s] #define STDC_HEADERS 1 [ 336s] #define HAVE_SYS_TYPES_H 1 [ 336s] #define HAVE_SYS_STAT_H 1 [ 336s] #define HAVE_STDLIB_H 1 [ 336s] #define HAVE_STRING_H 1 [ 336s] #define HAVE_MEMORY_H 1 [ 336s] #define HAVE_STRINGS_H 1 [ 336s] #define HAVE_INTTYPES_H 1 [ 336s] #define HAVE_STDINT_H 1 [ 336s] #define HAVE_UNISTD_H 1 [ 336s] #define HAVE_DLFCN_H 1 [ 336s] #define LT_OBJDIR ".libs/" [ 336s] [ 336s] configure: exit 1 [ 336s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 336s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 336s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 336s] make: *** [debian/rules:45: build] Error 2 [ 336s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 336s] ### VM INTERACTION START ### [ 339s] [ 295.050685] sysrq: Power Off [ 339s] [ 295.070020] reboot: Power down [ 339s] ### VM INTERACTION END ### [ 339s] [ 339s] obs-arm-9 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:53:37 UTC 2021. [ 339s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:57:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:57:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_11/aarch64 In-Reply-To: References: Message-ID: <6181de69dff8b_4be72abbd99885e05208c8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_11/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 300s] #define PACKAGE_URL "" [ 300s] #define PACKAGE "osmo-hnodeb" [ 300s] #define VERSION "UNKNOWN" [ 300s] #define STDC_HEADERS 1 [ 300s] #define HAVE_SYS_TYPES_H 1 [ 300s] #define HAVE_SYS_STAT_H 1 [ 300s] #define HAVE_STDLIB_H 1 [ 300s] #define HAVE_STRING_H 1 [ 300s] #define HAVE_MEMORY_H 1 [ 300s] #define HAVE_STRINGS_H 1 [ 300s] #define HAVE_INTTYPES_H 1 [ 300s] #define HAVE_STDINT_H 1 [ 300s] #define HAVE_UNISTD_H 1 [ 300s] #define HAVE_DLFCN_H 1 [ 300s] #define LT_OBJDIR ".libs/" [ 300s] [ 300s] configure: exit 1 [ 300s] dh_auto_configure: error: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 300s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 300s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 300s] make: *** [debian/rules:45: build] Error 2 [ 300s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 300s] ### VM INTERACTION START ### [ 302s] Powering off. [ 302s] [ 224.862375] reboot: Power down [ 302s] ### VM INTERACTION END ### [ 302s] [ 302s] obs-arm-11 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:56:56 UTC 2021. [ 302s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 00:57:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 00:57:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6181dea1b8acb_4be72abbd99885e05210e2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 378s] #define PACKAGE_URL "" [ 378s] #define PACKAGE "osmo-hnodeb" [ 378s] #define VERSION "UNKNOWN" [ 378s] #define STDC_HEADERS 1 [ 378s] #define HAVE_SYS_TYPES_H 1 [ 378s] #define HAVE_SYS_STAT_H 1 [ 378s] #define HAVE_STDLIB_H 1 [ 378s] #define HAVE_STRING_H 1 [ 378s] #define HAVE_MEMORY_H 1 [ 378s] #define HAVE_STRINGS_H 1 [ 378s] #define HAVE_INTTYPES_H 1 [ 378s] #define HAVE_STDINT_H 1 [ 378s] #define HAVE_UNISTD_H 1 [ 378s] #define HAVE_DLFCN_H 1 [ 378s] #define LT_OBJDIR ".libs/" [ 378s] [ 378s] configure: exit 1 [ 378s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 378s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 378s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 378s] make: *** [debian/rules:45: build] Error 2 [ 378s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 378s] ### VM INTERACTION START ### [ 380s] Powering off. [ 380s] [ 363.548172] reboot: Power down [ 380s] ### VM INTERACTION END ### [ 380s] [ 380s] lamb07 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 00:57:44 UTC 2021. [ 380s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 01:01:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 01:01:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_11/i586 In-Reply-To: References: Message-ID: <6181df92c39fa_4be72abbd99885e0521855@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_11/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 355s] #define PACKAGE_URL "" [ 355s] #define PACKAGE "osmo-hnodeb" [ 355s] #define VERSION "UNKNOWN" [ 355s] #define STDC_HEADERS 1 [ 355s] #define HAVE_SYS_TYPES_H 1 [ 355s] #define HAVE_SYS_STAT_H 1 [ 355s] #define HAVE_STDLIB_H 1 [ 355s] #define HAVE_STRING_H 1 [ 355s] #define HAVE_MEMORY_H 1 [ 355s] #define HAVE_STRINGS_H 1 [ 355s] #define HAVE_INTTYPES_H 1 [ 355s] #define HAVE_STDINT_H 1 [ 355s] #define HAVE_UNISTD_H 1 [ 355s] #define HAVE_DLFCN_H 1 [ 355s] #define LT_OBJDIR ".libs/" [ 355s] [ 355s] configure: exit 1 [ 355s] dh_auto_configure: error: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 355s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 25 [ 355s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 355s] make: *** [debian/rules:45: build] Error 2 [ 355s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 355s] ### VM INTERACTION START ### [ 356s] Powering off. [ 356s] [ 341.883114] reboot: Power down [ 356s] ### VM INTERACTION END ### [ 356s] [ 356s] sheep88 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 01:01:34 UTC 2021. [ 356s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 01:36:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 01:36:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <6181e7c5e5aa9_4be72abbd99885e05233e6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 90s] checking for gcc option to produce PIC... -fPIC -DPIC [ 90s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 90s] checking if gcc static flag -static works... no [ 90s] checking if gcc supports -c -o file.o... yes [ 90s] checking if gcc supports -c -o file.o... (cached) yes [ 90s] checking whether the gcc linker (/usr/armv7hl-suse-linux-gnueabi/bin/ld) supports shared libraries... yes [ 90s] checking whether -lc should be explicitly linked in... no [ 91s] checking dynamic linker characteristics... GNU/Linux ld.so [ 91s] checking how to hardcode library paths into programs... immediate [ 91s] checking whether stripping libraries is possible... yes [ 91s] checking if libtool supports shared libraries... yes [ 91s] checking whether to build shared libraries... yes [ 91s] checking whether to build static libraries... yes [ 91s] checking for pkg-config... /usr/bin/pkg-config [ 91s] checking for armv7hl-suse-linux-gnueabi-pkg-config... /usr/bin/armv7hl-suse-linux-gnueabi-pkg-config [ 91s] checking pkg-config is at least version 0.20... yes [ 91s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 91s] error: Bad exit status from /var/tmp/rpm-tmp.k6DTPE (%build) [ 91s] [ 91s] [ 91s] RPM build errors: [ 91s] Bad exit status from /var/tmp/rpm-tmp.k6DTPE (%build) [ 91s] ### VM INTERACTION START ### [ 94s] [ 76.453241] sysrq: SysRq : Power Off [ 94s] [ 76.458559] reboot: Power down [ 94s] ### VM INTERACTION END ### [ 94s] [ 94s] armbuild02 failed "build osmo-hnodeb.spec" at Wed Nov 3 01:36:50 UTC 2021. [ 94s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 01:49:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 01:49:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <6181eab4ea041_4be72abbd99885e0523793@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 805s] intention of the Shared Library Policy is to allow parallel installation of [ 805s] multiple versions of the same shared library, hard dependencies likely make [ 805s] that impossible. Please remove this dependency and instead move it to the [ 805s] runtime uses of your library. [ 805s] [ 805s] osmo-iuh.armv7hl: W: suse-missing-rclink osmo-hnbgw [ 805s] The package contains an init script or systemd service file but lacks the [ 805s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 805s] [ 805s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 805s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postin (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 805s] This package contains a library and provides no %post scriptlet containing a [ 805s] call to ldconfig. [ 805s] [ 805s] libosmo-hnbap0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-hnbap.so.0.0.0 [ 805s] libosmo-rua0.armv7hl: E: library-without-ldconfig-postun (Badness: 300) /usr/lib/libosmo-rua.so.0.0.0 [ 805s] This package contains a library and provides no %postun scriptlet containing a [ 805s] call to ldconfig. [ 805s] [ 805s] (none): E: badness 1200 exceeds threshold 1000, aborting. [ 805s] 10 packages and 0 specfiles checked; 4 errors, 21 warnings. [ 805s] [ 805s] ### VM INTERACTION START ### [ 808s] [ 792.546781] sysrq: SysRq : Power Off [ 808s] [ 792.570135] reboot: Power down [ 808s] ### VM INTERACTION END ### [ 808s] [ 808s] armbuild21 failed "build osmo-iuh.spec" at Wed Nov 3 01:49:17 UTC 2021. [ 808s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:28:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:28:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618202093172c_4be72abbd99885e05280b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 305s] # we create a symlink at ./srcfile.adoc pointing at [ 305s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 305s] # is like basename from coreutils, and . is WD. [ 305s] if ! [ -f test-usermanual.adoc ]; then \ [ 305s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 305s] fi [ 305s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 305s] # in ... [ 305s] TEXINPUTS=".." \ [ 305s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 305s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 305s] a2x: resource files: [] [ 305s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 305s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 305s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 305s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 305s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 305s] make[1]: *** [Makefile:363: all] Error 2 [ 305s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 305s] dh_auto_build: error: make -j1 returned exit code 2 [ 305s] make: *** [debian/rules:5: binary] Error 25 [ 305s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 305s] ### VM INTERACTION START ### [ 306s] Powering off. [ 306s] [ 290.148457] reboot: Power down [ 306s] ### VM INTERACTION END ### [ 306s] [ 306s] old-atreju5 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111030026.dsc" at Wed Nov 3 03:28:41 UTC 2021. [ 306s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:35:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:35:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618203ad82690_4be72abbd99885e05283cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 368s] # we create a symlink at ./srcfile.adoc pointing at [ 368s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 368s] # is like basename from coreutils, and . is WD. [ 368s] if ! [ -f test-usermanual.adoc ]; then \ [ 368s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 368s] fi [ 368s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 368s] # in ... [ 368s] TEXINPUTS=".." \ [ 368s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 368s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 368s] a2x: resource files: [] [ 368s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 368s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 368s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 368s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 368s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 368s] make[1]: *** [Makefile:363: all] Error 2 [ 368s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 368s] dh_auto_build: error: make -j1 returned exit code 2 [ 368s] make: *** [debian/rules:5: binary] Error 25 [ 368s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 368s] ### VM INTERACTION START ### [ 370s] Powering off. [ 370s] [ 351.564631] reboot: Power down [ 370s] ### VM INTERACTION END ### [ 370s] [ 370s] lamb28 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Wed Nov 3 03:35:36 UTC 2021. [ 370s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:37:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:37:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <6182042197ba3_4be72abbd99885e0528484@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 470s] #define PACKAGE_URL "" [ 470s] #define PACKAGE "osmo-hnodeb" [ 470s] #define VERSION "UNKNOWN" [ 470s] #define STDC_HEADERS 1 [ 470s] #define HAVE_SYS_TYPES_H 1 [ 470s] #define HAVE_SYS_STAT_H 1 [ 470s] #define HAVE_STDLIB_H 1 [ 470s] #define HAVE_STRING_H 1 [ 470s] #define HAVE_MEMORY_H 1 [ 470s] #define HAVE_STRINGS_H 1 [ 470s] #define HAVE_INTTYPES_H 1 [ 470s] #define HAVE_STDINT_H 1 [ 470s] #define HAVE_UNISTD_H 1 [ 470s] #define HAVE_DLFCN_H 1 [ 470s] #define LT_OBJDIR ".libs/" [ 470s] [ 470s] configure: exit 1 [ 470s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 470s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 470s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 470s] make: *** [debian/rules:45: build] Error 2 [ 470s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 470s] ### VM INTERACTION START ### [ 472s] [ 432.496267] sysrq: SysRq : Power Off [ 472s] [ 432.518153] reboot: Power down [ 473s] ### VM INTERACTION END ### [ 473s] [ 473s] armbuild02 failed "build osmo-hnodeb_0.0.0.202111030026.dsc" at Wed Nov 3 03:37:30 UTC 2021. [ 473s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:39:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:39:26 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182047d41b30_4be72abbd99885e0528673@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 206s] # is like basename from coreutils, and . is WD. [ 206s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 206s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 206s] fi [ 206s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 206s] # in /usr/share/osmo-gsm-manuals. [ 206s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 206s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 206s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 206s] a2x: resource files: [] [ 206s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 206s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 206s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 206s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 206s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 206s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 206s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 206s] make[1]: *** [Makefile:368: all] Error 2 [ 206s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 206s] dh_auto_build: error: make -j1 returned exit code 2 [ 206s] make: *** [debian/rules:45: build] Error 25 [ 206s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 206s] ### VM INTERACTION START ### [ 207s] Powering off. [ 207s] [ 196.408506] reboot: Power down [ 207s] ### VM INTERACTION END ### [ 207s] [ 207s] goat17 failed "build osmo-cbc_0.2.2.dsc" at Wed Nov 3 03:39:22 UTC 2021. [ 207s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:39:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:39:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182049b87cdf_4be72abbd99885e052877c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 211s] # is like basename from coreutils, and . is WD. [ 211s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 211s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 211s] fi [ 211s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 211s] # in /usr/share/osmo-gsm-manuals. [ 211s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 211s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 211s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 211s] a2x: resource files: [] [ 211s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 211s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 211s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 211s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 211s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 211s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 211s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 211s] make[1]: *** [Makefile:392: all] Error 2 [ 211s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 211s] dh_auto_build: error: make -j1 returned exit code 2 [ 211s] make: *** [debian/rules:15: build] Error 25 [ 211s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 211s] ### VM INTERACTION START ### [ 212s] Powering off. [ 212s] [ 201.375847] reboot: Power down [ 212s] ### VM INTERACTION END ### [ 212s] [ 212s] goat11 failed "build osmo-ggsn_1.7.1.dsc" at Wed Nov 3 03:39:27 UTC 2021. [ 212s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:40:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:40:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618204ba4a898_4be72abbd99885e0528925@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 253s] # is like basename from coreutils, and . is WD. [ 253s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 253s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 253s] fi [ 253s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 253s] # in /usr/share/osmo-gsm-manuals. [ 253s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 253s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 253s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 253s] a2x: resource files: [] [ 253s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 253s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 253s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 253s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 253s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 253s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 253s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 253s] make[1]: *** [Makefile:371: all] Error 2 [ 253s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 253s] dh_auto_build: error: make -j1 returned exit code 2 [ 253s] make: *** [debian/rules:12: build] Error 25 [ 253s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 253s] ### VM INTERACTION START ### [ 254s] Powering off. [ 254s] [ 241.643476] reboot: Power down [ 254s] ### VM INTERACTION END ### [ 254s] [ 254s] hci-cnode2-m0 failed "build osmo-bts_1.3.3.dsc" at Wed Nov 3 03:40:20 UTC 2021. [ 254s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:40:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:40:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618204ba1bf13_4be72abbd99885e052886a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 245s] # is like basename from coreutils, and . is WD. [ 245s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 245s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 245s] fi [ 245s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 245s] # in /usr/share/osmo-gsm-manuals. [ 245s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 245s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 245s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 245s] a2x: resource files: [] [ 245s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 245s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 245s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 245s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 245s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 245s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 245s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 245s] make[1]: *** [Makefile:410: all] Error 2 [ 245s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 245s] dh_auto_build: error: make -j1 returned exit code 2 [ 245s] make: *** [debian/rules:7: build] Error 25 [ 245s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 245s] ### VM INTERACTION START ### [ 246s] Powering off. [ 246s] [ 233.596129] reboot: Power down [ 246s] ### VM INTERACTION END ### [ 246s] [ 246s] hci-cnode2-m0 failed "build osmo-hlr_1.3.1.dsc" at Wed Nov 3 03:40:10 UTC 2021. [ 246s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:40:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:40:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618204d8a67b2_4be72abbd99885e0529027@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 282s] | ^~~~~ [ 282s] mgcp_client.c:745:67: error: invalid type argument of unary '*' (have 'int') [ 282s] 745 | osmo_sock_get_name2(fd->fd), errno, strerror(errno), [ 282s] | ^~~~~ [ 282s] mgcp_client.c: In function 'mgcp_client_connect': [ 282s] mgcp_client.c:848:83: error: invalid type argument of unary '*' (have 'int') [ 282s] 848 | mgcp->actual.remote_addr, mgcp->actual.remote_port, strerror(errno)); [ 282s] | ^~~~~ [ 282s] mgcp_client.c:848:83: error: invalid type argument of unary '*' (have 'int') [ 282s] 848 | mgcp->actual.remote_addr, mgcp->actual.remote_port, strerror(errno)); [ 282s] | ^~~~~ [ 282s] make[4]: *** [Makefile:507: mgcp_client.lo] Error 1 [ 282s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libosmo-mgcp-client' [ 282s] make[3]: *** [Makefile:408: all-recursive] Error 1 [ 282s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 282s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 282s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 282s] make[1]: *** [Makefile:423: all] Error 2 [ 282s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 282s] dh_auto_build: error: make -j1 returned exit code 2 [ 282s] make: *** [debian/rules:17: build] Error 25 [ 282s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 283s] ### VM INTERACTION START ### [ 284s] Powering off. [ 284s] [ 269.335702] reboot: Power down [ 284s] ### VM INTERACTION END ### [ 284s] [ 284s] sheep86 failed "build osmo-mgw_1.8.1.dsc" at Wed Nov 3 03:40:47 UTC 2021. [ 284s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:41:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:41:25 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618204f9508f7_4be72abbd99885e0529398@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 325s] # is like basename from coreutils, and . is WD. [ 325s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 325s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 325s] fi [ 325s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 325s] # in /usr/share/osmo-gsm-manuals. [ 325s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 325s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 325s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 325s] a2x: resource files: [] [ 325s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 325s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 325s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 325s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 325s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 325s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 325s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 325s] make[1]: *** [Makefile:327: all] Error 2 [ 325s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 325s] dh_auto_build: error: make -j1 returned exit code 2 [ 325s] make: *** [debian/rules:12: build] Error 25 [ 325s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 325s] ### VM INTERACTION START ### [ 326s] Powering off. [ 326s] [ 308.003917] reboot: Power down [ 326s] ### VM INTERACTION END ### [ 326s] [ 326s] old-atreju5 failed "build osmo-sip-connector_1.5.1.dsc" at Wed Nov 3 03:41:23 UTC 2021. [ 326s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:42:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:42:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61820531434af_4be72abbd99885e05295f9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 380s] # we create a symlink at ./srcfile.adoc pointing at [ 380s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 380s] # is like basename from coreutils, and . is WD. [ 380s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 380s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 380s] fi [ 380s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 380s] # in /usr/share/osmo-gsm-manuals. [ 380s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 380s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 380s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 380s] a2x: resource files: [] [ 380s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 380s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 380s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 380s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 380s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 380s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 380s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 380s] dh_auto_build: error: make -j1 returned exit code 2 [ 380s] make: *** [debian/rules:12: build] Error 25 [ 380s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 380s] ### VM INTERACTION START ### [ 381s] Powering off. [ 381s] [ 364.028712] reboot: Power down [ 381s] ### VM INTERACTION END ### [ 381s] [ 381s] old-atreju2 failed "build osmo-pcu_0.9.1.dsc" at Wed Nov 3 03:42:20 UTC 2021. [ 381s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:42:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:42:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61820530ebdb2_4be72abbd99885e052949d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 370s] # is like basename from coreutils, and . is WD. [ 370s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 370s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 370s] fi [ 370s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 370s] # in /usr/share/osmo-gsm-manuals. [ 370s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 370s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 370s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 370s] a2x: resource files: [] [ 370s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 370s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 370s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 370s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 370s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 370s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 370s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 370s] make[1]: *** [Makefile:377: all] Error 2 [ 370s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 370s] dh_auto_build: error: make -j1 returned exit code 2 [ 370s] make: *** [debian/rules:45: build] Error 25 [ 370s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 370s] ### VM INTERACTION START ### [ 371s] Powering off. [ 371s] [ 352.865246] reboot: Power down [ 372s] ### VM INTERACTION END ### [ 372s] [ 372s] lamb28 failed "build osmo-gbproxy_0.1.2.dsc" at Wed Nov 3 03:42:13 UTC 2021. [ 372s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:42:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:42:50 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182054f9e5d5_4be72abbd99885e05296e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 400s] # is like basename from coreutils, and . is WD. [ 400s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 400s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 400s] fi [ 400s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 400s] # in /usr/share/osmo-gsm-manuals. [ 400s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 400s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 400s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 400s] a2x: resource files: [] [ 400s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 400s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 400s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 400s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 400s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 400s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 400s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 400s] make[1]: *** [Makefile:403: all] Error 2 [ 400s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 400s] dh_auto_build: error: make -j1 returned exit code 2 [ 400s] make: *** [debian/rules:12: build] Error 25 [ 400s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 400s] ### VM INTERACTION START ### [ 401s] Powering off. [ 401s] [ 382.022149] reboot: Power down [ 401s] ### VM INTERACTION END ### [ 401s] [ 401s] lamb28 failed "build libosmo-sccp_1.4.0.dsc" at Wed Nov 3 03:42:41 UTC 2021. [ 401s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:43:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:43:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182054fcf8f8_4be72abbd99885e052978d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 409s] # is like basename from coreutils, and . is WD. [ 409s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 409s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 409s] fi [ 409s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 409s] # in /usr/share/osmo-gsm-manuals. [ 409s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 409s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 409s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 409s] a2x: resource files: [] [ 409s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 409s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 409s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 409s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 409s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 409s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 409s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 409s] make[1]: *** [Makefile:387: all] Error 2 [ 409s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 409s] dh_auto_build: error: make -j1 returned exit code 2 [ 409s] make: *** [debian/rules:12: build] Error 25 [ 409s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 409s] ### VM INTERACTION START ### [ 411s] Powering off. [ 411s] [ 393.579971] reboot: Power down [ 411s] ### VM INTERACTION END ### [ 411s] [ 411s] lamb08 failed "build osmo-remsim_0.2.4.dsc" at Wed Nov 3 03:42:56 UTC 2021. [ 411s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:43:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:43:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182056e38762_4be72abbd99885e052989a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 425s] # is like basename from coreutils, and . is WD. [ 425s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 425s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 425s] fi [ 425s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 425s] # in /usr/share/osmo-gsm-manuals. [ 425s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 425s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 425s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 425s] a2x: resource files: [] [ 425s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 425s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 425s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 425s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 425s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 425s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 425s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 425s] make[1]: *** [Makefile:452: all] Error 2 [ 425s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 425s] dh_auto_build: error: make -j1 returned exit code 2 [ 425s] make: *** [debian/rules:6: build] Error 25 [ 425s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 425s] ### VM INTERACTION START ### [ 426s] Powering off. [ 426s] [ 409.044606] reboot: Power down [ 426s] ### VM INTERACTION END ### [ 426s] [ 426s] wildcard2 failed "build osmo-trx_1.3.1.dsc" at Wed Nov 3 03:43:09 UTC 2021. [ 426s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:48:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:48:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618206b721a7b_4be72abbd99885e05299d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 348s] # is like basename from coreutils, and . is WD. [ 348s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 348s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 348s] fi [ 348s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 348s] # in /usr/share/osmo-gsm-manuals. [ 348s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 348s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 348s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 348s] a2x: resource files: [] [ 348s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 348s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 348s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 348s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 348s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 348s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 348s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 348s] make[1]: *** [Makefile:388: all] Error 2 [ 348s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 348s] dh_auto_build: error: make -j1 returned exit code 2 [ 348s] make: *** [debian/rules:45: build] Error 25 [ 348s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 348s] ### VM INTERACTION START ### [ 349s] Powering off. [ 349s] [ 332.747974] reboot: Power down [ 349s] ### VM INTERACTION END ### [ 349s] [ 349s] wildcard2 failed "build osmo-bsc_1.7.2.dsc" at Wed Nov 3 03:48:43 UTC 2021. [ 349s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:49:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:49:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618206d5b6ab0_4be72abbd99885e0530035@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 370s] # is like basename from coreutils, and . is WD. [ 370s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 370s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 370s] fi [ 370s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 370s] # in /usr/share/osmo-gsm-manuals. [ 370s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 370s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 370s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 370s] a2x: resource files: [] [ 370s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 370s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 370s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 370s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 370s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 370s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 370s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 370s] make[1]: *** [Makefile:377: all] Error 2 [ 370s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 370s] dh_auto_build: error: make -j1 returned exit code 2 [ 370s] make: *** [debian/rules:45: build] Error 25 [ 370s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 370s] ### VM INTERACTION START ### [ 371s] Powering off. [ 371s] [ 353.174882] reboot: Power down [ 371s] ### VM INTERACTION END ### [ 371s] [ 371s] lamb17 failed "build osmo-smlc_0.2.0.dsc" at Wed Nov 3 03:49:11 UTC 2021. [ 371s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 03:54:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 03:54:10 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618207ff83074_4be72abbd99885e0530274@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 650s] # is like basename from coreutils, and . is WD. [ 650s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 650s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 650s] fi [ 650s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 650s] # in /usr/share/osmo-gsm-manuals. [ 650s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 650s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 650s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 650s] a2x: resource files: [] [ 650s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 650s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 650s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 650s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 650s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 650s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 650s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 650s] make[1]: *** [Makefile:391: all] Error 2 [ 650s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 650s] dh_auto_build: error: make -j1 returned exit code 2 [ 650s] make: *** [debian/rules:9: build] Error 25 [ 650s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 650s] ### VM INTERACTION START ### [ 651s] Powering off. [ 651s] [ 633.737740] reboot: Power down [ 652s] ### VM INTERACTION END ### [ 652s] [ 652s] lamb51 failed "build osmo-iuh_1.0.0.dsc" at Wed Nov 3 03:53:57 UTC 2021. [ 652s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 04:00:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 04:00:58 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182098997f92_4be72abbd99885e0530757@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 389s] # is like basename from coreutils, and . is WD. [ 389s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 389s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 389s] fi [ 389s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 389s] # in /usr/share/osmo-gsm-manuals. [ 389s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 389s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 389s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 389s] a2x: resource files: [] [ 389s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 389s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 389s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 389s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 389s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 389s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 389s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 389s] make[1]: *** [Makefile:402: all] Error 2 [ 389s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 389s] dh_auto_build: error: make -j1 returned exit code 2 [ 389s] make: *** [debian/rules:45: build] Error 25 [ 389s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 389s] ### VM INTERACTION START ### [ 390s] Powering off. [ 390s] [ 371.599670] reboot: Power down [ 390s] ### VM INTERACTION END ### [ 390s] [ 390s] lamb24 failed "build osmo-msc_1.7.1.dsc" at Wed Nov 3 04:00:49 UTC 2021. [ 390s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 04:00:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 04:00:58 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618209895a28a_4be72abbd99885e05306a6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 390s] # is like basename from coreutils, and . is WD. [ 390s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 390s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 390s] fi [ 390s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 390s] # in /usr/share/osmo-gsm-manuals. [ 390s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 390s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 390s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 390s] a2x: resource files: [] [ 390s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 390s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 390s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 390s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 390s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 390s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 390s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 390s] make[1]: *** [Makefile:394: all] Error 2 [ 390s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 390s] dh_auto_build: error: make -j1 returned exit code 2 [ 390s] make: *** [debian/rules:45: build] Error 25 [ 390s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 391s] ### VM INTERACTION START ### [ 392s] Powering off. [ 392s] [ 373.723660] reboot: Power down [ 392s] ### VM INTERACTION END ### [ 392s] [ 392s] lamb51 failed "build osmo-sgsn_1.7.1.dsc" at Wed Nov 3 04:00:47 UTC 2021. [ 392s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Nov 3 07:55:51 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 3 Nov 2021 07:55:51 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 ) Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/2/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062/2/src/gb_proxy.c at 1043 PS2, Line 1043: rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); > so we don't need 2 TLVs anymore? or where they never needed? They were never needed. The second one is only used to handle RIM messages which can have multiple (src/dst) RIM_ROUTING_INFO IEs. It doesn't matter for parsing here since we don't need to look at those. -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 07:55:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 07:55:56 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 3 Nov 2021 07:55:56 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Move BSSGP decoding into its own function and use it In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 ) Change subject: gbproxy: Move BSSGP decoding into its own function and use it ...................................................................... gbproxy: Move BSSGP decoding into its own function and use it This code was copied in BSS and SGSN PTP receive functions and also in the functions that extract the inner PDU-in-error from the STATUS PDU. Use a central function for less code duplication and better maintainability. This also fixes TTCN3 test TC_status_ptp_ul_tlli the c&p omitted the special handling of UL/DL unitdata. Related: OS#4892 Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 --- M src/gb_proxy.c 1 file changed, 27 insertions(+), 36 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 7333e80..b96b374 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -380,6 +380,29 @@ return gbprox_relay2peer(msg, sgsn_bvc, sig_bvci ? 0 : sgsn_bvc->bvci); } +static int gbproxy_decode_bssgp(const struct bssgp_normal_hdr *bgph, int msg_len, struct tlv_parsed *tp, const char *log_pfx) +{ + int rc; + + /* UNITDATA PDUs have a different header than the other PDUs */ + if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA || bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) { + const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) bgph; + if (msg_len < sizeof(*budh)) + return -OSMO_TLVP_ERR_MAND_IE_MISSING; + rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, budh->pdu_type, budh->data, + msg_len - sizeof(*budh), 0, 0, DGPRS, log_pfx); + /* populate TLLI from the fixed headser into the TLV-parsed array so later code + * doesn't have to worry where the TLLI came from */ + tp->lv[BSSGP_IE_TLLI].len = 4; + tp->lv[BSSGP_IE_TLLI].val = (const uint8_t *) &budh->tlli; + } else { + rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, bgph->pdu_type, bgph->data, + msg_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx); + } + + return rc; +} + static int gbproxy_tlli_from_status_pdu(struct tlv_parsed *tp, uint32_t *tlli, char *log_pfx); /* Receive an incoming PTP message from a BSS-side NS-VC */ @@ -419,21 +442,7 @@ return tx_status(nse, ns_bvci, BSSGP_CAUSE_UNKNOWN_BVCI, &ns_bvci, msg); } - /* UL_UNITDATA has a different header than all other uplink PDUs */ - if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA) { - const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) msgb_bssgph(msg); - if (msgb_bssgp_len(msg) < sizeof(*budh)) - return tx_status(nse, ns_bvci, BSSGP_CAUSE_INV_MAND_INF, NULL, msg); - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, budh->data, - msgb_bssgp_len(msg) - sizeof(*budh), 0, 0, DGPRS, log_pfx); - /* populate TLLI from the fixed headser into the TLV-parsed array so later code - * doesn't have to worry where the TLLI came from */ - tp.lv[BSSGP_IE_TLLI].len = 4; - tp.lv[BSSGP_IE_TLLI].val = (const uint8_t *) &budh->tlli; - } else { - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, bgph->data, - msgb_bssgp_len(msg) - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - } + rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &tp, log_pfx); if (rc < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_BSS)); return tx_status_from_tlvp(nse, rc, msg); @@ -567,21 +576,7 @@ return tx_status(nse, ns_bvci, BSSGP_CAUSE_BVCI_BLOCKED, &ns_bvci, msg); } - /* DL_UNITDATA has a different header than all other uplink PDUs */ - if (bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) { - const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) msgb_bssgph(msg); - if (msgb_bssgp_len(msg) < sizeof(*budh)) - return tx_status(nse, ns_bvci, BSSGP_CAUSE_INV_MAND_INF, NULL, msg); - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, budh->data, - msgb_bssgp_len(msg) - sizeof(*budh), 0, 0, DGPRS, log_pfx); - /* populate TLLI from the fixed headser into the TLV-parsed array so later code - * doesn't have to worry where the TLLI came from */ - tp.lv[BSSGP_IE_TLLI].len = 4; - tp.lv[BSSGP_IE_TLLI].val = (const uint8_t *) &budh->tlli; - } else { - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, &tp, 1, bgph->pdu_type, bgph->data, - msgb_bssgp_len(msg) - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - } + rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &tp, log_pfx); if (rc < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_BSS)); return tx_status_from_tlvp(nse, rc, msg); @@ -1017,9 +1012,7 @@ struct tlv_parsed tp_inner[2]; /* TODO: Parse partial messages as well */ - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp_inner, ARRAY_SIZE(tp_inner), bgph->pdu_type, bgph->data, - pdu_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); if (rc < 0) return rc; @@ -1047,9 +1040,7 @@ struct tlv_parsed tp_inner[2]; /* TODO: Parse partial messages as well */ - rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp_inner, ARRAY_SIZE(tp_inner), bgph->pdu_type, bgph->data, - pdu_len - sizeof(*bgph), 0, 0, DGPRS, log_pfx); - + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); if (rc < 0) return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I882aa97b0f4158affe45e81e4e4701bd36ef89f7 Gerrit-Change-Number: 26062 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 07:55:57 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 3 Nov 2021 07:55:57 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Increase correct counter when BSSGP decode from SGSN fails In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26063 ) Change subject: gbproxy: Increase correct counter when BSSGP decode from SGSN fails ...................................................................... gbproxy: Increase correct counter when BSSGP decode from SGSN fails Change-Id: I8936cee105c933987c9af1fac3c91dc26864325b --- M src/gb_proxy.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index b96b374..0fa8be3 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -578,7 +578,7 @@ rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &tp, log_pfx); if (rc < 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_BSS)); + rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_SGSN)); return tx_status_from_tlvp(nse, rc, msg); } /* hack to get both msg + tlv_parsed passed via osmo_fsm_inst_dispatch */ -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I8936cee105c933987c9af1fac3c91dc26864325b Gerrit-Change-Number: 26063 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 07:55:58 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 3 Nov 2021 07:55:58 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 ) Change subject: gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp ...................................................................... gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp Change-Id: I7965a4b68866c619159c524a63e051b0d9cbe80f --- M src/gb_proxy.c 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 0fa8be3..9845a09 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -1009,18 +1009,18 @@ int pdu_len = TLVP_LEN(&tp[0], BSSGP_IE_PDU_IN_ERROR); const uint8_t *pdu_data = TLVP_VAL(&tp[0], BSSGP_IE_PDU_IN_ERROR); struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; - struct tlv_parsed tp_inner[2]; + struct tlv_parsed tp_inner; /* TODO: Parse partial messages as well */ - rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); if (rc < 0) return rc; - if (TLVP_PRESENT(&tp_inner[0], BSSGP_IE_TLLI)) { - *tlli = osmo_load32be(TLVP_VAL(&tp_inner[0], BSSGP_IE_TLLI)); - } else if (TLVP_PRESENT(&tp_inner[0], BSSGP_IE_TMSI)) { + if (TLVP_PRESENT(&tp_inner, BSSGP_IE_TLLI)) { + *tlli = osmo_load32be(TLVP_VAL(&tp_inner, BSSGP_IE_TLLI)); + } else if (TLVP_PRESENT(&tp_inner, BSSGP_IE_TMSI)) { /* we treat the TMSI like a TLLI and extract the NRI from it */ - *tlli = osmo_load32be(TLVP_VAL(&tp_inner[0], BSSGP_IE_TMSI)); + *tlli = osmo_load32be(TLVP_VAL(&tp_inner, BSSGP_IE_TMSI)); /* Convert the TMSI into a FOREIGN TLLI so it is routed appropriately */ *tlli = gprs_tmsi2tlli(*tlli, TLLI_FOREIGN); } else { @@ -1037,15 +1037,15 @@ int pdu_len = TLVP_LEN(&tp[0], BSSGP_IE_PDU_IN_ERROR); const uint8_t *pdu_data = TLVP_VAL(&tp[0], BSSGP_IE_PDU_IN_ERROR); struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; - struct tlv_parsed tp_inner[2]; + struct tlv_parsed tp_inner; /* TODO: Parse partial messages as well */ - rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner[0], log_pfx); + rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); if (rc < 0) return rc; - if (TLVP_PRESENT(&tp_inner[0], BSSGP_IE_BVCI)) - *bvci = ntohs(tlvp_val16_unal(&tp_inner[0], BSSGP_IE_BVCI)); + if (TLVP_PRESENT(&tp_inner, BSSGP_IE_BVCI)) + *bvci = ntohs(tlvp_val16_unal(&tp_inner, BSSGP_IE_BVCI)); else return -ENOENT; -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I7965a4b68866c619159c524a63e051b0d9cbe80f Gerrit-Change-Number: 26064 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 09:47:42 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 3 Nov 2021 09:47:42 +0000 Subject: Change in pysim[master]: pySim-shell: print newline on exit with CTRL+D References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26081 ) Change subject: pySim-shell: print newline on exit with CTRL+D ...................................................................... pySim-shell: print newline on exit with CTRL+D When pySim-shell is exited using CTRL+D it does not print a newline. This means that the prompt of the OS shell shows up after the pySim-shell prompt. This is irretating. Lets print a new line on exit with CTRL+D so that everything looks straight. Change-Id: I88e58094b9badeaabd8502006e5e16f35eaa683e --- M pySim-shell.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/26081/1 diff --git a/pySim-shell.py b/pySim-shell.py index 3fc5859..ee74506 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -204,6 +204,10 @@ """Display the intro banner""" self.poutput(self.intro) + def do_eof(self, _: argparse.Namespace) -> bool: + self.poutput("") + return self.do_quit('') + @cmd2.with_category(CUSTOM_CATEGORY) def do_equip(self, opts): """Equip pySim-shell with card""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88e58094b9badeaabd8502006e5e16f35eaa683e Gerrit-Change-Number: 26081 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 09:52:44 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 09:52:44 +0000 Subject: Change in osmo-iuh[master]: contrib/osmo-iuh.spec: fix missing ldconfig lines References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26082 ) Change subject: contrib/osmo-iuh.spec: fix missing ldconfig lines ...................................................................... contrib/osmo-iuh.spec: fix missing ldconfig lines Fix build failure on various openSUSE distributions in OBS, where rpmlint runs after the build and complains about these missing post/postun scriptlets. Fix for: libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 ... (none): E: badness 1200 exceeds threshold 1000, aborting. Related: SYS#5516 Change-Id: I898aa67dbc7deaa9a8235f508a34dd29cc83b385 --- M contrib/osmo-iuh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/26082/1 diff --git a/contrib/osmo-iuh.spec.in b/contrib/osmo-iuh.spec.in index b4f14f2..f40c3db 100644 --- a/contrib/osmo-iuh.spec.in +++ b/contrib/osmo-iuh.spec.in @@ -129,8 +129,12 @@ %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) +%post -n libosmo-hnbap0 -p /sbin/ldconfig +%postun -n libosmo-hnbap0 -p /sbin/ldconfig %post -n libosmo-ranap3 -p /sbin/ldconfig %postun -n libosmo-ranap3 -p /sbin/ldconfig +%post -n libosmo-rua0 -p /sbin/ldconfig +%postun -n libosmo-rua0 -p /sbin/ldconfig %post -n libosmo-sabp0 -p /sbin/ldconfig %postun -n libosmo-sabp0 -p /sbin/ldconfig -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I898aa67dbc7deaa9a8235f508a34dd29cc83b385 Gerrit-Change-Number: 26082 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 09:52:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 09:52:59 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 to look at the new patch set (#3). Change subject: d/control, spec: add missing builddeps ...................................................................... d/control, spec: add missing builddeps autoconf-archive is apparently needed to build the package. We have it in few other Osmocom projects as build dependency too, others seem to ship related m4 macros directly in a m4 dir. Fix for: configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. Related: SYS#5516 Change-Id: If9ff232844d72094fb883700185ae152ca40493d --- M contrib/osmo-hnodeb.spec.in M debian/control 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/65/26065/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 09:54:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 09:54:45 +0000 Subject: Change in osmo-iuh[master]: contrib/osmo-iuh.spec: fix missing ldconfig lines In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26082 ) Change subject: contrib/osmo-iuh.spec: fix missing ldconfig lines ...................................................................... Patch Set 1: Fixes the build, as tested here: https://build.opensuse.org/package/show/home:osmith42/osmo-iuh -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I898aa67dbc7deaa9a8235f508a34dd29cc83b385 Gerrit-Change-Number: 26082 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 09:54:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 09:55:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 09:55:14 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... Patch Set 3: This works now: https://build.opensuse.org/package/show/home:osmith42/osmo-hnodeb -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 09:55:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:00:09 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:00:09 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... Patch Set 3: Jenkins build failure is unrelated, removing... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 10:00:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:00:11 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:00:11 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:00:27 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:00:27 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... Patch Set 3: Verified+1 Verified here: https://build.opensuse.org/package/show/home:osmith42/osmo-hnodeb -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Nov 2021 10:00:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:02:12 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:02:12 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... Patch Set 3: Code-Review+2 Trivial patch, adding +2 to unblock the broken package in OBS. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Nov 2021 10:02:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:02:32 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:02:32 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... d/control, spec: add missing builddeps autoconf-archive is apparently needed to build the package. We have it in few other Osmocom projects as build dependency too, others seem to ship related m4 macros directly in a m4 dir. Fix for: configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. Related: SYS#5516 Change-Id: If9ff232844d72094fb883700185ae152ca40493d --- M contrib/osmo-hnodeb.spec.in M debian/control 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index 4dbb670..21b1ff9 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -24,8 +24,10 @@ Group: Hardware/Mobile URL: https://osmocom.org/projects/osmohnodeb Source: %{name}-%{version}.tar.xz +BuildRequires: autoconf-archive BuildRequires: automake >= 1.9 BuildRequires: libtool >= 2 +BuildRequires: lksctp-tools-devel BuildRequires: pkgconfig >= 0.20 %if 0%{?suse_version} BuildRequires: systemd-rpm-macros @@ -39,7 +41,11 @@ BuildRequires: pkgconfig(libosmogb) >= 1.5.0 BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-hnbap) >= 0.7.0 +BuildRequires: pkgconfig(libosmo-ranap) >= 0.7.0 +BuildRequires: pkgconfig(libosmo-rua) >= 0.7.0 BuildRequires: pkgconfig(talloc) +BuildRequires: pkgconfig(libasn1c) >= 0.9.30 %{?systemd_requires} %description diff --git a/debian/control b/debian/control index a7316db..fd5f4bb 100644 --- a/debian/control +++ b/debian/control @@ -6,16 +6,21 @@ dh-autoreconf, autotools-dev, autoconf, + autoconf-archive, automake, libtool, pkg-config, python3-minimal, libtalloc-dev, - libasn1c-dev, + libasn1c-dev (>= 0.9.30), + libsctp-dev, libosmocore-dev (>= 1.5.0), libosmo-sigtran-dev (>= 1.4.0), libosmo-abis-dev (>= 1.1.0), libosmo-netif-dev (>= 1.1.0), + libosmo-hnbap-dev (>= 0.7.0), + libosmo-ranap-dev (>= 0.7.0), + libosmo-rua-dev (>= 0.7.0), osmo-gsm-manuals-dev (>= 1.1.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-hnodeb.git -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:02:33 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:02:33 +0000 Subject: Change in osmo-hnodeb[master]: rpm spec: fix invalid file paths In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 ) Change subject: rpm spec: fix invalid file paths ...................................................................... rpm spec: fix invalid file paths Fix for: File not found: /home/abuild/rpmbuild/BUILDROOT/osmo-hnodeb-0.0.0.202111021358-1.1.arm/usr/share/doc/packages/osmo-hnodeb/examples/osmo-hnodeb/*/osmo-hnodeb*.cfg File not found: /home/abuild/rpmbuild/BUILDROOT/osmo-hnodeb-0.0.0.202111021358-1.1.arm/usr/share/doc/packages/osmo-hnodeb/README With this patch applied, the deb and rpm packages build successfully now (verified in own OBS namespace). Related: SYS#5516 Change-Id: I3c728489d38272d8477da5050f407708b8c4289b --- M contrib/osmo-hnodeb.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index 21b1ff9..57b3280 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -84,12 +84,11 @@ %files %license COPYING -%doc AUTHORS README +%doc AUTHORS README.md %{_bindir}/osmo-hnodeb %dir %{_docdir}/%{name}/examples %dir %{_docdir}/%{name}/examples/osmo-hnodeb %{_docdir}/%{name}/examples/osmo-hnodeb/osmo-hnodeb.cfg -%{_docdir}/%{name}/examples/osmo-hnodeb/*/osmo-hnodeb*.cfg %dir %{_sysconfdir}/osmocom %config(noreplace) %{_sysconfdir}/osmocom/osmo-hnodeb.cfg %{_unitdir}/%{name}.service -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I3c728489d38272d8477da5050f407708b8c4289b Gerrit-Change-Number: 26066 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:02:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:02:34 +0000 Subject: Change in osmo-hnodeb[master]: gitignore: add src/osmo-hnodeb/osmo-hnodeb In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 ) Change subject: gitignore: add src/osmo-hnodeb/osmo-hnodeb ...................................................................... gitignore: add src/osmo-hnodeb/osmo-hnodeb Change-Id: I6bfb0b0696b8910c3f095390d6634f49baeebb14 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 0518b6f..635f5ed 100644 --- a/.gitignore +++ b/.gitignore @@ -45,6 +45,8 @@ tags /deps +src/osmo-hnodeb/osmo-hnodeb + #tests tests/testsuite.dir tests/*/*_test -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6bfb0b0696b8910c3f095390d6634f49baeebb14 Gerrit-Change-Number: 26067 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:04:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:04:10 +0000 Subject: Change in osmo-iuh[master]: contrib/osmo-iuh.spec: fix missing ldconfig lines In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26082 ) Change subject: contrib/osmo-iuh.spec: fix missing ldconfig lines ...................................................................... Patch Set 1: Code-Review+2 Trivial patch, merging now to fix these build errors on OBS. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I898aa67dbc7deaa9a8235f508a34dd29cc83b385 Gerrit-Change-Number: 26082 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Nov 2021 10:04:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:04:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 10:04:14 +0000 Subject: Change in osmo-iuh[master]: contrib/osmo-iuh.spec: fix missing ldconfig lines In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26082 ) Change subject: contrib/osmo-iuh.spec: fix missing ldconfig lines ...................................................................... contrib/osmo-iuh.spec: fix missing ldconfig lines Fix build failure on various openSUSE distributions in OBS, where rpmlint runs after the build and complains about these missing post/postun scriptlets. Fix for: libosmo-hnbap0.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosmo-hnbap.so.0.0.0 ... (none): E: badness 1200 exceeds threshold 1000, aborting. Related: SYS#5516 Change-Id: I898aa67dbc7deaa9a8235f508a34dd29cc83b385 --- M contrib/osmo-iuh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/contrib/osmo-iuh.spec.in b/contrib/osmo-iuh.spec.in index b4f14f2..f40c3db 100644 --- a/contrib/osmo-iuh.spec.in +++ b/contrib/osmo-iuh.spec.in @@ -129,8 +129,12 @@ %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) +%post -n libosmo-hnbap0 -p /sbin/ldconfig +%postun -n libosmo-hnbap0 -p /sbin/ldconfig %post -n libosmo-ranap3 -p /sbin/ldconfig %postun -n libosmo-ranap3 -p /sbin/ldconfig +%post -n libosmo-rua0 -p /sbin/ldconfig +%postun -n libosmo-rua0 -p /sbin/ldconfig %post -n libosmo-sabp0 -p /sbin/ldconfig %postun -n libosmo-sabp0 -p /sbin/ldconfig -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I898aa67dbc7deaa9a8235f508a34dd29cc83b385 Gerrit-Change-Number: 26082 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:49:48 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 3 Nov 2021 10:49:48 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26055 to look at the new patch set (#3). Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... commands: do not check SW manually, use send_apdu_checksw() The transport layer provides a method send_apdu_checksw to send APDUs and to be sure the SW is the expected one. Given that, there is no need to verify the SW manually. The exception of send_apdu_checksw will catch the problem and also display the SW in a human readable form. Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Related: OS#5275 --- M pySim/commands.py 1 file changed, 13 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/26055/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:49:49 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 3 Nov 2021 10:49:49 +0000 Subject: Change in pysim[master]: commands: return none, when offset exceeds file length References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26083 ) Change subject: commands: return none, when offset exceeds file length ...................................................................... commands: return none, when offset exceeds file length The computed length of the file may be negative, when the offset exceeds the file length. When this is the case, return none Change-Id: I2c017c620254fae188022851ef3b670730aab503 --- M pySim/commands.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/26083/1 diff --git a/pySim/commands.py b/pySim/commands.py index 1fd1f61..347b821 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -140,6 +140,9 @@ return (None, None) if length is None: length = self.__len(r) - offset + if length < 0: + return (None, None) + total_data = '' chunk_offset = 0 while chunk_offset < length: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2c017c620254fae188022851ef3b670730aab503 Gerrit-Change-Number: 26083 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 10:53:20 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 3 Nov 2021 10:53:20 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py at 148 PS2, Line 148: data, sw = self._tp.send_apdu_checksw(pdu) > I would wrap this block into additional try/catch: [?] I wasn't sure if the context info about offset and len is useful at all. Its now added again. The line is bit long now. In this particular case it is important that all exception info is represented in one line since the text of the last expectation used as error message in the log of the export command. https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py at 177 PS2, Line 177: chunk_data, chunk_sw = self._tp.send_apdu_checksw(pdu) > Same here. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 10:53:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:34:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:34:50 +0000 Subject: Change in pysim[master]: sim-rest-client: Errors are plain text, not JSON References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26084 ) Change subject: sim-rest-client: Errors are plain text, not JSON ...................................................................... sim-rest-client: Errors are plain text, not JSON don't try to decode JSON where there is none. Change-Id: Iafa5d1fc20b2b9ea8d9c828fc3c7e8490d0c3693 --- M contrib/sim-rest-client.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/84/26084/1 diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py index 8f74adc..512765b 100755 --- a/contrib/sim-rest-client.py +++ b/contrib/sim-rest-client.py @@ -128,6 +128,9 @@ req_json = {'rand': rand.hex(), 'autn': t['autn'].hex()} print("-> %s" % req_json) resp = rest_post('/slot/%u' % args.slot_nr, req_json) + if not resp.ok: + print("<- ERROR %u: %s" % (resp.status_code, resp.text)) + break resp_json = resp.json() print("<- %s" % resp_json) if 'synchronisation_failure' in resp_json: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iafa5d1fc20b2b9ea8d9c828fc3c7e8490d0c3693 Gerrit-Change-Number: 26084 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:34:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:34:51 +0000 Subject: Change in pysim[master]: sim-rest-server: Add capability to obtain IMSI + ICCID of card References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26085 ) Change subject: sim-rest-server: Add capability to obtain IMSI + ICCID of card ...................................................................... sim-rest-server: Add capability to obtain IMSI + ICCID of card $ curl http://localhost:8000/sim-info-api/v1/slot/0 { "imsi": "262011500776110", "iccid": "89490240001879910128" } Change-Id: I9df8854f6a962e7f86f62b2d44ec7696271c58c8 --- M contrib/sim-rest-server.py 1 file changed, 50 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/85/26085/1 diff --git a/contrib/sim-rest-server.py b/contrib/sim-rest-server.py index 0f77dfe..fb73ef8 100755 --- a/contrib/sim-rest-server.py +++ b/contrib/sim-rest-server.py @@ -34,6 +34,23 @@ #print("CMD: %s -> RSP: %s %s" % (cmd, sw, resp)) pass +def connect_to_card(slot_nr:int): + tp = PcscSimLink(slot_nr, apdu_tracer=ApduPrintTracer()) + tp.connect() + + scc = SimCardCommands(tp) + card = UsimCard(scc) + + # this should be part of UsimCard, but FairewavesSIM breaks with that :/ + scc.cla_byte = "00" + scc.sel_ctrl = "0004" + + card.read_aids() + card.select_adf_by_aid(adf='usim') + + return tp, scc, card + + @route('/sim-auth-api/v1/slot/') def auth(request, slot): """REST API endpoint for performing authentication against a USIM. @@ -49,8 +66,7 @@ return "Malformed Request" try: - tp = PcscSimLink(slot, apdu_tracer=ApduPrintTracer()) - tp.connect() + tp, scc, card = connect_to_card(slot) except ReaderError: request.setResponseCode(404) return "Specified SIM Slot doesn't exist" @@ -61,13 +77,7 @@ request.setResponseCode(410) return "No SIM card inserted in slot" - scc = SimCardCommands(tp) - card = UsimCard(scc) - # this should be part of UsimCard, but FairewavesSIM breaks with that :/ - scc.cla_byte = "00" - scc.sel_ctrl = "0004" try: - card.read_aids() card.select_adf_by_aid(adf='usim') res, sw = scc.authenticate(rand, autn) except SwMatchError as e: @@ -78,6 +88,38 @@ return json.dumps(res, indent=4) + at route('/sim-info-api/v1/slot/') +def info(request, slot): + """REST API endpoint for obtaining information about an USIM. + Expects empty body in request. + Returns a JSON body containing ICCID, IMSI.""" + + try: + tp, scc, card = connect_to_card(slot) + except ReaderError: + request.setResponseCode(404) + return "Specified SIM Slot doesn't exist" + except ProtocolError: + request.setResponseCode(500) + return "Error" + except NoCardError: + request.setResponseCode(410) + return "No SIM card inserted in slot" + + try: + card.select_adf_by_aid(adf='usim') + iccid, sw = card.read_iccid() + imsi, sw = card.read_imsi() + res = {"imsi": imsi, "iccid": iccid } + except SwMatchError as e: + request.setResponseCode(500) + return "Communication Error %s" % e + + tp.disconnect() + + return json.dumps(res, indent=4) + + def main(argv): parser = argparse.ArgumentParser() parser.add_argument("-H", "--host", help="Host/IP to bind HTTP to", default="localhost") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9df8854f6a962e7f86f62b2d44ec7696271c58c8 Gerrit-Change-Number: 26085 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:34:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:34:51 +0000 Subject: Change in pysim[master]: sim-rest-client: Add support for 'info' command to get IMSI+ICCID References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26086 ) Change subject: sim-rest-client: Add support for 'info' command to get IMSI+ICCID ...................................................................... sim-rest-client: Add support for 'info' command to get IMSI+ICCID Change-Id: Ia2a13033b1d3e009a841579184f4ad39101f94d0 --- M contrib/sim-rest-client.py 1 file changed, 49 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/26086/1 diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py index 512765b..7da2363 100755 --- a/contrib/sim-rest-client.py +++ b/contrib/sim-rest-client.py @@ -73,10 +73,9 @@ return False -def build_url(suffix:str) -> str: +def build_url(suffix:str, base_path="/sim-auth-api/v1") -> str: """Build an URL from global server_host, server_port, BASE_PATH and suffix.""" - BASE_PATH= "/sim-auth-api/v1" - return "http://%s:%u%s%s" % (server_host, server_port, BASE_PATH, suffix) + return "http://%s:%u%s%s" % (server_host, server_port, base_path, suffix) def rest_post(suffix:str, js:Optional[dict] = None): @@ -91,29 +90,29 @@ print("POST failed") return resp +def rest_get(suffix:str, base_path=None): + """Perform a RESTful GET.""" + url = build_url(suffix, base_path) + if verbose: + print("GET %s" % url) + resp = requests.get(url) + if verbose: + print("-> %s" % (resp)) + if not resp.ok: + print("GET failed") + return resp -def main(argv): - global server_port, server_host, verbose +def main_info(args): + resp = rest_get('/slot/%u' % args.slot_nr, base_path="/sim-info-api/v1") + if not resp.ok: + print("<- ERROR %u: %s" % (resp.status_code, resp.text)) + sys.exit(1) + resp_json = resp.json() + print("<- %s" % resp_json) - parser = argparse.ArgumentParser() - parser.add_argument("-H", "--host", help="Host to connect to", default="localhost") - parser.add_argument("-p", "--port", help="TCP port to connect to", default=8000) - parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0) - parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, default=0) - parser.add_argument("-c", "--count", help="Auth count", type=int, default=10) - parser.add_argument("-k", "--key", help="Secret key K (hex)", type=str, required=True) - parser.add_argument("-o", "--opc", help="Secret OPc (hex)", type=str, required=True) - parser.add_argument("-a", "--amf", help="AMF Field (hex)", type=str, default="0000") - parser.add_argument("-s", "--sqn", help="SQN Field (hex)", type=str, default="000000000000") - - args = parser.parse_args() - - server_host = args.host - server_port = args.port - verbose = args.verbose - +def main_auth(args): #opc = bytes.fromhex('767A662ACF4587EB0C450C6A95540A04') #k = bytes.fromhex('876B2D8D403EE96755BEF3E0A1857EBE') opc = bytes.fromhex(args.opc) @@ -154,5 +153,33 @@ raise RuntimeError("Auth failure") +def main(argv): + global server_port, server_host, verbose + + parser = argparse.ArgumentParser() + parser.add_argument("-H", "--host", help="Host to connect to", default="localhost") + parser.add_argument("-p", "--port", help="TCP port to connect to", default=8000) + parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0) + parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, default=0) + subp = parser.add_subparsers() + + auth_p = subp.add_parser('auth', help='UMTS AKA Authentication') + auth_p.add_argument("-c", "--count", help="Auth count", type=int, default=10) + auth_p.add_argument("-k", "--key", help="Secret key K (hex)", type=str, required=True) + auth_p.add_argument("-o", "--opc", help="Secret OPc (hex)", type=str, required=True) + auth_p.add_argument("-a", "--amf", help="AMF Field (hex)", type=str, default="0000") + auth_p.add_argument("-s", "--sqn", help="SQN Field (hex)", type=str, default="000000000000") + auth_p.set_defaults(func=main_auth) + + info_p = subp.add_parser('info', help='Information about the Card') + info_p.set_defaults(func=main_info) + + args = parser.parse_args() + server_host = args.host + server_port = args.port + verbose = args.verbose + args.func(args) + + if __name__ == "__main__": main(sys.argv) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2a13033b1d3e009a841579184f4ad39101f94d0 Gerrit-Change-Number: 26086 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:36:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:36:57 +0000 Subject: Change in pysim[master]: sim-rest-client: Errors are plain text, not JSON In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26084 ) Change subject: sim-rest-client: Errors are plain text, not JSON ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iafa5d1fc20b2b9ea8d9c828fc3c7e8490d0c3693 Gerrit-Change-Number: 26084 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 11:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:37:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:37:10 +0000 Subject: Change in pysim[master]: sim-rest-server: Add capability to obtain IMSI + ICCID of card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26085 ) Change subject: sim-rest-server: Add capability to obtain IMSI + ICCID of card ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9df8854f6a962e7f86f62b2d44ec7696271c58c8 Gerrit-Change-Number: 26085 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 11:37:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:37:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:37:17 +0000 Subject: Change in pysim[master]: sim-rest-client: Add support for 'info' command to get IMSI+ICCID In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26086 ) Change subject: sim-rest-client: Add support for 'info' command to get IMSI+ICCID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2a13033b1d3e009a841579184f4ad39101f94d0 Gerrit-Change-Number: 26086 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 11:37:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:38:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:38:28 +0000 Subject: Change in pysim[master]: sim-rest-client: Errors are plain text, not JSON In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26084 ) Change subject: sim-rest-client: Errors are plain text, not JSON ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iafa5d1fc20b2b9ea8d9c828fc3c7e8490d0c3693 Gerrit-Change-Number: 26084 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 11:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:38:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:38:31 +0000 Subject: Change in pysim[master]: sim-rest-server: Add capability to obtain IMSI + ICCID of card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26085 ) Change subject: sim-rest-server: Add capability to obtain IMSI + ICCID of card ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9df8854f6a962e7f86f62b2d44ec7696271c58c8 Gerrit-Change-Number: 26085 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 11:38:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:38:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:38:33 +0000 Subject: Change in pysim[master]: sim-rest-client: Add support for 'info' command to get IMSI+ICCID In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26086 ) Change subject: sim-rest-client: Add support for 'info' command to get IMSI+ICCID ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2a13033b1d3e009a841579184f4ad39101f94d0 Gerrit-Change-Number: 26086 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 11:38:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:38:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:38:35 +0000 Subject: Change in pysim[master]: sim-rest-client: Errors are plain text, not JSON In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26084 ) Change subject: sim-rest-client: Errors are plain text, not JSON ...................................................................... sim-rest-client: Errors are plain text, not JSON don't try to decode JSON where there is none. Change-Id: Iafa5d1fc20b2b9ea8d9c828fc3c7e8490d0c3693 --- M contrib/sim-rest-client.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py index 8f74adc..512765b 100755 --- a/contrib/sim-rest-client.py +++ b/contrib/sim-rest-client.py @@ -128,6 +128,9 @@ req_json = {'rand': rand.hex(), 'autn': t['autn'].hex()} print("-> %s" % req_json) resp = rest_post('/slot/%u' % args.slot_nr, req_json) + if not resp.ok: + print("<- ERROR %u: %s" % (resp.status_code, resp.text)) + break resp_json = resp.json() print("<- %s" % resp_json) if 'synchronisation_failure' in resp_json: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iafa5d1fc20b2b9ea8d9c828fc3c7e8490d0c3693 Gerrit-Change-Number: 26084 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:38:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:38:35 +0000 Subject: Change in pysim[master]: sim-rest-server: Add capability to obtain IMSI + ICCID of card In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26085 ) Change subject: sim-rest-server: Add capability to obtain IMSI + ICCID of card ...................................................................... sim-rest-server: Add capability to obtain IMSI + ICCID of card $ curl http://localhost:8000/sim-info-api/v1/slot/0 { "imsi": "262011500776110", "iccid": "89490240001879910128" } Change-Id: I9df8854f6a962e7f86f62b2d44ec7696271c58c8 --- M contrib/sim-rest-server.py 1 file changed, 50 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/contrib/sim-rest-server.py b/contrib/sim-rest-server.py index 0f77dfe..fb73ef8 100755 --- a/contrib/sim-rest-server.py +++ b/contrib/sim-rest-server.py @@ -34,6 +34,23 @@ #print("CMD: %s -> RSP: %s %s" % (cmd, sw, resp)) pass +def connect_to_card(slot_nr:int): + tp = PcscSimLink(slot_nr, apdu_tracer=ApduPrintTracer()) + tp.connect() + + scc = SimCardCommands(tp) + card = UsimCard(scc) + + # this should be part of UsimCard, but FairewavesSIM breaks with that :/ + scc.cla_byte = "00" + scc.sel_ctrl = "0004" + + card.read_aids() + card.select_adf_by_aid(adf='usim') + + return tp, scc, card + + @route('/sim-auth-api/v1/slot/') def auth(request, slot): """REST API endpoint for performing authentication against a USIM. @@ -49,8 +66,7 @@ return "Malformed Request" try: - tp = PcscSimLink(slot, apdu_tracer=ApduPrintTracer()) - tp.connect() + tp, scc, card = connect_to_card(slot) except ReaderError: request.setResponseCode(404) return "Specified SIM Slot doesn't exist" @@ -61,13 +77,7 @@ request.setResponseCode(410) return "No SIM card inserted in slot" - scc = SimCardCommands(tp) - card = UsimCard(scc) - # this should be part of UsimCard, but FairewavesSIM breaks with that :/ - scc.cla_byte = "00" - scc.sel_ctrl = "0004" try: - card.read_aids() card.select_adf_by_aid(adf='usim') res, sw = scc.authenticate(rand, autn) except SwMatchError as e: @@ -78,6 +88,38 @@ return json.dumps(res, indent=4) + at route('/sim-info-api/v1/slot/') +def info(request, slot): + """REST API endpoint for obtaining information about an USIM. + Expects empty body in request. + Returns a JSON body containing ICCID, IMSI.""" + + try: + tp, scc, card = connect_to_card(slot) + except ReaderError: + request.setResponseCode(404) + return "Specified SIM Slot doesn't exist" + except ProtocolError: + request.setResponseCode(500) + return "Error" + except NoCardError: + request.setResponseCode(410) + return "No SIM card inserted in slot" + + try: + card.select_adf_by_aid(adf='usim') + iccid, sw = card.read_iccid() + imsi, sw = card.read_imsi() + res = {"imsi": imsi, "iccid": iccid } + except SwMatchError as e: + request.setResponseCode(500) + return "Communication Error %s" % e + + tp.disconnect() + + return json.dumps(res, indent=4) + + def main(argv): parser = argparse.ArgumentParser() parser.add_argument("-H", "--host", help="Host/IP to bind HTTP to", default="localhost") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9df8854f6a962e7f86f62b2d44ec7696271c58c8 Gerrit-Change-Number: 26085 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:38:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:38:36 +0000 Subject: Change in pysim[master]: sim-rest-client: Add support for 'info' command to get IMSI+ICCID In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26086 ) Change subject: sim-rest-client: Add support for 'info' command to get IMSI+ICCID ...................................................................... sim-rest-client: Add support for 'info' command to get IMSI+ICCID Change-Id: Ia2a13033b1d3e009a841579184f4ad39101f94d0 --- M contrib/sim-rest-client.py 1 file changed, 49 insertions(+), 22 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py index 512765b..7da2363 100755 --- a/contrib/sim-rest-client.py +++ b/contrib/sim-rest-client.py @@ -73,10 +73,9 @@ return False -def build_url(suffix:str) -> str: +def build_url(suffix:str, base_path="/sim-auth-api/v1") -> str: """Build an URL from global server_host, server_port, BASE_PATH and suffix.""" - BASE_PATH= "/sim-auth-api/v1" - return "http://%s:%u%s%s" % (server_host, server_port, BASE_PATH, suffix) + return "http://%s:%u%s%s" % (server_host, server_port, base_path, suffix) def rest_post(suffix:str, js:Optional[dict] = None): @@ -91,29 +90,29 @@ print("POST failed") return resp +def rest_get(suffix:str, base_path=None): + """Perform a RESTful GET.""" + url = build_url(suffix, base_path) + if verbose: + print("GET %s" % url) + resp = requests.get(url) + if verbose: + print("-> %s" % (resp)) + if not resp.ok: + print("GET failed") + return resp -def main(argv): - global server_port, server_host, verbose +def main_info(args): + resp = rest_get('/slot/%u' % args.slot_nr, base_path="/sim-info-api/v1") + if not resp.ok: + print("<- ERROR %u: %s" % (resp.status_code, resp.text)) + sys.exit(1) + resp_json = resp.json() + print("<- %s" % resp_json) - parser = argparse.ArgumentParser() - parser.add_argument("-H", "--host", help="Host to connect to", default="localhost") - parser.add_argument("-p", "--port", help="TCP port to connect to", default=8000) - parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0) - parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, default=0) - parser.add_argument("-c", "--count", help="Auth count", type=int, default=10) - parser.add_argument("-k", "--key", help="Secret key K (hex)", type=str, required=True) - parser.add_argument("-o", "--opc", help="Secret OPc (hex)", type=str, required=True) - parser.add_argument("-a", "--amf", help="AMF Field (hex)", type=str, default="0000") - parser.add_argument("-s", "--sqn", help="SQN Field (hex)", type=str, default="000000000000") - - args = parser.parse_args() - - server_host = args.host - server_port = args.port - verbose = args.verbose - +def main_auth(args): #opc = bytes.fromhex('767A662ACF4587EB0C450C6A95540A04') #k = bytes.fromhex('876B2D8D403EE96755BEF3E0A1857EBE') opc = bytes.fromhex(args.opc) @@ -154,5 +153,33 @@ raise RuntimeError("Auth failure") +def main(argv): + global server_port, server_host, verbose + + parser = argparse.ArgumentParser() + parser.add_argument("-H", "--host", help="Host to connect to", default="localhost") + parser.add_argument("-p", "--port", help="TCP port to connect to", default=8000) + parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0) + parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, default=0) + subp = parser.add_subparsers() + + auth_p = subp.add_parser('auth', help='UMTS AKA Authentication') + auth_p.add_argument("-c", "--count", help="Auth count", type=int, default=10) + auth_p.add_argument("-k", "--key", help="Secret key K (hex)", type=str, required=True) + auth_p.add_argument("-o", "--opc", help="Secret OPc (hex)", type=str, required=True) + auth_p.add_argument("-a", "--amf", help="AMF Field (hex)", type=str, default="0000") + auth_p.add_argument("-s", "--sqn", help="SQN Field (hex)", type=str, default="000000000000") + auth_p.set_defaults(func=main_auth) + + info_p = subp.add_parser('info', help='Information about the Card') + info_p.set_defaults(func=main_info) + + args = parser.parse_args() + server_host = args.host + server_port = args.port + verbose = args.verbose + args.func(args) + + if __name__ == "__main__": main(sys.argv) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2a13033b1d3e009a841579184f4ad39101f94d0 Gerrit-Change-Number: 26086 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:40:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 11:40:45 +0000 Subject: Change in osmo-hnodeb[master]: d/control, spec: add missing builddeps In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 ) Change subject: d/control, spec: add missing builddeps ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If9ff232844d72094fb883700185ae152ca40493d Gerrit-Change-Number: 26065 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 11:40:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:41:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 11:41:17 +0000 Subject: Change in osmo-iuh[master]: contrib/osmo-iuh.spec: fix missing ldconfig lines In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26082 ) Change subject: contrib/osmo-iuh.spec: fix missing ldconfig lines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I898aa67dbc7deaa9a8235f508a34dd29cc83b385 Gerrit-Change-Number: 26082 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 11:41:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:50:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:50:29 +0000 Subject: Change in pysim[master]: sim-rest-server: Add example systemd service/unit file References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26087 ) Change subject: sim-rest-server: Add example systemd service/unit file ...................................................................... sim-rest-server: Add example systemd service/unit file the sim-rest-server is a minimal HTTP/RESTful API for performing UMTS-AKA against a SIM card inserted in a locally reachable PC/SC reader. Let's add s systemd service/unit file for people wanting to run this service from systemd. Change-Id: I84b390af09d33de2c740898ff3d7d5a90a300588 --- A contrib/sim-rest-server.service 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/26087/1 diff --git a/contrib/sim-rest-server.service b/contrib/sim-rest-server.service new file mode 100644 index 0000000..f062611 --- /dev/null +++ b/contrib/sim-rest-server.service @@ -0,0 +1,14 @@ +[Unit] +Description=Osmocom SIM REST server + +[Service] +Type=simple +# we listen to 0.0.0.0, allowing remote, unauthenticated clients to connect from everywhere! +ExecStart=/usr/local/src/pysim/contrib/sim-rest-server.py -H 0.0.0.0 +Restart=always +RestartSec=2 +# this user must be created beforehand; it must have PC/SC access +User=rest + +[Install] +WantedBy=multi-user.target -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I84b390af09d33de2c740898ff3d7d5a90a300588 Gerrit-Change-Number: 26087 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:56:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:56:19 +0000 Subject: Change in pysim[master]: sim-rest-server: Add example systemd service/unit file In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26087 ) Change subject: sim-rest-server: Add example systemd service/unit file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I84b390af09d33de2c740898ff3d7d5a90a300588 Gerrit-Change-Number: 26087 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 11:56:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 11:58:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 11:58:47 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py at 148 PS2, Line 148: data, sw = self._tp.send_apdu_checksw(pdu) > I wasn't sure if the context info about offset and len is useful at all. Its now added again. [?] side note: I think if the export command relies on no CR/LF in an exception text, then it should itself make sure to filter out such line breaks to make sure it is not generating unreadable export scripts. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 11:58:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 12:02:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 12:02:39 +0000 Subject: Change in pysim[master]: pySim-shell: add method to probe for UICC In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 4: Code-Review+1 I'm happy to merge the patch as it is an improvement. Howeve, I think a proper solution is to move all of that detection logic into the various CardProfile etc. classes. So the main application code of pySim-shell should really only call one (classmethod?) to perform autodetection aof card profiles, which would then iterate of all subclasses of CardProfile, call their autodetect method, which would do whatever it needs to do, etc. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 12:02:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 12:27:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 12:27:39 +0000 Subject: Change in pysim[master]: sim-rest-server: Add example systemd service/unit file In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26087 ) Change subject: sim-rest-server: Add example systemd service/unit file ...................................................................... sim-rest-server: Add example systemd service/unit file the sim-rest-server is a minimal HTTP/RESTful API for performing UMTS-AKA against a SIM card inserted in a locally reachable PC/SC reader. Let's add s systemd service/unit file for people wanting to run this service from systemd. Change-Id: I84b390af09d33de2c740898ff3d7d5a90a300588 --- A contrib/sim-rest-server.service 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/sim-rest-server.service b/contrib/sim-rest-server.service new file mode 100644 index 0000000..f062611 --- /dev/null +++ b/contrib/sim-rest-server.service @@ -0,0 +1,14 @@ +[Unit] +Description=Osmocom SIM REST server + +[Service] +Type=simple +# we listen to 0.0.0.0, allowing remote, unauthenticated clients to connect from everywhere! +ExecStart=/usr/local/src/pysim/contrib/sim-rest-server.py -H 0.0.0.0 +Restart=always +RestartSec=2 +# this user must be created beforehand; it must have PC/SC access +User=rest + +[Install] +WantedBy=multi-user.target -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I84b390af09d33de2c740898ff3d7d5a90a300588 Gerrit-Change-Number: 26087 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 12:28:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 12:28:00 +0000 Subject: Change in pysim[master]: commands: return none, when offset exceeds file length In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26083 ) Change subject: commands: return none, when offset exceeds file length ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2c017c620254fae188022851ef3b670730aab503 Gerrit-Change-Number: 26083 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 12:28:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 12:29:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 12:29:18 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 12:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 12:29:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 12:29:31 +0000 Subject: Change in osmo-sip-connector[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/25980 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/25980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Iaff46732948f8f5d03e42f17c35cbac8a80af49b Gerrit-Change-Number: 25980 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 12:29:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 12:34:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 12:34:58 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > That being said, I'm happy to hear opinions from others, I'm open to comments and I'll accept whatever the consensus ends up being. as often the case, I see pros and cons on both side of the argument. Unfortuantely I don't have any deep operational insight into performance monitoring, nor modern tools like grafana, etc. so I absolutely don't understand enough to make decision without spending at least half a day [probably more] reading up and thinking about it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 12:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 12:35:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 12:35:04 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 12:35:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 14:30:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 14:30:06 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Nov 2021 14:30:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 14:38:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Nov 2021 14:38:10 +0000 Subject: Change in pysim[master]: pySim-shell: add method to probe for UICC In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 4: (2 comments) two nitpicks, otherwise LGTM https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py at 85 PS4, Line 85: ; lines don't end with ";" in python https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py at 109 PS4, Line 109: SIM word repeated -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 14:38:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 15:18:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 15:18:45 +0000 Subject: Change in osmo-mgw[master]: add modified .clang-format In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25460 ) Change subject: add modified .clang-format ...................................................................... add modified .clang-format Adjusted ColumnLimit: 80 -> 120 Added ForEachMacros: - 'for_each_line' - 'for_each_non_empty_line' Change-Id: I080cf2d2437d0b8e6190fbd7c01af8cdc9420878 --- A .clang-format 1 file changed, 563 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/.clang-format b/.clang-format new file mode 100644 index 0000000..5d4791c --- /dev/null +++ b/.clang-format @@ -0,0 +1,563 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# clang-format configuration file. Intended for clang-format >= 4. +# +# For more information, see: +# +# Documentation/process/clang-format.rst +# https://clang.llvm.org/docs/ClangFormat.html +# https://clang.llvm.org/docs/ClangFormatStyleOptions.html +# +--- +AccessModifierOffset: -4 +AlignAfterOpenBracket: Align +AlignConsecutiveAssignments: false +AlignConsecutiveDeclarations: false +#AlignEscapedNewlines: Left # Unknown to clang-format-4.0 +AlignOperands: true +AlignTrailingComments: false +AllowAllParametersOfDeclarationOnNextLine: false +AllowShortBlocksOnASingleLine: false +AllowShortCaseLabelsOnASingleLine: false +AllowShortFunctionsOnASingleLine: None +AllowShortIfStatementsOnASingleLine: false +AllowShortLoopsOnASingleLine: false +AlwaysBreakAfterDefinitionReturnType: None +AlwaysBreakAfterReturnType: None +AlwaysBreakBeforeMultilineStrings: false +AlwaysBreakTemplateDeclarations: false +BinPackArguments: true +BinPackParameters: true +BraceWrapping: + AfterClass: false + AfterControlStatement: false + AfterEnum: false + AfterFunction: true + AfterNamespace: true + AfterObjCDeclaration: false + AfterStruct: false + AfterUnion: false + #AfterExternBlock: false # Unknown to clang-format-5.0 + BeforeCatch: false + BeforeElse: false + IndentBraces: false + #SplitEmptyFunction: true # Unknown to clang-format-4.0 + #SplitEmptyRecord: true # Unknown to clang-format-4.0 + #SplitEmptyNamespace: true # Unknown to clang-format-4.0 +BreakBeforeBinaryOperators: None +BreakBeforeBraces: Custom +#BreakBeforeInheritanceComma: false # Unknown to clang-format-4.0 +BreakBeforeTernaryOperators: false +BreakConstructorInitializersBeforeComma: false +#BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0 +BreakAfterJavaFieldAnnotations: false +BreakStringLiterals: false +ColumnLimit: 120 +CommentPragmas: '^ IWYU pragma:' +#CompactNamespaces: false # Unknown to clang-format-4.0 +ConstructorInitializerAllOnOneLineOrOnePerLine: false +ConstructorInitializerIndentWidth: 8 +ContinuationIndentWidth: 8 +Cpp11BracedListStyle: false +DerivePointerAlignment: false +DisableFormat: false +ExperimentalAutoDetectBinPacking: false +#FixNamespaceComments: false # Unknown to clang-format-4.0 + +# Taken from: +# git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' include/ \ +# | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$, - '\1'," \ +# | sort | uniq +ForEachMacros: + - 'apei_estatus_for_each_section' + - 'ata_for_each_dev' + - 'ata_for_each_link' + - '__ata_qc_for_each' + - 'ata_qc_for_each' + - 'ata_qc_for_each_raw' + - 'ata_qc_for_each_with_internal' + - 'ax25_for_each' + - 'ax25_uid_for_each' + - '__bio_for_each_bvec' + - 'bio_for_each_bvec' + - 'bio_for_each_bvec_all' + - 'bio_for_each_integrity_vec' + - '__bio_for_each_segment' + - 'bio_for_each_segment' + - 'bio_for_each_segment_all' + - 'bio_list_for_each' + - 'bip_for_each_vec' + - 'bitmap_for_each_clear_region' + - 'bitmap_for_each_set_region' + - 'blkg_for_each_descendant_post' + - 'blkg_for_each_descendant_pre' + - 'blk_queue_for_each_rl' + - 'bond_for_each_slave' + - 'bond_for_each_slave_rcu' + - 'bpf_for_each_spilled_reg' + - 'btree_for_each_safe128' + - 'btree_for_each_safe32' + - 'btree_for_each_safe64' + - 'btree_for_each_safel' + - 'card_for_each_dev' + - 'cgroup_taskset_for_each' + - 'cgroup_taskset_for_each_leader' + - 'cpufreq_for_each_entry' + - 'cpufreq_for_each_entry_idx' + - 'cpufreq_for_each_valid_entry' + - 'cpufreq_for_each_valid_entry_idx' + - 'css_for_each_child' + - 'css_for_each_descendant_post' + - 'css_for_each_descendant_pre' + - 'device_for_each_child_node' + - 'displayid_iter_for_each' + - 'dma_fence_chain_for_each' + - 'do_for_each_ftrace_op' + - 'drm_atomic_crtc_for_each_plane' + - 'drm_atomic_crtc_state_for_each_plane' + - 'drm_atomic_crtc_state_for_each_plane_state' + - 'drm_atomic_for_each_plane_damage' + - 'drm_client_for_each_connector_iter' + - 'drm_client_for_each_modeset' + - 'drm_connector_for_each_possible_encoder' + - 'drm_for_each_bridge_in_chain' + - 'drm_for_each_connector_iter' + - 'drm_for_each_crtc' + - 'drm_for_each_crtc_reverse' + - 'drm_for_each_encoder' + - 'drm_for_each_encoder_mask' + - 'drm_for_each_fb' + - 'drm_for_each_legacy_plane' + - 'drm_for_each_plane' + - 'drm_for_each_plane_mask' + - 'drm_for_each_privobj' + - 'drm_mm_for_each_hole' + - 'drm_mm_for_each_node' + - 'drm_mm_for_each_node_in_range' + - 'drm_mm_for_each_node_safe' + - 'flow_action_for_each' + - 'for_each_acpi_dev_match' + - 'for_each_active_dev_scope' + - 'for_each_active_drhd_unit' + - 'for_each_active_iommu' + - 'for_each_aggr_pgid' + - 'for_each_available_child_of_node' + - 'for_each_bio' + - 'for_each_board_func_rsrc' + - 'for_each_bvec' + - 'for_each_card_auxs' + - 'for_each_card_auxs_safe' + - 'for_each_card_components' + - 'for_each_card_dapms' + - 'for_each_card_pre_auxs' + - 'for_each_card_prelinks' + - 'for_each_card_rtds' + - 'for_each_card_rtds_safe' + - 'for_each_card_widgets' + - 'for_each_card_widgets_safe' + - 'for_each_cgroup_storage_type' + - 'for_each_child_of_node' + - 'for_each_clear_bit' + - 'for_each_clear_bit_from' + - 'for_each_cmsghdr' + - 'for_each_compatible_node' + - 'for_each_component_dais' + - 'for_each_component_dais_safe' + - 'for_each_comp_order' + - 'for_each_console' + - 'for_each_cpu' + - 'for_each_cpu_and' + - 'for_each_cpu_not' + - 'for_each_cpu_wrap' + - 'for_each_dapm_widgets' + - 'for_each_dev_addr' + - 'for_each_dev_scope' + - 'for_each_dma_cap_mask' + - 'for_each_dpcm_be' + - 'for_each_dpcm_be_rollback' + - 'for_each_dpcm_be_safe' + - 'for_each_dpcm_fe' + - 'for_each_drhd_unit' + - 'for_each_dss_dev' + - 'for_each_dtpm_table' + - 'for_each_efi_memory_desc' + - 'for_each_efi_memory_desc_in_map' + - 'for_each_element' + - 'for_each_element_extid' + - 'for_each_element_id' + - 'for_each_endpoint_of_node' + - 'for_each_evictable_lru' + - 'for_each_fib6_node_rt_rcu' + - 'for_each_fib6_walker_rt' + - 'for_each_free_mem_pfn_range_in_zone' + - 'for_each_free_mem_pfn_range_in_zone_from' + - 'for_each_free_mem_range' + - 'for_each_free_mem_range_reverse' + - 'for_each_func_rsrc' + - 'for_each_hstate' + - 'for_each_if' + - 'for_each_iommu' + - 'for_each_ip_tunnel_rcu' + - 'for_each_irq_nr' + - 'for_each_link_codecs' + - 'for_each_link_cpus' + - 'for_each_link_platforms' + - 'for_each_lru' + - 'for_each_matching_node' + - 'for_each_matching_node_and_match' + - 'for_each_member' + - 'for_each_memcg_cache_index' + - 'for_each_mem_pfn_range' + - '__for_each_mem_range' + - 'for_each_mem_range' + - '__for_each_mem_range_rev' + - 'for_each_mem_range_rev' + - 'for_each_mem_region' + - 'for_each_migratetype_order' + - 'for_each_msi_entry' + - 'for_each_msi_entry_safe' + - 'for_each_msi_vector' + - 'for_each_net' + - 'for_each_net_continue_reverse' + - 'for_each_netdev' + - 'for_each_netdev_continue' + - 'for_each_netdev_continue_rcu' + - 'for_each_netdev_continue_reverse' + - 'for_each_netdev_feature' + - 'for_each_netdev_in_bond_rcu' + - 'for_each_netdev_rcu' + - 'for_each_netdev_reverse' + - 'for_each_netdev_safe' + - 'for_each_net_rcu' + - 'for_each_new_connector_in_state' + - 'for_each_new_crtc_in_state' + - 'for_each_new_mst_mgr_in_state' + - 'for_each_new_plane_in_state' + - 'for_each_new_private_obj_in_state' + - 'for_each_node' + - 'for_each_node_by_name' + - 'for_each_node_by_type' + - 'for_each_node_mask' + - 'for_each_node_state' + - 'for_each_node_with_cpus' + - 'for_each_node_with_property' + - 'for_each_nonreserved_multicast_dest_pgid' + - 'for_each_of_allnodes' + - 'for_each_of_allnodes_from' + - 'for_each_of_cpu_node' + - 'for_each_of_pci_range' + - 'for_each_old_connector_in_state' + - 'for_each_old_crtc_in_state' + - 'for_each_old_mst_mgr_in_state' + - 'for_each_oldnew_connector_in_state' + - 'for_each_oldnew_crtc_in_state' + - 'for_each_oldnew_mst_mgr_in_state' + - 'for_each_oldnew_plane_in_state' + - 'for_each_oldnew_plane_in_state_reverse' + - 'for_each_oldnew_private_obj_in_state' + - 'for_each_old_plane_in_state' + - 'for_each_old_private_obj_in_state' + - 'for_each_online_cpu' + - 'for_each_online_node' + - 'for_each_online_pgdat' + - 'for_each_pci_bridge' + - 'for_each_pci_dev' + - 'for_each_pci_msi_entry' + - 'for_each_pcm_streams' + - 'for_each_physmem_range' + - 'for_each_populated_zone' + - 'for_each_possible_cpu' + - 'for_each_present_cpu' + - 'for_each_prime_number' + - 'for_each_prime_number_from' + - 'for_each_process' + - 'for_each_process_thread' + - 'for_each_prop_codec_conf' + - 'for_each_prop_dai_codec' + - 'for_each_prop_dai_cpu' + - 'for_each_prop_dlc_codecs' + - 'for_each_prop_dlc_cpus' + - 'for_each_prop_dlc_platforms' + - 'for_each_property_of_node' + - 'for_each_registered_fb' + - 'for_each_requested_gpio' + - 'for_each_requested_gpio_in_range' + - 'for_each_reserved_mem_range' + - 'for_each_reserved_mem_region' + - 'for_each_rtd_codec_dais' + - 'for_each_rtd_components' + - 'for_each_rtd_cpu_dais' + - 'for_each_rtd_dais' + - 'for_each_set_bit' + - 'for_each_set_bit_from' + - 'for_each_set_clump8' + - 'for_each_sg' + - 'for_each_sg_dma_page' + - 'for_each_sg_page' + - 'for_each_sgtable_dma_page' + - 'for_each_sgtable_dma_sg' + - 'for_each_sgtable_page' + - 'for_each_sgtable_sg' + - 'for_each_sibling_event' + - 'for_each_subelement' + - 'for_each_subelement_extid' + - 'for_each_subelement_id' + - '__for_each_thread' + - 'for_each_thread' + - 'for_each_unicast_dest_pgid' + - 'for_each_vsi' + - 'for_each_wakeup_source' + - 'for_each_zone' + - 'for_each_zone_zonelist' + - 'for_each_zone_zonelist_nodemask' + - 'fwnode_for_each_available_child_node' + - 'fwnode_for_each_child_node' + - 'fwnode_graph_for_each_endpoint' + - 'gadget_for_each_ep' + - 'genradix_for_each' + - 'genradix_for_each_from' + - 'hash_for_each' + - 'hash_for_each_possible' + - 'hash_for_each_possible_rcu' + - 'hash_for_each_possible_rcu_notrace' + - 'hash_for_each_possible_safe' + - 'hash_for_each_rcu' + - 'hash_for_each_safe' + - 'hctx_for_each_ctx' + - 'hlist_bl_for_each_entry' + - 'hlist_bl_for_each_entry_rcu' + - 'hlist_bl_for_each_entry_safe' + - 'hlist_for_each' + - 'hlist_for_each_entry' + - 'hlist_for_each_entry_continue' + - 'hlist_for_each_entry_continue_rcu' + - 'hlist_for_each_entry_continue_rcu_bh' + - 'hlist_for_each_entry_from' + - 'hlist_for_each_entry_from_rcu' + - 'hlist_for_each_entry_rcu' + - 'hlist_for_each_entry_rcu_bh' + - 'hlist_for_each_entry_rcu_notrace' + - 'hlist_for_each_entry_safe' + - 'hlist_for_each_entry_srcu' + - '__hlist_for_each_rcu' + - 'hlist_for_each_safe' + - 'hlist_nulls_for_each_entry' + - 'hlist_nulls_for_each_entry_from' + - 'hlist_nulls_for_each_entry_rcu' + - 'hlist_nulls_for_each_entry_safe' + - 'i3c_bus_for_each_i2cdev' + - 'i3c_bus_for_each_i3cdev' + - 'ide_host_for_each_port' + - 'ide_port_for_each_dev' + - 'ide_port_for_each_present_dev' + - 'idr_for_each_entry' + - 'idr_for_each_entry_continue' + - 'idr_for_each_entry_continue_ul' + - 'idr_for_each_entry_ul' + - 'in_dev_for_each_ifa_rcu' + - 'in_dev_for_each_ifa_rtnl' + - 'inet_bind_bucket_for_each' + - 'inet_lhash2_for_each_icsk_rcu' + - 'key_for_each' + - 'key_for_each_safe' + - 'klp_for_each_func' + - 'klp_for_each_func_safe' + - 'klp_for_each_func_static' + - 'klp_for_each_object' + - 'klp_for_each_object_safe' + - 'klp_for_each_object_static' + - 'kunit_suite_for_each_test_case' + - 'kvm_for_each_memslot' + - 'kvm_for_each_vcpu' + - 'list_for_each' + - 'list_for_each_codec' + - 'list_for_each_codec_safe' + - 'list_for_each_continue' + - 'list_for_each_entry' + - 'list_for_each_entry_continue' + - 'list_for_each_entry_continue_rcu' + - 'list_for_each_entry_continue_reverse' + - 'list_for_each_entry_from' + - 'list_for_each_entry_from_rcu' + - 'list_for_each_entry_from_reverse' + - 'list_for_each_entry_lockless' + - 'list_for_each_entry_rcu' + - 'list_for_each_entry_reverse' + - 'list_for_each_entry_safe' + - 'list_for_each_entry_safe_continue' + - 'list_for_each_entry_safe_from' + - 'list_for_each_entry_safe_reverse' + - 'list_for_each_entry_srcu' + - 'list_for_each_prev' + - 'list_for_each_prev_safe' + - 'list_for_each_safe' + - 'llist_for_each' + - 'llist_for_each_entry' + - 'llist_for_each_entry_safe' + - 'llist_for_each_safe' + - 'mci_for_each_dimm' + - 'media_device_for_each_entity' + - 'media_device_for_each_intf' + - 'media_device_for_each_link' + - 'media_device_for_each_pad' + - 'nanddev_io_for_each_page' + - 'netdev_for_each_lower_dev' + - 'netdev_for_each_lower_private' + - 'netdev_for_each_lower_private_rcu' + - 'netdev_for_each_mc_addr' + - 'netdev_for_each_uc_addr' + - 'netdev_for_each_upper_dev_rcu' + - 'netdev_hw_addr_list_for_each' + - 'nft_rule_for_each_expr' + - 'nla_for_each_attr' + - 'nla_for_each_nested' + - 'nlmsg_for_each_attr' + - 'nlmsg_for_each_msg' + - 'nr_neigh_for_each' + - 'nr_neigh_for_each_safe' + - 'nr_node_for_each' + - 'nr_node_for_each_safe' + - 'of_for_each_phandle' + - 'of_property_for_each_string' + - 'of_property_for_each_u32' + - 'pci_bus_for_each_resource' + - 'pcl_for_each_chunk' + - 'pcl_for_each_segment' + - 'pcm_for_each_format' + - 'ping_portaddr_for_each_entry' + - 'plist_for_each' + - 'plist_for_each_continue' + - 'plist_for_each_entry' + - 'plist_for_each_entry_continue' + - 'plist_for_each_entry_safe' + - 'plist_for_each_safe' + - 'pnp_for_each_card' + - 'pnp_for_each_dev' + - 'protocol_for_each_card' + - 'protocol_for_each_dev' + - 'queue_for_each_hw_ctx' + - 'radix_tree_for_each_slot' + - 'radix_tree_for_each_tagged' + - 'rb_for_each' + - 'rbtree_postorder_for_each_entry_safe' + - 'rdma_for_each_block' + - 'rdma_for_each_port' + - 'rdma_umem_for_each_dma_block' + - 'resource_list_for_each_entry' + - 'resource_list_for_each_entry_safe' + - 'rhl_for_each_entry_rcu' + - 'rhl_for_each_rcu' + - 'rht_for_each' + - 'rht_for_each_entry' + - 'rht_for_each_entry_from' + - 'rht_for_each_entry_rcu' + - 'rht_for_each_entry_rcu_from' + - 'rht_for_each_entry_safe' + - 'rht_for_each_from' + - 'rht_for_each_rcu' + - 'rht_for_each_rcu_from' + - '__rq_for_each_bio' + - 'rq_for_each_bvec' + - 'rq_for_each_segment' + - 'scsi_for_each_prot_sg' + - 'scsi_for_each_sg' + - 'sctp_for_each_hentry' + - 'sctp_skb_for_each' + - 'shdma_for_each_chan' + - '__shost_for_each_device' + - 'shost_for_each_device' + - 'sk_for_each' + - 'sk_for_each_bound' + - 'sk_for_each_entry_offset_rcu' + - 'sk_for_each_from' + - 'sk_for_each_rcu' + - 'sk_for_each_safe' + - 'sk_nulls_for_each' + - 'sk_nulls_for_each_from' + - 'sk_nulls_for_each_rcu' + - 'snd_array_for_each' + - 'snd_pcm_group_for_each_entry' + - 'snd_soc_dapm_widget_for_each_path' + - 'snd_soc_dapm_widget_for_each_path_safe' + - 'snd_soc_dapm_widget_for_each_sink_path' + - 'snd_soc_dapm_widget_for_each_source_path' + - 'tb_property_for_each' + - 'tcf_exts_for_each_action' + - 'udp_portaddr_for_each_entry' + - 'udp_portaddr_for_each_entry_rcu' + - 'usb_hub_for_each_child' + - 'v4l2_device_for_each_subdev' + - 'v4l2_m2m_for_each_dst_buf' + - 'v4l2_m2m_for_each_dst_buf_safe' + - 'v4l2_m2m_for_each_src_buf' + - 'v4l2_m2m_for_each_src_buf_safe' + - 'virtio_device_for_each_vq' + - 'while_for_each_ftrace_op' + - 'xa_for_each' + - 'xa_for_each_marked' + - 'xa_for_each_range' + - 'xa_for_each_start' + - 'xas_for_each' + - 'xas_for_each_conflict' + - 'xas_for_each_marked' + - 'xbc_array_for_each_value' + - 'xbc_for_each_key_value' + - 'xbc_node_for_each_array_value' + - 'xbc_node_for_each_child' + - 'xbc_node_for_each_key_value' + - 'zorro_for_each_dev' + - 'for_each_line' + - 'for_each_non_empty_line' + +#IncludeBlocks: Preserve # Unknown to clang-format-5.0 +IncludeCategories: + - Regex: '.*' + Priority: 1 +IncludeIsMainRegex: '(Test)?$' +IndentCaseLabels: false +#IndentPPDirectives: None # Unknown to clang-format-5.0 +IndentWidth: 8 +IndentWrappedFunctionNames: false +JavaScriptQuotes: Leave +JavaScriptWrapImports: true +KeepEmptyLinesAtTheStartOfBlocks: false +MacroBlockBegin: '' +MacroBlockEnd: '' +MaxEmptyLinesToKeep: 1 +NamespaceIndentation: None +#ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0 +ObjCBlockIndentWidth: 8 +ObjCSpaceAfterProperty: true +ObjCSpaceBeforeProtocolList: true + +# Taken from git's rules +#PenaltyBreakAssignment: 10 # Unknown to clang-format-4.0 +PenaltyBreakBeforeFirstCallParameter: 30 +PenaltyBreakComment: 10 +PenaltyBreakFirstLessLess: 0 +PenaltyBreakString: 10 +PenaltyExcessCharacter: 100 +PenaltyReturnTypeOnItsOwnLine: 60 + +PointerAlignment: Right +ReflowComments: false +SortIncludes: false +#SortUsingDeclarations: false # Unknown to clang-format-4.0 +SpaceAfterCStyleCast: false +SpaceAfterTemplateKeyword: true +SpaceBeforeAssignmentOperators: true +#SpaceBeforeCtorInitializerColon: true # Unknown to clang-format-5.0 +#SpaceBeforeInheritanceColon: true # Unknown to clang-format-5.0 +SpaceBeforeParens: ControlStatements +#SpaceBeforeRangeBasedForLoopColon: true # Unknown to clang-format-5.0 +SpaceInEmptyParentheses: false +SpacesBeforeTrailingComments: 1 +SpacesInAngles: false +SpacesInContainerLiterals: false +SpacesInCStyleCastParentheses: false +SpacesInParentheses: false +SpacesInSquareBrackets: false +Standard: Cpp03 +TabWidth: 8 +UseTab: Always +... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I080cf2d2437d0b8e6190fbd7c01af8cdc9420878 Gerrit-Change-Number: 25460 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 15:18:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 15:18:59 +0000 Subject: Change in osmo-mgw[master]: rename strip_epname and find_specific_endpoint and make them available In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25429 ) Change subject: rename strip_epname and find_specific_endpoint and make them available ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f76676640a308ab84da3848e1c1ec22bd5d9566 Gerrit-Change-Number: 25429 Gerrit-PatchSet: 17 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 15:18:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 15:19:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 15:19:13 +0000 Subject: Change in osmo-mgw[master]: rename strip_epname and find_specific_endpoint and make them available In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25429 ) Change subject: rename strip_epname and find_specific_endpoint and make them available ...................................................................... rename strip_epname and find_specific_endpoint and make them available Change-Id: I4f76676640a308ab84da3848e1c1ec22bd5d9566 --- M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/mgcp_endp.c 2 files changed, 20 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/mgcp/mgcp_endp.h b/include/osmocom/mgcp/mgcp_endp.h index b8796c1..91c4551 100644 --- a/include/osmocom/mgcp/mgcp_endp.h +++ b/include/osmocom/mgcp/mgcp_endp.h @@ -136,3 +136,7 @@ bool mgcp_endp_avail(struct mgcp_endpoint *endp); void mgcp_endp_add_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_remove_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); +void mgcp_endp_strip_name(char *epname_stripped, const char *epname, + const struct mgcp_trunk *trunk); +struct mgcp_endpoint *mgcp_endp_find_specific(const char *epname, + const struct mgcp_trunk *trunk); diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 19446ce..247baac 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -187,12 +187,16 @@ } } -/* Convert all characters in epname to lowercase and strip trunk prefix and + + /*! Convert all characters in epname to lowercase and strip trunk prefix and * endpoint name suffix (domain name) from epname. The result is written to * to the memory pointed at by epname_stripped. The expected size of the * result is either equal or lower then the length of the input string - * (epname) */ -static void strip_epname(char *epname_stripped, const char *epname, + * (epname) + * \param[out] epname_stripped pointer to store the stripped ep name. + * \param[in] epname endpoint name to lookup. + * \param[in] trunk where the endpoint is located. */ +void mgcp_endp_strip_name(char *epname_stripped, const char *epname, const struct mgcp_trunk *trunk) { osmo_str_tolower_buf(epname_stripped, MGCP_ENDPOINT_MAXLEN, epname); @@ -219,9 +223,11 @@ return NULL; } -/* Find an endpoint specified by its name. If the endpoint can not be found, - * return NULL */ -static struct mgcp_endpoint *find_specific_endpoint(const char *epname, +/*! Find an endpoint of a trunk specified by its name. + * \param[in] epname endpoint name to check + * \param[in] trunk mgcp_trunk that might have this endpoint + * \returns NULL if no ep found, else endpoint */ +struct mgcp_endpoint *mgcp_endp_find_specific(const char *epname, const struct mgcp_trunk *trunk) { char epname_stripped[MGCP_ENDPOINT_MAXLEN]; @@ -230,11 +236,11 @@ unsigned int i; /* Strip irrelevant information from the endpoint name */ - strip_epname(epname_stripped, epname, trunk); + mgcp_endp_strip_name(epname_stripped, epname, trunk); for (i = 0; i < trunk->number_endpoints; i++) { endp = trunk->endpoints[i]; - strip_epname(epname_stripped_endp, endp->name, trunk); + mgcp_endp_strip_name(epname_stripped_endp, endp->name, trunk); if (strcmp(epname_stripped_endp, epname_stripped) == 0) return endp; } @@ -289,7 +295,7 @@ /* Find an endpoint by its name (if wildcarded request is not * applicable) */ - endp = find_specific_endpoint(epname, trunk); + endp = mgcp_endp_find_specific(epname, trunk); if (endp) { LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "(trunk:%d) found endpoint: %s\n", @@ -540,7 +546,7 @@ epname_check = gen_e1_epname(endp, endp->trunk->cfg->domain, endp->trunk->trunk_nr, ts_nr, interlock[i]); - endp_check = find_specific_endpoint(epname_check, endp->trunk); + endp_check = mgcp_endp_find_specific(epname_check, endp->trunk); if (!endp_check) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "cannot check endpoint availability, overlapping endpoint:%s not found!\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f76676640a308ab84da3848e1c1ec22bd5d9566 Gerrit-Change-Number: 25429 Gerrit-PatchSet: 18 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 15:19:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 15:19:14 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25430 ) Change subject: fix mgcp_conn_free_all ...................................................................... fix mgcp_conn_free_all It calls itself recursively which messes with the list an ep, so ubsan complains. Change-Id: If38ead0ba0c28396df2332990c98b2532cf17d1c --- M src/libosmo-mgcp/mgcp_conn.c 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 4acf18c..4f6e1a2 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -328,12 +328,10 @@ void mgcp_conn_free_all(struct mgcp_endpoint *endp) { struct mgcp_conn *conn; - struct mgcp_conn *conn_tmp; - /* Drop all items in the list */ - llist_for_each_entry_safe(conn, conn_tmp, &endp->conns, entry) { + /* Drop all items in the list, might be consecutive! */ + while ((conn = llist_first_entry_or_null(&endp->conns, struct mgcp_conn, entry))) mgcp_conn_free(endp, conn->id); - } return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If38ead0ba0c28396df2332990c98b2532cf17d1c Gerrit-Change-Number: 25430 Gerrit-PatchSet: 19 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 16:03:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 16:03:29 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Drop impossible code path References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26088 ) Change subject: bts-trx: sched_lchan_tchf: Drop impossible code path ...................................................................... bts-trx: sched_lchan_tchf: Drop impossible code path It cannot happen that msg1 is NULL and msg2 is not null, since they are deuqueed from same place. Only possible combinations are: msg1!=NULL && msg2!=NULL msg1!=NULL && msg2==NULL Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/26088/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 20a4077..a6fcd7a 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -398,12 +398,6 @@ msg_tch = msg2; } } - } else if (msg2) { - l1sap = msgb_l1sap_prim(msg2); - if (l1sap->oph.primitive == PRIM_TCH) - msg_tch = msg2; - else - msg_facch = msg2; } /* check validity of message */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f Gerrit-Change-Number: 26088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 16:25:05 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 3 Nov 2021 16:25:05 +0000 Subject: Change in pysim[master]: pySim-shell: add method to probe for UICC In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 4: (2 comments) > Patch Set 4: Code-Review+1 > > I'm happy to merge the patch as it is an improvement. Howeve, I think a proper solution is to move all of that detection logic into the various CardProfile etc. classes. > > So the main application code of pySim-shell should really only call one (classmethod?) to perform autodetection aof card profiles, which would then iterate of all subclasses of CardProfile, call their autodetect method, which would do whatever it needs to do, etc. I think I get what you mean. I will move the detection into the profile classes - I put this into WIP until I am done with that. https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py at 85 PS4, Line 85: ; > lines don't end with ";" in python Thanks! There is no way to have this in the linter? python does not complain about it, so this goes unnoticed from time to time. https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py at 109 PS4, Line 109: SIM > word repeated Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 16:25:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 16:35:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 16:35:20 +0000 Subject: Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26089 ) Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... logging: Fix double lock of log_tgt_mutex Recent commit introduced the "blocking-io" param to "log stderr" VTY command, which calls log_target_file_switch_to_{stream,wqueue}. The VTY command already locks the log_tgt_mutex mutex, since it has to access the tgt list. However, the functions mention above also want to lock the same mutex in order to log information. Let's drop the logging to avoid the double lock, and update its documentation to mention it must be called with the lock already held, as documented on other similar functions. Fixes: b72867f0e68c96ca25e1f9929ce92be0a802db6b Related: OS#4311 Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 --- M src/logging.c 1 file changed, 6 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/26089/1 diff --git a/src/logging.c b/src/logging.c index 00d75c3..9e2f5c2 100644 --- a/src/logging.c +++ b/src/logging.c @@ -1090,34 +1090,21 @@ /*! switch from non-blocking/write-queue to blocking + buffered stream output * \param[in] target log target which we should switch - * \return 0 on success; 1 if already switched before; negative on error */ + * \return 0 on success; 1 if already switched before; negative on error + * Must be called with mutex osmo_log_tgt_mutex held, see log_tgt_mutex_lock. + */ int log_target_file_switch_to_stream(struct log_target *target) { struct osmo_wqueue *wq; - const char *name; if (!target) return -ENODEV; - /* this only works for file/stderr targets */ - switch (target->type) { - case LOG_TGT_TYPE_FILE: - name = target->tgt_file.fname; - break; - case LOG_TGT_TYPE_STDERR: - name = "stderr"; - break; - default: - return -EINVAL; - } - if (target->tgt_file.out) { /* target has already been switched over */ return 1; } - LOGP(DLGLOBAL, LOGL_INFO, "Switching log target '%s' to blocking stream I/O\n", name); - wq = target->tgt_file.wqueue; OSMO_ASSERT(wq); @@ -1127,8 +1114,6 @@ else target->tgt_file.out = fopen(target->tgt_file.fname, "a"); if (!target->tgt_file.out) { - LOGP(DLGLOBAL, LOGL_ERROR, "Cannot open log target '%s' as blocking stream I/O: %s\n", - name, strerror(errno)); return -EIO; } @@ -1156,35 +1141,22 @@ /*! switch from blocking + buffered file output to non-blocking write-queue based output. * \param[in] target log target which we should switch - * \return 0 on success; 1 if already switched before; negative on error */ + * \return 0 on success; 1 if already switched before; negative on error + * Must be called with mutex osmo_log_tgt_mutex held, see log_tgt_mutex_lock. + */ int log_target_file_switch_to_wqueue(struct log_target *target) { struct osmo_wqueue *wq; - const char *name; int rc; if (!target) return -ENODEV; - /* this only works for file/stderr targets */ - switch (target->type) { - case LOG_TGT_TYPE_FILE: - name = target->tgt_file.fname; - break; - case LOG_TGT_TYPE_STDERR: - name = "stderr"; - break; - default: - return -EINVAL; - } - if (!target->tgt_file.out) { /* target has already been switched over */ return 1; } - LOGP(DLGLOBAL, LOGL_INFO, "Switching log target '%s' to non-blocking I/O\n", name); - /* we create a ~640kB sized talloc pool within the write-queue to ensure individual * log lines (stored as msgbs) will not put result in malloc() calls, and also to * reduce the OOM probability within logging, as the pool is already allocated */ @@ -1198,8 +1170,6 @@ if (target->type == LOG_TGT_TYPE_FILE) { rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); if (rc < 0) { - LOGP(DLGLOBAL, LOGL_ERROR, "Cannot open log target '%s' as non-blocking I/O: %s\n", - name, strerror(errno)); talloc_free(wq); return -errno; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 16:44:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 16:44:13 +0000 Subject: Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26089 to look at the new patch set (#2). Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... logging: Fix double lock of log_tgt_mutex Recent commit introduced the "blocking-io" param to "log stderr" VTY command, which calls log_target_file_switch_to_{stream,wqueue}. The VTY command already locks the log_tgt_mutex mutex, since it has to access the tgt list. However, the functions mention above also want to lock the same mutex in order to log information. Let's drop the logging to avoid the double lock, and update its documentation to mention it must be called with the lock already held, as documented on other similar functions. The issue can be spotted when running osmo-trx-uhd: """ (gdb) bt #0 0x00007ffff75d7600 in __lll_lock_wait () from /usr/lib/libpthread.so.0 #1 0x00007ffff75d0503 in pthread_mutex_lock () from /usr/lib/libpthread.so.0 #2 0x00007ffff66314fb in log_tgt_mutex_lock_impl () at /git/libosmocore/src/logging.c:130 #3 0x00007ffff6638e74 in log_check_level (subsys=8, subsys at entry=-1, level=level at entry=3) at /git/libosmocore/src/logging.c:1510 #4 0x00007ffff6639c91 in log_target_file_switch_to_wqueue (target=target at entry=0x611000000320) at /git/libosmocore/src/logging.c:1186 #5 0x00007ffff68565d3 in cfg_log_stderr (self=, vty=0x6140000018a0, argc=0, argv=) at /git/libosmocore/src/vty/logging_vty.c:859 #6 0x00007ffff683db3d in cmd_execute_command_strict (vline=0x60b0000dfe80, vty=vty at entry=0x6140000018a0, cmd=cmd at entry=0x0) at /git/libosmocore/src/vty/command.c:2768 7 0x00007ffff683e396 in config_from_file (vty=vty at entry=0x6140000018a0, fp=fp at entry=0x615000036400) at /git/libosmocore/src/vty/command.c:2880 8 0x00007ffff684cedb in vty_read_config_filep (confp=confp at entry=0x615000036400, priv=priv at entry=0x0) at /git/libosmocore/src/vty/vty.c:1529 9 0x00007ffff684ebfc in vty_read_config_file (file_name=0x7fffffffe7d8 "/build/new/conf/osmo-trx-uhd.cfg", priv=0x0) at /git/libosmocore/src/vty/vty.c:1920 10 0x0000555555565270 in main (argc=3, argv=0x7fffffffe3c8) at /git/osmo-trx/Transceiver52M/osmo-trx.cpp:652 """ Debugged by rebuilding libosmocore with "LOG_MTX_DEBUG 1": """ /libosmocore/src/logging.c:1510 [log_check_level] lock /libosmocore/src/logging.c:1522 [log_check_level] unlock /libosmocore/src/vty/logging_vty.c:844 [cfg_log_stderr] lock /libosmocore/src/logging.c:1510 [log_check_level] lock """ Fixes: b72867f0e68c96ca25e1f9929ce92be0a802db6b Related: OS#4311 Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 --- M src/logging.c 1 file changed, 6 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/26089/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:02:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:02:39 +0000 Subject: Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26089 ) Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... Patch Set 2: Thanks, nice catch. I would rather go for introducing variants that don't hold the mutex. In the kernel we have __foo() and foo() where the first doesn't grab the lock an the second does. Not sure if we want to go exactly there, but normally I would expect the published API to take care of any internal locking/mutex as needed.... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 17:02:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:05:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:05:00 +0000 Subject: Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26089 ) Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... Patch Set 2: Code-Review+1 nevermind, the lock is already exposed and customarily used by the vty code. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 17:05:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:05:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:05:40 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Drop impossible code path In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26088 ) Change subject: bts-trx: sched_lchan_tchf: Drop impossible code path ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f Gerrit-Change-Number: 26088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 17:05:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:06:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:06:51 +0000 Subject: Change in pysim[master]: pySim-shell: print newline on exit with CTRL+D In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26081 ) Change subject: pySim-shell: print newline on exit with CTRL+D ...................................................................... Patch Set 1: who calls this do_eof() function? Doesn't that just add an "eof" command to the shell? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88e58094b9badeaabd8502006e5e16f35eaa683e Gerrit-Change-Number: 26081 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 17:06:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:07:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:07:27 +0000 Subject: Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26089 ) Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 17:07:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:07:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:07:41 +0000 Subject: Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26089 ) Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... Patch Set 2: let's merge this to make it into nightly builds tomorrow. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 17:07:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:07:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:07:43 +0000 Subject: Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26089 ) Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... logging: Fix double lock of log_tgt_mutex Recent commit introduced the "blocking-io" param to "log stderr" VTY command, which calls log_target_file_switch_to_{stream,wqueue}. The VTY command already locks the log_tgt_mutex mutex, since it has to access the tgt list. However, the functions mention above also want to lock the same mutex in order to log information. Let's drop the logging to avoid the double lock, and update its documentation to mention it must be called with the lock already held, as documented on other similar functions. The issue can be spotted when running osmo-trx-uhd: """ (gdb) bt #0 0x00007ffff75d7600 in __lll_lock_wait () from /usr/lib/libpthread.so.0 #1 0x00007ffff75d0503 in pthread_mutex_lock () from /usr/lib/libpthread.so.0 #2 0x00007ffff66314fb in log_tgt_mutex_lock_impl () at /git/libosmocore/src/logging.c:130 #3 0x00007ffff6638e74 in log_check_level (subsys=8, subsys at entry=-1, level=level at entry=3) at /git/libosmocore/src/logging.c:1510 #4 0x00007ffff6639c91 in log_target_file_switch_to_wqueue (target=target at entry=0x611000000320) at /git/libosmocore/src/logging.c:1186 #5 0x00007ffff68565d3 in cfg_log_stderr (self=, vty=0x6140000018a0, argc=0, argv=) at /git/libosmocore/src/vty/logging_vty.c:859 #6 0x00007ffff683db3d in cmd_execute_command_strict (vline=0x60b0000dfe80, vty=vty at entry=0x6140000018a0, cmd=cmd at entry=0x0) at /git/libosmocore/src/vty/command.c:2768 7 0x00007ffff683e396 in config_from_file (vty=vty at entry=0x6140000018a0, fp=fp at entry=0x615000036400) at /git/libosmocore/src/vty/command.c:2880 8 0x00007ffff684cedb in vty_read_config_filep (confp=confp at entry=0x615000036400, priv=priv at entry=0x0) at /git/libosmocore/src/vty/vty.c:1529 9 0x00007ffff684ebfc in vty_read_config_file (file_name=0x7fffffffe7d8 "/build/new/conf/osmo-trx-uhd.cfg", priv=0x0) at /git/libosmocore/src/vty/vty.c:1920 10 0x0000555555565270 in main (argc=3, argv=0x7fffffffe3c8) at /git/osmo-trx/Transceiver52M/osmo-trx.cpp:652 """ Debugged by rebuilding libosmocore with "LOG_MTX_DEBUG 1": """ /libosmocore/src/logging.c:1510 [log_check_level] lock /libosmocore/src/logging.c:1522 [log_check_level] unlock /libosmocore/src/vty/logging_vty.c:844 [cfg_log_stderr] lock /libosmocore/src/logging.c:1510 [log_check_level] lock """ Fixes: b72867f0e68c96ca25e1f9929ce92be0a802db6b Related: OS#4311 Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 --- M src/logging.c 1 file changed, 6 insertions(+), 36 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/logging.c b/src/logging.c index 00d75c3..9e2f5c2 100644 --- a/src/logging.c +++ b/src/logging.c @@ -1090,34 +1090,21 @@ /*! switch from non-blocking/write-queue to blocking + buffered stream output * \param[in] target log target which we should switch - * \return 0 on success; 1 if already switched before; negative on error */ + * \return 0 on success; 1 if already switched before; negative on error + * Must be called with mutex osmo_log_tgt_mutex held, see log_tgt_mutex_lock. + */ int log_target_file_switch_to_stream(struct log_target *target) { struct osmo_wqueue *wq; - const char *name; if (!target) return -ENODEV; - /* this only works for file/stderr targets */ - switch (target->type) { - case LOG_TGT_TYPE_FILE: - name = target->tgt_file.fname; - break; - case LOG_TGT_TYPE_STDERR: - name = "stderr"; - break; - default: - return -EINVAL; - } - if (target->tgt_file.out) { /* target has already been switched over */ return 1; } - LOGP(DLGLOBAL, LOGL_INFO, "Switching log target '%s' to blocking stream I/O\n", name); - wq = target->tgt_file.wqueue; OSMO_ASSERT(wq); @@ -1127,8 +1114,6 @@ else target->tgt_file.out = fopen(target->tgt_file.fname, "a"); if (!target->tgt_file.out) { - LOGP(DLGLOBAL, LOGL_ERROR, "Cannot open log target '%s' as blocking stream I/O: %s\n", - name, strerror(errno)); return -EIO; } @@ -1156,35 +1141,22 @@ /*! switch from blocking + buffered file output to non-blocking write-queue based output. * \param[in] target log target which we should switch - * \return 0 on success; 1 if already switched before; negative on error */ + * \return 0 on success; 1 if already switched before; negative on error + * Must be called with mutex osmo_log_tgt_mutex held, see log_tgt_mutex_lock. + */ int log_target_file_switch_to_wqueue(struct log_target *target) { struct osmo_wqueue *wq; - const char *name; int rc; if (!target) return -ENODEV; - /* this only works for file/stderr targets */ - switch (target->type) { - case LOG_TGT_TYPE_FILE: - name = target->tgt_file.fname; - break; - case LOG_TGT_TYPE_STDERR: - name = "stderr"; - break; - default: - return -EINVAL; - } - if (!target->tgt_file.out) { /* target has already been switched over */ return 1; } - LOGP(DLGLOBAL, LOGL_INFO, "Switching log target '%s' to non-blocking I/O\n", name); - /* we create a ~640kB sized talloc pool within the write-queue to ensure individual * log lines (stored as msgbs) will not put result in malloc() calls, and also to * reduce the OOM probability within logging, as the pool is already allocated */ @@ -1198,8 +1170,6 @@ if (target->type == LOG_TGT_TYPE_FILE) { rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); if (rc < 0) { - LOGP(DLGLOBAL, LOGL_ERROR, "Cannot open log target '%s' as non-blocking I/O: %s\n", - name, strerror(errno)); talloc_free(wq); return -errno; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:25:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:25:24 +0000 Subject: Change in osmo-bsc[master]: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25996 ) Change subject: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id97bc0d31a358db6221c385761773fb48670c921 Gerrit-Change-Number: 25996 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 17:25:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:25:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:25:29 +0000 Subject: Change in osmo-bsc[master]: heighbor_ident: add/del neighbor cells via ctrl interface In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25976 ) Change subject: heighbor_ident: add/del neighbor cells via ctrl interface ...................................................................... heighbor_ident: add/del neighbor cells via ctrl interface The VTY allows flexible control over the neighbor cell information via the neighbor command, which can be found in the configure terminal under the bts node. Lets add pendant of this command on the control interface as well. Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Related: SYS#5641 --- M doc/manuals/chapters/control.adoc M include/osmocom/bsc/neighbor_ident.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_ctrl_commands.c A src/osmo-bsc/neighbor_ident_ctrl.c M src/osmo-bsc/neighbor_ident_vty.c M tests/ctrl_test_runner.py 7 files changed, 958 insertions(+), 29 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/control.adoc b/doc/manuals/chapters/control.adoc index c2d7a82..091cdc6 100644 --- a/doc/manuals/chapters/control.adoc +++ b/doc/manuals/chapters/control.adoc @@ -120,4 +120,29 @@ Set/Get the value of maximum power reduction. Even values between 0 and 22 are accepted. +=== add/del neighbor cell + +The control interface allows for editing the neighbor cell configuration. Neighbor +cells can be added or removed during runtime. It is also possible to clear the +entire neighbor list if necessary. + +.Variables available over control interface +[options="header",width="100%",cols="20%,5%,5%,50%,20%"] +|=== +|Name|Access|Trap|Value|Comment +|bts.N.neighbor-bts.add|WO|No|""|Add neighbor cell by local BTS number. +|bts.N.neighbor-bts.del|WO|No|""|Delete neighbor cell by local BTS number. +|bts.N.neighbor-lac.add|WO|No|"[--]"|Add neighbor cell by LAC. +|bts.N.neighbor-lac.del|WO|No|"[--]"|Delete neighbor cell by LAC. +|bts.N.neighbor-lac-ci.add|WO|No|"-[--]"|Add neighbor cell by LAC and CI. +|bts.N.neighbor-lac-ci.del|WO|No|"-[--]"|Delete neighbor cell by LAC and CI. +|bts.N.neighbor-cgi.add|WO|No|"---[--]"|Add neighbor cell by cgi. +|bts.N.neighbor-cgi.del|WO|No|"---[--]"|Delete neighbor cell by cgi. +|bts.N.neighbor-cgi-ps.add|WO|No|"----[--]"|Add neighbor cell by cgi (Packet Switched, with RAC) +|bts.N.neighbor-cgi-ps.del|WO|No|"----[--]"|Delete neighbor cell by cgi (Packet Switched, with RAC). +|bts.N.neighbor-clear|WO|No|Ignored|Delete all neighbor cells. +|=== + +NOTE: The bsic-number () can also be set to "any" if no explcit bsic shall be given + FIXME: add variables defined in src/ctrl/control_if.c? diff --git a/include/osmocom/bsc/neighbor_ident.h b/include/osmocom/bsc/neighbor_ident.h index 58300ba..c6a2c42 100644 --- a/include/osmocom/bsc/neighbor_ident.h +++ b/include/osmocom/bsc/neighbor_ident.h @@ -77,6 +77,10 @@ void neighbor_ident_vty_write_bts(struct vty *vty, const char *indent, struct gsm_bts *bts); void neighbor_ident_vty_write_network(struct vty *vty, const char *indent); +int neighbor_ident_add_neighbor(struct vty *vty, struct gsm_bts *bts, struct neighbor *n); +int neighbor_ident_del_neighbor(struct vty *vty, struct gsm_bts *bts, struct neighbor *n); +int neighbor_ident_ctrl_init(void); + int neighbors_check_cfg(); #define CELL_AB_VTY_PARAMS "arfcn <0-1023> bsic (<0-63>|any)" diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index 19af569..3d6666e 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -78,6 +78,7 @@ meas_rep.c \ neighbor_ident.c \ neighbor_ident_vty.c \ + neighbor_ident_ctrl.c \ net_init.c \ nm_common_fsm.c \ nm_bb_transc_fsm.c \ diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c index a94baae..0affee0 100644 --- a/src/osmo-bsc/bsc_ctrl_commands.c +++ b/src/osmo-bsc/bsc_ctrl_commands.c @@ -35,6 +35,7 @@ #include #include #include +#include static int verify_net_apply_config_file(struct ctrl_cmd *cmd, const char *value, void *_data) { @@ -692,6 +693,8 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rf_states); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_c0_power_red); + rc |= neighbor_ident_ctrl_init(); + rc |= ctrl_cmd_install(CTRL_NODE_TRX, &cmd_trx_max_power); rc |= ctrl_cmd_install(CTRL_NODE_TRX, &cmd_trx_arfcn); rc |= ctrl_cmd_install(CTRL_NODE_TRX, &cmd_trx_rf_locked); diff --git a/src/osmo-bsc/neighbor_ident_ctrl.c b/src/osmo-bsc/neighbor_ident_ctrl.c new file mode 100644 index 0000000..8e5e048 --- /dev/null +++ b/src/osmo-bsc/neighbor_ident_ctrl.c @@ -0,0 +1,713 @@ +/* CTRL interface implementation to manage identity of neighboring BSS cells for inter-BSC handover. */ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * + * All Rights Reserved + * + * Author: Philipp Maier + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include + +#include +#include +#include +#include +#include +#include + +/* Continue to parse ARFCN and BSIC, which are optional parameters at the end of the parameter string in most of the + * commands. The result is ignored when parameter n is set to NULL. */ +static int continue_parse_arfcn_and_bsic(char **saveptr, struct neighbor *n) +{ + int arfcn; + int bsic; + char *tok; + + tok = strtok_r(NULL, "-", saveptr); + + /* No ARFCN and BSIC persent - stop */ + if (!tok) + return 0; + + if (osmo_str_to_int(&arfcn, tok, 10, 0, 1023) < 0) + return -EINVAL; + + tok = strtok_r(NULL, "-", saveptr); + + /* When an ARFCN is given, then the BSIC parameter is + * mandatory */ + if (!tok) + return -EINVAL; + + if (strcmp(tok, "any") == 0) { + bsic = BSIC_ANY; + } else { + if (osmo_str_to_int(&bsic, tok, 10, 0, 63) < 0) + return 1; + } + + /* Make sure there are no excess parameters */ + if (strtok_r(NULL, "-", saveptr)) + return -EINVAL; + + if (n) { + n->cell_id.ab_present = true; + n->cell_id.ab.arfcn = arfcn; + n->cell_id.ab.bsic = bsic; + } + + return 0; +} + +/* This and the following: Add/Remove a BTS as neighbor */ +static int verify_neighbor_bts(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + struct gsm_bts *bts = cmd->node; + const int neigh_bts_nr = atoi(value); + struct gsm_bts *neigh_bts = gsm_bts_num(bts->network, neigh_bts_nr); + + if (!neigh_bts) { + cmd->reply = "Invalid Neighbor BTS number - no such BTS"; + return 1; + } + + return 0; +} + +static int verify_neighbor_bts_add(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + return verify_neighbor_bts(cmd, value, _data); +} + +static int set_neighbor_bts_add(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + const int bts_nr = atoi(cmd->value); + int rc; + + struct neighbor n = { + .type = NEIGHBOR_TYPE_BTS_NR, + .bts_nr = bts_nr, + }; + rc = neighbor_ident_add_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to add neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: "" + * num: BTS number (0-255) */ +CTRL_CMD_DEFINE_WO(neighbor_bts_add, "neighbor-bts add"); + +static int verify_neighbor_bts_del(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + return verify_neighbor_bts(cmd, value, _data); +} + +static int set_neighbor_bts_del(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + const int bts_nr = atoi(cmd->value); + int rc; + + struct neighbor n = { + .type = NEIGHBOR_TYPE_BTS_NR, + .bts_nr = bts_nr, + }; + rc = neighbor_ident_del_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to delete neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: (see "add" command above) */ +CTRL_CMD_DEFINE_WO(neighbor_bts_del, "neighbor-bts del"); + +/* This and the following: Add/Remove a LAC as neighbor */ +static int parse_lac(void *ctx, struct neighbor *n, const char *value) +{ + char *tmp = NULL, *tok, *saveptr; + int rc = 0; + int lac; + + if (n) + memset(n, 0, sizeof(*n)); + + tmp = talloc_strdup(ctx, value); + if (!tmp) + return -EINVAL; + + /* Parse LAC */ + tok = strtok_r(tmp, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&lac, tok, 10, 0, 65535) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Optional parameters: ARFCN and BSIC */ + if (continue_parse_arfcn_and_bsic(&saveptr, n)) { + rc = -EINVAL; + goto exit; + } + + if (n) { + n->type = NEIGHBOR_TYPE_CELL_ID; + n->cell_id.id.id_discr = CELL_IDENT_LAC; + n->cell_id.id.id.lac = lac; + } + +exit: + talloc_free(tmp); + return rc; +} + +static int verify_neighbor_lac_add(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_lac(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_lac_add(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + + parse_lac(cmd, &n, cmd->value); + rc = neighbor_ident_add_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to add neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: "[--]" + * lac: Location area of neighbor cell (0-65535) + * arfcn: ARFCN of neighbor cell (0-1023) + * bsic: BSIC of neighbor cell */ +CTRL_CMD_DEFINE_WO(neighbor_lac_add, "neighbor-lac add"); + +static int verify_neighbor_lac_del(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_lac(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_lac_del(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + parse_lac(cmd, &n, cmd->value); + rc = neighbor_ident_del_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to delete neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: (see "add" command above) */ +CTRL_CMD_DEFINE_WO(neighbor_lac_del, "neighbor-lac del"); + +/* This and the following: Add/Remove a LAC-CI as neighbor */ +static int parse_lac_ci(void *ctx, struct neighbor *n, const char *value) +{ + char *tmp = NULL, *tok, *saveptr; + int rc = 0; + int lac; + int ci; + + if (n) + memset(n, 0, sizeof(*n)); + + tmp = talloc_strdup(ctx, value); + if (!tmp) + return -EINVAL; + + /* Parse LAC */ + tok = strtok_r(tmp, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&lac, tok, 10, 0, 65535) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse CI */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&ci, tok, 10, 0, 65535) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Optional parameters: ARFCN and BSIC */ + if (continue_parse_arfcn_and_bsic(&saveptr, n)) { + rc = -EINVAL; + goto exit; + } + + if (n) { + n->type = NEIGHBOR_TYPE_CELL_ID; + n->cell_id.id.id_discr = CELL_IDENT_LAC_AND_CI; + n->cell_id.id.id.lac = lac; + n->cell_id.id.id.ci = ci; + } + +exit: + talloc_free(tmp); + return rc; +} + +static int verify_neighbor_lac_ci_add(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_lac_ci(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_lac_ci_add(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + + parse_lac_ci(cmd, &n, cmd->value); + rc = neighbor_ident_add_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to add neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: "-[--]" + * lac: Location area of neighbor cell (0-65535) + * ci: Cell ID of neighbor cell (0-65535) + * arfcn: ARFCN of neighbor cell (0-1023) + * bsic: BSIC of neighbor cell */ +CTRL_CMD_DEFINE_WO(neighbor_lac_ci_add, "neighbor-lac-ci add"); + +static int verify_neighbor_lac_ci_del(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_lac_ci(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_lac_ci_del(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + parse_lac_ci(cmd, &n, cmd->value); + rc = neighbor_ident_del_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to delete neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: (see "add" command above) */ +CTRL_CMD_DEFINE_WO(neighbor_lac_ci_del, "neighbor-lac-ci del"); + +/* This and the following: Add/Remove a CGI as neighbor */ +static int parse_cgi(void *ctx, struct neighbor *n, const char *value) +{ + char *tmp = NULL, *tok, *saveptr; + int rc = 0; + uint16_t mcc; + uint16_t mnc; + bool mnc_3_digits; + int lac; + int ci; + + if (n) + memset(n, 0, sizeof(*n)); + + tmp = talloc_strdup(ctx, value); + if (!tmp) + return -EINVAL; + + /* Parse MCC */ + tok = strtok_r(tmp, "-", &saveptr); + if (tok) { + if (osmo_mcc_from_str(tok, &mcc)) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse MNC */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_mnc_from_str(tok, &mnc, &mnc_3_digits)) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse LAC */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&lac, tok, 10, 0, 65535) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse CI */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&ci, tok, 10, 0, 65535) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Optional parameters: ARFCN and BSIC */ + if (continue_parse_arfcn_and_bsic(&saveptr, n)) { + rc = -EINVAL; + goto exit; + } + + if (n) { + n->type = NEIGHBOR_TYPE_CELL_ID; + n->cell_id.id.id_discr = CELL_IDENT_WHOLE_GLOBAL; + n->cell_id.id.id.global.lai.lac = lac; + n->cell_id.id.id.global.lai.plmn.mcc = mcc; + n->cell_id.id.id.global.lai.plmn.mnc = mnc; + n->cell_id.id.id.global.lai.plmn.mnc_3_digits = mnc_3_digits; + n->cell_id.id.id.global.cell_identity = ci; + } + +exit: + talloc_free(tmp); + return rc; +} + +static int verify_neighbor_cgi_add(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_cgi(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_cgi_add(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + + parse_cgi(cmd, &n, cmd->value); + rc = neighbor_ident_add_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to add neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: "---[--]" + * mcc: Mobile country code of neighbor cell (0-999) + * mnc: Mobile network code of neighbor cell (0-999) + * lac: Location area of neighbor cell (0-65535) + * ci: Cell ID of neighbor cell (0-65535) + * arfcn: ARFCN of neighbor cell (0-1023) + * bsic: BSIC of neighbor cell */ +CTRL_CMD_DEFINE_WO(neighbor_cgi_add, "neighbor-cgi add"); + +static int verify_neighbor_cgi_del(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_cgi(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_cgi_del(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + parse_cgi(cmd, &n, cmd->value); + rc = neighbor_ident_del_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to delete neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: (see "add" command above) */ +CTRL_CMD_DEFINE_WO(neighbor_cgi_del, "neighbor-cgi del"); + +/* This and the following: Add/Remove a CGI-PS as neighbor */ +static int parse_cgi_ps(void *ctx, struct neighbor *n, const char *value) +{ + char *tmp = NULL, *tok, *saveptr; + int rc = 0; + uint16_t mcc; + uint16_t mnc; + bool mnc_3_digits; + int lac; + int rac; + int ci; + + if (n) + memset(n, 0, sizeof(*n)); + + tmp = talloc_strdup(ctx, value); + if (!tmp) + return -EINVAL; + + /* Parse MCC */ + tok = strtok_r(tmp, "-", &saveptr); + if (tok) { + if (osmo_mcc_from_str(tok, &mcc)) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse MNC */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_mnc_from_str(tok, &mnc, &mnc_3_digits)) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse LAC */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&lac, tok, 10, 0, 65535) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse RAC */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&rac, tok, 10, 0, 255) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Parse CI */ + tok = strtok_r(NULL, "-", &saveptr); + if (tok) { + if (osmo_str_to_int(&ci, tok, 10, 0, 65535) < 0) { + rc = -EINVAL; + goto exit; + } + } else { + rc = -EINVAL; + goto exit; + } + + /* Optional parameters: ARFCN and BSIC */ + if (continue_parse_arfcn_and_bsic(&saveptr, n)) { + rc = -EINVAL; + goto exit; + } + + if (n) { + n->type = NEIGHBOR_TYPE_CELL_ID; + n->cell_id.id.id_discr = CELL_IDENT_WHOLE_GLOBAL_PS; + n->cell_id.id.id.global_ps.rai.lac.lac = lac; + n->cell_id.id.id.global_ps.rai.rac = lac; + n->cell_id.id.id.global_ps.rai.lac.plmn.mcc = mcc; + n->cell_id.id.id.global_ps.rai.lac.plmn.mnc = mnc; + n->cell_id.id.id.global_ps.rai.lac.plmn.mnc_3_digits = mnc_3_digits; + n->cell_id.id.id.global_ps.cell_identity = ci; + } + +exit: + talloc_free(tmp); + return rc; +} + +static int verify_neighbor_cgi_ps_add(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_cgi_ps(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_cgi_ps_add(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + + parse_cgi_ps(cmd, &n, cmd->value); + rc = neighbor_ident_add_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to add neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: "----[--]" + * mcc: Mobile country code of neighbor cell (0-999) + * mnc: Mobile network code of neighbor cell (0-999) + * lac: Location area of neighbor cell (0-65535) + * rac: Routing area of neighbor cell (0-65535) + * ci: Cell ID of neighbor cell (0-65535) + * arfcn: ARFCN of neighbor cell (0-1023) + * bsic: BSIC of neighbor cell */ +CTRL_CMD_DEFINE_WO(neighbor_cgi_ps_add, "neighbor-cgi-ps add"); + +static int verify_neighbor_cgi_ps_del(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (parse_cgi_ps(cmd, NULL, value)) + return 1; + return 0; +} + +static int set_neighbor_cgi_ps_del(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int rc; + + struct neighbor n; + parse_cgi_ps(cmd, &n, cmd->value); + rc = neighbor_ident_del_neighbor(NULL, bts, &n); + if (rc != CMD_SUCCESS) { + cmd->reply = "Failed to delete neighbor"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +/* Parameter format: (see "add" command above) */ +CTRL_CMD_DEFINE_WO(neighbor_cgi_ps_del, "neighbor-cgi-ps del"); + +/* This and the following: clear all neighbor cell information */ +static int set_neighbor_clear(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + struct neighbor *neighbor; + struct neighbor *neighbor_tmp; + + llist_for_each_entry_safe(neighbor, neighbor_tmp, &bts->neighbors, entry) { + llist_del(&neighbor->entry); + talloc_free(neighbor); + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE_WO_NOVRF(neighbor_clear, "neighbor-clear"); + +/* Register control interface commands implemented above */ +int neighbor_ident_ctrl_init(void) +{ + int rc = 0; + + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_bts_add); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_bts_del); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_lac_add); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_lac_del); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_lac_ci_add); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_lac_ci_del); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_cgi_add); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_cgi_del); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_cgi_ps_add); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_cgi_ps_del); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_neighbor_clear); + + return rc; +} diff --git a/src/osmo-bsc/neighbor_ident_vty.c b/src/osmo-bsc/neighbor_ident_vty.c index b500b34..e40fa8c 100644 --- a/src/osmo-bsc/neighbor_ident_vty.c +++ b/src/osmo-bsc/neighbor_ident_vty.c @@ -146,23 +146,32 @@ }; } -static int add_neighbor(struct vty *vty, struct neighbor *n) +#define LOGPORVTY(vty, fmt, args...) \ +{ \ + if (vty) \ + vty_out(vty, "%% " fmt "%s", ## args, VTY_NEWLINE); \ + else \ + LOGP(DLINP, LOGL_NOTICE, fmt "\n", ## args); \ +} while (0) \ + +/* Delete a neighbor from neighborlist. When the parameter *vty is set to NULL all error messages are redirected to the + * logtext. */ +int neighbor_ident_add_neighbor(struct vty *vty, struct gsm_bts *bts, struct neighbor *n) { - struct gsm_bts *bts = vty->index; struct neighbor *neighbor; - OSMO_ASSERT((vty->node == BTS_NODE) && bts); + OSMO_ASSERT(bts); + OSMO_ASSERT(!vty || (vty->node == BTS_NODE)); llist_for_each_entry(neighbor, &bts->neighbors, entry) { /* Check against duplicates */ if (neighbor_same(neighbor, n, false)) { /* Found a match on Cell ID or BTS number, without ARFCN+BSIC. If they are fully identical, ignore the * duplicate. If the ARFCN+BSIC part differs, it's an error. */ - vty_out(vty, "%% BTS %u already had neighbor %s%s", bts->nr, neighbor_to_str_c(OTC_SELECT, neighbor), - VTY_NEWLINE); + LOGPORVTY(vty, "BTS %u already had neighbor %s", bts->nr, neighbor_to_str_c(OTC_SELECT, neighbor)); if (!neighbor_same(neighbor, n, true)) { - vty_out(vty, "%% ERROR: duplicate Cell ID in neighbor config, with differing ARFCN+BSIC: %s%s", - neighbor_to_str_c(OTC_SELECT, n), VTY_NEWLINE); + LOGPORVTY(vty, "ERROR: duplicate Cell ID in neighbor config, with differing ARFCN+BSIC: %s", + neighbor_to_str_c(OTC_SELECT, n)); return CMD_WARNING; } /* Exact same neighbor again, just ignore. */ @@ -173,9 +182,9 @@ if (n->type == NEIGHBOR_TYPE_CELL_ID && n->cell_id.ab_present && neighbor->cell_id.ab_present && cell_ab_match(&n->cell_id.ab, &neighbor->cell_id.ab, true)) { - vty_out(vty, "%% Error: only one Cell Identifier entry is allowed per remote neighbor." - " Already have: BTS %u -> %s%s", bts->nr, - neighbor_to_str_c(OTC_SELECT, neighbor), VTY_NEWLINE); + LOGPORVTY(vty, "Error: only one Cell Identifier entry is allowed per remote neighbor." + " Already have: BTS %u -> %s", bts->nr, + neighbor_to_str_c(OTC_SELECT, neighbor)); return CMD_WARNING; } } @@ -186,12 +195,14 @@ return CMD_SUCCESS; } -static int del_neighbor(struct vty *vty, struct neighbor *n) +/* Delete a neighbor from neighborlist. When the parameter *vty is set to NULL all error messages are redirected to the + * logtext. */ +int neighbor_ident_del_neighbor(struct vty *vty, struct gsm_bts *bts, struct neighbor *n) { - struct gsm_bts *bts = vty->index; struct neighbor *neighbor; - OSMO_ASSERT((vty->node == BTS_NODE) && bts); + OSMO_ASSERT(bts); + OSMO_ASSERT(!vty || (vty->node == BTS_NODE)); llist_for_each_entry(neighbor, &bts->neighbors, entry) { if (neighbor->type != n->type) @@ -216,8 +227,8 @@ return CMD_SUCCESS; } - vty_out(vty, "%% Error: no such neighbor on BTS %d: %s%s", - bts->nr, neighbor_to_str_c(OTC_SELECT, n), VTY_NEWLINE); + LOGPORVTY(vty, "Error: no such neighbor on BTS %d: %s", + bts->nr, neighbor_to_str_c(OTC_SELECT, n)); return CMD_WARNING; } @@ -271,7 +282,7 @@ .type = NEIGHBOR_TYPE_BTS_NR, .bts_nr = atoi(argv[0]), }; - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_add_lac, cfg_neighbor_add_lac_cmd, @@ -283,7 +294,7 @@ }; if (neighbor_ident_vty_parse_lac(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_add_lac_ci, cfg_neighbor_add_lac_ci_cmd, @@ -295,7 +306,7 @@ }; if (neighbor_ident_vty_parse_lac_ci(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_add_cgi, cfg_neighbor_add_cgi_cmd, @@ -307,7 +318,7 @@ }; if (neighbor_ident_vty_parse_cgi(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_add_cgi_ps, cfg_neighbor_add_cgi_ps_cmd, @@ -319,7 +330,7 @@ }; if (neighbor_ident_vty_parse_cgi_ps(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } static int neighbor_del_all(struct vty *vty) @@ -354,7 +365,7 @@ if (neighbor_ident_vty_parse_lac(vty, &n.cell_id.id, argv)) return CMD_WARNING; neighbor_ident_vty_parse_arfcn_bsic(&n.cell_id.ab, argv + LAC_ARGC); - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_add_lac_ci_arfcn_bsic, cfg_neighbor_add_lac_ci_arfcn_bsic_cmd, @@ -368,7 +379,7 @@ if (neighbor_ident_vty_parse_lac_ci(vty, &n.cell_id.id, argv)) return CMD_WARNING; neighbor_ident_vty_parse_arfcn_bsic(&n.cell_id.ab, argv + LAC_CI_ARGC); - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_add_cgi_arfcn_bsic, cfg_neighbor_add_cgi_arfcn_bsic_cmd, @@ -382,7 +393,7 @@ if (neighbor_ident_vty_parse_cgi(vty, &n.cell_id.id, argv)) return CMD_WARNING; neighbor_ident_vty_parse_arfcn_bsic(&n.cell_id.ab, argv + CGI_ARGC); - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_add_cgi_ps_arfcn_bsic, cfg_neighbor_add_cgi_ps_arfcn_bsic_cmd, @@ -396,7 +407,7 @@ if (neighbor_ident_vty_parse_cgi_ps(vty, &n.cell_id.id, argv)) return CMD_WARNING; neighbor_ident_vty_parse_arfcn_bsic(&n.cell_id.ab, argv + CGI_PS_ARGC); - return add_neighbor(vty, &n); + return neighbor_ident_add_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_del_bts_nr, cfg_neighbor_del_bts_nr_cmd, @@ -407,7 +418,7 @@ .type = NEIGHBOR_TYPE_BTS_NR, .bts_nr = atoi(argv[0]), }; - return del_neighbor(vty, &n); + return neighbor_ident_del_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_del_lac, cfg_neighbor_del_lac_cmd, @@ -419,7 +430,7 @@ }; if (neighbor_ident_vty_parse_lac(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return del_neighbor(vty, &n); + return neighbor_ident_del_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_del_lac_ci, cfg_neighbor_del_lac_ci_cmd, @@ -431,7 +442,7 @@ }; if (neighbor_ident_vty_parse_lac_ci(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return del_neighbor(vty, &n); + return neighbor_ident_del_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_del_cgi, cfg_neighbor_del_cgi_cmd, @@ -443,7 +454,7 @@ }; if (neighbor_ident_vty_parse_cgi(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return del_neighbor(vty, &n); + return neighbor_ident_del_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_del_cgi_ps, cfg_neighbor_del_cgi_ps_cmd, @@ -455,7 +466,7 @@ }; if (neighbor_ident_vty_parse_cgi_ps(vty, &n.cell_id.id, argv)) return CMD_WARNING; - return del_neighbor(vty, &n); + return neighbor_ident_del_neighbor(vty, vty->index, &n); } DEFUN(cfg_neighbor_del_arfcn_bsic, cfg_neighbor_del_arfcn_bsic_cmd, diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index bd2cb10..5e9bcef 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -562,6 +562,177 @@ self.assertEqual(r['var'], 'neighbor_resolve_cgi_ps_from_lac_ci.1.6969.23.32') self.assertEqual(r['value'], '023-42-423-2-5') + +class TestCtrlBSCNeighborCell(TestCtrlBase): + + def tearDown(self): + TestCtrlBase.tearDown(self) + os.unlink("tmp_dummy_sock") + + def ctrl_command(self): + return ["./src/osmo-bsc/osmo-bsc", "-r", "tmp_dummy_sock", "-c", + "tests/ctrl/osmo-bsc-neigh-test.cfg"] + + def ctrl_app(self): + return (4249, "./src/osmo-bsc/osmo-bsc", "OsmoBSC", "bsc") + + def testCtrlAddDelBTS(self): + r = self.do_set('bts.0.neighbor-bts.add', '1') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-bts.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-bts.del', '1') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-bts.del') + self.assertEqual(r['value'], 'OK') + + def testCtrlAddDelLAC(self): + # without ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-lac.add', '100') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-lac.del', '100') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac.del') + self.assertEqual(r['value'], 'OK') + + # with ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-lac.add', '100-123-4') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-lac.del', '100-123-4') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac.del') + self.assertEqual(r['value'], 'OK') + + def testCtrlAddDelLACCI(self): + # without ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-lac-ci.add', '100-200') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac-ci.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-lac-ci.del', '100-200') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac-ci.del') + self.assertEqual(r['value'], 'OK') + + # with ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-lac-ci.add', '100-200-123-any') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac-ci.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-lac-ci.del', '100-200-123-any') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-lac-ci.del') + self.assertEqual(r['value'], 'OK') + + def testCtrlAddDelCGI(self): + # without ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-cgi.add', '001-01-100-200') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-cgi.del', '001-01-100-200') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi.del') + self.assertEqual(r['value'], 'OK') + + # with ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-cgi.add', '001-01-100-200-123-4') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-cgi.del', '001-01-100-200-123-4') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi.del') + self.assertEqual(r['value'], 'OK') + + def testCtrlAddDelCGIPS(self): + # without ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-cgi-ps.add', '001-01-100-33-200') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi-ps.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-cgi-ps.del', '001-01-100-33-200') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi-ps.del') + self.assertEqual(r['value'], 'OK') + + # with ARFCN+BSIC: + r = self.do_set('bts.0.neighbor-cgi-ps.add', '001-01-100-33-200-123-any') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi-ps.add') + self.assertEqual(r['value'], 'OK') + r = self.do_set('bts.0.neighbor-cgi-ps.del', '001-01-100-33-200-123-any') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-cgi-ps.del') + self.assertEqual(r['value'], 'OK') + + def testCtrlClearNeighbors(self): + r = self.do_set('bts.0.neighbor-clear', 'ignored') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-clear') + self.assertEqual(r['value'], 'OK') + + def testCtrlErrs(self): + # Missing BSIC + r = self.do_set('bts.0.neighbor-lac.add', '100-123') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Value failed verification.') + + # Short value (missing RAC) + r = self.do_set('bts.0.neighbor-cgi-ps.del', '001-01-100-200-123-1') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Value failed verification.') + + # Long value + r = self.do_set('bts.0.neighbor-cgi-ps.del', '001-01-100-33-200-123-1-2') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Value failed verification.') + + # Out of range values + r = self.do_set('bts.0.neighbor-cgi.add', '100001-1123401-100-200') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Value failed verification.') + + # Garbage + r = self.do_set('bts.0.neighbor-lac-ci.add', '0G1-Z1-1U0-a3-2p0') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Value failed verification.') + + # Delete something that shouldn't be there + r = self.do_set('bts.0.neighbor-cgi-ps.del', '001-01-100-33-200-123-any') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Failed to delete neighbor') + + def add_bsc_test(suite, workdir, klass): if not os.path.isfile(os.path.join(workdir, "src/osmo-bsc/osmo-bsc")): print("Skipping the BSC test") @@ -601,5 +772,6 @@ suite = unittest.TestSuite() add_bsc_test(suite, workdir, TestCtrlBSC) add_bsc_test(suite, workdir, TestCtrlBSCNeighbor) + add_bsc_test(suite, workdir, TestCtrlBSCNeighborCell) res = unittest.TextTestRunner(verbosity=verbose_level).run(suite) sys.exit(len(res.errors) + len(res.failures)) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Gerrit-Change-Number: 25976 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:25:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:25:30 +0000 Subject: Change in osmo-bsc[master]: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25996 ) Change subject: bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface ...................................................................... bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface It is possible to change the neighbor-list mode via the VTY from automatic mode to manual neighbor-list configuration. In the manual mode, the user can add ARFCN values manually. This command can be found under the bts node. Lets add pendant of this command on the control interface as well. Change-Id: Id97bc0d31a358db6221c385761773fb48670c921 Related: SYS#5641 --- M doc/manuals/chapters/control.adoc M src/osmo-bsc/bsc_ctrl_commands.c M tests/ctrl_test_runner.py 3 files changed, 160 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/manuals/chapters/control.adoc b/doc/manuals/chapters/control.adoc index 091cdc6..695dd80 100644 --- a/doc/manuals/chapters/control.adoc +++ b/doc/manuals/chapters/control.adoc @@ -68,6 +68,9 @@ |[bts.N.]handover2.penalty-time.failed-assignment|RW|No|<0-99999>,"default"|Time to suspend handover for a subscriber after a failed re-assignment within this cell. |[bts.N.]handover2.retries|RW|No|<0-9>,"default"|Number of times to immediately retry a failed handover/assignment, before a penalty time is applied. |handover2.congestion-check|RW|No|"disabled",<1-999>,"now"|Congestion check interval in seconds, "now" triggers immediate congestion check. +|bts.N.neighbor-list.mode|WO|No|"automatic","manual","manual-si5"|Mode of Neighbor List generation. +|bts.N.neighbor-list.add|WO|No|<0-1023>|Add to manual neighbor list. +|bts.N.neighbor-list.del|WO|No|<0-1023>|Delete from manual neighbor list. |=== [[notif]] diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c index 0affee0..f379bd2 100644 --- a/src/osmo-bsc/bsc_ctrl_commands.c +++ b/src/osmo-bsc/bsc_ctrl_commands.c @@ -668,6 +668,120 @@ CTRL_CMD_DEFINE(bts_c0_power_red, "c0-power-reduction"); +static int verify_bts_neighbor_list_add_del(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + int arfcn; + + if (osmo_str_to_int(&arfcn, value, 10, 0, 1023) < 0) { + cmd->reply = "Invalid ARFCN value"; + return 1; + } + + return 0; +} + +static int set_bts_neighbor_list_add_del(struct ctrl_cmd *cmd, void *data, bool add) +{ + struct gsm_bts *bts = cmd->node; + struct bitvec *bv = &bts->si_common.neigh_list; + int arfcn_int; + uint16_t arfcn; + enum gsm_band unused; + + if (osmo_str_to_int(&arfcn_int, cmd->value, 10, 0, 1023) < 0) { + cmd->reply = "Failed to parse ARFCN value"; + return CTRL_CMD_ERROR; + } + arfcn = (uint16_t) arfcn_int; + + if (bts->neigh_list_manual_mode == NL_MODE_AUTOMATIC) { + cmd->reply = "Neighbor list not in manual mode"; + return CTRL_CMD_ERROR; + } + + if (gsm_arfcn2band_rc(arfcn, &unused) < 0) { + cmd->reply = "Invalid arfcn detected"; + return CTRL_CMD_ERROR; + } + + if (add) + bitvec_set_bit_pos(bv, arfcn, 1); + else + bitvec_set_bit_pos(bv, arfcn, 0); + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +static int verify_bts_neighbor_list_add(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + return verify_bts_neighbor_list_add_del(cmd, value, _data); +} + +static int set_bts_neighbor_list_add(struct ctrl_cmd *cmd, void *data) +{ + return set_bts_neighbor_list_add_del(cmd, data, true); +} + +CTRL_CMD_DEFINE_WO(bts_neighbor_list_add, "neighbor-list add"); + +static int verify_bts_neighbor_list_del(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + return verify_bts_neighbor_list_add_del(cmd, value, _data); +} + +static int set_bts_neighbor_list_del(struct ctrl_cmd *cmd, void *data) +{ + return set_bts_neighbor_list_add_del(cmd, data, false); +} + +CTRL_CMD_DEFINE_WO(bts_neighbor_list_del, "neighbor-list del"); + +static int verify_bts_neighbor_list_mode(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + if (!strcmp(value, "automatic")) + return 0; + if (!strcmp(value, "manual")) + return 0; + if (!strcmp(value, "manual-si5")) + return 0; + + cmd->reply = "Invalid mode"; + return 1; +} + +static int set_bts_neighbor_list_mode(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + int mode; + + if (!strcmp(cmd->value, "automatic")) + mode = NL_MODE_AUTOMATIC; + else if (!strcmp(cmd->value, "manual")) + mode = NL_MODE_MANUAL; + else if (!strcmp(cmd->value, "manual-si5")) + mode = NL_MODE_MANUAL_SI5SEP; + + switch (mode) { + case NL_MODE_MANUAL_SI5SEP: + case NL_MODE_MANUAL: + /* make sure we clear the current list when switching to + * manual mode */ + if (bts->neigh_list_manual_mode == 0) + memset(&bts->si_common.data.neigh_list, 0, sizeof(bts->si_common.data.neigh_list)); + break; + default: + break; + } + + bts->neigh_list_manual_mode = mode; + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE_WO(bts_neighbor_list_mode, "neighbor-list mode"); + int bsc_base_ctrl_cmds_install(void) { int rc = 0; @@ -692,6 +806,9 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rf_state); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rf_states); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_c0_power_red); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_add); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_del); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); rc |= neighbor_ident_ctrl_init(); diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index 5e9bcef..4c07d5e 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -525,6 +525,46 @@ self.assertEqual(r['var'], 'apply-config-file') self.assertEqual(r['value'], 'OK') + def testNeighborList(self): + # Enter manual neighbor-list mode + r = self.do_set('bts.0.neighbor-list.mode', 'manual') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-list.mode') + self.assertEqual(r['value'], 'OK') + + # Add an ARFCN + r = self.do_set('bts.0.neighbor-list.add', '123') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-list.add') + self.assertEqual(r['value'], 'OK') + + # Delete the ARFCN again + r = self.do_set('bts.0.neighbor-list.del', '123') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-list.del') + self.assertEqual(r['value'], 'OK') + + # Go back to automatic neighbor-list mode + r = self.do_set('bts.0.neighbor-list.mode', 'automatic') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'SET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-list.mode') + self.assertEqual(r['value'], 'OK') + + # This must not work as we are in automatic neighbor-list mode + r = self.do_set('bts.0.neighbor-list.add', '123') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Neighbor list not in manual mode') + + # Try an invalid neighbor-list mode + r = self.do_set('bts.0.neighbor-list.mode', 'qwertzuiop') + print('respose: ' + str(r)) + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Invalid mode') class TestCtrlBSCNeighbor(TestCtrlBase): -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id97bc0d31a358db6221c385761773fb48670c921 Gerrit-Change-Number: 25996 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:25:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 17:25:30 +0000 Subject: Change in osmo-bsc[master]: control.adoc: comment out fixme note In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26052 ) Change subject: control.adoc: comment out fixme note ...................................................................... control.adoc: comment out fixme note The fixme note: "FIXME: add variables defined in src/ctrl/control_if.c?" is not directed at the reader of the manual. It should stay in the source, but it should not be visible in the pdf. Lets comment it out. Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 --- M doc/manuals/chapters/control.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/control.adoc b/doc/manuals/chapters/control.adoc index 695dd80..09e828e 100644 --- a/doc/manuals/chapters/control.adoc +++ b/doc/manuals/chapters/control.adoc @@ -148,4 +148,4 @@ NOTE: The bsic-number () can also be set to "any" if no explcit bsic shall be given -FIXME: add variables defined in src/ctrl/control_if.c? +//FIXME: add variables defined in src/ctrl/control_if.c? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 Gerrit-Change-Number: 26052 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:31:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 17:31:57 +0000 Subject: Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26090 ) Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors ...................................................................... scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors Recent commit (see below) changed a check to avoid weird results for msg which had l2h=NULL, since l2len would return unexpected results there. However, some code branches like FACCH or TCH seem to be always setting l2h even if len=0. Hence, we must test either of the 2 scenarios (null pointer and l2len()). This commit fixes the following message appearing all the time during calls: """ TCH/F: Prim has odd len=0 != 23 """ Fixes: fb905b8d235ff2efe6c1cd9fde2b488b311c1cd7 Related: SYS#5676 Related: SYS#4919 Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 --- M src/common/scheduler.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/26090/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 0388445..ba5c18a 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -869,7 +869,7 @@ OSMO_ASSERT(l1sap->oph.msg); /* ignore empty frame */ - if (!l1sap->oph.msg->l2h) { + if (!l1sap->oph.msg->l2h || msgb_l2len(l1sap->oph.msg) == 0) { msgb_free(l1sap->oph.msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 Gerrit-Change-Number: 26090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 17:45:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 17:45:39 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Change log level to debug for line informi... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26091 ) Change subject: bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim ...................................................................... bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim This scenario is actually expected when the call is being set up or torn down, since we may not be receiving RTP from the MGW to send to the MS. Hence, let's lower the log level to DEBUG to avoid having log clogged for each call start/stop if INFO is used. Related: SYS#5676 Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/91/26091/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index a6fcd7a..85ab321 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -537,7 +537,7 @@ 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, }; - LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No TCH or FACCH prim for transmit.\n"); + LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "No TCH or FACCH prim for transmit.\n"); gsm0503_tch_fr_encode(*bursts_p, dummy, sizeof(dummy), 1); goto send_burst; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 Gerrit-Change-Number: 26091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:15:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 19:15:04 +0000 Subject: Change in osmo-bts[master]: abis: Drop unneded if condition in else clause References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26092 ) Change subject: abis: Drop unneded if condition in else clause ...................................................................... abis: Drop unneded if condition in else clause priv->current_bsc will for sure be != last, otherwise it would have entered the if clause above it. Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 --- M src/common/abis.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/26092/1 diff --git a/src/common/abis.c b/src/common/abis.c index c0cd18c..06e6f3b 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -126,7 +126,7 @@ if (!priv->current_bsc || priv->current_bsc == last) /* Pick first one (wrap around): */ priv->current_bsc = (struct bsc_oml_host *)llist_first_entry(&bts->bsc_oml_hosts, struct bsc_oml_host, list); - else if (priv->current_bsc != last) + else priv->current_bsc = (struct bsc_oml_host *)llist_entry(priv->current_bsc->list.next, struct bsc_oml_host, list); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 Gerrit-Change-Number: 26092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Nov 3 19:26:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 19:26:02 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6182e24cb9794_26f62ae79e4a05f01950f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 299s] checking for gcc option to produce PIC... -fPIC -DPIC [ 299s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 299s] checking if gcc static flag -static works... no [ 299s] checking if gcc supports -c -o file.o... yes [ 299s] checking if gcc supports -c -o file.o... (cached) yes [ 299s] checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes [ 299s] checking whether -lc should be explicitly linked in... no [ 300s] checking dynamic linker characteristics... GNU/Linux ld.so [ 300s] checking how to hardcode library paths into programs... immediate [ 300s] checking whether stripping libraries is possible... yes [ 300s] checking if libtool supports shared libraries... yes [ 300s] checking whether to build shared libraries... yes [ 300s] checking whether to build static libraries... yes [ 300s] checking for pkg-config... /usr/bin/pkg-config [ 300s] checking for x86_64-redhat-linux-gnu-pkg-config... /usr/bin/x86_64-redhat-linux-gnu-pkg-config [ 300s] checking pkg-config is at least version 0.20... yes [ 300s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 300s] error: Bad exit status from /var/tmp/rpm-tmp.zl5yxM (%build) [ 300s] [ 300s] [ 300s] RPM build errors: [ 300s] Bad exit status from /var/tmp/rpm-tmp.zl5yxM (%build) [ 300s] ### VM INTERACTION START ### [ 301s] Powering off. [ 301s] [ 244.130765] reboot: Power down [ 301s] ### VM INTERACTION END ### [ 301s] [ 301s] lamb28 failed "build osmo-hnodeb.spec" at Wed Nov 3 19:25:42 UTC 2021. [ 301s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:29:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Nov 2021 19:29:36 +0000 Subject: Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one ...................................................................... abis: Try one reconnect to previously connected BSC before trying next one This way we keep all BTS connected to the same BSC if there was a spurious network problem. Related: SYS#4971 Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 --- M src/common/abis.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/93/26093/1 diff --git a/src/common/abis.c b/src/common/abis.c index 06e6f3b..4afe81a 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -82,6 +82,7 @@ struct bsc_oml_host *current_bsc; struct gsm_bts *bts; char *model_name; + bool reconnect_to_current_bsc; }; static void reset_oml_link(struct gsm_bts *bts) @@ -122,6 +123,13 @@ return -1; } + /* Keep current pointer to priv->current_bsc: */ + if (priv->reconnect_to_current_bsc) { + OSMO_ASSERT(priv->current_bsc); + priv->reconnect_to_current_bsc = false; + return 0; + } + last = (struct bsc_oml_host *)llist_last_entry(&bts->bsc_oml_hosts, struct bsc_oml_host, list); if (!priv->current_bsc || priv->current_bsc == last) /* Pick first one (wrap around): */ @@ -233,6 +241,9 @@ * line when something goes wrong... */ } bts_model_abis_close(bts); + + /* We want to try reconnecting to the current BSC at least once before switching to a new one: */ + priv->reconnect_to_current_bsc = true; osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_WAIT_RECONNECT, OML_RETRY_TIMER, 0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:33:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:33:33 +0000 Subject: Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26090 ) Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 Gerrit-Change-Number: 26090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 19:33:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:33:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:33:44 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Change log level to debug for line informi... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26091 ) Change subject: bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 Gerrit-Change-Number: 26091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 19:33:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:34:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:34:16 +0000 Subject: Change in osmo-bts[master]: abis: Drop unneded if condition in else clause In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26092 ) Change subject: abis: Drop unneded if condition in else clause ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 Gerrit-Change-Number: 26092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Nov 2021 19:34:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:34:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:34:58 +0000 Subject: Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Nov 2021 19:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:36:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:36:23 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c at 2155 PS1, Line 2155: switch (lchan->activate.info.chreq_reason) { > Just raising the topic: I often have the feeling these long chunks of code affect readability of the [?] sounds like an excellent idea, but that could be a further cleanup on top of this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 19:36:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:36:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:36:40 +0000 Subject: Change in osmo-bsc[master]: drop unused gsm48_tx_mm_serv_ack() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26069 ) Change subject: drop unused gsm48_tx_mm_serv_ack() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea Gerrit-Change-Number: 26069 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 19:36:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:37:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:37:10 +0000 Subject: Change in osmo-bsc[master]: cosmetic tweaks on handover counting code In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26070 ) Change subject: cosmetic tweaks on handover counting code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 Gerrit-Change-Number: 26070 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 19:37:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 19:37:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Nov 2021 19:37:36 +0000 Subject: Change in osmo-bsc[master]: tweak intra-bsc ho counter descriptions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26071 ) Change subject: tweak intra-bsc ho counter descriptions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 Gerrit-Change-Number: 26071 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Nov 2021 19:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Nov 3 19:42:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 19:42:04 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <6182e60e56d5e_26f62ae79e4a05f0204558@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 73s] checking for gcc option to produce PIC... -fPIC -DPIC [ 73s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 73s] checking if gcc static flag -static works... no [ 74s] checking if gcc supports -c -o file.o... yes [ 74s] checking if gcc supports -c -o file.o... (cached) yes [ 74s] checking whether the gcc linker (/usr/armv7hl-suse-linux-gnueabi/bin/ld) supports shared libraries... yes [ 74s] checking whether -lc should be explicitly linked in... no [ 74s] checking dynamic linker characteristics... GNU/Linux ld.so [ 74s] checking how to hardcode library paths into programs... immediate [ 74s] checking whether stripping libraries is possible... yes [ 74s] checking if libtool supports shared libraries... yes [ 74s] checking whether to build shared libraries... yes [ 74s] checking whether to build static libraries... yes [ 74s] checking for pkg-config... /usr/bin/pkg-config [ 74s] checking for armv7hl-suse-linux-gnueabi-pkg-config... /usr/bin/armv7hl-suse-linux-gnueabi-pkg-config [ 74s] checking pkg-config is at least version 0.20... yes [ 74s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 74s] error: Bad exit status from /var/tmp/rpm-tmp.9ufPzG (%build) [ 74s] [ 74s] [ 74s] RPM build errors: [ 74s] Bad exit status from /var/tmp/rpm-tmp.9ufPzG (%build) [ 74s] ### VM INTERACTION START ### [ 77s] [ 42.167095][ T383] sysrq: Power Off [ 77s] [ 42.167646][ T15] reboot: Power down [ 77s] ### VM INTERACTION END ### [ 77s] [ 77s] obs-arm-10 failed "build osmo-hnodeb.spec" at Wed Nov 3 19:41:46 UTC 2021. [ 77s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:12:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:12:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182ed4f9c6ae_26f62ae79e4a05f021585c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 227s] # we create a symlink at ./srcfile.adoc pointing at [ 227s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 227s] # is like basename from coreutils, and . is WD. [ 227s] if ! [ -f test-usermanual.adoc ]; then \ [ 227s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 227s] fi [ 227s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 227s] # in ... [ 227s] TEXINPUTS=".." \ [ 227s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 227s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 227s] a2x: resource files: [] [ 227s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 227s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 227s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 227s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 227s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 227s] make[1]: *** [Makefile:363: all] Error 2 [ 227s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 227s] dh_auto_build: error: make -j1 returned exit code 2 [ 227s] make: *** [debian/rules:5: binary] Error 25 [ 227s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 227s] ### VM INTERACTION START ### [ 228s] Powering off. [ 228s] [ 216.904909] reboot: Power down [ 228s] ### VM INTERACTION END ### [ 228s] [ 228s] goat19 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Wed Nov 3 20:12:36 UTC 2021. [ 228s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:14:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:14:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182eda7dd079_26f62ae79e4a05f02162d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 319s] # we create a symlink at ./srcfile.adoc pointing at [ 319s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 319s] # is like basename from coreutils, and . is WD. [ 319s] if ! [ -f test-usermanual.adoc ]; then \ [ 319s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 319s] fi [ 319s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 319s] # in ... [ 319s] TEXINPUTS=".." \ [ 319s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 319s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 319s] a2x: resource files: [] [ 319s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 319s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 319s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 319s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 319s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 319s] make[1]: *** [Makefile:363: all] Error 2 [ 319s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 319s] dh_auto_build: error: make -j1 returned exit code 2 [ 319s] make: *** [debian/rules:5: binary] Error 25 [ 319s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 319s] ### VM INTERACTION START ### [ 320s] Powering off. [ 320s] [ 305.131285] reboot: Power down [ 321s] ### VM INTERACTION END ### [ 321s] [ 321s] sheep85 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111030026.dsc" at Wed Nov 3 20:14:17 UTC 2021. [ 321s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:32:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:32:03 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f1e296f39_26f62ae79e4a05f02257e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 232s] # is like basename from coreutils, and . is WD. [ 232s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 232s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 232s] fi [ 232s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 232s] # in /usr/share/osmo-gsm-manuals. [ 232s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 232s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 232s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 232s] a2x: resource files: [] [ 232s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 232s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 232s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 232s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 232s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 232s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 232s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 232s] make[1]: *** [Makefile:392: all] Error 2 [ 232s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 232s] dh_auto_build: error: make -j1 returned exit code 2 [ 232s] make: *** [debian/rules:15: build] Error 25 [ 232s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 232s] ### VM INTERACTION START ### [ 233s] Powering off. [ 233s] [ 222.917991] reboot: Power down [ 233s] ### VM INTERACTION END ### [ 233s] [ 233s] goat07 failed "build osmo-ggsn_1.7.1.dsc" at Wed Nov 3 20:31:56 UTC 2021. [ 233s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:32:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:32:03 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f1e2c6e33_26f62ae79e4a05f022589f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 227s] # is like basename from coreutils, and . is WD. [ 227s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 227s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 227s] fi [ 227s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 227s] # in /usr/share/osmo-gsm-manuals. [ 227s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 227s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 227s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 227s] a2x: resource files: [] [ 227s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 227s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 227s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 227s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 227s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 227s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 227s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 227s] make[1]: *** [Makefile:327: all] Error 2 [ 227s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 227s] dh_auto_build: error: make -j1 returned exit code 2 [ 227s] make: *** [debian/rules:12: build] Error 25 [ 227s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 227s] ### VM INTERACTION START ### [ 228s] Powering off. [ 228s] [ 215.234199] reboot: Power down [ 228s] ### VM INTERACTION END ### [ 229s] [ 229s] goat01 failed "build osmo-sip-connector_1.5.1.dsc" at Wed Nov 3 20:31:57 UTC 2021. [ 229s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:33:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:33:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f21de96af_26f62ae79e4a05f02263d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 317s] # is like basename from coreutils, and . is WD. [ 317s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 317s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 317s] fi [ 317s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 317s] # in /usr/share/osmo-gsm-manuals. [ 317s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 317s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 317s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 317s] a2x: resource files: [] [ 317s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 317s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 317s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 317s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 317s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 317s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 317s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 317s] make[1]: *** [Makefile:371: all] Error 2 [ 317s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 317s] dh_auto_build: error: make -j1 returned exit code 2 [ 317s] make: *** [debian/rules:12: build] Error 25 [ 317s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 317s] ### VM INTERACTION START ### [ 318s] Powering off. [ 318s] [ 302.425357] reboot: Power down [ 318s] ### VM INTERACTION END ### [ 318s] [ 318s] sheep88 failed "build osmo-bts_1.3.3.dsc" at Wed Nov 3 20:33:26 UTC 2021. [ 318s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:33:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:33:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f23c84f1d_26f62ae79e4a05f0226439@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 327s] # is like basename from coreutils, and . is WD. [ 327s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 327s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 327s] fi [ 327s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 327s] # in /usr/share/osmo-gsm-manuals. [ 327s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 327s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 328s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 328s] a2x: resource files: [] [ 328s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 328s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 328s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 328s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 328s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 328s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 328s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 328s] make[1]: *** [Makefile:452: all] Error 2 [ 328s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 328s] dh_auto_build: error: make -j1 returned exit code 2 [ 328s] make: *** [debian/rules:6: build] Error 25 [ 328s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 328s] ### VM INTERACTION START ### [ 329s] Powering off. [ 329s] [ 316.631916] reboot: Power down [ 329s] ### VM INTERACTION END ### [ 329s] [ 329s] goat19 failed "build osmo-trx_1.3.1.dsc" at Wed Nov 3 20:33:37 UTC 2021. [ 329s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:34:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:34:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f27a4792a_26f62ae79e4a05f02266b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 385s] # we create a symlink at ./srcfile.adoc pointing at [ 385s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 385s] # is like basename from coreutils, and . is WD. [ 385s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 385s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 385s] fi [ 385s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 385s] # in /usr/share/osmo-gsm-manuals. [ 385s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 385s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 385s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 385s] a2x: resource files: [] [ 385s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 385s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 385s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 385s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 385s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 385s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 385s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 385s] dh_auto_build: error: make -j1 returned exit code 2 [ 385s] make: *** [debian/rules:12: build] Error 25 [ 385s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 385s] ### VM INTERACTION START ### [ 387s] Powering off. [ 387s] [ 373.468039] reboot: Power down [ 387s] ### VM INTERACTION END ### [ 387s] [ 387s] goat15 failed "build osmo-pcu_0.9.1.dsc" at Wed Nov 3 20:34:31 UTC 2021. [ 387s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:43:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:43:10 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f4772955a_26f62ae79e4a05f02302ad@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 875s] # is like basename from coreutils, and . is WD. [ 875s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 875s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 875s] fi [ 875s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 875s] # in /usr/share/osmo-gsm-manuals. [ 875s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 875s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 875s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 875s] a2x: resource files: [] [ 875s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 875s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 875s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 875s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 875s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 875s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 875s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 875s] make[1]: *** [Makefile:377: all] Error 2 [ 875s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 875s] dh_auto_build: error: make -j1 returned exit code 2 [ 875s] make: *** [debian/rules:45: build] Error 25 [ 875s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 875s] ### VM INTERACTION START ### [ 876s] Powering off. [ 876s] [ 829.357791] reboot: Power down [ 876s] ### VM INTERACTION END ### [ 877s] [ 877s] lamb59 failed "build osmo-gbproxy_0.1.2.dsc" at Wed Nov 3 20:42:55 UTC 2021. [ 877s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:45:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:45:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f4ec888bb_26f62ae79e4a05f023106d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 844s] # is like basename from coreutils, and . is WD. [ 844s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 844s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 844s] fi [ 844s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 844s] # in /usr/share/osmo-gsm-manuals. [ 844s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 844s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 844s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 844s] a2x: resource files: [] [ 844s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 844s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 844s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 844s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 844s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 844s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 844s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 844s] make[1]: *** [Makefile:410: all] Error 2 [ 844s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 844s] dh_auto_build: error: make -j1 returned exit code 2 [ 844s] make: *** [debian/rules:7: build] Error 25 [ 844s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 844s] ### VM INTERACTION START ### [ 845s] Powering off. [ 845s] [ 766.039468] reboot: Power down [ 845s] ### VM INTERACTION END ### [ 845s] [ 845s] lamb16 failed "build osmo-hlr_1.3.1.dsc" at Wed Nov 3 20:45:17 UTC 2021. [ 845s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:46:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:46:19 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f52abe673_26f62ae79e4a05f023141@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 904s] # is like basename from coreutils, and . is WD. [ 904s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 904s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 904s] fi [ 904s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 904s] # in /usr/share/osmo-gsm-manuals. [ 904s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 904s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 904s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 904s] a2x: resource files: [] [ 904s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 904s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 904s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 904s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 904s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 904s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 904s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 904s] make[1]: *** [Makefile:403: all] Error 2 [ 904s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 904s] dh_auto_build: error: make -j1 returned exit code 2 [ 904s] make: *** [debian/rules:12: build] Error 25 [ 904s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 904s] ### VM INTERACTION START ### [ 905s] Powering off. [ 905s] [ 797.964434] reboot: Power down [ 905s] ### VM INTERACTION END ### [ 905s] [ 905s] lamb02 failed "build libosmo-sccp_1.4.0.dsc" at Wed Nov 3 20:46:13 UTC 2021. [ 905s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:47:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:47:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f5657fb65_26f62ae79e4a05f023199a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 967s] # is like basename from coreutils, and . is WD. [ 967s] if ! [ -f osmomgw-usermanual.adoc ]; then \ [ 967s] ln -s osmomgw-usermanual.adoc osmomgw-usermanual.adoc; \ [ 967s] fi [ 967s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 967s] # in /usr/share/osmo-gsm-manuals. [ 967s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 967s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomgw-usermanual.adoc [ 968s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 968s] a2x: resource files: [] [ 968s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 968s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 968s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 968s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 968s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 968s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 968s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 968s] make[1]: *** [Makefile:423: all] Error 2 [ 968s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 968s] dh_auto_build: error: make -j1 returned exit code 2 [ 968s] make: *** [debian/rules:17: build] Error 25 [ 968s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 968s] ### VM INTERACTION START ### [ 969s] Powering off. [ 969s] [ 898.303337] reboot: Power down [ 969s] ### VM INTERACTION END ### [ 969s] [ 969s] lamb04 failed "build osmo-mgw_1.8.1.dsc" at Wed Nov 3 20:47:11 UTC 2021. [ 969s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:47:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:47:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f5842ebe5_26f62ae79e4a05f02321b2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 1148s] # is like basename from coreutils, and . is WD. [ 1148s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 1148s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 1148s] fi [ 1148s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1148s] # in /usr/share/osmo-gsm-manuals. [ 1148s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1148s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 1148s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 1148s] a2x: resource files: [] [ 1148s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1148s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 1148s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1148s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 1148s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1148s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 1148s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1148s] make[1]: *** [Makefile:387: all] Error 2 [ 1148s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1148s] dh_auto_build: error: make -j1 returned exit code 2 [ 1149s] make: *** [debian/rules:12: build] Error 25 [ 1149s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1149s] ### VM INTERACTION START ### [ 1150s] Powering off. [ 1150s] [ 1086.133512] reboot: Power down [ 1150s] ### VM INTERACTION END ### [ 1150s] [ 1150s] lamb10 failed "build osmo-remsim_0.2.4.dsc" at Wed Nov 3 20:47:30 UTC 2021. [ 1150s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:52:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:52:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f6ae27e2a_26f62ae79e4a05f02332f0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 1258s] # is like basename from coreutils, and . is WD. [ 1258s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 1258s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 1258s] fi [ 1258s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1258s] # in /usr/share/osmo-gsm-manuals. [ 1258s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1258s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 1258s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 1258s] a2x: resource files: [] [ 1258s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1258s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 1258s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1258s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 1258s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1258s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 1258s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1258s] make[1]: *** [Makefile:368: all] Error 2 [ 1258s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1258s] dh_auto_build: error: make -j1 returned exit code 2 [ 1258s] make: *** [debian/rules:45: build] Error 25 [ 1258s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1258s] ### VM INTERACTION START ### [ 1259s] Powering off. [ 1259s] [ 1151.719414] reboot: Power down [ 1260s] ### VM INTERACTION END ### [ 1260s] [ 1260s] lamb54 failed "build osmo-cbc_0.2.2.dsc" at Wed Nov 3 20:52:26 UTC 2021. [ 1260s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 20:53:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 20:53:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f6eced259_26f62ae79e4a05f02336c5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 411s] # is like basename from coreutils, and . is WD. [ 411s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 411s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 411s] fi [ 411s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 411s] # in /usr/share/osmo-gsm-manuals. [ 411s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 411s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 411s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 411s] a2x: resource files: [] [ 411s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 411s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 411s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 411s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 411s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 411s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 411s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 411s] make[1]: *** [Makefile:391: all] Error 2 [ 411s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 411s] dh_auto_build: error: make -j1 returned exit code 2 [ 411s] make: *** [debian/rules:9: build] Error 25 [ 411s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 411s] ### VM INTERACTION START ### [ 412s] Powering off. [ 412s] [ 401.077374] reboot: Power down [ 412s] ### VM INTERACTION END ### [ 412s] [ 412s] goat11 failed "build osmo-iuh_1.0.0.dsc" at Wed Nov 3 20:53:26 UTC 2021. [ 412s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 21:00:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 21:00:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f89120996_26f62ae79e4a05f0235045@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 833s] # is like basename from coreutils, and . is WD. [ 833s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 833s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 833s] fi [ 833s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 833s] # in /usr/share/osmo-gsm-manuals. [ 833s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 833s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 833s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 833s] a2x: resource files: [] [ 833s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 833s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 833s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 833s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 833s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 833s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 833s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 833s] make[1]: *** [Makefile:377: all] Error 2 [ 833s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 833s] dh_auto_build: error: make -j1 returned exit code 2 [ 833s] make: *** [debian/rules:45: build] Error 25 [ 833s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 833s] ### VM INTERACTION START ### [ 834s] Powering off. [ 834s] [ 749.080250] reboot: Power down [ 835s] ### VM INTERACTION END ### [ 835s] [ 835s] lamb53 failed "build osmo-smlc_0.2.0.dsc" at Wed Nov 3 21:00:48 UTC 2021. [ 835s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 21:03:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 21:03:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182f925898c0_26f62ae79e4a05f02359e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 553s] # is like basename from coreutils, and . is WD. [ 553s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 553s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 553s] fi [ 553s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 553s] # in /usr/share/osmo-gsm-manuals. [ 553s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 553s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 553s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 553s] a2x: resource files: [] [ 553s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 553s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 553s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 553s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 553s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 553s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 553s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 553s] make[1]: *** [Makefile:402: all] Error 2 [ 553s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 553s] dh_auto_build: error: make -j1 returned exit code 2 [ 553s] make: *** [debian/rules:45: build] Error 25 [ 553s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 553s] ### VM INTERACTION START ### [ 554s] Powering off. [ 554s] [ 525.267850] reboot: Power down [ 554s] ### VM INTERACTION END ### [ 554s] [ 554s] lamb23 failed "build osmo-msc_1.7.1.dsc" at Wed Nov 3 21:03:11 UTC 2021. [ 554s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 21:07:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 21:07:10 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182fa1623f1b_26f62ae79e4a05f02377f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 1153s] # is like basename from coreutils, and . is WD. [ 1153s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 1153s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 1153s] fi [ 1153s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1153s] # in /usr/share/osmo-gsm-manuals. [ 1153s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1153s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 1153s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 1153s] a2x: resource files: [] [ 1153s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1153s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 1153s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1153s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 1153s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1153s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 1153s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1153s] make[1]: *** [Makefile:388: all] Error 2 [ 1153s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1153s] dh_auto_build: error: make -j1 returned exit code 2 [ 1153s] make: *** [debian/rules:45: build] Error 25 [ 1153s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1153s] ### VM INTERACTION START ### [ 1154s] Powering off. [ 1154s] [ 1054.403851] reboot: Power down [ 1155s] ### VM INTERACTION END ### [ 1155s] [ 1155s] lamb01 failed "build osmo-bsc_1.7.2.dsc" at Wed Nov 3 21:06:56 UTC 2021. [ 1155s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Nov 3 21:12:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Nov 2021 21:12:52 +0000 Subject: Change in osmo-msc[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25982 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... mncc: rework passing GCR over the MNCC interface Using *unpacked* 'struct osmo_gcr_parsed' in the MNCC PDUs makes the protocol even more complicated than it currently is, and moreover complicates implementing MNCCv8 in the ttcn3-sip-test. Replace 'struct osmo_gcr_parsed' in 'struct gsm_mncc' with a fixed-length buffer, which is supposed to hold the Global Call Reference encoded as per 3GPP TS 29.205. Indicate presence of GCR using the MNCC_F_GCR flag. Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Fixes: I705c860e51637b4537cad65a330ecbaaca96dd5b Related: OS#5164, OS#5282 --- M include/osmocom/msc/mncc.h M src/libmsc/gsm_04_08_cc.c M tests/mncc/mncc_test.ok 3 files changed, 34 insertions(+), 17 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/msc/mncc.h b/include/osmocom/msc/mncc.h index 5002227..06a5dcc 100644 --- a/include/osmocom/msc/mncc.h +++ b/include/osmocom/msc/mncc.h @@ -26,7 +26,6 @@ #include #include -#include #include #include @@ -125,6 +124,7 @@ #define MNCC_F_CCCAP 0x0800 #define MNCC_F_KEYPAD 0x1000 #define MNCC_F_SIGNAL 0x2000 +#define MNCC_F_GCR 0x4000 struct gsm_mncc { /* context based information */ @@ -161,7 +161,10 @@ unsigned char lchan_type; unsigned char lchan_mode; - struct osmo_gcr_parsed gcr; + + /* Global Call Reference (encoded as per 3GPP TS 29.205) */ + uint8_t gcr[16]; + /* A buffer to contain SDP ('\0' terminated) */ char sdp[1024]; }; diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index d6a2864..6562daa 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -320,12 +320,16 @@ trans->paging_request = NULL; /* Get the GCR from the MO call leg (if any). */ - if (!trans->cc.lcls) { + if (!trans->cc.lcls) trans->cc.lcls = trans_lcls_compose(trans, true); - if (trans->cc.lcls) { - trans->cc.lcls->gcr = trans->cc.msg.gcr; + if (trans->cc.lcls && trans->cc.msg.fields & MNCC_F_GCR) { + int rc = osmo_dec_gcr(&trans->cc.lcls->gcr, + &trans->cc.msg.gcr[0], + sizeof(trans->cc.msg.gcr)); + if (rc < 0) + LOG_TRANS(trans, LOGL_ERROR, "Failed to parse GCR\n"); + else trans->cc.lcls->gcr_available = true; - } } osmo_fsm_inst_dispatch(msc_a->c.fi, MSC_A_EV_TRANSACTION_ACCEPTED, trans); @@ -517,8 +521,18 @@ trans->cc.lcls = trans_lcls_compose(trans, true); /* Pass the LCLS GCR on to the MT call leg via MNCC */ - if (trans->cc.lcls) - setup.gcr = trans->cc.lcls->gcr; + if (trans->cc.lcls) { + struct msgb *gcr_msg = msgb_alloc(sizeof(setup.gcr), "MNCC GCR"); + const struct osmo_gcr_parsed *gcr = &trans->cc.lcls->gcr; + int rc; + + if (gcr_msg != NULL && (rc = osmo_enc_gcr(gcr_msg, gcr)) > 0) { + memcpy(&setup.gcr[0], gcr_msg->data, rc); + setup.fields |= MNCC_F_GCR; + } else + LOG_TRANS(trans, LOGL_ERROR, "Failed to encode GCR\n"); + msgb_free(gcr_msg); + } tlv_parse(&tp, &gsm48_att_tlvdef, gh->data, payload_len, 0, 0); /* emergency setup is identified by msg_type */ diff --git a/tests/mncc/mncc_test.ok b/tests/mncc/mncc_test.ok index 7cb1201..059e808 100644 --- a/tests/mncc/mncc_test.ok +++ b/tests/mncc/mncc_test.ok @@ -1,15 +1,15 @@ test_sdp_termination() struct gsm_mncc: -empty SDP: len=1872 sdplen=1024 sdp="\0" rc=0 -empty SDP, shortest possible: len=849 sdplen=1 sdp="\0" rc=0 -empty SDP, zero len: len=848 sdplen=0 sdp=- rc=-22 -terminated SDP str: len=1872 sdplen=1024 sdp="Privacy is a desirable marketing option\0" rc=0 -terminated SDP str, shortest possible: len=888 sdplen=40 sdp="Privacy is a desirable marketing option\0" rc=0 -terminated SDP str, but len excludes nul: len=887 sdplen=39 sdp="Privacy is a desirable marketing option" rc=-22 -terminated SDP str, but len too short: len=871 sdplen=23 sdp="Privacy is a desirable " rc=-22 -len way too short: len=10 sdplen=-838 sdp=- rc=-22 -len zero: len=0 sdplen=-848 sdp=- rc=-22 +empty SDP: len=1876 sdplen=1026 sdp="\0" rc=0 +empty SDP, shortest possible: len=851 sdplen=1 sdp="\0" rc=0 +empty SDP, zero len: len=850 sdplen=0 sdp=- rc=-22 +terminated SDP str: len=1876 sdplen=1026 sdp="Privacy is a desirable marketing option\0" rc=0 +terminated SDP str, shortest possible: len=890 sdplen=40 sdp="Privacy is a desirable marketing option\0" rc=0 +terminated SDP str, but len excludes nul: len=889 sdplen=39 sdp="Privacy is a desirable marketing option" rc=-22 +terminated SDP str, but len too short: len=873 sdplen=23 sdp="Privacy is a desirable " rc=-22 +len way too short: len=10 sdplen=-840 sdp=- rc=-22 +len zero: len=0 sdplen=-850 sdp=- rc=-22 struct gsm_mncc_rtp: empty SDP: len=1168 sdplen=1024 sdp="\0" rc=0 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I259b6d7e4cbe26159b9b496356fc7c1c27d54521 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 3 21:13:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Nov 2021 21:13:03 +0000 Subject: Change in osmo-sip-connector[master]: mncc: rework passing GCR over the MNCC interface In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/25980 ) Change subject: mncc: rework passing GCR over the MNCC interface ...................................................................... mncc: rework passing GCR over the MNCC interface Using *unpacked* 'struct osmo_gcr_parsed' in the MNCC PDUs makes the protocol even more complicated than it currently is, and moreover complicates implementing MNCCv8 in the ttcn3-sip-test. Replace 'struct osmo_gcr_parsed' in 'struct gsm_mncc' with a fixed-length buffer, which is supposed to hold the Global Call Reference encoded as per 3GPP TS 29.205. Check / indicate presence of GCR using the MNCC_F_GCR flag. Change-Id: Iaff46732948f8f5d03e42f17c35cbac8a80af49b Fixes: Id40d7e0fed9356f801b3627c118150055e7232b1 Related: OS#5164, OS#5282 --- M src/mncc.c M src/mncc_protocol.h 2 files changed, 31 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/mncc.c b/src/mncc.c index c8bf4bd..f302b3e 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -485,6 +485,7 @@ const struct gsm_mncc_number *called; struct call *call; struct mncc_call_leg *leg; + struct osmo_gcr_parsed gcr; if (rc < sizeof(*data)) { LOGP(DMNCC, LOGL_ERROR, "gsm_mncc of wrong size %d vs. %zu\n", @@ -525,6 +526,16 @@ return; } + /* Decode the Global Call Reference (if present) */ + if (data->fields & MNCC_F_GCR) { + if (osmo_dec_gcr(&gcr, data->gcr, sizeof(data->gcr)) < 0) { + LOGP(DMNCC, LOGL_ERROR, + "MNCC leg(%u) failed to parse GCR\n", data->callref); + mncc_send(conn, MNCC_REJ_REQ, data->callref); + return; + } + } + /* Create an RTP port and then allocate a call */ call = call_mncc_create(); if (!call) { @@ -543,12 +554,15 @@ leg->conn = conn; leg->state = MNCC_CC_INITIAL; leg->dir = MNCC_DIR_MO; - leg->base.call->gcr = data->gcr; - leg->base.call->gcr_present = true; memcpy(&leg->called, called, sizeof(leg->called)); memcpy(&leg->calling, &data->calling, sizeof(leg->calling)); memcpy(&leg->imsi, data->imsi, sizeof(leg->imsi)); + if (data->fields & MNCC_F_GCR) { + leg->base.call->gcr_present = true; + leg->base.call->gcr = gcr; + } + LOGP(DMNCC, LOGL_INFO, "Created call(%u) with MNCC leg(%u) IMSI(%.16s)\n", call->id, leg->callref, data->imsi); @@ -873,6 +887,7 @@ { struct mncc_call_leg *leg; struct gsm_mncc mncc = { 0, }; + struct msgb *msg; int rc; leg = talloc_zero(call, struct mncc_call_leg); @@ -900,8 +915,6 @@ mncc.fields |= MNCC_F_CALLING; mncc.calling.plan = GSM48_NPI_ISDN_E164; - if (call->gcr_present) - mncc.gcr = call->gcr; if (call->source && call->source[0] == '+') { mncc.calling.type = GSM48_TON_INTERNATIONAL; @@ -920,6 +933,16 @@ OSMO_STRLCPY_ARRAY(mncc.called.number, call->dest); } + /* Encode the Global Call Reference (if present) */ + if (call->gcr_present) { + msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR"); + if (msg == NULL || (rc = osmo_enc_gcr(msg, &call->gcr)) == 0) + LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode GCR\n", call->id); + else + memcpy(&mncc.gcr[0], msg->data, rc); + msgb_free(msg); + } + /* * TODO/FIXME: * - Determine/request channel based on offered audio codecs diff --git a/src/mncc_protocol.h b/src/mncc_protocol.h index 11969ee..cd592ad 100644 --- a/src/mncc_protocol.h +++ b/src/mncc_protocol.h @@ -26,7 +26,6 @@ #include #include -#include #include #include @@ -124,6 +123,7 @@ #define MNCC_F_CCCAP 0x0800 #define MNCC_F_KEYPAD 0x1000 #define MNCC_F_SIGNAL 0x2000 +#define MNCC_F_GCR 0x4000 struct gsm_mncc { /* context based information */ @@ -160,7 +160,9 @@ unsigned char lchan_type; unsigned char lchan_mode; - struct osmo_gcr_parsed gcr; + + /* Global Call Reference (encoded as per 3GPP TS 29.205) */ + uint8_t gcr[16]; /* A buffer to contain SDP ('\0' terminated) */ char sdp[1024]; -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/25980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Iaff46732948f8f5d03e42f17c35cbac8a80af49b Gerrit-Change-Number: 25980 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Nov 3 21:13:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 21:13:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6182fb9d5ec3a_26f62ae79e4a05f02396af@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 1176s] # is like basename from coreutils, and . is WD. [ 1176s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 1176s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 1176s] fi [ 1176s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1176s] # in /usr/share/osmo-gsm-manuals. [ 1176s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1176s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 1177s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 1177s] a2x: resource files: [] [ 1177s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1177s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 1177s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1177s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 1177s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1177s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 1177s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1177s] make[1]: *** [Makefile:394: all] Error 2 [ 1177s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1177s] dh_auto_build: error: make -j1 returned exit code 2 [ 1177s] make: *** [debian/rules:45: build] Error 25 [ 1177s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1177s] ### VM INTERACTION START ### [ 1178s] Powering off. [ 1178s] [ 1059.335404] reboot: Power down [ 1178s] ### VM INTERACTION END ### [ 1178s] [ 1178s] lamb25 failed "build osmo-sgsn_1.7.1.dsc" at Wed Nov 3 21:13:31 UTC 2021. [ 1178s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 21:14:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 21:14:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <6182fbd833700_26f62ae79e4a05f02398d0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 116s] checking for gcc option to produce PIC... -fPIC -DPIC [ 117s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 117s] checking if gcc static flag -static works... no [ 117s] checking if gcc supports -c -o file.o... yes [ 117s] checking if gcc supports -c -o file.o... (cached) yes [ 117s] checking whether the gcc linker (/usr/aarch64-suse-linux/bin/ld) supports shared libraries... yes [ 117s] checking whether -lc should be explicitly linked in... no [ 117s] checking dynamic linker characteristics... GNU/Linux ld.so [ 117s] checking how to hardcode library paths into programs... immediate [ 117s] checking whether stripping libraries is possible... yes [ 117s] checking if libtool supports shared libraries... yes [ 117s] checking whether to build shared libraries... yes [ 117s] checking whether to build static libraries... yes [ 117s] checking for pkg-config... /usr/bin/pkg-config [ 117s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config [ 117s] checking pkg-config is at least version 0.20... yes [ 117s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 117s] error: Bad exit status from /var/tmp/rpm-tmp.tPA4Fe (%build) [ 117s] [ 117s] [ 117s] RPM build errors: [ 117s] Bad exit status from /var/tmp/rpm-tmp.tPA4Fe (%build) [ 117s] ### VM INTERACTION START ### [ 121s] [ 78.460988][ T385] sysrq: Power Off [ 121s] [ 78.463659][ T15] reboot: Power down [ 121s] ### VM INTERACTION END ### [ 121s] [ 121s] obs-arm-8 failed "build osmo-hnodeb.spec" at Wed Nov 3 21:14:45 UTC 2021. [ 121s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 3 22:57:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 03 Nov 2021 22:57:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <618313fb87e8f_26f62ae79e4a05f025774b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 153s] checking for gcc option to produce PIC... -fPIC -DPIC [ 153s] checking if gcc PIC flag -fPIC -DPIC works... yes [ 153s] checking if gcc static flag -static works... no [ 153s] checking if gcc supports -c -o file.o... yes [ 153s] checking if gcc supports -c -o file.o... (cached) yes [ 153s] checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes [ 153s] checking whether -lc should be explicitly linked in... no [ 153s] checking dynamic linker characteristics... GNU/Linux ld.so [ 153s] checking how to hardcode library paths into programs... immediate [ 153s] checking whether stripping libraries is possible... yes [ 153s] checking if libtool supports shared libraries... yes [ 153s] checking whether to build shared libraries... yes [ 153s] checking whether to build static libraries... yes [ 153s] checking for pkg-config... /usr/bin/pkg-config [ 153s] checking for aarch64-redhat-linux-gnu-pkg-config... /usr/bin/aarch64-redhat-linux-gnu-pkg-config [ 153s] checking pkg-config is at least version 0.20... yes [ 153s] configure: error: Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect. [ 153s] error: Bad exit status from /var/tmp/rpm-tmp.y0hKtY (%build) [ 153s] [ 153s] [ 153s] RPM build errors: [ 153s] Bad exit status from /var/tmp/rpm-tmp.y0hKtY (%build) [ 154s] ### VM INTERACTION START ### [ 155s] Powering off. [ 155s] [ 132.632423] reboot: Power down [ 155s] ### VM INTERACTION END ### [ 155s] [ 155s] obs-arm-9 failed "build osmo-hnodeb.spec" at Wed Nov 3 22:57:30 UTC 2021. [ 155s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:35:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:35:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61832af1e878c_26f62ae79e4a05f02754a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 28s] CC bsc_ctrl_commands.lo [ 28s] CC bsc_ctrl_lookup.lo [ 28s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 28s] bsc_ctrl_commands.c:756:13: error: 'mode' may be used uninitialized [-Werror=maybe-uninitialized] [ 28s] 756 | int mode; [ 28s] | ^~~~ [ 28s] CC bsc_init.lo [ 28s] CC bsc_rf_ctrl.lo [ 29s] cc1: some warnings being treated as errors [ 29s] make[3]: *** [Makefile:768: bsc_ctrl_commands.lo] Error 1 [ 29s] make[3]: *** Waiting for unfinished jobs.... [ 31s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 31s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 31s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 31s] make[1]: *** [Makefile:454: all-recursive] Error 1 [ 31s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 31s] make: *** [Makefile:386: all] Error 2 [ 31s] error: Bad exit status from /var/tmp/rpm-tmp.nYIOWl (%build) [ 31s] [ 31s] [ 31s] RPM build errors: [ 31s] Bad exit status from /var/tmp/rpm-tmp.nYIOWl (%build) [ 31s] ### VM INTERACTION START ### [ 34s] [ 30.266538][ T418] sysrq: Power Off [ 34s] [ 30.280084][ T417] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] goat19 failed "build osmo-bsc.spec" at Thu Nov 4 00:35:36 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:37:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:37:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61832b6a640a6_26f62ae79e4a05f027611b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 55s] CC abis_rsl.lo [ 55s] CC acc.lo [ 56s] CC assignment_fsm.lo [ 56s] CC bsc_ctrl_commands.lo [ 56s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 56s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 56s] int mode; [ 56s] ^~~~ [ 56s] cc1: some warnings being treated as errors [ 56s] make[3]: *** [Makefile:714: bsc_ctrl_commands.lo] Error 1 [ 56s] make[3]: *** Waiting for unfinished jobs.... [ 59s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 59s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 59s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 59s] make[1]: *** [Makefile:452: all-recursive] Error 1 [ 59s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 59s] make: *** [Makefile:384: all] Error 2 [ 59s] error: Bad exit status from /var/tmp/rpm-tmp.WfQel6 (%build) [ 59s] [ 59s] [ 59s] RPM build errors: [ 59s] Bad exit status from /var/tmp/rpm-tmp.WfQel6 (%build) [ 59s] ### VM INTERACTION START ### [ 62s] [ 51.463713] sysrq: Power Off [ 62s] [ 51.467540] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] old-cirrus2 failed "build osmo-bsc.spec" at Thu Nov 4 00:37:46 UTC 2021. [ 62s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:38:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:38:23 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61832b8920641_26f62ae79e4a05f027628e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 437s] # we create a symlink at ./srcfile.adoc pointing at [ 437s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 437s] # is like basename from coreutils, and . is WD. [ 437s] if ! [ -f test-usermanual.adoc ]; then \ [ 437s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 437s] fi [ 437s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 437s] # in ... [ 437s] TEXINPUTS=".." \ [ 437s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 437s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 437s] a2x: resource files: [] [ 437s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 437s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 437s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 437s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 437s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 437s] make[1]: *** [Makefile:363: all] Error 2 [ 437s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 437s] dh_auto_build: error: make -j1 returned exit code 2 [ 437s] make: *** [debian/rules:5: binary] Error 25 [ 437s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 437s] ### VM INTERACTION START ### [ 438s] Powering off. [ 438s] [ 413.960389] reboot: Power down [ 438s] ### VM INTERACTION END ### [ 438s] [ 438s] lamb09 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111040026.dsc" at Thu Nov 4 00:38:14 UTC 2021. [ 438s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:38:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:38:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61832ba833e47_26f62ae79e4a05f02764a1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 59s] CC bsc_ctrl_lookup.lo [ 59s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 59s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 59s] int mode; [ 59s] ^~~~ [ 59s] CC bsc_init.lo [ 59s] CC bsc_rf_ctrl.lo [ 59s] CC bsc_rll.lo [ 59s] cc1: some warnings being treated as errors [ 59s] make[3]: *** [Makefile:714: bsc_ctrl_commands.lo] Error 1 [ 59s] make[3]: *** Waiting for unfinished jobs.... [ 62s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 62s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 62s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 62s] make[1]: *** [Makefile:452: all-recursive] Error 1 [ 62s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 62s] make: *** [Makefile:384: all] Error 2 [ 62s] error: Bad exit status from /var/tmp/rpm-tmp.oj0owq (%build) [ 62s] [ 62s] [ 62s] RPM build errors: [ 62s] Bad exit status from /var/tmp/rpm-tmp.oj0owq (%build) [ 62s] ### VM INTERACTION START ### [ 65s] [ 54.976540] sysrq: SysRq : Power Off [ 65s] [ 54.984798] reboot: Power down [ 66s] ### VM INTERACTION END ### [ 66s] [ 66s] lamb15 failed "build osmo-bsc.spec" at Thu Nov 4 00:38:56 UTC 2021. [ 66s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:38:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:38:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61832ba87b28c_26f62ae79e4a05f027658b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 81s] CC abis_rsl.lo [ 81s] CC acc.lo [ 83s] CC assignment_fsm.lo [ 84s] CC bsc_ctrl_commands.lo [ 85s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 85s] bsc_ctrl_commands.c:756:13: error: 'mode' may be used uninitialized [-Werror=maybe-uninitialized] [ 85s] 756 | int mode; [ 85s] | ^~~~ [ 86s] cc1: some warnings being treated as errors [ 86s] make[3]: *** [Makefile:768: bsc_ctrl_commands.lo] Error 1 [ 86s] make[3]: *** Waiting for unfinished jobs.... [ 89s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 89s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 89s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 89s] make[1]: *** [Makefile:454: all-recursive] Error 1 [ 89s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 89s] make: *** [Makefile:386: all] Error 2 [ 89s] error: Bad exit status from /var/tmp/rpm-tmp.N3Lwmv (%build) [ 89s] [ 89s] [ 89s] RPM build errors: [ 89s] Bad exit status from /var/tmp/rpm-tmp.N3Lwmv (%build) [ 89s] ### VM INTERACTION START ### [ 92s] [ 61.121652][ T392] sysrq: Power Off [ 92s] [ 61.155901][ T16] reboot: Power down [ 93s] ### VM INTERACTION END ### [ 93s] [ 93s] cloud103 failed "build osmo-bsc.spec" at Thu Nov 4 00:38:47 UTC 2021. [ 93s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 4 00:39:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 00:39:23 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Drop impossible code path In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26088 ) Change subject: bts-trx: sched_lchan_tchf: Drop impossible code path ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f Gerrit-Change-Number: 26088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 00:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 00:40:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 00:40:17 +0000 Subject: Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26090 ) Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 Gerrit-Change-Number: 26090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 00:40:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 00:41:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 00:41:41 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Change log level to debug for line informi... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26091 ) Change subject: bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim ...................................................................... Patch Set 1: Code-Review+1 We may want to introduce a rate counter for this. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 Gerrit-Change-Number: 26091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 00:41:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 4 00:41:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:41:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/i586 In-Reply-To: References: Message-ID: <61832c5d8a947_26f62ae79e4a05f027706d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 198s] switch (mode) { [ 198s] ^~~~~~ [ 198s] bsc_ctrl_commands.c:756:6: note: 'mode' was declared here [ 198s] int mode; [ 198s] ^~~~ [ 198s] cc1: some warnings being treated as errors [ 198s] Makefile:715: recipe for target 'bsc_ctrl_commands.lo' failed [ 198s] make[4]: *** [bsc_ctrl_commands.lo] Error 1 [ 198s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 198s] Makefile:403: recipe for target 'all-recursive' failed [ 198s] make[3]: *** [all-recursive] Error 1 [ 198s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 198s] Makefile:453: recipe for target 'all-recursive' failed [ 198s] make[2]: *** [all-recursive] Error 1 [ 198s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 198s] Makefile:385: recipe for target 'all' failed [ 198s] make[1]: *** [all] Error 2 [ 198s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 198s] dh_auto_build: make -j1 returned exit code 2 [ 198s] debian/rules:45: recipe for target 'build' failed [ 198s] make: *** [build] Error 2 [ 198s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 198s] ### VM INTERACTION START ### [ 201s] [ 190.621983] sysrq: Power Off [ 201s] [ 190.631010] reboot: Power down [ 201s] ### VM INTERACTION END ### [ 201s] [ 201s] sheep82 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:41:33 UTC 2021. [ 201s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 4 00:43:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 00:43:33 +0000 Subject: Change in osmo-bts[master]: abis: Drop unneded if condition in else clause In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26092 ) Change subject: abis: Drop unneded if condition in else clause ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 Gerrit-Change-Number: 26092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 00:43:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 4 00:44:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:44:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61832cf41b82f_26f62ae79e4a05f02773a6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 70s] CC bsc_ctrl_commands.lo [ 70s] CC bsc_ctrl_lookup.lo [ 70s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 70s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 70s] int mode; [ 70s] ^~~~ [ 70s] CC bsc_init.lo [ 70s] CC bsc_rf_ctrl.lo [ 70s] cc1: some warnings being treated as errors [ 70s] make[3]: *** [Makefile:768: bsc_ctrl_commands.lo] Error 1 [ 70s] make[3]: *** Waiting for unfinished jobs.... [ 73s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 73s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 73s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 73s] make[1]: *** [Makefile:452: all-recursive] Error 1 [ 73s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 73s] make: *** [Makefile:384: all] Error 2 [ 73s] error: Bad exit status from /var/tmp/rpm-tmp.F40P87 (%build) [ 73s] [ 73s] [ 73s] RPM build errors: [ 73s] Bad exit status from /var/tmp/rpm-tmp.F40P87 (%build) [ 73s] ### VM INTERACTION START ### [ 74s] Powering off. [ 74s] [ 65.427564] reboot: Power down [ 74s] ### VM INTERACTION END ### [ 74s] [ 74s] goat01 failed "build osmo-bsc.spec" at Thu Nov 4 00:43:55 UTC 2021. [ 74s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 4 00:45:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 00:45:00 +0000 Subject: Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 00:45:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 4 00:47:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:47:14 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <61832da4ddc8b_26f62ae79e4a05f02777ef@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 307s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 308s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 308s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 310s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 311s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 311s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 312s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 312s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 312s] int mode; [ 312s] ^~~~ [ 312s] cc1: some warnings being treated as errors [ 312s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 312s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 312s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 312s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 312s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 312s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 312s] make[1]: *** [Makefile:385: all] Error 2 [ 312s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 312s] dh_auto_build: make -j1 returned exit code 2 [ 312s] make: *** [debian/rules:45: build] Error 2 [ 312s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 312s] ### VM INTERACTION START ### [ 315s] [ 300.026874] sysrq: Power Off [ 315s] [ 300.034030] reboot: Power down [ 315s] ### VM INTERACTION END ### [ 315s] [ 315s] lamb19 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:46:59 UTC 2021. [ 315s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:47:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:47:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <61832dc433b7d_26f62ae79e4a05f02778d6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 123s] switch (mode) { [ 123s] ^~~~~~ [ 123s] bsc_ctrl_commands.c:756:6: note: 'mode' was declared here [ 123s] int mode; [ 123s] ^~~~ [ 123s] cc1: some warnings being treated as errors [ 123s] Makefile:715: recipe for target 'bsc_ctrl_commands.lo' failed [ 123s] make[4]: *** [bsc_ctrl_commands.lo] Error 1 [ 123s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 123s] Makefile:403: recipe for target 'all-recursive' failed [ 123s] make[3]: *** [all-recursive] Error 1 [ 123s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 123s] Makefile:453: recipe for target 'all-recursive' failed [ 123s] make[2]: *** [all-recursive] Error 1 [ 123s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 123s] Makefile:385: recipe for target 'all' failed [ 123s] make[1]: *** [all] Error 2 [ 123s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 123s] dh_auto_build: make -j1 returned exit code 2 [ 123s] debian/rules:45: recipe for target 'build' failed [ 123s] make: *** [build] Error 2 [ 123s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 123s] ### VM INTERACTION START ### [ 126s] [ 118.931843] sysrq: Power Off [ 126s] [ 118.935245] reboot: Power down [ 126s] ### VM INTERACTION END ### [ 126s] [ 126s] goat13 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:47:47 UTC 2021. [ 126s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:52:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:52:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61832ed1ce3b4_26f62ae79e4a05f02782dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_10/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 179s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 179s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 179s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 180s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 181s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 181s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 181s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 181s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 181s] int mode; [ 181s] ^~~~ [ 181s] cc1: some warnings being treated as errors [ 181s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 181s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 181s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 181s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 181s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 181s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 181s] make[1]: *** [Makefile:385: all] Error 2 [ 181s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 181s] dh_auto_build: make -j1 returned exit code 2 [ 181s] make: *** [debian/rules:45: build] Error 2 [ 181s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 181s] ### VM INTERACTION START ### [ 184s] [ 174.633825] sysrq: Power Off [ 184s] [ 174.637656] reboot: Power down [ 184s] ### VM INTERACTION END ### [ 184s] [ 184s] goat05 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:52:04 UTC 2021. [ 184s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:52:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:52:22 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61832ed25fee9_26f62ae79e4a05f02783a5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 520s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 521s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 521s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 521s] int mode; [ 521s] ^~~~ [ 521s] cc1: some warnings being treated as errors [ 521s] Makefile:715: recipe for target 'bsc_ctrl_commands.lo' failed [ 521s] make[4]: *** [bsc_ctrl_commands.lo] Error 1 [ 521s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 521s] Makefile:403: recipe for target 'all-recursive' failed [ 521s] make[3]: *** [all-recursive] Error 1 [ 521s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 521s] Makefile:453: recipe for target 'all-recursive' failed [ 521s] make[2]: *** [all-recursive] Error 1 [ 521s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 521s] Makefile:385: recipe for target 'all' failed [ 521s] make[1]: *** [all] Error 2 [ 521s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 521s] dh_auto_build: make -j1 returned exit code 2 [ 521s] debian/rules:45: recipe for target 'build' failed [ 521s] make: *** [build] Error 2 [ 521s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 521s] ### VM INTERACTION START ### [ 524s] [ 505.685335] sysrq: Power Off [ 524s] [ 505.739324] reboot: Power down [ 524s] ### VM INTERACTION END ### [ 524s] [ 524s] lamb01 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:52:16 UTC 2021. [ 524s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:56:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:56:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <61832fe343743_26f62ae79e4a05f02788dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 397s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 397s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 397s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 399s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 401s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 401s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 401s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 401s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 401s] 756 | int mode; [ 401s] | ^~~~ [ 401s] cc1: some warnings being treated as errors [ 401s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 401s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 401s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 401s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 401s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 401s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 401s] make[1]: *** [Makefile:385: all] Error 2 [ 401s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 401s] dh_auto_build: error: make -j1 returned exit code 2 [ 401s] make: *** [debian/rules:45: build] Error 25 [ 401s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 402s] ### VM INTERACTION START ### [ 403s] Powering off. [ 403s] [ 385.688222] reboot: Power down [ 403s] ### VM INTERACTION END ### [ 403s] [ 403s] old-cirrus4 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:56:28 UTC 2021. [ 403s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:56:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:56:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <61832fe3dc897_26f62ae79e4a05f0278994@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_21.10/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 300s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 301s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 301s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 302s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 303s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 304s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 304s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 304s] bsc_ctrl_commands.c:756:13: error: 'mode' may be used uninitialized [-Werror=maybe-uninitialized] [ 304s] 756 | int mode; [ 304s] | ^~~~ [ 304s] cc1: some warnings being treated as errors [ 304s] make[4]: *** [Makefile:770: bsc_ctrl_commands.lo] Error 1 [ 304s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 304s] make[3]: *** [Makefile:404: all-recursive] Error 1 [ 304s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 304s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 304s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 304s] make[1]: *** [Makefile:387: all] Error 2 [ 304s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 304s] dh_auto_build: error: make -j1 returned exit code 2 [ 304s] make: *** [debian/rules:45: build] Error 25 [ 304s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 304s] ### VM INTERACTION START ### [ 305s] Powering off. [ 305s] [ 297.368169] reboot: Power down [ 305s] ### VM INTERACTION END ### [ 305s] [ 305s] goat05 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:56:36 UTC 2021. [ 305s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 00:59:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 00:59:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <618330963efef_26f62ae79e4a05f02794de@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 186s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 187s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 187s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 188s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 189s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 189s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 189s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 189s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 189s] 756 | int mode; [ 189s] | ^~~~ [ 189s] cc1: some warnings being treated as errors [ 189s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 189s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 189s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 189s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 189s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 189s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 189s] make[1]: *** [Makefile:385: all] Error 2 [ 189s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 189s] dh_auto_build: error: make -j1 returned exit code 2 [ 189s] make: *** [debian/rules:45: build] Error 25 [ 189s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 189s] ### VM INTERACTION START ### [ 192s] [ 183.996896] sysrq: Power Off [ 192s] [ 184.000151] reboot: Power down [ 192s] ### VM INTERACTION END ### [ 192s] [ 192s] goat17 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 00:59:27 UTC 2021. [ 192s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 01:00:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 01:00:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_11/x86_64 In-Reply-To: References: Message-ID: <618330d05da3f_26f62ae79e4a05f0279560@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_11/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 394s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 394s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 394s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 396s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 397s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 397s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 398s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 398s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 398s] 756 | int mode; [ 398s] | ^~~~ [ 398s] cc1: some warnings being treated as errors [ 398s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 398s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 398s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 398s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 398s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 398s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 398s] make[1]: *** [Makefile:387: all] Error 2 [ 398s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 398s] dh_auto_build: error: make -j1 returned exit code 2 [ 398s] make: *** [debian/rules:45: build] Error 25 [ 398s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 398s] ### VM INTERACTION START ### [ 399s] Powering off. [ 399s] [ 380.682388] reboot: Power down [ 399s] ### VM INTERACTION END ### [ 399s] [ 399s] old-cirrus4 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 01:00:37 UTC 2021. [ 399s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 01:00:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 01:00:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_11/i586 In-Reply-To: References: Message-ID: <618330d0bf634_26f62ae79e4a05f027965d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_11/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 843s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 844s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 844s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 847s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 850s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 850s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 850s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 850s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 850s] 756 | int mode; [ 850s] | ^~~~ [ 851s] cc1: some warnings being treated as errors [ 851s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 851s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 851s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 851s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 851s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 851s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 851s] make[1]: *** [Makefile:387: all] Error 2 [ 851s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 851s] dh_auto_build: error: make -j1 returned exit code 2 [ 851s] make: *** [debian/rules:45: build] Error 25 [ 851s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 851s] ### VM INTERACTION START ### [ 852s] Powering off. [ 852s] [ 813.049226] reboot: Power down [ 852s] ### VM INTERACTION END ### [ 852s] [ 852s] lamb27 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 01:00:39 UTC 2021. [ 852s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 01:02:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 01:02:02 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <6183312895e35_26f62ae79e4a05f0279883@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 440s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 441s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 441s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 443s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 445s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 445s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 445s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 445s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 445s] 756 | int mode; [ 445s] | ^~~~ [ 446s] cc1: some warnings being treated as errors [ 446s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 446s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 446s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 446s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 446s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 446s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 446s] make[1]: *** [Makefile:387: all] Error 2 [ 446s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 446s] dh_auto_build: error: make -j1 returned exit code 2 [ 446s] make: *** [debian/rules:45: build] Error 25 [ 446s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 446s] ### VM INTERACTION START ### [ 447s] Powering off. [ 447s] [ 424.057140] reboot: Power down [ 447s] ### VM INTERACTION END ### [ 447s] [ 447s] cloud106 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 01:02:00 UTC 2021. [ 447s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 01:04:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 01:04:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_10/i586 In-Reply-To: References: Message-ID: <618331c0446f4_26f62ae79e4a05f0280476@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_10/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 702s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 703s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 703s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 706s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 709s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 710s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 710s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 710s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 710s] int mode; [ 710s] ^~~~ [ 710s] cc1: some warnings being treated as errors [ 710s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 710s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 710s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 710s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 710s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 710s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 710s] make[1]: *** [Makefile:385: all] Error 2 [ 710s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 710s] dh_auto_build: make -j1 returned exit code 2 [ 710s] make: *** [debian/rules:45: build] Error 2 [ 710s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 710s] ### VM INTERACTION START ### [ 714s] [ 618.717701] sysrq: Power Off [ 714s] [ 618.734939] reboot: Power down [ 714s] ### VM INTERACTION END ### [ 714s] [ 714s] cloud138 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 01:04:25 UTC 2021. [ 714s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 01:07:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 01:07:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618332734ba4b_26f62ae79e4a05f0280879@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 464s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 465s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 465s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 467s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 470s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 470s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 471s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 471s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 471s] 756 | int mode; [ 471s] | ^~~~ [ 471s] cc1: some warnings being treated as errors [ 471s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 471s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 471s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 471s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 471s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 471s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 471s] make[1]: *** [Makefile:387: all] Error 2 [ 471s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 471s] dh_auto_build: error: make -j1 returned exit code 2 [ 471s] make: *** [debian/rules:45: build] Error 25 [ 471s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 471s] ### VM INTERACTION START ### [ 472s] Powering off. [ 472s] [ 447.191659] reboot: Power down [ 473s] ### VM INTERACTION END ### [ 473s] [ 473s] cloud125 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 01:07:40 UTC 2021. [ 473s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 01:25:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 01:25:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <6183368c5e1cf_26f62ae79e4a05f02825ec@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 72s] CC abis_rsl.lo [ 72s] CC acc.lo [ 73s] CC assignment_fsm.lo [ 74s] CC bsc_ctrl_commands.lo [ 74s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 74s] bsc_ctrl_commands.c:756:13: error: 'mode' may be used uninitialized [-Werror=maybe-uninitialized] [ 74s] 756 | int mode; [ 74s] | ^~~~ [ 74s] cc1: some warnings being treated as errors [ 74s] make[3]: *** [Makefile:768: bsc_ctrl_commands.lo] Error 1 [ 74s] make[3]: *** Waiting for unfinished jobs.... [ 76s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 76s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 76s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 76s] make[1]: *** [Makefile:454: all-recursive] Error 1 [ 76s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 76s] make: *** [Makefile:386: all] Error 2 [ 76s] error: Bad exit status from /var/tmp/rpm-tmp.1Huj8m (%build) [ 76s] [ 76s] [ 76s] RPM build errors: [ 76s] Bad exit status from /var/tmp/rpm-tmp.1Huj8m (%build) [ 76s] ### VM INTERACTION START ### [ 80s] [ 51.273560][ T384] sysrq: Power Off [ 80s] [ 51.274444][ T15] reboot: Power down [ 80s] ### VM INTERACTION END ### [ 80s] [ 80s] obs-arm-11 failed "build osmo-bsc.spec" at Thu Nov 4 01:24:51 UTC 2021. [ 80s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 02:02:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 02:02:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61833f1d2c993_26f62ae79e4a05f0286148@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 102s] CC abis_rsl.lo [ 104s] CC acc.lo [ 106s] CC assignment_fsm.lo [ 106s] CC bsc_ctrl_commands.lo [ 107s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 107s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 107s] int mode; [ 107s] ^~~~ [ 108s] cc1: some warnings being treated as errors [ 108s] make[3]: *** [Makefile:714: bsc_ctrl_commands.lo] Error 1 [ 108s] make[3]: *** Waiting for unfinished jobs.... [ 116s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 116s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 116s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 116s] make[1]: *** [Makefile:452: all-recursive] Error 1 [ 116s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 116s] make: *** [Makefile:384: all] Error 2 [ 116s] error: Bad exit status from /var/tmp/rpm-tmp.Qgz9DH (%build) [ 116s] [ 116s] [ 116s] RPM build errors: [ 116s] Bad exit status from /var/tmp/rpm-tmp.Qgz9DH (%build) [ 116s] ### VM INTERACTION START ### [ 119s] [ 104.476802] sysrq: SysRq : Power Off [ 119s] [ 104.606338] reboot: Power down [ 120s] ### VM INTERACTION END ### [ 120s] [ 120s] armbuild21 failed "build osmo-bsc.spec" at Thu Nov 4 02:01:59 UTC 2021. [ 120s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 02:11:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 02:11:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <618341731a8c4_26f62ae79e4a05f02878d1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 75s] CC assignment_fsm.lo [ 76s] CC bsc_ctrl_commands.lo [ 77s] CC bsc_ctrl_lookup.lo [ 77s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 77s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 77s] int mode; [ 77s] ^~~~ [ 77s] CC bsc_init.lo [ 77s] cc1: some warnings being treated as errors [ 77s] make[3]: *** [Makefile:714: bsc_ctrl_commands.lo] Error 1 [ 77s] make[3]: *** Waiting for unfinished jobs.... [ 81s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 81s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 81s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 81s] make[1]: *** [Makefile:452: all-recursive] Error 1 [ 81s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 81s] make: *** [Makefile:384: all] Error 2 [ 81s] error: Bad exit status from /var/tmp/rpm-tmp.yhkhkX (%build) [ 81s] [ 81s] [ 81s] RPM build errors: [ 81s] Bad exit status from /var/tmp/rpm-tmp.yhkhkX (%build) [ 81s] ### VM INTERACTION START ### [ 84s] [ 72.125383] sysrq: SysRq : Power Off [ 84s] [ 72.127008] reboot: Power down [ 85s] ### VM INTERACTION END ### [ 85s] [ 85s] obs-arm-8 failed "build osmo-bsc.spec" at Thu Nov 4 02:11:52 UTC 2021. [ 85s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 02:55:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 02:55:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61834bc49c1a5_26f62ae79e4a05f029207c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 101s] CC assignment_fsm.lo [ 101s] CC bsc_ctrl_commands.lo [ 101s] CC bsc_ctrl_lookup.lo [ 102s] CC bsc_init.lo [ 102s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 102s] bsc_ctrl_commands.c:756:13: error: 'mode' may be used uninitialized [-Werror=maybe-uninitialized] [ 102s] 756 | int mode; [ 102s] | ^~~~ [ 103s] cc1: some warnings being treated as errors [ 103s] make[3]: *** [Makefile:768: bsc_ctrl_commands.lo] Error 1 [ 103s] make[3]: *** Waiting for unfinished jobs.... [ 106s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 106s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 106s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 106s] make[1]: *** [Makefile:454: all-recursive] Error 1 [ 106s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 106s] make: *** [Makefile:386: all] Error 2 [ 106s] error: Bad exit status from /var/tmp/rpm-tmp.j7UNg2 (%build) [ 106s] [ 106s] [ 106s] RPM build errors: [ 106s] Bad exit status from /var/tmp/rpm-tmp.j7UNg2 (%build) [ 106s] ### VM INTERACTION START ### [ 110s] [ 85.743576][ T385] sysrq: Power Off [ 110s] [ 85.745648][ T190] reboot: Power down [ 110s] ### VM INTERACTION END ### [ 110s] [ 110s] obs-arm-9 failed "build osmo-bsc.spec" at Thu Nov 4 02:55:24 UTC 2021. [ 110s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 02:55:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 02:55:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61834bc44108c_26f62ae79e4a05f029196e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 147s] CC abis_rsl.lo [ 147s] CC acc.lo [ 149s] CC assignment_fsm.lo [ 150s] CC bsc_ctrl_commands.lo [ 151s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 151s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 151s] int mode; [ 151s] ^~~~ [ 151s] cc1: some warnings being treated as errors [ 151s] make[3]: *** [Makefile:768: bsc_ctrl_commands.lo] Error 1 [ 151s] make[3]: *** Waiting for unfinished jobs.... [ 154s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src/osmo-bsc' [ 154s] make[2]: *** [Makefile:402: all-recursive] Error 1 [ 154s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026/src' [ 154s] make[1]: *** [Makefile:452: all-recursive] Error 1 [ 154s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-bsc-1.7.0.311.9cb63.202111040026' [ 154s] make: *** [Makefile:384: all] Error 2 [ 154s] error: Bad exit status from /var/tmp/rpm-tmp.Hg8gcQ (%build) [ 154s] [ 154s] [ 154s] RPM build errors: [ 154s] Bad exit status from /var/tmp/rpm-tmp.Hg8gcQ (%build) [ 154s] ### VM INTERACTION START ### [ 155s] Powering off. [ 155s] [ 130.262679] reboot: Power down [ 156s] ### VM INTERACTION END ### [ 156s] [ 156s] obs-arm-9 failed "build osmo-bsc.spec" at Thu Nov 4 02:55:34 UTC 2021. [ 156s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 03:38:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 03:38:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <618355d63501f_26f62ae79e4a05f02973f2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-bsc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 682s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 683s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 683s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 688s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 694s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 694s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 695s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 695s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 695s] int mode; [ 695s] ^~~~ [ 696s] cc1: some warnings being treated as errors [ 696s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 696s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 696s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 696s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 696s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 696s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 696s] make[1]: *** [Makefile:385: all] Error 2 [ 696s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 696s] dh_auto_build: make -j1 returned exit code 2 [ 696s] make: *** [debian/rules:45: build] Error 2 [ 696s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 696s] ### VM INTERACTION START ### [ 699s] [ 657.366547] sysrq: SysRq : Power Off [ 699s] [ 657.400594] reboot: Power down [ 699s] ### VM INTERACTION END ### [ 699s] [ 699s] armbuild01 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 03:38:28 UTC 2021. [ 699s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 03:56:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 03:56:16 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <618359efd5426_26f62ae79e4a05f029952d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 1052s] switch (mode) { [ 1052s] ^~~~~~ [ 1052s] bsc_ctrl_commands.c:756:6: note: 'mode' was declared here [ 1052s] int mode; [ 1052s] ^~~~ [ 1053s] cc1: some warnings being treated as errors [ 1053s] Makefile:715: recipe for target 'bsc_ctrl_commands.lo' failed [ 1053s] make[4]: *** [bsc_ctrl_commands.lo] Error 1 [ 1053s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 1053s] Makefile:403: recipe for target 'all-recursive' failed [ 1053s] make[3]: *** [all-recursive] Error 1 [ 1053s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 1053s] Makefile:453: recipe for target 'all-recursive' failed [ 1053s] make[2]: *** [all-recursive] Error 1 [ 1053s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1053s] Makefile:385: recipe for target 'all' failed [ 1053s] make[1]: *** [all] Error 2 [ 1053s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1053s] dh_auto_build: make -j1 returned exit code 2 [ 1053s] debian/rules:45: recipe for target 'build' failed [ 1053s] make: *** [build] Error 2 [ 1053s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1053s] ### VM INTERACTION START ### [ 1057s] [ 974.541515] sysrq: Power Off [ 1057s] [ 974.557068] reboot: Power down [ 1057s] ### VM INTERACTION END ### [ 1057s] [ 1057s] obs-arm-1 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 03:56:06 UTC 2021. [ 1057s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 03:59:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 03:59:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835ac3f3ba5_26f62ae79e4a05f0300338@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 238s] # we create a symlink at ./srcfile.adoc pointing at [ 238s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 238s] # is like basename from coreutils, and . is WD. [ 238s] if ! [ -f test-usermanual.adoc ]; then \ [ 238s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 238s] fi [ 238s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 238s] # in ... [ 238s] TEXINPUTS=".." \ [ 238s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 239s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 239s] a2x: resource files: [] [ 239s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 239s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 239s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 239s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 239s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 239s] make[1]: *** [Makefile:363: all] Error 2 [ 239s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 239s] dh_auto_build: error: make -j1 returned exit code 2 [ 239s] make: *** [debian/rules:5: binary] Error 25 [ 239s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 239s] ### VM INTERACTION START ### [ 240s] Powering off. [ 240s] [ 226.682354] reboot: Power down [ 240s] ### VM INTERACTION END ### [ 240s] [ 240s] goat11 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Thu Nov 4 03:59:27 UTC 2021. [ 240s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:00:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:00:14 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835ae2d0b1f_26f62ae79e4a05f0300494@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 284s] # we create a symlink at ./srcfile.adoc pointing at [ 284s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 284s] # is like basename from coreutils, and . is WD. [ 284s] if ! [ -f test-usermanual.adoc ]; then \ [ 284s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 284s] fi [ 284s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 284s] # in ... [ 284s] TEXINPUTS=".." \ [ 284s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 284s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 284s] a2x: resource files: [] [ 284s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 284s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 284s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 284s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 284s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 284s] make[1]: *** [Makefile:363: all] Error 2 [ 284s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 284s] dh_auto_build: error: make -j1 returned exit code 2 [ 284s] make: *** [debian/rules:5: binary] Error 25 [ 284s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 284s] ### VM INTERACTION START ### [ 285s] Powering off. [ 285s] [ 270.113155] reboot: Power down [ 285s] ### VM INTERACTION END ### [ 285s] [ 285s] sheep87 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111040026.dsc" at Thu Nov 4 04:00:05 UTC 2021. [ 285s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:06:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:06:28 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835c4a96847_26f62ae79e4a05f0300977@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 220s] # is like basename from coreutils, and . is WD. [ 220s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 220s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 220s] fi [ 220s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 220s] # in /usr/share/osmo-gsm-manuals. [ 220s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 220s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 220s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 220s] a2x: resource files: [] [ 220s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 220s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 220s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 220s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 220s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 220s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 220s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 220s] make[1]: *** [Makefile:327: all] Error 2 [ 220s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 220s] dh_auto_build: error: make -j1 returned exit code 2 [ 220s] make: *** [debian/rules:12: build] Error 25 [ 220s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 220s] ### VM INTERACTION START ### [ 221s] Powering off. [ 221s] [ 211.035388] reboot: Power down [ 222s] ### VM INTERACTION END ### [ 222s] [ 222s] goat11 failed "build osmo-sip-connector_1.5.1.dsc" at Thu Nov 4 04:06:26 UTC 2021. [ 222s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:07:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:07:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835ca18b64d_26f62ae79e4a05f03011e2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 285s] # is like basename from coreutils, and . is WD. [ 285s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 285s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 285s] fi [ 285s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 285s] # in /usr/share/osmo-gsm-manuals. [ 285s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 285s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 285s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 285s] a2x: resource files: [] [ 285s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 285s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 285s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 285s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 285s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 285s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 285s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 285s] make[1]: *** [Makefile:392: all] Error 2 [ 285s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 285s] dh_auto_build: error: make -j1 returned exit code 2 [ 285s] make: *** [debian/rules:15: build] Error 25 [ 285s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 285s] ### VM INTERACTION START ### [ 286s] Powering off. [ 286s] [ 275.835935] reboot: Power down [ 286s] ### VM INTERACTION END ### [ 286s] [ 286s] goat09 failed "build osmo-ggsn_1.7.1.dsc" at Thu Nov 4 04:07:26 UTC 2021. [ 286s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:10:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:10:09 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835d38c1d3_26f62ae79e4a05f03014c5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 299s] # is like basename from coreutils, and . is WD. [ 299s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 299s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 299s] fi [ 299s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 299s] # in /usr/share/osmo-gsm-manuals. [ 299s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 299s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 299s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 299s] a2x: resource files: [] [ 299s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 299s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 299s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 299s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 299s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 299s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 299s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 299s] make[1]: *** [Makefile:403: all] Error 2 [ 299s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 299s] dh_auto_build: error: make -j1 returned exit code 2 [ 299s] make: *** [debian/rules:12: build] Error 25 [ 299s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 299s] ### VM INTERACTION START ### [ 301s] Powering off. [ 301s] [ 289.403967] reboot: Power down [ 301s] ### VM INTERACTION END ### [ 301s] [ 301s] goat09 failed "build libosmo-sccp_1.4.0.dsc" at Thu Nov 4 04:10:02 UTC 2021. [ 301s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:11:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:11:00 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835d57700e5_26f62ae79e4a05f03016d4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 474s] # is like basename from coreutils, and . is WD. [ 474s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 474s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 474s] fi [ 474s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 474s] # in /usr/share/osmo-gsm-manuals. [ 474s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 474s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 474s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 474s] a2x: resource files: [] [ 474s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 474s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 474s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 474s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 474s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 474s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 474s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 474s] make[1]: *** [Makefile:377: all] Error 2 [ 474s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 474s] dh_auto_build: error: make -j1 returned exit code 2 [ 474s] make: *** [debian/rules:45: build] Error 25 [ 474s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 474s] ### VM INTERACTION START ### [ 475s] Powering off. [ 475s] [ 455.213721] reboot: Power down [ 475s] ### VM INTERACTION END ### [ 475s] [ 475s] lamb18 failed "build osmo-gbproxy_0.1.2.dsc" at Thu Nov 4 04:10:46 UTC 2021. [ 475s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:13:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:13:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835e0bec5fd_26f62ae79e4a05f03026cd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 434s] # is like basename from coreutils, and . is WD. [ 434s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 434s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 434s] fi [ 434s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 434s] # in /usr/share/osmo-gsm-manuals. [ 434s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 434s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 434s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 434s] a2x: resource files: [] [ 434s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 434s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 434s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 434s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 434s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 434s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 434s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 434s] make[1]: *** [Makefile:387: all] Error 2 [ 434s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 434s] dh_auto_build: error: make -j1 returned exit code 2 [ 434s] make: *** [debian/rules:12: build] Error 25 [ 434s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 434s] ### VM INTERACTION START ### [ 435s] Powering off. [ 435s] [ 414.017617] reboot: Power down [ 435s] ### VM INTERACTION END ### [ 435s] [ 435s] old-cirrus2 failed "build osmo-remsim_0.2.4.dsc" at Thu Nov 4 04:13:23 UTC 2021. [ 435s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:13:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:13:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835e0c49000_26f62ae79e4a05f03027d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 209s] # is like basename from coreutils, and . is WD. [ 209s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 209s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 209s] fi [ 209s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 209s] # in /usr/share/osmo-gsm-manuals. [ 209s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 209s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 209s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 209s] a2x: resource files: [] [ 209s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 209s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 209s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 209s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 209s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 209s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 209s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 209s] make[1]: *** [Makefile:377: all] Error 2 [ 209s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 209s] dh_auto_build: error: make -j1 returned exit code 2 [ 209s] make: *** [debian/rules:45: build] Error 25 [ 209s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 209s] ### VM INTERACTION START ### [ 210s] Powering off. [ 211s] [ 201.090808] reboot: Power down [ 211s] ### VM INTERACTION END ### [ 211s] [ 211s] goat07 failed "build osmo-smlc_0.2.0.dsc" at Thu Nov 4 04:13:43 UTC 2021. [ 211s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:14:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:14:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835e46596bd_26f62ae79e4a05f0302984@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 505s] # is like basename from coreutils, and . is WD. [ 505s] if ! [ -f osmomgw-usermanual.adoc ]; then \ [ 505s] ln -s osmomgw-usermanual.adoc osmomgw-usermanual.adoc; \ [ 505s] fi [ 505s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 505s] # in /usr/share/osmo-gsm-manuals. [ 505s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 505s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomgw-usermanual.adoc [ 505s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 505s] a2x: resource files: [] [ 505s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 505s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 505s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 505s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 505s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 505s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 505s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 505s] make[1]: *** [Makefile:423: all] Error 2 [ 505s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 505s] dh_auto_build: error: make -j1 returned exit code 2 [ 505s] make: *** [debian/rules:17: build] Error 25 [ 505s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 505s] ### VM INTERACTION START ### [ 506s] Powering off. [ 506s] [ 474.146771] reboot: Power down [ 506s] ### VM INTERACTION END ### [ 506s] [ 506s] lamb18 failed "build osmo-mgw_1.8.1.dsc" at Thu Nov 4 04:14:30 UTC 2021. [ 506s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:15:15 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:15:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61835e656d65b_26f62ae79e4a05f030308b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_10/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 385s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 386s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 386s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 389s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 391s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 391s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 392s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 392s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 392s] int mode; [ 392s] ^~~~ [ 392s] cc1: some warnings being treated as errors [ 392s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 392s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 392s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 392s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 392s] make[2]: *** [Makefile:453: all-recursive] Error 1 [ 392s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 392s] make[1]: *** [Makefile:385: all] Error 2 [ 392s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 392s] dh_auto_build: make -j1 returned exit code 2 [ 392s] make: *** [debian/rules:45: build] Error 2 [ 392s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 392s] ### VM INTERACTION START ### [ 396s] [ 359.945791] sysrq: Power Off [ 396s] [ 359.995989] reboot: Power down [ 396s] ### VM INTERACTION END ### [ 396s] [ 396s] obs-arm-9 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 04:15:10 UTC 2021. [ 396s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:15:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:15:49 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835e84cd220_26f62ae79e4a05f030318c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 602s] # is like basename from coreutils, and . is WD. [ 602s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 602s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 602s] fi [ 602s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 602s] # in /usr/share/osmo-gsm-manuals. [ 602s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 602s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 602s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 602s] a2x: resource files: [] [ 602s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 602s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 602s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 602s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 602s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 602s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 602s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 602s] make[1]: *** [Makefile:368: all] Error 2 [ 602s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 602s] dh_auto_build: error: make -j1 returned exit code 2 [ 602s] make: *** [debian/rules:45: build] Error 25 [ 603s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 603s] ### VM INTERACTION START ### [ 604s] Powering off. [ 604s] [ 581.250005] reboot: Power down [ 604s] ### VM INTERACTION END ### [ 604s] [ 604s] lamb19 failed "build osmo-cbc_0.2.2.dsc" at Thu Nov 4 04:15:41 UTC 2021. [ 604s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:16:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:16:23 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835ea448971_26f62ae79e4a05f0303398@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 797s] # we create a symlink at ./srcfile.adoc pointing at [ 797s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 797s] # is like basename from coreutils, and . is WD. [ 797s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 797s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 797s] fi [ 797s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 797s] # in /usr/share/osmo-gsm-manuals. [ 797s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 797s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 797s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 797s] a2x: resource files: [] [ 797s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 797s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 797s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 797s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 797s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 797s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 797s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 797s] dh_auto_build: error: make -j1 returned exit code 2 [ 797s] make: *** [debian/rules:12: build] Error 25 [ 797s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 797s] ### VM INTERACTION START ### [ 798s] Powering off. [ 798s] [ 747.202447] reboot: Power down [ 799s] ### VM INTERACTION END ### [ 799s] [ 799s] lamb05 failed "build osmo-pcu_0.9.1.dsc" at Thu Nov 4 04:16:10 UTC 2021. [ 799s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:17:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:17:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835edd134c8_26f62ae79e4a05f03037a3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 673s] # is like basename from coreutils, and . is WD. [ 673s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 673s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 673s] fi [ 673s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 673s] # in /usr/share/osmo-gsm-manuals. [ 673s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 673s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 673s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 673s] a2x: resource files: [] [ 673s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 673s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 673s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 673s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 673s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 673s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 673s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 673s] make[1]: *** [Makefile:410: all] Error 2 [ 673s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 673s] dh_auto_build: error: make -j1 returned exit code 2 [ 673s] make: *** [debian/rules:7: build] Error 25 [ 673s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 673s] ### VM INTERACTION START ### [ 674s] Powering off. [ 674s] [ 571.849249] reboot: Power down [ 674s] ### VM INTERACTION END ### [ 674s] [ 674s] old-atreju4 failed "build osmo-hlr_1.3.1.dsc" at Thu Nov 4 04:17:20 UTC 2021. [ 674s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:18:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:18:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835f39a3cc4_26f62ae79e4a05f030403@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 230s] # is like basename from coreutils, and . is WD. [ 230s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 230s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 230s] fi [ 230s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 230s] # in /usr/share/osmo-gsm-manuals. [ 230s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 230s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 230s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 230s] a2x: resource files: [] [ 230s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 230s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 230s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 230s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 230s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 230s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 230s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 230s] make[1]: *** [Makefile:388: all] Error 2 [ 230s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 230s] dh_auto_build: error: make -j1 returned exit code 2 [ 230s] make: *** [debian/rules:45: build] Error 25 [ 230s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 230s] ### VM INTERACTION START ### [ 231s] Powering off. [ 231s] [ 220.038394] reboot: Power down [ 231s] ### VM INTERACTION END ### [ 231s] [ 231s] goat13 failed "build osmo-bsc_1.7.2.dsc" at Thu Nov 4 04:18:35 UTC 2021. [ 231s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:20:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:20:55 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835fb07f89d_26f62ae79e4a05f03042ea@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 855s] # is like basename from coreutils, and . is WD. [ 855s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 855s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 855s] fi [ 855s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 855s] # in /usr/share/osmo-gsm-manuals. [ 855s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 855s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 856s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 856s] a2x: resource files: [] [ 856s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 856s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 856s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 856s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 856s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 856s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 856s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 856s] make[1]: *** [Makefile:452: all] Error 2 [ 856s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 856s] dh_auto_build: error: make -j1 returned exit code 2 [ 856s] make: *** [debian/rules:6: build] Error 25 [ 856s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 856s] ### VM INTERACTION START ### [ 857s] Powering off. [ 857s] [ 794.093740] reboot: Power down [ 858s] ### VM INTERACTION END ### [ 858s] [ 858s] cloud111 failed "build osmo-trx_1.3.1.dsc" at Thu Nov 4 04:20:41 UTC 2021. [ 858s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:21:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:21:46 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61835fee1be94_26f62ae79e4a05f0304482@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 672s] # is like basename from coreutils, and . is WD. [ 672s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 672s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 672s] fi [ 672s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 672s] # in /usr/share/osmo-gsm-manuals. [ 672s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 672s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 672s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 672s] a2x: resource files: [] [ 672s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 672s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 672s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 672s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 672s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 672s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 672s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 672s] make[1]: *** [Makefile:391: all] Error 2 [ 672s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 672s] dh_auto_build: error: make -j1 returned exit code 2 [ 672s] make: *** [debian/rules:9: build] Error 25 [ 672s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 672s] ### VM INTERACTION START ### [ 673s] Powering off. [ 673s] [ 654.925454] reboot: Power down [ 673s] ### VM INTERACTION END ### [ 673s] [ 673s] hci-cnode1-e5 failed "build osmo-iuh_1.0.0.dsc" at Thu Nov 4 04:21:33 UTC 2021. [ 673s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:25:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:25:27 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_11/aarch64 In-Reply-To: References: Message-ID: <618360c096e48_26f62ae79e4a05f030539e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_11/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 583s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c acc.c -o acc.o >/dev/null 2>&1 [ 584s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o assignment_fsm.lo assignment_fsm.c [ 584s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -fPIC -DPIC -o .libs/assignment_fsm.o [ 589s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c assignment_fsm.c -o assignment_fsm.o >/dev/null 2>&1 [ 593s] /bin/bash ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o bsc_ctrl_commands.lo bsc_ctrl_commands.c [ 593s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Wnull-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c bsc_ctrl_commands.c -fPIC -DPIC -o .libs/bsc_ctrl_commands.o [ 594s] bsc_ctrl_commands.c: In function 'set_bts_neighbor_list_mode': [ 594s] bsc_ctrl_commands.c:756:6: error: 'mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] [ 594s] 756 | int mode; [ 594s] | ^~~~ [ 594s] cc1: some warnings being treated as errors [ 594s] make[4]: *** [Makefile:769: bsc_ctrl_commands.lo] Error 1 [ 594s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc' [ 594s] make[3]: *** [Makefile:403: all-recursive] Error 1 [ 594s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 594s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 594s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 594s] make[1]: *** [Makefile:387: all] Error 2 [ 594s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 594s] dh_auto_build: error: make -j1 returned exit code 2 [ 594s] make: *** [debian/rules:45: build] Error 25 [ 594s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 595s] ### VM INTERACTION START ### [ 596s] Powering off. [ 596s] [ 535.953576] reboot: Power down [ 596s] ### VM INTERACTION END ### [ 596s] [ 596s] obs-arm-8 failed "build osmo-bsc_1.7.0.311.9cb63.202111040026.dsc" at Thu Nov 4 04:25:19 UTC 2021. [ 596s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:25:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:25:10 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618360c01268b_26f62ae79e4a05f0305173@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 1118s] # is like basename from coreutils, and . is WD. [ 1118s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 1118s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 1118s] fi [ 1118s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1118s] # in /usr/share/osmo-gsm-manuals. [ 1118s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1118s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 1118s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 1118s] a2x: resource files: [] [ 1118s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1118s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 1118s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1118s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 1118s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1118s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 1118s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1118s] make[1]: *** [Makefile:371: all] Error 2 [ 1118s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1118s] dh_auto_build: error: make -j1 returned exit code 2 [ 1118s] make: *** [debian/rules:12: build] Error 25 [ 1118s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1119s] ### VM INTERACTION START ### [ 1120s] Powering off. [ 1120s] [ 1032.489130] reboot: Power down [ 1120s] ### VM INTERACTION END ### [ 1120s] [ 1120s] lamb52 failed "build osmo-bts_1.3.3.dsc" at Thu Nov 4 04:24:57 UTC 2021. [ 1120s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:25:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:25:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618360c0bdd94_26f62ae79e4a05f03054a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 217s] # is like basename from coreutils, and . is WD. [ 217s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 217s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 217s] fi [ 217s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 217s] # in /usr/share/osmo-gsm-manuals. [ 217s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 217s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 217s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 217s] a2x: resource files: [] [ 217s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 217s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 217s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 217s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 217s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 217s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 217s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 217s] make[1]: *** [Makefile:402: all] Error 2 [ 217s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 217s] dh_auto_build: error: make -j1 returned exit code 2 [ 217s] make: *** [debian/rules:45: build] Error 25 [ 217s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 217s] ### VM INTERACTION START ### [ 218s] Powering off. [ 218s] [ 207.242691] reboot: Power down [ 218s] ### VM INTERACTION END ### [ 218s] [ 218s] goat17 failed "build osmo-msc_1.7.1.dsc" at Thu Nov 4 04:25:21 UTC 2021. [ 218s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 04:25:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 04:25:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618360da48239_26f62ae79e4a05f030551@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 231s] # is like basename from coreutils, and . is WD. [ 231s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 231s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 231s] fi [ 231s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 231s] # in /usr/share/osmo-gsm-manuals. [ 231s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 231s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 231s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 231s] a2x: resource files: [] [ 231s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 231s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 231s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 231s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 231s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 231s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 231s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 231s] make[1]: *** [Makefile:394: all] Error 2 [ 231s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 231s] dh_auto_build: error: make -j1 returned exit code 2 [ 231s] make: *** [debian/rules:45: build] Error 25 [ 231s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 231s] ### VM INTERACTION START ### [ 232s] Powering off. [ 232s] [ 221.824183] reboot: Power down [ 232s] ### VM INTERACTION END ### [ 232s] [ 232s] goat03 failed "build osmo-sgsn_1.7.1.dsc" at Thu Nov 4 04:25:41 UTC 2021. [ 232s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 4 08:54:04 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 08:54:04 +0000 Subject: Change in osmo-bsc[master]: bsc_ctrl_commands: fix uninitialized value (mode) References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26094 ) Change subject: bsc_ctrl_commands: fix uninitialized value (mode) ...................................................................... bsc_ctrl_commands: fix uninitialized value (mode) Fixes: CID#240848 Change-Id: I571055b350d343318ef1ae469ae92475925d1910 --- M src/osmo-bsc/bsc_ctrl_commands.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/26094/1 diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c index f379bd2..fb8bd0c 100644 --- a/src/osmo-bsc/bsc_ctrl_commands.c +++ b/src/osmo-bsc/bsc_ctrl_commands.c @@ -753,7 +753,7 @@ static int set_bts_neighbor_list_mode(struct ctrl_cmd *cmd, void *data) { struct gsm_bts *bts = cmd->node; - int mode; + int mode = NL_MODE_AUTOMATIC; if (!strcmp(cmd->value, "automatic")) mode = NL_MODE_AUTOMATIC; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571055b350d343318ef1ae469ae92475925d1910 Gerrit-Change-Number: 26094 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 08:58:32 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 08:58:32 +0000 Subject: Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex... In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 08:58:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:01:31 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 09:01:31 +0000 Subject: Change in osmo-bsc[master]: bsc_ctrl_commands: fix uninitialized value (mode) In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26094 ) Change subject: bsc_ctrl_commands: fix uninitialized value (mode) ...................................................................... Patch Set 1: Code-Review+2 Not really a bug ;-) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571055b350d343318ef1ae469ae92475925d1910 Gerrit-Change-Number: 26094 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Thu, 04 Nov 2021 09:01:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:05:08 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 09:05:08 +0000 Subject: Change in osmo-bts[master]: abis: Drop unneded if condition in else clause In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26092 ) Change subject: abis: Drop unneded if condition in else clause ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 Gerrit-Change-Number: 26092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 09:05:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:06:24 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 09:06:24 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Change log level to debug for line informi... In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26091 ) Change subject: bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 Gerrit-Change-Number: 26091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 09:06:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:06:37 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 09:06:37 +0000 Subject: Change in osmo-bsc[master]: bsc_ctrl_commands: fix uninitialized value (mode) In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26094 ) Change subject: bsc_ctrl_commands: fix uninitialized value (mode) ...................................................................... bsc_ctrl_commands: fix uninitialized value (mode) Fixes: CID#240848 Change-Id: I571055b350d343318ef1ae469ae92475925d1910 --- M src/osmo-bsc/bsc_ctrl_commands.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c index f379bd2..fb8bd0c 100644 --- a/src/osmo-bsc/bsc_ctrl_commands.c +++ b/src/osmo-bsc/bsc_ctrl_commands.c @@ -753,7 +753,7 @@ static int set_bts_neighbor_list_mode(struct ctrl_cmd *cmd, void *data) { struct gsm_bts *bts = cmd->node; - int mode; + int mode = NL_MODE_AUTOMATIC; if (!strcmp(cmd->value, "automatic")) mode = NL_MODE_AUTOMATIC; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571055b350d343318ef1ae469ae92475925d1910 Gerrit-Change-Number: 26094 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:08:15 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 09:08:15 +0000 Subject: Change in osmo-bsc[master]: tweak intra-bsc ho counter descriptions In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26071 ) Change subject: tweak intra-bsc ho counter descriptions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 Gerrit-Change-Number: 26071 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 09:08:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:12:09 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 09:12:09 +0000 Subject: Change in osmo-bsc[master]: drop unused gsm48_tx_mm_serv_ack() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26069 ) Change subject: drop unused gsm48_tx_mm_serv_ack() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea Gerrit-Change-Number: 26069 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 09:12:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 4 09:19:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 09:19:29 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6183a5ab6d90_26f62ae79e4a05f034770@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 405s] # we create a symlink at ./srcfile.adoc pointing at [ 405s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 405s] # is like basename from coreutils, and . is WD. [ 405s] if ! [ -f test-usermanual.adoc ]; then \ [ 405s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 405s] fi [ 405s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 405s] # in ... [ 405s] TEXINPUTS=".." \ [ 405s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 406s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 406s] a2x: resource files: [] [ 406s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 406s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 406s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 406s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 406s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 406s] make[1]: *** [Makefile:363: all] Error 2 [ 406s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 406s] dh_auto_build: error: make -j1 returned exit code 2 [ 406s] make: *** [debian/rules:5: binary] Error 25 [ 406s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 406s] ### VM INTERACTION START ### [ 407s] Powering off. [ 407s] [ 387.120813] reboot: Power down [ 407s] ### VM INTERACTION END ### [ 407s] [ 407s] lamb26 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111040908.dsc" at Thu Nov 4 09:19:25 UTC 2021. [ 407s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:20:43 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 09:20:43 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c at 2155 PS1, Line 2155: switch (lchan->activate.info.chreq_reason) { > sounds like an excellent idea, but that could be a further cleanup on top of this patch. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 09:20:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 09:40:01 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 09:40:01 +0000 Subject: Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors" References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/26095/1 diff --git a/configure.ac b/configure.ac index 195acfe..bcf91ba 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -120,13 +115,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:21:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:21:55 +0000 Subject: Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors" References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/96/26096/1 diff --git a/configure.ac b/configure.ac index 1207171..702be9f 100644 --- a/configure.ac +++ b/configure.ac @@ -36,12 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) @@ -119,15 +113,6 @@ AC_HEADER_STDC AC_CHECK_HEADERS(dbi/dbd.h,,AC_MSG_ERROR(DBI library is not installed)) - -dnl Checks for typedefs, structures and compiler characteristics -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:22:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:22:06 +0000 Subject: Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors" References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/97/26097/1 diff --git a/configure.ac b/configure.ac index b996e87..ddd8862 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -90,16 +85,6 @@ CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" fi -dnl Checks for typedefs, structures and compiler characteristics - -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=sometimes-uninitialized], [CFLAGS="$CFLAGS -Werror=sometimes-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:22:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:22:15 +0000 Subject: Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors" References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/98/26098/1 diff --git a/configure.ac b/configure.ac index c29bacb..9607373 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -124,13 +119,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:22:26 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:22:26 +0000 Subject: Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder refs/changes/99/26099/1 diff --git a/configure.ac b/configure.ac index e986809..cec703f 100644 --- a/configure.ac +++ b/configure.ac @@ -31,11 +31,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.2.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.2.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.2.0) @@ -87,13 +82,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c Gerrit-Change-Number: 26099 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:22:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:22:39 +0000 Subject: Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors" References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/00/26100/1 diff --git a/configure.ac b/configure.ac index 309d3f7..11ebac4 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -105,13 +100,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:22:51 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:22:51 +0000 Subject: Change in osmo-smlc[master]: configure: don't turn some warnings into errors References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26101 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/01/26101/1 diff --git a/configure.ac b/configure.ac index e4b902b..eed5ee9 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) @@ -92,13 +87,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 Gerrit-Change-Number: 26101 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:22:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:22:59 +0000 Subject: Change in osmo-sysmon[master]: configure: don't turn some warnings into errors References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/02/26102/1 diff --git a/configure.ac b/configure.ac index 63615b8..2546b61 100644 --- a/configure.ac +++ b/configure.ac @@ -30,11 +30,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -96,13 +91,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 Gerrit-Change-Number: 26102 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 10:24:33 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 10:24:33 +0000 Subject: Change in osmo-uecups[master]: configure: don't turn some warnings into errors References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26103 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/03/26103/1 diff --git a/configure.ac b/configure.ac index 94bde9d..ba36b3f 100644 --- a/configure.ac +++ b/configure.ac @@ -26,11 +26,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.1.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.1.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.7.0) @@ -80,13 +75,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d Gerrit-Change-Number: 26103 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 11:27:46 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Thu, 4 Nov 2021 11:27:46 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: Sorry for writing so much, but it seems necessary... First off, still open point, orthogonal to rate_ctr vs stat_item decision: Should I remove the configurability features and reduce to one fixed counting behavior? e.g. fix to granularity of seconds, and to the round() rounding scheme? (The customer expressed that either round() or ceil() would be suitable, and floor() is not desirable) ... I think it makes more sense to keep that configurability stuff, now that the code works correctly already. It is a bit of feature creep, the only two arguments to keep it is handwavy "maybe useful at some point in the future"/"maybe some user likes it idk", and a concrete "it would require investing even more effort to remove the features" > Well the question would then be: Can one still use the same external tools (grafana, elastic search, etc) with rate_ctr? I'm not sure how are those exported over statsd. Yes, of course! The customer expressed the preferred way of reporting would be a rate counter. Let me explain why, hopefully making more sense this time: In the stats exporting, the main difference is that - a stat_item is exported as the current value in each report. stat_item makes sense for values that rise and (possibly) fall, and where you want to read the actual current value, like number of active cells or say CPU load in percent, or uptime. - a rate_ctr is exported as nr of increments since the last stat report. Makes sense for counting spike events over time. It is suitable where one is interested in increments of a value per time, to see how busy a constantly rising value currently is, rather than the absolute value itself. A stat_item used for this cumulative time counter looks like a slope ramping up, like a staircase: staying a horizontal line at times of no chan exhaustion, and rising at times of chan exhaustion; taken to relative infinity, the value would at some point wrap the integer range. Imagine osmo-bsc ran for weeks, then the value could be a flat line at say 123000, and inc to 123001 when chan exhaustion occurs. For displaying such graph, if you're showing the entire y axis range, the increment is hardly visible. You need to zoom in on the y axis range say 123000 to 123100 to even be able to see that channels are currently exhausted. Or you need to employ math to graph the gradient of the line instead, so that you get 0 for non-exhausted times and spikes for exhausted times. We're interested in the gradient's spikes, i.e. in the "1", and not in the "123000" baseline. A rate_ctr looks like a city skyline, flat line at value 0 for no exhaustion, with spikes at times where chan exhaustion occurs, going back to zero when exhaustion is over. IOW it already *is* the gradient of the chan exhaustion time counter, which is exactly the interesting information: the number of exhausted seconds since the last stat report. A stat_item *would* make sense if it reported, say, the current percent of time where channels are exhausted. If you see the stat showing 100, you know the channels are currently all exhausted for all of the time. So something where the current value is the interesting metric. This however introduces complex design decisions: over what amount of time do we calculate the percentage? should that be configurable? when/how do we degrade the percentage when exhaustion is over? A rate_ctr *is* the simplest, least convoluted and true way of passing the actual useful information to an external stats tool, "and letting grafana figure it out" if the user wants some exhaustion percentage graph; and letting the user's infrastructure figure out whether to evaluate exhaustion over 5/15/30/60 minutes as the spec suggests, without actually introducing these choices to the osmo-bsc code base. > In general I think the main difference on how we see it, is that your focus is to have it look nice when using VTY Not at all. Looking useful on the VTY is just a side argument. It is a compelling argument nevertheless, the main point being to visualize to you that a rate counter is the proper design choice. Read: "even the VTY output becomes more useful". If I want to quickly check channel exhaustion without graphana, a stat item is very much harder to interpret than a rate counter: you need to repeatedly watch the value change. A rate counter gives you instant information about the gradient, as explained earlier. I have asked a number of times, but you have still not explained to me how a stat_item value should be designed in a useful and simple way. As I'm pointing out, a forever rising value is not very useful. > while my point is that it should in first place be usable for external tools. It *is* more useful to external tools as a rate counter. > Moreover, I have the feeling you are just abusing the rate_ctr infrastructure with some logic > just to get some output in VTY which you can understand (rate_ctr is aimed at tick events, not counting time). Please understand that this is exactly what a rate counter is designed for. We are interested in the current gradient, not the current value. The "tick event" here being "channel exhaustion occured for one entire second". Do not be confused by the fact that we are counting time over time. Time is involved twice in this metric! The metric is: "exhausted time, over time". Not simply "time since X", like e.g. uptime would be. That is an important difference that needs to be acknowledged. I started out a long time ago thinking that a stat item would be best, and the math about it as well as a customer discussion convinced me otherwise. I would appreciate if you could acknowledge these arguments, and, if the argument is flawed, actually suggest a detailed way of reporting as stat item in a useful way. What I am reading so far is merely generally brushing over my argument, and i read a dismissive tone, hope I'm wrong there. I would appreciate if we could keep this technical and detailed. I'm happy to change this and make it more useful, if there is a compelling argument to do so. Haven't seen one yet. What part am I not getting? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 11:27:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:18:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 12:18:53 +0000 Subject: Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:18:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:22:13 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Thu, 4 Nov 2021 12:22:13 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c at 2157 PS1, Line 2157: rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); BTW, i always dislike these long lines of rate_ctr_inc(rate_ctr_group_get_ctr()) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:29:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:29:31 +0000 Subject: Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26090 ) Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 Gerrit-Change-Number: 26090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:29:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:29:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:29:44 +0000 Subject: Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:29:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:29:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:29:46 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Drop impossible code path In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26088 ) Change subject: bts-trx: sched_lchan_tchf: Drop impossible code path ...................................................................... bts-trx: sched_lchan_tchf: Drop impossible code path It cannot happen that msg1 is NULL and msg2 is not null, since they are deuqueed from same place. Only possible combinations are: msg1!=NULL && msg2!=NULL msg1!=NULL && msg2==NULL Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 20a4077..a6fcd7a 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -398,12 +398,6 @@ msg_tch = msg2; } } - } else if (msg2) { - l1sap = msgb_l1sap_prim(msg2); - if (l1sap->oph.primitive == PRIM_TCH) - msg_tch = msg2; - else - msg_facch = msg2; } /* check validity of message */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f Gerrit-Change-Number: 26088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:29:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:29:47 +0000 Subject: Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg... In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26090 ) Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors ...................................................................... scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors Recent commit (see below) changed a check to avoid weird results for msg which had l2h=NULL, since l2len would return unexpected results there. However, some code branches like FACCH or TCH seem to be always setting l2h even if len=0. Hence, we must test either of the 2 scenarios (null pointer and l2len()). This commit fixes the following message appearing all the time during calls: """ TCH/F: Prim has odd len=0 != 23 """ Fixes: fb905b8d235ff2efe6c1cd9fde2b488b311c1cd7 Related: SYS#5676 Related: SYS#4919 Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 --- M src/common/scheduler.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 0388445..ba5c18a 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -869,7 +869,7 @@ OSMO_ASSERT(l1sap->oph.msg); /* ignore empty frame */ - if (!l1sap->oph.msg->l2h) { + if (!l1sap->oph.msg->l2h || msgb_l2len(l1sap->oph.msg) == 0) { msgb_free(l1sap->oph.msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 Gerrit-Change-Number: 26090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:29:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:29:47 +0000 Subject: Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Change log level to debug for line informi... In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26091 ) Change subject: bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim ...................................................................... bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim This scenario is actually expected when the call is being set up or torn down, since we may not be receiving RTP from the MGW to send to the MS. Hence, let's lower the log level to DEBUG to avoid having log clogged for each call start/stop if INFO is used. Related: SYS#5676 Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index a6fcd7a..85ab321 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -537,7 +537,7 @@ 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, }; - LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No TCH or FACCH prim for transmit.\n"); + LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "No TCH or FACCH prim for transmit.\n"); gsm0503_tch_fr_encode(*bursts_p, dummy, sizeof(dummy), 1); goto send_burst; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 Gerrit-Change-Number: 26091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:29:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:29:48 +0000 Subject: Change in osmo-bts[master]: abis: Drop unneded if condition in else clause In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26092 ) Change subject: abis: Drop unneded if condition in else clause ...................................................................... abis: Drop unneded if condition in else clause priv->current_bsc will for sure be != last, otherwise it would have entered the if clause above it. Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 --- M src/common/abis.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved dexter: Looks good to me, approved diff --git a/src/common/abis.c b/src/common/abis.c index c0cd18c..06e6f3b 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -126,7 +126,7 @@ if (!priv->current_bsc || priv->current_bsc == last) /* Pick first one (wrap around): */ priv->current_bsc = (struct bsc_oml_host *)llist_first_entry(&bts->bsc_oml_hosts, struct bsc_oml_host, list); - else if (priv->current_bsc != last) + else priv->current_bsc = (struct bsc_oml_host *)llist_entry(priv->current_bsc->list.next, struct bsc_oml_host, list); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 Gerrit-Change-Number: 26092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:29:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:29:49 +0000 Subject: Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex... In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one ...................................................................... abis: Try one reconnect to previously connected BSC before trying next one This way we keep all BTS connected to the same BSC if there was a spurious network problem. Related: SYS#4971 Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 --- M src/common/abis.c 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/abis.c b/src/common/abis.c index 06e6f3b..4afe81a 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -82,6 +82,7 @@ struct bsc_oml_host *current_bsc; struct gsm_bts *bts; char *model_name; + bool reconnect_to_current_bsc; }; static void reset_oml_link(struct gsm_bts *bts) @@ -122,6 +123,13 @@ return -1; } + /* Keep current pointer to priv->current_bsc: */ + if (priv->reconnect_to_current_bsc) { + OSMO_ASSERT(priv->current_bsc); + priv->reconnect_to_current_bsc = false; + return 0; + } + last = (struct bsc_oml_host *)llist_last_entry(&bts->bsc_oml_hosts, struct bsc_oml_host, list); if (!priv->current_bsc || priv->current_bsc == last) /* Pick first one (wrap around): */ @@ -233,6 +241,9 @@ * line when something goes wrong... */ } bts_model_abis_close(bts); + + /* We want to try reconnecting to the current BSC at least once before switching to a new one: */ + priv->reconnect_to_current_bsc = true; osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_WAIT_RECONNECT, OML_RETRY_TIMER, 0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:32:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:32:53 +0000 Subject: Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:32:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:32:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:32:59 +0000 Subject: Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:32:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:33:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:33:06 +0000 Subject: Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:33:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:33:12 +0000 Subject: Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:33:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:33:19 +0000 Subject: Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:33:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:33:27 +0000 Subject: Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c Gerrit-Change-Number: 26099 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:33:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:33:33 +0000 Subject: Change in osmo-smlc[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26101 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 Gerrit-Change-Number: 26101 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:33:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:33:40 +0000 Subject: Change in osmo-sysmon[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 Gerrit-Change-Number: 26102 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:33:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:33:47 +0000 Subject: Change in osmo-uecups[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26103 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d Gerrit-Change-Number: 26103 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:36:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 12:36:07 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c at 2157 PS1, Line 2157: rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); > BTW, i always dislike these long lines of rate_ctr_inc(rate_ctr_group_get_ctr()) Feel free to add a rate_ctr_group_ctr_inc() or alike: rate_ctr_group_ctr_inc(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_CALL); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:36:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:46:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 12:46:58 +0000 Subject: Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 to look at the new patch set (#4). Change subject: l1sap: rework handling of DATA.ind on SACCH ...................................................................... l1sap: rework handling of DATA.ind on SACCH Currently an Uplink SACCH block is being passed to LAPDm first, and then gets forwareded to the BSC in handle_ms_meas_report(), together with the Uplink measurements collected so far. This approach has a serious flaw: handle_ms_meas_report() won't be called if an Uplink block contains SAPI=3 data (SMS) or was not decoded at all (len=0) fow whatever reason. Therefore, no RSL MEASurement RESult message will be sent to the BSC. Rename handle_ms_meas_report() to lchan_meas_handle_sacch(), and call it from l1sap_ph_data_ind(). This way perioduc RSL MEASurement RESult messages will be sent regardless of what happens on Uplink SACCH. Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Fixes: TC_meas_res_speech_{tchf,tchh}_sapi3 Related: SYS#5319 --- M include/osmo-bts/measurement.h M src/common/l1sap.c M src/common/measurement.c M src/common/rsl.c 4 files changed, 84 insertions(+), 74 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/26046/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 12:46:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 12:46:58 +0000 Subject: Change in osmo-bts[master]: measurement: get rid of *le in lchan_meas_handle_sacch() In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 to look at the new patch set (#3). Change subject: measurement: get rid of *le in lchan_meas_handle_sacch() ...................................................................... measurement: get rid of *le in lchan_meas_handle_sacch() The current Timing Advance value can be obtained either from the L1 SACCH header (if received) or from lchan->ta_ctrl.current. Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 --- M src/common/measurement.c 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/26051/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 Gerrit-Change-Number: 26051 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:00:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:00:16 +0000 Subject: Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:00:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:00:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:00:40 +0000 Subject: Change in osmo-bts[master]: measurement: get rid of *le in lchan_meas_handle_sacch() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26051 ) Change subject: measurement: get rid of *le in lchan_meas_handle_sacch() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 Gerrit-Change-Number: 26051 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:00:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:01:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:01:36 +0000 Subject: Change in osmo-uecups[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26103 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d Gerrit-Change-Number: 26103 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:01:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:01:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 13:01:51 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: Configurability features: Ok fine to keep them. So AFAIU the problem boils down to not wanting an ever increasing value, which means stat_item would need to be reset to 0 when you stop counting, but then sub-period increases would be lost (not announced/visible to statsd). Fine then, please do the documentation improvements you already ACKed. I'd really add structure wrappers to allocate/free the struct, so that users don't need to care about details and we can later on expand them as we see is needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:01:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:00 +0000 Subject: Change in osmo-uecups[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26103 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 94bde9d..ba36b3f 100644 --- a/configure.ac +++ b/configure.ac @@ -26,11 +26,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.1.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.1.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.7.0) @@ -80,13 +75,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d Gerrit-Change-Number: 26103 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:14 +0000 Subject: Change in osmo-sysmon[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 Gerrit-Change-Number: 26102 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:17 +0000 Subject: Change in osmo-sysmon[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 63615b8..2546b61 100644 --- a/configure.ac +++ b/configure.ac @@ -30,11 +30,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -96,13 +91,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 Gerrit-Change-Number: 26102 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:24 +0000 Subject: Change in osmo-smlc[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26101 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 Gerrit-Change-Number: 26101 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:27 +0000 Subject: Change in osmo-smlc[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26101 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index e4b902b..eed5ee9 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) @@ -92,13 +87,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 Gerrit-Change-Number: 26101 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:30 +0000 Subject: Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c Gerrit-Change-Number: 26099 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:38 +0000 Subject: Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index e986809..cec703f 100644 --- a/configure.ac +++ b/configure.ac @@ -31,11 +31,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.2.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.2.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.2.0) @@ -87,13 +82,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c Gerrit-Change-Number: 26099 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:50 +0000 Subject: Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:02:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:02:55 +0000 Subject: Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 309d3f7..11ebac4 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -105,13 +100,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:01 +0000 Subject: Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:03 +0000 Subject: Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index c29bacb..9607373 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -124,13 +119,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:09 +0000 Subject: Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:11 +0000 Subject: Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index b996e87..ddd8862 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -90,16 +85,6 @@ CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" fi -dnl Checks for typedefs, structures and compiler characteristics - -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=sometimes-uninitialized], [CFLAGS="$CFLAGS -Werror=sometimes-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:14 +0000 Subject: Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:20 +0000 Subject: Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 1207171..702be9f 100644 --- a/configure.ac +++ b/configure.ac @@ -36,12 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) @@ -119,15 +113,6 @@ AC_HEADER_STDC AC_CHECK_HEADERS(dbi/dbd.h,,AC_MSG_ERROR(DBI library is not installed)) - -dnl Checks for typedefs, structures and compiler characteristics -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:23 +0000 Subject: Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:03:25 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 4 Nov 2021 13:03:25 +0000 Subject: Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors" In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" ...................................................................... Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 195acfe..bcf91ba 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -120,13 +115,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:09:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:09:12 +0000 Subject: Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 ) Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c at 958 PS4, Line 958: if (dtxu_used) { > You're right. This is actually a fault of https://gerrit.osmocom. [?] Fixed in the new patch set. Looks like we build without -Werror=maybe-uninitialized? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2 Gerrit-Change-Number: 26047 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:09:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:19:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:19:11 +0000 Subject: Change in osmo-pcu[master]: bts: Fix misleading log line in bts_rcv_rach() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26060 ) Change subject: bts: Fix misleading log line in bts_rcv_rach() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 Gerrit-Change-Number: 26060 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:19:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:19:55 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:19:55 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp at 171 PS2, Line 171: by on? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:19:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:22:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:22:36 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... Patch Set 1: Is it safe to change counter names in general? AFAIU, if we do so, we may break external monitoring tools for the users. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:23:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 13:23:19 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp at 171 PS2, Line 171: by > on? I guess it depends on whether you want to consider a request the subject calling it or simply consider it timing where the event happening. I don't really care :P -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:24:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:24:09 +0000 Subject: Change in osmo-pcu[master]: bts: Improve logging to clarify RACH req is for 2 phase access In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26075 ) Change subject: bts: Improve logging to clarify RACH req is for 2 phase access ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd Gerrit-Change-Number: 26075 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:24:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:25:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:25:04 +0000 Subject: Change in osmo-pcu[master]: bts: Count RACH Request with unexpected content In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26076 ) Change subject: bts: Count RACH Request with unexpected content ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b Gerrit-Change-Number: 26076 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:25:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:25:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:25:41 +0000 Subject: Change in osmo-pcu[master]: bts: Add counters for successful 1, 2 phase pkt access In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26077 ) Change subject: bts: Add counters for successful 1,2 phase pkt access ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 Gerrit-Change-Number: 26077 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:25:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:26:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:26:50 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG at 7 PS1, Line 7: pdch::rcv_resource_request(): Use local var to store bts pointer So what's your motivation, and how it makes the code better? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:26:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:27:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:27:24 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26079 ) Change subject: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d Gerrit-Change-Number: 26079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:27:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:28:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:28:59 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:28:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:29:47 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 13:29:47 +0000 Subject: Change in osmo-pcu[master]: bts: Fix misleading log line in bts_rcv_rach() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26060 ) Change subject: bts: Fix misleading log line in bts_rcv_rach() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 Gerrit-Change-Number: 26060 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:29:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:30:43 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Nov 2021 13:30:43 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:30:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:35:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 13:35:40 +0000 Subject: Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:35:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:36:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 13:36:09 +0000 Subject: Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 ) Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2 Gerrit-Change-Number: 26047 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:36:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:37:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 13:37:19 +0000 Subject: Change in osmo-bts[master]: measurement: pass *mr to lchan_bs_pwr_ctrl() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26049 ) Change subject: measurement: pass *mr to lchan_bs_pwr_ctrl() ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937117cf26fb718d57920382f6972390ad498c51 Gerrit-Change-Number: 26049 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:37:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:47:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:47:13 +0000 Subject: Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH ...................................................................... l1sap: rework handling of DATA.ind on SACCH Currently an Uplink SACCH block is being passed to LAPDm first, and then gets forwareded to the BSC in handle_ms_meas_report(), together with the Uplink measurements collected so far. This approach has a serious flaw: handle_ms_meas_report() won't be called if an Uplink block contains SAPI=3 data (SMS) or was not decoded at all (len=0) fow whatever reason. Therefore, no RSL MEASurement RESult message will be sent to the BSC. Rename handle_ms_meas_report() to lchan_meas_handle_sacch(), and call it from l1sap_ph_data_ind(). This way perioduc RSL MEASurement RESult messages will be sent regardless of what happens on Uplink SACCH. Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Fixes: TC_meas_res_speech_{tchf,tchh}_sapi3 Related: SYS#5319 --- M include/osmo-bts/measurement.h M src/common/l1sap.c M src/common/measurement.c M src/common/rsl.c 4 files changed, 84 insertions(+), 74 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/include/osmo-bts/measurement.h b/include/osmo-bts/measurement.h index f63a05a..ad86d8d 100644 --- a/include/osmo-bts/measurement.h +++ b/include/osmo-bts/measurement.h @@ -20,8 +20,6 @@ int is_meas_complete(struct gsm_lchan *lchan, uint32_t fn); -int handle_ms_meas_report(struct gsm_lchan *lchan, - const struct gsm48_hdr *gh, - unsigned int len); +void lchan_meas_handle_sacch(struct gsm_lchan *lchan, struct msgb *msg); #endif diff --git a/src/common/l1sap.c b/src/common/l1sap.c index f983b62..8dee209 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -33,7 +33,6 @@ #include #include #include -#include #include #include #include @@ -1470,7 +1469,6 @@ uint8_t tn; uint32_t fn; enum osmo_ph_pres_info_type pr_info = data_ind->pdch_presence_info; - struct gsm_sacch_l1_hdr *l1_hdr; chan_nr = data_ind->chan_nr; link_id = data_ind->link_id; @@ -1529,48 +1527,33 @@ if (bts_internal_flag_get(trx->bts, BTS_INTERNAL_FLAG_MEAS_PAYLOAD_COMB)) process_l1sap_meas_data(lchan, l1sap, PRIM_PH_DATA); - if (L1SAP_IS_LINK_SACCH(link_id)) + if (L1SAP_IS_LINK_SACCH(link_id)) { repeated_ul_sacch_active_decision(lchan, data_ind->ber10k); - /* bad frame */ - if (len == 0) { - if (L1SAP_IS_LINK_SACCH(link_id)) { - /* In case we loose a SACCH block, we must take care - * that the related measurement report is sent via RSL. - * This is a fallback method. The report will also - * lack the measurement report from the MS side. See - * also rsl.c:lapdm_rll_tx_cb() */ - LOGPGT(DL1P, LOGL_INFO, &g_time, "Lost SACCH block, faking meas reports and ms pwr\n"); - handle_ms_meas_report(lchan, NULL, 0); - + /* Radio Link Timeout counter */ + if (len == 0) { + LOGPGT(DL1P, LOGL_INFO, &g_time, "%s Lost SACCH block\n", + gsm_lchan_name(lchan)); radio_link_timeout(lchan, true); + } else { + radio_link_timeout(lchan, false); } - return -EINVAL; + + /* Trigger the measurement reporting/processing logic */ + lchan_meas_handle_sacch(lchan, msg); } + /* bad frame */ + if (len == 0) + return -EINVAL; + /* report first valid received frame to handover process */ if (lchan->ho.active == HANDOVER_WAIT_FRAME) handover_frame(lchan); - if (L1SAP_IS_LINK_SACCH(link_id)) { - radio_link_timeout(lchan, false); + if (L1SAP_IS_LINK_SACCH(link_id)) le = &lchan->lapdm_ch.lapdm_acch; - /* save the SACCH L1 header in the lchan struct for RSL MEAS RES */ - if (len != GSM_MACBLOCK_LEN) { - LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with odd len=%u!?!\n", len); - return -EINVAL; - } - /* Some brilliant engineer decided that the ordering of - * fields on the Um interface is different from the - * order of fields in RSL. See 3GPP TS 44.004 (section 7.2) - * vs. 3GPP TS 48.058 (section 9.3.10). */ - l1_hdr = (struct gsm_sacch_l1_hdr*)data; - lchan->meas.l1_info.ms_pwr = l1_hdr->ms_pwr; - lchan->meas.l1_info.fpc_epc = l1_hdr->fpc_epc; - lchan->meas.l1_info.srr_sro = l1_hdr->srr_sro; - lchan->meas.l1_info.ta = l1_hdr->ta; - lchan->meas.flags |= LC_UL_M_F_L1_VALID; - } else + else le = &lchan->lapdm_ch.lapdm_dcch; if (check_for_first_ciphrd(lchan, data, len)) diff --git a/src/common/measurement.c b/src/common/measurement.c index a83be34..3aeb901 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -2,8 +2,11 @@ #include #include -#include #include +#include + +#include +#include #include #include @@ -865,24 +868,74 @@ LOGPLCHAN(lchan, DL1P, LOGL_DEBUG, "DL-FACCH repetition: active => inactive\n"); } -/* Called every time a Measurement Result (TS 08.58 8.4.8) is received from - * lower layers and has to be forwarded to BSC */ -int handle_ms_meas_report(struct gsm_lchan *lchan, - const struct gsm48_hdr *gh, - unsigned int len) +static bool data_is_rr_meas_rep(const uint8_t *data) { + const struct gsm48_hdr *gh = (void *)(data + 5); + const uint8_t *lapdm_hdr = (void *)(data + 2); + + /* LAPDm address field: SAPI=0, C/R=0, EA=1 */ + if (lapdm_hdr[0] != 0x01) + return false; + /* LAPDm control field: U, func=UI */ + if (lapdm_hdr[1] != 0x03) + return false; + /* Protocol discriminator: RR */ + if (gh->proto_discr != GSM48_PDISC_RR) + return false; + + switch (gh->msg_type) { + case GSM48_MT_RR_EXT_MEAS_REP: + case GSM48_MT_RR_MEAS_REP: + return true; + default: + return false; + } +} + +/* Called every time a SACCH block is received from lower layers */ +void lchan_meas_handle_sacch(struct gsm_lchan *lchan, struct msgb *msg) +{ + const struct gsm48_meas_res *mr = NULL; + const struct gsm48_hdr *gh = NULL; int timing_offset, rc; struct lapdm_entity *le; - bool dtxu_used; + bool dtxu_used = true; /* safe default assumption */ uint8_t ms_pwr; uint8_t ms_ta; int8_t ul_rssi; int16_t ul_ci_cb; + if (msgb_l2len(msg) == GSM_MACBLOCK_LEN) { + /* Some brilliant engineer decided that the ordering of + * fields on the Um interface is different from the + * order of fields in RSL. See 3GPP TS 44.004 (section 7.2) + * vs. 3GPP TS 48.058 (section 9.3.10). */ + const struct gsm_sacch_l1_hdr *l1h = msgb_l2(msg); + lchan->meas.l1_info.ms_pwr = l1h->ms_pwr; + lchan->meas.l1_info.fpc_epc = l1h->fpc_epc; + lchan->meas.l1_info.srr_sro = l1h->srr_sro; + lchan->meas.l1_info.ta = l1h->ta; + lchan->meas.flags |= LC_UL_M_F_L1_VALID; + + /* Check if this is a Measurement Report */ + if (data_is_rr_meas_rep(msgb_l2(msg))) { + /* Skip both L1 SACCH and LAPDm headers */ + msg->l3h = (void *)(msg->l2h + 2 + 3); + gh = msgb_l3(msg); + } + + ms_pwr = lchan->meas.l1_info.ms_pwr; + ms_ta = lchan->meas.l1_info.ta; + } else { + lchan->meas.flags &= ~LC_UL_M_F_L1_VALID; + ms_pwr = lchan->ms_power_ctrl.current; + ms_ta = lchan->ta_ctrl.current; + } + le = &lchan->lapdm_ch.lapdm_acch; timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, le) : -1; - rc = rsl_tx_meas_res(lchan, (const uint8_t *)gh, len, timing_offset); + rc = rsl_tx_meas_res(lchan, msgb_l3(msg), msgb_l3len(msg), timing_offset); if (rc == 0) /* Count successful transmissions */ lchan->meas.res_nr++; @@ -896,25 +949,9 @@ * feed the Control Loop with the measurements for the same * period (the previous one), which is stored in lchan->meas(.ul_res): */ - if (len == 0) { - dtxu_used = true; - ms_ta = lchan->ta_ctrl.current; - ms_pwr = lchan->ms_power_ctrl.current; - } else { - /* if len!=0, it means we were able to parse L1Header in UL SACCH: */ - OSMO_ASSERT(lchan->meas.flags & LC_UL_M_F_L1_VALID); - - ms_ta = lchan->meas.l1_info.ta; - ms_pwr = lchan->meas.l1_info.ms_pwr; - switch (gh->msg_type) { - case GSM48_MT_RR_MEAS_REP: - dtxu_used = (len > sizeof(*gh) + 1) && !!(gh->data[0] & 0x40); - break; - case GSM48_MT_RR_EXT_MEAS_REP: - default: - dtxu_used = true; /* FIXME: not implemented */ - break; - } + if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) { + mr = (const struct gsm48_meas_res *)gh->data; + dtxu_used = mr->dtx_used; } if (dtxu_used) { @@ -934,8 +971,6 @@ /* Reset state for next iteration */ lchan->tch.dtx.dl_active = false; lchan->meas.flags &= ~LC_UL_M_F_OSMO_EXT_VALID; - lchan->meas.flags &= ~LC_UL_M_F_L1_VALID; lchan->ms_t_offs = -1; lchan->p_offs = -1; - return rc; } diff --git a/src/common/rsl.c b/src/common/rsl.c index 2d00005..5d069c2 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -3566,17 +3566,11 @@ msg->trx = lchan->ts->trx; msg->lchan = lchan; - /* check if this is a measurement report from SACCH which needs special - * processing before forwarding */ + /* If this is a Measurement Report, then we simply ignore it, + * because it has already been processed in l1sap_ph_data_ind(). */ if (rslms_is_meas_rep(msg)) { - int rc; - - LOGPLCHAN(lchan, DRSL, LOGL_INFO, "Handing RLL msg %s from LAPDm to MEAS REP\n", - rsl_msg_name(rh->msg_type)); - - rc = handle_ms_meas_report(lchan, (struct gsm48_hdr *)msgb_l3(msg), msgb_l3len(msg)); msgb_free(msg); - return rc; + return 0; } else if (rslms_is_gprs_susp_req(msg)) { return handle_gprs_susp_req(msg); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:47:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:47:14 +0000 Subject: Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 ) Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid ...................................................................... lchan_meas_handle_sacch(): check if Measurement Result is valid We should not rely on measurement data marked as invalid. Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2 --- M src/common/measurement.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/common/measurement.c b/src/common/measurement.c index 3aeb901..73c5e43 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -951,7 +951,8 @@ */ if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) { mr = (const struct gsm48_meas_res *)gh->data; - dtxu_used = mr->dtx_used; + if (mr->meas_valid == 0) /* 0 = valid */ + dtxu_used = mr->dtx_used; } if (dtxu_used) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2 Gerrit-Change-Number: 26047 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:47:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:47:14 +0000 Subject: Change in osmo-bts[master]: measurement: get rid of *le in lchan_meas_handle_sacch() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26051 ) Change subject: measurement: get rid of *le in lchan_meas_handle_sacch() ...................................................................... measurement: get rid of *le in lchan_meas_handle_sacch() The current Timing Advance value can be obtained either from the L1 SACCH header (if received) or from lchan->ta_ctrl.current. Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 --- M src/common/measurement.c 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/measurement.c b/src/common/measurement.c index 73c5e43..042f8b9 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -782,9 +782,9 @@ lchan->meas.last_fn = LCHAN_FN_DUMMY; } -static inline uint8_t ms_to2rsl(const struct gsm_lchan *lchan, const struct lapdm_entity *le) +static inline uint8_t ms_to2rsl(const struct gsm_lchan *lchan, uint8_t ta) { - return (lchan->ms_t_offs >= 0) ? lchan->ms_t_offs : (lchan->p_offs - le->ta); + return (lchan->ms_t_offs >= 0) ? lchan->ms_t_offs : (lchan->p_offs - ta); } static inline bool ms_to_valid(const struct gsm_lchan *lchan) @@ -898,7 +898,6 @@ const struct gsm48_meas_res *mr = NULL; const struct gsm48_hdr *gh = NULL; int timing_offset, rc; - struct lapdm_entity *le; bool dtxu_used = true; /* safe default assumption */ uint8_t ms_pwr; uint8_t ms_ta; @@ -932,9 +931,7 @@ ms_ta = lchan->ta_ctrl.current; } - le = &lchan->lapdm_ch.lapdm_acch; - - timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, le) : -1; + timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, ms_ta) : -1; rc = rsl_tx_meas_res(lchan, msgb_l3(msg), msgb_l3len(msg), timing_offset); if (rc == 0) /* Count successful transmissions */ lchan->meas.res_nr++; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 Gerrit-Change-Number: 26051 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:47:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:47:15 +0000 Subject: Change in osmo-bts[master]: measurement: pass *mr to repeated_dl_facch_active_decision() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26048 ) Change subject: measurement: pass *mr to repeated_dl_facch_active_decision() ...................................................................... measurement: pass *mr to repeated_dl_facch_active_decision() Change-Id: Idbf5f95d632aa2270c49b351ad5561ca2182bf9a Related: SYS#5114 --- M src/common/measurement.c 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/measurement.c b/src/common/measurement.c index 042f8b9..c5d60b2 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -795,9 +795,8 @@ /* Decide if repeated FACCH should be applied or not. If RXQUAL level, that the * MS reports is high enough, FACCH repetition is not needed. */ static void repeated_dl_facch_active_decision(struct gsm_lchan *lchan, - const struct gsm48_hdr *gh) + const struct gsm48_meas_res *meas_res) { - const struct gsm48_meas_res *meas_res; uint8_t upper; uint8_t lower; uint8_t rxqual; @@ -828,14 +827,8 @@ } /* Parse MS measurement results */ - if (gh == NULL) + if (meas_res == NULL) goto out; - /* Check if this is a Measurement Report */ - if (gh->proto_discr != GSM48_PDISC_RR) - goto out; - if (gh->msg_type != GSM48_MT_RR_MEAS_REP) - goto out; - meas_res = (const struct gsm48_meas_res *) gh->data; if (meas_res->meas_valid != 0) /* 0 = valid */ goto out; @@ -964,7 +957,7 @@ if (gh) lchan_bs_pwr_ctrl(lchan, gh); - repeated_dl_facch_active_decision(lchan, gh); + repeated_dl_facch_active_decision(lchan, mr); /* Reset state for next iteration */ lchan->tch.dtx.dl_active = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idbf5f95d632aa2270c49b351ad5561ca2182bf9a Gerrit-Change-Number: 26048 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:47:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:47:17 +0000 Subject: Change in osmo-bts[master]: measurement: pass *mr to lchan_bs_pwr_ctrl() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26049 ) Change subject: measurement: pass *mr to lchan_bs_pwr_ctrl() ...................................................................... measurement: pass *mr to lchan_bs_pwr_ctrl() As a side effect, we have to sacrifice a unit test (TC_inval_dummy) because it becomes impossible to pass a dummy or invalid SACCH block to lchan_bs_pwr_ctrl(). Change-Id: I937117cf26fb718d57920382f6972390ad498c51 Related: SYS#4918 --- M include/osmo-bts/power_control.h M src/common/measurement.c M src/common/power_control.c M tests/power/bs_power_loop_test.c M tests/power/bs_power_loop_test.err M tests/power/bs_power_loop_test.ok 6 files changed, 19 insertions(+), 112 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmo-bts/power_control.h b/include/osmo-bts/power_control.h index e8b035d..0764ba7 100644 --- a/include/osmo-bts/power_control.h +++ b/include/osmo-bts/power_control.h @@ -87,4 +87,4 @@ const int16_t ul_lqual_cb); int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan, - const struct gsm48_hdr *gh); + const struct gsm48_meas_res *mr); diff --git a/src/common/measurement.c b/src/common/measurement.c index c5d60b2..8f33eaa 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -954,8 +954,8 @@ } lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256); lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb); - if (gh) - lchan_bs_pwr_ctrl(lchan, gh); + if (mr && mr->meas_valid == 0) /* 0 = valid */ + lchan_bs_pwr_ctrl(lchan, mr); repeated_dl_facch_active_decision(lchan, mr); diff --git a/src/common/power_control.c b/src/common/power_control.c index a81000e..42d9d07 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -311,46 +311,26 @@ /*! compute the new Downlink attenuation value for the given logical channel. * \param lchan logical channel for which to compute (and in which to store) new power value. - * \param[in] gh pointer to the beginning of (presumably) a Measurement Report. + * \param[in] mr pointer to a *valid* Measurement Report. */ int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan, - const struct gsm48_hdr *gh) + const struct gsm48_meas_res *mr) { struct lchan_power_ctrl_state *state = &lchan->bs_power_ctrl; const struct gsm_power_ctrl_params *params = state->dpc_params; - uint8_t rxqual_full, rxqual_sub; - uint8_t rxlev_full, rxlev_sub; uint8_t rxqual, rxqual_avg, rxlev, rxlev_avg; int new_att; /* Check if dynamic BS Power Control is enabled */ if (params == NULL) return 0; - /* Check if this is a Measurement Report */ - if (gh->proto_discr != GSM48_PDISC_RR) - return 0; - if (gh->msg_type != GSM48_MT_RR_MEAS_REP) - return 0; - - /* Check if the measurement results are valid */ - if ((gh->data[1] & 0x40) == 0x40) { - LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG, - "The measurement results are not valid\n"); - return 0; - } - - /* See 3GPP TS 44.018, section 10.5.2.20 */ - rxqual_full = (gh->data[2] >> 4) & 0x7; - rxqual_sub = (gh->data[2] >> 1) & 0x7; - - rxlev_full = gh->data[0] & 0x3f; - rxlev_sub = gh->data[1] & 0x3f; LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG, "Rx DL Measurement Report: " "RXLEV-FULL(%02u), RXQUAL-FULL(%u), " "RXLEV-SUB(%02u), RXQUAL-SUB(%u), " "DTx is %s => using %s\n", - rxlev_full, rxqual_full, rxlev_sub, rxqual_sub, + mr->rxlev_full, mr->rxqual_full, + mr->rxlev_sub, mr->rxqual_sub, lchan->tch.dtx.dl_active ? "enabled" : "disabled", lchan->tch.dtx.dl_active ? "SUB" : "FULL"); @@ -360,11 +340,11 @@ /* If DTx is active on Downlink, use the '-SUB' */ if (lchan->tch.dtx.dl_active) { - rxqual = rxqual_sub; - rxlev = rxlev_sub; + rxqual = mr->rxqual_sub; + rxlev = mr->rxlev_sub; } else { /* ... otherwise use the '-FULL' */ - rxqual = rxqual_full; - rxlev = rxlev_full; + rxqual = mr->rxqual_full; + rxlev = mr->rxlev_full; } rxlev_avg = do_avg_algo(¶ms->rxlev_meas, &state->rxlev_meas_proc, rxlev); diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c index 6b67ba2..06fe3ed 100644 --- a/tests/power/bs_power_loop_test.c +++ b/tests/power/bs_power_loop_test.c @@ -47,14 +47,8 @@ { DL_MEAS_FULL(rxqual, rxlev), \ DL_MEAS_SUB(rxqual, rxlev) } -#define DL_MEAS_FULL_SUB_INV(rxqual, rxlev) \ - { DL_MEAS_FULL(rxqual, rxlev), \ - DL_MEAS_SUB(rxqual, rxlev), \ - .invalid = true } - enum power_test_step_type { PWR_TEST_ST_IND_MEAS = 0, - PWR_TEST_ST_IND_DUMMY, PWR_TEST_ST_SET_STATE, PWR_TEST_ST_SET_CTRL_INTERVAL, PWR_TEST_ST_SET_STEP_SIZE, @@ -78,7 +72,6 @@ uint8_t rxqual_sub; uint8_t rxlev_full; uint8_t rxlev_sub; - bool invalid; } meas; /* Increase / reduce step size */ struct { @@ -123,28 +116,21 @@ printf("\nStarting test case '%s'\n", name); } -static void enc_meas_rep(struct gsm48_hdr *gh, +static void enc_meas_rep(struct gsm48_meas_res *mr, const unsigned int n, const struct power_test_step *step) { - struct gsm48_meas_res *mr = (struct gsm48_meas_res *) gh->data; - - gh->proto_discr = GSM48_PDISC_RR; - gh->msg_type = GSM48_MT_RR_MEAS_REP; - *mr = (struct gsm48_meas_res) { .rxlev_full = step->meas.rxlev_full, .rxlev_sub = step->meas.rxlev_sub, .rxqual_full = step->meas.rxqual_full, .rxqual_sub = step->meas.rxqual_sub, - /* NOTE: inversed logic (1 means invalid) */ - .meas_valid = step->meas.invalid, }; - printf("#%02u %s() -> Measurement Results (%svalid): " + printf("#%02u %s() -> Measurement Results (valid): " "RXLEV-FULL(%02u), RXQUAL-FULL(%u), " "RXLEV-SUB(%02u), RXQUAL-SUB(%u)\n", - n, __func__, step->meas.invalid ? "in" : "", + n, __func__, mr->rxlev_full, mr->rxqual_full, mr->rxlev_sub, mr->rxqual_sub); } @@ -153,11 +139,8 @@ const unsigned int n, const struct power_test_step *step) { - struct gsm48_hdr *gh; + struct gsm48_meas_res mr; uint8_t old, new; - uint8_t buf[18]; - - gh = (struct gsm48_hdr *) buf; switch (step->type) { case PWR_TEST_ST_SET_STATE: @@ -192,20 +175,16 @@ printf("#%02u %s() <- Enable DTXd\n", n, __func__); lchan->tch.dtx.dl_active = true; return 0; /* we're done */ - case PWR_TEST_ST_IND_DUMMY: - printf("#%02u %s() <- Dummy block\n", n, __func__); - memset(buf, 0x2b, sizeof(buf)); - break; case PWR_TEST_ST_IND_MEAS: - enc_meas_rep(gh, n, step); + enc_meas_rep(&mr, n, step); break; } - printf("#%02u lchan_bs_pwr_ctrl() <- UL SACCH: %s\n", - n, osmo_hexdump(buf, sizeof(buf))); + printf("#%02u lchan_bs_pwr_ctrl() <- UL SACCH: 06 15 %s\n", + n, osmo_hexdump((void *)&mr, sizeof(mr))); old = lchan->bs_power_ctrl.current; - lchan_bs_pwr_ctrl(lchan, gh); + lchan_bs_pwr_ctrl(lchan, &mr); new = lchan->bs_power_ctrl.current; printf("#%02u lchan_bs_pwr_ctrl() -> BS power reduction: " @@ -406,24 +385,6 @@ { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET) }, /* max */ }; -/* Verify that invalid and dummy SACCH blocks are ignored. */ -static const struct power_test_step TC_inval_dummy[] = { - /* Initial state: 16 dB, up to 20 dB */ - { .type = PWR_TEST_ST_SET_STATE, - .state = { .current = 16, .max = 2 * 10 } }, - - /* MS sends invalid measurement results which must be ignored */ - { .meas = DL_MEAS_FULL_SUB_INV(7, 63), .exp_txred = 16 }, - { .meas = DL_MEAS_FULL_SUB_INV(0, 0), .exp_txred = 16 }, - - /* Let's say SMS (SAPI=3) blocks substitute some of the reports */ - { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, - { .type = PWR_TEST_ST_IND_DUMMY, /* not a report */ .exp_txred = 16 }, - { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, - { .type = PWR_TEST_ST_IND_DUMMY, /* not a report */ .exp_txred = 16 }, - { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET), .exp_txred = 16 }, -}; - /* Verify handling of optional power control interval (P_Con_INTERVAL). */ static const struct power_test_step TC_ctrl_interval[] = { /* Initial state: 0 dB, up to 20 dB */ @@ -545,7 +506,6 @@ exec_test(TC_dtxd_mode); exec_test(TC_rxqual_ber); - exec_test(TC_inval_dummy); exec_test(TC_ctrl_interval); exec_test(TC_rxlev_hyst); diff --git a/tests/power/bs_power_loop_test.err b/tests/power/bs_power_loop_test.err index dc4f411..24107ba 100644 --- a/tests/power/bs_power_loop_test.err +++ b/tests/power/bs_power_loop_test.err @@ -130,14 +130,6 @@ (bts=0,trx=0,ts=0,ss=0) Keeping DL attenuation at 0 dB: max 20 dB, RSSI[curr -80, avg -80, thresh -80..-80] dBm, RxQual[curr 7, avg 7, thresh 3..0] (bts=0,trx=0,ts=0,ss=0) Rx DL Measurement Report: RXLEV-FULL(30), RXQUAL-FULL(7), RXLEV-SUB(30), RXQUAL-SUB(7), DTx is disabled => using FULL (bts=0,trx=0,ts=0,ss=0) Keeping DL attenuation at 0 dB: max 20 dB, RSSI[curr -80, avg -80, thresh -80..-80] dBm, RxQual[curr 7, avg 7, thresh 3..0] -(bts=0,trx=0,ts=0,ss=0) The measurement results are not valid -(bts=0,trx=0,ts=0,ss=0) The measurement results are not valid -(bts=0,trx=0,ts=0,ss=0) Rx DL Measurement Report: RXLEV-FULL(30), RXQUAL-FULL(0), RXLEV-SUB(30), RXQUAL-SUB(0), DTx is disabled => using FULL -(bts=0,trx=0,ts=0,ss=0) Keeping DL attenuation at 16 dB: max 20 dB, RSSI[curr -80, avg -80, thresh -80..-80] dBm, RxQual[curr 0, avg 0, thresh 3..0] -(bts=0,trx=0,ts=0,ss=0) Rx DL Measurement Report: RXLEV-FULL(30), RXQUAL-FULL(0), RXLEV-SUB(30), RXQUAL-SUB(0), DTx is disabled => using FULL -(bts=0,trx=0,ts=0,ss=0) Keeping DL attenuation at 16 dB: max 20 dB, RSSI[curr -80, avg -80, thresh -80..-80] dBm, RxQual[curr 0, avg 0, thresh 3..0] -(bts=0,trx=0,ts=0,ss=0) Rx DL Measurement Report: RXLEV-FULL(30), RXQUAL-FULL(0), RXLEV-SUB(30), RXQUAL-SUB(0), DTx is disabled => using FULL -(bts=0,trx=0,ts=0,ss=0) Keeping DL attenuation at 16 dB: max 20 dB, RSSI[curr -80, avg -80, thresh -80..-80] dBm, RxQual[curr 0, avg 0, thresh 3..0] (bts=0,trx=0,ts=0,ss=0) Rx DL Measurement Report: RXLEV-FULL(60), RXQUAL-FULL(0), RXLEV-SUB(60), RXQUAL-SUB(0), DTx is disabled => using FULL (bts=0,trx=0,ts=0,ss=0) Raising DL attenuation 0 dB => 2 dB:max 20 dB, RSSI[curr -50, avg -50, thresh -80..-80] dBm, RxQual[curr 0, avg 0, thresh 3..0] (bts=0,trx=0,ts=0,ss=0) Rx DL Measurement Report: RXLEV-FULL(60), RXQUAL-FULL(0), RXLEV-SUB(60), RXQUAL-SUB(0), DTx is disabled => using FULL diff --git a/tests/power/bs_power_loop_test.ok b/tests/power/bs_power_loop_test.ok index 2c12392..18a94ba 100644 --- a/tests/power/bs_power_loop_test.ok +++ b/tests/power/bs_power_loop_test.ok @@ -243,31 +243,6 @@ #16 lchan_bs_pwr_ctrl() -> BS power reduction: 0 -> 0 (expected 0) Test case verdict: SUCCESS -Starting test case 'TC_inval_dummy' -#00 exec_power_step() <- State (re)set (current 16 dB, max 20 dB) -#01 enc_meas_rep() -> Measurement Results (invalid): RXLEV-FULL(63), RXQUAL-FULL(7), RXLEV-SUB(63), RXQUAL-SUB(7) -#01 lchan_bs_pwr_ctrl() <- UL SACCH: 06 15 3f 7f 7e 00 00 00 00 00 00 00 00 00 00 00 00 00 -#01 lchan_bs_pwr_ctrl() -> BS power reduction: 16 -> 16 (expected 16) -#02 enc_meas_rep() -> Measurement Results (invalid): RXLEV-FULL(00), RXQUAL-FULL(0), RXLEV-SUB(00), RXQUAL-SUB(0) -#02 lchan_bs_pwr_ctrl() <- UL SACCH: 06 15 00 40 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -#02 lchan_bs_pwr_ctrl() -> BS power reduction: 16 -> 16 (expected 16) -#03 enc_meas_rep() -> Measurement Results (valid): RXLEV-FULL(30), RXQUAL-FULL(0), RXLEV-SUB(30), RXQUAL-SUB(0) -#03 lchan_bs_pwr_ctrl() <- UL SACCH: 06 15 1e 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -#03 lchan_bs_pwr_ctrl() -> BS power reduction: 16 -> 16 (expected 16) -#04 exec_power_step() <- Dummy block -#04 lchan_bs_pwr_ctrl() <- UL SACCH: 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b -#04 lchan_bs_pwr_ctrl() -> BS power reduction: 16 -> 16 (expected 16) -#05 enc_meas_rep() -> Measurement Results (valid): RXLEV-FULL(30), RXQUAL-FULL(0), RXLEV-SUB(30), RXQUAL-SUB(0) -#05 lchan_bs_pwr_ctrl() <- UL SACCH: 06 15 1e 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -#05 lchan_bs_pwr_ctrl() -> BS power reduction: 16 -> 16 (expected 16) -#06 exec_power_step() <- Dummy block -#06 lchan_bs_pwr_ctrl() <- UL SACCH: 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b -#06 lchan_bs_pwr_ctrl() -> BS power reduction: 16 -> 16 (expected 16) -#07 enc_meas_rep() -> Measurement Results (valid): RXLEV-FULL(30), RXQUAL-FULL(0), RXLEV-SUB(30), RXQUAL-SUB(0) -#07 lchan_bs_pwr_ctrl() <- UL SACCH: 06 15 1e 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -#07 lchan_bs_pwr_ctrl() -> BS power reduction: 16 -> 16 (expected 16) -Test case verdict: SUCCESS - Starting test case 'TC_ctrl_interval' #00 exec_power_step() <- State (re)set (current 0 dB, max 20 dB) #01 exec_power_step() <- (Re)set power control interval: 0 -> 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937117cf26fb718d57920382f6972390ad498c51 Gerrit-Change-Number: 26049 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 13:47:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 13:47:30 +0000 Subject: Change in osmo-bts[master]: [overpower] Turn it on and off depending on DL RxQual In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25899 ) Change subject: [overpower] Turn it on and off depending on DL RxQual ...................................................................... [overpower] Turn it on and off depending on DL RxQual Change-Id: Iaa812d4661ee17c4cd4a8c4ae4bd3e94c1a2e6cc Depends: Ia28293a12de0af71f55e701fb65c46e905dae217 Related: SYS#5319 --- M include/osmo-bts/lchan.h M src/common/measurement.c M src/common/rsl.c M src/common/scheduler.c 4 files changed, 57 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h index 754dc7c..3aaa75a 100644 --- a/include/osmo-bts/lchan.h +++ b/include/osmo-bts/lchan.h @@ -293,8 +293,9 @@ struct gsm_power_ctrl_params ms_dpc_params; struct gsm_power_ctrl_params bs_dpc_params; - /* Temporary ACCH overpower capabilities */ + /* Temporary ACCH overpower capabilities and state */ struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap; + bool top_acch_active; struct msgb *pending_rel_ind_msg; diff --git a/src/common/measurement.c b/src/common/measurement.c index 8f33eaa..4341be7 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -861,6 +861,43 @@ LOGPLCHAN(lchan, DL1P, LOGL_DEBUG, "DL-FACCH repetition: active => inactive\n"); } +static void acch_overpower_active_decision(struct gsm_lchan *lchan, + const struct gsm48_meas_res *meas_res) +{ + const bool old = lchan->top_acch_active; + uint8_t upper, lower, rxqual; + + /* ACCH overpower is not allowed => nothing to do */ + if (lchan->top_acch_cap.overpower_db == 0) + return; + /* RxQual threshold is disabled => overpower is always on */ + if (lchan->top_acch_cap.rxqual == 0) + return; + + /* If DTx is active on Downlink, use the '-SUB' */ + if (meas_res->dtx_used) + rxqual = meas_res->rxqual_sub; + else /* ... otherwise use the '-FULL' */ + rxqual = meas_res->rxqual_full; + + upper = lchan->top_acch_cap.rxqual; + if (upper > 2) + lower = upper - 2; + else + lower = 0; + + if (rxqual >= upper) + lchan->top_acch_active = true; + else if (rxqual <= lower) + lchan->top_acch_active = false; + + if (lchan->top_acch_active != old) { + LOGPLCHAN(lchan, DL1P, LOGL_DEBUG, "Temporary ACCH overpower: %s\n", + lchan->top_acch_active ? "inactive => active" + : "active => inactive"); + } +} + static bool data_is_rr_meas_rep(const uint8_t *data) { const struct gsm48_hdr *gh = (void *)(data + 5); @@ -954,8 +991,10 @@ } lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256); lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb); - if (mr && mr->meas_valid == 0) /* 0 = valid */ + if (mr && mr->meas_valid == 0) { /* 0 = valid */ lchan_bs_pwr_ctrl(lchan, mr); + acch_overpower_active_decision(lchan, mr); + } repeated_dl_facch_active_decision(lchan, mr); diff --git a/src/common/rsl.c b/src/common/rsl.c index 5d069c2..4c84f21 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1928,6 +1928,13 @@ if (rc < 0) return rsl_tx_chan_act_acknack(lchan, -rc); + /* Take the first ACCH overpower decision (if allowed): it can be + * enabled immediately if the RxQual threshold is disabled (0). */ + if (lchan->top_acch_cap.overpower_db > 0) + lchan->top_acch_active = !lchan->top_acch_cap.rxqual; + else + lchan->top_acch_active = false; + /* actually activate the channel in the BTS */ rc = l1sap_chan_act(lchan->ts->trx, dch->chan_nr, &tp); if (rc < 0) @@ -2198,6 +2205,13 @@ if (rc < 0) return rsl_tx_mode_modif_nack(lchan, -rc); + /* Immediately disable ACCH overpower if the value is 0 dB, + * or enable if the RxQual threshold becomes disabled (0). */ + if (lchan->top_acch_cap.overpower_db == 0) + lchan->top_acch_active = false; + else if (lchan->top_acch_cap.rxqual == 0) + lchan->top_acch_active = true; + l1sap_chan_modify(lchan->ts->trx, dch->chan_nr); /* FIXME: delay this until L1 says OK? */ diff --git a/src/common/scheduler.c b/src/common/scheduler.c index ba5c18a..d8048b5 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1310,7 +1310,7 @@ br->att = lchan->bs_power_ctrl.current; /* Temporary Overpower for SACCH/FACCH bursts */ - if (lchan->top_acch_cap.overpower_db == 0) + if (!lchan->top_acch_active) return; if ((lchan->top_acch_cap.sacch_enable && desc->link_id == LID_SACCH) || (lchan->top_acch_cap.facch_enable && br->flags & TRX_BR_F_FACCH)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa812d4661ee17c4cd4a8c4ae4bd3e94c1a2e6cc Gerrit-Change-Number: 25899 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:15:17 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 4 Nov 2021 14:15:17 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... Patch Set 1: Code-Review+1 > Patch Set 1: > > Is it safe to change counter names in general? > AFAIU, if we do so, we may break external monitoring tools for the users. I agree with the concern, but think the change still makes sense. Better do it before the per-type splitting than after. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 14:15:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:26:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 14:26:42 +0000 Subject: Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26104 ) Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro ...................................................................... gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/26104/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 3fa9419..e54ce42 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -593,6 +593,10 @@ #endif } __attribute__ ((packed)); +/* Check if the given mr contains valid measurement results */ +#define gsm48_meas_res_is_valid(mr) \ + ((mr)->meas_valid == 0) /* 0 means valid */ + /* Chapter 10.5.2.21aa */ struct gsm48_multi_rate_conf { #if OSMO_IS_LITTLE_ENDIAN -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:39:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 14:39:52 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > > Patch Set 1: > > > > Is it safe to change counter names in general? > > AFAIU, if we do so, we may break external monitoring tools for the users. > > I agree with the concern, but think the change still makes sense. Better do it before the per-type splitting than after. Agree with Daniel, I checked no TTCN3 is using it, and I doubt anyone is really using them systematically yet. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 14:39:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:41:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 14:41:00 +0000 Subject: Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26104 ) Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26104/1/include/osmocom/gsm/protocol/gsm_04_08.h File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/26104/1/include/osmocom/gsm/protocol/gsm_04_08.h at 597 PS1, Line 597: #define gsm48_meas_res_is_valid(mr) \ maybe a static inline would be clearer here, but fine anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 14:41:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:41:06 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 4 Nov 2021 14:41:06 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 4: (5 comments) https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/gsm_04_08.c at 415 PS1, Line 415: is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, > This logic > 0x01 is a bit confusion to read. [?] i would like to replace it in a patch after this one https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c at 1296 PS4, Line 1296: is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, > it may make sense to have an msc_a_encryption_enabled(msc_a) function, since you do this complex tes [?] i would like to replace it in a patch https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c at 172 PS4, Line 172: /* So far just a boolean switch, a future patch might add individual config for UEA1 and UEA2, see OS#4143 */ > This comment is not true anymore. Done https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c at 371 PS4, Line 371: for (i = 0; i < 8; i++) { > So in the command above we only support UEA0/1/2, but here we go up to 8. is it a problem? so far we never set it to anything > UEA2 because the vty validates the range and the default is also correct. https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c at 375 PS3, Line 375: return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > 0x01 ? cm->vec->ck : NULL, > You mismatched the arguments. The keystatus needs to be in fron of 0x06. [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 14:41:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:41:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 14:41:41 +0000 Subject: Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() macro References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26105 ) Change subject: measurement: make use of gsm48_meas_res_is_valid() macro ...................................................................... measurement: make use of gsm48_meas_res_is_valid() macro Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Depends: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M src/common/measurement.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/26105/1 diff --git a/src/common/measurement.c b/src/common/measurement.c index 4341be7..1a5992b 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -829,7 +829,7 @@ /* Parse MS measurement results */ if (meas_res == NULL) goto out; - if (meas_res->meas_valid != 0) /* 0 = valid */ + if (!gsm48_meas_res_is_valid(meas_res)) goto out; /* If the RXQUAL level at the MS drops under a certain threshold @@ -978,7 +978,7 @@ */ if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) { mr = (const struct gsm48_meas_res *)gh->data; - if (mr->meas_valid == 0) /* 0 = valid */ + if (gsm48_meas_res_is_valid(mr)) dtxu_used = mr->dtx_used; } @@ -991,7 +991,7 @@ } lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256); lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb); - if (mr && mr->meas_valid == 0) { /* 0 = valid */ + if (mr && gsm48_meas_res_is_valid(mr)) { lchan_bs_pwr_ctrl(lchan, mr); acch_overpower_active_decision(lchan, mr); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:42:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 14:42:25 +0000 Subject: Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() macro In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26105 ) Change subject: measurement: make use of gsm48_meas_res_is_valid() macro ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Nov 2021 14:42:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:46:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 14:46:57 +0000 Subject: Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26104 to look at the new patch set (#2). Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() ...................................................................... gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/26104/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:47:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 14:47:10 +0000 Subject: Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 to look at the new patch set (#2). Change subject: measurement: make use of gsm48_meas_res_is_valid() ...................................................................... measurement: make use of gsm48_meas_res_is_valid() Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Depends: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M src/common/measurement.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/26105/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:47:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 14:47:53 +0000 Subject: Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26104 ) Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 14:47:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:48:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 14:48:04 +0000 Subject: Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26105 ) Change subject: measurement: make use of gsm48_meas_res_is_valid() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 14:48:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 14:50:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 14:50:25 +0000 Subject: Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26104 ) Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() ...................................................................... gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 3fa9419..ea77e76 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -593,6 +593,12 @@ #endif } __attribute__ ((packed)); +/*! Check if the given mr contains valid measurement results */ +static inline bool gsm48_meas_res_is_valid(const struct gsm48_meas_res *mr) +{ + return (mr->meas_valid == 0); /* 0 means valid */ +} + /* Chapter 10.5.2.21aa */ struct gsm48_multi_rate_conf { #if OSMO_IS_LITTLE_ENDIAN -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 15:05:44 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 4 Nov 2021 15:05:44 +0000 Subject: Change in libosmocore[master]: include: add enum for UTRAN cipher References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26106 ) Change subject: include: add enum for UTRAN cipher ...................................................................... include: add enum for UTRAN cipher Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf --- M include/Makefile.am A include/osmocom/crypt/utran_cipher.h 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/26106/1 diff --git a/include/Makefile.am b/include/Makefile.am index 7df651a..49402d0 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -64,6 +64,7 @@ osmocom/crypt/auth.h \ osmocom/crypt/gprs_cipher.h \ osmocom/crypt/kdf.h \ + osmocom/crypt/utran_cipher.h \ osmocom/ctrl/control_cmd.h \ osmocom/ctrl/control_if.h \ osmocom/ctrl/ports.h \ diff --git a/include/osmocom/crypt/utran_cipher.h b/include/osmocom/crypt/utran_cipher.h new file mode 100644 index 0000000..9c14da8 --- /dev/null +++ b/include/osmocom/crypt/utran_cipher.h @@ -0,0 +1,18 @@ +/*! \file utran_cipher.h */ + +#pragma once + +/* 3GPP TS 25.413 ? 9.2.1.11 */ +enum utran_integrity_algo { + UTRAN_UIA1 = 0, + UTRAN_UIA2 = 1, + _UTRAN_UIA_NUM +}; +/* 3GPP TS 25.413 ? 9.2.1.12 */ +enum utran_encryption_algo { + UTRAN_UEA0 = 0, + UTRAN_UEA1 = 1, + UTRAN_UEA2 = 2, + _UTRAN_UEA_NUM +}; + -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 15:07:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 15:07:42 +0000 Subject: Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26105 ) Change subject: measurement: make use of gsm48_meas_res_is_valid() ...................................................................... measurement: make use of gsm48_meas_res_is_valid() Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Depends: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M src/common/measurement.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/measurement.c b/src/common/measurement.c index 4341be7..1a5992b 100644 --- a/src/common/measurement.c +++ b/src/common/measurement.c @@ -829,7 +829,7 @@ /* Parse MS measurement results */ if (meas_res == NULL) goto out; - if (meas_res->meas_valid != 0) /* 0 = valid */ + if (!gsm48_meas_res_is_valid(meas_res)) goto out; /* If the RXQUAL level at the MS drops under a certain threshold @@ -978,7 +978,7 @@ */ if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) { mr = (const struct gsm48_meas_res *)gh->data; - if (mr->meas_valid == 0) /* 0 = valid */ + if (gsm48_meas_res_is_valid(mr)) dtxu_used = mr->dtx_used; } @@ -991,7 +991,7 @@ } lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256); lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb); - if (mr && mr->meas_valid == 0) { /* 0 = valid */ + if (mr && gsm48_meas_res_is_valid(mr)) { lchan_bs_pwr_ctrl(lchan, mr); acch_overpower_active_decision(lchan, mr); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 15:14:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 15:14:51 +0000 Subject: Change in libosmocore[master]: include: add enum for UTRAN cipher In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26106 ) Change subject: include: add enum for UTRAN cipher ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 15:14:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 15:48:06 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 4 Nov 2021 15:48:06 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c File src/libmsc/msc_net_init.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c at 71 PS1, Line 71: net->uea_encryption_mask = (1 << 2) | (1 << 1); > > Is uea_encryption_mask a mask of discrete bits or does it contain the algorithm number? [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 15:48:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 15:51:53 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 4 Nov 2021 15:51:53 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: lynxis lazus has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Make UTRAN encryption algorithms configurable Allow the user fine-grained control over which UMTS encryption algorithms are permitted, rather than always permitting UEA1 and UEA2 or neither. This brings the handling of UEA in line with the handling of A5 for GERAN. Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Closes: OS#4144 Depends: osmo-iuh.git I6d2d033b0427bdc84fee61e0f3cb7b29935214bf --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/ran_msg.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c M src/libmsc/msc_net_init.c M src/libmsc/msc_vty.c M src/libmsc/ran_msg_iu.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/test_nodes.vty 9 files changed, 38 insertions(+), 64 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/22766/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 15:51:53 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 4 Nov 2021 15:51:53 +0000 Subject: Change in osmo-msc[master]: utran: use new UTRAN encryption enum References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26107 ) Change subject: utran: use new UTRAN encryption enum ...................................................................... utran: use new UTRAN encryption enum Depends: libosmocore.git I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa --- M src/libmsc/gsm_04_08.c M src/libmsc/msc_net_init.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_tests.h 4 files changed, 12 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/07/26107/1 diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index fc1b2e2..f34b7b6 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -51,6 +51,7 @@ #include #include #include +#include #include #include @@ -414,7 +415,7 @@ net->vlr, msc_a, vlr_lu_type, tmsi, imsi, &old_lai, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, lu->key_seq, osmo_gsm48_classmark1_is_r99(&lu->classmark1), is_utran, @@ -805,7 +806,7 @@ req->cm_service_type, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -931,7 +932,7 @@ VLR_PR_ARQ_T_CM_RE_ESTABLISH_REQ, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -1293,7 +1294,7 @@ net->vlr, msc_a, VLR_PR_ARQ_T_PAGING_RESP, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, pr->key_seq, osmo_gsm48_classmark2_is_r99(cm2, classmark2_len), is_utran); diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index d53156b..93dbfe6 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -30,6 +30,7 @@ #include #include #include +#include /* TODO: would be great to have all timer declarations in one place */ #include @@ -68,7 +69,7 @@ /* Permit a compile-time default of A5/3 and A5/1 */ net->a5_encryption_mask = (1 << 3) | (1 << 1); /* Permit a compile-time default of UEA2 and UEA1 */ - net->uea_encryption_mask = (1 << 2) | (1 << 1); + net->uea_encryption_mask = (1 << UTRAN_UEA2) | (1 << UTRAN_UEA1); net->mncc_guard_timeout = 180; net->ncss_guard_timeout = 30; diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index 655183b..0b3bc31 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -333,7 +333,7 @@ static void test_umts_authen_utran() { comment_start(); - net->uea_encryption_mask = 0x01; + net->uea_encryption_mask = (1 << UTRAN_UEA0); _test_umts_authen(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -341,7 +341,7 @@ static void test_umts_auth_ciph_utran() { comment_start(); - net->uea_encryption_mask = 0x06; + net->uea_encryption_mask = (1 << UTRAN_UEA1 | 1 << UTRAN_UEA2); _test_umts_authen(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -588,7 +588,7 @@ static void test_umts_authen_resync_utran() { comment_start(); - net->uea_encryption_mask = 0x01; + net->uea_encryption_mask = (1 << UTRAN_UEA0); _test_umts_authen_resync(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -596,7 +596,7 @@ static void test_umts_auth_ciph_resync_utran() { comment_start(); - net->uea_encryption_mask = 0x06; + net->uea_encryption_mask = (1 << UTRAN_UEA1 | 1 << UTRAN_UEA2); _test_umts_authen_resync(OSMO_RAT_UTRAN_IU); comment_end(); } diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index a2b2f22..1f83013 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -26,6 +26,7 @@ #include #include +#include #include #include #include -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa Gerrit-Change-Number: 26107 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 15:51:54 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 4 Nov 2021 15:51:54 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require encryption into own inline function References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require encryption into own inline function ...................................................................... libmsc/gsm_04_08: refactor require encryption into own inline function Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 --- M include/osmocom/msc/gsm_data.h M src/libmsc/gsm_04_08.c M tests/msc_vlr/msc_vlr_test_umts_authen.c 3 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/08/26108/1 diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 710fd86..1a21b8e 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -13,6 +13,7 @@ #include #include #include +#include #include @@ -261,6 +262,13 @@ char *sms_db_file_path; }; +static inline bool net_require_encryption(struct gsm_network *net, bool is_utran) { + if (is_utran) + return net->uea_encryption_mask > (1 << UTRAN_UEA0); + else + return net->a5_encryption_mask > 0x1; +} + struct osmo_esme; enum gsm_sms_source_id { diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index f34b7b6..ec92b06 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -415,7 +415,7 @@ net->vlr, msc_a, vlr_lu_type, tmsi, imsi, &old_lai, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + net_require_encryption(net, is_utran), lu->key_seq, osmo_gsm48_classmark1_is_r99(&lu->classmark1), is_utran, @@ -806,7 +806,7 @@ req->cm_service_type, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + net_require_encryption(net, is_utran), req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -932,7 +932,7 @@ VLR_PR_ARQ_T_CM_RE_ESTABLISH_REQ, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + net_require_encryption(net, is_utran), req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -1294,7 +1294,7 @@ net->vlr, msc_a, VLR_PR_ARQ_T_PAGING_RESP, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + net_require_encryption(net, is_utran), pr->key_seq, osmo_gsm48_classmark2_is_r99(cm2, classmark2_len), is_utran); diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index 0b3bc31..9b4af9f 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -49,8 +49,7 @@ "5079da1e1ee7416937485e9ea7c965373d1d6683c270383b3d0e" "d3d36ff71c949e83c22072799e9687c5ec32a81d96afcbf4b4fb" "0c7ac3e9e9b7db05"; - bool encryption = (via_ran == OSMO_RAT_GERAN_A && net->a5_encryption_mask > 0x1) - || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption_mask > 0x1); + bool encryption = net_require_encryption(net, via_ran == OSMO_RAT_UTRAN_IU); net->authentication_required = true; net->vlr->cfg.assign_tmsi = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:02:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 16:02:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: remove misleading PADDING attributes References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 ) Change subject: library/GSM_RR_Types: remove misleading PADDING attributes ...................................................................... library/GSM_RR_Types: remove misleading PADDING attributes Unfortunately, TITAN has a weird (and often unusable) model of defining padding in records. According to its reference guide, padding length is counted from the beginning of the message. So if the 'MeasurementResults' is a part of another record, and there are other fields preceeding it, the encoded representation of the 'MeasurementResults' may still be shorter than 16 octets. Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 --- M library/GSM_RR_Types.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/26109/1 diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index f7b00e1..f45784c 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -650,8 +650,7 @@ NcellReports ncell_reports optional } with { variant (no_ncell_m) "LENGTHTO(ncell_reports)" variant (no_ncell_m) "UNIT(elements)" - variant "PADDING(yes)" - variant "FIELDLENGTH(16)" + /* FIXME: pad to 16 octets */ }; type record NcellReport { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 Gerrit-Change-Number: 26109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:02:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 16:02:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP ...................................................................... library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP Change-Id: I198cbfd176e41c55f67d625d9587ba5b6062f0c4 Related: SYS#5114 --- M library/RSL_Types.ttcn 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/26110/1 diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index aa206a3..3ac40ce 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -220,6 +220,7 @@ RSL_IE_TFO_STATUS ('00111011'B), RSL_IE_LLP_APDU ('00111100'B), + RSL_IE_OSMO_REP_ACCH_CAP ('01100000'B), RSL_IE_OSMO_TRAINING_SEQUENCE ('01100001'B), /* ip.access */ @@ -873,6 +874,16 @@ uint8_t tsc } with { variant (len) "LENGTHTO(tsc_set,tsc)" } + type record RSL_IE_OSMO_RepAcchCap { + uint8_t len, + BIT1 rfu ('0'B), + uint3_t rxqual, + boolean ul_sacch, + boolean dl_sacch, + boolean dl_facch_all, + boolean dl_facch_cmd + } with { variant (len) "LENGTHTO(rfu,rxqual,ul_sacch,dl_sacch,dl_facch_all,dl_facch_cmd)" } + /* union of all IE bodies */ type union RSL_IE_Body { RslChannelNr chan_nr, @@ -927,6 +938,7 @@ RSL_IE_IPA_SpeechMode ipa_speech_mode, RSL_IE_OSMO_TrainingSequence osmo_training_sequence, + RSL_IE_OSMO_RepAcchCap rep_acch_cap, RSL_LV other } @@ -989,6 +1001,7 @@ ipa_speech_mode, iei = RSL_IE_IPAC_SPEECH_MODE; osmo_training_sequence, iei = RSL_IE_OSMO_TRAINING_SEQUENCE; + rep_acch_cap, iei = RSL_IE_OSMO_REP_ACCH_CAP; other, OTHERWISE; )" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I198cbfd176e41c55f67d625d9587ba5b6062f0c4 Gerrit-Change-Number: 26110 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:02:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 16:02:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP ...................................................................... library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP Change-Id: I3bd491fba5b72f0fdd262992a97895f037be69d8 Related: SYS#5319 --- M library/RSL_Types.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/26111/1 diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 3ac40ce..1f602b9 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -222,6 +222,7 @@ RSL_IE_OSMO_REP_ACCH_CAP ('01100000'B), RSL_IE_OSMO_TRAINING_SEQUENCE ('01100001'B), + RSL_IE_OSMO_TOP_ACCH_CAP ('01100010'B), /* ip.access */ RSL_IE_IPAC_SRTP_CONFIG ('11100000'B), @@ -884,6 +885,14 @@ boolean dl_facch_cmd } with { variant (len) "LENGTHTO(rfu,rxqual,ul_sacch,dl_sacch,dl_facch_all,dl_facch_cmd)" } + type record RSL_IE_OSMO_TopAcchCap { + uint8_t len, + boolean sacch_enable, + boolean facch_enable, + uint3_t rxqual, + uint3_t overpower_db + } with { variant (len) "LENGTHTO(sacch_enable,facch_enable,rxqual,overpower_db)" } + /* union of all IE bodies */ type union RSL_IE_Body { RslChannelNr chan_nr, @@ -939,6 +948,7 @@ RSL_IE_OSMO_TrainingSequence osmo_training_sequence, RSL_IE_OSMO_RepAcchCap rep_acch_cap, + RSL_IE_OSMO_TopAcchCap top_acch_cap, RSL_LV other } @@ -1002,6 +1012,7 @@ osmo_training_sequence, iei = RSL_IE_OSMO_TRAINING_SEQUENCE; rep_acch_cap, iei = RSL_IE_OSMO_REP_ACCH_CAP; + top_acch_cap, iei = RSL_IE_OSMO_TOP_ACCH_CAP; other, OTHERWISE; )" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3bd491fba5b72f0fdd262992a97895f037be69d8 Gerrit-Change-Number: 26111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:23:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 16:23:09 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3bd491fba5b72f0fdd262992a97895f037be69d8 Gerrit-Change-Number: 26111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 16:23:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:23:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 16:23:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: remove misleading PADDING attributes In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 ) Change subject: library/GSM_RR_Types: remove misleading PADDING attributes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 Gerrit-Change-Number: 26109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 16:23:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:23:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 16:23:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I198cbfd176e41c55f67d625d9587ba5b6062f0c4 Gerrit-Change-Number: 26110 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 16:23:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:24:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 16:24:03 +0000 Subject: Change in osmo-pcu[master]: bts: Fix misleading log line in bts_rcv_rach() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26060 ) Change subject: bts: Fix misleading log line in bts_rcv_rach() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 Gerrit-Change-Number: 26060 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 16:24:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:24:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 16:24:09 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 16:24:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:24:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 16:24:19 +0000 Subject: Change in osmo-pcu[master]: bts: Fix misleading log line in bts_rcv_rach() In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26060 ) Change subject: bts: Fix misleading log line in bts_rcv_rach() ...................................................................... bts: Fix misleading log line in bts_rcv_rach() If it's not single block packets access, then it's one phase packet access. TS 44.018 Table 9.1.8.1: """ One phase packet access with request for single timeslot uplink transmission; one PDCH is needed. """ Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 --- M src/bts.cpp 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/bts.cpp b/src/bts.cpp index 50df92e..bd1366e 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -900,8 +900,8 @@ if (chan_req.single_block) LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation\n"); else if (bts->pcu->vty.force_two_phase) { - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation, " - "but we force two phase access\n"); + LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single TS uplink transmission " + "(one phase packet access), but we force two phase access\n"); chan_req.single_block = true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 Gerrit-Change-Number: 26060 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:24:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 16:24:20 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used ...................................................................... tbf_ul: Document context where tbf_alloc_ul_ccch() is used It can be seen that this function properly passes single=true to tbf_alloc_ul_tbf(). Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 --- M src/tbf_ul.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 74b2636..d6936e1 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -168,7 +168,8 @@ return tbf; } -/* Alloc a UL TBF to be assigned over CCCH */ +/* Alloc a UL TBF to be assigned over CCCH. Used by request of a "One phase + * packet access", where MS requested only 1 PDCH TS (TS 44.018 Table 9.1.8.1). */ struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_ccch(struct gprs_rlcmac_bts *bts, struct GprsMs *ms) { struct gprs_rlcmac_ul_tbf *tbf; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:55:18 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 16:55:18 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26055 to look at the new patch set (#4). Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... commands: do not check SW manually, use send_apdu_checksw() The transport layer provides a method send_apdu_checksw to send APDUs and to be sure the SW is the expected one. Given that, there is no need to verify the SW manually. The exception of send_apdu_checksw will catch the problem and also display the SW in a human readable form. Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Related: OS#5275 --- M pySim/commands.py 1 file changed, 16 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/26055/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:55:18 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 16:55:18 +0000 Subject: Change in pysim[master]: commands: complete documentation strings References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26112 ) Change subject: commands: complete documentation strings ...................................................................... commands: complete documentation strings Some of the methods lack an explaination of the arguments. Lets add that to be complete Change-Id: Icda245e2fd5ef4556c7736d73574dfbb48168973 --- M pySim/commands.py 1 file changed, 107 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/26112/1 diff --git a/pySim/commands.py b/pySim/commands.py index 8d0dc00..bc51bc7 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -91,7 +91,12 @@ return self._tp.get_atr() def try_select_path(self, dir_list): - """ Try to select a specified path given as list of hex-string FIDs""" + """ Try to select a specified path + + Args: + dir_list : list of hex-string FIDs + """ + rv = [] if type(dir_list) is not list: dir_list = [dir_list] @@ -120,11 +125,21 @@ return rv def select_file(self, fid:str): - """Execute SELECT a given file by FID.""" + """Execute SELECT a given file by FID. + + Args: + fid : file identifier as hex string + """ + return self._tp.send_apdu_checksw(self.cla_byte + "a4" + self.sel_ctrl + "02" + fid) def select_adf(self, aid:str): - """Execute SELECT a given Applicaiton ADF.""" + """Execute SELECT a given Applicaiton ADF. + + Args: + aid : application identifier as hex string + """ + aidlen = ("0" + format(len(aid) // 2, 'x'))[-2:] return self._tp.send_apdu_checksw(self.cla_byte + "a4" + "0404" + aidlen + aid) @@ -216,6 +231,16 @@ def update_record(self, ef, rec_no:int, data:str, force_len:bool=False, verify:bool=False, conserve:bool=False): + """Execute UPDATE RECORD. + + Args: + ef : string or list of strings indicating name or path of linear fixed EF + rec_no : record number to read + data : hex string of data to be written + force_len : enforce record length by using the actual data length + verify : verify data by re-reading the record + conserve : read record and compare it with data, skip write on match + """ res = self.select_path(ef) if force_len: @@ -245,6 +270,13 @@ return res def verify_record(self, ef, rec_no:int, data:str): + """Verify record against given data + + Args: + ef : string or list of strings indicating name or path of linear fixed EF + rec_no : record number to read + data : hex string of data to be verified + """ res = self.read_record(ef, rec_no) if res[0].lower() != data.lower(): raise ValueError('Record verification failed (expected %s, got %s)' % (data.lower(), res[0].lower())) @@ -346,14 +378,24 @@ return rdata, sw def run_gsm(self, rand:str): - """Execute RUN GSM ALGORITHM.""" + """Execute RUN GSM ALGORITHM. + + Args: + rand : 16 byte random data as hex string (RAND) + """ if len(rand) != 32: raise ValueError('Invalid rand') self.select_path(['3f00', '7f20']) return self._tp.send_apdu(self.cla_byte + '88000010' + rand) def authenticate(self, rand:str, autn:str, context='3g'): - """Execute AUTHENTICATE (USIM/ISIM).""" + """Execute AUTHENTICATE (USIM/ISIM). + + Args: + rand : 16 byte random data as hex string (RAND) + autn : 8 byte Autentication Token (AUTN) + context : 16 byte random data ('3g' or 'gsm') + """ # 3GPP TS 31.102 Section 7.1.2.1 AuthCmd3G = Struct('rand'/LV, 'autn'/Optional(LV)) AuthResp3GSyncFail = Struct(Const(b'\xDC'), 'auts'/LV) @@ -381,11 +423,20 @@ return self._tp.send_apdu_constr_checksw(self.cla_byte, '04', '00', '00', None, None, None) def activate_file(self, fid): - """Execute ACTIVATE FILE command as per TS 102 221 Section 11.1.15.""" + """Execute ACTIVATE FILE command as per TS 102 221 Section 11.1.15. + + Args: + fid : file identifier as hex string + """ return self._tp.send_apdu_checksw(self.cla_byte + '44000002' + fid) def manage_channel(self, mode='open', lchan_nr=0): - """Execute MANAGE CHANNEL command as per TS 102 221 Section 11.1.17.""" + """Execute MANAGE CHANNEL command as per TS 102 221 Section 11.1.17. + + Args: + mode : logical channel operation code ('open' or 'close') + lchan_nr : logical channel number (1-19, 0=assigned by UICC) + """ if mode == 'close': p1 = 0x80 else: @@ -405,53 +456,94 @@ raise SwMatchError(sw, '9000') def verify_chv(self, chv_no:int, code:str): - """Verify a given CHV (Card Holder Verification == PIN)""" + """Verify a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + code : chv code as hex string + """ fc = rpad(b2h(code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2000' + ('%02X' % chv_no) + '08' + fc) self._chv_process_sw('verify', chv_no, code, sw) return (data, sw) def unblock_chv(self, chv_no:int, puk_code:str, pin_code:str): - """Unblock a given CHV (Card Holder Verification == PIN)""" + """Unblock a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + puk_code : puk code as hex string + pin_code : new chv code as hex string + """ fc = rpad(b2h(puk_code), 16) + rpad(b2h(pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2C00' + ('%02X' % chv_no) + '10' + fc) self._chv_process_sw('unblock', chv_no, pin_code, sw) return (data, sw) def change_chv(self, chv_no:int, pin_code:str, new_pin_code:str): - """Change a given CHV (Card Holder Verification == PIN)""" + """Change a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + pin_code : current chv code as hex string + new_pin_code : new chv code as hex string + """ fc = rpad(b2h(pin_code), 16) + rpad(b2h(new_pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2400' + ('%02X' % chv_no) + '10' + fc) self._chv_process_sw('change', chv_no, pin_code, sw) return (data, sw) def disable_chv(self, chv_no:int, pin_code:str): - """Disable a given CHV (Card Holder Verification == PIN)""" + """Disable a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + pin_code : current chv code as hex string + new_pin_code : new chv code as hex string + """ fc = rpad(b2h(pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2600' + ('%02X' % chv_no) + '08' + fc) self._chv_process_sw('disable', chv_no, pin_code, sw) return (data, sw) def enable_chv(self, chv_no:int, pin_code:str): - """Enable a given CHV (Card Holder Verification == PIN)""" + """Enable a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + pin_code : chv code as hex string + """ fc = rpad(b2h(pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2800' + ('%02X' % chv_no) + '08' + fc) self._chv_process_sw('enable', chv_no, pin_code, sw) return (data, sw) def envelope(self, payload:str): - """Send one ENVELOPE command to the SIM""" + """Send one ENVELOPE command to the SIM + + Args: + payload : payload as hex string + """ return self._tp.send_apdu_checksw('80c20000%02x%s' % (len(payload)//2, payload)) def terminal_profile(self, payload:str): - """Send TERMINAL PROFILE to card""" + """Send TERMINAL PROFILE to card + + Args: + payload : payload as hex string + """ data_length = len(payload) // 2 data, sw = self._tp.send_apdu(('80100000%02x' % data_length) + payload) return (data, sw) # ETSI TS 102 221 11.1.22 def suspend_uicc(self, min_len_secs:int=60, max_len_secs:int=43200): - """Send SUSPEND UICC to the card.""" + """Send SUSPEND UICC to the card. + + Args: + min_len_secs : mimumum suspend time seconds + max_len_secs : maximum suspend time seconds + """ def encode_duration(secs:int) -> Hexstr: if secs >= 10*24*60*60: return '04%02x' % (secs // (10*24*60*60)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icda245e2fd5ef4556c7736d73574dfbb48168973 Gerrit-Change-Number: 26112 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 16:56:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 4 Nov 2021 16:56:36 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py at 148 PS2, Line 148: data, sw = self._tp.send_apdu_checksw(pdu) > side note: I think if the export command relies on no CR/LF in an exception text, then it should its [?] Are multi line exception strings even possible? I don't know, I have never seen any. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 16:56:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 17:40:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 17:40:03 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: ping 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 17:40:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 20:12:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 20:12:48 +0000 Subject: Change in osmo-bts[master]: gsm_ts_release(): Make sure pchan{, is_want} is reset to NONE References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26113 ) Change subject: gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE ...................................................................... gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE Let's make sure all ts->pchan* related data is reset when we release the TS. This is important for pchan_is, since in bts-trx upon shutdown finish the PDCH lchan of a osmo dyn TS is set to lchan->state=LCHAN_S_NONE, and as a result when the PCU tries to release it by means of PCUIF act_req later, it may be ignored since the lchan is already in erased state. Related: SYS#4971 Change-Id: Ic7c34c0de23101ce094ffd03e00b4d2f6a551152 --- M src/common/gsm_data.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/26113/1 diff --git a/src/common/gsm_data.c b/src/common/gsm_data.c index 4446958..e5dbf10 100644 --- a/src/common/gsm_data.c +++ b/src/common/gsm_data.c @@ -314,4 +314,8 @@ struct gsm_lchan *lchan = &ts->lchan[ln]; gsm_lchan_release(lchan, LCHAN_REL_ACT_OML); } + ts->pchan = GSM_PCHAN_NONE; + /* Make sure pchan_is is reset, since PCU act_req to release it will be + * ignored as the lchan will already be released. */ + ts->dyn.pchan_is = ts->dyn.pchan_want = GSM_PCHAN_NONE; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic7c34c0de23101ce094ffd03e00b4d2f6a551152 Gerrit-Change-Number: 26113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 20:17:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 20:17:28 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 20:17:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 20:18:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 20:18:10 +0000 Subject: Change in osmo-msc[master]: utran: use new UTRAN encryption enum In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26107 ) Change subject: utran: use new UTRAN encryption enum ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa Gerrit-Change-Number: 26107 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 20:18:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 20:20:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 20:20:32 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require encryption into own inline function In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require encryption into own inline function ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26108/1/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/26108/1/src/libmsc/gsm_04_08.c at 1297 PS1, Line 1297: net_require_encryption(net, is_utran), net = msc_a_net(msc_a); is_utran = (msc_a->c.ran->type == OSMO_RAT_UTRAN_IU); Hence, you can rework this function to be msc_a_require_encryption(msc_a), there's only need to pass 1 param. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 20:20:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 20:44:56 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 20:44:56 +0000 Subject: Change in osmo-bts[master]: gsm_ts_release(): Make sure pchan{, is_want} is reset to NONE In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26113 ) Change subject: gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic7c34c0de23101ce094ffd03e00b4d2f6a551152 Gerrit-Change-Number: 26113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 20:44:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 4 20:58:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:58:46 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184499a34e3c_26f62ae79e4a05f06177b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/Debian_Testing/x86_64 Package network:osmocom:nightly/libasn1c failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 6s] [10/12] preinstalling mount... [ 6s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.812611] sysrq: Changing Loglevel [ 13s] .3.18-59.24-defa[ 4.813178] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.835127] sysrq: Power Off [ 16s] [ 7.838330] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat01 failed "build libasn1c_0.9.33.202111040908.dsc" at Thu Nov 4 20:58:41 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:58:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:58:46 +0000 Subject: Build failure of network:osmocom:latest/libosmo-dsp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184499aa500d_26f62ae79e4a05f06179e0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-dsp/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-dsp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-dsp Last lines of build log: [ 8s] [10/12] preinstalling mount... [ 8s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 11s] reordering...cycle: libc6 -> libgcc-s1 [ 11s] breaking dependency libgcc-s1 -> libc6 [ 11s] done [ 11s] booting kvm... [ 11s] ### VM INTERACTION START ### [ 11s] Using UART console [ 11s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 11s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5[ 5.113834] sysrq: Changing Loglevel [ 17s] .3.18-59.24-defa[ 5.115498] sysrq: Loglevel set to 4 [ 17s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] /.build/build-vm: line 632: mkswap: command not found [ 17s] swapon: /dev/vdb: read swap header failed [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.153534] sysrq: Power Off [ 20s] [ 8.157429] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] sheep88 failed "build libosmodsp_0.4.0.dsc" at Thu Nov 4 20:58:45 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:03 +0000 Subject: Build failure of network:osmocom:latest/libasn1c in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184499c6a0e_26f62ae79e4a05f06182db@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/Debian_Testing/x86_64 Package network:osmocom:latest/libasn1c failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libasn1c Last lines of build log: [ 19s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 20s] [12/12] preinstalling binutils... [ 20s] copying packages... [ 24s] reordering...cycle: libc6 -> libgcc-s1 [ 24s] breaking dependency libgcc-s1 -> libc6 [ 24s] done [ 25s] booting kvm... [ 25s] ### VM INTERACTION START ### [ 25s] Using UART console [ 25s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 26s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 26s] Booting from ROM... [ 33s] c[?7l### VM INTERACTION END ### [ 33s] 2nd stage started in virtual machine [ 33s] machine type: x86_64 [ 33s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 33s] Increasing log level from now on... [ 33s] [ 6.516638] sysrq: Changing Loglevel [ 33s] [ 6.517373] sysrq: Loglevel set to 4 [ 33s] Enable sysrq operations [ 33s] /.build/build-vm: line 632: mkswap: command not found [ 33s] swapon: /dev/vdb: read swap header failed [ 33s] ### VM INTERACTION START ### [ 36s] [ 9.590842] sysrq: Power Off [ 36s] [ 9.593689] reboot: Power down [ 36s] ### VM INTERACTION END ### [ 36s] [ 36s] build85 failed "build libasn1c_0.9.33.dsc" at Thu Nov 4 20:58:58 UTC 2021. [ 36s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:58:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:58:46 +0000 Subject: Build failure of network:osmocom:latest/neocon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184499a6b33b_26f62ae79e4a05f061781b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/neocon/Debian_Testing/x86_64 Package network:osmocom:latest/neocon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest neocon Last lines of build log: [ 8s] [10/12] preinstalling mount... [ 8s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 10s] reordering...cycle: libc6 -> libgcc-s1 [ 10s] breaking dependency libgcc-s1 -> libc6 [ 10s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 11s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5.3.18-59.24-defa[ 5.560795] sysrq: Changing Loglevel [ 17s] ult #1 SMP Mon S[ 5.561541] sysrq: Loglevel set to 4 [ 17s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] /.build/build-vm: line 632: mkswap: command not found [ 17s] swapon: /dev/vdb: read swap header failed [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.587749] sysrq: Power Off [ 20s] [ 8.590015] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] hci-cnode2-m0 failed "build neocon_1.0.1.dsc" at Thu Nov 4 20:58:43 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:03 +0000 Subject: Build failure of network:osmocom:latest/libsmpp34 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184499ba7ec9_26f62ae79e4a05f06181a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsmpp34/Debian_Testing/x86_64 Package network:osmocom:latest/libsmpp34 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libsmpp34 Last lines of build log: [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM... [ 19s] c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.462834] sysrq: Changing Loglevel [ 19s] [ 5.464444] sysrq: Loglevel set to 4 [ 19s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.510420] sysrq: Power Off [ 22s] [ 8.514523] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] cloud108 failed "build libsmpp34_1.14.1.dsc" at Thu Nov 4 20:58:55 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:03 +0000 Subject: Build failure of network:osmocom:nightly/osmo-fl2k in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184499b4fd19_26f62ae79e4a05f0618075@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-fl2k failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: [ 6s] [10/12] preinstalling mount... [ 6s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.24-defa[ 4.792370] sysrq: Changing Loglevel [ 13s] ult #1 SMP Mon S[ 4.792941] sysrq: Loglevel set to 4 [ 13s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.820711] sysrq: Power Off [ 16s] [ 7.823566] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat03 failed "build osmo-fl2k_0.1.1.28.197f.202111040908.dsc" at Thu Nov 4 20:58:46 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:03 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184499c3ed53_26f62ae79e4a05f061832d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/Debian_Testing/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM... [ 27s] c[?7l### VM INTERACTION END ### [ 27s] 2nd stage started in virtual machine [ 27s] machine type: x86_64 [ 27s] Linux version: 5.3.18-59.24-defa[ 5.589515] sysrq: Changing Loglevel [ 27s] ult #1 SMP Mon Sep 13 15:06:42 U[ 5.591030] sysrq: Loglevel set to 4 [ 27s] TC 2021 (2f872ea) [ 27s] Increasing log level from now on... [ 27s] Enable sysrq operations [ 27s] /.build/build-vm: line 632: mkswap: command not found [ 27s] swapon: /dev/vdb: read swap header failed [ 27s] ### VM INTERACTION START ### [ 30s] [ 8.636439] sysrq: Power Off [ 30s] [ 8.640354] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] cloud121 failed "build osmocom-nightly_1.0.0.202111040908.dsc" at Thu Nov 4 20:58:59 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:20 +0000 Subject: Build failure of network:osmocom:nightly/rtl-sdr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449b58fbbf_26f62ae79e4a05f061842@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Debian_Testing/x86_64 Package network:osmocom:nightly/rtl-sdr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: [ 14s] [10/12] preinstalling mount... [ 14s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 15s] [12/12] preinstalling binutils... [ 15s] copying packages... [ 21s] reordering...cycle: libc6 -> libgcc-s1 [ 21s] breaking dependency libgcc-s1 -> libc6 [ 21s] done [ 21s] booting kvm... [ 21s] ### VM INTERACTION START ### [ 21s] Using UART console [ 21s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 22s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 31s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: x86_64 [ 31s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 31s] Increasing log l[ 9.412125] sysrq: Changing Loglevel [ 31s] evel from now on[ 9.413205] sysrq: Loglevel set to 4 [ 31s] ... [ 31s] Enable sysrq operations [ 31s] /.build/build-vm: line 632: mkswap: command not found [ 31s] swapon: /dev/vdb: read swap header failed [ 31s] ### VM INTERACTION START ### [ 34s] [ 12.509391] sysrq: Power Off [ 34s] [ 12.536935] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] lamb56 failed "build rtl-sdr_0.5.4.42.d770.202111040908.dsc" at Thu Nov 4 20:59:18 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:20 +0000 Subject: Build failure of network:osmocom:latest/libgtpnl in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449b5bbd34_26f62ae79e4a05f0618595@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libgtpnl/Debian_Testing/x86_64 Package network:osmocom:latest/libgtpnl failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libgtpnl Last lines of build log: [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 26s] reordering...cycle: libc6 -> libgcc-s1 [ 26s] breaking dependency libgcc-s1 -> libc6 [ 26s] done [ 26s] booting kvm... [ 26s] ### VM INTERACTION START ### [ 26s] Using UART console [ 26s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 28s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 29s] Booting from ROM... [ 35s] c[?7l### VM INTERACTION END ### [ 35s] 2nd stage started in virtual machine [ 35s] machine type: x86_64 [ 35s] Linux version: 5.3.18-59.24-default #1 SMP Mon S[ 5.624115] sysrq: Changing Loglevel [ 35s] [ 5.625883] sysrq: Loglevel set to 4 [ 35s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 35s] Increasing log level from now on... [ 35s] Enable sysrq operations [ 35s] /.build/build-vm: line 632: mkswap: command not found [ 35s] swapon: /dev/vdb: read swap header failed [ 35s] ### VM INTERACTION START ### [ 38s] [ 8.680087] sysrq: Power Off [ 38s] [ 8.694814] reboot: Power down [ 38s] ### VM INTERACTION END ### [ 38s] [ 38s] cloud127 failed "build libgtpnl_1.2.2.dsc" at Thu Nov 4 20:59:03 UTC 2021. [ 38s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:20 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449b5e7ea5_26f62ae79e4a05f06186b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_Testing/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 15s] [10/12] preinstalling mount... [ 15s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 15s] [12/12] preinstalling binutils... [ 15s] copying packages... [ 18s] reordering...cycle: libc6 -> libgcc-s1 [ 18s] breaking dependency libgcc-s1 -> libc6 [ 18s] done [ 19s] booting kvm... [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 19s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 29s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 29s] 2nd stage started in virtual machine [ 29s] machine type: x86_64 [ 29s] Linux version: 5[ 9.097139] sysrq: Changing Loglevel [ 29s] [ 9.097953] sysrq: Loglevel set to 4 [ 29s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 29s] Increasing log level from now on... [ 29s] Enable sysrq operations [ 29s] /.build/build-vm: line 632: mkswap: command not found [ 29s] swapon: /dev/vdb: read swap header failed [ 29s] ### VM INTERACTION START ### [ 32s] [ 12.157997] sysrq: Power Off [ 32s] [ 12.170346] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] lamb14 failed "build libgtpnl_1.2.2.202111040908.dsc" at Thu Nov 4 20:59:04 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:20 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449b64f071_26f62ae79e4a05f06187c0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 11s] [10/12] preinstalling mount... [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 12s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] [ 8.638182] sysrq: Changing Loglevel [ 25s] [ 8.639070] sysrq: Loglevel set to 4 [ 25s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 25s] Increasing log level from now on... [ 25s] Enable sysrq operations [ 25s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 11.725732] sysrq: Power Off [ 28s] [ 11.740790] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb59 failed "build osmo-python-tests_0.0.9.202111040908.dsc" at Thu Nov 4 20:59:08 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:20 +0000 Subject: Build failure of network:osmocom:latest/osmocom-latest in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449b6a8f04_26f62ae79e4a05f0618976@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmocom-latest/Debian_Testing/x86_64 Package network:osmocom:latest/osmocom-latest failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmocom-latest Last lines of build log: [ 17s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 17s] [12/12] preinstalling binutils... [ 18s] copying packages... [ 22s] reordering...cycle: libc6 -> libgcc-s1 [ 22s] breaking dependency libgcc-s1 -> libc6 [ 22s] done [ 26s] booting kvm... [ 26s] ### VM INTERACTION START ### [ 26s] Using UART console [ 26s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 27s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 28s] Booting from ROM... [ 37s] c[?7l### VM INTERACTION END ### [ 37s] 2nd stage started in virtual machine [ 37s] machine type: x86_64 [ 37s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 37s] Increasing log level from now on... [ 37s] [ 8.276612] sysrq: Changing Loglevel [ 37s] [ 8.278594] sysrq: Loglevel set to 4 [ 37s] Enable sysrq operations [ 37s] /.build/build-vm: line 632: mkswap: command not found [ 37s] swapon: /dev/vdb: read swap header failed [ 37s] ### VM INTERACTION START ### [ 41s] [ 11.394800] sysrq: Power Off [ 41s] [ 11.404187] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] cloud126 failed "build osmocom-latest_1.0.0.dsc" at Thu Nov 4 20:59:10 UTC 2021. [ 41s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:54 +0000 Subject: Build failure of network:osmocom:latest/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449d5bb4bf_26f62ae79e4a05f0619020@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_Testing/x86_64 Package network:osmocom:latest/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: [ 8s] [10/12] preinstalling mount... [ 8s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 8s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 11s] reordering...cycle: libc6 -> libgcc-s1 [ 11s] breaking dependency libgcc-s1 -> libc6 [ 11s] done [ 11s] booting kvm... [ 11s] ### VM INTERACTION START ### [ 11s] Using UART console [ 11s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_13/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_13/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_13/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 11s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5[ 5.053474] sysrq: Changing Loglevel [ 17s] .3.18-59.24-defa[ 5.054926] sysrq: Loglevel set to 4 [ 17s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] /.build/build-vm: line 632: mkswap: command not found [ 17s] swapon: /dev/vdb: read swap header failed [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.092572] sysrq: Power Off [ 20s] [ 8.095573] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] sheep85 failed "build libosmocore_1.5.2.dsc" at Thu Nov 4 20:59:43 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:54 +0000 Subject: Build failure of network:osmocom:nightly/orcania in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449d6422ea_26f62ae79e4a05f061913b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/Debian_Testing/x86_64 Package network:osmocom:nightly/orcania failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 7s] [10/12] preinstalling mount... [ 7s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 7s] [12/12] preinstalling binutils... [ 7s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.24-defa[ 4.353483] sysrq: Changing Loglevel [ 13s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] [ 4.356670] sysrq: Loglevel set to 4 [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.383822] sysrq: Power Off [ 16s] [ 7.386188] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] build70 failed "build orcania_1.2.9-5.dsc" at Thu Nov 4 20:59:48 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:54 +0000 Subject: Build failure of network:osmocom:nightly/open5gs in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449d67b032_26f62ae79e4a05f061922d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_Testing/x86_64 Package network:osmocom:nightly/open5gs failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 6s] [10/12] preinstalling mount... [ 6s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.24-defa[ 4.494909] sysrq: Changing Loglevel [ 13s] ult #1 SMP Mon S[ 4.496192] sysrq: Loglevel set to 4 [ 13s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.515642] sysrq: Power Off [ 16s] [ 7.518528] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat13 failed "build open5gs_2.3.6.202111040908.dsc" at Thu Nov 4 20:59:38 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:54 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449d6eaa96_26f62ae79e4a05f06194e2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/Debian_Testing/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 33s] [10/12] preinstalling mount... [ 33s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 34s] [12/12] preinstalling binutils... [ 36s] copying packages... [ 46s] reordering...cycle: libc6 -> libgcc-s1 [ 46s] breaking dependency libgcc-s1 -> libc6 [ 46s] done [ 47s] booting kvm... [ 47s] ### VM INTERACTION START ### [ 47s] Using UART console [ 47s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 48s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 63s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 63s] 2nd stage started in virtual machine [ 64s] [ 12.918276] sysrq: Changing Loglevel [ 64s] [ 12.919664] sysrq: Loglevel set to 4 [ 64s] machine type: x86_64 [ 64s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 64s] Increasing log level from now on... [ 64s] Enable sysrq operations [ 64s] /.build/build-vm: line 632: mkswap: command not found [ 64s] swapon: /dev/vdb: read swap header failed [ 64s] ### VM INTERACTION START ### [ 67s] [ 16.071538] sysrq: Power Off [ 67s] [ 16.126667] reboot: Power down [ 67s] ### VM INTERACTION END ### [ 67s] [ 67s] lamb03 failed "build libsmpp34_1.14.1.202111040908.dsc" at Thu Nov 4 20:59:39 UTC 2021. [ 67s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:54 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-dsp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449d760ddf_26f62ae79e4a05f0619657@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-dsp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: [ 46s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 47s] [12/12] preinstalling binutils... [ 47s] copying packages... [ 58s] reordering...cycle: libc6 -> libgcc-s1 [ 58s] breaking dependency libgcc-s1 -> libc6 [ 58s] done [ 59s] booting kvm... [ 59s] ### VM INTERACTION START ### [ 59s] Using UART console [ 60s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 60s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 60s] Booting from ROM... [ 72s] c[?7l### VM INTERACTION END ### [ 72s] 2nd stage started in virtual machine [ 72s] machine type: x86_64 [ 72s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 72s] Increasing log level from now on... [ 72s] [ 10.968015] sysrq: Changing Loglevel [ 72s] [ 10.968780] sysrq: Loglevel set to 4 [ 72s] Enable sysrq operations [ 72s] /.build/build-vm: line 632: mkswap: command not found [ 72s] swapon: /dev/vdb: read swap header failed [ 72s] ### VM INTERACTION START ### [ 75s] [ 14.165067] sysrq: Power Off [ 75s] [ 14.202090] reboot: Power down [ 75s] ### VM INTERACTION END ### [ 75s] [ 75s] lamb17 failed "build libosmodsp_0.4.0.202111040908.dsc" at Thu Nov 4 20:59:50 UTC 2021. [ 75s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:54 +0000 Subject: Build failure of network:osmocom:latest/limesuite in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449d6aedd1_26f62ae79e4a05f06193f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/limesuite/Debian_Testing/x86_64 Package network:osmocom:latest/limesuite failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest limesuite Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.24-defa[ 5.391571] sysrq: Changing Loglevel [ 21s] ult #1 SMP Mon S[ 5.393026] sysrq: Loglevel set to 4 [ 21s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] /.build/build-vm: line 632: mkswap: command not found [ 21s] swapon: /dev/vdb: read swap header failed [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.452728] sysrq: Power Off [ 24s] [ 8.457558] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] old-cirrus1 failed "build limesuite_20.10.0-1.dsc" at Thu Nov 4 20:59:49 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 20:59:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 20:59:54 +0000 Subject: Build failure of network:osmocom:latest/eclipse-titan in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449d721d35_26f62ae79e4a05f06195fb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/Debian_Testing/x86_64 Package network:osmocom:latest/eclipse-titan failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest eclipse-titan Last lines of build log: [ 12s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: default-jre-headless -> openjdk-11-jre-headless -> ca-certificates-java [ 16s] breaking dependency openjdk-11-jre-headless -> ca-certificates-java [ 16s] done [ 23s] booting kvm... [ 23s] ### VM INTERACTION START ### [ 23s] Using UART console [ 23s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 23s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM... [ 31s] c[?7l### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: x86_64 [ 31s] Linux version: 5.3.18-59.24-defa[ 6.244075] sysrq: Changing Loglevel [ 31s] ult #1 SMP Mon S[ 6.245683] sysrq: Loglevel set to 4 [ 31s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 31s] Increasing log level from now on... [ 31s] Enable sysrq operations [ 31s] /.build/build-vm: line 632: mkswap: command not found [ 31s] swapon: /dev/vdb: read swap header failed [ 31s] ### VM INTERACTION START ### [ 34s] [ 9.296565] sysrq: Power Off [ 34s] [ 9.307982] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] cloud118 failed "build eclipse-titan_8.0.0-1.dsc" at Thu Nov 4 20:59:50 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:00:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:00:11 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449f0e608c_26f62ae79e4a05f06197b8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 12s] [10/12] preinstalling mount... [ 12s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 13s] [12/12] preinstalling binutils... [ 13s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 5.732236] sysrq: Changing Loglevel [ 22s] .3.18-59.24-defa[ 5.733518] sysrq: Loglevel set to 4 [ 22s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.775679] sysrq: Power Off [ 25s] [ 8.780898] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb59 failed "build libosmocore_1.5.1.268.843a.202111040908.dsc" at Thu Nov 4 20:59:56 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:00:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:00:11 +0000 Subject: Build failure of network:osmocom:nightly/neocon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449f132864_26f62ae79e4a05f061985a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/neocon/Debian_Testing/x86_64 Package network:osmocom:nightly/neocon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly neocon Last lines of build log: [ 39s] [10/12] preinstalling mount... [ 40s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 41s] [12/12] preinstalling binutils... [ 42s] copying packages... [ 53s] reordering...cycle: libc6 -> libgcc-s1 [ 53s] breaking dependency libgcc-s1 -> libc6 [ 53s] done [ 54s] booting kvm... [ 54s] ### VM INTERACTION START ### [ 54s] Using UART console [ 54s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 55s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 67s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 67s] 2nd stage started in virtual machine [ 68s] machine type: x86_64 [ 68s] [ 10.697126] sysrq: Changing Loglevel [ 68s] [ 10.697967] sysrq: Loglevel set to 4 [ 68s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 68s] Increasing log level from now on... [ 68s] Enable sysrq operations [ 68s] /.build/build-vm: line 632: mkswap: command not found [ 68s] swapon: /dev/vdb: read swap header failed [ 68s] ### VM INTERACTION START ### [ 71s] [ 13.810892] sysrq: Power Off [ 71s] [ 13.867804] reboot: Power down [ 71s] ### VM INTERACTION END ### [ 71s] [ 71s] lamb60 failed "build neocon_1.0.1.202111040908.dsc" at Thu Nov 4 20:59:57 UTC 2021. [ 71s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:00:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:00:11 +0000 Subject: Build failure of network:osmocom:latest/open5gs in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618449f16b95a_26f62ae79e4a05f0619958@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/open5gs/Debian_Testing/x86_64 Package network:osmocom:latest/open5gs failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest open5gs Last lines of build log: [ 13s] [10/12] preinstalling mount... [ 13s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 13s] [12/12] preinstalling binutils... [ 13s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] [ 6.568981] sysrq: Changing Loglevel [ 25s] [ 6.569829] sysrq: Loglevel set to 4 [ 25s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 25s] Increasing log level from now on... [ 25s] Enable sysrq operations [ 25s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 9.630541] sysrq: Power Off [ 28s] [ 9.650042] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb56 failed "build open5gs_2.3.6.dsc" at Thu Nov 4 20:59:59 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:00:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:00:45 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a111a489_26f62ae79e4a05f062002f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 7s] [10/12] preinstalling mount... [ 7s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 7s] [12/12] preinstalling binutils... [ 7s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 5.045543] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 5.046078] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 8.076271] sysrq: Power Off [ 17s] [ 8.078789] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] goat01 failed "build libosmo-netif_1.1.0.202111040908.dsc" at Thu Nov 4 21:00:35 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:00:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:00:45 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a114c431_26f62ae79e4a05f06201b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-netif failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 19s] [10/12] preinstalling mount... [ 19s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 19s] [12/12] preinstalling binutils... [ 20s] copying packages... [ 24s] reordering...cycle: libc6 -> libgcc-s1 [ 24s] breaking dependency libgcc-s1 -> libc6 [ 24s] done [ 24s] booting kvm... [ 24s] ### VM INTERACTION START ### [ 24s] Using UART console [ 24s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 25s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 30s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 30s] 2nd stage started in virtual machine [ 31s] machine type: x86_64 [ 31s] Linux version: 5.3.18-59.24-defa[ 5.600979] sysrq: Changing Loglevel [ 31s] [ 5.601952] sysrq: Loglevel set to 4 [ 31s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 31s] Increasing log level from now on... [ 31s] Enable sysrq operations [ 31s] /.build/build-vm: line 632: mkswap: command not found [ 31s] swapon: /dev/vdb: read swap header failed [ 31s] ### VM INTERACTION START ### [ 34s] [ 8.658023] sysrq: Power Off [ 34s] [ 8.661202] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] build74 failed "build libosmo-netif_1.1.0.dsc" at Thu Nov 4 21:00:35 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:00:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:00:45 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a1239a85_26f62ae79e4a05f0620264@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-abis failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 11s] [10/12] preinstalling mount... [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 12s] [12/12] preinstalling binutils... [ 12s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 6.556201] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 6.557318] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 9.642802] sysrq: Power Off [ 26s] [ 9.669661] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb56 failed "build libosmo-abis_1.1.1.dsc" at Thu Nov 4 21:00:29 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:00:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:00:45 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-abis in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a1296528_26f62ae79e4a05f062032d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: [ 5s] [10/12] preinstalling mount... [ 5s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 7s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5[ 4.654647] sysrq: Changing Loglevel [ 12s] .3.18-59.24-defa[ 4.655618] sysrq: Loglevel set to 4 [ 12s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.680542] sysrq: Power Off [ 15s] [ 7.683295] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat17 failed "build libosmo-abis_1.1.1.14.57ff.202111040908.dsc" at Thu Nov 4 21:00:32 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:02 +0000 Subject: Build failure of network:osmocom:latest/orcania in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a138373b_26f62ae79e4a05f0620452@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/Debian_Testing/x86_64 Package network:osmocom:latest/orcania failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 24s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 25s] [12/12] preinstalling binutils... [ 25s] copying packages... [ 48s] reordering...cycle: libc6 -> libgcc-s1 [ 48s] breaking dependency libgcc-s1 -> libc6 [ 49s] done [ 51s] booting kvm... [ 51s] ### VM INTERACTION START ### [ 51s] Using UART console [ 51s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 55s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 58s] Booting from ROM... [ 64s] c[?7l### VM INTERACTION END ### [ 64s] 2nd stage started in virtual machine [ 64s] machine type: x86_64 [ 64s] [ 5.795271] sysrq: Changing Loglevel [ 64s] Linux version: 5[ 5.796970] sysrq: Loglevel set to 4 [ 64s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 64s] Increasing log level from now on... [ 64s] Enable sysrq operations [ 64s] /.build/build-vm: line 632: mkswap: command not found [ 64s] swapon: /dev/vdb: read swap header failed [ 64s] ### VM INTERACTION START ### [ 67s] [ 8.858692] sysrq: Power Off [ 67s] [ 8.863511] reboot: Power down [ 67s] ### VM INTERACTION END ### [ 67s] [ 67s] cloud113 failed "build orcania_1.2.9-5.dsc" at Thu Nov 4 21:00:51 UTC 2021. [ 67s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a2d94a11_26f62ae79e4a05f062053@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sysmon Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] [ 5.113772] sysrq: Changing Loglevel [ 20s] [ 5.114544] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.164588] sysrq: Power Off [ 23s] [ 8.168894] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] old-cirrus3 failed "build osmo-sysmon_0.3.0.2.032c.202111040908.dsc" at Thu Nov 4 21:01:13 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:36 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a4d8434c_26f62ae79e4a05f06207df@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 14s] [10/12] preinstalling mount... [ 14s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 15s] [12/12] preinstalling binutils... [ 15s] copying packages... [ 20s] reordering...cycle: libc6 -> libgcc-s1 [ 20s] breaking dependency libgcc-s1 -> libc6 [ 20s] done [ 21s] booting kvm... [ 21s] ### VM INTERACTION START ### [ 21s] Using UART console [ 21s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 21s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 28s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 28s] 2nd stage started in virtual machine [ 28s] machine type: x86_64 [ 28s] Linux version: 5.3.18-59.24-defa[ 6.066964] sysrq: Changing Loglevel [ 28s] ult #1 SMP Mon S[ 6.067947] sysrq: Loglevel set to 4 [ 28s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 28s] Increasing log level from now on... [ 28s] Enable sysrq operations [ 28s] /.build/build-vm: line 632: mkswap: command not found [ 28s] swapon: /dev/vdb: read swap header failed [ 28s] ### VM INTERACTION START ### [ 31s] [ 9.112912] sysrq: Power Off [ 31s] [ 9.140921] reboot: Power down [ 31s] ### VM INTERACTION END ### [ 31s] [ 31s] old-atreju2 failed "build simtrace2_0.7.0.165.2312.202111040908.dsc" at Thu Nov 4 21:01:22 UTC 2021. [ 31s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcap in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a4ddb3ed_26f62ae79e4a05f062088d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcap failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: [ 16s] [10/12] preinstalling mount... [ 16s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 17s] [12/12] preinstalling binutils... [ 18s] copying packages... [ 22s] reordering...cycle: libc6 -> libgcc-s1 [ 22s] breaking dependency libgcc-s1 -> libc6 [ 22s] done [ 22s] booting kvm... [ 22s] ### VM INTERACTION START ### [ 22s] Using UART console [ 22s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 23s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 30s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 30s] 2nd stage started in virtual machine [ 30s] machine type: x86_64 [ 30s] [ 6.799357] sysrq: Changing Loglevel [ 30s] [ 6.800402] sysrq: Loglevel set to 4 [ 30s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 30s] Increasing log level from now on... [ 30s] Enable sysrq operations [ 30s] /.build/build-vm: line 632: mkswap: command not found [ 30s] swapon: /dev/vdb: read swap header failed [ 30s] ### VM INTERACTION START ### [ 33s] [ 9.872326] sysrq: Power Off [ 33s] [ 9.892555] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] old-atreju3 failed "build osmo-pcap_0.2.0.3.eedd.202111040908.dsc" at Thu Nov 4 21:01:25 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a4e58861_26f62ae79e4a05f062093e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 6s] [10/12] preinstalling mount... [ 6s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 7s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.873548] sysrq: Changing Loglevel [ 13s] .3.18-59.24-defa[ 4.874230] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.912219] sysrq: Power Off [ 16s] [ 7.930060] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat11 failed "build osmo-sysmon_0.3.0.dsc" at Thu Nov 4 21:01:28 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a4ecb4b4_26f62ae79e4a05f0621054@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 17s] copying packages... [ 39s] reordering...cycle: libc6 -> libgcc-s1 [ 39s] breaking dependency libgcc-s1 -> libc6 [ 39s] cycle: libdevmapper1.02.1 -> dmsetup [ 39s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 39s] done [ 40s] booting kvm... [ 40s] ### VM INTERACTION START ### [ 40s] Using UART console [ 40s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 2000 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 40s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 41s] Booting from ROM... [ 46s] c[?7l### VM INTERACTION END ### [ 46s] 2nd stage started in virtual machine [ 46s] machine type: x86_64 [ 46s] Linux version: 5.3.18-59.24-defa[ 4.540215] sysrq: Changing Loglevel [ 46s] [ 4.541102] sysrq: Loglevel set to 4 [ 46s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 46s] Increasing log level from now on... [ 46s] Enable sysrq operations [ 46s] /.build/build-vm: line 632: mkswap: command not found [ 46s] swapon: /dev/vdb: read swap header failed [ 46s] ### VM INTERACTION START ### [ 49s] [ 7.571894] sysrq: Power Off [ 49s] [ 7.574114] reboot: Power down [ 49s] ### VM INTERACTION END ### [ 49s] [ 49s] wildcard2 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111040908.dsc" at Thu Nov 4 21:01:34 UTC 2021. [ 49s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a4f258eb_26f62ae79e4a05f0621159@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-pcap failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] [ 5.633785] sysrq: Changing Loglevel [ 19s] [ 5.634464] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.686869] sysrq: Power Off [ 22s] [ 8.689764] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] build78 failed "build osmo-pcap_0.2.0.dsc" at Thu Nov 4 21:01:36 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:01:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:01:53 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a4faad5b_26f62ae79e4a05f0621270@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/Debian_Testing/x86_64 Package network:osmocom:latest/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] [ 5.126090] sysrq: Changing Loglevel [ 20s] [ 5.126842] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.180284] sysrq: Power Off [ 23s] [ 8.183695] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] old-cirrus1 failed "build simtrace2_0.5.2.dsc" at Thu Nov 4 21:01:41 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:02:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:02:44 +0000 Subject: Build failure of network:osmocom:nightly/yder in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a8869fbb_26f62ae79e4a05f0621375@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/yder/Debian_Testing/x86_64 Package network:osmocom:nightly/yder failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly yder Last lines of build log: [ 23s] [10/12] preinstalling mount... [ 23s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 24s] [12/12] preinstalling binutils... [ 25s] copying packages... [ 34s] reordering...cycle: libc6 -> libgcc-s1 [ 34s] breaking dependency libgcc-s1 -> libc6 [ 34s] done [ 35s] booting kvm... [ 35s] ### VM INTERACTION START ### [ 35s] Using UART console [ 35s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 35s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 43s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 43s] 2nd stage started in virtual machine [ 43s] machine type: x86_64 [ 43s] [ 7.568218] sysrq: Changing Loglevel [ 43s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 43s] Increasing log level from now on... [ 43s] [ 7.572762] sysrq: Loglevel set to 4 [ 43s] Enable sysrq operations [ 43s] /.build/build-vm: line 632: mkswap: command not found [ 43s] swapon: /dev/vdb: read swap header failed [ 43s] ### VM INTERACTION START ### [ 46s] [ 10.645792] sysrq: Power Off [ 46s] [ 10.661841] reboot: Power down [ 46s] ### VM INTERACTION END ### [ 46s] [ 46s] cloud132 failed "build yder_1.4.4-4.1.dsc" at Thu Nov 4 21:02:33 UTC 2021. [ 46s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:02:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:02:44 +0000 Subject: Build failure of network:osmocom:latest/yder in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a88ddbee_26f62ae79e4a05f062145e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/yder/Debian_Testing/x86_64 Package network:osmocom:latest/yder failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest yder Last lines of build log: [ 35s] [10/12] preinstalling mount... [ 36s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 37s] [12/12] preinstalling binutils... [ 38s] copying packages... [ 56s] reordering...cycle: libc6 -> libgcc-s1 [ 56s] breaking dependency libgcc-s1 -> libc6 [ 56s] done [ 57s] booting kvm... [ 57s] ### VM INTERACTION START ### [ 57s] Using UART console [ 57s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 58s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 70s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 70s] 2nd stage started in virtual machine [ 70s] machine type: x86_64 [ 70s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 70s] Increasing log level from now on... [ 70s] [ 11.482597] sysrq: Changing Loglevel [ 70s] [ 11.483388] sysrq: Loglevel set to 4 [ 70s] Enable sysrq operations [ 70s] /.build/build-vm: line 632: mkswap: command not found [ 70s] swapon: /dev/vdb: read swap header failed [ 70s] ### VM INTERACTION START ### [ 73s] [ 14.578769] sysrq: Power Off [ 73s] [ 14.611975] reboot: Power down [ 73s] ### VM INTERACTION END ### [ 73s] [ 73s] lamb57 failed "build yder_1.4.4-4.1.dsc" at Thu Nov 4 21:02:39 UTC 2021. [ 73s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844a8ec3cfe_26f62ae79e4a05f062203a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 62s] copying packages... [ 90s] reordering...cycle: libc6 -> libgcc-s1 [ 90s] breaking dependency libgcc-s1 -> libc6 [ 90s] cycle: libdevmapper1.02.1 -> dmsetup [ 90s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 90s] done [ 92s] booting kvm... [ 92s] ### VM INTERACTION START ### [ 92s] Using UART console [ 92s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 92s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 92s] Booting from ROM... [ 107s] c[?7l### VM INTERACTION END ### [ 107s] 2nd stage started in virtual machine [ 107s] machine type: x86_64 [ 107s] [ 13.006625] sysrq: Changing Loglevel [ 107s] [ 13.007744] sysrq: Loglevel set to 4 [ 107s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 107s] Increasing log level from now on... [ 107s] Enable sysrq operations [ 107s] /.build/build-vm: line 632: mkswap: command not found [ 107s] swapon: /dev/vdb: read swap header failed [ 107s] ### VM INTERACTION START ### [ 111s] [ 16.399329] sysrq: Power Off [ 111s] [ 16.419116] reboot: Power down [ 111s] ### VM INTERACTION END ### [ 111s] [ 111s] old-atreju4 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Thu Nov 4 21:02:43 UTC 2021. [ 111s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ac3bf956_26f62ae79e4a05f06222dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 8s] [12/12] preinstalling binutils... [ 8s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 2000 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.24-defa[ 4.742458] sysrq: Changing Loglevel [ 23s] ult #1 SMP Mon S[ 4.743603] sysrq: Loglevel set to 4 [ 23s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 7.773343] sysrq: Power Off [ 26s] [ 7.775341] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] wildcard2 failed "build osmo-hlr_1.3.1.dsc" at Thu Nov 4 21:03:46 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ac415ba8_26f62ae79e4a05f06223e7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 5.3.18-59.24-defa[ 4.453787] sysrq: Changing Loglevel [ 15s] ult #1 SMP Mon S[ 4.454755] sysrq: Loglevel set to 4 [ 15s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] /.build/build-vm: line 632: mkswap: command not found [ 15s] swapon: /dev/vdb: read swap header failed [ 15s] ### VM INTERACTION START ### [ 18s] [ 7.476809] sysrq: Power Off [ 18s] [ 7.481135] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] goat09 failed "build osmo-trx_1.3.1.28.019d.202111040908.dsc" at Thu Nov 4 21:03:48 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-e1d in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ac4660ac_26f62ae79e4a05f06224e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-e1d/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-e1d failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-e1d Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] [ 4.468440] sysrq: Changing Loglevel [ 14s] [ 4.469312] sysrq: Loglevel set to 4 [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.492485] sysrq: Power Off [ 17s] [ 7.495669] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat07 failed "build osmo-e1d_0.2.1.dsc" at Thu Nov 4 21:03:36 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-e1d in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ac4ab7fe_26f62ae79e4a05f06225d0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-e1d failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.579829] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.581567] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.604769] sysrq: Power Off [ 17s] [ 7.610517] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat19 failed "build osmo-e1d_0.2.1.4.74fa.202111040908.dsc" at Thu Nov 4 21:03:38 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ac4d98a6_26f62ae79e4a05f06226ef@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] cycle: libdevmapper1.02.1 -> dmsetup [ 12s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 5.010436] sysrq: Changing Loglevel [ 18s] .3.18-59.24-defa[ 5.011691] sysrq: Loglevel set to 4 [ 18s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.044705] sysrq: Power Off [ 21s] [ 8.056315] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] sheep88 failed "build osmo-gbproxy_0.1.2.dsc" at Thu Nov 4 21:03:50 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:53 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ac536d3f_26f62ae79e4a05f06227ac@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Testing/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] cycle: dmsetup -> libdevmapper1.02.1 [ 8s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 8s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.477572] sysrq: Changing Loglevel [ 13s] .3.18-59.24-defa[ 4.478765] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.499899] sysrq: Power Off [ 16s] [ 7.503128] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat07 failed "build ulfius_2.5.2-4.2.dsc" at Thu Nov 4 21:03:39 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:03:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:03:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ac5744e5_26f62ae79e4a05f0622887@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 5[ 4.928760] sysrq: Changing Loglevel [ 15s] .3.18-59.24-defa[ 4.929230] sysrq: Loglevel set to 4 [ 15s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] /.build/build-vm: line 632: mkswap: command not found [ 15s] swapon: /dev/vdb: read swap header failed [ 15s] ### VM INTERACTION START ### [ 18s] [ 7.949035] sysrq: Power Off [ 18s] [ 7.959905] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] goat15 failed "build osmo-sip-connector_1.5.0.8.bd66.202111040908.dsc" at Thu Nov 4 21:03:41 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae42625_26f62ae79e4a05f062292@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Testing/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: dmsetup -> libdevmapper1.02.1 [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 21s] Increasing log level from now on... [ 21s] [ 5.923640] sysrq: Changing Loglevel [ 21s] [ 5.924618] sysrq: Loglevel set to 4 [ 21s] Enable sysrq operations [ 21s] /.build/build-vm: line 632: mkswap: command not found [ 21s] swapon: /dev/vdb: read swap header failed [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.973206] sysrq: Power Off [ 24s] [ 8.976248] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] old-atreju2 failed "build ulfius_2.5.2-4.2.dsc" at Thu Nov 4 21:03:57 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae438a00_26f62ae79e4a05f062303e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_15/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_15/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_15/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.000230] sysrq: Changing Loglevel [ 20s] .3.18-59.24-defa[ 5.001046] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.031997] sysrq: Power Off [ 23s] [ 8.036040] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] sheep86 failed "build libosmo-sccp_1.4.0.dsc" at Thu Nov 4 21:03:58 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae483d33_26f62ae79e4a05f062318@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5[ 5.896353] sysrq: Changing Loglevel [ 24s] .3.18-59.24-defa[ 5.897589] sysrq: Loglevel set to 4 [ 24s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 24s] swapon: /dev/vdb: read swap header failed [ 24s] ### VM INTERACTION START ### [ 27s] [ 8.950876] sysrq: Power Off [ 27s] [ 8.955884] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb14 failed "build osmo-hlr_1.3.0.7.bfee.202111040908.dsc" at Thu Nov 4 21:04:02 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae4b91a0_26f62ae79e4a05f06232f6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.005577] sysrq: Changing Loglevel [ 20s] .3.18-59.24-defa[ 5.006999] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.042416] sysrq: Power Off [ 23s] [ 8.046709] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] sheep86 failed "build osmo-pcu_0.9.1.dsc" at Thu Nov 4 21:04:02 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae51e858_26f62ae79e4a05f06233f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.24-defa[ 5.817767] sysrq: Changing Loglevel [ 23s] ult #1 SMP Mon S[ 5.818800] sysrq: Loglevel set to 4 [ 23s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.865854] sysrq: Power Off [ 26s] [ 8.871297] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb14 failed "build libosmo-sccp_1.4.0.34.8aa6.202111040908.dsc" at Thu Nov 4 21:04:04 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae54c1c8_26f62ae79e4a05f06234ba@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gbproxy failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] [ 5.942262] sysrq: Changing Loglevel [ 24s] [ 5.943344] sysrq: Loglevel set to 4 [ 24s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 25s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 9.077578] sysrq: Power Off [ 28s] [ 9.082813] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] old-atreju2 failed "build osmo-gbproxy_0.1.0.47.0141.202111040908.dsc" at Thu Nov 4 21:03:53 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae5825fd_26f62ae79e4a05f0623549@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.009660] sysrq: Changing Loglevel [ 20s] .3.18-59.24-defa[ 5.012203] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.051548] sysrq: Power Off [ 23s] [ 8.056266] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] sheep86 failed "build osmo-mgw_1.8.1.88.fdbef.202111040908.dsc" at Thu Nov 4 21:04:04 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae5b98d5_26f62ae79e4a05f0623639@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] cycle: libdevmapper1.02.1 -> dmsetup [ 13s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 13s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.023494] sysrq: Changing Loglevel [ 19s] .3.18-59.24-defa[ 5.024965] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.059432] sysrq: Power Off [ 22s] [ 8.062955] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] sheep88 failed "build osmo-ggsn_1.7.1.20.8cbd.202111040908.dsc" at Thu Nov 4 21:03:53 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:10 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae5f0053_26f62ae79e4a05f06237d9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_13/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_13/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_13/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5[ 4.954582] sysrq: Changing Loglevel [ 21s] .3.18-59.24-defa[ 4.956470] sysrq: Loglevel set to 4 [ 21s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] /.build/build-vm: line 632: mkswap: command not found [ 21s] swapon: /dev/vdb: read swap header failed [ 21s] ### VM INTERACTION START ### [ 24s] [ 7.987063] sysrq: Power Off [ 24s] [ 7.992242] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] sheep88 failed "build osmo-trx_1.3.1.dsc" at Thu Nov 4 21:04:05 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae65f2e2_26f62ae79e4a05f06238a4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] [ 4.542614] sysrq: Changing Loglevel [ 14s] [ 4.543003] sysrq: Loglevel set to 4 [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.561805] sysrq: Power Off [ 17s] [ 7.564843] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat03 failed "build osmo-cbc_0.2.2.dsc" at Thu Nov 4 21:04:17 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae6d0a87_26f62ae79e4a05f0623976@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 5s] [12/12] preinstalling binutils... [ 5s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] cycle: libdevmapper1.02.1 -> dmsetup [ 8s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 8s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.472103] sysrq: Changing Loglevel [ 13s] .3.18-59.24-defa[ 4.472570] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.490944] sysrq: Power Off [ 16s] [ 7.493611] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat01 failed "build osmo-smlc_0.2.0.dsc" at Thu Nov 4 21:04:24 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae753d11_26f62ae79e4a05f062403d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 18s] [12/12] preinstalling binutils... [ 18s] copying packages... [ 25s] reordering...cycle: libc6 -> libgcc-s1 [ 25s] breaking dependency libgcc-s1 -> libc6 [ 25s] cycle: libdevmapper1.02.1 -> dmsetup [ 25s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 25s] done [ 27s] booting kvm... [ 27s] ### VM INTERACTION START ### [ 27s] Using UART console [ 27s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 27s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 36s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 36s] 2nd stage started in virtual machine [ 36s] machine type: x86_64 [ 36s] [ 8.988124] sysrq: Changing Loglevel [ 36s] [ 8.988986] sysrq: Loglevel set to 4 [ 36s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 36s] Increasing log level from now on... [ 36s] Enable sysrq operations [ 36s] /.build/build-vm: line 632: mkswap: command not found [ 36s] swapon: /dev/vdb: read swap header failed [ 36s] ### VM INTERACTION START ### [ 39s] [ 12.102380] sysrq: Power Off [ 39s] [ 12.130886] reboot: Power down [ 40s] ### VM INTERACTION END ### [ 40s] [ 40s] lamb09 failed "build osmo-mgw_1.8.1.dsc" at Thu Nov 4 21:04:14 UTC 2021. [ 40s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844ae79c4f4_26f62ae79e4a05f0624126@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.448074] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.449150] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.475577] sysrq: Power Off [ 17s] [ 7.479992] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat09 failed "build osmo-remsim_0.2.4.dsc" at Thu Nov 4 21:04:17 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b013da22_26f62ae79e4a05f0624246@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] [ 5.579919] sysrq: Changing Loglevel [ 22s] [ 5.580669] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.618704] sysrq: Power Off [ 26s] [ 8.621550] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] build74 failed "build osmo-remsim_0.2.2.113.eb9f.202111040908.dsc" at Thu Nov 4 21:04:38 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b0176618_26f62ae79e4a05f0624396@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] [ 5.203065] sysrq: Changing Loglevel [ 20s] [ 5.203893] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.239320] sysrq: Power Off [ 23s] [ 8.242535] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] build77 failed "build osmo-cbc_0.2.2.1.cf3c.202111040908.dsc" at Thu Nov 4 21:04:38 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b01ba6b7_26f62ae79e4a05f0624426@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.447154] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.448271] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.468638] sysrq: Power Off [ 17s] [ 7.472051] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat17 failed "build osmo-bsc_1.7.0.312.ed10d.202111040908.dsc" at Thu Nov 4 21:04:39 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b0222cf8_26f62ae79e4a05f06245ee@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 7s] [12/12] preinstalling binutils... [ 7s] copying packages... [ 10s] reordering...cycle: libc6 -> libgcc-s1 [ 10s] breaking dependency libgcc-s1 -> libc6 [ 10s] cycle: libdevmapper1.02.1 -> dmsetup [ 10s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 10s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 5[ 4.512548] sysrq: Changing Loglevel [ 15s] .3.18-59.24-defa[ 4.513458] sysrq: Loglevel set to 4 [ 15s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] /.build/build-vm: line 632: mkswap: command not found [ 15s] swapon: /dev/vdb: read swap header failed [ 15s] ### VM INTERACTION START ### [ 18s] [ 7.537426] sysrq: Power Off [ 18s] [ 7.542845] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] goat07 failed "build osmo-bsc_1.7.2.dsc" at Thu Nov 4 21:04:43 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:04:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:04:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b027b457_26f62ae79e4a05f0624641@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 17s] copying packages... [ 34s] reordering...cycle: libc6 -> libgcc-s1 [ 34s] breaking dependency libgcc-s1 -> libc6 [ 34s] cycle: libdevmapper1.02.1 -> dmsetup [ 34s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 34s] done [ 35s] booting kvm... [ 35s] ### VM INTERACTION START ### [ 35s] Using UART console [ 35s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 36s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 36s] Booting from ROM... [ 47s] c[?7l### VM INTERACTION END ### [ 47s] 2nd stage started in virtual machine [ 48s] machine type: x86_64 [ 48s] [ 9.994456] sysrq: Changing Loglevel [ 48s] [ 9.995280] sysrq: Loglevel set to 4 [ 48s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 48s] Increasing log level from now on... [ 48s] Enable sysrq operations [ 48s] /.build/build-vm: line 632: mkswap: command not found [ 48s] swapon: /dev/vdb: read swap header failed [ 48s] ### VM INTERACTION START ### [ 51s] [ 13.141885] sysrq: Power Off [ 51s] [ 13.169223] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] lamb57 failed "build osmo-pcu_0.9.0.234.dd28.202111040908.dsc" at Thu Nov 4 21:04:32 UTC 2021. [ 51s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b0389e03_26f62ae79e4a05f0624722@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 31s] [12/12] preinstalling binutils... [ 32s] copying packages... [ 48s] reordering...cycle: libc6 -> libgcc-s1 [ 48s] breaking dependency libgcc-s1 -> libc6 [ 48s] cycle: libdevmapper1.02.1 -> dmsetup [ 48s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 48s] done [ 50s] booting kvm... [ 50s] ### VM INTERACTION START ### [ 50s] Using UART console [ 50s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 50s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 59s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 59s] 2nd stage started in virtual machine [ 60s] machine type: x86_64 [ 60s] [ 9.156711] sysrq: Changing Loglevel [ 60s] [ 9.157502] sysrq: Loglevel set to 4 [ 60s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 60s] Increasing log level from now on... [ 60s] Enable sysrq operations [ 60s] /.build/build-vm: line 632: mkswap: command not found [ 60s] swapon: /dev/vdb: read swap header failed [ 60s] ### VM INTERACTION START ### [ 63s] [ 12.272628] sysrq: Power Off [ 63s] [ 12.301826] reboot: Power down [ 63s] ### VM INTERACTION END ### [ 63s] [ 63s] lamb27 failed "build osmo-sip-connector_1.5.1.dsc" at Thu Nov 4 21:04:49 UTC 2021. [ 63s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:02 +0000 Subject: Build failure of network:osmocom:nightly/osmo-uecups in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b03c09be_26f62ae79e4a05f0624897@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-uecups failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-uecups Last lines of build log: [ 25s] [12/12] preinstalling binutils... [ 27s] copying packages... [ 45s] reordering...cycle: libc6 -> libgcc-s1 [ 45s] breaking dependency libgcc-s1 -> libc6 [ 45s] cycle: libdevmapper1.02.1 -> dmsetup [ 45s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 45s] done [ 47s] booting kvm... [ 47s] ### VM INTERACTION START ### [ 47s] Using UART console [ 47s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 47s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 59s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 59s] 2nd stage started in virtual machine [ 59s] machine type: x86_64 [ 59s] [ 10.574554] sysrq: Changing Loglevel [ 59s] [ 10.575512] sysrq: Loglevel set to 4 [ 59s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 59s] Increasing log level from now on... [ 59s] Enable sysrq operations [ 59s] /.build/build-vm: line 632: mkswap: command not found [ 59s] swapon: /dev/vdb: read swap header failed [ 59s] ### VM INTERACTION START ### [ 62s] [ 13.733323] sysrq: Power Off [ 63s] [ 13.770957] reboot: Power down [ 63s] ### VM INTERACTION END ### [ 63s] [ 63s] lamb51 failed "build osmo-uecups_0.1.3.1.8362.202111040908.dsc" at Thu Nov 4 21:04:51 UTC 2021. [ 63s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b0437f51_26f62ae79e4a05f0624947@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 16s] [12/12] preinstalling binutils... [ 16s] copying packages... [ 28s] reordering...cycle: libc6 -> libgcc-s1 [ 28s] breaking dependency libgcc-s1 -> libc6 [ 28s] cycle: libdevmapper1.02.1 -> dmsetup [ 28s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 28s] done [ 29s] booting kvm... [ 29s] ### VM INTERACTION START ### [ 29s] Using UART console [ 29s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 30s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 39s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 39s] 2nd stage started in virtual machine [ 40s] machine type: x86_64 [ 40s] [ 9.259414] sysrq: Changing Loglevel [ 40s] [ 9.260379] sysrq: Loglevel set to 4 [ 40s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 40s] Increasing log level from now on... [ 40s] Enable sysrq operations [ 40s] /.build/build-vm: line 632: mkswap: command not found [ 40s] swapon: /dev/vdb: read swap header failed [ 40s] ### VM INTERACTION START ### [ 43s] [ 13.184811] sysrq: Power Off [ 43s] [ 13.249261] reboot: Power down [ 44s] ### VM INTERACTION END ### [ 44s] [ 44s] old-atreju2 failed "build osmo-iuh_1.0.0.dsc" at Thu Nov 4 21:04:57 UTC 2021. [ 44s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b1db79d8_26f62ae79e4a05f062502e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 42s] copying packages... [ 62s] reordering...cycle: libc6 -> libgcc-s1 [ 62s] breaking dependency libgcc-s1 -> libc6 [ 62s] cycle: libdevmapper1.02.1 -> dmsetup [ 62s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 62s] done [ 63s] booting kvm... [ 63s] ### VM INTERACTION START ### [ 63s] Using UART console [ 63s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 63s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 63s] Booting from ROM... [ 74s] c[?7l### VM INTERACTION END ### [ 74s] 2nd stage started in virtual machine [ 74s] machine type: x86_64 [ 74s] [ 10.768206] sysrq: Changing Loglevel [ 74s] [ 10.769022] sysrq: Loglevel set to 4 [ 74s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 74s] Increasing log level from now on... [ 74s] Enable sysrq operations [ 74s] /.build/build-vm: line 632: mkswap: command not found [ 74s] swapon: /dev/vdb: read swap header failed [ 74s] ### VM INTERACTION START ### [ 77s] [ 13.871890] sysrq: Power Off [ 78s] [ 13.951562] reboot: Power down [ 78s] ### VM INTERACTION END ### [ 78s] [ 78s] lamb28 failed "build osmo-bts_1.3.3.dsc" at Thu Nov 4 21:05:12 UTC 2021. [ 78s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b1e65c97_26f62ae79e4a05f06251c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 43s] [12/12] preinstalling binutils... [ 44s] copying packages... [ 64s] reordering...cycle: libc6 -> libgcc-s1 [ 64s] breaking dependency libgcc-s1 -> libc6 [ 64s] cycle: libdevmapper1.02.1 -> dmsetup [ 64s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 64s] done [ 65s] booting kvm... [ 65s] ### VM INTERACTION START ### [ 65s] Using UART console [ 65s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 65s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 76s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 76s] 2nd stage started in virtual machine [ 76s] machine type: x86_64 [ 76s] [ 10.322881] sysrq: Changing Loglevel [ 76s] [ 10.324105] sysrq: Loglevel set to 4 [ 76s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 76s] Increasing log level from now on... [ 76s] Enable sysrq operations [ 76s] /.build/build-vm: line 632: mkswap: command not found [ 76s] swapon: /dev/vdb: read swap header failed [ 76s] ### VM INTERACTION START ### [ 80s] [ 13.510796] sysrq: Power Off [ 80s] [ 13.570001] reboot: Power down [ 80s] ### VM INTERACTION END ### [ 80s] [ 80s] lamb28 failed "build osmo-ggsn_1.7.1.dsc" at Thu Nov 4 21:05:07 UTC 2021. [ 80s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b3d930b3_26f62ae79e4a05f062521e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 21s] [12/12] preinstalling binutils... [ 21s] copying packages... [ 32s] reordering...cycle: libc6 -> libgcc-s1 [ 32s] breaking dependency libgcc-s1 -> libc6 [ 32s] cycle: libdevmapper1.02.1 -> dmsetup [ 32s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 32s] done [ 33s] booting kvm... [ 33s] ### VM INTERACTION START ### [ 33s] Using UART console [ 33s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 33s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 41s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 41s] 2nd stage started in virtual machine [ 41s] machine type: x86_64 [ 41s] Linux version: 5.3.18-59.24-defa[ 7.458471] sysrq: Changing Loglevel [ 41s] ult #1 SMP Mon S[ 7.460047] sysrq: Loglevel set to 4 [ 41s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 41s] Increasing log level from now on... [ 41s] Enable sysrq operations [ 41s] /.build/build-vm: line 632: mkswap: command not found [ 41s] swapon: /dev/vdb: read swap header failed [ 41s] ### VM INTERACTION START ### [ 44s] [ 10.521530] sysrq: Power Off [ 44s] [ 10.525310] reboot: Power down [ 45s] ### VM INTERACTION END ### [ 45s] [ 45s] cloud119 failed "build osmo-smlc_0.2.0.1.44a2.202111040908.dsc" at Thu Nov 4 21:05:28 UTC 2021. [ 45s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b40838d3_26f62ae79e4a05f06255ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.553646] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.554197] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.574318] sysrq: Power Off [ 17s] [ 7.578015] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat11 failed "build osmo-msc_1.7.1.dsc" at Thu Nov 4 21:05:24 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:05:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:05:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b411e738_26f62ae79e4a05f06257d0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 51s] copying packages... [ 80s] reordering...cycle: libc6 -> libgcc-s1 [ 80s] breaking dependency libgcc-s1 -> libc6 [ 80s] cycle: libdevmapper1.02.1 -> dmsetup [ 80s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 80s] done [ 82s] booting kvm... [ 82s] ### VM INTERACTION START ### [ 82s] Using UART console [ 82s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 83s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 83s] Booting from ROM... [ 103s] c[?7l### VM INTERACTION END ### [ 103s] 2nd stage started in virtual machine [ 104s] machine type: x86_64 [ 104s] [ 18.548914] sysrq: Changing Loglevel [ 104s] [ 18.551771] sysrq: Loglevel set to 4 [ 104s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 104s] Increasing log level from now on... [ 104s] Enable sysrq operations [ 104s] /.build/build-vm: line 632: mkswap: command not found [ 104s] swapon: /dev/vdb: read swap header failed [ 104s] ### VM INTERACTION START ### [ 107s] [ 21.900604] sysrq: Power Off [ 107s] [ 21.980599] reboot: Power down [ 107s] ### VM INTERACTION END ### [ 107s] [ 107s] lamb52 failed "build osmo-bts_1.3.0.330.7bb78.202111040908.dsc" at Thu Nov 4 21:05:40 UTC 2021. [ 107s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:06:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:06:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b76cb10b_26f62ae79e4a05f06261e4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 25s] copying packages... [ 60s] reordering...cycle: libc6 -> libgcc-s1 [ 60s] breaking dependency libgcc-s1 -> libc6 [ 60s] cycle: libdevmapper1.02.1 -> dmsetup [ 60s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 60s] done [ 69s] booting kvm... [ 69s] ### VM INTERACTION START ### [ 69s] Using UART console [ 69s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 74s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 89s] Booting from ROM... [ 94s] c[?7l### VM INTERACTION END ### [ 94s] 2nd stage started in virtual machine [ 94s] machine type: x86_64 [ 94s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 94s] Increasing log level from now on... [ 94s] [ 5.446048] sysrq: Changing Loglevel [ 94s] [ 5.447328] sysrq: Loglevel set to 4 [ 94s] Enable sysrq operations [ 94s] /.build/build-vm: line 632: mkswap: command not found [ 94s] swapon: /dev/vdb: read swap header failed [ 94s] ### VM INTERACTION START ### [ 97s] [ 8.490666] sysrq: Power Off [ 97s] [ 8.493684] reboot: Power down [ 97s] ### VM INTERACTION END ### [ 97s] [ 97s] cloud111 failed "build osmo-iuh_0.7.0.26.e321.202111040908.dsc" at Thu Nov 4 21:06:34 UTC 2021. [ 97s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:06:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:06:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b7722464_26f62ae79e4a05f0626213@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 32s] [12/12] preinstalling binutils... [ 32s] copying packages... [ 48s] reordering...cycle: libc6 -> libgcc-s1 [ 48s] breaking dependency libgcc-s1 -> libc6 [ 48s] cycle: libdevmapper1.02.1 -> dmsetup [ 48s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 48s] done [ 49s] booting kvm... [ 49s] ### VM INTERACTION START ### [ 49s] Using UART console [ 49s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 50s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 59s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 59s] 2nd stage started in virtual machine [ 59s] machine type: x86_64 [ 59s] [ 8.906990] sysrq: Changing Loglevel [ 59s] [ 8.908083] sysrq: Loglevel set to 4 [ 59s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 59s] Increasing log level from now on... [ 59s] Enable sysrq operations [ 59s] /.build/build-vm: line 632: mkswap: command not found [ 59s] swapon: /dev/vdb: read swap header failed [ 59s] ### VM INTERACTION START ### [ 62s] [ 12.017735] sysrq: Power Off [ 62s] [ 12.072128] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] lamb25 failed "build osmo-sgsn_1.7.1.dsc" at Thu Nov 4 21:06:38 UTC 2021. [ 62s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:07:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:07:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844b9692337_26f62ae79e4a05f062639d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] cycle: libdevmapper1.02.1 -> dmsetup [ 8s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 8s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] [ 4.579770] sysrq: Changing Loglevel [ 14s] [ 4.580990] sysrq: Loglevel set to 4 [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.611601] sysrq: Power Off [ 17s] [ 7.614285] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat15 failed "build osmo-msc_1.7.0.36.c6921.202111040908.dsc" at Thu Nov 4 21:07:05 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:07:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:07:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844bb5e37c3_26f62ae79e4a05f0626585@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 12s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 23s] booting kvm... [ 23s] ### VM INTERACTION START ### [ 23s] Using UART console [ 23s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 23s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM... [ 29s] c[?7l### VM INTERACTION END ### [ 29s] 2nd stage started in virtual machine [ 29s] machine type: x86_64 [ 29s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 29s] Increasing log level from now on... [ 29s] [ 5.392106] sysrq: Changing Loglevel [ 29s] [ 5.393237] sysrq: Loglevel set to 4 [ 29s] Enable sysrq operations [ 29s] /.build/build-vm: line 632: mkswap: command not found [ 29s] swapon: /dev/vdb: read swap header failed [ 29s] ### VM INTERACTION START ### [ 32s] [ 8.436897] sysrq: Power Off [ 32s] [ 8.440209] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] cloud108 failed "build osmo-sgsn_1.7.0.26.6cee1.202111040908.dsc" at Thu Nov 4 21:07:28 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 4 21:08:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 04 Nov 2021 21:08:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61844bd066520_26f62ae79e4a05f0626658@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 13s] copying packages... [ 38s] reordering...cycle: libc6 -> libgcc-s1 [ 38s] breaking dependency libgcc-s1 -> libc6 [ 38s] cycle: libdevmapper1.02.1 -> dmsetup [ 38s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 38s] done [ 40s] booting kvm... [ 41s] ### VM INTERACTION START ### [ 41s] Using UART console [ 41s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 45s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 47s] Booting from ROM... [ 54s] c[?7l### VM INTERACTION END ### [ 54s] 2nd stage started in virtual machine [ 54s] machine type: x86_64 [ 54s] Linux version: 5[ 6.792950] sysrq: Changing Loglevel [ 54s] [ 6.794463] sysrq: Loglevel set to 4 [ 54s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 54s] Increasing log level from now on... [ 54s] Enable sysrq operations [ 54s] /.build/build-vm: line 632: mkswap: command not found [ 54s] swapon: /dev/vdb: read swap header failed [ 54s] ### VM INTERACTION START ### [ 57s] [ 9.845311] sysrq: Power Off [ 57s] [ 9.864070] reboot: Power down [ 58s] ### VM INTERACTION END ### [ 58s] [ 58s] cloud138 failed "build osmo-hnodeb_0.0.0.202111040908.dsc" at Thu Nov 4 21:07:59 UTC 2021. [ 58s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:10:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 21:10:48 +0000 Subject: Change in osmo-bsc[master]: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26114 ) Change subject: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() ...................................................................... assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() Change-Id: I579c265e9d18402ce806e4d0ea836042185dedaa --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/26114/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 1449bdb..f9a81b3 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -959,7 +959,7 @@ assignment_fail(new_lchan->activate.gsm0808_error_cause, "Failed to %s lchan %s", conn->assignment.new_lchan ? "activate" : "modify", - conn->assignment.new_lchan ? gsm_lchan_name(conn->assignment.new_lchan) : ""); + gsm_lchan_name(new_lchan)); return; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I579c265e9d18402ce806e4d0ea836042185dedaa Gerrit-Change-Number: 26114 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:11:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:11:41 +0000 Subject: Change in osmo-bsc[master]: .gitignore: also ignore *.la files References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26115 ) Change subject: .gitignore: also ignore *.la files ...................................................................... .gitignore: also ignore *.la files I started to see 'src/osmo-bsc/libbsc.la' in 'Untracked files'. Change-Id: I6e4a88e3bf92a1c0e1ccb92f8ff91e24d4e99926 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/26115/1 diff --git a/.gitignore b/.gitignore index e504f4c..c637d37 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ *.o *.lo *.a +*.la .deps Makefile Makefile.in -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6e4a88e3bf92a1c0e1ccb92f8ff91e24d4e99926 Gerrit-Change-Number: 26115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:11:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:11:42 +0000 Subject: Change in osmo-bsc[master]: .gitignore: remove non-existing ipaccess-firmware binary References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26116 ) Change subject: .gitignore: remove non-existing ipaccess-firmware binary ...................................................................... .gitignore: remove non-existing ipaccess-firmware binary Change-Id: I4fb706ace67216f51a8e052b0ef72d944cefd88f --- M .gitignore 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/16/26116/1 diff --git a/.gitignore b/.gitignore index c637d37..0bbe478 100644 --- a/.gitignore +++ b/.gitignore @@ -48,7 +48,6 @@ src/utils/bs11_config src/ipaccess/ipaccess-config src/ipaccess/abisip-find -src/ipaccess/ipaccess-firmware src/ipaccess/ipaccess-proxy src/utils/isdnsync src/osmo-bsc_nat/osmo-bsc_nat -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4fb706ace67216f51a8e052b0ef72d944cefd88f Gerrit-Change-Number: 26116 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:19:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 21:19:46 +0000 Subject: Change in osmo-bsc[master]: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26117 ) Change subject: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() ...................................................................... lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() _lchan_on_activation_failure(), which calls lchan_on_mode_modify_failure(), already checks for !for_conn in other paths. Hence, it can be that for_conn being passed to _lchan_on_mode_modify_failure() may be null. """ Stack trace of thread 7077: #0 0x000055d25a463842 _lchan_on_mode_modify_failure (osmo-bsc) #1 0x000055d25a46b57c _lchan_on_activation_failure (osmo-bsc) #2 0x00007fe8b2083be4 state_chg (libosmocore.so.17) #3 0x00007fe8b208409d _osmo_fsm_inst_state_chg (libosmocore.so.17) #4 0x000055d25a46825a lchan_fsm_wait_rll_rtp_establish (osmo-bsc) #5 0x00007fe8b2084239 _osmo_fsm_inst_dispatch (libosmocore.so.17) #6 0x00007fe8b2083be4 state_chg (libosmocore.so.17) #7 0x00007fe8b208409d _osmo_fsm_inst_state_chg (libosmocore.so.17) #8 0x000055d25a46dbdc lchan_rtp_fsm_wait_ipacc_mdcx_ack (osmo-bsc) #9 0x00007fe8b2084239 _osmo_fsm_inst_dispatch (libosmocore.so.17) #10 0x000055d25a411d69 abis_rsl_rx_ipacc_mdcx_ack (osmo-bsc) """ Related: SYS#5698 Change-Id: If8b2895feef6e30f9c1db97394dd16d892b277f2 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/26117/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 2f62487..ae7a891 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -97,6 +97,11 @@ case MODIFY_FOR_ASSIGNMENT: LOG_LCHAN(lchan, LOGL_NOTICE, "Signalling Assignment FSM of error (%s)\n", lchan->last_error ? : "unknown error"); + if (!for_conn) { + LOG_LCHAN(lchan, LOGL_ERROR, "lchan Channel Mode Modify failed, " + "but modify request has no conn\n"); + break; + } _osmo_fsm_inst_dispatch(for_conn->assignment.fi, ASSIGNMENT_EV_LCHAN_ERROR, lchan, file, line); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b2895feef6e30f9c1db97394dd16d892b277f2 Gerrit-Change-Number: 26117 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:21:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 21:21:15 +0000 Subject: Change in osmo-bsc[master]: .gitignore: also ignore *.la files In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26115 ) Change subject: .gitignore: also ignore *.la files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6e4a88e3bf92a1c0e1ccb92f8ff91e24d4e99926 Gerrit-Change-Number: 26115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 21:21:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:21:23 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Nov 2021 21:21:23 +0000 Subject: Change in osmo-bsc[master]: .gitignore: remove non-existing ipaccess-firmware binary In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26116 ) Change subject: .gitignore: remove non-existing ipaccess-firmware binary ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4fb706ace67216f51a8e052b0ef72d944cefd88f Gerrit-Change-Number: 26116 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 21:21:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:23:45 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:23:45 +0000 Subject: Change in osmo-bsc[master]: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26117 ) Change subject: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b2895feef6e30f9c1db97394dd16d892b277f2 Gerrit-Change-Number: 26117 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Nov 2021 21:23:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:24:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:24:17 +0000 Subject: Change in osmo-bsc[master]: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26114 ) Change subject: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I579c265e9d18402ce806e4d0ea836042185dedaa Gerrit-Change-Number: 26114 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 21:24:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:27:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:27:31 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 21:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:29:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:29:14 +0000 Subject: Change in libosmocore[master]: include: add enum for UTRAN cipher In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26106 ) Change subject: include: add enum for UTRAN cipher ...................................................................... Patch Set 1: I believe we should use prefix 'OSMO_' for the new symbols. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 21:29:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:29:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:29:46 +0000 Subject: Change in osmo-bsc[master]: .gitignore: also ignore *.la files In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26115 ) Change subject: .gitignore: also ignore *.la files ...................................................................... .gitignore: also ignore *.la files I started to see 'src/osmo-bsc/libbsc.la' in 'Untracked files'. Change-Id: I6e4a88e3bf92a1c0e1ccb92f8ff91e24d4e99926 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/.gitignore b/.gitignore index e504f4c..c637d37 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ *.o *.lo *.a +*.la .deps Makefile Makefile.in -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6e4a88e3bf92a1c0e1ccb92f8ff91e24d4e99926 Gerrit-Change-Number: 26115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:29:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:29:46 +0000 Subject: Change in osmo-bsc[master]: .gitignore: remove non-existing ipaccess-firmware binary In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26116 ) Change subject: .gitignore: remove non-existing ipaccess-firmware binary ...................................................................... .gitignore: remove non-existing ipaccess-firmware binary Change-Id: I4fb706ace67216f51a8e052b0ef72d944cefd88f --- M .gitignore 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/.gitignore b/.gitignore index c637d37..0bbe478 100644 --- a/.gitignore +++ b/.gitignore @@ -48,7 +48,6 @@ src/utils/bs11_config src/ipaccess/ipaccess-config src/ipaccess/abisip-find -src/ipaccess/ipaccess-firmware src/ipaccess/ipaccess-proxy src/utils/isdnsync src/osmo-bsc_nat/osmo-bsc_nat -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4fb706ace67216f51a8e052b0ef72d944cefd88f Gerrit-Change-Number: 26116 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 21:34:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 21:34:48 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require encryption into own inline function In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require encryption into own inline function ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26108/1/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/26108/1/include/osmocom/msc/gsm_data.h at 267 PS1, Line 267: net->uea_encryption_mask Can we do it this way? return (net->uea_encryption_mask >> 1); We basically check if any bit other than the LSB is set, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 21:34:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 22:59:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 22:59:39 +0000 Subject: Change in osmo-bsc[master]: lchan_fsm: cosmetic: move a 'case' below the 'default' branch References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26118 ) Change subject: lchan_fsm: cosmetic: move a 'case' below the 'default' branch ...................................................................... lchan_fsm: cosmetic: move a 'case' below the 'default' branch It's unusual to have 'case' statements below the 'default' statement. Change-Id: I523a6d55d9a103ba69351d9dc6d0c000a422a765 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/26118/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 2f62487..64840f0 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -806,8 +806,8 @@ act_type = lchan->conn->ho.async ? RSL_ACT_INTER_ASYNC : RSL_ACT_INTER_SYNC; ho_ref = lchan->conn->ho.ho_ref; break; - default: case ACTIVATE_FOR_ASSIGNMENT: + default: act_type = RSL_ACT_INTRA_NORM_ASS; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I523a6d55d9a103ba69351d9dc6d0c000a422a765 Gerrit-Change-Number: 26118 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 22:59:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Nov 2021 22:59:40 +0000 Subject: Change in osmo-bsc[master]: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26119 ) Change subject: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS ...................................................................... rsl_tx_chan_activ(): fix manual channel activation for nanoBTS nanoBTS would NACK a CHANnel ACTIVation message for an 'intra cell channel change' if it does not contain the Timing Advance IE. And this is right, because according to 3GPP TS 48.058, section 8.4.1, point '4)', it *must* be included. Indeed, the actual Timing Advance value is not known during the manual channel activation triggered from the VTY interface. So let's merely indicate 0 if it's not known. Change-Id: Iee7ddb4cf1a9a7bb9b34e6c9f6f9899da480fbd0 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/26119/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0e2ffc6..c3825f6 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -691,6 +691,12 @@ if (bts->type == GSM_BTS_TYPE_BS11) ta <<= 2; msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta); + } else if ((act_type & 0x06) == 0x00) { + /* Note '4)' in section 8.4.1: The Timing Advance element must be + * included if activation type is intra cell channel change. */ + LOG_LCHAN(lchan, LOGL_NOTICE, "Timing Advance IE shall be present, " + "but the actual value is not known => assuming 0\n"); + msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, 0); } /* BS/MS Power Control Parameters (if supported by BTS model) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee7ddb4cf1a9a7bb9b34e6c9f6f9899da480fbd0 Gerrit-Change-Number: 26119 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 4 23:14:36 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 4 Nov 2021 23:14:36 +0000 Subject: Change in simtrace2[master]: firmware: increase dfu page size References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26120 ) Change subject: firmware: increase dfu page size ...................................................................... firmware: increase dfu page size This was never the actual flash page size of the sam3 to begin with (256), only the buffer size filled by usb transfers. Increasing this to 20K saves us some time, the flash code automatically writes page-sized areas anyway, and we have plenty of ram to spare. Change-Id: I5dfdc04070cd9cae3bec2bf28e125876dd39d72c --- M firmware/libboard/common/include/board_common.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/20/26120/1 diff --git a/firmware/libboard/common/include/board_common.h b/firmware/libboard/common/include/board_common.h index 7c4b908..35fe138 100644 --- a/firmware/libboard/common/include/board_common.h +++ b/firmware/libboard/common/include/board_common.h @@ -116,7 +116,7 @@ #define BOARD_DFU_BOOT_SIZE (16 * 1024) #define BOARD_DFU_RAM_SIZE (2 * 1024) -#define BOARD_DFU_PAGE_SIZE 512 +#define BOARD_DFU_PAGE_SIZE IFLASH_PAGE_SIZE*8*10 /** number of DFU interfaces (used to flash specific partitions) */ #define BOARD_DFU_NUM_IF 3 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I5dfdc04070cd9cae3bec2bf28e125876dd39d72c Gerrit-Change-Number: 26120 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 00:26:02 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Fri, 5 Nov 2021 00:26:02 +0000 Subject: Change in libosmocore[master]: include: add enum for UTRAN cipher In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26106 to look at the new patch set (#2). Change subject: include: add enum for UTRAN cipher ...................................................................... include: add enum for UTRAN cipher Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf --- M include/Makefile.am A include/osmocom/crypt/utran_cipher.h 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/26106/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Nov 5 00:31:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:17 +0000 Subject: Build failure of network:osmocom:nightly/rtl-sdr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b6630272_26f62ae79e4a05f0659716@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Debian_Testing/x86_64 Package network:osmocom:nightly/rtl-sdr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: [ 5s] [10/12] preinstalling mount... [ 5s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 5s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 6s] reordering...cycle: libc6 -> libgcc-s1 [ 6s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 7s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5[ 4.496138] sysrq: Changing Loglevel [ 12s] .3.18-59.24-defa[ 4.496623] sysrq: Loglevel set to 4 [ 12s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.520411] sysrq: Power Off [ 15s] [ 7.523497] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat15 failed "build rtl-sdr_0.5.4.42.d770.202111050026.dsc" at Fri Nov 5 00:31:06 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b669a297_26f62ae79e4a05f06598eb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 5s] [10/12] preinstalling mount... [ 5s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 7s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5[ 4.576264] sysrq: Changing Loglevel [ 12s] .3.18-59.24-defa[ 4.576809] sysrq: Loglevel set to 4 [ 12s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.593185] sysrq: Power Off [ 15s] [ 7.595728] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat05 failed "build osmo-python-tests_0.0.9.202111050026.dsc" at Fri Nov 5 00:31:13 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:17 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-dsp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b66c710d_26f62ae79e4a05f06599e0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-dsp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: [ 7s] [10/12] preinstalling mount... [ 7s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 8s] [12/12] preinstalling binutils... [ 8s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_15/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_15/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_15/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 5.3.18-59.24-defa[ 4.976691] sysrq: Changing Loglevel [ 15s] ult #1 SMP Mon S[ 4.977776] sysrq: Loglevel set to 4 [ 15s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] /.build/build-vm: line 632: mkswap: command not found [ 15s] swapon: /dev/vdb: read swap header failed [ 15s] ### VM INTERACTION START ### [ 18s] [ 8.013210] sysrq: Power Off [ 18s] [ 8.016562] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] sheep86 failed "build libosmodsp_0.4.0.202111050026.dsc" at Fri Nov 5 00:31:13 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:17 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b67813_26f62ae79e4a05f0660044@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/Debian_Testing/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 6s] [10/12] preinstalling mount... [ 6s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.434344] sysrq: Changing Loglevel [ 13s] .3.18-59.24-defa[ 4.435458] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.458513] sysrq: Power Off [ 16s] [ 7.462496] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat13 failed "build libsmpp34_1.14.1.202111050026.dsc" at Fri Nov 5 00:31:14 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:34 +0000 Subject: Build failure of network:osmocom:nightly/open5gs in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b856ea04_26f62ae79e4a05f0660149@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_Testing/x86_64 Package network:osmocom:nightly/open5gs failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 12s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 12s] [12/12] preinstalling binutils... [ 13s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] done [ 19s] booting kvm... [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 19s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM... [ 27s] c[?7l### VM INTERACTION END ### [ 27s] 2nd stage started in virtual machine [ 27s] machine type: x86_64 [ 27s] Linux version: 5[ 6.650475] sysrq: Changing Loglevel [ 27s] [ 6.652209] sysrq: Loglevel set to 4 [ 27s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 27s] Increasing log level from now on... [ 27s] Enable sysrq operations [ 27s] /.build/build-vm: line 632: mkswap: command not found [ 27s] swapon: /dev/vdb: read swap header failed [ 27s] ### VM INTERACTION START ### [ 30s] [ 9.708971] sysrq: Power Off [ 30s] [ 9.733712] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] cloud125 failed "build open5gs_2.3.6.202111050026.dsc" at Fri Nov 5 00:31:26 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:34 +0000 Subject: Build failure of network:osmocom:nightly/neocon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b859b32e_26f62ae79e4a05f06602c7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/neocon/Debian_Testing/x86_64 Package network:osmocom:nightly/neocon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly neocon Last lines of build log: [ 12s] [10/12] preinstalling mount... [ 12s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 13s] [12/12] preinstalling binutils... [ 13s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 25s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 25s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] Linux version: 5[ 7.352037] sysrq: Changing Loglevel [ 25s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 25s] Increasing log level from now on... [ 25s] [ 7.359591] sysrq: Loglevel set to 4 [ 25s] Enable sysrq operations [ 25s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 10.408564] sysrq: Power Off [ 28s] [ 10.422657] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb56 failed "build neocon_1.0.1.202111050026.dsc" at Fri Nov 5 00:31:27 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:34 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b8613118_26f62ae79e4a05f0660371@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/Debian_Testing/x86_64 Package network:osmocom:nightly/libasn1c failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.623034] sysrq: Changing Loglevel [ 20s] .3.18-59.24-defa[ 5.624201] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.665793] sysrq: Power Off [ 23s] [ 8.673778] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb59 failed "build libasn1c_0.9.33.202111050026.dsc" at Fri Nov 5 00:31:21 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-fl2k in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b864764a_26f62ae79e4a05f06604b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-fl2k failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: [ 12s] [10/12] preinstalling mount... [ 12s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 12s] [12/12] preinstalling binutils... [ 12s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 6.512363] sysrq: Changing Loglevel [ 22s] .3.18-59.24-defa[ 6.513264] sysrq: Loglevel set to 4 [ 22s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 9.545287] sysrq: Power Off [ 25s] [ 9.547479] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] hci-cnode2-m0 failed "build osmo-fl2k_0.1.1.28.197f.202111050026.dsc" at Fri Nov 5 00:31:23 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b868e273_26f62ae79e4a05f0660513@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.470480] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.471486] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.494890] sysrq: Power Off [ 17s] [ 7.498569] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat01 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111050026.dsc" at Fri Nov 5 00:31:45 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:51 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b86c7d76_26f62ae79e4a05f066065f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_Testing/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 12s] [10/12] preinstalling mount... [ 12s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 13s] [12/12] preinstalling binutils... [ 13s] copying packages... [ 22s] reordering...cycle: libc6 -> libgcc-s1 [ 22s] breaking dependency libgcc-s1 -> libc6 [ 22s] done [ 23s] booting kvm... [ 23s] ### VM INTERACTION START ### [ 23s] Using UART console [ 23s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 24s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 30s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 30s] 2nd stage started in virtual machine [ 30s] machine type: x86_64 [ 30s] Linux version: 5[ 6.356829] sysrq: Changing Loglevel [ 30s] .3.18-59.24-defa[ 6.358093] sysrq: Loglevel set to 4 [ 30s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 30s] Increasing log level from now on... [ 30s] Enable sysrq operations [ 30s] /.build/build-vm: line 632: mkswap: command not found [ 30s] swapon: /dev/vdb: read swap header failed [ 31s] ### VM INTERACTION START ### [ 34s] [ 9.414329] sysrq: Power Off [ 34s] [ 9.420307] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] lamb25 failed "build libgtpnl_1.2.2.202111050026.dsc" at Fri Nov 5 00:31:34 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:31:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:31:51 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847b8715583_26f62ae79e4a05f066073d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 13s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 13s] [12/12] preinstalling binutils... [ 13s] copying packages... [ 28s] reordering...cycle: libc6 -> libgcc-s1 [ 28s] breaking dependency libgcc-s1 -> libc6 [ 28s] done [ 30s] booting kvm... [ 30s] ### VM INTERACTION START ### [ 30s] Using UART console [ 30s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 30s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 30s] Booting from ROM... [ 36s] c[?7l### VM INTERACTION END ### [ 36s] 2nd stage started in virtual machine [ 36s] machine type: x86_64 [ 36s] Linux version: 5.3.18-59.24-default #1 SMP Mon S[ 5.311788] sysrq: Changing Loglevel [ 36s] [ 5.313266] sysrq: Loglevel set to 4 [ 36s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 36s] Increasing log level from now on... [ 36s] Enable sysrq operations [ 36s] /.build/build-vm: line 632: mkswap: command not found [ 36s] swapon: /dev/vdb: read swap header failed [ 36s] ### VM INTERACTION START ### [ 39s] [ 8.359052] sysrq: Power Off [ 39s] [ 8.361643] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] cloud104 failed "build libosmocore_1.5.1.269.190b.202111050026.dsc" at Fri Nov 5 00:31:36 UTC 2021. [ 39s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:08 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847ba09481b_26f62ae79e4a05f0660829@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/Debian_Testing/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 19s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 19s] [12/12] preinstalling binutils... [ 19s] copying packages... [ 30s] reordering...cycle: libc6 -> libgcc-s1 [ 30s] breaking dependency libgcc-s1 -> libc6 [ 30s] done [ 30s] booting kvm... [ 30s] ### VM INTERACTION START ### [ 30s] Using UART console [ 30s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 30s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 30s] Booting from ROM... [ 36s] c[?7l### VM INTERACTION END ### [ 36s] 2nd stage started in virtual machine [ 36s] machine type: x86_64 [ 36s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 36s] Increasing lo[ 5.499977] sysrq: Changing Loglevel [ 36s] g level from now[ 5.501955] sysrq: Loglevel set to 4 [ 36s] on... [ 36s] Enable sysrq operations [ 36s] /.build/build-vm: line 632: mkswap: command not found [ 36s] swapon: /dev/vdb: read swap header failed [ 36s] ### VM INTERACTION START ### [ 39s] [ 8.544192] sysrq: Power Off [ 39s] [ 8.547096] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] cloud122 failed "build osmocom-nightly_1.0.0.202111050026.dsc" at Fri Nov 5 00:31:52 UTC 2021. [ 39s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcap in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847ba154536_26f62ae79e4a05f066098f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcap failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: [ 5s] [10/12] preinstalling mount... [ 5s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 5s] [12/12] preinstalling binutils... [ 5s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 7s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5.3.18-59.24-defa[ 4.521591] sysrq: Changing Loglevel [ 12s] ult #1 SMP Mon S[ 4.522638] sysrq: Loglevel set to 4 [ 12s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.549780] sysrq: Power Off [ 15s] [ 7.554104] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat09 failed "build osmo-pcap_0.2.0.3.eedd.202111050026.dsc" at Fri Nov 5 00:32:19 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847ba188447_26f62ae79e4a05f0661085@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] [ 4.433081] sysrq: Changing Loglevel [ 14s] Linux version: 5[ 4.433450] sysrq: Loglevel set to 4 [ 14s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.455186] sysrq: Power Off [ 17s] [ 7.458571] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat19 failed "build osmo-ggsn_1.7.1.20.8cbd.202111050026.dsc" at Fri Nov 5 00:32:22 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-e1d in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847ba1b1914_26f62ae79e4a05f066113b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-e1d failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] [ 4.491271] sysrq: Changing Loglevel [ 15s] Linux version: 5[ 4.491728] sysrq: Loglevel set to 4 [ 15s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] /.build/build-vm: line 632: mkswap: command not found [ 15s] swapon: /dev/vdb: read swap header failed [ 15s] ### VM INTERACTION START ### [ 18s] [ 7.511660] sysrq: Power Off [ 18s] [ 7.515555] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] goat15 failed "build osmo-e1d_0.2.1.4.74fa.202111050026.dsc" at Fri Nov 5 00:32:23 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:42 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bc068fab_26f62ae79e4a05f0661319@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 8s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 11s] reordering...cycle: libc6 -> libgcc-s1 [ 11s] breaking dependency libgcc-s1 -> libc6 [ 11s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5.3.18-59.24-defa[ 4.999554] sysrq: Changing Loglevel [ 17s] [ 5.000777] sysrq: Loglevel set to 4 [ 17s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] /.build/build-vm: line 632: mkswap: command not found [ 17s] swapon: /dev/vdb: read swap header failed [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.038073] sysrq: Power Off [ 20s] [ 8.043233] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] sheep86 failed "build simtrace2_0.7.0.165.2312.202111050026.dsc" at Fri Nov 5 00:32:37 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bc09ed0c_26f62ae79e4a05f066149f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] cycle: libdevmapper1.02.1 -> dmsetup [ 13s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 13s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.24-defa[ 4.871923] sysrq: Changing Loglevel [ 19s] ult #1 SMP Mon S[ 4.872779] sysrq: Loglevel set to 4 [ 19s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 7.904015] sysrq: Power Off [ 22s] [ 7.908569] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] sheep85 failed "build osmo-pcu_0.9.0.236.858f.202111050026.dsc" at Fri Nov 5 00:32:37 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:42 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bc0d24da_26f62ae79e4a05f066155b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 11s] [10/12] preinstalling mount... [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 12s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 6.557764] sysrq: Changing Loglevel [ 22s] .3.18-59.24-defa[ 6.558775] sysrq: Loglevel set to 4 [ 22s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 9.610044] sysrq: Power Off [ 25s] [ 9.616388] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb56 failed "build libosmo-netif_1.1.0.202111050026.dsc" at Fri Nov 5 00:32:38 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bc11bf37_26f62ae79e4a05f066168@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gbproxy failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 5.585067] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 5.586167] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.631228] sysrq: Power Off [ 26s] [ 8.636168] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb27 failed "build osmo-gbproxy_0.1.0.48.2705.202111050026.dsc" at Fri Nov 5 00:32:38 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bc230284_26f62ae79e4a05f066189e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5[ 6.116521] sysrq: Changing Loglevel [ 24s] .3.18-59.24-defa[ 6.117637] sysrq: Loglevel set to 4 [ 24s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 24s] swapon: /dev/vdb: read swap header failed [ 24s] ### VM INTERACTION START ### [ 27s] [ 9.168330] sysrq: Power Off [ 27s] [ 9.175082] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb17 failed "build osmo-sip-connector_1.5.0.8.bd66.202111050026.dsc" at Fri Nov 5 00:32:49 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:59 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-abis in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bc1da7e7_26f62ae79e4a05f0661758@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: [ 14s] [10/12] preinstalling mount... [ 14s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 14s] [12/12] preinstalling binutils... [ 15s] copying packages... [ 18s] reordering...cycle: libc6 -> libgcc-s1 [ 18s] breaking dependency libgcc-s1 -> libc6 [ 18s] done [ 19s] booting kvm... [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 19s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 28s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 28s] 2nd stage started in virtual machine [ 28s] machine type: x86_64 [ 28s] [ 7.692548] sysrq: Changing Loglevel [ 28s] [ 7.693444] sysrq: Loglevel set to 4 [ 28s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 28s] Increasing log level from now on... [ 28s] Enable sysrq operations [ 28s] /.build/build-vm: line 632: mkswap: command not found [ 28s] swapon: /dev/vdb: read swap header failed [ 28s] ### VM INTERACTION START ### [ 31s] [ 10.763500] sysrq: Power Off [ 31s] [ 10.789301] reboot: Power down [ 31s] ### VM INTERACTION END ### [ 31s] [ 31s] lamb21 failed "build libosmo-abis_1.1.1.14.57ff.202111050026.dsc" at Fri Nov 5 00:32:47 UTC 2021. [ 31s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:32:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:32:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bc289d38_26f62ae79e4a05f0661985@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5[ 5.284630] sysrq: Changing Loglevel [ 24s] .3.18-59.24-defa[ 5.286415] sysrq: Loglevel set to 4 [ 24s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 24s] swapon: /dev/vdb: read swap header failed [ 24s] ### VM INTERACTION START ### [ 27s] [ 8.332765] sysrq: Power Off [ 27s] [ 8.338164] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb20 failed "build osmo-trx_1.3.1.28.019d.202111050026.dsc" at Fri Nov 5 00:32:53 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfb56fb_26f62ae79e4a05f06622e4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 5s] [12/12] preinstalling binutils... [ 5s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] cycle: libdevmapper1.02.1 -> dmsetup [ 8s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 8s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] [ 4.434636] sysrq: Changing Loglevel [ 14s] [ 4.435475] sysrq: Loglevel set to 4 [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.456224] sysrq: Power Off [ 17s] [ 7.460421] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat15 failed "build osmo-hlr_1.3.0.7.bfee.202111050026.dsc" at Fri Nov 5 00:33:21 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:33 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfac7672_26f62ae79e4a05f06621a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] cycle: libdevmapper1.02.1 -> dmsetup [ 12s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.24-defa[ 5.542111] sysrq: Changing Loglevel [ 19s] ult #1 SMP Mon S[ 5.542867] sysrq: Loglevel set to 4 [ 19s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.569809] sysrq: Power Off [ 22s] [ 8.572329] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] hci-cnode1-e5 failed "build libosmo-sccp_1.4.0.34.8aa6.202111050026.dsc" at Fri Nov 5 00:33:20 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfb31ad4_26f62ae79e4a05f06623a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.464383] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.465500] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.486172] sysrq: Power Off [ 17s] [ 7.489162] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat03 failed "build osmo-mgw_1.8.1.89.172f5.202111050026.dsc" at Fri Nov 5 00:33:21 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfb68462_26f62ae79e4a05f06624df@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.434163] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.434676] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.458786] sysrq: Power Off [ 17s] [ 7.461642] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat17 failed "build osmo-bts_1.3.0.342.333d.202111050026.dsc" at Fri Nov 5 00:33:22 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfb950a6_26f62ae79e4a05f0662557@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 5.183937] sysrq: Changing Loglevel [ 22s] [ 5.185094] sysrq: Loglevel set to 4 [ 22s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.219803] sysrq: Power Off [ 25s] [ 8.221745] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] old-atreju2 failed "build osmo-cbc_0.2.2.1.cf3c.202111050026.dsc" at Fri Nov 5 00:33:23 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-uecups in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfbc7a51_26f62ae79e4a05f0662648@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-uecups failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-uecups Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.24-defa[ 4.912085] sysrq: Changing Loglevel [ 22s] ult #1 SMP Mon S[ 4.913418] sysrq: Loglevel set to 4 [ 22s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.005684] sysrq: Power Off [ 25s] [ 8.013030] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] old-cirrus2 failed "build osmo-uecups_0.1.3.2.0ac9.202111050026.dsc" at Fri Nov 5 00:33:25 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfc88f4_26f62ae79e4a05f0662768@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sysmon Last lines of build log: [ 11s] [10/12] preinstalling mount... [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 7.008650] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 7.009901] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 10.109404] sysrq: Power Off [ 26s] [ 10.140887] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb09 failed "build osmo-sysmon_0.3.0.3.0d9d.202111050026.dsc" at Fri Nov 5 00:33:26 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:33:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:33:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847bfd15344_26f62ae79e4a05f06630bf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5[ 5.957913] sysrq: Changing Loglevel [ 24s] .3.18-59.24-defa[ 5.959407] sysrq: Loglevel set to 4 [ 24s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 24s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 9.004501] sysrq: Power Off [ 28s] [ 9.009201] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb21 failed "build osmo-remsim_0.2.2.113.eb9f.202111050026.dsc" at Fri Nov 5 00:33:44 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:34:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:34:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847c1c1d3b1_26f62ae79e4a05f06632b7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 5.446722] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 5.447692] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.498558] sysrq: Power Off [ 27s] [ 8.506093] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb21 failed "build osmo-smlc_0.2.0.2.ec37.202111050026.dsc" at Fri Nov 5 00:34:06 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:34:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:34:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847c37cb29a_26f62ae79e4a05f066348f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 11s] copying packages... [ 27s] reordering...cycle: libc6 -> libgcc-s1 [ 27s] breaking dependency libgcc-s1 -> libc6 [ 27s] cycle: libdevmapper1.02.1 -> dmsetup [ 27s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 27s] done [ 32s] booting kvm... [ 32s] ### VM INTERACTION START ### [ 32s] Using UART console [ 32s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 32s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 32s] Booting from ROM... [ 38s] c[?7l### VM INTERACTION END ### [ 38s] 2nd stage started in virtual machine [ 38s] machine type: x86_64 [ 38s] Linux version: 5[ 5.585610] sysrq: Changing Loglevel [ 38s] .3.18-59.24-defa[ 5.587732] sysrq: Loglevel set to 4 [ 38s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 38s] Increasing log level from now on... [ 38s] Enable sysrq operations [ 38s] /.build/build-vm: line 632: mkswap: command not found [ 38s] swapon: /dev/vdb: read swap header failed [ 38s] ### VM INTERACTION START ### [ 41s] [ 8.652235] sysrq: Power Off [ 41s] [ 8.660207] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] cloud138 failed "build osmo-iuh_0.7.0.26.e321.202111050026.dsc" at Fri Nov 5 00:34:24 UTC 2021. [ 41s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:34:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:34:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847c382d122_26f62ae79e4a05f06635e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 13s] [12/12] preinstalling binutils... [ 13s] copying packages... [ 21s] reordering...cycle: libc6 -> libgcc-s1 [ 21s] breaking dependency libgcc-s1 -> libc6 [ 21s] cycle: libdevmapper1.02.1 -> dmsetup [ 21s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 21s] done [ 22s] booting kvm... [ 22s] ### VM INTERACTION START ### [ 22s] Using UART console [ 22s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 22s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 31s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: x86_64 [ 31s] Linux version: 5[ 8.454858] sysrq: Changing Loglevel [ 31s] .3.18-59.24-defa[ 8.455961] sysrq: Loglevel set to 4 [ 31s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 31s] Increasing log level from now on... [ 31s] Enable sysrq operations [ 31s] /.build/build-vm: line 632: mkswap: command not found [ 31s] swapon: /dev/vdb: read swap header failed [ 31s] ### VM INTERACTION START ### [ 34s] [ 11.532491] sysrq: Power Off [ 34s] [ 11.537278] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] lamb26 failed "build osmo-bsc_1.7.0.315.0650.202111050026.dsc" at Fri Nov 5 00:34:32 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:34:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:34:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847c3887781_26f62ae79e4a05f06636c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.407630] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.408637] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.430529] sysrq: Power Off [ 17s] [ 7.434598] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat01 failed "build osmo-hnodeb_0.0.0.202111050026.dsc" at Fri Nov 5 00:34:52 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:34:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:34:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847c38b2e34_26f62ae79e4a05f0663787@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] [ 4.400402] sysrq: Changing Loglevel [ 14s] [ 4.400789] sysrq: Loglevel set to 4 [ 14s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.419526] sysrq: Power Off [ 17s] [ 7.423596] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat13 failed "build osmo-msc_1.7.0.37.efa6c.202111050026.dsc" at Fri Nov 5 00:34:53 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:35:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:35:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61847c7595c7c_26f62ae79e4a05f06638a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 312s] # we create a symlink at ./srcfile.adoc pointing at [ 312s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 312s] # is like basename from coreutils, and . is WD. [ 312s] if ! [ -f test-usermanual.adoc ]; then \ [ 312s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 312s] fi [ 312s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 312s] # in ... [ 312s] TEXINPUTS=".." \ [ 312s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 312s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 312s] a2x: resource files: [] [ 312s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 312s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 312s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 312s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 312s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 312s] make[1]: *** [Makefile:363: all] Error 2 [ 312s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 312s] dh_auto_build: error: make -j1 returned exit code 2 [ 312s] make: *** [debian/rules:5: binary] Error 25 [ 312s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 312s] ### VM INTERACTION START ### [ 313s] Powering off. [ 313s] [ 289.798298] reboot: Power down [ 313s] ### VM INTERACTION END ### [ 313s] [ 313s] wildcard2 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111050026.dsc" at Fri Nov 5 00:35:40 UTC 2021. [ 313s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:35:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:35:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61847c75ee1d3_26f62ae79e4a05f066391b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 31s] [12/12] preinstalling binutils... [ 31s] copying packages... [ 50s] reordering...cycle: libc6 -> libgcc-s1 [ 50s] breaking dependency libgcc-s1 -> libc6 [ 50s] cycle: libdevmapper1.02.1 -> dmsetup [ 50s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 50s] done [ 51s] booting kvm... [ 51s] ### VM INTERACTION START ### [ 51s] Using UART console [ 51s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_15/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_15/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_15/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 51s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 59s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 59s] 2nd stage started in virtual machine [ 59s] machine type: x86_64 [ 59s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 59s] Increasing log level from now on... [ 59s] [ 6.584367] sysrq: Changing Loglevel [ 59s] [ 6.585175] sysrq: Loglevel set to 4 [ 59s] Enable sysrq operations [ 59s] /.build/build-vm: line 632: mkswap: command not found [ 59s] swapon: /dev/vdb: read swap header failed [ 59s] ### VM INTERACTION START ### [ 62s] [ 9.646784] sysrq: Power Off [ 62s] [ 9.652365] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] lamb04 failed "build osmo-sgsn_1.7.0.27.2d0e2.202111050026.dsc" at Fri Nov 5 00:35:48 UTC 2021. [ 62s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 00:41:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 00:41:30 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61847dbee90e_26f62ae79e4a05f0664378@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 179s] | #define HAVE_SYS_STAT_H 1 [ 179s] | #define HAVE_SYS_TYPES_H 1 [ 179s] | #define HAVE_UNISTD_H 1 [ 179s] | #define STDC_HEADERS 1 [ 179s] | #define HAVE_DLFCN_H 1 [ 179s] | #define LT_OBJDIR ".libs/" [ 179s] | #define HAVE_EXECINFO_H 1 [ 179s] | #define HAVE_SYS_SELECT_H 1 [ 179s] | #define HAVE_SYS_SOCKET_H 1 [ 179s] | #define HAVE_SYSLOG_H 1 [ 179s] | #define HAVE_CTYPE_H 1 [ 179s] | #define HAVE_NETINET_SCTP_H 1 [ 179s] | #define HAVE_LIBOSMOCORE 1 [ 179s] | #define HAVE_LIBSCTP 1 [ 179s] | #define HAVE_PCAP_H 1 [ 179s] | [ 179s] | configure: exit 0 [ 179s] [ 179s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 179s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 179s] make: *** [debian/rules:13: build] Error 2 [ 179s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 179s] ### VM INTERACTION START ### [ 182s] [ 166.277646] sysrq: Power Off [ 182s] [ 166.283150] reboot: Power down [ 182s] ### VM INTERACTION END ### [ 182s] [ 182s] lamb60 failed "build libosmo-netif_1.1.0.202111050026.dsc" at Fri Nov 5 00:41:15 UTC 2021. [ 182s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Nov 5 01:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 01:42:36 +0000 Subject: Change in libosmocore[master]: include: add enum for UTRAN cipher In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26106 ) Change subject: include: add enum for UTRAN cipher ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 01:42:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 01:54:36 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Fri, 5 Nov 2021 01:54:36 +0000 Subject: Change in osmo-msc[master]: utran: use new UTRAN encryption enum In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26107 to look at the new patch set (#2). Change subject: utran: use new UTRAN encryption enum ...................................................................... utran: use new UTRAN encryption enum Depends: libosmocore.git I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa --- M src/libmsc/gsm_04_08.c M src/libmsc/msc_net_init.c M src/libmsc/ran_msg_iu.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_tests.h 5 files changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/07/26107/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa Gerrit-Change-Number: 26107 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 01:54:36 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Fri, 5 Nov 2021 01:54:36 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require encryption into own function In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 to look at the new patch set (#2). Change subject: libmsc/gsm_04_08: refactor require encryption into own function ...................................................................... libmsc/gsm_04_08: refactor require encryption into own function Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 4 files changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/08/26108/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Nov 5 03:32:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:31 +0000 Subject: Build failure of network:osmocom:latest/libsmpp34 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5d42e4db_26f62ae79e4a05f0682426@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsmpp34/Debian_Testing/x86_64 Package network:osmocom:latest/libsmpp34 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libsmpp34 Last lines of build log: [ 5s] [10/12] preinstalling mount... [ 5s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 5s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 7s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5[ 4.418690] sysrq: Changing Loglevel [ 12s] .3.18-59.24-defa[ 4.419732] sysrq: Loglevel set to 4 [ 12s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.440933] sysrq: Power Off [ 15s] [ 7.444841] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat15 failed "build libsmpp34_1.14.1.dsc" at Fri Nov 5 03:32:28 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:31 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5d4bef9a_26f62ae79e4a05f0682512@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/Debian_Testing/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 6s] [10/12] preinstalling mount... [ 6s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5.3.18-59.24-defa[ 4.412477] sysrq: Changing Loglevel [ 12s] ult #1 SMP Mon S[ 4.413374] sysrq: Loglevel set to 4 [ 12s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.436223] sysrq: Power Off [ 15s] [ 7.440185] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat03 failed "build libsmpp34_1.14.1.202111050026.dsc" at Fri Nov 5 03:32:29 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:nightly/orcania in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5ee84753_26f62ae79e4a05f0682692@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/Debian_Testing/x86_64 Package network:osmocom:nightly/orcania failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.24-defa[ 5.626407] sysrq: Changing Loglevel [ 20s] ult #1 SMP Mon S[ 5.627423] sysrq: Loglevel set to 4 [ 20s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.678614] sysrq: Power Off [ 23s] [ 8.684715] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb26 failed "build orcania_1.2.9-5.dsc" at Fri Nov 5 03:32:42 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:nightly/rtl-sdr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5ef18654_26f62ae79e4a05f06829d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Debian_Testing/x86_64 Package network:osmocom:nightly/rtl-sdr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.543829] sysrq: Changing Loglevel [ 19s] .3.18-59.24-defa[ 5.545097] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.593172] sysrq: Power Off [ 22s] [ 8.599520] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb60 failed "build rtl-sdr_0.5.4.42.d770.202111050026.dsc" at Fri Nov 5 03:32:43 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5ef4a7a2_26f62ae79e4a05f06830a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.496927] sysrq: Changing Loglevel [ 19s] .3.18-59.24-defa[ 5.499401] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.542886] sysrq: Power Off [ 22s] [ 8.550461] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb59 failed "build libosmocore_1.5.1.269.190b.202111050026.dsc" at Fri Nov 5 03:32:43 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:nightly/osmo-fl2k in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5ef7354c_26f62ae79e4a05f0683151@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-fl2k failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.24-defa[ 5.584714] sysrq: Changing Loglevel [ 19s] ult #1 SMP Mon Sep 13 15:06:42 U[ 5.587307] sysrq: Loglevel set to 4 [ 19s] TC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.636565] sysrq: Power Off [ 22s] [ 8.643894] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb53 failed "build osmo-fl2k_0.1.1.28.197f.202111050026.dsc" at Fri Nov 5 03:32:43 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5efbf5a7_26f62ae79e4a05f06832b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] [ 4.396229] sysrq: Changing Loglevel [ 14s] [ 4.397013] sysrq: Loglevel set to 4 [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.419990] sysrq: Power Off [ 17s] [ 7.424036] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat17 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Fri Nov 5 03:32:44 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:latest/orcania in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f013d1d_26f62ae79e4a05f06833f6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/Debian_Testing/x86_64 Package network:osmocom:latest/orcania failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 5.016239] sysrq: Changing Loglevel [ 18s] .3.18-59.24-defa[ 5.017558] sysrq: Loglevel set to 4 [ 18s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.051684] sysrq: Power Off [ 21s] [ 8.053647] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] old-atreju2 failed "build orcania_1.2.9-5.dsc" at Fri Nov 5 03:32:35 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:latest/open5gs in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f046a93_26f62ae79e4a05f068341a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/open5gs/Debian_Testing/x86_64 Package network:osmocom:latest/open5gs failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest open5gs Last lines of build log: [ 5s] [10/12] preinstalling mount... [ 5s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 5s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5[ 4.408858] sysrq: Changing Loglevel [ 12s] .3.18-59.24-defa[ 4.409933] sysrq: Loglevel set to 4 [ 12s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.430624] sysrq: Power Off [ 15s] [ 7.434604] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat01 failed "build open5gs_2.3.6.dsc" at Fri Nov 5 03:32:35 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-dsp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f0b14bd_26f62ae79e4a05f0683643@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-dsp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: [ 11s] [10/12] preinstalling mount... [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5[ 5.837753] sysrq: Changing Loglevel [ 21s] .3.18-59.24-defa[ 5.838837] sysrq: Loglevel set to 4 [ 21s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] /.build/build-vm: line 632: mkswap: command not found [ 21s] swapon: /dev/vdb: read swap header failed [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.890243] sysrq: Power Off [ 24s] [ 8.895801] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb23 failed "build libosmodsp_0.4.0.202111050026.dsc" at Fri Nov 5 03:32:46 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:latest/libgtpnl in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f131f3f_26f62ae79e4a05f068374a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libgtpnl/Debian_Testing/x86_64 Package network:osmocom:latest/libgtpnl failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libgtpnl Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 6.031450] sysrq: Changing Loglevel [ 20s] .3.18-59.24-defa[ 6.032520] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 9.076135] sysrq: Power Off [ 23s] [ 9.081349] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb25 failed "build libgtpnl_1.2.2.dsc" at Fri Nov 5 03:32:38 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:nightly/open5gs in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f080f30_26f62ae79e4a05f0683512@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_Testing/x86_64 Package network:osmocom:nightly/open5gs failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 6s] [10/12] preinstalling mount... [ 6s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 6s] [12/12] preinstalling binutils... [ 7s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5.3.18-59.24-defa[ 5.093564] sysrq: Changing Loglevel [ 14s] ult #1 SMP Mon S[ 5.094281] sysrq: Loglevel set to 4 [ 14s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 8.117417] sysrq: Power Off [ 17s] [ 8.119361] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] hci-cnode1-e5 failed "build open5gs_2.3.6.202111050026.dsc" at Fri Nov 5 03:32:46 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:latest/limesuite in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f1da269_26f62ae79e4a05f0683975@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/limesuite/Debian_Testing/x86_64 Package network:osmocom:latest/limesuite failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest limesuite Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] cycle: libdevmapper1.02.1 -> dmsetup [ 8s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 8s] done [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.360597] sysrq: Changing Loglevel [ 13s] .3.18-59.24-defa[ 4.361177] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] /.build/build-vm: line 632: mkswap: command not found [ 13s] swapon: /dev/vdb: read swap header failed [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.382533] sysrq: Power Off [ 16s] [ 7.387091] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat19 failed "build limesuite_20.10.0-1.dsc" at Fri Nov 5 03:32:31 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:latest/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f1a971c_26f62ae79e4a05f06838fb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_Testing/x86_64 Package network:osmocom:latest/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.24-default #1 SMP Mon S[ 5.358048] sysrq: Changing Loglevel [ 19s] ep 13 15:06:42 U[ 5.359478] sysrq: Loglevel set to 4 [ 19s] TC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.402404] sysrq: Power Off [ 22s] [ 8.409835] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb51 failed "build libosmocore_1.5.2.dsc" at Fri Nov 5 03:32:40 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:latest/libosmo-dsp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f24250b_26f62ae79e4a05f068416b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-dsp/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-dsp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-dsp Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] [ 5.361717] sysrq: Changing Loglevel [ 18s] Linux version: 5[ 5.363702] sysrq: Loglevel set to 4 [ 18s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.409085] sysrq: Power Off [ 21s] [ 8.417404] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb27 failed "build libosmodsp_0.4.0.dsc" at Fri Nov 5 03:32:40 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:32:48 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a5f2158c1_26f62ae79e4a05f06840ab@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_Testing/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 5.449013] sysrq: Changing Loglevel [ 18s] .3.18-59.24-defa[ 5.450611] sysrq: Loglevel set to 4 [ 18s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.494707] sysrq: Power Off [ 21s] [ 8.518901] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb21 failed "build libgtpnl_1.2.2.202111050026.dsc" at Fri Nov 5 03:32:40 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:05 +0000 Subject: Build failure of network:osmocom:latest/yder in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a60c29a1b_26f62ae79e4a05f06843ab@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/yder/Debian_Testing/x86_64 Package network:osmocom:latest/yder failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest yder Last lines of build log: [ 5s] [10/12] preinstalling mount... [ 5s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 5s] [12/12] preinstalling binutils... [ 5s] copying packages... [ 7s] reordering...cycle: libc6 -> libgcc-s1 [ 7s] breaking dependency libgcc-s1 -> libc6 [ 7s] done [ 7s] booting kvm... [ 7s] ### VM INTERACTION START ### [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 7s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] [ 4.472344] sysrq: Changing Loglevel [ 12s] Linux version: 5[ 4.472707] sysrq: Loglevel set to 4 [ 12s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] /.build/build-vm: line 632: mkswap: command not found [ 12s] swapon: /dev/vdb: read swap header failed [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.493214] sysrq: Power Off [ 15s] [ 7.496837] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat01 failed "build yder_1.4.4-4.1.dsc" at Fri Nov 5 03:33:02 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a60c5d0bb_26f62ae79e4a05f068443b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.24-defa[ 5.261936] sysrq: Changing Loglevel [ 21s] ult #1 SMP Mon S[ 5.264222] sysrq: Loglevel set to 4 [ 21s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] /.build/build-vm: line 632: mkswap: command not found [ 21s] swapon: /dev/vdb: read swap header failed [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.310447] sysrq: Power Off [ 24s] [ 8.317685] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb58 failed "build osmo-gsm-manuals-dev_1.1.0.17.b92c.202111050026.dsc" at Fri Nov 5 03:33:03 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:05 +0000 Subject: Build failure of network:osmocom:latest/eclipse-titan in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a60c8ddc5_26f62ae79e4a05f0684579@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/Debian_Testing/x86_64 Package network:osmocom:latest/eclipse-titan failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest eclipse-titan Last lines of build log: [ 8s] [12/12] preinstalling binutils... [ 8s] copying packages... [ 10s] reordering...cycle: libc6 -> libgcc-s1 [ 10s] breaking dependency libgcc-s1 -> libc6 [ 10s] cycle: default-jre-headless -> openjdk-11-jre-headless -> ca-certificates-java [ 10s] breaking dependency openjdk-11-jre-headless -> ca-certificates-java [ 10s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 11s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 16s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 16s] 2nd stage started in virtual machine [ 16s] machine type: x86_64 [ 16s] Linux version: 5.3.18-59.24-defa[ 5.463911] sysrq: Changing Loglevel [ 16s] ult #1 SMP Mon S[ 5.464632] sysrq: Loglevel set to 4 [ 16s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 16s] Increasing log level from now on... [ 16s] Enable sysrq operations [ 16s] /.build/build-vm: line 632: mkswap: command not found [ 16s] swapon: /dev/vdb: read swap header failed [ 16s] ### VM INTERACTION START ### [ 20s] [ 8.491506] sysrq: Power Off [ 20s] [ 8.493482] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] hci-cnode2-m0 failed "build eclipse-titan_8.0.0-1.dsc" at Fri Nov 5 03:32:48 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a60ee4d9f_26f62ae79e4a05f068519b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.451813] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.452840] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.474097] sysrq: Power Off [ 17s] [ 7.477770] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat03 failed "build osmo-ggsn_1.7.1.dsc" at Fri Nov 5 03:33:20 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-abis in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62e2f094_26f62ae79e4a05f0685384@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.369261] sysrq: Changing Loglevel [ 19s] [ 5.371163] sysrq: Loglevel set to 4 [ 19s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.414764] sysrq: Power Off [ 22s] [ 8.422034] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb51 failed "build libosmo-abis_1.1.1.14.57ff.202111050026.dsc" at Fri Nov 5 03:33:31 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62dd6544_26f62ae79e4a05f0685236@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-pcap failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5.3.18-59.24-defa[ 5.274896] sysrq: Changing Loglevel [ 18s] ult #1 SMP Mon S[ 5.275980] sysrq: Loglevel set to 4 [ 18s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.318141] sysrq: Power Off [ 21s] [ 8.325657] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb27 failed "build osmo-pcap_0.2.0.dsc" at Fri Nov 5 03:33:31 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcap in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62e57d15_26f62ae79e4a05f0685473@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcap failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] [ 5.457391] sysrq: Changing Loglevel [ 18s] Linux version: 5[ 5.458173] sysrq: Loglevel set to 4 [ 18s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.499288] sysrq: Power Off [ 21s] [ 8.517226] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb54 failed "build osmo-pcap_0.2.0.3.eedd.202111050026.dsc" at Fri Nov 5 03:33:32 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62e90058_26f62ae79e4a05f068557b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/Debian_Testing/x86_64 Package network:osmocom:latest/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 7s] [10/12] preinstalling mount... [ 7s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 7s] [12/12] preinstalling binutils... [ 7s] copying packages... [ 8s] reordering...cycle: libc6 -> libgcc-s1 [ 8s] breaking dependency libgcc-s1 -> libc6 [ 8s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 18432 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 16 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 5[ 5.931059] sysrq: Changing Loglevel [ 15s] .3.18-59.24-defa[ 5.932775] sysrq: Loglevel set to 4 [ 15s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] /.build/build-vm: line 632: mkswap: command not found [ 15s] swapon: /dev/vdb: read swap header failed [ 15s] ### VM INTERACTION START ### [ 18s] [ 8.970421] sysrq: Power Off [ 18s] [ 8.980104] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] sheep83 failed "build simtrace2_0.5.2.dsc" at Fri Nov 5 03:33:33 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62ec5f8c_26f62ae79e4a05f06856a2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] [ 5.272146] sysrq: Changing Loglevel [ 22s] Linux version: 5[ 5.273755] sysrq: Loglevel set to 4 [ 22s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.330372] sysrq: Power Off [ 25s] [ 8.337776] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb61 failed "build osmo-gbproxy_0.1.2.dsc" at Fri Nov 5 03:33:34 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62f57a5_26f62ae79e4a05f068578c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-netif failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 6.952445] sysrq: Changing Loglevel [ 20s] .3.18-59.24-defa[ 6.953411] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 10.010318] sysrq: Power Off [ 23s] [ 10.016042] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb60 failed "build libosmo-netif_1.1.0.dsc" at Fri Nov 5 03:33:34 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62f3082d_26f62ae79e4a05f0685864@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] [ 5.612785] sysrq: Changing Loglevel [ 22s] [ 5.614463] sysrq: Loglevel set to 4 [ 22s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 26s] [ 8.660966] sysrq: Power Off [ 26s] [ 8.667156] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb26 failed "build osmo-sip-connector_1.5.1.dsc" at Fri Nov 5 03:33:36 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62f62ef6_26f62ae79e4a05f06859a1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5[ 5.851546] sysrq: Changing Loglevel [ 24s] .3.18-59.24-defa[ 5.852927] sysrq: Loglevel set to 4 [ 24s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 24s] swapon: /dev/vdb: read swap header failed [ 24s] ### VM INTERACTION START ### [ 27s] [ 8.894421] sysrq: Power Off [ 27s] [ 8.902362] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb57 failed "build osmo-pcu_0.9.1.dsc" at Fri Nov 5 03:33:36 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a62fa2180_26f62ae79e4a05f068603d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-abis failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 11s] [10/12] preinstalling mount... [ 11s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 12s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5[ 7.934188] sysrq: Changing Loglevel [ 24s] .3.18-59.24-defa[ 7.935156] sysrq: Loglevel set to 4 [ 24s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 10.999168] sysrq: Power Off [ 28s] [ 11.009694] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb56 failed "build libosmo-abis_1.1.1.dsc" at Fri Nov 5 03:33:38 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:nightly/yder in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6301a0f_26f62ae79e4a05f0686122@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/yder/Debian_Testing/x86_64 Package network:osmocom:nightly/yder failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly yder Last lines of build log: [ 10s] [10/12] preinstalling mount... [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] [ 5.448852] sysrq: Changing Loglevel [ 19s] [ 5.449627] sysrq: Loglevel set to 4 [ 19s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.503867] sysrq: Power Off [ 22s] [ 8.511150] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb53 failed "build yder_1.4.4-4.1.dsc" at Fri Nov 5 03:33:23 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:39 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a630a3e7d_26f62ae79e4a05f06863a3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 7s] [10/12] preinstalling mount... [ 7s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 8s] [12/12] preinstalling binutils... [ 8s] copying packages... [ 10s] reordering...cycle: libc6 -> libgcc-s1 [ 10s] breaking dependency libgcc-s1 -> libc6 [ 10s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 18432 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 16 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 16s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 16s] 2nd stage started in virtual machine [ 16s] machine type: x86_64 [ 16s] Linux version: 5[ 5.790896] sysrq: Changing Loglevel [ 16s] .3.18-59.24-defa[ 5.792383] sysrq: Loglevel set to 4 [ 16s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 16s] Increasing log level from now on... [ 16s] Enable sysrq operations [ 16s] /.build/build-vm: line 632: mkswap: command not found [ 16s] swapon: /dev/vdb: read swap header failed [ 16s] ### VM INTERACTION START ### [ 19s] [ 8.826061] sysrq: Power Off [ 19s] [ 8.836204] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] sheep81 failed "build libosmo-netif_1.1.0.202111050026.dsc" at Fri Nov 5 03:33:30 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:56 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a630d960b_26f62ae79e4a05f068641b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Testing/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] cycle: dmsetup -> libdevmapper1.02.1 [ 12s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.343090] sysrq: Changing Loglevel [ 19s] .3.18-59.24-defa[ 5.344889] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.388393] sysrq: Power Off [ 22s] [ 8.396768] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb08 failed "build ulfius_2.5.2-4.2.dsc" at Fri Nov 5 03:33:54 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6312dc52_26f62ae79e4a05f06865d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 19s] booting kvm... [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 19s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] Linux version: 5[ 5.397026] sysrq: Changing Loglevel [ 25s] .3.18-59.24-defa[ 5.398026] sysrq: Loglevel set to 4 [ 25s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 25s] Increasing log level from now on... [ 25s] Enable sysrq operations [ 25s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 8.441066] sysrq: Power Off [ 28s] [ 8.448077] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb55 failed "build osmo-trx_1.3.1.dsc" at Fri Nov 5 03:33:44 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:56 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a631d7a64_26f62ae79e4a05f068673a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gbproxy failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] cycle: libdevmapper1.02.1 -> dmsetup [ 12s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 4.863406] sysrq: Changing Loglevel [ 18s] .3.18-59.24-defa[ 4.864064] sysrq: Loglevel set to 4 [ 18s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.897942] sysrq: Power Off [ 21s] [ 7.902961] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] sheep86 failed "build osmo-gbproxy_0.1.0.48.2705.202111050026.dsc" at Fri Nov 5 03:33:53 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:33:56 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6315e355_26f62ae79e4a05f0686623@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Testing/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 9s] [10/12] preinstalling mount... [ 9s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] done [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.451068] sysrq: Changing Loglevel [ 19s] [ 5.452989] sysrq: Loglevel set to 4 [ 19s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] /.build/build-vm: line 632: mkswap: command not found [ 19s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.498490] sysrq: Power Off [ 22s] [ 8.502767] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb18 failed "build simtrace2_0.7.0.165.2312.202111050026.dsc" at Fri Nov 5 03:33:44 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-e1d in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64b4c53e_26f62ae79e4a05f0686851@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-e1d failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] [ 5.484893] sysrq: Changing Loglevel [ 24s] [ 5.485679] sysrq: Loglevel set to 4 [ 24s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 24s] swapon: /dev/vdb: read swap header failed [ 24s] ### VM INTERACTION START ### [ 27s] [ 8.528642] sysrq: Power Off [ 27s] [ 8.534911] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb02 failed "build osmo-e1d_0.2.1.4.74fa.202111050026.dsc" at Fri Nov 5 03:33:59 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64bbcb10_26f62ae79e4a05f0687066@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 5.631918] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 5.633181] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.676289] sysrq: Power Off [ 26s] [ 8.681160] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb09 failed "build osmo-sip-connector_1.5.0.8.bd66.202111050026.dsc" at Fri Nov 5 03:34:01 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64b7d1f6_26f62ae79e4a05f068697a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 5.671703] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 5.672741] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.733427] sysrq: Power Off [ 26s] [ 8.738616] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb17 failed "build osmo-pcu_0.9.0.236.858f.202111050026.dsc" at Fri Nov 5 03:34:00 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64c2141a_26f62ae79e4a05f06871fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5.3.18-59.24-defa[ 5.321876] sysrq: Changing Loglevel [ 24s] ult #1 SMP Mon S[ 5.323381] sysrq: Loglevel set to 4 [ 24s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] /.build/build-vm: line 632: mkswap: command not found [ 24s] swapon: /dev/vdb: read swap header failed [ 24s] ### VM INTERACTION START ### [ 27s] [ 8.365762] sysrq: Power Off [ 27s] [ 8.373338] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb05 failed "build osmo-trx_1.3.1.28.019d.202111050026.dsc" at Fri Nov 5 03:34:05 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:13 +0000 Subject: Build failure of network:osmocom:latest/osmo-e1d in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64c6a9cb_26f62ae79e4a05f068720@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-e1d/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-e1d failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-e1d Last lines of build log: [ 14s] copying packages... [ 35s] reordering...cycle: libc6 -> libgcc-s1 [ 35s] breaking dependency libgcc-s1 -> libc6 [ 35s] cycle: libdevmapper1.02.1 -> dmsetup [ 35s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 35s] done [ 39s] booting kvm... [ 39s] ### VM INTERACTION START ### [ 39s] Using UART console [ 39s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 40s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 41s] Booting from ROM... [ 47s] c[?7l### VM INTERACTION END ### [ 47s] 2nd stage started in virtual machine [ 47s] machine type: x86_64 [ 47s] Linux version: 5.3.18-59.24-defa[ 5.776190] sysrq: Changing Loglevel [ 47s] ult #1 SMP Mon S[ 5.777829] sysrq: Loglevel set to 4 [ 47s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 47s] Increasing log level from now on... [ 47s] Enable sysrq operations [ 47s] /.build/build-vm: line 632: mkswap: command not found [ 47s] swapon: /dev/vdb: read swap header failed [ 47s] ### VM INTERACTION START ### [ 51s] [ 8.828113] sysrq: Power Off [ 51s] [ 8.843328] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] cloud125 failed "build osmo-e1d_0.2.1.dsc" at Fri Nov 5 03:34:07 UTC 2021. [ 51s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64cb1e1f_26f62ae79e4a05f068737d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] cycle: libdevmapper1.02.1 -> dmsetup [ 17s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 17s] done [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 25s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 25s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] Linux version: 5[ 6.378374] sysrq: Changing Loglevel [ 25s] .3.18-59.24-defa[ 6.380063] sysrq: Loglevel set to 4 [ 25s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 25s] Increasing log level from now on... [ 25s] Enable sysrq operations [ 25s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 9.445000] sysrq: Power Off [ 28s] [ 9.451634] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb13 failed "build osmo-ggsn_1.7.1.20.8cbd.202111050026.dsc" at Fri Nov 5 03:34:08 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:30 +0000 Subject: Build failure of network:osmocom:nightly/osmo-uecups in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64d354d4_26f62ae79e4a05f068750@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-uecups failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-uecups Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.24-defa[ 5.401585] sysrq: Changing Loglevel [ 21s] [ 5.403402] sysrq: Loglevel set to 4 [ 21s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] /.build/build-vm: line 632: mkswap: command not found [ 21s] swapon: /dev/vdb: read swap header failed [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.453911] sysrq: Power Off [ 24s] [ 8.459789] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb25 failed "build osmo-uecups_0.1.3.2.0ac9.202111050026.dsc" at Fri Nov 5 03:34:14 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64cdb4ef_26f62ae79e4a05f068747d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sysmon Last lines of build log: [ 10s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 13s] reordering...cycle: libc6 -> libgcc-s1 [ 13s] breaking dependency libgcc-s1 -> libc6 [ 13s] done [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM... [ 20s] c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.24-defa[ 5.195957] sysrq: Changing Loglevel [ 20s] ult #1 SMP Mon S[ 5.197958] sysrq: Loglevel set to 4 [ 20s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] /.build/build-vm: line 632: mkswap: command not found [ 20s] swapon: /dev/vdb: read swap header failed [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.248388] sysrq: Power Off [ 23s] [ 8.251304] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] cloud122 failed "build osmo-sysmon_0.3.0.3.0d9d.202111050026.dsc" at Fri Nov 5 03:34:10 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:30 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64d930fb_26f62ae79e4a05f06877fb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.404896] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.406021] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.427566] sysrq: Power Off [ 17s] [ 7.431792] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat17 failed "build osmo-hlr_1.3.0.7.bfee.202111050026.dsc" at Fri Nov 5 03:34:18 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:30 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a64dd1fda_26f62ae79e4a05f06878b9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 12s] copying packages... [ 19s] reordering...cycle: libc6 -> libgcc-s1 [ 19s] breaking dependency libgcc-s1 -> libc6 [ 19s] cycle: libdevmapper1.02.1 -> dmsetup [ 19s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 19s] done [ 23s] booting kvm... [ 23s] ### VM INTERACTION START ### [ 23s] Using UART console [ 23s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 23s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM... [ 29s] c[?7l### VM INTERACTION END ### [ 29s] 2nd stage started in virtual machine [ 29s] machine type: x86_64 [ 29s] [ 5.330457] sysrq: Changing Loglevel [ 29s] [ 5.332023] sysrq: Loglevel set to 4 [ 29s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 29s] Increasing log level from now on... [ 29s] Enable sysrq operations [ 29s] /.build/build-vm: line 632: mkswap: command not found [ 29s] swapon: /dev/vdb: read swap header failed [ 29s] ### VM INTERACTION START ### [ 32s] [ 8.375102] sysrq: Power Off [ 32s] [ 8.378156] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] cloud105 failed "build libosmo-sccp_1.4.0.34.8aa6.202111050026.dsc" at Fri Nov 5 03:34:19 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6534ddec_26f62ae79e4a05f0687936@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 7s] [10/12] preinstalling mount... [ 7s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 8s] [12/12] preinstalling binutils... [ 8s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] done [ 10s] booting kvm... [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 18432 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 16 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 16s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 16s] 2nd stage started in virtual machine [ 16s] machine type: x86_64 [ 16s] Linux version: 5[ 5.840107] sysrq: Changing Loglevel [ 16s] .3.18-59.24-defa[ 5.841731] sysrq: Loglevel set to 4 [ 16s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 16s] Increasing log level from now on... [ 16s] Enable sysrq operations [ 16s] /.build/build-vm: line 632: mkswap: command not found [ 16s] swapon: /dev/vdb: read swap header failed [ 16s] ### VM INTERACTION START ### [ 19s] [ 8.876603] sysrq: Power Off [ 19s] [ 8.885862] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] sheep82 failed "build osmo-sysmon_0.3.0.dsc" at Fri Nov 5 03:34:23 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:30 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6541a417_26f62ae79e4a05f06882f2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Testing/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 11s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: dmsetup -> libdevmapper1.02.1 [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM... [ 22s] c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.24-defa[ 5.368933] sysrq: Changing Loglevel [ 22s] ult #1 SMP Mon S[ 5.371353] sysrq: Loglevel set to 4 [ 22s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.411043] sysrq: Power Off [ 25s] [ 8.416615] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] cloud118 failed "build ulfius_2.5.2-4.2.dsc" at Fri Nov 5 03:34:13 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a66858d60_26f62ae79e4a05f0688333@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 7s] [12/12] preinstalling binutils... [ 7s] copying packages... [ 11s] reordering...cycle: libc6 -> libgcc-s1 [ 11s] breaking dependency libgcc-s1 -> libc6 [ 11s] cycle: libdevmapper1.02.1 -> dmsetup [ 11s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 11s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 18432 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 16 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 5.945251] sysrq: Changing Loglevel [ 18s] .3.18-59.24-defa[ 5.946822] sysrq: Loglevel set to 4 [ 18s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.984756] sysrq: Power Off [ 21s] [ 8.994663] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] sheep83 failed "build osmo-mgw_1.8.1.89.172f5.202111050026.dsc" at Fri Nov 5 03:34:33 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a66898a3b_26f62ae79e4a05f06884c5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] [ 5.269651] sysrq: Changing Loglevel [ 22s] Linux version: 5[ 5.271435] sysrq: Loglevel set to 4 [ 22s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.318185] sysrq: Power Off [ 25s] [ 8.326110] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb61 failed "build osmo-bts_1.3.0.342.333d.202111050026.dsc" at Fri Nov 5 03:34:33 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a668ce305_26f62ae79e4a05f0688512@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 5.251246] sysrq: Changing Loglevel [ 22s] .3.18-59.24-defa[ 5.252974] sysrq: Loglevel set to 4 [ 22s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.297007] sysrq: Power Off [ 25s] [ 8.304588] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb22 failed "build libosmo-sccp_1.4.0.dsc" at Fri Nov 5 03:34:35 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6698a935_26f62ae79e4a05f06888b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 11s] copying packages... [ 18s] reordering...cycle: libc6 -> libgcc-s1 [ 18s] breaking dependency libgcc-s1 -> libc6 [ 18s] cycle: libdevmapper1.02.1 -> dmsetup [ 18s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 18s] done [ 20s] booting kvm... [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 21s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM... [ 26s] c[?7l### VM INTERACTION END ### [ 26s] 2nd stage started in virtual machine [ 26s] machine type: x86_64 [ 26s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 26s] Increasing log level from now on... [ 26s] [ 5.506235] sysrq: Changing Loglevel [ 26s] [ 5.507464] sysrq: Loglevel set to 4 [ 26s] Enable sysrq operations [ 26s] /.build/build-vm: line 632: mkswap: command not found [ 26s] swapon: /dev/vdb: read swap header failed [ 26s] ### VM INTERACTION START ### [ 29s] [ 8.551659] sysrq: Power Off [ 29s] [ 8.555177] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] cloud120 failed "build osmo-remsim_0.2.4.dsc" at Fri Nov 5 03:34:42 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a669d7e3c_26f62ae79e4a05f06889e6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 12s] [12/12] preinstalling binutils... [ 12s] copying packages... [ 18s] reordering...cycle: libc6 -> libgcc-s1 [ 18s] breaking dependency libgcc-s1 -> libc6 [ 18s] cycle: libdevmapper1.02.1 -> dmsetup [ 18s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 18s] done [ 20s] booting kvm... [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 20s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 28s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 28s] 2nd stage started in virtual machine [ 28s] machine type: x86_64 [ 28s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 28s] Increasing log level from now on... [ 28s] [ 6.982463] sysrq: Changing Loglevel [ 28s] [ 6.983292] sysrq: Loglevel set to 4 [ 28s] Enable sysrq operations [ 28s] /.build/build-vm: line 632: mkswap: command not found [ 28s] swapon: /dev/vdb: read swap header failed [ 28s] ### VM INTERACTION START ### [ 31s] [ 10.053710] sysrq: Power Off [ 31s] [ 10.080793] reboot: Power down [ 31s] ### VM INTERACTION END ### [ 31s] [ 31s] lamb56 failed "build osmo-hlr_1.3.1.dsc" at Fri Nov 5 03:34:45 UTC 2021. [ 31s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6691aa7c_26f62ae79e4a05f068862c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 5.299986] sysrq: Changing Loglevel [ 22s] .3.18-59.24-defa[ 5.302034] sysrq: Loglevel set to 4 [ 22s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.348550] sysrq: Power Off [ 25s] [ 8.354673] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb08 failed "build osmo-cbc_0.2.2.dsc" at Fri Nov 5 03:34:37 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a66951a6f_26f62ae79e4a05f0688727@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] [ 5.434527] sysrq: Changing Loglevel [ 22s] [ 5.435349] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.477496] sysrq: Power Off [ 25s] [ 8.482736] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb54 failed "build osmo-bts_1.3.3.dsc" at Fri Nov 5 03:34:38 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:34:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:34:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a66a26ca1_26f62ae79e4a05f06890ac@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] [ 4.991686] sysrq: Changing Loglevel [ 23s] Linux version: 5[ 4.993687] sysrq: Loglevel set to 4 [ 23s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.038275] sysrq: Power Off [ 26s] [ 8.045250] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb27 failed "build osmo-mgw_1.8.1.dsc" at Fri Nov 5 03:34:31 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:04 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a683cbbbf_26f62ae79e4a05f0689295@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 5.619784] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 5.621120] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.664670] sysrq: Power Off [ 26s] [ 8.672259] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb17 failed "build osmo-remsim_0.2.2.113.eb9f.202111050026.dsc" at Fri Nov 5 03:35:01 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:04 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a684141d9_26f62ae79e4a05f0689352@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.24-defa[ 5.341302] sysrq: Changing Loglevel [ 22s] ult #1 SMP Mon S[ 5.342483] sysrq: Loglevel set to 4 [ 22s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 26s] [ 8.388239] sysrq: Power Off [ 26s] [ 8.396298] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb09 failed "build osmo-cbc_0.2.2.1.cf3c.202111050026.dsc" at Fri Nov 5 03:35:02 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a684ca140_26f62ae79e4a05f0689447@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 5.347162] sysrq: Changing Loglevel [ 22s] .3.18-59.24-defa[ 5.349133] sysrq: Loglevel set to 4 [ 22s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.393225] sysrq: Power Off [ 25s] [ 8.398490] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb61 failed "build osmo-iuh_0.7.0.26.e321.202111050026.dsc" at Fri Nov 5 03:35:11 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6854f6b6_26f62ae79e4a05f0689691@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 14s] reordering...cycle: libc6 -> libgcc-s1 [ 14s] breaking dependency libgcc-s1 -> libc6 [ 14s] cycle: libdevmapper1.02.1 -> dmsetup [ 14s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 14s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] [ 5.390960] sysrq: Changing Loglevel [ 21s] [ 5.392251] sysrq: Loglevel set to 4 [ 21s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] /.build/build-vm: line 632: mkswap: command not found [ 21s] swapon: /dev/vdb: read swap header failed [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.434060] sysrq: Power Off [ 24s] [ 8.440867] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb27 failed "build osmo-iuh_1.0.0.dsc" at Fri Nov 5 03:35:18 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a685192d9_26f62ae79e4a05f06895eb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 8s] [12/12] preinstalling binutils... [ 8s] copying packages... [ 12s] reordering...cycle: libc6 -> libgcc-s1 [ 12s] breaking dependency libgcc-s1 -> libc6 [ 12s] cycle: libdevmapper1.02.1 -> dmsetup [ 12s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 12s] done [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 18432 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 16 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5.3.18-59.24-defa[ 5.774842] sysrq: Changing Loglevel [ 18s] ult #1 SMP Mon S[ 5.776159] sysrq: Loglevel set to 4 [ 18s] ep 13 15:06:42 UTC 2021 (2f872ea) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] /.build/build-vm: line 632: mkswap: command not found [ 18s] swapon: /dev/vdb: read swap header failed [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.811348] sysrq: Power Off [ 22s] [ 8.820412] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] sheep83 failed "build osmo-smlc_0.2.0.dsc" at Fri Nov 5 03:35:14 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6857b393_26f62ae79e4a05f0689742@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 9s] [12/12] preinstalling binutils... [ 9s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] [ 5.322964] sysrq: Changing Loglevel [ 22s] [ 5.324165] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.374162] sysrq: Power Off [ 25s] [ 8.382409] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb61 failed "build osmo-bsc_1.7.0.315.0650.202111050026.dsc" at Fri Nov 5 03:35:19 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a685a3be3_26f62ae79e4a05f068984@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 11s] [12/12] preinstalling binutils... [ 11s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] [ 5.406927] sysrq: Changing Loglevel [ 23s] [ 5.407739] sysrq: Loglevel set to 4 [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.451066] sysrq: Power Off [ 26s] [ 8.459349] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb51 failed "build osmo-bsc_1.7.2.dsc" at Fri Nov 5 03:35:19 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:38 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6a42175f_26f62ae79e4a05f0689936@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 13s] copying packages... [ 21s] reordering...cycle: libc6 -> libgcc-s1 [ 21s] breaking dependency libgcc-s1 -> libc6 [ 21s] cycle: libdevmapper1.02.1 -> dmsetup [ 21s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 21s] done [ 31s] booting kvm... [ 31s] ### VM INTERACTION START ### [ 31s] Using UART console [ 31s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 32s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 32s] Booting from ROM... [ 37s] c[?7l### VM INTERACTION END ### [ 37s] 2nd stage started in virtual machine [ 37s] machine type: x86_64 [ 37s] Linux version: 5.3.18-59.24-default #1 SMP Mon S[ 5.363100] sysrq: Changing Loglevel [ 37s] ep 13 15:06:42 U[ 5.364648] sysrq: Loglevel set to 4 [ 37s] TC 2021 (2f872ea) [ 37s] Increasing log level from now on... [ 37s] Enable sysrq operations [ 37s] /.build/build-vm: line 632: mkswap: command not found [ 37s] swapon: /dev/vdb: read swap header failed [ 37s] ### VM INTERACTION START ### [ 40s] [ 8.411446] sysrq: Power Off [ 40s] [ 8.415391] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] cloud102 failed "build osmo-smlc_0.2.0.2.ec37.202111050026.dsc" at Fri Nov 5 03:35:28 UTC 2021. [ 41s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:35:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:35:55 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6a4e6e7b_26f62ae79e4a05f0690031@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 6s] [12/12] preinstalling binutils... [ 6s] copying packages... [ 9s] reordering...cycle: libc6 -> libgcc-s1 [ 9s] breaking dependency libgcc-s1 -> libc6 [ 9s] cycle: libdevmapper1.02.1 -> dmsetup [ 9s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.392960] sysrq: Changing Loglevel [ 14s] .3.18-59.24-defa[ 4.394073] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] /.build/build-vm: line 632: mkswap: command not found [ 14s] swapon: /dev/vdb: read swap header failed [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.415294] sysrq: Power Off [ 17s] [ 7.419222] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat17 failed "build osmo-hnodeb_0.0.0.202111050026.dsc" at Fri Nov 5 03:35:41 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:36:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:36:12 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6c33f009_26f62ae79e4a05f06901f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5[ 5.374072] sysrq: Changing Loglevel [ 23s] .3.18-59.24-defa[ 5.376090] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.421356] sysrq: Power Off [ 26s] [ 8.427523] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb18 failed "build osmo-msc_1.7.0.37.efa6c.202111050026.dsc" at Fri Nov 5 03:35:55 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:36:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:36:12 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6c3bbdfc_26f62ae79e4a05f06903c4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] [ 4.876246] sysrq: Changing Loglevel [ 22s] Linux version: 5[ 4.877846] sysrq: Loglevel set to 4 [ 22s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] /.build/build-vm: line 632: mkswap: command not found [ 22s] swapon: /dev/vdb: read swap header failed [ 22s] ### VM INTERACTION START ### [ 25s] [ 7.923361] sysrq: Power Off [ 25s] [ 7.927875] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] old-cirrus2 failed "build osmo-msc_1.7.1.dsc" at Fri Nov 5 03:35:59 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:36:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:36:12 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6c3826d0_26f62ae79e4a05f06902a5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 15s] reordering...cycle: libc6 -> libgcc-s1 [ 15s] breaking dependency libgcc-s1 -> libc6 [ 15s] cycle: libdevmapper1.02.1 -> dmsetup [ 15s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 15s] done [ 16s] booting kvm... [ 16s] ### VM INTERACTION START ### [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] [ 5.718820] sysrq: Changing Loglevel [ 23s] Linux version: 5[ 5.719655] sysrq: Loglevel set to 4 [ 23s] .3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.781534] sysrq: Power Off [ 26s] [ 8.786448] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb55 failed "build osmo-sgsn_1.7.0.27.2d0e2.202111050026.dsc" at Fri Nov 5 03:35:57 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 03:36:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 03:36:12 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6184a6c425d10_26f62ae79e4a05f069045d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 10s] [12/12] preinstalling binutils... [ 10s] copying packages... [ 16s] reordering...cycle: libc6 -> libgcc-s1 [ 16s] breaking dependency libgcc-s1 -> libc6 [ 16s] cycle: libdevmapper1.02.1 -> dmsetup [ 16s] breaking dependency libdevmapper1.02.1 -> dmsetup [ 16s] done [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.24-defa[ 5.470349] sysrq: Changing Loglevel [ 23s] [ 5.472163] sysrq: Loglevel set to 4 [ 23s] ult #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea) [ 23s] Increasing log level from now on... [ 23s] Enable sysrq operations [ 23s] /.build/build-vm: line 632: mkswap: command not found [ 23s] swapon: /dev/vdb: read swap header failed [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.573124] sysrq: Power Off [ 26s] [ 8.579441] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb02 failed "build osmo-sgsn_1.7.1.dsc" at Fri Nov 5 03:36:01 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:18:55 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 09:18:55 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c at 371 PS4, Line 371: for (i = 0; i < 8; i++) { > is it a problem? so far we never set it to anything > UEA2 because the vty validates the range and t [?] Ack https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/tests/msc_vlr/msc_vlr_test_umts_authen.c File tests/msc_vlr/msc_vlr_test_umts_authen.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/tests/msc_vlr/msc_vlr_test_umts_authen.c at 344 PS4, Line 344: net->uea_encryption_mask = 0x06; I find those magic numbers a bit hard to read. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 09:18:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:20:33 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 09:20:33 +0000 Subject: Change in osmo-bsc[master]: lchan_fsm: cosmetic: move a 'case' below the 'default' branch In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26118 ) Change subject: lchan_fsm: cosmetic: move a 'case' below the 'default' branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I523a6d55d9a103ba69351d9dc6d0c000a422a765 Gerrit-Change-Number: 26118 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Fri, 05 Nov 2021 09:20:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:25:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:25:19 +0000 Subject: Change in osmo-bsc[master]: lchan_fsm: cosmetic: move a 'case' below the 'default' branch In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26118 ) Change subject: lchan_fsm: cosmetic: move a 'case' below the 'default' branch ...................................................................... lchan_fsm: cosmetic: move a 'case' below the 'default' branch It's unusual to have 'case' statements below the 'default' statement. Change-Id: I523a6d55d9a103ba69351d9dc6d0c000a422a765 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 2f62487..64840f0 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -806,8 +806,8 @@ act_type = lchan->conn->ho.async ? RSL_ACT_INTER_ASYNC : RSL_ACT_INTER_SYNC; ho_ref = lchan->conn->ho.ho_ref; break; - default: case ACTIVATE_FOR_ASSIGNMENT: + default: act_type = RSL_ACT_INTRA_NORM_ASS; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I523a6d55d9a103ba69351d9dc6d0c000a422a765 Gerrit-Change-Number: 26118 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:25:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:25:49 +0000 Subject: Change in osmo-bsc[master]: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26119 ) Change subject: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee7ddb4cf1a9a7bb9b34e6c9f6f9899da480fbd0 Gerrit-Change-Number: 26119 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 05 Nov 2021 09:25:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:25:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:25:51 +0000 Subject: Change in osmo-bsc[master]: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26119 ) Change subject: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS ...................................................................... rsl_tx_chan_activ(): fix manual channel activation for nanoBTS nanoBTS would NACK a CHANnel ACTIVation message for an 'intra cell channel change' if it does not contain the Timing Advance IE. And this is right, because according to 3GPP TS 48.058, section 8.4.1, point '4)', it *must* be included. Indeed, the actual Timing Advance value is not known during the manual channel activation triggered from the VTY interface. So let's merely indicate 0 if it's not known. Change-Id: Iee7ddb4cf1a9a7bb9b34e6c9f6f9899da480fbd0 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0e2ffc6..c3825f6 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -691,6 +691,12 @@ if (bts->type == GSM_BTS_TYPE_BS11) ta <<= 2; msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta); + } else if ((act_type & 0x06) == 0x00) { + /* Note '4)' in section 8.4.1: The Timing Advance element must be + * included if activation type is intra cell channel change. */ + LOG_LCHAN(lchan, LOGL_NOTICE, "Timing Advance IE shall be present, " + "but the actual value is not known => assuming 0\n"); + msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, 0); } /* BS/MS Power Control Parameters (if supported by BTS model) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee7ddb4cf1a9a7bb9b34e6c9f6f9899da480fbd0 Gerrit-Change-Number: 26119 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:28:19 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 09:28:19 +0000 Subject: Change in osmo-bsc[master]: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify... In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26117 ) Change subject: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b2895feef6e30f9c1db97394dd16d892b277f2 Gerrit-Change-Number: 26117 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Fri, 05 Nov 2021 09:28:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:46:30 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 09:46:30 +0000 Subject: Change in libosmocore[master]: include: add enum for UTRAN cipher In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26106 ) Change subject: include: add enum for UTRAN cipher ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 09:46:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:48:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:48:10 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 09:48:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:48:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:48:20 +0000 Subject: Change in osmo-msc[master]: Validate the choosen UTRAN encryption algorithm In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25832 ) Change subject: Validate the choosen UTRAN encryption algorithm ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icfc135c8b8ae862defe7114db492af600c26407f Gerrit-Change-Number: 25832 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 09:48:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:48:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:48:27 +0000 Subject: Change in osmo-msc[master]: Fix enabling of UMTS UEA encryption In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22757 ) Change subject: Fix enabling of UMTS UEA encryption ...................................................................... Fix enabling of UMTS UEA encryption The existing code allowed the user to configure UMTS encryption in the vty, but we never actually passed this information down to RANAP. As a result, the RAN had no chance of ever enabling encryption on the air interface. Change-Id: Ieaaa6b23b7337b7edb902fad8031e195e0c5e9d2 Related: OS#4144 --- M include/osmocom/msc/ran_msg.h M src/libmsc/msc_a.c M src/libmsc/ran_msg_iu.c 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/msc/ran_msg.h b/include/osmocom/msc/ran_msg.h index fd2439f..816ef1f 100644 --- a/include/osmocom/msc/ran_msg.h +++ b/include/osmocom/msc/ran_msg.h @@ -102,6 +102,9 @@ /* out-argument to return the key to the caller, pass NULL if not needed. */ struct geran_encr *chosen_key; } geran; + struct { + bool uea_encryption; + } utran; }; struct ran_handover_request { diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 9b6b602..fe3af14 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -348,6 +348,9 @@ /* for ran_a.c to store the GERAN key that is actually used */ .chosen_key = &msc_a->geran_encr, }, + .utran = { + .uea_encryption = net->uea_encryption + } }, }; diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 5d13460..6120918 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -369,7 +369,7 @@ LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, ik %s\n", osmo_hexdump_nospc(cm->vec->ik, 16)); - return ranap_new_msg_sec_mod_cmd(cm->vec->ik, NULL, RANAP_KeyStatus_new); + return ranap_new_msg_sec_mod_cmd(cm->vec->ik, cm->utran.uea_encryption ? cm->vec->ck : NULL, RANAP_KeyStatus_new); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ieaaa6b23b7337b7edb902fad8031e195e0c5e9d2 Gerrit-Change-Number: 22757 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:48:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:48:27 +0000 Subject: Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable ...................................................................... Make UTRAN encryption algorithms configurable Allow the user fine-grained control over which UMTS encryption algorithms are permitted, rather than always permitting UEA1 and UEA2 or neither. This brings the handling of UEA in line with the handling of A5 for GERAN. Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Closes: OS#4144 Depends: osmo-iuh.git I6d2d033b0427bdc84fee61e0f3cb7b29935214bf --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/ran_msg.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c M src/libmsc/msc_net_init.c M src/libmsc/msc_vty.c M src/libmsc/ran_msg_iu.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/test_nodes.vty 9 files changed, 38 insertions(+), 64 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 72e33a6..2a64c53 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -155,10 +155,8 @@ bool authentication_required; int send_mm_info; - /* Whether to use encryption on UTRAN. - * TODO: we should offer a choice of UEA1 and/or UEA2, and probably replace this bool with a bit-mask of - * permitted Iu encryption algorithms. See also OS#4143 and the 'encryption uea' vty command. */ - bool uea_encryption; + /* bit-mask of permitted encryption algorithms. LSB=UEA0, MSB=UEA7 */ + uint8_t uea_encryption_mask; struct rate_ctr_group *msc_ctrs; struct osmo_stat_item_group *statg; diff --git a/include/osmocom/msc/ran_msg.h b/include/osmocom/msc/ran_msg.h index 816ef1f..0714607 100644 --- a/include/osmocom/msc/ran_msg.h +++ b/include/osmocom/msc/ran_msg.h @@ -103,7 +103,7 @@ struct geran_encr *chosen_key; } geran; struct { - bool uea_encryption; + uint8_t uea_encryption_mask; } utran; }; diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 565e7ad..fc1b2e2 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -414,7 +414,7 @@ net->vlr, msc_a, vlr_lu_type, tmsi, imsi, &old_lai, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, lu->key_seq, osmo_gsm48_classmark1_is_r99(&lu->classmark1), is_utran, @@ -805,7 +805,7 @@ req->cm_service_type, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -931,7 +931,7 @@ VLR_PR_ARQ_T_CM_RE_ESTABLISH_REQ, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -1293,7 +1293,7 @@ net->vlr, msc_a, VLR_PR_ARQ_T_PAGING_RESP, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, pr->key_seq, osmo_gsm48_classmark2_is_r99(cm2, classmark2_len), is_utran); diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index fe3af14..a79cf6a 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -349,8 +349,8 @@ .chosen_key = &msc_a->geran_encr, }, .utran = { - .uea_encryption = net->uea_encryption - } + .uea_encryption_mask = net->uea_encryption_mask, + }, }, }; diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index 9e3e8b3..d53156b 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -67,7 +67,8 @@ /* Permit a compile-time default of A5/3 and A5/1 */ net->a5_encryption_mask = (1 << 3) | (1 << 1); - net->uea_encryption = true; + /* Permit a compile-time default of UEA2 and UEA1 */ + net->uea_encryption_mask = (1 << 2) | (1 << 1); net->mncc_guard_timeout = 180; net->ncss_guard_timeout = 30; diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index e4e0937..6be09d8 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -169,41 +169,21 @@ return CMD_SUCCESS; } -/* So far just a boolean switch, a future patch might add individual config for UEA1 and UEA2, see OS#4143 */ DEFUN(cfg_net_encryption_uea, cfg_net_encryption_uea_cmd, "encryption uea <0-2> [<0-2>] [<0-2>]", ENCRYPTION_STR - "UTRAN (3G) encryption algorithms to allow: 0 = UEA0 (no encryption), 1 = UEA1, 2 = UEA2." - " NOTE: the current implementation does not allow free choice of combining encryption algorithms yet." - " The only valid settings are either 'encryption uea 0' or 'encryption uea 1 2'.\n" + "UTRAN (3G) encryption algorithms to allow: 0 = UEA0 (no encryption), 1 = UEA1, 2 = UEA2.\n" "UEAn Algorithm Number\n" "UEAn Algorithm Number\n" "UEAn Algorithm Number\n" ) { unsigned int i; - uint8_t mask = 0; + gsmnet->uea_encryption_mask = 0; for (i = 0; i < argc; i++) - mask |= (1 << atoi(argv[i])); - - if (mask == (1 << 0)) { - /* UEA0. Disable encryption. */ - gsmnet->uea_encryption = false; - } else if (mask == ((1 << 1) | (1 << 2))) { - /* UEA1 and UEA2. Enable encryption. */ - gsmnet->uea_encryption = true; - } else { - vty_out(vty, - "%% Error: the current implementation does not allow free choice of combining%s" - "%% encryption algorithms yet. The only valid settings are either%s" - "%% encryption uea 0%s" - "%% or%s" - "%% encryption uea 1 2%s", - VTY_NEWLINE, VTY_NEWLINE, VTY_NEWLINE, VTY_NEWLINE, VTY_NEWLINE); - return CMD_WARNING; - } + gsmnet->uea_encryption_mask |= (1 << atoi(argv[i])); return CMD_SUCCESS; } @@ -386,10 +366,12 @@ } vty_out(vty, "%s", VTY_NEWLINE); - if (!gsmnet->uea_encryption) - vty_out(vty, " encryption uea 0%s", VTY_NEWLINE); - else - vty_out(vty, " encryption uea 1 2%s", VTY_NEWLINE); + vty_out(vty, " encryption uea"); + for (i = 0; i < 8; i++) { + if (gsmnet->uea_encryption_mask & (1 << i)) + vty_out(vty, " %u", i); + } + vty_out(vty, "%s", VTY_NEWLINE); vty_out(vty, " authentication %s%s", gsmnet->authentication_required ? "required" : "optional", VTY_NEWLINE); vty_out(vty, " rrlp mode %s%s", msc_rrlp_mode_name(gsmnet->rrlp.mode), diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 6120918..7b3dd1c 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -367,9 +367,13 @@ const struct ran_cipher_mode_command *cm) { - LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, ik %s\n", - osmo_hexdump_nospc(cm->vec->ik, 16)); - return ranap_new_msg_sec_mod_cmd(cm->vec->ik, cm->utran.uea_encryption ? cm->vec->ck : NULL, RANAP_KeyStatus_new); + LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, IK=%s, CK=%s\n", + osmo_hexdump_nospc(cm->vec->ik, 16), + cm->utran.uea_encryption_mask > 0x01 ? osmo_hexdump_nospc(cm->vec->ck, 16) : "NONE"); + /* TODO: Do we need to check if the UE supports all of the algorithms and build an intersection like + * in the case of A5? */ + return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > 0x01 ? cm->vec->ck : NULL, + RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask); } diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index 46f8d98..e462ef4 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -50,7 +50,7 @@ "d3d36ff71c949e83c22072799e9687c5ec32a81d96afcbf4b4fb" "0c7ac3e9e9b7db05"; bool encryption = (via_ran == OSMO_RAT_GERAN_A && net->a5_encryption_mask > 0x1) - || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption); + || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption_mask > 0x1); net->authentication_required = true; net->vlr->cfg.assign_tmsi = true; @@ -333,7 +333,7 @@ static void test_umts_authen_utran() { comment_start(); - net->uea_encryption = false; + net->uea_encryption_mask = 0x01; _test_umts_authen(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -341,7 +341,7 @@ static void test_umts_auth_ciph_utran() { comment_start(); - net->uea_encryption = true; + net->uea_encryption_mask = 0x06; _test_umts_authen(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -361,7 +361,7 @@ struct vlr_subscr *vsub; const char *imsi = "901700000010650"; bool encryption = (via_ran == OSMO_RAT_GERAN_A && net->a5_encryption_mask > 0x1) - || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption); + || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption_mask > 0x1); net->authentication_required = true; net->vlr->cfg.assign_tmsi = true; @@ -588,7 +588,7 @@ static void test_umts_authen_resync_utran() { comment_start(); - net->uea_encryption = false; + net->uea_encryption_mask = 0x01; _test_umts_authen_resync(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -596,7 +596,7 @@ static void test_umts_auth_ciph_resync_utran() { comment_start(); - net->uea_encryption = true; + net->uea_encryption_mask = 0x06; _test_umts_authen_resync(OSMO_RAT_UTRAN_IU); comment_end(); } diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 315264f..14f15a2 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -31,7 +31,7 @@ encryption Encryption options OsmoMSC(config-net)# encryption ? a5 GSM A5 Air Interface Encryption. - uea UTRAN (3G) encryption algorithms to allow: 0 = UEA0 (no encryption), 1 = UEA1, 2 = UEA2. NOTE: the current implementation does not allow free choice of combining encryption algorithms yet. The only valid settings are either 'encryption uea 0' or 'encryption uea 1 2'. + uea UTRAN (3G) encryption algorithms to allow: 0 = UEA0 (no encryption), 1 = UEA1, 2 = UEA2. OsmoMSC(config-net)# encryption uea ? <0-2> UEAn Algorithm Number @@ -189,38 +189,27 @@ ... OsmoMSC(config-net)# encryption uea 1 -% Error: the current implementation does not allow free choice of combining -% encryption algorithms yet. The only valid settings are either -% encryption uea 0 -% or -% encryption uea 1 2 OsmoMSC(config-net)# show running-config ... - encryption uea 0 + encryption uea 1 ... OsmoMSC(config-net)# encryption uea 2 -% Error: the current implementation does not allow free choice of combining -... OsmoMSC(config-net)# show running-config ... - encryption uea 0 + encryption uea 2 ... OsmoMSC(config-net)# encryption uea 0 1 -% Error: the current implementation does not allow free choice of combining -... OsmoMSC(config-net)# show running-config ... - encryption uea 0 + encryption uea 0 1 ... OsmoMSC(config-net)# encryption uea 0 2 -% Error: the current implementation does not allow free choice of combining -... OsmoMSC(config-net)# show running-config ... - encryption uea 0 + encryption uea 0 2 ... OsmoMSC(config-net)# encryption uea 1 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:48:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:48:27 +0000 Subject: Change in osmo-msc[master]: Validate the choosen UTRAN encryption algorithm In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25832 ) Change subject: Validate the choosen UTRAN encryption algorithm ...................................................................... Validate the choosen UTRAN encryption algorithm RANAP Security Command can include an encryption IE. If it includes it the RNC can still ignore it (e.g. unsupported encryption) and return the Security Command Complete with an choosen encryption IE: "no encryption". Validate the encryption element and ensure the encryption is included in the encryption mask. Closes: OS#4144 Change-Id: Icfc135c8b8ae862defe7114db492af600c26407f --- M include/osmocom/msc/ran_msg.h M src/libmsc/msc_a.c M src/libmsc/ran_msg_iu.c M tests/msc_vlr/msc_vlr_test_authen_reuse.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_tests.c M tests/msc_vlr/msc_vlr_tests.h 8 files changed, 52 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/include/osmocom/msc/ran_msg.h b/include/osmocom/msc/ran_msg.h index 0714607..32b24a0 100644 --- a/include/osmocom/msc/ran_msg.h +++ b/include/osmocom/msc/ran_msg.h @@ -216,6 +216,12 @@ * alg_id == 1 means A5/0 i.e. no encryption, alg_id == 4 means A5/3. * alg_id == 0 means no such IE was present. */ uint8_t alg_id; + /*! utran integrity protection. 0..15 */ + int16_t utran_integrity; + /*! utran_integrity is in encoded format: + * utran_integrity == -1 means no such IE was present + * utran_integrity == 0 means no encryption. */ + int16_t utran_encryption; const char *imeisv; const struct tlv_p_entry *l3_msg; } cipher_mode_complete; diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index a79cf6a..583f9e7 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1404,6 +1404,7 @@ int msc_a_ran_dec_from_msc_i(struct msc_a *msc_a, struct msc_a_ran_dec_data *d) { struct vlr_subscr *vsub = msc_a_vsub(msc_a); + struct gsm_network *net = msc_a_net(msc_a); const struct ran_msg *msg = d->ran_dec; int rc = -99; @@ -1459,7 +1460,25 @@ msc_a->geran_encr.alg_id = msg->cipher_mode_complete.alg_id; LOG_MSC_A(msc_a, LOGL_DEBUG, "Cipher Mode Complete: chosen encryption algorithm: A5/%u\n", msc_a->geran_encr.alg_id - 1); - }; + } + + if (msc_a->c.ran->type == OSMO_RAT_UTRAN_IU) { + int16_t utran_encryption; + + /* utran: ensure chosen ciphering mode is allowed + * If the IE is missing (utran_encryption == -1), parse it as no encryption */ + utran_encryption = msg->cipher_mode_complete.utran_encryption; + if (utran_encryption == -1) + utran_encryption = 0; + if ((net->uea_encryption_mask & (1 << utran_encryption)) == 0) { + /* cipher disallowed */ + LOG_MSC_A(msc_a, LOGL_ERROR, "Cipher Mode Complete: RNC chosen forbidden ciphering UEA%d\n", + msg->cipher_mode_complete.utran_encryption); + vlr_subscr_rx_ciph_res(vsub, VLR_CIPH_REJECT); + rc = 0; + break; + } + } vlr_subscr_rx_ciph_res(vsub, VLR_CIPH_COMPL); rc = 0; diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 7b3dd1c..81147cf 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -211,12 +211,20 @@ ranap_free_rab_setupormodifieditemies(&setup_ies); } -static void ran_iu_decode_security_mode_complete(struct ran_dec *ran_iu_decode) +static void ran_iu_decode_security_mode_complete(struct ran_dec *ran_iu_decode, const RANAP_SecurityModeCompleteIEs_t *ies) { struct ran_msg ran_dec_msg = { .msg_type = RAN_MSG_CIPHER_MODE_COMPLETE, .msg_name = "RANAP SecurityModeControl successfulOutcome", + .cipher_mode_complete = { + .utran_integrity = ies->chosenIntegrityProtectionAlgorithm, + .utran_encryption = -1, + }, }; + + if (ies->presenceMask & SECURITYMODECOMPLETEIES_RANAP_CHOSENENCRYPTIONALGORITHM_PRESENT) + ran_dec_msg.cipher_mode_complete.utran_encryption = ies->chosenEncryptionAlgorithm; + ran_decoded(ran_iu_decode, &ran_dec_msg); } @@ -272,7 +280,7 @@ case RANAP_ProcedureCode_id_SecurityModeControl: switch (message->direction) { case RANAP_RANAP_PDU_PR_successfulOutcome: - ran_iu_decode_security_mode_complete(ran_iu_decode); + ran_iu_decode_security_mode_complete(ran_iu_decode, &message->msg.securityModeCompleteIEs); return; case RANAP_RANAP_PDU_PR_unsuccessfulOutcome: ran_iu_decode_security_mode_reject(ran_iu_decode); diff --git a/tests/msc_vlr/msc_vlr_test_authen_reuse.c b/tests/msc_vlr/msc_vlr_test_authen_reuse.c index f8f9383..870f993 100644 --- a/tests/msc_vlr/msc_vlr_test_authen_reuse.c +++ b/tests/msc_vlr/msc_vlr_test_authen_reuse.c @@ -99,7 +99,7 @@ btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); } @@ -170,7 +170,7 @@ VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); } @@ -239,7 +239,7 @@ VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); } diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index 9ab1066..a547935 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -128,7 +128,7 @@ btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); @@ -197,7 +197,7 @@ VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); BTW("a call is initiated"); @@ -317,7 +317,7 @@ btw("MS sends SecurityModeControl acceptance, VLR accepts, sends CC Setup"); dtap_expect_tx("0305" /* CC: Setup */); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); btw("MS confirms call, we create a RAN-side RTP and forward MNCC_CALL_CONF_IND"); expect_crcx(RTP_TO_RAN); @@ -420,7 +420,7 @@ btw("MS sends SecurityModeControl acceptance, VLR accepts, sends CC Setup"); dtap_expect_tx("0305" /* CC: Setup */); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); btw("MS confirms call, we create a RAN-side RTP and forward MNCC_CALL_CONF_IND"); expect_crcx(RTP_TO_RAN); @@ -509,7 +509,7 @@ VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); BTW("a call is initiated"); @@ -605,7 +605,7 @@ VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); BTW("a call is initiated"); diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index e462ef4..655183b 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -138,7 +138,7 @@ btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); } @@ -211,7 +211,7 @@ VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); } } else { @@ -278,7 +278,7 @@ btw("MS sends SecurityModeControl acceptance, VLR accepts and sends SMS"); dtap_expect_tx(sms); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); } } else { /* Encryption disabled */ @@ -530,7 +530,7 @@ btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(); + ms_sends_security_mode_complete(1); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); } diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index 102fba7..fbd2540 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -986,12 +986,13 @@ g_msub = NULL; } -void ms_sends_security_mode_complete() +void ms_sends_security_mode_complete(uint8_t utran_encryption) { struct ran_msg ran_dec; ran_dec = (struct ran_msg){ .msg_type = RAN_MSG_CIPHER_MODE_COMPLETE, + .cipher_mode_complete.utran_encryption = utran_encryption, }; fake_msc_a_ran_dec(&ran_dec); diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index 23dc9da..a2b2f22 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -184,7 +184,7 @@ void ms_sends_msg(const char *hex); void ms_sends_classmark_update(const struct osmo_gsm48_classmark *classmark); void ms_sends_ciphering_mode_complete(const char *inner_nas_msg); -void ms_sends_security_mode_complete(); +void ms_sends_security_mode_complete(uint8_t utran_encryption); void ms_sends_assignment_complete(enum mgcp_codecs assigned_codec); void gsup_rx(const char *rx_hex, const char *expect_tx_hex); void send_sms(struct vlr_subscr *receiver, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icfc135c8b8ae862defe7114db492af600c26407f Gerrit-Change-Number: 25832 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:50:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:50:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: remove misleading PADDING attributes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 ) Change subject: library/GSM_RR_Types: remove misleading PADDING attributes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109/1//COMMIT_MSG at 11 PS1, Line 11: padding length is counted from the beginning of the message. maybe it is worth raising a feature request with TITAN, explaining to them why a different model is needed [in addition to their existing one]. It worked with other feature requests like the L/H syntax. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 Gerrit-Change-Number: 26109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 09:50:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:50:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:50:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I198cbfd176e41c55f67d625d9587ba5b6062f0c4 Gerrit-Change-Number: 26110 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 09:50:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:50:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 09:50:41 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... Patch Set 1: Code-Review+1 Please do not forget to update the manual: Table 5: bts - BTS Statistics -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 05 Nov 2021 09:50:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:50:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:50:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3bd491fba5b72f0fdd262992a97895f037be69d8 Gerrit-Change-Number: 26111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 09:50:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 09:51:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 09:51:24 +0000 Subject: Change in osmo-bsc[master]: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26114 ) Change subject: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I579c265e9d18402ce806e4d0ea836042185dedaa Gerrit-Change-Number: 26114 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 05 Nov 2021 09:51:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 10:06:29 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 10:06:29 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require encryption into own function In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require encryption into own function ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 10:06:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 10:09:35 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 10:09:35 +0000 Subject: Change in osmo-msc[master]: utran: use new UTRAN encryption enum In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26107 ) Change subject: utran: use new UTRAN encryption enum ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26107/2/tests/msc_vlr/msc_vlr_test_umts_authen.c File tests/msc_vlr/msc_vlr_test_umts_authen.c: https://gerrit.osmocom.org/c/osmo-msc/+/26107/2/tests/msc_vlr/msc_vlr_test_umts_authen.c at 344 PS2, Line 344: net->uea_encryption_mask = (1 << OSMO_UTRAN_UEA1) | (1 << OSMO_UTRAN_UEA2); This is much easier to read! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa Gerrit-Change-Number: 26107 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 10:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 10:26:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 10:26:39 +0000 Subject: Change in osmo-bsc[master]: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26114 ) Change subject: assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() ...................................................................... assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() Change-Id: I579c265e9d18402ce806e4d0ea836042185dedaa --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 1449bdb..f9a81b3 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -959,7 +959,7 @@ assignment_fail(new_lchan->activate.gsm0808_error_cause, "Failed to %s lchan %s", conn->assignment.new_lchan ? "activate" : "modify", - conn->assignment.new_lchan ? gsm_lchan_name(conn->assignment.new_lchan) : ""); + gsm_lchan_name(new_lchan)); return; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I579c265e9d18402ce806e4d0ea836042185dedaa Gerrit-Change-Number: 26114 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 10:26:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 10:26:39 +0000 Subject: Change in osmo-bsc[master]: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify... In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26117 ) Change subject: lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() ...................................................................... lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() _lchan_on_activation_failure(), which calls lchan_on_mode_modify_failure(), already checks for !for_conn in other paths. Hence, it can be that for_conn being passed to _lchan_on_mode_modify_failure() may be null. """ Stack trace of thread 7077: #0 0x000055d25a463842 _lchan_on_mode_modify_failure (osmo-bsc) #1 0x000055d25a46b57c _lchan_on_activation_failure (osmo-bsc) #2 0x00007fe8b2083be4 state_chg (libosmocore.so.17) #3 0x00007fe8b208409d _osmo_fsm_inst_state_chg (libosmocore.so.17) #4 0x000055d25a46825a lchan_fsm_wait_rll_rtp_establish (osmo-bsc) #5 0x00007fe8b2084239 _osmo_fsm_inst_dispatch (libosmocore.so.17) #6 0x00007fe8b2083be4 state_chg (libosmocore.so.17) #7 0x00007fe8b208409d _osmo_fsm_inst_state_chg (libosmocore.so.17) #8 0x000055d25a46dbdc lchan_rtp_fsm_wait_ipacc_mdcx_ack (osmo-bsc) #9 0x00007fe8b2084239 _osmo_fsm_inst_dispatch (libosmocore.so.17) #10 0x000055d25a411d69 abis_rsl_rx_ipacc_mdcx_ack (osmo-bsc) """ Related: SYS#5698 Change-Id: If8b2895feef6e30f9c1db97394dd16d892b277f2 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 64840f0..d5d6e77 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -97,6 +97,11 @@ case MODIFY_FOR_ASSIGNMENT: LOG_LCHAN(lchan, LOGL_NOTICE, "Signalling Assignment FSM of error (%s)\n", lchan->last_error ? : "unknown error"); + if (!for_conn) { + LOG_LCHAN(lchan, LOGL_ERROR, "lchan Channel Mode Modify failed, " + "but modify request has no conn\n"); + break; + } _osmo_fsm_inst_dispatch(for_conn->assignment.fi, ASSIGNMENT_EV_LCHAN_ERROR, lchan, file, line); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b2895feef6e30f9c1db97394dd16d892b277f2 Gerrit-Change-Number: 26117 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:12:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 5 Nov 2021 12:12:20 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/pysim/+/26055/4/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/26055/4/pySim/commands.py at 152 PS4, Line 152: e_str = ''.join([c if c in string.printable.strip() else ' ' for c in str(e)]) cosmetics: this is used twice, maybe move it to a function and make this more readable? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 05 Nov 2021 12:12:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:16:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 5 Nov 2021 12:16:06 +0000 Subject: Change in pysim[master]: commands: complete documentation strings In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26112 ) Change subject: commands: complete documentation strings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icda245e2fd5ef4556c7736d73574dfbb48168973 Gerrit-Change-Number: 26112 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 12:16:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:26:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 12:26:57 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require encryption into own function In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require encryption into own function ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26108/2/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/26108/2/src/libmsc/gsm_04_08.c at 808 PS2, Line 808: is_utran || net->authentication_required, May be worth doing the same for authentication perhaps, in a different patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 12:26:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:34:47 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 5 Nov 2021 12:34:47 +0000 Subject: Change in pysim[master]: pySim-shell: add method to probe for UICC In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 4: (1 comment) (clicking on start review to add a comment) https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py at 85 PS4, Line 85: ; > Thanks! There is no way to have this in the linter? python does not complain about it, so this goes [?] you can install flake8 and put something like this in your pre-commit hook: flake8 --select E703 $(find -name '*.py') it will test for this, e.g.: ./test.py:15:74: E703 statement ends with a semicolon to add it to the linter that runs in gerrit, I've created: https://osmocom.org/issues/5292 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 12:34:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:39:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 12:39:09 +0000 Subject: Change in osmo-pcu[master]: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26121 ) Change subject: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg ...................................................................... vty: Avoid crash in tbf_print_vty_info with null ptr ctrg Previous code did use a ctrg based on MS being EGPRS capable or not. However, an MS being EGPRS capable doesn't mean necessarily that all its TBFs are EGPRS, since we may known about the capability after we already created some previous TBF, so it was not ugpraded. Hence, we were sometimes accessing the wrong NULL ctrg. Let's simply check for non NULL ctrg when deciding what to print. """ Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7561ea6 in vty_out_rate_ctr_group (vty=vty at entry=0x897850, prefix=prefix at entry=0x4482cd " ", ctrg=0x0) at utils.c:82 82 utils.c: No such file or directory. (gdb) bt #0 0x00007ffff7561ea6 in vty_out_rate_ctr_group (vty=vty at entry=0x897850, prefix=prefix at entry=0x4482cd " ", ctrg=0x0) at utils.c:82 #1 0x000000000041437b in tbf_print_vty_info (vty=vty at entry=0x897850, tbf=0x3fb61f0) at pcu_vty_functions.cpp:98 #2 0x0000000000414acc in pcu_vty_show_tbf_all (vty=vty at entry=0x897850, bts=bts at entry=0x7be650, flags=4294967295) at pcu_vty_functions.cpp:127 #3 0x000000000041206f in show_tbf (self=, vty=0x897850, argc=, argv=0x7fffffffe040) at pcu_vty.c:1150 #4 0x00007ffff755d167 in cmd_execute_command_real (vline=vline at entry=0x7bc300, vty=vty at entry=0x897850, cmd=) at command.c:2604 """ Related: SYS#5689 Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024 --- M src/pcu_vty_functions.cpp 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/21/26121/1 diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index 657e5a1..21851df 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -79,11 +79,10 @@ ul_tbf->window_size(), win->v_q(), win->v_r()); vty_out(vty, "%s", VTY_NEWLINE); vty_out(vty, " TBF Statistics:%s", VTY_NEWLINE); - if (GPRS == ms_mode(tbf->ms())) { + if (ul_tbf->m_ul_gprs_ctrs) vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_gprs_ctrs); - } else { + if (ul_tbf->m_ul_egprs_ctrs) vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_egprs_ctrs); - } } if (dl_tbf) { gprs_rlc_dl_window *win = static_cast(dl_tbf->window()); @@ -92,11 +91,10 @@ win->window_stalled() ? " STALLED" : ""); vty_out(vty, "%s", VTY_NEWLINE); vty_out_rate_ctr_group(vty, " ", tbf->m_ctrs); - if (GPRS == ms_mode(tbf->ms())) { + if (dl_tbf->m_dl_gprs_ctrs) vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_gprs_ctrs); - } else { + if (dl_tbf->m_dl_egprs_ctrs) vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_egprs_ctrs); - } } vty_out(vty, "%s%s", VTY_NEWLINE, VTY_NEWLINE); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024 Gerrit-Change-Number: 26121 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:48:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 12:48:55 +0000 Subject: Change in osmo-pcu[master]: doc: Update counters_generated.adoc using osmo_vty_interact.py References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26122 ) Change subject: doc: Update counters_generated.adoc using osmo_vty_interact.py ...................................................................... doc: Update counters_generated.adoc using osmo_vty_interact.py osmo_interact_vty.py -c 'enable;show asciidoc counters' -p 4240 -H 127.0.0.1 -O doc/manuals/chapters/counters_generated.adoc Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 --- M doc/manuals/chapters/counters_generated.adoc 1 file changed, 169 insertions(+), 139 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/22/26122/1 diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc index 2ee425e..ac7d16a 100644 --- a/doc/manuals/chapters/counters_generated.adoc +++ b/doc/manuals/chapters/counters_generated.adoc @@ -1,9 +1,62 @@ + // autogenerated by show asciidoc counters -These counters and their description based on Osmo-PCU 0.4.0.4-8d55 (Osmo-PCU). +These counters and their description are based on OsmoPCU 0.9.0.244-de96 (OsmoPCU). + +=== Rate Counters // generating tables for rate_ctr_group +// rate_ctr_group table NSVC Peer Statistics +.ns:nsvc - NSVC Peer Statistics +[options="header"] +|=== +| Name | Reference | Description +| packets:in | <> | Packets at NS Level ( In) +| packets:out | <> | Packets at NS Level (Out) +| packets:out:drop | <> | Dropped Packets (Out) +| bytes:in | <> | Bytes at NS Level ( In) +| bytes:out | <> | Bytes at NS Level (Out) +| bytes:out:drop | <> | Dropped Bytes (Out) +| blocked | <> | NS-VC Block count +| unblocked | <> | NS-VC Unblock count +| dead | <> | NS-VC gone dead count +| replaced | <> | NS-VC replaced other count +| nsei-chg | <> | NS-VC changed NSEI count +| inv-nsvci | <> | NS-VCI was invalid count +| inv-nsei | <> | NSEI was invalid count +| lost:alive | <> | ALIVE ACK missing count +| lost:reset | <> | RESET ACK missing count +|=== +// rate_ctr_group table NSE Peer Statistics +.ns:nse - NSE Peer Statistics +[options="header"] +|=== +| Name | Reference | Description +| packets:in | <> | Packets at NS Level ( In) +| packets:out | <> | Packets at NS Level (Out) +| packets:out:drop | <> | Dropped Packets (Out) +| bytes:in | <> | Bytes at NS Level ( In) +| bytes:out | <> | Bytes at NS Level (Out) +| bytes:out:drop | <> | Dropped Bytes (Out) +| blocked | <> | NS-VC Block count +| unblocked | <> | NS-VC Unblock count +| dead | <> | NS-VC gone dead count +| replaced | <> | NS-VC replaced other count +| nsei-chg | <> | NS-VC changed NSEI count +| inv-nsvci | <> | NS-VCI was invalid count +| inv-nsei | <> | NSEI was invalid count +| lost:alive | <> | ALIVE ACK missing count +| lost:reset | <> | RESET ACK missing count +|=== +// rate_ctr_group table SGSN Statistics +.pcu:sgsn - SGSN Statistics +[options="header"] +|=== +| Name | Reference | Description +| rx_paging_cs | <> | Amount of paging CS requests received +| rx_paging_ps | <> | Amount of paging PS requests received +|=== // rate_ctr_group table BSSGP Peer Statistics -.bssgp:bss_ctx - BSSGP Peer Statistics +.bssgp:bss_ctx - BSSGP Peer Statistics [options="header"] |=== | Name | Reference | Description @@ -15,164 +68,141 @@ | discarded | <> | BVC LLC Discarded count | status | <> | BVC Status count |=== -// rate_ctr_group table NSVC Peer Statistics -.ns:nsvc - NSVC Peer Statistics -[options="header"] -|=== -| Name | Reference | Description -| packets:in | <> | Packets at NS Level ( In) -| packets:out | <> | Packets at NS Level (Out) -| bytes:in | <> | Bytes at NS Level ( In) -| bytes:out | <> | Bytes at NS Level (Out) -| blocked | <> | NS-VC Block count -| dead | <> | NS-VC gone dead count -| replaced | <> | NS-VC replaced other count -| nsei-chg | <> | NS-VC changed NSEI count -| inv-nsvci | <> | NS-VCI was invalid count -| inv-nsei | <> | NSEI was invalid count -| lost:alive | <> | ALIVE ACK missing count -| lost:reset | <> | RESET ACK missing count -|=== -// rate_ctr_group table NSVC Peer Statistics -.ns:nsvc - NSVC Peer Statistics -[options="header"] -|=== -| Name | Reference | Description -| packets:in | <> | Packets at NS Level ( In) -| packets:out | <> | Packets at NS Level (Out) -| bytes:in | <> | Bytes at NS Level ( In) -| bytes:out | <> | Bytes at NS Level (Out) -| blocked | <> | NS-VC Block count -| dead | <> | NS-VC gone dead count -| replaced | <> | NS-VC replaced other count -| nsei-chg | <> | NS-VC changed NSEI count -| inv-nsvci | <> | NS-VCI was invalid count -| inv-nsei | <> | NSEI was invalid count -| lost:alive | <> | ALIVE ACK missing count -| lost:reset | <> | RESET ACK missing count -|=== // rate_ctr_group table BTS Statistics -.bts - BTS Statistics +.bts - BTS Statistics [options="header"] |=== | Name | Reference | Description -| tbf:dl:alloc | <> | TBF DL Allocated -| tbf:dl:freed | <> | TBF DL Freed -| tbf:dl:aborted | <> | TBF DL Aborted -| tbf:ul:alloc | <> | TBF UL Allocated -| tbf:ul:freed | <> | TBF UL Freed -| tbf:ul:aborted | <> | TBF UL Aborted -| tbf:reused | <> | TBF Reused -| tbf:alloc:algo-a | <> | TBF Alloc Algo A -| tbf:alloc:algo-b | <> | TBF Alloc Algo B -| tbf:failed:egprs-only | <> | TBF Failed EGPRS-only -| rlc:sent | <> | RLC Sent -| rlc:resent | <> | RLC Resent -| rlc:restarted | <> | RLC Restarted -| rlc:stalled | <> | RLC Stalled -| rlc:nacked | <> | RLC Nacked -| rlc:final_block_resent | <> | RLC Final Blk resent -| rlc:ass:timedout | <> | RLC Assign Timeout -| rlc:ass:failed | <> | RLC Assign Failed -| rlc:ack:timedout | <> | RLC Ack Timeout -| rlc:ack:failed | <> | RLC Ack Failed -| rlc:rel:timedout | <> | RLC Release Timeout -| rlc:late-block | <> | RLC Late Block -| rlc:sent-dummy | <> | RLC Sent Dummy -| rlc:sent-control | <> | RLC Sent Control -| rlc:dl_bytes | <> | RLC DL Bytes -| rlc:dl_payload_bytes | <> | RLC DL Payload Bytes -| rlc:ul_bytes | <> | RLC UL Bytes -| rlc:ul_payload_bytes | <> | RLC UL Payload Bytes -| decode:errors | <> | Decode Errors -| sba:allocated | <> | SBA Allocated -| sba:freed | <> | SBA Freed -| sba:timedout | <> | SBA Timeout -| llc:timeout | <> | Timedout Frames -| llc:dropped | <> | Dropped Frames -| llc:scheduled | <> | Scheduled Frames +| tbf:dl:alloc | <> | TBF DL Allocated +| tbf:dl:freed | <> | TBF DL Freed +| tbf:dl:aborted | <> | TBF DL Aborted +| tbf:ul:alloc | <> | TBF UL Allocated +| tbf:ul:freed | <> | TBF UL Freed +| tbf:ul:aborted | <> | TBF UL Aborted +| tbf:reused | <> | TBF Reused +| tbf:alloc:algo-a | <> | TBF Alloc Algo A +| tbf:alloc:algo-b | <> | TBF Alloc Algo B +| tbf:alloc:failed | <> | TBF Alloc Failure (any reason) +| tbf:alloc:failed:no_tfi | <> | TBF Alloc Failure (TFIs exhausted) +| tbf:alloc:failed:no_usf | <> | TBF Alloc Failure (USFs exhausted) +| tbf:alloc:failed:no_slot_combi | <> | TBF Alloc Failure (No valid UL/DL slot combination found) +| tbf:alloc:failed:no_slot_avail | <> | TBF Alloc Failure (No slot available) +| rlc:sent | <> | RLC Sent +| rlc:resent | <> | RLC Resent +| rlc:restarted | <> | RLC Restarted +| rlc:stalled | <> | RLC Stalled +| rlc:nacked | <> | RLC Nacked +| rlc:final_block_resent | <> | RLC Final Blk resent +| rlc:ass:timedout | <> | RLC Assign Timeout +| rlc:ass:failed | <> | RLC Assign Failed +| rlc:ack:timedout | <> | RLC Ack Timeout +| rlc:ack:failed | <> | RLC Ack Failed +| rlc:rel:timedout | <> | RLC Release Timeout +| rlc:late-block | <> | RLC Late Block +| rlc:sent-dummy | <> | RLC Sent Dummy +| rlc:sent-control | <> | RLC Sent Control +| rlc:dl_bytes | <> | RLC DL Bytes +| rlc:dl_payload_bytes | <> | RLC DL Payload Bytes +| rlc:ul_bytes | <> | RLC UL Bytes +| rlc:ul_payload_bytes | <> | RLC UL Payload Bytes +| decode:errors | <> | Decode Errors +| sba:allocated | <> | SBA Allocated +| sba:freed | <> | SBA Freed +| sba:timedout | <> | SBA Timeout +| llc:timeout | <> | Timedout Frames +| llc:dropped | <> | Dropped Frames +| llc:scheduled | <> | Scheduled Frames | llc:dl_bytes | <> | RLC encapsulated PDUs -| llc:ul_bytes | <> | full PDUs received -| rach:requests | <> | RACH requests -| 11bit_rach:requests | <> | 11BIT_RACH requests -| spb:uplink_first_segment | <> | First seg of UL SPB -| spb:uplink_second_segment | <> | Second seg of UL SPB -| spb:downlink_first_segment | <> | First seg of DL SPB -| spb:downlink_second_segment | <> | Second seg of DL SPB -| immediate:assignment_UL | <> | Immediate Assign UL -| immediate:assignment_rej | <> | Immediate Assign Rej -| immediate:assignment_DL | <> | Immediate Assign DL -| channel:request_description | <> | Channel Request Desc -| pkt:ul_assignment | <> | Packet UL Assignment -| pkt:access_reject | <> | Packet Access Reject -| pkt:dl_assignment | <> | Packet DL Assignment -| ul:control | <> | UL control Block -| ul:assignment_poll_timeout | <> | UL Assign Timeout -| ul:assignment_failed | <> | UL Assign Failed -| dl:assignment_timeout | <> | DL Assign Timeout -| dl:assignment_failed | <> | DL Assign Failed -| pkt:ul_ack_nack_timeout | <> | PUAN Poll Timeout -| pkt:ul_ack_nack_failed | <> | PUAN poll Failed -| pkt:dl_ack_nack_timeout | <> | PDAN poll Timeout -| pkt:dl_ack_nack_failed | <> | PDAN poll Failed -| gprs:downlink_cs1 | <> | CS1 downlink -| gprs:downlink_cs2 | <> | CS2 downlink -| gprs:downlink_cs3 | <> | CS3 downlink -| gprs:downlink_cs4 | <> | CS4 downlink -| egprs:downlink_mcs1 | <> | MCS1 downlink -| egprs:downlink_mcs2 | <> | MCS2 downlink -| egprs:downlink_mcs3 | <> | MCS3 downlink -| egprs:downlink_mcs4 | <> | MCS4 downlink -| egprs:downlink_mcs5 | <> | MCS5 downlink -| egprs:downlink_mcs6 | <> | MCS6 downlink -| egprs:downlink_mcs7 | <> | MCS7 downlink -| egprs:downlink_mcs8 | <> | MCS8 downlink -| egprs:downlink_mcs9 | <> | MCS9 downlink -| gprs:uplink_cs1 | <> | CS1 Uplink -| gprs:uplink_cs2 | <> | CS2 Uplink -| gprs:uplink_cs3 | <> | CS3 Uplink -| gprs:uplink_cs4 | <> | CS4 Uplink -| egprs:uplink_mcs1 | <> | MCS1 Uplink -| egprs:uplink_mcs2 | <> | MCS2 Uplink -| egprs:uplink_mcs3 | <> | MCS3 Uplink -| egprs:uplink_mcs4 | <> | MCS4 Uplink -| egprs:uplink_mcs5 | <> | MCS5 Uplink -| egprs:uplink_mcs6 | <> | MCS6 Uplink -| egprs:uplink_mcs7 | <> | MCS7 Uplink -| egprs:uplink_mcs8 | <> | MCS8 Uplink -| egprs:uplink_mcs9 | <> | MCS9 Uplink +| llc:ul_bytes | <> | full PDUs received +| pch:requests | <> | PCH requests sent +| pch:requests:timeout | <> | PCH requests timeout +| rach:requests | <> | RACH requests received +| rach:requests:11bit | <> | 11BIT_RACH requests received +| rach:requests:one_phase | <> | One phase packet access with request for single TS UL +| rach:requests:two_phase | <> | Single block packet request for two phase packet access +| rach:requests:unexpected | <> | RACH Request with unexpected content received +| spb:uplink_first_segment | <> | First seg of UL SPB +| spb:uplink_second_segment | <> | Second seg of UL SPB +| spb:downlink_first_segment | <> | First seg of DL SPB +| spb:downlink_second_segment | <> | Second seg of DL SPB +| immediate:assignment_UL | <> | Immediate Assign UL +| immediate:assignment_ul:one_phase | <> | Immediate Assign UL (one phase packet access) +| immediate:assignment_ul:two_phase | <> | Immediate Assign UL (two phase packet access) +| immediate:assignment_ul:contention_resolution_success | <> | First RLC Block (PDU) on the PDTCH from the MS received +| immediate:assignment_rej | <> | Immediate Assign Rej +| immediate:assignment_DL | <> | Immediate Assign DL +| channel:request_description | <> | Channel Request Desc +| pkt:ul_assignment | <> | Packet UL Assignment +| pkt:access_reject | <> | Packet Access Reject +| pkt:dl_assignment | <> | Packet DL Assignment +| pkt:cell_chg_notification | <> | Packet Cell Change Notification +| pkt:cell_chg_continue | <> | Packet Cell Change Continue +| pkt:neigh_cell_data | <> | Packet Neighbour Cell Data +| ul:control | <> | UL control Block +| ul:assignment_poll_timeout | <> | UL Assign Timeout +| ul:assignment_failed | <> | UL Assign Failed +| dl:assignment_timeout | <> | DL Assign Timeout +| dl:assignment_failed | <> | DL Assign Failed +| pkt:ul_ack_nack_timeout | <> | PUAN Poll Timeout +| pkt:ul_ack_nack_failed | <> | PUAN poll Failed +| pkt:dl_ack_nack_timeout | <> | PDAN poll Timeout +| pkt:dl_ack_nack_failed | <> | PDAN poll Failed +| gprs:downlink_cs1 | <> | CS1 downlink +| gprs:downlink_cs2 | <> | CS2 downlink +| gprs:downlink_cs3 | <> | CS3 downlink +| gprs:downlink_cs4 | <> | CS4 downlink +| egprs:downlink_mcs1 | <> | MCS1 downlink +| egprs:downlink_mcs2 | <> | MCS2 downlink +| egprs:downlink_mcs3 | <> | MCS3 downlink +| egprs:downlink_mcs4 | <> | MCS4 downlink +| egprs:downlink_mcs5 | <> | MCS5 downlink +| egprs:downlink_mcs6 | <> | MCS6 downlink +| egprs:downlink_mcs7 | <> | MCS7 downlink +| egprs:downlink_mcs8 | <> | MCS8 downlink +| egprs:downlink_mcs9 | <> | MCS9 downlink +| gprs:uplink_cs1 | <> | CS1 Uplink +| gprs:uplink_cs2 | <> | CS2 Uplink +| gprs:uplink_cs3 | <> | CS3 Uplink +| gprs:uplink_cs4 | <> | CS4 Uplink +| egprs:uplink_mcs1 | <> | MCS1 Uplink +| egprs:uplink_mcs2 | <> | MCS2 Uplink +| egprs:uplink_mcs3 | <> | MCS3 Uplink +| egprs:uplink_mcs4 | <> | MCS4 Uplink +| egprs:uplink_mcs5 | <> | MCS5 Uplink +| egprs:uplink_mcs6 | <> | MCS6 Uplink +| egprs:uplink_mcs7 | <> | MCS7 Uplink +| egprs:uplink_mcs8 | <> | MCS8 Uplink +| egprs:uplink_mcs9 | <> | MCS9 Uplink |=== +=== Osmo Stat Items + // generating tables for osmo_stat_items NSVC Peer Statistics // osmo_stat_item_group table NSVC Peer Statistics -.ns.nsvc - NSVC Peer Statistics +.ns.nsvc - NSVC Peer Statistics [options="header"] |=== | Name | Reference | Description | Unit | alive.delay | <> | ALIVE response time | ms |=== -NSVC Peer Statistics -// osmo_stat_item_group table NSVC Peer Statistics -.ns.nsvc - NSVC Peer Statistics +NS Bind Statistics +// osmo_stat_item_group table NS Bind Statistics +.ns.bind - NS Bind Statistics [options="header"] |=== | Name | Reference | Description | Unit -| alive.delay | <> | ALIVE response time | ms +| tx_backlog_length | <> | Transmit backlog length | packets |=== BTS Statistics // osmo_stat_item_group table BTS Statistics -.bts - BTS Statistics +.bts - BTS Statistics [options="header"] |=== | Name | Reference | Description | Unit -| ms.present | <> | MS Present | +| ms.present | <> | MS Present | +| pdch.available | <> | PDCH available | +| pdch.occupied | <> | PDCH occupied (all) | +| pdch.occupied.gprs | <> | PDCH occupied (GPRS) | +| pdch.occupied.egprs | <> | PDCH occupied (EGPRS) | |=== -// generating tables for osmo_counters -// ungrouped osmo_counters -.ungrouped osmo counters -[options="header"] -|=== -| Name | Reference | Description -|=== - - +// there are no ungrouped osmo_counters -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 Gerrit-Change-Number: 26122 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:49:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 12:49:06 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > Please do not forget to update the manual: Table 5: bts - BTS Statistics Done here: https://gerrit.osmocom.org/c/osmo-pcu/+/26122 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 05 Nov 2021 12:49:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:49:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 12:49:09 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 12:49:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:49:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 12:49:11 +0000 Subject: Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter ...................................................................... bts: Rename 11bit RACH request counter This way it fits better the structure where the general one counts all rachs, and 11bit only the 11 bits. More per-type splitting will be done in follow-up commits where new types are added. Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 --- M src/bts.cpp M src/bts.h 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/bts.cpp b/src/bts.cpp index bd1366e..4ce036b 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -136,7 +136,7 @@ { "pch:requests", "PCH requests sent "}, { "pch:requests:timeout", "PCH requests timeout "}, { "rach:requests", "RACH requests received"}, - { "11bit_rach:requests", "11BIT_RACH requests received"}, + { "rach:requests:11bit", "11BIT_RACH requests received"}, { "spb:uplink_first_segment", "First seg of UL SPB "}, { "spb:uplink_second_segment", "Second seg of UL SPB "}, { "spb:downlink_first_segment", "First seg of DL SPB "}, @@ -880,7 +880,7 @@ bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS); if (rip->is_11bit) - bts_do_rate_ctr_inc(bts, CTR_11BIT_RACH_REQUESTS); + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_11BIT); /* Determine full frame number */ uint32_t Fn = bts_rfn_to_fn(bts, rip->rfn); diff --git a/src/bts.h b/src/bts.h index d9a86eb..63f80a8 100644 --- a/src/bts.h +++ b/src/bts.h @@ -128,7 +128,7 @@ CTR_PCH_REQUESTS, CTR_PCH_REQUESTS_TIMEDOUT, CTR_RACH_REQUESTS, - CTR_11BIT_RACH_REQUESTS, + CTR_RACH_REQUESTS_11BIT, CTR_SPB_UL_FIRST_SEGMENT, CTR_SPB_UL_SECOND_SEGMENT, CTR_SPB_DL_FIRST_SEGMENT, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 12:54:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 12:54:54 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG at 7 PS1, Line 7: pdch::rcv_resource_request(): Use local var to store bts pointer > So what's your motivation, and how it makes the code better? Because I'm adding even more uses of bts() since I'm adding new counters, and there's no point in calling bts() each time. Makes code clearer, and is also a preparation to make transition to C code easier later. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 12:54:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:06:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 13:06:09 +0000 Subject: Change in pysim[master]: contrib/jenkins.sh: make pylint warn about unnecessary semicolon References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26123 ) Change subject: contrib/jenkins.sh: make pylint warn about unnecessary semicolon ...................................................................... contrib/jenkins.sh: make pylint warn about unnecessary semicolon Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Related: OS#5292 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/26123/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 91dcdd2..e2e04e7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -38,6 +38,7 @@ python -m pylint --errors-only \ --disable E1102 \ --disable E0401 \ + --enable W0301 \ pySim *.py # attempt to build documentation -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Gerrit-Change-Number: 26123 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:14:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 13:14:08 +0000 Subject: Change in pysim[master]: contrib/jenkins.sh: make pylint warn about unnecessary semicolon In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26123 ) Change subject: contrib/jenkins.sh: make pylint warn about unnecessary semicolon ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Gerrit-Change-Number: 26123 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 13:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:17:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 13:17:09 +0000 Subject: Change in osmo-bts[master]: gsm_ts_release(): Make sure pchan{, is_want} is reset to NONE In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26113 ) Change subject: gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE ...................................................................... gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE Let's make sure all ts->pchan* related data is reset when we release the TS. This is important for pchan_is, since in bts-trx upon shutdown finish the PDCH lchan of a osmo dyn TS is set to lchan->state=LCHAN_S_NONE, and as a result when the PCU tries to release it by means of PCUIF act_req later, it may be ignored since the lchan is already in erased state. Related: SYS#4971 Change-Id: Ic7c34c0de23101ce094ffd03e00b4d2f6a551152 --- M src/common/gsm_data.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/gsm_data.c b/src/common/gsm_data.c index 4446958..e5dbf10 100644 --- a/src/common/gsm_data.c +++ b/src/common/gsm_data.c @@ -314,4 +314,8 @@ struct gsm_lchan *lchan = &ts->lchan[ln]; gsm_lchan_release(lchan, LCHAN_REL_ACT_OML); } + ts->pchan = GSM_PCHAN_NONE; + /* Make sure pchan_is is reset, since PCU act_req to release it will be + * ignored as the lchan will already be released. */ + ts->dyn.pchan_is = ts->dyn.pchan_want = GSM_PCHAN_NONE; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic7c34c0de23101ce094ffd03e00b4d2f6a551152 Gerrit-Change-Number: 26113 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:18:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 5 Nov 2021 13:18:03 +0000 Subject: Change in pysim[master]: contrib/jenkins.sh: make pylint warn about unnecessary semicolon In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26123 ) Change subject: contrib/jenkins.sh: make pylint warn about unnecessary semicolon ...................................................................... Patch Set 1: Code-Review+1 looks like we first need a patch to remove all of those semicolons: ************* Module pySim.utils pySim/utils.py:136:0: W0301: Unnecessary semicolon (unnecessary-semicolon) pySim/utils.py:246:0: W0301: Unnecessary semicolon (unnecessary-semicolon) ************* Module pySim-shell pySim-shell.py:75:0: W0301: Unnecessary semicolon (unnecessary-semicolon) pySim-shell.py:78:0: W0301: Unnecessary semicolon (unnecessary-semicolon) pySim-shell.py:83:0: W0301: Unnecessary semicolon (unnecessary-semicolon) pySim-shell.py:210:0: W0301: Unnecessary semicolon (unnecessary-semicolon) pySim-shell.py:355:0: W0301: Unnecessary semicolon (unnecessary-semicolon) Build step 'Execute shell' marked build as failure -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Gerrit-Change-Number: 26123 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 13:18:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:22:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 13:22:13 +0000 Subject: Change in pysim[master]: Python is not C: get rid of unnecessary semicolons References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26124 ) Change subject: Python is not C: get rid of unnecessary semicolons ...................................................................... Python is not C: get rid of unnecessary semicolons See https://www.python.org/dev/peps/pep-0008/. Change-Id: I9de3bcd324b0a1b98af761678996eaae85f7f790 Related: OS#5292 --- M pySim-shell.py M pySim/utils.py 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/26124/1 diff --git a/pySim-shell.py b/pySim-shell.py index 3fc5859..0be6f21 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -72,15 +72,15 @@ sl.wait_for_card(3) except NoCardError: print("No card detected!") - return None, None; + return None, None except: print("Card not readable!") - return None, None; + return None, None card = card_detect("auto", scc) if card is None: print("Could not detect card type!") - return None, None; + return None, None # Create runtime state with card profile profile = CardProfileUICC() @@ -207,7 +207,7 @@ @cmd2.with_category(CUSTOM_CATEGORY) def do_equip(self, opts): """Equip pySim-shell with card""" - rs, card = init_card(sl); + rs, card = init_card(sl) self.equip(card, rs) class InterceptStderr(list): @@ -352,7 +352,7 @@ except (KeyboardInterrupt): self.poutput("") self.poutput("Terminated by user!") - return; + return except (SystemExit): # When all cards are processed the card handler device will throw a SystemExit # exception. Also Errors that are not recoverable (cards stuck etc.) will end up here. diff --git a/pySim/utils.py b/pySim/utils.py index def88f0..68de14a 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -133,7 +133,7 @@ compr = tag.get('comprehension', False) if tag['tag'] in [0x00, 0x80, 0xff] or tag['tag'] > 0xff: # 3-byte format - byte3 = tag['tag'] & 0xff; + byte3 = tag['tag'] & 0xff byte2 = (tag['tag'] >> 8) & 0x7f if compr: byte2 |= 0x80 @@ -243,7 +243,7 @@ t |= (cls & 3) << 6 return bytes([t]) else: # multi-byte tag - t = 0x1f; + t = 0x1f if constructed: t |= 0x20 t |= (cls & 3) << 6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9de3bcd324b0a1b98af761678996eaae85f7f790 Gerrit-Change-Number: 26124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:23:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 13:23:53 +0000 Subject: Change in pysim[master]: contrib/jenkins.sh: make pylint warn about unnecessary semicolon In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26123 ) Change subject: contrib/jenkins.sh: make pylint warn about unnecessary semicolon ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+1 > > looks like we first need a patch to remove all of those semicolons: > > ************* Module pySim.utils > pySim/utils.py:136:0: W0301: Unnecessary semicolon (unnecessary-semicolon) > pySim/utils.py:246:0: W0301: Unnecessary semicolon (unnecessary-semicolon) > ************* Module pySim-shell > pySim-shell.py:75:0: W0301: Unnecessary semicolon (unnecessary-semicolon) > pySim-shell.py:78:0: W0301: Unnecessary semicolon (unnecessary-semicolon) > pySim-shell.py:83:0: W0301: Unnecessary semicolon (unnecessary-semicolon) > pySim-shell.py:210:0: W0301: Unnecessary semicolon (unnecessary-semicolon) > pySim-shell.py:355:0: W0301: Unnecessary semicolon (unnecessary-semicolon) > Build step 'Execute shell' marked build as failure Indeed, I just wanted to see if it works as expected. See https://gerrit.osmocom.org/c/pysim/+/26124. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Gerrit-Change-Number: 26123 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 13:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:27:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 13:27:10 +0000 Subject: Change in osmo-pcu[master]: doc: Update counters_generated.adoc using osmo_vty_interact.py In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26122 ) Change subject: doc: Update counters_generated.adoc using osmo_vty_interact.py ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 Gerrit-Change-Number: 26122 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 13:27:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:31:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 13:31:23 +0000 Subject: Change in osmo-pcu[master]: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26121 ) Change subject: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024 Gerrit-Change-Number: 26121 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 13:31:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 13:43:24 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 13:43:24 +0000 Subject: Change in osmo-pcu[master]: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26121 ) Change subject: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024 Gerrit-Change-Number: 26121 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 13:43:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 14:08:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 5 Nov 2021 14:08:35 +0000 Subject: Change in pysim[master]: Python is not C: get rid of unnecessary semicolons In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26124 ) Change subject: Python is not C: get rid of unnecessary semicolons ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9de3bcd324b0a1b98af761678996eaae85f7f790 Gerrit-Change-Number: 26124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 05 Nov 2021 14:08:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 14:08:57 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 5 Nov 2021 14:08:57 +0000 Subject: Change in pysim[master]: contrib/jenkins.sh: make pylint warn about unnecessary semicolon In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26123 ) Change subject: contrib/jenkins.sh: make pylint warn about unnecessary semicolon ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Gerrit-Change-Number: 26123 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 14:08:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 14:48:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 14:48:41 +0000 Subject: Change in osmo-pcu[master]: doc: Update counters_generated.adoc using osmo_vty_interact.py In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26122 ) Change subject: doc: Update counters_generated.adoc using osmo_vty_interact.py ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 Gerrit-Change-Number: 26122 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 14:48:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Nov 5 15:48:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 15:48:52 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6185527e3c520_2ea32b0a73cf05f095654@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/Debian_Testing/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 12s] [11/12] preinstalling binutils-x86-64-linux-gnu... [ 12s] [12/12] preinstalling binutils... [ 12s] copying packages... [ 17s] reordering...cycle: libc6 -> libgcc-s1 [ 17s] breaking dependency libgcc-s1 -> libc6 [ 17s] done [ 19s] booting kvm... [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 19s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM... [ 25s] c[?7l### VM INTERACTION END ### [ 25s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] Linux version: 5.3.18-59.24-default #1 SMP Mon Sep 13 15:06:42 UTC 2021 (2f872ea[ 5.411656] sysrq: Changing Loglevel [ 25s] [ 5.413282] sysrq: Loglevel set to 4 [ 25s] ) [ 25s] Increasing log level from now on... [ 25s] Enable sysrq operations [ 25s] /.build/build-vm: line 632: mkswap: command not found [ 25s] swapon: /dev/vdb: read swap header failed [ 25s] ### VM INTERACTION START ### [ 28s] [ 8.456677] sysrq: Power Off [ 28s] [ 8.460529] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] cloud124 failed "build osmocom-nightly_1.0.0.202111050026.dsc" at Fri Nov 5 15:48:43 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Nov 5 15:58:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 15:58:36 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26055 to look at the new patch set (#5). Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... commands: do not check SW manually, use send_apdu_checksw() The transport layer provides a method send_apdu_checksw to send APDUs and to be sure the SW is the expected one. Given that, there is no need to verify the SW manually. The exception of send_apdu_checksw will catch the problem and also display the SW in a human readable form. Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Related: OS#5275 --- M pySim/commands.py M pySim/utils.py 2 files changed, 30 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/26055/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 15:58:37 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 15:58:37 +0000 Subject: Change in pysim[master]: utils: cosmetic: remove stray comment References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26125 ) Change subject: utils: cosmetic: remove stray comment ...................................................................... utils: cosmetic: remove stray comment The comment is already covered by the help string, lets remove it. Change-Id: Ide2080ddb898441b6af70e32511b33ced23d0023 --- M pySim/utils.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/26125/1 diff --git a/pySim/utils.py b/pySim/utils.py index 3d4fb28..13299fb 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -56,7 +56,6 @@ b.extend(map(ord, s)) return b2h(b) -# List of bytes to string def i2s(s:List[int]) -> str: """convert from a list of integers to an ASCII string""" return ''.join([chr(x) for x in s]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ide2080ddb898441b6af70e32511b33ced23d0023 Gerrit-Change-Number: 26125 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:00:09 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 16:00:09 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26055/4/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/26055/4/pySim/commands.py at 152 PS4, Line 152: e_str = ''.join([c if c in string.printable.strip() else ' ' for c in str(e)]) > cosmetics: this is used twice, maybe move it to a function and make this more readable? I have put it in utils. Its probably not the last time we need to sanitize a string -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 05 Nov 2021 16:00:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:03:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 16:03:52 +0000 Subject: Change in pysim[master]: contrib/jenkins.sh: make pylint warn about unnecessary semicolon In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26123 ) Change subject: contrib/jenkins.sh: make pylint warn about unnecessary semicolon ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Gerrit-Change-Number: 26123 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 16:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:04:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 16:04:03 +0000 Subject: Change in pysim[master]: Python is not C: get rid of unnecessary semicolons In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26124 ) Change subject: Python is not C: get rid of unnecessary semicolons ...................................................................... Python is not C: get rid of unnecessary semicolons See https://www.python.org/dev/peps/pep-0008/. Change-Id: I9de3bcd324b0a1b98af761678996eaae85f7f790 Related: OS#5292 --- M pySim-shell.py M pySim/utils.py 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index 3fc5859..0be6f21 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -72,15 +72,15 @@ sl.wait_for_card(3) except NoCardError: print("No card detected!") - return None, None; + return None, None except: print("Card not readable!") - return None, None; + return None, None card = card_detect("auto", scc) if card is None: print("Could not detect card type!") - return None, None; + return None, None # Create runtime state with card profile profile = CardProfileUICC() @@ -207,7 +207,7 @@ @cmd2.with_category(CUSTOM_CATEGORY) def do_equip(self, opts): """Equip pySim-shell with card""" - rs, card = init_card(sl); + rs, card = init_card(sl) self.equip(card, rs) class InterceptStderr(list): @@ -352,7 +352,7 @@ except (KeyboardInterrupt): self.poutput("") self.poutput("Terminated by user!") - return; + return except (SystemExit): # When all cards are processed the card handler device will throw a SystemExit # exception. Also Errors that are not recoverable (cards stuck etc.) will end up here. diff --git a/pySim/utils.py b/pySim/utils.py index def88f0..68de14a 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -133,7 +133,7 @@ compr = tag.get('comprehension', False) if tag['tag'] in [0x00, 0x80, 0xff] or tag['tag'] > 0xff: # 3-byte format - byte3 = tag['tag'] & 0xff; + byte3 = tag['tag'] & 0xff byte2 = (tag['tag'] >> 8) & 0x7f if compr: byte2 |= 0x80 @@ -243,7 +243,7 @@ t |= (cls & 3) << 6 return bytes([t]) else: # multi-byte tag - t = 0x1f; + t = 0x1f if constructed: t |= 0x20 t |= (cls & 3) << 6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9de3bcd324b0a1b98af761678996eaae85f7f790 Gerrit-Change-Number: 26124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:04:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 16:04:03 +0000 Subject: Change in pysim[master]: contrib/jenkins.sh: make pylint warn about unnecessary semicolon In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26123 ) Change subject: contrib/jenkins.sh: make pylint warn about unnecessary semicolon ...................................................................... contrib/jenkins.sh: make pylint warn about unnecessary semicolon Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Related: OS#5292 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 91dcdd2..e2e04e7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -38,6 +38,7 @@ python -m pylint --errors-only \ --disable E1102 \ --disable E0401 \ + --enable W0301 \ pySim *.py # attempt to build documentation -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7793e30501ad109c95b207cbfada50596de17cda Gerrit-Change-Number: 26123 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:04:29 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 16:04:29 +0000 Subject: Change in pysim[master]: utils: cosmetic: remove stray comment In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26125 ) Change subject: utils: cosmetic: remove stray comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ide2080ddb898441b6af70e32511b33ced23d0023 Gerrit-Change-Number: 26125 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Nov 2021 16:04:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:05:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 5 Nov 2021 16:05:17 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 05 Nov 2021 16:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Nov 5 16:05:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:05:35 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618556621aa9b_2ea32b0a73cf05f099422@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 357s] # we create a symlink at ./srcfile.adoc pointing at [ 357s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 357s] # is like basename from coreutils, and . is WD. [ 357s] if ! [ -f test-usermanual.adoc ]; then \ [ 357s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 357s] fi [ 357s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 357s] # in ... [ 357s] TEXINPUTS=".." \ [ 357s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 357s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 357s] a2x: resource files: [] [ 357s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 357s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 357s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 357s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 357s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 357s] make[1]: *** [Makefile:363: all] Error 2 [ 357s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 357s] dh_auto_build: error: make -j1 returned exit code 2 [ 357s] make: *** [debian/rules:5: binary] Error 25 [ 357s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 357s] ### VM INTERACTION START ### [ 358s] Powering off. [ 358s] [ 341.103242] reboot: Power down [ 358s] ### VM INTERACTION END ### [ 358s] [ 358s] lamb15 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Fri Nov 5 16:05:28 UTC 2021. [ 358s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:12:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:12:23 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855806ce6f9_2ea32b0a73cf05f0103597@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 315s] # we create a symlink at ./srcfile.adoc pointing at [ 315s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 315s] # is like basename from coreutils, and . is WD. [ 315s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 315s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 315s] fi [ 315s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 315s] # in /usr/share/osmo-gsm-manuals. [ 315s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 315s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 315s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 315s] a2x: resource files: [] [ 315s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 315s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 315s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 315s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 315s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 315s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 315s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 315s] dh_auto_build: error: make -j1 returned exit code 2 [ 315s] make: *** [debian/rules:12: build] Error 25 [ 315s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 315s] ### VM INTERACTION START ### [ 316s] Powering off. [ 316s] [ 302.122669] reboot: Power down [ 316s] ### VM INTERACTION END ### [ 316s] [ 316s] sheep86 failed "build osmo-pcu_0.9.1.dsc" at Fri Nov 5 16:12:09 UTC 2021. [ 316s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:14:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:14:05 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6185585f575aa_2ea32b0a73cf05f0105130@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 413s] # is like basename from coreutils, and . is WD. [ 413s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 413s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 413s] fi [ 413s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 413s] # in /usr/share/osmo-gsm-manuals. [ 413s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 413s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 413s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 413s] a2x: resource files: [] [ 413s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 413s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 413s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 413s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 413s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 413s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 413s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 413s] make[1]: *** [Makefile:377: all] Error 2 [ 413s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 413s] dh_auto_build: error: make -j1 returned exit code 2 [ 413s] make: *** [debian/rules:45: build] Error 25 [ 413s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 413s] ### VM INTERACTION START ### [ 414s] Powering off. [ 414s] [ 396.231931] reboot: Power down [ 414s] ### VM INTERACTION END ### [ 414s] [ 414s] lamb26 failed "build osmo-gbproxy_0.1.2.dsc" at Fri Nov 5 16:13:54 UTC 2021. [ 414s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:14:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:14:05 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6185585f9d21b_2ea32b0a73cf05f01052ee@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 416s] # is like basename from coreutils, and . is WD. [ 416s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 416s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 416s] fi [ 416s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 416s] # in /usr/share/osmo-gsm-manuals. [ 416s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 416s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 416s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 416s] a2x: resource files: [] [ 416s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 416s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 416s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 416s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 416s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 416s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 416s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 416s] make[1]: *** [Makefile:392: all] Error 2 [ 416s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 416s] dh_auto_build: error: make -j1 returned exit code 2 [ 416s] make: *** [debian/rules:15: build] Error 25 [ 416s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 416s] ### VM INTERACTION START ### [ 418s] Powering off. [ 418s] [ 400.089260] reboot: Power down [ 418s] ### VM INTERACTION END ### [ 418s] [ 418s] lamb51 failed "build osmo-ggsn_1.7.1.dsc" at Fri Nov 5 16:13:56 UTC 2021. [ 418s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:14:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:14:22 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855879dfc4_2ea32b0a73cf05f010536f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 222s] # is like basename from coreutils, and . is WD. [ 222s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 222s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 222s] fi [ 222s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 222s] # in /usr/share/osmo-gsm-manuals. [ 222s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 222s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 222s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 222s] a2x: resource files: [] [ 222s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 222s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 222s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 222s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 222s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 222s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 222s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 222s] make[1]: *** [Makefile:403: all] Error 2 [ 222s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 222s] dh_auto_build: error: make -j1 returned exit code 2 [ 222s] make: *** [debian/rules:12: build] Error 25 [ 222s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 222s] ### VM INTERACTION START ### [ 223s] Powering off. [ 223s] [ 212.822650] reboot: Power down [ 223s] ### VM INTERACTION END ### [ 223s] [ 223s] goat17 failed "build libosmo-sccp_1.4.0.dsc" at Fri Nov 5 16:14:15 UTC 2021. [ 223s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:14:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:14:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6185587955bd4_2ea32b0a73cf05f0105474@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 434s] # is like basename from coreutils, and . is WD. [ 434s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 434s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 434s] fi [ 434s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 434s] # in /usr/share/osmo-gsm-manuals. [ 434s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 434s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 434s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 434s] a2x: resource files: [] [ 434s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 434s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 434s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 434s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 434s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 434s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 434s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 434s] make[1]: *** [Makefile:327: all] Error 2 [ 434s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 434s] dh_auto_build: error: make -j1 returned exit code 2 [ 434s] make: *** [debian/rules:12: build] Error 25 [ 434s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 434s] ### VM INTERACTION START ### [ 436s] Powering off. [ 436s] [ 417.546636] reboot: Power down [ 436s] ### VM INTERACTION END ### [ 436s] [ 436s] lamb02 failed "build osmo-sip-connector_1.5.1.dsc" at Fri Nov 5 16:14:08 UTC 2021. [ 436s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:16:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:16:04 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618558d217c4c_2ea32b0a73cf05f0105752@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 317s] # is like basename from coreutils, and . is WD. [ 317s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 317s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 317s] fi [ 317s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 317s] # in /usr/share/osmo-gsm-manuals. [ 317s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 317s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 317s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 317s] a2x: resource files: [] [ 317s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 317s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 317s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 317s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 317s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 317s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 317s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 317s] make[1]: *** [Makefile:371: all] Error 2 [ 317s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 317s] dh_auto_build: error: make -j1 returned exit code 2 [ 317s] make: *** [debian/rules:12: build] Error 25 [ 317s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 317s] ### VM INTERACTION START ### [ 318s] Powering off. [ 318s] [ 303.237990] reboot: Power down [ 318s] ### VM INTERACTION END ### [ 318s] [ 318s] build83 failed "build osmo-bts_1.3.3.dsc" at Fri Nov 5 16:15:54 UTC 2021. [ 318s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:16:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:16:55 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618559113484d_2ea32b0a73cf05f01066f3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 584s] # is like basename from coreutils, and . is WD. [ 584s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 584s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 584s] fi [ 584s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 584s] # in /usr/share/osmo-gsm-manuals. [ 584s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 584s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 584s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 584s] a2x: resource files: [] [ 584s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 584s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 584s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 584s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 584s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 584s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 584s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 584s] make[1]: *** [Makefile:452: all] Error 2 [ 584s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 584s] dh_auto_build: error: make -j1 returned exit code 2 [ 584s] make: *** [debian/rules:6: build] Error 25 [ 584s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 584s] ### VM INTERACTION START ### [ 585s] Powering off. [ 585s] [ 569.352201] reboot: Power down [ 585s] ### VM INTERACTION END ### [ 585s] [ 585s] old-atreju5 failed "build osmo-trx_1.3.1.dsc" at Fri Nov 5 16:16:37 UTC 2021. [ 585s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:17:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:17:12 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855914a4aa4_2ea32b0a73cf05f0107067@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 387s] # is like basename from coreutils, and . is WD. [ 387s] if ! [ -f osmomgw-usermanual.adoc ]; then \ [ 387s] ln -s osmomgw-usermanual.adoc osmomgw-usermanual.adoc; \ [ 387s] fi [ 387s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 387s] # in /usr/share/osmo-gsm-manuals. [ 387s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 387s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomgw-usermanual.adoc [ 387s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 387s] a2x: resource files: [] [ 387s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 387s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 387s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 387s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 387s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 387s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 387s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 387s] make[1]: *** [Makefile:423: all] Error 2 [ 387s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 387s] dh_auto_build: error: make -j1 returned exit code 2 [ 387s] make: *** [debian/rules:17: build] Error 25 [ 387s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 387s] ### VM INTERACTION START ### [ 388s] Powering off. [ 388s] [ 372.049500] reboot: Power down [ 389s] ### VM INTERACTION END ### [ 389s] [ 389s] lamb14 failed "build osmo-mgw_1.8.1.dsc" at Fri Nov 5 16:17:11 UTC 2021. [ 389s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:17:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:17:29 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6185592f63e8a_2ea32b0a73cf05f01072d1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 393s] # is like basename from coreutils, and . is WD. [ 393s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 393s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 393s] fi [ 393s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 393s] # in /usr/share/osmo-gsm-manuals. [ 393s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 393s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 393s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 393s] a2x: resource files: [] [ 393s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 393s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 393s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 393s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 393s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 393s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 393s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 393s] make[1]: *** [Makefile:410: all] Error 2 [ 393s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 393s] dh_auto_build: error: make -j1 returned exit code 2 [ 393s] make: *** [debian/rules:7: build] Error 25 [ 393s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 393s] ### VM INTERACTION START ### [ 395s] Powering off. [ 395s] [ 377.151241] reboot: Power down [ 395s] ### VM INTERACTION END ### [ 395s] [ 395s] old-cirrus1 failed "build osmo-hlr_1.3.1.dsc" at Fri Nov 5 16:17:15 UTC 2021. [ 395s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:18:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:18:54 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6185598853ac2_2ea32b0a73cf05f01078e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 483s] # is like basename from coreutils, and . is WD. [ 483s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 483s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 483s] fi [ 483s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 483s] # in /usr/share/osmo-gsm-manuals. [ 483s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 483s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 483s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 483s] a2x: resource files: [] [ 483s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 483s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 483s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 483s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 483s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 483s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 483s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 483s] make[1]: *** [Makefile:368: all] Error 2 [ 483s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 483s] dh_auto_build: error: make -j1 returned exit code 2 [ 483s] make: *** [debian/rules:45: build] Error 25 [ 483s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 483s] ### VM INTERACTION START ### [ 484s] Powering off. [ 484s] [ 437.530640] reboot: Power down [ 485s] ### VM INTERACTION END ### [ 485s] [ 485s] cloud106 failed "build osmo-cbc_0.2.2.dsc" at Fri Nov 5 16:18:48 UTC 2021. [ 485s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:20:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:20:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618559c26b632_2ea32b0a73cf05f0108341@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 289s] # is like basename from coreutils, and . is WD. [ 289s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 289s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 289s] fi [ 289s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 289s] # in /usr/share/osmo-gsm-manuals. [ 289s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 289s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 289s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 289s] a2x: resource files: [] [ 289s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 289s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 289s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 289s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 289s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 289s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 289s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 289s] make[1]: *** [Makefile:377: all] Error 2 [ 289s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 289s] dh_auto_build: error: make -j1 returned exit code 2 [ 289s] make: *** [debian/rules:45: build] Error 25 [ 289s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 289s] ### VM INTERACTION START ### [ 290s] Powering off. [ 290s] [ 277.116419] reboot: Power down [ 290s] ### VM INTERACTION END ### [ 290s] [ 290s] sheep85 failed "build osmo-smlc_0.2.0.dsc" at Fri Nov 5 16:19:45 UTC 2021. [ 290s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:22:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:22:35 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855a58103f6_2ea32b0a73cf05f0109171@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 275s] # is like basename from coreutils, and . is WD. [ 275s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 275s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 275s] fi [ 275s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 275s] # in /usr/share/osmo-gsm-manuals. [ 275s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 275s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 275s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 275s] a2x: resource files: [] [ 275s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 275s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 275s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 275s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 275s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 275s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 275s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 275s] make[1]: *** [Makefile:388: all] Error 2 [ 275s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 275s] dh_auto_build: error: make -j1 returned exit code 2 [ 275s] make: *** [debian/rules:45: build] Error 25 [ 275s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 275s] ### VM INTERACTION START ### [ 276s] Powering off. [ 276s] [ 264.702181] reboot: Power down [ 276s] ### VM INTERACTION END ### [ 276s] [ 276s] build71 failed "build osmo-bsc_1.7.2.dsc" at Fri Nov 5 16:22:19 UTC 2021. [ 276s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:23:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 16:23:45 +0000 Subject: Change in osmo-pcu[master]: bts: Improve logging to clarify RACH req is for 2 phase access In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26075 to look at the new patch set (#2). Change subject: bts: Improve logging to clarify RACH req is for 2 phase access ...................................................................... bts: Improve logging to clarify RACH req is for 2 phase access Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd --- M src/bts.cpp M tests/tbf/TbfTest.err 2 files changed, 23 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/26075/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd Gerrit-Change-Number: 26075 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:23:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 16:23:45 +0000 Subject: Change in osmo-pcu[master]: bts: Count RACH Request with unexpected content In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076 to look at the new patch set (#2). Change subject: bts: Count RACH Request with unexpected content ...................................................................... bts: Count RACH Request with unexpected content Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b --- M src/bts.cpp M src/bts.h 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/26076/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b Gerrit-Change-Number: 26076 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:23:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 16:23:46 +0000 Subject: Change in osmo-pcu[master]: bts: Rename assignment_{UL, DL} to be all lower-case References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26126 ) Change subject: bts: Rename assignment_{UL,DL} to be all lower-case ...................................................................... bts: Rename assignment_{UL,DL} to be all lower-case This way we have all counter all lower-case, those were not standarized. It also make sense since we added recently new subcounters. Change-Id: I8de29c7e9dd8b17719dfeb784380c685377ce117 --- M doc/manuals/chapters/counters_generated.adoc M src/bts.cpp 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/26/26126/1 diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc index ac7d16a..99f603f 100644 --- a/doc/manuals/chapters/counters_generated.adoc +++ b/doc/manuals/chapters/counters_generated.adoc @@ -125,12 +125,12 @@ | spb:uplink_second_segment | <> | Second seg of UL SPB | spb:downlink_first_segment | <> | First seg of DL SPB | spb:downlink_second_segment | <> | Second seg of DL SPB -| immediate:assignment_UL | <> | Immediate Assign UL +| immediate:assignment_ul | <> | Immediate Assign UL | immediate:assignment_ul:one_phase | <> | Immediate Assign UL (one phase packet access) | immediate:assignment_ul:two_phase | <> | Immediate Assign UL (two phase packet access) | immediate:assignment_ul:contention_resolution_success | <> | First RLC Block (PDU) on the PDTCH from the MS received | immediate:assignment_rej | <> | Immediate Assign Rej -| immediate:assignment_DL | <> | Immediate Assign DL +| immediate:assignment_dl | <> | Immediate Assign DL | channel:request_description | <> | Channel Request Desc | pkt:ul_assignment | <> | Packet UL Assignment | pkt:access_reject | <> | Packet Access Reject diff --git a/src/bts.cpp b/src/bts.cpp index 9b3440b..28844f2 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -144,12 +144,12 @@ { "spb:uplink_second_segment", "Second seg of UL SPB "}, { "spb:downlink_first_segment", "First seg of DL SPB "}, { "spb:downlink_second_segment","Second seg of DL SPB "}, - { "immediate:assignment_UL", "Immediate Assign UL "}, + { "immediate:assignment_ul", "Immediate Assign UL "}, { "immediate:assignment_ul:one_phase", "Immediate Assign UL (one phase packet access)"}, /* TS 52.402 B.2.1.50 */ { "immediate:assignment_ul:two_phase", "Immediate Assign UL (two phase packet access)"}, /* TS 52.402 B.2.1.50 */ { "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */ { "immediate:assignment_rej", "Immediate Assign Rej "}, - { "immediate:assignment_DL", "Immediate Assign DL "}, + { "immediate:assignment_dl", "Immediate Assign DL "}, { "channel:request_description","Channel Request Desc "}, { "pkt:ul_assignment", "Packet UL Assignment "}, { "pkt:access_reject", "Packet Access Reject "}, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8de29c7e9dd8b17719dfeb784380c685377ce117 Gerrit-Change-Number: 26126 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Nov 5 16:23:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:23:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855a95f06e7_2ea32b0a73cf05f01095b1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 515s] # is like basename from coreutils, and . is WD. [ 515s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 515s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 515s] fi [ 515s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 515s] # in /usr/share/osmo-gsm-manuals. [ 515s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 515s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 515s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 515s] a2x: resource files: [] [ 515s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 515s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 515s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 515s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 515s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 515s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 515s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 515s] make[1]: *** [Makefile:391: all] Error 2 [ 515s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 515s] dh_auto_build: error: make -j1 returned exit code 2 [ 515s] make: *** [debian/rules:9: build] Error 25 [ 515s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 515s] ### VM INTERACTION START ### [ 516s] Powering off. [ 516s] [ 502.334845] reboot: Power down [ 516s] ### VM INTERACTION END ### [ 516s] [ 516s] sheep87 failed "build osmo-iuh_1.0.0.dsc" at Fri Nov 5 16:23:34 UTC 2021. [ 516s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:24:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:24:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855ad38efe8_2ea32b0a73cf05f010983a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 819s] # is like basename from coreutils, and . is WD. [ 819s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 819s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 819s] fi [ 819s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 819s] # in /usr/share/osmo-gsm-manuals. [ 819s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 819s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 819s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 819s] a2x: resource files: [] [ 819s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 819s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 819s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 819s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 819s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 819s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 819s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 819s] make[1]: *** [Makefile:387: all] Error 2 [ 819s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 819s] dh_auto_build: error: make -j1 returned exit code 2 [ 819s] make: *** [debian/rules:12: build] Error 25 [ 819s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 819s] ### VM INTERACTION START ### [ 820s] Powering off. [ 820s] [ 784.997352] reboot: Power down [ 820s] ### VM INTERACTION END ### [ 820s] [ 820s] lamb03 failed "build osmo-remsim_0.2.4.dsc" at Fri Nov 5 16:24:18 UTC 2021. [ 820s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:31:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:31:05 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855ccbca496_2ea32b0a73cf05f01117e7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 391s] # is like basename from coreutils, and . is WD. [ 391s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 391s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 391s] fi [ 391s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 391s] # in /usr/share/osmo-gsm-manuals. [ 391s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 391s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 391s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 391s] a2x: resource files: [] [ 391s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 391s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 391s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 391s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 391s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 391s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 391s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 391s] make[1]: *** [Makefile:402: all] Error 2 [ 391s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 391s] dh_auto_build: error: make -j1 returned exit code 2 [ 391s] make: *** [debian/rules:45: build] Error 25 [ 391s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 391s] ### VM INTERACTION START ### [ 392s] Powering off. [ 392s] [ 374.575094] reboot: Power down [ 392s] ### VM INTERACTION END ### [ 392s] [ 392s] old-cirrus1 failed "build osmo-msc_1.7.1.dsc" at Fri Nov 5 16:30:56 UTC 2021. [ 392s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 5 16:31:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 05 Nov 2021 16:31:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61855ccc80091_2ea32b0a73cf05f01118a5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 395s] # is like basename from coreutils, and . is WD. [ 395s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 395s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 395s] fi [ 395s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 395s] # in /usr/share/osmo-gsm-manuals. [ 395s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 395s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 395s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 395s] a2x: resource files: [] [ 395s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 395s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 395s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 395s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 395s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 395s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 395s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 395s] make[1]: *** [Makefile:394: all] Error 2 [ 395s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 395s] dh_auto_build: error: make -j1 returned exit code 2 [ 395s] make: *** [debian/rules:45: build] Error 25 [ 395s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 396s] ### VM INTERACTION START ### [ 397s] Powering off. [ 397s] [ 379.090366] reboot: Power down [ 397s] ### VM INTERACTION END ### [ 397s] [ 397s] lamb54 failed "build osmo-sgsn_1.7.1.dsc" at Fri Nov 5 16:31:14 UTC 2021. [ 397s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:38:52 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 5 Nov 2021 16:38:52 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 05 Nov 2021 16:38:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:40:40 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 5 Nov 2021 16:40:40 +0000 Subject: Change in pysim[master]: commands: complete documentation strings In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26112 ) Change subject: commands: complete documentation strings ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icda245e2fd5ef4556c7736d73574dfbb48168973 Gerrit-Change-Number: 26112 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 16:40:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:54:43 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 16:54:43 +0000 Subject: Change in pysim[master]: commands: do not check SW manually, use send_apdu_checksw() In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... commands: do not check SW manually, use send_apdu_checksw() The transport layer provides a method send_apdu_checksw to send APDUs and to be sure the SW is the expected one. Given that, there is no need to verify the SW manually. The exception of send_apdu_checksw will catch the problem and also display the SW in a human readable form. Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Related: OS#5275 --- M pySim/commands.py M pySim/utils.py 2 files changed, 30 insertions(+), 16 deletions(-) Approvals: daniel: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index 805fe61..1faa00f 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -23,7 +23,7 @@ from construct import * from pySim.construct import LV -from pySim.utils import rpad, b2h, h2b, sw_match, bertlv_encode_len, Hexstr, h2i +from pySim.utils import rpad, b2h, h2b, sw_match, bertlv_encode_len, Hexstr, h2i, str_sanitize from pySim.exceptions import SwMatchError class SimCardCommands(object): @@ -145,12 +145,12 @@ while chunk_offset < length: chunk_len = min(255, length-chunk_offset) pdu = self.cla_byte + 'b0%04x%02x' % (offset + chunk_offset, chunk_len) - data,sw = self._tp.send_apdu(pdu) - if sw == '9000': - total_data += data - chunk_offset += chunk_len - else: - raise ValueError('Failed to read (offset %d)' % (offset)) + try: + data, sw = self._tp.send_apdu_checksw(pdu) + except Exception as e: + raise ValueError('%s, failed to read (offset %d)' % (str_sanitize(str(e)), offset)) + total_data += data + chunk_offset += chunk_len return total_data, sw def update_binary(self, ef, data:str, offset:int=0, verify:bool=False, conserve:bool=False): @@ -172,22 +172,21 @@ self.select_path(ef) total_data = '' - total_sw = "9000" chunk_offset = 0 while chunk_offset < data_length: chunk_len = min(255, data_length - chunk_offset) # chunk_offset is bytes, but data slicing is hex chars, so we need to multiply by 2 pdu = self.cla_byte + 'd6%04x%02x' % (offset + chunk_offset, chunk_len) + data[chunk_offset*2 : (chunk_offset+chunk_len)*2] - chunk_data, chunk_sw = self._tp.send_apdu(pdu) - if chunk_sw == total_sw: - total_data += chunk_data - chunk_offset += chunk_len - else: - total_sw = chunk_sw - raise ValueError('Failed to write chunk (chunk_offset %d, chunk_len %d)' % (chunk_offset, chunk_len)) + try: + chunk_data, chunk_sw = self._tp.send_apdu_checksw(pdu) + except Exception as e: + raise ValueError('%s, failed to write chunk (chunk_offset %d, chunk_len %d)' % \ + (str_sanitize(str(e)), chunk_offset, chunk_len)) + total_data += data + chunk_offset += chunk_len if verify: self.verify_binary(ef, data, offset) - return total_data, total_sw + return total_data, chunk_sw def verify_binary(self, ef, data:str, offset:int=0): """Verify contents of transparent EF. diff --git a/pySim/utils.py b/pySim/utils.py index 68de14a..8f2b2e9 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -5,6 +5,7 @@ import json import abc +import string from io import BytesIO from typing import Optional, List, Dict, Any, Tuple @@ -89,6 +90,20 @@ def half_round_up(n:int) -> int: return (n + 1)//2 +def str_sanitize(s:str) -> str: + """replace all non printable chars, line breaks and whitespaces, with ' ', make sure that + there are no whitespaces at the end and at the beginning of the string. + + Args: + s : string to sanitize + Returns: + filtered result of string 's' + """ + + chars_to_keep = string.digits + string.ascii_letters + string.punctuation + res = ''.join([c if c in chars_to_keep else ' ' for c in s]) + return res.strip() + ######################################################################### # poor man's COMPREHENSION-TLV decoder. ######################################################################### -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:55:01 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 16:55:01 +0000 Subject: Change in pysim[master]: utils: cosmetic: remove stray comment In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26125 ) Change subject: utils: cosmetic: remove stray comment ...................................................................... utils: cosmetic: remove stray comment The comment is already covered by the help string, lets remove it. Change-Id: Ide2080ddb898441b6af70e32511b33ced23d0023 --- M pySim/utils.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/utils.py b/pySim/utils.py index 8f2b2e9..521abd6 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -56,7 +56,6 @@ b.extend(map(ord, s)) return b2h(b) -# List of bytes to string def i2s(s:List[int]) -> str: """convert from a list of integers to an ASCII string""" return ''.join([chr(x) for x in s]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ide2080ddb898441b6af70e32511b33ced23d0023 Gerrit-Change-Number: 26125 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:55:27 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 16:55:27 +0000 Subject: Change in pysim[master]: commands: complete documentation strings In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26112 ) Change subject: commands: complete documentation strings ...................................................................... commands: complete documentation strings Some of the methods lack an explaination of the arguments. Lets add that to be complete Change-Id: Icda245e2fd5ef4556c7736d73574dfbb48168973 --- M pySim/commands.py 1 file changed, 107 insertions(+), 15 deletions(-) Approvals: daniel: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index 1faa00f..107f0f5 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -90,7 +90,12 @@ return self._tp.get_atr() def try_select_path(self, dir_list): - """ Try to select a specified path given as list of hex-string FIDs""" + """ Try to select a specified path + + Args: + dir_list : list of hex-string FIDs + """ + rv = [] if type(dir_list) is not list: dir_list = [dir_list] @@ -119,11 +124,21 @@ return rv def select_file(self, fid:str): - """Execute SELECT a given file by FID.""" + """Execute SELECT a given file by FID. + + Args: + fid : file identifier as hex string + """ + return self._tp.send_apdu_checksw(self.cla_byte + "a4" + self.sel_ctrl + "02" + fid) def select_adf(self, aid:str): - """Execute SELECT a given Applicaiton ADF.""" + """Execute SELECT a given Applicaiton ADF. + + Args: + aid : application identifier as hex string + """ + aidlen = ("0" + format(len(aid) // 2, 'x'))[-2:] return self._tp.send_apdu_checksw(self.cla_byte + "a4" + "0404" + aidlen + aid) @@ -214,6 +229,16 @@ def update_record(self, ef, rec_no:int, data:str, force_len:bool=False, verify:bool=False, conserve:bool=False): + """Execute UPDATE RECORD. + + Args: + ef : string or list of strings indicating name or path of linear fixed EF + rec_no : record number to read + data : hex string of data to be written + force_len : enforce record length by using the actual data length + verify : verify data by re-reading the record + conserve : read record and compare it with data, skip write on match + """ res = self.select_path(ef) if force_len: @@ -243,6 +268,13 @@ return res def verify_record(self, ef, rec_no:int, data:str): + """Verify record against given data + + Args: + ef : string or list of strings indicating name or path of linear fixed EF + rec_no : record number to read + data : hex string of data to be verified + """ res = self.read_record(ef, rec_no) if res[0].lower() != data.lower(): raise ValueError('Record verification failed (expected %s, got %s)' % (data.lower(), res[0].lower())) @@ -344,14 +376,24 @@ return rdata, sw def run_gsm(self, rand:str): - """Execute RUN GSM ALGORITHM.""" + """Execute RUN GSM ALGORITHM. + + Args: + rand : 16 byte random data as hex string (RAND) + """ if len(rand) != 32: raise ValueError('Invalid rand') self.select_path(['3f00', '7f20']) return self._tp.send_apdu(self.cla_byte + '88000010' + rand) def authenticate(self, rand:str, autn:str, context='3g'): - """Execute AUTHENTICATE (USIM/ISIM).""" + """Execute AUTHENTICATE (USIM/ISIM). + + Args: + rand : 16 byte random data as hex string (RAND) + autn : 8 byte Autentication Token (AUTN) + context : 16 byte random data ('3g' or 'gsm') + """ # 3GPP TS 31.102 Section 7.1.2.1 AuthCmd3G = Struct('rand'/LV, 'autn'/Optional(LV)) AuthResp3GSyncFail = Struct(Const(b'\xDC'), 'auts'/LV) @@ -379,11 +421,20 @@ return self._tp.send_apdu_constr_checksw(self.cla_byte, '04', '00', '00', None, None, None) def activate_file(self, fid): - """Execute ACTIVATE FILE command as per TS 102 221 Section 11.1.15.""" + """Execute ACTIVATE FILE command as per TS 102 221 Section 11.1.15. + + Args: + fid : file identifier as hex string + """ return self._tp.send_apdu_checksw(self.cla_byte + '44000002' + fid) def manage_channel(self, mode='open', lchan_nr=0): - """Execute MANAGE CHANNEL command as per TS 102 221 Section 11.1.17.""" + """Execute MANAGE CHANNEL command as per TS 102 221 Section 11.1.17. + + Args: + mode : logical channel operation code ('open' or 'close') + lchan_nr : logical channel number (1-19, 0=assigned by UICC) + """ if mode == 'close': p1 = 0x80 else: @@ -403,53 +454,94 @@ raise SwMatchError(sw, '9000') def verify_chv(self, chv_no:int, code:str): - """Verify a given CHV (Card Holder Verification == PIN)""" + """Verify a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + code : chv code as hex string + """ fc = rpad(b2h(code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2000' + ('%02X' % chv_no) + '08' + fc) self._chv_process_sw('verify', chv_no, code, sw) return (data, sw) def unblock_chv(self, chv_no:int, puk_code:str, pin_code:str): - """Unblock a given CHV (Card Holder Verification == PIN)""" + """Unblock a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + puk_code : puk code as hex string + pin_code : new chv code as hex string + """ fc = rpad(b2h(puk_code), 16) + rpad(b2h(pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2C00' + ('%02X' % chv_no) + '10' + fc) self._chv_process_sw('unblock', chv_no, pin_code, sw) return (data, sw) def change_chv(self, chv_no:int, pin_code:str, new_pin_code:str): - """Change a given CHV (Card Holder Verification == PIN)""" + """Change a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + pin_code : current chv code as hex string + new_pin_code : new chv code as hex string + """ fc = rpad(b2h(pin_code), 16) + rpad(b2h(new_pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2400' + ('%02X' % chv_no) + '10' + fc) self._chv_process_sw('change', chv_no, pin_code, sw) return (data, sw) def disable_chv(self, chv_no:int, pin_code:str): - """Disable a given CHV (Card Holder Verification == PIN)""" + """Disable a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + pin_code : current chv code as hex string + new_pin_code : new chv code as hex string + """ fc = rpad(b2h(pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2600' + ('%02X' % chv_no) + '08' + fc) self._chv_process_sw('disable', chv_no, pin_code, sw) return (data, sw) def enable_chv(self, chv_no:int, pin_code:str): - """Enable a given CHV (Card Holder Verification == PIN)""" + """Enable a given CHV (Card Holder Verification == PIN) + + Args: + chv_no : chv number (1=CHV1, 2=CHV2, ...) + pin_code : chv code as hex string + """ fc = rpad(b2h(pin_code), 16) data, sw = self._tp.send_apdu(self.cla_byte + '2800' + ('%02X' % chv_no) + '08' + fc) self._chv_process_sw('enable', chv_no, pin_code, sw) return (data, sw) def envelope(self, payload:str): - """Send one ENVELOPE command to the SIM""" + """Send one ENVELOPE command to the SIM + + Args: + payload : payload as hex string + """ return self._tp.send_apdu_checksw('80c20000%02x%s' % (len(payload)//2, payload)) def terminal_profile(self, payload:str): - """Send TERMINAL PROFILE to card""" + """Send TERMINAL PROFILE to card + + Args: + payload : payload as hex string + """ data_length = len(payload) // 2 data, sw = self._tp.send_apdu(('80100000%02x' % data_length) + payload) return (data, sw) # ETSI TS 102 221 11.1.22 def suspend_uicc(self, min_len_secs:int=60, max_len_secs:int=43200): - """Send SUSPEND UICC to the card.""" + """Send SUSPEND UICC to the card. + + Args: + min_len_secs : mimumum suspend time seconds + max_len_secs : maximum suspend time seconds + """ def encode_duration(secs:int) -> Hexstr: if secs >= 10*24*60*60: return '04%02x' % (secs // (10*24*60*60)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icda245e2fd5ef4556c7736d73574dfbb48168973 Gerrit-Change-Number: 26112 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 16:55:48 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 16:55:48 +0000 Subject: Change in pysim[master]: commands: return none, when offset exceeds file length In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26083 ) Change subject: commands: return none, when offset exceeds file length ...................................................................... commands: return none, when offset exceeds file length The computed length of the file may be negative, when the offset exceeds the file length. When this is the case, return none Change-Id: I2c017c620254fae188022851ef3b670730aab503 --- M pySim/commands.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index 107f0f5..cea330e 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -155,6 +155,9 @@ return (None, None) if length is None: length = self.__len(r) - offset + if length < 0: + return (None, None) + total_data = '' chunk_offset = 0 while chunk_offset < length: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2c017c620254fae188022851ef3b670730aab503 Gerrit-Change-Number: 26083 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 17:39:09 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Nov 2021 17:39:09 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_ctrl: make sure strtok results are checked References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26127 ) Change subject: osmo_bsc_ctrl: make sure strtok results are checked ...................................................................... osmo_bsc_ctrl: make sure strtok results are checked The function set_bts_loc does not check the string pointers resturned by strtok_r. In this particular case this is not a problem because the function set_bts_lock will only see verfied input. However, lets check the results anyway to avoid creating false positives in coverity scan. Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Fixes: CID#240849 --- M src/osmo-bsc/osmo_bsc_ctrl.c 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/26127/1 diff --git a/src/osmo-bsc/osmo_bsc_ctrl.c b/src/osmo-bsc/osmo_bsc_ctrl.c index 1eea690..969efb5 100644 --- a/src/osmo-bsc/osmo_bsc_ctrl.c +++ b/src/osmo-bsc/osmo_bsc_ctrl.c @@ -428,6 +428,20 @@ if (!tmp) goto oom; + tstamp = strtok_r(tmp, ",", &saveptr); + valid = strtok_r(NULL, ",", &saveptr); + lat = strtok_r(NULL, ",", &saveptr); + lon = strtok_r(NULL, ",", &saveptr); + height = strtok_r(NULL, "\0", &saveptr); + + /* Check if one of the strtok results was NULL. This will probably never occur since we will only see verified + * input in this code path */ + if ((tstamp == NULL) || (valid == NULL) || (lat == NULL) || (lon == NULL) || (height == NULL)) { + talloc_free(tmp); + cmd->reply = "parse error"; + return CTRL_CMD_ERROR; + } + curloc = talloc_zero(tall_bsc_ctx, struct bts_location); if (!curloc) { talloc_free(tmp); @@ -435,13 +449,6 @@ } INIT_LLIST_HEAD(&curloc->list); - - tstamp = strtok_r(tmp, ",", &saveptr); - valid = strtok_r(NULL, ",", &saveptr); - lat = strtok_r(NULL, ",", &saveptr); - lon = strtok_r(NULL, ",", &saveptr); - height = strtok_r(NULL, "\0", &saveptr); - curloc->tstamp = atol(tstamp); curloc->valid = get_string_value(bts_loc_fix_names, valid); curloc->lat = atof(lat); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Gerrit-Change-Number: 26127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 17:45:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 17:45:10 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_ctrl: make sure strtok results are checked In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26127 ) Change subject: osmo_bsc_ctrl: make sure strtok results are checked ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26127/1/src/osmo-bsc/osmo_bsc_ctrl.c File src/osmo-bsc/osmo_bsc_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26127/1/src/osmo-bsc/osmo_bsc_ctrl.c at 447 PS1, Line 447: talloc_free(tmp); You can actually move this talloc_free to be under oom tag. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Gerrit-Change-Number: 26127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 17:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 17:47:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 17:47:28 +0000 Subject: Change in osmo-bts[master]: lchan: fix band calculation in gsm_lchan_interf_meas_calc_avg() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26128 ) Change subject: lchan: fix band calculation in gsm_lchan_interf_meas_calc_avg() ...................................................................... lchan: fix band calculation in gsm_lchan_interf_meas_calc_avg() This patch makes osmo-bts bahave similar to ip.access nanoBTS. Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Related: SYS#5313 --- M src/common/lchan.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/26128/1 diff --git a/src/common/lchan.c b/src/common/lchan.c index 29fd247..ec1b175 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -464,8 +464,11 @@ /* Calculate the average of all collected samples */ meas_avg = meas_sum / (int) meas_num; - /* Determine the band using interference boundaries from BSC */ - for (b = 0; b < ARRAY_SIZE(bts->interference.boundary); b++) { + /* 3GPP TS 48.008 defines 5 interference bands, and 6 interference level + * boundaries (0, X1, ... X5). It's not clear how to handle values + * exceeding the outer boundaries (0 or X5), because bands 0 and 6 do + * not exist (sigh). Let's map such values to closest bands 1 and 5. */ + for (b = 1; b < ARRAY_SIZE(bts->interference.boundary) - 1; b++) { if (meas_avg >= bts->interference.boundary[b]) break; /* Current 'b' is the band value */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Gerrit-Change-Number: 26128 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 17:47:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 17:47:28 +0000 Subject: Change in osmo-bts[master]: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26129 ) Change subject: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() ...................................................................... oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() Change-Id: I89dab55e39fe49c8b4d3afb4b46d1b7f2bf3663c --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/29/26129/1 diff --git a/src/common/oml.c b/src/common/oml.c index 30caad5..a434ad3 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -598,7 +598,7 @@ /* 9.4.25 Interference Level Boundaries */ if (TLVP_PRES_LEN(&tp, NM_ATT_INTERF_BOUND, 6)) { payload = TLVP_VAL(&tp, NM_ATT_INTERF_BOUND); - for (i = 0; i < 6; i++) { + for (i = 0; i < ARRAY_SIZE(bts->interference.boundary); i++) { const int16_t boundary = payload[i]; bts->interference.boundary[i] = -1 * boundary; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I89dab55e39fe49c8b4d3afb4b46d1b7f2bf3663c Gerrit-Change-Number: 26129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 17:50:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 17:50:31 +0000 Subject: Change in osmo-bts[master]: lchan: fix band calculation in gsm_lchan_interf_meas_calc_avg() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26128 ) Change subject: lchan: fix band calculation in gsm_lchan_interf_meas_calc_avg() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Gerrit-Change-Number: 26128 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Nov 2021 17:50:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 17:50:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 17:50:39 +0000 Subject: Change in osmo-bts[master]: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26129 ) Change subject: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I89dab55e39fe49c8b4d3afb4b46d1b7f2bf3663c Gerrit-Change-Number: 26129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Nov 2021 17:50:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 18:10:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 18:10:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Improve counter validation References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 ) Change subject: pcu: Improve counter validation ...................................................................... pcu: Improve counter validation Validate some new counters recently added in osmo-pcu. Use new naming for assignment_{UL,DL}, which were renamed to be lower-case. Tests on older version will still work by checking the older name. Related: SYS#4878 Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff --- M pcu/PCU_Tests.ttcn 1 file changed, 192 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/26130/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 2daf89b..dbe5f80 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -2383,6 +2383,22 @@ var template (present) CodingScheme exp_dl_cs_mcs := cs_gprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); + + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } } testcase TC_mo_ping_pong_with_ul_racap_egprs_only() runs on RAW_PCU_Test_CT { @@ -2390,6 +2406,21 @@ var template (present) CodingScheme exp_dl_cs_mcs := mcs_egprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_default, ms_racap_egprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } } testcase TC_force_two_phase_access() runs on RAW_PCU_Test_CT { @@ -2400,6 +2431,22 @@ var template (present) CodingScheme exp_dl_cs_mcs := cs_gprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); + + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } } /* Test scenario where SGSN wants to send some data against MS and it is @@ -2674,13 +2721,22 @@ var StatsDExpects expect := { { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 0, max := 0}, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 1, max := 1}, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0}, { name := "TTCN3.bts.0.tbf.dl.alloc", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.tbf.ul.alloc", mtype := "c", min := 0, max := 0}, { name := "TTCN3.bts.0.rlc.dl_payload_bytes", mtype := "c", min := 64, max := 64}, { name := "TTCN3.bts.0.rlc.ul_payload_bytes", mtype := "c", min := 0, max := 0} }; + if (mp_osmo_pcu_newer_than_0_9_0) { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 0, max := 0} + }; + } else { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0} + }; + } f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); @@ -3054,6 +3110,7 @@ /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); /* Establish BSSGP connection to the PCU */ f_bssgp_establish(); @@ -3094,6 +3151,22 @@ /* ACK the ACK */ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3487,12 +3560,22 @@ var StatsDExpects expect := { { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1}, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.tbf.dl.alloc", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.tbf.ul.alloc", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.rlc.dl_payload_bytes", mtype := "c", min := 10, max := 10}, { name := "TTCN3.bts.0.rlc.ul_payload_bytes", mtype := "c", min := 26, max := 26} }; + if (mp_osmo_pcu_newer_than_0_9_0) { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1} + }; + } else { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1} + }; + } f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); @@ -3628,16 +3711,18 @@ var template GsmRrMessage imm_ass; var template IaRestOctets rest; var template EgprsUlAss ul_ass; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ signalling := { tag := '110011'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { var BIT5 ext_ra := int2bit(f_rnd_int(32), 5); req.signalling.random_bits := ext_ra; @@ -3649,6 +3734,21 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3656,16 +3756,18 @@ var template GsmRrMessage imm_ass; var template IaRestOctets rest; var template EgprsUlAss ul_ass; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ one_phase := { tag := '0'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { var BIT5 ext_ra := int2bit(f_rnd_int(32), 5); var BIT5 mslot_class := int2bit(f_rnd_int(32), 5); var BIT2 priority := substr(ext_ra, 0, 2); @@ -3683,6 +3785,21 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3690,16 +3807,18 @@ var template GsmRrMessage imm_ass; var template IaRestOctets rest; var template EgprsUlAss ul_ass; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ two_phase := { tag := '110000'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { var BIT5 ext_ra := int2bit(f_rnd_int(32), 5); var BIT2 priority := substr(ext_ra, 0, 2); var BIT3 rand := substr(ext_ra, 2, 3); @@ -3715,6 +3834,21 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3767,11 +3901,13 @@ testcase TC_egprs_pkt_chan_req_reject_content() runs on RAW_PCU_Test_CT { var template IARRestOctets rest; var BIT5 ext_ra; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { ext_ra := int2bit(f_rnd_int(32), 5); /* 5 LSB's of RA11 */ rest := tr_IARRestOctets({ *, tr_ExtRAOpt(ext_ra), * }); @@ -3779,6 +3915,20 @@ f_TC_egprs_pkt_chan_req_reject('111111'B & ext_ra, 1337 + i, rest); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3788,16 +3938,18 @@ var template IARRestOctets rest; var BIT5 ext_ra; var BIT11 ra11; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ emergency := { tag := '110111'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { ext_ra := int2bit(f_rnd_int(32), 5); /* 5 LSB's of RA11 */ rest := tr_IARRestOctets({ *, tr_ExtRAOpt(ext_ra), * }); @@ -3808,6 +3960,20 @@ f_TC_egprs_pkt_chan_req_reject(ra11, 1337 + i, rest); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3826,6 +3992,7 @@ /* Initialize the PCU interface abstraction */ f_init_raw(testcasename(), info_ind); + f_statsd_reset(); var EGPRSPktChRequest req := { one_phase := { @@ -3849,6 +4016,23 @@ /* At this point, the IUT should run out of free USFs */ f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff Gerrit-Change-Number: 26130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 18:26:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 18:26:37 +0000 Subject: Change in osmo-pcu[master]: bts: Introduce new RACH req counters for one/two phase access In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26074 ) Change subject: bts: Introduce new RACH req counters for one/two phase access ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id87c3a53d3acee92499987c843130e358f54742c Gerrit-Change-Number: 26074 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 18:26:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 19:08:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 19:08:43 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): fix band calculation In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26128 to look at the new patch set (#2). Change subject: gsm_lchan_interf_meas_calc_avg(): fix band calculation ...................................................................... gsm_lchan_interf_meas_calc_avg(): fix band calculation This patch makes osmo-bts bahave similar to ip.access nanoBTS. Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Related: SYS#5313 --- M src/common/lchan.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/26128/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Gerrit-Change-Number: 26128 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 19:09:01 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 19:09:01 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 05 Nov 2021 19:09:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 19:09:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 19:09:42 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): fix band calculation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26128 ) Change subject: gsm_lchan_interf_meas_calc_avg(): fix band calculation ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Gerrit-Change-Number: 26128 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 19:09:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 19:11:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 19:11:51 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 19:11:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 19:46:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 19:46:37 +0000 Subject: Change in osmo-pcu[master]: vty: Log tbf_state when showing a TBF References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26131 ) Change subject: vty: Log tbf_state when showing a TBF ...................................................................... vty: Log tbf_state when showing a TBF That's one of the most important information bits about a TBF when debugging, and it's not shown currently, only when "show ms" is used. Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945 --- M src/pcu_vty_functions.cpp 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/31/26131/1 diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index 21851df..fb7897d 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -54,8 +54,9 @@ tbf->ta(), tbf->direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", tbf->imsi(), VTY_NEWLINE); - vty_out(vty, " created=%lu state=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s", - tbf->created_ts(), tbf->state_fsm.state_flags, + vty_out(vty, " created=%lu state=%s flags=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s", + tbf->created_ts(), tbf->state_name(), + tbf->state_fsm.state_flags, tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH), tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH), tbf->first_ts, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945 Gerrit-Change-Number: 26131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 19:46:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 19:46:37 +0000 Subject: Change in osmo-pcu[master]: vty: show tbf: Drop unneeded check for non-null ms References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26132 ) Change subject: vty: show tbf: Drop unneeded check for non-null ms ...................................................................... vty: show tbf: Drop unneeded check for non-null ms Since a while a go, a TBF is guaranteed to always have a MS assigned. Hence, there's no point in checking it. Change-Id: I89e062432ac671c73731ce68c889aeb5e24277f5 --- M src/pcu_vty_functions.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/32/26132/1 diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index fb7897d..c2cc950 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -62,7 +62,7 @@ tbf->first_ts, tbf->first_common_ts, tbf->control_ts, tbf->ms_class(), - tbf->ms() ? ms_egprs_ms_class(tbf->ms()) : -1, + ms_egprs_ms_class(tbf->ms()), VTY_NEWLINE); vty_out(vty, " TS_alloc="); for (int i = 0; i < 8; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I89e062432ac671c73731ce68c889aeb5e24277f5 Gerrit-Change-Number: 26132 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 20:02:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 20:02:08 +0000 Subject: Change in osmo-pcu[master]: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26121 ) Change subject: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024 Gerrit-Change-Number: 26121 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Nov 2021 20:02:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 20:02:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Nov 2021 20:02:10 +0000 Subject: Change in osmo-pcu[master]: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26121 ) Change subject: vty: Avoid crash in tbf_print_vty_info with null ptr ctrg ...................................................................... vty: Avoid crash in tbf_print_vty_info with null ptr ctrg Previous code did use a ctrg based on MS being EGPRS capable or not. However, an MS being EGPRS capable doesn't mean necessarily that all its TBFs are EGPRS, since we may known about the capability after we already created some previous TBF, so it was not ugpraded. Hence, we were sometimes accessing the wrong NULL ctrg. Let's simply check for non NULL ctrg when deciding what to print. """ Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7561ea6 in vty_out_rate_ctr_group (vty=vty at entry=0x897850, prefix=prefix at entry=0x4482cd " ", ctrg=0x0) at utils.c:82 82 utils.c: No such file or directory. (gdb) bt #0 0x00007ffff7561ea6 in vty_out_rate_ctr_group (vty=vty at entry=0x897850, prefix=prefix at entry=0x4482cd " ", ctrg=0x0) at utils.c:82 #1 0x000000000041437b in tbf_print_vty_info (vty=vty at entry=0x897850, tbf=0x3fb61f0) at pcu_vty_functions.cpp:98 #2 0x0000000000414acc in pcu_vty_show_tbf_all (vty=vty at entry=0x897850, bts=bts at entry=0x7be650, flags=4294967295) at pcu_vty_functions.cpp:127 #3 0x000000000041206f in show_tbf (self=, vty=0x897850, argc=, argv=0x7fffffffe040) at pcu_vty.c:1150 #4 0x00007ffff755d167 in cmd_execute_command_real (vline=vline at entry=0x7bc300, vty=vty at entry=0x897850, cmd=) at command.c:2604 """ Related: SYS#5689 Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024 --- M src/pcu_vty_functions.cpp 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index 657e5a1..21851df 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -79,11 +79,10 @@ ul_tbf->window_size(), win->v_q(), win->v_r()); vty_out(vty, "%s", VTY_NEWLINE); vty_out(vty, " TBF Statistics:%s", VTY_NEWLINE); - if (GPRS == ms_mode(tbf->ms())) { + if (ul_tbf->m_ul_gprs_ctrs) vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_gprs_ctrs); - } else { + if (ul_tbf->m_ul_egprs_ctrs) vty_out_rate_ctr_group(vty, " ", ul_tbf->m_ul_egprs_ctrs); - } } if (dl_tbf) { gprs_rlc_dl_window *win = static_cast(dl_tbf->window()); @@ -92,11 +91,10 @@ win->window_stalled() ? " STALLED" : ""); vty_out(vty, "%s", VTY_NEWLINE); vty_out_rate_ctr_group(vty, " ", tbf->m_ctrs); - if (GPRS == ms_mode(tbf->ms())) { + if (dl_tbf->m_dl_gprs_ctrs) vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_gprs_ctrs); - } else { + if (dl_tbf->m_dl_egprs_ctrs) vty_out_rate_ctr_group(vty, " ", dl_tbf->m_dl_egprs_ctrs); - } } vty_out(vty, "%s%s", VTY_NEWLINE, VTY_NEWLINE); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024 Gerrit-Change-Number: 26121 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 21:19:01 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 21:19:01 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26056 ) Change subject: doc/manuals: add documentation for interference reporting ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Nov 2021 21:19:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 21:51:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 21:51:44 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26133 ) Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... gsm_data: use ascending order for interference boundaries It's more logical to have the boundaries sorted in ascending order: * band 1 represents lowest interference levels, * band 5 represents highest interference levels. Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Related: SYS#5313 --- M doc/manuals/chapters/interf_meas.adoc M src/osmo-bsc/gsm_data.c 2 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/26133/1 diff --git a/doc/manuals/chapters/interf_meas.adoc b/doc/manuals/chapters/interf_meas.adoc index c54b2a6..9e93faa 100644 --- a/doc/manuals/chapters/interf_meas.adoc +++ b/doc/manuals/chapters/interf_meas.adoc @@ -19,7 +19,7 @@ network bts 0 interference-meas avg-period 6 <1> - interference-meas level-bounds -85 <2> -91 -97 -103 -109 -115 <3> + interference-meas level-bounds -115 <2> -109 -103 -97 -91 -85 <3> ---- <1> Averaging period (`Intave`) in SACCH multiframe periods (480ms). <2> Interference level boundary `0` (in dBm). @@ -34,11 +34,11 @@ averaged interference levels (initially in dBm) into these 5 bands. ---- --85 dBm -91 dBm -97 dBm -103 dBm -109 dBm -115 dBm - | | | | | | - +----------+----------+----------+----------+----------+ - | band 1 | band 2 | band 3 | band 4 | band 5 | - +----------+----------+----------+----------+----------+ +-115 dBm -109 dBm -103 dBm -97 dBm -91 dBm -85 dBm + | | | | | | + +----------+----------+----------+----------+----------+ + | band 1 | band 2 | band 3 | band 4 | band 5 | + +----------+----------+----------+----------+----------+ ---- Unfortunately, it's not claer how to map dBm values exceeding the outer diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 0134e34..988d70e 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -1120,12 +1120,12 @@ const struct gsm_interf_meas_params interf_meas_params_def = { .avg_period = 6, /* 6 SACCH periods */ .bounds_dbm = { - 85, /* 0: -85 dBm */ - 91, /* X1: -91 dBm */ - 97, /* X2: -97 dBm */ - 103, /* X3: -103 dBm */ - 109, /* X4: -109 dBm */ - 115, /* X5: -115 dBm */ + 115, /* 0: -115 dBm */ + 109, /* X1: -109 dBm */ + 103, /* X2: -103 dBm */ + 97, /* X3: -97 dBm */ + 91, /* X4: -91 dBm */ + 85, /* X5: -85 dBm */ }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 22:05:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 22:05:26 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 to look at the new patch set (#2). Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... gsm_data: use ascending order for interference boundaries It's more logical to have the boundaries sorted in ascending order: * band 1 represents lowest interference levels, * band 5 represents highest interference levels. Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Related: SYS#5313 --- M doc/manuals/chapters/interf_meas.adoc M src/osmo-bsc/gsm_data.c M tests/nanobts_omlattr/nanobts_omlattr_test.c 3 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/26133/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 22:17:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 22:17:22 +0000 Subject: Change in osmo-pcu[master]: bts: Introduce new RACH req counters for one/two phase access In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26074 ) Change subject: bts: Introduce new RACH req counters for one/two phase access ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id87c3a53d3acee92499987c843130e358f54742c Gerrit-Change-Number: 26074 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 22:17:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 22:17:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 22:17:37 +0000 Subject: Change in osmo-pcu[master]: bts: Improve logging to clarify RACH req is for 2 phase access In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26075 ) Change subject: bts: Improve logging to clarify RACH req is for 2 phase access ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd Gerrit-Change-Number: 26075 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 22:17:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 22:18:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 22:18:00 +0000 Subject: Change in osmo-pcu[master]: bts: Count RACH Request with unexpected content In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26076 ) Change subject: bts: Count RACH Request with unexpected content ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b Gerrit-Change-Number: 26076 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 22:18:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 22:18:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 22:18:40 +0000 Subject: Change in osmo-pcu[master]: bts: Add counters for successful 1, 2 phase pkt access In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26077 ) Change subject: bts: Add counters for successful 1,2 phase pkt access ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26077/2/src/bts.h File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/26077/2/src/bts.h at 140 PS2, Line 140: CTR_IMMEDIATE_ASSIGN_UL_TBF_1_PHASE, Same here, let's better use _ONE_ and _TWO_. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 Gerrit-Change-Number: 26077 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 22:18:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 22:19:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 22:19:35 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG at 7 PS1, Line 7: pdch::rcv_resource_request(): Use local var to store bts pointer > Because I'm adding even more uses of bts() since I'm adding new counters, and there's no point in ca [?] This should be in the commit description. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 05 Nov 2021 22:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 22:24:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 22:24:07 +0000 Subject: Change in osmo-pcu[master]: bts: Rename assignment_{UL, DL} to be all lower-case In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26126 ) Change subject: bts: Rename assignment_{UL,DL} to be all lower-case ...................................................................... Patch Set 1: Code-Review-1 I have the same opinion here: this is another rather cosmetic change potentially breaking reporting expectations for our users. I also don't like this inconsistency, but IMO we should not break things just because of that. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8de29c7e9dd8b17719dfeb784380c685377ce117 Gerrit-Change-Number: 26126 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 05 Nov 2021 22:24:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 5 23:57:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Nov 2021 23:57:08 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 to look at the new patch set (#4). Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries The ordering of interference level boundaries is not clearly defined by 3GPP, so we should support both ascending and descending variants. The idea is to always store the boundaries in ascending order, even if the BSC sends them in descending order. Determine the ordering in oml_rx_set_bts_attr(), and create a mapping between the array indexes in bts->interference.boundary[] and the actual band values. Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Related: SYS#5313 --- M include/osmo-bts/bts.h M src/common/lchan.c M src/common/oml.c 3 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/25734/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 00:10:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 00:10:57 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 to look at the new patch set (#3). Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... gsm_data: use ascending order for interference boundaries It's more logical to have the boundaries sorted in ascending order: * band 1 represents lowest interference levels, * band 5 represents highest interference levels. Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Related: SYS#5313 --- M doc/manuals/chapters/interf_meas.adoc M src/osmo-bsc/gsm_data.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 4 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/26133/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 00:18:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 00:18:26 +0000 Subject: Change in osmo-pcu[master]: vty: Log tbf_state when showing a TBF In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26131 ) Change subject: vty: Log tbf_state when showing a TBF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945 Gerrit-Change-Number: 26131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 06 Nov 2021 00:18:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 00:18:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 00:18:39 +0000 Subject: Change in osmo-pcu[master]: vty: show tbf: Drop unneeded check for non-null ms In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26132 ) Change subject: vty: show tbf: Drop unneeded check for non-null ms ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I89e062432ac671c73731ce68c889aeb5e24277f5 Gerrit-Change-Number: 26132 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 06 Nov 2021 00:18:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 00:54:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 00:54:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 ) Change subject: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I235027c2b53b8f2ae975e25eb7c38b1959668d6f Gerrit-Change-Number: 25949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Sat, 06 Nov 2021 00:54:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 00:54:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 00:54:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 ) Change subject: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() ...................................................................... BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment() This test case fails in ttcn3-bsc-test-sccplite due to: BSC_Tests.ttcn:10212 Dynamic test case error: Using the value of an optional field containing omit. Change-Id: I235027c2b53b8f2ae975e25eb7c38b1959668d6f Related: SYS#5627 --- M bsc/BSC_Tests.ttcn 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index ad8f666..f602929 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -10311,11 +10311,9 @@ * Activ Ack (SYS#5627). */ private function f_TC_lost_sdcch_during_assignment(charstring id) runs on MSC_ConnHdlr { var PDU_BSSAP ass_cmd := f_gen_ass_req(); - if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_AoIP) { - ass_cmd.pdu.bssmap.assignmentRequest.codecList := g_pars.ass_codec_list; - } - ass_cmd.pdu.bssmap.assignmentRequest.channelType := - f_BSSMAP_chtype_from_codec(g_pars.ass_codec_list.codecElements[0]); + + ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType); + ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); var BSSMAP_FIELD_CodecType codecType; codecType := valueof(ass_cmd.pdu.bssmap.assignmentRequest.codecList.codecElements[0].codecType); @@ -10389,7 +10387,6 @@ f_init(1, true); f_sleep(1.0); - pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); vc_conn := f_start_handler(refers(f_TC_lost_sdcch_during_assignment), pars); vc_conn.done; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I235027c2b53b8f2ae975e25eb7c38b1959668d6f Gerrit-Change-Number: 25949 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Sat Nov 6 03:48:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 03:48:09 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185fb025b5cd_2ea32b0a73cf05f02710f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 508s] # we create a symlink at ./srcfile.adoc pointing at [ 508s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 508s] # is like basename from coreutils, and . is WD. [ 508s] if ! [ -f test-usermanual.adoc ]; then \ [ 508s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 508s] fi [ 508s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 508s] # in ... [ 508s] TEXINPUTS=".." \ [ 508s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 509s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 509s] a2x: resource files: [] [ 509s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 509s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 509s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 509s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 509s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 509s] make[1]: *** [Makefile:363: all] Error 2 [ 509s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 509s] dh_auto_build: error: make -j1 returned exit code 2 [ 509s] make: *** [debian/rules:5: binary] Error 25 [ 509s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 509s] ### VM INTERACTION START ### [ 510s] Powering off. [ 510s] [ 490.139151] reboot: Power down [ 510s] ### VM INTERACTION END ### [ 510s] [ 510s] lamb58 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Sat Nov 6 03:48:06 UTC 2021. [ 510s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 03:54:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 03:54:26 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185fc87d241c_2ea32b0a73cf05f02724aa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 321s] # is like basename from coreutils, and . is WD. [ 321s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 321s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 321s] fi [ 321s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 321s] # in /usr/share/osmo-gsm-manuals. [ 321s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 321s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 321s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 321s] a2x: resource files: [] [ 321s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 321s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 321s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 321s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 321s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 321s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 321s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 321s] make[1]: *** [Makefile:377: all] Error 2 [ 321s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 321s] dh_auto_build: error: make -j1 returned exit code 2 [ 321s] make: *** [debian/rules:45: build] Error 25 [ 321s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 321s] ### VM INTERACTION START ### [ 322s] Powering off. [ 322s] [ 303.779743] reboot: Power down [ 322s] ### VM INTERACTION END ### [ 322s] [ 322s] wildcard2 failed "build osmo-gbproxy_0.1.2.dsc" at Sat Nov 6 03:54:24 UTC 2021. [ 322s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 03:56:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 03:56:09 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185fce5c03a4_2ea32b0a73cf05f027290@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 420s] # is like basename from coreutils, and . is WD. [ 420s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 420s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 420s] fi [ 420s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 420s] # in /usr/share/osmo-gsm-manuals. [ 420s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 420s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 421s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 421s] a2x: resource files: [] [ 421s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 421s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 421s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 421s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 421s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 421s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 421s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 421s] make[1]: *** [Makefile:392: all] Error 2 [ 421s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 421s] dh_auto_build: error: make -j1 returned exit code 2 [ 421s] make: *** [debian/rules:15: build] Error 25 [ 421s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 421s] ### VM INTERACTION START ### [ 422s] Powering off. [ 422s] [ 401.011071] reboot: Power down [ 422s] ### VM INTERACTION END ### [ 422s] [ 422s] build81 failed "build osmo-ggsn_1.7.1.dsc" at Sat Nov 6 03:56:08 UTC 2021. [ 422s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 03:57:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 03:57:00 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185fd1f2833c_2ea32b0a73cf05f02731a4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 271s] # is like basename from coreutils, and . is WD. [ 271s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 271s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 271s] fi [ 271s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 271s] # in /usr/share/osmo-gsm-manuals. [ 271s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 271s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 271s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 271s] a2x: resource files: [] [ 271s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 271s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 271s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 271s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 271s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 271s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 271s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 271s] make[1]: *** [Makefile:368: all] Error 2 [ 271s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 271s] dh_auto_build: error: make -j1 returned exit code 2 [ 271s] make: *** [debian/rules:45: build] Error 25 [ 271s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 271s] ### VM INTERACTION START ### [ 272s] Powering off. [ 272s] [ 256.540109] reboot: Power down [ 272s] ### VM INTERACTION END ### [ 272s] [ 272s] goat05 failed "build osmo-cbc_0.2.2.dsc" at Sat Nov 6 03:56:56 UTC 2021. [ 272s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 03:57:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 03:57:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185fd1fd65f5_2ea32b0a73cf05f02732b8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 487s] # we create a symlink at ./srcfile.adoc pointing at [ 487s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 487s] # is like basename from coreutils, and . is WD. [ 487s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 487s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 487s] fi [ 487s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 487s] # in /usr/share/osmo-gsm-manuals. [ 487s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 487s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 487s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 487s] a2x: resource files: [] [ 487s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 487s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 487s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 487s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 487s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 487s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 487s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 487s] dh_auto_build: error: make -j1 returned exit code 2 [ 487s] make: *** [debian/rules:12: build] Error 25 [ 487s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 487s] ### VM INTERACTION START ### [ 488s] Powering off. [ 488s] [ 468.410353] reboot: Power down [ 488s] ### VM INTERACTION END ### [ 488s] [ 488s] old-atreju4 failed "build osmo-pcu_0.9.1.dsc" at Sat Nov 6 03:57:13 UTC 2021. [ 488s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 03:58:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 03:58:09 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185fd5e92fd5_2ea32b0a73cf05f02733ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 320s] # is like basename from coreutils, and . is WD. [ 320s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 320s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 320s] fi [ 320s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 320s] # in /usr/share/osmo-gsm-manuals. [ 320s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 320s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 320s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 320s] a2x: resource files: [] [ 320s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 320s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 320s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 320s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 320s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 320s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 320s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 320s] make[1]: *** [Makefile:452: all] Error 2 [ 320s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 320s] dh_auto_build: error: make -j1 returned exit code 2 [ 320s] make: *** [debian/rules:6: build] Error 25 [ 320s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 320s] ### VM INTERACTION START ### [ 321s] Powering off. [ 321s] [ 305.802660] reboot: Power down [ 321s] ### VM INTERACTION END ### [ 321s] [ 321s] goat19 failed "build osmo-trx_1.3.1.dsc" at Sat Nov 6 03:58:03 UTC 2021. [ 321s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:04:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:04:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185fec498e5a_2ea32b0a73cf05f0274244@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 521s] # is like basename from coreutils, and . is WD. [ 521s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 521s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 521s] fi [ 521s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 521s] # in /usr/share/osmo-gsm-manuals. [ 521s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 521s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 521s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 521s] a2x: resource files: [] [ 521s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 521s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 521s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 521s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 521s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 521s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 521s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 521s] make[1]: *** [Makefile:371: all] Error 2 [ 521s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 521s] dh_auto_build: error: make -j1 returned exit code 2 [ 521s] make: *** [debian/rules:12: build] Error 25 [ 521s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 521s] ### VM INTERACTION START ### [ 522s] Powering off. [ 522s] [ 497.603243] reboot: Power down [ 523s] ### VM INTERACTION END ### [ 523s] [ 523s] lamb13 failed "build osmo-bts_1.3.3.dsc" at Sat Nov 6 04:03:56 UTC 2021. [ 523s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:06:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:06:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185ff5b5ab06_2ea32b0a73cf05f027484b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 1002s] # is like basename from coreutils, and . is WD. [ 1002s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 1002s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 1002s] fi [ 1002s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1002s] # in /usr/share/osmo-gsm-manuals. [ 1002s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1002s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 1002s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 1002s] a2x: resource files: [] [ 1002s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1002s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 1002s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1002s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 1002s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1002s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 1002s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1002s] make[1]: *** [Makefile:327: all] Error 2 [ 1002s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1002s] dh_auto_build: error: make -j1 returned exit code 2 [ 1002s] make: *** [debian/rules:12: build] Error 25 [ 1002s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1002s] ### VM INTERACTION START ### [ 1003s] Powering off. [ 1003s] [ 924.234358] reboot: Power down [ 1004s] ### VM INTERACTION END ### [ 1004s] [ 1004s] lamb28 failed "build osmo-sip-connector_1.5.1.dsc" at Sat Nov 6 04:06:05 UTC 2021. [ 1004s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:07:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:07:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6185ffb32d356_2ea32b0a73cf05f02751d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 746s] # is like basename from coreutils, and . is WD. [ 746s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 746s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 746s] fi [ 746s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 746s] # in /usr/share/osmo-gsm-manuals. [ 746s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 746s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 746s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 746s] a2x: resource files: [] [ 746s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 746s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 746s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 746s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 746s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 746s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 746s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 746s] make[1]: *** [Makefile:410: all] Error 2 [ 746s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 746s] dh_auto_build: error: make -j1 returned exit code 2 [ 746s] make: *** [debian/rules:7: build] Error 25 [ 746s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 746s] ### VM INTERACTION START ### [ 747s] Powering off. [ 747s] [ 726.770939] reboot: Power down [ 747s] ### VM INTERACTION END ### [ 747s] [ 747s] lamb23 failed "build osmo-hlr_1.3.1.dsc" at Sat Nov 6 04:07:41 UTC 2021. [ 747s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:10:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:10:05 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6186002b7771c_2ea32b0a73cf05f02754d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 1035s] # is like basename from coreutils, and . is WD. [ 1035s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 1035s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 1035s] fi [ 1035s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1035s] # in /usr/share/osmo-gsm-manuals. [ 1035s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1035s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 1035s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 1035s] a2x: resource files: [] [ 1035s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1035s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 1035s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1035s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 1035s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1035s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 1035s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1035s] make[1]: *** [Makefile:403: all] Error 2 [ 1035s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1036s] dh_auto_build: error: make -j1 returned exit code 2 [ 1036s] make: *** [debian/rules:12: build] Error 25 [ 1036s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1036s] ### VM INTERACTION START ### [ 1037s] Powering off. [ 1037s] [ 971.477781] reboot: Power down [ 1037s] ### VM INTERACTION END ### [ 1037s] [ 1037s] lamb54 failed "build libosmo-sccp_1.4.0.dsc" at Sat Nov 6 04:09:56 UTC 2021. [ 1037s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:10:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:10:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61860049f280b_2ea32b0a73cf05f02755cf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 895s] # is like basename from coreutils, and . is WD. [ 895s] if ! [ -f osmomgw-usermanual.adoc ]; then \ [ 895s] ln -s osmomgw-usermanual.adoc osmomgw-usermanual.adoc; \ [ 895s] fi [ 896s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 896s] # in /usr/share/osmo-gsm-manuals. [ 896s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 896s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomgw-usermanual.adoc [ 896s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 896s] a2x: resource files: [] [ 896s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 896s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 896s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 896s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 896s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 896s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 896s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 896s] make[1]: *** [Makefile:423: all] Error 2 [ 896s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 896s] dh_auto_build: error: make -j1 returned exit code 2 [ 896s] make: *** [debian/rules:17: build] Error 25 [ 896s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 896s] ### VM INTERACTION START ### [ 897s] Powering off. [ 897s] [ 859.840898] reboot: Power down [ 897s] ### VM INTERACTION END ### [ 898s] [ 898s] lamb26 failed "build osmo-mgw_1.8.1.dsc" at Sat Nov 6 04:10:16 UTC 2021. [ 898s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:12:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:12:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618600e146526_2ea32b0a73cf05f0276566@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 1060s] # is like basename from coreutils, and . is WD. [ 1060s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 1060s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 1060s] fi [ 1060s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1060s] # in /usr/share/osmo-gsm-manuals. [ 1060s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1060s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 1060s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 1060s] a2x: resource files: [] [ 1060s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1060s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 1060s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1060s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 1060s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1060s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 1060s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1060s] make[1]: *** [Makefile:387: all] Error 2 [ 1060s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1060s] dh_auto_build: error: make -j1 returned exit code 2 [ 1060s] make: *** [debian/rules:12: build] Error 25 [ 1060s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1060s] ### VM INTERACTION START ### [ 1061s] Powering off. [ 1062s] [ 962.212762] reboot: Power down [ 1062s] ### VM INTERACTION END ### [ 1062s] [ 1062s] cloud113 failed "build osmo-remsim_0.2.4.dsc" at Sat Nov 6 04:12:55 UTC 2021. [ 1062s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:14:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:14:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6186015a427ea_2ea32b0a73cf05f027703c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 262s] # is like basename from coreutils, and . is WD. [ 262s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 262s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 262s] fi [ 262s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 262s] # in /usr/share/osmo-gsm-manuals. [ 262s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 262s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 262s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 262s] a2x: resource files: [] [ 262s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 262s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 262s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 262s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 262s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 262s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 262s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 262s] make[1]: *** [Makefile:388: all] Error 2 [ 262s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 262s] dh_auto_build: error: make -j1 returned exit code 2 [ 262s] make: *** [debian/rules:45: build] Error 25 [ 262s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 262s] ### VM INTERACTION START ### [ 263s] Powering off. [ 263s] [ 252.161943] reboot: Power down [ 263s] ### VM INTERACTION END ### [ 263s] [ 263s] goat17 failed "build osmo-bsc_1.7.2.dsc" at Sat Nov 6 04:14:51 UTC 2021. [ 263s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:17:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:17:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618601ee21d40_2ea32b0a73cf05f0277939@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 423s] # is like basename from coreutils, and . is WD. [ 423s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 423s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 423s] fi [ 423s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 423s] # in /usr/share/osmo-gsm-manuals. [ 423s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 423s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 423s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 423s] a2x: resource files: [] [ 423s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 423s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 423s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 423s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 423s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 423s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 423s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 423s] make[1]: *** [Makefile:377: all] Error 2 [ 423s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 423s] dh_auto_build: error: make -j1 returned exit code 2 [ 423s] make: *** [debian/rules:45: build] Error 25 [ 423s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 423s] ### VM INTERACTION START ### [ 424s] Powering off. [ 424s] [ 392.168099] reboot: Power down [ 424s] ### VM INTERACTION END ### [ 424s] [ 424s] cloud109 failed "build osmo-smlc_0.2.0.dsc" at Sat Nov 6 04:17:35 UTC 2021. [ 424s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:24:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:24:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618603755d910_2ea32b0a73cf05f02791f5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 834s] # is like basename from coreutils, and . is WD. [ 834s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 834s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 834s] fi [ 834s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 834s] # in /usr/share/osmo-gsm-manuals. [ 834s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 834s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 835s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 835s] a2x: resource files: [] [ 835s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 835s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 835s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 835s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 835s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 835s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 835s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 835s] make[1]: *** [Makefile:391: all] Error 2 [ 835s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 835s] dh_auto_build: error: make -j1 returned exit code 2 [ 835s] make: *** [debian/rules:9: build] Error 25 [ 835s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 835s] ### VM INTERACTION START ### [ 836s] Powering off. [ 836s] [ 807.832637] reboot: Power down [ 836s] ### VM INTERACTION END ### [ 836s] [ 836s] cloud115 failed "build osmo-iuh_1.0.0.dsc" at Sat Nov 6 04:24:17 UTC 2021. [ 836s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:31:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:31:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61860534a5c35_2ea32b0a73cf05f0280139@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 395s] # is like basename from coreutils, and . is WD. [ 395s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 395s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 395s] fi [ 395s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 395s] # in /usr/share/osmo-gsm-manuals. [ 395s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 395s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 395s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 395s] a2x: resource files: [] [ 395s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 395s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 395s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 395s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 395s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 395s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 395s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 395s] make[1]: *** [Makefile:394: all] Error 2 [ 395s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 395s] dh_auto_build: error: make -j1 returned exit code 2 [ 395s] make: *** [debian/rules:45: build] Error 25 [ 395s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 395s] ### VM INTERACTION START ### [ 396s] Powering off. [ 396s] [ 377.379207] reboot: Power down [ 397s] ### VM INTERACTION END ### [ 397s] [ 397s] old-cirrus4 failed "build osmo-sgsn_1.7.1.dsc" at Sat Nov 6 04:31:16 UTC 2021. [ 397s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sat Nov 6 04:34:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 04:34:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618605ca94388_2ea32b0a73cf05f0281318@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 567s] # is like basename from coreutils, and . is WD. [ 567s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 567s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 567s] fi [ 567s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 567s] # in /usr/share/osmo-gsm-manuals. [ 567s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 567s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 567s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 567s] a2x: resource files: [] [ 567s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 567s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 567s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 567s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 567s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 567s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 567s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 567s] make[1]: *** [Makefile:402: all] Error 2 [ 567s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 567s] dh_auto_build: error: make -j1 returned exit code 2 [ 567s] make: *** [debian/rules:45: build] Error 25 [ 567s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 567s] ### VM INTERACTION START ### [ 568s] Powering off. [ 568s] [ 516.027340] reboot: Power down [ 569s] ### VM INTERACTION END ### [ 569s] [ 569s] old-atreju5 failed "build osmo-msc_1.7.1.dsc" at Sat Nov 6 04:34:12 UTC 2021. [ 569s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sat Nov 6 13:55:07 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 13:55:07 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > Fine then, please do the documentation improvements you already ACKed. I'd really add structure wrappers to allocate/free the struct, so that users don't need to care about details and we can later on expand them as we see is needed. ah yes, thanks for reminding -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 13:55:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 15:56:54 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 15:56:54 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 15:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 15:57:48 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 15:57:48 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 to look at the new patch set (#2). Change subject: add chreq:successful_ rate counters ...................................................................... add chreq:successful_ rate counters Related: SYS#4878 Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c 5 files changed, 65 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/68/26068/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 15:58:04 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 15:58:04 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 15:58:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:03:32 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:03:32 +0000 Subject: Change in osmo-bsc[master]: cosmetic tweaks on handover counting code In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26070 to look at the new patch set (#3). Change subject: cosmetic tweaks on handover counting code ...................................................................... cosmetic tweaks on handover counting code I was a bit confused that grep did not find HO counters being used, so let's add some comments to better explain and provide a grep hook. Related: SYS#4878 Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 --- M src/osmo-bsc/handover_fsm.c 1 file changed, 25 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/26070/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 Gerrit-Change-Number: 26070 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:03:33 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:03:33 +0000 Subject: Change in osmo-bsc[master]: for linter: s/while(0)/while (0) References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26134 ) Change subject: for linter: s/while(0)/while (0) ...................................................................... for linter: s/while(0)/while (0) Change-Id: Ib422e7d1a7d543dcd8738581839ce55bb8fc29d2 --- M include/osmocom/bsc/assignment_fsm.h M include/osmocom/bsc/handover.h M include/osmocom/bsc/lchan_fsm.h M include/osmocom/bsc/lchan_rtp_fsm.h M include/osmocom/bsc/lcs_loc_req.h M include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/timeslot_fsm.h M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/handover_decision_2.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/lchan_rtp_fsm.c M src/osmo-bsc/lcs_loc_req.c M src/osmo-bsc/lcs_ta_req.c 14 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/26134/1 diff --git a/include/osmocom/bsc/assignment_fsm.h b/include/osmocom/bsc/assignment_fsm.h index 3a64f7d..6c429e4 100644 --- a/include/osmocom/bsc/assignment_fsm.h +++ b/include/osmocom/bsc/assignment_fsm.h @@ -17,7 +17,7 @@ conn->assignment.new_lchan ? " of " : "", \ conn->assignment.new_lchan ? gsm_lchan_name(conn->assignment.new_lchan) : "", \ ## args); \ - } while(0) + } while (0) enum assignment_fsm_state { ASSIGNMENT_ST_WAIT_LCHAN_ACTIVE, diff --git a/include/osmocom/bsc/handover.h b/include/osmocom/bsc/handover.h index f671491..58fea35 100644 --- a/include/osmocom/bsc/handover.h +++ b/include/osmocom/bsc/handover.h @@ -17,7 +17,7 @@ else \ LOGP(DHODEC, level, "%s: " fmt, \ handover_status(conn), ## args); \ - } while(0) + } while (0) struct gsm_network; struct gsm_lchan; diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h index fa0d299..eb8312e 100644 --- a/include/osmocom/bsc/lchan_fsm.h +++ b/include/osmocom/bsc/lchan_fsm.h @@ -10,14 +10,14 @@ LOGPFSML((lchan)->fi, level, "(type=%s) " fmt, gsm_lchant_name((lchan)->type), ## args); \ else \ LOGP(DRSL, level, "%s (not initialized) " fmt, gsm_lchan_name(lchan), ## args); \ - } while(0) + } while (0) #define LCHAN_SET_LAST_ERROR(LCHAN, fmt, args...) do { \ if ((LCHAN)->last_error) \ talloc_free((LCHAN)->last_error); \ (LCHAN)->last_error = talloc_asprintf((LCHAN)->ts->trx, fmt, ##args); \ LOG_LCHAN(LCHAN, LOGL_ERROR, "%s\n", (LCHAN)->last_error); \ - } while(0) + } while (0) enum lchan_fsm_state { LCHAN_ST_UNUSED, diff --git a/include/osmocom/bsc/lchan_rtp_fsm.h b/include/osmocom/bsc/lchan_rtp_fsm.h index 6ff8fe3..18ab348 100644 --- a/include/osmocom/bsc/lchan_rtp_fsm.h +++ b/include/osmocom/bsc/lchan_rtp_fsm.h @@ -7,7 +7,7 @@ else \ LOGP(DLMGCP, level, "%s (not initialized) " fmt, gsm_lchan_name(lchan), \ ## args); \ - } while(0) + } while (0) struct gsm_lchan; struct mgcp_conn_peer; diff --git a/include/osmocom/bsc/lcs_loc_req.h b/include/osmocom/bsc/lcs_loc_req.h index ba677e8..86540f2 100644 --- a/include/osmocom/bsc/lcs_loc_req.h +++ b/include/osmocom/bsc/lcs_loc_req.h @@ -8,7 +8,7 @@ LOGPFSML((LOC_REQ)->fi, level, fmt, ## args); \ else \ LOGP(DLCS, level, "LCS Perf Loc Req: " fmt, ## args); \ - } while(0) + } while (0) struct lcs_ta_req; diff --git a/include/osmocom/bsc/lcs_ta_req.h b/include/osmocom/bsc/lcs_ta_req.h index b9b7a4e..bdfc14f 100644 --- a/include/osmocom/bsc/lcs_ta_req.h +++ b/include/osmocom/bsc/lcs_ta_req.h @@ -11,7 +11,7 @@ LOGPFSML((TA_REQ)->fi, level, fmt, ## args); \ else \ LOGP(DLCS, level, "LCS TA Req: " fmt, ## args); \ - } while(0) + } while (0) enum lcs_ta_req_fsm_event { LCS_TA_REQ_EV_GOT_TA, diff --git a/include/osmocom/bsc/timeslot_fsm.h b/include/osmocom/bsc/timeslot_fsm.h index 5e62188..526f3cf 100644 --- a/include/osmocom/bsc/timeslot_fsm.h +++ b/include/osmocom/bsc/timeslot_fsm.h @@ -17,7 +17,7 @@ gsm_ts_name(ts), \ ## args, \ (!fmt || !*fmt || fmt[strlen(fmt)-1] != '\n') ? "\n" : ""); \ - } while(0) + } while (0) enum ts_fsm_state { TS_ST_NOT_INITIALIZED, diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index f9a81b3..656bd3e 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -74,7 +74,7 @@ osmo_fsm_inst_state_name(fi), gsm0808_cause_name(cause), ## args); \ assignment_count_result(CTR_ASSIGNMENT_ERROR); \ on_assignment_failure(_conn); \ - } while(0) + } while (0) /* Assume presence of local var 'conn' as struct gsm_subscriber_connection */ #define assignment_count(counter) do { \ @@ -98,7 +98,7 @@ break; \ } \ } \ - } while(0) + } while (0) #define assignment_count_result(counter) do { \ if (!conn->assignment.result_rate_ctr_done) { \ @@ -109,7 +109,7 @@ "result rate counter already recorded, NOT counting as: %s %s\n", \ bsc_ctr_description[BSC_##counter].name, \ bsc_ctr_description[BSC_##counter].description); \ - } while(0) + } while (0) void assignment_reset(struct gsm_subscriber_connection *conn) { diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index d08173c..e384feb 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -86,7 +86,7 @@ LOGPHOLCHANTOBTS((candidate)->current.lchan, (candidate)->target.bts, level, fmt, ## args); \ else if ((candidate)->target.cell_ids.id_list_len) \ LOGPHOLCHANTOREMOTE((candidate)->current.lchan, &(candidate)->target.cell_ids, level, fmt, ## args); \ - } while(0) + } while (0) #define REQUIREMENT_A_TCHF 0x01 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 255478f..82a0588 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -90,7 +90,7 @@ bsc_ctr_description[counter].name, \ bsc_ctr_description[counter].description); \ rate_ctr_inc(rate_ctr_group_get_ctr(conn->network->bsc_ctrs, counter)); \ - } while(0) + } while (0) /* Assume presence of local var 'conn' as struct gsm_subscriber_connection. * Handles bts == NULL gracefully @@ -106,12 +106,12 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, counter)); \ else \ rate_ctr_inc(rate_ctr_group_get_ctr(conn->network->bts_unknown_ctrs, counter)); \ - } while(0) + } while (0) #define ho_count(bts, counter) do { \ ho_count_bsc(BSC_##counter); \ ho_count_bts(bts, BTS_##counter); \ -} while(0) +} while (0) static uint8_t g_next_ho_ref = 1; @@ -212,12 +212,12 @@ LOG_HO(conn, LOGL_ERROR, "Handover failed in state %s, %s: " fmt "\n", \ osmo_fsm_inst_state_name(conn->fi), handover_result_name(result), ## args); \ handover_end(conn, result); \ - } while(0) + } while (0) #define ho_success() do { \ LOG_HO(conn, LOGL_DEBUG, "Handover succeeded\n"); \ handover_end(conn, HO_RESULT_OK); \ - } while(0) + } while (0) /* issue handover to a cell identified by ARFCN and BSIC */ int handover_request(struct handover_out_req *req) diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 52aadce..d61d032 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -302,7 +302,7 @@ else \ LOG_LCHAN(_lchan, LOGL_DEBUG, "After failure handling, already in state %s\n", \ osmo_fsm_state_name(fsm, state_chg)); \ - } while(0) + } while (0) /* Which state to transition to when lchan_fail() is called in a given state. */ uint32_t lchan_fsm_on_error[34] = { diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index 7bd8209..62cd100 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -66,7 +66,7 @@ LCHAN_SET_LAST_ERROR(_lchan, "lchan-rtp failure in state %s: " fmt, \ osmo_fsm_state_name(fi->fsm, state_was), ## args); \ osmo_fsm_inst_dispatch(_lchan->fi, LCHAN_EV_RTP_ERROR, 0); \ - } while(0) + } while (0) /* Called from lchan_fsm_init(), does not need to be visible in lchan_rtp_fsm.h */ void lchan_rtp_fsm_init() diff --git a/src/osmo-bsc/lcs_loc_req.c b/src/osmo-bsc/lcs_loc_req.c index 7153ce6..d2ea72d 100644 --- a/src/osmo-bsc/lcs_loc_req.c +++ b/src/osmo-bsc/lcs_loc_req.c @@ -81,7 +81,7 @@ .cause_val = cause, \ }; \ lcs_loc_req_fsm_state_chg(lcs_loc_req->fi, LCS_LOC_REQ_ST_FAILED); \ - } while(0) + } while (0) static struct lcs_loc_req *lcs_loc_req_alloc(struct osmo_fsm_inst *parent_fi, uint32_t parent_event_term) { @@ -110,7 +110,7 @@ #define PARSE_ERR(ERRMSG) do { \ lcs_loc_req_fail(LCS_CAUSE_PROTOCOL_ERROR, "rx BSSMAP Perform Location Request: " ERRMSG); \ return false; \ - } while(0) + } while (0) payload_length = msg->tail - msg->l4h; if (tlv_parse2(tp_arr, 1, gsm0808_att_tlvdef(), msg->l4h + 1, payload_length - 1, 0, 0) <= 0) diff --git a/src/osmo-bsc/lcs_ta_req.c b/src/osmo-bsc/lcs_ta_req.c index bcee6e1..6252d46 100644 --- a/src/osmo-bsc/lcs_ta_req.c +++ b/src/osmo-bsc/lcs_ta_req.c @@ -63,7 +63,7 @@ lcs_ta_req ? osmo_fsm_inst_state_name(lcs_ta_req->fi) : "NULL", ## args); \ lcs_ta_req->failure_cause = cause; \ lcs_ta_req_fsm_state_chg(lcs_ta_req->fi, LCS_TA_REQ_ST_FAILED); \ - } while(0) + } while (0) static struct osmo_fsm lcs_ta_req_fsm; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib422e7d1a7d543dcd8738581839ce55bb8fc29d2 Gerrit-Change-Number: 26134 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:05:30 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:05:30 +0000 Subject: Change in osmo-bsc[master]: add chreq:successful_ rate counters In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters ...................................................................... add chreq:successful_ rate counters Related: SYS#4878 Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c 5 files changed, 65 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 68654f2..68e7cfe 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -27,6 +27,13 @@ BTS_CTR_CHREQ_ATTEMPTED_OTHER, BTS_CTR_CHREQ_ATTEMPTED_UNKNOWN, BTS_CTR_CHREQ_SUCCESSFUL, + BTS_CTR_CHREQ_SUCCESSFUL_EMERG, + BTS_CTR_CHREQ_SUCCESSFUL_CALL, + BTS_CTR_CHREQ_SUCCESSFUL_LOCATION_UPD, + BTS_CTR_CHREQ_SUCCESSFUL_PAG, + BTS_CTR_CHREQ_SUCCESSFUL_PDCH, + BTS_CTR_CHREQ_SUCCESSFUL_OTHER, + BTS_CTR_CHREQ_SUCCESSFUL_UNKNOWN, BTS_CTR_CHREQ_NO_CHANNEL, BTS_CTR_CHREQ_MAX_DELAY_EXCEEDED, BTS_CTR_CHAN_RF_FAIL, diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index cb56028..6a60f06 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -617,6 +617,8 @@ struct lchan_activate_info { enum lchan_activate_for activ_for; + /* If activ_for == ACTIVATE_FOR_MS_CHANNEL_REQUEST, the original CHREQ reason. */ + enum gsm_chreq_reason_t chreq_reason; struct gsm_subscriber_connection *for_conn; struct channel_mode_and_rate ch_mode_rate; struct gsm_encr encr; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index c3825f6..cdd57c2 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2097,6 +2097,7 @@ gsm_chreq_name(rqd->reason), rqd->ref.ra, rqd->ta); info = (struct lchan_activate_info){ .activ_for = ACTIVATE_FOR_MS_CHANNEL_REQUEST, + .chreq_reason = rqd->reason, .ch_mode_rate = { .chan_mode = GSM48_CMODE_SIGN, .chan_rate = CH_RATE_SDCCH, @@ -2112,6 +2113,35 @@ return; } +static void imm_ass_rate_ctr(struct gsm_lchan *lchan) +{ + struct gsm_bts *bts = lchan->ts->trx->bts; + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL)); + switch (lchan->activate.info.chreq_reason) { + case GSM_CHREQ_REASON_EMERG: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); + break; + case GSM_CHREQ_REASON_CALL: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_CALL)); + break; + case GSM_CHREQ_REASON_LOCATION_UPD: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_LOCATION_UPD)); + break; + case GSM_CHREQ_REASON_PAG: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PAG)); + break; + case GSM_CHREQ_REASON_PDCH: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PDCH)); + break; + case GSM_CHREQ_REASON_OTHER: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_OTHER)); + break; + default: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_UNKNOWN)); + break; + } +} + int rsl_tx_imm_assignment(struct gsm_lchan *lchan) { int rc; @@ -2156,7 +2186,7 @@ rc = rsl_imm_assign_cmd(bts, sizeof(*ia)+ia->mob_alloc_len, (uint8_t *) ia); if (!rc) - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL)); + imm_ass_rate_ctr(lchan); return rc; } diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 21ee01a..28059bb 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -849,6 +849,27 @@ [BTS_CTR_CHREQ_SUCCESSFUL] = \ { "chreq:successful", "Successful channel requests (immediate assign sent)" }, + [BTS_CTR_CHREQ_SUCCESSFUL_EMERG] = \ + { "chreq:successful_emerg", + "Sent Immediate Assignment for EMERG" }, + [BTS_CTR_CHREQ_SUCCESSFUL_CALL] = \ + { "chreq:successful_call", + "Sent Immediate Assignment for CALL" }, + [BTS_CTR_CHREQ_SUCCESSFUL_LOCATION_UPD] = \ + { "chreq:successful_location_upd", + "Sent Immediate Assignment for LOCATION_UPD" }, + [BTS_CTR_CHREQ_SUCCESSFUL_PAG] = \ + { "chreq:successful_pag", + "Sent Immediate Assignment for PAG" }, + [BTS_CTR_CHREQ_SUCCESSFUL_PDCH] = \ + { "chreq:successful_pdch", + "Sent Immediate Assignment for PDCH" }, + [BTS_CTR_CHREQ_SUCCESSFUL_OTHER] = \ + { "chreq:successful_other", + "Sent Immediate Assignment for OTHER" }, + [BTS_CTR_CHREQ_SUCCESSFUL_UNKNOWN] = \ + { "chreq:successful_unknown", + "Sent Immediate Assignment for UNKNOWN" }, [BTS_CTR_CHREQ_NO_CHANNEL] = \ { "chreq:no_channel", "Sent to MS no channel available" }, diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index d5d6e77..52aadce 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -632,6 +632,10 @@ lchan->release.requested = false; lchan->activate.info = *info; + /* To avoid confusion, invalidate info.chreq_reason value if it isn't for a CHREQ */ + if (lchan->activate.info.activ_for != ACTIVATE_FOR_MS_CHANNEL_REQUEST) + lchan->activate.info.chreq_reason = -1; + lchan->activate.concluded = false; lchan_fsm_state_chg(LCHAN_ST_WAIT_TS_READY); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:05:31 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:05:31 +0000 Subject: Change in osmo-bsc[master]: drop unused gsm48_tx_mm_serv_ack() In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26069 ) Change subject: drop unused gsm48_tx_mm_serv_ack() ...................................................................... drop unused gsm48_tx_mm_serv_ack() Related: SYS#4878 Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea --- M include/osmocom/bsc/gsm_04_08_rr.h M src/osmo-bsc/gsm_08_08.c 2 files changed, 0 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve diff --git a/include/osmocom/bsc/gsm_04_08_rr.h b/include/osmocom/bsc/gsm_04_08_rr.h index 5ddee7f..1f50ef9 100644 --- a/include/osmocom/bsc/gsm_04_08_rr.h +++ b/include/osmocom/bsc/gsm_04_08_rr.h @@ -33,9 +33,6 @@ int gsm48_lchan_modify(struct gsm_lchan *lchan, uint8_t mode); int gsm48_rx_rr_modif_ack(struct msgb *msg); int gsm48_parse_meas_rep(struct gsm_meas_rep *rep, struct msgb *msg); -int gsm48_tx_mm_serv_ack(struct gsm_subscriber_connection *conn); -int gsm48_tx_mm_serv_rej(struct gsm_subscriber_connection *conn, - enum gsm48_reject_value value); struct msgb *gsm48_create_mm_serv_rej(enum gsm48_reject_value value); struct msgb *gsm48_create_loc_upd_rej(uint8_t cause); diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 91c90fe..1715533 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -101,23 +101,6 @@ msgb_free(resp); } -/* 9.2.5 CM service accept */ -int gsm48_tx_mm_serv_ack(struct gsm_subscriber_connection *conn) -{ - struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 SERV ACK"); - struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); - - msg->lchan = conn->lchan; - - gh->proto_discr = GSM48_PDISC_MM; - gh->msg_type = GSM48_MT_MM_CM_SERV_ACC; - - DEBUGP(DMM, "-> CM SERVICE ACK\n"); - - gscon_submit_rsl_dtap(conn, msg, 0, 0); - return 0; -} - static bool is_cm_service_for_emerg(struct msgb *msg) { struct gsm48_service_request *cm; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea Gerrit-Change-Number: 26069 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:07:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:07:36 +0000 Subject: Change in osmo-bsc[master]: cosmetic tweaks on handover counting code In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26070 ) Change subject: cosmetic tweaks on handover counting code ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 Gerrit-Change-Number: 26070 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 16:07:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:09:52 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:09:52 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 to look at the new patch set (#2). Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... add time_cc API: cumlative counter for time, reported as rate_ctr This is a candidate for adding to libosmocore (as osmo_time_cc), but let's first use this in osmo-bsc to make sure that it works as intended. I started out expecting to be done with this in half an hour, but I found out that accumulating elapsed time to an integer counter has a staggering amount of complexity to it, and a million pitfalls. The intended use is to report allAvailableSDCCHAllocated and allAvailableTCHAllocated performance indicators in OsmoBSC. Hopefully this will also be generally useful elsewhere, to be worth the effort. Related: SYS#4878 Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 --- M configure.ac M include/osmocom/bsc/Makefile.am A include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am A src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/Makefile.am A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 10 files changed, 1,510 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/25973/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:09:52 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:09:52 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 to look at the new patch set (#2). Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... implement all_allocated:{sdcch,tch} rate counters Based on allAvailable{SDCCH,TCH}Allocated performance indicators, see 3GPP TS 52.402. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/net_init.c 8 files changed, 130 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/25974/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:17:45 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:17:45 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 to look at the new patch set (#3). Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... implement all_allocated:{sdcch,tch} rate counters Based on allAvailable{SDCCH,TCH}Allocated performance indicators, see 3GPP TS 52.402. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/net_init.c 8 files changed, 131 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/25974/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:23:23 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:23:23 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/1/include/osmocom/bsc/gsm_data.h at 1448 PS1, Line 1448: typedef unsigned int chan_counts_t [CHAN_COUNTS1_N][CHAN_COUNTS2_N][_GSM_LCHAN_MAX]; > I wouldn't call it a personal preference, it's having a way to pass a data structure in an easy way [?] I accept that, but still the point I keep raising is: how to do chan_counts_dim3_add() with a struct type? The function needs just the counts for a single gsm_lchant; instead i would have to pass the struct, containing the arrays for all gsm_lchant, multiplied by all chan_counts_dim2, multiplied by all chan_counts_dim1. possible, but do you prefer that? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 16:23:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 16:49:21 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 16:49:21 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 3: (2 comments) Just now I am busy implementing with a struct, but I am having the problem of ... (s.b.) https://gerrit.osmocom.org/c/osmo-bsc/+/25972/3/src/osmo-bsc/chan_counts.c File src/osmo-bsc/chan_counts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25972/3/src/osmo-bsc/chan_counts.c at 29 PS3, Line 29: ...adding this array... https://gerrit.osmocom.org/c/osmo-bsc/+/25972/3/src/osmo-bsc/chan_counts.c at 81 PS3, Line 81: chan_counts_dim3_add(ts_count[CHAN_COUNTS2_MAX_TOTAL], lchans_per_pchan[ts->pchan_on_init]); ...to this Because with a struct, it looks like this: static inline void chan_counts_dim3_add(struct chan_counts *dst, const struct chan_counts *add, enum chan_counts_dim1 dim1, enum chan_counts_dim2 dim2) { int i; for (i = 0; i < _GSM_LCHAN_MAX; i++) dst->val[dim1][dim2][i] += add->val[dim1][dim2][i]; } So the array to be added is also a struct chan_counts, but above struct lchans_per_pchan has a quite different structure. Only that struct's second dimension is the same as chan_counts' third dimension ... don't know how to resolve that now -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 16:49:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 17:15:59 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 17:15:59 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 to look at the new patch set (#4). Change subject: refactor lchan counting ...................................................................... refactor lchan counting Add chan_counts_for_trx() and chan_counts_for_bts(). Drop bts_count_free_ts() and trx_count_free_ts(). Rationale: The bts_count_free_ts() and trx_count_free_ts() always returned the number of free lchans, not timeslots. Hence, passing the pchan type as argument never really matched the semantics. Especially, when looking for free SDCCH, there is no clear match on a gsm_phys_chan_config enum value: SDCCH8_SACCH8C, CCCH_SDCCH4, CCCH_SDCCH4_CBCH, SDCCH8_SACCH8C_CBCH? -- GSM_LCHAN_SDCCH is clear. ==> Rather count free lchans by enum gsm_chan_t. Counting lchans of distinct types required separate iterations for each lchan type. ==> Rather compose an array of counts for all types, in one go. I need to count the amount of free SDCCH lchans in an upcoming patch to implement the performance indicator allAvailableAllocatedSDCCH (cumulate time for which no SDCCH are available). To implement allAvailableAllocated{SDCCH,TCH}, I need a count of both the used as well as the total lchans for a type: it does not make sense to flag "all available allocated" if none are ever available. To properly count dynamic ts, I need the maximum total that can be possible at any time. And to count currently free lchans, I need the current total. This may seem counter intuitive, but consider, e.g.: - Obviously, if a cell has only static TCH/F timeslots, it does not make sense to flag that all available TCH/H are occupied, because no TCH/H are available ever. Just stating this as contrast to dyn TS. - If a cell has OSMO_DYN timeslots, I *do* want to flag that all TCH/H are occupied when all dyn timeslots are fully occupied. - If those OSMO_DYN however are all used as TCH/F, the current total of TCH/H becomes zero, and it seems like TCH/H should not be considered. - To count the nr of currently free lchans, I need the currently possible total of lchans and the nr of occupied lchans. So return both a maximum total and a current total of lchans. In above example, the maximum total shows that there would be TCH/H possible. BTW, it would be nice to keep a chan_counts array on trx, bts and bsc level and update as channels are allocated and released, instead of counting them all over periodically. But it's less error prone this way. Related: SYS#4878 Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/bts_trx.h A include/osmocom/bsc/chan_counts.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx.c A src/osmo-bsc/chan_counts.c M src/osmo-bsc/handover_decision_2.c 10 files changed, 238 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/25972/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 17:18:05 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 17:18:05 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 4: Here is a new patch set using a struct, and I don't like it at all. It makes working with array dimensions much less like it should be. I find this version of chan_counts_for_trx() much harder to understand. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 17:18:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 17:29:22 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 17:29:22 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 to look at the new patch set (#5). Change subject: refactor lchan counting ...................................................................... refactor lchan counting Add chan_counts_for_trx() and chan_counts_for_bts(). Drop bts_count_free_ts() and trx_count_free_ts(). Rationale: The bts_count_free_ts() and trx_count_free_ts() always returned the number of free lchans, not timeslots. Hence, passing the pchan type as argument never really matched the semantics. Especially, when looking for free SDCCH, there is no clear match on a gsm_phys_chan_config enum value: SDCCH8_SACCH8C, CCCH_SDCCH4, CCCH_SDCCH4_CBCH, SDCCH8_SACCH8C_CBCH? -- GSM_LCHAN_SDCCH is clear. ==> Rather count free lchans by enum gsm_chan_t. Counting lchans of distinct types required separate iterations for each lchan type. ==> Rather compose an array of counts for all types, in one go. I need to count the amount of free SDCCH lchans in an upcoming patch to implement the performance indicator allAvailableAllocatedSDCCH (cumulate time for which no SDCCH are available). To implement allAvailableAllocated{SDCCH,TCH}, I need a count of both the used as well as the total lchans for a type: it does not make sense to flag "all available allocated" if none are ever available. To properly count dynamic ts, I need the maximum total that can be possible at any time. And to count currently free lchans, I need the current total. This may seem counter intuitive, but consider, e.g.: - Obviously, if a cell has only static TCH/F timeslots, it does not make sense to flag that all available TCH/H are occupied, because no TCH/H are available ever. Just stating this as contrast to dyn TS. - If a cell has OSMO_DYN timeslots, I *do* want to flag that all TCH/H are occupied when all dyn timeslots are fully occupied. - If those OSMO_DYN however are all used as TCH/F, the current total of TCH/H becomes zero, and it seems like TCH/H should not be considered. - To count the nr of currently free lchans, I need the currently possible total of lchans and the nr of occupied lchans. So return both a maximum total and a current total of lchans. In above example, the maximum total shows that there would be TCH/H possible. BTW, it would be nice to keep a chan_counts array on trx, bts and bsc level and update as channels are allocated and released, instead of counting them all over periodically. But it's less error prone this way. Related: SYS#4878 Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/bts_trx.h A include/osmocom/bsc/chan_counts.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx.c A src/osmo-bsc/chan_counts.c M src/osmo-bsc/handover_decision_2.c 10 files changed, 238 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/25972/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 17:36:05 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 6 Nov 2021 17:36:05 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 5: repeat to not get lost in the jenkins noise: Here is a new patch set using a struct, and I don't like it at all. It makes working with array dimensions much less like it should be. I find this version of chan_counts_for_trx() much harder to understand. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Nov 2021 17:36:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 19:25:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 19:25:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 ) Change subject: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap ...................................................................... library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap Change-Id: If2e287699925c6bb7f93439d0729e16682fab019 Related: SYS#5319 --- M library/RSL_Types.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/26135/1 diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 1f602b9..1057f0b 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -893,6 +893,29 @@ uint3_t overpower_db } with { variant (len) "LENGTHTO(sacch_enable,facch_enable,rxqual,overpower_db)" } + template (value) RSL_IE_OSMO_TopAcchCap + ts_RSL_IE_OSMO_TopAcchCap(template (value) uint3_t overpower := 2, + template (value) uint3_t rxqual := 4, + boolean facch_enable := true, + boolean sacch_enable := true) := { + len := 0, /* overwritten */ + sacch_enable := sacch_enable, + facch_enable := facch_enable, + rxqual := rxqual, + overpower_db := overpower + }; + template RSL_IE_OSMO_TopAcchCap + tr_RSL_IE_OSMO_TopAcchCap(template (present) uint3_t overpower := ?, + template (present) uint3_t rxqual := ?, + template (present) boolean facch_enable := ?, + template (present) boolean sacch_enable := ?) := { + len := ?, /* overwritten */ + sacch_enable := sacch_enable, + facch_enable := facch_enable, + rxqual := rxqual, + overpower_db := overpower + }; + /* union of all IE bodies */ type union RSL_IE_Body { RslChannelNr chan_nr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2e287699925c6bb7f93439d0729e16682fab019 Gerrit-Change-Number: 26135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 19:25:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 19:25:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/L1CTL_PortType: add f_L1CTL_rx_data() helper References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 ) Change subject: library/L1CTL_PortType: add f_L1CTL_rx_data() helper ...................................................................... library/L1CTL_PortType: add f_L1CTL_rx_data() helper Change-Id: I254171c6dc83f046b5ad1a72586c097deebb0fa7 Related: SYS#5319 --- M library/L1CTL_PortType.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26136/1 diff --git a/library/L1CTL_PortType.ttcn b/library/L1CTL_PortType.ttcn index 80e33a8..ed235d3 100644 --- a/library/L1CTL_PortType.ttcn +++ b/library/L1CTL_PortType.ttcn @@ -42,6 +42,29 @@ return len; } + function f_L1CTL_rx_data(L1CTL_PT pt, + template (present) RslChannelNr chan_nr := ?, + template (present) RslLinkId link_id := ?) + return L1ctlDlMessage { + var L1ctlDlMessage dl; + timer T := 2.0; + + T.start; + alt { + [] pt.receive(tr_L1CTL_DATA_IND(chan_nr, link_id)) -> value dl { + return dl; + } + [] pt.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for L1CTL DATA.ind"); + mtc.stop; + } + } + + /* Unreachable, make TITAN happy */ + return dl; + } + function f_L1CTL_FBSB(L1CTL_PT pt, GsmBandArfcn arfcn, L1ctlCcchMode ccch_mode := CCCH_MODE_COMBINED, integer rxlev_exp := 57) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I254171c6dc83f046b5ad1a72586c097deebb0fa7 Gerrit-Change-Number: 26136 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 19:25:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 19:25:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... BTS_Tests: add test cases for Temporary ACCH Overpower Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Related: SYS#5319 --- M bts/BTS_Tests.ttcn M library/GSM_RR_Types.ttcn 2 files changed, 329 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/26137/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 7476a0c..14cee45 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -317,7 +317,8 @@ /* Test-specific parameters */ friend type union TestSpecUnion { - RllTestCase rll + RllTestCase rll, + TopTestCase top } private template (value) RachControlParameters ts_RachCtrl_default := { @@ -773,6 +774,43 @@ var RSL_Message rx := f_rsl_transceive_ret(tx, exp_rx, id, ignore_other); } +/* Send the given measurement results to the IUT over the Um interface, + * wait for the IUT to receive then and forward over the A-bis/RSL interface. */ +friend function f_transceive_meas_rep(template (value) MeasurementResults meas_res) +runs on ConnHdlr { + var template (value) SacchL1Header l1h; + var octetstring l2, l3; + timer T; + + /* RR Measurement Report to be sent */ + var GsmRrL3Message meas_rep := { + header := valueof(t_RrL3Header(MEASUREMENT_REPORT)), + payload := { meas_rep := { meas_res := valueof(meas_res) } } + }; + + /* TITAN has weird (and often unusable) padding model, so we pad here manaully */ + l3 := f_pad_oct(enc_GsmRrL3Message(meas_rep), 18, '00'O); + l2 := f_pad_oct(enc_LapdmFrameAB(valueof(ts_LAPDm_AB(0, meas_rep))), 21, '00'O); + l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, false, + g_pars.l1_pars.ms_actual_ta); + + /* Send RR Measurement Report over the Um interface */ + L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2)); + + /* Expect MEASurement RESult on the A-bis/RSL interface */ + T.start(2.0); + alt { + [] RSL.receive(tr_RSL_MEAS_RES_OSMO(g_chan_nr, l3_info := l3)) { + setverdict(pass); + } + [] RSL.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for RSL MEASurement RESult"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } +} + friend function f_rsl_chan_act(RSL_IE_ChannelMode mode, boolean encr_enable := false, RSL_IE_List more_ies := {}, @@ -7956,6 +7994,269 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } +private type record TopTestCase { + RSL_IE_BS_Power bs_power, + RSL_IE_OSMO_TopAcchCap top_cap, + record of TopTestStep steps +}; +private type record TopTestStep { + MeasurementResults meas_res optional, + GsmRxLev overpower_sacch, + GsmRxLev overpower_facch +}; + +private function f_rxlev_match(template (present) RslLinkId link_id, + template (present) GsmRxLev rxlev) +runs on ConnHdlr { + var L1ctlDlMessage dl := f_L1CTL_rx_data(L1CTL, g_chan_nr, link_id); + if (not match(dl.dl_info.rx_level, rxlev)) { + setverdict(fail, "RxLev(", link_id, ") := ", dl.dl_info.rx_level, + " does not match expected RxLev := ", rxlev); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } +} + +private function f_TC_acch_overpower(charstring id) runs on ConnHdlr { + var TopTestCase tc := g_pars.spec.top; + var GsmRxLev rxlev_dcch; + var L1ctlDlMessage dl; + + /* Wait for Pau ramping to complete */ + f_sleep(6.0); + + f_l1_tune(L1CTL); + L1CTL.clear; + RSL.clear; + + /* Measure RxLev(BCCH), calculate RxLev(DCCH) */ + dl := f_L1CTL_rx_data(L1CTL, t_RslChanNr_BCCH(0)); + rxlev_dcch := dl.dl_info.rx_level - (tc.bs_power.power_level * 2); + + log("RxLev(BCCH) := ", dl.dl_info.rx_level); + log("Expected RxLev(DCCH) := ", rxlev_dcch); + + /* Additional IEs for the CHANnel ACTIVation message */ + var template (value) RSL_IE_List ies := { + /* Employ BS power control in static mode */ + t_RSL_IE(RSL_IE_MS_POWER, RSL_IE_Body:{ + bs_power := tc.bs_power + }), + /* Indicate the given Temporary Overpower capability */ + t_RSL_IE(RSL_IE_OSMO_TOP_ACCH_CAP, RSL_IE_Body:{ + top_acch_cap := tc.top_cap + }) + }; + + /* Establish a dedicated channel */ + f_est_dchan(more_ies := valueof(ies)); + L1CTL.clear; + RSL.clear; + + for (var integer i := 0; i < lengthof(tc.steps); i := i + 1) { + var TopTestStep step := tc.steps[i]; + var GsmRxLev rxlev_facch := rxlev_dcch + step.overpower_facch; + var GsmRxLev rxlev_sacch := rxlev_dcch + step.overpower_sacch; + + log("Executing step[", i, "] := ", step); + + /* Send RR Measurement Report (if present) */ + if (ispresent(step.meas_res)) { + f_transceive_meas_rep(step.meas_res); + f_sleep(0.480 * 2.0); + L1CTL.clear; + } + + /* Check RxLev on both FACCH and SACCH */ + f_rxlev_match(tr_RslLinkID_DCCH(?), rxlev_facch); + f_rxlev_match(tr_RslLinkID_SACCH(?), rxlev_sacch); + + setverdict(pass); + } +} +testcase TC_acch_overpower_rxqual_thresh() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Verify lower and upper RxQual thresholds */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 2dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(4), /* 4dB */ + steps := { + /* Channel established, no overpower */ + { meas_res := omit, + overpower_sacch := 0, overpower_facch := 0 }, + + /* Worst possible RxQual value, overpower of 4dB */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 4, overpower_facch := 4 }, + /* Worst possible RxQual value, disabling overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 0, overpower_facch := 0 }, + + /* Lower threshold not reached, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 1), + overpower_sacch := 0, overpower_facch := 0 }, + /* Lower threshold not reached, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 2), + overpower_sacch := 0, overpower_facch := 0 }, + /* Lower threshold reached, overpower of 4dB */ + { meas_res := ts_MeasurementResults(rxq_f := 4), + overpower_sacch := 4, overpower_facch := 4 }, + /* Upper threshold not reached, keeping overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 3), + overpower_sacch := 4, overpower_facch := 4 }, + /* Upper threshold reached, disabling overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 3), + overpower_sacch := 0, overpower_facch := 0 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_rxqual_thresh_dtx() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Verify handling of FULL and SUB values */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 2dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(4), /* 4dB */ + steps := { + /* Channel established, no overpower */ + { meas_res := omit, + overpower_sacch := 0, overpower_facch := 0 }, + + /* Invalid measurement results, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 7, + rxq_s := 7, + valid := false), + overpower_sacch := 0, overpower_facch := 0 }, + + /* DTXu was in use, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 7, + rxq_s := 0, + dtx_used := true), + overpower_sacch := 0, overpower_facch := 0 }, + /* DTXu was in use, overpower of 4 dB */ + { meas_res := ts_MeasurementResults(rxq_f := 0, + rxq_s := 7, + dtx_used := true), + overpower_sacch := 4, overpower_facch := 4 }, + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_always_on_facch() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Overpower is always on, SACCH disabled */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ + rxqual := 0, /* always on */ + sacch_enable := false), + steps := { + /* Channel established, FACCH overpower */ + { meas_res := omit, + overpower_sacch := 0, overpower_facch := 4 }, + /* MS indicates good RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 0, overpower_facch := 4 }, + /* MS indicates bad RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 0, overpower_facch := 4 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_always_on_sacch() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Overpower is always on, FACCH disabled */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ + rxqual := 0, /* always on */ + facch_enable := false), + steps := { + /* Channel established, SACCH overpower */ + { meas_res := omit, + overpower_sacch := 4, overpower_facch := 0 }, + /* MS indicates good RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 4, overpower_facch := 0 }, + /* MS indicates bad RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 4, overpower_facch := 0 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_limit() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Overpower higher than current power reduction level (2dB) */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(1), /* 1 x 2dB = 2dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ + rxqual := 0 /* always on */), + steps := { + /* Channel established, ACCH overpower of 2dB */ + { meas_res := omit, + overpower_sacch := 2, overpower_facch := 2 }, + /* MS indicates good RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 2, overpower_facch := 2 }, + /* MS indicates bad RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 2, overpower_facch := 2 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + /* test generation of RLL ERR IND based on Um errors (TS 48.058 3.9) */ /* protocol error as per 44.006 */ /* link layer failure (repetition of I-frame N200 times without ACK */ @@ -8160,6 +8461,12 @@ execute( TC_early_immediate_assignment() ); + execute( TC_acch_overpower_rxqual_thresh() ); + execute( TC_acch_overpower_rxqual_thresh_dtx() ); + execute( TC_acch_overpower_always_on_facch() ); + execute( TC_acch_overpower_always_on_sacch() ); + execute( TC_acch_overpower_limit() ); + /* BEWARE: these test cases can potentially break the IUT or cause * weird/unexpected behavior. Ensure that they are executed last. */ execute( TC_dyn_osmo_pdch_tchh_race_act() ); diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index f45784c..980020e 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -1104,6 +1104,27 @@ } }; + template (value) MeasurementResults + ts_MeasurementResults(template (value) uint6_t rxl_f := 63, + template (value) uint6_t rxl_s := 63, + template (value) uint3_t rxq_f := 0, + template (value) uint3_t rxq_s := 0, + boolean dtx_used := false, + boolean valid := true, + template (omit) NcellReports reps := omit) := { + ba_used := '0'B, + dtx_used := bool2bit(dtx_used), + rxlev_full_srv_cell := rxl_f, + threeg_ba_used := '0'B, + meas_valid := bool2bit(not valid), + rxlev_sub_srv_cell := rxl_s, + si23_ba_used := '0'B, + rxqual_full_srv_cell := rxq_f, + rxqual_sub_srv_cell := rxq_s, + no_ncell_m := 0, + ncell_reports := reps + }; + template (value) GsmRrL3Message ts_MEAS_REP(boolean valid, template (value) uint6_t rxl_f, template (value) uint6_t rxl_s, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 19:27:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 19:27:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 to look at the new patch set (#2). Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... BTS_Tests: add test cases for Temporary ACCH Overpower Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Related: SYS#5319 --- M bts/BTS_Tests.ttcn M library/GSM_RR_Types.ttcn 2 files changed, 329 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/26137/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Sat Nov 6 19:52:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Sat, 06 Nov 2021 19:52:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6186dd1162bdb_2ea32b0a73cf05f05676cc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 687s] # is like basename from coreutils, and . is WD. [ 687s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 687s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 687s] fi [ 687s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 687s] # in /usr/share/osmo-gsm-manuals. [ 687s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 687s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 688s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 688s] a2x: resource files: [] [ 688s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 688s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 688s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 688s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 688s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 688s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 688s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 688s] make[1]: *** [Makefile:452: all] Error 2 [ 688s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 688s] dh_auto_build: error: make -j1 returned exit code 2 [ 688s] make: *** [debian/rules:6: build] Error 25 [ 688s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 688s] ### VM INTERACTION START ### [ 689s] Powering off. [ 689s] [ 612.466975] reboot: Power down [ 689s] ### VM INTERACTION END ### [ 689s] [ 689s] cloud101 failed "build osmo-trx_1.3.1.dsc" at Sat Nov 6 19:52:09 UTC 2021. [ 689s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sat Nov 6 20:48:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 20:48:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 to look at the new patch set (#3). Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... BTS_Tests: add test cases for Temporary ACCH Overpower Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Related: SYS#5319 --- M bts/BTS_Tests.ttcn M library/GSM_RR_Types.ttcn 2 files changed, 332 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/26137/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 6 23:26:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 6 Nov 2021 23:26:03 +0000 Subject: Change in osmo-bsc[master]: ipaccess/ipaccess-config: reduce verbosity of the OML logging References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26138 ) Change subject: ipaccess/ipaccess-config: reduce verbosity of the OML logging ...................................................................... ipaccess/ipaccess-config: reduce verbosity of the OML logging Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/26138/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index ada23ea..9f23b56 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -925,7 +925,7 @@ .name = "DNM", .description = "A-bis Network Management / O&M (NM/OML)", .color = "\033[1;36m", - .loglevel = LOGL_DEBUG, + .loglevel = LOGL_NOTICE, .enabled = 1, }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e Gerrit-Change-Number: 26138 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 01:09:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 01:09:16 +0000 Subject: Change in osmo-bts[master]: common/Makefile.am: reformat {AM_CPPFLAGS, AM_CFLAGS, LDADD} References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26139 ) Change subject: common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} ...................................................................... common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} Change-Id: If475999cccc215b6792f276b9cc6c494a0c1ad81 --- M src/common/Makefile.am 1 file changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/26139/1 diff --git a/src/common/Makefile.am b/src/common/Makefile.am index 5b69b5c..35df73e 100644 --- a/src/common/Makefile.am +++ b/src/common/Makefile.am @@ -1,6 +1,21 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include -AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOTRAU_CFLAGS) $(LIBOSMOCODEC_CFLAGS) -LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOTRAU_LIBS) $(LIBOSMOCODEC_LIBS) +AM_CPPFLAGS = \ + $(all_includes) \ + -I$(top_srcdir)/include \ + -I$(top_builddir)/include \ + $(NULL) + +AM_CFLAGS = \ + -Wall \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMOCODEC_CFLAGS) \ + $(NULL) + +LDADD = \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMOCODEC_LIBS) \ + $(NULL) if ENABLE_LC15BTS AM_CFLAGS += -DENABLE_LC15BTS -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If475999cccc215b6792f276b9cc6c494a0c1ad81 Gerrit-Change-Number: 26139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 01:09:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 01:09:17 +0000 Subject: Change in osmo-bts[master]: tx_power: send CTRL TRAP when power ramping is completed References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26140 ) Change subject: tx_power: send CTRL TRAP when power ramping is completed ...................................................................... tx_power: send CTRL TRAP when power ramping is completed Change-Id: I747e1715e316999a6fb0c25275d9a86f42b5858d --- M include/osmo-bts/gsm_data.h M src/common/Makefile.am M src/common/main.c M src/common/tx_power.c M tests/stubs.c 5 files changed, 29 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/40/26140/1 diff --git a/include/osmo-bts/gsm_data.h b/include/osmo-bts/gsm_data.h index dcb357f..6660060 100644 --- a/include/osmo-bts/gsm_data.h +++ b/include/osmo-bts/gsm_data.h @@ -46,6 +46,7 @@ unsigned int num_bts; struct osmo_plmn_id plmn; struct pcu_sock_state *pcu_state; + struct ctrl_handle *ctrl; }; /* 16 is the max. number of SI2quater messages according to 3GPP TS 44.018 Table 10.5.2.33b.1: diff --git a/src/common/Makefile.am b/src/common/Makefile.am index 35df73e..f0c6ebb 100644 --- a/src/common/Makefile.am +++ b/src/common/Makefile.am @@ -7,12 +7,14 @@ AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOCTRL_CFLAGS) \ $(LIBOSMOTRAU_CFLAGS) \ $(LIBOSMOCODEC_CFLAGS) \ $(NULL) LDADD = \ $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOTRAU_LIBS) \ $(LIBOSMOCODEC_LIBS) \ $(NULL) diff --git a/src/common/main.c b/src/common/main.c index b5ba21b..b47dc0a 100644 --- a/src/common/main.c +++ b/src/common/main.c @@ -59,6 +59,8 @@ #include #include +extern struct gsm_network bts_gsmnet; + static int quit = 0; static const char *config_file = "osmo-bts.cfg"; static int daemonize = 0; @@ -384,7 +386,12 @@ gsmtap_source_add_sink(g_bts->gsmtap.inst); } - bts_controlif_setup(g_bts, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_BTS); + bts_gsmnet.ctrl = bts_controlif_setup(g_bts, ctrl_vty_get_bind_addr(), + OSMO_CTRL_PORT_BTS); + if (bts_gsmnet.ctrl == NULL) { + fprintf(stderr, "Error initializing the control interface\n"); + exit(1); + } rc = telnet_init_dynif(tall_bts_ctx, NULL, vty_get_bind_addr(), g_vty_port_num); diff --git a/src/common/tx_power.c b/src/common/tx_power.c index 0307422..5e86af0 100644 --- a/src/common/tx_power.c +++ b/src/common/tx_power.c @@ -24,12 +24,16 @@ #include #include +#include #include #include #include #include #include +#include + +extern struct gsm_network bts_gsmnet; static int get_pa_drive_level_mdBm(const struct power_amp *pa, int desired_p_out_mdBm, unsigned int arfcn) @@ -212,6 +216,16 @@ /* we had finished in last loop iteration */ if (!first && tpp->ramp.attenuation_mdB == 0) { + char *name = talloc_asprintf(trx, "bts.%u.trx.%u.power-ramping-completed", + trx->bts->nr, trx->nr); + /* FIXME: we always get "down" here */ + const char *dir = we_are_ramping_up(trx) ? "up" : "down"; + + LOGPTRX(trx, DL1C, LOGL_INFO, "Power ramping (%s) completed\n", dir); + + ctrl_cmd_send_trap(bts_gsmnet.ctrl, name, (char *)dir); + talloc_free(name); + if (tpp->ramp.compl_cb) tpp->ramp.compl_cb(trx); return; diff --git a/tests/stubs.c b/tests/stubs.c index b24dfc9..a8c4f6c 100644 --- a/tests/stubs.c +++ b/tests/stubs.c @@ -72,3 +72,7 @@ int bts_model_phy_link_open(struct phy_link *plink) { return 0; } + +struct ctrl_handle; +int ctrl_cmd_send_trap(struct ctrl_handle *ctrl, const char *name, char *value) +{ return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I747e1715e316999a6fb0c25275d9a86f42b5858d Gerrit-Change-Number: 26140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:25:05 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:25:05 +0000 Subject: Change in osmo-bsc[master]: for linter: s/while(0)/while (0) In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26134 ) Change subject: for linter: s/while(0)/while (0) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib422e7d1a7d543dcd8738581839ce55bb8fc29d2 Gerrit-Change-Number: 26134 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Sun, 07 Nov 2021 10:25:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:26:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:26:49 +0000 Subject: Change in osmo-bsc[master]: implement incoming_intra_bsc_ho:* rate counters In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26072 ) Change subject: implement incoming_intra_bsc_ho:* rate counters ...................................................................... Patch Set 3: Code-Review+2 trivial patch in that it is essentially a copy-paste of other HO counting code -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f2c6e2865ebe680879018fff08d283ce24c983 Gerrit-Change-Number: 26072 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Nov 2021 10:26:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:26:54 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:26:54 +0000 Subject: Change in osmo-bsc[master]: for linter: s/while(0)/while (0) In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26134 ) Change subject: for linter: s/while(0)/while (0) ...................................................................... for linter: s/while(0)/while (0) Change-Id: Ib422e7d1a7d543dcd8738581839ce55bb8fc29d2 --- M include/osmocom/bsc/assignment_fsm.h M include/osmocom/bsc/handover.h M include/osmocom/bsc/lchan_fsm.h M include/osmocom/bsc/lchan_rtp_fsm.h M include/osmocom/bsc/lcs_loc_req.h M include/osmocom/bsc/lcs_ta_req.h M include/osmocom/bsc/timeslot_fsm.h M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/handover_decision_2.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/lchan_rtp_fsm.c M src/osmo-bsc/lcs_loc_req.c M src/osmo-bsc/lcs_ta_req.c 14 files changed, 22 insertions(+), 22 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/include/osmocom/bsc/assignment_fsm.h b/include/osmocom/bsc/assignment_fsm.h index 3a64f7d..6c429e4 100644 --- a/include/osmocom/bsc/assignment_fsm.h +++ b/include/osmocom/bsc/assignment_fsm.h @@ -17,7 +17,7 @@ conn->assignment.new_lchan ? " of " : "", \ conn->assignment.new_lchan ? gsm_lchan_name(conn->assignment.new_lchan) : "", \ ## args); \ - } while(0) + } while (0) enum assignment_fsm_state { ASSIGNMENT_ST_WAIT_LCHAN_ACTIVE, diff --git a/include/osmocom/bsc/handover.h b/include/osmocom/bsc/handover.h index f671491..58fea35 100644 --- a/include/osmocom/bsc/handover.h +++ b/include/osmocom/bsc/handover.h @@ -17,7 +17,7 @@ else \ LOGP(DHODEC, level, "%s: " fmt, \ handover_status(conn), ## args); \ - } while(0) + } while (0) struct gsm_network; struct gsm_lchan; diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h index fa0d299..eb8312e 100644 --- a/include/osmocom/bsc/lchan_fsm.h +++ b/include/osmocom/bsc/lchan_fsm.h @@ -10,14 +10,14 @@ LOGPFSML((lchan)->fi, level, "(type=%s) " fmt, gsm_lchant_name((lchan)->type), ## args); \ else \ LOGP(DRSL, level, "%s (not initialized) " fmt, gsm_lchan_name(lchan), ## args); \ - } while(0) + } while (0) #define LCHAN_SET_LAST_ERROR(LCHAN, fmt, args...) do { \ if ((LCHAN)->last_error) \ talloc_free((LCHAN)->last_error); \ (LCHAN)->last_error = talloc_asprintf((LCHAN)->ts->trx, fmt, ##args); \ LOG_LCHAN(LCHAN, LOGL_ERROR, "%s\n", (LCHAN)->last_error); \ - } while(0) + } while (0) enum lchan_fsm_state { LCHAN_ST_UNUSED, diff --git a/include/osmocom/bsc/lchan_rtp_fsm.h b/include/osmocom/bsc/lchan_rtp_fsm.h index 6ff8fe3..18ab348 100644 --- a/include/osmocom/bsc/lchan_rtp_fsm.h +++ b/include/osmocom/bsc/lchan_rtp_fsm.h @@ -7,7 +7,7 @@ else \ LOGP(DLMGCP, level, "%s (not initialized) " fmt, gsm_lchan_name(lchan), \ ## args); \ - } while(0) + } while (0) struct gsm_lchan; struct mgcp_conn_peer; diff --git a/include/osmocom/bsc/lcs_loc_req.h b/include/osmocom/bsc/lcs_loc_req.h index ba677e8..86540f2 100644 --- a/include/osmocom/bsc/lcs_loc_req.h +++ b/include/osmocom/bsc/lcs_loc_req.h @@ -8,7 +8,7 @@ LOGPFSML((LOC_REQ)->fi, level, fmt, ## args); \ else \ LOGP(DLCS, level, "LCS Perf Loc Req: " fmt, ## args); \ - } while(0) + } while (0) struct lcs_ta_req; diff --git a/include/osmocom/bsc/lcs_ta_req.h b/include/osmocom/bsc/lcs_ta_req.h index b9b7a4e..bdfc14f 100644 --- a/include/osmocom/bsc/lcs_ta_req.h +++ b/include/osmocom/bsc/lcs_ta_req.h @@ -11,7 +11,7 @@ LOGPFSML((TA_REQ)->fi, level, fmt, ## args); \ else \ LOGP(DLCS, level, "LCS TA Req: " fmt, ## args); \ - } while(0) + } while (0) enum lcs_ta_req_fsm_event { LCS_TA_REQ_EV_GOT_TA, diff --git a/include/osmocom/bsc/timeslot_fsm.h b/include/osmocom/bsc/timeslot_fsm.h index 5e62188..526f3cf 100644 --- a/include/osmocom/bsc/timeslot_fsm.h +++ b/include/osmocom/bsc/timeslot_fsm.h @@ -17,7 +17,7 @@ gsm_ts_name(ts), \ ## args, \ (!fmt || !*fmt || fmt[strlen(fmt)-1] != '\n') ? "\n" : ""); \ - } while(0) + } while (0) enum ts_fsm_state { TS_ST_NOT_INITIALIZED, diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index f9a81b3..656bd3e 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -74,7 +74,7 @@ osmo_fsm_inst_state_name(fi), gsm0808_cause_name(cause), ## args); \ assignment_count_result(CTR_ASSIGNMENT_ERROR); \ on_assignment_failure(_conn); \ - } while(0) + } while (0) /* Assume presence of local var 'conn' as struct gsm_subscriber_connection */ #define assignment_count(counter) do { \ @@ -98,7 +98,7 @@ break; \ } \ } \ - } while(0) + } while (0) #define assignment_count_result(counter) do { \ if (!conn->assignment.result_rate_ctr_done) { \ @@ -109,7 +109,7 @@ "result rate counter already recorded, NOT counting as: %s %s\n", \ bsc_ctr_description[BSC_##counter].name, \ bsc_ctr_description[BSC_##counter].description); \ - } while(0) + } while (0) void assignment_reset(struct gsm_subscriber_connection *conn) { diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index d08173c..e384feb 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -86,7 +86,7 @@ LOGPHOLCHANTOBTS((candidate)->current.lchan, (candidate)->target.bts, level, fmt, ## args); \ else if ((candidate)->target.cell_ids.id_list_len) \ LOGPHOLCHANTOREMOTE((candidate)->current.lchan, &(candidate)->target.cell_ids, level, fmt, ## args); \ - } while(0) + } while (0) #define REQUIREMENT_A_TCHF 0x01 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 255478f..82a0588 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -90,7 +90,7 @@ bsc_ctr_description[counter].name, \ bsc_ctr_description[counter].description); \ rate_ctr_inc(rate_ctr_group_get_ctr(conn->network->bsc_ctrs, counter)); \ - } while(0) + } while (0) /* Assume presence of local var 'conn' as struct gsm_subscriber_connection. * Handles bts == NULL gracefully @@ -106,12 +106,12 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, counter)); \ else \ rate_ctr_inc(rate_ctr_group_get_ctr(conn->network->bts_unknown_ctrs, counter)); \ - } while(0) + } while (0) #define ho_count(bts, counter) do { \ ho_count_bsc(BSC_##counter); \ ho_count_bts(bts, BTS_##counter); \ -} while(0) +} while (0) static uint8_t g_next_ho_ref = 1; @@ -212,12 +212,12 @@ LOG_HO(conn, LOGL_ERROR, "Handover failed in state %s, %s: " fmt "\n", \ osmo_fsm_inst_state_name(conn->fi), handover_result_name(result), ## args); \ handover_end(conn, result); \ - } while(0) + } while (0) #define ho_success() do { \ LOG_HO(conn, LOGL_DEBUG, "Handover succeeded\n"); \ handover_end(conn, HO_RESULT_OK); \ - } while(0) + } while (0) /* issue handover to a cell identified by ARFCN and BSIC */ int handover_request(struct handover_out_req *req) diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 52aadce..d61d032 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -302,7 +302,7 @@ else \ LOG_LCHAN(_lchan, LOGL_DEBUG, "After failure handling, already in state %s\n", \ osmo_fsm_state_name(fsm, state_chg)); \ - } while(0) + } while (0) /* Which state to transition to when lchan_fail() is called in a given state. */ uint32_t lchan_fsm_on_error[34] = { diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index 7bd8209..62cd100 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -66,7 +66,7 @@ LCHAN_SET_LAST_ERROR(_lchan, "lchan-rtp failure in state %s: " fmt, \ osmo_fsm_state_name(fi->fsm, state_was), ## args); \ osmo_fsm_inst_dispatch(_lchan->fi, LCHAN_EV_RTP_ERROR, 0); \ - } while(0) + } while (0) /* Called from lchan_fsm_init(), does not need to be visible in lchan_rtp_fsm.h */ void lchan_rtp_fsm_init() diff --git a/src/osmo-bsc/lcs_loc_req.c b/src/osmo-bsc/lcs_loc_req.c index 7153ce6..d2ea72d 100644 --- a/src/osmo-bsc/lcs_loc_req.c +++ b/src/osmo-bsc/lcs_loc_req.c @@ -81,7 +81,7 @@ .cause_val = cause, \ }; \ lcs_loc_req_fsm_state_chg(lcs_loc_req->fi, LCS_LOC_REQ_ST_FAILED); \ - } while(0) + } while (0) static struct lcs_loc_req *lcs_loc_req_alloc(struct osmo_fsm_inst *parent_fi, uint32_t parent_event_term) { @@ -110,7 +110,7 @@ #define PARSE_ERR(ERRMSG) do { \ lcs_loc_req_fail(LCS_CAUSE_PROTOCOL_ERROR, "rx BSSMAP Perform Location Request: " ERRMSG); \ return false; \ - } while(0) + } while (0) payload_length = msg->tail - msg->l4h; if (tlv_parse2(tp_arr, 1, gsm0808_att_tlvdef(), msg->l4h + 1, payload_length - 1, 0, 0) <= 0) diff --git a/src/osmo-bsc/lcs_ta_req.c b/src/osmo-bsc/lcs_ta_req.c index bcee6e1..6252d46 100644 --- a/src/osmo-bsc/lcs_ta_req.c +++ b/src/osmo-bsc/lcs_ta_req.c @@ -63,7 +63,7 @@ lcs_ta_req ? osmo_fsm_inst_state_name(lcs_ta_req->fi) : "NULL", ## args); \ lcs_ta_req->failure_cause = cause; \ lcs_ta_req_fsm_state_chg(lcs_ta_req->fi, LCS_TA_REQ_ST_FAILED); \ - } while(0) + } while (0) static struct osmo_fsm lcs_ta_req_fsm; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib422e7d1a7d543dcd8738581839ce55bb8fc29d2 Gerrit-Change-Number: 26134 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:26:54 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:26:54 +0000 Subject: Change in osmo-bsc[master]: cosmetic tweaks on handover counting code In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26070 ) Change subject: cosmetic tweaks on handover counting code ...................................................................... cosmetic tweaks on handover counting code I was a bit confused that grep did not find HO counters being used, so let's add some comments to better explain and provide a grep hook. Related: SYS#4878 Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 --- M src/osmo-bsc/handover_fsm.c 1 file changed, 25 insertions(+), 3 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 82a0588..7cf11cc 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -108,10 +108,13 @@ rate_ctr_inc(rate_ctr_group_get_ctr(conn->network->bts_unknown_ctrs, counter)); \ } while (0) +/* Count handover result on both bts and bsc level. + * Call with 'counter' being the counter name without the "BSC_"/"BTS_" part, + * e.g. ho_count(conn_get_bts(conn), CTR_HANDOVER_ATTEMPTED); */ #define ho_count(bts, counter) do { \ - ho_count_bsc(BSC_##counter); \ - ho_count_bts(bts, BTS_##counter); \ -} while (0) + ho_count_bsc(BSC_##counter); \ + ho_count_bts(bts, BTS_##counter); \ + } while (0) static uint8_t g_next_ho_ref = 1; @@ -748,6 +751,23 @@ lchan_activate(ho->new_lchan, &info); } +/* Create functions result_counter_{BSC,BTS}_{HANDOVER,...}(), to evaluate the handover result and return + * BSC_CTR_HANDOVER_ATTEMPTED, + * BSC_CTR_HANDOVER_COMPLETED, + * BSC_CTR_HANDOVER_STOPPED, + * BSC_CTR_HANDOVER_NO_CHANNEL, + * BSC_CTR_HANDOVER_TIMEOUT, + * BSC_CTR_HANDOVER_FAILED, + * BSC_CTR_HANDOVER_ERROR, + * or + * BTS_CTR_HANDOVER_ATTEMPTED, + * BTS_CTR_HANDOVER_COMPLETED, + * BTS_CTR_HANDOVER_STOPPED, + * BTS_CTR_HANDOVER_NO_CHANNEL, + * BTS_CTR_HANDOVER_TIMEOUT, + * BTS_CTR_HANDOVER_FAILED, + * BTS_CTR_HANDOVER_ERROR, + */ #define FUNC_RESULT_COUNTER(obj, name) \ static int result_counter_##obj##_##name(enum handover_result result) \ { \ @@ -773,6 +793,7 @@ FUNC_RESULT_COUNTER(BSC, INTRA_BSC_HO) FUNC_RESULT_COUNTER(BSC, INTER_BSC_HO_IN) +/* INTRA_BSC_HO_OUT does not have a NO_CHANNEL result, so can't do this with FUNC_RESULT_COUNTER() macro. */ static int result_counter_BSC_INTER_BSC_HO_OUT(enum handover_result result) { switch (result) { case HO_RESULT_OK: @@ -810,6 +831,7 @@ FUNC_RESULT_COUNTER(BTS, INTRA_BSC_HO) FUNC_RESULT_COUNTER(BTS, INTER_BSC_HO_IN) +/* INTRA_BSC_HO_OUT does not have a NO_CHANNEL result, so can't do this with FUNC_RESULT_COUNTER() macro. */ static int result_counter_BTS_INTER_BSC_HO_OUT(enum handover_result result) { switch (result) { case HO_RESULT_OK: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I242de13e657286e09428a8ca6e583d8b5155faa2 Gerrit-Change-Number: 26070 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:26:55 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:26:55 +0000 Subject: Change in osmo-bsc[master]: tweak intra-bsc ho counter descriptions In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26071 ) Change subject: tweak intra-bsc ho counter descriptions ...................................................................... tweak intra-bsc ho counter descriptions Related: SYS#4878 Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 --- M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index 7176809..ccba4a6 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -35,13 +35,13 @@ [BSC_CTR_ASSIGNMENT_FAILED] = {"assignment:failed", "Received Assignment Failure message"}, [BSC_CTR_ASSIGNMENT_ERROR] = {"assignment:error", "Assignment failed for other reason"}, - [BSC_CTR_HANDOVER_ATTEMPTED] = {"handover:attempted", "Intra-BSC handover attempts"}, - [BSC_CTR_HANDOVER_COMPLETED] = {"handover:completed", "Intra-BSC handover completed"}, + [BSC_CTR_HANDOVER_ATTEMPTED] = {"handover:attempted", "Handover attempts"}, + [BSC_CTR_HANDOVER_COMPLETED] = {"handover:completed", "Handover completed"}, [BSC_CTR_HANDOVER_STOPPED] = {"handover:stopped", "Connection ended during HO"}, [BSC_CTR_HANDOVER_NO_CHANNEL] = {"handover:no_channel", "Failure to allocate lchan for HO"}, [BSC_CTR_HANDOVER_TIMEOUT] = {"handover:timeout", "Handover timed out"}, [BSC_CTR_HANDOVER_FAILED] = {"handover:failed", "Received Handover Fail messages"}, - [BSC_CTR_HANDOVER_ERROR] = {"handover:error", "Re-assignment failed for other reason"}, + [BSC_CTR_HANDOVER_ERROR] = {"handover:error", "Handover failed for other reason"}, [BSC_CTR_INTRA_CELL_HO_ATTEMPTED] = {"intra_cell_ho:attempted", "Intra-Cell handover attempts"}, [BSC_CTR_INTRA_CELL_HO_COMPLETED] = {"intra_cell_ho:completed", "Intra-Cell handover completed"}, @@ -49,15 +49,15 @@ [BSC_CTR_INTRA_CELL_HO_NO_CHANNEL] = {"intra_cell_ho:no_channel", "Failure to allocate lchan for HO"}, [BSC_CTR_INTRA_CELL_HO_TIMEOUT] = {"intra_cell_ho:timeout", "Handover timed out"}, [BSC_CTR_INTRA_CELL_HO_FAILED] = {"intra_cell_ho:failed", "Received Handover Fail messages"}, - [BSC_CTR_INTRA_CELL_HO_ERROR] = {"intra_cell_ho:error", "Re-assignment failed for other reason"}, + [BSC_CTR_INTRA_CELL_HO_ERROR] = {"intra_cell_ho:error", "Intra-cell handover failed for other reason"}, - [BSC_CTR_INTRA_BSC_HO_ATTEMPTED] = {"intra_bsc_ho:attempted", "Intra-BSC handover attempts"}, - [BSC_CTR_INTRA_BSC_HO_COMPLETED] = {"intra_bsc_ho:completed", "Intra-BSC handover completed"}, + [BSC_CTR_INTRA_BSC_HO_ATTEMPTED] = {"intra_bsc_ho:attempted", "Intra-BSC inter-cell handover attempts"}, + [BSC_CTR_INTRA_BSC_HO_COMPLETED] = {"intra_bsc_ho:completed", "Intra-BSC inter-cell handover completed"}, [BSC_CTR_INTRA_BSC_HO_STOPPED] = {"intra_bsc_ho:stopped", "Connection ended during HO"}, [BSC_CTR_INTRA_BSC_HO_NO_CHANNEL] = {"intra_bsc_ho:no_channel", "Failure to allocate lchan for HO"}, [BSC_CTR_INTRA_BSC_HO_TIMEOUT] = {"intra_bsc_ho:timeout", "Handover timed out"}, [BSC_CTR_INTRA_BSC_HO_FAILED] = {"intra_bsc_ho:failed", "Received Handover Fail messages"}, - [BSC_CTR_INTRA_BSC_HO_ERROR] = {"intra_bsc_ho:error", "Re-assignment failed for other reason"}, + [BSC_CTR_INTRA_BSC_HO_ERROR] = {"intra_bsc_ho:error", "Intra-BSC inter-cell HO failed for other reason"}, [BSC_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = {"interbsc_ho_out:attempted", "Attempts to handover to remote BSS"}, diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 28059bb..ee2e791 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1146,10 +1146,10 @@ [BTS_CTR_INTRA_BSC_HO_ATTEMPTED] = \ { "intra_bsc_ho:attempted", - "Intra-BSC handover attempts" }, + "Intra-BSC inter-cell handover attempts" }, [BTS_CTR_INTRA_BSC_HO_COMPLETED] = \ { "intra_bsc_ho:completed", - "Intra-BSC handover completed" }, + "Intra-BSC inter-cell handover completed" }, [BTS_CTR_INTRA_BSC_HO_STOPPED] = \ { "intra_bsc_ho:stopped", "Connection ended during HO" }, @@ -1164,7 +1164,7 @@ "Received Handover Fail messages" }, [BTS_CTR_INTRA_BSC_HO_ERROR] = \ { "intra_bsc_ho:error", - "Re-assignment failed for other reason" }, + "Intra-BSC inter-cell HO failed for other reason" }, [BTS_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = \ { "interbsc_ho_out:attempted", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 Gerrit-Change-Number: 26071 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:26:55 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:26:55 +0000 Subject: Change in osmo-bsc[master]: implement incoming_intra_bsc_ho:* rate counters In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26072 ) Change subject: implement incoming_intra_bsc_ho:* rate counters ...................................................................... implement incoming_intra_bsc_ho:* rate counters We have lots of counters for intra-BSC handover *away from* a given BTS, but still missing are counters indicating how many handovers *targeted* a given BTS. Also count incoming HO. Related: SYS#4878 Related: Iba229313d73fa20266f6d4eac5820579fb14c604 (osmo-ttcn3-hacks) Change-Id: Id9f2c6e2865ebe680879018fff08d283ce24c983 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/handover_fsm.c 3 files changed, 34 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 68e7cfe..7e73acd 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -131,6 +131,13 @@ BTS_CTR_INTRA_BSC_HO_TIMEOUT, BTS_CTR_INTRA_BSC_HO_FAILED, BTS_CTR_INTRA_BSC_HO_ERROR, + BTS_CTR_INCOMING_INTRA_BSC_HO_ATTEMPTED, + BTS_CTR_INCOMING_INTRA_BSC_HO_COMPLETED, + BTS_CTR_INCOMING_INTRA_BSC_HO_STOPPED, + BTS_CTR_INCOMING_INTRA_BSC_HO_NO_CHANNEL, + BTS_CTR_INCOMING_INTRA_BSC_HO_TIMEOUT, + BTS_CTR_INCOMING_INTRA_BSC_HO_FAILED, + BTS_CTR_INCOMING_INTRA_BSC_HO_ERROR, BTS_CTR_INTER_BSC_HO_OUT_ATTEMPTED, BTS_CTR_INTER_BSC_HO_OUT_COMPLETED, BTS_CTR_INTER_BSC_HO_OUT_STOPPED, diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index ee2e791..83adcc4 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1166,6 +1166,28 @@ { "intra_bsc_ho:error", "Intra-BSC inter-cell HO failed for other reason" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_ATTEMPTED] = \ + { "incoming_intra_bsc_ho:attempted", + "Incoming intra-BSC inter-cell handover attempts" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_COMPLETED] = \ + { "incoming_intra_bsc_ho:completed", + "Incoming intra-BSC inter-cell handover completed" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_STOPPED] = \ + { "incoming_intra_bsc_ho:stopped", + "Connection ended during HO" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_NO_CHANNEL] = \ + { "incoming_intra_bsc_ho:no_channel", + "Failure to allocate lchan for HO" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_TIMEOUT] = \ + { "incoming_intra_bsc_ho:timeout", + "Handover timed out" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_FAILED] = \ + { "incoming_intra_bsc_ho:failed", + "Received Handover Fail messages" }, + [BTS_CTR_INCOMING_INTRA_BSC_HO_ERROR] = \ + { "incoming_intra_bsc_ho:error", + "Incoming intra-BSC inter-cell HO failed for other reason" }, + [BTS_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = \ { "interbsc_ho_out:attempted", "Attempts to handover to remote BSS" }, diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 7cf11cc..37e7417 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -387,6 +387,7 @@ } else { ho_count(bts, CTR_INTRA_BSC_HO_ATTEMPTED); ho_fsm_update_id(fi, "intraBSC"); + ho_count_bts(ho->new_bts, BTS_CTR_INCOMING_INTRA_BSC_HO_ATTEMPTED); } if (!ho->new_lchan) { @@ -829,6 +830,7 @@ FUNC_RESULT_COUNTER(BTS, HANDOVER) FUNC_RESULT_COUNTER(BTS, INTRA_CELL_HO) FUNC_RESULT_COUNTER(BTS, INTRA_BSC_HO) +FUNC_RESULT_COUNTER(BTS, INCOMING_INTRA_BSC_HO) FUNC_RESULT_COUNTER(BTS, INTER_BSC_HO_IN) /* INTRA_BSC_HO_OUT does not have a NO_CHANNEL result, so can't do this with FUNC_RESULT_COUNTER() macro. */ @@ -1020,6 +1022,9 @@ ho_count_bsc(result_counter_bsc(ho->scope, result)); ho_count_bts(bts, result_counter_BTS_HANDOVER(result)); ho_count_bts(bts, result_counter_bts(ho->scope, result)); + /* For inter-cell HO, also increment the "INCOMING" counters on the target BTS. */ + if (ho->scope & HO_INTRA_BSC) + ho_count_bts(ho->new_bts, result_counter_BTS_INCOMING_INTRA_BSC_HO(result)); if (ho->scope & HO_INTER_BSC_IN && conn->fast_return.last_eutran_plmn_valid) { /* From outside local BSC and with Last EUTRAN PLMN Id => SRVCC */ ho_count_bsc(result_counter_BSC_SRVCC(result)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f2c6e2865ebe680879018fff08d283ce24c983 Gerrit-Change-Number: 26072 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:27:39 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:27:39 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: comment: tweak TS reference In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25970 ) Change subject: bsc: comment: tweak TS reference ...................................................................... bsc: comment: tweak TS reference Change-Id: I53ec51240d6e9a0f93f784c8afee2f54226cc51f --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index f602929..833b6f9 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1400,7 +1400,7 @@ chreq_total := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total"); chreq_nochan := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:no_channel"); - /* GSM 04.08 Table 9.9a: + /* GSM 44.018 Table 9.1.8.2: * RA = '33'O -> Establishment cause = 0011xxxx (MS dual rate capable and asks for "TCH/H or TCH/F"). * With current setup, expect 4xSDCCH + 4xTCH/F + 1xTCH/H to succeed */ for (i := 0; i < NUM_TCHF_PER_BTS + NUM_TCHH_PER_BTS + NUM_SDCCH_PER_BTS; i := i+1) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53ec51240d6e9a0f93f784c8afee2f54226cc51f Gerrit-Change-Number: 25970 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 10:32:43 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 10:32:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add testing of incoming_intra_bsc_ho rate_ctrs References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 ) Change subject: bsc: add testing of incoming_intra_bsc_ho rate_ctrs ...................................................................... bsc: add testing of incoming_intra_bsc_ho rate_ctrs Related: SYS#4878 Related: Id9f2c6e2865ebe680879018fff08d283ce24c983 (osmo-bsc) Change-Id: Iba229313d73fa20266f6d4eac5820579fb14c604 --- M bsc/BSC_Tests.ttcn 1 file changed, 59 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/26141/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 833b6f9..236889a 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -170,6 +170,16 @@ { "interbsc_ho_in:error", 0 } }; +const CounterNameVals counternames_bts_handover := { + { "incoming_intra_bsc_ho:attempted", 0 }, + { "incoming_intra_bsc_ho:completed", 0 }, + { "incoming_intra_bsc_ho:stopped", 0 }, + { "incoming_intra_bsc_ho:no_channel", 0 }, + { "incoming_intra_bsc_ho:timeout", 0 }, + { "incoming_intra_bsc_ho:failed", 0 }, + { "incoming_intra_bsc_ho:error", 0 } +}; + /* Set of all System Information received during one RSL port's startup. * Note that some System Information may be sent on RSL, but lacking actual SI data, to indicate that the BTS should not * broadcast that SI type. That will be reflected as 'omit' here. @@ -762,8 +772,19 @@ f_ctrs_bsc_init(counternames); } -private function f_ctrs_bsc_and_bts_add(integer bts_nr, charstring countername, integer val := 1) runs on test_CT { +private function f_ctrs_bsc_and_bts_handover_init(integer bts_count := NUM_BTS) runs on test_CT { + var CounterNameVals bts_names := counternames_bsc_bts_handover & counternames_bts_handover; + g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, bts_names); + log("initial bts rate counters: ", g_ctr_bts); + f_ctrs_bsc_init(counternames_bsc_bts_handover); +} + +private function f_ctrs_bts_add(integer bts_nr, charstring countername, integer val := 1) runs on test_CT { f_counter_name_vals_list_add(g_ctr_bts, bts_nr, countername, val); +} + +private function f_ctrs_bsc_and_bts_add(integer bts_nr, charstring countername, integer val := 1) runs on test_CT { + f_ctrs_bts_add(bts_nr, countername, val); f_ctrs_bsc_add(countername, val); } @@ -5154,7 +5175,7 @@ pars.expect_tsc := BTS_TSC[0]; - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_int), pars); vc_conn.done; @@ -5167,6 +5188,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:completed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:completed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:completed"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); } @@ -5180,7 +5203,7 @@ f_vty_encryption_a5(enc_a5); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_int), pars); vc_conn.done; @@ -5193,6 +5216,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:completed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:completed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:completed"); f_ctrs_bsc_and_bts_verify(); f_vty_encryption_a5_reset(); f_shutdown_helper(); @@ -5300,7 +5325,7 @@ f_init(2, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_int_radio_link_failure)); vc_conn.done; @@ -5313,6 +5338,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:stopped"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:stopped"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:stopped"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); } @@ -5420,7 +5447,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_of_this_bsc)); vc_conn.done; @@ -5503,7 +5530,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_msc_response)); vc_conn.done; @@ -5584,7 +5611,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_fail_rr_ho_failure)); vc_conn.done; @@ -5684,7 +5711,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_result_after_ho_cmd)); vc_conn.done; @@ -5801,7 +5828,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -5903,7 +5930,7 @@ } f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.last_used_eutran_plmn := '323454'O; pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; @@ -6010,7 +6037,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6100,7 +6127,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6189,7 +6216,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6270,7 +6297,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6480,7 +6507,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 60.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_1)); vc_conn.done; @@ -6495,6 +6522,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:failed"); /* 1.b */ f_ctrs_bsc_and_bts_add(0, "handover:attempted"); @@ -6509,6 +6538,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:failed"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); @@ -6540,7 +6571,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_2)); vc_conn.done; @@ -6555,6 +6586,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:failed"); /* 2.b */ f_ctrs_bsc_and_bts_add(0, "handover:attempted"); @@ -6589,7 +6622,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_3)); vc_conn.done; @@ -6608,6 +6641,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:failed"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); @@ -6641,7 +6676,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_4)); vc_conn.done; @@ -6691,7 +6726,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_5)); vc_conn.done; @@ -6734,7 +6769,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_6)); vc_conn.done; @@ -6778,7 +6813,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_7)); vc_conn.done; @@ -6793,6 +6828,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:failed"); /* 7.b */ /* "timeout" means a handover was triggered and started (which is all this test aims for) and the test ended the @@ -9750,7 +9787,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); vc_conn := f_start_handler(refers(f_TC_reassignment_codec), pars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba229313d73fa20266f6d4eac5820579fb14c604 Gerrit-Change-Number: 26141 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 13:16:29 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 13:16:29 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26142 ) Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... implement bts.N.cm_serv_rej: rate counters Related: I0214b27da18af87eca9715ebf7eeeff945e3e12a (osmo-ttcn3-hacks) Related: SYS#4878 Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c 3 files changed, 202 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/26142/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 7e73acd..8e168ec 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -158,6 +158,31 @@ BTS_CTR_SRVCC_TIMEOUT, BTS_CTR_SRVCC_FAILED, BTS_CTR_SRVCC_ERROR, + BTS_CTR_CM_SERVICE_REJECT, + BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_HLR, + BTS_CTR_CM_SERV_REJ_ILLEGAL_MS, + BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_VLR, + BTS_CTR_CM_SERV_REJ_IMEI_NOT_ACCEPTED, + BTS_CTR_CM_SERV_REJ_ILLEGAL_ME, + BTS_CTR_CM_SERV_REJ_PLMN_NOT_ALLOWED, + BTS_CTR_CM_SERV_REJ_LOC_NOT_ALLOWED, + BTS_CTR_CM_SERV_REJ_ROAMING_NOT_ALLOWED, + BTS_CTR_CM_SERV_REJ_NETWORK_FAILURE, + BTS_CTR_CM_SERV_REJ_SYNCH_FAILURE, + BTS_CTR_CM_SERV_REJ_CONGESTION, + BTS_CTR_CM_SERV_REJ_SRV_OPT_NOT_SUPPORTED, + BTS_CTR_CM_SERV_REJ_RQD_SRV_OPT_NOT_SUPPORTED, + BTS_CTR_CM_SERV_REJ_SRV_OPT_TMP_OUT_OF_ORDER, + BTS_CTR_CM_SERV_REJ_CALL_CAN_NOT_BE_IDENTIFIED, + BTS_CTR_CM_SERV_REJ_INCORRECT_MESSAGE, + BTS_CTR_CM_SERV_REJ_INVALID_MANDANTORY_INF, + BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_IMPLEMENTED, + BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_COMPATIBLE, + BTS_CTR_CM_SERV_REJ_INF_ELEME_NOT_IMPLEMENTED, + BTS_CTR_CM_SERV_REJ_CONDTIONAL_IE_ERROR, + BTS_CTR_CM_SERV_REJ_MSG_NOT_COMPATIBLE, + BTS_CTR_CM_SERV_REJ_PROTOCOL_ERROR, + BTS_CTR_CM_SERV_REJ_RETRY_IN_NEW_CELL, }; extern const struct rate_ctr_desc bts_ctr_description[]; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index cdd57c2..b6f11a9 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1021,6 +1021,106 @@ } +/* For 3GPP TS 52.402 unsuccReqsForService, we need to decode the DTAP and count CM Service Reject messages. */ +static void count_unsucc_reqs_for_service(struct msgb *msg) +{ + struct gsm_bts *bts = msg->lchan->ts->trx->bts; + struct gsm48_hdr *gh; + uint8_t pdisc, mtype; + uint8_t cause; + + if (msgb_l3len(msg) < sizeof(*gh)) + return; + + gh = msgb_l3(msg); + pdisc = gsm48_hdr_pdisc(gh); + mtype = gsm48_hdr_msg_type(gh); + + if (pdisc != GSM48_PDISC_MM || mtype != GSM48_MT_MM_CM_SERV_REJ) + return; + + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERVICE_REJECT)); + + cause = gh->data[0]; + switch (cause) { + case GSM48_REJECT_IMSI_UNKNOWN_IN_HLR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_HLR)); + break; + case GSM48_REJECT_ILLEGAL_MS: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_ILLEGAL_MS)); + break; + case GSM48_REJECT_IMSI_UNKNOWN_IN_VLR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_VLR)); + break; + case GSM48_REJECT_IMEI_NOT_ACCEPTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_IMEI_NOT_ACCEPTED)); + break; + case GSM48_REJECT_ILLEGAL_ME: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_ILLEGAL_ME)); + break; + case GSM48_REJECT_PLMN_NOT_ALLOWED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_PLMN_NOT_ALLOWED)); + break; + case GSM48_REJECT_LOC_NOT_ALLOWED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_LOC_NOT_ALLOWED)); + break; + case GSM48_REJECT_ROAMING_NOT_ALLOWED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_ROAMING_NOT_ALLOWED)); + break; + case GSM48_REJECT_NETWORK_FAILURE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_NETWORK_FAILURE)); + break; + case GSM48_REJECT_SYNCH_FAILURE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_SYNCH_FAILURE)); + break; + case GSM48_REJECT_CONGESTION: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_CONGESTION)); + break; + case GSM48_REJECT_SRV_OPT_NOT_SUPPORTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_SRV_OPT_NOT_SUPPORTED)); + break; + case GSM48_REJECT_RQD_SRV_OPT_NOT_SUPPORTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_RQD_SRV_OPT_NOT_SUPPORTED)); + break; + case GSM48_REJECT_SRV_OPT_TMP_OUT_OF_ORDER: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_SRV_OPT_TMP_OUT_OF_ORDER)); + break; + case GSM48_REJECT_CALL_CAN_NOT_BE_IDENTIFIED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_CALL_CAN_NOT_BE_IDENTIFIED)); + break; + case GSM48_REJECT_INCORRECT_MESSAGE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_INCORRECT_MESSAGE)); + break; + case GSM48_REJECT_INVALID_MANDANTORY_INF: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_INVALID_MANDANTORY_INF)); + break; + case GSM48_REJECT_MSG_TYPE_NOT_IMPLEMENTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_IMPLEMENTED)); + break; + case GSM48_REJECT_MSG_TYPE_NOT_COMPATIBLE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_COMPATIBLE)); + break; + case GSM48_REJECT_INF_ELEME_NOT_IMPLEMENTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_INF_ELEME_NOT_IMPLEMENTED)); + break; + case GSM48_REJECT_CONDTIONAL_IE_ERROR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_CONDTIONAL_IE_ERROR)); + break; + case GSM48_REJECT_MSG_NOT_COMPATIBLE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_MSG_NOT_COMPATIBLE)); + break; + default: + if (cause >= 48 && cause <= 63) { + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_RETRY_IN_NEW_CELL)); + break; + } + /* else fall thru */ + case GSM48_REJECT_PROTOCOL_ERROR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_PROTOCOL_ERROR)); + break; + } +} + /* Send "DATA REQUEST" message with given L3 Info payload */ /* Chapter 8.3.1 */ int rsl_data_request(struct msgb *msg, uint8_t link_id) @@ -1033,6 +1133,8 @@ return -EINVAL; } + count_unsucc_reqs_for_service(msg); + chan_nr = gsm_lchan2chan_nr(msg->lchan, true); if (chan_nr < 0) { msgb_free(msg); diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 83adcc4..d13f3b7 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1249,6 +1249,81 @@ [BTS_CTR_SRVCC_ERROR] = \ { "srvcc:error", "Re-assignment failed for other reason" }, + + [BTS_CTR_CM_SERVICE_REJECT] = + { "cm_serv_rej", "MSC sent CM Service Reject" }, + [BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_HLR] = + { "cm_serv_rej:imsi_unknown_in_hlr", + "MSC sent CM Service Reject with cause IMSI_UNKNOWN_IN_HLR" }, + [BTS_CTR_CM_SERV_REJ_ILLEGAL_MS] = + { "cm_serv_rej:illegal_ms", + "MSC sent CM Service Reject with cause ILLEGAL_MS" }, + [BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_VLR] = + { "cm_serv_rej:imsi_unknown_in_vlr", + "MSC sent CM Service Reject with cause IMSI_UNKNOWN_IN_VLR" }, + [BTS_CTR_CM_SERV_REJ_IMEI_NOT_ACCEPTED] = + { "cm_serv_rej:imei_not_accepted", + "MSC sent CM Service Reject with cause IMEI_NOT_ACCEPTED" }, + [BTS_CTR_CM_SERV_REJ_ILLEGAL_ME] = + { "cm_serv_rej:illegal_me", + "MSC sent CM Service Reject with cause ILLEGAL_ME" }, + [BTS_CTR_CM_SERV_REJ_PLMN_NOT_ALLOWED] = + { "cm_serv_rej:plmn_not_allowed", + "MSC sent CM Service Reject with cause PLMN_NOT_ALLOWED" }, + [BTS_CTR_CM_SERV_REJ_LOC_NOT_ALLOWED] = + { "cm_serv_rej:loc_not_allowed", + "MSC sent CM Service Reject with cause LOC_NOT_ALLOWED" }, + [BTS_CTR_CM_SERV_REJ_ROAMING_NOT_ALLOWED] = + { "cm_serv_rej:roaming_not_allowed", + "MSC sent CM Service Reject with cause ROAMING_NOT_ALLOWED" }, + [BTS_CTR_CM_SERV_REJ_NETWORK_FAILURE] = + { "cm_serv_rej:network_failure", + "MSC sent CM Service Reject with cause NETWORK_FAILURE" }, + [BTS_CTR_CM_SERV_REJ_SYNCH_FAILURE] = + { "cm_serv_rej:synch_failure", + "MSC sent CM Service Reject with cause SYNCH_FAILURE" }, + [BTS_CTR_CM_SERV_REJ_CONGESTION] = + { "cm_serv_rej:congestion", + "MSC sent CM Service Reject with cause CONGESTION" }, + [BTS_CTR_CM_SERV_REJ_SRV_OPT_NOT_SUPPORTED] = + { "cm_serv_rej:srv_opt_not_supported", + "MSC sent CM Service Reject with cause SRV_OPT_NOT_SUPPORTED" }, + [BTS_CTR_CM_SERV_REJ_RQD_SRV_OPT_NOT_SUPPORTED] = + { "cm_serv_rej:rqd_srv_opt_not_supported", + "MSC sent CM Service Reject with cause RQD_SRV_OPT_NOT_SUPPORTED" }, + [BTS_CTR_CM_SERV_REJ_SRV_OPT_TMP_OUT_OF_ORDER] = + { "cm_serv_rej:srv_opt_tmp_out_of_order", + "MSC sent CM Service Reject with cause SRV_OPT_TMP_OUT_OF_ORDER" }, + [BTS_CTR_CM_SERV_REJ_CALL_CAN_NOT_BE_IDENTIFIED] = + { "cm_serv_rej:call_can_not_be_identified", + "MSC sent CM Service Reject with cause CALL_CAN_NOT_BE_IDENTIFIED" }, + [BTS_CTR_CM_SERV_REJ_INCORRECT_MESSAGE] = + { "cm_serv_rej:incorrect_message", + "MSC sent CM Service Reject with cause INCORRECT_MESSAGE" }, + [BTS_CTR_CM_SERV_REJ_INVALID_MANDANTORY_INF] = + { "cm_serv_rej:invalid_mandantory_inf", + "MSC sent CM Service Reject with cause INVALID_MANDANTORY_INF" }, + [BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_IMPLEMENTED] = + { "cm_serv_rej:msg_type_not_implemented", + "MSC sent CM Service Reject with cause MSG_TYPE_NOT_IMPLEMENTED" }, + [BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_COMPATIBLE] = + { "cm_serv_rej:msg_type_not_compatible", + "MSC sent CM Service Reject with cause MSG_TYPE_NOT_COMPATIBLE" }, + [BTS_CTR_CM_SERV_REJ_INF_ELEME_NOT_IMPLEMENTED] = + { "cm_serv_rej:inf_eleme_not_implemented", + "MSC sent CM Service Reject with cause INF_ELEME_NOT_IMPLEMENTED" }, + [BTS_CTR_CM_SERV_REJ_CONDTIONAL_IE_ERROR] = + { "cm_serv_rej:condtional_ie_error", + "MSC sent CM Service Reject with cause CONDTIONAL_IE_ERROR" }, + [BTS_CTR_CM_SERV_REJ_MSG_NOT_COMPATIBLE] = + { "cm_serv_rej:msg_not_compatible", + "MSC sent CM Service Reject with cause MSG_NOT_COMPATIBLE" }, + [BTS_CTR_CM_SERV_REJ_PROTOCOL_ERROR] = + { "cm_serv_rej:protocol_error", + "MSC sent CM Service Reject with cause PROTOCOL_ERROR" }, + [BTS_CTR_CM_SERV_REJ_RETRY_IN_NEW_CELL] = + { "cm_serv_rej:retry_in_new_cell", + "MSC sent CM Service Reject with cause 00110000..00111111, Retry upon entry in a new cell" }, }; const struct rate_ctr_group_desc bts_ctrg_desc = { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 13:16:58 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sun, 7 Nov 2021 13:16:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add test for CM Service Reject counter References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 ) Change subject: bsc: add test for CM Service Reject counter ...................................................................... bsc: add test for CM Service Reject counter Related: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b (osmo-bsc) Related: SYS#4878 Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a --- M bsc/BSC_Tests.ttcn M library/L3_Templates.ttcn 2 files changed, 82 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/26143/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 236889a..f060a6e 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -766,8 +766,12 @@ /* Convenience functions for rate counters using g_ctr_bts, always also including g_ctr_bsc. */ -private function f_ctrs_bsc_and_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { +private function f_ctrs_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, counternames); +} + +function f_ctrs_bsc_and_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { + f_ctrs_bts_init(bts_count, counternames); log("initial bts rate counters: ", g_ctr_bts); f_ctrs_bsc_init(counternames); } @@ -788,6 +792,10 @@ f_ctrs_bsc_add(countername, val); } +function f_ctrs_bts_verify() runs on test_CT { + f_counter_name_vals_expect_n(IPA_CTRL, "bts", g_ctr_bts); +} + /* f_ctrs_bsc_and_bts_init(); * f_do_thing(on_bts := 0); * f_do_thing(on_bts := 0); @@ -797,7 +805,7 @@ * f_ctrs_bsc_and_bts_verify(); */ private function f_ctrs_bsc_and_bts_verify() runs on test_CT { - f_counter_name_vals_expect_n(IPA_CTRL, "bts", g_ctr_bts); + f_ctrs_bts_verify(); f_ctrs_bsc_verify(); } @@ -10344,6 +10352,59 @@ f_shutdown_helper(); } +const CounterNameVals counternames_cm_serv_rej := { + { "cm_serv_rej", 0 }, + { "cm_serv_rej:imsi_unknown_in_hlr", 0 }, + { "cm_serv_rej:illegal_ms", 0 }, + { "cm_serv_rej:imsi_unknown_in_vlr", 0 }, + { "cm_serv_rej:imei_not_accepted", 0 }, + { "cm_serv_rej:illegal_me", 0 }, + { "cm_serv_rej:plmn_not_allowed", 0 }, + { "cm_serv_rej:loc_not_allowed", 0 }, + { "cm_serv_rej:roaming_not_allowed", 0 }, + { "cm_serv_rej:network_failure", 0 }, + { "cm_serv_rej:synch_failure", 0 }, + { "cm_serv_rej:congestion", 0 }, + { "cm_serv_rej:srv_opt_not_supported", 0 }, + { "cm_serv_rej:rqd_srv_opt_not_supported", 0 }, + { "cm_serv_rej:srv_opt_tmp_out_of_order", 0 }, + { "cm_serv_rej:call_can_not_be_identified", 0 }, + { "cm_serv_rej:incorrect_message", 0 }, + { "cm_serv_rej:invalid_mandantory_inf", 0 }, + { "cm_serv_rej:msg_type_not_implemented", 0 }, + { "cm_serv_rej:msg_type_not_compatible", 0 }, + { "cm_serv_rej:inf_eleme_not_implemented", 0 }, + { "cm_serv_rej:condtional_ie_error", 0 }, + { "cm_serv_rej:msg_not_compatible", 0 }, + { "cm_serv_rej:protocol_error", 0 }, + { "cm_serv_rej:retry_in_new_cell", 0 } +}; + +private function f_TC_cm_serv_rej(charstring id) runs on MSC_ConnHdlr +{ + f_create_chan_and_exp(); + BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); + f_sleep(3.0); +} +testcase TC_cm_serv_rej() runs on test_CT { + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + var MSC_ConnHdlr vc_conn; + + f_init(1, true); + f_sleep(1.0); + + f_ctrs_bts_init(1, counternames_cm_serv_rej); + + vc_conn := f_start_handler(refers(f_TC_cm_serv_rej), pars); + vc_conn.done; + + f_ctrs_bts_add(0, "cm_serv_rej", 1); + f_ctrs_bts_add(0, "cm_serv_rej:imsi_unknown_in_hlr", 1); + f_ctrs_bts_verify(); + + f_shutdown_helper(); +} + /* Reproduce a segfault happening when the SDCCH (primary) lchan is lost in-between a TCH Channel Activ and its Channel * Activ Ack (SYS#5627). */ private function f_TC_lost_sdcch_during_assignment(charstring id) runs on MSC_ConnHdlr { @@ -10739,6 +10800,8 @@ execute( TC_ctrl_trx_rf_locked() ); + execute( TC_cm_serv_rej() ); + execute( TC_lost_sdcch_during_assignment() ); } diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 997b433..e6efb68 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -389,6 +389,23 @@ } } +template (value) PDU_ML3_NW_MS ts_CM_SERV_REJ(OCT1 rejectCause) := { + discriminator := '0000'B, /* overwritten */ + tiOrSkip := { + skipIndicator := '0000'B + }, + msgs := { + mm := { + cMServiceReject := { + messageType := '000000'B, /* overwritten */ + nsd := '00'B, + rejectCause := rejectCause, + t3246_Value := omit + } + } + } +} + template (value) PDU_ML3_MS_NW ts_CM_REESTABL_REQ(MobileIdentityLV mi_lv) := { discriminator := '0000'B, /* overwritten */ tiOrSkip := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a Gerrit-Change-Number: 26143 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 13:55:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 13:55:23 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26142 ) Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/26142/1/include/osmocom/bsc/bts.h File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/26142/1/include/osmocom/bsc/bts.h at 161 PS1, Line 161: BTS_CTR_CM_SERVICE_REJECT Why not 'BTS_CTR_CM_SERV_REJ'? https://gerrit.osmocom.org/c/osmo-bsc/+/26142/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26142/1/src/osmo-bsc/abis_rsl.c at 1025 PS1, Line 1025: struct msgb *msg const https://gerrit.osmocom.org/c/osmo-bsc/+/26142/1/src/osmo-bsc/abis_rsl.c at 1028 PS1, Line 1028: struct gsm48_hdr *gh const -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 07 Nov 2021 13:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 17:34:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 17:34:11 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: permit simultaneous ACCH repetition and overpower References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26144 ) Change subject: abis_rsl: permit simultaneous ACCH repetition and overpower ...................................................................... abis_rsl: permit simultaneous ACCH repetition and overpower As stated in "GSM/EDGE Evolution and Performance", section 12.3, both features *can* be enabled simultaneously. Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Related: SYS#5319 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 3 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/26144/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index cdd57c2..75c0bd7 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -555,30 +555,15 @@ /* indicate Temporary overpower of SACCH and FACCH channels */ static void top_acch_cap_for_bts(struct gsm_lchan *lchan, struct msgb *msg) { - struct abis_rsl_osmo_temp_ovp_acch_cap cap; struct gsm_bts *bts = lchan->ts->trx->bts; - bool acch_rep_enabled; - bool acch_rep_supp_by_ms; /* The BTS_FEAT_ACCH_TEMP_OVP IE is a proprietary IE, that can only be used with osmo-bts type BTSs */ if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS && osmo_bts_has_feature(&bts->features, BTS_FEAT_ACCH_TEMP_OVP))) return; - memcpy(&cap, &bts->temporary_overpower, sizeof(cap)); - - /* The user has enabled one of the two downlink related ACCH repetition features. */ - acch_rep_enabled = bts->repeated_acch_policy.dl_sacch || bts->repeated_acch_policy.dl_facch_all - || bts->repeated_acch_policy.dl_facch_cmd; - - /* The MS indicates support for ACCH repetition */ - acch_rep_supp_by_ms = lchan->conn && lchan->conn->cm3_valid && lchan->conn->cm3.repeated_acch_capability; - - /* If the MS fully supports repeated ACCH capabilites as specified in 3GPP TS 44.006, section 10 and 11. and if - * ACCH repetition is enabled for this BTS, then we will not apply temporary overpower. */ - if (acch_rep_enabled && acch_rep_supp_by_ms) - cap.overpower_db = 0; - - msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(cap), (uint8_t*) &cap); + msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, + sizeof(bts->temporary_overpower), + (void *)&bts->temporary_overpower); } /* Write RSL_IE_OSMO_TRAINING_SEQUENCE to msgb. The tsc_set argument's range is 1-4, tsc argument range is 0-7. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Gerrit-Change-Number: 26144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 19:35:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 19:35:37 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: reduce verbosity of the OML logging In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 to look at the new patch set (#2). Change subject: ipaccess-config: reduce verbosity of the OML logging ...................................................................... ipaccess-config: reduce verbosity of the OML logging Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/26138/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e Gerrit-Change-Number: 26138 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 19:35:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 19:35:38 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: do not pass lchan to print_meas_rep_buf() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26145 ) Change subject: abis_rsl: do not pass lchan to print_meas_rep_buf() ...................................................................... abis_rsl: do not pass lchan to print_meas_rep_buf() Change-Id: If965c7dc6b989ee758ddec0190ec1cce8363b240 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 11 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/26145/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index cdd57c2..f849d27 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1177,21 +1177,11 @@ prefix, mru->full.rx_qual, prefix, mru->sub.rx_qual); } -static int print_meas_rep_buf(char *buf, size_t len, struct gsm_lchan *lchan, struct gsm_meas_rep *mr) +static int print_meas_rep_buf(char *buf, size_t len, struct gsm_meas_rep *mr) { - const char *name = ""; - struct bsc_subscr *bsub = NULL; struct osmo_strbuf sb = { .buf = buf, .len = len }; - if (lchan && lchan->conn) { - bsub = lchan->conn->bsub; - if (bsub) { - name = bsc_subscr_name(bsub); - } else - name = lchan->name; - } - - OSMO_STRBUF_PRINTF(sb, "[%s] MEASUREMENT RESULT NR=%d ", name, mr->nr); + OSMO_STRBUF_PRINTF(sb, "MEASUREMENT RESULT NR=%d ", mr->nr); if (mr->flags & MEAS_REP_F_DL_DTX) OSMO_STRBUF_PRINTF(sb, "DTXd "); @@ -1222,25 +1212,30 @@ return sb.chars_needed; } -static char *print_meas_rep_c(void *ctx, struct gsm_lchan *lchan, struct gsm_meas_rep *mr) +static char *print_meas_rep_c(void *ctx, struct gsm_meas_rep *mr) { /* A naive count of required characters gets me to ~200, so 256 should be safe to get a large enough buffer on * the first time. */ - OSMO_NAME_C_IMPL(ctx, 256, "ERROR", print_meas_rep_buf, lchan, mr) + OSMO_NAME_C_IMPL(ctx, 256, "ERROR", print_meas_rep_buf, mr) } static void print_meas_rep(struct gsm_lchan *lchan, struct gsm_meas_rep *mr) { int i; + const char *name = ""; struct bsc_subscr *bsub = NULL; if (lchan && lchan->conn) { bsub = lchan->conn->bsub; - if (bsub) + if (bsub) { log_set_context(LOG_CTX_BSC_SUBSCR, bsub); + name = bsc_subscr_name(bsub); + } else { + name = lchan->name; + } } - DEBUGP(DMEAS, "%s\n", print_meas_rep_c(OTC_SELECT, lchan, mr)); + DEBUGP(DMEAS, "[%s] %s\n", name, print_meas_rep_c(OTC_SELECT, mr)); if (mr->num_cell != 7 && log_check_level(DMEAS, LOGL_DEBUG)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If965c7dc6b989ee758ddec0190ec1cce8363b240 Gerrit-Change-Number: 26145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 19:35:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 19:35:38 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: print_meas_rep_{buf, uni}() accept const *mr References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26146 ) Change subject: abis_rsl: print_meas_rep_{buf,uni}() accept const *mr ...................................................................... abis_rsl: print_meas_rep_{buf,uni}() accept const *mr Change-Id: I5c3e27a00cd84f102558499072965ec538f5a87f --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/46/26146/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index f849d27..0291224 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1168,7 +1168,9 @@ return 0; } -static void print_meas_rep_uni(struct osmo_strbuf *sb, struct gsm_meas_rep_unidir *mru, const char *prefix) +static void print_meas_rep_uni(struct osmo_strbuf *sb, + const struct gsm_meas_rep_unidir *mru, + const char *prefix) { OSMO_STRBUF_PRINTF(*sb, "RXL-FULL-%s=%3ddBm RXL-SUB-%s=%3ddBm ", prefix, rxlev2dbm(mru->full.rx_lev), @@ -1177,7 +1179,7 @@ prefix, mru->full.rx_qual, prefix, mru->sub.rx_qual); } -static int print_meas_rep_buf(char *buf, size_t len, struct gsm_meas_rep *mr) +static int print_meas_rep_buf(char *buf, size_t len, const struct gsm_meas_rep *mr) { struct osmo_strbuf sb = { .buf = buf, .len = len }; @@ -1212,14 +1214,14 @@ return sb.chars_needed; } -static char *print_meas_rep_c(void *ctx, struct gsm_meas_rep *mr) +static char *print_meas_rep_c(void *ctx, const struct gsm_meas_rep *mr) { /* A naive count of required characters gets me to ~200, so 256 should be safe to get a large enough buffer on * the first time. */ OSMO_NAME_C_IMPL(ctx, 256, "ERROR", print_meas_rep_buf, mr) } -static void print_meas_rep(struct gsm_lchan *lchan, struct gsm_meas_rep *mr) +static void print_meas_rep(struct gsm_lchan *lchan, const struct gsm_meas_rep *mr) { int i; const char *name = ""; @@ -1240,7 +1242,7 @@ if (mr->num_cell != 7 && log_check_level(DMEAS, LOGL_DEBUG)) { for (i = 0; i < mr->num_cell; i++) { - struct gsm_meas_rep_cell *mrc = &mr->cell[i]; + const struct gsm_meas_rep_cell *mrc = &mr->cell[i]; DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u => %d dBm\n", mrc->neigh_idx, mrc->arfcn, mrc->bsic, rxlev2dbm(mrc->rxlev)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c3e27a00cd84f102558499072965ec538f5a87f Gerrit-Change-Number: 26146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 19:35:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 19:35:38 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26147 ) Change subject: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] ...................................................................... ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] Change-Id: Idf8e3a9ee6d9a8801d53254c772548586d4a9c60 --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/26147/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 9f23b56..e3d0e48 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -501,7 +501,7 @@ { 0x0002, "static-gw" }, { 0x0004, "no-dhcp-vsi" }, { 0x0008, "dhcp-enabled" }, - { 0x0040, "led-disabled" }, + { 0x0040, "led-enabled" }, { 0x0100, "secondary-oml-enabled" }, { 0x0200, "diag-enabled" }, { 0x0400, "cli-enabled" }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf8e3a9ee6d9a8801d53254c772548586d4a9c60 Gerrit-Change-Number: 26147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 19:35:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 19:35:38 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: warn about unknown flag name References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26148 ) Change subject: ipaccess-config: warn about unknown flag name ...................................................................... ipaccess-config: warn about unknown flag name Change-Id: Iab3bae3af9e1cac992b1f8947cda25fcff647992 --- M src/ipaccess/ipaccess-config.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/48/26148/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index e3d0e48..2d72d0e 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -516,8 +516,10 @@ { int rc; rc = get_string_value(ipa_nvflag_strs, name); - if (rc < 0) + if (rc < 0) { + fprintf(stderr, "Unknown attribute '%s'\n", name); return rc; + } *mask |= rc; if (en) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab3bae3af9e1cac992b1f8947cda25fcff647992 Gerrit-Change-Number: 26148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 19:35:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 19:35:39 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... ipaccess-config: improve readability of printed attribute response Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 --- M src/ipaccess/ipaccess-config.c 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/26149/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 2d72d0e..b10959c 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -281,6 +281,7 @@ char oml_ip[20] = {0}; uint16_t oml_port = 0; char unit_id[40] = {0}; + unsigned int indent = 0; abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh)); @@ -290,8 +291,21 @@ abis_nm_tlv_attr_unit_id(&tp, unit_id, sizeof(unit_id)); - fprintf(stdout, "{ \"primary_oml_ip\": \"%s\", \"primary_oml_port\": %" PRIu16 ", \"unit_id\": \"%s\" }\n", - oml_ip, oml_port, unit_id); +#define print_offset(fmt, args...) \ + fprintf(stdout, "%*s" fmt, indent * 4, "", ## args) +#define print_field(field, fmt, args...) \ + print_offset("\"%s\": \"" fmt "\",\n", field, ## args) + + print_offset("{\n"); + indent++; + + print_field("primary_oml_ip", "%s", oml_ip); + print_field("primary_oml_port", "%u", oml_port); + print_field("unit_id", "%s", unit_id); + + indent--; + print_offset("}\n"); + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 7 19:35:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Nov 2021 19:35:39 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS Below is an example output: """ Received SIGNAL S_NM_GET_ATTR_REP { "primary_oml_ip": "192.168.100.100", "primary_oml_port": "0", "unit_id": "6969/0/0", "nv_flags": { "static-ip": "no", "static-gw": "no", "no-dhcp-vsi": "no", "dhcp-enabled": "yes", "led-enabled": "yes", "secondary-oml-enabled": "yes", "diag-enabled": "yes", "cli-enabled": "yes", "http-enabled": "no", "post-enabled": "yes", "snmp-enabled": "yes", } } """ Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 --- M src/ipaccess/ipaccess-config.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/26150/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index b10959c..493644b 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -268,6 +268,8 @@ return 0; } +static const struct value_string ipa_nvflag_strs[]; + static int print_attr_rep(struct msgb *mb) { /* Parse using nanoBTS own formatting for Get Attribute Response */ @@ -303,6 +305,26 @@ print_field("primary_oml_port", "%u", oml_port); print_field("unit_id", "%s", unit_id); + uint16_t Fx = (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[2] << 8) + | (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[0] << 0); + uint16_t Mx = (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[3] << 8) + | (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[1] << 0); + const struct value_string *nvflag = ipa_nvflag_strs; + + print_offset("\"nv_flags\": {\n"); + indent++; + + while (nvflag->value != 0x00 && nvflag->str != NULL) { + const char *val = (Fx & nvflag->value) ? "yes" : "no"; + if (~Mx & nvflag->value) + val = "unknown"; + print_field(nvflag->str, "%s", val); + nvflag++; + } + + indent--; + print_offset("}\n"); + indent--; print_offset("}\n"); @@ -557,6 +579,7 @@ if (get_attr) { msgb_put_u8(nmsg_get, NM_ATT_IPACC_PRIM_OML_CFG); msgb_put_u8(nmsg_get, NM_ATT_IPACC_UNIT_ID); + msgb_put_u8(nmsg_get, NM_ATT_IPACC_NV_FLAGS); } if (unit_id) { len = strlen(unit_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Nov 8 06:00:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:00:24 +0000 Subject: Build failure of network:osmocom:latest/open5gs in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188bd1820977_2ea32b0a73cf05f011897d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/open5gs/Debian_Testing/x86_64 Package network:osmocom:latest/open5gs failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest open5gs Last lines of build log: [ 91s] #include [ 91s] int main (int argc, char ** argv) { [ 91s] sctp_connectx(0, NULL, 0, NULL); [ 91s] } [ 91s] Compiler stdout: [ 91s] [ 91s] Compiler stderr: [ 91s] [ 91s] Checking if "sctp_connectx() accepts 4 arguments" : compiles: YES [ 91s] Configuring freeDiameter-host.h using configuration [ 91s] Configuring version.h using configuration [ 91s] WARNING: Target "../dict_dcca_3gpp" has a path separator in its name. [ 91s] This is not supported, it can cause unexpected failures and will become [ 91s] a hard error in the future. [ 91s] [ 91s] ../subprojects/freeDiameter/extensions/dict_dcca_3gpp/meson.build:1:0: ERROR: Target "../dict_dcca_3gpp" has a path segment pointing to directory "subprojects/freeDiameter/extensions/dict_dcca_3gpp/..". This is an error. [ 91s] To define a target that builds in that directory you must define it [ 91s] in the meson.build file in that directory. [ 91s] [ 91s] dh_auto_configure: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu --libexecdir=lib/x86_64-linux-gnu returned exit code 1 [ 91s] make: *** [debian/rules:11: binary] Error 25 [ 91s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 [ 91s] ### VM INTERACTION START ### [ 94s] [ 85.525905] sysrq: Power Off [ 94s] [ 85.530736] reboot: Power down [ 94s] ### VM INTERACTION END ### [ 94s] [ 94s] goat05 failed "build open5gs_2.3.6.dsc" at Mon Nov 8 06:00:13 UTC 2021. [ 94s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:12:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:12:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188bfde9da88_2ea32b0a73cf05f01191177@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 781s] # we create a symlink at ./srcfile.adoc pointing at [ 781s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 781s] # is like basename from coreutils, and . is WD. [ 781s] if ! [ -f test-usermanual.adoc ]; then \ [ 781s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 781s] fi [ 781s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 781s] # in ... [ 781s] TEXINPUTS=".." \ [ 781s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 781s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 781s] a2x: resource files: [] [ 781s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 781s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 781s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 781s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 781s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 781s] make[1]: *** [Makefile:363: all] Error 2 [ 781s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 781s] dh_auto_build: error: make -j1 returned exit code 2 [ 781s] make: *** [debian/rules:5: binary] Error 25 [ 781s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 781s] ### VM INTERACTION START ### [ 782s] Powering off. [ 782s] [ 738.156474] reboot: Power down [ 783s] ### VM INTERACTION END ### [ 783s] [ 783s] lamb55 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Mon Nov 8 06:12:09 UTC 2021. [ 783s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:19:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:19:33 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c184b0db1_2ea32b0a73cf05f0119197e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 400s] # is like basename from coreutils, and . is WD. [ 400s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 400s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 400s] fi [ 400s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 400s] # in /usr/share/osmo-gsm-manuals. [ 400s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 400s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 400s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 400s] a2x: resource files: [] [ 400s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 400s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 400s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 400s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 400s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 400s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 400s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 400s] make[1]: *** [Makefile:403: all] Error 2 [ 400s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 400s] dh_auto_build: error: make -j1 returned exit code 2 [ 400s] make: *** [debian/rules:12: build] Error 25 [ 400s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 400s] ### VM INTERACTION START ### [ 401s] Powering off. [ 401s] [ 381.468872] reboot: Power down [ 401s] ### VM INTERACTION END ### [ 401s] [ 401s] old-cirrus2 failed "build libosmo-sccp_1.4.0.dsc" at Mon Nov 8 06:19:21 UTC 2021. [ 401s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:23:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:23:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c25942aba_2ea32b0a73cf05f011940b6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 566s] # is like basename from coreutils, and . is WD. [ 566s] if ! [ -f osmomgw-usermanual.adoc ]; then \ [ 566s] ln -s osmomgw-usermanual.adoc osmomgw-usermanual.adoc; \ [ 566s] fi [ 566s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 566s] # in /usr/share/osmo-gsm-manuals. [ 566s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 566s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomgw-usermanual.adoc [ 567s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 567s] a2x: resource files: [] [ 567s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 567s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 567s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 567s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 567s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 567s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 567s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 567s] make[1]: *** [Makefile:423: all] Error 2 [ 567s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 567s] dh_auto_build: error: make -j1 returned exit code 2 [ 567s] make: *** [debian/rules:17: build] Error 25 [ 567s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 567s] ### VM INTERACTION START ### [ 568s] Powering off. [ 568s] [ 547.107004] reboot: Power down [ 568s] ### VM INTERACTION END ### [ 568s] [ 568s] lamb55 failed "build osmo-mgw_1.8.1.dsc" at Mon Nov 8 06:23:00 UTC 2021. [ 568s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:28:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:28:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c3a040540_2ea32b0a73cf05f011945b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 226s] # is like basename from coreutils, and . is WD. [ 226s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 226s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 226s] fi [ 226s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 226s] # in /usr/share/osmo-gsm-manuals. [ 226s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 226s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 226s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 226s] a2x: resource files: [] [ 226s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 226s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 226s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 226s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 226s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 226s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 226s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 226s] make[1]: *** [Makefile:392: all] Error 2 [ 226s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 226s] dh_auto_build: error: make -j1 returned exit code 2 [ 226s] make: *** [debian/rules:15: build] Error 25 [ 226s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 226s] ### VM INTERACTION START ### [ 227s] Powering off. [ 227s] [ 216.773584] reboot: Power down [ 228s] ### VM INTERACTION END ### [ 228s] [ 228s] goat13 failed "build osmo-ggsn_1.7.1.dsc" at Mon Nov 8 06:28:36 UTC 2021. [ 228s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:31:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:31:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c45424166_2ea32b0a73cf05f011950c4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 393s] # is like basename from coreutils, and . is WD. [ 393s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 393s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 393s] fi [ 393s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 393s] # in /usr/share/osmo-gsm-manuals. [ 393s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 393s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 393s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 393s] a2x: resource files: [] [ 393s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 393s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 393s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 393s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 393s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 393s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 393s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 393s] make[1]: *** [Makefile:391: all] Error 2 [ 393s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 393s] dh_auto_build: error: make -j1 returned exit code 2 [ 393s] make: *** [debian/rules:9: build] Error 25 [ 393s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 393s] ### VM INTERACTION START ### [ 394s] Powering off. [ 394s] [ 383.236102] reboot: Power down [ 394s] ### VM INTERACTION END ### [ 394s] [ 394s] goat03 failed "build osmo-iuh_1.0.0.dsc" at Mon Nov 8 06:31:24 UTC 2021. [ 394s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:37:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:37:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c5dc1ba65_2ea32b0a73cf05f01196063@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 400s] # is like basename from coreutils, and . is WD. [ 400s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 400s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 400s] fi [ 400s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 400s] # in /usr/share/osmo-gsm-manuals. [ 400s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 400s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 400s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 400s] a2x: resource files: [] [ 400s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 400s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 400s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 400s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 400s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 400s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 400s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 400s] make[1]: *** [Makefile:371: all] Error 2 [ 400s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 400s] dh_auto_build: error: make -j1 returned exit code 2 [ 400s] make: *** [debian/rules:12: build] Error 25 [ 400s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 400s] ### VM INTERACTION START ### [ 401s] Powering off. [ 401s] [ 382.880937] reboot: Power down [ 401s] ### VM INTERACTION END ### [ 401s] [ 401s] old-cirrus4 failed "build osmo-bts_1.3.3.dsc" at Mon Nov 8 06:37:35 UTC 2021. [ 401s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:40:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:40:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c651aba37_2ea32b0a73cf05f0119658e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 1114s] # is like basename from coreutils, and . is WD. [ 1114s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 1114s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 1114s] fi [ 1114s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1114s] # in /usr/share/osmo-gsm-manuals. [ 1114s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1114s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 1115s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 1115s] a2x: resource files: [] [ 1115s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1115s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 1115s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1115s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 1115s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1115s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 1115s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1115s] make[1]: *** [Makefile:410: all] Error 2 [ 1115s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1115s] dh_auto_build: error: make -j1 returned exit code 2 [ 1115s] make: *** [debian/rules:7: build] Error 25 [ 1115s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1115s] ### VM INTERACTION START ### [ 1116s] Powering off. [ 1116s] [ 1051.228664] reboot: Power down [ 1116s] ### VM INTERACTION END ### [ 1116s] [ 1116s] lamb61 failed "build osmo-hlr_1.3.1.dsc" at Mon Nov 8 06:40:02 UTC 2021. [ 1116s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:40:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:40:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188c671a119c_2ea32b0a73cf05f01196998@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 543s] # we create a symlink at ./srcfile.adoc pointing at [ 543s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc, [ 543s] # is like basename from coreutils, and . is WD. [ 543s] if ! [ -f test-usermanual.adoc ]; then \ [ 543s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 543s] fi [ 543s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 543s] # in ... [ 543s] TEXINPUTS=".." \ [ 543s] a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'" --dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" test-usermanual.adoc [ 543s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 543s] a2x: resource files: [] [ 543s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 543s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 543s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 543s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 543s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 543s] make[1]: *** [Makefile:363: all] Error 2 [ 543s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 543s] dh_auto_build: error: make -j1 returned exit code 2 [ 543s] make: *** [debian/rules:5: binary] Error 25 [ 543s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 543s] ### VM INTERACTION START ### [ 544s] Powering off. [ 544s] [ 520.123353] reboot: Power down [ 544s] ### VM INTERACTION END ### [ 544s] [ 544s] lamb06 failed "build osmo-gsm-manuals-dev_1.1.0.dsc" at Mon Nov 8 06:40:13 UTC 2021. [ 544s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:42:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:42:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c6e68fed5_2ea32b0a73cf05f01197377@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 504s] # is like basename from coreutils, and . is WD. [ 504s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 504s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 504s] fi [ 504s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 504s] # in /usr/share/osmo-gsm-manuals. [ 504s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 504s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 504s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 504s] a2x: resource files: [] [ 504s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 504s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 504s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 504s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 504s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 504s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 504s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 504s] make[1]: *** [Makefile:368: all] Error 2 [ 504s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 504s] dh_auto_build: error: make -j1 returned exit code 2 [ 504s] make: *** [debian/rules:45: build] Error 25 [ 504s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 504s] ### VM INTERACTION START ### [ 506s] Powering off. [ 506s] [ 443.191553] reboot: Power down [ 506s] ### VM INTERACTION END ### [ 506s] [ 506s] cloud103 failed "build osmo-cbc_0.2.2.dsc" at Mon Nov 8 06:42:31 UTC 2021. [ 506s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:47:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:47:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c8131b9b2_2ea32b0a73cf05f011988e1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 330s] # is like basename from coreutils, and . is WD. [ 330s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 330s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 330s] fi [ 330s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 330s] # in /usr/share/osmo-gsm-manuals. [ 330s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 330s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 330s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 330s] a2x: resource files: [] [ 330s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 330s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 330s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 330s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 330s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 330s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 330s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 330s] make[1]: *** [Makefile:377: all] Error 2 [ 330s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 330s] dh_auto_build: error: make -j1 returned exit code 2 [ 330s] make: *** [debian/rules:45: build] Error 25 [ 330s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 330s] ### VM INTERACTION START ### [ 331s] Powering off. [ 331s] [ 298.693719] reboot: Power down [ 331s] ### VM INTERACTION END ### [ 331s] [ 331s] goat17 failed "build osmo-gbproxy_0.1.2.dsc" at Mon Nov 8 06:47:22 UTC 2021. [ 331s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:48:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:48:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c852d91fe_2ea32b0a73cf05f0119923f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 284s] # we create a symlink at ./srcfile.adoc pointing at [ 284s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 284s] # is like basename from coreutils, and . is WD. [ 284s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 284s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 284s] fi [ 284s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 284s] # in /usr/share/osmo-gsm-manuals. [ 284s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 284s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 285s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 285s] a2x: resource files: [] [ 285s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 285s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 285s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 285s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 285s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 285s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 285s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 285s] dh_auto_build: error: make -j1 returned exit code 2 [ 285s] make: *** [debian/rules:12: build] Error 25 [ 285s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 285s] ### VM INTERACTION START ### [ 286s] Powering off. [ 286s] [ 274.640748] reboot: Power down [ 286s] ### VM INTERACTION END ### [ 286s] [ 286s] goat19 failed "build osmo-pcu_0.9.1.dsc" at Mon Nov 8 06:48:17 UTC 2021. [ 286s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:48:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:48:41 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188c853cb15d_2ea32b0a73cf05f011993ac@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 445s] # is like basename from coreutils, and . is WD. [ 445s] if ! [ -f osmostp-usermanual.adoc ]; then \ [ 445s] ln -s osmostp-usermanual.adoc osmostp-usermanual.adoc; \ [ 445s] fi [ 445s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 445s] # in /usr/share/osmo-gsm-manuals. [ 445s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 445s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmostp-usermanual.adoc [ 445s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 445s] a2x: resource files: [] [ 445s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 445s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 445s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 445s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 445s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 445s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 445s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 445s] make[1]: *** [Makefile:403: all] Error 2 [ 445s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 445s] dh_auto_build: error: make -j1 returned exit code 2 [ 445s] make: *** [debian/rules:12: build] Error 25 [ 445s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 445s] ### VM INTERACTION START ### [ 446s] Powering off. [ 446s] [ 426.294306] reboot: Power down [ 446s] ### VM INTERACTION END ### [ 446s] [ 446s] old-cirrus4 failed "build libosmo-sccp_1.4.0.dsc" at Mon Nov 8 06:48:26 UTC 2021. [ 446s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:52:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:52:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188c94298e7c_2ea32b0a73cf05f01200328@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 273s] # is like basename from coreutils, and . is WD. [ 273s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 273s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 273s] fi [ 273s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 273s] # in /usr/share/osmo-gsm-manuals. [ 273s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 273s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 273s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 273s] a2x: resource files: [] [ 273s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 273s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 273s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 273s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 273s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 273s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 273s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 273s] make[1]: *** [Makefile:327: all] Error 2 [ 273s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 273s] dh_auto_build: error: make -j1 returned exit code 2 [ 273s] make: *** [debian/rules:12: build] Error 25 [ 273s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 273s] ### VM INTERACTION START ### [ 274s] Powering off. [ 274s] [ 261.784815] reboot: Power down [ 275s] ### VM INTERACTION END ### [ 275s] [ 275s] goat09 failed "build osmo-sip-connector_1.5.1.dsc" at Mon Nov 8 06:52:27 UTC 2021. [ 275s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:53:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:53:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188c99b60fda_2ea32b0a73cf05f012008cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 297s] # is like basename from coreutils, and . is WD. [ 297s] if ! [ -f osmoggsn-usermanual.adoc ]; then \ [ 297s] ln -s osmoggsn-usermanual.adoc osmoggsn-usermanual.adoc; \ [ 297s] fi [ 297s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 297s] # in /usr/share/osmo-gsm-manuals. [ 297s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 297s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmoggsn-usermanual.adoc [ 297s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 297s] a2x: resource files: [] [ 297s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 297s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 297s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 297s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 297s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 297s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 297s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 297s] make[1]: *** [Makefile:392: all] Error 2 [ 297s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 297s] dh_auto_build: error: make -j1 returned exit code 2 [ 297s] make: *** [debian/rules:15: build] Error 25 [ 297s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 297s] ### VM INTERACTION START ### [ 298s] Powering off. [ 298s] [ 282.174531] reboot: Power down [ 298s] ### VM INTERACTION END ### [ 298s] [ 298s] sheep88 failed "build osmo-ggsn_1.7.1.dsc" at Mon Nov 8 06:53:39 UTC 2021. [ 298s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:58:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:58:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188caa96bf0a_2ea32b0a73cf05f012025b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 996s] # is like basename from coreutils, and . is WD. [ 996s] if ! [ -f osmomgw-usermanual.adoc ]; then \ [ 996s] ln -s osmomgw-usermanual.adoc osmomgw-usermanual.adoc; \ [ 996s] fi [ 996s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 996s] # in /usr/share/osmo-gsm-manuals. [ 996s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 996s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomgw-usermanual.adoc [ 996s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 996s] a2x: resource files: [] [ 996s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 996s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 996s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 996s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 996s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 996s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 996s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 996s] make[1]: *** [Makefile:423: all] Error 2 [ 996s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 996s] dh_auto_build: error: make -j1 returned exit code 2 [ 997s] make: *** [debian/rules:17: build] Error 25 [ 997s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 997s] ### VM INTERACTION START ### [ 998s] Powering off. [ 998s] [ 904.988540] reboot: Power down [ 998s] ### VM INTERACTION END ### [ 998s] [ 998s] lamb02 failed "build osmo-mgw_1.8.1.dsc" at Mon Nov 8 06:58:25 UTC 2021. [ 998s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 06:59:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 06:59:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188caca240e_2ea32b0a73cf05f01202839@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 918s] # is like basename from coreutils, and . is WD. [ 918s] if ! [ -f osmohlr-usermanual.adoc ]; then \ [ 918s] ln -s osmohlr-usermanual.adoc osmohlr-usermanual.adoc; \ [ 918s] fi [ 918s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 918s] # in /usr/share/osmo-gsm-manuals. [ 918s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 918s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohlr-usermanual.adoc [ 918s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 918s] a2x: resource files: [] [ 918s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 918s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 918s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 919s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 919s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 919s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 919s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 919s] make[1]: *** [Makefile:410: all] Error 2 [ 919s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 919s] dh_auto_build: error: make -j1 returned exit code 2 [ 919s] make: *** [debian/rules:7: build] Error 25 [ 919s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 919s] ### VM INTERACTION START ### [ 920s] Powering off. [ 920s] [ 827.954313] reboot: Power down [ 920s] ### VM INTERACTION END ### [ 920s] [ 920s] lamb57 failed "build osmo-hlr_1.3.1.dsc" at Mon Nov 8 06:59:09 UTC 2021. [ 920s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:00:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:00:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188cb2355caf_2ea32b0a73cf05f0120329a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 388s] # is like basename from coreutils, and . is WD. [ 388s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 388s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 388s] fi [ 388s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 388s] # in /usr/share/osmo-gsm-manuals. [ 388s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 388s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 388s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 388s] a2x: resource files: [] [ 388s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 388s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 388s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 388s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 388s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 388s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 388s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 388s] make[1]: *** [Makefile:377: all] Error 2 [ 388s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 388s] dh_auto_build: error: make -j1 returned exit code 2 [ 388s] make: *** [debian/rules:45: build] Error 25 [ 388s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 388s] ### VM INTERACTION START ### [ 389s] Powering off. [ 389s] [ 370.245799] reboot: Power down [ 389s] ### VM INTERACTION END ### [ 389s] [ 389s] old-cirrus4 failed "build osmo-smlc_0.2.0.dsc" at Mon Nov 8 07:00:17 UTC 2021. [ 389s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:04:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:04:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188cc0e2341a_2ea32b0a73cf05f012042bb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 862s] # is like basename from coreutils, and . is WD. [ 862s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 862s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 862s] fi [ 862s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 862s] # in /usr/share/osmo-gsm-manuals. [ 862s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 862s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 862s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 862s] a2x: resource files: [] [ 862s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 862s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 862s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 862s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 862s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 862s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 862s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 862s] make[1]: *** [Makefile:387: all] Error 2 [ 862s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 862s] dh_auto_build: error: make -j1 returned exit code 2 [ 862s] make: *** [debian/rules:12: build] Error 25 [ 862s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 862s] ### VM INTERACTION START ### [ 863s] Powering off. [ 863s] [ 697.743744] reboot: Power down [ 864s] ### VM INTERACTION END ### [ 864s] [ 864s] cloud103 failed "build osmo-remsim_0.2.4.dsc" at Mon Nov 8 07:04:19 UTC 2021. [ 864s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:08:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:08:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188cd014e8f9_2ea32b0a73cf05f0120507@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 352s] # is like basename from coreutils, and . is WD. [ 352s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 352s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 352s] fi [ 352s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 352s] # in /usr/share/osmo-gsm-manuals. [ 352s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 352s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 352s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 352s] a2x: resource files: [] [ 352s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 352s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 352s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 352s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 352s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 352s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 352s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 352s] make[1]: *** [Makefile:388: all] Error 2 [ 352s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 352s] dh_auto_build: error: make -j1 returned exit code 2 [ 352s] make: *** [debian/rules:45: build] Error 25 [ 352s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 352s] ### VM INTERACTION START ### [ 353s] Powering off. [ 353s] [ 336.746707] reboot: Power down [ 353s] ### VM INTERACTION END ### [ 353s] [ 353s] sheep86 failed "build osmo-bsc_1.7.2.dsc" at Mon Nov 8 07:08:13 UTC 2021. [ 353s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:12:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:12:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188cdf053ae8_2ea32b0a73cf05f0120592c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 1365s] # is like basename from coreutils, and . is WD. [ 1365s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 1365s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 1365s] fi [ 1365s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1365s] # in /usr/share/osmo-gsm-manuals. [ 1365s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1365s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 1365s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 1365s] a2x: resource files: [] [ 1365s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1365s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 1365s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1365s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 1365s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1365s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 1365s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1365s] make[1]: *** [Makefile:452: all] Error 2 [ 1365s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1365s] dh_auto_build: error: make -j1 returned exit code 2 [ 1365s] make: *** [debian/rules:6: build] Error 25 [ 1365s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1365s] ### VM INTERACTION START ### [ 1366s] Powering off. [ 1366s] [ 1298.766422] reboot: Power down [ 1366s] ### VM INTERACTION END ### [ 1366s] [ 1366s] lamb52 failed "build osmo-trx_1.3.1.dsc" at Mon Nov 8 07:12:20 UTC 2021. [ 1366s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:13:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:13:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188ce117afa5_2ea32b0a73cf05f012064cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 1029s] # is like basename from coreutils, and . is WD. [ 1029s] if ! [ -f osmohnbgw-usermanual.adoc ]; then \ [ 1029s] ln -s osmohnbgw-usermanual.adoc osmohnbgw-usermanual.adoc; \ [ 1029s] fi [ 1029s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1029s] # in /usr/share/osmo-gsm-manuals. [ 1029s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1029s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmohnbgw-usermanual.adoc [ 1029s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 1029s] a2x: resource files: [] [ 1029s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1029s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 1029s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1029s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 1029s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1029s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 1029s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1029s] make[1]: *** [Makefile:391: all] Error 2 [ 1029s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1029s] dh_auto_build: error: make -j1 returned exit code 2 [ 1029s] make: *** [debian/rules:9: build] Error 25 [ 1029s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1029s] ### VM INTERACTION START ### [ 1030s] Powering off. [ 1030s] [ 997.636588] reboot: Power down [ 1030s] ### VM INTERACTION END ### [ 1030s] [ 1030s] lamb14 failed "build osmo-iuh_1.0.0.dsc" at Mon Nov 8 07:12:58 UTC 2021. [ 1030s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:13:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:13:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188ce4c3c01c_2ea32b0a73cf05f012072f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 441s] # is like basename from coreutils, and . is WD. [ 441s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 441s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 441s] fi [ 441s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 441s] # in /usr/share/osmo-gsm-manuals. [ 441s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 441s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 441s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 441s] a2x: resource files: [] [ 441s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 441s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 441s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 441s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 441s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 441s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 441s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 441s] make[1]: *** [Makefile:394: all] Error 2 [ 441s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 441s] dh_auto_build: error: make -j1 returned exit code 2 [ 441s] make: *** [debian/rules:45: build] Error 25 [ 441s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 441s] ### VM INTERACTION START ### [ 442s] Powering off. [ 442s] [ 425.103490] reboot: Power down [ 442s] ### VM INTERACTION END ### [ 442s] [ 442s] lamb19 failed "build osmo-sgsn_1.7.1.dsc" at Mon Nov 8 07:13:39 UTC 2021. [ 442s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:16:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:16:58 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188cefea6abe_2ea32b0a73cf05f0120874d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 742s] # is like basename from coreutils, and . is WD. [ 742s] if ! [ -f osmogbproxy-usermanual.adoc ]; then \ [ 742s] ln -s osmogbproxy-usermanual.adoc osmogbproxy-usermanual.adoc; \ [ 742s] fi [ 742s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 742s] # in /usr/share/osmo-gsm-manuals. [ 742s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 742s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmogbproxy-usermanual.adoc [ 742s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 742s] a2x: resource files: [] [ 742s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 742s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 742s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 742s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 742s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 742s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 742s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 742s] make[1]: *** [Makefile:377: all] Error 2 [ 742s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 742s] dh_auto_build: error: make -j1 returned exit code 2 [ 742s] make: *** [debian/rules:45: build] Error 25 [ 742s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 742s] ### VM INTERACTION START ### [ 743s] Powering off. [ 743s] [ 666.863194] reboot: Power down [ 743s] ### VM INTERACTION END ### [ 743s] [ 743s] old-atreju5 failed "build osmo-gbproxy_0.1.2.dsc" at Mon Nov 8 07:16:43 UTC 2021. [ 743s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:18:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:18:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6188cf392a361_2ea32b0a73cf05f01209169@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 462s] # is like basename from coreutils, and . is WD. [ 462s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 462s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 462s] fi [ 462s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 462s] # in /usr/share/osmo-gsm-manuals. [ 462s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 462s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 462s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 462s] a2x: resource files: [] [ 462s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 462s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 462s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 462s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 462s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 462s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 462s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 462s] make[1]: *** [Makefile:402: all] Error 2 [ 462s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 462s] dh_auto_build: error: make -j1 returned exit code 2 [ 462s] make: *** [debian/rules:45: build] Error 25 [ 462s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 462s] ### VM INTERACTION START ### [ 463s] Powering off. [ 463s] [ 442.707152] reboot: Power down [ 463s] ### VM INTERACTION END ### [ 463s] [ 463s] old-cirrus4 failed "build osmo-msc_1.7.1.dsc" at Mon Nov 8 07:17:51 UTC 2021. [ 463s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:18:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:18:58 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188cf78a152_2ea32b0a73cf05f01209444@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 1005s] # is like basename from coreutils, and . is WD. [ 1005s] if ! [ -f osmobts-usermanual.adoc ]; then \ [ 1005s] ln -s osmobts-usermanual.adoc osmobts-usermanual.adoc; \ [ 1005s] fi [ 1005s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 1005s] # in /usr/share/osmo-gsm-manuals. [ 1005s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 1005s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobts-usermanual.adoc [ 1005s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobts-usermanual.adoc'] [ 1005s] a2x: resource files: [] [ 1005s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 1005s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobts-usermanual.pdf] Error 1 [ 1005s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1005s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 1005s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1005s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 1005s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1005s] make[1]: *** [Makefile:371: all] Error 2 [ 1005s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1005s] dh_auto_build: error: make -j1 returned exit code 2 [ 1005s] make: *** [debian/rules:12: build] Error 25 [ 1005s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1005s] ### VM INTERACTION START ### [ 1007s] Powering off. [ 1007s] [ 915.335097] reboot: Power down [ 1007s] ### VM INTERACTION END ### [ 1007s] [ 1007s] lamb56 failed "build osmo-bts_1.3.3.dsc" at Mon Nov 8 07:18:56 UTC 2021. [ 1007s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:22:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:22:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d04899615_2ea32b0a73cf05f01210798@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 248s] # is like basename from coreutils, and . is WD. [ 248s] if ! [ -f osmo-remsim-usermanual.adoc ]; then \ [ 248s] ln -s osmo-remsim-usermanual.adoc osmo-remsim-usermanual.adoc; \ [ 248s] fi [ 248s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 248s] # in /usr/share/osmo-gsm-manuals. [ 248s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 248s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmo-remsim-usermanual.adoc [ 248s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 248s] a2x: resource files: [] [ 248s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 248s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 248s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 248s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 248s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 248s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 248s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 248s] make[1]: *** [Makefile:387: all] Error 2 [ 248s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 248s] dh_auto_build: error: make -j1 returned exit code 2 [ 248s] make: *** [debian/rules:12: build] Error 25 [ 248s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 248s] ### VM INTERACTION START ### [ 249s] Powering off. [ 249s] [ 237.984209] reboot: Power down [ 249s] ### VM INTERACTION END ### [ 249s] [ 249s] goat03 failed "build osmo-remsim_0.2.4.dsc" at Mon Nov 8 07:22:12 UTC 2021. [ 249s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:27:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:27:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d159e43f0_2ea32b0a73cf05f012128d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 396s] # is like basename from coreutils, and . is WD. [ 396s] if ! [ -f osmotrx-usermanual.adoc ]; then \ [ 396s] ln -s osmotrx-usermanual.adoc osmotrx-usermanual.adoc; \ [ 396s] fi [ 396s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 396s] # in /usr/share/osmo-gsm-manuals. [ 396s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 396s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmotrx-usermanual.adoc [ 397s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 397s] a2x: resource files: [] [ 397s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 397s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 397s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 397s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 397s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 397s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 397s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 397s] make[1]: *** [Makefile:452: all] Error 2 [ 397s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 397s] dh_auto_build: error: make -j1 returned exit code 2 [ 397s] make: *** [debian/rules:6: build] Error 25 [ 397s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 397s] ### VM INTERACTION START ### [ 398s] Powering off. [ 398s] [ 379.787253] reboot: Power down [ 398s] ### VM INTERACTION END ### [ 398s] [ 398s] sheep88 failed "build osmo-trx_1.3.1.dsc" at Mon Nov 8 07:27:11 UTC 2021. [ 398s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:30:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:30:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d20d6fc9b_2ea32b0a73cf05f0121369d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 820s] # is like basename from coreutils, and . is WD. [ 820s] if ! [ -f osmocbc-usermanual.adoc ]; then \ [ 820s] ln -s osmocbc-usermanual.adoc osmocbc-usermanual.adoc; \ [ 820s] fi [ 820s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 820s] # in /usr/share/osmo-gsm-manuals. [ 820s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 820s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmocbc-usermanual.adoc [ 820s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 820s] a2x: resource files: [] [ 820s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 820s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 820s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 820s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 820s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 820s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 820s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 820s] make[1]: *** [Makefile:368: all] Error 2 [ 820s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 820s] dh_auto_build: error: make -j1 returned exit code 2 [ 820s] make: *** [debian/rules:45: build] Error 25 [ 820s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 820s] ### VM INTERACTION START ### [ 821s] Powering off. [ 821s] [ 776.154954] reboot: Power down [ 822s] ### VM INTERACTION END ### [ 822s] [ 822s] lamb61 failed "build osmo-cbc_0.2.2.dsc" at Mon Nov 8 07:30:04 UTC 2021. [ 822s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:30:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:30:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d20ed3a51_2ea32b0a73cf05f012140c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 334s] # we create a symlink at ./srcfile.adoc pointing at [ 334s] # ./srcfile.adoc. osmopcu-usermanual.adoc is the ./srcfile.adoc, [ 334s] # is like basename from coreutils, and . is WD. [ 334s] if ! [ -f osmopcu-usermanual.adoc ]; then \ [ 334s] ln -s osmopcu-usermanual.adoc osmopcu-usermanual.adoc; \ [ 334s] fi [ 334s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 334s] # in /usr/share/osmo-gsm-manuals. [ 334s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 334s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmopcu-usermanual.adoc [ 334s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 334s] a2x: resource files: [] [ 334s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 334s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 334s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 334s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 334s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 334s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 334s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 334s] dh_auto_build: error: make -j1 returned exit code 2 [ 334s] make: *** [debian/rules:12: build] Error 25 [ 334s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 334s] ### VM INTERACTION START ### [ 335s] Powering off. [ 335s] [ 318.946547] reboot: Power down [ 335s] ### VM INTERACTION END ### [ 335s] [ 335s] sheep86 failed "build osmo-pcu_0.9.1.dsc" at Mon Nov 8 07:30:02 UTC 2021. [ 335s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:31:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:31:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d2625d567_2ea32b0a73cf05f012141cf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 509s] # is like basename from coreutils, and . is WD. [ 509s] if ! [ -f osmosipconnector-usermanual.adoc ]; then \ [ 509s] ln -s osmosipconnector-usermanual.adoc osmosipconnector-usermanual.adoc; \ [ 509s] fi [ 509s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 509s] # in /usr/share/osmo-gsm-manuals. [ 509s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 510s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosipconnector-usermanual.adoc [ 510s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 510s] a2x: resource files: [] [ 510s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 510s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 510s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 510s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 510s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 510s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 510s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 510s] make[1]: *** [Makefile:327: all] Error 2 [ 510s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 510s] dh_auto_build: error: make -j1 returned exit code 2 [ 510s] make: *** [debian/rules:12: build] Error 25 [ 510s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 510s] ### VM INTERACTION START ### [ 511s] Powering off. [ 511s] [ 441.446977] reboot: Power down [ 511s] ### VM INTERACTION END ### [ 511s] [ 511s] cloud121 failed "build osmo-sip-connector_1.5.1.dsc" at Mon Nov 8 07:31:20 UTC 2021. [ 511s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:35:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:35:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d370a3db7_2ea32b0a73cf05f012158a9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 289s] # is like basename from coreutils, and . is WD. [ 289s] if ! [ -f osmobsc-usermanual.adoc ]; then \ [ 289s] ln -s osmobsc-usermanual.adoc osmobsc-usermanual.adoc; \ [ 289s] fi [ 289s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 289s] # in /usr/share/osmo-gsm-manuals. [ 289s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 289s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmobsc-usermanual.adoc [ 289s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 289s] a2x: resource files: [] [ 289s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 289s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 289s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 289s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 289s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 289s] make[2]: *** [Makefile:456: all-recursive] Error 1 [ 289s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 289s] make[1]: *** [Makefile:388: all] Error 2 [ 289s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 289s] dh_auto_build: error: make -j1 returned exit code 2 [ 289s] make: *** [debian/rules:45: build] Error 25 [ 289s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 289s] ### VM INTERACTION START ### [ 290s] Powering off. [ 290s] [ 274.130995] reboot: Power down [ 290s] ### VM INTERACTION END ### [ 290s] [ 290s] goat11 failed "build osmo-bsc_1.7.2.dsc" at Mon Nov 8 07:35:38 UTC 2021. [ 290s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:37:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:37:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d3cbd1a4f_2ea32b0a73cf05f0121630@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 428s] # is like basename from coreutils, and . is WD. [ 428s] if ! [ -f osmosmlc-usermanual.adoc ]; then \ [ 428s] ln -s osmosmlc-usermanual.adoc osmosmlc-usermanual.adoc; \ [ 428s] fi [ 428s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 428s] # in /usr/share/osmo-gsm-manuals. [ 428s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 428s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosmlc-usermanual.adoc [ 428s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 428s] a2x: resource files: [] [ 428s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 428s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 428s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 428s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 428s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 428s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 428s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 428s] make[1]: *** [Makefile:377: all] Error 2 [ 428s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 428s] dh_auto_build: error: make -j1 returned exit code 2 [ 428s] make: *** [debian/rules:45: build] Error 25 [ 428s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 428s] ### VM INTERACTION START ### [ 429s] Powering off. [ 429s] [ 409.411501] reboot: Power down [ 430s] ### VM INTERACTION END ### [ 430s] [ 430s] lamb16 failed "build osmo-smlc_0.2.0.dsc" at Mon Nov 8 07:37:27 UTC 2021. [ 430s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:40:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:40:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d4655dc84_2ea32b0a73cf05f0121703c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 469s] # is like basename from coreutils, and . is WD. [ 469s] if ! [ -f osmomsc-usermanual.adoc ]; then \ [ 469s] ln -s osmomsc-usermanual.adoc osmomsc-usermanual.adoc; \ [ 469s] fi [ 469s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 469s] # in /usr/share/osmo-gsm-manuals. [ 469s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 469s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmomsc-usermanual.adoc [ 469s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 469s] a2x: resource files: [] [ 469s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 469s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 469s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 469s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 469s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 469s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 469s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 469s] make[1]: *** [Makefile:402: all] Error 2 [ 469s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 469s] dh_auto_build: error: make -j1 returned exit code 2 [ 469s] make: *** [debian/rules:45: build] Error 25 [ 469s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 469s] ### VM INTERACTION START ### [ 470s] Powering off. [ 470s] [ 451.564422] reboot: Power down [ 471s] ### VM INTERACTION END ### [ 471s] [ 471s] lamb14 failed "build osmo-msc_1.7.1.dsc" at Mon Nov 8 07:39:59 UTC 2021. [ 471s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 07:40:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 07:40:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6188d465b0a4f_2ea32b0a73cf05f012171dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 410s] # is like basename from coreutils, and . is WD. [ 410s] if ! [ -f osmosgsn-usermanual.adoc ]; then \ [ 410s] ln -s osmosgsn-usermanual.adoc osmosgsn-usermanual.adoc; \ [ 410s] fi [ 410s] # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} [ 410s] # in /usr/share/osmo-gsm-manuals. [ 410s] TEXINPUTS="/usr/share/osmo-gsm-manuals" \ [ 410s] a2x -vv -L --asciidoc-opts="-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'" --dblatex-opts="-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown" osmosgsn-usermanual.adoc [ 410s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 410s] a2x: resource files: [] [ 410s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 410s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 410s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 410s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 410s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 410s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 410s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 410s] make[1]: *** [Makefile:394: all] Error 2 [ 410s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 410s] dh_auto_build: error: make -j1 returned exit code 2 [ 410s] make: *** [debian/rules:45: build] Error 25 [ 410s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 410s] ### VM INTERACTION START ### [ 412s] Powering off. [ 412s] [ 392.162247] reboot: Power down [ 412s] ### VM INTERACTION END ### [ 412s] [ 412s] lamb15 failed "build osmo-sgsn_1.7.1.dsc" at Mon Nov 8 07:40:02 UTC 2021. [ 412s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Nov 8 11:05:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 11:05:02 +0000 Subject: Change in osmo-pcu[master]: tbf: Increase log level of line about unable to allocate poll for TBF References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26151 ) Change subject: tbf: Increase log level of line about unable to allocate poll for TBF ...................................................................... tbf: Increase log level of line about unable to allocate poll for TBF Change-Id: I0bd972d3b68017f12a0816a27162e3a409b1893a --- M src/tbf.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/26151/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 07732dc..2d6139b 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -524,7 +524,7 @@ } if ((rc = pdch_ulc_get_next_free_rrbp_fn(trx->pdch[ts].ulc, fn, poll_fn_, rrbp_)) < 0) { - LOGPTBF(this, LOGL_DEBUG, + LOGPTBF(this, LOGL_NOTICE, "(bts=%u,trx=%u,ts=%u) FN=%u No suitable free RRBP offset found!\n", trx->bts->nr, trx->trx_no, ts, fn); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0bd972d3b68017f12a0816a27162e3a409b1893a Gerrit-Change-Number: 26151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 11:24:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 11:24:16 +0000 Subject: Change in osmo-pcu[master]: pdch: Improve log line and increase log level References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26152 ) Change subject: pdch: Improve log line and increase log level ...................................................................... pdch: Improve log line and increase log level Change-Id: Ie593331a69f6b8ec3b21e2b274a1aa060b2dc439 --- M src/pdch.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/52/26152/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 5d8658a..ddad020 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -126,7 +126,7 @@ LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we provide one:\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS, NULL); } else { - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we packet access reject:\n"); + LOGP(DRLCMAC, LOGL_NOTICE, "MS requests UL TBF in ack message, but alloc failed: send PktAssRej\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS_REJ, NULL); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie593331a69f6b8ec3b21e2b274a1aa060b2dc439 Gerrit-Change-Number: 26152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:01:33 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 8 Nov 2021 12:01:33 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_ctrl: make sure strtok results are checked In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26127 ) Change subject: osmo_bsc_ctrl: make sure strtok results are checked ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Gerrit-Change-Number: 26127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:01:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:22:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:22:45 +0000 Subject: Change in osmo-pcu[master]: vty: Log tbf_state when showing a TBF In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26131 ) Change subject: vty: Log tbf_state when showing a TBF ...................................................................... vty: Log tbf_state when showing a TBF That's one of the most important information bits about a TBF when debugging, and it's not shown currently, only when "show ms" is used. Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945 --- M src/pcu_vty_functions.cpp 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index 21851df..fb7897d 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -54,8 +54,9 @@ tbf->ta(), tbf->direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", tbf->imsi(), VTY_NEWLINE); - vty_out(vty, " created=%lu state=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s", - tbf->created_ts(), tbf->state_fsm.state_flags, + vty_out(vty, " created=%lu state=%s flags=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s", + tbf->created_ts(), tbf->state_name(), + tbf->state_fsm.state_flags, tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH), tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH), tbf->first_ts, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945 Gerrit-Change-Number: 26131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:22:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:22:46 +0000 Subject: Change in osmo-pcu[master]: vty: show tbf: Drop unneeded check for non-null ms In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26132 ) Change subject: vty: show tbf: Drop unneeded check for non-null ms ...................................................................... vty: show tbf: Drop unneeded check for non-null ms Since a while a go, a TBF is guaranteed to always have a MS assigned. Hence, there's no point in checking it. Change-Id: I89e062432ac671c73731ce68c889aeb5e24277f5 --- M src/pcu_vty_functions.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index fb7897d..c2cc950 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -62,7 +62,7 @@ tbf->first_ts, tbf->first_common_ts, tbf->control_ts, tbf->ms_class(), - tbf->ms() ? ms_egprs_ms_class(tbf->ms()) : -1, + ms_egprs_ms_class(tbf->ms()), VTY_NEWLINE); vty_out(vty, " TS_alloc="); for (int i = 0; i < 8; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I89e062432ac671c73731ce68c889aeb5e24277f5 Gerrit-Change-Number: 26132 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:23:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:23:31 +0000 Subject: Change in osmo-pcu[master]: bts: Introduce new RACH req counters for one/two phase access In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26074 ) Change subject: bts: Introduce new RACH req counters for one/two phase access ...................................................................... bts: Introduce new RACH req counters for one/two phase access These new counters allow the user to find out which kind of access are MS requesting. Related: SYS#4878 Change-Id: Id87c3a53d3acee92499987c843130e358f54742c --- M src/bts.cpp M src/bts.h M tests/tbf/TbfTest.err 3 files changed, 23 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 4ce036b..7974f41 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -137,6 +137,8 @@ { "pch:requests:timeout", "PCH requests timeout "}, { "rach:requests", "RACH requests received"}, { "rach:requests:11bit", "11BIT_RACH requests received"}, + { "rach:requests:one_phase", "One phase packet access with request for single TS UL"}, /* TS 52.402 B.2.1.49 */ + { "rach:requests:two_phase", "Single block packet request for two phase packet access"}, /* TS 52.402 B.2.1.49 */ { "spb:uplink_first_segment", "First seg of UL SPB "}, { "spb:uplink_second_segment", "Second seg of UL SPB "}, { "spb:downlink_first_segment", "First seg of DL SPB "}, @@ -897,12 +899,17 @@ if (rc) /* Send RR Immediate Assignment Reject */ goto send_imm_ass_rej; - if (chan_req.single_block) + if (chan_req.single_block) { + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_TWO_PHASE); LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation\n"); - else if (bts->pcu->vty.force_two_phase) { + } else { + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_ONE_PHASE); LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single TS uplink transmission " - "(one phase packet access), but we force two phase access\n"); - chan_req.single_block = true; + "(one phase packet access)\n"); + if (bts->pcu->vty.force_two_phase) { + LOGP(DRLCMAC, LOGL_DEBUG, "Forcing two phase access\n"); + chan_req.single_block = true; + } } /* TODO: handle Radio Priority (see 3GPP TS 44.060, table 11.2.5a.5) */ diff --git a/src/bts.h b/src/bts.h index 63f80a8..06eb07c 100644 --- a/src/bts.h +++ b/src/bts.h @@ -129,6 +129,8 @@ CTR_PCH_REQUESTS_TIMEDOUT, CTR_RACH_REQUESTS, CTR_RACH_REQUESTS_11BIT, + CTR_RACH_REQUESTS_ONE_PHASE, + CTR_RACH_REQUESTS_TWO_PHASE, CTR_SPB_UL_FIRST_SEGMENT, CTR_SPB_UL_SECOND_SEGMENT, CTR_SPB_DL_FIRST_SEGMENT, diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 26ba446..27be4f0 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1719,6 +1719,7 @@ === start test_tbf_single_phase === Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -2445,6 +2446,7 @@ DL_ASS_TBF(UL-TFI_0){SEND_ASS}: Deallocated Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654275 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7104,6 +7106,7 @@ === end test_tbf_epdan_out_of_rx_window === === start test_immediate_assign_rej_multi_block === MS requests Uplink resource on CCCH/RACH: ra=0x78 (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7131,6 +7134,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=0 USF=0 MS requests Uplink resource on CCCH/RACH: ra=0x79 (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7158,6 +7162,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=1 USF=1 MS requests Uplink resource on CCCH/RACH: ra=0x7a (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7185,6 +7190,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=2 USF=2 MS requests Uplink resource on CCCH/RACH: ra=0x7b (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7212,6 +7218,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=3 USF=3 MS requests Uplink resource on CCCH/RACH: ra=0x7c (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7239,6 +7246,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=4 USF=4 MS requests Uplink resource on CCCH/RACH: ra=0x7d (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7266,6 +7274,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=5 USF=5 MS requests Uplink resource on CCCH/RACH: ra=0x7e (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF @@ -7293,6 +7302,7 @@ Modifying MS object, TLLI = 0xffffffff, TA 220 -> 7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=6 USF=6 MS requests Uplink resource on CCCH/RACH: ra=0x7f (8 bit) Fn=2654167 qta=31 +MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** UL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating UL TBF -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id87c3a53d3acee92499987c843130e358f54742c Gerrit-Change-Number: 26074 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:23:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:23:31 +0000 Subject: Change in osmo-pcu[master]: bts: Improve logging to clarify RACH req is for 2 phase access In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26075 ) Change subject: bts: Improve logging to clarify RACH req is for 2 phase access ...................................................................... bts: Improve logging to clarify RACH req is for 2 phase access Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd --- M src/bts.cpp M tests/tbf/TbfTest.err 2 files changed, 23 insertions(+), 22 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 7974f41..ee4da01 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -901,7 +901,8 @@ if (chan_req.single_block) { bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_TWO_PHASE); - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation\n"); + LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single block allocation " + "(two phase packet access)\n"); } else { bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_ONE_PHASE); LOGP(DRLCMAC, LOGL_DEBUG, "MS requests single TS uplink transmission " diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 27be4f0..a8fd741 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1801,7 +1801,7 @@ === end test_tbf_single_phase === === start test_tbf_two_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -1900,7 +1900,7 @@ === end test_tbf_two_phase === === start test_tbf_ra_update_rach === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2065,7 +2065,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) Scheduled Ack/Nack polling on FN=2654309, TS=7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) msg block (BSN 0, CS-4): 0f 01 00 29 52 41 55 5f 41 43 43 45 50 54 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 00 MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654245 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654348 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=1 @@ -2164,7 +2164,7 @@ === end test_tbf_ra_update_rach === === start test_tbf_dl_flow_and_rach_two_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2272,7 +2272,7 @@ UL_ASS_TBF(UL-TFI_0){NONE}: Deallocated DL_ASS_TBF(UL-TFI_0){SEND_ASS}: Deallocated MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654224 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654327 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2337,7 +2337,7 @@ === end test_tbf_dl_flow_and_rach_two_phase === === start test_tbf_dl_flow_and_rach_single_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -2509,7 +2509,7 @@ === end test_tbf_dl_flow_and_rach_single_phase === === start test_tbf_dl_reuse === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -3686,7 +3686,7 @@ === end test_tbf_ws === === start test_tbf_egprs_two_phase === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -3793,7 +3793,7 @@ === end test_tbf_egprs_two_phase === === start test_tbf_egprs_two_phase_spb === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -6746,7 +6746,7 @@ === end test_tbf_egprs_spb_dl === === start test_tbf_puan_urbb_len === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -6935,7 +6935,7 @@ === end test_tbf_update_ws === === start test_tbf_li_decoding === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -7331,14 +7331,14 @@ === end test_immediate_assign_rej_multi_block === === start test_immediate_assign_rej_single_block === MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) No PDCH available. No PDCH resource for single block allocation Tx Immediate Assignment Reject on AGCH === end test_immediate_assign_rej_single_block === === start test_tbf_egprs_two_phase_puan === MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Found first unallocated TRX=0 TFI=0 @@ -8645,35 +8645,35 @@ === end test_packet_access_rej_epdan === === start test_packet_access_rej_prr === MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=52 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x71 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=56 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x72 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=60 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=65 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x74 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=69 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x75 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=73 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x76 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=78 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 MS requests Uplink resource on CCCH/RACH: ra=0x77 (8 bit) Fn=2654167 qta=31 -MS requests single block allocation +MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=82 TRX=0 TS=7 Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=-1 USF=7 Detected FN jump! 2654167 -> 52 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd Gerrit-Change-Number: 26075 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:23:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:23:32 +0000 Subject: Change in osmo-pcu[master]: bts: Count RACH Request with unexpected content In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26076 ) Change subject: bts: Count RACH Request with unexpected content ...................................................................... bts: Count RACH Request with unexpected content Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b --- M src/bts.cpp M src/bts.h 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index ee4da01..6ef3280 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -139,6 +139,7 @@ { "rach:requests:11bit", "11BIT_RACH requests received"}, { "rach:requests:one_phase", "One phase packet access with request for single TS UL"}, /* TS 52.402 B.2.1.49 */ { "rach:requests:two_phase", "Single block packet request for two phase packet access"}, /* TS 52.402 B.2.1.49 */ + { "rach:requests:unexpected", "RACH Request with unexpected content received"}, { "spb:uplink_first_segment", "First seg of UL SPB "}, { "spb:uplink_second_segment", "Second seg of UL SPB "}, { "spb:downlink_first_segment", "First seg of DL SPB "}, @@ -896,8 +897,11 @@ /* Parse [EGPRS Packet] Channel Request from RACH.ind */ rc = parse_rach_ind(rip, &chan_req); - if (rc) /* Send RR Immediate Assignment Reject */ + if (rc) { + bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_UNEXPECTED); + /* Send RR Immediate Assignment Reject */ goto send_imm_ass_rej; + } if (chan_req.single_block) { bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_TWO_PHASE); diff --git a/src/bts.h b/src/bts.h index 06eb07c..fa3216f 100644 --- a/src/bts.h +++ b/src/bts.h @@ -131,6 +131,7 @@ CTR_RACH_REQUESTS_11BIT, CTR_RACH_REQUESTS_ONE_PHASE, CTR_RACH_REQUESTS_TWO_PHASE, + CTR_RACH_REQUESTS_UNEXPECTED, CTR_SPB_UL_FIRST_SEGMENT, CTR_SPB_UL_SECOND_SEGMENT, CTR_SPB_DL_FIRST_SEGMENT, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b Gerrit-Change-Number: 26076 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:28:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:28:35 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/25734/4/src/common/lchan.c File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/25734/4/src/common/lchan.c at 476 PS4, Line 476: LOGPLCHAN(lchan, DL1C, LOGL_NOTICE, NOTICE? really? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:28:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:29:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:29:12 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26133 ) Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:29:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:31:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:31:16 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 2: Code-Review+1 Please fix the linter warnings. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:31:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:38:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:38:01 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:38:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:38:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 ) Change subject: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2e287699925c6bb7f93439d0729e16682fab019 Gerrit-Change-Number: 26135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:38:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:39:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:39:12 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/L1CTL_PortType: add f_L1CTL_rx_data() helper In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 ) Change subject: library/L1CTL_PortType: add f_L1CTL_rx_data() helper ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136/1/library/L1CTL_PortType.ttcn File library/L1CTL_PortType.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136/1/library/L1CTL_PortType.ttcn at 45 PS1, Line 45: function f_L1CTL_rx_data(L1CTL_PT pt, maybe call it f_L1CTL_rx_data_ind? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I254171c6dc83f046b5ad1a72586c097deebb0fa7 Gerrit-Change-Number: 26136 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:39:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:39:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:39:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:39:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:40:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:40:12 +0000 Subject: Change in osmo-bts[master]: common/Makefile.am: reformat {AM_CPPFLAGS, AM_CFLAGS, LDADD} In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26139 ) Change subject: common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If475999cccc215b6792f276b9cc6c494a0c1ad81 Gerrit-Change-Number: 26139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:40:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 12:40:44 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/25734/4/src/common/lchan.c File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/25734/4/src/common/lchan.c at 476 PS4, Line 476: LOGPLCHAN(lchan, DL1C, LOGL_NOTICE, > NOTICE? really? Leftover from debugging, thanks for pointing this out! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:40:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:46:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:46:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add testing of incoming_intra_bsc_ho rate_ctrs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 ) Change subject: bsc: add testing of incoming_intra_bsc_ho rate_ctrs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba229313d73fa20266f6d4eac5820579fb14c604 Gerrit-Change-Number: 26141 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:46:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:47:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:47:39 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add test for CM Service Reject counter In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 ) Change subject: bsc: add test for CM Service Reject counter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a Gerrit-Change-Number: 26143 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:48:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:48:14 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: permit simultaneous ACCH repetition and overpower In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26144 ) Change subject: abis_rsl: permit simultaneous ACCH repetition and overpower ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Gerrit-Change-Number: 26144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:48:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:49:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:49:14 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: reduce verbosity of the OML logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26138 ) Change subject: ipaccess-config: reduce verbosity of the OML logging ...................................................................... Patch Set 2: I think it's fine having debug by default here? You have the quiet option if you don't want logging? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e Gerrit-Change-Number: 26138 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:49:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:50:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:50:22 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: do not pass lchan to print_meas_rep_buf() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26145 ) Change subject: abis_rsl: do not pass lchan to print_meas_rep_buf() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If965c7dc6b989ee758ddec0190ec1cce8363b240 Gerrit-Change-Number: 26145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:50:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:50:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:50:36 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: print_meas_rep_{buf, uni}() accept const *mr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26146 ) Change subject: abis_rsl: print_meas_rep_{buf,uni}() accept const *mr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c3e27a00cd84f102558499072965ec538f5a87f Gerrit-Change-Number: 26146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:50:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:51:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:51:30 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26147 ) Change subject: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] ...................................................................... Patch Set 1: I guess you checked this either in some documentation or by validating it manually? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf8e3a9ee6d9a8801d53254c772548586d4a9c60 Gerrit-Change-Number: 26147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:51:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:51:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:51:53 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: warn about unknown flag name In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26148 ) Change subject: ipaccess-config: warn about unknown flag name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab3bae3af9e1cac992b1f8947cda25fcff647992 Gerrit-Change-Number: 26148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:51:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:53:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:53:40 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 1: IMHO That should at least be a cmdline option, some programs may rely on one-entry-per-line format (we need to check OGT). Something like --enable-pretty-printing-json. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:55:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:55:03 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 1: Code-Review+1 See my previous post regarding one-line-per-entry. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:55:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 12:55:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 12:55:18 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_ctrl: make sure strtok results are checked In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26127 ) Change subject: osmo_bsc_ctrl: make sure strtok results are checked ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Gerrit-Change-Number: 26127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 12:55:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:06:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:06:44 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: reduce verbosity of the OML logging In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26138 ) Change subject: ipaccess-config: reduce verbosity of the OML logging ...................................................................... Patch Set 2: > Patch Set 2: > > I think it's fine having debug by default here? I find dozens of messages like "NM_FOO_BAR_OP[0x559cf7f52640]{DISABLED_NOTINSTALLED}: Allocated" useless, they just spam the output. Most of the MOs are not really involved in the process of configuration anyway. And this kind of conforms to our recent strategy of using NOTICE by default. > You have the quiet option if you don't want logging? But your logging still shows up, even when I am using '--quiet'... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e Gerrit-Change-Number: 26138 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:06:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:07:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:07:20 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG at 7 PS1, Line 7: pdch::rcv_resource_request(): Use local var to store bts pointer > This should be in the commit description. I think it's obvious that dereferencing the pointer once is better than doing it several times by calling a function, so I don't see the point in putting that in the commit description tbh. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 13:07:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:07:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:07:43 +0000 Subject: Change in osmo-pcu[master]: bts: Add counters for successful 1, 2 phase pkt access In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 to look at the new patch set (#3). Change subject: bts: Add counters for successful 1,2 phase pkt access ...................................................................... bts: Add counters for successful 1,2 phase pkt access These counters relate to succPDTCHAssProcsPerCause (B.2.1.50 Successful Packet Channel Assignment Procedures, per cause). Related: SYS#4878 Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 --- M src/bts.cpp M src/bts.h 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/26077/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 Gerrit-Change-Number: 26077 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:07:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:07:43 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 to look at the new patch set (#3). Change subject: Add counter for successful contention resolution procedures ...................................................................... Add counter for successful contention resolution procedures This counter is related to succPDTCHSeizures, (3GPP TS 52.402 B.2.1.51 Successful PDTCH seizures). The relevant event when the first RLC block on the PDCH from the MS is received is the fact that contention resolution is considered as done in the network side. Hence, name the counter that way to ease interpretation. Related: SYS#4878 Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c --- M src/bts.cpp M src/bts.h M src/pdch.cpp M src/tbf_ul.cpp 4 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/26080/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:10:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:10:57 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26147 ) Change subject: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] ...................................................................... Patch Set 1: Verified+1 > Patch Set 1: > > I guess you checked this either in some documentation or by validating it manually? Yes, I confirm that "enabled" is the correct flag name. If you set this flag, then the led works as usual. If you unset it, then the led gets dark and no longer lights up. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf8e3a9ee6d9a8801d53254c772548586d4a9c60 Gerrit-Change-Number: 26147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:10:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:14:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:14:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Improve counter validation In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 to look at the new patch set (#2). Change subject: pcu: Improve counter validation ...................................................................... pcu: Improve counter validation Validate some new counters recently added in osmo-pcu. Related: SYS#4878 Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff --- M pcu/PCU_Tests.ttcn 1 file changed, 170 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/26130/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff Gerrit-Change-Number: 26130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:14:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:14:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Use lower case for for counters assignment_{UL, DL} References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26153 ) Change subject: pcu: Use lower case for for counters assignment_{UL,DL} ...................................................................... pcu: Use lower case for for counters assignment_{UL,DL} The counters were renamed recently to be lower-case. Tests on older version will still work by checking the older name. Change-Id: I417d3bb12b5af2f50dce6bc9dbb705b7d7a52bce Depends: osmo-pcu.git Change-Id: I8de29c7e9dd8b17719dfeb784380c685377ce117 Related: SYS#4878 --- M pcu/PCU_Tests.ttcn 1 file changed, 42 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/26153/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 2cc6fad..5754451 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -2390,11 +2390,11 @@ { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } }; f_statsd_expect(expect); @@ -2412,11 +2412,11 @@ { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } }; f_statsd_expect(expect); @@ -2438,11 +2438,11 @@ { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } }; f_statsd_expect(expect); @@ -2721,13 +2721,22 @@ var StatsDExpects expect := { { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 0, max := 0}, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 1, max := 1}, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0}, { name := "TTCN3.bts.0.tbf.dl.alloc", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.tbf.ul.alloc", mtype := "c", min := 0, max := 0}, { name := "TTCN3.bts.0.rlc.dl_payload_bytes", mtype := "c", min := 64, max := 64}, { name := "TTCN3.bts.0.rlc.ul_payload_bytes", mtype := "c", min := 0, max := 0} }; + if (mp_osmo_pcu_newer_than_0_9_0) { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 0, max := 0} + }; + } else { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 0, max := 0} + }; + } f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); @@ -3148,11 +3157,11 @@ { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 1, max := 1 }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } }; f_statsd_expect(expect); @@ -3551,12 +3560,22 @@ var StatsDExpects expect := { { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1}, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.tbf.dl.alloc", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.tbf.ul.alloc", mtype := "c", min := 1, max := 1}, { name := "TTCN3.bts.0.rlc.dl_payload_bytes", mtype := "c", min := 10, max := 10}, { name := "TTCN3.bts.0.rlc.ul_payload_bytes", mtype := "c", min := 26, max := 26} }; + if (mp_osmo_pcu_newer_than_0_9_0) { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1} + }; + } else { + expect := expect & { + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 1, max := 1}, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 1, max := 1} + }; + } f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); @@ -3721,11 +3740,11 @@ { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } }; f_statsd_expect(expect); } @@ -3772,11 +3791,11 @@ { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } }; f_statsd_expect(expect); } @@ -3821,11 +3840,11 @@ { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } }; f_statsd_expect(expect); } @@ -3903,9 +3922,9 @@ { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } }; f_statsd_expect(expect); } @@ -3948,9 +3967,9 @@ { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } }; f_statsd_expect(expect); } @@ -4004,12 +4023,12 @@ { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 8, max := 8 }, { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul", mtype := "c", min := 7, max := 7 }, { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 7, max := 7 }, { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + { name := "TTCN3.bts.0.immediate.assignment_dl", mtype := "c", min := 0, max := 0 } }; f_statsd_expect(expect); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I417d3bb12b5af2f50dce6bc9dbb705b7d7a52bce Gerrit-Change-Number: 26153 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:15:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:15:02 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26147 ) Change subject: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf8e3a9ee6d9a8801d53254c772548586d4a9c60 Gerrit-Change-Number: 26147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:15:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:16:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:16:17 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 1: > Patch Set 1: > > IMHO That should at least be a cmdline option, some programs may rely on one-entry-per-line format (we need to check OGT). Something like --enable-pretty-printing-json. This is still valid JSON, isn't it? Whitespace does not matter in JSON. The only thing I am worried about is the trailing comma, but some parsers do permit it. I guess you're using some parser in OGT rather than parsing the output manually? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:16:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:18:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:18:47 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 1: Code-Review+1 Ok I checked and we are parsing json (see get_oml_ip in osmo-gsm-tester.git). Older programs parsing one per line are probably using the older non-json format. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:18:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:20:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:20:48 +0000 Subject: Change in osmo-pcu[master]: doc: Update counters_generated.adoc using osmo_vty_interact.py In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26122 ) Change subject: doc: Update counters_generated.adoc using osmo_vty_interact.py ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 Gerrit-Change-Number: 26122 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:20:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Nov 8 13:22:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:22:20 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <618924a72bcb3_2ea32b0a73cf05f01337516@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/libusrp failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 190s] [365/367] installing libboost-mpi-python1.71-dev-1.71.0-6ubuntu6 [ 190s] [366/367] installing libboost-mpi-python-dev-1.71.0.0ubuntu2 [ 190s] [367/367] installing libboost-all-dev-1.71.0.0ubuntu2 [ 190s] configuring all installed packages... [ 190s] now finalizing build dir... [ 190s] SIOCSIFADDR: File exists [ 191s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.4.cdc0.202111080026.dsc) [ 191s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 191s] dpkg-source: info: unpacking libusrp_3.4.5.4.cdc0.202111080026.tar.xz [ 191s] ----------------------------------------------------------------- [ 191s] ----- building libusrp_3.4.5.4.cdc0.202111080026.dsc (user abuild) [ 191s] ----------------------------------------------------------------- [ 191s] ----------------------------------------------------------------- [ 191s] dpkg-buildpackage: info: source package libusrp [ 191s] dpkg-buildpackage: info: source version 3.4.5.4.cdc0.202111080026 [ 191s] dpkg-buildpackage: info: source distribution UNRELEASED [ 191s] dpkg-buildpackage: info: source changed by Harald Welte [ 191s] dpkg-source --before-build . [ 191s] dpkg-buildpackage: info: host architecture amd64 [ 192s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 192s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 192s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 192s] ### VM INTERACTION START ### [ 195s] [ 174.951552] sysrq: Power Off [ 195s] [ 174.974657] reboot: Power down [ 195s] ### VM INTERACTION END ### [ 195s] [ 195s] cloud123 failed "build libusrp_3.4.5.4.cdc0.202111080026.dsc" at Mon Nov 8 13:22:08 UTC 2021. [ 195s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:22:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:22:37 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618924a81612a_2ea32b0a73cf05f0133773f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Testing/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 169s] [380/382] installing libboost-mpi-python1.74-dev-1.74.0-9 [ 169s] [381/382] installing libboost-mpi-python-dev-1.74.0.3 [ 169s] [382/382] installing libboost-all-dev-1.74.0.3 [ 169s] configuring all installed packages... [ 169s] now finalizing build dir... [ 169s] SIOCSIFADDR: File exists [ 169s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.4.cdc0.202111080026.dsc) [ 169s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 169s] dpkg-source: info: unpacking libusrp_3.4.5.4.cdc0.202111080026.tar.xz [ 170s] ----------------------------------------------------------------- [ 170s] ----- building libusrp_3.4.5.4.cdc0.202111080026.dsc (user abuild) [ 170s] ----------------------------------------------------------------- [ 170s] ----------------------------------------------------------------- [ 170s] dpkg-buildpackage: info: source package libusrp [ 170s] dpkg-buildpackage: info: source version 3.4.5.4.cdc0.202111080026 [ 170s] dpkg-buildpackage: info: source distribution UNRELEASED [ 170s] dpkg-buildpackage: info: source changed by Harald Welte [ 170s] dpkg-source --before-build . [ 170s] dpkg-buildpackage: info: host architecture amd64 [ 170s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 170s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 170s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 170s] ### VM INTERACTION START ### [ 173s] [ 157.743241] sysrq: Power Off [ 173s] [ 157.767958] reboot: Power down [ 174s] ### VM INTERACTION END ### [ 174s] [ 174s] lamb18 failed "build libusrp_3.4.5.4.cdc0.202111080026.dsc" at Mon Nov 8 13:22:29 UTC 2021. [ 174s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:23:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:23:28 +0000 Subject: Build failure of network:osmocom:latest/libusrp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <618924e63133e_2ea32b0a73cf05f013379d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Testing/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 191s] [380/382] installing libboost-mpi-python1.74-dev-1.74.0-9 [ 191s] [381/382] installing libboost-mpi-python-dev-1.74.0.3 [ 192s] [382/382] installing libboost-all-dev-1.74.0.3 [ 192s] configuring all installed packages... [ 192s] now finalizing build dir... [ 192s] SIOCSIFADDR: File exists [ 192s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.dsc) [ 192s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 192s] dpkg-source: info: unpacking libusrp_3.4.5.tar.xz [ 192s] ----------------------------------------------------------------- [ 192s] ----- building libusrp_3.4.5.dsc (user abuild) [ 192s] ----------------------------------------------------------------- [ 192s] ----------------------------------------------------------------- [ 192s] dpkg-buildpackage: info: source package libusrp [ 192s] dpkg-buildpackage: info: source version 3.4.5 [ 192s] dpkg-buildpackage: info: source distribution unstable [ 192s] dpkg-buildpackage: info: source changed by Harald Welte [ 192s] dpkg-source --before-build . [ 192s] dpkg-buildpackage: info: host architecture amd64 [ 193s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 193s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 193s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 193s] ### VM INTERACTION START ### [ 196s] [ 179.261183] sysrq: Power Off [ 196s] [ 179.270028] reboot: Power down [ 196s] ### VM INTERACTION END ### [ 196s] [ 196s] lamb60 failed "build libusrp_3.4.5.dsc" at Mon Nov 8 13:23:21 UTC 2021. [ 196s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:23:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:23:46 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <618924e749faf_2ea32b0a73cf05f01338135@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/libusrp failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 101s] [371/373] installing libboost-mpi-python1.71-dev-1.71.0-6ubuntu9 [ 101s] [372/373] installing libboost-mpi-python-dev-1.71.0.0ubuntu4 [ 101s] [373/373] installing libboost-all-dev-1.71.0.0ubuntu4 [ 101s] configuring all installed packages... [ 101s] now finalizing build dir... [ 101s] SIOCSIFADDR: File exists [ 101s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.4.cdc0.202111080026.dsc) [ 101s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 101s] dpkg-source: info: unpacking libusrp_3.4.5.4.cdc0.202111080026.tar.xz [ 101s] ----------------------------------------------------------------- [ 101s] ----- building libusrp_3.4.5.4.cdc0.202111080026.dsc (user abuild) [ 101s] ----------------------------------------------------------------- [ 101s] ----------------------------------------------------------------- [ 101s] dpkg-buildpackage: info: source package libusrp [ 101s] dpkg-buildpackage: info: source version 3.4.5.4.cdc0.202111080026 [ 101s] dpkg-buildpackage: info: source distribution UNRELEASED [ 101s] dpkg-buildpackage: info: source changed by Harald Welte [ 101s] dpkg-source --before-build . [ 101s] dpkg-buildpackage: info: host architecture amd64 [ 102s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 102s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 102s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 102s] ### VM INTERACTION START ### [ 105s] [ 96.275759] sysrq: Power Off [ 105s] [ 96.279774] reboot: Power down [ 105s] ### VM INTERACTION END ### [ 105s] [ 105s] goat03 failed "build libusrp_3.4.5.4.cdc0.202111080026.dsc" at Mon Nov 8 13:23:39 UTC 2021. [ 105s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:24:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:24:54 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <6189253f5c87b_2ea32b0a73cf05f0133853a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/libusrp failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 152s] [388/390] installing libboost-fiber-dev-1.74.0.3ubuntu5 [ 152s] [389/390] installing libboost-mpi-python-dev-1.74.0.3ubuntu5 [ 153s] [390/390] installing libboost-all-dev-1.74.0.3ubuntu5 [ 153s] configuring all installed packages... [ 153s] now finalizing build dir... [ 153s] SIOCSIFADDR: File exists [ 153s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.4.cdc0.202111080026.dsc) [ 153s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 153s] dpkg-source: info: unpacking libusrp_3.4.5.4.cdc0.202111080026.tar.xz [ 153s] ----------------------------------------------------------------- [ 153s] ----- building libusrp_3.4.5.4.cdc0.202111080026.dsc (user abuild) [ 153s] ----------------------------------------------------------------- [ 153s] ----------------------------------------------------------------- [ 153s] dpkg-buildpackage: info: source package libusrp [ 153s] dpkg-buildpackage: info: source version 3.4.5.4.cdc0.202111080026 [ 153s] dpkg-buildpackage: info: source distribution UNRELEASED [ 153s] dpkg-buildpackage: info: source changed by Harald Welte [ 153s] dpkg-source --before-build . [ 153s] dpkg-buildpackage: info: host architecture amd64 [ 154s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 154s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 154s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 154s] ### VM INTERACTION START ### [ 157s] [ 143.453522] sysrq: Power Off [ 157s] [ 143.460532] reboot: Power down [ 157s] ### VM INTERACTION END ### [ 157s] [ 157s] lamb18 failed "build libusrp_3.4.5.4.cdc0.202111080026.dsc" at Mon Nov 8 13:24:39 UTC 2021. [ 157s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:24:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:24:54 +0000 Subject: Build failure of network:osmocom:latest/libusrp in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <61892540131a8_2ea32b0a73cf05f01338737@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/xUbuntu_20.10/x86_64 Package network:osmocom:latest/libusrp failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 0s] Using BUILD_ROOT=/var/cache/obs/worker/root_3/.mount [ 0s] Using BUILD_ARCH=x86_64:i686:i586:i486:i386 [ 0s] Doing kvm build in /var/cache/obs/worker/root_3/root [ 0s] [ 0s] [ 0s] cloud111 started "build libusrp_3.4.5.dsc" at Mon Nov 8 13:25:16 UTC 2021. [ 0s] [ 0s] Building libusrp for project 'network:osmocom:latest' repository 'xUbuntu_20.10' arch 'x86_64' srcmd5 '62bca661816aec4461ef857f8ebda700' [ 0s] [ 1s] processing recipe /var/cache/obs/worker/root_3/.build-srcdir/libusrp_3.4.5.dsc ... [ 1s] running changelog2spec --target debian --file /var/cache/obs/worker/root_3/.build-srcdir/libusrp_3.4.5.dsc [ 1s] init_buildsystem --configdir /var/run/obs/worker/3/build/configs --cachedir /var/cache/build --prepare --clean --rpmlist /var/cache/obs/worker/root_3/.build.rpmlist /var/cache/obs/worker/root_3/.build-srcdir/libusrp_3.4.5.dsc build ... -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:25:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:25:11 +0000 Subject: Build failure of network:osmocom:latest/libusrp in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <61892540f2ca1_2ea32b0a73cf05f013390de@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/xUbuntu_21.04/x86_64 Package network:osmocom:latest/libusrp failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 184s] [388/390] installing libboost-fiber-dev-1.74.0.3ubuntu5 [ 184s] [389/390] installing libboost-mpi-python-dev-1.74.0.3ubuntu5 [ 184s] [390/390] installing libboost-all-dev-1.74.0.3ubuntu5 [ 184s] configuring all installed packages... [ 184s] now finalizing build dir... [ 184s] SIOCSIFADDR: File exists [ 185s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.dsc) [ 185s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 185s] dpkg-source: info: unpacking libusrp_3.4.5.tar.xz [ 186s] ----------------------------------------------------------------- [ 186s] ----- building libusrp_3.4.5.dsc (user abuild) [ 186s] ----------------------------------------------------------------- [ 186s] ----------------------------------------------------------------- [ 187s] dpkg-buildpackage: info: source package libusrp [ 187s] dpkg-buildpackage: info: source version 3.4.5 [ 187s] dpkg-buildpackage: info: source distribution unstable [ 187s] dpkg-buildpackage: info: source changed by Harald Welte [ 187s] dpkg-source --before-build . [ 187s] dpkg-buildpackage: info: host architecture amd64 [ 187s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 187s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 187s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 187s] ### VM INTERACTION START ### [ 190s] [ 175.687795] sysrq: Power Off [ 190s] [ 175.721462] reboot: Power down [ 191s] ### VM INTERACTION END ### [ 191s] [ 191s] cloud105 failed "build libusrp_3.4.5.dsc" at Mon Nov 8 13:25:10 UTC 2021. [ 191s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:26:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:26:05 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG at 7 PS1, Line 7: pdch::rcv_resource_request(): Use local var to store bts pointer > I think it's obvious that dereferencing the pointer once is better than doing it several times by ca [?] Well, it is obvious *for you*. For me it was not, especially given that you still have code like trx_no() and ul_tbf->ms() in this function. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 13:26:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:26:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:26:54 +0000 Subject: Change in osmo-pcu[master]: bts: Add counters for successful 1, 2 phase pkt access In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26077 ) Change subject: bts: Add counters for successful 1,2 phase pkt access ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 Gerrit-Change-Number: 26077 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 13:26:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Nov 8 13:28:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:28:03 +0000 Subject: Build failure of network:osmocom:latest/libusrp in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <618925f24f503_2ea32b0a73cf05f0134004e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/xUbuntu_20.04/x86_64 Package network:osmocom:latest/libusrp failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:29:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:29:11 +0000 Subject: Build failure of network:osmocom:latest/libusrp in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <6189262cf2a45_2ea32b0a73cf05f01340751@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/xUbuntu_21.10/x86_64 Package network:osmocom:latest/libusrp failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 409s] [380/382] installing libboost-mpi-python1.74-dev-1.74.0-8ubuntu6 [ 409s] [381/382] installing libboost-mpi-python-dev-1.74.0.3ubuntu6 [ 409s] [382/382] installing libboost-all-dev-1.74.0.3ubuntu6 [ 409s] configuring all installed packages... [ 409s] now finalizing build dir... [ 409s] SIOCSIFADDR: File exists [ 410s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.dsc) [ 410s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 410s] dpkg-source: info: unpacking libusrp_3.4.5.tar.xz [ 410s] ----------------------------------------------------------------- [ 410s] ----- building libusrp_3.4.5.dsc (user abuild) [ 410s] ----------------------------------------------------------------- [ 410s] ----------------------------------------------------------------- [ 410s] dpkg-buildpackage: info: source package libusrp [ 410s] dpkg-buildpackage: info: source version 3.4.5 [ 410s] dpkg-buildpackage: info: source distribution unstable [ 410s] dpkg-buildpackage: info: source changed by Harald Welte [ 410s] dpkg-source --before-build . [ 410s] dpkg-buildpackage: info: host architecture amd64 [ 411s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 411s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 411s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 411s] ### VM INTERACTION START ### [ 414s] [ 342.250992] sysrq: Power Off [ 414s] [ 342.257441] reboot: Power down [ 414s] ### VM INTERACTION END ### [ 414s] [ 414s] lamb14 failed "build libusrp_3.4.5.dsc" at Mon Nov 8 13:29:03 UTC 2021. [ 414s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 8 13:30:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 08 Nov 2021 13:30:54 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <618926a4ce9d0_2ea32b0a73cf05f01341280@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/xUbuntu_21.10/x86_64 Package network:osmocom:nightly/libusrp failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 515s] [380/382] installing libboost-mpi-python1.74-dev-1.74.0-8ubuntu6 [ 515s] [381/382] installing libboost-mpi-python-dev-1.74.0.3ubuntu6 [ 515s] [382/382] installing libboost-all-dev-1.74.0.3ubuntu6 [ 515s] configuring all installed packages... [ 515s] now finalizing build dir... [ 515s] SIOCSIFADDR: File exists [ 516s] dpkg-source: warning: extracting unsigned source package (/usr/src/packages/SOURCES/libusrp_3.4.5.4.cdc0.202111080026.dsc) [ 516s] dpkg-source: info: extracting libusrp in /usr/src/packages/BUILD [ 516s] dpkg-source: info: unpacking libusrp_3.4.5.4.cdc0.202111080026.tar.xz [ 516s] ----------------------------------------------------------------- [ 516s] ----- building libusrp_3.4.5.4.cdc0.202111080026.dsc (user abuild) [ 516s] ----------------------------------------------------------------- [ 516s] ----------------------------------------------------------------- [ 516s] dpkg-buildpackage: info: source package libusrp [ 516s] dpkg-buildpackage: info: source version 3.4.5.4.cdc0.202111080026 [ 516s] dpkg-buildpackage: info: source distribution UNRELEASED [ 516s] dpkg-buildpackage: info: source changed by Harald Welte [ 517s] dpkg-source --before-build . [ 517s] dpkg-buildpackage: info: host architecture amd64 [ 517s] dpkg-checkbuilddeps: error: Unmet build dependencies: python [ 517s] dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting [ 517s] dpkg-buildpackage: warning: (Use -d flag to override.) [ 517s] ### VM INTERACTION START ### [ 520s] [ 473.195554] sysrq: Power Off [ 520s] [ 473.253778] reboot: Power down [ 520s] ### VM INTERACTION END ### [ 520s] [ 521s] lamb08 failed "build libusrp_3.4.5.4.cdc0.202111080026.dsc" at Mon Nov 8 13:30:49 UTC 2021. [ 521s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:31:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:31:41 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 13:31:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:32:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:32:22 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > See my previous post regarding one-line-per-entry. Having all NVRAM flags in one line would make the output unreadable :( -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:32:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:34:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:34:41 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 5: (1 comment) This change is ready for review. https://gerrit.osmocom.org/c/osmo-bts/+/25734/4/src/common/lchan.c File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/25734/4/src/common/lchan.c at 476 PS4, Line 476: LOGPLCHAN(lchan, DL1C, LOGL_NOTICE, > Leftover from debugging, thanks for pointing this out! Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:34:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:42:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:42:39 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Set first_(common_)ts in handle_tbf_reject References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26154 ) Change subject: tbf_ul: Set first_(common_)ts in handle_tbf_reject ...................................................................... tbf_ul: Set first_(common_)ts in handle_tbf_reject Let's set them to match expectancies for this type of dummy TBFs, in order to avoid acidental use/access of other timeslots to the one where the reject was associated to. Also use tbf_assign_control_ts() to log the TS used for the TBF, similar to what's used in other places where control_ts is assigned. Related: OS#5293 Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e --- M src/tbf_ul.cpp M tests/tbf/TbfTest.err 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/26154/1 diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index d6936e1..ca929ea 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -204,8 +204,11 @@ talloc_set_destructor(ul_tbf, ul_tbf_dtor); new (ul_tbf) gprs_rlcmac_ul_tbf(bts, ms); - ul_tbf->control_ts = ts; ul_tbf->trx = trx; + /* The only one TS is the common, control TS */ + ul_tbf->first_ts = ts; + ul_tbf->first_common_ts = ts; + tbf_assign_control_ts(ul_tbf); ul_tbf->m_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ctrg_desc, next_tbf_ctr_group_id++); ul_tbf->m_ul_egprs_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ul_egprs_ctrg_desc, diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index a8fd741..0374f57 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -9076,6 +9076,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated +TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] @@ -9106,6 +9107,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated +TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e Gerrit-Change-Number: 26154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:42:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:42:39 +0000 Subject: Change in osmo-pcu[master]: tbf: Set m_created_ts in constructor References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26155 ) Change subject: tbf: Set m_created_ts in constructor ...................................................................... tbf: Set m_created_ts in constructor This way the timestamp is also set for dummy reject TBFs. For other TBFs, setup() is called immediatelly after calling the constructor, so we are fine too. Change-Id: I2966ec7f3f9161d528a173d94797b72d1398c747 --- M src/tbf.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/26155/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 2d6139b..4bd87dd 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -137,6 +137,8 @@ m_llc.init(); m_name_buf[0] = '\0'; + + m_created_ts = time(NULL); } @@ -657,7 +659,6 @@ if (ms_mode(m_ms) != GPRS) enable_egprs(); - m_created_ts = time(NULL); /* select algorithm */ rc = the_pcu->alloc_algorithm(bts, this, single_slot, use_trx); /* if no resource */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2966ec7f3f9161d528a173d94797b72d1398c747 Gerrit-Change-Number: 26155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:42:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:42:40 +0000 Subject: Change in osmo-pcu[master]: tbf: Mark initial first_(common_)ts with special value References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26156 ) Change subject: tbf: Mark initial first_(common_)ts with special value ...................................................................... tbf: Mark initial first_(common_)ts with special value This way it's easier to distinguish when this value was not properly filled when debugging or looking at logs. Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e --- M src/tbf.cpp M src/tbf.h 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/56/26156/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 4bd87dd..bdba2e7 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -94,9 +94,9 @@ gprs_rlcmac_tbf::gprs_rlcmac_tbf(struct gprs_rlcmac_bts *bts_, GprsMs *ms, gprs_rlcmac_tbf_direction dir) : direction(dir), trx(NULL), - first_ts(0), - first_common_ts(0), - control_ts(TBF_CONTROL_TS_UNSET), + first_ts(TBF_TS_UNSET), + first_common_ts(TBF_TS_UNSET), + control_ts(TBF_TS_UNSET), fT(0), num_fT_exp(0), upgrade_to_multislot(false), @@ -251,7 +251,7 @@ * confirmation from the MS and goes through the FLOW state. Hence, we * may have ULC pollings ongoing and we need to make sure we drop all * reserved nodes there: */ - if (tbf->control_ts != TBF_CONTROL_TS_UNSET && !tbf->pdch[tbf->control_ts]) + if (tbf->control_ts != TBF_TS_UNSET && !tbf->pdch[tbf->control_ts]) pdch_ulc_release_tbf(tbf->trx->pdch[tbf->control_ts].ulc, tbf); /* Now simply detach from all attached PDCHs */ @@ -340,7 +340,7 @@ void tbf_assign_control_ts(struct gprs_rlcmac_tbf *tbf) { - if (tbf->control_ts == TBF_CONTROL_TS_UNSET) + if (tbf->control_ts == TBF_TS_UNSET) LOGPTBF(tbf, LOGL_INFO, "Setting Control TS %d\n", tbf->first_common_ts); else if (tbf->control_ts != tbf->first_common_ts) diff --git a/src/tbf.h b/src/tbf.h index 4013ab0..4652d95 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -116,7 +116,7 @@ #define GPRS_RLCMAC_FLAG_TO_DL_ACK 3 /* DL TBF: Failed to receive last polled DL ACK/NACK */ #define GPRS_RLCMAC_FLAG_TO_MASK 0xf0 /* timeout bits */ -#define TBF_CONTROL_TS_UNSET 0xff +#define TBF_TS_UNSET 0xff #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e Gerrit-Change-Number: 26156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:42:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:42:40 +0000 Subject: Change in osmo-pcu[master]: tbf: Set tfi to initial special value References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26157 ) Change subject: tbf: Set tfi to initial special value ...................................................................... tbf: Set tfi to initial special value This allows distinguishing when a TBF didn't set the TFI. Useful to identify dummy reject TBFs, etc, and make sure a non-dummy TBF set its TFI properly. Change-Id: Iecf54a24041bd14f4ef5b86e57c3732e1b69d463 --- M src/tbf.cpp M src/tbf.h M tests/alloc/AllocTest.err M tests/ms/MsTest.err M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 6 files changed, 99 insertions(+), 97 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/26157/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index bdba2e7..4b78595 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -101,7 +101,7 @@ num_fT_exp(0), upgrade_to_multislot(false), bts(bts_), - m_tfi(0), + m_tfi(TBF_TFI_UNSET), m_created_ts(0), m_ctrs(NULL), m_ms(ms), @@ -719,9 +719,10 @@ const char *gprs_rlcmac_tbf::name() const { + int8_t tfi = m_tfi == TBF_TS_UNSET ? -1 : m_tfi; snprintf(m_name_buf, sizeof(m_name_buf) - 1, "TBF(TFI=%d TLLI=0x%08x DIR=%s STATE=%s%s)", - m_tfi, tlli(), + tfi, tlli(), direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", state_name(), is_egprs_enabled() ? " EGPRS" : "" diff --git a/src/tbf.h b/src/tbf.h index 4652d95..9ce1813 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -117,6 +117,7 @@ #define GPRS_RLCMAC_FLAG_TO_MASK 0xf0 /* timeout bits */ #define TBF_TS_UNSET 0xff +#define TBF_TFI_UNSET 0xff #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__) diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err index 1ca4b3b..cb98332 100644 --- a/tests/alloc/AllocTest.err +++ b/tests/alloc/AllocTest.err @@ -389,7 +389,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -748,7 +748,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -1595,7 +1595,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -2294,7 +2294,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -474805,7 +474805,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -474994,7 +474994,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475183,7 +475183,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475468,7 +475468,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475681,7 +475681,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475895,7 +475895,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -476330,7 +476330,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -476529,7 +476529,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -476729,7 +476729,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -479307,7 +479307,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -479836,7 +479836,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: 0). [DL] algo B (suggested TRX: 0): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -481537,7 +481537,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482112,7 +482112,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482371,7 +482371,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482631,7 +482631,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482854,7 +482854,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482953,7 +482953,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -483095,7 +483095,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -484069,7 +484069,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -484272,7 +484272,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: -1). [DL] algo B (suggested TRX: -1): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -484959,7 +484959,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -487533,7 +487533,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -487753,7 +487753,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xc0000023 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xc0000023 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -491263,7 +491263,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -493033,7 +493033,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -493563,7 +493563,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: 0). [DL] algo B (suggested TRX: 0): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -493679,7 +493679,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -494436,7 +494436,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: 0). [DL] algo B (suggested TRX: 0): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -494803,7 +494803,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: -1). [DL] algo B (suggested TRX: -1): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -496297,7 +496297,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -496409,7 +496409,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -499422,7 +499422,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -501192,7 +501192,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated diff --git a/tests/ms/MsTest.err b/tests/ms/MsTest.err index 6adbfc4..d4895b9 100644 --- a/tests/ms/MsTest.err +++ b/tests/ms/MsTest.err @@ -1,22 +1,22 @@ Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xaa000000 Modifying MS object, UL TLLI: 0xaa000000 -> 0xff001111, not yet confirmed @@ -41,21 +41,21 @@ Creating MS object, TLLI = 0xffffffff Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddbc, not yet confirmed Modifying MS object, TLLI = 0xffeeddbc, IMSI '' -> '001001987654322' -MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Destroying MS object -MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Release timer expired MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) Creating MS object, TLLI = 0xdeadbeef Creating MS object, TLLI = 0xdeadbef0 -MS(TLLI=0xdeadbef0, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xdeadbef0 DIR=DL STATE=NEW) +MS(TLLI=0xdeadbef0, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0xdeadbef0 DIR=DL STATE=NEW) diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 0374f57..7d2d534 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1601,7 +1601,7 @@ DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): Alloc start [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xc0000020 DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 +TBF(TFI=-1 TLLI=0xc0000020 DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -7320,7 +7320,7 @@ - Skipping TS 6, because not enabled - Skipping TS 7, because no USF available [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 UL_ACK_TBF{NONE}: Deallocated TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated @@ -9066,7 +9066,7 @@ - Skipping TS 6, because not enabled - Skipping TS 7, because no USF available [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW EGPRS) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW EGPRS) Timeslot Allocation failed: trx = 0, single_slot = 0 UL_ACK_TBF{NONE}: Deallocated TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated @@ -9076,12 +9076,12 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 -MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 +MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] TBF{NEW}: state_chg to ASSIGN -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ PDCH(bts=0,trx=0,ts=7) Expiring FN=82 but previous FN=2654231 is still reserved! @@ -9107,21 +9107,21 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 -MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 +MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] TBF{NEW}: state_chg to ASSIGN -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ UL_ASS_TBF{SEND_ASS_REJ}: Received Event CREATE_RLCMAC_MSG UL_ASS_TBF{SEND_ASS_REJ}: state_chg to NONE -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) starting timer X2000 [reject (PACCH)] with 0 sec. 0 microsec -PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) starting timer X2000 [reject (PACCH)] with 0 sec. 0 microsec +PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) UL_ASS_TBF{NONE}: Timeout of X2000 -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) free -MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) free +MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Destroying MS object ********** UL-TBF ends here ********** UL_ACK_TBF{NONE}: Deallocated diff --git a/tests/ulc/PdchUlcTest.err b/tests/ulc/PdchUlcTest.err index d122f31..411c3f3 100644 --- a/tests/ulc/PdchUlcTest.err +++ b/tests/ulc/PdchUlcTest.err @@ -5,42 +5,42 @@ PDCH(bts=0,trx=0,ts=0) Trying to release unregistered SBA (FN=78, TA=0) PDCH(bts=0,trx=0,ts=0) Timeout for registered SBA (FN=72, TA=0) Creating MS object, TLLI = 0x12345678 -MS(TLLI=0x12345678, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +MS(TLLI=0x12345678, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=2715613 but previous FN=2715608 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715608, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715613, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715608, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715613, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715617 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715617, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715617, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715622 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715622, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715622, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715626 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715626, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715626, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715630 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715630, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715630, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715635 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715635, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715635, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715639 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715639, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715639, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715643 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715643, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715643, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=4 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=4, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=4, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=8 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=8, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=8, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=13 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=13, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=13, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=17 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=17, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=17, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=21 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=21, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=21, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=26 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=26, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=26, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=30 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=30, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=30, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=34 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=34, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=34, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=39 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=39, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=39, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 26 + 13 = 39 PDCH(bts=0,trx=0,ts=0) UL block already scheduled at FN 91 + 13 = 104 PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 91 + 17 = 108 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iecf54a24041bd14f4ef5b86e57c3732e1b69d463 Gerrit-Change-Number: 26157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:42:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:42:41 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Update FSM names for dummy reject TBFs References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26158 ) Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... tbf_ul: Update FSM names for dummy reject TBFs This allows easily identifying dummt TBFs created to send assignment rejects. Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 --- M src/tbf.cpp M src/tbf_ul.cpp M tests/tbf/TbfTest.err 3 files changed, 18 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/58/26158/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 4b78595..79c8eb0 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -734,9 +734,10 @@ void tbf_update_state_fsm_name(struct gprs_rlcmac_tbf *tbf) { char buf[64]; + int8_t tfi = tbf_tfi(tbf) == TBF_TS_UNSET ? -1 : tbf_tfi(tbf); snprintf(buf, sizeof(buf), "%s-TFI_%d", tbf_direction(tbf) == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", - tbf_tfi(tbf)); + tfi); osmo_identifier_sanitize_buf(buf, NULL, '_'); osmo_fsm_inst_update_id(tbf->state_fsm.fi, buf); diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index ca929ea..f0d16b5 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -221,6 +221,7 @@ talloc_free(ul_tbf); return NULL; } + tbf_update_state_fsm_name(ul_tbf); ms_attach_tbf(ms, ul_tbf); llist_add(tbf_trx_list((struct gprs_rlcmac_tbf *)ul_tbf), &trx->ul_tbfs); diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 7d2d534..c440499 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -9078,12 +9078,12 @@ UL_ACK_TBF{NONE}: Allocated TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) -TBF{NEW}: Received Event ASSIGN_ADD_PACCH +TBF(UL-TFI_-1){NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] -TBF{NEW}: state_chg to ASSIGN +TBF(UL-TFI_-1){NEW}: state_chg to ASSIGN TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec -UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ -UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){NONE}: Received Event SCHED_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){NONE}: state_chg to SEND_ASS_REJ PDCH(bts=0,trx=0,ts=7) Expiring FN=82 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=6 TLLI=0xffeeddd2 DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=6 TLLI=0xffeeddd2 DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 82) @@ -9109,23 +9109,23 @@ UL_ACK_TBF{NONE}: Allocated TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) -TBF{NEW}: Received Event ASSIGN_ADD_PACCH +TBF(UL-TFI_-1){NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] -TBF{NEW}: state_chg to ASSIGN +TBF(UL-TFI_-1){NEW}: state_chg to ASSIGN TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec -UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ -UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ -UL_ASS_TBF{SEND_ASS_REJ}: Received Event CREATE_RLCMAC_MSG -UL_ASS_TBF{SEND_ASS_REJ}: state_chg to NONE +UL_ASS_TBF(UL-TFI_-1){NONE}: Received Event SCHED_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){NONE}: state_chg to SEND_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){SEND_ASS_REJ}: Received Event CREATE_RLCMAC_MSG +UL_ASS_TBF(UL-TFI_-1){SEND_ASS_REJ}: state_chg to NONE TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) starting timer X2000 [reject (PACCH)] with 0 sec. 0 microsec PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) -UL_ASS_TBF{NONE}: Timeout of X2000 +UL_ASS_TBF(UL-TFI_-1){NONE}: Timeout of X2000 TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) free MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Destroying MS object ********** UL-TBF ends here ********** -UL_ACK_TBF{NONE}: Deallocated -TBF{ASSIGN}: Deallocated -UL_ASS_TBF{NONE}: Deallocated -DL_ASS_TBF{NONE}: Deallocated +UL_ACK_TBF(UL-TFI_-1){NONE}: Deallocated +TBF(UL-TFI_-1){ASSIGN}: Deallocated +UL_ASS_TBF(UL-TFI_-1){NONE}: Deallocated +DL_ASS_TBF(UL-TFI_-1){NONE}: Deallocated === end test_packet_access_rej_prr_no_other_tbfs === -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:51:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 13:51:07 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 13:51:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:52:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:52:38 +0000 Subject: Change in osmo-pcu[master]: pdch: Improve log line and increase log level In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26152 ) Change subject: pdch: Improve log line and increase log level ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie593331a69f6b8ec3b21e2b274a1aa060b2dc439 Gerrit-Change-Number: 26152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 13:52:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:52:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:52:43 +0000 Subject: Change in osmo-pcu[master]: tbf: Increase log level of line about unable to allocate poll for TBF In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26151 ) Change subject: tbf: Increase log level of line about unable to allocate poll for TBF ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0bd972d3b68017f12a0816a27162e3a409b1893a Gerrit-Change-Number: 26151 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 13:52:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:53:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:53:48 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Set first_(common_)ts in handle_tbf_reject In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26154 ) Change subject: tbf_ul: Set first_(common_)ts in handle_tbf_reject ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e Gerrit-Change-Number: 26154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 08 Nov 2021 13:53:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:54:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:54:15 +0000 Subject: Change in osmo-pcu[master]: tbf: Set m_created_ts in constructor In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26155 ) Change subject: tbf: Set m_created_ts in constructor ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2966ec7f3f9161d528a173d94797b72d1398c747 Gerrit-Change-Number: 26155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 08 Nov 2021 13:54:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:54:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:54:49 +0000 Subject: Change in osmo-pcu[master]: tbf: Mark initial first_(common_)ts with special value In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26156 ) Change subject: tbf: Mark initial first_(common_)ts with special value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e Gerrit-Change-Number: 26156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 08 Nov 2021 13:54:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 13:56:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 13:56:14 +0000 Subject: Change in osmo-pcu[master]: tbf: Set tfi to initial special value In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26157 ) Change subject: tbf: Set tfi to initial special value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iecf54a24041bd14f4ef5b86e57c3732e1b69d463 Gerrit-Change-Number: 26157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 13:56:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:39:33 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:39:33 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 to look at the new patch set (#2). Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... implement bts.N.cm_serv_rej: rate counters Related: I0214b27da18af87eca9715ebf7eeeff945e3e12a (osmo-ttcn3-hacks) Related: SYS#4878 Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c 3 files changed, 202 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/26142/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:40:10 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:40:10 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 to look at the new patch set (#6). Change subject: refactor lchan counting ...................................................................... refactor lchan counting Add chan_counts_for_trx() and chan_counts_for_bts(). Drop bts_count_free_ts() and trx_count_free_ts(). Rationale: The bts_count_free_ts() and trx_count_free_ts() always returned the number of free lchans, not timeslots. Hence, passing the pchan type as argument never really matched the semantics. Especially, when looking for free SDCCH, there is no clear match on a gsm_phys_chan_config enum value: SDCCH8_SACCH8C, CCCH_SDCCH4, CCCH_SDCCH4_CBCH, SDCCH8_SACCH8C_CBCH? -- GSM_LCHAN_SDCCH is clear. ==> Rather count free lchans by enum gsm_chan_t. Counting lchans of distinct types required separate iterations for each lchan type. ==> Rather compose an array of counts for all types, in one go. I need to count the amount of free SDCCH lchans in an upcoming patch to implement the performance indicator allAvailableAllocatedSDCCH (cumulate time for which no SDCCH are available). To implement allAvailableAllocated{SDCCH,TCH}, I need a count of both the used as well as the total lchans for a type: it does not make sense to flag "all available allocated" if none are ever available. To properly count dynamic ts, I need the maximum total that can be possible at any time. And to count currently free lchans, I need the current total. This may seem counter intuitive, but consider, e.g.: - Obviously, if a cell has only static TCH/F timeslots, it does not make sense to flag that all available TCH/H are occupied, because no TCH/H are available ever. Just stating this as contrast to dyn TS. - If a cell has OSMO_DYN timeslots, I *do* want to flag that all TCH/H are occupied when all dyn timeslots are fully occupied. - If those OSMO_DYN however are all used as TCH/F, the current total of TCH/H becomes zero, and it seems like TCH/H should not be considered. - To count the nr of currently free lchans, I need the currently possible total of lchans and the nr of occupied lchans. So return both a maximum total and a current total of lchans. In above example, the maximum total shows that there would be TCH/H possible. BTW, it would be nice to keep a chan_counts array on trx, bts and bsc level and update as channels are allocated and released, instead of counting them all over periodically. But it's less error prone this way. Related: SYS#4878 Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/bts_trx.h A include/osmocom/bsc/chan_counts.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx.c A src/osmo-bsc/chan_counts.c M src/osmo-bsc/handover_decision_2.c 10 files changed, 219 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/25972/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:42:26 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:42:26 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 to look at the new patch set (#7). Change subject: refactor lchan counting ...................................................................... refactor lchan counting Add chan_counts_for_trx() and chan_counts_for_bts(). Drop bts_count_free_ts() and trx_count_free_ts(). Rationale: The bts_count_free_ts() and trx_count_free_ts() always returned the number of free lchans, not timeslots. Hence, passing the pchan type as argument never really matched the semantics. Especially, when looking for free SDCCH, there is no clear match on a gsm_phys_chan_config enum value: SDCCH8_SACCH8C, CCCH_SDCCH4, CCCH_SDCCH4_CBCH, SDCCH8_SACCH8C_CBCH? -- GSM_LCHAN_SDCCH is clear. ==> Rather count free lchans by enum gsm_chan_t. Counting lchans of distinct types required separate iterations for each lchan type. ==> Rather compose an array of counts for all types, in one go. I need to count the amount of free SDCCH lchans in an upcoming patch to implement the performance indicator allAvailableAllocatedSDCCH (cumulate time for which no SDCCH are available). To implement allAvailableAllocated{SDCCH,TCH}, I need a count of both the used as well as the total lchans for a type: it does not make sense to flag "all available allocated" if none are ever available. To properly count dynamic ts, I need the maximum total that can be possible at any time. And to count currently free lchans, I need the current total. This may seem counter intuitive, but consider, e.g.: - Obviously, if a cell has only static TCH/F timeslots, it does not make sense to flag that all available TCH/H are occupied, because no TCH/H are available ever. Just stating this as contrast to dyn TS. - If a cell has OSMO_DYN timeslots, I *do* want to flag that all TCH/H are occupied when all dyn timeslots are fully occupied. - If those OSMO_DYN however are all used as TCH/F, the current total of TCH/H becomes zero, and it seems like TCH/H should not be considered. - To count the nr of currently free lchans, I need the currently possible total of lchans and the nr of occupied lchans. So return both a maximum total and a current total of lchans. In above example, the maximum total shows that there would be TCH/H possible. BTW, it would be nice to keep a chan_counts array on trx, bts and bsc level and update as channels are allocated and released, instead of counting them all over periodically. But it's less error prone this way. Related: SYS#4878 Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/bts_trx.h A include/osmocom/bsc/chan_counts.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx.c A src/osmo-bsc/chan_counts.c M src/osmo-bsc/handover_decision_2.c 10 files changed, 238 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/25972/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:43:14 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:43:14 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 7: Code-Review+1 accidentally pushed a previous patch version; re-adding the +1 from patch set 5, because 7 is identical -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 14:43:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:48:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 14:48:03 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26142 ) Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 14:48:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:52:35 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:52:35 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 to look at the new patch set (#6). Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... implement all_allocated:{sdcch,tch} rate counters Based on allAvailable{SDCCH,TCH}Allocated performance indicators, see 3GPP TS 52.402. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/net_init.c 8 files changed, 131 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/25974/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:52:35 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:52:35 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{static_sdcch, static_tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25975 to look at the new patch set (#6). Change subject: implement all_allocated:{static_sdcch,static_tch} rate counters ...................................................................... implement all_allocated:{static_sdcch,static_tch} rate counters Same as all_allocated:{sdcch,tch}, but already trigger when all non-dynamic timeslots are allocated. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I2fa14531f16d3f07085620f1c50eb839c420da6a --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c 6 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/25975/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fa14531f16d3f07085620f1c50eb839c420da6a Gerrit-Change-Number: 25975 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:54:54 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:54:54 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: reduce verbosity of the OML logging In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26138 ) Change subject: ipaccess-config: reduce verbosity of the OML logging ...................................................................... Patch Set 2: Code-Review+1 in general, a main program's default should not be DEBUG -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e Gerrit-Change-Number: 26138 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 14:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:56:53 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:56:53 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: do not pass lchan to print_meas_rep_buf() In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26145 ) Change subject: abis_rsl: do not pass lchan to print_meas_rep_buf() ...................................................................... Patch Set 1: Code-Review+2 ok, whatever? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If965c7dc6b989ee758ddec0190ec1cce8363b240 Gerrit-Change-Number: 26145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 14:56:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:57:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:57:36 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: print_meas_rep_{buf, uni}() accept const *mr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26146 ) Change subject: abis_rsl: print_meas_rep_{buf,uni}() accept const *mr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c3e27a00cd84f102558499072965ec538f5a87f Gerrit-Change-Number: 26146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 14:57:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 14:58:15 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 14:58:15 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: warn about unknown flag name In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26148 ) Change subject: ipaccess-config: warn about unknown flag name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab3bae3af9e1cac992b1f8947cda25fcff647992 Gerrit-Change-Number: 26148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 14:58:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:00:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:00:49 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 1: in patches like this, it would be nice to see an example of the resulting change in the commit log -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:00:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:04:05 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:04:05 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 1: Code-Review+1 if it doesn't break operation of OGT, then fine. OTOH why spend time on these cosmetics despite "never change a running system" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 15:04:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:05:41 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:05:41 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 1: Code-Review+1 ok if it works... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 15:05:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:06:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:06:49 +0000 Subject: Change in osmo-pcu[master]: tbf: Increase log level of line about unable to allocate poll for TBF In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26151 ) Change subject: tbf: Increase log level of line about unable to allocate poll for TBF ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0bd972d3b68017f12a0816a27162e3a409b1893a Gerrit-Change-Number: 26151 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:06:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:10:02 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:10:02 +0000 Subject: Change in osmo-pcu[master]: pdch: Improve log line and increase log level In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26152 ) Change subject: pdch: Improve log line and increase log level ...................................................................... Patch Set 2: Code-Review+1 are you sure NOTICE isn't too aggressive? how often does this occur / how normal is this? If it occurs for a normal situation like currently no bandwidth available, then it may be hard for the user to silence these messages without missing higher level NOTICE messages? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie593331a69f6b8ec3b21e2b274a1aa060b2dc439 Gerrit-Change-Number: 26152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:10:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:14:00 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:14:00 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Set first_(common_)ts in handle_tbf_reject In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26154 ) Change subject: tbf_ul: Set first_(common_)ts in handle_tbf_reject ...................................................................... Patch Set 1: Code-Review+1 i don't understand, but if fixeria agrees... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e Gerrit-Change-Number: 26154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:15:37 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:15:37 +0000 Subject: Change in osmo-pcu[master]: tbf: Set m_created_ts in constructor In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26155 ) Change subject: tbf: Set m_created_ts in constructor ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2966ec7f3f9161d528a173d94797b72d1398c747 Gerrit-Change-Number: 26155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:15:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:16:35 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:16:35 +0000 Subject: Change in osmo-pcu[master]: tbf: Mark initial first_(common_)ts with special value In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26156 ) Change subject: tbf: Mark initial first_(common_)ts with special value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e Gerrit-Change-Number: 26156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:16:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:17:30 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:17:30 +0000 Subject: Change in osmo-pcu[master]: tbf: Set tfi to initial special value In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26157 ) Change subject: tbf: Set tfi to initial special value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iecf54a24041bd14f4ef5b86e57c3732e1b69d463 Gerrit-Change-Number: 26157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:17:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:25:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:25:42 +0000 Subject: Change in osmo-pcu[master]: pdch: Improve log line and increase log level In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26152 ) Change subject: pdch: Improve log line and increase log level ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie593331a69f6b8ec3b21e2b274a1aa060b2dc439 Gerrit-Change-Number: 26152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 15:25:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:25:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:25:45 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Set first_(common_)ts in handle_tbf_reject In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26154 ) Change subject: tbf_ul: Set first_(common_)ts in handle_tbf_reject ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e Gerrit-Change-Number: 26154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 15:25:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:26:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:26:17 +0000 Subject: Change in osmo-pcu[master]: tbf: Increase log level of line about unable to allocate poll for TBF In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26151 ) Change subject: tbf: Increase log level of line about unable to allocate poll for TBF ...................................................................... tbf: Increase log level of line about unable to allocate poll for TBF Change-Id: I0bd972d3b68017f12a0816a27162e3a409b1893a --- M src/tbf.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf.cpp b/src/tbf.cpp index 07732dc..2d6139b 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -524,7 +524,7 @@ } if ((rc = pdch_ulc_get_next_free_rrbp_fn(trx->pdch[ts].ulc, fn, poll_fn_, rrbp_)) < 0) { - LOGPTBF(this, LOGL_DEBUG, + LOGPTBF(this, LOGL_NOTICE, "(bts=%u,trx=%u,ts=%u) FN=%u No suitable free RRBP offset found!\n", trx->bts->nr, trx->trx_no, ts, fn); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0bd972d3b68017f12a0816a27162e3a409b1893a Gerrit-Change-Number: 26151 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:26:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:26:18 +0000 Subject: Change in osmo-pcu[master]: pdch: Improve log line and increase log level In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26152 ) Change subject: pdch: Improve log line and increase log level ...................................................................... pdch: Improve log line and increase log level Change-Id: Ie593331a69f6b8ec3b21e2b274a1aa060b2dc439 --- M src/pdch.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/pdch.cpp b/src/pdch.cpp index 5d8658a..ddad020 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -126,7 +126,7 @@ LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we provide one:\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS, NULL); } else { - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we packet access reject:\n"); + LOGP(DRLCMAC, LOGL_NOTICE, "MS requests UL TBF in ack message, but alloc failed: send PktAssRej\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS_REJ, NULL); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie593331a69f6b8ec3b21e2b274a1aa060b2dc439 Gerrit-Change-Number: 26152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:26:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:26:18 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Set first_(common_)ts in handle_tbf_reject In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26154 ) Change subject: tbf_ul: Set first_(common_)ts in handle_tbf_reject ...................................................................... tbf_ul: Set first_(common_)ts in handle_tbf_reject Let's set them to match expectancies for this type of dummy TBFs, in order to avoid acidental use/access of other timeslots to the one where the reject was associated to. Also use tbf_assign_control_ts() to log the TS used for the TBF, similar to what's used in other places where control_ts is assigned. Related: OS#5293 Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e --- M src/tbf_ul.cpp M tests/tbf/TbfTest.err 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index d6936e1..ca929ea 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -204,8 +204,11 @@ talloc_set_destructor(ul_tbf, ul_tbf_dtor); new (ul_tbf) gprs_rlcmac_ul_tbf(bts, ms); - ul_tbf->control_ts = ts; ul_tbf->trx = trx; + /* The only one TS is the common, control TS */ + ul_tbf->first_ts = ts; + ul_tbf->first_common_ts = ts; + tbf_assign_control_ts(ul_tbf); ul_tbf->m_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ctrg_desc, next_tbf_ctr_group_id++); ul_tbf->m_ul_egprs_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ul_egprs_ctrg_desc, diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index a8fd741..0374f57 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -9076,6 +9076,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated +TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] @@ -9106,6 +9107,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated +TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e Gerrit-Change-Number: 26154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:26:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:26:19 +0000 Subject: Change in osmo-pcu[master]: tbf: Set m_created_ts in constructor In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26155 ) Change subject: tbf: Set m_created_ts in constructor ...................................................................... tbf: Set m_created_ts in constructor This way the timestamp is also set for dummy reject TBFs. For other TBFs, setup() is called immediatelly after calling the constructor, so we are fine too. Change-Id: I2966ec7f3f9161d528a173d94797b72d1398c747 --- M src/tbf.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf.cpp b/src/tbf.cpp index 2d6139b..4bd87dd 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -137,6 +137,8 @@ m_llc.init(); m_name_buf[0] = '\0'; + + m_created_ts = time(NULL); } @@ -657,7 +659,6 @@ if (ms_mode(m_ms) != GPRS) enable_egprs(); - m_created_ts = time(NULL); /* select algorithm */ rc = the_pcu->alloc_algorithm(bts, this, single_slot, use_trx); /* if no resource */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2966ec7f3f9161d528a173d94797b72d1398c747 Gerrit-Change-Number: 26155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:26:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:26:19 +0000 Subject: Change in osmo-pcu[master]: tbf: Mark initial first_(common_)ts with special value In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26156 ) Change subject: tbf: Mark initial first_(common_)ts with special value ...................................................................... tbf: Mark initial first_(common_)ts with special value This way it's easier to distinguish when this value was not properly filled when debugging or looking at logs. Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e --- M src/tbf.cpp M src/tbf.h 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf.cpp b/src/tbf.cpp index 4bd87dd..bdba2e7 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -94,9 +94,9 @@ gprs_rlcmac_tbf::gprs_rlcmac_tbf(struct gprs_rlcmac_bts *bts_, GprsMs *ms, gprs_rlcmac_tbf_direction dir) : direction(dir), trx(NULL), - first_ts(0), - first_common_ts(0), - control_ts(TBF_CONTROL_TS_UNSET), + first_ts(TBF_TS_UNSET), + first_common_ts(TBF_TS_UNSET), + control_ts(TBF_TS_UNSET), fT(0), num_fT_exp(0), upgrade_to_multislot(false), @@ -251,7 +251,7 @@ * confirmation from the MS and goes through the FLOW state. Hence, we * may have ULC pollings ongoing and we need to make sure we drop all * reserved nodes there: */ - if (tbf->control_ts != TBF_CONTROL_TS_UNSET && !tbf->pdch[tbf->control_ts]) + if (tbf->control_ts != TBF_TS_UNSET && !tbf->pdch[tbf->control_ts]) pdch_ulc_release_tbf(tbf->trx->pdch[tbf->control_ts].ulc, tbf); /* Now simply detach from all attached PDCHs */ @@ -340,7 +340,7 @@ void tbf_assign_control_ts(struct gprs_rlcmac_tbf *tbf) { - if (tbf->control_ts == TBF_CONTROL_TS_UNSET) + if (tbf->control_ts == TBF_TS_UNSET) LOGPTBF(tbf, LOGL_INFO, "Setting Control TS %d\n", tbf->first_common_ts); else if (tbf->control_ts != tbf->first_common_ts) diff --git a/src/tbf.h b/src/tbf.h index 4013ab0..4652d95 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -116,7 +116,7 @@ #define GPRS_RLCMAC_FLAG_TO_DL_ACK 3 /* DL TBF: Failed to receive last polled DL ACK/NACK */ #define GPRS_RLCMAC_FLAG_TO_MASK 0xf0 /* timeout bits */ -#define TBF_CONTROL_TS_UNSET 0xff +#define TBF_TS_UNSET 0xff #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0c9c9fdcfca9eb15125ea49efcbb76711850052e Gerrit-Change-Number: 26156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:26:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:26:19 +0000 Subject: Change in osmo-pcu[master]: tbf: Set tfi to initial special value In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26157 ) Change subject: tbf: Set tfi to initial special value ...................................................................... tbf: Set tfi to initial special value This allows distinguishing when a TBF didn't set the TFI. Useful to identify dummy reject TBFs, etc, and make sure a non-dummy TBF set its TFI properly. Change-Id: Iecf54a24041bd14f4ef5b86e57c3732e1b69d463 --- M src/tbf.cpp M src/tbf.h M tests/alloc/AllocTest.err M tests/ms/MsTest.err M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 6 files changed, 99 insertions(+), 97 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/tbf.cpp b/src/tbf.cpp index bdba2e7..4b78595 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -101,7 +101,7 @@ num_fT_exp(0), upgrade_to_multislot(false), bts(bts_), - m_tfi(0), + m_tfi(TBF_TFI_UNSET), m_created_ts(0), m_ctrs(NULL), m_ms(ms), @@ -719,9 +719,10 @@ const char *gprs_rlcmac_tbf::name() const { + int8_t tfi = m_tfi == TBF_TS_UNSET ? -1 : m_tfi; snprintf(m_name_buf, sizeof(m_name_buf) - 1, "TBF(TFI=%d TLLI=0x%08x DIR=%s STATE=%s%s)", - m_tfi, tlli(), + tfi, tlli(), direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", state_name(), is_egprs_enabled() ? " EGPRS" : "" diff --git a/src/tbf.h b/src/tbf.h index 4652d95..9ce1813 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -117,6 +117,7 @@ #define GPRS_RLCMAC_FLAG_TO_MASK 0xf0 /* timeout bits */ #define TBF_TS_UNSET 0xff +#define TBF_TFI_UNSET 0xff #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__) diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err index 1ca4b3b..cb98332 100644 --- a/tests/alloc/AllocTest.err +++ b/tests/alloc/AllocTest.err @@ -389,7 +389,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -748,7 +748,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -1595,7 +1595,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -2294,7 +2294,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -474805,7 +474805,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -474994,7 +474994,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475183,7 +475183,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475468,7 +475468,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475681,7 +475681,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -475895,7 +475895,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -476330,7 +476330,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -476529,7 +476529,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -476729,7 +476729,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -479307,7 +479307,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -479836,7 +479836,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: 0). [DL] algo B (suggested TRX: 0): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -481537,7 +481537,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482112,7 +482112,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482371,7 +482371,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482631,7 +482631,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482854,7 +482854,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -482953,7 +482953,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -483095,7 +483095,7 @@ DL_ASS_TBF{NONE}: Allocated No USF available [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -484069,7 +484069,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -484272,7 +484272,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: -1). [DL] algo B (suggested TRX: -1): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -484959,7 +484959,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -487533,7 +487533,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -487753,7 +487753,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xc0000023 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xc0000023 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -491263,7 +491263,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -493033,7 +493033,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -493563,7 +493563,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: 0). [DL] algo B (suggested TRX: 0): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -493679,7 +493679,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated No USF available -TBF(TFI=0 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -494436,7 +494436,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: 0). [DL] algo B (suggested TRX: 0): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -494803,7 +494803,7 @@ DL_ASS_TBF{NONE}: Allocated No TFI available (suggested TRX: -1). [DL] algo B (suggested TRX: -1): failed to allocate a TFI -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -496297,7 +496297,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -496409,7 +496409,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xc0000011 DIR=UL STATE=NEW) Timeslot Allocation failed: trx = 0, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -499422,7 +499422,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [UL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -501192,7 +501192,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 +TBF(TFI=-1 TLLI=0xffffffff DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 0 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated diff --git a/tests/ms/MsTest.err b/tests/ms/MsTest.err index 6adbfc4..d4895b9 100644 --- a/tests/ms/MsTest.err +++ b/tests/ms/MsTest.err @@ -1,22 +1,22 @@ Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xaa000000 Modifying MS object, UL TLLI: 0xaa000000 -> 0xff001111, not yet confirmed @@ -41,21 +41,21 @@ Creating MS object, TLLI = 0xffffffff Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddbc, not yet confirmed Modifying MS object, TLLI = 0xffeeddbc, IMSI '' -> '001001987654322' -MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=001001987654321, TA=220, 0/0,) Destroying MS object -MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) MS(TLLI=0xffeeddbc, IMSI=001001987654322, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=UL STATE=NEW) -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, UL) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0, DL) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=UL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Release timer expired MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Destroying MS object Creating MS object, TLLI = 0xffeeddbb -MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xffeeddbb DIR=DL STATE=NEW) +MS(TLLI=0xffeeddbb, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0xffeeddbb DIR=DL STATE=NEW) Creating MS object, TLLI = 0xdeadbeef Creating MS object, TLLI = 0xdeadbef0 -MS(TLLI=0xdeadbef0, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xdeadbef0 DIR=DL STATE=NEW) +MS(TLLI=0xdeadbef0, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0xdeadbef0 DIR=DL STATE=NEW) diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 0374f57..7d2d534 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1601,7 +1601,7 @@ DL_ASS_TBF{NONE}: Allocated [DL] algo A (suggested TRX: -1): Alloc start [DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI exhausted) -TBF(TFI=0 TLLI=0xc0000020 DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 +TBF(TFI=-1 TLLI=0xc0000020 DIR=DL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated DL_ASS_TBF{NONE}: Deallocated @@ -7320,7 +7320,7 @@ - Skipping TS 6, because not enabled - Skipping TS 7, because no USF available [UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 +TBF(TFI=-1 TLLI=0xffffffff DIR=UL STATE=NEW) Timeslot Allocation failed: trx = -1, single_slot = 1 UL_ACK_TBF{NONE}: Deallocated TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated @@ -9066,7 +9066,7 @@ - Skipping TS 6, because not enabled - Skipping TS 7, because no USF available [UL] algo A (suggested TRX: 0): failed to allocate a TS, no USF available -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW EGPRS) Timeslot Allocation failed: trx = 0, single_slot = 0 +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW EGPRS) Timeslot Allocation failed: trx = 0, single_slot = 0 UL_ACK_TBF{NONE}: Deallocated TBF{NEW}: Deallocated UL_ASS_TBF{NONE}: Deallocated @@ -9076,12 +9076,12 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 -MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 +MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] TBF{NEW}: state_chg to ASSIGN -TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec +TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ PDCH(bts=0,trx=0,ts=7) Expiring FN=82 but previous FN=2654231 is still reserved! @@ -9107,21 +9107,21 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 -MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 +MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] TBF{NEW}: state_chg to ASSIGN -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ UL_ASS_TBF{SEND_ASS_REJ}: Received Event CREATE_RLCMAC_MSG UL_ASS_TBF{SEND_ASS_REJ}: state_chg to NONE -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) starting timer X2000 [reject (PACCH)] with 0 sec. 0 microsec -PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) starting timer X2000 [reject (PACCH)] with 0 sec. 0 microsec +PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) UL_ASS_TBF{NONE}: Timeout of X2000 -TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) free -MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) +TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) free +MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Destroying MS object ********** UL-TBF ends here ********** UL_ACK_TBF{NONE}: Deallocated diff --git a/tests/ulc/PdchUlcTest.err b/tests/ulc/PdchUlcTest.err index d122f31..411c3f3 100644 --- a/tests/ulc/PdchUlcTest.err +++ b/tests/ulc/PdchUlcTest.err @@ -5,42 +5,42 @@ PDCH(bts=0,trx=0,ts=0) Trying to release unregistered SBA (FN=78, TA=0) PDCH(bts=0,trx=0,ts=0) Timeout for registered SBA (FN=72, TA=0) Creating MS object, TLLI = 0x12345678 -MS(TLLI=0x12345678, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +MS(TLLI=0x12345678, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=2715613 but previous FN=2715608 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715608, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715613, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715608, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715613, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715617 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715617, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715617, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715622 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715622, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715622, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715626 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715626, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715626, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715630 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715630, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715630, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715635 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715635, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715635, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715639 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715639, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715639, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=2715643 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715643, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=2715643, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=4 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=4, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=4, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=8 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=8, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=8, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=13 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=13, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=13, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=17 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=17, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=17, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=21 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=21, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=21, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=26 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=26, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=26, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=30 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=30, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=30, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=34 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=34, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=34, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=39 is still reserved! -PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=39, reason=UL_ASS): TBF(TFI=0 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=39, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 26 + 13 = 39 PDCH(bts=0,trx=0,ts=0) UL block already scheduled at FN 91 + 13 = 104 PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 91 + 17 = 108 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iecf54a24041bd14f4ef5b86e57c3732e1b69d463 Gerrit-Change-Number: 26157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:26:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:26:50 +0000 Subject: Change in osmo-pcu[master]: bts: Add counters for successful 1, 2 phase pkt access In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26077 ) Change subject: bts: Add counters for successful 1,2 phase pkt access ...................................................................... bts: Add counters for successful 1,2 phase pkt access These counters relate to succPDTCHAssProcsPerCause (B.2.1.50 Successful Packet Channel Assignment Procedures, per cause). Related: SYS#4878 Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 --- M src/bts.cpp M src/bts.h 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 6ef3280..d053396 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -145,6 +145,8 @@ { "spb:downlink_first_segment", "First seg of DL SPB "}, { "spb:downlink_second_segment","Second seg of DL SPB "}, { "immediate:assignment_UL", "Immediate Assign UL "}, + { "immediate:assignment_ul:one_phase", "Immediate Assign UL (one phase packet access)"}, /* TS 52.402 B.2.1.50 */ + { "immediate:assignment_ul:two_phase", "Immediate Assign UL (two phase packet access)"}, /* TS 52.402 B.2.1.50 */ { "immediate:assignment_rej", "Immediate Assign Rej "}, { "immediate:assignment_DL", "Immediate Assign DL "}, { "channel:request_description","Channel Request Desc "}, @@ -937,6 +939,7 @@ sb_fn = sba->fn; LOGP(DRLCMAC, LOGL_DEBUG, "Allocated a single block at " "SBFn=%u TRX=%u TS=%u\n", sb_fn, pdch->trx->trx_no, pdch->ts_no); + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_TWO_PHASE); } else { GprsMs *ms = bts_alloc_ms(bts, 0, chan_req.egprs_mslot_class); tbf = tbf_alloc_ul_ccch(bts, ms); @@ -948,6 +951,7 @@ tbf->set_ta(ta); pdch = &tbf->trx->pdch[tbf->first_ts]; usf = tbf->m_usf[pdch->ts_no]; + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_ONE_PHASE); } trx = pdch->trx; diff --git a/src/bts.h b/src/bts.h index fa3216f..d0119b6 100644 --- a/src/bts.h +++ b/src/bts.h @@ -137,6 +137,8 @@ CTR_SPB_DL_FIRST_SEGMENT, CTR_SPB_DL_SECOND_SEGMENT, CTR_IMMEDIATE_ASSIGN_UL_TBF, + CTR_IMMEDIATE_ASSIGN_UL_TBF_ONE_PHASE, + CTR_IMMEDIATE_ASSIGN_UL_TBF_TWO_PHASE, CTR_IMMEDIATE_ASSIGN_REJ, CTR_IMMEDIATE_ASSIGN_DL_TBF, CTR_CHANNEL_REQUEST_DESCRIPTION, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 Gerrit-Change-Number: 26077 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:29:31 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 15:29:31 +0000 Subject: Change in pysim[master]: pySim-shell: add method to probe for UICC In-Reply-To: References: Message-ID: dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Abandoned I have now implemented it differently. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:31:22 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:31:22 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Update FSM names for dummy reject TBFs In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26158 ) Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26158/1/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26158/1/src/tbf.cpp at 737 PS1, Line 737: int8_t tfi = tbf_tfi(tbf) == TBF_TS_UNSET ? -1 : tbf_tfi(tbf); i'd prefer aggressive bracing in compounded statements like this. more often than not, these do unexpected stuff because of omitted braces. at least for (y == z), to make sure it isn't interpreted as x = (y == (z ? 1 : 2)) Bugs like this are quite hard to find, seen it happen. or even x = ((y == z) ? 1 : 2) (also makes it easier to read IMHO.) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:31:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:34:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:34:19 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Update FSM names for dummy reject TBFs In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 to look at the new patch set (#2). Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... tbf_ul: Update FSM names for dummy reject TBFs This allows easily identifying dummt TBFs created to send assignment rejects. Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 --- M src/tbf.cpp M src/tbf_ul.cpp M tests/tbf/TbfTest.err 3 files changed, 18 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/58/26158/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:34:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 15:34:19 +0000 Subject: Change in osmo-pcu[master]: cosmetic: Add parenthesis around expression to clarify it References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26159 ) Change subject: cosmetic: Add parenthesis around expression to clarify it ...................................................................... cosmetic: Add parenthesis around expression to clarify it Change-Id: I621ef02868aff2bd23d82c8bc70e5cdbc391fbc2 --- M src/tbf.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/59/26159/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 99d1018..0b02623 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -719,7 +719,7 @@ const char *gprs_rlcmac_tbf::name() const { - int8_t tfi = m_tfi == TBF_TS_UNSET ? -1 : m_tfi; + int8_t tfi = (m_tfi == TBF_TS_UNSET) ? -1 : m_tfi; snprintf(m_name_buf, sizeof(m_name_buf) - 1, "TBF(TFI=%d TLLI=0x%08x DIR=%s STATE=%s%s)", tfi, tlli(), -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I621ef02868aff2bd23d82c8bc70e5cdbc391fbc2 Gerrit-Change-Number: 26159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:37:56 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:37:56 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c at 602 PS5, Line 602: ) p usually no space after type cast https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c at 605 PS5, Line 605: bts->interference.band_map[i] = 6 - i; i'm a bit confused by '5 - i' vs '6 - i' https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c at 608 PS5, Line 608: bts->interference.band_map[i] = i; ...especially because there is no diff-by-one involved here -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:37:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:41:52 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 15:41:52 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: permit simultaneous ACCH repetition and overpower In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26144 ) Change subject: abis_rsl: permit simultaneous ACCH repetition and overpower ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26144/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26144/1/src/osmo-bsc/abis_rsl.c at 566 PS1, Line 566: (void *)&bts->temporary_overpower); orthogonal to this patch, but if the MS indicates no support for repeated ACCH in cm3, should we make sure to not enable that? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Gerrit-Change-Number: 26144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 15:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:46:24 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 15:46:24 +0000 Subject: Change in pysim[master]: ts_102_221: put select response decoder into separate file References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26160 ) Change subject: ts_102_221: put select response decoder into separate file ...................................................................... ts_102_221: put select response decoder into separate file The decoder function that decodes the select response has become more and more complex over time, so it makes sense to put the code into a separate file, lets also mark the functions we only call from inside the decoder as private. This makes the code more readable and also helps to prevent circular dependencies. Change-Id: If5fae46bb40d0f285236a6ab287070125c69ed70 --- M pySim/ts_102_221.py A pySim/ts_102_221_select.py M pySim/ts_31_102.py M pySim/ts_31_103.py M pySim/ts_51_011.py 5 files changed, 182 insertions(+), 155 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/26160/1 diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 3665939..8b1f7da 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -17,7 +17,7 @@ along with this program. If not, see . """ -from pytlv.TLV import * +#from pytlv.TLV import * from construct import * from pySim.construct import * from pySim.utils import * @@ -70,138 +70,11 @@ ]) -FCP_TLV_MAP = { - '82': 'file_descriptor', - '83': 'file_identifier', - '84': 'df_name', - 'A5': 'proprietary_info', - '8A': 'life_cycle_status_int', - '8B': 'security_attrib_ref_expanded', - '8C': 'security_attrib_compact', - 'AB': 'security_attrib_espanded', - 'C6': 'pin_status_template_do', - '80': 'file_size', - '81': 'total_file_size', - '88': 'short_file_id', - } - -# ETSI TS 102 221 11.1.1.4.6 -FCP_Proprietary_TLV_MAP = { - '80': 'uicc_characteristics', - '81': 'application_power_consumption', - '82': 'minimum_app_clock_freq', - '83': 'available_memory', - '84': 'file_details', - '85': 'reserved_file_size', - '86': 'maximum_file_size', - '87': 'suported_system_commands', - '88': 'specific_uicc_env_cond', - '89': 'p2p_cat_secured_apdu', - # Additional private TLV objects (bits b7 and b8 of the first byte of the tag set to '1') - } - -# ETSI TS 102 221 11.1.1.4.3 -def interpret_file_descriptor(in_hex): - in_bin = h2b(in_hex) - out = {} - ft_dict = { - 0: 'working_ef', - 1: 'internal_ef', - 7: 'df' - } - fs_dict = { - 0: 'no_info_given', - 1: 'transparent', - 2: 'linear_fixed', - 6: 'cyclic', - 0x39: 'ber_tlv', - } - fdb = in_bin[0] - ftype = (fdb >> 3) & 7 - if fdb & 0xbf == 0x39: - fstruct = 0x39 - else: - fstruct = fdb & 7 - out['shareable'] = True if fdb & 0x40 else False - out['file_type'] = ft_dict[ftype] if ftype in ft_dict else ftype - out['structure'] = fs_dict[fstruct] if fstruct in fs_dict else fstruct - if len(in_bin) >= 5: - out['record_len'] = int.from_bytes(in_bin[2:4], 'big') - out['num_of_rec'] = int.from_bytes(in_bin[4:5], 'big') - return out - -# ETSI TS 102 221 11.1.1.4.9 -def interpret_life_cycle_sts_int(in_hex): - lcsi = int(in_hex, 16) - if lcsi == 0x00: - return 'no_information' - elif lcsi == 0x01: - return 'creation' - elif lcsi == 0x03: - return 'initialization' - elif lcsi & 0x05 == 0x05: - return 'operational_activated' - elif lcsi & 0x05 == 0x04: - return 'operational_deactivated' - elif lcsi & 0xc0 == 0xc0: - return 'termination' - else: - return in_hex - -# ETSI TS 102 221 11.1.1.4.10 -FCP_Pin_Status_TLV_MAP = { - '90': 'ps_do', - '95': 'usage_qualifier', - '83': 'key_reference', - } - -def interpret_ps_templ_do(in_hex): - # cannot use the 'TLV' parser due to repeating tags - #psdo_tlv = TLV(FCP_Pin_Status_TLV_MAP) - #return psdo_tlv.parse(in_hex) - return in_hex - -# 'interpreter' functions for each tag -FCP_interpreter_map = { - '80': lambda x: int(x, 16), - '82': interpret_file_descriptor, - '8A': interpret_life_cycle_sts_int, - 'C6': interpret_ps_templ_do, - } - -FCP_prorietary_interpreter_map = { - '83': lambda x: int(x, 16), - } - -# pytlv unfortunately doesn't have a setting using which we can make it -# accept unknown tags. It also doesn't raise a specific exception type but -# just the generic ValueError, so we cannot ignore those either. Instead, -# we insert a dict entry for every possible proprietary tag permitted -def fixup_fcp_proprietary_tlv_map(tlv_map): - if 'D0' in tlv_map: - return - for i in range(0xc0, 0xff): - i_hex = i2h([i]).upper() - tlv_map[i_hex] = 'proprietary_' + i_hex - # Other non-standard TLV objects found on some cards - tlv_map['9B'] = 'target_ef' # for sysmoUSIM-SJS1 -def tlv_key_replace(inmap, indata): - def newkey(inmap, key): - if key in inmap: - return inmap[key] - else: - return key - return {newkey(inmap, d[0]): d[1] for d in indata.items()} -def tlv_val_interpret(inmap, indata): - def newval(inmap, key, val): - if key in inmap: - return inmap[key](val) - else: - return val - return {d[0]: newval(inmap, d[0], d[1]) for d in indata.items()} + + # ETSI TS 102 221 Section 9.2.7 + ISO7816-4 9.3.3/9.3.4 @@ -466,28 +339,6 @@ SC_DO = DataObjectChoice('security_condition', 'Security Condition', members=[Always_DO, Never_DO, SecCondByte_DO(), SecCondByte_DO(0x9e), CRT_DO()]) - -# ETSI TS 102 221 Section 11.1.1.3 -def decode_select_response(resp_hex): - fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) - resp_hex = resp_hex.upper() - # outer layer - fcp_base_tlv = TLV(['62']) - fcp_base = fcp_base_tlv.parse(resp_hex) - # actual FCP - fcp_tlv = TLV(FCP_TLV_MAP) - fcp = fcp_tlv.parse(fcp_base['62']) - # further decode the proprietary information - if fcp['A5']: - prop_tlv = TLV(FCP_Proprietary_TLV_MAP) - prop = prop_tlv.parse(fcp['A5']) - fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop) - fcp['A5'] = tlv_key_replace(FCP_Proprietary_TLV_MAP, fcp['A5']) - # finally make sure we get human-readable keys in the output dict - r = tlv_val_interpret(FCP_interpreter_map, fcp) - return tlv_key_replace(FCP_TLV_MAP, r) - - # TS 102 221 Section 13.1 class EF_DIR(LinFixedEF): def __init__(self, fid='2f00', sfid=0x1e, name='EF.DIR', desc='Application Directory'): diff --git a/pySim/ts_102_221_select.py b/pySim/ts_102_221_select.py new file mode 100644 index 0000000..74ede38 --- /dev/null +++ b/pySim/ts_102_221_select.py @@ -0,0 +1,173 @@ +# coding=utf-8 +"""Utilities / Functions related to ETSI TS 102 221, section 11.1.1 SELECT. + +(C) 2021 by Harald Welte + +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 2 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see . +""" + +from pySim.utils import i2h, h2b, bertlv_parse_one +from pytlv.TLV import * + +FCP_TLV_MAP = { + '82': 'file_descriptor', + '83': 'file_identifier', + '84': 'df_name', + 'A5': 'proprietary_info', + '8A': 'life_cycle_status_int', + '8B': 'security_attrib_ref_expanded', + '8C': 'security_attrib_compact', + 'AB': 'security_attrib_espanded', + 'C6': 'pin_status_template_do', + '80': 'file_size', + '81': 'total_file_size', + '88': 'short_file_id', + } + +# ETSI TS 102 221 11.1.1.4.6 +FCP_Proprietary_TLV_MAP = { + '80': 'uicc_characteristics', + '81': 'application_power_consumption', + '82': 'minimum_app_clock_freq', + '83': 'available_memory', + '84': 'file_details', + '85': 'reserved_file_size', + '86': 'maximum_file_size', + '87': 'suported_system_commands', + '88': 'specific_uicc_env_cond', + '89': 'p2p_cat_secured_apdu', + # Additional private TLV objects (bits b7 and b8 of the first byte of the tag set to '1') + } + +# ETSI TS 102 221 11.1.1.4.3 +def _interpret_file_descriptor(in_hex): + in_bin = h2b(in_hex) + out = {} + ft_dict = { + 0: 'working_ef', + 1: 'internal_ef', + 7: 'df' + } + fs_dict = { + 0: 'no_info_given', + 1: 'transparent', + 2: 'linear_fixed', + 6: 'cyclic', + 0x39: 'ber_tlv', + } + fdb = in_bin[0] + ftype = (fdb >> 3) & 7 + if fdb & 0xbf == 0x39: + fstruct = 0x39 + else: + fstruct = fdb & 7 + out['shareable'] = True if fdb & 0x40 else False + out['file_type'] = ft_dict[ftype] if ftype in ft_dict else ftype + out['structure'] = fs_dict[fstruct] if fstruct in fs_dict else fstruct + if len(in_bin) >= 5: + out['record_len'] = int.from_bytes(in_bin[2:4], 'big') + out['num_of_rec'] = int.from_bytes(in_bin[4:5], 'big') + return out + +# ETSI TS 102 221 11.1.1.4.9 +def _interpret_life_cycle_sts_int(in_hex): + lcsi = int(in_hex, 16) + if lcsi == 0x00: + return 'no_information' + elif lcsi == 0x01: + return 'creation' + elif lcsi == 0x03: + return 'initialization' + elif lcsi & 0x05 == 0x05: + return 'operational_activated' + elif lcsi & 0x05 == 0x04: + return 'operational_deactivated' + elif lcsi & 0xc0 == 0xc0: + return 'termination' + else: + return in_hex + +# ETSI TS 102 221 11.1.1.4.10 +FCP_Pin_Status_TLV_MAP = { + '90': 'ps_do', + '95': 'usage_qualifier', + '83': 'key_reference', + } + +def _interpret_ps_templ_do(in_hex): + # cannot use the 'TLV' parser due to repeating tags + #psdo_tlv = TLV(FCP_Pin_Status_TLV_MAP) + #return psdo_tlv.parse(in_hex) + return in_hex + +# 'interpreter' functions for each tag +FCP_interpreter_map = { + '80': lambda x: int(x, 16), + '82': _interpret_file_descriptor, + '8A': _interpret_life_cycle_sts_int, + 'C6': _interpret_ps_templ_do, + } + +FCP_prorietary_interpreter_map = { + '83': lambda x: int(x, 16), + } + +# pytlv unfortunately doesn't have a setting using which we can make it +# accept unknown tags. It also doesn't raise a specific exception type but +# just the generic ValueError, so we cannot ignore those either. Instead, +# we insert a dict entry for every possible proprietary tag permitted +def _fixup_fcp_proprietary_tlv_map(tlv_map): + if 'D0' in tlv_map: + return + for i in range(0xc0, 0xff): + i_hex = i2h([i]).upper() + tlv_map[i_hex] = 'proprietary_' + i_hex + # Other non-standard TLV objects found on some cards + tlv_map['9B'] = 'target_ef' # for sysmoUSIM-SJS1 + +def _tlv_key_replace(inmap, indata): + def newkey(inmap, key): + if key in inmap: + return inmap[key] + else: + return key + return {newkey(inmap, d[0]): d[1] for d in indata.items()} + +def _tlv_val_interpret(inmap, indata): + def newval(inmap, key, val): + if key in inmap: + return inmap[key](val) + else: + return val + return {d[0]: newval(inmap, d[0], d[1]) for d in indata.items()} + +# ETSI TS 102 221 Section 11.1.1.3 +def decode_select_response(resp_hex): + _fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) + resp_hex = resp_hex.upper() + # outer layer + fcp_base_tlv = TLV(['62']) + fcp_base = fcp_base_tlv.parse(resp_hex) + # actual FCP + fcp_tlv = TLV(FCP_TLV_MAP) + fcp = fcp_tlv.parse(fcp_base['62']) + # further decode the proprietary information + if fcp['A5']: + prop_tlv = TLV(FCP_Proprietary_TLV_MAP) + prop = prop_tlv.parse(fcp['A5']) + fcp['A5'] = _tlv_val_interpret(FCP_prorietary_interpreter_map, prop) + fcp['A5'] = _tlv_key_replace(FCP_Proprietary_TLV_MAP, fcp['A5']) + # finally make sure we get human-readable keys in the output dict + r = _tlv_val_interpret(FCP_interpreter_map, fcp) + return _tlv_key_replace(FCP_TLV_MAP, r) diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 14d7ec1..83c281c 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -294,6 +294,7 @@ from pySim.ts_51_011 import EF_MMSN, EF_MMSICP, EF_MMSUP, EF_MMSUCP, EF_VGCS, EF_VGCSS, EF_NIA from pySim.ts_51_011 import EF_ACMmax, EF_AAeM, EF_eMLPP, EF_CMI +import pySim.ts_51_011 import pySim.ts_102_221 # 3GPP TS 31.102 Section 4.4.11.4 (EF_5GS3GPPNSC) @@ -1067,7 +1068,7 @@ self.add_files(files) def decode_select_response(self, data_hex): - return pySim.ts_102_221.decode_select_response(data_hex) + return pySim.ts_102_221_select.decode_select_response(data_hex) @with_default_category('Application-Specific Commands') class AddlShellCommands(CommandSet): diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py index 63ef99e..3fd6629 100644 --- a/pySim/ts_31_103.py +++ b/pySim/ts_31_103.py @@ -28,6 +28,7 @@ from pySim.ts_51_011 import EF_AD, EF_SMS, EF_SMSS, EF_SMSR, EF_SMSP from pySim.ts_31_102 import ADF_USIM, EF_FromPreferred import pySim.ts_102_221 +import pySim.ts_102_221_select from pySim.ts_102_221 import EF_ARR # Mapping between ISIM Service Number and its description @@ -213,7 +214,7 @@ self.shell_commands += [ADF_USIM.AddlShellCommands()] def decode_select_response(self, data_hex): - return pySim.ts_102_221.decode_select_response(data_hex) + return pySim.ts_102_221_select.decode_select_response(data_hex) # TS 31.103 Section 7.1 sw_isim = { diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 743c14b..c7168e8 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -333,6 +333,7 @@ from pySim.filesystem import * import pySim.ts_102_221 +import pySim.ts_102_221_select ###################################################################### # DF.TELECOM @@ -942,7 +943,7 @@ def decode_select_response(resp_hex): resp_bin = h2b(resp_hex) if resp_bin[0] == 0x62: - return pySim.ts_102_221.decode_select_response(resp_hex) + return pySim.ts_102_221_select.decode_select_response(resp_hex) struct_of_file_map = { 0: 'transparent', 1: 'linear_fixed', -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If5fae46bb40d0f285236a6ab287070125c69ed70 Gerrit-Change-Number: 26160 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:46:24 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 15:46:24 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26161 ) Change subject: filesystem: fix decode_select_response ...................................................................... filesystem: fix decode_select_response There are some problems with the usage of decode_select_response. At the moment the ADF files overload the related method to provide decoding of the select responses as per 3gpp TS 102 221. However, this also means that the decoder is only available under ADF.USIM and ADF.ISIM. DF.GSM and DF.TELECOM also overload the decoder method, just like an ADF would do. This decoding method is then implemented as per 3gpp TS 51 011. Since this a a problem on UICCs, the method detects the magic byte 0x62 that can be found at the beginning on every select response of an UICC to defer to the TS 102 221 decoding method. TS 51 011 defines the first two bytes of the select response as RFU. This at least problematic. To solve this there should be a default method for decode_select_response in the profile, which can be used if no file overloads it with a specific decoder. ADFs use specific decoders, but everything else should use the default decoder. When we deal with an UICC, we expect the select response to be consistantly conform to TS 102 221, if we deal with a clasic sim we expect responses as per TS 51 011 only. Since it is still possible to replace the select response decoder we still have the opportunity to have custom select response in cartain DFs and ADFs should we need them. Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Related: OS#5274 --- M pySim/filesystem.py M pySim/ts_102_221.py M pySim/ts_51_011.py 3 files changed, 63 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/26161/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index dcc2608..d427ded 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -44,6 +44,9 @@ from pySim.jsonpath import js_path_find, js_path_modify from pySim.commands import SimCardCommands +import pySim.ts_102_221_select +import pySim.ts_51_011 + class CardFile(object): """Base class for all objects in the smart card filesystem. Serve as a common ancestor to all other file types; rarely used directly. @@ -52,7 +55,7 @@ RESERVED_FIDS = ['3f00'] def __init__(self, fid:str=None, sfid:str=None, name:str=None, desc:str=None, - parent:Optional['CardDF']=None): + parent:Optional['CardDF']=None, profile:Optional['CardProfile']=None): """ Args: fid : File Identifier (4 hex digits) @@ -60,6 +63,7 @@ name : Brief name of the file, lik EF_ICCID desc : Description of the file parent : Parent CardFile object within filesystem hierarchy + profile : Card profile that this file should be part of """ if not isinstance(self, CardADF) and fid == None: raise ValueError("fid is mandatory") @@ -72,6 +76,7 @@ self.parent = parent if self.parent and self.parent != self and self.fid: self.parent.add_file(self) + self.profile = profile self.shell_commands = [] # type: List[CommandSet] # Note: the basic properties (fid, name, ect.) are verified when @@ -173,10 +178,34 @@ return list(sels.keys()) def decode_select_response(self, data_hex:str): - """Decode the response to a SELECT command.""" + """Decode the response to a SELECT command. + + Args: + data_hex: Hex string of the select response + """ + + # When the current file does not implement a custom select response decoder, + # we just ask the parent file to decode the select response. If this method + # is not overloaded by the current file we will again ask the parent file. + # This way we recursively travel up the file system tree until we hit a file + # that does implement a concrete decoder. if self.parent: return self.parent.decode_select_response(data_hex) + def get_profile(self): + """Get the profile associated with this file. If this file does not have any + profile assigned, try to find a file above (usually the MF) in the filesystem + hirarchy that has a profile assigned + """ + + # If we have a profile set, return it + if self.profile: + return self.profile + + # Walk up recursively until we hit a parent that has a profile set + if self.parent: + return self.parent.get_profile() + return None class CardDF(CardFile): """DF (Dedicated File) in the smart card filesystem. Those are basically sub-directories.""" @@ -331,12 +360,18 @@ def decode_select_response(self, data_hex:str) -> Any: """Decode the response to a SELECT command. - This is the fall-back method which doesn't perform any decoding. It mostly - exists so specific derived classes can overload it for actual decoding. + This is the fall-back method which automatically defers to the standard decoding + method defined by the card profile. When no profile is set, then no decoding is + performed. Specific derived classes (usually ADF) can overload this method to + install specific decoding. """ - return data_hex + profile = self.get_profile() + if profile: + return profile.decode_select_response(data_hex) + else: + return data_hex class CardADF(CardDF): """ADF (Application Dedicated File) in the smart card filesystem""" @@ -1029,7 +1064,7 @@ card : pysim.cards.Card instance profile : CardProfile instance """ - self.mf = CardMF() + self.mf = CardMF(profile=profile) self.card = card self.selected_file = self.mf # type: CardDF self.profile = profile @@ -1437,6 +1472,19 @@ """ return interpret_sw(self.sw, sw) + def decode_select_response(self, data_hex:str) -> Any: + """Decode the response to a SELECT command. + + This is the fall-back method which doesn't perform any decoding. It mostly + exists so specific derived classes can overload it for actual decoding. + This method is implemented in the profile and is only used when application + specific decoding cannot be performed (no ADF is selected). + + Args: + data_hex: Hex string of the select response + """ + return data_hex + class CardModel(abc.ABC): """A specific card model, typically having some additional vendor-specific files. All diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 8b1f7da..b763f0f 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -535,3 +535,6 @@ } super().__init__('UICC', desc='ETSI TS 102 221', files_in_mf=files, sw=sw) + + def decode_select_response(self, data_hex:str) -> Any: + return pySim.ts_102_221_select.decode_select_response(data_hex) diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index c7168e8..a00cf0d 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -332,8 +332,6 @@ import enum from pySim.filesystem import * -import pySim.ts_102_221 -import pySim.ts_102_221_select ###################################################################### # DF.TELECOM @@ -452,9 +450,6 @@ ] self.add_files(files) - def decode_select_response(self, data_hex): - return decode_select_response(data_hex) - ###################################################################### # DF.GSM ###################################################################### @@ -937,13 +932,11 @@ ] self.add_files(files) - def decode_select_response(self, data_hex): - return decode_select_response(data_hex) -def decode_select_response(resp_hex): + +def _decode_select_response(resp_hex): + resp_bin = h2b(resp_hex) - if resp_bin[0] == 0x62: - return pySim.ts_102_221_select.decode_select_response(resp_hex) struct_of_file_map = { 0: 'transparent', 1: 'linear_fixed', @@ -984,3 +977,6 @@ class CardProfileSIM(CardProfile): def __init__(self): super().__init__('SIM', desc='GSM SIM Card', files_in_mf=[DF_TELECOM(), DF_GSM()]) + + def decode_select_response(self, data_hex:str) -> Any: + return _decode_select_response(data_hex) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:46:25 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 15:46:25 +0000 Subject: Change in pysim[master]: filesystem: do not read AIDs when no apps are defined References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26162 ) Change subject: filesystem: do not read AIDs when no apps are defined ...................................................................... filesystem: do not read AIDs when no apps are defined When the profile does not define any ADFs, then do not try to read any AIDs. This is the case for old non UICC SIMs for example. Change-Id: I8cfbee1d23e9f99461fa5f4fbf92c1a0929c50bf Related: OS#5274 --- M pySim/filesystem.py 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/26162/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index d427ded..0387de2 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1080,6 +1080,13 @@ def _match_applications(self): """match the applications from the profile with applications on the card""" apps_profile = self.profile.applications + + # When the profile does not feature any applications, then we are done already + if not apps_profile: + return [] + + # Read AIDs from card and match them against the applications defined by the + # card profile aids_card = self.card.read_aids() apps_taken = [] if aids_card: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8cfbee1d23e9f99461fa5f4fbf92c1a0929c50bf Gerrit-Change-Number: 26162 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:46:25 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 15:46:25 +0000 Subject: Change in pysim[master]: filesystem: make sure the card is in a defined state References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26163 ) Change subject: filesystem: make sure the card is in a defined state ...................................................................... filesystem: make sure the card is in a defined state When the runtime state is created there is already some interaction with the card. Lets make sure that the card is in a defined state when we leave the constructor of the RuntimeState. Change-Id: I986204964903069bcce781afdbf3c5d26682b749 Related: OS#5274 --- M pySim/filesystem.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/63/26163/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 0387de2..3297858 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1077,6 +1077,10 @@ self.mf.add_file(f) self.conserve_write = True + # make sure that when the runtime state is created, the card is also + # in a defined state. + self.reset() + def _match_applications(self): """match the applications from the profile with applications on the card""" apps_profile = self.profile.applications -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I986204964903069bcce781afdbf3c5d26682b749 Gerrit-Change-Number: 26163 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:46:25 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 15:46:25 +0000 Subject: Change in pysim[master]: filesystem: define class byte and select control bytes in profile References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26164 ) Change subject: filesystem: define class byte and select control bytes in profile ...................................................................... filesystem: define class byte and select control bytes in profile The class byte and the select control bytes are different for SIM cards and UICC cards. Lets define those parameters in the card profile, so that we always get the correct parameters depending on which profile we use. Change-Id: I2d175e28bd748a4871b1373273b3a9be9ae8c4d0 Related: OS#5274 --- M pySim/filesystem.py M pySim/ts_102_221.py M pySim/ts_51_011.py 3 files changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/64/26164/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 3297858..75cd210 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1068,6 +1068,11 @@ self.card = card self.selected_file = self.mf # type: CardDF self.profile = profile + + # make sure the class and selection control bytes, which are specified + # by the card profile are used + self.card.set_apdu_parameter(cla=self.profile.cla, sel_ctrl=self.profile.sel_ctrl) + # add application ADFs + MF-files from profile apps = self._match_applications() for a in apps: @@ -1453,6 +1458,8 @@ applications : List of CardApplications present on card sw : List of status word definitions shell_cmdsets : List of cmd2 shell command sets of profile-specific commands + cla : class byte that should be used with cards of this profile + sel_ctrl : selection control bytes class byte that should be used with cards of this profile """ self.name = name self.desc = kw.get("desc", None) @@ -1460,6 +1467,8 @@ self.sw = kw.get("sw", []) self.applications = kw.get("applications", []) self.shell_cmdsets = kw.get("shell_cmdsets", []) + self.cla = kw.get("cla", "00") + self.sel_ctrl = kw.get("sel_ctrl", "0004") def __str__(self): return self.name diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index b763f0f..f86a8b3 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -534,7 +534,7 @@ }, } - super().__init__('UICC', desc='ETSI TS 102 221', files_in_mf=files, sw=sw) + super().__init__('UICC', desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) def decode_select_response(self, data_hex:str) -> Any: return pySim.ts_102_221_select.decode_select_response(data_hex) diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index a00cf0d..c146a79 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -976,7 +976,6 @@ class CardProfileSIM(CardProfile): def __init__(self): - super().__init__('SIM', desc='GSM SIM Card', files_in_mf=[DF_TELECOM(), DF_GSM()]) - + super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()]) def decode_select_response(self, data_hex:str) -> Any: return _decode_select_response(data_hex) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2d175e28bd748a4871b1373273b3a9be9ae8c4d0 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 15:46:25 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 15:46:25 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 5 files changed, 167 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/1 diff --git a/pySim-shell.py b/pySim-shell.py index 0be6f21..7941329 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -47,6 +47,7 @@ from pySim.filesystem import CardMF, RuntimeState, CardDF, CardADF, CardModel from pySim.ts_51_011 import CardProfileSIM, DF_TELECOM, DF_GSM from pySim.ts_102_221 import CardProfileUICC +from pySim.ts_102_221 import CardProfileUICCSIM from pySim.ts_31_102 import CardApplicationUSIM from pySim.ts_31_103 import CardApplicationISIM from pySim.gsm_r import DF_EIRENE @@ -58,6 +59,8 @@ from pySim.card_key_provider import CardKeyProviderCsv, card_key_provider_register, card_key_provider_get_field +from pySim.profile import profile_detect + def init_card(sl): """ Detect card in reader and setup card profile and runtime state. This @@ -79,18 +82,31 @@ card = card_detect("auto", scc) if card is None: - print("Could not detect card type!") + print("Warning: Could not detect card type - assuming a generic card type...") + card = SimCard(scc) + + profile = profile_detect(scc) + if profile is None: + print("Unsupported card type!") return None, None + print("Info: Card is of type: %s" % str(profile)) + + # FIXME: This shouln't be here, the profile should add the applications, + # however, we cannot simply put his into ts_102_221.py since we would + # have to e.g. import CardApplicationUSIM from ts_31_102.py, which already + # imports from ts_102_221.py. This means we will end up with a circular + # import, which needs to be resolved first. + if type(profile) is CardProfileUICC or type(profile) is CardProfileUICCSIM: + profile.add_application(CardApplicationUSIM()) + profile.add_application(CardApplicationISIM()) + # Create runtime state with card profile - profile = CardProfileUICC() - profile.add_application(CardApplicationUSIM()) - profile.add_application(CardApplicationISIM()) rs = RuntimeState(card, profile) - # FIXME: do this dynamically - rs.mf.add_file(DF_TELECOM()) - rs.mf.add_file(DF_GSM()) + # FIXME: This is an GSM-R related file, it needs to be added throught, + # the profile. At the moment we add it for all cards, this won't hurt, + # but regular SIM and UICC will not have it and fail to select it. rs.mf.add_file(DF_EIRENE()) CardModel.apply_matching_models(scc, rs) diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 75cd210..df99bc7 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1505,6 +1505,21 @@ """ return data_hex + @staticmethod + def match_witch_card(scc:SimCardCommands) -> bool: + """Check if the specific profile matches the card. This method is a + placeholder that is overloaded by specific dirived classes. The method + actively probes the card to make sure the profile class matches the + physical card. This usually also means that the card is reset during + the process, so this method must not be called at random times. It may + only be called on startup. + + Args: + scc: SimCardCommands class + Returns: + match = True, no match = False + """ + return False class CardModel(abc.ABC): """A specific card model, typically having some additional vendor-specific files. All diff --git a/pySim/profile.py b/pySim/profile.py new file mode 100644 index 0000000..78f5e23 --- /dev/null +++ b/pySim/profile.py @@ -0,0 +1,39 @@ +# -*- coding: utf-8 -*- + +""" pySim: tell old 2G SIMs apart from UICC +""" + +# +# (C) 2021 by Sysmocom s.f.m.c. GmbH +# All Rights Reserved +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +from pySim.commands import SimCardCommands +from pySim.filesystem import CardProfile +from pySim.ts_102_221 import CardProfileUICC +from pySim.ts_102_221 import CardProfileUICCSIM +from pySim.ts_51_011 import CardProfileSIM + +# In order for autodetection ... +_profile_classes = [ CardProfileUICCSIM, CardProfileUICC, CardProfileSIM ] + +def profile_detect(scc:SimCardCommands): + + for p in _profile_classes: + if p.match_witch_card(scc): + return p() + + return None diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index f86a8b3..b1d5e37 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -24,6 +24,10 @@ from pySim.filesystem import * from bidict import bidict +# A UICC will usually also support 2G functionality. If this is the case, we +# need to add DF_GSM and DF_TELECOM along with the UICC related files +from pySim.ts_51_011 import DF_GSM, DF_TELECOM + ts_102_22x_cmdset = CardCommandSet('TS 102 22x', [ # TS 102 221 Section 10.1.2 Table 10.5 "Coding of Instruction Byte" CardCommand('SELECT', 0xA4, ['0X', '4X', '6X']), @@ -454,6 +458,48 @@ addl_info = FlagsEnum(Byte, req_inc_idle_current=1, support_uicc_suspend=2) self._construct = Struct('max_current_mA'/Int8ub, 't_op_s'/Int8ub, 'addl_info'/addl_info) +def _match_uicc(scc:SimCardCommands) -> bool: + """ Try to access MF via UICC APDUs (3GPP TS 102.221), if this works, the + card is considered a UICC card. + """ + cla_byte_bak = scc.cla_byte + sel_ctrl_bak = scc.sel_ctrl + scc.reset_card() + + scc.cla_byte = "00" + scc.sel_ctrl = "0004" + rc = True + try: + scc.select_file('3f00') + except: + rc = False + + scc.reset_card() + scc.cla_byte = cla_byte_bak + scc.sel_ctrl = sel_ctrl_bak + return rc + +def _match_sim(scc:SimCardCommands) -> bool: + """ Try to access MF via 2G APDUs (3GPP TS 11.11), if this works, the card + is also a simcard. This will be the case for most UICC cards, but there may + also be plain UICC cards without 2G support as well. + """ + cla_byte_bak = scc.cla_byte + sel_ctrl_bak = scc.sel_ctrl + scc.reset_card() + + scc.cla_byte = "a0" + scc.sel_ctrl = "0000" + rc = True + try: + scc.select_file('3f00') + except: + rc = False + + scc.reset_card() + scc.cla_byte = cla_byte_bak + scc.sel_ctrl = sel_ctrl_bak + return rc class CardProfileUICC(CardProfile): def __init__(self): @@ -538,3 +584,20 @@ def decode_select_response(self, data_hex:str) -> Any: return pySim.ts_102_221_select.decode_select_response(data_hex) + + @staticmethod + def match_witch_card(scc:SimCardCommands) -> bool: + return _match_uicc(scc) + +class CardProfileUICCSIM(CardProfileUICC): + """Same as above, but including 2G SIM support""" + def __init__(self): + super().__init__() + + # Add GSM specific files + self.files_in_mf.append(DF_TELECOM()) + self.files_in_mf.append(DF_GSM()) + + @staticmethod + def match_witch_card(scc:SimCardCommands) -> bool: + return _match_uicc(scc) and _match_sim(scc) diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index c146a79..c2c1711 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -974,8 +974,35 @@ return ret +def _match_witch_card(scc:SimCardCommands) -> bool: + """ Try to access MF via 2G APDUs (3GPP TS 11.11), if this works, the + card is considered a SIM card. This test will also succeed on UICC + cards that also have SIM card functionality for compatibility with + older MS + """ + cla_byte_bak = scc.cla_byte + sel_ctrl_bak = scc.sel_ctrl + scc.reset_card() + + scc.cla_byte = "a0" + scc.sel_ctrl = "0000" + rc = True + try: + scc.select_file('3f00') + except: + rc = False + + scc.reset_card() + scc.cla_byte = cla_byte_bak + scc.sel_ctrl = sel_ctrl_bak + return rc + class CardProfileSIM(CardProfile): def __init__(self): super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()]) def decode_select_response(self, data_hex:str) -> Any: return _decode_select_response(data_hex) + + @staticmethod + def match_witch_card(scc:SimCardCommands) -> bool: + return _match_witch_card(scc) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:04:53 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 16:04:53 +0000 Subject: Change in pysim[master]: ts_102_221: put select response decoder into separate file In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26160 to look at the new patch set (#2). Change subject: ts_102_221: put select response decoder into separate file ...................................................................... ts_102_221: put select response decoder into separate file The decoder function that decodes the select response has become more and more complex over time, so it makes sense to put the code into a separate file, lets also mark the functions we only call from inside the decoder as private. This makes the code more readable and also helps to prevent circular dependencies. Change-Id: If5fae46bb40d0f285236a6ab287070125c69ed70 --- M pySim/sysmocom_sja2.py M pySim/ts_102_221.py A pySim/ts_102_221_select.py M pySim/ts_31_102.py M pySim/ts_31_103.py M pySim/ts_51_011.py 6 files changed, 184 insertions(+), 156 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/26160/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If5fae46bb40d0f285236a6ab287070125c69ed70 Gerrit-Change-Number: 26160 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:06:14 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:06:14 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Improve counter validation In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 ) Change subject: pcu: Improve counter validation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff Gerrit-Change-Number: 26130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 16:06:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:09:45 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:09:45 +0000 Subject: Change in osmo-pcu[master]: bts: Rename assignment_{UL, DL} to be all lower-case In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26126 ) Change subject: bts: Rename assignment_{UL,DL} to be all lower-case ...................................................................... Patch Set 3: Code-Review-1 i'm with fixeria. you could duplicate the counter with a better name, but if this counter was already part of an official release, we should not change it. (I recently did such a duplication in osmo-bsc) maybe we could consider some compat shim feature in libosmocore, so that a deprecated name can redirect to a new name? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8de29c7e9dd8b17719dfeb784380c685377ce117 Gerrit-Change-Number: 26126 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 16:09:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:14:40 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:14:40 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 4: (1 comment) i think the commit log is fine, but... https://gerrit.osmocom.org/c/osmo-pcu/+/26078/4/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/4/src/pdch.cpp at 616 PS4, Line 616: struct gprs_rlcmac_bts *bts = trx->bts; why not call bts() here though? I guess it's the same, but patch wise you are replacing "bts()" with "trx->bts". usually the intention of a function like bts() is to have a handle on the places where the caller retrieves the bts pointer, using "trx->bts" would then bypass that. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 16:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:18:39 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:18:39 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/bts.cpp at 150 PS4, Line 150: { "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */ (kind of long name, in bts we usually have "imm ass"-like abbreviations -- can't change that part here, but maybe "cont_res_succ", and write "Contention resolution success" in the description? Personally I am actually for writing things out long, but trying to adhere to osmo style) https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/pdch.cpp at 654 PS4, Line 654: bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS); (also here) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 16:18:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:20:44 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 16:20:44 +0000 Subject: Change in pysim[master]: ts_102_221: put select response decoder into separate file In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26160 to look at the new patch set (#3). Change subject: ts_102_221: put select response decoder into separate file ...................................................................... ts_102_221: put select response decoder into separate file The decoder function that decodes the select response has become more and more complex over time, so it makes sense to put the code into a separate file, lets also mark the functions we only call from inside the decoder as private. This makes the code more readable and also helps to prevent circular dependencies. Change-Id: If5fae46bb40d0f285236a6ab287070125c69ed70 --- M pySim/sysmocom_sja2.py M pySim/ts_102_221.py A pySim/ts_102_221_select.py M pySim/ts_31_102.py M pySim/ts_31_103.py M pySim/ts_51_011.py 6 files changed, 183 insertions(+), 155 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/26160/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If5fae46bb40d0f285236a6ab287070125c69ed70 Gerrit-Change-Number: 26160 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:28:01 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:28:01 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 to look at the new patch set (#5). Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... add time_cc API: cumlative counter for time, reported as rate_ctr This is a candidate for adding to libosmocore (as osmo_time_cc), but let's first use this in osmo-bsc to make sure that it works as intended. I started out expecting to be done with this in half an hour, but I found out that accumulating elapsed time to an integer counter has a staggering amount of complexity to it, and a million pitfalls. The intended use is to report allAvailableSDCCHAllocated and allAvailableTCHAllocated performance indicators in OsmoBSC. Hopefully this will also be generally useful elsewhere, to be worth the effort. Related: SYS#4878 Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 --- M configure.ac M include/osmocom/bsc/Makefile.am A include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am A src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/Makefile.am A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 10 files changed, 1,508 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/25973/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:28:01 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:28:01 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 to look at the new patch set (#7). Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... implement all_allocated:{sdcch,tch} rate counters Based on allAvailable{SDCCH,TCH}Allocated performance indicators, see 3GPP TS 52.402. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/net_init.c M tests/timer.vty 9 files changed, 137 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/25974/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:29:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 16:29:51 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/4/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/4/src/pdch.cpp at 616 PS4, Line 616: struct gprs_rlcmac_bts *bts = trx->bts; > why not call bts() here though? [?] It's already in the direction of getting rid of C++ getters, so that let's less churn to get rid of in the future. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 16:29:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:31:09 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:31:09 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 to look at the new patch set (#8). Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... implement all_allocated:{sdcch,tch} rate counters Based on allAvailable{SDCCH,TCH}Allocated performance indicators, see 3GPP TS 52.402. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/net_init.c M tests/timer.vty 9 files changed, 137 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/25974/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 8 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:31:09 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:31:09 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{static_sdcch, static_tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25975 to look at the new patch set (#8). Change subject: implement all_allocated:{static_sdcch,static_tch} rate counters ...................................................................... implement all_allocated:{static_sdcch,static_tch} rate counters Same as all_allocated:{sdcch,tch}, but already trigger when all non-dynamic timeslots are allocated. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I2fa14531f16d3f07085620f1c50eb839c420da6a --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c 6 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/25975/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fa14531f16d3f07085620f1c50eb839c420da6a Gerrit-Change-Number: 25975 Gerrit-PatchSet: 8 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:31:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 16:31:26 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Patch Set 4: I also thought about the long name, and I agree that the prefix should have been named imm_ass, but agree to let's not change that. For contention resolution, Ithink it's not clear enough if it gets squeezed, so I prefer keeping the long name. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 16:31:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:31:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 16:31:31 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 16:31:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:32:30 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Nov 2021 16:32:30 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 to look at the new patch set (#6). Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... add time_cc API: cumlative counter for time, reported as rate_ctr This is a candidate for adding to libosmocore (as osmo_time_cc), but let's first use this in osmo-bsc to make sure that it works as intended. I started out expecting to be done with this in half an hour, but I found out that accumulating elapsed time to an integer counter has a staggering amount of complexity to it, and a million pitfalls. The intended use is to report allAvailableSDCCHAllocated and allAvailableTCHAllocated performance indicators in OsmoBSC. Hopefully this will also be generally useful elsewhere, to be worth the effort. Related: SYS#4878 Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 --- M configure.ac M include/osmocom/bsc/Makefile.am A include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am A src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/Makefile.am A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 10 files changed, 1,508 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/25973/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:53:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 16:53:00 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: do not pass lchan to print_meas_rep_buf() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26145 ) Change subject: abis_rsl: do not pass lchan to print_meas_rep_buf() ...................................................................... abis_rsl: do not pass lchan to print_meas_rep_buf() Change-Id: If965c7dc6b989ee758ddec0190ec1cce8363b240 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 11 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index cdd57c2..f849d27 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1177,21 +1177,11 @@ prefix, mru->full.rx_qual, prefix, mru->sub.rx_qual); } -static int print_meas_rep_buf(char *buf, size_t len, struct gsm_lchan *lchan, struct gsm_meas_rep *mr) +static int print_meas_rep_buf(char *buf, size_t len, struct gsm_meas_rep *mr) { - const char *name = ""; - struct bsc_subscr *bsub = NULL; struct osmo_strbuf sb = { .buf = buf, .len = len }; - if (lchan && lchan->conn) { - bsub = lchan->conn->bsub; - if (bsub) { - name = bsc_subscr_name(bsub); - } else - name = lchan->name; - } - - OSMO_STRBUF_PRINTF(sb, "[%s] MEASUREMENT RESULT NR=%d ", name, mr->nr); + OSMO_STRBUF_PRINTF(sb, "MEASUREMENT RESULT NR=%d ", mr->nr); if (mr->flags & MEAS_REP_F_DL_DTX) OSMO_STRBUF_PRINTF(sb, "DTXd "); @@ -1222,25 +1212,30 @@ return sb.chars_needed; } -static char *print_meas_rep_c(void *ctx, struct gsm_lchan *lchan, struct gsm_meas_rep *mr) +static char *print_meas_rep_c(void *ctx, struct gsm_meas_rep *mr) { /* A naive count of required characters gets me to ~200, so 256 should be safe to get a large enough buffer on * the first time. */ - OSMO_NAME_C_IMPL(ctx, 256, "ERROR", print_meas_rep_buf, lchan, mr) + OSMO_NAME_C_IMPL(ctx, 256, "ERROR", print_meas_rep_buf, mr) } static void print_meas_rep(struct gsm_lchan *lchan, struct gsm_meas_rep *mr) { int i; + const char *name = ""; struct bsc_subscr *bsub = NULL; if (lchan && lchan->conn) { bsub = lchan->conn->bsub; - if (bsub) + if (bsub) { log_set_context(LOG_CTX_BSC_SUBSCR, bsub); + name = bsc_subscr_name(bsub); + } else { + name = lchan->name; + } } - DEBUGP(DMEAS, "%s\n", print_meas_rep_c(OTC_SELECT, lchan, mr)); + DEBUGP(DMEAS, "[%s] %s\n", name, print_meas_rep_c(OTC_SELECT, mr)); if (mr->num_cell != 7 && log_check_level(DMEAS, LOGL_DEBUG)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If965c7dc6b989ee758ddec0190ec1cce8363b240 Gerrit-Change-Number: 26145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:53:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 16:53:00 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: print_meas_rep_{buf, uni}() accept const *mr In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26146 ) Change subject: abis_rsl: print_meas_rep_{buf,uni}() accept const *mr ...................................................................... abis_rsl: print_meas_rep_{buf,uni}() accept const *mr Change-Id: I5c3e27a00cd84f102558499072965ec538f5a87f --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index f849d27..0291224 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1168,7 +1168,9 @@ return 0; } -static void print_meas_rep_uni(struct osmo_strbuf *sb, struct gsm_meas_rep_unidir *mru, const char *prefix) +static void print_meas_rep_uni(struct osmo_strbuf *sb, + const struct gsm_meas_rep_unidir *mru, + const char *prefix) { OSMO_STRBUF_PRINTF(*sb, "RXL-FULL-%s=%3ddBm RXL-SUB-%s=%3ddBm ", prefix, rxlev2dbm(mru->full.rx_lev), @@ -1177,7 +1179,7 @@ prefix, mru->full.rx_qual, prefix, mru->sub.rx_qual); } -static int print_meas_rep_buf(char *buf, size_t len, struct gsm_meas_rep *mr) +static int print_meas_rep_buf(char *buf, size_t len, const struct gsm_meas_rep *mr) { struct osmo_strbuf sb = { .buf = buf, .len = len }; @@ -1212,14 +1214,14 @@ return sb.chars_needed; } -static char *print_meas_rep_c(void *ctx, struct gsm_meas_rep *mr) +static char *print_meas_rep_c(void *ctx, const struct gsm_meas_rep *mr) { /* A naive count of required characters gets me to ~200, so 256 should be safe to get a large enough buffer on * the first time. */ OSMO_NAME_C_IMPL(ctx, 256, "ERROR", print_meas_rep_buf, mr) } -static void print_meas_rep(struct gsm_lchan *lchan, struct gsm_meas_rep *mr) +static void print_meas_rep(struct gsm_lchan *lchan, const struct gsm_meas_rep *mr) { int i; const char *name = ""; @@ -1240,7 +1242,7 @@ if (mr->num_cell != 7 && log_check_level(DMEAS, LOGL_DEBUG)) { for (i = 0; i < mr->num_cell; i++) { - struct gsm_meas_rep_cell *mrc = &mr->cell[i]; + const struct gsm_meas_rep_cell *mrc = &mr->cell[i]; DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u => %d dBm\n", mrc->neigh_idx, mrc->arfcn, mrc->bsic, rxlev2dbm(mrc->rxlev)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c3e27a00cd84f102558499072965ec538f5a87f Gerrit-Change-Number: 26146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 16:58:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 16:58:02 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: permit simultaneous ACCH repetition and overpower In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26144 ) Change subject: abis_rsl: permit simultaneous ACCH repetition and overpower ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26144/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26144/1/src/osmo-bsc/abis_rsl.c at 566 PS1, Line 566: (void *)&bts->temporary_overpower); > orthogonal to this patch, but if the MS indicates no support for repeated ACCH in cm3, should we mak [?] If the MS does not support repeated ACCH, then we don't enable repeated ACCH. Temporary ACCH overpower requires no support in the MS, so it can be enabled regardless. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Gerrit-Change-Number: 26144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 16:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 17:00:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 17:00:08 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... bts_pch_timer: Fix timer working only for MI type IMSI This commit actually addresses 2 errors: 1- gprs_bssgp_pcu_rx_paging_ps() called gprs_rlcmac_paging_request() with MI which can be either TMSI or IMSI, and the later always called bts_pch_timer_start() passing mi->imsi regardless of the MI type. Hence, trash was being accessed & stored into bts_pch_timer structures if MI type used for paging was TMSI. 2- When the MS received the PS paging on CCCH and requests an UL TBF, it will send some data. If one phase access is used for whatever reason, the IMSI may not be yet available in the GprsMs object since we never received it (and we'd only have it by means of PktResourceReq). Hence, let's better first try to match the paging by TLLI/TMSI if set in both places, and otherwise use the IMSI. Related: OS#5297 Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 --- M src/bts_pch_timer.c M src/bts_pch_timer.h M src/gprs_bssgp_pcu.c M src/gprs_rlcmac.cpp M src/tbf_ul.cpp M tests/alloc/AllocTest.cpp M tests/alloc/AllocTest.err 7 files changed, 58 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/26166/1 diff --git a/src/bts_pch_timer.c b/src/bts_pch_timer.c index 20373ac..062420c 100644 --- a/src/bts_pch_timer.c +++ b/src/bts_pch_timer.c @@ -26,8 +26,22 @@ #include #include #include +#include -static struct bts_pch_timer *bts_pch_timer_get(struct gprs_rlcmac_bts *bts, const char *imsi) +static struct bts_pch_timer *bts_pch_timer_get_by_ptmsi(struct gprs_rlcmac_bts *bts, uint32_t ptmsi) +{ + struct bts_pch_timer *p; + OSMO_ASSERT(ptmsi != GSM_RESERVED_TMSI); + + llist_for_each_entry(p, &bts->pch_timer, entry) { + if (p->ptmsi != GSM_RESERVED_TMSI && p->ptmsi == ptmsi) + return p; + } + + return NULL; +} + +static struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi) { struct bts_pch_timer *p; @@ -57,29 +71,45 @@ bts_pch_timer_remove(p); } -void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const char *imsi) +void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const struct osmo_mobile_identity *mi_paging, + const char *imsi) { - if (bts_pch_timer_get(bts, imsi)) + struct bts_pch_timer *p; + struct osmo_tdef *tdef; + + if (bts_pch_timer_get_by_imsi(bts, imsi)) return; - struct bts_pch_timer *p; p = talloc_zero(bts, struct bts_pch_timer); llist_add_tail(&p->entry, &bts->pch_timer); - osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi)); p->bts = bts; + osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi)); + p->ptmsi = (mi_paging->type == GSM_MI_TYPE_TMSI) ? mi_paging->tmsi : GSM_RESERVED_TMSI; - struct osmo_tdef *tdef = osmo_tdef_get_entry(the_pcu->T_defs, 3113); + tdef = osmo_tdef_get_entry(the_pcu->T_defs, 3113); OSMO_ASSERT(tdef); osmo_timer_setup(&p->T3113, T3113_callback, p); osmo_timer_schedule(&p->T3113, tdef->val, 0); - LOGP(DPCU, LOGL_DEBUG, "PCH paging timer started for IMSI=%s\n", p->imsi); + if (log_check_level(DPCU, LOGL_DEBUG)) { + char str[64]; + osmo_mobile_identity_to_str_buf(str, sizeof(str), mi_paging); + LOGP(DPCU, LOGL_DEBUG, "PCH paging timer started for MI=%s IMSI=%s\n", str, p->imsi); + } } -void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const char *imsi) +void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const struct GprsMs *ms) { - struct bts_pch_timer *p = bts_pch_timer_get(bts, imsi); + struct bts_pch_timer *p = NULL; + uint32_t tlli = ms_tlli(ms); + const char *imsi = ms_imsi(ms); + /* First try matching by TMSI if available in MS */ + if (tlli != GSM_RESERVED_TMSI) + p = bts_pch_timer_get_by_ptmsi(bts, tlli); + /* Otherwise try matching by IMSI if available in MS */ + if (!p && imsi[0] != '\0') + p = bts_pch_timer_get_by_imsi(bts, imsi); if (p) bts_pch_timer_remove(p); } diff --git a/src/bts_pch_timer.h b/src/bts_pch_timer.h index 26b89c8..3e47161 100644 --- a/src/bts_pch_timer.h +++ b/src/bts_pch_timer.h @@ -32,11 +32,15 @@ struct llist_head entry; struct gprs_rlcmac_bts *bts; struct osmo_timer_list T3113; + uint32_t ptmsi; /* GSM_RESERVED_TMSI if not available */ char imsi[OSMO_IMSI_BUF_SIZE]; }; -void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const char *imsi); -void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const char *imsi); +struct GprsMs; + +void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const struct osmo_mobile_identity *mi_paging, + const char *imsi); +void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const struct GprsMs *ms); void bts_pch_timer_stop_all(struct gprs_rlcmac_bts *bts); #ifdef __cplusplus diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 0dd6cdc..424a381 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -39,6 +39,7 @@ #include "tbf_dl.h" #include "llc.h" #include "gprs_rlcmac.h" +#include "bts_pch_timer.h" /* Tuning parameters for BSSGP flow control */ #define FC_DEFAULT_LIFE_TIME_SECS 10 /* experimental value, 10s */ @@ -319,7 +320,9 @@ /* FIXME: look if MS is attached a specific BTS and then only page on that one? */ llist_for_each_entry(bts, &the_pcu->bts_list, list) { - gprs_rlcmac_paging_request(bts, &paging_mi, pgroup); + if (gprs_rlcmac_paging_request(bts, &paging_mi, pgroup) < 0) + continue; + bts_pch_timer_start(bts, &paging_mi, mi_imsi.imsi); } return 0; } diff --git a/src/gprs_rlcmac.cpp b/src/gprs_rlcmac.cpp index 22b12df..ffa656c 100644 --- a/src/gprs_rlcmac.cpp +++ b/src/gprs_rlcmac.cpp @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include @@ -49,7 +48,6 @@ return -1; } bts_do_rate_ctr_inc(bts, CTR_PCH_REQUESTS); - bts_pch_timer_start(bts, mi->imsi); pcu_l1if_tx_pch(bts, paging_request, plen, pgroup); bitvec_free(paging_request); diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index f0d16b5..ba0a850 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -435,7 +435,7 @@ "Decoded premier TLLI=0x%08x of UL DATA TFI=%d.\n", new_tlli, rlc->tfi); update_ms(new_tlli, GPRS_RLCMAC_UL_TBF); - bts_pch_timer_stop(bts, ms_imsi(ms())); + bts_pch_timer_stop(bts, ms()); } else if (new_tlli != GSM_RESERVED_TMSI && new_tlli != tlli()) { LOGPTBFUL(this, LOGL_NOTICE, "Decoded TLLI=%08x mismatch on UL DATA TFI=%d. (Ignoring due to contention resolution)\n", diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index 35bbfc4..cd9c7bc 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -806,15 +806,17 @@ static void test_bts_pch_timer(void) { struct gprs_rlcmac_bts *bts = bts_alloc(the_pcu, 0); - const char *imsi1 = "1234"; - const char *imsi2 = "5678"; + struct osmo_mobile_identity mi_imsi1, mi_imsi2; + mi_imsi1.type = mi_imsi2.type = GSM_MI_TYPE_IMSI; + OSMO_STRLCPY_ARRAY(mi_imsi1.imsi, "1234"); + OSMO_STRLCPY_ARRAY(mi_imsi2.imsi, "5678"); fprintf(stderr, "Testing bts_pch_timer dealloc on bts dealloc\n"); log_set_category_filter(osmo_stderr_target, DPCU, 1, LOGL_DEBUG); fprintf(stderr, "Starting PCH timer for 2 IMSI\n"); - bts_pch_timer_start(bts, imsi1); - bts_pch_timer_start(bts, imsi2); + bts_pch_timer_start(bts, &mi_imsi1, mi_imsi1.imsi); + bts_pch_timer_start(bts, &mi_imsi2, mi_imsi2.imsi); fprintf(stderr, "Deallocating BTS, expecting the PCH timer to be stopped and deallocated\n"); talloc_free(bts); diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err index cb98332..53e2edd 100644 --- a/tests/alloc/AllocTest.err +++ b/tests/alloc/AllocTest.err @@ -501219,8 +501219,8 @@ DL_ASS_TBF(DL-TFI_1){NONE}: Deallocated Testing bts_pch_timer dealloc on bts dealloc Starting PCH timer for 2 IMSI -PCH paging timer started for IMSI=1234 -PCH paging timer started for IMSI=5678 +PCH paging timer started for MI=IMSI-1234 IMSI=1234 +PCH paging timer started for MI=IMSI-5678 IMSI=5678 Deallocating BTS, expecting the PCH timer to be stopped and deallocated PCH paging timer stopped for IMSI=1234 PCH paging timer stopped for IMSI=5678 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 17:00:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 17:00:08 +0000 Subject: Change in osmo-pcu[master]: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26167 ) Change subject: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI ...................................................................... tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a --- M tests/alloc/AllocTest.cpp M tests/alloc/AllocTest.err 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/67/26167/1 diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index cd9c7bc..1f2bbda 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -807,9 +807,12 @@ { struct gprs_rlcmac_bts *bts = bts_alloc(the_pcu, 0); struct osmo_mobile_identity mi_imsi1, mi_imsi2; + struct osmo_mobile_identity mi_tmsi1; mi_imsi1.type = mi_imsi2.type = GSM_MI_TYPE_IMSI; + mi_tmsi1.type = GSM_MI_TYPE_TMSI; OSMO_STRLCPY_ARRAY(mi_imsi1.imsi, "1234"); OSMO_STRLCPY_ARRAY(mi_imsi2.imsi, "5678"); + mi_tmsi1.tmsi = 987654321; fprintf(stderr, "Testing bts_pch_timer dealloc on bts dealloc\n"); log_set_category_filter(osmo_stderr_target, DPCU, 1, LOGL_DEBUG); @@ -817,6 +820,8 @@ fprintf(stderr, "Starting PCH timer for 2 IMSI\n"); bts_pch_timer_start(bts, &mi_imsi1, mi_imsi1.imsi); bts_pch_timer_start(bts, &mi_imsi2, mi_imsi2.imsi); + fprintf(stderr, "Starting PCH timer for 1 TMSI\n"); + bts_pch_timer_start(bts, &mi_tmsi1, "6666"); fprintf(stderr, "Deallocating BTS, expecting the PCH timer to be stopped and deallocated\n"); talloc_free(bts); diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err index 53e2edd..1f86336 100644 --- a/tests/alloc/AllocTest.err +++ b/tests/alloc/AllocTest.err @@ -501221,6 +501221,9 @@ Starting PCH timer for 2 IMSI PCH paging timer started for MI=IMSI-1234 IMSI=1234 PCH paging timer started for MI=IMSI-5678 IMSI=5678 +Starting PCH timer for 1 TMSI +PCH paging timer started for MI=TMSI-0x3ADE68B1 IMSI=6666 Deallocating BTS, expecting the PCH timer to be stopped and deallocated PCH paging timer stopped for IMSI=1234 PCH paging timer stopped for IMSI=5678 +PCH paging timer stopped for IMSI=6666 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a Gerrit-Change-Number: 26167 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 17:53:22 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 17:53:22 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26166/1/src/bts_pch_timer.c File src/bts_pch_timer.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26166/1/src/bts_pch_timer.c at 79 PS1, Line 79: Its probably obvious, but maybe a comment helps to understand it better: /* We already have a timer running for this IMSI */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Mon, 08 Nov 2021 17:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 17:54:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 17:54:36 +0000 Subject: Change in osmo-pcu[master]: cosmetic: Add parenthesis around expression to clarify it In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26159 ) Change subject: cosmetic: Add parenthesis around expression to clarify it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I621ef02868aff2bd23d82c8bc70e5cdbc391fbc2 Gerrit-Change-Number: 26159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Mon, 08 Nov 2021 17:54:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 17:56:14 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 8 Nov 2021 17:56:14 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Update FSM names for dummy reject TBFs In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26158 ) Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 17:56:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:21:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:21:54 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Update FSM names for dummy reject TBFs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26158 ) Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 18:21:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:21:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:21:55 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 to look at the new patch set (#2). Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... bts_pch_timer: Fix timer working only for MI type IMSI This commit actually addresses 2 errors: 1- gprs_bssgp_pcu_rx_paging_ps() called gprs_rlcmac_paging_request() with MI which can be either TMSI or IMSI, and the later always called bts_pch_timer_start() passing mi->imsi regardless of the MI type. Hence, trash was being accessed & stored into bts_pch_timer structures if MI type used for paging was TMSI. 2- When the MS received the PS paging on CCCH and requests an UL TBF, it will send some data. If one phase access is used for whatever reason, the IMSI may not be yet available in the GprsMs object since we never received it (and we'd only have it by means of PktResourceReq). Hence, let's better first try to match the paging by TLLI/TMSI if set in both places, and otherwise use the IMSI. Related: OS#5297 Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 --- M src/bts_pch_timer.c M src/bts_pch_timer.h M src/gprs_bssgp_pcu.c M src/gprs_rlcmac.cpp M src/tbf_ul.cpp M tests/alloc/AllocTest.cpp M tests/alloc/AllocTest.err 7 files changed, 59 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/26166/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:21:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:21:56 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26168 ) Change subject: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed ...................................................................... bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed Let's avoid flooding the BTS and taking CCCH resources for no good reason. If user configures everything correctly, the SGSN should not attempt a retry after similar timer >= T3113. Related: OS#5297 Change-Id: I2a77714648d16ccff2a340ce775e83dcc5ffe707 --- M src/bts.cpp M src/bts.h M src/bts_pch_timer.c M src/bts_pch_timer.h M src/gprs_bssgp_pcu.c 5 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/68/26168/1 diff --git a/src/bts.cpp b/src/bts.cpp index d053396..2aee8e1 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -134,6 +134,7 @@ { "llc:dl_bytes", "RLC encapsulated PDUs"}, { "llc:ul_bytes", "full PDUs received "}, { "pch:requests", "PCH requests sent "}, + { "pch:requests:already", "PCH requests on subscriber already being paged"}, { "pch:requests:timeout", "PCH requests timeout "}, { "rach:requests", "RACH requests received"}, { "rach:requests:11bit", "11BIT_RACH requests received"}, diff --git a/src/bts.h b/src/bts.h index d0119b6..2615d26 100644 --- a/src/bts.h +++ b/src/bts.h @@ -126,6 +126,7 @@ CTR_LLC_DL_BYTES, CTR_LLC_UL_BYTES, CTR_PCH_REQUESTS, + CTR_PCH_REQUESTS_ALREADY, CTR_PCH_REQUESTS_TIMEDOUT, CTR_RACH_REQUESTS, CTR_RACH_REQUESTS_11BIT, diff --git a/src/bts_pch_timer.c b/src/bts_pch_timer.c index 644b516..b616420 100644 --- a/src/bts_pch_timer.c +++ b/src/bts_pch_timer.c @@ -41,7 +41,7 @@ return NULL; } -static struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi) +struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi) { struct bts_pch_timer *p; @@ -77,10 +77,6 @@ struct bts_pch_timer *p; struct osmo_tdef *tdef; - /* We already have a timer running for this IMSI */ - if (bts_pch_timer_get_by_imsi(bts, imsi)) - return; - p = talloc_zero(bts, struct bts_pch_timer); llist_add_tail(&p->entry, &bts->pch_timer); p->bts = bts; diff --git a/src/bts_pch_timer.h b/src/bts_pch_timer.h index 3e47161..cc5dcb0 100644 --- a/src/bts_pch_timer.h +++ b/src/bts_pch_timer.h @@ -42,6 +42,7 @@ const char *imsi); void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const struct GprsMs *ms); void bts_pch_timer_stop_all(struct gprs_rlcmac_bts *bts); +struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi); #ifdef __cplusplus } diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 424a381..4328e07 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -320,6 +320,11 @@ /* FIXME: look if MS is attached a specific BTS and then only page on that one? */ llist_for_each_entry(bts, &the_pcu->bts_list, list) { + if (bts_pch_timer_get_by_imsi(bts, mi_imsi.imsi)) { + LOGP(DBSSGP, LOGL_INFO, "PS-Paging request already pending for IMSI=%s\n", mi_imsi.imsi); + bts_do_rate_ctr_inc(bts, CTR_PCH_REQUESTS_ALREADY); + continue; + } if (gprs_rlcmac_paging_request(bts, &paging_mi, pgroup) < 0) continue; bts_pch_timer_start(bts, &paging_mi, mi_imsi.imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a77714648d16ccff2a340ce775e83dcc5ffe707 Gerrit-Change-Number: 26168 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:22:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:22:06 +0000 Subject: Change in osmo-pcu[master]: cosmetic: Add parenthesis around expression to clarify it In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26159 ) Change subject: cosmetic: Add parenthesis around expression to clarify it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I621ef02868aff2bd23d82c8bc70e5cdbc391fbc2 Gerrit-Change-Number: 26159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:22:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:23:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:23:42 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Update FSM names for dummy reject TBFs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26158 ) Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 18:23:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:23:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:23:49 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Update FSM names for dummy reject TBFs In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26158 ) Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... tbf_ul: Update FSM names for dummy reject TBFs This allows easily identifying dummt TBFs created to send assignment rejects. Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 --- M src/tbf.cpp M src/tbf_ul.cpp M tests/tbf/TbfTest.err 3 files changed, 18 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/tbf.cpp b/src/tbf.cpp index 4b78595..99d1018 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -734,9 +734,10 @@ void tbf_update_state_fsm_name(struct gprs_rlcmac_tbf *tbf) { char buf[64]; + int8_t tfi = (tbf_tfi(tbf) == TBF_TS_UNSET) ? -1 : tbf_tfi(tbf); snprintf(buf, sizeof(buf), "%s-TFI_%d", tbf_direction(tbf) == GPRS_RLCMAC_UL_TBF ? "UL" : "DL", - tbf_tfi(tbf)); + tfi); osmo_identifier_sanitize_buf(buf, NULL, '_'); osmo_fsm_inst_update_id(tbf->state_fsm.fi, buf); diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index ca929ea..f0d16b5 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -221,6 +221,7 @@ talloc_free(ul_tbf); return NULL; } + tbf_update_state_fsm_name(ul_tbf); ms_attach_tbf(ms, ul_tbf); llist_add(tbf_trx_list((struct gprs_rlcmac_tbf *)ul_tbf), &trx->ul_tbfs); diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 7d2d534..c440499 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -9078,12 +9078,12 @@ UL_ACK_TBF{NONE}: Allocated TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) -TBF{NEW}: Received Event ASSIGN_ADD_PACCH +TBF(UL-TFI_-1){NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] -TBF{NEW}: state_chg to ASSIGN +TBF(UL-TFI_-1){NEW}: state_chg to ASSIGN TBF(TFI=-1 TLLI=0xffeeddd3 DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec -UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ -UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){NONE}: Received Event SCHED_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){NONE}: state_chg to SEND_ASS_REJ PDCH(bts=0,trx=0,ts=7) Expiring FN=82 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=6 TLLI=0xffeeddd2 DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=6 TLLI=0xffeeddd2 DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 82) @@ -9109,23 +9109,23 @@ UL_ACK_TBF{NONE}: Allocated TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) -TBF{NEW}: Received Event ASSIGN_ADD_PACCH +TBF(UL-TFI_-1){NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] -TBF{NEW}: state_chg to ASSIGN +TBF(UL-TFI_-1){NEW}: state_chg to ASSIGN TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec -UL_ASS_TBF{NONE}: Received Event SCHED_ASS_REJ -UL_ASS_TBF{NONE}: state_chg to SEND_ASS_REJ -UL_ASS_TBF{SEND_ASS_REJ}: Received Event CREATE_RLCMAC_MSG -UL_ASS_TBF{SEND_ASS_REJ}: state_chg to NONE +UL_ASS_TBF(UL-TFI_-1){NONE}: Received Event SCHED_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){NONE}: state_chg to SEND_ASS_REJ +UL_ASS_TBF(UL-TFI_-1){SEND_ASS_REJ}: Received Event CREATE_RLCMAC_MSG +UL_ASS_TBF(UL-TFI_-1){SEND_ASS_REJ}: state_chg to NONE TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) starting timer X2000 [reject (PACCH)] with 0 sec. 0 microsec PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) -UL_ASS_TBF{NONE}: Timeout of X2000 +UL_ASS_TBF(UL-TFI_-1){NONE}: Timeout of X2000 TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) free MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Detaching TBF: TBF(TFI=-1 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN) MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Destroying MS object ********** UL-TBF ends here ********** -UL_ACK_TBF{NONE}: Deallocated -TBF{ASSIGN}: Deallocated -UL_ASS_TBF{NONE}: Deallocated -DL_ASS_TBF{NONE}: Deallocated +UL_ACK_TBF(UL-TFI_-1){NONE}: Deallocated +TBF(UL-TFI_-1){ASSIGN}: Deallocated +UL_ASS_TBF(UL-TFI_-1){NONE}: Deallocated +DL_ASS_TBF(UL-TFI_-1){NONE}: Deallocated === end test_packet_access_rej_prr_no_other_tbfs === -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:23:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:23:50 +0000 Subject: Change in osmo-pcu[master]: cosmetic: Add parenthesis around expression to clarify it In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26159 ) Change subject: cosmetic: Add parenthesis around expression to clarify it ...................................................................... cosmetic: Add parenthesis around expression to clarify it Change-Id: I621ef02868aff2bd23d82c8bc70e5cdbc391fbc2 --- M src/tbf.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/tbf.cpp b/src/tbf.cpp index 99d1018..0b02623 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -719,7 +719,7 @@ const char *gprs_rlcmac_tbf::name() const { - int8_t tfi = m_tfi == TBF_TS_UNSET ? -1 : m_tfi; + int8_t tfi = (m_tfi == TBF_TS_UNSET) ? -1 : m_tfi; snprintf(m_name_buf, sizeof(m_name_buf) - 1, "TBF(TFI=%d TLLI=0x%08x DIR=%s STATE=%s%s)", tfi, tlli(), -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I621ef02868aff2bd23d82c8bc70e5cdbc391fbc2 Gerrit-Change-Number: 26159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:24:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:24:40 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:24:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:25:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:25:00 +0000 Subject: Change in osmo-pcu[master]: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26167 ) Change subject: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a Gerrit-Change-Number: 26167 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:25:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:25:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:25:37 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26168 ) Change subject: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a77714648d16ccff2a340ce775e83dcc5ffe707 Gerrit-Change-Number: 26168 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 08 Nov 2021 18:25:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:27:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:27:32 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 18:27:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:27:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:27:48 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26079 ) Change subject: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d Gerrit-Change-Number: 26079 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:27:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:28:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:28:42 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/bts.cpp at 150 PS4, Line 150: { "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */ > (kind of long name, in bts we usually have "imm ass"-like abbreviations -- can't change that part he [?] I'd argue in favor of the shorter name -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 18:28:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:28:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:28:59 +0000 Subject: Change in osmo-pcu[master]: doc: Update counters_generated.adoc using osmo_vty_interact.py In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26122 ) Change subject: doc: Update counters_generated.adoc using osmo_vty_interact.py ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 Gerrit-Change-Number: 26122 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 18:28:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:29:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:29:45 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: permit simultaneous ACCH repetition and overpower In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26144 ) Change subject: abis_rsl: permit simultaneous ACCH repetition and overpower ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Gerrit-Change-Number: 26144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 18:29:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:30:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:30:06 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: permit simultaneous ACCH repetition and overpower In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26144 ) Change subject: abis_rsl: permit simultaneous ACCH repetition and overpower ...................................................................... abis_rsl: permit simultaneous ACCH repetition and overpower As stated in "GSM/EDGE Evolution and Performance", section 12.3, both features *can* be enabled simultaneously. Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Related: SYS#5319 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 3 insertions(+), 18 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0291224..423c2b8 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -555,30 +555,15 @@ /* indicate Temporary overpower of SACCH and FACCH channels */ static void top_acch_cap_for_bts(struct gsm_lchan *lchan, struct msgb *msg) { - struct abis_rsl_osmo_temp_ovp_acch_cap cap; struct gsm_bts *bts = lchan->ts->trx->bts; - bool acch_rep_enabled; - bool acch_rep_supp_by_ms; /* The BTS_FEAT_ACCH_TEMP_OVP IE is a proprietary IE, that can only be used with osmo-bts type BTSs */ if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS && osmo_bts_has_feature(&bts->features, BTS_FEAT_ACCH_TEMP_OVP))) return; - memcpy(&cap, &bts->temporary_overpower, sizeof(cap)); - - /* The user has enabled one of the two downlink related ACCH repetition features. */ - acch_rep_enabled = bts->repeated_acch_policy.dl_sacch || bts->repeated_acch_policy.dl_facch_all - || bts->repeated_acch_policy.dl_facch_cmd; - - /* The MS indicates support for ACCH repetition */ - acch_rep_supp_by_ms = lchan->conn && lchan->conn->cm3_valid && lchan->conn->cm3.repeated_acch_capability; - - /* If the MS fully supports repeated ACCH capabilites as specified in 3GPP TS 44.006, section 10 and 11. and if - * ACCH repetition is enabled for this BTS, then we will not apply temporary overpower. */ - if (acch_rep_enabled && acch_rep_supp_by_ms) - cap.overpower_db = 0; - - msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(cap), (uint8_t*) &cap); + msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, + sizeof(bts->temporary_overpower), + (void *)&bts->temporary_overpower); } /* Write RSL_IE_OSMO_TRAINING_SEQUENCE to msgb. The tsc_set argument's range is 1-4, tsc argument range is 0-7. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2189f01bd78625dab3d642597240338ee581fc98 Gerrit-Change-Number: 26144 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:30:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:30:31 +0000 Subject: Change in pysim[master]: pySim-shell: print newline on exit with CTRL+D In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26081 ) Change subject: pySim-shell: print newline on exit with CTRL+D ...................................................................... Patch Set 2: > Patch Set 1: > > who calls this do_eof() function? Doesn't that just add an "eof" command to the shell? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88e58094b9badeaabd8502006e5e16f35eaa683e Gerrit-Change-Number: 26081 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 18:30:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:31:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 18:31:00 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c File src/bts_pch_timer.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c at 37 PS2, Line 37: p->ptmsi != GSM_RESERVED_TMSI Above you already ensure that ptmsi != GSM_RESERVED_TMSI, so this check is redundant. https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c at 87 PS2, Line 87: osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi)); OSMO_STRLCPY_ARRAY(p->imsi, imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 18:31:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:31:46 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:31:46 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: reduce verbosity of the OML logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26138 ) Change subject: ipaccess-config: reduce verbosity of the OML logging ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e Gerrit-Change-Number: 26138 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 18:31:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:32:29 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 18:32:29 +0000 Subject: Change in osmo-pcu[master]: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26167 ) Change subject: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a Gerrit-Change-Number: 26167 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:32:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:32:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:32:43 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: reduce verbosity of the OML logging In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26138 ) Change subject: ipaccess-config: reduce verbosity of the OML logging ...................................................................... ipaccess-config: reduce verbosity of the OML logging Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved neels: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index ada23ea..9f23b56 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -925,7 +925,7 @@ .name = "DNM", .description = "A-bis Network Management / O&M (NM/OML)", .color = "\033[1;36m", - .loglevel = LOGL_DEBUG, + .loglevel = LOGL_NOTICE, .enabled = 1, }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie52db9236da15da540e14cad56e01c2246b3e82e Gerrit-Change-Number: 26138 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:32:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:32:43 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26147 ) Change subject: ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] ...................................................................... ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] Change-Id: Idf8e3a9ee6d9a8801d53254c772548586d4a9c60 --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Verified diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 9f23b56..e3d0e48 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -501,7 +501,7 @@ { 0x0002, "static-gw" }, { 0x0004, "no-dhcp-vsi" }, { 0x0008, "dhcp-enabled" }, - { 0x0040, "led-disabled" }, + { 0x0040, "led-enabled" }, { 0x0100, "secondary-oml-enabled" }, { 0x0200, "diag-enabled" }, { 0x0400, "cli-enabled" }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf8e3a9ee6d9a8801d53254c772548586d4a9c60 Gerrit-Change-Number: 26147 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:32:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:32:44 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: warn about unknown flag name In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26148 ) Change subject: ipaccess-config: warn about unknown flag name ...................................................................... ipaccess-config: warn about unknown flag name Change-Id: Iab3bae3af9e1cac992b1f8947cda25fcff647992 --- M src/ipaccess/ipaccess-config.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index e3d0e48..2d72d0e 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -516,8 +516,10 @@ { int rc; rc = get_string_value(ipa_nvflag_strs, name); - if (rc < 0) + if (rc < 0) { + fprintf(stderr, "Unknown attribute '%s'\n", name); return rc; + } *mask |= rc; if (en) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab3bae3af9e1cac992b1f8947cda25fcff647992 Gerrit-Change-Number: 26148 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:32:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:32:54 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 18:32:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:33:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:33:04 +0000 Subject: Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... pdch::rcv_resource_request(): Use local var to store bts pointer Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 --- M src/pdch.cpp 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/pdch.cpp b/src/pdch.cpp index ddad020..a69ce60 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -613,15 +613,16 @@ { struct gprs_rlcmac_sba *sba; int rc; + struct gprs_rlcmac_bts *bts = trx->bts; if (request->ID.UnionType) { struct gprs_rlcmac_ul_tbf *ul_tbf = NULL; struct pdch_ulc_node *item; uint32_t tlli = request->ID.u.TLLI; - GprsMs *ms = bts_ms_by_tlli(bts(), tlli, GSM_RESERVED_TMSI); + GprsMs *ms = bts_ms_by_tlli(bts, tlli, GSM_RESERVED_TMSI); if (!ms) { - ms = bts_alloc_ms(bts(), 0, 0); /* ms class updated later */ + ms = bts_alloc_ms(bts, 0, 0); /* ms class updated later */ ms_set_tlli(ms, tlli); } @@ -707,9 +708,9 @@ ms_set_egprs_ms_class(ms, egprs_ms_class); } - ul_tbf = tbf_alloc_ul_pacch(bts(), ms, trx_no()); + ul_tbf = tbf_alloc_ul_pacch(bts, ms, trx_no()); if (!ul_tbf) { - handle_tbf_reject(bts(), ms, trx_no(), ts_no); + handle_tbf_reject(bts, ms, trx_no(), ts_no); goto return_unref; } @@ -738,7 +739,7 @@ if (request->ID.u.Global_TFI.UnionType) { struct gprs_rlcmac_dl_tbf *dl_tbf; int8_t tfi = request->ID.u.Global_TFI.u.DOWNLINK_TFI; - dl_tbf = bts_dl_tbf_by_tfi(bts(), tfi, trx_no(), ts_no); + dl_tbf = bts_dl_tbf_by_tfi(bts, tfi, trx_no(), ts_no); if (!dl_tbf) { LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown downlink TFI=%d\n", tfi); return; @@ -751,7 +752,7 @@ } else { struct gprs_rlcmac_ul_tbf *ul_tbf; int8_t tfi = request->ID.u.Global_TFI.u.UPLINK_TFI; - ul_tbf = bts_ul_tbf_by_tfi(bts(), tfi, trx_no(), ts_no); + ul_tbf = bts_ul_tbf_by_tfi(bts, tfi, trx_no(), ts_no); if (!ul_tbf) { LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown uplink TFI=%d\n", tfi); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:33:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:33:04 +0000 Subject: Change in osmo-pcu[master]: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26079 ) Change subject: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() ...................................................................... tbf_ul: Improve documentation of tbf_alloc_ul_pacch() Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d --- M src/tbf_ul.cpp 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index f0d16b5..9390fbb 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -151,7 +151,12 @@ return tbf; } -/* Alloc a UL TBF to be assigned over PACCH */ +/* Alloc a UL TBF to be assigned over PACCH. Called when an MS requests to + * create a new UL TBF during the end of life of a previous UL TBF (or an SBA). + * In summary, this TBF is allocated as a consequence of receiving a "Pkt + * Resource Req" or "Pkt Ctrl Ack" from the MS. + * See TS 44.060 9.3.2.4.2 "Non-extended uplink TBF mode". + */ gprs_rlcmac_ul_tbf *tbf_alloc_ul_pacch(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx) { struct gprs_rlcmac_ul_tbf *tbf; @@ -162,6 +167,7 @@ /* Caller will most probably send a Imm Ass Reject after return */ return NULL; } + /* Contention resolution is considered to be done since TLLI is known in MS: */ tbf->m_contention_resolution_done = 1; osmo_fsm_inst_dispatch(tbf->state_fsm.fi, TBF_EV_ASSIGN_ADD_PACCH, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d Gerrit-Change-Number: 26079 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:33:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:33:05 +0000 Subject: Change in osmo-pcu[master]: Add counter for successful contention resolution procedures In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures ...................................................................... Add counter for successful contention resolution procedures This counter is related to succPDTCHSeizures, (3GPP TS 52.402 B.2.1.51 Successful PDTCH seizures). The relevant event when the first RLC block on the PDCH from the MS is received is the fact that contention resolution is considered as done in the network side. Hence, name the counter that way to ease interpretation. Related: SYS#4878 Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c --- M src/bts.cpp M src/bts.h M src/pdch.cpp M src/tbf_ul.cpp 4 files changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index d053396..2dc8ffb 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -147,6 +147,7 @@ { "immediate:assignment_UL", "Immediate Assign UL "}, { "immediate:assignment_ul:one_phase", "Immediate Assign UL (one phase packet access)"}, /* TS 52.402 B.2.1.50 */ { "immediate:assignment_ul:two_phase", "Immediate Assign UL (two phase packet access)"}, /* TS 52.402 B.2.1.50 */ + { "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */ { "immediate:assignment_rej", "Immediate Assign Rej "}, { "immediate:assignment_DL", "Immediate Assign DL "}, { "channel:request_description","Channel Request Desc "}, diff --git a/src/bts.h b/src/bts.h index d0119b6..3f482c9 100644 --- a/src/bts.h +++ b/src/bts.h @@ -139,6 +139,7 @@ CTR_IMMEDIATE_ASSIGN_UL_TBF, CTR_IMMEDIATE_ASSIGN_UL_TBF_ONE_PHASE, CTR_IMMEDIATE_ASSIGN_UL_TBF_TWO_PHASE, + CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS, CTR_IMMEDIATE_ASSIGN_REJ, CTR_IMMEDIATE_ASSIGN_DL_TBF, CTR_CHANNEL_REQUEST_DESCRIPTION, diff --git a/src/pdch.cpp b/src/pdch.cpp index a69ce60..fdac100 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -650,6 +650,8 @@ "MS requests UL TBF throguh SBA\n", fn); ms_set_ta(ms, sba->ta); sba_free(sba); + /* MS seized the PDCH answering on the SBA: */ + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS); break; case PDCH_ULC_NODE_TBF_POLL: if (item->tbf_poll.poll_tbf->direction != GPRS_RLCMAC_UL_TBF) { diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 9390fbb..1d06e53 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -332,6 +332,8 @@ /* now we must set this flag, so we are allowed to assign downlink * TBF on PACCH. it is only allowed when TLLI is acknowledged. */ m_contention_resolution_done = 1; + + bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS); } /*! \brief receive data from PDCH/L1 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:33:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:33:05 +0000 Subject: Change in osmo-pcu[master]: doc: Update counters_generated.adoc using osmo_vty_interact.py In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26122 ) Change subject: doc: Update counters_generated.adoc using osmo_vty_interact.py ...................................................................... doc: Update counters_generated.adoc using osmo_vty_interact.py osmo_interact_vty.py -c 'enable;show asciidoc counters' -p 4240 -H 127.0.0.1 -O doc/manuals/chapters/counters_generated.adoc Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 --- M doc/manuals/chapters/counters_generated.adoc 1 file changed, 169 insertions(+), 139 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc index 2ee425e..ac7d16a 100644 --- a/doc/manuals/chapters/counters_generated.adoc +++ b/doc/manuals/chapters/counters_generated.adoc @@ -1,9 +1,62 @@ + // autogenerated by show asciidoc counters -These counters and their description based on Osmo-PCU 0.4.0.4-8d55 (Osmo-PCU). +These counters and their description are based on OsmoPCU 0.9.0.244-de96 (OsmoPCU). + +=== Rate Counters // generating tables for rate_ctr_group +// rate_ctr_group table NSVC Peer Statistics +.ns:nsvc - NSVC Peer Statistics +[options="header"] +|=== +| Name | Reference | Description +| packets:in | <> | Packets at NS Level ( In) +| packets:out | <> | Packets at NS Level (Out) +| packets:out:drop | <> | Dropped Packets (Out) +| bytes:in | <> | Bytes at NS Level ( In) +| bytes:out | <> | Bytes at NS Level (Out) +| bytes:out:drop | <> | Dropped Bytes (Out) +| blocked | <> | NS-VC Block count +| unblocked | <> | NS-VC Unblock count +| dead | <> | NS-VC gone dead count +| replaced | <> | NS-VC replaced other count +| nsei-chg | <> | NS-VC changed NSEI count +| inv-nsvci | <> | NS-VCI was invalid count +| inv-nsei | <> | NSEI was invalid count +| lost:alive | <> | ALIVE ACK missing count +| lost:reset | <> | RESET ACK missing count +|=== +// rate_ctr_group table NSE Peer Statistics +.ns:nse - NSE Peer Statistics +[options="header"] +|=== +| Name | Reference | Description +| packets:in | <> | Packets at NS Level ( In) +| packets:out | <> | Packets at NS Level (Out) +| packets:out:drop | <> | Dropped Packets (Out) +| bytes:in | <> | Bytes at NS Level ( In) +| bytes:out | <> | Bytes at NS Level (Out) +| bytes:out:drop | <> | Dropped Bytes (Out) +| blocked | <> | NS-VC Block count +| unblocked | <> | NS-VC Unblock count +| dead | <> | NS-VC gone dead count +| replaced | <> | NS-VC replaced other count +| nsei-chg | <> | NS-VC changed NSEI count +| inv-nsvci | <> | NS-VCI was invalid count +| inv-nsei | <> | NSEI was invalid count +| lost:alive | <> | ALIVE ACK missing count +| lost:reset | <> | RESET ACK missing count +|=== +// rate_ctr_group table SGSN Statistics +.pcu:sgsn - SGSN Statistics +[options="header"] +|=== +| Name | Reference | Description +| rx_paging_cs | <> | Amount of paging CS requests received +| rx_paging_ps | <> | Amount of paging PS requests received +|=== // rate_ctr_group table BSSGP Peer Statistics -.bssgp:bss_ctx - BSSGP Peer Statistics +.bssgp:bss_ctx - BSSGP Peer Statistics [options="header"] |=== | Name | Reference | Description @@ -15,164 +68,141 @@ | discarded | <> | BVC LLC Discarded count | status | <> | BVC Status count |=== -// rate_ctr_group table NSVC Peer Statistics -.ns:nsvc - NSVC Peer Statistics -[options="header"] -|=== -| Name | Reference | Description -| packets:in | <> | Packets at NS Level ( In) -| packets:out | <> | Packets at NS Level (Out) -| bytes:in | <> | Bytes at NS Level ( In) -| bytes:out | <> | Bytes at NS Level (Out) -| blocked | <> | NS-VC Block count -| dead | <> | NS-VC gone dead count -| replaced | <> | NS-VC replaced other count -| nsei-chg | <> | NS-VC changed NSEI count -| inv-nsvci | <> | NS-VCI was invalid count -| inv-nsei | <> | NSEI was invalid count -| lost:alive | <> | ALIVE ACK missing count -| lost:reset | <> | RESET ACK missing count -|=== -// rate_ctr_group table NSVC Peer Statistics -.ns:nsvc - NSVC Peer Statistics -[options="header"] -|=== -| Name | Reference | Description -| packets:in | <> | Packets at NS Level ( In) -| packets:out | <> | Packets at NS Level (Out) -| bytes:in | <> | Bytes at NS Level ( In) -| bytes:out | <> | Bytes at NS Level (Out) -| blocked | <> | NS-VC Block count -| dead | <> | NS-VC gone dead count -| replaced | <> | NS-VC replaced other count -| nsei-chg | <> | NS-VC changed NSEI count -| inv-nsvci | <> | NS-VCI was invalid count -| inv-nsei | <> | NSEI was invalid count -| lost:alive | <> | ALIVE ACK missing count -| lost:reset | <> | RESET ACK missing count -|=== // rate_ctr_group table BTS Statistics -.bts - BTS Statistics +.bts - BTS Statistics [options="header"] |=== | Name | Reference | Description -| tbf:dl:alloc | <> | TBF DL Allocated -| tbf:dl:freed | <> | TBF DL Freed -| tbf:dl:aborted | <> | TBF DL Aborted -| tbf:ul:alloc | <> | TBF UL Allocated -| tbf:ul:freed | <> | TBF UL Freed -| tbf:ul:aborted | <> | TBF UL Aborted -| tbf:reused | <> | TBF Reused -| tbf:alloc:algo-a | <> | TBF Alloc Algo A -| tbf:alloc:algo-b | <> | TBF Alloc Algo B -| tbf:failed:egprs-only | <> | TBF Failed EGPRS-only -| rlc:sent | <> | RLC Sent -| rlc:resent | <> | RLC Resent -| rlc:restarted | <> | RLC Restarted -| rlc:stalled | <> | RLC Stalled -| rlc:nacked | <> | RLC Nacked -| rlc:final_block_resent | <> | RLC Final Blk resent -| rlc:ass:timedout | <> | RLC Assign Timeout -| rlc:ass:failed | <> | RLC Assign Failed -| rlc:ack:timedout | <> | RLC Ack Timeout -| rlc:ack:failed | <> | RLC Ack Failed -| rlc:rel:timedout | <> | RLC Release Timeout -| rlc:late-block | <> | RLC Late Block -| rlc:sent-dummy | <> | RLC Sent Dummy -| rlc:sent-control | <> | RLC Sent Control -| rlc:dl_bytes | <> | RLC DL Bytes -| rlc:dl_payload_bytes | <> | RLC DL Payload Bytes -| rlc:ul_bytes | <> | RLC UL Bytes -| rlc:ul_payload_bytes | <> | RLC UL Payload Bytes -| decode:errors | <> | Decode Errors -| sba:allocated | <> | SBA Allocated -| sba:freed | <> | SBA Freed -| sba:timedout | <> | SBA Timeout -| llc:timeout | <> | Timedout Frames -| llc:dropped | <> | Dropped Frames -| llc:scheduled | <> | Scheduled Frames +| tbf:dl:alloc | <> | TBF DL Allocated +| tbf:dl:freed | <> | TBF DL Freed +| tbf:dl:aborted | <> | TBF DL Aborted +| tbf:ul:alloc | <> | TBF UL Allocated +| tbf:ul:freed | <> | TBF UL Freed +| tbf:ul:aborted | <> | TBF UL Aborted +| tbf:reused | <> | TBF Reused +| tbf:alloc:algo-a | <> | TBF Alloc Algo A +| tbf:alloc:algo-b | <> | TBF Alloc Algo B +| tbf:alloc:failed | <> | TBF Alloc Failure (any reason) +| tbf:alloc:failed:no_tfi | <> | TBF Alloc Failure (TFIs exhausted) +| tbf:alloc:failed:no_usf | <> | TBF Alloc Failure (USFs exhausted) +| tbf:alloc:failed:no_slot_combi | <> | TBF Alloc Failure (No valid UL/DL slot combination found) +| tbf:alloc:failed:no_slot_avail | <> | TBF Alloc Failure (No slot available) +| rlc:sent | <> | RLC Sent +| rlc:resent | <> | RLC Resent +| rlc:restarted | <> | RLC Restarted +| rlc:stalled | <> | RLC Stalled +| rlc:nacked | <> | RLC Nacked +| rlc:final_block_resent | <> | RLC Final Blk resent +| rlc:ass:timedout | <> | RLC Assign Timeout +| rlc:ass:failed | <> | RLC Assign Failed +| rlc:ack:timedout | <> | RLC Ack Timeout +| rlc:ack:failed | <> | RLC Ack Failed +| rlc:rel:timedout | <> | RLC Release Timeout +| rlc:late-block | <> | RLC Late Block +| rlc:sent-dummy | <> | RLC Sent Dummy +| rlc:sent-control | <> | RLC Sent Control +| rlc:dl_bytes | <> | RLC DL Bytes +| rlc:dl_payload_bytes | <> | RLC DL Payload Bytes +| rlc:ul_bytes | <> | RLC UL Bytes +| rlc:ul_payload_bytes | <> | RLC UL Payload Bytes +| decode:errors | <> | Decode Errors +| sba:allocated | <> | SBA Allocated +| sba:freed | <> | SBA Freed +| sba:timedout | <> | SBA Timeout +| llc:timeout | <> | Timedout Frames +| llc:dropped | <> | Dropped Frames +| llc:scheduled | <> | Scheduled Frames | llc:dl_bytes | <> | RLC encapsulated PDUs -| llc:ul_bytes | <> | full PDUs received -| rach:requests | <> | RACH requests -| 11bit_rach:requests | <> | 11BIT_RACH requests -| spb:uplink_first_segment | <> | First seg of UL SPB -| spb:uplink_second_segment | <> | Second seg of UL SPB -| spb:downlink_first_segment | <> | First seg of DL SPB -| spb:downlink_second_segment | <> | Second seg of DL SPB -| immediate:assignment_UL | <> | Immediate Assign UL -| immediate:assignment_rej | <> | Immediate Assign Rej -| immediate:assignment_DL | <> | Immediate Assign DL -| channel:request_description | <> | Channel Request Desc -| pkt:ul_assignment | <> | Packet UL Assignment -| pkt:access_reject | <> | Packet Access Reject -| pkt:dl_assignment | <> | Packet DL Assignment -| ul:control | <> | UL control Block -| ul:assignment_poll_timeout | <> | UL Assign Timeout -| ul:assignment_failed | <> | UL Assign Failed -| dl:assignment_timeout | <> | DL Assign Timeout -| dl:assignment_failed | <> | DL Assign Failed -| pkt:ul_ack_nack_timeout | <> | PUAN Poll Timeout -| pkt:ul_ack_nack_failed | <> | PUAN poll Failed -| pkt:dl_ack_nack_timeout | <> | PDAN poll Timeout -| pkt:dl_ack_nack_failed | <> | PDAN poll Failed -| gprs:downlink_cs1 | <> | CS1 downlink -| gprs:downlink_cs2 | <> | CS2 downlink -| gprs:downlink_cs3 | <> | CS3 downlink -| gprs:downlink_cs4 | <> | CS4 downlink -| egprs:downlink_mcs1 | <> | MCS1 downlink -| egprs:downlink_mcs2 | <> | MCS2 downlink -| egprs:downlink_mcs3 | <> | MCS3 downlink -| egprs:downlink_mcs4 | <> | MCS4 downlink -| egprs:downlink_mcs5 | <> | MCS5 downlink -| egprs:downlink_mcs6 | <> | MCS6 downlink -| egprs:downlink_mcs7 | <> | MCS7 downlink -| egprs:downlink_mcs8 | <> | MCS8 downlink -| egprs:downlink_mcs9 | <> | MCS9 downlink -| gprs:uplink_cs1 | <> | CS1 Uplink -| gprs:uplink_cs2 | <> | CS2 Uplink -| gprs:uplink_cs3 | <> | CS3 Uplink -| gprs:uplink_cs4 | <> | CS4 Uplink -| egprs:uplink_mcs1 | <> | MCS1 Uplink -| egprs:uplink_mcs2 | <> | MCS2 Uplink -| egprs:uplink_mcs3 | <> | MCS3 Uplink -| egprs:uplink_mcs4 | <> | MCS4 Uplink -| egprs:uplink_mcs5 | <> | MCS5 Uplink -| egprs:uplink_mcs6 | <> | MCS6 Uplink -| egprs:uplink_mcs7 | <> | MCS7 Uplink -| egprs:uplink_mcs8 | <> | MCS8 Uplink -| egprs:uplink_mcs9 | <> | MCS9 Uplink +| llc:ul_bytes | <> | full PDUs received +| pch:requests | <> | PCH requests sent +| pch:requests:timeout | <> | PCH requests timeout +| rach:requests | <> | RACH requests received +| rach:requests:11bit | <> | 11BIT_RACH requests received +| rach:requests:one_phase | <> | One phase packet access with request for single TS UL +| rach:requests:two_phase | <> | Single block packet request for two phase packet access +| rach:requests:unexpected | <> | RACH Request with unexpected content received +| spb:uplink_first_segment | <> | First seg of UL SPB +| spb:uplink_second_segment | <> | Second seg of UL SPB +| spb:downlink_first_segment | <> | First seg of DL SPB +| spb:downlink_second_segment | <> | Second seg of DL SPB +| immediate:assignment_UL | <> | Immediate Assign UL +| immediate:assignment_ul:one_phase | <> | Immediate Assign UL (one phase packet access) +| immediate:assignment_ul:two_phase | <> | Immediate Assign UL (two phase packet access) +| immediate:assignment_ul:contention_resolution_success | <> | First RLC Block (PDU) on the PDTCH from the MS received +| immediate:assignment_rej | <> | Immediate Assign Rej +| immediate:assignment_DL | <> | Immediate Assign DL +| channel:request_description | <> | Channel Request Desc +| pkt:ul_assignment | <> | Packet UL Assignment +| pkt:access_reject | <> | Packet Access Reject +| pkt:dl_assignment | <> | Packet DL Assignment +| pkt:cell_chg_notification | <> | Packet Cell Change Notification +| pkt:cell_chg_continue | <> | Packet Cell Change Continue +| pkt:neigh_cell_data | <> | Packet Neighbour Cell Data +| ul:control | <> | UL control Block +| ul:assignment_poll_timeout | <> | UL Assign Timeout +| ul:assignment_failed | <> | UL Assign Failed +| dl:assignment_timeout | <> | DL Assign Timeout +| dl:assignment_failed | <> | DL Assign Failed +| pkt:ul_ack_nack_timeout | <> | PUAN Poll Timeout +| pkt:ul_ack_nack_failed | <> | PUAN poll Failed +| pkt:dl_ack_nack_timeout | <> | PDAN poll Timeout +| pkt:dl_ack_nack_failed | <> | PDAN poll Failed +| gprs:downlink_cs1 | <> | CS1 downlink +| gprs:downlink_cs2 | <> | CS2 downlink +| gprs:downlink_cs3 | <> | CS3 downlink +| gprs:downlink_cs4 | <> | CS4 downlink +| egprs:downlink_mcs1 | <> | MCS1 downlink +| egprs:downlink_mcs2 | <> | MCS2 downlink +| egprs:downlink_mcs3 | <> | MCS3 downlink +| egprs:downlink_mcs4 | <> | MCS4 downlink +| egprs:downlink_mcs5 | <> | MCS5 downlink +| egprs:downlink_mcs6 | <> | MCS6 downlink +| egprs:downlink_mcs7 | <> | MCS7 downlink +| egprs:downlink_mcs8 | <> | MCS8 downlink +| egprs:downlink_mcs9 | <> | MCS9 downlink +| gprs:uplink_cs1 | <> | CS1 Uplink +| gprs:uplink_cs2 | <> | CS2 Uplink +| gprs:uplink_cs3 | <> | CS3 Uplink +| gprs:uplink_cs4 | <> | CS4 Uplink +| egprs:uplink_mcs1 | <> | MCS1 Uplink +| egprs:uplink_mcs2 | <> | MCS2 Uplink +| egprs:uplink_mcs3 | <> | MCS3 Uplink +| egprs:uplink_mcs4 | <> | MCS4 Uplink +| egprs:uplink_mcs5 | <> | MCS5 Uplink +| egprs:uplink_mcs6 | <> | MCS6 Uplink +| egprs:uplink_mcs7 | <> | MCS7 Uplink +| egprs:uplink_mcs8 | <> | MCS8 Uplink +| egprs:uplink_mcs9 | <> | MCS9 Uplink |=== +=== Osmo Stat Items + // generating tables for osmo_stat_items NSVC Peer Statistics // osmo_stat_item_group table NSVC Peer Statistics -.ns.nsvc - NSVC Peer Statistics +.ns.nsvc - NSVC Peer Statistics [options="header"] |=== | Name | Reference | Description | Unit | alive.delay | <> | ALIVE response time | ms |=== -NSVC Peer Statistics -// osmo_stat_item_group table NSVC Peer Statistics -.ns.nsvc - NSVC Peer Statistics +NS Bind Statistics +// osmo_stat_item_group table NS Bind Statistics +.ns.bind - NS Bind Statistics [options="header"] |=== | Name | Reference | Description | Unit -| alive.delay | <> | ALIVE response time | ms +| tx_backlog_length | <> | Transmit backlog length | packets |=== BTS Statistics // osmo_stat_item_group table BTS Statistics -.bts - BTS Statistics +.bts - BTS Statistics [options="header"] |=== | Name | Reference | Description | Unit -| ms.present | <> | MS Present | +| ms.present | <> | MS Present | +| pdch.available | <> | PDCH available | +| pdch.occupied | <> | PDCH occupied (all) | +| pdch.occupied.gprs | <> | PDCH occupied (GPRS) | +| pdch.occupied.egprs | <> | PDCH occupied (EGPRS) | |=== -// generating tables for osmo_counters -// ungrouped osmo_counters -.ungrouped osmo counters -[options="header"] -|=== -| Name | Reference | Description -|=== - - +// there are no ungrouped osmo_counters -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I88e8e5548876fd6515e6bfcccec47bc48ba0ceb4 Gerrit-Change-Number: 26122 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:33:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:33:51 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c File src/bts_pch_timer.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c at 37 PS2, Line 37: p->ptmsi != GSM_RESERVED_TMSI > Above you already ensure that ptmsi != GSM_RESERVED_TMSI, so this check is redundant. I agree that in practice is not needed, but conceptually it makes to have it here, since the ptmsi being set is a precondition for checking it, so it's easier to understand the whole lifecycle of each struct and the use of the field. https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c at 87 PS2, Line 87: osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi)); > OSMO_STRLCPY_ARRAY(p->imsi, imsi); Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 18:33:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:34:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 18:34:39 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26168 ) Change subject: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a77714648d16ccff2a340ce775e83dcc5ffe707 Gerrit-Change-Number: 26168 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:35:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:35:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Improve counter validation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 ) Change subject: pcu: Improve counter validation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) looks like a lot of boilerplte code to me which could be improved by use of templates. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130/2/pcu/PCU_Tests.ttcn at 3946 PS2, Line 3946: name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req might be worth to ahave some kind of template for filling in this struct? the template cound default min/max to 0, and mtype to 'c', making this code much more compact. The valueof() could happen in f_statsd_expect(valueof(expect)); or even pushed into f_statsd_expect if the latter would accept a template argument. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff Gerrit-Change-Number: 26130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 18:35:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:35:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:35:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Use lower case for for counters assignment_{UL, DL} In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26153 ) Change subject: pcu: Use lower case for for counters assignment_{UL,DL} ...................................................................... Patch Set 1: Code-Review-1 marking as -1 as the corresponding change in osmo-pcu also has -1. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I417d3bb12b5af2f50dce6bc9dbb705b7d7a52bce Gerrit-Change-Number: 26153 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:39:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:39:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Improve counter validation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 ) Change subject: pcu: Improve counter validation ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130/2/pcu/PCU_Tests.ttcn at 3946 PS2, Line 3946: name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req > might be worth to ahave some kind of template for filling in this struct? the template cound defaul [?] Not sure it's really worth it, since in each test one wants to validate different values anyway... Also buring this more into some struct will make it more difficult to understand what are the expectancies for the counters imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff Gerrit-Change-Number: 26130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Mon, 08 Nov 2021 18:39:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:41:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:41:41 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 to look at the new patch set (#3). Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... bts_pch_timer: Fix timer working only for MI type IMSI This commit actually addresses 2 errors: 1- gprs_bssgp_pcu_rx_paging_ps() called gprs_rlcmac_paging_request() with MI which can be either TMSI or IMSI, and the later always called bts_pch_timer_start() passing mi->imsi regardless of the MI type. Hence, trash was being accessed & stored into bts_pch_timer structures if MI type used for paging was TMSI. 2- When the MS received the PS paging on CCCH and requests an UL TBF, it will send some data. If one phase access is used for whatever reason, the IMSI may not be yet available in the GprsMs object since we never received it (and we'd only have it by means of PktResourceReq). Hence, let's better first try to match the paging by TLLI/TMSI if set in both places, and otherwise use the IMSI. Related: OS#5297 Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 --- M src/bts_pch_timer.c M src/bts_pch_timer.h M src/gprs_bssgp_pcu.c M src/gprs_rlcmac.cpp M src/tbf_ul.cpp M tests/alloc/AllocTest.cpp M tests/alloc/AllocTest.err 7 files changed, 59 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/26166/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:41:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:41:45 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26161 ) Change subject: filesystem: fix decode_select_response ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:41:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:41:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:41:53 +0000 Subject: Change in osmo-pcu[master]: bts: Rename assignment_{UL, DL} to be all lower-case In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26126 ) Change subject: bts: Rename assignment_{UL,DL} to be all lower-case ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8de29c7e9dd8b17719dfeb784380c685377ce117 Gerrit-Change-Number: 26126 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:42:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:42:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Use lower case for for counters assignment_{UL, DL} In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26153 ) Change subject: pcu: Use lower case for for counters assignment_{UL,DL} ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I417d3bb12b5af2f50dce6bc9dbb705b7d7a52bce Gerrit-Change-Number: 26153 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:42:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:42:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Improve counter validation In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 ) Change subject: pcu: Improve counter validation ...................................................................... pcu: Improve counter validation Validate some new counters recently added in osmo-pcu. Related: SYS#4878 Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff --- M pcu/PCU_Tests.ttcn 1 file changed, 170 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 2daf89b..2cc6fad 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -2383,6 +2383,22 @@ var template (present) CodingScheme exp_dl_cs_mcs := cs_gprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); + + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } } testcase TC_mo_ping_pong_with_ul_racap_egprs_only() runs on RAW_PCU_Test_CT { @@ -2390,6 +2406,21 @@ var template (present) CodingScheme exp_dl_cs_mcs := mcs_egprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_default, ms_racap_egprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } } testcase TC_force_two_phase_access() runs on RAW_PCU_Test_CT { @@ -2400,6 +2431,22 @@ var template (present) CodingScheme exp_dl_cs_mcs := cs_gprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); + + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } } /* Test scenario where SGSN wants to send some data against MS and it is @@ -3054,6 +3101,7 @@ /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); /* Establish BSSGP connection to the PCU */ f_bssgp_establish(); @@ -3094,6 +3142,22 @@ /* ACK the ACK */ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3628,16 +3692,18 @@ var template GsmRrMessage imm_ass; var template IaRestOctets rest; var template EgprsUlAss ul_ass; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ signalling := { tag := '110011'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { var BIT5 ext_ra := int2bit(f_rnd_int(32), 5); req.signalling.random_bits := ext_ra; @@ -3649,6 +3715,21 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3656,16 +3737,18 @@ var template GsmRrMessage imm_ass; var template IaRestOctets rest; var template EgprsUlAss ul_ass; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ one_phase := { tag := '0'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { var BIT5 ext_ra := int2bit(f_rnd_int(32), 5); var BIT5 mslot_class := int2bit(f_rnd_int(32), 5); var BIT2 priority := substr(ext_ra, 0, 2); @@ -3683,6 +3766,21 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3690,16 +3788,18 @@ var template GsmRrMessage imm_ass; var template IaRestOctets rest; var template EgprsUlAss ul_ass; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ two_phase := { tag := '110000'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { var BIT5 ext_ra := int2bit(f_rnd_int(32), 5); var BIT2 priority := substr(ext_ra, 0, 2); var BIT3 rand := substr(ext_ra, 2, 3); @@ -3715,6 +3815,21 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3767,11 +3882,13 @@ testcase TC_egprs_pkt_chan_req_reject_content() runs on RAW_PCU_Test_CT { var template IARRestOctets rest; var BIT5 ext_ra; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { ext_ra := int2bit(f_rnd_int(32), 5); /* 5 LSB's of RA11 */ rest := tr_IARRestOctets({ *, tr_ExtRAOpt(ext_ra), * }); @@ -3779,6 +3896,20 @@ f_TC_egprs_pkt_chan_req_reject('111111'B & ext_ra, 1337 + i, rest); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3788,16 +3919,18 @@ var template IARRestOctets rest; var BIT5 ext_ra; var BIT11 ra11; + const integer num_req := 6; /* Initialize the PCU interface abstraction */ f_init_raw(testcasename()); + f_statsd_reset(); var EGPRSPktChRequest req := { /* NOTE: other fields are set in the loop */ emergency := { tag := '110111'B } }; - for (var integer i := 0; i < 6; i := i + 1) { + for (var integer i := 0; i < num_req; i := i + 1) { ext_ra := int2bit(f_rnd_int(32), 5); /* 5 LSB's of RA11 */ rest := tr_IARRestOctets({ *, tr_ExtRAOpt(ext_ra), * }); @@ -3808,6 +3941,20 @@ f_TC_egprs_pkt_chan_req_reject(ra11, 1337 + i, rest); } + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3826,6 +3973,7 @@ /* Initialize the PCU interface abstraction */ f_init_raw(testcasename(), info_ind); + f_statsd_reset(); var EGPRSPktChRequest req := { one_phase := { @@ -3849,6 +3997,23 @@ /* At this point, the IUT should run out of free USFs */ f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); + if (mp_osmo_pcu_newer_than_0_9_0) { + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); + } + f_shutdown(__BFILE__, __LINE__, final := true); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff Gerrit-Change-Number: 26130 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:42:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:42:40 +0000 Subject: Change in pysim[master]: filesystem: do not read AIDs when no apps are defined In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26162 ) Change subject: filesystem: do not read AIDs when no apps are defined ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8cfbee1d23e9f99461fa5f4fbf92c1a0929c50bf Gerrit-Change-Number: 26162 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:42:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:42:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:42:46 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: ping 3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 08 Nov 2021 18:42:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:42:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:42:56 +0000 Subject: Change in pysim[master]: filesystem: make sure the card is in a defined state In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26163 ) Change subject: filesystem: make sure the card is in a defined state ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I986204964903069bcce781afdbf3c5d26682b749 Gerrit-Change-Number: 26163 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:42:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:43:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Nov 2021 18:43:23 +0000 Subject: Change in pysim[master]: filesystem: define class byte and select control bytes in profile In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26164 ) Change subject: filesystem: define class byte and select control bytes in profile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2d175e28bd748a4871b1373273b3a9be9ae8c4d0 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:43:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:45:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 18:45:58 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c File src/bts_pch_timer.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c at 37 PS2, Line 37: p->ptmsi != GSM_RESERVED_TMSI > I agree that in practice is not needed, but conceptually it makes to have it here, since the ptmsi b [?] AFAIK, conditional statements in a loop are the evil in terms of performance. So I would avoid redundant checks. Of course, it depends on how often this function gets called. Not gonna block, just sharing my thoughts. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 18:45:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:48:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:48:15 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c File src/bts_pch_timer.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c at 37 PS2, Line 37: p->ptmsi != GSM_RESERVED_TMSI > AFAIK, conditional statements in a loop are the evil in terms of performance. [?] well it's an extra cmp & jmp, and we are not running over a thousand element array tight loop, we are iterating over a few items in a linked list, so not an issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Nov 2021 18:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:50:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Nov 2021 18:50:44 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c File src/bts_pch_timer.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c at 37 PS2, Line 37: p->ptmsi != GSM_RESERVED_TMSI > well it's an extra cmp & jmp, and we are not running over a thousand element array tight loop, we ar [?] Fine with me then. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Nov 2021 18:50:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:53:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:53:35 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26168 ) Change subject: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a77714648d16ccff2a340ce775e83dcc5ffe707 Gerrit-Change-Number: 26168 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 18:53:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:54:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:54:09 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 3: Code-Review+2 Readding previous +1 after applying change requested by fixeria. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Nov 2021 18:54:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:54:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:54:13 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 ) Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... bts_pch_timer: Fix timer working only for MI type IMSI This commit actually addresses 2 errors: 1- gprs_bssgp_pcu_rx_paging_ps() called gprs_rlcmac_paging_request() with MI which can be either TMSI or IMSI, and the later always called bts_pch_timer_start() passing mi->imsi regardless of the MI type. Hence, trash was being accessed & stored into bts_pch_timer structures if MI type used for paging was TMSI. 2- When the MS received the PS paging on CCCH and requests an UL TBF, it will send some data. If one phase access is used for whatever reason, the IMSI may not be yet available in the GprsMs object since we never received it (and we'd only have it by means of PktResourceReq). Hence, let's better first try to match the paging by TLLI/TMSI if set in both places, and otherwise use the IMSI. Related: OS#5297 Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 --- M src/bts_pch_timer.c M src/bts_pch_timer.h M src/gprs_bssgp_pcu.c M src/gprs_rlcmac.cpp M src/tbf_ul.cpp M tests/alloc/AllocTest.cpp M tests/alloc/AllocTest.err 7 files changed, 59 insertions(+), 21 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts_pch_timer.c b/src/bts_pch_timer.c index 20373ac..312d85a 100644 --- a/src/bts_pch_timer.c +++ b/src/bts_pch_timer.c @@ -26,8 +26,22 @@ #include #include #include +#include -static struct bts_pch_timer *bts_pch_timer_get(struct gprs_rlcmac_bts *bts, const char *imsi) +static struct bts_pch_timer *bts_pch_timer_get_by_ptmsi(struct gprs_rlcmac_bts *bts, uint32_t ptmsi) +{ + struct bts_pch_timer *p; + OSMO_ASSERT(ptmsi != GSM_RESERVED_TMSI); + + llist_for_each_entry(p, &bts->pch_timer, entry) { + if (p->ptmsi != GSM_RESERVED_TMSI && p->ptmsi == ptmsi) + return p; + } + + return NULL; +} + +static struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi) { struct bts_pch_timer *p; @@ -57,29 +71,46 @@ bts_pch_timer_remove(p); } -void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const char *imsi) +void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const struct osmo_mobile_identity *mi_paging, + const char *imsi) { - if (bts_pch_timer_get(bts, imsi)) + struct bts_pch_timer *p; + struct osmo_tdef *tdef; + + /* We already have a timer running for this IMSI */ + if (bts_pch_timer_get_by_imsi(bts, imsi)) return; - struct bts_pch_timer *p; p = talloc_zero(bts, struct bts_pch_timer); llist_add_tail(&p->entry, &bts->pch_timer); - osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi)); p->bts = bts; + OSMO_STRLCPY_ARRAY(p->imsi, imsi); + p->ptmsi = (mi_paging->type == GSM_MI_TYPE_TMSI) ? mi_paging->tmsi : GSM_RESERVED_TMSI; - struct osmo_tdef *tdef = osmo_tdef_get_entry(the_pcu->T_defs, 3113); + tdef = osmo_tdef_get_entry(the_pcu->T_defs, 3113); OSMO_ASSERT(tdef); osmo_timer_setup(&p->T3113, T3113_callback, p); osmo_timer_schedule(&p->T3113, tdef->val, 0); - LOGP(DPCU, LOGL_DEBUG, "PCH paging timer started for IMSI=%s\n", p->imsi); + if (log_check_level(DPCU, LOGL_DEBUG)) { + char str[64]; + osmo_mobile_identity_to_str_buf(str, sizeof(str), mi_paging); + LOGP(DPCU, LOGL_DEBUG, "PCH paging timer started for MI=%s IMSI=%s\n", str, p->imsi); + } } -void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const char *imsi) +void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const struct GprsMs *ms) { - struct bts_pch_timer *p = bts_pch_timer_get(bts, imsi); + struct bts_pch_timer *p = NULL; + uint32_t tlli = ms_tlli(ms); + const char *imsi = ms_imsi(ms); + /* First try matching by TMSI if available in MS */ + if (tlli != GSM_RESERVED_TMSI) + p = bts_pch_timer_get_by_ptmsi(bts, tlli); + /* Otherwise try matching by IMSI if available in MS */ + if (!p && imsi[0] != '\0') + p = bts_pch_timer_get_by_imsi(bts, imsi); if (p) bts_pch_timer_remove(p); } diff --git a/src/bts_pch_timer.h b/src/bts_pch_timer.h index 26b89c8..3e47161 100644 --- a/src/bts_pch_timer.h +++ b/src/bts_pch_timer.h @@ -32,11 +32,15 @@ struct llist_head entry; struct gprs_rlcmac_bts *bts; struct osmo_timer_list T3113; + uint32_t ptmsi; /* GSM_RESERVED_TMSI if not available */ char imsi[OSMO_IMSI_BUF_SIZE]; }; -void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const char *imsi); -void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const char *imsi); +struct GprsMs; + +void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const struct osmo_mobile_identity *mi_paging, + const char *imsi); +void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const struct GprsMs *ms); void bts_pch_timer_stop_all(struct gprs_rlcmac_bts *bts); #ifdef __cplusplus diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 0dd6cdc..424a381 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -39,6 +39,7 @@ #include "tbf_dl.h" #include "llc.h" #include "gprs_rlcmac.h" +#include "bts_pch_timer.h" /* Tuning parameters for BSSGP flow control */ #define FC_DEFAULT_LIFE_TIME_SECS 10 /* experimental value, 10s */ @@ -319,7 +320,9 @@ /* FIXME: look if MS is attached a specific BTS and then only page on that one? */ llist_for_each_entry(bts, &the_pcu->bts_list, list) { - gprs_rlcmac_paging_request(bts, &paging_mi, pgroup); + if (gprs_rlcmac_paging_request(bts, &paging_mi, pgroup) < 0) + continue; + bts_pch_timer_start(bts, &paging_mi, mi_imsi.imsi); } return 0; } diff --git a/src/gprs_rlcmac.cpp b/src/gprs_rlcmac.cpp index 22b12df..ffa656c 100644 --- a/src/gprs_rlcmac.cpp +++ b/src/gprs_rlcmac.cpp @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include @@ -49,7 +48,6 @@ return -1; } bts_do_rate_ctr_inc(bts, CTR_PCH_REQUESTS); - bts_pch_timer_start(bts, mi->imsi); pcu_l1if_tx_pch(bts, paging_request, plen, pgroup); bitvec_free(paging_request); diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 1d06e53..0282122 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -443,7 +443,7 @@ "Decoded premier TLLI=0x%08x of UL DATA TFI=%d.\n", new_tlli, rlc->tfi); update_ms(new_tlli, GPRS_RLCMAC_UL_TBF); - bts_pch_timer_stop(bts, ms_imsi(ms())); + bts_pch_timer_stop(bts, ms()); } else if (new_tlli != GSM_RESERVED_TMSI && new_tlli != tlli()) { LOGPTBFUL(this, LOGL_NOTICE, "Decoded TLLI=%08x mismatch on UL DATA TFI=%d. (Ignoring due to contention resolution)\n", diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index 35bbfc4..cd9c7bc 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -806,15 +806,17 @@ static void test_bts_pch_timer(void) { struct gprs_rlcmac_bts *bts = bts_alloc(the_pcu, 0); - const char *imsi1 = "1234"; - const char *imsi2 = "5678"; + struct osmo_mobile_identity mi_imsi1, mi_imsi2; + mi_imsi1.type = mi_imsi2.type = GSM_MI_TYPE_IMSI; + OSMO_STRLCPY_ARRAY(mi_imsi1.imsi, "1234"); + OSMO_STRLCPY_ARRAY(mi_imsi2.imsi, "5678"); fprintf(stderr, "Testing bts_pch_timer dealloc on bts dealloc\n"); log_set_category_filter(osmo_stderr_target, DPCU, 1, LOGL_DEBUG); fprintf(stderr, "Starting PCH timer for 2 IMSI\n"); - bts_pch_timer_start(bts, imsi1); - bts_pch_timer_start(bts, imsi2); + bts_pch_timer_start(bts, &mi_imsi1, mi_imsi1.imsi); + bts_pch_timer_start(bts, &mi_imsi2, mi_imsi2.imsi); fprintf(stderr, "Deallocating BTS, expecting the PCH timer to be stopped and deallocated\n"); talloc_free(bts); diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err index cb98332..53e2edd 100644 --- a/tests/alloc/AllocTest.err +++ b/tests/alloc/AllocTest.err @@ -501219,8 +501219,8 @@ DL_ASS_TBF(DL-TFI_1){NONE}: Deallocated Testing bts_pch_timer dealloc on bts dealloc Starting PCH timer for 2 IMSI -PCH paging timer started for IMSI=1234 -PCH paging timer started for IMSI=5678 +PCH paging timer started for MI=IMSI-1234 IMSI=1234 +PCH paging timer started for MI=IMSI-5678 IMSI=5678 Deallocating BTS, expecting the PCH timer to be stopped and deallocated PCH paging timer stopped for IMSI=1234 PCH paging timer stopped for IMSI=5678 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:54:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:54:13 +0000 Subject: Change in osmo-pcu[master]: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26167 ) Change subject: tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI ...................................................................... tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a --- M tests/alloc/AllocTest.cpp M tests/alloc/AllocTest.err 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index cd9c7bc..1f2bbda 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -807,9 +807,12 @@ { struct gprs_rlcmac_bts *bts = bts_alloc(the_pcu, 0); struct osmo_mobile_identity mi_imsi1, mi_imsi2; + struct osmo_mobile_identity mi_tmsi1; mi_imsi1.type = mi_imsi2.type = GSM_MI_TYPE_IMSI; + mi_tmsi1.type = GSM_MI_TYPE_TMSI; OSMO_STRLCPY_ARRAY(mi_imsi1.imsi, "1234"); OSMO_STRLCPY_ARRAY(mi_imsi2.imsi, "5678"); + mi_tmsi1.tmsi = 987654321; fprintf(stderr, "Testing bts_pch_timer dealloc on bts dealloc\n"); log_set_category_filter(osmo_stderr_target, DPCU, 1, LOGL_DEBUG); @@ -817,6 +820,8 @@ fprintf(stderr, "Starting PCH timer for 2 IMSI\n"); bts_pch_timer_start(bts, &mi_imsi1, mi_imsi1.imsi); bts_pch_timer_start(bts, &mi_imsi2, mi_imsi2.imsi); + fprintf(stderr, "Starting PCH timer for 1 TMSI\n"); + bts_pch_timer_start(bts, &mi_tmsi1, "6666"); fprintf(stderr, "Deallocating BTS, expecting the PCH timer to be stopped and deallocated\n"); talloc_free(bts); diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err index 53e2edd..1f86336 100644 --- a/tests/alloc/AllocTest.err +++ b/tests/alloc/AllocTest.err @@ -501221,6 +501221,9 @@ Starting PCH timer for 2 IMSI PCH paging timer started for MI=IMSI-1234 IMSI=1234 PCH paging timer started for MI=IMSI-5678 IMSI=5678 +Starting PCH timer for 1 TMSI +PCH paging timer started for MI=TMSI-0x3ADE68B1 IMSI=6666 Deallocating BTS, expecting the PCH timer to be stopped and deallocated PCH paging timer stopped for IMSI=1234 PCH paging timer stopped for IMSI=5678 +PCH paging timer stopped for IMSI=6666 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3673d387fa735b54fbc137ffaa18af581fa1b85a Gerrit-Change-Number: 26167 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 8 18:54:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 8 Nov 2021 18:54:14 +0000 Subject: Change in osmo-pcu[master]: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26168 ) Change subject: bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed ...................................................................... bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed Let's avoid flooding the BTS and taking CCCH resources for no good reason. If user configures everything correctly, the SGSN should not attempt a retry after similar timer >= T3113. Related: OS#5297 Change-Id: I2a77714648d16ccff2a340ce775e83dcc5ffe707 --- M src/bts.cpp M src/bts.h M src/bts_pch_timer.c M src/bts_pch_timer.h M src/gprs_bssgp_pcu.c 5 files changed, 9 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 2dc8ffb..dc20259 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -134,6 +134,7 @@ { "llc:dl_bytes", "RLC encapsulated PDUs"}, { "llc:ul_bytes", "full PDUs received "}, { "pch:requests", "PCH requests sent "}, + { "pch:requests:already", "PCH requests on subscriber already being paged"}, { "pch:requests:timeout", "PCH requests timeout "}, { "rach:requests", "RACH requests received"}, { "rach:requests:11bit", "11BIT_RACH requests received"}, diff --git a/src/bts.h b/src/bts.h index 3f482c9..3a58c63 100644 --- a/src/bts.h +++ b/src/bts.h @@ -126,6 +126,7 @@ CTR_LLC_DL_BYTES, CTR_LLC_UL_BYTES, CTR_PCH_REQUESTS, + CTR_PCH_REQUESTS_ALREADY, CTR_PCH_REQUESTS_TIMEDOUT, CTR_RACH_REQUESTS, CTR_RACH_REQUESTS_11BIT, diff --git a/src/bts_pch_timer.c b/src/bts_pch_timer.c index 312d85a..d721155 100644 --- a/src/bts_pch_timer.c +++ b/src/bts_pch_timer.c @@ -41,7 +41,7 @@ return NULL; } -static struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi) +struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi) { struct bts_pch_timer *p; @@ -77,10 +77,6 @@ struct bts_pch_timer *p; struct osmo_tdef *tdef; - /* We already have a timer running for this IMSI */ - if (bts_pch_timer_get_by_imsi(bts, imsi)) - return; - p = talloc_zero(bts, struct bts_pch_timer); llist_add_tail(&p->entry, &bts->pch_timer); p->bts = bts; diff --git a/src/bts_pch_timer.h b/src/bts_pch_timer.h index 3e47161..cc5dcb0 100644 --- a/src/bts_pch_timer.h +++ b/src/bts_pch_timer.h @@ -42,6 +42,7 @@ const char *imsi); void bts_pch_timer_stop(struct gprs_rlcmac_bts *bts, const struct GprsMs *ms); void bts_pch_timer_stop_all(struct gprs_rlcmac_bts *bts); +struct bts_pch_timer *bts_pch_timer_get_by_imsi(struct gprs_rlcmac_bts *bts, const char *imsi); #ifdef __cplusplus } diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 424a381..4328e07 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -320,6 +320,11 @@ /* FIXME: look if MS is attached a specific BTS and then only page on that one? */ llist_for_each_entry(bts, &the_pcu->bts_list, list) { + if (bts_pch_timer_get_by_imsi(bts, mi_imsi.imsi)) { + LOGP(DBSSGP, LOGL_INFO, "PS-Paging request already pending for IMSI=%s\n", mi_imsi.imsi); + bts_do_rate_ctr_inc(bts, CTR_PCH_REQUESTS_ALREADY); + continue; + } if (gprs_rlcmac_paging_request(bts, &paging_mi, pgroup) < 0) continue; bts_pch_timer_start(bts, &paging_mi, mi_imsi.imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a77714648d16ccff2a340ce775e83dcc5ffe707 Gerrit-Change-Number: 26168 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 01:11:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 01:11:46 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26169 ) Change subject: tests/stats: add VTY transcript tests ...................................................................... tests/stats: add VTY transcript tests Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Related: SYS#5713 --- M tests/Makefile.am A tests/stats/stats_vty_test.c A tests/stats/stats_vty_test.vty 3 files changed, 256 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/26169/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 0880561..b72619f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -73,6 +73,7 @@ if !EMBEDDED check_PROGRAMS += \ stats/stats_test \ + stats/stats_vty_test \ exec/exec_test endif @@ -89,6 +90,9 @@ stats_stats_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la stats_stats_test_CPPFLAGS = $(AM_CPPFLAGS) -I$(top_srcdir)/src +stats_stats_vty_test_SOURCES = stats/stats_vty_test.c +stats_stats_vty_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la + a5_a5_test_SOURCES = a5/a5_test.c a5_a5_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libgsmint.la @@ -374,6 +378,7 @@ comp128/comp128_test.ok bits/bitfield_test.ok \ utils/utils_test.ok utils/utils_test.err \ stats/stats_test.ok stats/stats_test.err \ + stats/stats_vty_test.vty \ bitvec/bitvec_test.ok msgb/msgb_test.ok bits/bitcomp_test.ok \ sim/sim_test.ok tlv/tlv_test.ok abis/abis_test.ok \ gsup/gsup_test.ok gsup/gsup_test.err \ @@ -677,12 +682,19 @@ -r "$(top_builddir)/tests/tdef/tdef_vty_test_dynamic" \ $(U) $(srcdir)/tdef/tdef_vty_test_dynamic.vty +vty-test-stats: + osmo_verify_transcript_vty.py -v \ + -p 42042 \ + -r "$(top_builddir)/tests/stats/stats_vty_test" \ + $(U) $(srcdir)/stats/*.vty + # don't run vty tests concurrently so that the ports don't conflict vty-test: $(MAKE) vty-test-logging $(MAKE) vty-test-vty $(MAKE) vty-test-tdef $(MAKE) vty-test-ns2 + $(MAKE) vty-test-stats ctrl-test: echo "No CTRL tests exist currently" diff --git a/tests/stats/stats_vty_test.c b/tests/stats/stats_vty_test.c new file mode 100644 index 0000000..f3742bd --- /dev/null +++ b/tests/stats/stats_vty_test.c @@ -0,0 +1,89 @@ +/* + * (C) 2021 by sysmocom s.f.m.c. GmbH + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +#include +#include + +#include +#include +#include +#include + +#include +#include +#include + +static void *root_ctx = NULL; +static int quit = 0; + +static void signal_handler(int signal) +{ + fprintf(stdout, "signal %u received\n", signal); + + switch (signal) { + case SIGINT: + case SIGTERM: + quit++; + break; + } +} + +static struct vty_app_info vty_info = { + .name = "stats_vty_test", +}; + +static const struct log_info_cat default_categories[] = { }; + +const struct log_info log_info = { + .cat = default_categories, + .num_cat = ARRAY_SIZE(default_categories), +}; + +int main(int argc, char **argv) +{ + int rc; + + root_ctx = talloc_named_const(NULL, 0, "stats_vty_test"); + + osmo_init_logging2(root_ctx, &log_info); + + vty_info.tall_ctx = root_ctx; + vty_init(&vty_info); + + osmo_stats_vty_add_cmds(); + + rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + if (rc < 0) + return 2; + + signal(SIGINT, &signal_handler); + signal(SIGTERM, &signal_handler); + osmo_init_ignore_signals(); + + while (!quit) + osmo_select_main(0); + + talloc_free(tall_vty_ctx); + talloc_free(root_ctx); + + return 0; +} diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty new file mode 100644 index 0000000..4ec03c9 --- /dev/null +++ b/tests/stats/stats_vty_test.vty @@ -0,0 +1,155 @@ +stats_vty_test> en +stats_vty_test# configure terminal +stats_vty_test(config)# list +... + stats reporter statsd + no stats reporter statsd + stats reporter log + no stats reporter log + stats interval <0-65535> +... + +stats_vty_test(config)# ### No reporters shall be configured by default +stats_vty_test(config)# show running-config +... !stats reporter + + +stats_vty_test(config)# ### Create a statsd reporter +stats_vty_test(config)# stats reporter statsd +stats_vty_test(config-stats)# list +... + local-ip ADDR + no local-ip + remote-ip ADDR + remote-port <1-65535> + mtu <100-65535> + no mtu + prefix PREFIX + no prefix + level (global|peer|subscriber) + enable + disable + flush-period <0-65535> +... + +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + level global + no prefix +stats interval 5 +... + +stats_vty_test(config-stats)# level subscriber +stats_vty_test(config-stats)# prefix statsd-prefix +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + level subscriber + prefix statsd-prefix +... + +stats_vty_test(config-stats)# remote-ip 192.168.1.200 +stats_vty_test(config-stats)# remote-port 6969 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 +... !local-ip + +stats_vty_test(config-stats)# local-ip 192.168.1.100 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + local-ip 192.168.1.100 +... + +stats_vty_test(config-stats)# no local-ip +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd +... !local-ip + +stats_vty_test(config-stats)# mtu 1337 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + mtu 1337 +... + +stats_vty_test(config-stats)# no mtu +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd +... !mtu + +stats_vty_test(config-stats)# flush-period 43556 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + flush-period 43556 +... + +stats_vty_test(config-stats)# flush-period 0 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd +... !flush-period + +stats_vty_test(config-stats)# enable +stats_vty_test(config-stats)# exit +stats_vty_test(config)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + enable +... + + +stats_vty_test(config)# ### Create a statsd reporter +stats_vty_test(config)# stats reporter log +stats_vty_test(config-stats)# level peer +stats_vty_test(config-stats)# prefix log-prefix +stats_vty_test(config-stats)# enable +stats_vty_test(config-stats)# exit +stats_vty_test(config)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + enable +stats reporter log + disable + level peer + prefix log-prefix + enable +... + + +stats_vty_test(config)# stats interval 1337 +stats_vty_test(config)# show running-config +... +stats interval 1337 +... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 01:11:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 01:11:46 +0000 Subject: Change in libosmocore[master]: stats: use llist_add_tail() in osmo_stats_reporter_alloc() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26170 ) Change subject: stats: use llist_add_tail() in osmo_stats_reporter_alloc() ...................................................................... stats: use llist_add_tail() in osmo_stats_reporter_alloc() This allows printing reporters to the VTY in the exact order as they were configired. Otherwise the list gets reversed. Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Related: SYS#5713 --- M src/stats.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/26170/1 diff --git a/src/stats.c b/src/stats.c index 28a3ab3..0967305 100644 --- a/src/stats.c +++ b/src/stats.c @@ -223,7 +223,7 @@ srep->name = talloc_strdup(srep, name); srep->fd = -1; - llist_add(&srep->list, &osmo_stats_reporter_list); + llist_add_tail(&srep->list, &osmo_stats_reporter_list); return srep; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Gerrit-Change-Number: 26170 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 01:11:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 01:11:46 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... stats: allow configuring reporter's name in the VTY This allows configuring more than one reporter of the given type. Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Related: SYS#5713 --- M include/osmocom/core/stats.h M src/stats.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 4 files changed, 121 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/26171/1 diff --git a/include/osmocom/core/stats.h b/include/osmocom/core/stats.h index b9edac2..c4f71c8 100644 --- a/include/osmocom/core/stats.h +++ b/include/osmocom/core/stats.h @@ -108,6 +108,7 @@ int interval; }; +extern struct llist_head osmo_stats_reporter_list; extern struct osmo_stats_config *osmo_stats_config; void osmo_stats_init(void *ctx); diff --git a/src/stats.c b/src/stats.c index 0967305..702e408 100644 --- a/src/stats.c +++ b/src/stats.c @@ -106,7 +106,7 @@ #define STATS_DEFAULT_INTERVAL 5 /* secs */ #define STATS_DEFAULT_BUFLEN 256 -static LLIST_HEAD(osmo_stats_reporter_list); +LLIST_HEAD(osmo_stats_reporter_list); static void *osmo_stats_ctx = NULL; static int is_initialised = 0; diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 17e7190..a4fc6ea 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -269,14 +269,20 @@ } DEFUN(cfg_stats_reporter_statsd, cfg_stats_reporter_statsd_cmd, - "stats reporter statsd", - CFG_STATS_STR CFG_REPORTER_STR "Report to a STATSD server\n") + "stats reporter statsd [NAME]", + CFG_STATS_STR CFG_REPORTER_STR + "Report to a STATSD server\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name); if (!srep) { - srep = osmo_stats_reporter_create_statsd(NULL); + srep = osmo_stats_reporter_create_statsd(name); if (!srep) { vty_out(vty, "%% Unable to create statsd reporter%s", VTY_NEWLINE); @@ -293,12 +299,18 @@ } DEFUN(cfg_no_stats_reporter_statsd, cfg_no_stats_reporter_statsd_cmd, - "no stats reporter statsd", - NO_STR CFG_STATS_STR CFG_REPORTER_STR "Report to a STATSD server\n") + "no stats reporter statsd [NAME]", + NO_STR CFG_STATS_STR CFG_REPORTER_STR + "Report to a STATSD server\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name); if (!srep) { vty_out(vty, "%% No statsd logging active%s", VTY_NEWLINE); @@ -311,14 +323,20 @@ } DEFUN(cfg_stats_reporter_log, cfg_stats_reporter_log_cmd, - "stats reporter log", - CFG_STATS_STR CFG_REPORTER_STR "Report to the logger\n") + "stats reporter log [NAME]", + CFG_STATS_STR CFG_REPORTER_STR + "Report to the logger\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name); if (!srep) { - srep = osmo_stats_reporter_create_log(NULL); + srep = osmo_stats_reporter_create_log(name); if (!srep) { vty_out(vty, "%% Unable to create log reporter%s", VTY_NEWLINE); @@ -335,12 +353,18 @@ } DEFUN(cfg_no_stats_reporter_log, cfg_no_stats_reporter_log_cmd, - "no stats reporter log", - NO_STR CFG_STATS_STR CFG_REPORTER_STR "Report to the logger\n") + "no stats reporter log [NAME]", + NO_STR CFG_STATS_STR CFG_REPORTER_STR + "Report to the logger\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name); if (!srep) { vty_out(vty, "%% No log reporting active%s", VTY_NEWLINE); @@ -598,18 +622,22 @@ static int config_write_stats_reporter(struct vty *vty, struct osmo_stats_reporter *srep) { - if (srep == NULL) - return 0; + const char *type = NULL; switch (srep->type) { case OSMO_STATS_REPORTER_STATSD: - vty_out(vty, "stats reporter statsd%s", VTY_NEWLINE); + type = "statsd"; break; case OSMO_STATS_REPORTER_LOG: - vty_out(vty, "stats reporter log%s", VTY_NEWLINE); + type = "log"; break; } + vty_out(vty, "stats reporter %s", type); + if (srep->name != NULL) + vty_out(vty, " %s", srep->name); + vty_out(vty, "%s", VTY_NEWLINE); + vty_out(vty, " disable%s", VTY_NEWLINE); if (srep->have_net_config) { @@ -652,11 +680,9 @@ { struct osmo_stats_reporter *srep; - /* TODO: loop through all reporters */ - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, NULL); - config_write_stats_reporter(vty, srep); - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, NULL); - config_write_stats_reporter(vty, srep); + /* Loop through all reporters */ + llist_for_each_entry(srep, &osmo_stats_reporter_list, list) + config_write_stats_reporter(vty, srep); vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index 4ec03c9..017b188 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -2,10 +2,10 @@ stats_vty_test# configure terminal stats_vty_test(config)# list ... - stats reporter statsd - no stats reporter statsd - stats reporter log - no stats reporter log + stats reporter statsd [NAME] + no stats reporter statsd [NAME] + stats reporter log [NAME] + no stats reporter log [NAME] stats interval <0-65535> ... @@ -148,6 +148,72 @@ ... +stats_vty_test(config)# ### Create an additional statsd reporter +stats_vty_test(config)# stats reporter statsd statsd-foo +stats_vty_test(config-stats)# level global +stats_vty_test(config-stats)# prefix statsd-one-prefix +stats_vty_test(config-stats)# remote-ip 192.168.2.200 +stats_vty_test(config-stats)# remote-port 9696 +stats_vty_test(config-stats)# flush-period 1 +stats_vty_test(config-stats)# exit + +stats_vty_test(config)# ### Create an additional log reporter +stats_vty_test(config)# stats reporter log log-bar +stats_vty_test(config-stats)# level global +stats_vty_test(config-stats)# prefix log-bar-prefix +stats_vty_test(config-stats)# flush-period 2 +stats_vty_test(config-stats)# exit + +stats_vty_test(config)# ### Create an additional log reporter +stats_vty_test(config)# stats reporter log log-zoo +stats_vty_test(config-stats)# level global +stats_vty_test(config-stats)# prefix log-zoo-prefix +stats_vty_test(config-stats)# flush-period 3 +stats_vty_test(config-stats)# exit + +stats_vty_test(config)# ### We should have 5 reporters now +stats_vty_test(config)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + enable +stats reporter log + disable + level peer + prefix log-prefix + enable +stats reporter statsd statsd-foo + disable + remote-ip 192.168.2.200 + remote-port 9696 + level global + prefix statsd-one-prefix + flush-period 1 +stats reporter log log-bar + disable + level global + prefix log-bar-prefix + flush-period 2 +stats reporter log log-zoo + disable + level global + prefix log-zoo-prefix + flush-period 3 +... + + +stats_vty_test(config)# ### Test removing reporters +stats_vty_test(config)# no stats reporter statsd statsd-foo +stats_vty_test(config)# no stats reporter log log-bar +stats_vty_test(config)# no stats reporter log log-zoo +stats_vty_test(config)# show running-config +... !(foo|bar|zoo) + + stats_vty_test(config)# stats interval 1337 stats_vty_test(config)# show running-config ... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 01:30:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 01:30:10 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26169 to look at the new patch set (#2). Change subject: tests/stats: add VTY transcript tests ...................................................................... tests/stats: add VTY transcript tests Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Related: SYS#5713 --- M tests/Makefile.am A tests/stats/stats_vty_test.c A tests/stats/stats_vty_test.vty 3 files changed, 255 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/26169/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 01:35:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 01:35:39 +0000 Subject: Change in libosmocore[master]: stats: use llist_add_tail() in osmo_stats_reporter_alloc() In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26170 to look at the new patch set (#3). Change subject: stats: use llist_add_tail() in osmo_stats_reporter_alloc() ...................................................................... stats: use llist_add_tail() in osmo_stats_reporter_alloc() This allows printing reporters in the exact order as they were configired. Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Related: SYS#5713 --- M src/stats.c M tests/stats/stats_test.err 2 files changed, 35 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/26170/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Gerrit-Change-Number: 26170 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 9 03:28:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 09 Nov 2021 03:28:50 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6189eb0fd4578_2ea32b0a73cf05f015546d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 100s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 100s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 100s] [ 101s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 101s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 101s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 101s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 101s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 101s] 4/4 Test #4: websocket ........................ Passed 0.78 sec [ 101s] [ 101s] 75% tests passed, 1 tests failed out of 4 [ 101s] [ 101s] Total Test time (real) = 0.80 sec [ 101s] [ 101s] The following tests FAILED: [ 101s] 3 - framework (Failed) [ 101s] Errors while running CTest [ 101s] make[1]: *** [Makefile:129: test] Error 8 [ 101s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 101s] dh_auto_test: error: cd build && make -j6 test ARGS\+=--verbose ARGS\+=-j6 returned exit code 2 [ 101s] make: *** [debian/rules:9: build] Error 25 [ 101s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 101s] ### VM INTERACTION START ### [ 104s] [ 90.409775] sysrq: Power Off [ 104s] [ 90.414196] reboot: Power down [ 104s] ### VM INTERACTION END ### [ 104s] [ 104s] sheep86 failed "build ulfius_2.5.2-4.2.dsc" at Tue Nov 9 03:28:42 UTC 2021. [ 104s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 9 03:31:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 09 Nov 2021 03:31:41 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6189eba66dbcc_2ea32b0a73cf05f015548e4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 135s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 135s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 135s] [ 135s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 135s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 135s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 135s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 135s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 135s] 4/4 Test #4: websocket ........................ Passed 0.63 sec [ 135s] [ 135s] 75% tests passed, 1 tests failed out of 4 [ 135s] [ 135s] Total Test time (real) = 0.65 sec [ 135s] [ 135s] The following tests FAILED: [ 135s] 3 - framework (Failed) [ 135s] Errors while running CTest [ 135s] make[1]: *** [Makefile:129: test] Error 8 [ 135s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 135s] dh_auto_test: error: cd build && make -j4 test ARGS\+=--verbose ARGS\+=-j4 returned exit code 2 [ 135s] make: *** [debian/rules:9: build] Error 25 [ 135s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 135s] ### VM INTERACTION START ### [ 138s] [ 121.040803] sysrq: Power Off [ 138s] [ 121.043823] reboot: Power down [ 139s] ### VM INTERACTION END ### [ 139s] [ 139s] old-cirrus1 failed "build ulfius_2.5.2-4.2.dsc" at Tue Nov 9 03:31:33 UTC 2021. [ 139s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 9 07:47:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 07:47:53 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26172 ) Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In Osmocom core, we have the following written in one line: while (osmo_select_main_ctx(1) > 0); This currently causes the following linter error: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line According to the linter, we should write it as follows: while (osmo_select_main_ctx(1) > 0) ; But this is not followed in Osmocom code, so let's ignore the check. Related: OS#5087 Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/26172/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index f9cc74f..ec9384c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -69,6 +69,7 @@ # * SPDX_LICENSE_TAG: we don't place it on line 1 # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability +# * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) @@ -103,6 +104,7 @@ --ignore SPDX_LICENSE_TAG \ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ + --ignore TRAILING_STATEMENTS \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ --max-line-length 120 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 07:48:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 07:48:54 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 6: The remaining linter error TRAILING_STATEMENTS does not seem useful for Osmocom code, so I've submitted this patch to disable it: https://gerrit.osmocom.org/c/osmo-ci/+/26172 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Tue, 09 Nov 2021 07:48:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 08:03:00 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Nov 2021 08:03:00 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: (1 comment) (sorry, should have reviewed a lot sooner) https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c at 216 PS3, Line 216: lchan = &ts->lchan[i]; For dyn TS in TCH mode, the primary lchans are each shadowed by a VAMOS lchan (1 VAMOS for TCH/F, 2 VAMOS for TCH/H). For SDCCH8, there should be no VAMOS secondary at all. But for SDCCH8, ts->max_primary_lchans should be 8, and ts->max_lchans_possible should also be 8. So I wonder why this extra condition is needed at all? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Nov 2021 08:03:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 9 09:44:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 09 Nov 2021 09:44:02 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618a42f1ce35a_2ea32b0a73cf05f0165545a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 68s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 68s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 68s] [ 68s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 68s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 68s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 68s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 68s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 68s] 4/4 Test #4: websocket ........................ Passed 0.78 sec [ 68s] [ 68s] 75% tests passed, 1 tests failed out of 4 [ 68s] [ 68s] Total Test time (real) = 0.78 sec [ 68s] [ 68s] The following tests FAILED: [ 68s] 3 - framework (Failed) [ 68s] Errors while running CTest [ 68s] make[1]: *** [Makefile:129: test] Error 8 [ 68s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 68s] dh_auto_test: error: cd build && make -j8 test ARGS\+=--verbose ARGS\+=-j8 returned exit code 2 [ 68s] make: *** [debian/rules:9: build] Error 25 [ 68s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 68s] ### VM INTERACTION START ### [ 71s] [ 63.760791] sysrq: Power Off [ 71s] [ 63.764268] reboot: Power down [ 72s] ### VM INTERACTION END ### [ 72s] [ 72s] goat03 failed "build ulfius_2.5.2-4.2.dsc" at Tue Nov 9 09:43:51 UTC 2021. [ 72s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 9 09:45:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 09 Nov 2021 09:45:27 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618a434e4768c_2ea32b0a73cf05f01655788@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 68s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 68s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 68s] [ 69s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 69s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 69s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 69s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 69s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 69s] 4/4 Test #4: websocket ........................ Passed 0.72 sec [ 69s] [ 69s] 75% tests passed, 1 tests failed out of 4 [ 69s] [ 69s] Total Test time (real) = 0.72 sec [ 69s] [ 69s] The following tests FAILED: [ 69s] 3 - framework (Failed) [ 69s] Errors while running CTest [ 69s] make[1]: *** [Makefile:129: test] Error 8 [ 69s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 69s] dh_auto_test: error: cd build && make -j8 test ARGS\+=--verbose ARGS\+=-j8 returned exit code 2 [ 69s] make: *** [debian/rules:9: build] Error 25 [ 69s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 69s] ### VM INTERACTION START ### [ 72s] [ 62.997540] sysrq: Power Off [ 72s] [ 63.001110] reboot: Power down [ 72s] ### VM INTERACTION END ### [ 72s] [ 72s] goat03 failed "build ulfius_2.5.2-4.2.dsc" at Tue Nov 9 09:45:24 UTC 2021. [ 72s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:18:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 10:18:16 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Tue, 09 Nov 2021 10:18:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:23:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 10:23:44 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c at 687 PS3, Line 687: vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); Not important, but it may be now better to have this before the list, so to have common param before the list. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:23:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:24:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 10:24:31 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26169 ) Change subject: tests/stats: add VTY transcript tests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:24:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 10:24:47 +0000 Subject: Change in libosmocore[master]: stats: use llist_add_tail() in osmo_stats_reporter_alloc() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26170 ) Change subject: stats: use llist_add_tail() in osmo_stats_reporter_alloc() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Gerrit-Change-Number: 26170 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:24:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:25:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 10:25:14 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26172 ) Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:25:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:31:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 10:31:54 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26169 ) Change subject: tests/stats: add VTY transcript tests ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26169/2/tests/stats/stats_vty_test.vty File tests/stats/stats_vty_test.vty: https://gerrit.osmocom.org/c/libosmocore/+/26169/2/tests/stats/stats_vty_test.vty at 124 PS2, Line 124: enable is it intentional that it lists both disable and enable? not an issue with this patch, so giving +1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:31:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:32:57 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 10:32:57 +0000 Subject: Change in libosmocore[master]: stats: use llist_add_tail() in osmo_stats_reporter_alloc() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26170 ) Change subject: stats: use llist_add_tail() in osmo_stats_reporter_alloc() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Gerrit-Change-Number: 26170 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:32:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:37:06 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:37:06 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26169 ) Change subject: tests/stats: add VTY transcript tests ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26169/2/tests/stats/stats_vty_test.vty File tests/stats/stats_vty_test.vty: https://gerrit.osmocom.org/c/libosmocore/+/26169/2/tests/stats/stats_vty_test.vty at 124 PS2, Line 124: enable > is it intentional that it lists both disable and enable? [?] I also find it weird. I can change it to print either 'disable' or 'enable' in a follow up patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:37:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:37:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:37:27 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c at 687 PS3, Line 687: vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); > Not important, but it may be now better to have this before the list, so to have common param before [?] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:37:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:38:23 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 10:38:23 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c at 216 PS3, Line 216: lchan = &ts->lchan[i]; > For dyn TS in TCH mode, the primary lchans are each shadowed by a VAMOS lchan [?] pchan_is=GSM_PCHAN_TCH_F In this case we have: ts->max_primary_lchans = 1 max_lchans_possible_vamos = 2; ts->max_lchans_possible = 8; /*DYNTS*/ With previous code, the following happens: lchan[0].vamos.is_secondary = false lchan[1].vamos.is_secondary = true lchan[2].vamos.is_secondary = true lchan[3].vamos.is_secondary = true lchan[4].vamos.is_secondary = true lchan[5].vamos.is_secondary = true lchan[6].vamos.is_secondary = true lchan[7].vamos.is_secondary = true While with the new patch, the following should happen: lchan[0].vamos.is_secondary = false lchan[1].vamos.is_secondary = true lchan[2].vamos.is_secondary = false lchan[3].vamos.is_secondary = false lchan[4].vamos.is_secondary = false lchan[5].vamos.is_secondary = false lchan[6].vamos.is_secondary = false lchan[7].vamos.is_secondary = false -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Nov 2021 10:38:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:44:52 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 10:44:52 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c at 369 PS3, Line 369: vty_out(vty, "%% No log reporting active%s", Maybe change the message here, depending on "name" being NULL or not. It may be active, but not with the given "name". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:44:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:47:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:47:42 +0000 Subject: Change in libosmocore[master]: stats: cosmetic: print 'stats interval' before the reporters References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26173 ) Change subject: stats: cosmetic: print 'stats interval' before the reporters ...................................................................... stats: cosmetic: print 'stats interval' before the reporters It's better to have the common parameters printed first. Change-Id: Ifb401d4d363fb70e89960ca739baba5ee55eefe8 Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/73/26173/1 diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index a4fc6ea..48e4f1c 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -680,12 +680,12 @@ { struct osmo_stats_reporter *srep; + vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); + /* Loop through all reporters */ llist_for_each_entry(srep, &osmo_stats_reporter_list, list) config_write_stats_reporter(vty, srep); - vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); - return 1; } diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index 017b188..7c01d3f 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -34,11 +34,11 @@ stats_vty_test(config-stats)# show running-config ... +stats interval 5 stats reporter statsd disable level global no prefix -stats interval 5 ... stats_vty_test(config-stats)# level subscriber -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifb401d4d363fb70e89960ca739baba5ee55eefe8 Gerrit-Change-Number: 26173 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:47:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:47:43 +0000 Subject: Change in libosmocore[master]: stats: don't mark reporter as 'disable' beforehand References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26174 ) Change subject: stats: don't mark reporter as 'disable' beforehand ...................................................................... stats: don't mark reporter as 'disable' beforehand Change-Id: I330a079807cca48b7cc43767abcd2b58830a05fc Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 6 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/26174/1 diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 48e4f1c..308bab6 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -638,8 +638,6 @@ vty_out(vty, " %s", srep->name); vty_out(vty, "%s", VTY_NEWLINE); - vty_out(vty, " disable%s", VTY_NEWLINE); - if (srep->have_net_config) { if (srep->dest_addr_str) vty_out(vty, " remote-ip %s%s", @@ -672,6 +670,8 @@ if (srep->enabled) vty_out(vty, " enable%s", VTY_NEWLINE); + else + vty_out(vty, " disable%s", VTY_NEWLINE); return 1; } diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index 7c01d3f..ddfb3a6 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -36,9 +36,9 @@ ... stats interval 5 stats reporter statsd - disable level global no prefix + disable ... stats_vty_test(config-stats)# level subscriber @@ -46,7 +46,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable level subscriber prefix statsd-prefix ... @@ -56,7 +55,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 ... !local-ip @@ -65,7 +63,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 local-ip 192.168.1.100 @@ -81,7 +78,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 mtu 1337 @@ -97,7 +93,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber @@ -116,7 +111,6 @@ stats_vty_test(config)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber @@ -134,14 +128,12 @@ stats_vty_test(config)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber prefix statsd-prefix enable stats reporter log - disable level peer prefix log-prefix enable @@ -175,34 +167,32 @@ stats_vty_test(config)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber prefix statsd-prefix enable stats reporter log - disable level peer prefix log-prefix enable stats reporter statsd statsd-foo - disable remote-ip 192.168.2.200 remote-port 9696 level global prefix statsd-one-prefix flush-period 1 -stats reporter log log-bar disable +stats reporter log log-bar level global prefix log-bar-prefix flush-period 2 -stats reporter log log-zoo disable +stats reporter log log-zoo level global prefix log-zoo-prefix flush-period 3 + disable ... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I330a079807cca48b7cc43767abcd2b58830a05fc Gerrit-Change-Number: 26174 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:48:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:48:14 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c at 687 PS3, Line 687: vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); > Ack https://gerrit.osmocom.org/c/libosmocore/+/26173 stats: cosmetic: print 'stats interval' before the reporters -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:48:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 10:48:22 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In-Reply-To: References: Message-ID: Hello Jenkins Builder, neels, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 to look at the new patch set (#2). Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In Osmocom code, we have the following written in one line: while (osmo_select_main_ctx(1) > 0); This currently causes the following linter error: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line According to the linter, we should write it as follows: while (osmo_select_main_ctx(1) > 0) ; But this is not followed in Osmocom code, so let's ignore the check. Related: OS#5087 Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/26172/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:48:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:48:44 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26169 ) Change subject: tests/stats: add VTY transcript tests ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26169/2/tests/stats/stats_vty_test.vty File tests/stats/stats_vty_test.vty: https://gerrit.osmocom.org/c/libosmocore/+/26169/2/tests/stats/stats_vty_test.vty at 124 PS2, Line 124: enable > I also find it weird. I can change it to print either 'disable' or 'enable' in a follow up patch. https://gerrit.osmocom.org/c/libosmocore/+/26174 stats: don't mark reporter as 'disable' beforehand -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:48:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:48:55 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:48:55 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26169 ) Change subject: tests/stats: add VTY transcript tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:48:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:48:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 10:48:59 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:48:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:49:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 10:49:25 +0000 Subject: Change in libosmocore[master]: stats: cosmetic: print 'stats interval' before the reporters In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26173 ) Change subject: stats: cosmetic: print 'stats interval' before the reporters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifb401d4d363fb70e89960ca739baba5ee55eefe8 Gerrit-Change-Number: 26173 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 09 Nov 2021 10:49:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:49:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 10:49:54 +0000 Subject: Change in libosmocore[master]: stats: don't mark reporter as 'disable' beforehand In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26174 ) Change subject: stats: don't mark reporter as 'disable' beforehand ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I330a079807cca48b7cc43767abcd2b58830a05fc Gerrit-Change-Number: 26174 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 09 Nov 2021 10:49:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 10:51:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 10:51:10 +0000 Subject: Change in osmo-bts[master]: common/Makefile.am: reformat {AM_CPPFLAGS, AM_CFLAGS, LDADD} In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26139 ) Change subject: common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If475999cccc215b6792f276b9cc6c494a0c1ad81 Gerrit-Change-Number: 26139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 10:51:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:00:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 11:00:00 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/26175/1 diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 308bab6..72253dd 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -312,8 +312,8 @@ srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name); if (!srep) { - vty_out(vty, "%% No statsd logging active%s", - VTY_NEWLINE); + vty_out(vty, "%% There is no such statsd reporter with name '%s'%s", + name, VTY_NEWLINE); return CMD_WARNING; } @@ -366,8 +366,8 @@ srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name); if (!srep) { - vty_out(vty, "%% No log reporting active%s", - VTY_NEWLINE); + vty_out(vty, "%% There is no such log reporter with name '%s'%s", + name, VTY_NEWLINE); return CMD_WARNING; } diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index ddfb3a6..94cc7e8 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -203,6 +203,11 @@ stats_vty_test(config)# show running-config ... !(foo|bar|zoo) +stats_vty_test(config)# no stats reporter statsd statsd-foo +% There is no such statsd reporter with name 'statsd-foo' +stats_vty_test(config)# no stats reporter log log-zoo +% There is no such log reporter with name 'log-zoo' + stats_vty_test(config)# stats interval 1337 stats_vty_test(config)# show running-config -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:00:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 11:00:20 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26171/3/src/vty/stats_vty.c at 369 PS3, Line 369: vty_out(vty, "%% No log reporting active%s", > Maybe change the message here, depending on "name" being NULL or not. [?] https://gerrit.osmocom.org/c/libosmocore/+/26175 stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:00:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:00:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 11:00:30 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26172 ) Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:00:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:01:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 11:01:23 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c at 316 PS1, Line 316: name And yes, name can be NULL here. This is fine. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 09 Nov 2021 11:01:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:04:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 11:04:25 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c at 316 PS1, Line 316: name > And yes, name can be NULL here. This is fine. No, that will probably print "(null)", which is not the same as if the user called the reporter "(null)" himself, so that's confusing. I'd actually print "" here if the name is NULL. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:04:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:04:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 11:04:53 +0000 Subject: Change in libosmocore[master]: stats: cosmetic: print 'stats interval' before the reporters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26173 ) Change subject: stats: cosmetic: print 'stats interval' before the reporters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifb401d4d363fb70e89960ca739baba5ee55eefe8 Gerrit-Change-Number: 26173 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:04:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:05:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 11:05:43 +0000 Subject: Change in libosmocore[master]: stats: don't mark reporter as 'disable' beforehand In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26174 ) Change subject: stats: don't mark reporter as 'disable' beforehand ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I330a079807cca48b7cc43767abcd2b58830a05fc Gerrit-Change-Number: 26174 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:05:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:05:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 11:05:53 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26172 ) Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:05:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:06:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 11:06:15 +0000 Subject: Change in osmo-bts[master]: common/Makefile.am: reformat {AM_CPPFLAGS, AM_CFLAGS, LDADD} In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26139 ) Change subject: common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} ...................................................................... common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} Change-Id: If475999cccc215b6792f276b9cc6c494a0c1ad81 --- M src/common/Makefile.am 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/common/Makefile.am b/src/common/Makefile.am index 5b69b5c..35df73e 100644 --- a/src/common/Makefile.am +++ b/src/common/Makefile.am @@ -1,6 +1,21 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include -AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOTRAU_CFLAGS) $(LIBOSMOCODEC_CFLAGS) -LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOTRAU_LIBS) $(LIBOSMOCODEC_LIBS) +AM_CPPFLAGS = \ + $(all_includes) \ + -I$(top_srcdir)/include \ + -I$(top_builddir)/include \ + $(NULL) + +AM_CFLAGS = \ + -Wall \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOTRAU_CFLAGS) \ + $(LIBOSMOCODEC_CFLAGS) \ + $(NULL) + +LDADD = \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOTRAU_LIBS) \ + $(LIBOSMOCODEC_LIBS) \ + $(NULL) if ENABLE_LC15BTS AM_CFLAGS += -DENABLE_LC15BTS -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If475999cccc215b6792f276b9cc6c494a0c1ad81 Gerrit-Change-Number: 26139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:11:13 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 11:11:13 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26172 ) Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:16:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 11:16:03 +0000 Subject: Change in osmo-pcu[master]: pdch: Log line detaching TBF at start of the function References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26176 ) Change subject: pdch: Log line detaching TBF at start of the function ...................................................................... pdch: Log line detaching TBF at start of the function Log before the action is done ("Detaching", not "Detached"). This way, if something crashes we see that last line. Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a --- M src/pdch.cpp M tests/app_info/AppInfoTest.err M tests/tbf/TbfTest.err 3 files changed, 59 insertions(+), 59 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/26176/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index fdac100..8e70ffc 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -1135,6 +1135,11 @@ { gprs_rlcmac_ul_tbf *ul_tbf; + LOGPDCH(this, DRLCMAC, LOGL_INFO, "Detaching %s, %d TBFs, " + "USFs = %02x, TFIs = %08x.\n", + tbf->name(), num_tbfs(tbf->direction), + m_assigned_usf, m_assigned_tfi[tbf->direction]); + if (tbf->is_egprs_enabled()) { OSMO_ASSERT(m_num_tbfs_egprs[tbf->direction] > 0); } else { @@ -1150,11 +1155,6 @@ m_tbfs[tbf->direction][tbf->tfi()] = NULL; pdch_ulc_release_tbf(ulc, tbf); - - LOGPDCH(this, DRLCMAC, LOGL_INFO, "Detaching %s, %d TBFs, " - "USFs = %02x, TFIs = %08x.\n", - tbf->name(), num_tbfs(tbf->direction), - m_assigned_usf, m_assigned_tfi[tbf->direction]); } bool gprs_rlcmac_pdch::has_gprs_only_tbf_attached() const diff --git a/tests/app_info/AppInfoTest.err b/tests/app_info/AppInfoTest.err index a8c4511..d39e952 100644 --- a/tests/app_info/AppInfoTest.err +++ b/tests/app_info/AppInfoTest.err @@ -52,14 +52,14 @@ Sending Packet Application Information to 2 subscribers with active TBF --- cleanup --- -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. -PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 2 TBFs, USFs = 00, TFIs = 00000003. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 2 TBFs, USFs = 00, TFIs = 00000003. +PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 2 TBFs, USFs = 00, TFIs = 00000003. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 10/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. MS(TLLI=0xffffffff, IMSI=, TA=220, 12/13,) Detaching TBF: TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) MS(TLLI=0xffffffff, IMSI=, TA=220, 12/13,) Destroying MS object MS(TLLI=0xffffffff, IMSI=, TA=220, 10/11,) Destroying MS object diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index c440499..bc817b2 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -144,14 +144,14 @@ TBF(DL-TFI_1){NEW}: state_chg to ASSIGN TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 2 TBFs, USFs = 00, TFIs = 00000003. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) ********** DL-TBF ends here ********** TBF(DL-TFI_0){WAIT_RELEASE}: Deallocated UL_ASS_TBF(DL-TFI_0){NONE}: Deallocated DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Deallocated TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 00, TFIs = 00000002. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) ********** DL-TBF ends here ********** TBF(DL-TFI_1){ASSIGN}: Deallocated @@ -257,14 +257,14 @@ TBF(DL-TFI_1){NEW}: state_chg to ASSIGN TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 2 TBFs, USFs = 00, TFIs = 00000003. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) ********** DL-TBF ends here ********** TBF(DL-TFI_1){ASSIGN}: Deallocated UL_ASS_TBF(DL-TFI_1){NONE}: Deallocated DL_ASS_TBF(DL-TFI_1){NONE}: Deallocated TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) ********** DL-TBF ends here ********** TBF(DL-TFI_0){WAIT_RELEASE}: Deallocated @@ -532,7 +532,7 @@ TBF(DL-TFI_0){FINISHED}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Destroying MS object ********** DL-TBF ends here ********** @@ -612,7 +612,7 @@ Modifying MS object, TLLI = 0xf1000002, IMSI '' -> '001001000000002' MS(TLLI=0xf1000002, IMSI=, TA=0, 45/0, DL) IMSI '001001000000002' was already assigned to another MS object: TLLI = 0xf1000001, that IMSI will be removed TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW), 2 TBFs, USFs = 00, TFIs = 00000003. MS(TLLI=0xf1000001, IMSI=001001000000002, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW) ********** DL-TBF ends here ********** TBF(DL-TFI_0){FLOW}: Deallocated @@ -621,7 +621,7 @@ MS(TLLI=0xf1000001, IMSI=001001000000002, TA=0, 45/0,) Clearing MS object MS(TLLI=0xffffffff, IMSI=, TA=0, 45/0,) Destroying MS object TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW), 1 TBFs, USFs = 00, TFIs = 00000002. MS(TLLI=0xf1000002, IMSI=001001000000002, TA=0, 45/0,) Detaching TBF: TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW) MS(TLLI=0xf1000002, IMSI=001001000000002, TA=0, 45/0,) Destroying MS object ********** DL-TBF ends here ********** @@ -1642,7 +1642,7 @@ Modifying MS object, TLLI = 0xc0123456, TA 220 -> 0 TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) appending 19 bytes TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xc0123456, IMSI=001001000123456, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) MS(TLLI=0xc0123456, IMSI=001001000123456, TA=0, 45/0,) Schedule MS release in 10 secs ********** DL-TBF ends here ********** @@ -2149,7 +2149,7 @@ MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) MS(TLLI=0xf5667788, IMSI=, TA=7, 1/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf5667788 DIR=DL STATE=FINISHED) TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 1 TBFs, USFs = 02, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 2 TBFs, USFs = 03, TFIs = 00000003. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0,) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) ********** UL-TBF ends here ********** UL_ACK_TBF(UL-TFI_0){NONE}: Deallocated @@ -2264,7 +2264,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 20 bytes Old MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 1 TBFs, USFs = 01, TFIs = 00000001. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) ********** UL-TBF ends here ********** UL_ACK_TBF(UL-TFI_0){NONE}: Deallocated @@ -2437,7 +2437,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 20 bytes Old MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 1 TBFs, USFs = 01, TFIs = 00000001. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) ********** UL-TBF ends here ********** UL_ACK_TBF(UL-TFI_0){NONE}: Deallocated @@ -2482,7 +2482,7 @@ TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=FLOW) data_length=20, data=f1 22 33 44 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=FLOW) Decoded premier TLLI=0xf1223344 of UL DATA TFI=0. TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN), 0 TBFs, USFs = 01, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 01, TFIs = 00000001. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0,) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) ********** DL-TBF ends here ********** TBF(DL-TFI_0){ASSIGN}: Deallocated @@ -3361,7 +3361,7 @@ DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: state_chg to NONE TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 01, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE), 2 TBFs, USFs = 01, TFIs = 00000003. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL DL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) ********** DL-TBF ends here ********** TBF(DL-TFI_0){WAIT_RELEASE}: Deallocated @@ -3627,10 +3627,10 @@ MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) DL TBF slots: 0x3c, N: 4, WS: 64 TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) free -PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) Destroying MS object ********** DL-TBF ends here ********** @@ -3673,10 +3673,10 @@ ws(384) DL TBF slots: 0x3c, N: 4, WS: 384 TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) free -PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 12/12,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) MS(TLLI=0xffffffff, IMSI=, TA=220, 12/12,) Destroying MS object ********** DL-TBF ends here ********** @@ -4323,7 +4323,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -4581,7 +4581,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -4799,7 +4799,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5001,7 +5001,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5187,7 +5187,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5349,7 +5349,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5520,7 +5520,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5682,7 +5682,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5833,7 +5833,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5906,7 +5906,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5976,7 +5976,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6046,7 +6046,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6140,7 +6140,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6233,7 +6233,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6326,7 +6326,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6419,7 +6419,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6498,7 +6498,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6575,7 +6575,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6652,7 +6652,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6736,7 +6736,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6905,7 +6905,7 @@ ws(192) DL TBF slots: 0x10, N: 1, WS: 192 ********** DL-TBF update ********** -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. [DL] algo B (suggested TRX: -1): Alloc start Found first unallocated TRX=0 TFI=0 Selected DL slots: (TS=0)"..DDDD.."(TS=7), multi @@ -6922,10 +6922,10 @@ ws(384) DL TBF slots: 0x3c, N: 4, WS: 384 TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) free -PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) MS(TLLI=0xffffffff, IMSI=, TA=220, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -7096,7 +7096,7 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) DL analysis, range=1176:1288, lost=0, recv=0, skipped=112, bsn=1944, info='xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx................................................................................................................................................................................................................................................................................................................................................................................' TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) V(B): (V(A)=1186)"NNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNAAANAAAAAAAAAAAAAAAAAAAAAAAAAA"(V(S)-1=1287) A=Acked N=Nacked U=Unacked X=Resend-Unacked I=Invalid TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a Gerrit-Change-Number: 26176 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:18:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 11:18:52 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26175 to look at the new patch set (#2). Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/26175/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:19:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 11:19:07 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c at 316 PS1, Line 316: name > No, that will probably print "(null)", which is not the same as if the user called the reporter "(nu [?] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:19:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:22:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 11:22:52 +0000 Subject: Change in osmo-pcu[master]: pdch: Log TS enable/disable transitions References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26177 ) Change subject: pdch: Log TS enable/disable transitions ...................................................................... pdch: Log TS enable/disable transitions Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52 --- M src/pdch.cpp M tests/app_info/AppInfoTest.err M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 4 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/26177/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 8e70ffc..c1c7714 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -143,6 +143,7 @@ void gprs_rlcmac_pdch::enable() { + LOGPDCH(this, DRLCMAC, LOGL_INFO, "PDCH state: %s => enabled\n", m_is_enabled ? "enabled" : "disabled"); OSMO_ASSERT(m_is_enabled == 0); INIT_LLIST_HEAD(&paging_list); @@ -155,6 +156,7 @@ void gprs_rlcmac_pdch::disable() { + LOGPDCH(this, DRLCMAC, LOGL_INFO, "PDCH state: %s => disabled\n", m_is_enabled ? "enabled" : "disabled"); OSMO_ASSERT(m_is_enabled == 1); this->free_resources(); diff --git a/tests/app_info/AppInfoTest.err b/tests/app_info/AppInfoTest.err index d39e952..1a9fab0 100644 --- a/tests/app_info/AppInfoTest.err +++ b/tests/app_info/AppInfoTest.err @@ -10,6 +10,10 @@ Packet Application Information will not be sent, no subscribers with active TBF --- prepare_bts_with_two_dl_tbf_subscr --- +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=6) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 10 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index bc817b2..ec0981c 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1,6 +1,8 @@ === start test_tbf_base === === end test_tbf_base === === start test_tbf_tlli_update === +PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** DL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating DL TBF @@ -47,6 +49,7 @@ Modifying MS object, TLLI = 0x00004232, TA 4 -> 6 === end test_tbf_tlli_update === === start test_tbf_final_ack === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -160,6 +163,7 @@ MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Destroying MS object === end test_tbf_final_ack === === start test_tbf_final_ack === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -273,6 +277,7 @@ MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Destroying MS object === end test_tbf_final_ack === === start test_tbf_delayed_release === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -541,6 +546,7 @@ DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Deallocated === end test_tbf_delayed_release === === start test_tbf_imsi === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -630,6 +636,7 @@ DL_ASS_TBF(DL-TFI_1){SEND_ASS}: Deallocated === end test_tbf_imsi === === start test_tbf_exhaustion === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000000' @@ -1609,6 +1616,7 @@ === end test_tbf_exhaustion === MS(TLLI=0xc0000020, IMSI=001001000000032, TA=220, 45/0,) Destroying MS object === start test_tbf_dl_llc_loss === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000123456' @@ -1717,6 +1725,7 @@ MSG = 07 01 04 4d 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 === end test_tbf_dl_llc_loss === === start test_tbf_single_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) @@ -1800,6 +1809,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 4 bytes === end test_tbf_single_phase === === start test_tbf_two_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -1899,6 +1909,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 4 bytes === end test_tbf_two_phase === === start test_tbf_ra_update_rach === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -2163,6 +2174,7 @@ New MS: TLLI = 0xf5667788, TA = 7, IMSI = 0011223344, LLC = 1 === end test_tbf_ra_update_rach === === start test_tbf_dl_flow_and_rach_two_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -2336,6 +2348,7 @@ New MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 === end test_tbf_dl_flow_and_rach_two_phase === === start test_tbf_dl_flow_and_rach_single_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -2508,6 +2521,7 @@ New MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 === end test_tbf_dl_flow_and_rach_single_phase === === start test_tbf_dl_reuse === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -3563,6 +3577,7 @@ TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=FINISHED) msg block (BSN 10, CS-1): 0f 03 14 4d 43 20 50 41 43 4b 45 54 20 30 39 20 28 54 42 46 20 32 29 === end test_tbf_dl_reuse === === start test_tbf_gprs_egprs === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001123456789' @@ -3595,6 +3610,10 @@ TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=ASSIGN) appending 256 bytes === end test_tbf_gprs_egprs === === start test_tbf_ws === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 12 MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) ********** DL-TBF starts here ********** @@ -3685,6 +3704,7 @@ DL_ASS_TBF(DL-TFI_0){NONE}: Deallocated === end test_tbf_ws === === start test_tbf_egprs_two_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -3792,6 +3812,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_egprs_two_phase === === start test_tbf_egprs_two_phase_spb === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -4022,6 +4043,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_egprs_two_phase_spb === === start test_tbf_egprs_dl === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing MCS-1 Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 @@ -5842,6 +5864,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_egprs_dl === === start test_tbf_egprs_retx_dl === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing retx for MCS 6 - 6 Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 @@ -6428,6 +6451,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_egprs_retx_dl === === start test_tbf_egprs_spb_dl === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing retx for MCS 6 to reseg_mcs 3 Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 @@ -6745,6 +6769,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_egprs_spb_dl === === start test_tbf_puan_urbb_len === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -6875,6 +6900,10 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_puan_urbb_len === === start test_tbf_update_ws === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 @@ -6934,6 +6963,7 @@ DL_ASS_TBF(DL-TFI_0){NONE}: Deallocated === end test_tbf_update_ws === === start test_tbf_li_decoding === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -7053,6 +7083,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_li_decoding === === start test_tbf_epdan_out_of_rx_window === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 @@ -7105,6 +7136,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_epdan_out_of_rx_window === === start test_immediate_assign_rej_multi_block === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x78 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff @@ -7330,6 +7362,8 @@ MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Destroying MS object === end test_immediate_assign_rej_multi_block === === start test_immediate_assign_rej_single_block === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=7) PDCH state: enabled => disabled MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) No PDCH available. @@ -7337,6 +7371,7 @@ Tx Immediate Assignment Reject on AGCH === end test_immediate_assign_rej_single_block === === start test_tbf_egprs_two_phase_puan === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -8599,6 +8634,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_egprs_two_phase_puan === === start test_packet_access_rej_epdan === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 @@ -8644,6 +8680,7 @@ packet reject: 40 84 7f f7 6e e6 7e ab 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b === end test_packet_access_rej_epdan === === start test_packet_access_rej_prr === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=52 TRX=0 TS=7 @@ -9101,6 +9138,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN EGPRS) === end test_packet_access_rej_prr === === start test_packet_access_rej_prr_no_other_tbfs === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddcc, not yet confirmed TBF{NEW}: Allocated diff --git a/tests/ulc/PdchUlcTest.err b/tests/ulc/PdchUlcTest.err index 411c3f3..c7357c5 100644 --- a/tests/ulc/PdchUlcTest.err +++ b/tests/ulc/PdchUlcTest.err @@ -1,9 +1,11 @@ +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 72 PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 78 PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 72 PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 78 PDCH(bts=0,trx=0,ts=0) Trying to release unregistered SBA (FN=78, TA=0) PDCH(bts=0,trx=0,ts=0) Timeout for registered SBA (FN=72, TA=0) +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled Creating MS object, TLLI = 0x12345678 MS(TLLI=0x12345678, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=2715613 but previous FN=2715608 is still reserved! @@ -41,6 +43,8 @@ PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=34, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=39 is still reserved! PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=39, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 26 + 13 = 39 PDCH(bts=0,trx=0,ts=0) UL block already scheduled at FN 91 + 13 = 104 PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 91 + 17 = 108 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52 Gerrit-Change-Number: 26177 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:26:48 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 11:26:48 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c at 316 PS1, Line 316: name > No, that will probably print "(null)", which is not the same as if the user called the reporter "(nu [?] Hmm. I wonder if "" is not so good, but it is even possible that name can be null. The user must specify something, so if (argc > 0) will be always true? Or am I wrong? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:50:16 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 11:50:16 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:50:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 11:50:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 11:50:45 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... Patch Set 2: Code-Review+1 (1 comment) I would not avoid printing the empty string name, that provides information on which one is not found. Printing that conditionally is confusing imho. https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c at 316 PS1, Line 316: name > Hmm. I wonder if "" is not so good, but it is even possible that name can be null. [?] If user write no NAME arg, then argc=0 and name used internally in osmo_stats_reporter_find is NULL. Since user cannot add a name with empty string (""), then adding no name is the same as using empty string, and it's handled internally by passing NULL. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 11:50:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:04:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:04:15 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26175 to look at the new patch set (#3). Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/26175/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:06:01 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 12:06:01 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26161 to look at the new patch set (#2). Change subject: filesystem: fix decode_select_response ...................................................................... filesystem: fix decode_select_response There are some problems with the usage of decode_select_response. At the moment the ADF files overload the related method to provide decoding of the select responses as per 3gpp TS 102 221. However, this also means that the decoder is only available under ADF.USIM and ADF.ISIM. DF.GSM and DF.TELECOM also overload the decoder method, just like an ADF would do. This decoding method is then implemented as per 3gpp TS 51 011. Since this a a problem on UICCs, the method detects the magic byte 0x62 that can be found at the beginning on every select response of an UICC to defer to the TS 102 221 decoding method. TS 51 011 defines the first two bytes of the select response as RFU. This at least problematic. To solve this there should be a default method for decode_select_response in the profile, which can be used if no file overloads it with a specific decoder. ADFs use specific decoders, but everything else should use the default decoder. When we deal with an UICC, we expect the select response to be consistantly conform to TS 102 221, if we deal with a clasic sim we expect responses as per TS 51 011 only. Since it is still possible to replace the select response decoder we still have the opportunity to have custom select response in cartain DFs and ADFs should we need them. Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Related: OS#5274 --- M pySim/filesystem.py M pySim/ts_102_221.py M pySim/ts_51_011.py 3 files changed, 63 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/26161/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:23:55 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 12:23:55 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26161 to look at the new patch set (#3). Change subject: filesystem: fix decode_select_response ...................................................................... filesystem: fix decode_select_response There are some problems with the usage of decode_select_response. At the moment the ADF files overload the related method to provide decoding of the select responses as per 3gpp TS 102 221. However, this also means that the decoder is only available under ADF.USIM and ADF.ISIM. DF.GSM and DF.TELECOM also overload the decoder method, just like an ADF would do. This decoding method is then implemented as per 3gpp TS 51 011. Since this a a problem on UICCs, the method detects the magic byte 0x62 that can be found at the beginning on every select response of an UICC to defer to the TS 102 221 decoding method. TS 51 011 defines the first two bytes of the select response as RFU. This at least problematic. To solve this there should be a default method for decode_select_response in the profile, which can be used if no file overloads it with a specific decoder. ADFs use specific decoders, but everything else should use the default decoder. When we deal with an UICC, we expect the select response to be consistantly conform to TS 102 221, if we deal with a clasic sim we expect responses as per TS 51 011 only. Since it is still possible to replace the select response decoder we still have the opportunity to have custom select response in cartain DFs and ADFs should we need them. Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Related: OS#5274 --- M pySim/filesystem.py M pySim/ts_102_221.py M pySim/ts_51_011.py 3 files changed, 62 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/26161/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:28:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:28:19 +0000 Subject: Change in osmo-bts[master]: rsl: exclude disabled timeslots from interference reports References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26178 ) Change subject: rsl: exclude disabled timeslots from interference reports ...................................................................... rsl: exclude disabled timeslots from interference reports It may happen after the A-bis connection recovery that the RF RESource INDication message gets sent too early, while some timeslots are not yet configured. This confuses the BSC and provokes error messages. Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Related: SYS#4971 --- M src/common/l1sap.c M src/common/pcu_sock.c M src/common/rsl.c 3 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/78/26178/1 diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 8dee209..502bcef 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -597,6 +597,11 @@ for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { struct gsm_bts_trx_ts *ts = &trx->ts[tn]; + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (ts->mo.nm_state.availability != NM_AVSTATE_OK) + continue; + for (ln = 0; ln < ARRAY_SIZE(ts->lchan); ln++) { struct gsm_lchan *lchan = &ts->lchan[ln]; diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index f8a0f55..0018acb 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -579,6 +579,10 @@ const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; const struct gsm_lchan *lchan = &ts->lchan[0]; + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (ts->mo.nm_state.availability != NM_AVSTATE_OK) + continue; if (ts_pchan(ts) != GSM_PCHAN_PDCH) continue; diff --git a/src/common/rsl.c b/src/common/rsl.c index 4c84f21..9b73869 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -442,6 +442,11 @@ for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (ts->mo.nm_state.availability != NM_AVSTATE_OK) + continue; + for (ln = 0; ln < ARRAY_SIZE(ts->lchan); ln++) { const struct gsm_lchan *lchan = &ts->lchan[ln]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Gerrit-Change-Number: 26178 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:28:45 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:28:45 +0000 Subject: Change in osmo-bts[master]: rsl: exclude disabled timeslots from interference reports In-Reply-To: References: Message-ID: fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/26178 ) Change subject: rsl: exclude disabled timeslots from interference reports ...................................................................... rsl: exclude disabled timeslots from interference reports It may happen after the A-bis connection recovery that the RF RESource INDication message gets sent too early, while some timeslots are not yet configured. This confuses the BSC and provokes error messages. Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Related: SYS#5313, SYS#4971 --- M src/common/l1sap.c M src/common/pcu_sock.c M src/common/rsl.c 3 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/78/26178/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Gerrit-Change-Number: 26178 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:32:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:32:49 +0000 Subject: Change in libosmocore[master]: tests/stats: add VTY transcript tests In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26169 ) Change subject: tests/stats: add VTY transcript tests ...................................................................... tests/stats: add VTY transcript tests Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Related: SYS#5713 --- M tests/Makefile.am A tests/stats/stats_vty_test.c A tests/stats/stats_vty_test.vty 3 files changed, 255 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index 0880561..b72619f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -73,6 +73,7 @@ if !EMBEDDED check_PROGRAMS += \ stats/stats_test \ + stats/stats_vty_test \ exec/exec_test endif @@ -89,6 +90,9 @@ stats_stats_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la stats_stats_test_CPPFLAGS = $(AM_CPPFLAGS) -I$(top_srcdir)/src +stats_stats_vty_test_SOURCES = stats/stats_vty_test.c +stats_stats_vty_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la + a5_a5_test_SOURCES = a5/a5_test.c a5_a5_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libgsmint.la @@ -374,6 +378,7 @@ comp128/comp128_test.ok bits/bitfield_test.ok \ utils/utils_test.ok utils/utils_test.err \ stats/stats_test.ok stats/stats_test.err \ + stats/stats_vty_test.vty \ bitvec/bitvec_test.ok msgb/msgb_test.ok bits/bitcomp_test.ok \ sim/sim_test.ok tlv/tlv_test.ok abis/abis_test.ok \ gsup/gsup_test.ok gsup/gsup_test.err \ @@ -677,12 +682,19 @@ -r "$(top_builddir)/tests/tdef/tdef_vty_test_dynamic" \ $(U) $(srcdir)/tdef/tdef_vty_test_dynamic.vty +vty-test-stats: + osmo_verify_transcript_vty.py -v \ + -p 42042 \ + -r "$(top_builddir)/tests/stats/stats_vty_test" \ + $(U) $(srcdir)/stats/*.vty + # don't run vty tests concurrently so that the ports don't conflict vty-test: $(MAKE) vty-test-logging $(MAKE) vty-test-vty $(MAKE) vty-test-tdef $(MAKE) vty-test-ns2 + $(MAKE) vty-test-stats ctrl-test: echo "No CTRL tests exist currently" diff --git a/tests/stats/stats_vty_test.c b/tests/stats/stats_vty_test.c new file mode 100644 index 0000000..09b125a --- /dev/null +++ b/tests/stats/stats_vty_test.c @@ -0,0 +1,88 @@ +/* + * (C) 2021 by sysmocom s.f.m.c. GmbH + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +#include +#include + +#include +#include +#include +#include + +#include +#include +#include + +static void *root_ctx = NULL; +static int quit = 0; + +static void signal_handler(int signal) +{ + fprintf(stdout, "signal %u received\n", signal); + + switch (signal) { + case SIGINT: + case SIGTERM: + quit++; + break; + } +} + +static struct vty_app_info vty_info = { + .name = "stats_vty_test", +}; + +static const struct log_info_cat default_categories[] = { }; + +const struct log_info log_info = { + .cat = default_categories, + .num_cat = ARRAY_SIZE(default_categories), +}; + +int main(int argc, char **argv) +{ + int rc; + + root_ctx = talloc_named_const(NULL, 0, "stats_vty_test"); + + osmo_init_logging2(root_ctx, &log_info); + + vty_info.tall_ctx = root_ctx; + vty_init(&vty_info); + + osmo_stats_vty_add_cmds(); + + rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + if (rc < 0) + return 2; + + signal(SIGINT, &signal_handler); + signal(SIGTERM, &signal_handler); + osmo_init_ignore_signals(); + + while (!quit) + osmo_select_main(0); + + talloc_free(tall_vty_ctx); + talloc_free(root_ctx); + + return 0; +} diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty new file mode 100644 index 0000000..4ec03c9 --- /dev/null +++ b/tests/stats/stats_vty_test.vty @@ -0,0 +1,155 @@ +stats_vty_test> en +stats_vty_test# configure terminal +stats_vty_test(config)# list +... + stats reporter statsd + no stats reporter statsd + stats reporter log + no stats reporter log + stats interval <0-65535> +... + +stats_vty_test(config)# ### No reporters shall be configured by default +stats_vty_test(config)# show running-config +... !stats reporter + + +stats_vty_test(config)# ### Create a statsd reporter +stats_vty_test(config)# stats reporter statsd +stats_vty_test(config-stats)# list +... + local-ip ADDR + no local-ip + remote-ip ADDR + remote-port <1-65535> + mtu <100-65535> + no mtu + prefix PREFIX + no prefix + level (global|peer|subscriber) + enable + disable + flush-period <0-65535> +... + +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + level global + no prefix +stats interval 5 +... + +stats_vty_test(config-stats)# level subscriber +stats_vty_test(config-stats)# prefix statsd-prefix +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + level subscriber + prefix statsd-prefix +... + +stats_vty_test(config-stats)# remote-ip 192.168.1.200 +stats_vty_test(config-stats)# remote-port 6969 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 +... !local-ip + +stats_vty_test(config-stats)# local-ip 192.168.1.100 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + local-ip 192.168.1.100 +... + +stats_vty_test(config-stats)# no local-ip +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd +... !local-ip + +stats_vty_test(config-stats)# mtu 1337 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + mtu 1337 +... + +stats_vty_test(config-stats)# no mtu +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd +... !mtu + +stats_vty_test(config-stats)# flush-period 43556 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + flush-period 43556 +... + +stats_vty_test(config-stats)# flush-period 0 +stats_vty_test(config-stats)# show running-config +... +stats reporter statsd +... !flush-period + +stats_vty_test(config-stats)# enable +stats_vty_test(config-stats)# exit +stats_vty_test(config)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + enable +... + + +stats_vty_test(config)# ### Create a statsd reporter +stats_vty_test(config)# stats reporter log +stats_vty_test(config-stats)# level peer +stats_vty_test(config-stats)# prefix log-prefix +stats_vty_test(config-stats)# enable +stats_vty_test(config-stats)# exit +stats_vty_test(config)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + enable +stats reporter log + disable + level peer + prefix log-prefix + enable +... + + +stats_vty_test(config)# stats interval 1337 +stats_vty_test(config)# show running-config +... +stats interval 1337 +... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85ac73f4c866617179e55821a292aad33b6edc99 Gerrit-Change-Number: 26169 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:32:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:32:50 +0000 Subject: Change in libosmocore[master]: stats: use llist_add_tail() in osmo_stats_reporter_alloc() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26170 ) Change subject: stats: use llist_add_tail() in osmo_stats_reporter_alloc() ...................................................................... stats: use llist_add_tail() in osmo_stats_reporter_alloc() This allows printing reporters in the exact order as they were configired. Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Related: SYS#5713 --- M src/stats.c M tests/stats/stats_test.err 2 files changed, 35 insertions(+), 35 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/stats.c b/src/stats.c index 28a3ab3..0967305 100644 --- a/src/stats.c +++ b/src/stats.c @@ -223,7 +223,7 @@ srep->name = talloc_strdup(srep, name); srep->fd = -1; - llist_add(&srep->list, &osmo_stats_reporter_list); + llist_add_tail(&srep->list, &osmo_stats_reporter_list); return srep; } diff --git a/tests/stats/stats_test.err b/tests/stats/stats_test.err index 1e604d1..4acd35d 100644 --- a/tests/stats/stats_test.err +++ b/tests/stats/stats_test.err @@ -7,26 +7,26 @@ test1: open test2: open report (initial): - test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 - test2: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 + test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 test1: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 - test2: counter p= g=ctr-test:one i=1 n=ctr:a v=0 d=0 + test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 test1: counter p= g=ctr-test:one i=1 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one i=1 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one i=1 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one i=1 n=ctr:b v=0 d=0 - test2: item p= g=test.one i=2 n=item.a v=-1 u=ma + test2: counter p= g=ctr-test:one i=1 n=ctr:b v=0 d=0 test1: item p= g=test.one i=2 n=item.a v=-1 u=ma - test2: item p= g=test.one i=2 n=item.b v=-1 u=kb + test2: item p= g=test.one i=2 n=item.a v=-1 u=ma test1: item p= g=test.one i=2 n=item.b v=-1 u=kb - test2: item p= g=test.one i=1 n=item.a v=-1 u=ma + test2: item p= g=test.one i=2 n=item.b v=-1 u=kb test1: item p= g=test.one i=1 n=item.a v=-1 u=ma - test2: item p= g=test.one i=1 n=item.b v=-1 u=kb + test2: item p= g=test.one i=1 n=item.a v=-1 u=ma test1: item p= g=test.one i=1 n=item.b v=-1 u=kb + test2: item p= g=test.one i=1 n=item.b v=-1 u=kb reported: 12 counter vals, 8 stat item vals report (srep1 global): test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 @@ -47,36 +47,36 @@ test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 test2: counter p= g=ctr-test:one i=1 n=ctr:a v=0 d=0 test2: counter p= g=ctr-test:one i=1 n=ctr:b v=0 d=0 - test2: item p= g=test.one i=2 n=item.a v=-1 u=ma test1: item p= g=test.one i=2 n=item.a v=-1 u=ma - test2: item p= g=test.one i=2 n=item.b v=-1 u=kb + test2: item p= g=test.one i=2 n=item.a v=-1 u=ma test1: item p= g=test.one i=2 n=item.b v=-1 u=kb - test2: item p= g=test.one i=1 n=item.a v=-1 u=ma + test2: item p= g=test.one i=2 n=item.b v=-1 u=kb test1: item p= g=test.one i=1 n=item.a v=-1 u=ma - test2: item p= g=test.one i=1 n=item.b v=-1 u=kb + test2: item p= g=test.one i=1 n=item.a v=-1 u=ma test1: item p= g=test.one i=1 n=item.b v=-1 u=kb + test2: item p= g=test.one i=1 n=item.b v=-1 u=kb reported: 6 counter vals, 8 stat item vals report (srep1 subscriber): - test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 - test2: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 + test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 test1: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 - test2: counter p= g=ctr-test:one i=1 n=ctr:a v=0 d=0 + test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 test1: counter p= g=ctr-test:one i=1 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one i=1 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one i=1 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one i=1 n=ctr:b v=0 d=0 - test2: item p= g=test.one i=2 n=item.a v=-1 u=ma + test2: counter p= g=ctr-test:one i=1 n=ctr:b v=0 d=0 test1: item p= g=test.one i=2 n=item.a v=-1 u=ma - test2: item p= g=test.one i=2 n=item.b v=-1 u=kb + test2: item p= g=test.one i=2 n=item.a v=-1 u=ma test1: item p= g=test.one i=2 n=item.b v=-1 u=kb - test2: item p= g=test.one i=1 n=item.a v=-1 u=ma + test2: item p= g=test.one i=2 n=item.b v=-1 u=kb test1: item p= g=test.one i=1 n=item.a v=-1 u=ma - test2: item p= g=test.one i=1 n=item.b v=-1 u=kb + test2: item p= g=test.one i=1 n=item.a v=-1 u=ma test1: item p= g=test.one i=1 n=item.b v=-1 u=kb + test2: item p= g=test.one i=1 n=item.b v=-1 u=kb reported: 12 counter vals, 8 stat item vals report (srep2 disabled): test2: close @@ -107,38 +107,38 @@ report (should be empty): reported: 0 counter vals, 0 stat item vals report (group 1, counter 1 update): - test2: counter p= g=ctr-test:one i=1 n=ctr:a v=1 d=1 test1: counter p= g=ctr-test:one i=1 n=ctr:a v=1 d=1 + test2: counter p= g=ctr-test:one i=1 n=ctr:a v=1 d=1 reported: 2 counter vals, 0 stat item vals report (group 1, item 1 update): - test2: item p= g=test.one i=1 n=item.a v=10 u=ma test1: item p= g=test.one i=1 n=item.a v=10 u=ma + test2: item p= g=test.one i=1 n=item.a v=10 u=ma reported: 0 counter vals, 2 stat item vals report (group 1, item 1 update twice, with same value): reported: 0 counter vals, 0 stat item vals report (group 1, item 1 update twice, check max): - test2: item p= g=test.one i=1 n=item.a v=20 u=ma test1: item p= g=test.one i=1 n=item.a v=20 u=ma + test2: item p= g=test.one i=1 n=item.a v=20 u=ma reported: 0 counter vals, 2 stat item vals report (group 1, item 1 no update, send last item (!= last max), OS#5215): - test2: item p= g=test.one i=1 n=item.a v=10 u=ma test1: item p= g=test.one i=1 n=item.a v=10 u=ma + test2: item p= g=test.one i=1 n=item.a v=10 u=ma reported: 0 counter vals, 2 stat item vals report (group 1, item 1 no update, nothing to send): reported: 0 counter vals, 0 stat item vals report (remove statg1, ctrg1): - test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 - test2: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 + test2: counter p= g=ctr-test:one_dot i=3 n=ctr:b v=0 d=0 test1: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 - test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 + test2: counter p= g=ctr-test:one i=2 n=ctr:a v=0 d=0 test1: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 - test2: item p= g=test.one i=2 n=item.a v=-1 u=ma + test2: counter p= g=ctr-test:one i=2 n=ctr:b v=0 d=0 test1: item p= g=test.one i=2 n=item.a v=-1 u=ma - test2: item p= g=test.one i=2 n=item.b v=-1 u=kb + test2: item p= g=test.one i=2 n=item.a v=-1 u=ma test1: item p= g=test.one i=2 n=item.b v=-1 u=kb + test2: item p= g=test.one i=2 n=item.b v=-1 u=kb reported: 8 counter vals, 4 stat item vals report (remove srep1): test1: close -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I904cd0ed53510dbe26c15cd287ba2707ca04cd6e Gerrit-Change-Number: 26170 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:32:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:32:50 +0000 Subject: Change in libosmocore[master]: stats: allow configuring reporter's name in the VTY In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26171 ) Change subject: stats: allow configuring reporter's name in the VTY ...................................................................... stats: allow configuring reporter's name in the VTY This allows configuring more than one reporter of the given type. Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Related: SYS#5713 --- M include/osmocom/core/stats.h M src/stats.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 4 files changed, 121 insertions(+), 28 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/core/stats.h b/include/osmocom/core/stats.h index b9edac2..c4f71c8 100644 --- a/include/osmocom/core/stats.h +++ b/include/osmocom/core/stats.h @@ -108,6 +108,7 @@ int interval; }; +extern struct llist_head osmo_stats_reporter_list; extern struct osmo_stats_config *osmo_stats_config; void osmo_stats_init(void *ctx); diff --git a/src/stats.c b/src/stats.c index 0967305..702e408 100644 --- a/src/stats.c +++ b/src/stats.c @@ -106,7 +106,7 @@ #define STATS_DEFAULT_INTERVAL 5 /* secs */ #define STATS_DEFAULT_BUFLEN 256 -static LLIST_HEAD(osmo_stats_reporter_list); +LLIST_HEAD(osmo_stats_reporter_list); static void *osmo_stats_ctx = NULL; static int is_initialised = 0; diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 17e7190..a4fc6ea 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -269,14 +269,20 @@ } DEFUN(cfg_stats_reporter_statsd, cfg_stats_reporter_statsd_cmd, - "stats reporter statsd", - CFG_STATS_STR CFG_REPORTER_STR "Report to a STATSD server\n") + "stats reporter statsd [NAME]", + CFG_STATS_STR CFG_REPORTER_STR + "Report to a STATSD server\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name); if (!srep) { - srep = osmo_stats_reporter_create_statsd(NULL); + srep = osmo_stats_reporter_create_statsd(name); if (!srep) { vty_out(vty, "%% Unable to create statsd reporter%s", VTY_NEWLINE); @@ -293,12 +299,18 @@ } DEFUN(cfg_no_stats_reporter_statsd, cfg_no_stats_reporter_statsd_cmd, - "no stats reporter statsd", - NO_STR CFG_STATS_STR CFG_REPORTER_STR "Report to a STATSD server\n") + "no stats reporter statsd [NAME]", + NO_STR CFG_STATS_STR CFG_REPORTER_STR + "Report to a STATSD server\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name); if (!srep) { vty_out(vty, "%% No statsd logging active%s", VTY_NEWLINE); @@ -311,14 +323,20 @@ } DEFUN(cfg_stats_reporter_log, cfg_stats_reporter_log_cmd, - "stats reporter log", - CFG_STATS_STR CFG_REPORTER_STR "Report to the logger\n") + "stats reporter log [NAME]", + CFG_STATS_STR CFG_REPORTER_STR + "Report to the logger\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name); if (!srep) { - srep = osmo_stats_reporter_create_log(NULL); + srep = osmo_stats_reporter_create_log(name); if (!srep) { vty_out(vty, "%% Unable to create log reporter%s", VTY_NEWLINE); @@ -335,12 +353,18 @@ } DEFUN(cfg_no_stats_reporter_log, cfg_no_stats_reporter_log_cmd, - "no stats reporter log", - NO_STR CFG_STATS_STR CFG_REPORTER_STR "Report to the logger\n") + "no stats reporter log [NAME]", + NO_STR CFG_STATS_STR CFG_REPORTER_STR + "Report to the logger\n" + "Name of the reporter\n") { struct osmo_stats_reporter *srep; + const char *name = NULL; - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, NULL); + if (argc > 0) + name = argv[0]; + + srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name); if (!srep) { vty_out(vty, "%% No log reporting active%s", VTY_NEWLINE); @@ -598,18 +622,22 @@ static int config_write_stats_reporter(struct vty *vty, struct osmo_stats_reporter *srep) { - if (srep == NULL) - return 0; + const char *type = NULL; switch (srep->type) { case OSMO_STATS_REPORTER_STATSD: - vty_out(vty, "stats reporter statsd%s", VTY_NEWLINE); + type = "statsd"; break; case OSMO_STATS_REPORTER_LOG: - vty_out(vty, "stats reporter log%s", VTY_NEWLINE); + type = "log"; break; } + vty_out(vty, "stats reporter %s", type); + if (srep->name != NULL) + vty_out(vty, " %s", srep->name); + vty_out(vty, "%s", VTY_NEWLINE); + vty_out(vty, " disable%s", VTY_NEWLINE); if (srep->have_net_config) { @@ -652,11 +680,9 @@ { struct osmo_stats_reporter *srep; - /* TODO: loop through all reporters */ - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, NULL); - config_write_stats_reporter(vty, srep); - srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, NULL); - config_write_stats_reporter(vty, srep); + /* Loop through all reporters */ + llist_for_each_entry(srep, &osmo_stats_reporter_list, list) + config_write_stats_reporter(vty, srep); vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index 4ec03c9..017b188 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -2,10 +2,10 @@ stats_vty_test# configure terminal stats_vty_test(config)# list ... - stats reporter statsd - no stats reporter statsd - stats reporter log - no stats reporter log + stats reporter statsd [NAME] + no stats reporter statsd [NAME] + stats reporter log [NAME] + no stats reporter log [NAME] stats interval <0-65535> ... @@ -148,6 +148,72 @@ ... +stats_vty_test(config)# ### Create an additional statsd reporter +stats_vty_test(config)# stats reporter statsd statsd-foo +stats_vty_test(config-stats)# level global +stats_vty_test(config-stats)# prefix statsd-one-prefix +stats_vty_test(config-stats)# remote-ip 192.168.2.200 +stats_vty_test(config-stats)# remote-port 9696 +stats_vty_test(config-stats)# flush-period 1 +stats_vty_test(config-stats)# exit + +stats_vty_test(config)# ### Create an additional log reporter +stats_vty_test(config)# stats reporter log log-bar +stats_vty_test(config-stats)# level global +stats_vty_test(config-stats)# prefix log-bar-prefix +stats_vty_test(config-stats)# flush-period 2 +stats_vty_test(config-stats)# exit + +stats_vty_test(config)# ### Create an additional log reporter +stats_vty_test(config)# stats reporter log log-zoo +stats_vty_test(config-stats)# level global +stats_vty_test(config-stats)# prefix log-zoo-prefix +stats_vty_test(config-stats)# flush-period 3 +stats_vty_test(config-stats)# exit + +stats_vty_test(config)# ### We should have 5 reporters now +stats_vty_test(config)# show running-config +... +stats reporter statsd + disable + remote-ip 192.168.1.200 + remote-port 6969 + level subscriber + prefix statsd-prefix + enable +stats reporter log + disable + level peer + prefix log-prefix + enable +stats reporter statsd statsd-foo + disable + remote-ip 192.168.2.200 + remote-port 9696 + level global + prefix statsd-one-prefix + flush-period 1 +stats reporter log log-bar + disable + level global + prefix log-bar-prefix + flush-period 2 +stats reporter log log-zoo + disable + level global + prefix log-zoo-prefix + flush-period 3 +... + + +stats_vty_test(config)# ### Test removing reporters +stats_vty_test(config)# no stats reporter statsd statsd-foo +stats_vty_test(config)# no stats reporter log log-bar +stats_vty_test(config)# no stats reporter log log-zoo +stats_vty_test(config)# show running-config +... !(foo|bar|zoo) + + stats_vty_test(config)# stats interval 1337 stats_vty_test(config)# show running-config ... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia815c24dc974648985539913012b3b074ea317a9 Gerrit-Change-Number: 26171 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:32:51 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:32:51 +0000 Subject: Change in libosmocore[master]: stats: cosmetic: print 'stats interval' before the reporters In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26173 ) Change subject: stats: cosmetic: print 'stats interval' before the reporters ...................................................................... stats: cosmetic: print 'stats interval' before the reporters It's better to have the common parameters printed first. Change-Id: Ifb401d4d363fb70e89960ca739baba5ee55eefe8 Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index a4fc6ea..48e4f1c 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -680,12 +680,12 @@ { struct osmo_stats_reporter *srep; + vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); + /* Loop through all reporters */ llist_for_each_entry(srep, &osmo_stats_reporter_list, list) config_write_stats_reporter(vty, srep); - vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); - return 1; } diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index 017b188..7c01d3f 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -34,11 +34,11 @@ stats_vty_test(config-stats)# show running-config ... +stats interval 5 stats reporter statsd disable level global no prefix -stats interval 5 ... stats_vty_test(config-stats)# level subscriber -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifb401d4d363fb70e89960ca739baba5ee55eefe8 Gerrit-Change-Number: 26173 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:32:51 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:32:51 +0000 Subject: Change in libosmocore[master]: stats: don't mark reporter as 'disable' beforehand In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26174 ) Change subject: stats: don't mark reporter as 'disable' beforehand ...................................................................... stats: don't mark reporter as 'disable' beforehand Change-Id: I330a079807cca48b7cc43767abcd2b58830a05fc Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 6 insertions(+), 16 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 48e4f1c..308bab6 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -638,8 +638,6 @@ vty_out(vty, " %s", srep->name); vty_out(vty, "%s", VTY_NEWLINE); - vty_out(vty, " disable%s", VTY_NEWLINE); - if (srep->have_net_config) { if (srep->dest_addr_str) vty_out(vty, " remote-ip %s%s", @@ -672,6 +670,8 @@ if (srep->enabled) vty_out(vty, " enable%s", VTY_NEWLINE); + else + vty_out(vty, " disable%s", VTY_NEWLINE); return 1; } diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index 7c01d3f..ddfb3a6 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -36,9 +36,9 @@ ... stats interval 5 stats reporter statsd - disable level global no prefix + disable ... stats_vty_test(config-stats)# level subscriber @@ -46,7 +46,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable level subscriber prefix statsd-prefix ... @@ -56,7 +55,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 ... !local-ip @@ -65,7 +63,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 local-ip 192.168.1.100 @@ -81,7 +78,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 mtu 1337 @@ -97,7 +93,6 @@ stats_vty_test(config-stats)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber @@ -116,7 +111,6 @@ stats_vty_test(config)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber @@ -134,14 +128,12 @@ stats_vty_test(config)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber prefix statsd-prefix enable stats reporter log - disable level peer prefix log-prefix enable @@ -175,34 +167,32 @@ stats_vty_test(config)# show running-config ... stats reporter statsd - disable remote-ip 192.168.1.200 remote-port 6969 level subscriber prefix statsd-prefix enable stats reporter log - disable level peer prefix log-prefix enable stats reporter statsd statsd-foo - disable remote-ip 192.168.2.200 remote-port 9696 level global prefix statsd-one-prefix flush-period 1 -stats reporter log log-bar disable +stats reporter log log-bar level global prefix log-bar-prefix flush-period 2 -stats reporter log log-zoo disable +stats reporter log log-zoo level global prefix log-zoo-prefix flush-period 3 + disable ... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I330a079807cca48b7cc43767abcd2b58830a05fc Gerrit-Change-Number: 26174 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:35:04 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 12:35:04 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26172 ) Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In Osmocom code, we have the following written in one line: while (osmo_select_main_ctx(1) > 0); This currently causes the following linter error: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line According to the linter, we should write it as follows: while (osmo_select_main_ctx(1) > 0) ; But this is not followed in Osmocom code, so let's ignore the check. Related: OS#5087 Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index f9cc74f..ec9384c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -69,6 +69,7 @@ # * SPDX_LICENSE_TAG: we don't place it on line 1 # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability +# * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) @@ -103,6 +104,7 @@ --ignore SPDX_LICENSE_TAG \ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ + --ignore TRAILING_STATEMENTS \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ --max-line-length 120 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:37:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:37:09 +0000 Subject: Change in osmo-pcu[master]: pdch: Log line detaching TBF at start of the function In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26176 ) Change subject: pdch: Log line detaching TBF at start of the function ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp at 1138 PS1, Line 1138: %d TBFs, " : "USFs = %02x, TFIs = %08x This looks more like summary that should be printed down below. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a Gerrit-Change-Number: 26176 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 12:37:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:37:33 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 12:37:33 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 12:37:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:40:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:40:27 +0000 Subject: Change in osmo-pcu[master]: pdch: Log TS enable/disable transitions In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26177 ) Change subject: pdch: Log TS enable/disable transitions ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp at 147 PS1, Line 147: OSMO_ASSERT Unrelated to this patch, but do we really want to assert() here? Wouldn't it be sufficient to log an error and return early? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52 Gerrit-Change-Number: 26177 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 12:40:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:41:02 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 12:41:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 ) Change subject: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2e287699925c6bb7f93439d0729e16682fab019 Gerrit-Change-Number: 26135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 12:41:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:42:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 12:42:54 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/L1CTL_PortType: add f_L1CTL_rx_data() helper In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 ) Change subject: library/L1CTL_PortType: add f_L1CTL_rx_data() helper ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I254171c6dc83f046b5ad1a72586c097deebb0fa7 Gerrit-Change-Number: 26136 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 12:42:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:49:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:49:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: remove misleading PADDING attributes In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 ) Change subject: library/GSM_RR_Types: remove misleading PADDING attributes ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109/1//COMMIT_MSG at 11 PS1, Line 11: padding length is counted from the beginning of the message. > maybe it is worth raising a feature request with TITAN, explaining to them why a different model is [?] https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/484 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 Gerrit-Change-Number: 26109 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 12:49:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:49:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:49:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 ) Change subject: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2e287699925c6bb7f93439d0729e16682fab019 Gerrit-Change-Number: 26135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 12:49:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:57:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:57:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/L1CTL_PortType: add f_L1CTL_rx_data() helper In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 ) Change subject: library/L1CTL_PortType: add f_L1CTL_rx_data() helper ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136/1/library/L1CTL_PortType.ttcn File library/L1CTL_PortType.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136/1/library/L1CTL_PortType.ttcn at 45 PS1, Line 45: function f_L1CTL_rx_data(L1CTL_PT pt, > maybe call it f_L1CTL_rx_data_ind? We can rename it any time later, not critical at the moment. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I254171c6dc83f046b5ad1a72586c097deebb0fa7 Gerrit-Change-Number: 26136 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 12:57:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:57:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:57:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: remove misleading PADDING attributes In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 ) Change subject: library/GSM_RR_Types: remove misleading PADDING attributes ...................................................................... library/GSM_RR_Types: remove misleading PADDING attributes Unfortunately, TITAN has a weird (and often unusable) model of defining padding in records. According to its reference guide, padding length is counted from the beginning of the message. So if the 'MeasurementResults' is a part of another record, and there are other fields preceeding it, the encoded representation of the 'MeasurementResults' may still be shorter than 16 octets. Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 --- M library/GSM_RR_Types.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index f7b00e1..f45784c 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -650,8 +650,7 @@ NcellReports ncell_reports optional } with { variant (no_ncell_m) "LENGTHTO(ncell_reports)" variant (no_ncell_m) "UNIT(elements)" - variant "PADDING(yes)" - variant "FIELDLENGTH(16)" + /* FIXME: pad to 16 octets */ }; type record NcellReport { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2 Gerrit-Change-Number: 26109 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:57:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:57:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP ...................................................................... library/RSL_Types: add missing RSL_IE_OSMO_REP_ACCH_CAP Change-Id: I198cbfd176e41c55f67d625d9587ba5b6062f0c4 Related: SYS#5114 --- M library/RSL_Types.ttcn 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index aa206a3..3ac40ce 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -220,6 +220,7 @@ RSL_IE_TFO_STATUS ('00111011'B), RSL_IE_LLP_APDU ('00111100'B), + RSL_IE_OSMO_REP_ACCH_CAP ('01100000'B), RSL_IE_OSMO_TRAINING_SEQUENCE ('01100001'B), /* ip.access */ @@ -873,6 +874,16 @@ uint8_t tsc } with { variant (len) "LENGTHTO(tsc_set,tsc)" } + type record RSL_IE_OSMO_RepAcchCap { + uint8_t len, + BIT1 rfu ('0'B), + uint3_t rxqual, + boolean ul_sacch, + boolean dl_sacch, + boolean dl_facch_all, + boolean dl_facch_cmd + } with { variant (len) "LENGTHTO(rfu,rxqual,ul_sacch,dl_sacch,dl_facch_all,dl_facch_cmd)" } + /* union of all IE bodies */ type union RSL_IE_Body { RslChannelNr chan_nr, @@ -927,6 +938,7 @@ RSL_IE_IPA_SpeechMode ipa_speech_mode, RSL_IE_OSMO_TrainingSequence osmo_training_sequence, + RSL_IE_OSMO_RepAcchCap rep_acch_cap, RSL_LV other } @@ -989,6 +1001,7 @@ ipa_speech_mode, iei = RSL_IE_IPAC_SPEECH_MODE; osmo_training_sequence, iei = RSL_IE_OSMO_TRAINING_SEQUENCE; + rep_acch_cap, iei = RSL_IE_OSMO_REP_ACCH_CAP; other, OTHERWISE; )" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I198cbfd176e41c55f67d625d9587ba5b6062f0c4 Gerrit-Change-Number: 26110 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:57:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:57:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 ) Change subject: library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP ...................................................................... library/RSL_Types: add missing RSL_IE_OSMO_TOP_ACCH_CAP Change-Id: I3bd491fba5b72f0fdd262992a97895f037be69d8 Related: SYS#5319 --- M library/RSL_Types.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 3ac40ce..1f602b9 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -222,6 +222,7 @@ RSL_IE_OSMO_REP_ACCH_CAP ('01100000'B), RSL_IE_OSMO_TRAINING_SEQUENCE ('01100001'B), + RSL_IE_OSMO_TOP_ACCH_CAP ('01100010'B), /* ip.access */ RSL_IE_IPAC_SRTP_CONFIG ('11100000'B), @@ -884,6 +885,14 @@ boolean dl_facch_cmd } with { variant (len) "LENGTHTO(rfu,rxqual,ul_sacch,dl_sacch,dl_facch_all,dl_facch_cmd)" } + type record RSL_IE_OSMO_TopAcchCap { + uint8_t len, + boolean sacch_enable, + boolean facch_enable, + uint3_t rxqual, + uint3_t overpower_db + } with { variant (len) "LENGTHTO(sacch_enable,facch_enable,rxqual,overpower_db)" } + /* union of all IE bodies */ type union RSL_IE_Body { RslChannelNr chan_nr, @@ -939,6 +948,7 @@ RSL_IE_OSMO_TrainingSequence osmo_training_sequence, RSL_IE_OSMO_RepAcchCap rep_acch_cap, + RSL_IE_OSMO_TopAcchCap top_acch_cap, RSL_LV other } @@ -1002,6 +1012,7 @@ osmo_training_sequence, iei = RSL_IE_OSMO_TRAINING_SEQUENCE; rep_acch_cap, iei = RSL_IE_OSMO_REP_ACCH_CAP; + top_acch_cap, iei = RSL_IE_OSMO_TOP_ACCH_CAP; other, OTHERWISE; )" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3bd491fba5b72f0fdd262992a97895f037be69d8 Gerrit-Change-Number: 26111 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:57:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:57:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 ) Change subject: library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap ...................................................................... library/RSL_Types: add templates for RSL_IE_OSMO_TopAcchCap Change-Id: If2e287699925c6bb7f93439d0729e16682fab019 Related: SYS#5319 --- M library/RSL_Types.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 1f602b9..1057f0b 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -893,6 +893,29 @@ uint3_t overpower_db } with { variant (len) "LENGTHTO(sacch_enable,facch_enable,rxqual,overpower_db)" } + template (value) RSL_IE_OSMO_TopAcchCap + ts_RSL_IE_OSMO_TopAcchCap(template (value) uint3_t overpower := 2, + template (value) uint3_t rxqual := 4, + boolean facch_enable := true, + boolean sacch_enable := true) := { + len := 0, /* overwritten */ + sacch_enable := sacch_enable, + facch_enable := facch_enable, + rxqual := rxqual, + overpower_db := overpower + }; + template RSL_IE_OSMO_TopAcchCap + tr_RSL_IE_OSMO_TopAcchCap(template (present) uint3_t overpower := ?, + template (present) uint3_t rxqual := ?, + template (present) boolean facch_enable := ?, + template (present) boolean sacch_enable := ?) := { + len := ?, /* overwritten */ + sacch_enable := sacch_enable, + facch_enable := facch_enable, + rxqual := rxqual, + overpower_db := overpower + }; + /* union of all IE bodies */ type union RSL_IE_Body { RslChannelNr chan_nr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2e287699925c6bb7f93439d0729e16682fab019 Gerrit-Change-Number: 26135 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:57:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 12:57:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/L1CTL_PortType: add f_L1CTL_rx_data() helper In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 ) Change subject: library/L1CTL_PortType: add f_L1CTL_rx_data() helper ...................................................................... library/L1CTL_PortType: add f_L1CTL_rx_data() helper Change-Id: I254171c6dc83f046b5ad1a72586c097deebb0fa7 Related: SYS#5319 --- M library/L1CTL_PortType.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/L1CTL_PortType.ttcn b/library/L1CTL_PortType.ttcn index 80e33a8..ed235d3 100644 --- a/library/L1CTL_PortType.ttcn +++ b/library/L1CTL_PortType.ttcn @@ -42,6 +42,29 @@ return len; } + function f_L1CTL_rx_data(L1CTL_PT pt, + template (present) RslChannelNr chan_nr := ?, + template (present) RslLinkId link_id := ?) + return L1ctlDlMessage { + var L1ctlDlMessage dl; + timer T := 2.0; + + T.start; + alt { + [] pt.receive(tr_L1CTL_DATA_IND(chan_nr, link_id)) -> value dl { + return dl; + } + [] pt.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for L1CTL DATA.ind"); + mtc.stop; + } + } + + /* Unreachable, make TITAN happy */ + return dl; + } + function f_L1CTL_FBSB(L1CTL_PT pt, GsmBandArfcn arfcn, L1ctlCcchMode ccch_mode := CCCH_MODE_COMBINED, integer rxlev_exp := 57) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I254171c6dc83f046b5ad1a72586c097deebb0fa7 Gerrit-Change-Number: 26136 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 12:58:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 12:58:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... Patch Set 3: (1 comment) Besides the 8dB comment, this looks good. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137/3/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137/3/bts/BTS_Tests.ttcn at 8087 PS3, Line 8087: ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 2dB */ = 8dB? this is also below in TC_acch_overpower_rxqual_thresh_dtx -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 12:58:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 13:01:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 13:01:44 +0000 Subject: Change in osmo-pcu[master]: pdch: Log DL TBF originating the new UL TBF References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26179 ) Change subject: pdch: Log DL TBF originating the new UL TBF ...................................................................... pdch: Log DL TBF originating the new UL TBF Change-Id: Ie4257a2468d589464d0d56882e4408e4bcfe340f --- M src/pdch.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/26179/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index c1c7714..6aae7d1 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -123,10 +123,10 @@ /* schedule uplink assignment or reject */ if (ul_tbf) { - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we provide one:\n"); + LOGPTBFDL(tbf, LOGL_DEBUG, "MS requests UL TBF in ack message, so we provide one:\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS, NULL); } else { - LOGP(DRLCMAC, LOGL_NOTICE, "MS requests UL TBF in ack message, but alloc failed: send PktAssRej\n"); + LOGPTBFDL(tbf, LOGL_NOTICE, "MS requests UL TBF in ack message, but alloc failed: send PktAssRej\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS_REJ, NULL); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie4257a2468d589464d0d56882e4408e4bcfe340f Gerrit-Change-Number: 26179 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 13:55:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 13:55:41 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26175/3/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/26175/3/src/vty/stats_vty.c at 316 PS3, Line 316: name ? name : "", VTY_NEWLINE); you could do following more compact, but fine: name ? : "" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 13:55:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 13:56:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 13:56:46 +0000 Subject: Change in osmo-pcu[master]: pdch: Log line detaching TBF at start of the function In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26176 ) Change subject: pdch: Log line detaching TBF at start of the function ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp at 1138 PS1, Line 1138: %d TBFs, " : "USFs = %02x, TFIs = %08x > This looks more like summary that should be printed down below. it's the current state, it's fine keeping it this way imho, it lets you know what detach is going to work on. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a Gerrit-Change-Number: 26176 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 13:56:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 13:59:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 13:59:08 +0000 Subject: Change in osmo-bts[master]: rsl: exclude disabled timeslots from interference reports In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26178 ) Change subject: rsl: exclude disabled timeslots from interference reports ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/26178/2/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/26178/2/src/common/l1sap.c at 600 PS2, Line 600: if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) I'd prefer checking against those 2 values together since conceptually they are coupled (as in the state being the joined value), but fine anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Gerrit-Change-Number: 26178 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 13:59:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 14:00:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 14:00:16 +0000 Subject: Change in osmo-pcu[master]: pdch: Log TS enable/disable transitions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26177 ) Change subject: pdch: Log TS enable/disable transitions ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp at 147 PS1, Line 147: OSMO_ASSERT > Unrelated to this patch, but do we really want to assert() here? [?] We want to assert here for sure. But using _is_enabled is informative for regular use for user when looking at logs, as well as it's really informative when this assert is hit, since last message is "enabled => enabled". -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52 Gerrit-Change-Number: 26177 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 14:00:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 14:04:09 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Nov 2021 14:04:09 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Nice api and well documented, LGTM https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h File include/osmocom/bsc/time_cc.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h at 1 PS6, Line 1: /* Report the cumulative counter of time for which a flag is true as rate counter. */ Missing license header https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h at 37 PS6, Line 37: * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a possible (This goes over 120 characters, so it wraps here in gerrit review for me. I think longer text comments are easier to read at less characters per line, so usually I ":set colorcolumn=80" for those.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 14:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 14:08:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 14:08:33 +0000 Subject: Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log} In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 ) Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} ...................................................................... stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Related: SYS#5713 --- M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 308bab6..c6c50ef 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -312,8 +312,8 @@ srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_STATSD, name); if (!srep) { - vty_out(vty, "%% No statsd logging active%s", - VTY_NEWLINE); + vty_out(vty, "%% There is no such statsd reporter with name '%s'%s", + name ? name : "", VTY_NEWLINE); return CMD_WARNING; } @@ -366,8 +366,8 @@ srep = osmo_stats_reporter_find(OSMO_STATS_REPORTER_LOG, name); if (!srep) { - vty_out(vty, "%% No log reporting active%s", - VTY_NEWLINE); + vty_out(vty, "%% There is no such log reporter with name '%s'%s", + name ? name : "", VTY_NEWLINE); return CMD_WARNING; } diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index ddfb3a6..94cc7e8 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -203,6 +203,11 @@ stats_vty_test(config)# show running-config ... !(foo|bar|zoo) +stats_vty_test(config)# no stats reporter statsd statsd-foo +% There is no such statsd reporter with name 'statsd-foo' +stats_vty_test(config)# no stats reporter log log-zoo +% There is no such log reporter with name 'log-zoo' + stats_vty_test(config)# stats interval 1337 stats_vty_test(config)# show running-config -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04 Gerrit-Change-Number: 26175 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 15:53:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 15:53:39 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: Simplify tfi_find_free logic References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26180 ) Change subject: ts_alloc: Simplify tfi_find_free logic ...................................................................... ts_alloc: Simplify tfi_find_free logic Avoid passing an extra pram which is accessible by GprsMs object already being passed. Once, the "trx = ms_current_trx(ms)" is moved inside the tfi_find_free function, it becomes clear that all the logic can be further simplified. Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 6 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/26180/1 diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index 5b3b355..c3709c5 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -298,20 +298,21 @@ /*! Return free TFI * * \param[in] bts Pointer to BTS struct - * \param[in] trx Optional pointer to TRX struct * \param[in] ms Pointer to MS object * \param[in] dir DL or UL direction * \param[in] use_trx which TRX to use or -1 if it should be selected based on what MS uses * \param[out] trx_no_ TRX number on which TFI was found * \returns negative error code or 0 on success */ -static int tfi_find_free(const struct gprs_rlcmac_bts *bts, const gprs_rlcmac_trx *trx, const GprsMs *ms, +static int tfi_find_free(const struct gprs_rlcmac_bts *bts, const GprsMs *ms, enum gprs_rlcmac_tbf_direction dir, int8_t use_trx, uint8_t *trx_no_) { + struct gprs_rlcmac_trx *trx; int tfi; uint8_t trx_no; - if (trx) { + /* If MS is already doing stuff on a TRX, set use_trx to it: */ + if ((trx = ms_current_trx(ms))) { if (use_trx >= 0 && use_trx != trx->trx_no) { LOGP(DRLCMAC, LOGL_ERROR, "- Requested incompatible TRX %d (current is %d)\n", use_trx, trx->trx_no); @@ -320,9 +321,6 @@ use_trx = trx->trx_no; } - if (use_trx == -1 && ms_current_trx(ms)) - use_trx = ms_current_trx(ms)->trx_no; - tfi = bts_tfi_find_free(bts, dir, &trx_no, use_trx); if (tfi < 0) return -EBUSY; @@ -884,18 +882,16 @@ reserved_dl_slots = ms_reserved_dl_slots(ms); reserved_ul_slots = ms_reserved_ul_slots(ms); first_common_ts = ms_first_common_ts(ms); - trx = ms_current_trx(ms); /* Step 2a: Find usable TRX and TFI */ - tfi = tfi_find_free(bts, trx, ms, tbf->direction, use_trx, &trx_no); + tfi = tfi_find_free(bts, ms, tbf->direction, use_trx, &trx_no); if (tfi < 0) { LOGPAL(tbf, "B", single, use_trx, LOGL_NOTICE, "failed to allocate a TFI\n"); return tfi; } /* Step 2b: Reserve slots on the TRX for the MS */ - if (!trx) - trx = &bts->trx[trx_no]; + trx = &bts->trx[trx_no]; if (!reserved_dl_slots || !reserved_ul_slots) { rc = find_multi_slots(trx, ms_ms_class(ms), &reserved_ul_slots, &reserved_dl_slots); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 Gerrit-Change-Number: 26180 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 16:38:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 16:38:46 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename function to clraify what it does References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26181 ) Change subject: ts_alloc: rename function to clraify what it does ...................................................................... ts_alloc: rename function to clraify what it does The function updates nothing, so it's misleading. It simply counts slots, so let's call it like that. Change-Id: I55954321d6f2b5e755177a8829512da371e934aa --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/26181/1 diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index c3709c5..dc46b84 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -661,7 +661,7 @@ * \param[out] slotcount Number of TS in use * \param[out] avail_count Number of reserved TS */ -static void update_slot_counters(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count) +static void count_slots(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count) { (*slotcount) = pcu_bitcount(slots); (*avail_count) = pcu_bitcount(reserved_slots); @@ -910,7 +910,7 @@ /* Step 3b: Derive the slot set for a given direction */ if (tbf->direction == GPRS_RLCMAC_DL_TBF) { dl_slots = rc; - update_slot_counters(dl_slots, reserved_dl_slots, &slotcount, &avail_count); + count_slots(dl_slots, reserved_dl_slots, &slotcount, &avail_count); } else { rc = allocate_usf(trx, rc, dl_slots, usf); if (rc < 0) @@ -919,7 +919,7 @@ ul_slots = rc; reserved_ul_slots = ul_slots; - update_slot_counters(ul_slots, reserved_ul_slots, &slotcount, &avail_count); + count_slots(ul_slots, reserved_ul_slots, &slotcount, &avail_count); } first_ts = ffs(rc) - 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I55954321d6f2b5e755177a8829512da371e934aa Gerrit-Change-Number: 26181 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 16:38:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 16:38:46 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename variable to clarify meaning References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26182 ) Change subject: ts_alloc: rename variable to clarify meaning ...................................................................... ts_alloc: rename variable to clarify meaning The variable counts reserved slots, not available one. It can easily be seen by checking function count_slots() documentation "Number of reserved TS". The previous naming was used probably to indicate "available to reserve" TS, but the naming is misleading. Change-Id: Ib58e87d5a067d20d0b331fe32dff61b95ecc3e3f --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/26182/1 diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index dc46b84..d86d9c3 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -659,12 +659,12 @@ * \param[in] slots Timeslots in use * \param[in] reserved_slots Reserved timeslots * \param[out] slotcount Number of TS in use - * \param[out] avail_count Number of reserved TS + * \param[out] reserve_count Number of reserved TS */ -static void count_slots(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count) +static void count_slots(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *reserve_count) { (*slotcount) = pcu_bitcount(slots); - (*avail_count) = pcu_bitcount(reserved_slots); + (*reserve_count) = pcu_bitcount(reserved_slots); } /*! Return slot mask with single TS from a given UL/DL set according to TBF's direction, ts pointer is set to that TS @@ -867,7 +867,7 @@ uint8_t reserved_ul_slots; int8_t first_common_ts; uint8_t slotcount = 0; - uint8_t avail_count = 0, trx_no; + uint8_t reserve_count = 0, trx_no; int first_ts = -1; int usf[8] = {-1, -1, -1, -1, -1, -1, -1, -1}; int rc; @@ -910,7 +910,7 @@ /* Step 3b: Derive the slot set for a given direction */ if (tbf->direction == GPRS_RLCMAC_DL_TBF) { dl_slots = rc; - count_slots(dl_slots, reserved_dl_slots, &slotcount, &avail_count); + count_slots(dl_slots, reserved_dl_slots, &slotcount, &reserve_count); } else { rc = allocate_usf(trx, rc, dl_slots, usf); if (rc < 0) @@ -919,7 +919,7 @@ ul_slots = rc; reserved_ul_slots = ul_slots; - count_slots(ul_slots, reserved_ul_slots, &slotcount, &avail_count); + count_slots(ul_slots, reserved_ul_slots, &slotcount, &reserve_count); } first_ts = ffs(rc) - 1; @@ -936,7 +936,7 @@ } if (single && slotcount) { - tbf->upgrade_to_multislot = (avail_count > slotcount); + tbf->upgrade_to_multislot = (reserve_count > slotcount); LOGPAL(tbf, "B", single, use_trx, LOGL_INFO, "using single slot at TS %d\n", first_ts); } else { tbf->upgrade_to_multislot = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib58e87d5a067d20d0b331fe32dff61b95ecc3e3f Gerrit-Change-Number: 26182 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:45:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 17:45:22 +0000 Subject: Change in osmo-pcu[master]: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26183 ) Change subject: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled ...................................................................... pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled Otherwise, after the TS is disabled, a new TBF created for that MS may end up in alloc_algorithm assigning the disabled TS, since it will be in the mask of reserved PDCH TS for that MS. Related: SYS#5356 Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c --- M src/pdch.cpp 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/26183/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 6aae7d1..4d82ab1 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -131,6 +131,32 @@ } } +/* Make sure the PDCH vanished from the mask of reserved PDCHs for all MS, to + * avoid alloc_algorithm using it. */ +static void pdch_unreserve_all_ms_reserved_slots(struct gprs_rlcmac_pdch *pdch) +{ + struct llist_head *tmp; + uint8_t ts_rm_mask = (~(1 << pdch->ts_no)); + struct gprs_rlcmac_trx *trx = pdch->trx; + + llist_for_each(tmp, bts_ms_list(trx->bts)) { + struct GprsMs *ms = llist_entry(tmp, typeof(*ms), list); + if (ms->current_trx != trx) + continue; + uint8_t old_dl_slots = ms_reserved_dl_slots(ms); + uint8_t old_ul_slots = ms_reserved_ul_slots(ms); + uint8_t new_dl_slots = old_dl_slots & ts_rm_mask; + uint8_t new_ul_slots = old_ul_slots & ts_rm_mask; + if (old_dl_slots == new_dl_slots && old_ul_slots == new_ul_slots) + continue; + ms_set_reserved_slots(ms, trx, new_ul_slots, new_dl_slots); + } + if (pdch->num_reserved(GPRS_RLCMAC_UL_TBF) > 0 || pdch->num_reserved(GPRS_RLCMAC_DL_TBF) > 0) + LOGPDCH(pdch, DRLCMAC, LOGL_ERROR, + "Reserved TS count not zero after unreserving from all current MS in list! UL=%u DL=%u\n", + pdch->num_reserved(GPRS_RLCMAC_UL_TBF), pdch->num_reserved(GPRS_RLCMAC_DL_TBF)); +} + void pdch_init(struct gprs_rlcmac_pdch *pdch, struct gprs_rlcmac_trx *trx, uint8_t ts_nr) { pdch->ts_no = ts_nr; @@ -171,6 +197,8 @@ /* kick all TBF on slot */ pdch_free_all_tbf(this); + pdch_unreserve_all_ms_reserved_slots(this); + /* flush all pending paging messages */ while ((pag = dequeue_paging())) talloc_free(pag); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c Gerrit-Change-Number: 26183 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:45:49 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:45:49 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 27 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 09 Nov 2021 17:45:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:45:51 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:45:51 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 ) Change subject: adjust mgcp response context ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 09 Nov 2021 17:45:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:45:53 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:45:53 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 ) Change subject: add a lock-free bounded spsc interthread queue ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 19 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 17:45:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:45:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 9 Nov 2021 17:45:59 +0000 Subject: Change in osmo-pcu[master]: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/26183 ) Change subject: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled ...................................................................... pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled Otherwise, after the TS is disabled, a new TBF created for that MS may end up in alloc_algorithm assigning the disabled TS, since it will be in the mask of reserved PDCH TS for that MS. Related: OS#5265 Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c --- M src/pdch.cpp 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/26183/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c Gerrit-Change-Number: 26183 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:48:25 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 17:48:25 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: bootstrap_bts: print errornous ARFCN number References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26184 ) Change subject: osmo_bsc_main: bootstrap_bts: print errornous ARFCN number ...................................................................... osmo_bsc_main: bootstrap_bts: print errornous ARFCN number The function bootstrap_bts verifies that the ARFCN number is within the valid range of the current band. In case of error it prints that the ARFCN is out of range, but it does not print the BTS number, nor the ARFCN number. Change-Id: I432448b4bd5ea1a209838a6c5105cc1e9f7d80ee --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/26184/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 17196e9..a39c109 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -447,32 +447,32 @@ switch (bts->band) { case GSM_BAND_1800: if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) { - LOGP(DNM, LOGL_ERROR, "GSM1800 channel must be between 512-885.\n"); + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1800 channel (%u) must be between 512-885.\n", + bts->nr, bts->c0->arfcn); return -EINVAL; } break; case GSM_BAND_1900: if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { - LOGP(DNM, LOGL_ERROR, "GSM1900 channel must be between 512-810.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n", + bts->nr, bts->c0->arfcn); } break; case GSM_BAND_900: if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 0-124, 955-1023.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", + bts->nr, bts->c0->arfcn); } break; case GSM_BAND_850: if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) { - LOGP(DNM, LOGL_ERROR, "GSM850 channel must be between 128-251.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n", + bts->nr, bts->c0->arfcn); } break; default: - LOGP(DNM, LOGL_ERROR, "Unsupported frequency band.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr); } /* Verify the physical channel mapping */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I432448b4bd5ea1a209838a6c5105cc1e9f7d80ee Gerrit-Change-Number: 26184 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:48:25 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 17:48:25 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: separate checks from bootstrap_bts References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26185 ) Change subject: osmo_bsc_main: separate checks from bootstrap_bts ...................................................................... osmo_bsc_main: separate checks from bootstrap_bts The function bootstrap_bts does a few checks before it does the actual initialization. To make the code more modular, lets split the function into two functions, check_bts and bootstrap_bts. Also be sure that we print the BTS number when the check failes. Change-Id: Id2b26f147d2f35e156e2da8ee58d2bbbb93de4ac Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 11 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/26185/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index a39c109..11db260 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -436,10 +436,9 @@ return 0; } -static int bootstrap_bts(struct gsm_bts *bts) +static int check_bts(struct gsm_bts *bts) { struct gsm_bts_trx *trx; - unsigned int n = 0; if (!bts->model) return -EFAULT; @@ -484,6 +483,13 @@ } } + return 0; +} + +static void bootstrap_bts(struct gsm_bts *bts) +{ + unsigned int n = 0; + /* Control Channel Description is set from vty/config */ /* Determine the value of CCCH_CONF. Is TS0/C0 combined? */ @@ -510,8 +516,6 @@ /* Initialize the BTS state */ gsm_bts_sm_mo_reset(bts->site_mgr); - - return 0; } static int bsc_network_configure(const char *config_file) @@ -535,11 +539,12 @@ osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) { - rc = bootstrap_bts(bts); + rc = check_bts(bts); if (rc < 0) { - LOGP(DNM, LOGL_FATAL, "Error bootstrapping BTS\n"); + LOGP(DNM, LOGL_FATAL, "(bts=%u) cannot bootstrap BTS, invalid BTS configuration\n", bts->nr); return rc; } + bootstrap_bts(bts); rc = e1_reconfig_bts(bts); if (rc < 0) { LOGP(DNM, LOGL_FATAL, "Error enabling E1 input driver\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id2b26f147d2f35e156e2da8ee58d2bbbb93de4ac Gerrit-Change-Number: 26185 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:48:26 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 17:48:26 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26186 ) Change subject: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts ...................................................................... osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts In order to be able to call check_bts() and bootstrap_bts() from inp_sig_cb(), we must move it below bootstrap_bts. Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 47 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/26186/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 11db260..fae2ef2 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -389,53 +389,6 @@ osmo_timer_schedule(&update_connection_stats_timer, 1, 0); } -/* Callback function to be called every time we receive a signal from INPUT */ -static int inp_sig_cb(unsigned int subsys, unsigned int signal, - void *handler_data, void *signal_data) -{ - struct input_signal_data *isd = signal_data; - struct gsm_bts_trx *trx = isd->trx; - - if (subsys != SS_L_INPUT) - return -EINVAL; - - LOGP(DLMI, LOGL_DEBUG, "%s(): Input signal '%s' received\n", __func__, - get_value_string(e1inp_signal_names, signal)); - switch (signal) { - case S_L_INP_TEI_UP: - if (isd->link_type == E1INP_SIGN_OML) { - /* Generate Mobile Allocation bit-masks for all timeslots. - * This needs to be done here, because it's used for TS configuration. */ - generate_ma_for_bts(trx->bts); - } - if (isd->link_type == E1INP_SIGN_RSL) - bootstrap_rsl(trx); - break; - case S_L_INP_TEI_DN: - LOG_TRX(trx, DLMI, LOGL_ERROR, "Lost E1 %s link\n", e1inp_signtype_name(isd->link_type)); - - if (isd->link_type == E1INP_SIGN_OML) { - rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_OML_FAIL)); - all_ts_dispatch_event(trx, TS_EV_OML_DOWN); - } else if (isd->link_type == E1INP_SIGN_RSL) { - rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_RSL_FAIL)); - acc_ramp_abort(&trx->bts->acc_ramp); - all_ts_dispatch_event(trx, TS_EV_RSL_DOWN); - if (trx->nr == 0) - osmo_timer_del(&trx->bts->cbch_timer); - } - - gsm_bts_sm_mo_reset(trx->bts->site_mgr); - - abis_nm_clear_queue(trx->bts); - break; - default: - break; - } - - return 0; -} - static int check_bts(struct gsm_bts *bts) { struct gsm_bts_trx *trx; @@ -518,6 +471,53 @@ gsm_bts_sm_mo_reset(bts->site_mgr); } +/* Callback function to be called every time we receive a signal from INPUT */ +static int inp_sig_cb(unsigned int subsys, unsigned int signal, + void *handler_data, void *signal_data) +{ + struct input_signal_data *isd = signal_data; + struct gsm_bts_trx *trx = isd->trx; + + if (subsys != SS_L_INPUT) + return -EINVAL; + + LOGP(DLMI, LOGL_DEBUG, "%s(): Input signal '%s' received\n", __func__, + get_value_string(e1inp_signal_names, signal)); + switch (signal) { + case S_L_INP_TEI_UP: + if (isd->link_type == E1INP_SIGN_OML) { + /* Generate Mobile Allocation bit-masks for all timeslots. + * This needs to be done here, because it's used for TS configuration. */ + generate_ma_for_bts(trx->bts); + } + if (isd->link_type == E1INP_SIGN_RSL) + bootstrap_rsl(trx); + break; + case S_L_INP_TEI_DN: + LOG_TRX(trx, DLMI, LOGL_ERROR, "Lost E1 %s link\n", e1inp_signtype_name(isd->link_type)); + + if (isd->link_type == E1INP_SIGN_OML) { + rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_OML_FAIL)); + all_ts_dispatch_event(trx, TS_EV_OML_DOWN); + } else if (isd->link_type == E1INP_SIGN_RSL) { + rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_RSL_FAIL)); + acc_ramp_abort(&trx->bts->acc_ramp); + all_ts_dispatch_event(trx, TS_EV_RSL_DOWN); + if (trx->nr == 0) + osmo_timer_del(&trx->bts->cbch_timer); + } + + gsm_bts_sm_mo_reset(trx->bts->site_mgr); + + abis_nm_clear_queue(trx->bts); + break; + default: + break; + } + + return 0; +} + static int bsc_network_configure(const char *config_file) { struct gsm_bts *bts; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Gerrit-Change-Number: 26186 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:48:26 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 17:48:26 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26187 ) Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() The function generate_ma_for_bts() is called when the OML TEI comes up. In the same code path boostrap_bts() is called as well. It would be more logical to call generate_ma_for_bts() from boostrap_bts() since it is also part of the bootstrapping process. Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Related: OS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/26187/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 9c97d9e..a2d367b 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -469,6 +469,10 @@ /* Initialize the BTS state */ gsm_bts_sm_mo_reset(bts->site_mgr); + + /* Generate Mobile Allocation bit-masks for all timeslots. + * This needs to be done here, because it's used for TS configuration. */ + generate_ma_for_bts(bts); } /* Callback function to be called every time we receive a signal from INPUT */ @@ -487,9 +491,6 @@ switch (signal) { case S_L_INP_TEI_UP: if (isd->link_type == E1INP_SIGN_OML) { - /* Generate Mobile Allocation bit-masks for all timeslots. - * This needs to be done here, because it's used for TS configuration. */ - generate_ma_for_bts(trx->bts); /* Check parameters and apply vty config dependent parameters */ rc = check_bts(trx->bts); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:49:01 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 9 Nov 2021 17:49:01 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Nov 2021 17:49:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:51:26 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:51:26 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 to look at the new patch set (#20). Change subject: add a lock-free bounded spsc interthread queue ...................................................................... add a lock-free bounded spsc interthread queue Not entirely wait-free: allows waiting on a fd, and in general fd notifications for poll-loop integration between threads. Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 --- A include/osmocom/mgcp/mgcp_threads_queue.h A src/libosmo-mgcp/mgcp_threads_queue.c 2 files changed, 260 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/31/25431/20 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 20 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:51:26 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:51:26 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#28). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then ansers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 14 files changed, 1,028 insertions(+), 349 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/28 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 28 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:51:28 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:51:28 +0000 Subject: Change in osmo-mgw[master]: fix up some docstrings that lost their dot References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26188 ) Change subject: fix up some docstrings that lost their dot ...................................................................... fix up some docstrings that lost their dot Change-Id: I88333c165f1dc11ae29f4c1726c15656386d1f0e --- M src/libosmo-mgcp/mgcp_endp.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/88/26188/1 diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 247baac..a41e0d0 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -224,9 +224,9 @@ } /*! Find an endpoint of a trunk specified by its name. - * \param[in] epname endpoint name to check - * \param[in] trunk mgcp_trunk that might have this endpoint - * \returns NULL if no ep found, else endpoint */ + * \param[in] epname endpoint name to check. + * \param[in] trunk mgcp_trunk that might have this endpoint. + * \returns NULL if no ep found, else endpoint. */ struct mgcp_endpoint *mgcp_endp_find_specific(const char *epname, const struct mgcp_trunk *trunk) { -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I88333c165f1dc11ae29f4c1726c15656386d1f0e Gerrit-Change-Number: 26188 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:51:28 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:51:28 +0000 Subject: Change in osmo-mgw[master]: rework message handling References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... rework message handling This was previously broken and a free endpoint was requirted to dlcx *, additionaly globally handling this is difficult due to different response codes, so just do it in the functions, they know best. Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 57 insertions(+), 58 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/89/26189/1 diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index f0c184b..7775415 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -97,10 +97,6 @@ /* function pointer to the request handler */ struct msgb *(*handle_request)(struct mgcp_request_data *data); - /* true if the request requires an endpoint, false if only a trunk - * is sufficient. (corner cases, e.g. wildcarded DLCX) */ - bool require_endp; - /* a human readable name that describes the request */ char *debug_name; }; @@ -112,32 +108,34 @@ static struct msgb *handle_rsip(struct mgcp_request_data *data); static struct msgb *handle_noti_req(struct mgcp_request_data *data); static const struct mgcp_request mgcp_requests[] = { - { .name = "AUEP", - .handle_request = handle_audit_endpoint, - .debug_name = "AuditEndpoint", - .require_endp = true }, - { .name = "CRCX", - .handle_request = handle_create_con, - .debug_name = "CreateConnection", - .require_endp = true }, - { .name = "DLCX", - .handle_request = handle_delete_con, - .debug_name = "DeleteConnection", - .require_endp = false }, - { .name = "MDCX", - .handle_request = handle_modify_con, - .debug_name = "ModifiyConnection", - .require_endp = true }, - { .name = "RQNT", - .handle_request = handle_noti_req, - .debug_name = "NotificationRequest", - .require_endp = true }, + { .name = "AUEP", .handle_request = handle_audit_endpoint, .debug_name = "AuditEndpoint" }, + { + .name = "CRCX", + .handle_request = handle_create_con, + .debug_name = "CreateConnection", + }, + { + .name = "DLCX", + .handle_request = handle_delete_con, + .debug_name = "DeleteConnection", + }, + { + .name = "MDCX", + .handle_request = handle_modify_con, + .debug_name = "ModifiyConnection", + }, + { + .name = "RQNT", + .handle_request = handle_noti_req, + .debug_name = "NotificationRequest", + }, /* SPEC extension */ - { .name = "RSIP", - .handle_request = handle_rsip, - .debug_name = "ReSetInProgress", - .require_endp = true }, + { + .name = "RSIP", + .handle_request = handle_rsip, + .debug_name = "ReSetInProgress", + }, }; /* Initalize transcoder */ @@ -424,17 +422,8 @@ } /* Find an appropriate handler for the current request and execute it */ - for (i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { + for (int i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { if (strcmp(mgcp_requests[i].name, rq.name) == 0) { - /* Check if the request requires and endpoint, if yes, check if we have it, otherwise don't - * execute the request handler. */ - if (mgcp_requests[i].require_endp && !rq.endp) { - LOGP(DLMGCP, LOGL_ERROR, - "%s: the request handler \"%s\" requires an endpoint resource for \"%s\", which is not available -- abort\n", - rq.name, mgcp_requests[i].debug_name, pdata.epname); - return create_err_response(rq.trunk, NULL, -rq.mgcp_cause, rq.name, pdata.trans); - } - /* Execute request handler */ if (rq.endp) LOGP(DLMGCP, LOGL_INFO, @@ -465,6 +454,11 @@ static struct msgb *handle_audit_endpoint(struct mgcp_request_data *rq) { LOGPENDP(rq->endp, DLMGCP, LOGL_NOTICE, "AUEP: auditing endpoint ...\n"); + if (!rq->endp || !mgcp_endp_avail(rq->endp)) { + LOGPENDP(rq->endp, DLMGCP, LOGL_ERROR, "AUEP: selected endpoint not available!\n"); + return create_err_response(rq->trunk, NULL, 501, "AUEP", rq->pdata->trans); + } + return create_ok_response(rq->trunk, rq->endp, 200, "AUEP", rq->pdata->trans); } @@ -859,6 +853,13 @@ LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "CRCX: creating new connection ...\n"); + /* we must have a free ep */ + if (!endp) { + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); + LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: no free endpoints available!\n"); + return create_err_response(rq->trunk, NULL, 403, "CRCX", pdata->trans); + } + if (!mgcp_endp_avail(endp)) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); LOGPENDP(endp, DLMGCP, LOGL_ERROR, @@ -1116,13 +1117,6 @@ LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "MDCX: modifying existing connection ...\n"); - if (!mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_AVAIL)); - LOGPENDP(endp, DLMGCP, LOGL_ERROR, - "MDCX: selected endpoint not available!\n"); - return create_err_response(endp, NULL, 501, "MDCX", pdata->trans); - } - /* Prohibit wildcarded requests */ if (rq->wildcarded) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, @@ -1131,6 +1125,11 @@ return create_err_response(rq->trunk, endp, 507, "MDCX", pdata->trans); } + if (!endp || !mgcp_endp_avail(endp)) { + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_AVAIL)); + LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: selected endpoint not available!\n"); + return create_err_response(rq->trunk, NULL, 501, "MDCX", pdata->trans); + } if (llist_count(&endp->conns) <= 0) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: endpoint is not holding a connection.\n"); @@ -1349,6 +1348,19 @@ return create_err_response(endp, endp, 515, "DLCX", pdata->trans); } + /* Handle wildcarded DLCX that refers to the whole trunk. This means + * that we walk over all endpoints on the trunk in order to drop all + * connections on the trunk. (see also RFC3435 Annex F.7) */ + if (rq->wildcarded) { + int num_conns = 0; + for (i = 0; i < trunk->number_endpoints; i++) { + num_conns += llist_count(&trunk->endpoints[i]->conns); + mgcp_endp_release(trunk->endpoints[i]); + } + rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); + return create_ok_response(trunk, NULL, 200, "DLCX", pdata->trans); + } + for_each_line(line, pdata->save) { if (!mgcp_check_param(endp, trunk, line)) continue; @@ -1398,19 +1410,6 @@ } } - /* Handle wildcarded DLCX that refers to the whole trunk. This means - * that we walk over all endpoints on the trunk in order to drop all - * connections on the trunk. (see also RFC3435 Annex F.7) */ - if (rq->wildcarded) { - int num_conns = 0; - for (i = 0; i < trunk->number_endpoints; i++) { - num_conns += llist_count(&trunk->endpoints[i]->conns); - mgcp_endp_release(trunk->endpoints[i]); - } - rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); - return create_ok_response(trunk, NULL, 200, "DLCX", pdata->trans); - } - /* The logic does not permit to go past this point without having the * the endp pointer populated. */ OSMO_ASSERT(endp); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 17:51:29 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 17:51:29 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 247 insertions(+), 216 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/1 diff --git a/include/osmocom/mgcp/mgcp_conn.h b/include/osmocom/mgcp/mgcp_conn.h index 4f882e9..8ab61d1 100644 --- a/include/osmocom/mgcp/mgcp_conn.h +++ b/include/osmocom/mgcp/mgcp_conn.h @@ -29,6 +29,7 @@ #include #include #include +#include #define LOGPCONN(conn, cat, level, fmt, args...) \ LOGPENDP((conn)->endp, cat, level, "CI:%s " fmt, \ @@ -93,7 +94,7 @@ } stats; } osmux; - struct rate_ctr_group *rate_ctr_group; + atomic_uint_least64_t atomic_counters[_MAX_RTP_CTR_NUM]; }; /*! MGCP connection (untyped) */ @@ -131,17 +132,6 @@ void *priv; }; -/* RTP connection related counters */ -enum { - IN_STREAM_ERR_TSTMP_CTR, - OUT_STREAM_ERR_TSTMP_CTR, - RTP_PACKETS_RX_CTR, - RTP_OCTETS_RX_CTR, - RTP_PACKETS_TX_CTR, - RTP_OCTETS_TX_CTR, - RTP_DROPPED_PACKETS_CTR, - RTP_NUM_CONNECTIONS, -}; /* RTP per-connection statistics. Instances of the corresponding rate counter group * exist for the lifetime of an RTP connection. diff --git a/include/osmocom/mgcp/mgcp_network.h b/include/osmocom/mgcp/mgcp_network.h index b9cf5e3..75e6ae6 100644 --- a/include/osmocom/mgcp/mgcp_network.h +++ b/include/osmocom/mgcp/mgcp_network.h @@ -1,6 +1,7 @@ #pragma once #include +#include #include #include @@ -23,7 +24,7 @@ uint32_t ssrc; uint16_t last_seq; uint32_t last_timestamp; - struct rate_ctr *err_ts_ctr; + atomic_uint_least64_t err_ts_ctr; int32_t last_tsdelta; uint32_t last_arrival_time; }; diff --git a/include/osmocom/mgcp/mgcp_ratectr.h b/include/osmocom/mgcp/mgcp_ratectr.h index c03c4e1..8c0cb8e 100644 --- a/include/osmocom/mgcp/mgcp_ratectr.h +++ b/include/osmocom/mgcp/mgcp_ratectr.h @@ -1,4 +1,18 @@ #pragma once +#include + +/* RTP connection related counters */ +enum { + IN_STREAM_ERR_TSTMP_CTR, + OUT_STREAM_ERR_TSTMP_CTR, + RTP_PACKETS_RX_CTR, + RTP_OCTETS_RX_CTR, + RTP_PACKETS_TX_CTR, + RTP_OCTETS_TX_CTR, + RTP_DROPPED_PACKETS_CTR, + RTP_NUM_CONNECTIONS, + _MAX_RTP_CTR_NUM +}; /* Global MCGP general rate counters */ enum { @@ -8,6 +22,7 @@ MGCP_GENERAL_RX_MSGS_UNHANDLED, MGCP_GENERAL_RX_FAIL_MSG_PARSE, MGCP_GENERAL_RX_FAIL_NO_ENDPOINT, + _MGCP_GENERAL_NUM_ENUMS, }; /* Trunk-global MCGP CRCX related rate counters */ @@ -28,6 +43,7 @@ MGCP_CRCX_FAIL_BIND_PORT, MGCP_CRCX_FAIL_AVAIL, MGCP_CRCX_FAIL_CLAIM, + _MGCP_CRCX_NUM_ENUMS, }; /* Trunk-global MCGP MDCX related rate counters */ @@ -45,6 +61,7 @@ MGCP_MDCX_FAIL_NO_REMOTE_CONN_DESC, MGCP_MDCX_FAIL_START_RTP, MGCP_MDCX_FAIL_AVAIL, + _MGCP_MDCX_NUM_ENUMS, }; /* Trunk-global MCGP DLCX related rate counters */ @@ -55,13 +72,15 @@ MGCP_DLCX_FAIL_INVALID_CONNID, MGCP_DLCX_FAIL_UNHANDLED_PARAM, MGCP_DLCX_FAIL_AVAIL, + _MGCP_DLCX_NUM_ENUMS, }; /* Trunk-global E1 related counters */ enum { - E1_I460_TRAU_RX_FAIL_CTR, - E1_I460_TRAU_TX_FAIL_CTR, - E1_I460_TRAU_MUX_EMPTY_CTR, + E1_I460_TRAU_RX_FAIL_CTR, + E1_I460_TRAU_TX_FAIL_CTR, + E1_I460_TRAU_MUX_EMPTY_CTR, + _E1_I460_TRAU_NUM_ENUMS, }; /* NOTE: When adding counters, also the dump_ratectr_* routines in vty.c must be updated. */ @@ -69,6 +88,7 @@ struct mgcp_ratectr_global { /* Rate counter group which contains stats for generic MGCP events. */ struct rate_ctr_group *mgcp_general_ctr_group; + atomic_uint_least64_t mgcp_general_ctr_atomic[_MGCP_GENERAL_NUM_ENUMS]; }; struct mgcp_ratectr_trunk { @@ -79,9 +99,18 @@ /* Rate counter group which contains stats for processed DLCX commands. */ struct rate_ctr_group *mgcp_dlcx_ctr_group; /* Rate counter group which aggregates stats of individual RTP connections. */ - struct rate_ctr_group *all_rtp_conn_stats; + struct rate_ctr_group *all_rtp_conn_stats_group; /* Rate counter group which contains stats for E1 events (only valid for E1 trunks) */ - struct rate_ctr_group *e1_stats; + struct rate_ctr_group *e1_stats_group; +}; + +/* as above, but just counters updated by the trunkthreads, then aggregated by the main thread */ +struct mgcp_per_thread_ctr_trunk { + atomic_uint_least64_t mgcp_crcx_ctr_atomic[_MGCP_CRCX_NUM_ENUMS]; + atomic_uint_least64_t mgcp_mdcx_ctr_atomic[_MGCP_MDCX_NUM_ENUMS]; + atomic_uint_least64_t mgcp_dlcx_ctr_atomic[_MGCP_DLCX_NUM_ENUMS]; + atomic_uint_least64_t all_rtp_conn_stats_atomic[_MAX_RTP_CTR_NUM]; + atomic_uint_least64_t e1_stats_atomic[_E1_I460_TRAU_NUM_ENUMS]; }; struct mgcp_config; diff --git a/include/osmocom/mgcp/mgcp_trunk.h b/include/osmocom/mgcp/mgcp_trunk.h index 36032b9..9058b51 100644 --- a/include/osmocom/mgcp/mgcp_trunk.h +++ b/include/osmocom/mgcp/mgcp_trunk.h @@ -27,8 +27,14 @@ struct per_thread_info *thread_info; int num_threads; /* number of threads for this parent trunk, related to thread_info */ bool use_threads; /* enables thread usage, set at cfg parsing time, ALWAYS false for e1/osmux */ - unsigned int number_endpoints_offset; /* offset for proper ep counting, since only the first thread starts at ep0 */ + unsigned int number_endpoints_offset; /* offset for proper ep counting, only first thread starts at ep0 */ struct mgcp_config *cfg; /* global cfg, points at private cfg copy in thread_info for child trunks */ + struct mgcp_per_thread_ctr_trunk thread_ctr; /* counters used by the threads, used by main thread */ + + /* rate counters and stat items to measure the trunks overall performance and health + updated by the main thread by aggregating the per-thread raw counters */ + struct mgcp_ratectr_trunk ratectr; /* NULL for the threads! */ + struct mgcp_stat_trunk stats; /* NULL for the threads! */ /* !!! no thread specific handling below this comment !!! */ @@ -62,10 +68,6 @@ unsigned int number_endpoints; struct mgcp_endpoint **endpoints; - /* rate counters and stat items to measure the trunks overall performance and health */ - struct mgcp_ratectr_trunk ratectr; - struct mgcp_stat_trunk stats; - union { /* Virtual trunk specific */ struct { diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 4f6e1a2..b360c15 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -35,15 +35,6 @@ #include #include -const static struct rate_ctr_group_desc rate_ctr_group_desc = { - .group_name_prefix = "conn_rtp", - .group_description = "rtp connection statistics", - .class_id = 1, - .num_ctr = ARRAY_SIZE(mgcp_conn_rate_ctr_desc), - .ctr_desc = mgcp_conn_rate_ctr_desc -}; - - /* Allocate a new connection identifier. According to RFC3435, they must * be unique only within the scope of the endpoint. (Caller must provide * memory for id) */ @@ -87,10 +78,6 @@ static int mgcp_rtp_conn_init(struct mgcp_conn_rtp *conn_rtp, struct mgcp_conn *conn) { struct mgcp_rtp_end *end = &conn_rtp->end; - /* FIXME: Each new rate counter group requires an unique index. At the - * moment we generate this index using this counter, but perhaps there - * is a more concious way to assign the indexes. */ - static atomic_uint rate_ctr_index = 0; conn_rtp->type = MGCP_RTP_DEFAULT; conn_rtp->osmux.cid_allocated = false; @@ -111,12 +98,8 @@ end->output_enabled = 0; end->maximum_packet_time = -1; - conn_rtp->rate_ctr_group = rate_ctr_group_alloc(conn, &rate_ctr_group_desc, rate_ctr_index++); - if (!conn_rtp->rate_ctr_group) - return -1; - - conn_rtp->state.in_stream.err_ts_ctr = rate_ctr_group_get_ctr(conn_rtp->rate_ctr_group, IN_STREAM_ERR_TSTMP_CTR); - conn_rtp->state.out_stream.err_ts_ctr = rate_ctr_group_get_ctr(conn_rtp->rate_ctr_group, OUT_STREAM_ERR_TSTMP_CTR); + memset(&conn_rtp->state, 0, sizeof(conn_rtp->state)); + memset(&conn_rtp->atomic_counters, 0, sizeof(conn_rtp->atomic_counters)); /* Make sure codec table is reset */ mgcp_codec_reset_all(conn_rtp); @@ -130,7 +113,6 @@ if (mgcp_conn_rtp_is_osmux(conn_rtp)) conn_osmux_disable(conn_rtp); mgcp_free_rtp_port(&conn_rtp->end); - rate_ctr_group_free(conn_rtp->rate_ctr_group); mgcp_codec_reset_all(conn_rtp); } @@ -258,24 +240,12 @@ static void aggregate_rtp_conn_stats(struct mgcp_endpoint *endp, struct mgcp_conn_rtp *conn_rtp) { - struct rate_ctr_group *all_stats = endp->trunk->ratectr.all_rtp_conn_stats; - struct rate_ctr_group *conn_stats = conn_rtp->rate_ctr_group; + atomic_uint_least64_t *per_trunk_stats = endp->trunk->thread_ctr.all_rtp_conn_stats_atomic; + atomic_uint_least64_t *per_conn_stats = conn_rtp->atomic_counters; - if (all_stats == NULL || conn_stats == NULL) - return; - - /* Compared to per-connection RTP statistics, aggregated RTP statistics - * contain one additional rate couter item (RTP_NUM_CONNECTIONS). - * All other counters in both counter groups correspond to each other. */ - OSMO_ASSERT(conn_stats->desc->num_ctr + 1 == all_stats->desc->num_ctr); - - /* all other counters are [now] updated in real-time */ - rate_ctr_add(rate_ctr_group_get_ctr(all_stats, IN_STREAM_ERR_TSTMP_CTR), - rate_ctr_group_get_ctr(conn_stats, IN_STREAM_ERR_TSTMP_CTR)->current); - rate_ctr_add(rate_ctr_group_get_ctr(all_stats, OUT_STREAM_ERR_TSTMP_CTR), - rate_ctr_group_get_ctr(conn_stats, OUT_STREAM_ERR_TSTMP_CTR)->current); - - rate_ctr_inc(rate_ctr_group_get_ctr(all_stats, RTP_NUM_CONNECTIONS)); + per_trunk_stats[IN_STREAM_ERR_TSTMP_CTR] += per_conn_stats[IN_STREAM_ERR_TSTMP_CTR]; + per_trunk_stats[OUT_STREAM_ERR_TSTMP_CTR] += per_conn_stats[OUT_STREAM_ERR_TSTMP_CTR]; + per_trunk_stats[RTP_NUM_CONNECTIONS]++; } /*! free a connection by its ID. diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 807904f..2de0baf 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -41,6 +41,7 @@ #include #include #include +#include #define DEBUG_BITS_MAX 80 #define DEBUG_BYTES_MAX 40 @@ -192,13 +193,13 @@ static void e1_i460_mux_empty_cb(struct osmo_i460_subchan *schan, void *user_data) { struct mgcp_endpoint *endp = user_data; - struct rate_ctr_group *rate_ctrs = endp->trunk->ratectr.e1_stats; + atomic_uint_least64_t *rate_ctrs = endp->trunk->thread_ctr.e1_stats_atomic; struct msgb *msg = msgb_alloc_c(endp->trunk, E1_TRAU_BITS_MSGB, "E1-I.460-IDLE-TX-TRAU-frame"); uint8_t *ptr; const uint8_t *ptr_ft; enum osmo_trau_frame_type ft; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, E1_I460_TRAU_MUX_EMPTY_CTR)); + rate_ctrs[E1_I460_TRAU_MUX_EMPTY_CTR]++; /* Choose an appropiate idle frame type */ ft = endp->e1.trau_rtp_st->type; @@ -242,7 +243,7 @@ unsigned int rtp_hdr_len = sizeof(struct rtp_hdr); struct mgcp_endpoint *endp = user_data; struct msgb *msg = msgb_alloc_c(endp->trunk, RTP_BUF_SIZE, "RTP-rx-from-E1"); - struct rate_ctr_group *rate_ctrs = endp->trunk->ratectr.e1_stats; + atomic_uint_least64_t *rate_ctrs = endp->trunk->thread_ctr.e1_stats_atomic; struct mgcp_conn *conn_dst; struct osmo_trau_frame fr; int rc; @@ -305,7 +306,7 @@ msgb_free(msg); return; skip: - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, E1_I460_TRAU_RX_FAIL_CTR)); + rate_ctrs[E1_I460_TRAU_RX_FAIL_CTR]++; msgb_free(msg); return; } @@ -627,7 +628,7 @@ int mgcp_e1_send_rtp(struct mgcp_endpoint *endp, struct mgcp_rtp_codec *codec, struct msgb *msg) { struct msgb *msg_tf = msgb_alloc_c(endp->trunk, E1_TRAU_BITS_MSGB, "E1-I.460-TX-TRAU-frame"); - struct rate_ctr_group *rate_ctrs = endp->trunk->ratectr.e1_stats; + atomic_uint_least64_t *rate_ctrs = endp->trunk->thread_ctr.e1_stats_atomic; unsigned int rtp_hdr_len = sizeof(struct rtp_hdr); struct osmo_trau_frame tf; uint8_t amr_ft; @@ -683,7 +684,7 @@ return 0; skip: - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, E1_I460_TRAU_TX_FAIL_CTR)); + rate_ctrs[E1_I460_TRAU_TX_FAIL_CTR]++; msgb_free(msg_tf); return -1; } diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 11ef9e0..72d5fdb 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -126,8 +126,6 @@ /* We must only decrement the stat item when the endpoint as actually * claimed. An endpoint is claimed when a call-id is set */ if (endp->callid) { - osmo_stat_item_dec(osmo_stat_item_group_get_item(endp->trunk->stats.common, - TRUNK_STAT_ENDPOINTS_USED), 1); endp->trunk->thread_info->eps_free++; } @@ -613,8 +611,6 @@ * connection ids) */ endp->callid = talloc_strdup(endp, callid); OSMO_ASSERT(endp->callid); - osmo_stat_item_inc(osmo_stat_item_group_get_item(endp->trunk->stats.common, - TRUNK_STAT_ENDPOINTS_USED), 1); endp->trunk->thread_info->eps_free--; /* Allocate resources */ diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 2d275ec..32ac930 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -21,6 +21,7 @@ * */ +#include #include #include #include @@ -62,12 +63,11 @@ static void rtpconn_rate_ctr_add(struct mgcp_conn_rtp *conn_rtp, struct mgcp_endpoint *endp, int id, int inc) { - struct rate_ctr_group *conn_stats = conn_rtp->rate_ctr_group; - struct rate_ctr_group *mgw_stats = endp->trunk->ratectr.all_rtp_conn_stats; + atomic_uint_least64_t *mgw_stats = endp->trunk->thread_ctr.all_rtp_conn_stats_atomic; /* add to both the per-connection and the global stats */ - rate_ctr_add(rate_ctr_group_get_ctr(conn_stats, id), inc); - rate_ctr_add(rate_ctr_group_get_ctr(mgw_stats, id), inc); + conn_rtp->atomic_counters[id] += inc; + mgw_stats[id] += inc; } static void rtpconn_rate_ctr_inc(struct mgcp_conn_rtp *conn_rtp, struct mgcp_endpoint *endp, int id) @@ -192,13 +192,10 @@ } /* Check timestamp and sequence number for plausibility */ -static int check_rtp_timestamp(const struct mgcp_endpoint *endp, - const struct mgcp_rtp_state *state, - const struct mgcp_rtp_stream_state *sstate, - const struct mgcp_rtp_end *rtp_end, - const struct osmo_sockaddr *addr, - uint16_t seq, uint32_t timestamp, - const char *text, int32_t * tsdelta_out) +static int check_rtp_timestamp(const struct mgcp_endpoint *endp, const struct mgcp_rtp_state *state, + struct mgcp_rtp_stream_state *sstate, const struct mgcp_rtp_end *rtp_end, + const struct osmo_sockaddr *addr, uint16_t seq, uint32_t timestamp, const char *text, + int32_t *tsdelta_out) { int32_t tsdelta; int32_t timestamp_error; @@ -210,7 +207,7 @@ if (seq == sstate->last_seq) { if (timestamp != sstate->last_timestamp) { - rate_ctr_inc(sstate->err_ts_ctr); + sstate->err_ts_ctr++; LOGPENDP(endp, DRTP, LOGL_ERROR, "The %s timestamp delta is != 0 but the sequence " "number %d is the same, " @@ -262,7 +259,7 @@ ts_alignment_error(sstate, state->packet_duration, timestamp); if (timestamp_error) { - rate_ctr_inc(sstate->err_ts_ctr); + sstate->err_ts_ctr++; LOGPENDP(endp, DRTP, LOGL_NOTICE, "The %s timestamp has an alignment error of %d " "on SSRC: %u " @@ -1501,8 +1498,8 @@ sizeof(struct sockaddr_in))); /* Increment RX statistics */ - rate_ctr_inc(rate_ctr_group_get_ctr(conn_src->rate_ctr_group, RTP_PACKETS_RX_CTR)); - rate_ctr_add(rate_ctr_group_get_ctr(conn_src->rate_ctr_group, RTP_OCTETS_RX_CTR), msgb_length(msg)); + conn_src->atomic_counters[RTP_PACKETS_RX_CTR]++; + conn_src->atomic_counters[RTP_OCTETS_RX_CTR]++; /* FIXME: count RTP and RTCP separately, also count IuUP payload-less separately */ /* Forward a copy of the RTP data to a debug ip/port */ diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index b746818..af77626 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -22,6 +22,7 @@ */ #include +#include #include #include #include @@ -314,18 +315,18 @@ * !! only public for testing !! */ struct msgb *mgcp_handle_message(struct mgcp_config *cfg, struct to_trunkthread_mgcp_msg *w) { - struct rate_ctr_group *rate_ctrs = cfg->ratectr.mgcp_general_ctr_group; + atomic_uint_least64_t *rate_ctrs = cfg->ratectr.mgcp_general_ctr_atomic; int code; ssize_t rc = w->x.msglen; struct mgcp_parse_data *pdata = &w->x.pdata; struct mgcp_request_data *rq = &w->x.rq; /* Count all messages, even incorect ones */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_TOTAL)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_TOTAL]++; if (rc < sizeof(rq->name) - 1) { LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_MSG_PARSE]++; return 0; } memcpy(rq->name, (const char *)&w->msg[0], sizeof(rq->name) - 1); @@ -335,7 +336,7 @@ /* attempt to treat it as a response */ if (sscanf((const char *)&w->msg[0], "%3d %*s", &code) == 1) { LOGP(DLMGCP, LOGL_DEBUG, "Response: Code: %d\n", code); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_MSG_PARSE]++; return 0; } @@ -343,7 +344,7 @@ rc = mgcp_parse_header(pdata, mgcp_strline((char *)&w->msg[4], &pdata->save)); if (rc < 0) { LOGP(DLMGCP, LOGL_ERROR, "%s: failed to parse MCGP message\n", rq->name); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_MSG_PARSE]++; return create_err_response(cfg, NULL, -rc, rq->name, "000000"); } @@ -418,7 +419,7 @@ { int rc = -500, handled = 0; struct msgb *resp = NULL; - struct rate_ctr_group *rate_ctrs = w->x.rq.trunk->cfg->ratectr.mgcp_general_ctr_group; + atomic_uint_least64_t *rate_ctrs = w->x.rq.trunk->cfg->ratectr.mgcp_general_ctr_atomic; struct mgcp_parse_data *pdata = &w->x.pdata; struct mgcp_request_data *rq = &w->x.rq; @@ -437,7 +438,7 @@ if (rq->wildcarded) { /* we know this is the trunk that handles this wildcarded message */ } else { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_NO_ENDPOINT)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_NO_ENDPOINT]++; /* If the endpoint name suggests that the request refers to a specific endpoint, then the * request cannot be handled and we must stop early. */ LOGP(DLMGCP, LOGL_NOTICE, "%s: cannot find endpoint \"%s\", cause=%d -- abort\n", rq->name, @@ -449,7 +450,7 @@ /* Check if we have to retransmit a response from a previous transaction */ if (pdata->trans && rq->endp->last_trans && strcmp(rq->endp->last_trans, pdata->trans) == 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_RETRANSMITTED)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_RETRANSMITTED]++; return create_retransmission_response(rq->endp); } } @@ -482,9 +483,9 @@ /* Check if the MGCP request was handled and increment rate counters accordingly - but don't count this multiple times */ if (!rq->wildcarded || (rq->wildcarded && !strcmp(rq->name, "CRCX"))) { if (handled) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_HANDLED)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_HANDLED]++; } else { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_UNHANDLED)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_UNHANDLED]++; LOGP(DLMGCP, LOGL_ERROR, "MSG with type: '%.4s' not handled\n", rq->name); } } @@ -881,7 +882,7 @@ struct mgcp_parse_data *pdata = rq->pdatap; struct mgcp_trunk *trunk = rq->trunk; struct mgcp_endpoint *endp = rq->endp; - struct rate_ctr_group *rate_ctrs = trunk->ratectr.mgcp_crcx_ctr_group; + atomic_uint_least64_t *rate_ctrs = trunk->thread_ctr.mgcp_crcx_ctr_atomic; int error_code = 400; const char *local_options = NULL; const char *callid = NULL; @@ -897,13 +898,13 @@ /* we must have a free ep */ if (!endp) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); + rate_ctrs[MGCP_CRCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: no free endpoints available!\n"); return create_err_response(rq->trunk, NULL, 403, "CRCX", pdata->trans); } if (!mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); + rate_ctrs[MGCP_CRCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "CRCX", pdata->trans); @@ -925,7 +926,7 @@ /* It is illegal to send a connection identifier * together with a CRCX, the MGW will assign the * connection identifier by itself on CRCX */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BAD_ACTION)); + rate_ctrs[MGCP_CRCX_FAIL_BAD_ACTION]++; return create_err_response(rq->trunk, NULL, 523, "CRCX", pdata->trans); break; case 'M': @@ -951,7 +952,7 @@ default: LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "CRCX: unhandled option: '%c'/%d\n", *line, *line); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_CRCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "CRCX", pdata->trans); break; } @@ -962,14 +963,14 @@ if (!callid) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: insufficient parameters, missing callid\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_MISSING_CALLID)); + rate_ctrs[MGCP_CRCX_FAIL_MISSING_CALLID]++; return create_err_response(endp, endp, 516, "CRCX", pdata->trans); } if (!mode) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: insufficient parameters, missing mode\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); + rate_ctrs[MGCP_CRCX_FAIL_INVALID_MODE]++; return create_err_response(endp, endp, 517, "CRCX", pdata->trans); } @@ -986,7 +987,7 @@ } else { /* There is no more room for a connection, leave * everything as it is and return with an error */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_LIMIT_EXCEEDED)); + rate_ctrs[MGCP_CRCX_FAIL_LIMIT_EXCEEDED]++; return create_err_response(endp, endp, 540, "CRCX", pdata->trans); } } @@ -1004,7 +1005,7 @@ else { /* This is not our call, leave everything as it is and * return with an error. */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_UNKNOWN_CALLID)); + rate_ctrs[MGCP_CRCX_FAIL_UNKNOWN_CALLID]++; return create_err_response(endp, endp, 400, "CRCX", pdata->trans); } } @@ -1015,7 +1016,7 @@ * the callid matches up (see above). */ rc = mgcp_endp_claim(endp, callid); if (rc != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_CLAIM)); + rate_ctrs[MGCP_CRCX_FAIL_CLAIM]++; return create_err_response(endp, endp, 502, "CRCX", pdata->trans); } } @@ -1025,7 +1026,7 @@ if (!_conn) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: unable to allocate RTP connection\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_ALLOC_CONN)); + rate_ctrs[MGCP_CRCX_FAIL_ALLOC_CONN]++; goto error2; } @@ -1035,7 +1036,7 @@ if (mgcp_parse_conn_mode(mode, endp, conn->conn) != 0) { error_code = 517; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); + rate_ctrs[MGCP_CRCX_FAIL_INVALID_MODE]++; goto error2; } @@ -1045,13 +1046,13 @@ if (osmux_cid >= -1) { /* -1 is wilcard, alloc next avail CID */ conn->osmux.state = OSMUX_STATE_ACTIVATING; if (conn_osmux_allocate_cid(conn, osmux_cid) == -1) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); + rate_ctrs[MGCP_CRCX_FAIL_NO_OSMUX]++; goto error2; } } else if (endp->trunk->cfg->osmux == OSMUX_USAGE_ONLY) { LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: osmux only and no osmux offered\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); + rate_ctrs[MGCP_CRCX_FAIL_NO_OSMUX]++; goto error2; } @@ -1063,7 +1064,7 @@ LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: inavlid local connection options!\n"); error_code = rc; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS)); + rate_ctrs[MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS]++; goto error2; } } @@ -1073,7 +1074,7 @@ mgcp_codec_summary(conn); if (rc) { error_code = rc; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_CODEC_NEGOTIATION)); + rate_ctrs[MGCP_CRCX_FAIL_CODEC_NEGOTIATION]++; goto error2; } @@ -1094,7 +1095,7 @@ LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: selected connection mode type requires an opposite end!\n"); error_code = 527; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_REMOTE_CONN_DESC)); + rate_ctrs[MGCP_CRCX_FAIL_NO_REMOTE_CONN_DESC]++; goto error2; } @@ -1102,14 +1103,14 @@ information, then find a free port for it */ mgcp_get_local_addr(conn->end.local_addr, conn); if (allocate_port(endp, conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); + rate_ctrs[MGCP_CRCX_FAIL_BIND_PORT]++; goto error2; } if (setup_rtp_processing(endp, conn) != 0) { LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: could not start RTP processing!\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_START_RTP)); + rate_ctrs[MGCP_CRCX_FAIL_START_RTP]++; goto error2; } @@ -1125,7 +1126,7 @@ LOGPCONN(_conn, DLMGCP, LOGL_NOTICE, "CRCX: connection successfully created\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_SUCCESS)); + rate_ctrs[MGCP_CRCX_SUCCESS]++; mgcp_endp_update(endp); /* NOTE: Only in the virtual trunk we allow dynamic endpoint names */ @@ -1144,7 +1145,7 @@ struct mgcp_parse_data *pdata = rq->pdatap; struct mgcp_trunk *trunk = rq->trunk; struct mgcp_endpoint *endp = rq->endp; - struct rate_ctr_group *rate_ctrs = trunk->ratectr.mgcp_mdcx_ctr_group; + atomic_uint_least64_t *rate_ctrs = trunk->thread_ctr.mgcp_mdcx_ctr_atomic; char new_local_addr[INET6_ADDRSTRLEN]; int error_code = 500; int silent = 0; @@ -1163,19 +1164,19 @@ if (rq->wildcarded) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: wildcarded endpoint names not supported.\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_WILDCARD)); + rate_ctrs[MGCP_MDCX_FAIL_WILDCARD]++; return create_err_response(rq->trunk, endp, 507, "MDCX", pdata->trans); } if (!endp || !mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_AVAIL)); + rate_ctrs[MGCP_MDCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "MDCX", pdata->trans); } if (llist_count(&endp->conns) <= 0) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: endpoint is not holding a connection.\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONN)); + rate_ctrs[MGCP_MDCX_FAIL_NO_CONN]++; return create_err_response(endp, endp, 400, "MDCX", pdata->trans); } @@ -1186,7 +1187,7 @@ switch (toupper(line[0])) { case 'C': if (mgcp_verify_call_id(endp, line + 3) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CALLID)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_CALLID]++; error_code = 516; goto error3; } @@ -1194,7 +1195,7 @@ case 'I': conn_id = (const char *)line + 3; if ((error_code = mgcp_verify_ci(endp, conn_id))) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CONNID)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_CONNID]++; goto error3; } break; @@ -1225,7 +1226,7 @@ LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "MDCX: Unhandled MGCP option: '%c'/%d\n", line[0], line[0]); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_MDCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "MDCX", pdata->trans); break; } @@ -1235,13 +1236,13 @@ if (!conn_id) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: insufficient parameters, missing ci (connectionIdentifier)\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONNID)); + rate_ctrs[MGCP_MDCX_FAIL_NO_CONNID]++; return create_err_response(endp, endp, 515, "MDCX", pdata->trans); } conn = mgcp_conn_get_rtp(endp, conn_id); if (!conn) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_CONN_NOT_FOUND)); + rate_ctrs[MGCP_MDCX_FAIL_CONN_NOT_FOUND]++; return create_err_response(endp, endp, 400, "MDCX", pdata->trans); } @@ -1249,7 +1250,7 @@ if (mode) { if (mgcp_parse_conn_mode(mode, endp, conn->conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_MODE)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_MODE]++; error_code = 517; goto error3; } @@ -1264,7 +1265,7 @@ LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, "MDCX: invalid local connection options!\n"); error_code = rc; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CONN_OPTIONS)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_CONN_OPTIONS]++; goto error3; } } @@ -1284,7 +1285,7 @@ LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, "MDCX: selected connection mode type requires an opposite end!\n"); error_code = 527; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_REMOTE_CONN_DESC)); + rate_ctrs[MGCP_MDCX_FAIL_NO_REMOTE_CONN_DESC]++; goto error3; } @@ -1317,13 +1318,13 @@ osmo_strlcpy(conn->end.local_addr, new_local_addr, sizeof(conn->end.local_addr)); mgcp_free_rtp_port(&conn->end); if (allocate_port(endp, conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); + rate_ctrs[MGCP_CRCX_FAIL_BIND_PORT]++; goto error3; } } if (setup_rtp_processing(endp, conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_START_RTP)); + rate_ctrs[MGCP_MDCX_FAIL_START_RTP]++; goto error3; } @@ -1340,7 +1341,7 @@ trunk->keepalive_interval != MGCP_KEEPALIVE_NEVER) send_dummy(endp, conn); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_SUCCESS)); + rate_ctrs[MGCP_MDCX_SUCCESS]++; if (silent) goto out_silent; @@ -1362,7 +1363,7 @@ struct mgcp_parse_data *pdata = rq->pdatap; struct mgcp_trunk *trunk = rq->trunk; struct mgcp_endpoint *endp = rq->endp; - struct rate_ctr_group *rate_ctrs = trunk->ratectr.mgcp_dlcx_ctr_group; + atomic_uint_least64_t *rate_ctrs = trunk->thread_ctr.mgcp_dlcx_ctr_atomic; int error_code = 400; int silent = 0; char *line; @@ -1377,7 +1378,7 @@ LOGPEPTR(endp, trunk, DLMGCP, LOGL_NOTICE, "DLCX: deleting connection(s) ...\n"); if (endp && !mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_AVAIL)); + rate_ctrs[MGCP_DLCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "DLCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "DLCX", pdata->trans); @@ -1386,7 +1387,7 @@ if (endp && !rq->wildcarded && llist_empty(&endp->conns)) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "DLCX: endpoint is not holding a connection.\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_NO_CONN)); + rate_ctrs[MGCP_DLCX_FAIL_NO_CONN]++; return create_err_response(endp, endp, 515, "DLCX", pdata->trans); } @@ -1399,7 +1400,7 @@ num_conns += llist_count(&trunk->endpoints[i]->conns); mgcp_endp_release(trunk->endpoints[i]); } - rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); + rate_ctrs[MGCP_DLCX_SUCCESS] += num_conns; return create_ok_response(trunk, NULL, 200, "DLCX", pdata->trans); } @@ -1414,13 +1415,13 @@ if (!endp) { LOGPTRUNK(trunk, DLMGCP, LOGL_NOTICE, "cannot handle requests with call-id (C) without endpoint -- abort!"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_DLCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); } if (mgcp_verify_call_id(endp, line + 3) != 0) { error_code = 516; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CALLID)); + rate_ctrs[MGCP_DLCX_FAIL_INVALID_CALLID]++; goto error3; } break; @@ -1430,13 +1431,13 @@ if (!endp) { LOGPTRUNK(trunk, DLMGCP, LOGL_NOTICE, "cannot handle requests with conn-id (I) without endpoint -- abort!"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_DLCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); } conn_id = (const char *)line + 3; if ((error_code = mgcp_verify_ci(endp, conn_id))) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CONNID)); + rate_ctrs[MGCP_DLCX_FAIL_INVALID_CONNID]++; goto error3; } break; @@ -1446,7 +1447,7 @@ default: LOGPEPTR(endp, trunk, DLMGCP, LOGL_NOTICE, "DLCX: Unhandled MGCP option: '%c'/%d\n", line[0], line[0]); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_DLCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); break; } @@ -1467,7 +1468,7 @@ num_conns); if (num_conns > 0) - rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); + rate_ctrs[MGCP_DLCX_SUCCESS] += num_conns; mgcp_endp_release(endp); @@ -1480,7 +1481,7 @@ /* Find the connection */ conn = mgcp_conn_get_rtp(endp, conn_id); if (!conn) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CONNID)); + rate_ctrs[MGCP_DLCX_FAIL_INVALID_CONNID]++; goto error3; } /* save the statistics of the current connection */ @@ -1500,7 +1501,7 @@ LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "DLCX: endpoint released\n"); } - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS)); + rate_ctrs[MGCP_DLCX_SUCCESS]++; if (silent) goto out_silent; return create_ok_resp_with_param(endp, endp, 250, "DLCX", pdata->trans, stats); diff --git a/src/libosmo-mgcp/mgcp_ratectr.c b/src/libosmo-mgcp/mgcp_ratectr.c index 6030ce2..e2b7f59 100644 --- a/src/libosmo-mgcp/mgcp_ratectr.c +++ b/src/libosmo-mgcp/mgcp_ratectr.c @@ -220,24 +220,24 @@ trunk->trunk_nr); rate_ctr_group_set_name(ratectr->mgcp_dlcx_ctr_group, ctr_name); } - if (ratectr->all_rtp_conn_stats == NULL) { - ratectr->all_rtp_conn_stats = rate_ctr_group_alloc(trunk, &all_rtp_conn_rate_ctr_group_desc, - all_rtp_conn_rate_ctr_index++); - if (!ratectr->all_rtp_conn_stats) + if (ratectr->all_rtp_conn_stats_group == NULL) { + ratectr->all_rtp_conn_stats_group = + rate_ctr_group_alloc(trunk, &all_rtp_conn_rate_ctr_group_desc, all_rtp_conn_rate_ctr_index++); + if (!ratectr->all_rtp_conn_stats_group) return -EINVAL; snprintf(ctr_name, sizeof(ctr_name), "%s-%u:rtp_conn", mgcp_trunk_type_strs_str(trunk->trunk_type), trunk->trunk_nr); - rate_ctr_group_set_name(ratectr->all_rtp_conn_stats, ctr_name); + rate_ctr_group_set_name(ratectr->all_rtp_conn_stats_group, ctr_name); } /* E1 specific */ - if (trunk->trunk_type == MGCP_TRUNK_E1 && ratectr->e1_stats == NULL) { - ratectr->e1_stats = rate_ctr_group_alloc(trunk, &e1_rate_ctr_group_desc, mdcx_rate_ctr_index++); - if (!ratectr->e1_stats) + if (trunk->trunk_type == MGCP_TRUNK_E1 && ratectr->e1_stats_group == NULL) { + ratectr->e1_stats_group = rate_ctr_group_alloc(trunk, &e1_rate_ctr_group_desc, mdcx_rate_ctr_index++); + if (!ratectr->e1_stats_group) return -EINVAL; snprintf(ctr_name, sizeof(ctr_name), "%s-%u:e1", mgcp_trunk_type_strs_str(trunk->trunk_type), trunk->trunk_nr); - rate_ctr_group_set_name(ratectr->e1_stats, ctr_name); + rate_ctr_group_set_name(ratectr->e1_stats_group, ctr_name); } return 0; } @@ -261,15 +261,15 @@ rate_ctr_group_free(ratectr->mgcp_dlcx_ctr_group); ratectr->mgcp_dlcx_ctr_group = NULL; } - if (ratectr->all_rtp_conn_stats) { - rate_ctr_group_free(ratectr->all_rtp_conn_stats); - ratectr->all_rtp_conn_stats = NULL; + if (ratectr->all_rtp_conn_stats_group) { + rate_ctr_group_free(ratectr->all_rtp_conn_stats_group); + ratectr->all_rtp_conn_stats_group = NULL; } /* E1 specific */ - if (ratectr->e1_stats) { - rate_ctr_group_free(ratectr->e1_stats); - ratectr->e1_stats = NULL; + if (ratectr->e1_stats_group) { + rate_ctr_group_free(ratectr->e1_stats_group); + ratectr->e1_stats_group = NULL; } } diff --git a/src/libosmo-mgcp/mgcp_stat.c b/src/libosmo-mgcp/mgcp_stat.c index e679882..512d141 100644 --- a/src/libosmo-mgcp/mgcp_stat.c +++ b/src/libosmo-mgcp/mgcp_stat.c @@ -29,6 +29,7 @@ #include #include #include +#include /* Helper function for mgcp_format_stats_rtp() to calculate packet loss */ #if defined(__has_attribute) @@ -39,7 +40,7 @@ void calc_loss(struct mgcp_conn_rtp *conn, uint32_t *expected, int *loss) { struct mgcp_rtp_state *state = &conn->state; - struct rate_ctr *packets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_RX_CTR); + atomic_uint_least64_t packets_rx = conn->atomic_counters[RTP_PACKETS_RX_CTR]; *expected = state->stats.cycles + state->stats.max_seq; *expected = *expected - state->stats.base_seq + 1; @@ -54,8 +55,8 @@ * Make sure the sign is correct and use the biggest * positive/negative number that fits. */ - *loss = *expected - packets_rx->current; - if (*expected < packets_rx->current) { + *loss = *expected - packets_rx; + if (*expected < packets_rx) { if (*loss > 0) *loss = INT_MIN; } else { @@ -80,19 +81,17 @@ int ploss; int nchars; - struct rate_ctr *packets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_RX_CTR); - struct rate_ctr *octets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_OCTETS_RX_CTR); - struct rate_ctr *packets_tx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_TX_CTR); - struct rate_ctr *octets_tx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_OCTETS_TX_CTR); + atomic_uint_least64_t packets_rx = conn->atomic_counters[RTP_PACKETS_RX_CTR]; + atomic_uint_least64_t octets_rx = conn->atomic_counters[RTP_OCTETS_RX_CTR]; + atomic_uint_least64_t packets_tx = conn->atomic_counters[RTP_PACKETS_TX_CTR]; + atomic_uint_least64_t octets_tx = conn->atomic_counters[RTP_OCTETS_TX_CTR]; calc_loss(conn, &expected, &ploss); jitter = calc_jitter(&conn->state); nchars = snprintf(str, str_len, "\r\nP: PS=%" PRIu64 ", OS=%" PRIu64 ", PR=%" PRIu64 ", OR=%" PRIu64 ", PL=%d, JI=%u", - packets_tx->current, octets_tx->current, - packets_rx->current, octets_rx->current, - ploss, jitter); + packets_tx, octets_tx, packets_rx, octets_rx, ploss, jitter); if (nchars < 0 || nchars >= str_len) goto truncate; @@ -101,10 +100,8 @@ if (conn->conn->endp->trunk->cfg->osmux != OSMUX_USAGE_OFF) { /* Error Counter */ - nchars = snprintf(str, str_len, - "\r\nX-Osmo-CP: EC TI=%" PRIu64 ", TO=%" PRIu64, - conn->state.in_stream.err_ts_ctr->current, - conn->state.out_stream.err_ts_ctr->current); + nchars = snprintf(str, str_len, "\r\nX-Osmo-CP: EC TI=%" PRIu64 ", TO=%" PRIu64, + conn->state.in_stream.err_ts_ctr, conn->state.out_stream.err_ts_ctr); if (nchars < 0 || nchars >= str_len) goto truncate; diff --git a/src/libosmo-mgcp/mgcp_threads.c b/src/libosmo-mgcp/mgcp_threads.c index 2ca0160..354e37a 100644 --- a/src/libosmo-mgcp/mgcp_threads.c +++ b/src/libosmo-mgcp/mgcp_threads.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -413,6 +414,50 @@ //FIXME: shutdown } +#define UPD_RATE_CTR_ATOMIC(ctrname, tid, enumname) \ + for (int i = 0; i < enumname; i++) { \ + atomic_uint_least64_t *c = &trunk->thread_info[tid].this_trunk->thread_ctr.ctrname##_atomic[i]; \ + struct rate_ctr *ctr = &trunk->ratectr.ctrname##_group->ctr[i]; \ + rate_ctr_add(ctr, *c - ctr->current); \ + } + +static struct osmo_timer_list rate_ctr_timer; + +/* updates rate counters by collecting the atomic per-thread counters, also updates ep used stats */ +static void rate_ctr_timer_cb(void *data) +{ + struct mgcp_trunk *trunk; + struct mgcp_config *cfg = data; + + for (int i = 0; i < _MGCP_GENERAL_NUM_ENUMS; i++) { + struct rate_ctr *ctr = &cfg->ratectr.mgcp_general_ctr_group->ctr[i]; + rate_ctr_add(ctr, cfg->ratectr.mgcp_general_ctr_atomic[i] - ctr->current); + } + + atomic_uint_least64_t endpoints_used = 0; + llist_for_each_entry (trunk, &cfg->trunks, entry) { + int thread_num = 0; + /* at least once: 0-thread trunks still need updating! */ + do { + UPD_RATE_CTR_ATOMIC(mgcp_crcx_ctr, thread_num, _MGCP_CRCX_NUM_ENUMS) + UPD_RATE_CTR_ATOMIC(mgcp_mdcx_ctr, thread_num, _MGCP_MDCX_NUM_ENUMS) + UPD_RATE_CTR_ATOMIC(mgcp_dlcx_ctr, thread_num, _MGCP_DLCX_NUM_ENUMS) + UPD_RATE_CTR_ATOMIC(all_rtp_conn_stats, thread_num, _MAX_RTP_CTR_NUM) + if (trunk->trunk_type == MGCP_TRUNK_E1) + UPD_RATE_CTR_ATOMIC(e1_stats, thread_num, _E1_I460_TRAU_NUM_ENUMS) + + endpoints_used += trunk->thread_info[thread_num].this_trunk->number_endpoints - + trunk->thread_info[thread_num].eps_free; + } while (++thread_num < trunk->num_threads); + + /* cheat by using the rate ctr one second callback to also update the ep usage stats */ + osmo_stat_item_set(osmo_stat_item_group_get_item(trunk->stats.common, TRUNK_STAT_ENDPOINTS_USED), + endpoints_used); + } + + osmo_timer_schedule(&rate_ctr_timer, 1, 0); +} + void split_trunks_into_threads(struct mgcp_config *cfg) { struct mgcp_trunk *trunk; @@ -447,4 +492,9 @@ split_per_thead(&trunk->thread_info[i]); } } + + /* wait for the threads to be done with init, so main thread can safely read atomics*/ + usleep(1000 * 100); + osmo_timer_setup(&rate_ctr_timer, rate_ctr_timer_cb, cfg); + osmo_timer_schedule(&rate_ctr_timer, 1, 0); } diff --git a/src/libosmo-mgcp/mgcp_threads_vty.c b/src/libosmo-mgcp/mgcp_threads_vty.c index c598c8a..3ab8bec 100644 --- a/src/libosmo-mgcp/mgcp_threads_vty.c +++ b/src/libosmo-mgcp/mgcp_threads_vty.c @@ -31,15 +31,15 @@ struct mgcp_rtp_state *state = &conn->state; struct mgcp_rtp_end *end = &conn->end; struct mgcp_rtp_codec *codec = end->codec; - struct rate_ctr *tx_packets, *tx_bytes; - struct rate_ctr *rx_packets, *rx_bytes; - struct rate_ctr *dropped_packets; + atomic_uint_least64_t tx_packets, tx_bytes; + atomic_uint_least64_t rx_packets, rx_bytes; + atomic_uint_least64_t dropped_packets; - tx_packets = conn->rate_ctr_group[RTP_PACKETS_TX_CTR].ctr; - tx_bytes = conn->rate_ctr_group[RTP_OCTETS_TX_CTR].ctr; - rx_packets = conn->rate_ctr_group[RTP_PACKETS_RX_CTR].ctr; - rx_bytes = conn->rate_ctr_group[RTP_OCTETS_RX_CTR].ctr; - dropped_packets = conn->rate_ctr_group[RTP_DROPPED_PACKETS_CTR].ctr; + tx_packets = conn->atomic_counters[RTP_PACKETS_TX_CTR]; + tx_bytes = conn->atomic_counters[RTP_OCTETS_TX_CTR]; + rx_packets = conn->atomic_counters[RTP_PACKETS_RX_CTR]; + rx_bytes = conn->atomic_counters[RTP_OCTETS_RX_CTR]; + dropped_packets = conn->atomic_counters[RTP_DROPPED_PACKETS_CTR]; vty_out(vty, " Packets Sent: %" PRIu64 " (%" PRIu64 " bytes total)%s" @@ -51,12 +51,12 @@ " FPP: %d Packet Duration: %u%s" " FMTP-Extra: %s Audio-Name: %s Sub-Type: %s%s" " Output-Enabled: %d Force-PTIME: %d%s", - tx_packets->current, tx_bytes->current, VTY_NEWLINE, rx_packets->current, rx_bytes->current, - VTY_NEWLINE, state->in_stream.err_ts_ctr->current, state->out_stream.err_ts_ctr->current, VTY_NEWLINE, - dropped_packets->current, VTY_NEWLINE, codec->payload_type, codec->rate, codec->channels, VTY_NEWLINE, - codec->frame_duration_num, codec->frame_duration_den, VTY_NEWLINE, end->frames_per_packet, - end->packet_duration_ms, VTY_NEWLINE, end->fmtp_extra, codec->audio_name, codec->subtype_name, - VTY_NEWLINE, end->output_enabled, end->force_output_ptime, VTY_NEWLINE); + tx_packets, tx_bytes, VTY_NEWLINE, rx_packets, rx_bytes, VTY_NEWLINE, state->in_stream.err_ts_ctr, + state->out_stream.err_ts_ctr, VTY_NEWLINE, dropped_packets, VTY_NEWLINE, codec->payload_type, + codec->rate, codec->channels, VTY_NEWLINE, codec->frame_duration_num, codec->frame_duration_den, + VTY_NEWLINE, end->frames_per_packet, end->packet_duration_ms, VTY_NEWLINE, end->fmtp_extra, + codec->audio_name, codec->subtype_name, VTY_NEWLINE, end->output_enabled, end->force_output_ptime, + VTY_NEWLINE); } void dump_endpoint(struct vty *vty, struct mgcp_endpoint *endp, unsigned int trunk_nr, enum mgcp_trunk_type trunk_type, diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c index 156fcf4..c1b4e01 100644 --- a/src/libosmo-mgcp/mgcp_vty.c +++ b/src/libosmo-mgcp/mgcp_vty.c @@ -209,22 +209,15 @@ " %25n: %10c (%S/s %M/m %H/h %D/d) %d", ratectr->mgcp_mdcx_ctr_group); } - if (ratectr->all_rtp_conn_stats) { - vty_out(vty, " %s:%s", - ratectr->all_rtp_conn_stats->desc->group_description, - VTY_NEWLINE); - vty_out_rate_ctr_group_fmt(vty, - " %25n: %10c (%S/s %M/m %H/h %D/d) %d", - ratectr->all_rtp_conn_stats); + if (ratectr->all_rtp_conn_stats_group) { + vty_out(vty, " %s:%s", ratectr->all_rtp_conn_stats_group->desc->group_description, VTY_NEWLINE); + vty_out_rate_ctr_group_fmt(vty, " %25n: %10c (%S/s %M/m %H/h %D/d) %d", + ratectr->all_rtp_conn_stats_group); } - if (ratectr->e1_stats && trunk->trunk_type == MGCP_TRUNK_E1) { - vty_out(vty, " %s:%s", - ratectr->e1_stats->desc->group_description, - VTY_NEWLINE); - vty_out_rate_ctr_group_fmt(vty, - " %25n: %10c (%S/s %M/m %H/h %D/d) %d", - ratectr->e1_stats); + if (ratectr->e1_stats_group && trunk->trunk_type == MGCP_TRUNK_E1) { + vty_out(vty, " %s:%s", ratectr->e1_stats_group->desc->group_description, VTY_NEWLINE); + vty_out_rate_ctr_group_fmt(vty, " %25n: %10c (%S/s %M/m %H/h %D/d) %d", ratectr->e1_stats_group); } } @@ -1587,7 +1580,7 @@ } DEFUN(cfg_mgcp_num_threads_for_virttrunk, cfg_mgcp_num_threads_for_virttrunk_cmd, "number threads <1-65534>", - "Sets the number of threads that will handle the configured endpoints," + "Sets the number of threads that will handle the configured virtual trunk endpoints," " the thread name is automatially set to __ starting with thread 0\n" "Number of threads\n") { diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index 9deee85..18f3c29 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -16,9 +16,8 @@ * You should have received a copy of the GNU Affero General Public License * along with this program. If not, see . */ -#undef _GNU_SOURCE -#define _GNU_SOURCE +#include #include #include #include @@ -39,11 +38,17 @@ #include #include #include -#include + #include #include #include +#undef _GNU_SOURCE +#define _GNU_SOURCE +#undef __USE_GNU +#define __USE_GNU +#include + char *strline_r(char *str, char **saveptr); const char *strline_test_data = @@ -1084,21 +1089,21 @@ struct mgcp_conn_rtp *conn = NULL; struct mgcp_conn *_conn = NULL; struct mgcp_rtp_state *state; - struct rate_ctr *packets_rx; + atomic_uint_least64_t packets_rx; _conn = mgcp_conn_alloc(NULL, &endp, MGCP_CONN_TYPE_RTP, "test-connection"); conn = mgcp_conn_get_rtp(&endp, _conn->id); state = &conn->state; - packets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_RX_CTR); + packets_rx = conn->atomic_counters[RTP_PACKETS_RX_CTR]; state->stats.initialized = 1; state->stats.base_seq = pl_test_dat[i].base_seq; state->stats.max_seq = pl_test_dat[i].max_seq; state->stats.cycles = pl_test_dat[i].cycles; - packets_rx->current = pl_test_dat[i].packets; + packets_rx = pl_test_dat[i].packets; calc_loss(conn, &expected, &loss); if (loss != pl_test_dat[i].loss @@ -1309,8 +1314,8 @@ uint64_t last_out_ts_err_cnt = 0; struct mgcp_conn_rtp *conn = NULL; struct mgcp_conn *_conn = NULL; - struct rate_ctr test_ctr_in; - struct rate_ctr test_ctr_out; + atomic_uint_least64_t test_ctr_in; + atomic_uint_least64_t test_ctr_out; printf("Testing packet error detection%s%s.\n", patch_ssrc ? ", patch SSRC" : "", @@ -1323,8 +1328,8 @@ memset(&test_ctr_in, 0, sizeof(test_ctr_in)); memset(&test_ctr_out, 0, sizeof(test_ctr_out)); - state.in_stream.err_ts_ctr = &test_ctr_in; - state.out_stream.err_ts_ctr = &test_ctr_out; + state.in_stream.err_ts_ctr = test_ctr_in; + state.out_stream.err_ts_ctr = test_ctr_out; endp.type = &ep_typeset.rtp; @@ -1374,17 +1379,16 @@ printf("Out TS change: %d, dTS: %d, Seq change: %d, " "TS Err change: in +%u, out +%u\n", - state.out_stream.last_timestamp - last_timestamp, - state.out_stream.last_tsdelta, + state.out_stream.last_timestamp - last_timestamp, state.out_stream.last_tsdelta, state.out_stream.last_seq - last_seqno, - (unsigned int) (state.in_stream.err_ts_ctr->current - last_in_ts_err_cnt), - (unsigned int) (state.out_stream.err_ts_ctr->current - last_out_ts_err_cnt)); + (unsigned int)(state.in_stream.err_ts_ctr - last_in_ts_err_cnt), + (unsigned int)(state.out_stream.err_ts_ctr - last_out_ts_err_cnt)); printf("Stats: Jitter = %u, Transit = %d\n", calc_jitter(&state), state.stats.transit); - last_in_ts_err_cnt = state.in_stream.err_ts_ctr->current; - last_out_ts_err_cnt = state.out_stream.err_ts_ctr->current; + last_in_ts_err_cnt = state.in_stream.err_ts_ctr; + last_out_ts_err_cnt = state.out_stream.err_ts_ctr; last_timestamp = state.out_stream.last_timestamp; last_seqno = state.out_stream.last_seq; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:03:06 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 18:03:06 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#2). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 248 insertions(+), 216 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:07:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:07:39 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: bootstrap_bts: print errornous ARFCN number In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26184 ) Change subject: osmo_bsc_main: bootstrap_bts: print errornous ARFCN number ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I432448b4bd5ea1a209838a6c5105cc1e9f7d80ee Gerrit-Change-Number: 26184 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:07:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:08:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:08:31 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: separate checks from bootstrap_bts In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26185 ) Change subject: osmo_bsc_main: separate checks from bootstrap_bts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id2b26f147d2f35e156e2da8ee58d2bbbb93de4ac Gerrit-Change-Number: 26185 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:08:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:09:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:09:34 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26186 ) Change subject: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts ...................................................................... Patch Set 1: Code-Review+1 It could probably make sense to move this function at the end of file. What do you think? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Gerrit-Change-Number: 26186 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:09:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:11:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:11:48 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25767/4/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25767/4/src/osmo-bsc/osmo_bsc_main.c at 502 PS4, Line 502: check_bts Does it make sense to check the configuration here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Nov 2021 18:11:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:12:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:12:15 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26187 ) Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:12:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:13:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:13:34 +0000 Subject: Change in osmo-pcu[master]: pdch: Log DL TBF originating the new UL TBF In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26179 ) Change subject: pdch: Log DL TBF originating the new UL TBF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie4257a2468d589464d0d56882e4408e4bcfe340f Gerrit-Change-Number: 26179 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:13:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:15:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:15:04 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: Simplify tfi_find_free logic In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26180 ) Change subject: ts_alloc: Simplify tfi_find_free logic ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26180/1/src/gprs_rlcmac_ts_alloc.cpp File src/gprs_rlcmac_ts_alloc.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26180/1/src/gprs_rlcmac_ts_alloc.cpp at 310 PS1, Line 310: struct gprs_rlcmac_trx *trx; Not const anymore? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 Gerrit-Change-Number: 26180 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:15:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:15:45 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:15:45 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename function to clraify what it does In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26181 ) Change subject: ts_alloc: rename function to clraify what it does ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I55954321d6f2b5e755177a8829512da371e934aa Gerrit-Change-Number: 26181 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:15:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:16:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 18:16:16 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename variable to clarify meaning In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26182 ) Change subject: ts_alloc: rename variable to clarify meaning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib58e87d5a067d20d0b331fe32dff61b95ecc3e3f Gerrit-Change-Number: 26182 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 09 Nov 2021 18:16:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:44:32 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 18:44:32 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 to look at the new patch set (#2). Change subject: rework message handling ...................................................................... rework message handling This was previously broken and a free endpoint was requirted to dlcx *, additionaly globally handling this is difficult due to different response codes, so just do it in the functions, they know best. Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 58 insertions(+), 59 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/89/26189/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:44:32 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 18:44:32 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 to look at the new patch set (#21). Change subject: add a lock-free bounded spsc interthread queue ...................................................................... add a lock-free bounded spsc interthread queue Not entirely wait-free: allows waiting on a fd, and in general fd notifications for poll-loop integration between threads. Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 --- A include/osmocom/mgcp/mgcp_threads_queue.h A src/libosmo-mgcp/mgcp_threads_queue.c 2 files changed, 260 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/31/25431/21 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 21 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:44:32 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 18:44:32 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#29). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then ansers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 14 files changed, 1,028 insertions(+), 349 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/29 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 29 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 18:51:11 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 18:51:11 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#30). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then ansers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h A include/osmocom/mgcp/mgcp_threads.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 15 files changed, 1,155 insertions(+), 349 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/30 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 30 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 19:44:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Nov 2021 19:44:26 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 30: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/30/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/30/src/libosmo-mgcp/mgcp_vty.c at 1589 PS30, Line 1589: DEFUN(cfg_mgcp_num_threads_for_virttrunk, cfg_mgcp_num_threads_for_virttrunk_cmd, "number threads <1-65534>", For the sake of consistency, please reformat this as it's done above: DEFUN(cfg_mgcp_num_threads_for_virttrunk, cfg_mgcp_num_threads_for_virttrunk_cmd, "number threads <1-65534>", ... Also, you have three vectors here: "number", "threads", and "<1-65534>", so it's required to provide documentation for all of them. But I would rather go for a better naming like "num-threads" or so. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 30 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 09 Nov 2021 19:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 19:46:25 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 19:46:25 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#31). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then ansers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h A include/osmocom/mgcp/mgcp_threads.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 15 files changed, 1,155 insertions(+), 349 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/31 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 31 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 19:46:25 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 19:46:25 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#5). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 244 insertions(+), 215 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 19:46:26 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 19:46:26 +0000 Subject: Change in osmo-mgw[master]: clang-format: remove foreach macros References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26191 ) Change subject: clang-format: remove foreach macros ...................................................................... clang-format: remove foreach macros We don't really care about the kernel style after all and the linter complains about proper formatting, so remove all for-like macros so we don't accidentally apply kernel style formatting. Change-Id: Ia1b5848b31470b694a2031ad83e84f3132212f94 --- M .clang-format 1 file changed, 0 insertions(+), 445 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/91/26191/1 diff --git a/.clang-format b/.clang-format index 5d4791c..2abc64d 100644 --- a/.clang-format +++ b/.clang-format @@ -64,451 +64,6 @@ ExperimentalAutoDetectBinPacking: false #FixNamespaceComments: false # Unknown to clang-format-4.0 -# Taken from: -# git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' include/ \ -# | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$, - '\1'," \ -# | sort | uniq -ForEachMacros: - - 'apei_estatus_for_each_section' - - 'ata_for_each_dev' - - 'ata_for_each_link' - - '__ata_qc_for_each' - - 'ata_qc_for_each' - - 'ata_qc_for_each_raw' - - 'ata_qc_for_each_with_internal' - - 'ax25_for_each' - - 'ax25_uid_for_each' - - '__bio_for_each_bvec' - - 'bio_for_each_bvec' - - 'bio_for_each_bvec_all' - - 'bio_for_each_integrity_vec' - - '__bio_for_each_segment' - - 'bio_for_each_segment' - - 'bio_for_each_segment_all' - - 'bio_list_for_each' - - 'bip_for_each_vec' - - 'bitmap_for_each_clear_region' - - 'bitmap_for_each_set_region' - - 'blkg_for_each_descendant_post' - - 'blkg_for_each_descendant_pre' - - 'blk_queue_for_each_rl' - - 'bond_for_each_slave' - - 'bond_for_each_slave_rcu' - - 'bpf_for_each_spilled_reg' - - 'btree_for_each_safe128' - - 'btree_for_each_safe32' - - 'btree_for_each_safe64' - - 'btree_for_each_safel' - - 'card_for_each_dev' - - 'cgroup_taskset_for_each' - - 'cgroup_taskset_for_each_leader' - - 'cpufreq_for_each_entry' - - 'cpufreq_for_each_entry_idx' - - 'cpufreq_for_each_valid_entry' - - 'cpufreq_for_each_valid_entry_idx' - - 'css_for_each_child' - - 'css_for_each_descendant_post' - - 'css_for_each_descendant_pre' - - 'device_for_each_child_node' - - 'displayid_iter_for_each' - - 'dma_fence_chain_for_each' - - 'do_for_each_ftrace_op' - - 'drm_atomic_crtc_for_each_plane' - - 'drm_atomic_crtc_state_for_each_plane' - - 'drm_atomic_crtc_state_for_each_plane_state' - - 'drm_atomic_for_each_plane_damage' - - 'drm_client_for_each_connector_iter' - - 'drm_client_for_each_modeset' - - 'drm_connector_for_each_possible_encoder' - - 'drm_for_each_bridge_in_chain' - - 'drm_for_each_connector_iter' - - 'drm_for_each_crtc' - - 'drm_for_each_crtc_reverse' - - 'drm_for_each_encoder' - - 'drm_for_each_encoder_mask' - - 'drm_for_each_fb' - - 'drm_for_each_legacy_plane' - - 'drm_for_each_plane' - - 'drm_for_each_plane_mask' - - 'drm_for_each_privobj' - - 'drm_mm_for_each_hole' - - 'drm_mm_for_each_node' - - 'drm_mm_for_each_node_in_range' - - 'drm_mm_for_each_node_safe' - - 'flow_action_for_each' - - 'for_each_acpi_dev_match' - - 'for_each_active_dev_scope' - - 'for_each_active_drhd_unit' - - 'for_each_active_iommu' - - 'for_each_aggr_pgid' - - 'for_each_available_child_of_node' - - 'for_each_bio' - - 'for_each_board_func_rsrc' - - 'for_each_bvec' - - 'for_each_card_auxs' - - 'for_each_card_auxs_safe' - - 'for_each_card_components' - - 'for_each_card_dapms' - - 'for_each_card_pre_auxs' - - 'for_each_card_prelinks' - - 'for_each_card_rtds' - - 'for_each_card_rtds_safe' - - 'for_each_card_widgets' - - 'for_each_card_widgets_safe' - - 'for_each_cgroup_storage_type' - - 'for_each_child_of_node' - - 'for_each_clear_bit' - - 'for_each_clear_bit_from' - - 'for_each_cmsghdr' - - 'for_each_compatible_node' - - 'for_each_component_dais' - - 'for_each_component_dais_safe' - - 'for_each_comp_order' - - 'for_each_console' - - 'for_each_cpu' - - 'for_each_cpu_and' - - 'for_each_cpu_not' - - 'for_each_cpu_wrap' - - 'for_each_dapm_widgets' - - 'for_each_dev_addr' - - 'for_each_dev_scope' - - 'for_each_dma_cap_mask' - - 'for_each_dpcm_be' - - 'for_each_dpcm_be_rollback' - - 'for_each_dpcm_be_safe' - - 'for_each_dpcm_fe' - - 'for_each_drhd_unit' - - 'for_each_dss_dev' - - 'for_each_dtpm_table' - - 'for_each_efi_memory_desc' - - 'for_each_efi_memory_desc_in_map' - - 'for_each_element' - - 'for_each_element_extid' - - 'for_each_element_id' - - 'for_each_endpoint_of_node' - - 'for_each_evictable_lru' - - 'for_each_fib6_node_rt_rcu' - - 'for_each_fib6_walker_rt' - - 'for_each_free_mem_pfn_range_in_zone' - - 'for_each_free_mem_pfn_range_in_zone_from' - - 'for_each_free_mem_range' - - 'for_each_free_mem_range_reverse' - - 'for_each_func_rsrc' - - 'for_each_hstate' - - 'for_each_if' - - 'for_each_iommu' - - 'for_each_ip_tunnel_rcu' - - 'for_each_irq_nr' - - 'for_each_link_codecs' - - 'for_each_link_cpus' - - 'for_each_link_platforms' - - 'for_each_lru' - - 'for_each_matching_node' - - 'for_each_matching_node_and_match' - - 'for_each_member' - - 'for_each_memcg_cache_index' - - 'for_each_mem_pfn_range' - - '__for_each_mem_range' - - 'for_each_mem_range' - - '__for_each_mem_range_rev' - - 'for_each_mem_range_rev' - - 'for_each_mem_region' - - 'for_each_migratetype_order' - - 'for_each_msi_entry' - - 'for_each_msi_entry_safe' - - 'for_each_msi_vector' - - 'for_each_net' - - 'for_each_net_continue_reverse' - - 'for_each_netdev' - - 'for_each_netdev_continue' - - 'for_each_netdev_continue_rcu' - - 'for_each_netdev_continue_reverse' - - 'for_each_netdev_feature' - - 'for_each_netdev_in_bond_rcu' - - 'for_each_netdev_rcu' - - 'for_each_netdev_reverse' - - 'for_each_netdev_safe' - - 'for_each_net_rcu' - - 'for_each_new_connector_in_state' - - 'for_each_new_crtc_in_state' - - 'for_each_new_mst_mgr_in_state' - - 'for_each_new_plane_in_state' - - 'for_each_new_private_obj_in_state' - - 'for_each_node' - - 'for_each_node_by_name' - - 'for_each_node_by_type' - - 'for_each_node_mask' - - 'for_each_node_state' - - 'for_each_node_with_cpus' - - 'for_each_node_with_property' - - 'for_each_nonreserved_multicast_dest_pgid' - - 'for_each_of_allnodes' - - 'for_each_of_allnodes_from' - - 'for_each_of_cpu_node' - - 'for_each_of_pci_range' - - 'for_each_old_connector_in_state' - - 'for_each_old_crtc_in_state' - - 'for_each_old_mst_mgr_in_state' - - 'for_each_oldnew_connector_in_state' - - 'for_each_oldnew_crtc_in_state' - - 'for_each_oldnew_mst_mgr_in_state' - - 'for_each_oldnew_plane_in_state' - - 'for_each_oldnew_plane_in_state_reverse' - - 'for_each_oldnew_private_obj_in_state' - - 'for_each_old_plane_in_state' - - 'for_each_old_private_obj_in_state' - - 'for_each_online_cpu' - - 'for_each_online_node' - - 'for_each_online_pgdat' - - 'for_each_pci_bridge' - - 'for_each_pci_dev' - - 'for_each_pci_msi_entry' - - 'for_each_pcm_streams' - - 'for_each_physmem_range' - - 'for_each_populated_zone' - - 'for_each_possible_cpu' - - 'for_each_present_cpu' - - 'for_each_prime_number' - - 'for_each_prime_number_from' - - 'for_each_process' - - 'for_each_process_thread' - - 'for_each_prop_codec_conf' - - 'for_each_prop_dai_codec' - - 'for_each_prop_dai_cpu' - - 'for_each_prop_dlc_codecs' - - 'for_each_prop_dlc_cpus' - - 'for_each_prop_dlc_platforms' - - 'for_each_property_of_node' - - 'for_each_registered_fb' - - 'for_each_requested_gpio' - - 'for_each_requested_gpio_in_range' - - 'for_each_reserved_mem_range' - - 'for_each_reserved_mem_region' - - 'for_each_rtd_codec_dais' - - 'for_each_rtd_components' - - 'for_each_rtd_cpu_dais' - - 'for_each_rtd_dais' - - 'for_each_set_bit' - - 'for_each_set_bit_from' - - 'for_each_set_clump8' - - 'for_each_sg' - - 'for_each_sg_dma_page' - - 'for_each_sg_page' - - 'for_each_sgtable_dma_page' - - 'for_each_sgtable_dma_sg' - - 'for_each_sgtable_page' - - 'for_each_sgtable_sg' - - 'for_each_sibling_event' - - 'for_each_subelement' - - 'for_each_subelement_extid' - - 'for_each_subelement_id' - - '__for_each_thread' - - 'for_each_thread' - - 'for_each_unicast_dest_pgid' - - 'for_each_vsi' - - 'for_each_wakeup_source' - - 'for_each_zone' - - 'for_each_zone_zonelist' - - 'for_each_zone_zonelist_nodemask' - - 'fwnode_for_each_available_child_node' - - 'fwnode_for_each_child_node' - - 'fwnode_graph_for_each_endpoint' - - 'gadget_for_each_ep' - - 'genradix_for_each' - - 'genradix_for_each_from' - - 'hash_for_each' - - 'hash_for_each_possible' - - 'hash_for_each_possible_rcu' - - 'hash_for_each_possible_rcu_notrace' - - 'hash_for_each_possible_safe' - - 'hash_for_each_rcu' - - 'hash_for_each_safe' - - 'hctx_for_each_ctx' - - 'hlist_bl_for_each_entry' - - 'hlist_bl_for_each_entry_rcu' - - 'hlist_bl_for_each_entry_safe' - - 'hlist_for_each' - - 'hlist_for_each_entry' - - 'hlist_for_each_entry_continue' - - 'hlist_for_each_entry_continue_rcu' - - 'hlist_for_each_entry_continue_rcu_bh' - - 'hlist_for_each_entry_from' - - 'hlist_for_each_entry_from_rcu' - - 'hlist_for_each_entry_rcu' - - 'hlist_for_each_entry_rcu_bh' - - 'hlist_for_each_entry_rcu_notrace' - - 'hlist_for_each_entry_safe' - - 'hlist_for_each_entry_srcu' - - '__hlist_for_each_rcu' - - 'hlist_for_each_safe' - - 'hlist_nulls_for_each_entry' - - 'hlist_nulls_for_each_entry_from' - - 'hlist_nulls_for_each_entry_rcu' - - 'hlist_nulls_for_each_entry_safe' - - 'i3c_bus_for_each_i2cdev' - - 'i3c_bus_for_each_i3cdev' - - 'ide_host_for_each_port' - - 'ide_port_for_each_dev' - - 'ide_port_for_each_present_dev' - - 'idr_for_each_entry' - - 'idr_for_each_entry_continue' - - 'idr_for_each_entry_continue_ul' - - 'idr_for_each_entry_ul' - - 'in_dev_for_each_ifa_rcu' - - 'in_dev_for_each_ifa_rtnl' - - 'inet_bind_bucket_for_each' - - 'inet_lhash2_for_each_icsk_rcu' - - 'key_for_each' - - 'key_for_each_safe' - - 'klp_for_each_func' - - 'klp_for_each_func_safe' - - 'klp_for_each_func_static' - - 'klp_for_each_object' - - 'klp_for_each_object_safe' - - 'klp_for_each_object_static' - - 'kunit_suite_for_each_test_case' - - 'kvm_for_each_memslot' - - 'kvm_for_each_vcpu' - - 'list_for_each' - - 'list_for_each_codec' - - 'list_for_each_codec_safe' - - 'list_for_each_continue' - - 'list_for_each_entry' - - 'list_for_each_entry_continue' - - 'list_for_each_entry_continue_rcu' - - 'list_for_each_entry_continue_reverse' - - 'list_for_each_entry_from' - - 'list_for_each_entry_from_rcu' - - 'list_for_each_entry_from_reverse' - - 'list_for_each_entry_lockless' - - 'list_for_each_entry_rcu' - - 'list_for_each_entry_reverse' - - 'list_for_each_entry_safe' - - 'list_for_each_entry_safe_continue' - - 'list_for_each_entry_safe_from' - - 'list_for_each_entry_safe_reverse' - - 'list_for_each_entry_srcu' - - 'list_for_each_prev' - - 'list_for_each_prev_safe' - - 'list_for_each_safe' - - 'llist_for_each' - - 'llist_for_each_entry' - - 'llist_for_each_entry_safe' - - 'llist_for_each_safe' - - 'mci_for_each_dimm' - - 'media_device_for_each_entity' - - 'media_device_for_each_intf' - - 'media_device_for_each_link' - - 'media_device_for_each_pad' - - 'nanddev_io_for_each_page' - - 'netdev_for_each_lower_dev' - - 'netdev_for_each_lower_private' - - 'netdev_for_each_lower_private_rcu' - - 'netdev_for_each_mc_addr' - - 'netdev_for_each_uc_addr' - - 'netdev_for_each_upper_dev_rcu' - - 'netdev_hw_addr_list_for_each' - - 'nft_rule_for_each_expr' - - 'nla_for_each_attr' - - 'nla_for_each_nested' - - 'nlmsg_for_each_attr' - - 'nlmsg_for_each_msg' - - 'nr_neigh_for_each' - - 'nr_neigh_for_each_safe' - - 'nr_node_for_each' - - 'nr_node_for_each_safe' - - 'of_for_each_phandle' - - 'of_property_for_each_string' - - 'of_property_for_each_u32' - - 'pci_bus_for_each_resource' - - 'pcl_for_each_chunk' - - 'pcl_for_each_segment' - - 'pcm_for_each_format' - - 'ping_portaddr_for_each_entry' - - 'plist_for_each' - - 'plist_for_each_continue' - - 'plist_for_each_entry' - - 'plist_for_each_entry_continue' - - 'plist_for_each_entry_safe' - - 'plist_for_each_safe' - - 'pnp_for_each_card' - - 'pnp_for_each_dev' - - 'protocol_for_each_card' - - 'protocol_for_each_dev' - - 'queue_for_each_hw_ctx' - - 'radix_tree_for_each_slot' - - 'radix_tree_for_each_tagged' - - 'rb_for_each' - - 'rbtree_postorder_for_each_entry_safe' - - 'rdma_for_each_block' - - 'rdma_for_each_port' - - 'rdma_umem_for_each_dma_block' - - 'resource_list_for_each_entry' - - 'resource_list_for_each_entry_safe' - - 'rhl_for_each_entry_rcu' - - 'rhl_for_each_rcu' - - 'rht_for_each' - - 'rht_for_each_entry' - - 'rht_for_each_entry_from' - - 'rht_for_each_entry_rcu' - - 'rht_for_each_entry_rcu_from' - - 'rht_for_each_entry_safe' - - 'rht_for_each_from' - - 'rht_for_each_rcu' - - 'rht_for_each_rcu_from' - - '__rq_for_each_bio' - - 'rq_for_each_bvec' - - 'rq_for_each_segment' - - 'scsi_for_each_prot_sg' - - 'scsi_for_each_sg' - - 'sctp_for_each_hentry' - - 'sctp_skb_for_each' - - 'shdma_for_each_chan' - - '__shost_for_each_device' - - 'shost_for_each_device' - - 'sk_for_each' - - 'sk_for_each_bound' - - 'sk_for_each_entry_offset_rcu' - - 'sk_for_each_from' - - 'sk_for_each_rcu' - - 'sk_for_each_safe' - - 'sk_nulls_for_each' - - 'sk_nulls_for_each_from' - - 'sk_nulls_for_each_rcu' - - 'snd_array_for_each' - - 'snd_pcm_group_for_each_entry' - - 'snd_soc_dapm_widget_for_each_path' - - 'snd_soc_dapm_widget_for_each_path_safe' - - 'snd_soc_dapm_widget_for_each_sink_path' - - 'snd_soc_dapm_widget_for_each_source_path' - - 'tb_property_for_each' - - 'tcf_exts_for_each_action' - - 'udp_portaddr_for_each_entry' - - 'udp_portaddr_for_each_entry_rcu' - - 'usb_hub_for_each_child' - - 'v4l2_device_for_each_subdev' - - 'v4l2_m2m_for_each_dst_buf' - - 'v4l2_m2m_for_each_dst_buf_safe' - - 'v4l2_m2m_for_each_src_buf' - - 'v4l2_m2m_for_each_src_buf_safe' - - 'virtio_device_for_each_vq' - - 'while_for_each_ftrace_op' - - 'xa_for_each' - - 'xa_for_each_marked' - - 'xa_for_each_range' - - 'xa_for_each_start' - - 'xas_for_each' - - 'xas_for_each_conflict' - - 'xas_for_each_marked' - - 'xbc_array_for_each_value' - - 'xbc_for_each_key_value' - - 'xbc_node_for_each_array_value' - - 'xbc_node_for_each_child' - - 'xbc_node_for_each_key_value' - - 'zorro_for_each_dev' - - 'for_each_line' - - 'for_each_non_empty_line' - #IncludeBlocks: Preserve # Unknown to clang-format-5.0 IncludeCategories: - Regex: '.*' -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1b5848b31470b694a2031ad83e84f3132212f94 Gerrit-Change-Number: 26191 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 21:20:22 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 21:20:22 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26192 ) Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... fix mgcp_conn_free_all ubsan complaints ubsan still complains about a unaligned load that can't be explained, so silence it: /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime error: member access within misaligned address 0x612000000249 for type 'const struct llist_head', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime error: load of misaligned address 0x612000000249 for type 'struct llist_head *const', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in mgcp_conn.c:303:17: runtime error: member access within misaligned address 0x612000000249 for type 'struct llist_head', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:303:17 in mgcp_conn.c:303:17: runtime error: load of misaligned address 0x612000000249 for type 'struct llist_head *', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:303:17 in mgcp_conn.c:304:30: runtime error: member access within misaligned address 0x4800006120000002 for type 'struct mgcp_conn', which requires 8 byte alignment 0x4800006120000002: note: pointer points here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:304:30 in AddressSanitizer:DEADLYSIGNAL ================================================================= ==223426==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x0000004553f7 bp 0x7ffda5855080 sp 0x7ffda5855040 T0) ==223426==The signal is caused by a READ memory access. ==223426==Hint: this fault was caused by a dereference of a high value address (see register values below). Disassemble the provided pc to learn which register was used. /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:258:9 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:304:3 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_endp.c:124:2 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:670:3 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:923:2 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:2248:2 /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16 (/mgw-threads/osmo-mgw/tests/mgcp/mgcp_test+0x404c2d) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14 in mgcp_conn_get ==223426==ABORTING Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb --- M src/libosmo-mgcp/mgcp_conn.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/92/26192/1 diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 4f6e1a2..1d169f4 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -325,6 +325,11 @@ /*! free all connections at once. * \param[in] endp associated endpoint */ + #if defined(__has_attribute) +#if __has_attribute(no_sanitize) +__attribute__((no_sanitize("undefined"))) +#endif +#endif void mgcp_conn_free_all(struct mgcp_endpoint *endp) { struct mgcp_conn *conn; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 21:20:22 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 9 Nov 2021 21:20:22 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26193 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 XXY Change-Id: I5e3598f80cb062dbab376663ee51136b4508b78d --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 245 insertions(+), 215 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/93/26193/1 diff --git a/include/osmocom/mgcp/mgcp_conn.h b/include/osmocom/mgcp/mgcp_conn.h index 4f882e9..8ab61d1 100644 --- a/include/osmocom/mgcp/mgcp_conn.h +++ b/include/osmocom/mgcp/mgcp_conn.h @@ -29,6 +29,7 @@ #include #include #include +#include #define LOGPCONN(conn, cat, level, fmt, args...) \ LOGPENDP((conn)->endp, cat, level, "CI:%s " fmt, \ @@ -93,7 +94,7 @@ } stats; } osmux; - struct rate_ctr_group *rate_ctr_group; + atomic_uint_least64_t atomic_counters[_MAX_RTP_CTR_NUM]; }; /*! MGCP connection (untyped) */ @@ -131,17 +132,6 @@ void *priv; }; -/* RTP connection related counters */ -enum { - IN_STREAM_ERR_TSTMP_CTR, - OUT_STREAM_ERR_TSTMP_CTR, - RTP_PACKETS_RX_CTR, - RTP_OCTETS_RX_CTR, - RTP_PACKETS_TX_CTR, - RTP_OCTETS_TX_CTR, - RTP_DROPPED_PACKETS_CTR, - RTP_NUM_CONNECTIONS, -}; /* RTP per-connection statistics. Instances of the corresponding rate counter group * exist for the lifetime of an RTP connection. diff --git a/include/osmocom/mgcp/mgcp_network.h b/include/osmocom/mgcp/mgcp_network.h index b9cf5e3..75e6ae6 100644 --- a/include/osmocom/mgcp/mgcp_network.h +++ b/include/osmocom/mgcp/mgcp_network.h @@ -1,6 +1,7 @@ #pragma once #include +#include #include #include @@ -23,7 +24,7 @@ uint32_t ssrc; uint16_t last_seq; uint32_t last_timestamp; - struct rate_ctr *err_ts_ctr; + atomic_uint_least64_t err_ts_ctr; int32_t last_tsdelta; uint32_t last_arrival_time; }; diff --git a/include/osmocom/mgcp/mgcp_ratectr.h b/include/osmocom/mgcp/mgcp_ratectr.h index c03c4e1..8c0cb8e 100644 --- a/include/osmocom/mgcp/mgcp_ratectr.h +++ b/include/osmocom/mgcp/mgcp_ratectr.h @@ -1,4 +1,18 @@ #pragma once +#include + +/* RTP connection related counters */ +enum { + IN_STREAM_ERR_TSTMP_CTR, + OUT_STREAM_ERR_TSTMP_CTR, + RTP_PACKETS_RX_CTR, + RTP_OCTETS_RX_CTR, + RTP_PACKETS_TX_CTR, + RTP_OCTETS_TX_CTR, + RTP_DROPPED_PACKETS_CTR, + RTP_NUM_CONNECTIONS, + _MAX_RTP_CTR_NUM +}; /* Global MCGP general rate counters */ enum { @@ -8,6 +22,7 @@ MGCP_GENERAL_RX_MSGS_UNHANDLED, MGCP_GENERAL_RX_FAIL_MSG_PARSE, MGCP_GENERAL_RX_FAIL_NO_ENDPOINT, + _MGCP_GENERAL_NUM_ENUMS, }; /* Trunk-global MCGP CRCX related rate counters */ @@ -28,6 +43,7 @@ MGCP_CRCX_FAIL_BIND_PORT, MGCP_CRCX_FAIL_AVAIL, MGCP_CRCX_FAIL_CLAIM, + _MGCP_CRCX_NUM_ENUMS, }; /* Trunk-global MCGP MDCX related rate counters */ @@ -45,6 +61,7 @@ MGCP_MDCX_FAIL_NO_REMOTE_CONN_DESC, MGCP_MDCX_FAIL_START_RTP, MGCP_MDCX_FAIL_AVAIL, + _MGCP_MDCX_NUM_ENUMS, }; /* Trunk-global MCGP DLCX related rate counters */ @@ -55,13 +72,15 @@ MGCP_DLCX_FAIL_INVALID_CONNID, MGCP_DLCX_FAIL_UNHANDLED_PARAM, MGCP_DLCX_FAIL_AVAIL, + _MGCP_DLCX_NUM_ENUMS, }; /* Trunk-global E1 related counters */ enum { - E1_I460_TRAU_RX_FAIL_CTR, - E1_I460_TRAU_TX_FAIL_CTR, - E1_I460_TRAU_MUX_EMPTY_CTR, + E1_I460_TRAU_RX_FAIL_CTR, + E1_I460_TRAU_TX_FAIL_CTR, + E1_I460_TRAU_MUX_EMPTY_CTR, + _E1_I460_TRAU_NUM_ENUMS, }; /* NOTE: When adding counters, also the dump_ratectr_* routines in vty.c must be updated. */ @@ -69,6 +88,7 @@ struct mgcp_ratectr_global { /* Rate counter group which contains stats for generic MGCP events. */ struct rate_ctr_group *mgcp_general_ctr_group; + atomic_uint_least64_t mgcp_general_ctr_atomic[_MGCP_GENERAL_NUM_ENUMS]; }; struct mgcp_ratectr_trunk { @@ -79,9 +99,18 @@ /* Rate counter group which contains stats for processed DLCX commands. */ struct rate_ctr_group *mgcp_dlcx_ctr_group; /* Rate counter group which aggregates stats of individual RTP connections. */ - struct rate_ctr_group *all_rtp_conn_stats; + struct rate_ctr_group *all_rtp_conn_stats_group; /* Rate counter group which contains stats for E1 events (only valid for E1 trunks) */ - struct rate_ctr_group *e1_stats; + struct rate_ctr_group *e1_stats_group; +}; + +/* as above, but just counters updated by the trunkthreads, then aggregated by the main thread */ +struct mgcp_per_thread_ctr_trunk { + atomic_uint_least64_t mgcp_crcx_ctr_atomic[_MGCP_CRCX_NUM_ENUMS]; + atomic_uint_least64_t mgcp_mdcx_ctr_atomic[_MGCP_MDCX_NUM_ENUMS]; + atomic_uint_least64_t mgcp_dlcx_ctr_atomic[_MGCP_DLCX_NUM_ENUMS]; + atomic_uint_least64_t all_rtp_conn_stats_atomic[_MAX_RTP_CTR_NUM]; + atomic_uint_least64_t e1_stats_atomic[_E1_I460_TRAU_NUM_ENUMS]; }; struct mgcp_config; diff --git a/include/osmocom/mgcp/mgcp_trunk.h b/include/osmocom/mgcp/mgcp_trunk.h index 36032b9..9058b51 100644 --- a/include/osmocom/mgcp/mgcp_trunk.h +++ b/include/osmocom/mgcp/mgcp_trunk.h @@ -27,8 +27,14 @@ struct per_thread_info *thread_info; int num_threads; /* number of threads for this parent trunk, related to thread_info */ bool use_threads; /* enables thread usage, set at cfg parsing time, ALWAYS false for e1/osmux */ - unsigned int number_endpoints_offset; /* offset for proper ep counting, since only the first thread starts at ep0 */ + unsigned int number_endpoints_offset; /* offset for proper ep counting, only first thread starts at ep0 */ struct mgcp_config *cfg; /* global cfg, points at private cfg copy in thread_info for child trunks */ + struct mgcp_per_thread_ctr_trunk thread_ctr; /* counters used by the threads, used by main thread */ + + /* rate counters and stat items to measure the trunks overall performance and health + updated by the main thread by aggregating the per-thread raw counters */ + struct mgcp_ratectr_trunk ratectr; /* NULL for the threads! */ + struct mgcp_stat_trunk stats; /* NULL for the threads! */ /* !!! no thread specific handling below this comment !!! */ @@ -62,10 +68,6 @@ unsigned int number_endpoints; struct mgcp_endpoint **endpoints; - /* rate counters and stat items to measure the trunks overall performance and health */ - struct mgcp_ratectr_trunk ratectr; - struct mgcp_stat_trunk stats; - union { /* Virtual trunk specific */ struct { diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 1d169f4..19b56bf 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -35,15 +35,6 @@ #include #include -const static struct rate_ctr_group_desc rate_ctr_group_desc = { - .group_name_prefix = "conn_rtp", - .group_description = "rtp connection statistics", - .class_id = 1, - .num_ctr = ARRAY_SIZE(mgcp_conn_rate_ctr_desc), - .ctr_desc = mgcp_conn_rate_ctr_desc -}; - - /* Allocate a new connection identifier. According to RFC3435, they must * be unique only within the scope of the endpoint. (Caller must provide * memory for id) */ @@ -87,10 +78,6 @@ static int mgcp_rtp_conn_init(struct mgcp_conn_rtp *conn_rtp, struct mgcp_conn *conn) { struct mgcp_rtp_end *end = &conn_rtp->end; - /* FIXME: Each new rate counter group requires an unique index. At the - * moment we generate this index using this counter, but perhaps there - * is a more concious way to assign the indexes. */ - static atomic_uint rate_ctr_index = 0; conn_rtp->type = MGCP_RTP_DEFAULT; conn_rtp->osmux.cid_allocated = false; @@ -111,12 +98,8 @@ end->output_enabled = 0; end->maximum_packet_time = -1; - conn_rtp->rate_ctr_group = rate_ctr_group_alloc(conn, &rate_ctr_group_desc, rate_ctr_index++); - if (!conn_rtp->rate_ctr_group) - return -1; - - conn_rtp->state.in_stream.err_ts_ctr = rate_ctr_group_get_ctr(conn_rtp->rate_ctr_group, IN_STREAM_ERR_TSTMP_CTR); - conn_rtp->state.out_stream.err_ts_ctr = rate_ctr_group_get_ctr(conn_rtp->rate_ctr_group, OUT_STREAM_ERR_TSTMP_CTR); + memset(&conn_rtp->state, 0, sizeof(conn_rtp->state)); + memset(&conn_rtp->atomic_counters, 0, sizeof(conn_rtp->atomic_counters)); /* Make sure codec table is reset */ mgcp_codec_reset_all(conn_rtp); @@ -130,7 +113,6 @@ if (mgcp_conn_rtp_is_osmux(conn_rtp)) conn_osmux_disable(conn_rtp); mgcp_free_rtp_port(&conn_rtp->end); - rate_ctr_group_free(conn_rtp->rate_ctr_group); mgcp_codec_reset_all(conn_rtp); } @@ -258,24 +240,12 @@ static void aggregate_rtp_conn_stats(struct mgcp_endpoint *endp, struct mgcp_conn_rtp *conn_rtp) { - struct rate_ctr_group *all_stats = endp->trunk->ratectr.all_rtp_conn_stats; - struct rate_ctr_group *conn_stats = conn_rtp->rate_ctr_group; + atomic_uint_least64_t *per_trunk_stats = endp->trunk->thread_ctr.all_rtp_conn_stats_atomic; + atomic_uint_least64_t *per_conn_stats = conn_rtp->atomic_counters; - if (all_stats == NULL || conn_stats == NULL) - return; - - /* Compared to per-connection RTP statistics, aggregated RTP statistics - * contain one additional rate couter item (RTP_NUM_CONNECTIONS). - * All other counters in both counter groups correspond to each other. */ - OSMO_ASSERT(conn_stats->desc->num_ctr + 1 == all_stats->desc->num_ctr); - - /* all other counters are [now] updated in real-time */ - rate_ctr_add(rate_ctr_group_get_ctr(all_stats, IN_STREAM_ERR_TSTMP_CTR), - rate_ctr_group_get_ctr(conn_stats, IN_STREAM_ERR_TSTMP_CTR)->current); - rate_ctr_add(rate_ctr_group_get_ctr(all_stats, OUT_STREAM_ERR_TSTMP_CTR), - rate_ctr_group_get_ctr(conn_stats, OUT_STREAM_ERR_TSTMP_CTR)->current); - - rate_ctr_inc(rate_ctr_group_get_ctr(all_stats, RTP_NUM_CONNECTIONS)); + per_trunk_stats[IN_STREAM_ERR_TSTMP_CTR] += per_conn_stats[IN_STREAM_ERR_TSTMP_CTR]; + per_trunk_stats[OUT_STREAM_ERR_TSTMP_CTR] += per_conn_stats[OUT_STREAM_ERR_TSTMP_CTR]; + per_trunk_stats[RTP_NUM_CONNECTIONS]++; } /*! free a connection by its ID. diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 807904f..2de0baf 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -41,6 +41,7 @@ #include #include #include +#include #define DEBUG_BITS_MAX 80 #define DEBUG_BYTES_MAX 40 @@ -192,13 +193,13 @@ static void e1_i460_mux_empty_cb(struct osmo_i460_subchan *schan, void *user_data) { struct mgcp_endpoint *endp = user_data; - struct rate_ctr_group *rate_ctrs = endp->trunk->ratectr.e1_stats; + atomic_uint_least64_t *rate_ctrs = endp->trunk->thread_ctr.e1_stats_atomic; struct msgb *msg = msgb_alloc_c(endp->trunk, E1_TRAU_BITS_MSGB, "E1-I.460-IDLE-TX-TRAU-frame"); uint8_t *ptr; const uint8_t *ptr_ft; enum osmo_trau_frame_type ft; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, E1_I460_TRAU_MUX_EMPTY_CTR)); + rate_ctrs[E1_I460_TRAU_MUX_EMPTY_CTR]++; /* Choose an appropiate idle frame type */ ft = endp->e1.trau_rtp_st->type; @@ -242,7 +243,7 @@ unsigned int rtp_hdr_len = sizeof(struct rtp_hdr); struct mgcp_endpoint *endp = user_data; struct msgb *msg = msgb_alloc_c(endp->trunk, RTP_BUF_SIZE, "RTP-rx-from-E1"); - struct rate_ctr_group *rate_ctrs = endp->trunk->ratectr.e1_stats; + atomic_uint_least64_t *rate_ctrs = endp->trunk->thread_ctr.e1_stats_atomic; struct mgcp_conn *conn_dst; struct osmo_trau_frame fr; int rc; @@ -305,7 +306,7 @@ msgb_free(msg); return; skip: - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, E1_I460_TRAU_RX_FAIL_CTR)); + rate_ctrs[E1_I460_TRAU_RX_FAIL_CTR]++; msgb_free(msg); return; } @@ -627,7 +628,7 @@ int mgcp_e1_send_rtp(struct mgcp_endpoint *endp, struct mgcp_rtp_codec *codec, struct msgb *msg) { struct msgb *msg_tf = msgb_alloc_c(endp->trunk, E1_TRAU_BITS_MSGB, "E1-I.460-TX-TRAU-frame"); - struct rate_ctr_group *rate_ctrs = endp->trunk->ratectr.e1_stats; + atomic_uint_least64_t *rate_ctrs = endp->trunk->thread_ctr.e1_stats_atomic; unsigned int rtp_hdr_len = sizeof(struct rtp_hdr); struct osmo_trau_frame tf; uint8_t amr_ft; @@ -683,7 +684,7 @@ return 0; skip: - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, E1_I460_TRAU_TX_FAIL_CTR)); + rate_ctrs[E1_I460_TRAU_TX_FAIL_CTR]++; msgb_free(msg_tf); return -1; } diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 11ef9e0..72d5fdb 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -126,8 +126,6 @@ /* We must only decrement the stat item when the endpoint as actually * claimed. An endpoint is claimed when a call-id is set */ if (endp->callid) { - osmo_stat_item_dec(osmo_stat_item_group_get_item(endp->trunk->stats.common, - TRUNK_STAT_ENDPOINTS_USED), 1); endp->trunk->thread_info->eps_free++; } @@ -613,8 +611,6 @@ * connection ids) */ endp->callid = talloc_strdup(endp, callid); OSMO_ASSERT(endp->callid); - osmo_stat_item_inc(osmo_stat_item_group_get_item(endp->trunk->stats.common, - TRUNK_STAT_ENDPOINTS_USED), 1); endp->trunk->thread_info->eps_free--; /* Allocate resources */ diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 2d275ec..32ac930 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -21,6 +21,7 @@ * */ +#include #include #include #include @@ -62,12 +63,11 @@ static void rtpconn_rate_ctr_add(struct mgcp_conn_rtp *conn_rtp, struct mgcp_endpoint *endp, int id, int inc) { - struct rate_ctr_group *conn_stats = conn_rtp->rate_ctr_group; - struct rate_ctr_group *mgw_stats = endp->trunk->ratectr.all_rtp_conn_stats; + atomic_uint_least64_t *mgw_stats = endp->trunk->thread_ctr.all_rtp_conn_stats_atomic; /* add to both the per-connection and the global stats */ - rate_ctr_add(rate_ctr_group_get_ctr(conn_stats, id), inc); - rate_ctr_add(rate_ctr_group_get_ctr(mgw_stats, id), inc); + conn_rtp->atomic_counters[id] += inc; + mgw_stats[id] += inc; } static void rtpconn_rate_ctr_inc(struct mgcp_conn_rtp *conn_rtp, struct mgcp_endpoint *endp, int id) @@ -192,13 +192,10 @@ } /* Check timestamp and sequence number for plausibility */ -static int check_rtp_timestamp(const struct mgcp_endpoint *endp, - const struct mgcp_rtp_state *state, - const struct mgcp_rtp_stream_state *sstate, - const struct mgcp_rtp_end *rtp_end, - const struct osmo_sockaddr *addr, - uint16_t seq, uint32_t timestamp, - const char *text, int32_t * tsdelta_out) +static int check_rtp_timestamp(const struct mgcp_endpoint *endp, const struct mgcp_rtp_state *state, + struct mgcp_rtp_stream_state *sstate, const struct mgcp_rtp_end *rtp_end, + const struct osmo_sockaddr *addr, uint16_t seq, uint32_t timestamp, const char *text, + int32_t *tsdelta_out) { int32_t tsdelta; int32_t timestamp_error; @@ -210,7 +207,7 @@ if (seq == sstate->last_seq) { if (timestamp != sstate->last_timestamp) { - rate_ctr_inc(sstate->err_ts_ctr); + sstate->err_ts_ctr++; LOGPENDP(endp, DRTP, LOGL_ERROR, "The %s timestamp delta is != 0 but the sequence " "number %d is the same, " @@ -262,7 +259,7 @@ ts_alignment_error(sstate, state->packet_duration, timestamp); if (timestamp_error) { - rate_ctr_inc(sstate->err_ts_ctr); + sstate->err_ts_ctr++; LOGPENDP(endp, DRTP, LOGL_NOTICE, "The %s timestamp has an alignment error of %d " "on SSRC: %u " @@ -1501,8 +1498,8 @@ sizeof(struct sockaddr_in))); /* Increment RX statistics */ - rate_ctr_inc(rate_ctr_group_get_ctr(conn_src->rate_ctr_group, RTP_PACKETS_RX_CTR)); - rate_ctr_add(rate_ctr_group_get_ctr(conn_src->rate_ctr_group, RTP_OCTETS_RX_CTR), msgb_length(msg)); + conn_src->atomic_counters[RTP_PACKETS_RX_CTR]++; + conn_src->atomic_counters[RTP_OCTETS_RX_CTR]++; /* FIXME: count RTP and RTCP separately, also count IuUP payload-less separately */ /* Forward a copy of the RTP data to a debug ip/port */ diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 99f1257..d889238 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -22,6 +22,7 @@ */ #include +#include #include #include #include @@ -314,18 +315,18 @@ * !! only public for testing !! */ struct msgb *mgcp_handle_message(struct mgcp_config *cfg, struct to_trunkthread_mgcp_msg *w) { - struct rate_ctr_group *rate_ctrs = cfg->ratectr.mgcp_general_ctr_group; + atomic_uint_least64_t *rate_ctrs = cfg->ratectr.mgcp_general_ctr_atomic; int code; ssize_t rc = w->x.msglen; struct mgcp_parse_data *pdata = &w->x.pdata; struct mgcp_request_data *rq = &w->x.rq; /* Count all messages, even incorect ones */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_TOTAL)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_TOTAL]++; if (rc < sizeof(rq->name) - 1) { LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_MSG_PARSE]++; return 0; } memcpy(rq->name, (const char *)&w->msg[0], sizeof(rq->name) - 1); @@ -335,7 +336,7 @@ /* attempt to treat it as a response */ if (sscanf((const char *)&w->msg[0], "%3d %*s", &code) == 1) { LOGP(DLMGCP, LOGL_DEBUG, "Response: Code: %d\n", code); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_MSG_PARSE]++; return 0; } @@ -343,7 +344,7 @@ rc = mgcp_parse_header(pdata, mgcp_strline((char *)&w->msg[4], &pdata->save)); if (rc < 0) { LOGP(DLMGCP, LOGL_ERROR, "%s: failed to parse MCGP message\n", rq->name); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_MSG_PARSE]++; return create_err_response(cfg, NULL, -rc, rq->name, "000000"); } @@ -418,7 +419,7 @@ { int rc = -500, handled = 0; struct msgb *resp = NULL; - struct rate_ctr_group *rate_ctrs = w->x.rq.trunk->cfg->ratectr.mgcp_general_ctr_group; + atomic_uint_least64_t *rate_ctrs = w->x.rq.trunk->cfg->ratectr.mgcp_general_ctr_atomic; struct mgcp_parse_data *pdata = &w->x.pdata; struct mgcp_request_data *rq = &w->x.rq; @@ -437,7 +438,7 @@ if (rq->wildcarded) { /* we know this is the trunk that handles this wildcarded message */ } else { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_NO_ENDPOINT)); + rate_ctrs[MGCP_GENERAL_RX_FAIL_NO_ENDPOINT]++; /* If the endpoint name suggests that the request refers to a specific endpoint, then the * request cannot be handled and we must stop early. */ LOGP(DLMGCP, LOGL_NOTICE, "%s: cannot find endpoint \"%s\", cause=%d -- abort\n", rq->name, @@ -449,7 +450,7 @@ /* Check if we have to retransmit a response from a previous transaction */ if (pdata->trans && rq->endp->last_trans && strcmp(rq->endp->last_trans, pdata->trans) == 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_RETRANSMITTED)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_RETRANSMITTED]++; return create_retransmission_response(rq->endp); } } @@ -482,9 +483,9 @@ /* Check if the MGCP request was handled and increment rate counters accordingly - but don't count this multiple times */ if (!rq->wildcarded || (rq->wildcarded && !strcmp(rq->name, "CRCX"))) { if (handled) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_HANDLED)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_HANDLED]++; } else { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_MSGS_UNHANDLED)); + rate_ctrs[MGCP_GENERAL_RX_MSGS_UNHANDLED]++; LOGP(DLMGCP, LOGL_ERROR, "MSG with type: '%.4s' not handled\n", rq->name); } } @@ -881,7 +882,7 @@ struct mgcp_parse_data *pdata = rq->pdatap; struct mgcp_trunk *trunk = rq->trunk; struct mgcp_endpoint *endp = rq->endp; - struct rate_ctr_group *rate_ctrs = trunk->ratectr.mgcp_crcx_ctr_group; + atomic_uint_least64_t *rate_ctrs = trunk->thread_ctr.mgcp_crcx_ctr_atomic; int error_code = 400; const char *local_options = NULL; const char *callid = NULL; @@ -897,13 +898,13 @@ /* we must have a free ep */ if (!endp) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); + rate_ctrs[MGCP_CRCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: no free endpoints available!\n"); return create_err_response(rq->trunk, NULL, 403, "CRCX", pdata->trans); } if (!mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); + rate_ctrs[MGCP_CRCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "CRCX", pdata->trans); @@ -925,7 +926,7 @@ /* It is illegal to send a connection identifier * together with a CRCX, the MGW will assign the * connection identifier by itself on CRCX */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BAD_ACTION)); + rate_ctrs[MGCP_CRCX_FAIL_BAD_ACTION]++; return create_err_response(rq->trunk, NULL, 523, "CRCX", pdata->trans); break; case 'M': @@ -951,7 +952,7 @@ default: LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "CRCX: unhandled option: '%c'/%d\n", *line, *line); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_CRCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "CRCX", pdata->trans); break; } @@ -962,14 +963,14 @@ if (!callid) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: insufficient parameters, missing callid\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_MISSING_CALLID)); + rate_ctrs[MGCP_CRCX_FAIL_MISSING_CALLID]++; return create_err_response(endp, endp, 516, "CRCX", pdata->trans); } if (!mode) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: insufficient parameters, missing mode\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); + rate_ctrs[MGCP_CRCX_FAIL_INVALID_MODE]++; return create_err_response(endp, endp, 517, "CRCX", pdata->trans); } @@ -986,7 +987,7 @@ } else { /* There is no more room for a connection, leave * everything as it is and return with an error */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_LIMIT_EXCEEDED)); + rate_ctrs[MGCP_CRCX_FAIL_LIMIT_EXCEEDED]++; return create_err_response(endp, endp, 540, "CRCX", pdata->trans); } } @@ -1004,7 +1005,7 @@ else { /* This is not our call, leave everything as it is and * return with an error. */ - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_UNKNOWN_CALLID)); + rate_ctrs[MGCP_CRCX_FAIL_UNKNOWN_CALLID]++; return create_err_response(endp, endp, 400, "CRCX", pdata->trans); } } @@ -1015,7 +1016,7 @@ * the callid matches up (see above). */ rc = mgcp_endp_claim(endp, callid); if (rc != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_CLAIM)); + rate_ctrs[MGCP_CRCX_FAIL_CLAIM]++; return create_err_response(endp, endp, 502, "CRCX", pdata->trans); } } @@ -1025,7 +1026,7 @@ if (!_conn) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: unable to allocate RTP connection\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_ALLOC_CONN)); + rate_ctrs[MGCP_CRCX_FAIL_ALLOC_CONN]++; goto error2; } @@ -1035,7 +1036,7 @@ if (mgcp_parse_conn_mode(mode, endp, conn->conn) != 0) { error_code = 517; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); + rate_ctrs[MGCP_CRCX_FAIL_INVALID_MODE]++; goto error2; } @@ -1045,13 +1046,13 @@ if (osmux_cid >= -1) { /* -1 is wilcard, alloc next avail CID */ conn->osmux.state = OSMUX_STATE_ACTIVATING; if (conn_osmux_allocate_cid(conn, osmux_cid) == -1) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); + rate_ctrs[MGCP_CRCX_FAIL_NO_OSMUX]++; goto error2; } } else if (endp->trunk->cfg->osmux == OSMUX_USAGE_ONLY) { LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: osmux only and no osmux offered\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); + rate_ctrs[MGCP_CRCX_FAIL_NO_OSMUX]++; goto error2; } @@ -1063,7 +1064,7 @@ LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: inavlid local connection options!\n"); error_code = rc; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS)); + rate_ctrs[MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS]++; goto error2; } } @@ -1073,7 +1074,7 @@ mgcp_codec_summary(conn); if (rc) { error_code = rc; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_CODEC_NEGOTIATION)); + rate_ctrs[MGCP_CRCX_FAIL_CODEC_NEGOTIATION]++; goto error2; } @@ -1094,7 +1095,7 @@ LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: selected connection mode type requires an opposite end!\n"); error_code = 527; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_REMOTE_CONN_DESC)); + rate_ctrs[MGCP_CRCX_FAIL_NO_REMOTE_CONN_DESC]++; goto error2; } @@ -1102,14 +1103,14 @@ information, then find a free port for it */ mgcp_get_local_addr(conn->end.local_addr, conn); if (allocate_port(endp, conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); + rate_ctrs[MGCP_CRCX_FAIL_BIND_PORT]++; goto error2; } if (setup_rtp_processing(endp, conn) != 0) { LOGPCONN(_conn, DLMGCP, LOGL_ERROR, "CRCX: could not start RTP processing!\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_START_RTP)); + rate_ctrs[MGCP_CRCX_FAIL_START_RTP]++; goto error2; } @@ -1125,7 +1126,7 @@ LOGPCONN(_conn, DLMGCP, LOGL_NOTICE, "CRCX: connection successfully created\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_SUCCESS)); + rate_ctrs[MGCP_CRCX_SUCCESS]++; mgcp_endp_update(endp); /* NOTE: Only in the virtual trunk we allow dynamic endpoint names */ @@ -1144,7 +1145,7 @@ struct mgcp_parse_data *pdata = rq->pdatap; struct mgcp_trunk *trunk = rq->trunk; struct mgcp_endpoint *endp = rq->endp; - struct rate_ctr_group *rate_ctrs = trunk->ratectr.mgcp_mdcx_ctr_group; + atomic_uint_least64_t *rate_ctrs = trunk->thread_ctr.mgcp_mdcx_ctr_atomic; char new_local_addr[INET6_ADDRSTRLEN]; int error_code = 500; int silent = 0; @@ -1163,19 +1164,19 @@ if (rq->wildcarded) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: wildcarded endpoint names not supported.\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_WILDCARD)); + rate_ctrs[MGCP_MDCX_FAIL_WILDCARD]++; return create_err_response(rq->trunk, endp, 507, "MDCX", pdata->trans); } if (!endp || !mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_AVAIL)); + rate_ctrs[MGCP_MDCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "MDCX", pdata->trans); } if (llist_count(&endp->conns) <= 0) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: endpoint is not holding a connection.\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONN)); + rate_ctrs[MGCP_MDCX_FAIL_NO_CONN]++; return create_err_response(endp, endp, 400, "MDCX", pdata->trans); } @@ -1186,7 +1187,7 @@ switch (toupper(line[0])) { case 'C': if (mgcp_verify_call_id(endp, line + 3) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CALLID)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_CALLID]++; error_code = 516; goto error3; } @@ -1194,7 +1195,7 @@ case 'I': conn_id = (const char *)line + 3; if ((error_code = mgcp_verify_ci(endp, conn_id))) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CONNID)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_CONNID]++; goto error3; } break; @@ -1225,7 +1226,7 @@ LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "MDCX: Unhandled MGCP option: '%c'/%d\n", line[0], line[0]); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_MDCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "MDCX", pdata->trans); break; } @@ -1235,13 +1236,13 @@ if (!conn_id) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: insufficient parameters, missing ci (connectionIdentifier)\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONNID)); + rate_ctrs[MGCP_MDCX_FAIL_NO_CONNID]++; return create_err_response(endp, endp, 515, "MDCX", pdata->trans); } conn = mgcp_conn_get_rtp(endp, conn_id); if (!conn) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_CONN_NOT_FOUND)); + rate_ctrs[MGCP_MDCX_FAIL_CONN_NOT_FOUND]++; return create_err_response(endp, endp, 400, "MDCX", pdata->trans); } @@ -1249,7 +1250,7 @@ if (mode) { if (mgcp_parse_conn_mode(mode, endp, conn->conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_MODE)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_MODE]++; error_code = 517; goto error3; } @@ -1264,7 +1265,7 @@ LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, "MDCX: invalid local connection options!\n"); error_code = rc; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CONN_OPTIONS)); + rate_ctrs[MGCP_MDCX_FAIL_INVALID_CONN_OPTIONS]++; goto error3; } } @@ -1284,7 +1285,7 @@ LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, "MDCX: selected connection mode type requires an opposite end!\n"); error_code = 527; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_REMOTE_CONN_DESC)); + rate_ctrs[MGCP_MDCX_FAIL_NO_REMOTE_CONN_DESC]++; goto error3; } @@ -1317,13 +1318,13 @@ osmo_strlcpy(conn->end.local_addr, new_local_addr, sizeof(conn->end.local_addr)); mgcp_free_rtp_port(&conn->end); if (allocate_port(endp, conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); + rate_ctrs[MGCP_CRCX_FAIL_BIND_PORT]++; goto error3; } } if (setup_rtp_processing(endp, conn) != 0) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_START_RTP)); + rate_ctrs[MGCP_MDCX_FAIL_START_RTP]++; goto error3; } @@ -1340,7 +1341,7 @@ trunk->keepalive_interval != MGCP_KEEPALIVE_NEVER) send_dummy(endp, conn); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_SUCCESS)); + rate_ctrs[MGCP_MDCX_SUCCESS]++; if (silent) goto out_silent; @@ -1362,7 +1363,7 @@ struct mgcp_parse_data *pdata = rq->pdatap; struct mgcp_trunk *trunk = rq->trunk; struct mgcp_endpoint *endp = rq->endp; - struct rate_ctr_group *rate_ctrs = trunk->ratectr.mgcp_dlcx_ctr_group; + atomic_uint_least64_t *rate_ctrs = trunk->thread_ctr.mgcp_dlcx_ctr_atomic; int error_code = 400; int silent = 0; char *line; @@ -1377,7 +1378,7 @@ LOGPEPTR(endp, trunk, DLMGCP, LOGL_NOTICE, "DLCX: deleting connection(s) ...\n"); if (endp && !mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_AVAIL)); + rate_ctrs[MGCP_DLCX_FAIL_AVAIL]++; LOGPENDP(endp, DLMGCP, LOGL_ERROR, "DLCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "DLCX", pdata->trans); @@ -1386,7 +1387,7 @@ if (endp && !rq->wildcarded && llist_empty(&endp->conns)) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "DLCX: endpoint is not holding a connection.\n"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_NO_CONN)); + rate_ctrs[MGCP_DLCX_FAIL_NO_CONN]++; return create_err_response(endp, endp, 515, "DLCX", pdata->trans); } @@ -1399,7 +1400,7 @@ num_conns += llist_count(&trunk->endpoints[i]->conns); mgcp_endp_release(trunk->endpoints[i]); } - rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); + rate_ctrs[MGCP_DLCX_SUCCESS] += num_conns; return create_ok_response(trunk, NULL, 200, "DLCX", pdata->trans); } @@ -1414,13 +1415,13 @@ if (!endp) { LOGPTRUNK(trunk, DLMGCP, LOGL_NOTICE, "cannot handle requests with call-id (C) without endpoint -- abort!"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_DLCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); } if (mgcp_verify_call_id(endp, line + 3) != 0) { error_code = 516; - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CALLID)); + rate_ctrs[MGCP_DLCX_FAIL_INVALID_CALLID]++; goto error3; } break; @@ -1430,13 +1431,13 @@ if (!endp) { LOGPTRUNK(trunk, DLMGCP, LOGL_NOTICE, "cannot handle requests with conn-id (I) without endpoint -- abort!"); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_DLCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); } conn_id = (const char *)line + 3; if ((error_code = mgcp_verify_ci(endp, conn_id))) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CONNID)); + rate_ctrs[MGCP_DLCX_FAIL_INVALID_CONNID]++; goto error3; } break; @@ -1446,7 +1447,7 @@ default: LOGPEPTR(endp, trunk, DLMGCP, LOGL_NOTICE, "DLCX: Unhandled MGCP option: '%c'/%d\n", line[0], line[0]); - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); + rate_ctrs[MGCP_DLCX_FAIL_UNHANDLED_PARAM]++; return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); break; } @@ -1467,7 +1468,7 @@ num_conns); if (num_conns > 0) - rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); + rate_ctrs[MGCP_DLCX_SUCCESS] += num_conns; mgcp_endp_release(endp); @@ -1480,7 +1481,7 @@ /* Find the connection */ conn = mgcp_conn_get_rtp(endp, conn_id); if (!conn) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CONNID)); + rate_ctrs[MGCP_DLCX_FAIL_INVALID_CONNID]++; goto error3; } /* save the statistics of the current connection */ @@ -1500,7 +1501,7 @@ LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "DLCX: endpoint released\n"); } - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS)); + rate_ctrs[MGCP_DLCX_SUCCESS]++; if (silent) goto out_silent; return create_ok_resp_with_param(endp, endp, 250, "DLCX", pdata->trans, stats); diff --git a/src/libosmo-mgcp/mgcp_ratectr.c b/src/libosmo-mgcp/mgcp_ratectr.c index 6030ce2..e2b7f59 100644 --- a/src/libosmo-mgcp/mgcp_ratectr.c +++ b/src/libosmo-mgcp/mgcp_ratectr.c @@ -220,24 +220,24 @@ trunk->trunk_nr); rate_ctr_group_set_name(ratectr->mgcp_dlcx_ctr_group, ctr_name); } - if (ratectr->all_rtp_conn_stats == NULL) { - ratectr->all_rtp_conn_stats = rate_ctr_group_alloc(trunk, &all_rtp_conn_rate_ctr_group_desc, - all_rtp_conn_rate_ctr_index++); - if (!ratectr->all_rtp_conn_stats) + if (ratectr->all_rtp_conn_stats_group == NULL) { + ratectr->all_rtp_conn_stats_group = + rate_ctr_group_alloc(trunk, &all_rtp_conn_rate_ctr_group_desc, all_rtp_conn_rate_ctr_index++); + if (!ratectr->all_rtp_conn_stats_group) return -EINVAL; snprintf(ctr_name, sizeof(ctr_name), "%s-%u:rtp_conn", mgcp_trunk_type_strs_str(trunk->trunk_type), trunk->trunk_nr); - rate_ctr_group_set_name(ratectr->all_rtp_conn_stats, ctr_name); + rate_ctr_group_set_name(ratectr->all_rtp_conn_stats_group, ctr_name); } /* E1 specific */ - if (trunk->trunk_type == MGCP_TRUNK_E1 && ratectr->e1_stats == NULL) { - ratectr->e1_stats = rate_ctr_group_alloc(trunk, &e1_rate_ctr_group_desc, mdcx_rate_ctr_index++); - if (!ratectr->e1_stats) + if (trunk->trunk_type == MGCP_TRUNK_E1 && ratectr->e1_stats_group == NULL) { + ratectr->e1_stats_group = rate_ctr_group_alloc(trunk, &e1_rate_ctr_group_desc, mdcx_rate_ctr_index++); + if (!ratectr->e1_stats_group) return -EINVAL; snprintf(ctr_name, sizeof(ctr_name), "%s-%u:e1", mgcp_trunk_type_strs_str(trunk->trunk_type), trunk->trunk_nr); - rate_ctr_group_set_name(ratectr->e1_stats, ctr_name); + rate_ctr_group_set_name(ratectr->e1_stats_group, ctr_name); } return 0; } @@ -261,15 +261,15 @@ rate_ctr_group_free(ratectr->mgcp_dlcx_ctr_group); ratectr->mgcp_dlcx_ctr_group = NULL; } - if (ratectr->all_rtp_conn_stats) { - rate_ctr_group_free(ratectr->all_rtp_conn_stats); - ratectr->all_rtp_conn_stats = NULL; + if (ratectr->all_rtp_conn_stats_group) { + rate_ctr_group_free(ratectr->all_rtp_conn_stats_group); + ratectr->all_rtp_conn_stats_group = NULL; } /* E1 specific */ - if (ratectr->e1_stats) { - rate_ctr_group_free(ratectr->e1_stats); - ratectr->e1_stats = NULL; + if (ratectr->e1_stats_group) { + rate_ctr_group_free(ratectr->e1_stats_group); + ratectr->e1_stats_group = NULL; } } diff --git a/src/libosmo-mgcp/mgcp_stat.c b/src/libosmo-mgcp/mgcp_stat.c index e679882..512d141 100644 --- a/src/libosmo-mgcp/mgcp_stat.c +++ b/src/libosmo-mgcp/mgcp_stat.c @@ -29,6 +29,7 @@ #include #include #include +#include /* Helper function for mgcp_format_stats_rtp() to calculate packet loss */ #if defined(__has_attribute) @@ -39,7 +40,7 @@ void calc_loss(struct mgcp_conn_rtp *conn, uint32_t *expected, int *loss) { struct mgcp_rtp_state *state = &conn->state; - struct rate_ctr *packets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_RX_CTR); + atomic_uint_least64_t packets_rx = conn->atomic_counters[RTP_PACKETS_RX_CTR]; *expected = state->stats.cycles + state->stats.max_seq; *expected = *expected - state->stats.base_seq + 1; @@ -54,8 +55,8 @@ * Make sure the sign is correct and use the biggest * positive/negative number that fits. */ - *loss = *expected - packets_rx->current; - if (*expected < packets_rx->current) { + *loss = *expected - packets_rx; + if (*expected < packets_rx) { if (*loss > 0) *loss = INT_MIN; } else { @@ -80,19 +81,17 @@ int ploss; int nchars; - struct rate_ctr *packets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_RX_CTR); - struct rate_ctr *octets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_OCTETS_RX_CTR); - struct rate_ctr *packets_tx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_TX_CTR); - struct rate_ctr *octets_tx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_OCTETS_TX_CTR); + atomic_uint_least64_t packets_rx = conn->atomic_counters[RTP_PACKETS_RX_CTR]; + atomic_uint_least64_t octets_rx = conn->atomic_counters[RTP_OCTETS_RX_CTR]; + atomic_uint_least64_t packets_tx = conn->atomic_counters[RTP_PACKETS_TX_CTR]; + atomic_uint_least64_t octets_tx = conn->atomic_counters[RTP_OCTETS_TX_CTR]; calc_loss(conn, &expected, &ploss); jitter = calc_jitter(&conn->state); nchars = snprintf(str, str_len, "\r\nP: PS=%" PRIu64 ", OS=%" PRIu64 ", PR=%" PRIu64 ", OR=%" PRIu64 ", PL=%d, JI=%u", - packets_tx->current, octets_tx->current, - packets_rx->current, octets_rx->current, - ploss, jitter); + packets_tx, octets_tx, packets_rx, octets_rx, ploss, jitter); if (nchars < 0 || nchars >= str_len) goto truncate; @@ -101,10 +100,8 @@ if (conn->conn->endp->trunk->cfg->osmux != OSMUX_USAGE_OFF) { /* Error Counter */ - nchars = snprintf(str, str_len, - "\r\nX-Osmo-CP: EC TI=%" PRIu64 ", TO=%" PRIu64, - conn->state.in_stream.err_ts_ctr->current, - conn->state.out_stream.err_ts_ctr->current); + nchars = snprintf(str, str_len, "\r\nX-Osmo-CP: EC TI=%" PRIu64 ", TO=%" PRIu64, + conn->state.in_stream.err_ts_ctr, conn->state.out_stream.err_ts_ctr); if (nchars < 0 || nchars >= str_len) goto truncate; diff --git a/src/libosmo-mgcp/mgcp_threads.c b/src/libosmo-mgcp/mgcp_threads.c index 6d47f24..afd744a 100644 --- a/src/libosmo-mgcp/mgcp_threads.c +++ b/src/libosmo-mgcp/mgcp_threads.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -234,6 +235,7 @@ temp_trunk.number_endpoints_offset = own_trunk_data->number_endpoints_offset; temp_trunk.endpoints = own_trunk_data->endpoints; temp_trunk.stats = own_trunk_data->stats; + temp_trunk.thread_ctr = own_trunk_data->thread_ctr; temp_trunk.num_threads = own_trunk_data->num_threads; if (own_trunk_data->trunk_type == MGCP_TRUNK_VIRTUAL) @@ -413,6 +415,50 @@ //FIXME: shutdown } +#define UPD_RATE_CTR_ATOMIC(ctrname, tid, enumname) \ + for (int i = 0; i < enumname; i++) { \ + atomic_uint_least64_t *c = &trunk->thread_info[tid].this_trunk->thread_ctr.ctrname##_atomic[i]; \ + struct rate_ctr *ctr = &trunk->ratectr.ctrname##_group->ctr[i]; \ + rate_ctr_add(ctr, *c - ctr->current); \ + } + +static struct osmo_timer_list rate_ctr_timer; + +/* updates rate counters by collecting the atomic per-thread counters, also updates ep used stats */ +static void rate_ctr_timer_cb(void *data) +{ + struct mgcp_trunk *trunk; + struct mgcp_config *cfg = data; + + for (int i = 0; i < _MGCP_GENERAL_NUM_ENUMS; i++) { + struct rate_ctr *ctr = &cfg->ratectr.mgcp_general_ctr_group->ctr[i]; + rate_ctr_add(ctr, cfg->ratectr.mgcp_general_ctr_atomic[i] - ctr->current); + } + + atomic_uint_least64_t endpoints_used = 0; + llist_for_each_entry(trunk, &cfg->trunks, entry) { + int thread_num = 0; + /* at least once: 0-thread trunks still need updating! */ + do { + UPD_RATE_CTR_ATOMIC(mgcp_crcx_ctr, thread_num, _MGCP_CRCX_NUM_ENUMS) + UPD_RATE_CTR_ATOMIC(mgcp_mdcx_ctr, thread_num, _MGCP_MDCX_NUM_ENUMS) + UPD_RATE_CTR_ATOMIC(mgcp_dlcx_ctr, thread_num, _MGCP_DLCX_NUM_ENUMS) + UPD_RATE_CTR_ATOMIC(all_rtp_conn_stats, thread_num, _MAX_RTP_CTR_NUM) + if (trunk->trunk_type == MGCP_TRUNK_E1) + UPD_RATE_CTR_ATOMIC(e1_stats, thread_num, _E1_I460_TRAU_NUM_ENUMS) + + endpoints_used += trunk->thread_info[thread_num].this_trunk->number_endpoints - + trunk->thread_info[thread_num].eps_free; + } while (++thread_num < trunk->num_threads); + + /* cheat by using the rate ctr one second callback to also update the ep usage stats */ + osmo_stat_item_set(osmo_stat_item_group_get_item(trunk->stats.common, TRUNK_STAT_ENDPOINTS_USED), + endpoints_used); + } + + osmo_timer_schedule(&rate_ctr_timer, 1, 0); +} + void split_trunks_into_threads(struct mgcp_config *cfg) { struct mgcp_trunk *trunk; @@ -447,4 +493,9 @@ split_per_thead(&trunk->thread_info[i]); } } + + /* wait for the threads to be done with init, so main thread can safely read atomics*/ + usleep(1000 * 100); + osmo_timer_setup(&rate_ctr_timer, rate_ctr_timer_cb, cfg); + osmo_timer_schedule(&rate_ctr_timer, 1, 0); } diff --git a/src/libosmo-mgcp/mgcp_threads_vty.c b/src/libosmo-mgcp/mgcp_threads_vty.c index 3259c8d..0cd6daa 100644 --- a/src/libosmo-mgcp/mgcp_threads_vty.c +++ b/src/libosmo-mgcp/mgcp_threads_vty.c @@ -31,15 +31,15 @@ struct mgcp_rtp_state *state = &conn->state; struct mgcp_rtp_end *end = &conn->end; struct mgcp_rtp_codec *codec = end->codec; - struct rate_ctr *tx_packets, *tx_bytes; - struct rate_ctr *rx_packets, *rx_bytes; - struct rate_ctr *dropped_packets; + atomic_uint_least64_t tx_packets, tx_bytes; + atomic_uint_least64_t rx_packets, rx_bytes; + atomic_uint_least64_t dropped_packets; - tx_packets = conn->rate_ctr_group[RTP_PACKETS_TX_CTR].ctr; - tx_bytes = conn->rate_ctr_group[RTP_OCTETS_TX_CTR].ctr; - rx_packets = conn->rate_ctr_group[RTP_PACKETS_RX_CTR].ctr; - rx_bytes = conn->rate_ctr_group[RTP_OCTETS_RX_CTR].ctr; - dropped_packets = conn->rate_ctr_group[RTP_DROPPED_PACKETS_CTR].ctr; + tx_packets = conn->atomic_counters[RTP_PACKETS_TX_CTR]; + tx_bytes = conn->atomic_counters[RTP_OCTETS_TX_CTR]; + rx_packets = conn->atomic_counters[RTP_PACKETS_RX_CTR]; + rx_bytes = conn->atomic_counters[RTP_OCTETS_RX_CTR]; + dropped_packets = conn->atomic_counters[RTP_DROPPED_PACKETS_CTR]; vty_out(vty, " Packets Sent: %" PRIu64 " (%" PRIu64 " bytes total)%s" @@ -51,12 +51,12 @@ " FPP: %d Packet Duration: %u%s" " FMTP-Extra: %s Audio-Name: %s Sub-Type: %s%s" " Output-Enabled: %d Force-PTIME: %d%s", - tx_packets->current, tx_bytes->current, VTY_NEWLINE, rx_packets->current, rx_bytes->current, - VTY_NEWLINE, state->in_stream.err_ts_ctr->current, state->out_stream.err_ts_ctr->current, VTY_NEWLINE, - dropped_packets->current, VTY_NEWLINE, codec->payload_type, codec->rate, codec->channels, VTY_NEWLINE, - codec->frame_duration_num, codec->frame_duration_den, VTY_NEWLINE, end->frames_per_packet, - end->packet_duration_ms, VTY_NEWLINE, end->fmtp_extra, codec->audio_name, codec->subtype_name, - VTY_NEWLINE, end->output_enabled, end->force_output_ptime, VTY_NEWLINE); + tx_packets, tx_bytes, VTY_NEWLINE, rx_packets, rx_bytes, VTY_NEWLINE, state->in_stream.err_ts_ctr, + state->out_stream.err_ts_ctr, VTY_NEWLINE, dropped_packets, VTY_NEWLINE, codec->payload_type, + codec->rate, codec->channels, VTY_NEWLINE, codec->frame_duration_num, codec->frame_duration_den, + VTY_NEWLINE, end->frames_per_packet, end->packet_duration_ms, VTY_NEWLINE, end->fmtp_extra, + codec->audio_name, codec->subtype_name, VTY_NEWLINE, end->output_enabled, end->force_output_ptime, + VTY_NEWLINE); } void dump_endpoint(struct vty *vty, struct mgcp_endpoint *endp, unsigned int trunk_nr, enum mgcp_trunk_type trunk_type, diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c index 62a2bbf..8635fe0 100644 --- a/src/libosmo-mgcp/mgcp_vty.c +++ b/src/libosmo-mgcp/mgcp_vty.c @@ -209,22 +209,15 @@ " %25n: %10c (%S/s %M/m %H/h %D/d) %d", ratectr->mgcp_mdcx_ctr_group); } - if (ratectr->all_rtp_conn_stats) { - vty_out(vty, " %s:%s", - ratectr->all_rtp_conn_stats->desc->group_description, - VTY_NEWLINE); - vty_out_rate_ctr_group_fmt(vty, - " %25n: %10c (%S/s %M/m %H/h %D/d) %d", - ratectr->all_rtp_conn_stats); + if (ratectr->all_rtp_conn_stats_group) { + vty_out(vty, " %s:%s", ratectr->all_rtp_conn_stats_group->desc->group_description, VTY_NEWLINE); + vty_out_rate_ctr_group_fmt(vty, " %25n: %10c (%S/s %M/m %H/h %D/d) %d", + ratectr->all_rtp_conn_stats_group); } - if (ratectr->e1_stats && trunk->trunk_type == MGCP_TRUNK_E1) { - vty_out(vty, " %s:%s", - ratectr->e1_stats->desc->group_description, - VTY_NEWLINE); - vty_out_rate_ctr_group_fmt(vty, - " %25n: %10c (%S/s %M/m %H/h %D/d) %d", - ratectr->e1_stats); + if (ratectr->e1_stats_group && trunk->trunk_type == MGCP_TRUNK_E1) { + vty_out(vty, " %s:%s", ratectr->e1_stats_group->desc->group_description, VTY_NEWLINE); + vty_out_rate_ctr_group_fmt(vty, " %25n: %10c (%S/s %M/m %H/h %D/d) %d", ratectr->e1_stats_group); } } diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index 9deee85..c74a2c4 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -16,9 +16,8 @@ * You should have received a copy of the GNU Affero General Public License * along with this program. If not, see . */ -#undef _GNU_SOURCE -#define _GNU_SOURCE +#include #include #include #include @@ -39,11 +38,17 @@ #include #include #include -#include + #include #include #include +#undef _GNU_SOURCE +#define _GNU_SOURCE +#undef __USE_GNU +#define __USE_GNU +#include + char *strline_r(char *str, char **saveptr); const char *strline_test_data = @@ -1084,21 +1089,19 @@ struct mgcp_conn_rtp *conn = NULL; struct mgcp_conn *_conn = NULL; struct mgcp_rtp_state *state; - struct rate_ctr *packets_rx; _conn = mgcp_conn_alloc(NULL, &endp, MGCP_CONN_TYPE_RTP, "test-connection"); conn = mgcp_conn_get_rtp(&endp, _conn->id); state = &conn->state; - packets_rx = rate_ctr_group_get_ctr(conn->rate_ctr_group, RTP_PACKETS_RX_CTR); state->stats.initialized = 1; state->stats.base_seq = pl_test_dat[i].base_seq; state->stats.max_seq = pl_test_dat[i].max_seq; state->stats.cycles = pl_test_dat[i].cycles; - packets_rx->current = pl_test_dat[i].packets; + conn->atomic_counters[RTP_PACKETS_RX_CTR] = pl_test_dat[i].packets; calc_loss(conn, &expected, &loss); if (loss != pl_test_dat[i].loss @@ -1309,8 +1312,8 @@ uint64_t last_out_ts_err_cnt = 0; struct mgcp_conn_rtp *conn = NULL; struct mgcp_conn *_conn = NULL; - struct rate_ctr test_ctr_in; - struct rate_ctr test_ctr_out; + atomic_uint_least64_t test_ctr_in; + atomic_uint_least64_t test_ctr_out; printf("Testing packet error detection%s%s.\n", patch_ssrc ? ", patch SSRC" : "", @@ -1323,8 +1326,8 @@ memset(&test_ctr_in, 0, sizeof(test_ctr_in)); memset(&test_ctr_out, 0, sizeof(test_ctr_out)); - state.in_stream.err_ts_ctr = &test_ctr_in; - state.out_stream.err_ts_ctr = &test_ctr_out; + state.in_stream.err_ts_ctr = test_ctr_in; + state.out_stream.err_ts_ctr = test_ctr_out; endp.type = &ep_typeset.rtp; @@ -1374,17 +1377,16 @@ printf("Out TS change: %d, dTS: %d, Seq change: %d, " "TS Err change: in +%u, out +%u\n", - state.out_stream.last_timestamp - last_timestamp, - state.out_stream.last_tsdelta, + state.out_stream.last_timestamp - last_timestamp, state.out_stream.last_tsdelta, state.out_stream.last_seq - last_seqno, - (unsigned int) (state.in_stream.err_ts_ctr->current - last_in_ts_err_cnt), - (unsigned int) (state.out_stream.err_ts_ctr->current - last_out_ts_err_cnt)); + (unsigned int)(state.in_stream.err_ts_ctr - last_in_ts_err_cnt), + (unsigned int)(state.out_stream.err_ts_ctr - last_out_ts_err_cnt)); printf("Stats: Jitter = %u, Transit = %d\n", calc_jitter(&state), state.stats.transit); - last_in_ts_err_cnt = state.in_stream.err_ts_ctr->current; - last_out_ts_err_cnt = state.out_stream.err_ts_ctr->current; + last_in_ts_err_cnt = state.in_stream.err_ts_ctr; + last_out_ts_err_cnt = state.out_stream.err_ts_ctr; last_timestamp = state.out_stream.last_timestamp; last_seqno = state.out_stream.last_seq; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5e3598f80cb062dbab376663ee51136b4508b78d Gerrit-Change-Number: 26193 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 21:55:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Nov 2021 21:55:49 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 to look at the new patch set (#10). Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... implement all_allocated:{sdcch,tch} rate counters Based on allAvailable{SDCCH,TCH}Allocated performance indicators, see 3GPP TS 52.402. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/net_init.c M tests/timer.vty 9 files changed, 137 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/25974/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 10 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 22:32:24 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Nov 2021 22:32:24 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 7: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h File include/osmocom/bsc/time_cc.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h at 1 PS6, Line 1: /* Report the cumulative counter of time for which a flag is true as rate counter. */ > Missing license header AFAIK we only put the license in the .c files https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h at 37 PS6, Line 37: * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a possible > (This goes over 120 characters, so it wraps here in gerrit review for me. [?] i would love colorcolumn if it didn't mess up terminal copy-pasting! last time i used it, it adds trailing whitespace up to the colorcolumn when shift-mousedragging in vim -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 22:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 22:32:42 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Nov 2021 22:32:42 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 to look at the new patch set (#8). Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... add time_cc API: cumlative counter for time, reported as rate_ctr This is a candidate for adding to libosmocore (as osmo_time_cc), but let's first use this in osmo-bsc to make sure that it works as intended. I started out expecting to be done with this in half an hour, but I found out that accumulating elapsed time to an integer counter has a staggering amount of complexity to it, and a million pitfalls. The intended use is to report allAvailableSDCCHAllocated and allAvailableTCHAllocated performance indicators in OsmoBSC. Hopefully this will also be generally useful elsewhere, to be worth the effort. Related: SYS#4878 Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 --- M configure.ac M include/osmocom/bsc/Makefile.am A include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am A src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/Makefile.am A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 10 files changed, 1,508 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/25973/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 8 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 22:33:20 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Nov 2021 22:33:20 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 8: Code-Review+2 re-add votes after line wrap change -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 8 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 22:33:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 22:33:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Nov 2021 22:33:49 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... Patch Set 8: Code-Review+2 combine (dexter + pespin) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 8 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Nov 2021 22:33:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 9 23:04:20 2021 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 9 Nov 2021 23:04:20 +0000 Subject: Change in osmo-pcu[master]: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26183 ) Change subject: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled ...................................................................... Patch Set 2: Code-Review+1 My +1 because "w0?ks 4 m?" running on site. I didn't do more than glance at the code. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c Gerrit-Change-Number: 26183 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Comment-Date: Tue, 09 Nov 2021 23:04:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 9 23:07:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 09 Nov 2021 23:07:37 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618aff43b5a3e_2ea32b0a73cf05f01880698@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 73s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 73s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 73s] [ 73s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 73s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 73s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 73s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 73s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 73s] 4/4 Test #4: websocket ........................ Passed 0.72 sec [ 73s] [ 73s] 75% tests passed, 1 tests failed out of 4 [ 73s] [ 73s] Total Test time (real) = 0.73 sec [ 73s] [ 73s] The following tests FAILED: [ 73s] 3 - framework (Failed) [ 73s] Errors while running CTest [ 73s] make[1]: *** [Makefile:129: test] Error 8 [ 73s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 73s] dh_auto_test: error: cd build && make -j8 test ARGS\+=--verbose ARGS\+=-j8 returned exit code 2 [ 73s] make: *** [debian/rules:9: build] Error 25 [ 73s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 73s] ### VM INTERACTION START ### [ 76s] [ 66.380468] sysrq: Power Off [ 76s] [ 66.383555] reboot: Power down [ 76s] ### VM INTERACTION END ### [ 76s] [ 76s] goat05 failed "build ulfius_2.5.2-4.2.dsc" at Tue Nov 9 23:07:19 UTC 2021. [ 76s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 9 23:09:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 09 Nov 2021 23:09:03 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618aff9f70cea_2ea32b0a73cf05f018808d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 150s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 150s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 150s] [ 151s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 151s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 151s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 151s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 151s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 151s] 4/4 Test #4: websocket ........................ Passed 0.84 sec [ 151s] [ 151s] 75% tests passed, 1 tests failed out of 4 [ 151s] [ 151s] Total Test time (real) = 0.86 sec [ 151s] [ 151s] The following tests FAILED: [ 151s] 3 - framework (Failed) [ 151s] Errors while running CTest [ 151s] make[1]: *** [Makefile:129: test] Error 8 [ 151s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 151s] dh_auto_test: error: cd build && make -j8 test ARGS\+=--verbose ARGS\+=-j8 returned exit code 2 [ 151s] make: *** [debian/rules:9: build] Error 25 [ 151s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 151s] ### VM INTERACTION START ### [ 154s] [ 136.984853] sysrq: Power Off [ 154s] [ 136.990037] reboot: Power down [ 154s] ### VM INTERACTION END ### [ 154s] [ 154s] lamb55 failed "build ulfius_2.5.2-4.2.dsc" at Tue Nov 9 23:09:00 UTC 2021. [ 154s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Nov 10 00:35:29 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 00:35:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137/3/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137/3/bts/BTS_Tests.ttcn at 8087 PS3, Line 8087: ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 2dB */ > = 8dB? [?] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 00:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 00:35:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 00:35:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 to look at the new patch set (#4). Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... BTS_Tests: add test cases for Temporary ACCH Overpower Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Related: SYS#5319 --- M bts/BTS_Tests.ttcn M library/GSM_RR_Types.ttcn 2 files changed, 332 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/26137/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 01:27:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 01:27:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 ) Change subject: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots ...................................................................... library/RSL_Types: fix CHAN ACT templates for dynamic timeslots * t_RSL_IE_ActType_PDCH is actually a constant, not a template. * tr_RSL_CHAN_ACT_PDCH does not use parameter 'mode'. * Accomplish tr_RSL_CHAN_ACT_PDCH with a send template. * Use 'present' qualifier for receive template parameters. Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 --- M library/RSL_Types.ttcn 1 file changed, 18 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/26194/1 diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 1057f0b..092c1e6 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -318,7 +318,7 @@ } /* osmocom-style dynamic PDCH */ - const RSL_IE_ActivationType t_RSL_IE_ActType_PDCH := { + const RSL_IE_ActivationType c_RSL_IE_ActType_PDCH := { reactivation := false, reserved := 1, a_bits := ACT_REL_TO_OSMO_PDCH @@ -1380,13 +1380,23 @@ * } } - template RSL_Message tr_RSL_CHAN_ACT_PDCH(template RslChannelNr chan_nr, - template RSL_IE_ChannelMode mode) := { + + template (value) RSL_Message + ts_RSL_CHAN_ACT_PDCH(template (value) RslChannelNr chan_nr) := { + msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), + msg_type := RSL_MT_CHAN_ACTIV, + ies :={ + t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}), + t_RSL_IE(RSL_IE_ACT_TYPE, RSL_IE_Body:{act_type := c_RSL_IE_ActType_PDCH}) + } + } + template RSL_Message + tr_RSL_CHAN_ACT_PDCH(template (present) RslChannelNr chan_nr) := { msg_disc := tr_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ tr_RSL_IE(RSL_IE_Body:{chan_nr := chan_nr}), - tr_RSL_IE(RSL_IE_Body:{act_type := t_RSL_IE_ActType_PDCH}), + tr_RSL_IE(RSL_IE_Body:{act_type := c_RSL_IE_ActType_PDCH}), /* lots of optional IEs */ * } @@ -2280,14 +2290,16 @@ } - template (value) RSL_Message ts_RSL_IPA_PDCH_ACT(RslChannelNr chan_nr) := { + template (value) RSL_Message + ts_RSL_IPA_PDCH_ACT(template (value) RslChannelNr chan_nr) := { msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_IPAC_PDCH_ACT, ies := { t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}) } } - template RSL_Message tr_RSL_IPA_PDCH_ACT(template RslChannelNr chan_nr) := { + template RSL_Message + tr_RSL_IPA_PDCH_ACT(template (present) RslChannelNr chan_nr) := { msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_IPAC_PDCH_ACT, ies := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 Gerrit-Change-Number: 26194 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 01:27:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 01:27:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 ) Change subject: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind ...................................................................... BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind Starting from [1] osmo-bts does average the interference levels as defined by the Intave parameter before reporting over the PCUIF. In TC_pcu_interf_ind we expect to receive an interference report every 480ms (one SACCH period), so let's the Intave to 1. [1] osmo-bts.git I3fbaad5dbc3bbd305b3ad4cb4bfb431a42cfbffc Change-Id: I070b195af8c62454edd8de961cce6be2c120ae48 Related: SYS#5313 --- M bts/BTS_Tests.ttcn 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/26195/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 7476a0c..754516b 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6070,6 +6070,11 @@ var PCUIF_send_data sd; timer T; + /* Set the averaging/reporting period to 480ms */ + f_init_vty_bsc(); + f_vty_cfg_bts(BSCVTY, 0, { "interference-meas avg-period 1" }); + f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); + f_init_with_pcuif(); f_TC_pcu_act_req(0, 0, 7, true); @@ -6114,6 +6119,9 @@ } } + /* Reset the averaging/reporting period back to default */ + f_vty_cfg_bts(BSCVTY, 0, { "interference-meas avg-period 6" }); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I070b195af8c62454edd8de961cce6be2c120ae48 Gerrit-Change-Number: 26195 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 01:27:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 01:27:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: make TC_pcu_interf_ind more stable References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 ) Change subject: BTS_Tests: make TC_pcu_interf_ind more stable ...................................................................... BTS_Tests: make TC_pcu_interf_ind more stable The first interference report may contain unreliable values, so we ignore it and start the actual matching only after receiving it. Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf Related: SYS#5313 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/26196/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 754516b..143671c 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6067,6 +6067,7 @@ var template PCUIF_Message tr_interf_ind; var template PCUIF_interf ts_interf; var integer interf_ind_num := 0; + var boolean first := true; var PCUIF_send_data sd; timer T; @@ -6091,16 +6092,17 @@ interf := ts_interf ); - /* 4 SACCH periods => 4 reports (plus some guard time) */ - var float Tval := int2float(4 * 480) / 1000.0 + 0.5; - - /* Let it some time to stabilize */ - f_sleep(0.5); - PCU.clear; - - T.start(Tval); + T.start(0.480 * 1.5); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd { + /* The first interference report may contain unreliable values, so we ignore it */ + [first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) { + /* 4 SACCH periods => 4 reports (plus some guard time) */ + T.start(0.480 * 4.0 + 0.480 / 2.0); + first := false; + repeat; + } + /* Subsequent interference reports shall match our expectations */ + [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd { /* Check TDMA frame number period */ if (sd.data.u.interf_ind.fn mod 104 != 0) { setverdict(fail, "Odd TDMA frame number := ", @@ -6110,7 +6112,7 @@ if (interf_ind_num < 4) { repeat; } } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd { + [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd { setverdict(fail, "Received unexpected interference report: ", sd.data); } [] PCU.receive { repeat; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf Gerrit-Change-Number: 26196 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:05:50 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 08:05:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 08:05:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:29:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 08:29:42 +0000 Subject: Change in osmo-mgw[master]: fix up some docstrings that lost their dot In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26188 ) Change subject: fix up some docstrings that lost their dot ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I88333c165f1dc11ae29f4c1726c15656386d1f0e Gerrit-Change-Number: 26188 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Nov 2021 08:29:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:30:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 08:30:28 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 ) Change subject: adjust mgcp response context ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 08:30:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:31:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 08:31:57 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Nov 2021 08:31:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:32:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 08:32:36 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 ) Change subject: add a lock-free bounded spsc interthread queue ...................................................................... Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 21 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 08:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:32:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 08:32:58 +0000 Subject: Change in osmo-mgw[master]: clang-format: remove foreach macros In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26191 ) Change subject: clang-format: remove foreach macros ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1b5848b31470b694a2031ad83e84f3132212f94 Gerrit-Change-Number: 26191 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Nov 2021 08:32:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:36:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 08:36:06 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Nov 2021 08:36:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:36:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 08:36:44 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26192 ) Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Nov 2021 08:36:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:40:28 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 08:40:28 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26056 ) Change subject: doc/manuals: add documentation for interference reporting ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc File doc/manuals/chapters/interf_meas.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc at 8 PS2, Line 8: // TODO: BSC -> MSC reporting (3GPP TS 48.008, section 3.1.3) unresolved TODO? https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc at 44 PS2, Line 44: claer clear https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc at 45 PS2, Line 45: boundaries (`0` and `X5`), for example -75 dBm or -120 dBm. What does "how to map" mean here, is it not clearly defined how the BTS will map dBm values outside of the outer boundaries to band values? Maybe write about what the Osmocom stack does, where this behavior is not clearly defined? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 08:40:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 08:42:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 08:42:40 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26133 ) Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 08:42:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:17:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:17:44 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26186 ) Change subject: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts ...................................................................... Patch Set 1: Code-Review+2 I'm fine keeping it a sit is in this patch version. I would definetly void putting that after the main(). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Gerrit-Change-Number: 26186 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:24:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:24:21 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:24:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:27:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:27:04 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25974 ) Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 11 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:27:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:30:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:30:14 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 ) Change subject: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I070b195af8c62454edd8de961cce6be2c120ae48 Gerrit-Change-Number: 26195 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:30:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:31:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:31:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: make TC_pcu_interf_ind more stable In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 ) Change subject: BTS_Tests: make TC_pcu_interf_ind more stable ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf Gerrit-Change-Number: 26196 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:31:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:32:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:32:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137/4/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137/4/bts/BTS_Tests.ttcn at 778 PS4, Line 778: * wait for the IUT to receive then and forward over the A-bis/RSL interface. */ them -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:32:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:37:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:37:00 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: Simplify tfi_find_free logic In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26180 to look at the new patch set (#2). Change subject: ts_alloc: Simplify tfi_find_free logic ...................................................................... ts_alloc: Simplify tfi_find_free logic Avoid passing an extra pram which is accessible by GprsMs object already being passed. Once, the "trx = ms_current_trx(ms)" is moved inside the tfi_find_free function, it becomes clear that all the logic can be further simplified. Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 6 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/26180/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 Gerrit-Change-Number: 26180 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:41:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 10:41:42 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:41:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:41:45 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 10:41:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: add test cases for Temporary ACCH Overpower In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 ) Change subject: BTS_Tests: add test cases for Temporary ACCH Overpower ...................................................................... BTS_Tests: add test cases for Temporary ACCH Overpower Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Related: SYS#5319 --- M bts/BTS_Tests.ttcn M library/GSM_RR_Types.ttcn 2 files changed, 332 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 7476a0c..55bb0ee 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -317,7 +317,8 @@ /* Test-specific parameters */ friend type union TestSpecUnion { - RllTestCase rll + RllTestCase rll, + TopTestCase top } private template (value) RachControlParameters ts_RachCtrl_default := { @@ -773,6 +774,43 @@ var RSL_Message rx := f_rsl_transceive_ret(tx, exp_rx, id, ignore_other); } +/* Send the given measurement results to the IUT over the Um interface, + * wait for the IUT to receive then and forward over the A-bis/RSL interface. */ +friend function f_transceive_meas_rep(template (value) MeasurementResults meas_res) +runs on ConnHdlr { + var template (value) SacchL1Header l1h; + var octetstring l2, l3; + timer T; + + /* RR Measurement Report to be sent */ + var GsmRrL3Message meas_rep := { + header := valueof(t_RrL3Header(MEASUREMENT_REPORT)), + payload := { meas_rep := { meas_res := valueof(meas_res) } } + }; + + /* TITAN has weird (and often unusable) padding model, so we pad here manaully */ + l3 := f_pad_oct(enc_GsmRrL3Message(meas_rep), 18, '00'O); + l2 := f_pad_oct(enc_LapdmFrameAB(valueof(ts_LAPDm_AB(0, meas_rep))), 21, '00'O); + l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, false, + g_pars.l1_pars.ms_actual_ta); + + /* Send RR Measurement Report over the Um interface */ + L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2)); + + /* Expect MEASurement RESult on the A-bis/RSL interface */ + T.start(2.0); + alt { + [] RSL.receive(tr_RSL_MEAS_RES_OSMO(g_chan_nr, l3_info := l3)) { + setverdict(pass); + } + [] RSL.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for RSL MEASurement RESult"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } +} + friend function f_rsl_chan_act(RSL_IE_ChannelMode mode, boolean encr_enable := false, RSL_IE_List more_ies := {}, @@ -7956,6 +7994,272 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } +private type record TopTestCase { + RSL_IE_BS_Power bs_power, + RSL_IE_OSMO_TopAcchCap top_cap, + record of TopTestStep steps +}; +private type record TopTestStep { + MeasurementResults meas_res optional, + GsmRxLev overpower_sacch, + GsmRxLev overpower_facch +}; + +private function f_rxlev_match(template (present) RslLinkId link_id, + template (present) GsmRxLev rxlev) +runs on ConnHdlr { + var L1ctlDlMessage dl := f_L1CTL_rx_data(L1CTL, g_chan_nr, link_id); + if (not match(dl.dl_info.rx_level, rxlev)) { + setverdict(fail, "RxLev(", link_id, ") := ", dl.dl_info.rx_level, + " does not match expected RxLev := ", rxlev); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } +} + +private function f_TC_acch_overpower(charstring id) runs on ConnHdlr { + var TopTestCase tc := g_pars.spec.top; + var GsmRxLev rxlev_dcch; + var L1ctlDlMessage dl; + + /* Wait for Pau ramping to complete */ + f_sleep(6.0); + + f_l1_tune(L1CTL); + L1CTL.clear; + RSL.clear; + + /* Measure RxLev(BCCH), calculate RxLev(DCCH) */ + dl := f_L1CTL_rx_data(L1CTL, t_RslChanNr_BCCH(0)); + rxlev_dcch := dl.dl_info.rx_level - (tc.bs_power.power_level * 2); + + log("RxLev(BCCH) := ", dl.dl_info.rx_level); + log("Expected RxLev(DCCH) := ", rxlev_dcch); + + /* Additional IEs for the CHANnel ACTIVation message */ + var template (value) RSL_IE_List ies := { + /* Employ BS power control in static mode */ + t_RSL_IE(RSL_IE_MS_POWER, RSL_IE_Body:{ + bs_power := tc.bs_power + }), + /* Indicate the given Temporary Overpower capability */ + t_RSL_IE(RSL_IE_OSMO_TOP_ACCH_CAP, RSL_IE_Body:{ + top_acch_cap := tc.top_cap + }) + }; + + /* Establish a dedicated channel */ + f_est_dchan(more_ies := valueof(ies)); + + /* Give it some time to stabilize */ + f_sleep(0.480 * 2.0); + L1CTL.clear; + RSL.clear; + + for (var integer i := 0; i < lengthof(tc.steps); i := i + 1) { + var TopTestStep step := tc.steps[i]; + var GsmRxLev rxlev_facch := rxlev_dcch + step.overpower_facch; + var GsmRxLev rxlev_sacch := rxlev_dcch + step.overpower_sacch; + + log("Executing step[", i, "] := ", step); + + /* Send RR Measurement Report (if present) */ + if (ispresent(step.meas_res)) { + f_transceive_meas_rep(step.meas_res); + f_sleep(0.480 * 2.0); + L1CTL.clear; + } + + /* Check RxLev on both FACCH and SACCH */ + f_rxlev_match(tr_RslLinkID_DCCH(?), rxlev_facch); + f_rxlev_match(tr_RslLinkID_SACCH(?), rxlev_sacch); + + setverdict(pass); + } +} +testcase TC_acch_overpower_rxqual_thresh() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Verify lower and upper RxQual thresholds */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(4), /* 4dB */ + steps := { + /* Channel established, no overpower */ + { meas_res := omit, + overpower_sacch := 0, overpower_facch := 0 }, + + /* Worst possible RxQual value, overpower of 4dB */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 4, overpower_facch := 4 }, + /* Worst possible RxQual value, disabling overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 0, overpower_facch := 0 }, + + /* Lower threshold not reached, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 1), + overpower_sacch := 0, overpower_facch := 0 }, + /* Lower threshold not reached, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 2), + overpower_sacch := 0, overpower_facch := 0 }, + /* Lower threshold reached, overpower of 4dB */ + { meas_res := ts_MeasurementResults(rxq_f := 4), + overpower_sacch := 4, overpower_facch := 4 }, + /* Upper threshold not reached, keeping overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 3), + overpower_sacch := 4, overpower_facch := 4 }, + /* Upper threshold reached, disabling overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 2), + overpower_sacch := 0, overpower_facch := 0 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_rxqual_thresh_dtx() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Verify handling of FULL and SUB values */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(4), /* 4dB */ + steps := { + /* Channel established, no overpower */ + { meas_res := omit, + overpower_sacch := 0, overpower_facch := 0 }, + + /* Invalid measurement results, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 7, + rxq_s := 7, + valid := false), + overpower_sacch := 0, overpower_facch := 0 }, + + /* DTXu was in use, no overpower */ + { meas_res := ts_MeasurementResults(rxq_f := 7, + rxq_s := 0, + dtx_used := true), + overpower_sacch := 0, overpower_facch := 0 }, + /* DTXu was in use, overpower of 4 dB */ + { meas_res := ts_MeasurementResults(rxq_f := 0, + rxq_s := 7, + dtx_used := true), + overpower_sacch := 4, overpower_facch := 4 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_always_on_facch() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Overpower is always on, SACCH disabled */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ + rxqual := 0, /* always on */ + sacch_enable := false), + steps := { + /* Channel established, FACCH overpower */ + { meas_res := omit, + overpower_sacch := 0, overpower_facch := 4 }, + /* MS indicates good RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 0, overpower_facch := 4 }, + /* MS indicates bad RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 0, overpower_facch := 4 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_always_on_sacch() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Overpower is always on, FACCH disabled */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(4), /* 4 x 2dB = 8dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ + rxqual := 0, /* always on */ + facch_enable := false), + steps := { + /* Channel established, SACCH overpower */ + { meas_res := omit, + overpower_sacch := 4, overpower_facch := 0 }, + /* MS indicates good RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 4, overpower_facch := 0 }, + /* MS indicates bad RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 4, overpower_facch := 0 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} +testcase TC_acch_overpower_limit() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + /* Overpower higher than current power reduction level (2dB) */ + var template TopTestCase top := { + bs_power := ts_RSL_IE_BS_Power(1), /* 1 x 2dB = 2dB */ + top_cap := ts_RSL_IE_OSMO_TopAcchCap(overpower := 4, /* 4dB */ + rxqual := 0 /* always on */), + steps := { + /* Channel established, ACCH overpower of 2dB */ + { meas_res := omit, + overpower_sacch := 2, overpower_facch := 2 }, + /* MS indicates good RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 0), + overpower_sacch := 2, overpower_facch := 2 }, + /* MS indicates bad RxQual, no difference */ + { meas_res := ts_MeasurementResults(rxq_f := 7), + overpower_sacch := 2, overpower_facch := 2 } + } + }; + + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, + spec := { top := top }, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_acch_overpower), pars); + vc_conn.done; + + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + /* test generation of RLL ERR IND based on Um errors (TS 48.058 3.9) */ /* protocol error as per 44.006 */ /* link layer failure (repetition of I-frame N200 times without ACK */ @@ -8160,6 +8464,12 @@ execute( TC_early_immediate_assignment() ); + execute( TC_acch_overpower_rxqual_thresh() ); + execute( TC_acch_overpower_rxqual_thresh_dtx() ); + execute( TC_acch_overpower_always_on_facch() ); + execute( TC_acch_overpower_always_on_sacch() ); + execute( TC_acch_overpower_limit() ); + /* BEWARE: these test cases can potentially break the IUT or cause * weird/unexpected behavior. Ensure that they are executed last. */ execute( TC_dyn_osmo_pdch_tchh_race_act() ); diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index f45784c..980020e 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -1104,6 +1104,27 @@ } }; + template (value) MeasurementResults + ts_MeasurementResults(template (value) uint6_t rxl_f := 63, + template (value) uint6_t rxl_s := 63, + template (value) uint3_t rxq_f := 0, + template (value) uint3_t rxq_s := 0, + boolean dtx_used := false, + boolean valid := true, + template (omit) NcellReports reps := omit) := { + ba_used := '0'B, + dtx_used := bool2bit(dtx_used), + rxlev_full_srv_cell := rxl_f, + threeg_ba_used := '0'B, + meas_valid := bool2bit(not valid), + rxlev_sub_srv_cell := rxl_s, + si23_ba_used := '0'B, + rxqual_full_srv_cell := rxq_f, + rxqual_sub_srv_cell := rxq_s, + no_ncell_m := 0, + ncell_reports := reps + }; + template (value) GsmRrL3Message ts_MEAS_REP(boolean valid, template (value) uint6_t rxl_f, template (value) uint6_t rxl_s, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibdb94aa2779ae4b08f08cfef78c2959ae451a784 Gerrit-Change-Number: 26137 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:43:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:43:00 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 ) Change subject: adjust mgcp response context ...................................................................... Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c at 179 PS6, Line 179: msg = msgb_alloc_c(ctx, 4096, "MGCP msg"); why is the headroom not needed anymore? https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c at 187 PS6, Line 187: msgb_reserve(msg, 128); Ah I see, so there's no msgb_alloc_headroom_c() I guess. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:43:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:45:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 10:45:40 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c at 425 PS2, Line 425: for (int i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { I don't think we usually define int inside the loop in C files. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 10:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 10:54:31 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 10:54:31 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26161 to look at the new patch set (#4). Change subject: filesystem: fix decode_select_response ...................................................................... filesystem: fix decode_select_response There are some problems with the usage of decode_select_response. At the moment the ADF files overload the related method to provide decoding of the select responses as per 3gpp TS 102 221. However, this also means that the decoder is only available under ADF.USIM and ADF.ISIM. DF.GSM and DF.TELECOM also overload the decoder method, just like an ADF would do. This decoding method is then implemented as per 3gpp TS 51 011. Since this a a problem on UICCs, the method detects the magic byte 0x62 that can be found at the beginning on every select response of an UICC to defer to the TS 102 221 decoding method. TS 51 011 defines the first two bytes of the select response as RFU. This at least problematic. To solve this there should be a default method for decode_select_response in the profile, which can be used if no file overloads it with a specific decoder. ADFs use specific decoders, but everything else should use the default decoder. When we deal with an UICC, we expect the select response to be consistantly conform to TS 102 221, if we deal with a clasic sim we expect responses as per TS 51 011 only. Since it is still possible to replace the select response decoder we still have the opportunity to have custom select response in cartain DFs and ADFs should we need them. Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Related: OS#5274 --- M pySim/filesystem.py M pySim/ts_102_221.py M pySim/ts_51_011.py 3 files changed, 60 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/26161/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 11:18:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 11:18:59 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: Simplify tfi_find_free logic In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26180 ) Change subject: ts_alloc: Simplify tfi_find_free logic ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 Gerrit-Change-Number: 26180 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 10 Nov 2021 11:18:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 11:42:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 11:42:12 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26056 ) Change subject: doc/manuals: add documentation for interference reporting ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc File doc/manuals/chapters/interf_meas.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc at 8 PS2, Line 8: // TODO: BSC -> MSC reporting (3GPP TS 48.008, section 3.1.3) > unresolved TODO? Yes, we may want to extend this chapter some day. Currently BSC->MSC reporting is out of scope. https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc at 44 PS2, Line 44: claer > clear Done https://gerrit.osmocom.org/c/osmo-bsc/+/26056/2/doc/manuals/chapters/interf_meas.adoc at 45 PS2, Line 45: boundaries (`0` and `X5`), for example -75 dBm or -120 dBm. > What does "how to map" mean here, is it not clearly defined how the BTS will map dBm values outside [?] ACK, I'll rephrase and describe how osmo-bts behaves. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 11:42:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 11:45:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 11:45:32 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 to look at the new patch set (#3). Change subject: doc/manuals: add documentation for interference reporting ...................................................................... doc/manuals: add documentation for interference reporting Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Related: SYS#5313 --- A doc/manuals/chapters/interf_meas.adoc M doc/manuals/osmobsc-usermanual.adoc 2 files changed, 74 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/56/26056/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 11:45:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 11:45:32 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 to look at the new patch set (#4). Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... gsm_data: use ascending order for interference boundaries It's more logical to have the boundaries sorted in ascending order: * band 1 represents lowest interference levels, * band 5 represents highest interference levels. Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Related: SYS#5313 --- M doc/manuals/chapters/interf_meas.adoc M src/osmo-bsc/gsm_data.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 4 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/26133/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:00:40 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 12:00:40 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: OS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/osmo_bsc_main.c 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 7e73acd..2150060 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -284,6 +284,10 @@ /* Geographical location of the BTS */ struct llist_head loc_list; + /* Flag to indicate that this BTS has a valid configuration set. + * This flag is set by check_bts() in osmo_bsc_main.c. */ + bool valid_config; + /* number of this BTS in network */ uint8_t nr; /* human readable name / description */ diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 7c04394..cdab587 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -931,6 +931,21 @@ struct gsm_bts *bts = sign_link->trx->bts; int ret = 0; + /* Check if this BTS has a valid configuration. If not we will inhibit the BTS + * from booting with invalid configuration values by rejecting any OML messages + * comming from the BTS. */ + if (!bts->valid_config) { + struct nm_nack_signal_data nack_data; + LOGPFOH(DNM, LOGL_NOTICE, foh, "(bts=%u) BTS configuration inavlid, rejecting OML NM Message from BTS -- check and correct configuratin!\n", + bts->nr); + nack_data.msg = mb; + nack_data.mt = mt; + nack_data.bts = bts; + osmo_signal_dispatch(SS_NM, S_NM_NACK, &nack_data); + abis_nm_queue_send_next(bts); + return 0; + } + /* check for unsolicited message */ if (is_report(mt)) return abis_nm_rcvmsg_report(mb, bts); diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index a2d367b..573376a 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -396,6 +396,8 @@ if (!bts->model) return -EFAULT; + bts->valid_config = false; + switch (bts->band) { case GSM_BAND_1800: if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) { @@ -436,6 +438,7 @@ } } + bts->valid_config = true; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:15:17 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 12:15:17 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26161 to look at the new patch set (#5). Change subject: filesystem: fix decode_select_response ...................................................................... filesystem: fix decode_select_response There are some problems with the usage of decode_select_response. At the moment the ADF files overload the related method to provide decoding of the select responses as per 3gpp TS 102 221. However, this also means that the decoder is only available under ADF.USIM and ADF.ISIM. DF.GSM and DF.TELECOM also overload the decoder method, just like an ADF would do. This decoding method is then implemented as per 3gpp TS 51 011. Since this a a problem on UICCs, the method detects the magic byte 0x62 that can be found at the beginning on every select response of an UICC to defer to the TS 102 221 decoding method. TS 51 011 defines the first two bytes of the select response as RFU. This at least problematic. To solve this there should be a default method for decode_select_response in the profile, which can be used if no file overloads it with a specific decoder. ADFs use specific decoders, but everything else should use the default decoder. When we deal with an UICC, we expect the select response to be consistantly conform to TS 102 221, if we deal with a clasic sim we expect responses as per TS 51 011 only. Since it is still possible to replace the select response decoder we still have the opportunity to have custom select response in cartain DFs and ADFs should we need them. Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Related: OS#5274 --- M pySim/filesystem.py M pySim/gsm_r.py M pySim/ts_102_221.py M pySim/ts_51_011.py 4 files changed, 60 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/26161/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:27:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 12:27:56 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26133 ) Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:27:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:28:18 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 12:28:18 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26161 ) Change subject: filesystem: fix decode_select_response ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26161/5/pySim/gsm_r.py File pySim/gsm_r.py: https://gerrit.osmocom.org/c/pysim/+/26161/5/pySim/gsm_r.py at a256 PS5, Line 256: There is no need anymore to define a decode_select_response here. In any case, we should probably consider to define a GSM-R profile class. Also I woder: Which select response decoder is used when the GSM-R sim is a UICC? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Nov 2021 12:28:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:29:02 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 12:29:02 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26165 to look at the new patch set (#2). Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 5 files changed, 167 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:30:05 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 12:30:05 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26197/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/1/src/osmo-bsc/abis_nm.c at 937 PS1, Line 937: if (!bts->valid_config) { why doing this in this generic path? I't make more sense to drop the connection when the connection is established or something like that. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:30:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:31:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 12:31:00 +0000 Subject: Change in osmo-mgw[master]: fix up some docstrings that lost their dot In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26188 ) Change subject: fix up some docstrings that lost their dot ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I88333c165f1dc11ae29f4c1726c15656386d1f0e Gerrit-Change-Number: 26188 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:31:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:33:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 12:33:42 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c at 425 PS2, Line 425: for (int i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { > I don't think we usually define int inside the loop in C files. BTW, ths patch is changing the place where i is declared for no good reason I can tell, so even more reason to leave it as it was ad simplify the patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:41:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 12:41:18 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 ) Change subject: add a lock-free bounded spsc interthread queue ...................................................................... Patch Set 21: (3 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h File include/osmocom/mgcp/mgcp_threads_queue.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h at 27 PS21, Line 27: atomic_uint readptr; I'd welcome some brief documentation for each of the fields, it's not like it's a simple data structure+algo... https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h at 46 PS21, Line 46: ssize_t prep_pop(struct spsc *q); probably worth adding a spsc_* prefix to all functions listed here. https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/src/libosmo-mgcp/mgcp_threads_queue.c File src/libosmo-mgcp/mgcp_threads_queue.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/src/libosmo-mgcp/mgcp_threads_queue.c at 38 PS21, Line 38: -> own ptr relaxed, other one not so much... what do you mean here? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 21 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:41:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:41:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 12:41:49 +0000 Subject: Change in osmo-mgw[master]: clang-format: remove foreach macros In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26191 ) Change subject: clang-format: remove foreach macros ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1b5848b31470b694a2031ad83e84f3132212f94 Gerrit-Change-Number: 26191 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:41:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:43:09 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 12:43:09 +0000 Subject: Change in osmo-pcu[master]: pdch: Log line detaching TBF at start of the function In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26176 ) Change subject: pdch: Log line detaching TBF at start of the function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a Gerrit-Change-Number: 26176 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 10 Nov 2021 12:43:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:43:52 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 12:43:52 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename function to clraify what it does In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26181 ) Change subject: ts_alloc: rename function to clraify what it does ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I55954321d6f2b5e755177a8829512da371e934aa Gerrit-Change-Number: 26181 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Nov 2021 12:43:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:47:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 12:47:17 +0000 Subject: Change in osmo-pcu[master]: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26183 ) Change subject: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c Gerrit-Change-Number: 26183 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Nov 2021 12:47:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:47:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 12:47:32 +0000 Subject: Change in pysim[master]: pySim-shell: print newline on exit with CTRL+D In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26081 ) Change subject: pySim-shell: print newline on exit with CTRL+D ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/pysim/+/26081/2/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26081/2/pySim-shell.py at 207 PS2, Line 207: def do_eof(self, _: argparse.Namespace) -> bool: https://cmd2.readthedocs.io/en/latest/api/cmd.html#cmd2.Cmd.do_eof -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88e58094b9badeaabd8502006e5e16f35eaa683e Gerrit-Change-Number: 26081 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:47:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:50:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 12:50:07 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 5: (4 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h File include/osmocom/mgcp/mgcp_conn.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h at a134 PS5, Line 134: /* RTP connection related counters */ So you are removing the counters from here but still using them immediatelly afterwards? how is that supposed to work? are they included from somewhere? https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h at 27 PS5, Line 27: #include I don't see mgcp/mgcp_ratectr.h included here and that's where you moved the enum? https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h File include/osmocom/mgcp/mgcp_ratectr.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h at 15 PS5, Line 15: }; yo should perhaps move the rate_ctr dscriptions here too? https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c at a129 PS5, Line 129: osmo_stat_item_dec(osmo_stat_item_group_get_item(endp->trunk->stats.common, so we lost these counters? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:50:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:50:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 12:50:59 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26056 ) Change subject: doc/manuals: add documentation for interference reporting ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:50:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:51:21 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 12:51:21 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26133 ) Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:51:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:55:18 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 12:55:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 ) Change subject: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I070b195af8c62454edd8de961cce6be2c120ae48 Gerrit-Change-Number: 26195 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:55:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:57:02 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 12:57:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: make TC_pcu_interf_ind more stable In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 ) Change subject: BTS_Tests: make TC_pcu_interf_ind more stable ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf Gerrit-Change-Number: 26196 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:57:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:57:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 12:57:13 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 ) Change subject: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I070b195af8c62454edd8de961cce6be2c120ae48 Gerrit-Change-Number: 26195 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:57:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:57:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 12:57:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: make TC_pcu_interf_ind more stable In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 ) Change subject: BTS_Tests: make TC_pcu_interf_ind more stable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf Gerrit-Change-Number: 26196 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 12:57:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:57:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 12:57:23 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 ) Change subject: BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind ...................................................................... BTS_Tests: explicitly configure Intave in TC_pcu_interf_ind Starting from [1] osmo-bts does average the interference levels as defined by the Intave parameter before reporting over the PCUIF. In TC_pcu_interf_ind we expect to receive an interference report every 480ms (one SACCH period), so let's the Intave to 1. [1] osmo-bts.git I3fbaad5dbc3bbd305b3ad4cb4bfb431a42cfbffc Change-Id: I070b195af8c62454edd8de961cce6be2c120ae48 Related: SYS#5313 --- M bts/BTS_Tests.ttcn 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 55bb0ee..72d011d 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6108,6 +6108,11 @@ var PCUIF_send_data sd; timer T; + /* Set the averaging/reporting period to 480ms */ + f_init_vty_bsc(); + f_vty_cfg_bts(BSCVTY, 0, { "interference-meas avg-period 1" }); + f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); + f_init_with_pcuif(); f_TC_pcu_act_req(0, 0, 7, true); @@ -6152,6 +6157,9 @@ } } + /* Reset the averaging/reporting period back to default */ + f_vty_cfg_bts(BSCVTY, 0, { "interference-meas avg-period 6" }); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I070b195af8c62454edd8de961cce6be2c120ae48 Gerrit-Change-Number: 26195 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 12:57:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 12:57:23 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BTS_Tests: make TC_pcu_interf_ind more stable In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 ) Change subject: BTS_Tests: make TC_pcu_interf_ind more stable ...................................................................... BTS_Tests: make TC_pcu_interf_ind more stable The first interference report may contain unreliable values, so we ignore it and start the actual matching only after receiving it. Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf Related: SYS#5313 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 10 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 72d011d..27b004a 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6105,6 +6105,7 @@ var template PCUIF_Message tr_interf_ind; var template PCUIF_interf ts_interf; var integer interf_ind_num := 0; + var boolean first := true; var PCUIF_send_data sd; timer T; @@ -6129,16 +6130,17 @@ interf := ts_interf ); - /* 4 SACCH periods => 4 reports (plus some guard time) */ - var float Tval := int2float(4 * 480) / 1000.0 + 0.5; - - /* Let it some time to stabilize */ - f_sleep(0.5); - PCU.clear; - - T.start(Tval); + T.start(0.480 * 1.5); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd { + /* The first interference report may contain unreliable values, so we ignore it */ + [first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) { + /* 4 SACCH periods => 4 reports (plus some guard time) */ + T.start(0.480 * 4.0 + 0.480 / 2.0); + first := false; + repeat; + } + /* Subsequent interference reports shall match our expectations */ + [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd { /* Check TDMA frame number period */ if (sd.data.u.interf_ind.fn mod 104 != 0) { setverdict(fail, "Odd TDMA frame number := ", @@ -6148,7 +6150,7 @@ if (interf_ind_num < 4) { repeat; } } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd { + [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd { setverdict(fail, "Received unexpected interference report: ", sd.data); } [] PCU.receive { repeat; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I44b0db6675ecf740fba7ad2a6882f86da018febf Gerrit-Change-Number: 26196 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:00:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Nov 2021 13:00:07 +0000 Subject: Change in osmo-bts[master]: rsl: exclude disabled timeslots from interference reports In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26178 ) Change subject: rsl: exclude disabled timeslots from interference reports ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Gerrit-Change-Number: 26178 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:00:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:04:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 13:04:41 +0000 Subject: Change in pysim[master]: pySim-shell: print newline on exit with CTRL+D In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26081 ) Change subject: pySim-shell: print newline on exit with CTRL+D ...................................................................... pySim-shell: print newline on exit with CTRL+D When pySim-shell is exited using CTRL+D it does not print a newline. This means that the prompt of the OS shell shows up after the pySim-shell prompt. This is irretating. Lets print a new line on exit with CTRL+D so that everything looks straight. Change-Id: I88e58094b9badeaabd8502006e5e16f35eaa683e --- M pySim-shell.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index 0be6f21..037b843 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -204,6 +204,10 @@ """Display the intro banner""" self.poutput(self.intro) + def do_eof(self, _: argparse.Namespace) -> bool: + self.poutput("") + return self.do_quit('') + @cmd2.with_category(CUSTOM_CATEGORY) def do_equip(self, opts): """Equip pySim-shell with card""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88e58094b9badeaabd8502006e5e16f35eaa683e Gerrit-Change-Number: 26081 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:07:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 13:07:40 +0000 Subject: Change in osmo-bts[master]: rsl: exclude disabled timeslots from interference reports In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26178 ) Change subject: rsl: exclude disabled timeslots from interference reports ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Gerrit-Change-Number: 26178 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:07:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:07:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 13:07:44 +0000 Subject: Change in osmo-bts[master]: rsl: exclude disabled timeslots from interference reports In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26178 ) Change subject: rsl: exclude disabled timeslots from interference reports ...................................................................... rsl: exclude disabled timeslots from interference reports It may happen after the A-bis connection recovery that the RF RESource INDication message gets sent too early, while some timeslots are not yet configured. This confuses the BSC and provokes error messages. Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Related: SYS#5313, SYS#4971 --- M src/common/l1sap.c M src/common/pcu_sock.c M src/common/rsl.c 3 files changed, 14 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 8dee209..502bcef 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -597,6 +597,11 @@ for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { struct gsm_bts_trx_ts *ts = &trx->ts[tn]; + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (ts->mo.nm_state.availability != NM_AVSTATE_OK) + continue; + for (ln = 0; ln < ARRAY_SIZE(ts->lchan); ln++) { struct gsm_lchan *lchan = &ts->lchan[ln]; diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index f8a0f55..0018acb 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -579,6 +579,10 @@ const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; const struct gsm_lchan *lchan = &ts->lchan[0]; + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (ts->mo.nm_state.availability != NM_AVSTATE_OK) + continue; if (ts_pchan(ts) != GSM_PCHAN_PDCH) continue; diff --git a/src/common/rsl.c b/src/common/rsl.c index 4c84f21..9b73869 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -442,6 +442,11 @@ for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (ts->mo.nm_state.availability != NM_AVSTATE_OK) + continue; + for (ln = 0; ln < ARRAY_SIZE(ts->lchan); ln++) { const struct gsm_lchan *lchan = &ts->lchan[ln]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00bc6fe67ea1bbedcd5d8640e73bd8b16b9e667f Gerrit-Change-Number: 26178 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:10:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 13:10:00 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26056 ) Change subject: doc/manuals: add documentation for interference reporting ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:10:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:10:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 13:10:03 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26133 ) Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:10:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:10:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 13:10:35 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for interference reporting In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26056 ) Change subject: doc/manuals: add documentation for interference reporting ...................................................................... doc/manuals: add documentation for interference reporting Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Related: SYS#5313 --- A doc/manuals/chapters/interf_meas.adoc M doc/manuals/osmobsc-usermanual.adoc 2 files changed, 74 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/doc/manuals/chapters/interf_meas.adoc b/doc/manuals/chapters/interf_meas.adoc new file mode 100644 index 0000000..62b08c4 --- /dev/null +++ b/doc/manuals/chapters/interf_meas.adoc @@ -0,0 +1,72 @@ +== Interference reporting + +According to 3GPP 48.058, section 6.1, the BTS shall periodically report the +interference levels on *idle* channels using the "Radio resource indication" +procedure. This is done by sending the `RF RESource INDication` message, +which is specified in sections 8.6.1 and 9.3.21. + +// TODO: BSC -> MSC reporting (3GPP TS 48.008, section 3.1.3) + +=== Interference reporting parameters + +The interference band is calculated by the BTS based on the `Interference level +Boundaries` and the `Averaging period`. These parameters are sent by the BSC +over the A-bis/OML, and can be configured via the VTY interface. + +Below are the default values for them: + +---- +network + bts 0 + interference-meas avg-period 6 <1> + interference-meas level-bounds -85 <2> -91 -97 -103 -109 -115 <3> +---- +<1> Averaging period (`Intave`) in SACCH multiframe periods (480ms). +<2> Interference level boundary `0` (in dBm). +<3> Interference level boundary `X5` (in dBm). + +The `Intave` parameter defines the averaging and reporting period. With the +default value of 6 SACCH multiframe periods the BTS is instructed to report +averaged interference levels approximately every 3 seconds. + +According to 3GPP TS 48.008, there exist five interference bands and six +`Interference level Boundaries` (`0`, `X1`, ... `X5`). The BTS shall map the +averaged interference levels (initially in dBm) into these 5 bands. + +---- +-85 dBm -91 dBm -97 dBm -103 dBm -109 dBm -115 dBm + | <1> | <2> | <3> | <4> | <5> | <6> + +----------+----------+----------+----------+----------+ + | band 1 | band 2 | band 3 | band 4 | band 5 | + +----------+----------+----------+----------+----------+ +---- +<1> Interference level boundary `0` (outer). +<2> Interference level boundary `X1`. +<3> Interference level boundary `X2`. +<4> Interference level boundary `X3`. +<5> Interference level boundary `X4`. +<6> Interference level boundary `X5` (outer). + +Unfortunately, it's not clearly defined by 3GPP how the BTS is supposed to map +dBm values outside of the outer boundaries (`0` and `X5`) to band values. The +ip.access nanoBTS, for example, would map values -75 dBm and -120 dBm to bands +1 and 5, respectively. osmo-bts replicates this behavior. + +=== PDCH and dynamic timeslot handling + +The BTS may optionally report interference levels for PDCH timeslots. This +may be useful for the BSC to determine whether dynamic PDCH timeslots might +be better used for new circuit switched connections, or whether alternative +PDCH resources should be allocated for interference reasons. + +NOTE: Currently osmo-bsc makes no use of PDCH interference reports, neither +they get forwarded to the BSC co-located PCU over the PCUIF. + +For dynamic timeslots (`TCH/F_TCH/H_SDCCH/8_PDCH` and `TCH/F_PDCH`), the +following expectations apply: + +* when in TCH/F mode: no interference reports, because the only sub-channel is active; +* when in TCH/H mode: interference reports for *inactive* sub-channels only; +* when in SDCCH mode: interference reports for *inactive* sub-channels only; +* when in PDCH mode: optional interference reports; +** measurements can be performed during IDLE TDMA frames. diff --git a/doc/manuals/osmobsc-usermanual.adoc b/doc/manuals/osmobsc-usermanual.adoc index 120fe2c..0afa015 100644 --- a/doc/manuals/osmobsc-usermanual.adoc +++ b/doc/manuals/osmobsc-usermanual.adoc @@ -26,6 +26,8 @@ include::{srcdir}/chapters/power_control.adoc[] +include::{srcdir}/chapters/interf_meas.adoc[] + include::{srcdir}/chapters/handover.adoc[] include::{srcdir}/chapters/smscb.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3c15b11bbcba0811e3a15fe64365067bf8ad0dae Gerrit-Change-Number: 26056 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:10:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 13:10:35 +0000 Subject: Change in osmo-bsc[master]: gsm_data: use ascending order for interference boundaries In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26133 ) Change subject: gsm_data: use ascending order for interference boundaries ...................................................................... gsm_data: use ascending order for interference boundaries It's more logical to have the boundaries sorted in ascending order: * band 1 represents lowest interference levels, * band 5 represents highest interference levels. Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Related: SYS#5313 --- M doc/manuals/chapters/interf_meas.adoc M src/osmo-bsc/gsm_data.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 4 files changed, 16 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/doc/manuals/chapters/interf_meas.adoc b/doc/manuals/chapters/interf_meas.adoc index 62b08c4..c82ff49 100644 --- a/doc/manuals/chapters/interf_meas.adoc +++ b/doc/manuals/chapters/interf_meas.adoc @@ -19,7 +19,7 @@ network bts 0 interference-meas avg-period 6 <1> - interference-meas level-bounds -85 <2> -91 -97 -103 -109 -115 <3> + interference-meas level-bounds -115 <2> -109 -103 -97 -91 -85 <3> ---- <1> Averaging period (`Intave`) in SACCH multiframe periods (480ms). <2> Interference level boundary `0` (in dBm). @@ -34,11 +34,11 @@ averaged interference levels (initially in dBm) into these 5 bands. ---- --85 dBm -91 dBm -97 dBm -103 dBm -109 dBm -115 dBm - | <1> | <2> | <3> | <4> | <5> | <6> - +----------+----------+----------+----------+----------+ - | band 1 | band 2 | band 3 | band 4 | band 5 | - +----------+----------+----------+----------+----------+ +-115 dBm -109 dBm -103 dBm -97 dBm -91 dBm -85 dBm + | <1> | <2> | <3> | <4> | <5> | <6> + +----------+----------+----------+----------+----------+ + | band 1 | band 2 | band 3 | band 4 | band 5 | + +----------+----------+----------+----------+----------+ ---- <1> Interference level boundary `0` (outer). <2> Interference level boundary `X1`. @@ -49,7 +49,7 @@ Unfortunately, it's not clearly defined by 3GPP how the BTS is supposed to map dBm values outside of the outer boundaries (`0` and `X5`) to band values. The -ip.access nanoBTS, for example, would map values -75 dBm and -120 dBm to bands +ip.access nanoBTS, for example, would map values -120 dBm and -75 dBm to bands 1 and 5, respectively. osmo-bts replicates this behavior. === PDCH and dynamic timeslot handling diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 0134e34..988d70e 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -1120,12 +1120,12 @@ const struct gsm_interf_meas_params interf_meas_params_def = { .avg_period = 6, /* 6 SACCH periods */ .bounds_dbm = { - 85, /* 0: -85 dBm */ - 91, /* X1: -91 dBm */ - 97, /* X2: -97 dBm */ - 103, /* X3: -103 dBm */ - 109, /* X4: -109 dBm */ - 115, /* X5: -115 dBm */ + 115, /* 0: -115 dBm */ + 109, /* X1: -109 dBm */ + 103, /* X2: -103 dBm */ + 97, /* X3: -97 dBm */ + 91, /* X4: -91 dBm */ + 85, /* X5: -85 dBm */ }, }; diff --git a/tests/nanobts_omlattr/nanobts_omlattr_test.c b/tests/nanobts_omlattr/nanobts_omlattr_test.c index 0b9f6d9..1b3cc8e 100644 --- a/tests/nanobts_omlattr/nanobts_omlattr_test.c +++ b/tests/nanobts_omlattr/nanobts_omlattr_test.c @@ -163,7 +163,7 @@ bts->location_area_code = 1; bts->gprs.rac = 0; uint8_t attr_bts_expected[] = - { 0x19, 0x55, 0x5b, 0x61, 0x67, 0x6d, 0x73, 0x18, 0x06, 0x0e, 0x00, + { 0x19, 0x73, 0x6d, 0x67, 0x61, 0x5b, 0x55, 0x18, 0x06, 0x0e, 0x00, 0x02, 0x01, 0x20, 0x33, 0x1e, 0x24, 0x24, 0xa8, 0x34, 0x21, 0xa8, 0x1f, 0x3f, 0x25, 0x00, 0x01, 0x0a, 0x0c, 0x0a, 0x0b, 0x01, 0x2a, 0x5a, 0x2b, diff --git a/tests/nanobts_omlattr/nanobts_omlattr_test.ok b/tests/nanobts_omlattr/nanobts_omlattr_test.ok index 2f3ff77..e1029a4 100644 --- a/tests/nanobts_omlattr/nanobts_omlattr_test.ok +++ b/tests/nanobts_omlattr/nanobts_omlattr_test.ok @@ -1,6 +1,6 @@ Testing nanobts_attr_bts_get()... -result= 19555b61676d7318060e00020120331e2424a83421a81f3f2500010a0c0a0b012a5a2b03e80a0d230a080362093f99000700f11000010539 -expected=19555b61676d7318060e00020120331e2424a83421a81f3f2500010a0c0a0b012a5a2b03e80a0d230a080362093f99000700f11000010539 +result= 19736d67615b5518060e00020120331e2424a83421a81f3f2500010a0c0a0b012a5a2b03e80a0d230a080362093f99000700f11000010539 +expected=19736d67615b5518060e00020120331e2424a83421a81f3f2500010a0c0a0b012a5a2b03e80a0d230a080362093f99000700f11000010539 ok. Testing nanobts_attr_nse_get()... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9bf4bf0c89418685b8ea5096332d22cfba7c521 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:18:02 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 13:18:02 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26165 to look at the new patch set (#3). Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 5 files changed, 169 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:20:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 13:20:25 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c at 498 PS5, Line 498: usleep(1000 * 100); Let's rather have some volatile integer per thread or alike to check this, with a static bool done = true when it holds true. Maybe simply a global static counter which is incremented every time a thread is ready. You can incorporate that into rate_ctr_timer_cb and keep checking every second or even less in this case. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:20:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:22:23 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 13:22:23 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26192 ) Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26192/1/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26192/1/src/libosmo-mgcp/mgcp_conn.c at 330 PS1, Line 330: __attribute__((no_sanitize("undefined"))) Please add a comment in the code explaining why is this attribute added here. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:22:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:27:30 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:27:30 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25974 ) Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 11 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:27:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:27:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:27:36 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{static_sdcch, static_tch} rate counters In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25975 ) Change subject: implement all_allocated:{static_sdcch,static_tch} rate counters ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fa14531f16d3f07085620f1c50eb839c420da6a Gerrit-Change-Number: 25975 Gerrit-PatchSet: 11 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Wed, 10 Nov 2021 13:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:27:43 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:27:43 +0000 Subject: Change in osmo-bsc[master]: refactor lchan counting In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25972 ) Change subject: refactor lchan counting ...................................................................... refactor lchan counting Add chan_counts_for_trx() and chan_counts_for_bts(). Drop bts_count_free_ts() and trx_count_free_ts(). Rationale: The bts_count_free_ts() and trx_count_free_ts() always returned the number of free lchans, not timeslots. Hence, passing the pchan type as argument never really matched the semantics. Especially, when looking for free SDCCH, there is no clear match on a gsm_phys_chan_config enum value: SDCCH8_SACCH8C, CCCH_SDCCH4, CCCH_SDCCH4_CBCH, SDCCH8_SACCH8C_CBCH? -- GSM_LCHAN_SDCCH is clear. ==> Rather count free lchans by enum gsm_chan_t. Counting lchans of distinct types required separate iterations for each lchan type. ==> Rather compose an array of counts for all types, in one go. I need to count the amount of free SDCCH lchans in an upcoming patch to implement the performance indicator allAvailableAllocatedSDCCH (cumulate time for which no SDCCH are available). To implement allAvailableAllocated{SDCCH,TCH}, I need a count of both the used as well as the total lchans for a type: it does not make sense to flag "all available allocated" if none are ever available. To properly count dynamic ts, I need the maximum total that can be possible at any time. And to count currently free lchans, I need the current total. This may seem counter intuitive, but consider, e.g.: - Obviously, if a cell has only static TCH/F timeslots, it does not make sense to flag that all available TCH/H are occupied, because no TCH/H are available ever. Just stating this as contrast to dyn TS. - If a cell has OSMO_DYN timeslots, I *do* want to flag that all TCH/H are occupied when all dyn timeslots are fully occupied. - If those OSMO_DYN however are all used as TCH/F, the current total of TCH/H becomes zero, and it seems like TCH/H should not be considered. - To count the nr of currently free lchans, I need the currently possible total of lchans and the nr of occupied lchans. So return both a maximum total and a current total of lchans. In above example, the maximum total shows that there would be TCH/H possible. BTW, it would be nice to keep a chan_counts array on trx, bts and bsc level and update as channels are allocated and released, instead of counting them all over periodically. But it's less error prone this way. Related: SYS#4878 Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/bts_trx.h A include/osmocom/bsc/chan_counts.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx.c A src/osmo-bsc/chan_counts.c M src/osmo-bsc/handover_decision_2.c 10 files changed, 238 insertions(+), 72 deletions(-) Approvals: neels: Looks good to me, approved dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am index 3bccf44..3ddad45 100644 --- a/include/osmocom/bsc/Makefile.am +++ b/include/osmocom/bsc/Makefile.am @@ -16,6 +16,7 @@ bts_trx.h \ bts_ipaccess_nanobts_omlattr.h \ chan_alloc.h \ + chan_counts.h \ codec_pref.h \ ctrl.h \ debug.h \ diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 7e73acd..c887ca8 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -726,8 +726,6 @@ void gsm_bts_all_ts_dispatch(struct gsm_bts *bts, uint32_t ts_ev, void *data); -int bts_count_free_ts(struct gsm_bts *bts, enum gsm_phys_chan_config pchan); - int gsm_bts_set_system_infos(struct gsm_bts *bts); int gsm_bts_set_c0_power_red(struct gsm_bts *bts, const uint8_t red); diff --git a/include/osmocom/bsc/bts_trx.h b/include/osmocom/bsc/bts_trx.h index 4d705d0..c8df9d9 100644 --- a/include/osmocom/bsc/bts_trx.h +++ b/include/osmocom/bsc/bts_trx.h @@ -95,7 +95,6 @@ bool trx_is_usable(const struct gsm_bts_trx *trx); void gsm_trx_all_ts_dispatch(struct gsm_bts_trx *trx, uint32_t ts_ev, void *data); -int trx_count_free_ts(struct gsm_bts_trx *trx, enum gsm_phys_chan_config pchan); bool trx_has_valid_pchan_config(const struct gsm_bts_trx *trx); int gsm_bts_trx_set_system_infos(struct gsm_bts_trx *trx); diff --git a/include/osmocom/bsc/chan_counts.h b/include/osmocom/bsc/chan_counts.h new file mode 100644 index 0000000..9f73bc4 --- /dev/null +++ b/include/osmocom/bsc/chan_counts.h @@ -0,0 +1,76 @@ +/* API to count total, allocated and free channels of all types */ +#pragma once + +struct gsm_bts; +struct gsm_bts_trx; + +/* First array index to typedef chan_counts_arr. */ +enum chan_counts_dim1 { + CHAN_COUNTS1_ALL = 0, + CHAN_COUNTS1_STATIC = 1, + CHAN_COUNTS1_DYNAMIC = 2, + _CHAN_COUNTS1_NUM +}; + +/* Second array index to typedef chan_counts_arr. */ +enum chan_counts_dim2 { + /* The maximum possible nr of lchans of this type. Counts all dynamic timeslots as if they are fully available + * for this type, regardless of the current pchan mode. (For CHAN_COUNTS1_STATIC, of course no dyn TS are counted + * at all.) */ + CHAN_COUNTS2_MAX_TOTAL = 0, + /* Like MAX_TOTAL, but as soon as dynamic timeslots are switched to a specific pchan kind, current_total shrinks + * to count only currently present lchans (used and unused). */ + CHAN_COUNTS2_CURRENT_TOTAL = 1, + /* Currently used lchans of this type. To get currently free lchans, calculate CURRENT_TOTAL - ALLOCATED. */ + CHAN_COUNTS2_ALLOCATED = 2, + /* Currently assignable lchans of this type, same as CURRENT_TOTAL - ALLOCATED. */ + CHAN_COUNTS2_FREE = 3, + _CHAN_COUNTS2_NUM +}; + +struct chan_counts { + unsigned int val[_CHAN_COUNTS1_NUM][_CHAN_COUNTS2_NUM][_GSM_LCHAN_MAX]; +}; + +void chan_counts_for_bts(struct chan_counts *bts_counts, const struct gsm_bts *bts); +void chan_counts_for_trx(struct chan_counts *trx_counts, const struct gsm_bts_trx *trx); + +static inline void chan_counts_zero(struct chan_counts *counts) +{ + *counts = (struct chan_counts){0}; +} + +static inline void chan_counts_dim3_add(struct chan_counts *dst, + enum chan_counts_dim1 dst_dim1, enum chan_counts_dim2 dst_dim2, + const struct chan_counts *add, + enum chan_counts_dim1 add_dim1, enum chan_counts_dim2 add_dim2) +{ + int i; + for (i = 0; i < _GSM_LCHAN_MAX; i++) + dst->val[dst_dim1][dst_dim2][i] += add->val[add_dim1][add_dim2][i]; +} + +static inline void chan_counts_dim3_sub(struct chan_counts *dst, + enum chan_counts_dim1 dst_dim1, enum chan_counts_dim2 dst_dim2, + const struct chan_counts *sub, + enum chan_counts_dim1 sub_dim1, enum chan_counts_dim2 sub_dim2) +{ + int i; + for (i = 0; i < _GSM_LCHAN_MAX; i++) + dst->val[dst_dim1][dst_dim2][i] -= sub->val[sub_dim1][sub_dim2][i]; +} + +static inline void chan_counts_dim2_add(struct chan_counts *dst, enum chan_counts_dim1 dst_dim1, + const struct chan_counts *add, enum chan_counts_dim1 add_dim1) +{ + int i; + for (i = 0; i < _CHAN_COUNTS2_NUM; i++) + chan_counts_dim3_add(dst, dst_dim1, i, add, add_dim1, i); +} + +static inline void chan_counts_add(struct chan_counts *dst, const struct chan_counts *add) +{ + int i; + for (i = 0; i < _CHAN_COUNTS1_NUM; i++) + chan_counts_dim2_add(dst, i, add, i); +} diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index 3d6666e..583fb79 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -57,6 +57,7 @@ bts_vty.c \ bts_trx_vty.c \ chan_alloc.c \ + chan_counts.c \ codec_pref.c \ e1_config.c \ gsm_04_08_rr.c \ diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 423c2b8..c0d621c 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -56,6 +56,7 @@ #include #include #include +#include static void send_lchan_signal(int sig_no, struct gsm_lchan *lchan, struct gsm_meas_rep *resp) @@ -1946,6 +1947,7 @@ struct gsm_lchan *_select_sdcch_for_call(struct gsm_bts *bts, const struct chan_rqd *rqd, enum gsm_chan_t lctype) { + struct chan_counts bts_counts; struct gsm_lchan *lchan = NULL; int free_tchf, free_tchh; bool needs_dyn_switch; @@ -1957,8 +1959,9 @@ needs_dyn_switch = lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN && lchan->ts->pchan_is != GSM_PCHAN_SDCCH8_SACCH8C; - free_tchf = bts_count_free_ts(bts, GSM_PCHAN_TCH_F); - free_tchh = bts_count_free_ts(bts, GSM_PCHAN_TCH_H); + chan_counts_for_bts(&bts_counts, bts); + free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; + free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; if (free_tchf == 0 && free_tchh == 0) { LOG_BTS(bts, DRSL, LOGL_INFO, "CHAN RQD: 0x%x Requesting %s reason=call but no TCH available\n", diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 83adcc4..5701957 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -719,19 +719,6 @@ gsm_trx_all_ts_dispatch(trx, ts_ev, data); } - -/* Count number of free TS of given pchan type */ -int bts_count_free_ts(struct gsm_bts *bts, enum gsm_phys_chan_config pchan) -{ - struct gsm_bts_trx *trx; - int count = 0; - - llist_for_each_entry(trx, &bts->trx_list, list) - count += trx_count_free_ts(trx, pchan); - - return count; -} - /* set all system information types for a BTS */ int gsm_bts_set_system_infos(struct gsm_bts *bts) { diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c index f30c748..0333f70 100644 --- a/src/osmo-bsc/bts_trx.c +++ b/src/osmo-bsc/bts_trx.c @@ -292,54 +292,6 @@ } } -int trx_count_free_ts(struct gsm_bts_trx *trx, enum gsm_phys_chan_config pchan) -{ - struct gsm_bts_trx_ts *ts; - struct gsm_lchan *lchan; - int j; - int count = 0; - - if (!trx_is_usable(trx)) - return 0; - - for (j = 0; j < ARRAY_SIZE(trx->ts); j++) { - ts = &trx->ts[j]; - if (!ts_is_usable(ts)) - continue; - - if (ts->pchan_is == GSM_PCHAN_PDCH) { - /* Dynamic timeslots in PDCH mode will become TCH if needed. */ - switch (ts->pchan_on_init) { - case GSM_PCHAN_TCH_F_PDCH: - if (pchan == GSM_PCHAN_TCH_F) - count++; - continue; - - case GSM_PCHAN_OSMO_DYN: - if (pchan == GSM_PCHAN_TCH_F) - count++; - else if (pchan == GSM_PCHAN_TCH_H) - count += 2; - continue; - - default: - /* Not dynamic, not applicable. */ - continue; - } - } - - if (ts->pchan_is != pchan) - continue; - - ts_for_n_lchans(lchan, ts, ts->max_primary_lchans) { - if (lchan_state_is(lchan, LCHAN_ST_UNUSED)) - count++; - } - } - - return count; -} - bool trx_has_valid_pchan_config(const struct gsm_bts_trx *trx) { bool combined = false; diff --git a/src/osmo-bsc/chan_counts.c b/src/osmo-bsc/chan_counts.c new file mode 100644 index 0000000..99e6e76 --- /dev/null +++ b/src/osmo-bsc/chan_counts.c @@ -0,0 +1,142 @@ +/* count total, allocated and free channels of all types. + * + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Neels Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include + +#include +#include +#include +#include + +static const unsigned int lchans_per_pchan[_GSM_PCHAN_MAX][_GSM_LCHAN_MAX] = { + [GSM_PCHAN_NONE] = {0}, + [GSM_PCHAN_CCCH] = { [GSM_LCHAN_CCCH] = 1, }, + [GSM_PCHAN_PDCH] = { [GSM_LCHAN_PDTCH] = 1, }, + [GSM_PCHAN_CCCH_SDCCH4] = { + [GSM_LCHAN_CCCH] = 1, + [GSM_LCHAN_SDCCH] = 3, + }, + [GSM_PCHAN_TCH_F] = { [GSM_LCHAN_TCH_F] = 1, }, + [GSM_PCHAN_TCH_H] = { [GSM_LCHAN_TCH_H] = 2, }, + [GSM_PCHAN_SDCCH8_SACCH8C] = { [GSM_LCHAN_SDCCH] = 8, }, + [GSM_PCHAN_CCCH_SDCCH4_CBCH] = { + [GSM_LCHAN_CCCH] = 1, + [GSM_LCHAN_SDCCH] = 3, + [GSM_LCHAN_CBCH] = 1, + }, + [GSM_PCHAN_SDCCH8_SACCH8C_CBCH] = { + [GSM_LCHAN_SDCCH] = 8, + [GSM_LCHAN_CBCH] = 1, + }, + [GSM_PCHAN_OSMO_DYN] = { + [GSM_LCHAN_TCH_F] = 1, + [GSM_LCHAN_TCH_H] = 2, + [GSM_LCHAN_SDCCH] = 8, + [GSM_LCHAN_PDTCH] = 1, + }, + [GSM_PCHAN_TCH_F_PDCH] = { + [GSM_LCHAN_TCH_F] = 1, + [GSM_LCHAN_PDTCH] = 1, + }, +}; + +static inline void chan_counts_per_pchan_add(struct chan_counts *dst, + enum chan_counts_dim1 dim1, enum chan_counts_dim2 dim2, + enum gsm_phys_chan_config pchan) +{ + int i; + for (i = 0; i < _GSM_LCHAN_MAX; i++) + dst->val[dim1][dim2][i] += lchans_per_pchan[pchan][i]; +} + +void chan_counts_for_trx(struct chan_counts *trx_counts, const struct gsm_bts_trx *trx) +{ + const struct gsm_bts_trx_ts *ts; + const struct gsm_lchan *lchan; + int i; + + chan_counts_zero(trx_counts); + + if (!trx_is_usable(trx)) + return; + + for (i = 0; i < ARRAY_SIZE(trx->ts); i++) { + bool ts_is_dynamic; + struct chan_counts ts_count = {0}; + ts = &trx->ts[i]; + if (!ts_is_usable(ts)) + continue; + + /* Count the full potential nr of lchans for dynamic TS */ + chan_counts_per_pchan_add(&ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_MAX_TOTAL, ts->pchan_on_init); + + switch (ts->pchan_on_init) { + case GSM_PCHAN_TCH_F_PDCH: + case GSM_PCHAN_OSMO_DYN: + ts_is_dynamic = true; + break; + default: + ts_is_dynamic = false; + break; + } + + if (ts_is_dynamic && ts->pchan_is == GSM_PCHAN_PDCH) { + /* Dynamic timeslots in PDCH mode can become TCH or SDCCH immediately, + * so set CURRENT_TOTAL = MAX_TOTAL. */ + chan_counts_dim3_add(&ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_CURRENT_TOTAL, + &ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_MAX_TOTAL); + } else { + /* Static TS, or dyn TS that are currently fixed on a specific pchan: count lchans for the + * current pchan mode. */ + chan_counts_per_pchan_add(&ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_CURRENT_TOTAL, ts->pchan_is); + } + + /* Count currently allocated lchans */ + ts_for_n_lchans(lchan, ts, ts->max_primary_lchans) { + if (!lchan_state_is(lchan, LCHAN_ST_UNUSED)) + ts_count.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_ALLOCATED][lchan->type]++; + } + + chan_counts_dim3_add(&ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_FREE, + &ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_CURRENT_TOTAL); + chan_counts_dim3_sub(&ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_FREE, + &ts_count, CHAN_COUNTS1_ALL, CHAN_COUNTS2_ALLOCATED); + + if (ts_is_dynamic) + chan_counts_dim2_add(trx_counts, CHAN_COUNTS1_DYNAMIC, &ts_count, CHAN_COUNTS1_ALL); + else + chan_counts_dim2_add(trx_counts, CHAN_COUNTS1_STATIC, &ts_count, CHAN_COUNTS1_ALL); + chan_counts_dim2_add(trx_counts, CHAN_COUNTS1_ALL, &ts_count, CHAN_COUNTS1_ALL); + } +} + +void chan_counts_for_bts(struct chan_counts *bts_counts, const struct gsm_bts *bts) +{ + struct gsm_bts_trx *trx; + chan_counts_zero(bts_counts); + + llist_for_each_entry(trx, &bts->trx_list, list) { + struct chan_counts trx_counts; + chan_counts_for_trx(&trx_counts, trx); + chan_counts_add(bts_counts, &trx_counts); + } +} diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index e384feb..6730f26 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -42,6 +42,7 @@ #include #include #include +#include #define LOGPHOBTS(bts, level, fmt, args...) \ LOGP(DHODEC, level, "(BTS %u) " fmt, bts->nr, ## args) @@ -990,12 +991,15 @@ static void candidate_set_free_tch(struct ho_candidate *c) { + struct chan_counts bts_counts; struct gsm_lchan *next_lchan; - c->current.free_tchf = bts_count_free_ts(c->current.bts, GSM_PCHAN_TCH_F); + chan_counts_for_bts(&bts_counts, c->current.bts); + c->current.free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; c->current.min_free_tchf = ho_get_hodec2_tchf_min_slots(c->current.bts->ho); - c->current.free_tchh = bts_count_free_ts(c->current.bts, GSM_PCHAN_TCH_H); + c->current.free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; c->current.min_free_tchh = ho_get_hodec2_tchh_min_slots(c->current.bts->ho); + switch (c->current.lchan->ts->pchan_is) { case GSM_PCHAN_TCH_F: c->current.free_tch = c->current.free_tchf; @@ -1023,9 +1027,10 @@ break; } - c->target.free_tchf = bts_count_free_ts(c->target.bts, GSM_PCHAN_TCH_F); + chan_counts_for_bts(&bts_counts, c->target.bts); + c->target.free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; c->target.min_free_tchf = ho_get_hodec2_tchf_min_slots(c->target.bts->ho); - c->target.free_tchh = bts_count_free_ts(c->target.bts, GSM_PCHAN_TCH_H); + c->target.free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; c->target.min_free_tchh = ho_get_hodec2_tchh_min_slots(c->target.bts->ho); /* Would the next TCH/F lchan occupy a dynamic timeslot that currently counts for free TCH/H timeslots? */ @@ -1928,6 +1933,7 @@ static void bts_congestion_check(struct gsm_bts *bts) { + struct chan_counts bts_counts; int min_free_tchf, min_free_tchh; int free_tchf, free_tchh; @@ -1955,8 +1961,9 @@ return; } - free_tchf = bts_count_free_ts(bts, GSM_PCHAN_TCH_F); - free_tchh = bts_count_free_ts(bts, GSM_PCHAN_TCH_H); + chan_counts_for_bts(&bts_counts, bts); + free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; + free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; LOGPHOBTS(bts, LOGL_INFO, "Congestion check: (free/want-free) TCH/F=%d/%d TCH/H=%d/%d\n", free_tchf, min_free_tchf, free_tchh, min_free_tchh); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb48c549186db812b1e9d6b735a92e80f27b8d3 Gerrit-Change-Number: 25972 Gerrit-PatchSet: 9 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:27:44 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:27:44 +0000 Subject: Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... add time_cc API: cumlative counter for time, reported as rate_ctr This is a candidate for adding to libosmocore (as osmo_time_cc), but let's first use this in osmo-bsc to make sure that it works as intended. I started out expecting to be done with this in half an hour, but I found out that accumulating elapsed time to an integer counter has a staggering amount of complexity to it, and a million pitfalls. The intended use is to report allAvailableSDCCHAllocated and allAvailableTCHAllocated performance indicators in OsmoBSC. Hopefully this will also be generally useful elsewhere, to be worth the effort. Related: SYS#4878 Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 --- M configure.ac M include/osmocom/bsc/Makefile.am A include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am A src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/Makefile.am A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 10 files changed, 1,508 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index bcf91ba..989ad7d 100644 --- a/configure.ac +++ b/configure.ac @@ -238,6 +238,7 @@ tests/subscr/Makefile tests/nanobts_omlattr/Makefile tests/handover/Makefile + tests/time_cc/Makefile doc/Makefile doc/examples/Makefile doc/manuals/Makefile diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am index 3ddad45..8831533 100644 --- a/include/osmocom/bsc/Makefile.am +++ b/include/osmocom/bsc/Makefile.am @@ -58,6 +58,7 @@ signal.h \ system_information.h \ timeslot_fsm.h \ + time_cc.h \ vty.h \ gsm_08_08.h \ penalty_timers.h \ diff --git a/include/osmocom/bsc/time_cc.h b/include/osmocom/bsc/time_cc.h new file mode 100644 index 0000000..abddbcf --- /dev/null +++ b/include/osmocom/bsc/time_cc.h @@ -0,0 +1,157 @@ +/* Report the cumulative counter of time for which a flag is true as rate counter. */ +#pragma once + +#include + +#include + +struct osmo_tdef; +struct rate_ctr; + +/*! Configuration for time_cc. + * Report the cumulative counter of time for which a flag is true as rate counter. + * For example, for each second that the flag is true, increment a rate counter. + * + * The flag to be monitored is reported by time_cc_set_flag(). + * + * The granularity defines how much time one rate counter increment represents: + * the default configuration is gran_usec = 1000000, i.e. one rate counter increment represents one second. + * + * Reporting as rate counter is configurable by round_threshold_usec and forget_sum_usec, examples: + * + * round_threshold_usec: + * - To get "ceil()" behavior, set round_threshold_usec = 1. This increments the rate counter for each gran_usec period + * where the flag was seen true, even if it was true for only a very short fraction of a gran_usec period. + * - To get "round()" behavior, set round_threshold_usec = half of gran_usec. The rate counter increments when the flag + * has been true for 0.5 of a gran_usec (and then again at 1.5 * gran_usec of 'true' flag). round_threshold_usec = 0 + * is a special value that means to use half of gran_usec. + * - To get "floor()" behavior, set round_threshold_usec >= gran_usec. The rate counter increments when reaching full + * gran_usec periods of the flag being true. + * + * forget_sum_usec: + * This is a tradeoff between the accuracy of the reported rate counter and making sure that the events reported are not + * irrelevantly long ago. + * - To keep sub-granularity-period surplus time forever, set forget_sum_usec = 0. + * - To keep surplus time for up to a minute, set forget_sum_usec = 60000000 (60 seconds). + * - To get rid of "leftover" time (almost) immediately after the flag goes false, set forget_sum_usec = 1. + * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a + * possible inaccuracy of 1/60th, but makes sure that no timings older than a minute affect the current reports. + * + * Reporting modes in detail: + * + * The rate_ctr increments when the cumulative counter passes round_threshold_usec (default: half of gran_usec). + * + * sum ^ + * | ________ + * | / + * | / + * | / + * 3*gran --+--------------------------------------+ + * | /: + * | / : + * | - - - - - - - - - - - - - - - - - / : + * | /. : + * | / . : + * 2*gran --+--------------------------------+ . : + * | /: . : + * | / : . : + * | - - - - - - - - - -_________/ : . : + * | / . : . : + * | / . : . : + * 1*gran --+-----------------+ . : . : + * | /: . : . : + * | / : . : . : + * | - - - - - - -/ : . : . : + * | /. : . : . : + * | ....-------' . : . : . : + * 0 +------------------------------------------------------------------------> elapsed time + * . : . : . : + * _ _ _______ ____________ + * flag: __| |_| |____| . : |_______|. : . : |__________ + * f t f t f t . : f t. : . : f + * round_threshold_usec : . : . : . : + * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" + * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" + * >= gran_usec: 0 1 2 3 = "floor()" + * + */ +struct time_cc_cfg { + /*! Granularity in microseconds: nr of microseconds that one rate_ctr increment represents. A typical value is + * gran_usec = 1000000, meaning one rate counter increment represents one second. */ + uint64_t gran_usec; + /*! Nr of microseconds above a full gran_usec at which to trigger rate_ctr_round. When zero, half a gran_usec. */ + uint64_t round_threshold_usec; + /*! Forget counted sub-gran time after the flag was false for this long. */ + uint64_t forget_sum_usec; + /*! Rate counter to report to, or NULL to not use it. */ + struct rate_ctr *rate_ctr; + + /*! Update gran_usec from this T timer value, or zero to not use any T timer. */ + int T_gran; + /*! Update round_threshold_usec from this T timer value, or zero to not use any T timer. */ + int T_round_threshold; + /*! Update forget_sum_usec from this T timer value, or zero to not use any T timer. */ + int T_forget_sum; + /*! Look up T_gran and T_forget_sum in this list of timers, or NULL to not use any T timers. */ + struct osmo_tdef *T_defs; +}; + +/*! Report the cumulative counter of time for which a flag is true as rate counter. + * See also time_cc_cfg for details on configuring. + * + * Usage: + * + * struct my_obj { + * struct time_cc flag_cc; + * }; + * + * void my_obj_init(struct my_obj *my_obj) + * { + * time_cc_init(&my_obj->flag_cc); + * my_obj->flag_cc.cfg = (struct time_cc_cfg){ + * .gran_usec = 1000000, + * .forget_sum_usec = 60000000, + * .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, MY_CTR_IDX), + * }; + * // optional: set initial flag state, default is 'false': + * // time_cc_set_flag(&my_obj->flag_cc, false); + * } + * + * void my_obj_event(struct my_obj *my_obj, bool flag) + * { + * time_cc_set_flag(&my_obj->flag_cc, flag); + * } + * + * void my_obj_destruct(struct my_obj *my_obj) + * { + * time_cc_cleanup(&my_obj->flag_cc); + * } + */ +struct time_cc { + struct time_cc_cfg cfg; + + bool flag_state; + + /** Overall cumulative sum. Does not get reset for the entire lifetime of a time_cc. + * (Informational only, not used by the time_cc implementation.) */ + uint64_t total_sum; + + struct osmo_timer_list timer; + + /** CLOCK_MONOTONIC reading in microseconds, at the time when the time_cc instance started counting. */ + uint64_t start_time; + /** CLOCK_MONOTONIC reading in microseconds, at the time when the time_cc last evaluated the flag state and + * possibly added to the cumulated sum. */ + uint64_t last_counted_time; + + /** Internal cumulative counter of time that flag_state was true. It may get reset to zero regularly, depending + * on cfg.forget_sum_usec. This is the basis for incrementing cfg.rate_ctr. */ + uint64_t sum; + /** The amount of time that already reported cfg.rate_ctr increments account for. This may be ahead of or behind + * 'sum', depending on cfg.round_threshold_usec. */ + uint64_t reported_sum; +}; + +void time_cc_init(struct time_cc *tc); +void time_cc_set_flag(struct time_cc *tc, bool flag); +void time_cc_cleanup(struct time_cc *tc); diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index 583fb79..cebbaeb 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -105,6 +105,7 @@ bssmap_reset.c \ system_information.c \ timeslot_fsm.c \ + time_cc.c \ smscb.c \ cbch_scheduler.c \ cbsp_link.c \ diff --git a/src/osmo-bsc/time_cc.c b/src/osmo-bsc/time_cc.c new file mode 100644 index 0000000..e78e48d --- /dev/null +++ b/src/osmo-bsc/time_cc.c @@ -0,0 +1,208 @@ +/* Report the cumulative counter of time for which a flag is true as rate counter. */ +/* Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH + * + * All Rights Reserved + * + * Author: Neels Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include + +#include +#include + +#include + +#define GRAN_USEC(TIME_CC) ((TIME_CC)->cfg.gran_usec ? : 1000000) +#define ROUND_THRESHOLD_USEC(TIME_CC) ((TIME_CC)->cfg.round_threshold_usec ? \ + OSMO_MIN((TIME_CC)->cfg.round_threshold_usec, GRAN_USEC(TIME_CC)) \ + : (GRAN_USEC(TIME_CC) / 2)) + +static uint64_t time_now_usec() +{ + struct timespec tp; + if (osmo_clock_gettime(CLOCK_MONOTONIC, &tp)) + return 0; + return (uint64_t)tp.tv_sec * 1000000 + tp.tv_nsec / 1000; +} + +static void time_cc_forget_sum(struct time_cc *tc, uint64_t now); + +static void time_cc_update_from_tdef(struct time_cc *tc, uint64_t now) +{ + bool do_forget_sum = false; + if (!tc->cfg.T_defs) + return; + if (tc->cfg.T_gran) { + uint64_t was = GRAN_USEC(tc); + tc->cfg.gran_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_gran, OSMO_TDEF_US, -1); + if (was != GRAN_USEC(tc)) + do_forget_sum = true; + } + if (tc->cfg.T_round_threshold) + tc->cfg.round_threshold_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_round_threshold, + OSMO_TDEF_US, -1); + if (tc->cfg.T_forget_sum) { + uint64_t was = tc->cfg.forget_sum_usec; + tc->cfg.forget_sum_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_forget_sum, OSMO_TDEF_US, -1); + if (tc->cfg.forget_sum_usec && was != tc->cfg.forget_sum_usec) + do_forget_sum = true; + } + + if (do_forget_sum && tc->sum) + time_cc_forget_sum(tc, now); +} + +static void time_cc_schedule_timer(struct time_cc *tc, uint64_t now); + +/* Clear out osmo_timer and internal counting state of struct time_cc. The .cfg remains unaffected. After calling, the + * time_cc instance can be used again to accumulate state as if it had just been initialized. */ +void time_cc_cleanup(struct time_cc *tc) +{ + osmo_timer_del(&tc->timer); + *tc = (struct time_cc){ + .cfg = tc->cfg, + }; +} + +static void time_cc_start(struct time_cc *tc, uint64_t now) +{ + time_cc_cleanup(tc); + /* Set the default of 1 second of granularity */ + tc->start_time = now; + tc->last_counted_time = now; + time_cc_update_from_tdef(tc, now); + time_cc_schedule_timer(tc, now); +} + +static void time_cc_count_time(struct time_cc *tc, uint64_t now) +{ + uint64_t time_delta = now - tc->last_counted_time; + tc->last_counted_time = now; + if (!tc->flag_state) + return; + /* Flag is currently true, cumulate the elapsed time */ + tc->total_sum += time_delta; + tc->sum += time_delta; +} + +static void time_cc_report(struct time_cc *tc, uint64_t now) +{ + uint64_t delta; + uint64_t n; + if (!tc->cfg.rate_ctr) + return; + /* We report a sum "rounded up", ahead of time. If the granularity period has not yet elapsed after the last + * reporting, do not report again yet. */ + if (tc->reported_sum > tc->sum) + return; + delta = tc->sum - tc->reported_sum; + /* elapsed full periods */ + n = delta / GRAN_USEC(tc); + /* If the delta has passed round_threshold (normally half of gran_usec), increment. */ + delta -= n * GRAN_USEC(tc); + if (delta >= ROUND_THRESHOLD_USEC(tc)) + n++; + if (!n) + return; + + /* integer sanity, since rate_ctr_add() takes an int argument. */ + if (n > INT_MAX) + n = INT_MAX; + rate_ctr_add(tc->cfg.rate_ctr, n); + /* Store the increments of gran_usec that were counted. */ + tc->reported_sum += n * GRAN_USEC(tc); +} + +static void time_cc_forget_sum(struct time_cc *tc, uint64_t now) +{ + tc->reported_sum = 0; + tc->sum = 0; + + if (tc->last_counted_time < now) + tc->last_counted_time = now; +} + +/* Initialize struct time_cc. Call this once before use, and before setting up the .cfg items. */ +void time_cc_init(struct time_cc *tc) +{ + *tc = (struct time_cc){0}; +} + +void time_cc_set_flag(struct time_cc *tc, bool flag) +{ + uint64_t now = time_now_usec(); + if (!tc->start_time) + time_cc_start(tc, now); + /* No flag change == no effect */ + if (flag == tc->flag_state) + return; + /* Sum up elapsed time, report increments for that. */ + time_cc_count_time(tc, now); + time_cc_report(tc, now); + tc->flag_state = flag; + time_cc_schedule_timer(tc, now); +} + +static void time_cc_timer_cb(void *data) +{ + struct time_cc *tc = data; + uint64_t now = time_now_usec(); + + time_cc_update_from_tdef(tc, now); + + if (tc->flag_state) { + time_cc_count_time(tc, now); + time_cc_report(tc, now); + } else if (tc->cfg.forget_sum_usec && tc->sum + && (now >= tc->last_counted_time + tc->cfg.forget_sum_usec)) { + time_cc_forget_sum(tc, now); + } + time_cc_schedule_timer(tc, now); +} + +static void time_cc_schedule_timer(struct time_cc *tc, uint64_t now) +{ + uint64_t next_event = UINT64_MAX; + + time_cc_update_from_tdef(tc, now); + + /* Figure out the next time we should do anything, if the flag state remains unchanged. */ + /* If it is required, when will the next forget_sum happen? */ + if (tc->cfg.forget_sum_usec && !tc->flag_state && tc->sum > 0) { + uint64_t next_forget_time = tc->last_counted_time + tc->cfg.forget_sum_usec; + next_event = OSMO_MIN(next_event, next_forget_time); + } + /* Next rate_ctr increment? */ + if (tc->flag_state && tc->cfg.rate_ctr) { + uint64_t next_inc = now + (tc->reported_sum - tc->sum) + ROUND_THRESHOLD_USEC(tc); + next_event = OSMO_MIN(next_event, next_inc); + } + + /* No event coming up? */ + if (next_event == UINT64_MAX) + return; + + if (next_event <= now) + next_event = 0; + else + next_event -= now; + + osmo_timer_setup(&tc->timer, time_cc_timer_cb, tc); + osmo_timer_del(&tc->timer); + osmo_timer_schedule(&tc->timer, next_event / 1000000, next_event % 1000000); +} diff --git a/tests/Makefile.am b/tests/Makefile.am index 762561e..aefaae8 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -7,6 +7,7 @@ subscr \ nanobts_omlattr \ handover \ + time_cc \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. diff --git a/tests/testsuite.at b/tests/testsuite.at index e7eb76b..094117f 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -49,3 +49,9 @@ cat $abs_srcdir/handover/handover_tests.ok > expout AT_CHECK([$abs_srcdir/handover/handover_tests.sh $abs_srcdir/handover $abs_builddir/handover], [], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([time_cc_test]) +AT_KEYWORDS([time_cc_test]) +cat $abs_srcdir/time_cc/time_cc_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/time_cc/time_cc_test], [], [expout], [ignore]) +AT_CLEANUP diff --git a/tests/time_cc/Makefile.am b/tests/time_cc/Makefile.am new file mode 100644 index 0000000..de407e7 --- /dev/null +++ b/tests/time_cc/Makefile.am @@ -0,0 +1,36 @@ +AM_CPPFLAGS = \ + $(all_includes) \ + -I$(top_srcdir)/include \ + $(NULL) + +AM_CFLAGS = \ + -Wall \ + -ggdb3 \ + $(LIBOSMOCORE_CFLAGS) \ + $(COVERAGE_CFLAGS) \ + $(NULL) + +AM_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ + $(NULL) + +EXTRA_DIST = \ + time_cc_test.ok \ + $(NULL) + +noinst_PROGRAMS = \ + time_cc_test \ + $(NULL) + +time_cc_test_SOURCES = \ + time_cc_test.c \ + $(NULL) + +time_cc_test_LDADD = \ + $(top_builddir)/src/osmo-bsc/libbsc.la \ + $(LIBOSMOCORE_LIBS) \ + $(NULL) + +.PHONY: update_exp +update_exp: + $(builddir)/time_cc_test >$(srcdir)/time_cc_test.ok diff --git a/tests/time_cc/time_cc_test.c b/tests/time_cc/time_cc_test.c new file mode 100644 index 0000000..4c5396d --- /dev/null +++ b/tests/time_cc/time_cc_test.c @@ -0,0 +1,769 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Neels Janosch Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include + +#include +#include +#include +#include +#include +#include + +#include + +enum my_ctrs { + CTR_CEIL, + CTR_ROUND, + CTR_FLOOR, +}; + +const struct rate_ctr_desc my_ctr_desc[] = { + [CTR_CEIL] = {"ceil", "testing round_threshold_usec = 1"}, + [CTR_ROUND] = {"round", "testing round_threshold_usec = 0 = gran_usec/2"}, + [CTR_FLOOR] = {"floor", "testing round_threshold_usec = gran_usec"}, +}; + +const struct rate_ctr_group_desc my_ctrg_desc = { + "time_cc_test", + "Counters for time_cc test", + 0, + ARRAY_SIZE(my_ctr_desc), + my_ctr_desc, +}; + +struct rate_ctr_group *my_ctrg; + + +enum my_obj_timers { + T_GRAN = -23, + T_ROUND_THRESH = -24, + T_FORGET_SUM = -25, +}; + +struct osmo_tdef g_my_obj_tdefs[] = { + { .T = T_GRAN, .default_val = 0, .unit = OSMO_TDEF_MS, .desc = "flag_cc granularity, or zero for 1 second" }, + { .T = T_ROUND_THRESH, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "flag_cc rounding threshold, or zero for half a granularity" }, + { .T = T_FORGET_SUM, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "flag_cc inactivity forget period, or zero to not forget any timings" }, + {} +}; + + +struct my_obj { + struct time_cc flag_cc_ceil; + struct time_cc flag_cc_round; + struct time_cc flag_cc_floor; +}; + +void my_obj_init(struct my_obj *my_obj) +{ + time_cc_init(&my_obj->flag_cc_ceil); + my_obj->flag_cc_ceil.cfg = (struct time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_CEIL), + .round_threshold_usec = 1, + .T_gran = T_GRAN, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; + + time_cc_init(&my_obj->flag_cc_round); + my_obj->flag_cc_round.cfg = (struct time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_ROUND), + .T_gran = T_GRAN, + .T_round_threshold = T_ROUND_THRESH, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; + + time_cc_init(&my_obj->flag_cc_floor); + my_obj->flag_cc_floor.cfg = (struct time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_FLOOR), + .round_threshold_usec = UINT64_MAX, /* always >= gran_usec */ + .T_gran = T_GRAN, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; +} + +void my_obj_event(struct my_obj *my_obj, bool flag) +{ + time_cc_set_flag(&my_obj->flag_cc_ceil, flag); + time_cc_set_flag(&my_obj->flag_cc_round, flag); + time_cc_set_flag(&my_obj->flag_cc_floor, flag); +} + +void my_obj_destruct(struct my_obj *my_obj) +{ + time_cc_cleanup(&my_obj->flag_cc_ceil); + time_cc_cleanup(&my_obj->flag_cc_round); + time_cc_cleanup(&my_obj->flag_cc_floor); +} + +static const struct log_info_cat log_categories[] = { +}; + +static const struct log_info log_info = { + .cat = log_categories, + .num_cat = ARRAY_SIZE(log_categories), +}; + +int main() +{ + void *ctx = talloc_named_const(NULL, 0, "time_cc_test"); + struct timespec *now; + struct my_obj my_obj = {0}; + + osmo_init_logging2(ctx, &log_info); + + /* enable override for CLOCK_MONOTONIC */ + osmo_clock_override_enable(CLOCK_MONOTONIC, true); + now = osmo_clock_override_gettimespec(CLOCK_MONOTONIC); + now->tv_sec = 23000; + now->tv_nsec = 0; + + /* enable override for osmo_gettimeofday(), for osmo_timer_schedule() */ + osmo_gettimeofday_override = true; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_ctrg = rate_ctr_group_alloc(ctx, &my_ctrg_desc, 0); + +#define CHECK_RATE_CTRS(exp_ceil, exp_round, exp_floor) do { \ + printf("%d CHECK_RATE_CTRS(" #exp_ceil ", " #exp_round ", " #exp_floor ")", \ + my_obj.flag_cc_round.flag_state); \ + while (osmo_select_main_ctx(1) > 0); \ + if (exp_ceil != my_obj.flag_cc_ceil.cfg.rate_ctr->current \ + || exp_round != my_obj.flag_cc_round.cfg.rate_ctr->current \ + || exp_floor != my_obj.flag_cc_floor.cfg.rate_ctr->current) \ + printf("\n ERROR on line %d: ctr_ceil=%"PRIu64" ctr_round=%"PRIu64" ctr_floor=%"PRIu64"\n", \ + __LINE__, \ + my_obj.flag_cc_ceil.cfg.rate_ctr->current, \ + my_obj.flag_cc_round.cfg.rate_ctr->current, \ + my_obj.flag_cc_floor.cfg.rate_ctr->current); \ + else \ + printf(" ok\n"); \ + } while (0) + +#define ADD_MILLISECS_NO_SELECT(ms) do { \ + osmo_clock_override_add(CLOCK_MONOTONIC, ms / 1000, (uint64_t)(ms % 1000) * 1000000); \ + osmo_gettimeofday_override_add(ms / 1000, (uint64_t)(ms % 1000) * 1000); \ + printf("%d ADD_MILLISECS(" #ms ") --> %ld.%03ld", my_obj.flag_cc_round.flag_state, \ + now->tv_sec, now->tv_nsec/1000000); \ + printf("\n"); \ + } while (0) + +#define ADD_MILLISECS(ms) do { \ + ADD_MILLISECS_NO_SELECT(ms); \ + while (osmo_select_main_ctx(1) > 0); \ + } while (0) + +#define FLAG(VAL) do { \ + printf(" flag: %s -> %s\n", my_obj.flag_cc_round.flag_state ? "TRUE" : "FALSE", VAL ? "TRUE" : "FALSE"); \ + my_obj_event(&my_obj, VAL); \ + } while (0) + + /* + * sum ^ + * | ________ + * | / + * | / + * | / + * 3*gran --+--------------------------------------+ + * | /: + * | / : + * | - - - - - - - - - - - - - - - - - / : + * | /. : + * | / . : + * 2*gran --+--------------------------------+ . : + * | /: . : + * | / : . : + * | - - - - - - - - - -_________/ : . : + * | / . : . : + * | / . : . : + * 1*gran --+-----------------+ . : . : + * | /: . : . : + * | / : . : . : + * | - - - - - - -/ : . : . : + * | /. : . : . : + * | ....-------' . : . : . : + * 0 +----------------------------------------------------------> elapsed time + * . : . : . : + * _ _ _______ ____________ + * flag: __| |_| |____| . : |_______|. : . : |__________ + * f t f t f t . : f t. : . : f + * round_threshold_usec : . : . : . : + * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" + * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" + * = gran_usec: 0 1 2 3 = "floor()" + */ + + printf("\n----------- cumulating time, without forget_sum\n\n"); + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.001s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(99); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(100); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(100); + /* flag has been true for 0.2s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(300); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(299); + /* flag has been true for 0.499s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.5s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(499); + /* flag has been true for 0.999s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(1); + /* flag has been true for 1.0s */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* flag has been true for 1.001s */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(299); + /* flag has been true for 1.3s */ + CHECK_RATE_CTRS(2, 1, 1); + FLAG(false); + CHECK_RATE_CTRS(2, 1, 1); + + ADD_MILLISECS(400); + + CHECK_RATE_CTRS(2, 1, 1); + FLAG(true); + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(199); + /* flag has been true for 1.499s */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(2); + /* flag has been true for 1.501s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(498); + /* flag has been true for 1.999s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(2); + /* flag has been true for 2.001s */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(500); + /* flag has been true for 2.501s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(498); + /* flag has been true for 2.999s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(3); + /* flag has been true for 3.003s */ + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(200); + /* flag has been true for 3.203s */ + CHECK_RATE_CTRS(4, 3, 3); + FLAG(false); + CHECK_RATE_CTRS(4, 3, 3); + + ADD_MILLISECS(4321); + CHECK_RATE_CTRS(4, 3, 3); + + FLAG(true); + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(5678); + CHECK_RATE_CTRS(9, 9, 8); + FLAG(false); + CHECK_RATE_CTRS(9, 9, 8); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + printf("\n----------- test forget_sum_usec\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); + + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(1000); + /* 1 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(8999); + /* 9.999 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(1); + /* 10 s of being false, forget_sum_usec has occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* Since previous sums were forgotton, ceil() triggers again */ + CHECK_RATE_CTRS(2, 0, 0); + /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify + * that this does not occur, since now full 500 ms are required */ + ADD_MILLISECS(399); + CHECK_RATE_CTRS(2, 0, 0); + /* Adding another 100 ms will trigger round() */ + ADD_MILLISECS(99); + CHECK_RATE_CTRS(2, 0, 0); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(2, 1, 0); + /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify + * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ + ADD_MILLISECS(400); + CHECK_RATE_CTRS(2, 1, 0); + /* Adding another 100 ms will trigger floor() */ + ADD_MILLISECS(99); + CHECK_RATE_CTRS(2, 1, 0); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(2, 1, 1); + + /* Test that durations of false below forget_sum_usec never trigger a forget */ + ADD_MILLISECS(300); + CHECK_RATE_CTRS(3, 1, 1); + /* internal counter is now at 0.3s above the last reported rate counter */ + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + /* internal counter is now at 0.4s above the last reported rate counter */ + CHECK_RATE_CTRS(3, 1, 1); + ADD_MILLISECS(100); + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS(500); + CHECK_RATE_CTRS(3, 2, 2); + + /* Test that repeated time_cc_set_flag(false) does not cancel a forget_sum_usec */ + ADD_MILLISECS(300); + /* internal counter is now at 0.3s above the last reported rate counter */ + CHECK_RATE_CTRS(4, 2, 2); + FLAG(false); + ADD_MILLISECS(5000); + /* Repeat 'false', must not affect forget_sum_usec */ + FLAG(false); + ADD_MILLISECS(5000); + CHECK_RATE_CTRS(4, 2, 2); + /* 10 s have passed, forget_sum_usec has occurred. + * Hence ceil() will trigger again right away: */ + FLAG(true); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 2, 2); + /* Adding 200 ms to the initial 300 ms would have triggered round(), but no more after forget_sum_usec */ + ADD_MILLISECS(199); + CHECK_RATE_CTRS(5, 2, 2); + /* Adding another 300 ms will trigger round() */ + ADD_MILLISECS(299); + CHECK_RATE_CTRS(5, 2, 2); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 3, 2); + /* Adding 700 ms to the initial 300 ms would have triggered ceil(), but no more after forget_sum_usec */ + ADD_MILLISECS(200); + CHECK_RATE_CTRS(5, 3, 2); + /* Adding another 300 ms will trigger ceil() */ + ADD_MILLISECS(299); + CHECK_RATE_CTRS(5, 3, 2); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 3, 3); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + + /* Verify correctness when select() lags and runs timer callbacks too late */ + printf("\n----------- cumulating time, without forget_sum, when timer cb are invoked late\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 0, OSMO_TDEF_S); + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS_NO_SELECT(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(100); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.2s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(300); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(799); + /* flag has been true for 0.999s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 1.0s */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS_NO_SELECT(300); + /* flag has been true for 1.3s */ + CHECK_RATE_CTRS(2, 1, 1); + FLAG(false); + CHECK_RATE_CTRS(2, 1, 1); + + ADD_MILLISECS_NO_SELECT(400); + + CHECK_RATE_CTRS(2, 1, 1); + FLAG(true); + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS_NO_SELECT(699); + /* flag has been true for 1.999s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 2.0s */ + CHECK_RATE_CTRS(2, 2, 2); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 2.001s */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS_NO_SELECT(499); + /* flag has been true for 2.5s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS_NO_SELECT(499); + /* flag has been true for 2.999s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 3.0s */ + CHECK_RATE_CTRS(3, 3, 3); + ADD_MILLISECS_NO_SELECT(200); + /* flag has been true for 3.2s */ + CHECK_RATE_CTRS(4, 3, 3); + FLAG(false); + CHECK_RATE_CTRS(4, 3, 3); + + ADD_MILLISECS_NO_SELECT(4321); + CHECK_RATE_CTRS(4, 3, 3); + + FLAG(true); + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS_NO_SELECT(5678); + CHECK_RATE_CTRS(9, 9, 8); + FLAG(false); + CHECK_RATE_CTRS(9, 9, 8); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + + printf("\n----------- test forget_sum, when timer cb are invoked late\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); + + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(1000); + /* 1 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(8999); + /* 9.999 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(1); + /* 10 s of being false, forget_sum_usec has occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(1); + /* Since previous sums were forgotton, ceil() triggers again */ + CHECK_RATE_CTRS(2, 0, 0); + /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify + * that this does not occur, since now full 500 ms are required */ + ADD_MILLISECS_NO_SELECT(399); + CHECK_RATE_CTRS(2, 0, 0); + /* Adding another 100 ms will trigger round() */ + ADD_MILLISECS_NO_SELECT(99); + CHECK_RATE_CTRS(2, 0, 0); + ADD_MILLISECS_NO_SELECT(1); + CHECK_RATE_CTRS(2, 1, 0); + /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify + * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ + ADD_MILLISECS_NO_SELECT(400); + CHECK_RATE_CTRS(2, 1, 0); + /* Adding another 100 ms will trigger floor() */ + ADD_MILLISECS_NO_SELECT(99); + CHECK_RATE_CTRS(2, 1, 0); + ADD_MILLISECS_NO_SELECT(1); + CHECK_RATE_CTRS(2, 1, 1); + + /* Test that durations of false below forget_sum_usec never trigger a forget */ + ADD_MILLISECS_NO_SELECT(300); + CHECK_RATE_CTRS(3, 1, 1); + /* internal counter is now at 0.3s above the last reported rate counter */ + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + /* internal counter is now at 0.4s above the last reported rate counter */ + CHECK_RATE_CTRS(3, 1, 1); + ADD_MILLISECS_NO_SELECT(100); + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS_NO_SELECT(500); + CHECK_RATE_CTRS(3, 2, 2); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + +#define SET_TDEFS(gran, round_thresh, forget_sum) do { \ + osmo_tdef_set(g_my_obj_tdefs, T_GRAN, gran, OSMO_TDEF_MS); \ + osmo_tdef_set(g_my_obj_tdefs, T_ROUND_THRESH, round_thresh, OSMO_TDEF_MS); \ + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, forget_sum, OSMO_TDEF_S); \ + printf("T_defs: T_gran=%luusec T_round_threshold=%luusec T_forget_sum=%luusec\n", \ + osmo_tdef_get(g_my_obj_tdefs, T_GRAN, OSMO_TDEF_US, -1), \ + osmo_tdef_get(g_my_obj_tdefs, T_ROUND_THRESH, OSMO_TDEF_US, -1), \ + osmo_tdef_get(g_my_obj_tdefs, T_FORGET_SUM, OSMO_TDEF_US, -1)); \ + } while (0) + + printf("\n----------- test T_defs\n\n"); + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + SET_TDEFS(100, 10, 0); + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(9); + /* flag has been true for 0.009s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.010s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(90); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 1, 1); + + SET_TDEFS(200, 190, 1); + /* gran is changed to 200ms, but still continues until the next scheduled event until the change is picked up. + * For ceil(), it is 1 ms ahead. + * For round(), it is 10 ms ahead. + * For floor(), it is at the next full (previous) gran 100 ms ahead. + * When T_defs change, all internal sums are reset to zero without reporting. + */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* 1ms elapsed: ceil() picks up the T_gran change, starts anew. */ + /* elapsed: ceil 0 ms */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 1 ms */ + /* ceil() increments because flag has been true for more than 1 us after reset */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(8); + /* 10 ms elapsed: round() picks up the T_gran change, starts anew */ + /* elapsed: ceil 9 ms, round 0 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(90); + /* 100 ms elapsed: floor() picks up the T_gran change, starts anew */ + /* elapsed: ceil 99 ms, round 90 ms, floor 0 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(99); + /* elapsed: ceil 198 ms, round 189 ms, floor 99 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 199 ms, round 190 ms, floor 100 ms */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 200 ms, round 191 ms, floor 101 ms */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 201 ms, round 192 ms, floor 102 ms */ + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS(98); + /* elapsed: ceil 299 ms, round 290 ms, floor 200 ms */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(99); + /* elapsed: ceil 398 ms, round 389 ms, floor 299 ms */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 399 ms, round 390 ms, floor 300 ms */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 400 ms, round 391 ms, floor 301 ms */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 401 ms, round 392 ms, floor 302 ms */ + CHECK_RATE_CTRS(4, 3, 2); + ADD_MILLISECS(98); + /* elapsed: ceil 499 ms, round 490 ms, floor 400 ms */ + CHECK_RATE_CTRS(4, 3, 3); + + + SET_TDEFS(100, 0, 0); + /* T_defs change, but they only get picked up upon the next event: + * For ceil(), it is 102 ms ahead. + * For round(), it is 100 ms ahead (thresh is still 190, currently at 90). + * For floor(), it is 200 ms ahead. + * When T_defs change, all internal sums are reset to zero without reporting. + */ + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(100); + CHECK_RATE_CTRS(4, 3, 3); + /* round() picks up the new T_defs. Internal sum resets, nothing else happens yet. + * round() schedules the next event 50 ms ahead. */ + ADD_MILLISECS(2); + CHECK_RATE_CTRS(4, 3, 3); + /* ceil() picks up the change, its next event is 1 ms ahead. */ + ADD_MILLISECS(1); + /* ceil: 0.001 + * round: 0.003 + * floor: still 97 ms until it picks up the change */ + CHECK_RATE_CTRS(5, 3, 3); + ADD_MILLISECS(46); + CHECK_RATE_CTRS(5, 3, 3); + ADD_MILLISECS(1); + /* round() has first counter trigger after T_defs change. */ + CHECK_RATE_CTRS(5, 4, 3); + /* ceil: 0.048 + * round: 0.050 + * floor: still 50 ms until it picks up the change */ + ADD_MILLISECS(50); + /* floor() picks up the change. nothing happens yet. */ + /* ceil: 0.098 + * round: 0.100 + * floor: 0.0 */ + ADD_MILLISECS(2); + /* ceil: 0.100 + * round: 0.102 + * floor: 0.002 */ + CHECK_RATE_CTRS(5, 4, 3); + ADD_MILLISECS(1); + /* ceil: 0.101 + * round: 0.103 + * floor: 0.003 */ + CHECK_RATE_CTRS(6, 4, 3); + ADD_MILLISECS(46); + /* ceil: 0.147 + * round: 0.149 + * floor: 0.049 */ + CHECK_RATE_CTRS(6, 4, 3); + ADD_MILLISECS(1); + /* ceil: 0.148 + * round: 0.150 + * floor: 0.050 */ + CHECK_RATE_CTRS(6, 5, 3); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + return 0; +} diff --git a/tests/time_cc/time_cc_test.ok b/tests/time_cc/time_cc_test.ok new file mode 100644 index 0000000..ccf84d9 --- /dev/null +++ b/tests/time_cc/time_cc_test.ok @@ -0,0 +1,328 @@ + +----------- cumulating time, without forget_sum + +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(1) --> 23000.101 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(99) --> 23000.200 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.300 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.400 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(300) --> 23000.700 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(299) --> 23000.999 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23001.000 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(499) --> 23001.499 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(1) --> 23001.500 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23001.501 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(299) --> 23001.800 +1 CHECK_RATE_CTRS(2, 1, 1) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(2, 1, 1) ok +0 ADD_MILLISECS(400) --> 23002.200 +0 CHECK_RATE_CTRS(2, 1, 1) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(199) --> 23002.399 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(2) --> 23002.401 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(498) --> 23002.899 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(2) --> 23002.901 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(500) --> 23003.401 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(498) --> 23003.899 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(3) --> 23003.902 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(200) --> 23004.102 +1 CHECK_RATE_CTRS(4, 3, 3) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(4, 3, 3) ok +0 ADD_MILLISECS(4321) --> 23008.423 +0 CHECK_RATE_CTRS(4, 3, 3) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(5678) --> 23014.101 +1 CHECK_RATE_CTRS(9, 9, 8) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(9, 9, 8) ok + +----------- test forget_sum_usec + +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.100 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1000) --> 23001.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(8999) --> 23010.099 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1) --> 23010.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.101 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(399) --> 23010.500 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(99) --> 23010.599 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.600 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(400) --> 23011.000 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(99) --> 23011.099 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(1) --> 23011.100 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(300) --> 23011.400 +1 CHECK_RATE_CTRS(3, 1, 1) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23021.399 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23021.424 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23031.423 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23031.448 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23041.447 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23041.472 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23051.471 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23051.496 +1 CHECK_RATE_CTRS(3, 1, 1) ok +1 ADD_MILLISECS(100) --> 23051.596 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(500) --> 23052.096 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(300) --> 23052.396 +1 CHECK_RATE_CTRS(4, 2, 2) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(5000) --> 23057.396 + flag: FALSE -> FALSE +0 ADD_MILLISECS(5000) --> 23062.396 +0 CHECK_RATE_CTRS(4, 2, 2) ok + flag: FALSE -> TRUE +1 ADD_MILLISECS(1) --> 23062.397 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(199) --> 23062.596 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(299) --> 23062.895 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(1) --> 23062.896 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(200) --> 23063.096 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(299) --> 23063.395 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(1) --> 23063.396 +1 CHECK_RATE_CTRS(5, 3, 3) ok + +----------- cumulating time, without forget_sum, when timer cb are invoked late + +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.200 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.300 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.400 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(300) --> 23000.700 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(799) --> 23001.499 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(1) --> 23001.500 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(300) --> 23001.800 +1 CHECK_RATE_CTRS(2, 1, 1) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(2, 1, 1) ok +0 ADD_MILLISECS(400) --> 23002.200 +0 CHECK_RATE_CTRS(2, 1, 1) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(699) --> 23002.899 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23002.900 +1 CHECK_RATE_CTRS(2, 2, 2) ok +1 ADD_MILLISECS(1) --> 23002.901 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(499) --> 23003.400 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(499) --> 23003.899 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23003.900 +1 CHECK_RATE_CTRS(3, 3, 3) ok +1 ADD_MILLISECS(200) --> 23004.100 +1 CHECK_RATE_CTRS(4, 3, 3) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(4, 3, 3) ok +0 ADD_MILLISECS(4321) --> 23008.421 +0 CHECK_RATE_CTRS(4, 3, 3) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(5678) --> 23014.099 +1 CHECK_RATE_CTRS(9, 9, 8) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(9, 9, 8) ok + +----------- test forget_sum, when timer cb are invoked late + +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.100 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1000) --> 23001.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(8999) --> 23010.099 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1) --> 23010.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.101 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(399) --> 23010.500 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(99) --> 23010.599 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.600 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(400) --> 23011.000 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(99) --> 23011.099 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(1) --> 23011.100 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(300) --> 23011.400 +1 CHECK_RATE_CTRS(3, 1, 1) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23021.399 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23021.424 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23031.423 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23031.448 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23041.447 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23041.472 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23051.471 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23051.496 +1 CHECK_RATE_CTRS(3, 1, 1) ok +1 ADD_MILLISECS(100) --> 23051.596 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(500) --> 23052.096 +1 CHECK_RATE_CTRS(3, 2, 2) ok + +----------- test T_defs + +T_defs: T_gran=100000usec T_round_threshold=10000usec T_forget_sum=0usec +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(9) --> 23000.109 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23000.110 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(90) --> 23000.200 +1 CHECK_RATE_CTRS(1, 1, 1) ok +T_defs: T_gran=200000usec T_round_threshold=190000usec T_forget_sum=1000000usec +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.201 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.202 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(8) --> 23000.210 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(90) --> 23000.300 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(99) --> 23000.399 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.400 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23000.401 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23000.402 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(98) --> 23000.500 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(99) --> 23000.599 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(1) --> 23000.600 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23000.601 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23000.602 +1 CHECK_RATE_CTRS(4, 3, 2) ok +1 ADD_MILLISECS(98) --> 23000.700 +1 CHECK_RATE_CTRS(4, 3, 3) ok +T_defs: T_gran=100000usec T_round_threshold=0usec T_forget_sum=0usec +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(100) --> 23000.800 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(2) --> 23000.802 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(1) --> 23000.803 +1 CHECK_RATE_CTRS(5, 3, 3) ok +1 ADD_MILLISECS(46) --> 23000.849 +1 CHECK_RATE_CTRS(5, 3, 3) ok +1 ADD_MILLISECS(1) --> 23000.850 +1 CHECK_RATE_CTRS(5, 4, 3) ok +1 ADD_MILLISECS(50) --> 23000.900 +1 ADD_MILLISECS(2) --> 23000.902 +1 CHECK_RATE_CTRS(5, 4, 3) ok +1 ADD_MILLISECS(1) --> 23000.903 +1 CHECK_RATE_CTRS(6, 4, 3) ok +1 ADD_MILLISECS(46) --> 23000.949 +1 CHECK_RATE_CTRS(6, 4, 3) ok +1 ADD_MILLISECS(1) --> 23000.950 +1 CHECK_RATE_CTRS(6, 5, 3) ok -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 9 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:27:45 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:27:45 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{sdcch, tch} rate counters In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25974 ) Change subject: implement all_allocated:{sdcch,tch} rate counters ...................................................................... implement all_allocated:{sdcch,tch} rate counters Based on allAvailable{SDCCH,TCH}Allocated performance indicators, see 3GPP TS 52.402. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c M src/osmo-bsc/net_init.c M tests/timer.vty 9 files changed, 137 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bsc_stats.h b/include/osmocom/bsc/bsc_stats.h index 4250079..9a2f36c 100644 --- a/include/osmocom/bsc/bsc_stats.h +++ b/include/osmocom/bsc/bsc_stats.h @@ -81,6 +81,8 @@ BSC_CTR_MSCPOOL_SUBSCR_NO_MSC, BSC_CTR_MSCPOOL_EMERG_FORWARDED, BSC_CTR_MSCPOOL_EMERG_LOST, + BSC_CTR_ALL_ALLOCATED_SDCCH, + BSC_CTR_ALL_ALLOCATED_TCH, }; extern const struct rate_ctr_desc bsc_ctr_description[]; @@ -105,3 +107,4 @@ extern const struct osmo_stat_item_group_desc bsc_statg_desc; void bsc_update_connection_stats(struct gsm_network *net); +void bsc_update_time_cc_all_allocated(struct gsm_network *net); diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index c887ca8..8677143 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -158,6 +158,8 @@ BTS_CTR_SRVCC_TIMEOUT, BTS_CTR_SRVCC_FAILED, BTS_CTR_SRVCC_ERROR, + BTS_CTR_ALL_ALLOCATED_SDCCH, + BTS_CTR_ALL_ALLOCATED_TCH, }; extern const struct rate_ctr_desc bts_ctr_description[]; @@ -590,6 +592,9 @@ /* At what point in the channel allocation sequence to dispatch the Immediate Assignment (Abis optimization) */ enum imm_ass_time imm_ass_time; + + struct time_cc all_allocated_sdcch; + struct time_cc all_allocated_tch; }; #define GSM_BTS_SI2Q(bts, i) (struct gsm48_system_information_type_2quater *)((bts)->si_buf[SYSINFO_TYPE_2quater][i]) diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 6a60f06..30aab53 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -32,6 +32,7 @@ #include #include #include +#include #define GSM_T3122_DEFAULT 10 @@ -1260,6 +1261,9 @@ struct osmo_nri_ranges *null_nri_ranges; struct smlc_config *smlc; + + struct time_cc all_allocated_sdcch; + struct time_cc all_allocated_tch; }; struct gsm_audio_support { diff --git a/src/osmo-bsc/bsc_init.c b/src/osmo-bsc/bsc_init.c index bf150cb..11cda69 100644 --- a/src/osmo-bsc/bsc_init.c +++ b/src/osmo-bsc/bsc_init.c @@ -120,6 +120,29 @@ if (!net->bts_unknown_statg) goto err_free_all; + net->all_allocated_sdcch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(net->bsc_ctrs, BSC_CTR_ALL_ALLOCATED_SDCCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; + net->all_allocated_tch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(net->bsc_ctrs, BSC_CTR_ALL_ALLOCATED_TCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; + INIT_LLIST_HEAD(&net->bts_rejected); gsm_net_update_ctype(net); diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index ccba4a6..20ddd37 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -25,6 +25,7 @@ #include #include +#include const struct rate_ctr_desc bsc_ctr_description[] = { [BSC_CTR_ASSIGNMENT_ATTEMPTED] = {"assignment:attempted", "Assignment attempts"}, @@ -102,6 +103,8 @@ "Emergency call requests forwarded to an MSC (see also per-MSC counters"}, [BSC_CTR_MSCPOOL_EMERG_LOST] = {"mscpool:emerg:lost", "Emergency call requests lost because no MSC was found available"}, + [BSC_CTR_ALL_ALLOCATED_SDCCH] = {"all_allocated:sdcch", "Cumulative counter of seconds where all SDCCH channels were allocated"}, + [BSC_CTR_ALL_ALLOCATED_TCH] = {"all_allocated:tch", "Cumulative counter of seconds where all TCH channels were allocated"}, }; const struct rate_ctr_group_desc bsc_ctrg_desc = { @@ -185,4 +188,49 @@ osmo_stat_item_set(osmo_stat_item_group_get_item(net->bsc_statg, BSC_STAT_NUM_TRX_RSL_CONNECTED), trx_rsl_connected_total); osmo_stat_item_set(osmo_stat_item_group_get_item(net->bsc_statg, BSC_STAT_NUM_TRX_TOTAL), num_trx_total); + + /* Make sure to notice cells that become disconnected */ + bsc_update_time_cc_all_allocated(net); +} + +void bsc_update_time_cc_all_allocated(struct gsm_network *net) +{ + struct gsm_bts *bts; + struct gsm_bts_trx *trx; + + struct chan_counts bsc_counts; + chan_counts_zero(&bsc_counts); + + llist_for_each_entry(bts, &net->bts_list, list) { + struct chan_counts bts_counts; + chan_counts_zero(&bts_counts); + + llist_for_each_entry(trx, &bts->trx_list, list) { + struct chan_counts trx_counts; + chan_counts_for_trx(&trx_counts, trx); + chan_counts_add(&bts_counts, &trx_counts); + } + + time_cc_set_flag(&bts->all_allocated_sdcch, + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + + time_cc_set_flag(&bts->all_allocated_tch, + (bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + + chan_counts_add(&bsc_counts, &bts_counts); + } + + time_cc_set_flag(&net->all_allocated_sdcch, + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + + time_cc_set_flag(&net->all_allocated_tch, + (bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); } diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 5701957..880cb22 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -211,6 +211,29 @@ } bts->bts_statg = osmo_stat_item_group_alloc(bts, &bts_statg_desc, bts->nr); + bts->all_allocated_sdcch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_ALL_ALLOCATED_SDCCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; + bts->all_allocated_tch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_ALL_ALLOCATED_TCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; + /* create our primary TRX */ bts->c0 = gsm_bts_trx_alloc(bts); if (!bts->c0) { @@ -1236,6 +1259,12 @@ [BTS_CTR_SRVCC_ERROR] = \ { "srvcc:error", "Re-assignment failed for other reason" }, + [BTS_CTR_ALL_ALLOCATED_SDCCH] = \ + { "all_allocated:sdcch", + "Cumulative counter of seconds where all SDCCH channels were allocated" }, + [BTS_CTR_ALL_ALLOCATED_TCH] = \ + { "all_allocated:tch", + "Cumulative counter of seconds where all TCH channels were allocated" }, }; const struct rate_ctr_group_desc bts_ctrg_desc = { diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index d61d032..5ae6df6 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -40,6 +40,7 @@ #include #include #include +#include static struct osmo_fsm lchan_fsm; @@ -517,6 +518,8 @@ lchan_reset(lchan); osmo_fsm_inst_dispatch(lchan->ts->fi, TS_EV_LCHAN_UNUSED, lchan); + bsc_update_time_cc_all_allocated(bts->network); + /* Poll the channel request queue, so that waiting calls can make use of the lchan that just * has become unused now. */ abis_rsl_chan_rqd_queue_poll(bts); @@ -697,6 +700,8 @@ return; } + bsc_update_time_cc_all_allocated(bts->network); + lchan->conn = info->for_conn; /* If there is a previous lchan, and the new lchan is on the same cell as previous one, diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c index 6d88adb..ec2f881 100644 --- a/src/osmo-bsc/net_init.c +++ b/src/osmo-bsc/net_init.c @@ -56,6 +56,20 @@ { .T=-12, .default_val=5, .desc="Timeout for obtaining TA after BSSLAP TA Request" }, { .T=-13, .default_val=5, .desc="Timeout for RR Channel Mode Modify ACK (BSC <-> MS)" }, { .T=-14, .default_val=5, .desc="Timeout for RSL Channel Mode Modify ACK (BSC <-> BTS)" }, + { .T = -16, .default_val = 1000, .unit = OSMO_TDEF_MS, + .desc = "Granularity for all_allocated:* rate counters: amount of milliseconds that one counter increment" + " represents. See also X17, X18" }, + { .T = -17, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "Rounding threshold for all_allocated:* rate counters: round up to the next counter increment" + " after this many milliseconds. If set to half of X16 (or 0), employ the usual round() behavior:" + " round up after half of a granularity period. If set to 1, behave like ceil(): already" + " increment the counter immediately when all channels are allocated. If set >= X16, behave like" + " floor(): only increment after a full X16 period of all channels being occupied." + " See also X16, X18" }, + { .T = -18, .default_val = 60000, .unit = OSMO_TDEF_MS, + .desc = "Forget-sum period for all_allocated:* rate counters:" + " after this amount of idle time, forget internally cumulated time remainders. Zero to always" + " keep remainders. See also X16, X17." }, { .T=-3111, .default_val=4, .desc="Wait time after lchan was released in error (should be T3111 + 2s)" }, { .T=-3210, .default_val=20, .desc="After L3 Complete, wait for MSC to confirm" }, {} diff --git a/tests/timer.vty b/tests/timer.vty index 71dd2c1..12c13ad 100644 --- a/tests/timer.vty +++ b/tests/timer.vty @@ -29,6 +29,9 @@ net: X12 = 5 s Timeout for obtaining TA after BSSLAP TA Request (default: 5 s) net: X13 = 5 s Timeout for RR Channel Mode Modify ACK (BSC <-> MS) (default: 5 s) net: X14 = 5 s Timeout for RSL Channel Mode Modify ACK (BSC <-> BTS) (default: 5 s) +net: X16 = 1000 ms Granularity for all_allocated:* rate counters: amount of milliseconds that one counter increment represents. See also X17, X18 (default: 1000 ms) +net: X17 = 0 ms Rounding threshold for all_allocated:* rate counters: round up to the next counter increment after this many milliseconds. If set to half of X16 (or 0), employ the usual round() behavior: round up after half of a granularity period. If set to 1, behave like ceil(): already increment the counter immediately when all channels are allocated. If set >= X16, behave like floor(): only increment after a full X16 period of all channels being occupied. See also X16, X18 (default: 0 ms) +net: X18 = 60000 ms Forget-sum period for all_allocated:* rate counters: after this amount of idle time, forget internally cumulated time remainders. Zero to always keep remainders. See also X16, X17. (default: 60000 ms) net: X3111 = 4 s Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s) net: X3210 = 20 s After L3 Complete, wait for MSC to confirm (default: 20 s) mgw: X2427 = 5 s timeout for MGCP response from MGW (default: 5 s) @@ -78,6 +81,9 @@ net: X12 = 5 s Timeout for obtaining TA after BSSLAP TA Request (default: 5 s) net: X13 = 5 s Timeout for RR Channel Mode Modify ACK (BSC <-> MS) (default: 5 s) net: X14 = 5 s Timeout for RSL Channel Mode Modify ACK (BSC <-> BTS) (default: 5 s) +net: X16 = 1000 ms Granularity for all_allocated:* rate counters: amount of milliseconds that one counter increment represents. See also X17, X18 (default: 1000 ms) +net: X17 = 0 ms Rounding threshold for all_allocated:* rate counters: round up to the next counter increment after this many milliseconds. If set to half of X16 (or 0), employ the usual round() behavior: round up after half of a granularity period. If set to 1, behave like ceil(): already increment the counter immediately when all channels are allocated. If set >= X16, behave like floor(): only increment after a full X16 period of all channels being occupied. See also X16, X18 (default: 0 ms) +net: X18 = 60000 ms Forget-sum period for all_allocated:* rate counters: after this amount of idle time, forget internally cumulated time remainders. Zero to always keep remainders. See also X16, X17. (default: 60000 ms) net: X3111 = 4 s Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s) net: X3210 = 20 s After L3 Complete, wait for MSC to confirm (default: 20 s) mgw: X2427 = 5 s timeout for MGCP response from MGW (default: 5 s) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b06e435a224c8708cd6c67e97ee5413718fc1ed Gerrit-Change-Number: 25974 Gerrit-PatchSet: 12 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:27:45 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:27:45 +0000 Subject: Change in osmo-bsc[master]: implement all_allocated:{static_sdcch, static_tch} rate counters In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25975 ) Change subject: implement all_allocated:{static_sdcch,static_tch} rate counters ...................................................................... implement all_allocated:{static_sdcch,static_tch} rate counters Same as all_allocated:{sdcch,tch}, but already trigger when all non-dynamic timeslots are allocated. Related: SYS#4878 Related: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 (osmo-ttcn3-hacks) Change-Id: I2fa14531f16d3f07085620f1c50eb839c420da6a --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c 6 files changed, 82 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bsc_stats.h b/include/osmocom/bsc/bsc_stats.h index 9a2f36c..9140f85 100644 --- a/include/osmocom/bsc/bsc_stats.h +++ b/include/osmocom/bsc/bsc_stats.h @@ -82,7 +82,9 @@ BSC_CTR_MSCPOOL_EMERG_FORWARDED, BSC_CTR_MSCPOOL_EMERG_LOST, BSC_CTR_ALL_ALLOCATED_SDCCH, + BSC_CTR_ALL_ALLOCATED_STATIC_SDCCH, BSC_CTR_ALL_ALLOCATED_TCH, + BSC_CTR_ALL_ALLOCATED_STATIC_TCH, }; extern const struct rate_ctr_desc bsc_ctr_description[]; diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 8677143..9cf3fa4 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -159,7 +159,9 @@ BTS_CTR_SRVCC_FAILED, BTS_CTR_SRVCC_ERROR, BTS_CTR_ALL_ALLOCATED_SDCCH, + BTS_CTR_ALL_ALLOCATED_STATIC_SDCCH, BTS_CTR_ALL_ALLOCATED_TCH, + BTS_CTR_ALL_ALLOCATED_STATIC_TCH, }; extern const struct rate_ctr_desc bts_ctr_description[]; @@ -594,7 +596,9 @@ enum imm_ass_time imm_ass_time; struct time_cc all_allocated_sdcch; + struct time_cc all_allocated_static_sdcch; struct time_cc all_allocated_tch; + struct time_cc all_allocated_static_tch; }; #define GSM_BTS_SI2Q(bts, i) (struct gsm48_system_information_type_2quater *)((bts)->si_buf[SYSINFO_TYPE_2quater][i]) diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 30aab53..2823922 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1263,7 +1263,9 @@ struct smlc_config *smlc; struct time_cc all_allocated_sdcch; + struct time_cc all_allocated_static_sdcch; struct time_cc all_allocated_tch; + struct time_cc all_allocated_static_tch; }; struct gsm_audio_support { diff --git a/src/osmo-bsc/bsc_init.c b/src/osmo-bsc/bsc_init.c index 11cda69..9328707 100644 --- a/src/osmo-bsc/bsc_init.c +++ b/src/osmo-bsc/bsc_init.c @@ -131,6 +131,17 @@ .T_defs = net->T_defs, }, }; + net->all_allocated_static_sdcch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(net->bsc_ctrs, BSC_CTR_ALL_ALLOCATED_STATIC_SDCCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; net->all_allocated_tch = (struct time_cc){ .cfg = { .gran_usec = 1*1000000, @@ -142,6 +153,17 @@ .T_defs = net->T_defs, }, }; + net->all_allocated_static_tch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(net->bsc_ctrs, BSC_CTR_ALL_ALLOCATED_STATIC_TCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; INIT_LLIST_HEAD(&net->bts_rejected); gsm_net_update_ctype(net); diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index 20ddd37..0da3a6c 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -104,7 +104,11 @@ [BSC_CTR_MSCPOOL_EMERG_LOST] = {"mscpool:emerg:lost", "Emergency call requests lost because no MSC was found available"}, [BSC_CTR_ALL_ALLOCATED_SDCCH] = {"all_allocated:sdcch", "Cumulative counter of seconds where all SDCCH channels were allocated"}, + [BSC_CTR_ALL_ALLOCATED_STATIC_SDCCH] = {"all_allocated:static_sdcch", + "Cumulative counter of seconds where all non-dynamic SDCCH channels were allocated"}, [BSC_CTR_ALL_ALLOCATED_TCH] = {"all_allocated:tch", "Cumulative counter of seconds where all TCH channels were allocated"}, + [BSC_CTR_ALL_ALLOCATED_STATIC_TCH] = {"all_allocated:static_tch", + "Cumulative counter of seconds where all non-dynamic TCH channels were allocated"}, }; const struct rate_ctr_group_desc bsc_ctrg_desc = { @@ -215,12 +219,22 @@ bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] && !bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + time_cc_set_flag(&bts->all_allocated_static_sdcch, + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + time_cc_set_flag(&bts->all_allocated_tch, (bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) && !(bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + time_cc_set_flag(&bts->all_allocated_static_tch, + (bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + chan_counts_add(&bsc_counts, &bts_counts); } @@ -228,9 +242,19 @@ bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] && !bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + time_cc_set_flag(&net->all_allocated_static_sdcch, + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + time_cc_set_flag(&net->all_allocated_tch, (bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) && !(bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + + time_cc_set_flag(&net->all_allocated_static_tch, + (bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); } diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 880cb22..4dd05a9 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -222,6 +222,17 @@ .T_defs = net->T_defs, }, }; + bts->all_allocated_static_sdcch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_ALL_ALLOCATED_STATIC_SDCCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; bts->all_allocated_tch = (struct time_cc){ .cfg = { .gran_usec = 1*1000000, @@ -233,6 +244,17 @@ .T_defs = net->T_defs, }, }; + bts->all_allocated_static_tch = (struct time_cc){ + .cfg = { + .gran_usec = 1*1000000, + .forget_sum_usec = 60*1000000, + .rate_ctr = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_ALL_ALLOCATED_STATIC_TCH), + .T_gran = -16, + .T_round_threshold = -17, + .T_forget_sum = -18, + .T_defs = net->T_defs, + }, + }; /* create our primary TRX */ bts->c0 = gsm_bts_trx_alloc(bts); @@ -1262,9 +1284,15 @@ [BTS_CTR_ALL_ALLOCATED_SDCCH] = \ { "all_allocated:sdcch", "Cumulative counter of seconds where all SDCCH channels were allocated" }, + [BTS_CTR_ALL_ALLOCATED_STATIC_SDCCH] = \ + { "all_allocated:static_sdcch", + "Cumulative counter of seconds where all non-dynamic SDCCH channels were allocated" }, [BTS_CTR_ALL_ALLOCATED_TCH] = \ { "all_allocated:tch", "Cumulative counter of seconds where all TCH channels were allocated" }, + [BTS_CTR_ALL_ALLOCATED_STATIC_TCH] = \ + { "all_allocated:static_tch", + "Cumulative counter of seconds where all non-dynamic TCH channels were allocated" }, }; const struct rate_ctr_group_desc bts_ctrg_desc = { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fa14531f16d3f07085620f1c50eb839c420da6a Gerrit-Change-Number: 25975 Gerrit-PatchSet: 12 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:30:24 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:30:24 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 to look at the new patch set (#3). Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... implement bts.N.cm_serv_rej: rate counters Related: I0214b27da18af87eca9715ebf7eeeff945e3e12a (osmo-ttcn3-hacks) Related: SYS#4878 Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c 3 files changed, 202 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/26142/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:31:41 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:31:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add TC_ratectr_all_available_allocated and _dyn In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25969 ) Change subject: bsc: add TC_ratectr_all_available_allocated and _dyn ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 Gerrit-Change-Number: 25969 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:31:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:31:48 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:31:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add TC_ratectr_all_available_allocated and _dyn In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25969 ) Change subject: bsc: add TC_ratectr_all_available_allocated and _dyn ...................................................................... bsc: add TC_ratectr_all_available_allocated and _dyn Test new rate counters all_allocated:{sdcch,tch,static_sdcch,static_tch} Related: SYS#4878 Depends: I2fa14531f16d3f07085620f1c50eb839c420da6a (osmo-bsc) Change-Id: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 --- M bsc/BSC_Tests.ttcn M library/Osmocom_CTRL_Functions.ttcn 2 files changed, 234 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 833b6f9..6040a96 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1642,6 +1642,8 @@ RslChannelNr rsl_chan_nr } +type record of DchanTuple DchanTuples; + /* Send CHAN RQD and wait for allocation; acknowledge it */ private function f_chreq_act_ack(OCT1 ra := '23'O, GsmFrameNumber fn := 23) runs on test_CT return RslChannelNr { @@ -10393,6 +10395,156 @@ f_shutdown_helper(); } +const CounterNameVals counternames_bsc_bts_all_available_allocated := { + { "all_allocated:sdcch", 0 }, + { "all_allocated:static_sdcch", 0 }, + { "all_allocated:tch", 0 }, + { "all_allocated:static_tch", 0 } +} + +private function f_all_allocated_expect_counter_change(charstring_list expect_changed) runs on test_CT +{ + /* Make sure counters settle first */ + f_sleep(1.0); + + /* Take a baseline of counters */ + f_ctrs_bsc_and_bts_init(1, counternames_bsc_bts_all_available_allocated); + + /* Elapse some time so that we see changes in counters, hopefully where expected */ + f_sleep(2.0); + + /* Get new counters */ + var charstring_list all_changed := {}; + all_changed := all_changed & f_counter_name_vals_get_changed_n(IPA_CTRL, "bsc", g_ctr_bsc); + all_changed := all_changed & f_counter_name_vals_get_changed_n(IPA_CTRL, "bts", g_ctr_bts); + + /* Compare with expectations */ + var charstring_list all_expect_changed := {}; + for (var integer i := 0; i < lengthof(expect_changed); i := i + 1) { + all_expect_changed := all_expect_changed & { "bsc.0." & expect_changed[i], "bts.0." & expect_changed[i] }; + } + f_counter_name_vals_expect_changed_list(all_changed, all_expect_changed); +} + +testcase TC_ratectr_all_available_allocated() runs on test_CT { + var ASP_RSL_Unitdata rsl_ud; + var integer i; + var integer chreq_total, chreq_nochan; + + f_init(1); + f_sleep(1.0); + + /* Exhaust all dedicated SDCCH lchans. + /* GSM 44.018 Table 9.1.8.2: + * RA = '13'O -> Establishment cause = 0001xxxx (MS dual rate capable and asks for "SDCCH"). + */ + for (i := 0; i < NUM_SDCCH_PER_BTS; i := i+1) { + f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + } + + /* Since only bts 0 is connected, expecting all_allocated to become true for both bts 0 and the "global" bsc + * level. + * All SDCCH are now occupied. */ + f_all_allocated_expect_counter_change({"all_allocated:sdcch", "all_allocated:static_sdcch"}); + + /* Also fill up all remaining (TCH) channels */ + for (i := 0; i < NUM_TCHF_PER_BTS + NUM_TCHH_PER_BTS; i := i+1) { + f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + } + + /* All TCH are now also occupied */ + f_all_allocated_expect_counter_change({"all_allocated:sdcch", "all_allocated:static_sdcch", + "all_allocated:tch", "all_allocated:static_tch"}); + + f_shutdown_helper(); +} + +testcase TC_ratectr_all_available_allocated_dyn() runs on test_CT { + var ASP_RSL_Unitdata rsl_ud; + var integer i; + var integer chreq_total, chreq_nochan; + + f_init_vty(); + f_ts_set_chcomb(0, 0, 2, "TCH/F_TCH/H_PDCH"); + f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); + /* Now we have 3 TCH/F, 1 OSMO_DYN, 1 TCH/H */ + + f_init(1, guard_timeout := 60.0); + f_sleep(1.0); + + /* The dyn TS wants to activate PDCH mode, ACK that. */ + var RslChannelNr chan_nr; + chan_nr := valueof(t_RslChanNr_PDCH(2)); + f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342)); + + /* Exhaust all dedicated SDCCH lchans. + /* GSM 44.018 Table 9.1.8.2: + * RA = '13'O -> Establishment cause = 0001xxxx (MS dual rate capable and asks for "SDCCH"). + */ + for (i := 0; i < NUM_SDCCH_PER_BTS; i := i+1) { + f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + } + + /* The static SDCCH should now be occupied, while still 3x8 dynamic SDCCH potentially remain. So only + * all_allocated:static_sdcch is counted, all_allocated:sdcch remains zero. */ + f_all_allocated_expect_counter_change({"all_allocated:static_sdcch"}); + + /* Request more SDCCH, hence convert the first dyn TS to SDCCH8. + * Will release them later, so remember all the DchanTuples. */ + var DchanTuples dyn_sddch := {}; + dyn_sddch := dyn_sddch & { f_est_dchan_dyn('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; + + /* Also occupy the seven other SDCCH of the dyn TS */ + for (i := 0; i < 7; i := i+1) { + dyn_sddch := dyn_sddch & { f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; + } + + /* Now all dynamic SDCCH are also occupied, so for the first time all_allocated:sdcch will trigger... */ + f_all_allocated_expect_counter_change({"all_allocated:sdcch", "all_allocated:static_sdcch"}); + + /* occupy the remaining TCH, three TCH/F and two TCH/H lchans */ + for (i := 0; i < 5; i := i+1) { + f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + } + + /* All TCH lchans are now also occupied, both static and dynamic */ + f_all_allocated_expect_counter_change({"all_allocated:sdcch", "all_allocated:static_sdcch", + "all_allocated:tch", "all_allocated:static_tch"}); + + /* Starting to release the dyn TS: as soon as the first SDCCH gets released, all_allocated:sdcch stops + * incrementing. */ + var BssmapCause cause := 0; + var DchanTuple dt := dyn_sddch[0]; + BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSMAP_ClearCommand(cause))); + f_exp_chan_rel_and_clear(dt, 0); + + /* one dyn TS SDCCH is free again, so only the static_sdcch should increment. For tch, both static and dynamic + * count as occupied, so those still both increment. */ + f_all_allocated_expect_counter_change({"all_allocated:static_sdcch", + "all_allocated:tch", "all_allocated:static_tch"}); + + /* Release the remaining SDCCH of the dyn TS, so it becomes available as TCH again */ + for (i := 1; i < lengthof(dyn_sddch); i := i+1) { + dt := dyn_sddch[i]; + BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSMAP_ClearCommand(cause))); + f_exp_chan_rel_and_clear(dt, 0); + } + + /* All SDCCH on the dyn TS are released, the dyn TS wants to activate PDCH again */ + chan_nr := valueof(t_RslChanNr_PDCH(2)); + f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342)); + + /* Now all channels are occupied except the dyn TS, so expecting only the static counters to increment */ + f_all_allocated_expect_counter_change({"all_allocated:static_sdcch", "all_allocated:static_tch"}); + + /* clean up config */ + f_ts_reset_chcomb(0); + + f_shutdown_helper(); +} + control { /* CTRL interface testing */ execute( TC_ctrl_msc_connection_status() ); @@ -10702,6 +10854,9 @@ execute( TC_ctrl_trx_rf_locked() ); + execute( TC_ratectr_all_available_allocated() ); + execute( TC_ratectr_all_available_allocated_dyn() ); + execute( TC_lost_sdcch_during_assignment() ); } diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn index 8d5607b..2c90de4 100644 --- a/library/Osmocom_CTRL_Functions.ttcn +++ b/library/Osmocom_CTRL_Functions.ttcn @@ -23,6 +23,8 @@ import from Osmocom_CTRL_Types all; import from IPA_Emulation all; + type record of charstring charstring_list; + private function f_gen_rand_id() return CtrlId { return int2str(float2int(rnd()*999999999.0)); } @@ -289,4 +291,81 @@ } } + /* For a specific instance, call f_counter_name_vals_get() and indentify counters that have changed with respect + * to 'vals'. Return list of the changed counter names in the order they appear in 'vals'. */ + function f_counter_name_vals_get_changed(IPA_CTRL_PT pt, charstring instance_name, integer instance_nr, + CounterNameVals vals) + return charstring_list { + var charstring_list changed := {}; + var CounterNameVals last := f_counter_name_vals_get(pt, instance_name, instance_nr, vals); + for (var integer i := 0; i < lengthof(vals); i := i + 1) { + if (last[i].name != vals[i].name) { + setverdict(fail, "Internal error"); + } + if (last[i].val != vals[i].val) { + changed := changed & { instance_name & "." & int2str(instance_nr) & "." & vals[i].name }; + } + } + return changed; + } + + /* For N instances, call f_counter_name_vals_get() and indentify counters that have changed with respect + * to 'vals'. Return list of the changed counter names in the order they appear in 'vals'. */ + function f_counter_name_vals_get_changed_n(IPA_CTRL_PT pt, charstring instance_name, CounterNameValsList valslist) + return charstring_list { + var charstring_list changed := {}; + for (var integer instance_nr := 0; instance_nr < lengthof(valslist); instance_nr := instance_nr + 1) { + changed := changed & f_counter_name_vals_get_changed(pt, instance_name, instance_nr, valslist[instance_nr]); + } + return changed; + } + + function f_counter_name_vals_expect_changed(IPA_CTRL_PT pt, charstring instance_name, CounterNameValsList valslist, + charstring_list expect_changed) { + var charstring_list changed := f_counter_name_vals_get_changed_n(pt, instance_name, valslist); + f_counter_name_vals_expect_changed_list(changed, expect_changed); + } + + function f_counter_name_vals_expect_changed_list(charstring_list got_list, charstring_list expect_list) { + var charstring unexpected_change := ""; + for (var integer i := 0; i < lengthof(got_list); i := i + 1) { + var boolean found := false; + for (var integer j := 0; j < lengthof(expect_list); j := j + 1) { + if (got_list[i] == expect_list[j]) { + found := true; + break; + } + } + if (not found) { + unexpected_change := unexpected_change & " " & got_list[i]; + } + } + var charstring missing_change := ""; + for (var integer i := 0; i < lengthof(expect_list); i := i + 1) { + var boolean found := false; + for (var integer j := 0; j < lengthof(got_list); j := j + 1) { + if (expect_list[i] == got_list[j]) { + found := true; + break; + } + } + if (not found) { + missing_change := missing_change & " " & expect_list[i]; + } + } + var charstring diff := ""; + if (lengthof(unexpected_change) > 0) { + diff := diff & " Unexpected changes in" & unexpected_change & ";"; + } + if (lengthof(missing_change) > 0) { + diff := diff & " Missing changes in" & missing_change & ";"; + } + if (lengthof(diff) > 0) { + log("ERROR\nExpected: ", expect_list, "\nGot: ", got_list); + setverdict(fail, "Rate counters did not change as expected:" & diff); + } else { + setverdict(pass); + } + } + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3997a827c9cc43d1361bb0cf3bfab9f6d91bf82 Gerrit-Change-Number: 25969 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:33:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:33:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add test for CM Service Reject counter In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 to look at the new patch set (#2). Change subject: bsc: add test for CM Service Reject counter ...................................................................... bsc: add test for CM Service Reject counter Related: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b (osmo-bsc) Related: SYS#4878 Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a --- M bsc/BSC_Tests.ttcn M library/L3_Templates.ttcn 2 files changed, 82 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/26143/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a Gerrit-Change-Number: 26143 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:35:56 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:35:56 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add testing of incoming_intra_bsc_ho rate_ctrs In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 ) Change subject: bsc: add testing of incoming_intra_bsc_ho rate_ctrs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba229313d73fa20266f6d4eac5820579fb14c604 Gerrit-Change-Number: 26141 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:35:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:36:31 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:36:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add test for CM Service Reject counter In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 ) Change subject: bsc: add test for CM Service Reject counter ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a Gerrit-Change-Number: 26143 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 13:36:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:36:35 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:36:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add testing of incoming_intra_bsc_ho rate_ctrs In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 ) Change subject: bsc: add testing of incoming_intra_bsc_ho rate_ctrs ...................................................................... bsc: add testing of incoming_intra_bsc_ho rate_ctrs Related: SYS#4878 Related: Id9f2c6e2865ebe680879018fff08d283ce24c983 (osmo-bsc) Change-Id: Iba229313d73fa20266f6d4eac5820579fb14c604 --- M bsc/BSC_Tests.ttcn 1 file changed, 59 insertions(+), 22 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 6040a96..2fde8ae 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -170,6 +170,16 @@ { "interbsc_ho_in:error", 0 } }; +const CounterNameVals counternames_bts_handover := { + { "incoming_intra_bsc_ho:attempted", 0 }, + { "incoming_intra_bsc_ho:completed", 0 }, + { "incoming_intra_bsc_ho:stopped", 0 }, + { "incoming_intra_bsc_ho:no_channel", 0 }, + { "incoming_intra_bsc_ho:timeout", 0 }, + { "incoming_intra_bsc_ho:failed", 0 }, + { "incoming_intra_bsc_ho:error", 0 } +}; + /* Set of all System Information received during one RSL port's startup. * Note that some System Information may be sent on RSL, but lacking actual SI data, to indicate that the BTS should not * broadcast that SI type. That will be reflected as 'omit' here. @@ -762,8 +772,19 @@ f_ctrs_bsc_init(counternames); } -private function f_ctrs_bsc_and_bts_add(integer bts_nr, charstring countername, integer val := 1) runs on test_CT { +private function f_ctrs_bsc_and_bts_handover_init(integer bts_count := NUM_BTS) runs on test_CT { + var CounterNameVals bts_names := counternames_bsc_bts_handover & counternames_bts_handover; + g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, bts_names); + log("initial bts rate counters: ", g_ctr_bts); + f_ctrs_bsc_init(counternames_bsc_bts_handover); +} + +private function f_ctrs_bts_add(integer bts_nr, charstring countername, integer val := 1) runs on test_CT { f_counter_name_vals_list_add(g_ctr_bts, bts_nr, countername, val); +} + +private function f_ctrs_bsc_and_bts_add(integer bts_nr, charstring countername, integer val := 1) runs on test_CT { + f_ctrs_bts_add(bts_nr, countername, val); f_ctrs_bsc_add(countername, val); } @@ -5156,7 +5177,7 @@ pars.expect_tsc := BTS_TSC[0]; - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_int), pars); vc_conn.done; @@ -5169,6 +5190,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:completed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:completed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:completed"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); } @@ -5182,7 +5205,7 @@ f_vty_encryption_a5(enc_a5); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_int), pars); vc_conn.done; @@ -5195,6 +5218,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:completed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:completed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:completed"); f_ctrs_bsc_and_bts_verify(); f_vty_encryption_a5_reset(); f_shutdown_helper(); @@ -5302,7 +5327,7 @@ f_init(2, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_int_radio_link_failure)); vc_conn.done; @@ -5315,6 +5340,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:stopped"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:stopped"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:stopped"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); } @@ -5422,7 +5449,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_of_this_bsc)); vc_conn.done; @@ -5505,7 +5532,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_msc_response)); vc_conn.done; @@ -5586,7 +5613,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_fail_rr_ho_failure)); vc_conn.done; @@ -5686,7 +5713,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_result_after_ho_cmd)); vc_conn.done; @@ -5803,7 +5830,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -5905,7 +5932,7 @@ } f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.last_used_eutran_plmn := '323454'O; pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; @@ -6012,7 +6039,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6102,7 +6129,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6191,7 +6218,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6272,7 +6299,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.sccp_addr_msc := g_bssap[0].sccp_addr_own; pars.sccp_addr_bsc := g_bssap[0].sccp_addr_peer; @@ -6482,7 +6509,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 60.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_1)); vc_conn.done; @@ -6497,6 +6524,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:failed"); /* 1.b */ f_ctrs_bsc_and_bts_add(0, "handover:attempted"); @@ -6511,6 +6540,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:failed"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); @@ -6542,7 +6573,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_2)); vc_conn.done; @@ -6557,6 +6588,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(1, "incoming_intra_bsc_ho:failed"); /* 2.b */ f_ctrs_bsc_and_bts_add(0, "handover:attempted"); @@ -6591,7 +6624,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_3)); vc_conn.done; @@ -6610,6 +6643,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:failed"); f_ctrs_bsc_and_bts_verify(); f_shutdown_helper(); @@ -6643,7 +6678,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_4)); vc_conn.done; @@ -6693,7 +6728,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_5)); vc_conn.done; @@ -6736,7 +6771,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_6)); vc_conn.done; @@ -6780,7 +6815,7 @@ var MSC_ConnHdlr vc_conn; f_init(3, true, guard_timeout := 50.0); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_7)); vc_conn.done; @@ -6795,6 +6830,8 @@ f_ctrs_bsc_and_bts_add(0, "handover:failed"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:attempted"); f_ctrs_bsc_and_bts_add(0, "intra_bsc_ho:failed"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:attempted"); + f_ctrs_bts_add(2, "incoming_intra_bsc_ho:failed"); /* 7.b */ /* "timeout" means a handover was triggered and started (which is all this test aims for) and the test ended the @@ -9752,7 +9789,7 @@ f_init(1, true); f_sleep(1.0); - f_ctrs_bsc_and_bts_init(); + f_ctrs_bsc_and_bts_handover_init(); pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); vc_conn := f_start_handler(refers(f_TC_reassignment_codec), pars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba229313d73fa20266f6d4eac5820579fb14c604 Gerrit-Change-Number: 26141 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:36:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 13:36:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: add test for CM Service Reject counter In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 ) Change subject: bsc: add test for CM Service Reject counter ...................................................................... bsc: add test for CM Service Reject counter Related: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b (osmo-bsc) Related: SYS#4878 Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a --- M bsc/BSC_Tests.ttcn M library/L3_Templates.ttcn 2 files changed, 82 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 2fde8ae..4fdd059 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -766,8 +766,12 @@ /* Convenience functions for rate counters using g_ctr_bts, always also including g_ctr_bsc. */ -private function f_ctrs_bsc_and_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { +private function f_ctrs_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, counternames); +} + +function f_ctrs_bsc_and_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { + f_ctrs_bts_init(bts_count, counternames); log("initial bts rate counters: ", g_ctr_bts); f_ctrs_bsc_init(counternames); } @@ -788,6 +792,10 @@ f_ctrs_bsc_add(countername, val); } +function f_ctrs_bts_verify() runs on test_CT { + f_counter_name_vals_expect_n(IPA_CTRL, "bts", g_ctr_bts); +} + /* f_ctrs_bsc_and_bts_init(); * f_do_thing(on_bts := 0); * f_do_thing(on_bts := 0); @@ -797,7 +805,7 @@ * f_ctrs_bsc_and_bts_verify(); */ private function f_ctrs_bsc_and_bts_verify() runs on test_CT { - f_counter_name_vals_expect_n(IPA_CTRL, "bts", g_ctr_bts); + f_ctrs_bts_verify(); f_ctrs_bsc_verify(); } @@ -10346,6 +10354,59 @@ f_shutdown_helper(); } +const CounterNameVals counternames_cm_serv_rej := { + { "cm_serv_rej", 0 }, + { "cm_serv_rej:imsi_unknown_in_hlr", 0 }, + { "cm_serv_rej:illegal_ms", 0 }, + { "cm_serv_rej:imsi_unknown_in_vlr", 0 }, + { "cm_serv_rej:imei_not_accepted", 0 }, + { "cm_serv_rej:illegal_me", 0 }, + { "cm_serv_rej:plmn_not_allowed", 0 }, + { "cm_serv_rej:loc_not_allowed", 0 }, + { "cm_serv_rej:roaming_not_allowed", 0 }, + { "cm_serv_rej:network_failure", 0 }, + { "cm_serv_rej:synch_failure", 0 }, + { "cm_serv_rej:congestion", 0 }, + { "cm_serv_rej:srv_opt_not_supported", 0 }, + { "cm_serv_rej:rqd_srv_opt_not_supported", 0 }, + { "cm_serv_rej:srv_opt_tmp_out_of_order", 0 }, + { "cm_serv_rej:call_can_not_be_identified", 0 }, + { "cm_serv_rej:incorrect_message", 0 }, + { "cm_serv_rej:invalid_mandantory_inf", 0 }, + { "cm_serv_rej:msg_type_not_implemented", 0 }, + { "cm_serv_rej:msg_type_not_compatible", 0 }, + { "cm_serv_rej:inf_eleme_not_implemented", 0 }, + { "cm_serv_rej:condtional_ie_error", 0 }, + { "cm_serv_rej:msg_not_compatible", 0 }, + { "cm_serv_rej:protocol_error", 0 }, + { "cm_serv_rej:retry_in_new_cell", 0 } +}; + +private function f_TC_cm_serv_rej(charstring id) runs on MSC_ConnHdlr +{ + f_create_chan_and_exp(); + BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); + f_sleep(3.0); +} +testcase TC_cm_serv_rej() runs on test_CT { + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + var MSC_ConnHdlr vc_conn; + + f_init(1, true); + f_sleep(1.0); + + f_ctrs_bts_init(1, counternames_cm_serv_rej); + + vc_conn := f_start_handler(refers(f_TC_cm_serv_rej), pars); + vc_conn.done; + + f_ctrs_bts_add(0, "cm_serv_rej", 1); + f_ctrs_bts_add(0, "cm_serv_rej:imsi_unknown_in_hlr", 1); + f_ctrs_bts_verify(); + + f_shutdown_helper(); +} + /* Reproduce a segfault happening when the SDCCH (primary) lchan is lost in-between a TCH Channel Activ and its Channel * Activ Ack (SYS#5627). */ private function f_TC_lost_sdcch_during_assignment(charstring id) runs on MSC_ConnHdlr { @@ -10894,6 +10955,8 @@ execute( TC_ratectr_all_available_allocated() ); execute( TC_ratectr_all_available_allocated_dyn() ); + execute( TC_cm_serv_rej() ); + execute( TC_lost_sdcch_during_assignment() ); } diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 997b433..e6efb68 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -389,6 +389,23 @@ } } +template (value) PDU_ML3_NW_MS ts_CM_SERV_REJ(OCT1 rejectCause) := { + discriminator := '0000'B, /* overwritten */ + tiOrSkip := { + skipIndicator := '0000'B + }, + msgs := { + mm := { + cMServiceReject := { + messageType := '000000'B, /* overwritten */ + nsd := '00'B, + rejectCause := rejectCause, + t3246_Value := omit + } + } + } +} + template (value) PDU_ML3_MS_NW ts_CM_REESTABL_REQ(MobileIdentityLV mi_lv) := { discriminator := '0000'B, /* overwritten */ tiOrSkip := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0214b27da18af87eca9715ebf7eeeff945e3e12a Gerrit-Change-Number: 26143 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:48:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 13:48:03 +0000 Subject: Change in osmo-pcu[master]: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26183 ) Change subject: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c Gerrit-Change-Number: 26183 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: keith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Nov 2021 13:48:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:58:24 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 13:58:24 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26142 ) Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 10 Nov 2021 13:58:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 13:59:20 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 13:59:20 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename function to clraify what it does In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26181 ) Change subject: ts_alloc: rename function to clraify what it does ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I55954321d6f2b5e755177a8829512da371e934aa Gerrit-Change-Number: 26181 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Nov 2021 13:59:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:01:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:01:54 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 32: (23 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32//COMMIT_MSG at 37 PS32, Line 37: - the mgcp msg queue for mgcp commands, which the thread then ansers by answers https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h File include/osmocom/mgcp/mgcp_threads.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h at 38 PS32, Line 38: enum trunkthread_cfg_msg_t; we don't usually use the _t type suffix. It's actually discouraged for non simple types in the kernel style guide. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h at 73 PS32, Line 73: struct to_trunkthread_cfg_msg { This "to" prefix here is very confusing imho. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h at 115 PS32, Line 115: struct per_thread_info { imho this "per_" prefix can also be dropped, it confuses more than helps. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h at 121 PS32, Line 121: int tid; /* thread number handling this subtrunk */ as in gettid()? or some posix threads id? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 319 PS32, Line 319: ssize_t rc = w->x.msglen; this looks a bit weird, assigning a length to rc like this. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 326 PS32, Line 326: if (rc < sizeof(rq->name) - 1) { afaict you are only using rc here and in line 333 before setting it below, may be just more understandable to pass w->x.msglen here/there. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 331 PS32, Line 331: memcpy(rq->name, (const char *)&w->msg[0], sizeof(rq->name) - 1); no null char at the end of rq->name is required? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 396 PS32, Line 396: ti->dlcx_in_queue++; what's the relation between dlc_in_queue and having free endpoints? I cannot see the relation at first sight. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 407 PS32, Line 407: return NULL; Doesn't "w" need to be freed in any of these paths? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 1531 PS32, Line 1531: * endpoints, possible open connections are forcefully dropped */ need to fix formatting here. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 44 PS32, Line 44: #define GETF(yy, zz) \ That's 10 lines for all the macro + definition stuff. Having the 3 functions is 12 lines, and easier to read and look up them in the code. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 337 PS32, Line 337: void *split_per_thead(void *info) THis function name is misleading. I first though it was the one organizing stuff splitting into several threads, but it's actually the main() of each thread. Rather call it thread_main() or thread_func() or alike. Even better, thread_loop(), since it's calling the osmocom loop at the end. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 344 PS32, Line 344: top_ctx = talloc_named_const(NULL, 0, "top_thread_ctx"); idea: maybe add this_thread_number to the string here. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 357 PS32, Line 357: struct mgcp_trunk *t = thread_info->this_trunk; Please move this to the start, I was not finding it when looking for "t". https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 369 PS32, Line 369: t->ratectr = (struct mgcp_ratectr_trunk){ 0 }; what about this? I think there's APIs to reset the counters? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 377 PS32, Line 377: prctl(PR_SET_NAME, thrdname, NULL, NULL, NULL); POSIX threads have pthread_setname_np() for that. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 382 PS32, Line 382: log_enable_multithread(); iirc this needs to be called only once per program? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 383 PS32, Line 383: //msgb_talloc_ctx_init(OTC_GLOBAL,0); nooo is global! what about this? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 386 PS32, Line 386: /* this trunk does not have rate ctrs or stat items, it only has atomic counters, And hence is what we could have different structures for different main trunk and per-thread trunk. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 397 PS32, Line 397: osmo_stat_item_set(osmo_stat_item_group_get_item(t->stats.common, TRUNK_STAT_ENDPOINTS_TOTAL), is this safe? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 413 PS32, Line 413: //FIXME: shutdown something to do with this? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 440 PS32, Line 440: /* currently unused what about this? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 32 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 10 Nov 2021 14:01:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:16:06 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:16:06 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c at 425 PS2, Line 425: for (int i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { > BTW, ths patch is changing the place where i is declared for no good reason I can tell, so even more [?] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 14:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:18:11 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:18:11 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26192 ) Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26192/1/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26192/1/src/libosmo-mgcp/mgcp_conn.c at 330 PS1, Line 330: __attribute__((no_sanitize("undefined"))) > Please add a comment in the code explaining why is this attribute added here. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 14:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:32:58 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:32:58 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: bootstrap_bts: print errornous ARFCN number In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26184 ) Change subject: osmo_bsc_main: bootstrap_bts: print errornous ARFCN number ...................................................................... osmo_bsc_main: bootstrap_bts: print errornous ARFCN number The function bootstrap_bts verifies that the ARFCN number is within the valid range of the current band. In case of error it prints that the ARFCN is out of range, but it does not print the BTS number, nor the ARFCN number. Change-Id: I432448b4bd5ea1a209838a6c5105cc1e9f7d80ee --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 17196e9..a39c109 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -447,32 +447,32 @@ switch (bts->band) { case GSM_BAND_1800: if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) { - LOGP(DNM, LOGL_ERROR, "GSM1800 channel must be between 512-885.\n"); + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1800 channel (%u) must be between 512-885.\n", + bts->nr, bts->c0->arfcn); return -EINVAL; } break; case GSM_BAND_1900: if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { - LOGP(DNM, LOGL_ERROR, "GSM1900 channel must be between 512-810.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n", + bts->nr, bts->c0->arfcn); } break; case GSM_BAND_900: if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "GSM900 channel must be between 0-124, 955-1023.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", + bts->nr, bts->c0->arfcn); } break; case GSM_BAND_850: if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) { - LOGP(DNM, LOGL_ERROR, "GSM850 channel must be between 128-251.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n", + bts->nr, bts->c0->arfcn); } break; default: - LOGP(DNM, LOGL_ERROR, "Unsupported frequency band.\n"); - return -EINVAL; + LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr); } /* Verify the physical channel mapping */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I432448b4bd5ea1a209838a6c5105cc1e9f7d80ee Gerrit-Change-Number: 26184 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:33:27 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:33:27 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: separate checks from bootstrap_bts In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26185 ) Change subject: osmo_bsc_main: separate checks from bootstrap_bts ...................................................................... osmo_bsc_main: separate checks from bootstrap_bts The function bootstrap_bts does a few checks before it does the actual initialization. To make the code more modular, lets split the function into two functions, check_bts and bootstrap_bts. Also be sure that we print the BTS number when the check failes. Change-Id: Id2b26f147d2f35e156e2da8ee58d2bbbb93de4ac Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index a39c109..11db260 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -436,10 +436,9 @@ return 0; } -static int bootstrap_bts(struct gsm_bts *bts) +static int check_bts(struct gsm_bts *bts) { struct gsm_bts_trx *trx; - unsigned int n = 0; if (!bts->model) return -EFAULT; @@ -484,6 +483,13 @@ } } + return 0; +} + +static void bootstrap_bts(struct gsm_bts *bts) +{ + unsigned int n = 0; + /* Control Channel Description is set from vty/config */ /* Determine the value of CCCH_CONF. Is TS0/C0 combined? */ @@ -510,8 +516,6 @@ /* Initialize the BTS state */ gsm_bts_sm_mo_reset(bts->site_mgr); - - return 0; } static int bsc_network_configure(const char *config_file) @@ -535,11 +539,12 @@ osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) { - rc = bootstrap_bts(bts); + rc = check_bts(bts); if (rc < 0) { - LOGP(DNM, LOGL_FATAL, "Error bootstrapping BTS\n"); + LOGP(DNM, LOGL_FATAL, "(bts=%u) cannot bootstrap BTS, invalid BTS configuration\n", bts->nr); return rc; } + bootstrap_bts(bts); rc = e1_reconfig_bts(bts); if (rc < 0) { LOGP(DNM, LOGL_FATAL, "Error enabling E1 input driver\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id2b26f147d2f35e156e2da8ee58d2bbbb93de4ac Gerrit-Change-Number: 26185 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:36:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:36:03 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26186 to look at the new patch set (#3). Change subject: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts ...................................................................... osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts In order to be able to call check_bts() and bootstrap_bts() from inp_sig_cb(), we must move it below bootstrap_bts. Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 47 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/26186/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Gerrit-Change-Number: 26186 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:36:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:36:03 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 to look at the new patch set (#6). Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... osmo_bsc_main: call bootstrap_bts when OML TEI comes up At the moment check_bts and bootstrap_bts is called only once on startup. When a new BTS is set up during runtime bootstrap_bts, nor check_bts is called. This means that some parameters of the BTS stay uninitalized until osmo-bsc is restarted. Lets rather call check_bts() and then bootstrap_bts() when the OML TEI of the BTS comes up. Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 15 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/25767/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:36:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:36:03 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 to look at the new patch set (#3). Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() The function generate_ma_for_bts() is called when the OML TEI comes up. In the same code path boostrap_bts() is called as well. It would be more logical to call generate_ma_for_bts() from boostrap_bts() since it is also part of the bootstrapping process. Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/26187/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:36:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:36:03 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 to look at the new patch set (#3). Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/osmo_bsc_main.c 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:43:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:43:02 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26142 ) Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 10 Nov 2021 14:43:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:43:18 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:43:18 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26186 ) Change subject: osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts ...................................................................... osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts In order to be able to call check_bts() and bootstrap_bts() from inp_sig_cb(), we must move it below bootstrap_bts. Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 47 insertions(+), 47 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 11db260..fae2ef2 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -389,53 +389,6 @@ osmo_timer_schedule(&update_connection_stats_timer, 1, 0); } -/* Callback function to be called every time we receive a signal from INPUT */ -static int inp_sig_cb(unsigned int subsys, unsigned int signal, - void *handler_data, void *signal_data) -{ - struct input_signal_data *isd = signal_data; - struct gsm_bts_trx *trx = isd->trx; - - if (subsys != SS_L_INPUT) - return -EINVAL; - - LOGP(DLMI, LOGL_DEBUG, "%s(): Input signal '%s' received\n", __func__, - get_value_string(e1inp_signal_names, signal)); - switch (signal) { - case S_L_INP_TEI_UP: - if (isd->link_type == E1INP_SIGN_OML) { - /* Generate Mobile Allocation bit-masks for all timeslots. - * This needs to be done here, because it's used for TS configuration. */ - generate_ma_for_bts(trx->bts); - } - if (isd->link_type == E1INP_SIGN_RSL) - bootstrap_rsl(trx); - break; - case S_L_INP_TEI_DN: - LOG_TRX(trx, DLMI, LOGL_ERROR, "Lost E1 %s link\n", e1inp_signtype_name(isd->link_type)); - - if (isd->link_type == E1INP_SIGN_OML) { - rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_OML_FAIL)); - all_ts_dispatch_event(trx, TS_EV_OML_DOWN); - } else if (isd->link_type == E1INP_SIGN_RSL) { - rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_RSL_FAIL)); - acc_ramp_abort(&trx->bts->acc_ramp); - all_ts_dispatch_event(trx, TS_EV_RSL_DOWN); - if (trx->nr == 0) - osmo_timer_del(&trx->bts->cbch_timer); - } - - gsm_bts_sm_mo_reset(trx->bts->site_mgr); - - abis_nm_clear_queue(trx->bts); - break; - default: - break; - } - - return 0; -} - static int check_bts(struct gsm_bts *bts) { struct gsm_bts_trx *trx; @@ -518,6 +471,53 @@ gsm_bts_sm_mo_reset(bts->site_mgr); } +/* Callback function to be called every time we receive a signal from INPUT */ +static int inp_sig_cb(unsigned int subsys, unsigned int signal, + void *handler_data, void *signal_data) +{ + struct input_signal_data *isd = signal_data; + struct gsm_bts_trx *trx = isd->trx; + + if (subsys != SS_L_INPUT) + return -EINVAL; + + LOGP(DLMI, LOGL_DEBUG, "%s(): Input signal '%s' received\n", __func__, + get_value_string(e1inp_signal_names, signal)); + switch (signal) { + case S_L_INP_TEI_UP: + if (isd->link_type == E1INP_SIGN_OML) { + /* Generate Mobile Allocation bit-masks for all timeslots. + * This needs to be done here, because it's used for TS configuration. */ + generate_ma_for_bts(trx->bts); + } + if (isd->link_type == E1INP_SIGN_RSL) + bootstrap_rsl(trx); + break; + case S_L_INP_TEI_DN: + LOG_TRX(trx, DLMI, LOGL_ERROR, "Lost E1 %s link\n", e1inp_signtype_name(isd->link_type)); + + if (isd->link_type == E1INP_SIGN_OML) { + rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_OML_FAIL)); + all_ts_dispatch_event(trx, TS_EV_OML_DOWN); + } else if (isd->link_type == E1INP_SIGN_RSL) { + rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_RSL_FAIL)); + acc_ramp_abort(&trx->bts->acc_ramp); + all_ts_dispatch_event(trx, TS_EV_RSL_DOWN); + if (trx->nr == 0) + osmo_timer_del(&trx->bts->cbch_timer); + } + + gsm_bts_sm_mo_reset(trx->bts->site_mgr); + + abis_nm_clear_queue(trx->bts); + break; + default: + break; + } + + return 0; +} + static int bsc_network_configure(const char *config_file) { struct gsm_bts *bts; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1a365bc2278368ec1f5c0db3f3e466b124b16e83 Gerrit-Change-Number: 26186 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:44:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:44:03 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 14:44:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:44:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:44:25 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26187 ) Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 14:44:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:44:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:44:57 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 3: my previous comment still applies in new version. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 14:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:47:38 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:47:38 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 to look at the new patch set (#4). Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/osmo_bsc_main.c 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:49:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:49:54 +0000 Subject: Change in osmo-pcu[master]: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26183 ) Change subject: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c Gerrit-Change-Number: 26183 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: keith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 14:49:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:51:59 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 14:51:59 +0000 Subject: Change in osmo-pcu[master]: pdch: Log line detaching TBF at start of the function In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26176 ) Change subject: pdch: Log line detaching TBF at start of the function ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp at 1138 PS1, Line 1138: %d TBFs, " : "USFs = %02x, TFIs = %08x > it's the current state, it's fine keeping it this way imho, it lets you know what detach is going to [?] It says "Detaching", so I also would expect the current state. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a Gerrit-Change-Number: 26176 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 10 Nov 2021 14:51:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:52:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:52:51 +0000 Subject: Change in osmo-pcu[master]: pdch: Log line detaching TBF at start of the function In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26176 ) Change subject: pdch: Log line detaching TBF at start of the function ...................................................................... pdch: Log line detaching TBF at start of the function Log before the action is done ("Detaching", not "Detached"). This way, if something crashes we see that last line. Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a --- M src/pdch.cpp M tests/app_info/AppInfoTest.err M tests/tbf/TbfTest.err 3 files changed, 59 insertions(+), 59 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/pdch.cpp b/src/pdch.cpp index fdac100..8e70ffc 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -1135,6 +1135,11 @@ { gprs_rlcmac_ul_tbf *ul_tbf; + LOGPDCH(this, DRLCMAC, LOGL_INFO, "Detaching %s, %d TBFs, " + "USFs = %02x, TFIs = %08x.\n", + tbf->name(), num_tbfs(tbf->direction), + m_assigned_usf, m_assigned_tfi[tbf->direction]); + if (tbf->is_egprs_enabled()) { OSMO_ASSERT(m_num_tbfs_egprs[tbf->direction] > 0); } else { @@ -1150,11 +1155,6 @@ m_tbfs[tbf->direction][tbf->tfi()] = NULL; pdch_ulc_release_tbf(ulc, tbf); - - LOGPDCH(this, DRLCMAC, LOGL_INFO, "Detaching %s, %d TBFs, " - "USFs = %02x, TFIs = %08x.\n", - tbf->name(), num_tbfs(tbf->direction), - m_assigned_usf, m_assigned_tfi[tbf->direction]); } bool gprs_rlcmac_pdch::has_gprs_only_tbf_attached() const diff --git a/tests/app_info/AppInfoTest.err b/tests/app_info/AppInfoTest.err index a8c4511..d39e952 100644 --- a/tests/app_info/AppInfoTest.err +++ b/tests/app_info/AppInfoTest.err @@ -52,14 +52,14 @@ Sending Packet Application Information to 2 subscribers with active TBF --- cleanup --- -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. -PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 2 TBFs, USFs = 00, TFIs = 00000003. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 2 TBFs, USFs = 00, TFIs = 00000003. +PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 2 TBFs, USFs = 00, TFIs = 00000003. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 10/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=6) Detaching TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000002. MS(TLLI=0xffffffff, IMSI=, TA=220, 12/13,) Detaching TBF: TBF(TFI=1 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) MS(TLLI=0xffffffff, IMSI=, TA=220, 12/13,) Destroying MS object MS(TLLI=0xffffffff, IMSI=, TA=220, 10/11,) Destroying MS object diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index c440499..bc817b2 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -144,14 +144,14 @@ TBF(DL-TFI_1){NEW}: state_chg to ASSIGN TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 2 TBFs, USFs = 00, TFIs = 00000003. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) ********** DL-TBF ends here ********** TBF(DL-TFI_0){WAIT_RELEASE}: Deallocated UL_ASS_TBF(DL-TFI_0){NONE}: Deallocated DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Deallocated TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 00, TFIs = 00000002. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) ********** DL-TBF ends here ********** TBF(DL-TFI_1){ASSIGN}: Deallocated @@ -257,14 +257,14 @@ TBF(DL-TFI_1){NEW}: state_chg to ASSIGN TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) Starting timer X2001 [assignment (PACCH)] with 2 sec. 0 microsec TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN), 2 TBFs, USFs = 00, TFIs = 00000003. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=ASSIGN) ********** DL-TBF ends here ********** TBF(DL-TFI_1){ASSIGN}: Deallocated UL_ASS_TBF(DL-TFI_1){NONE}: Deallocated DL_ASS_TBF(DL-TFI_1){NONE}: Deallocated TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) ********** DL-TBF ends here ********** TBF(DL-TFI_0){WAIT_RELEASE}: Deallocated @@ -532,7 +532,7 @@ TBF(DL-TFI_0){FINISHED}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Destroying MS object ********** DL-TBF ends here ********** @@ -612,7 +612,7 @@ Modifying MS object, TLLI = 0xf1000002, IMSI '' -> '001001000000002' MS(TLLI=0xf1000002, IMSI=, TA=0, 45/0, DL) IMSI '001001000000002' was already assigned to another MS object: TLLI = 0xf1000001, that IMSI will be removed TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW), 1 TBFs, USFs = 00, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW), 2 TBFs, USFs = 00, TFIs = 00000003. MS(TLLI=0xf1000001, IMSI=001001000000002, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xf1000001 DIR=DL STATE=FLOW) ********** DL-TBF ends here ********** TBF(DL-TFI_0){FLOW}: Deallocated @@ -621,7 +621,7 @@ MS(TLLI=0xf1000001, IMSI=001001000000002, TA=0, 45/0,) Clearing MS object MS(TLLI=0xffffffff, IMSI=, TA=0, 45/0,) Destroying MS object TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW), 1 TBFs, USFs = 00, TFIs = 00000002. MS(TLLI=0xf1000002, IMSI=001001000000002, TA=0, 45/0,) Detaching TBF: TBF(TFI=1 TLLI=0xf1000002 DIR=DL STATE=FLOW) MS(TLLI=0xf1000002, IMSI=001001000000002, TA=0, 45/0,) Destroying MS object ********** DL-TBF ends here ********** @@ -1642,7 +1642,7 @@ Modifying MS object, TLLI = 0xc0123456, TA 220 -> 0 TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) appending 19 bytes TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xc0123456, IMSI=001001000123456, TA=0, 45/0,) Detaching TBF: TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=ASSIGN) MS(TLLI=0xc0123456, IMSI=001001000123456, TA=0, 45/0,) Schedule MS release in 10 secs ********** DL-TBF ends here ********** @@ -2149,7 +2149,7 @@ MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=FINISHED) MS(TLLI=0xf5667788, IMSI=, TA=7, 1/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf5667788 DIR=DL STATE=FINISHED) TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 1 TBFs, USFs = 02, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 2 TBFs, USFs = 03, TFIs = 00000003. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0,) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) ********** UL-TBF ends here ********** UL_ACK_TBF(UL-TFI_0){NONE}: Deallocated @@ -2264,7 +2264,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 20 bytes Old MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 1 TBFs, USFs = 01, TFIs = 00000001. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) ********** UL-TBF ends here ********** UL_ACK_TBF(UL-TFI_0){NONE}: Deallocated @@ -2437,7 +2437,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 20 bytes Old MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), 1 TBFs, USFs = 01, TFIs = 00000001. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, DL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) ********** UL-TBF ends here ********** UL_ACK_TBF(UL-TFI_0){NONE}: Deallocated @@ -2482,7 +2482,7 @@ TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=FLOW) data_length=20, data=f1 22 33 44 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 TBF(TFI=0 TLLI=0xffffffff DIR=UL STATE=FLOW) Decoded premier TLLI=0xf1223344 of UL DATA TFI=0. TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN), 0 TBFs, USFs = 01, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN), 1 TBFs, USFs = 01, TFIs = 00000001. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0,) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) ********** DL-TBF ends here ********** TBF(DL-TFI_0){ASSIGN}: Deallocated @@ -3361,7 +3361,7 @@ DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: state_chg to NONE TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) free -PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE), 1 TBFs, USFs = 01, TFIs = 00000002. +PDCH(bts=0,trx=0,ts=7) Detaching TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE), 2 TBFs, USFs = 01, TFIs = 00000003. MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL DL) Detaching TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) ********** DL-TBF ends here ********** TBF(DL-TFI_0){WAIT_RELEASE}: Deallocated @@ -3627,10 +3627,10 @@ MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) DL TBF slots: 0x3c, N: 4, WS: 64 TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) free -PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW) MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) Destroying MS object ********** DL-TBF ends here ********** @@ -3673,10 +3673,10 @@ ws(384) DL TBF slots: 0x3c, N: 4, WS: 384 TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) free -PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 12/12,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) MS(TLLI=0xffffffff, IMSI=, TA=220, 12/12,) Destroying MS object ********** DL-TBF ends here ********** @@ -4323,7 +4323,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -4581,7 +4581,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -4799,7 +4799,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5001,7 +5001,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5187,7 +5187,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5349,7 +5349,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5520,7 +5520,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5682,7 +5682,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5833,7 +5833,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5906,7 +5906,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -5976,7 +5976,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6046,7 +6046,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6140,7 +6140,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6233,7 +6233,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6326,7 +6326,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6419,7 +6419,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6498,7 +6498,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6575,7 +6575,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6652,7 +6652,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6736,7 +6736,7 @@ TBF(DL-TFI_0){FLOW}: state_chg to WAIT_RELEASE TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) starting timer T3193 with 0 sec. 100000 microsec TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -6905,7 +6905,7 @@ ws(192) DL TBF slots: 0x10, N: 1, WS: 192 ********** DL-TBF update ********** -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. [DL] algo B (suggested TRX: -1): Alloc start Found first unallocated TRX=0 TFI=0 Selected DL slots: (TS=0)"..DDDD.."(TS=7), multi @@ -6922,10 +6922,10 @@ ws(384) DL TBF slots: 0x3c, N: 4, WS: 384 TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) free -PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. -PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=2) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=3) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. +PDCH(bts=0,trx=0,ts=5) Detaching TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffffffff, IMSI=, TA=220, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffffffff DIR=DL STATE=NEW EGPRS) MS(TLLI=0xffffffff, IMSI=, TA=220, 11/11,) Destroying MS object ********** DL-TBF ends here ********** @@ -7096,7 +7096,7 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) DL analysis, range=1176:1288, lost=0, recv=0, skipped=112, bsn=1944, info='xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx................................................................................................................................................................................................................................................................................................................................................................................' TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) V(B): (V(A)=1186)"NNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNAAANAAAAAAAAAAAAAAAAAAAAAAAAAA"(V(S)-1=1287) A=Acked N=Nacked U=Unacked X=Resend-Unacked I=Invalid TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) free -PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS), 0 TBFs, USFs = 00, TFIs = 00000000. +PDCH(bts=0,trx=0,ts=4) Detaching TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Detaching TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) MS(TLLI=0xffeeddcc, IMSI=, TA=0, 11/11,) Destroying MS object ********** DL-TBF ends here ********** -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a Gerrit-Change-Number: 26176 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:52:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:52:51 +0000 Subject: Change in osmo-pcu[master]: pdch: Log TS enable/disable transitions In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26177 ) Change subject: pdch: Log TS enable/disable transitions ...................................................................... pdch: Log TS enable/disable transitions Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52 --- M src/pdch.cpp M tests/app_info/AppInfoTest.err M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 4 files changed, 48 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/pdch.cpp b/src/pdch.cpp index 8e70ffc..c1c7714 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -143,6 +143,7 @@ void gprs_rlcmac_pdch::enable() { + LOGPDCH(this, DRLCMAC, LOGL_INFO, "PDCH state: %s => enabled\n", m_is_enabled ? "enabled" : "disabled"); OSMO_ASSERT(m_is_enabled == 0); INIT_LLIST_HEAD(&paging_list); @@ -155,6 +156,7 @@ void gprs_rlcmac_pdch::disable() { + LOGPDCH(this, DRLCMAC, LOGL_INFO, "PDCH state: %s => disabled\n", m_is_enabled ? "enabled" : "disabled"); OSMO_ASSERT(m_is_enabled == 1); this->free_resources(); diff --git a/tests/app_info/AppInfoTest.err b/tests/app_info/AppInfoTest.err index d39e952..1a9fab0 100644 --- a/tests/app_info/AppInfoTest.err +++ b/tests/app_info/AppInfoTest.err @@ -10,6 +10,10 @@ Packet Application Information will not be sent, no subscribers with active TBF --- prepare_bts_with_two_dl_tbf_subscr --- +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=6) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 10 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index bc817b2..ec0981c 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1,6 +1,8 @@ === start test_tbf_base === === end test_tbf_base === === start test_tbf_tlli_update === +PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) ********** DL-TBF starts here ********** MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Allocating DL TBF @@ -47,6 +49,7 @@ Modifying MS object, TLLI = 0x00004232, TA 4 -> 6 === end test_tbf_tlli_update === === start test_tbf_final_ack === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -160,6 +163,7 @@ MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Destroying MS object === end test_tbf_final_ack === === start test_tbf_final_ack === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -273,6 +277,7 @@ MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0,) Destroying MS object === end test_tbf_final_ack === === start test_tbf_delayed_release === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -541,6 +546,7 @@ DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Deallocated === end test_tbf_delayed_release === === start test_tbf_imsi === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 @@ -630,6 +636,7 @@ DL_ASS_TBF(DL-TFI_1){SEND_ASS}: Deallocated === end test_tbf_imsi === === start test_tbf_exhaustion === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000000' @@ -1609,6 +1616,7 @@ === end test_tbf_exhaustion === MS(TLLI=0xc0000020, IMSI=001001000000032, TA=220, 45/0,) Destroying MS object === start test_tbf_dl_llc_loss === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000123456' @@ -1717,6 +1725,7 @@ MSG = 07 01 04 4d 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 03 === end test_tbf_dl_llc_loss === === start test_tbf_single_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) @@ -1800,6 +1809,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 4 bytes === end test_tbf_single_phase === === start test_tbf_two_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -1899,6 +1909,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) appending 4 bytes === end test_tbf_two_phase === === start test_tbf_ra_update_rach === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -2163,6 +2174,7 @@ New MS: TLLI = 0xf5667788, TA = 7, IMSI = 0011223344, LLC = 1 === end test_tbf_ra_update_rach === === start test_tbf_dl_flow_and_rach_two_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -2336,6 +2348,7 @@ New MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 === end test_tbf_dl_flow_and_rach_two_phase === === start test_tbf_dl_flow_and_rach_single_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -2508,6 +2521,7 @@ New MS: TLLI = 0xf1223344, TA = 7, IMSI = 0011223344, LLC = 2 === end test_tbf_dl_flow_and_rach_single_phase === === start test_tbf_dl_reuse === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -3563,6 +3577,7 @@ TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=FINISHED) msg block (BSN 10, CS-1): 0f 03 14 4d 43 20 50 41 43 4b 45 54 20 30 39 20 28 54 42 46 20 32 29 === end test_tbf_dl_reuse === === start test_tbf_gprs_egprs === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001123456789' @@ -3595,6 +3610,10 @@ TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=ASSIGN) appending 256 bytes === end test_tbf_gprs_egprs === === start test_tbf_ws === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 12 MS(TLLI=0xffffffff, IMSI=, TA=220, 12/0,) ********** DL-TBF starts here ********** @@ -3685,6 +3704,7 @@ DL_ASS_TBF(DL-TFI_0){NONE}: Deallocated === end test_tbf_ws === === start test_tbf_egprs_two_phase === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -3792,6 +3812,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_egprs_two_phase === === start test_tbf_egprs_two_phase_spb === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -4022,6 +4043,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_egprs_two_phase_spb === === start test_tbf_egprs_dl === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing MCS-1 Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 @@ -5842,6 +5864,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_egprs_dl === === start test_tbf_egprs_retx_dl === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing retx for MCS 6 - 6 Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 @@ -6428,6 +6451,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_egprs_retx_dl === === start test_tbf_egprs_spb_dl === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing retx for MCS 6 to reseg_mcs 3 Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 @@ -6745,6 +6769,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_egprs_spb_dl === === start test_tbf_puan_urbb_len === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -6875,6 +6900,10 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_puan_urbb_len === === start test_tbf_update_ws === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 @@ -6934,6 +6963,7 @@ DL_ASS_TBF(DL-TFI_0){NONE}: Deallocated === end test_tbf_update_ws === === start test_tbf_li_decoding === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -7053,6 +7083,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_li_decoding === === start test_tbf_epdan_out_of_rx_window === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 @@ -7105,6 +7136,7 @@ DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Deallocated === end test_tbf_epdan_out_of_rx_window === === start test_immediate_assign_rej_multi_block === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x78 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) Creating MS object, TLLI = 0xffffffff @@ -7330,6 +7362,8 @@ MS(TLLI=0xffffffff, IMSI=, TA=220, 0/0,) Destroying MS object === end test_immediate_assign_rej_multi_block === === start test_immediate_assign_rej_single_block === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=7) PDCH state: enabled => disabled MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) No PDCH available. @@ -7337,6 +7371,7 @@ Tx Immediate Assignment Reject on AGCH === end test_immediate_assign_rej_single_block === === start test_tbf_egprs_two_phase_puan === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x73 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=2654270 TRX=0 TS=7 @@ -8599,6 +8634,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes === end test_tbf_egprs_two_phase_puan === === start test_packet_access_rej_epdan === +PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 @@ -8644,6 +8680,7 @@ packet reject: 40 84 7f f7 6e e6 7e ab 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b === end test_packet_access_rej_epdan === === start test_packet_access_rej_prr === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x70 (8 bit) Fn=2654167 qta=31 MS requests single block allocation (two phase packet access) Allocated a single block at SBFn=52 TRX=0 TS=7 @@ -9101,6 +9138,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN EGPRS) === end test_packet_access_rej_prr === === start test_packet_access_rej_prr_no_other_tbfs === +PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled Creating MS object, TLLI = 0xffffffff Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddcc, not yet confirmed TBF{NEW}: Allocated diff --git a/tests/ulc/PdchUlcTest.err b/tests/ulc/PdchUlcTest.err index 411c3f3..c7357c5 100644 --- a/tests/ulc/PdchUlcTest.err +++ b/tests/ulc/PdchUlcTest.err @@ -1,9 +1,11 @@ +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 72 PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 78 PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 72 PDCH(bts=0,trx=0,ts=0) Trying to reserve already reserved FN 78 PDCH(bts=0,trx=0,ts=0) Trying to release unregistered SBA (FN=78, TA=0) PDCH(bts=0,trx=0,ts=0) Timeout for registered SBA (FN=72, TA=0) +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled Creating MS object, TLLI = 0x12345678 MS(TLLI=0x12345678, IMSI=, TA=220, 0/0,) Attaching DL TBF: TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=2715613 but previous FN=2715608 is still reserved! @@ -41,6 +43,8 @@ PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=34, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) PDCH(bts=0,trx=0,ts=0) Expiring FN=43 but previous FN=39 is still reserved! PDCH(bts=0,trx=0,ts=0) Timeout for registered POLL (FN=39, reason=UL_ASS): TBF(TFI=-1 TLLI=0x12345678 DIR=DL STATE=NEW) +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled +PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 26 + 13 = 39 PDCH(bts=0,trx=0,ts=0) UL block already scheduled at FN 91 + 13 = 104 PDCH(bts=0,trx=0,ts=0) POLL scheduled at FN 91 + 17 = 108 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52 Gerrit-Change-Number: 26177 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:52:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:52:51 +0000 Subject: Change in osmo-pcu[master]: pdch: Log DL TBF originating the new UL TBF In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26179 ) Change subject: pdch: Log DL TBF originating the new UL TBF ...................................................................... pdch: Log DL TBF originating the new UL TBF Change-Id: Ie4257a2468d589464d0d56882e4408e4bcfe340f --- M src/pdch.cpp 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/pdch.cpp b/src/pdch.cpp index c1c7714..6aae7d1 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -123,10 +123,10 @@ /* schedule uplink assignment or reject */ if (ul_tbf) { - LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack message, so we provide one:\n"); + LOGPTBFDL(tbf, LOGL_DEBUG, "MS requests UL TBF in ack message, so we provide one:\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS, NULL); } else { - LOGP(DRLCMAC, LOGL_NOTICE, "MS requests UL TBF in ack message, but alloc failed: send PktAssRej\n"); + LOGPTBFDL(tbf, LOGL_NOTICE, "MS requests UL TBF in ack message, but alloc failed: send PktAssRej\n"); osmo_fsm_inst_dispatch(tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS_REJ, NULL); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie4257a2468d589464d0d56882e4408e4bcfe340f Gerrit-Change-Number: 26179 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:52:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:52:52 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: Simplify tfi_find_free logic In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26180 ) Change subject: ts_alloc: Simplify tfi_find_free logic ...................................................................... ts_alloc: Simplify tfi_find_free logic Avoid passing an extra pram which is accessible by GprsMs object already being passed. Once, the "trx = ms_current_trx(ms)" is moved inside the tfi_find_free function, it becomes clear that all the logic can be further simplified. Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index 5b3b355..b69d735 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -298,20 +298,21 @@ /*! Return free TFI * * \param[in] bts Pointer to BTS struct - * \param[in] trx Optional pointer to TRX struct * \param[in] ms Pointer to MS object * \param[in] dir DL or UL direction * \param[in] use_trx which TRX to use or -1 if it should be selected based on what MS uses * \param[out] trx_no_ TRX number on which TFI was found * \returns negative error code or 0 on success */ -static int tfi_find_free(const struct gprs_rlcmac_bts *bts, const gprs_rlcmac_trx *trx, const GprsMs *ms, +static int tfi_find_free(const struct gprs_rlcmac_bts *bts, const GprsMs *ms, enum gprs_rlcmac_tbf_direction dir, int8_t use_trx, uint8_t *trx_no_) { + const struct gprs_rlcmac_trx *trx; int tfi; uint8_t trx_no; - if (trx) { + /* If MS is already doing stuff on a TRX, set use_trx to it: */ + if ((trx = ms_current_trx(ms))) { if (use_trx >= 0 && use_trx != trx->trx_no) { LOGP(DRLCMAC, LOGL_ERROR, "- Requested incompatible TRX %d (current is %d)\n", use_trx, trx->trx_no); @@ -320,9 +321,6 @@ use_trx = trx->trx_no; } - if (use_trx == -1 && ms_current_trx(ms)) - use_trx = ms_current_trx(ms)->trx_no; - tfi = bts_tfi_find_free(bts, dir, &trx_no, use_trx); if (tfi < 0) return -EBUSY; @@ -884,18 +882,16 @@ reserved_dl_slots = ms_reserved_dl_slots(ms); reserved_ul_slots = ms_reserved_ul_slots(ms); first_common_ts = ms_first_common_ts(ms); - trx = ms_current_trx(ms); /* Step 2a: Find usable TRX and TFI */ - tfi = tfi_find_free(bts, trx, ms, tbf->direction, use_trx, &trx_no); + tfi = tfi_find_free(bts, ms, tbf->direction, use_trx, &trx_no); if (tfi < 0) { LOGPAL(tbf, "B", single, use_trx, LOGL_NOTICE, "failed to allocate a TFI\n"); return tfi; } /* Step 2b: Reserve slots on the TRX for the MS */ - if (!trx) - trx = &bts->trx[trx_no]; + trx = &bts->trx[trx_no]; if (!reserved_dl_slots || !reserved_ul_slots) { rc = find_multi_slots(trx, ms_ms_class(ms), &reserved_ul_slots, &reserved_dl_slots); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733d9bee3fa1dfc647da9f150b30014fbdab7442 Gerrit-Change-Number: 26180 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:52:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:52:52 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename function to clraify what it does In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26181 ) Change subject: ts_alloc: rename function to clraify what it does ...................................................................... ts_alloc: rename function to clraify what it does The function updates nothing, so it's misleading. It simply counts slots, so let's call it like that. Change-Id: I55954321d6f2b5e755177a8829512da371e934aa --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved dexter: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index b69d735..13e6440 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -661,7 +661,7 @@ * \param[out] slotcount Number of TS in use * \param[out] avail_count Number of reserved TS */ -static void update_slot_counters(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count) +static void count_slots(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count) { (*slotcount) = pcu_bitcount(slots); (*avail_count) = pcu_bitcount(reserved_slots); @@ -910,7 +910,7 @@ /* Step 3b: Derive the slot set for a given direction */ if (tbf->direction == GPRS_RLCMAC_DL_TBF) { dl_slots = rc; - update_slot_counters(dl_slots, reserved_dl_slots, &slotcount, &avail_count); + count_slots(dl_slots, reserved_dl_slots, &slotcount, &avail_count); } else { rc = allocate_usf(trx, rc, dl_slots, usf); if (rc < 0) @@ -919,7 +919,7 @@ ul_slots = rc; reserved_ul_slots = ul_slots; - update_slot_counters(ul_slots, reserved_ul_slots, &slotcount, &avail_count); + count_slots(ul_slots, reserved_ul_slots, &slotcount, &avail_count); } first_ts = ffs(rc) - 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I55954321d6f2b5e755177a8829512da371e934aa Gerrit-Change-Number: 26181 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:52:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:52:52 +0000 Subject: Change in osmo-pcu[master]: ts_alloc: rename variable to clarify meaning In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26182 ) Change subject: ts_alloc: rename variable to clarify meaning ...................................................................... ts_alloc: rename variable to clarify meaning The variable counts reserved slots, not available one. It can easily be seen by checking function count_slots() documentation "Number of reserved TS". The previous naming was used probably to indicate "available to reserve" TS, but the naming is misleading. Change-Id: Ib58e87d5a067d20d0b331fe32dff61b95ecc3e3f --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index 13e6440..a243d21 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -659,12 +659,12 @@ * \param[in] slots Timeslots in use * \param[in] reserved_slots Reserved timeslots * \param[out] slotcount Number of TS in use - * \param[out] avail_count Number of reserved TS + * \param[out] reserve_count Number of reserved TS */ -static void count_slots(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *avail_count) +static void count_slots(uint8_t slots, uint8_t reserved_slots, uint8_t *slotcount, uint8_t *reserve_count) { (*slotcount) = pcu_bitcount(slots); - (*avail_count) = pcu_bitcount(reserved_slots); + (*reserve_count) = pcu_bitcount(reserved_slots); } /*! Return slot mask with single TS from a given UL/DL set according to TBF's direction, ts pointer is set to that TS @@ -867,7 +867,7 @@ uint8_t reserved_ul_slots; int8_t first_common_ts; uint8_t slotcount = 0; - uint8_t avail_count = 0, trx_no; + uint8_t reserve_count = 0, trx_no; int first_ts = -1; int usf[8] = {-1, -1, -1, -1, -1, -1, -1, -1}; int rc; @@ -910,7 +910,7 @@ /* Step 3b: Derive the slot set for a given direction */ if (tbf->direction == GPRS_RLCMAC_DL_TBF) { dl_slots = rc; - count_slots(dl_slots, reserved_dl_slots, &slotcount, &avail_count); + count_slots(dl_slots, reserved_dl_slots, &slotcount, &reserve_count); } else { rc = allocate_usf(trx, rc, dl_slots, usf); if (rc < 0) @@ -919,7 +919,7 @@ ul_slots = rc; reserved_ul_slots = ul_slots; - count_slots(ul_slots, reserved_ul_slots, &slotcount, &avail_count); + count_slots(ul_slots, reserved_ul_slots, &slotcount, &reserve_count); } first_ts = ffs(rc) - 1; @@ -936,7 +936,7 @@ } if (single && slotcount) { - tbf->upgrade_to_multislot = (avail_count > slotcount); + tbf->upgrade_to_multislot = (reserve_count > slotcount); LOGPAL(tbf, "B", single, use_trx, LOGL_INFO, "using single slot at TS %d\n", first_ts); } else { tbf->upgrade_to_multislot = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib58e87d5a067d20d0b331fe32dff61b95ecc3e3f Gerrit-Change-Number: 26182 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 14:52:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 14:52:53 +0000 Subject: Change in osmo-pcu[master]: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26183 ) Change subject: pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled ...................................................................... pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled Otherwise, after the TS is disabled, a new TBF created for that MS may end up in alloc_algorithm assigning the disabled TS, since it will be in the mask of reserved PDCH TS for that MS. Related: OS#5265 Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c --- M src/pdch.cpp 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved keith: Looks good to me, but someone else must approve diff --git a/src/pdch.cpp b/src/pdch.cpp index 6aae7d1..4d82ab1 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -131,6 +131,32 @@ } } +/* Make sure the PDCH vanished from the mask of reserved PDCHs for all MS, to + * avoid alloc_algorithm using it. */ +static void pdch_unreserve_all_ms_reserved_slots(struct gprs_rlcmac_pdch *pdch) +{ + struct llist_head *tmp; + uint8_t ts_rm_mask = (~(1 << pdch->ts_no)); + struct gprs_rlcmac_trx *trx = pdch->trx; + + llist_for_each(tmp, bts_ms_list(trx->bts)) { + struct GprsMs *ms = llist_entry(tmp, typeof(*ms), list); + if (ms->current_trx != trx) + continue; + uint8_t old_dl_slots = ms_reserved_dl_slots(ms); + uint8_t old_ul_slots = ms_reserved_ul_slots(ms); + uint8_t new_dl_slots = old_dl_slots & ts_rm_mask; + uint8_t new_ul_slots = old_ul_slots & ts_rm_mask; + if (old_dl_slots == new_dl_slots && old_ul_slots == new_ul_slots) + continue; + ms_set_reserved_slots(ms, trx, new_ul_slots, new_dl_slots); + } + if (pdch->num_reserved(GPRS_RLCMAC_UL_TBF) > 0 || pdch->num_reserved(GPRS_RLCMAC_DL_TBF) > 0) + LOGPDCH(pdch, DRLCMAC, LOGL_ERROR, + "Reserved TS count not zero after unreserving from all current MS in list! UL=%u DL=%u\n", + pdch->num_reserved(GPRS_RLCMAC_UL_TBF), pdch->num_reserved(GPRS_RLCMAC_DL_TBF)); +} + void pdch_init(struct gprs_rlcmac_pdch *pdch, struct gprs_rlcmac_trx *trx, uint8_t ts_nr) { pdch->ts_no = ts_nr; @@ -171,6 +197,8 @@ /* kick all TBF on slot */ pdch_free_all_tbf(this); + pdch_unreserve_all_ms_reserved_slots(this); + /* flush all pending paging messages */ while ((pag = dequeue_paging())) talloc_free(pag); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifc59ac37fa6b0ad9ecc8f76326928611e748b11c Gerrit-Change-Number: 26183 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: keith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 15:13:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 15:13:31 +0000 Subject: Change in osmo-pcu[master]: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26198 ) Change subject: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA ...................................................................... pdch: Drop previous UL TBF from MS who sent PktResReq through SBA If the MS has a pending UL TBF but we just received a PktResReq on an allocated SBA from it (same TLLI, hence same MS), then it means it allocated the SBA through RACH req and hence it was on CCCH. That means it was not active on any PDCH, hence for sure the previous UL TBF can be dropped. Related: OS#5293 Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c --- M src/pdch.cpp 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/26198/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 4d82ab1..c48b078 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -680,6 +680,16 @@ "MS requests UL TBF throguh SBA\n", fn); ms_set_ta(ms, sba->ta); sba_free(sba); + /* If MS identified by TLLI sent us a PktResReq through SBA, it means it came + * from CCCH, so it's for sure not using previous UL + * TBF; drop it if it still exits on our end: */ + if ((ul_tbf = ms_ul_tbf(ms))) { + /* Get rid of previous finished UL TBF before providing a new one */ + LOGPTBFUL(ul_tbf, LOGL_NOTICE, + "Got PACKET RESOURCE REQ while TBF not finished, killing pending UL TBF\n"); + tbf_free(ul_tbf); + ul_tbf = NULL; + } /* MS seized the PDCH answering on the SBA: */ bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c Gerrit-Change-Number: 26198 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 15:49:20 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 10 Nov 2021 15:49:20 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails alive_timeout_handler() changes the state to RECOVERING which calls ns2_st_alive_onenter()->ns2_nse_notify_unblocked(unblocked=false)-> ns2_sns_notify_alive(unblocked=false) When all (signalling) NSVCs have failed and gss->role is SGSN and not persistent sns_failed() calls gprs_ns2_free_nse() which talloc_free()s the nse before returning. The next line in ns2_nse_notify_unblocked() tries to read nse->alive which then causes the use-after-free. Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Related: OS#5302 --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_internal.h M src/gb/gprs_ns2_sns.c 3 files changed, 14 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/26199/1 diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 3bb04ae..c422cda 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -1391,12 +1391,13 @@ * \param[in] unblocked whether the NSE should be marked as unblocked (true) or blocked (false) */ void ns2_nse_notify_unblocked(struct gprs_ns2_vc *nsvc, bool unblocked) { + int rc; struct gprs_ns2_nse *nse = nsvc->nse; ns2_nse_data_sum(nse); - ns2_sns_notify_alive(nse, nsvc, unblocked); + rc = ns2_sns_notify_alive(nse, nsvc, unblocked); - if (unblocked == nse->alive) + if (rc == -ENOENT || unblocked == nse->alive) return; /* wait until both data_weight and sig_weight are != 0 before declaring NSE as alive */ diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h index 0959d2b..aaf0897 100644 --- a/src/gb/gprs_ns2_internal.h +++ b/src/gb/gprs_ns2_internal.h @@ -456,7 +456,7 @@ const char *id); struct osmo_fsm_inst *ns2_sns_sgsn_fsm_alloc(struct gprs_ns2_nse *nse, const char *id); void ns2_sns_replace_nsvc(struct gprs_ns2_vc *nsvc); -void ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bool alive); +int ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bool alive); void ns2_sns_update_weights(struct gprs_ns2_vc_bind *bind); /* vc */ diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c index 0afc06e..7984417 100644 --- a/src/gb/gprs_ns2_sns.c +++ b/src/gb/gprs_ns2_sns.c @@ -2584,24 +2584,24 @@ return count; } -void ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bool alive) +int ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bool alive) { struct ns2_sns_state *gss; struct gprs_ns2_vc *tmp; if (!nse->bss_sns_fi) - return; + return 0; gss = nse->bss_sns_fi->priv; if (nse->bss_sns_fi->state != GPRS_SNS_ST_CONFIGURED && nse->bss_sns_fi->state != GPRS_SNS_ST_LOCAL_PROCEDURE) - return; + return 0; if (gss->block_no_nsvc_events) - return; + return 0; if (gss->alive && nse->sum_sig_weight == 0) { sns_failed(nse->bss_sns_fi, "No signalling NSVC available"); - return; + return -ENOENT; } /* check if this is the current SNS NS-VC */ @@ -2620,25 +2620,27 @@ } if (alive == gss->alive) - return; + return 0; if (alive) { /* we need at least a signalling NSVC before become alive */ if (nse->sum_sig_weight == 0) - return; + return 0; gss->alive = true; osmo_fsm_inst_dispatch(nse->bss_sns_fi, NS2_SNS_EV_REQ_NSVC_ALIVE, NULL); } else { /* is there at least another alive nsvc? */ llist_for_each_entry(tmp, &nse->nsvc, list) { if (ns2_vc_is_unblocked(tmp)) - return; + return 0; } /* all NS-VC have failed */ gss->alive = false; osmo_fsm_inst_dispatch(nse->bss_sns_fi, NS2_SNS_EV_REQ_NO_NSVC, NULL); } + + return 0; } int gprs_ns2_sns_add_bind(struct gprs_ns2_nse *nse, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 15:51:54 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 10 Nov 2021 15:51:54 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c at 1398 PS1, Line 1398: rc = ns2_sns_notify_alive(nse, nsvc, unblocked); Rather return a bool indicating if the NSE was freed? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 10 Nov 2021 15:51:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 15:58:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 15:58:09 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c at 1398 PS1, Line 1398: rc = ns2_sns_notify_alive(nse, nsvc, unblocked); > Rather return a bool indicating if the NSE was freed? What about trying to retrieve again the nse from the nsvc (nvsc->nse) and checking if it's null? or can it be that nsvc is also freed? https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2_sns.c at 2587 PS1, Line 2587: int ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bool alive) Please document the behavior of the function somewhere: "-ENONENT if NSE is freed" or alike. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 15:58:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:12:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 16:12:15 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26187 ) Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 16:12:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:15:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 16:15:43 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 4: (1 comment) Can we rather drop the OML/RSL links rather than NACKing everything? https://gerrit.osmocom.org/c/osmo-bsc/+/26197/4/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/4/src/osmo-bsc/abis_nm.c at 939 PS4, Line 939: LOGPFOH(DNM, LOGL_NOTICE, foh, "(bts=%u) BTS configuration invalid, rejecting OML NM Message from BTS -- check and correct configuratin!\n", This line is way too long. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 16:15:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:20:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 10 Nov 2021 16:20:24 +0000 Subject: Change in osmo-pcu[master]: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26198 ) Change subject: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c Gerrit-Change-Number: 26198 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 10 Nov 2021 16:20:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:23:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 16:23:36 +0000 Subject: Change in osmo-pcu[master]: pdch: Increase log level of line informing about TS control change References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26200 ) Change subject: pdch: Increase log level of line informing about TS control change ...................................................................... pdch: Increase log level of line informing about TS control change This way it's the same log level as the one used in all other paths using tbf_assign_control_ts() to assign tbf->control_ts = tbf->first_common_ts, and this specific event is not lost from logs. Change-Id: Ia32d835ee4c14d7d48391452b5e3d05ed88e0483 --- M src/pdch.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/00/26200/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index c48b078..a942b01 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -763,7 +763,7 @@ * sent to tbf_fsm which will call tbf_assign_control_ts(), * effectively setting back control_ts to * tbf->initial_common_ts. */ - LOGPTBF(ul_tbf, LOGL_DEBUG, "change control TS %d -> %d until assignment is complete.\n", + LOGPTBF(ul_tbf, LOGL_INFO, "change control TS %d -> %d until assignment is complete.\n", ul_tbf->control_ts, ts_no); ul_tbf->control_ts = ts_no; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia32d835ee4c14d7d48391452b5e3d05ed88e0483 Gerrit-Change-Number: 26200 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:47:59 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 10 Nov 2021 16:47:59 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26199 to look at the new patch set (#2). Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails alive_timeout_handler() changes the state to RECOVERING which calls ns2_st_alive_onenter()->ns2_nse_notify_unblocked(unblocked=false)-> ns2_sns_notify_alive(unblocked=false) When all (signalling) NSVCs have failed and gss->role is SGSN and not persistent sns_failed() calls gprs_ns2_free_nse() which talloc_free()s the nse before returning. The next line in ns2_nse_notify_unblocked() tries to read nse->alive which then causes the use-after-free. Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Related: OS#5302 --- M src/gb/gprs_ns2.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/26199/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:48:01 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 10 Nov 2021 16:48:01 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c at 1398 PS1, Line 1398: rc = ns2_sns_notify_alive(nse, nsvc, unblocked); > What about trying to retrieve again the nse from the nsvc (nvsc->nse) and checking if it's null? or [?] Good idea, I'll just try to get it from the nsi again. https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2_sns.c at 2587 PS1, Line 2587: int ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bool alive) > Please document the behavior of the function somewhere: "-ENONENT if NSE is freed" or alike. I'll leave the function be instead -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Nov 2021 16:48:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:54:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 10 Nov 2021 16:54:53 +0000 Subject: Change in osmo-pcu[master]: tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for n... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26201 ) Change subject: tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for new one Change-Id: If475560aab16b0a89743139189ff7720389132a5 --- M src/tbf_ul_ass_fsm.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/01/26201/1 diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index ab23fbd..d2dea46 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -110,7 +110,12 @@ }; bitvec_unhex(&bv, DUMMY_VEC); - LOGPTBFUL((const struct gprs_rlcmac_tbf *)new_tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); + if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_tbf) + LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH) for %s\n", + tbf_name((const struct gprs_rlcmac_tbf *)new_tbf)); + else + LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); + mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); tlli = ms_tlli(ms); write_packet_uplink_assignment(mac_control_block, tbf_tfi(ctx->tbf), -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If475560aab16b0a89743139189ff7720389132a5 Gerrit-Change-Number: 26201 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:56:40 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 16:56:40 +0000 Subject: Change in pysim[master]: filesystem: CardProfile: initialize empty sw table as empty dict References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26202 ) Change subject: filesystem: CardProfile: initialize empty sw table as empty dict ...................................................................... filesystem: CardProfile: initialize empty sw table as empty dict The table that holds the status word descriptions is initialized as an empty list '[]'. This is not correct since the interpret_sw method processes this data as dictionary, so lets initialize the sw member with an empty dict '{}' when not status word description is given. Change-Id: I3cae83f0f6ab274546991ecd14425f094b2816b2 Related: OS#5274 --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/02/26202/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6e5a359..79c997c 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1461,7 +1461,7 @@ self.name = name self.desc = kw.get("desc", None) self.files_in_mf = kw.get("files_in_mf", []) - self.sw = kw.get("sw", []) + self.sw = kw.get("sw", {}) self.applications = kw.get("applications", []) self.shell_cmdsets = kw.get("shell_cmdsets", []) self.cla = kw.get("cla", "00") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3cae83f0f6ab274546991ecd14425f094b2816b2 Gerrit-Change-Number: 26202 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:56:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 16:56:41 +0000 Subject: Change in pysim[master]: ts_51_011: add status word definition References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26203 ) Change subject: ts_51_011: add status word definition ...................................................................... ts_51_011: add status word definition There is no status word definition given in the SIM profile. Lets add one to be complete Change-Id: I01f2643a93e4a9b2ce2f95134aa5d773179d9b1c --- M pySim/ts_51_011.py 1 file changed, 38 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/03/26203/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index c2c1711..a32b1e4 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -999,7 +999,44 @@ class CardProfileSIM(CardProfile): def __init__(self): - super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()]) + sw = { + 'Normal': { + '9000': 'Normal ending of the command', + '91xx': 'normal ending of the command, with extra information from the proactive SIM containing a command for the ME', + '9exx': 'length XX of the response data given in case of a SIM data download error', + '9fxx': 'length XX of the response data', + }, + 'Postponed processing': { + '9300': 'SIM Application Toolkit is busy. Command cannot be executed at present, further normal commands are allowed', + }, + 'Memory management': { + '920x': 'command successful but after using an internal update retry routine X times', + '9240': 'memory problem', + }, + 'Referencing management': { + '9400': 'no EF selected', + '9402': 'out of range (invalid address)', + '9404': 'file ID not found or pattern not found', + '9408': 'file is inconsistent with the command', + }, + 'Security management': { + '9802': 'no CHV initialized', + '9804': 'access condition not fulfilled, unsuccessful CHV verification or authentication failed', + '9808': 'in contradiction with CHV status', + '9810': 'in contradiction with invalidation status', + '9840': 'unsuccessful verification, CHV blocked, UNBLOCK CHV blocked', + '9850': 'increase cannot be performed, Max value reached', + }, + 'Application independent errors': { + '67xx': 'incorrect parameter P3', + '6bxx': 'incorrect parameter P1 or P2', + '6dxx': 'unknown instruction code given in the command', + '6exx': 'wrong instruction class given in the command', + '6fxx': 'technical problem with no diagnostic given', + }, + } + + super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) def decode_select_response(self, data_hex:str) -> Any: return _decode_select_response(data_hex) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01f2643a93e4a9b2ce2f95134aa5d773179d9b1c Gerrit-Change-Number: 26203 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:56:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 16:56:41 +0000 Subject: Change in pysim[master]: pySim-shell: guess number of records when not specified References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26204 ) Change subject: pySim-shell: guess number of records when not specified ...................................................................... pySim-shell: guess number of records when not specified The select response of an UICC will always return the number of records of a file. However, older SIM will not include the number of records in the select response. In those cases, simply guess the number of records by reading until the first empty record is hit. This works because unused records are still initialized with 'fffff....', so an empty record will clearly mark the end of the file. Related: OS#5274 Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 --- M pySim-shell.py 1 file changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/26204/1 diff --git a/pySim-shell.py b/pySim-shell.py index 72ed213..db72d2d 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -516,10 +516,23 @@ result = self._cmd.rs.read_binary() self._cmd.poutput("update_binary " + str(result[0])) elif structure == 'cyclic' or structure == 'linear_fixed': - num_of_rec = fd['num_of_rec'] - for r in range(1, num_of_rec + 1): - result = self._cmd.rs.read_record(r) - self._cmd.poutput("update_record %d %s" % (r, str(result[0]))) + # Use number of records specified in select response + if 'num_of_rec' in fd: + num_of_rec = fd['num_of_rec'] + for r in range(1, num_of_rec + 1): + result = self._cmd.rs.read_record(r) + self._cmd.poutput("update_record %d %s" % (r, str(result[0]))) + # When the select response does not return the number of records, read until we hit the + # first empty record. + else: + r = 1 + while True: + result = self._cmd.rs.read_record(r) + if len(result[0]) > 0: + self._cmd.poutput("update_record %d %s" % (r, str(result[0]))) + r = r + 1 + else: + break elif structure == 'ber_tlv': tags = self._cmd.rs.retrieve_tags() for t in tags: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 16:58:00 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 10 Nov 2021 16:58:00 +0000 Subject: Change in pysim[master]: ts_102_221: put select response decoder into separate file In-Reply-To: References: Message-ID: dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/26160 ) Change subject: ts_102_221: put select response decoder into separate file ...................................................................... Abandoned ts_102_221.py and ts_102_221_select.py share some functions so this is not so easy to split. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If5fae46bb40d0f285236a6ab287070125c69ed70 Gerrit-Change-Number: 26160 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 17:25:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 17:25:56 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26161 ) Change subject: filesystem: fix decode_select_response ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Nov 2021 17:25:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 17:26:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 17:26:12 +0000 Subject: Change in pysim[master]: filesystem: fix decode_select_response In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26161 ) Change subject: filesystem: fix decode_select_response ...................................................................... filesystem: fix decode_select_response There are some problems with the usage of decode_select_response. At the moment the ADF files overload the related method to provide decoding of the select responses as per 3gpp TS 102 221. However, this also means that the decoder is only available under ADF.USIM and ADF.ISIM. DF.GSM and DF.TELECOM also overload the decoder method, just like an ADF would do. This decoding method is then implemented as per 3gpp TS 51 011. Since this a a problem on UICCs, the method detects the magic byte 0x62 that can be found at the beginning on every select response of an UICC to defer to the TS 102 221 decoding method. TS 51 011 defines the first two bytes of the select response as RFU. This at least problematic. To solve this there should be a default method for decode_select_response in the profile, which can be used if no file overloads it with a specific decoder. ADFs use specific decoders, but everything else should use the default decoder. When we deal with an UICC, we expect the select response to be consistantly conform to TS 102 221, if we deal with a clasic sim we expect responses as per TS 51 011 only. Since it is still possible to replace the select response decoder we still have the opportunity to have custom select response in cartain DFs and ADFs should we need them. Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Related: OS#5274 --- M pySim/filesystem.py M pySim/gsm_r.py M pySim/ts_102_221.py M pySim/ts_51_011.py 4 files changed, 60 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index dcc2608..3caa470 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -52,7 +52,7 @@ RESERVED_FIDS = ['3f00'] def __init__(self, fid:str=None, sfid:str=None, name:str=None, desc:str=None, - parent:Optional['CardDF']=None): + parent:Optional['CardDF']=None, profile:Optional['CardProfile']=None): """ Args: fid : File Identifier (4 hex digits) @@ -60,6 +60,7 @@ name : Brief name of the file, lik EF_ICCID desc : Description of the file parent : Parent CardFile object within filesystem hierarchy + profile : Card profile that this file should be part of """ if not isinstance(self, CardADF) and fid == None: raise ValueError("fid is mandatory") @@ -72,6 +73,7 @@ self.parent = parent if self.parent and self.parent != self and self.fid: self.parent.add_file(self) + self.profile = profile self.shell_commands = [] # type: List[CommandSet] # Note: the basic properties (fid, name, ect.) are verified when @@ -173,10 +175,34 @@ return list(sels.keys()) def decode_select_response(self, data_hex:str): - """Decode the response to a SELECT command.""" + """Decode the response to a SELECT command. + + Args: + data_hex: Hex string of the select response + """ + + # When the current file does not implement a custom select response decoder, + # we just ask the parent file to decode the select response. If this method + # is not overloaded by the current file we will again ask the parent file. + # This way we recursively travel up the file system tree until we hit a file + # that does implement a concrete decoder. if self.parent: return self.parent.decode_select_response(data_hex) + def get_profile(self): + """Get the profile associated with this file. If this file does not have any + profile assigned, try to find a file above (usually the MF) in the filesystem + hirarchy that has a profile assigned + """ + + # If we have a profile set, return it + if self.profile: + return self.profile + + # Walk up recursively until we hit a parent that has a profile set + if self.parent: + return self.parent.get_profile() + return None class CardDF(CardFile): """DF (Dedicated File) in the smart card filesystem. Those are basically sub-directories.""" @@ -331,12 +357,18 @@ def decode_select_response(self, data_hex:str) -> Any: """Decode the response to a SELECT command. - This is the fall-back method which doesn't perform any decoding. It mostly - exists so specific derived classes can overload it for actual decoding. + This is the fall-back method which automatically defers to the standard decoding + method defined by the card profile. When no profile is set, then no decoding is + performed. Specific derived classes (usually ADF) can overload this method to + install specific decoding. """ - return data_hex + profile = self.get_profile() + if profile: + return profile.decode_select_response(data_hex) + else: + return data_hex class CardADF(CardDF): """ADF (Application Dedicated File) in the smart card filesystem""" @@ -1029,7 +1061,7 @@ card : pysim.cards.Card instance profile : CardProfile instance """ - self.mf = CardMF() + self.mf = CardMF(profile=profile) self.card = card self.selected_file = self.mf # type: CardDF self.profile = profile @@ -1437,6 +1469,19 @@ """ return interpret_sw(self.sw, sw) + def decode_select_response(self, data_hex:str) -> Any: + """Decode the response to a SELECT command. + + This is the fall-back method which doesn't perform any decoding. It mostly + exists so specific derived classes can overload it for actual decoding. + This method is implemented in the profile and is only used when application + specific decoding cannot be performed (no ADF is selected). + + Args: + data_hex: Hex string of the select response + """ + return data_hex + class CardModel(abc.ABC): """A specific card model, typically having some additional vendor-specific files. All diff --git a/pySim/gsm_r.py b/pySim/gsm_r.py index 7cd7529..22b88fe 100644 --- a/pySim/gsm_r.py +++ b/pySim/gsm_r.py @@ -253,6 +253,3 @@ EF_DialledVals(fid='6f87', name='EF.FreeNumber', desc='Free Number Call Type 0 and 8'), ] self.add_files(files) - - def decode_select_response(self, data_hex): - return pySim.ts_51_011.decode_select_response(data_hex) diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 3665939..3c99c4d 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -684,3 +684,6 @@ } super().__init__('UICC', desc='ETSI TS 102 221', files_in_mf=files, sw=sw) + + def decode_select_response(self, data_hex:str) -> Any: + return decode_select_response(data_hex) diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 743c14b..a00cf0d 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -332,7 +332,6 @@ import enum from pySim.filesystem import * -import pySim.ts_102_221 ###################################################################### # DF.TELECOM @@ -451,9 +450,6 @@ ] self.add_files(files) - def decode_select_response(self, data_hex): - return decode_select_response(data_hex) - ###################################################################### # DF.GSM ###################################################################### @@ -936,13 +932,11 @@ ] self.add_files(files) - def decode_select_response(self, data_hex): - return decode_select_response(data_hex) -def decode_select_response(resp_hex): + +def _decode_select_response(resp_hex): + resp_bin = h2b(resp_hex) - if resp_bin[0] == 0x62: - return pySim.ts_102_221.decode_select_response(resp_hex) struct_of_file_map = { 0: 'transparent', 1: 'linear_fixed', @@ -983,3 +977,6 @@ class CardProfileSIM(CardProfile): def __init__(self): super().__init__('SIM', desc='GSM SIM Card', files_in_mf=[DF_TELECOM(), DF_GSM()]) + + def decode_select_response(self, data_hex:str) -> Any: + return _decode_select_response(data_hex) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95e33ec1755727dc9bbbc6016ce2d99a9e66f214 Gerrit-Change-Number: 26161 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 17:26:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 17:26:12 +0000 Subject: Change in pysim[master]: filesystem: do not read AIDs when no apps are defined In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26162 ) Change subject: filesystem: do not read AIDs when no apps are defined ...................................................................... filesystem: do not read AIDs when no apps are defined When the profile does not define any ADFs, then do not try to read any AIDs. This is the case for old non UICC SIMs for example. Change-Id: I8cfbee1d23e9f99461fa5f4fbf92c1a0929c50bf Related: OS#5274 --- M pySim/filesystem.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 3caa470..3d2687f 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1077,6 +1077,13 @@ def _match_applications(self): """match the applications from the profile with applications on the card""" apps_profile = self.profile.applications + + # When the profile does not feature any applications, then we are done already + if not apps_profile: + return [] + + # Read AIDs from card and match them against the applications defined by the + # card profile aids_card = self.card.read_aids() apps_taken = [] if aids_card: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8cfbee1d23e9f99461fa5f4fbf92c1a0929c50bf Gerrit-Change-Number: 26162 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 17:26:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 17:26:13 +0000 Subject: Change in pysim[master]: filesystem: make sure the card is in a defined state In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26163 ) Change subject: filesystem: make sure the card is in a defined state ...................................................................... filesystem: make sure the card is in a defined state When the runtime state is created there is already some interaction with the card. Lets make sure that the card is in a defined state when we leave the constructor of the RuntimeState. Change-Id: I986204964903069bcce781afdbf3c5d26682b749 Related: OS#5274 --- M pySim/filesystem.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 3d2687f..6010c30 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1074,6 +1074,10 @@ self.mf.add_file(f) self.conserve_write = True + # make sure that when the runtime state is created, the card is also + # in a defined state. + self.reset() + def _match_applications(self): """match the applications from the profile with applications on the card""" apps_profile = self.profile.applications -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I986204964903069bcce781afdbf3c5d26682b749 Gerrit-Change-Number: 26163 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 17:26:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Nov 2021 17:26:13 +0000 Subject: Change in pysim[master]: filesystem: define class byte and select control bytes in profile In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26164 ) Change subject: filesystem: define class byte and select control bytes in profile ...................................................................... filesystem: define class byte and select control bytes in profile The class byte and the select control bytes are different for SIM cards and UICC cards. Lets define those parameters in the card profile, so that we always get the correct parameters depending on which profile we use. Change-Id: I2d175e28bd748a4871b1373273b3a9be9ae8c4d0 Related: OS#5274 --- M pySim/filesystem.py M pySim/ts_102_221.py M pySim/ts_51_011.py 3 files changed, 11 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6010c30..24872c0 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1065,6 +1065,11 @@ self.card = card self.selected_file = self.mf # type: CardDF self.profile = profile + + # make sure the class and selection control bytes, which are specified + # by the card profile are used + self.card.set_apdu_parameter(cla=self.profile.cla, sel_ctrl=self.profile.sel_ctrl) + # add application ADFs + MF-files from profile apps = self._match_applications() for a in apps: @@ -1450,6 +1455,8 @@ applications : List of CardApplications present on card sw : List of status word definitions shell_cmdsets : List of cmd2 shell command sets of profile-specific commands + cla : class byte that should be used with cards of this profile + sel_ctrl : selection control bytes class byte that should be used with cards of this profile """ self.name = name self.desc = kw.get("desc", None) @@ -1457,6 +1464,8 @@ self.sw = kw.get("sw", []) self.applications = kw.get("applications", []) self.shell_cmdsets = kw.get("shell_cmdsets", []) + self.cla = kw.get("cla", "00") + self.sel_ctrl = kw.get("sel_ctrl", "0004") def __str__(self): return self.name diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 3c99c4d..61e236e 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -683,7 +683,7 @@ }, } - super().__init__('UICC', desc='ETSI TS 102 221', files_in_mf=files, sw=sw) + super().__init__('UICC', desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) def decode_select_response(self, data_hex:str) -> Any: return decode_select_response(data_hex) diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index a00cf0d..c146a79 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -976,7 +976,6 @@ class CardProfileSIM(CardProfile): def __init__(self): - super().__init__('SIM', desc='GSM SIM Card', files_in_mf=[DF_TELECOM(), DF_GSM()]) - + super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()]) def decode_select_response(self, data_hex:str) -> Any: return _decode_select_response(data_hex) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2d175e28bd748a4871b1373273b3a9be9ae8c4d0 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 10 17:53:45 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 10 Nov 2021 17:53:45 +0000 Subject: Change in osmo-bsc[master]: implement bts.N.cm_serv_rej: rate counters In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26142 ) Change subject: implement bts.N.cm_serv_rej: rate counters ...................................................................... implement bts.N.cm_serv_rej: rate counters Related: I0214b27da18af87eca9715ebf7eeeff945e3e12a (osmo-ttcn3-hacks) Related: SYS#4878 Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c 3 files changed, 202 insertions(+), 0 deletions(-) Approvals: dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 9cf3fa4..89512f3 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -162,6 +162,31 @@ BTS_CTR_ALL_ALLOCATED_STATIC_SDCCH, BTS_CTR_ALL_ALLOCATED_TCH, BTS_CTR_ALL_ALLOCATED_STATIC_TCH, + BTS_CTR_CM_SERV_REJ, + BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_HLR, + BTS_CTR_CM_SERV_REJ_ILLEGAL_MS, + BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_VLR, + BTS_CTR_CM_SERV_REJ_IMEI_NOT_ACCEPTED, + BTS_CTR_CM_SERV_REJ_ILLEGAL_ME, + BTS_CTR_CM_SERV_REJ_PLMN_NOT_ALLOWED, + BTS_CTR_CM_SERV_REJ_LOC_NOT_ALLOWED, + BTS_CTR_CM_SERV_REJ_ROAMING_NOT_ALLOWED, + BTS_CTR_CM_SERV_REJ_NETWORK_FAILURE, + BTS_CTR_CM_SERV_REJ_SYNCH_FAILURE, + BTS_CTR_CM_SERV_REJ_CONGESTION, + BTS_CTR_CM_SERV_REJ_SRV_OPT_NOT_SUPPORTED, + BTS_CTR_CM_SERV_REJ_RQD_SRV_OPT_NOT_SUPPORTED, + BTS_CTR_CM_SERV_REJ_SRV_OPT_TMP_OUT_OF_ORDER, + BTS_CTR_CM_SERV_REJ_CALL_CAN_NOT_BE_IDENTIFIED, + BTS_CTR_CM_SERV_REJ_INCORRECT_MESSAGE, + BTS_CTR_CM_SERV_REJ_INVALID_MANDANTORY_INF, + BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_IMPLEMENTED, + BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_COMPATIBLE, + BTS_CTR_CM_SERV_REJ_INF_ELEME_NOT_IMPLEMENTED, + BTS_CTR_CM_SERV_REJ_CONDTIONAL_IE_ERROR, + BTS_CTR_CM_SERV_REJ_MSG_NOT_COMPATIBLE, + BTS_CTR_CM_SERV_REJ_PROTOCOL_ERROR, + BTS_CTR_CM_SERV_REJ_RETRY_IN_NEW_CELL, }; extern const struct rate_ctr_desc bts_ctr_description[]; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index c0d621c..0186024 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1007,6 +1007,106 @@ } +/* For 3GPP TS 52.402 unsuccReqsForService, we need to decode the DTAP and count CM Service Reject messages. */ +static void count_unsucc_reqs_for_service(const struct msgb *msg) +{ + struct gsm_bts *bts = msg->lchan->ts->trx->bts; + const struct gsm48_hdr *gh; + uint8_t pdisc, mtype; + uint8_t cause; + + if (msgb_l3len(msg) < sizeof(*gh)) + return; + + gh = msgb_l3(msg); + pdisc = gsm48_hdr_pdisc(gh); + mtype = gsm48_hdr_msg_type(gh); + + if (pdisc != GSM48_PDISC_MM || mtype != GSM48_MT_MM_CM_SERV_REJ) + return; + + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ)); + + cause = gh->data[0]; + switch (cause) { + case GSM48_REJECT_IMSI_UNKNOWN_IN_HLR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_HLR)); + break; + case GSM48_REJECT_ILLEGAL_MS: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_ILLEGAL_MS)); + break; + case GSM48_REJECT_IMSI_UNKNOWN_IN_VLR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_VLR)); + break; + case GSM48_REJECT_IMEI_NOT_ACCEPTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_IMEI_NOT_ACCEPTED)); + break; + case GSM48_REJECT_ILLEGAL_ME: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_ILLEGAL_ME)); + break; + case GSM48_REJECT_PLMN_NOT_ALLOWED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_PLMN_NOT_ALLOWED)); + break; + case GSM48_REJECT_LOC_NOT_ALLOWED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_LOC_NOT_ALLOWED)); + break; + case GSM48_REJECT_ROAMING_NOT_ALLOWED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_ROAMING_NOT_ALLOWED)); + break; + case GSM48_REJECT_NETWORK_FAILURE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_NETWORK_FAILURE)); + break; + case GSM48_REJECT_SYNCH_FAILURE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_SYNCH_FAILURE)); + break; + case GSM48_REJECT_CONGESTION: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_CONGESTION)); + break; + case GSM48_REJECT_SRV_OPT_NOT_SUPPORTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_SRV_OPT_NOT_SUPPORTED)); + break; + case GSM48_REJECT_RQD_SRV_OPT_NOT_SUPPORTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_RQD_SRV_OPT_NOT_SUPPORTED)); + break; + case GSM48_REJECT_SRV_OPT_TMP_OUT_OF_ORDER: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_SRV_OPT_TMP_OUT_OF_ORDER)); + break; + case GSM48_REJECT_CALL_CAN_NOT_BE_IDENTIFIED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_CALL_CAN_NOT_BE_IDENTIFIED)); + break; + case GSM48_REJECT_INCORRECT_MESSAGE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_INCORRECT_MESSAGE)); + break; + case GSM48_REJECT_INVALID_MANDANTORY_INF: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_INVALID_MANDANTORY_INF)); + break; + case GSM48_REJECT_MSG_TYPE_NOT_IMPLEMENTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_IMPLEMENTED)); + break; + case GSM48_REJECT_MSG_TYPE_NOT_COMPATIBLE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_COMPATIBLE)); + break; + case GSM48_REJECT_INF_ELEME_NOT_IMPLEMENTED: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_INF_ELEME_NOT_IMPLEMENTED)); + break; + case GSM48_REJECT_CONDTIONAL_IE_ERROR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_CONDTIONAL_IE_ERROR)); + break; + case GSM48_REJECT_MSG_NOT_COMPATIBLE: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_MSG_NOT_COMPATIBLE)); + break; + default: + if (cause >= 48 && cause <= 63) { + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_RETRY_IN_NEW_CELL)); + break; + } + /* else fall thru */ + case GSM48_REJECT_PROTOCOL_ERROR: + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CM_SERV_REJ_PROTOCOL_ERROR)); + break; + } +} + /* Send "DATA REQUEST" message with given L3 Info payload */ /* Chapter 8.3.1 */ int rsl_data_request(struct msgb *msg, uint8_t link_id) @@ -1019,6 +1119,8 @@ return -EINVAL; } + count_unsucc_reqs_for_service(msg); + chan_nr = gsm_lchan2chan_nr(msg->lchan, true); if (chan_nr < 0) { msgb_free(msg); diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 4dd05a9..71cf4da 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1293,6 +1293,81 @@ [BTS_CTR_ALL_ALLOCATED_STATIC_TCH] = \ { "all_allocated:static_tch", "Cumulative counter of seconds where all non-dynamic TCH channels were allocated" }, + + [BTS_CTR_CM_SERV_REJ] = \ + { "cm_serv_rej", "MSC sent CM Service Reject" }, + [BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_HLR] = \ + { "cm_serv_rej:imsi_unknown_in_hlr", + "MSC sent CM Service Reject with cause IMSI_UNKNOWN_IN_HLR" }, + [BTS_CTR_CM_SERV_REJ_ILLEGAL_MS] = \ + { "cm_serv_rej:illegal_ms", + "MSC sent CM Service Reject with cause ILLEGAL_MS" }, + [BTS_CTR_CM_SERV_REJ_IMSI_UNKNOWN_IN_VLR] = \ + { "cm_serv_rej:imsi_unknown_in_vlr", + "MSC sent CM Service Reject with cause IMSI_UNKNOWN_IN_VLR" }, + [BTS_CTR_CM_SERV_REJ_IMEI_NOT_ACCEPTED] = \ + { "cm_serv_rej:imei_not_accepted", + "MSC sent CM Service Reject with cause IMEI_NOT_ACCEPTED" }, + [BTS_CTR_CM_SERV_REJ_ILLEGAL_ME] = \ + { "cm_serv_rej:illegal_me", + "MSC sent CM Service Reject with cause ILLEGAL_ME" }, + [BTS_CTR_CM_SERV_REJ_PLMN_NOT_ALLOWED] = \ + { "cm_serv_rej:plmn_not_allowed", + "MSC sent CM Service Reject with cause PLMN_NOT_ALLOWED" }, + [BTS_CTR_CM_SERV_REJ_LOC_NOT_ALLOWED] = \ + { "cm_serv_rej:loc_not_allowed", + "MSC sent CM Service Reject with cause LOC_NOT_ALLOWED" }, + [BTS_CTR_CM_SERV_REJ_ROAMING_NOT_ALLOWED] = \ + { "cm_serv_rej:roaming_not_allowed", + "MSC sent CM Service Reject with cause ROAMING_NOT_ALLOWED" }, + [BTS_CTR_CM_SERV_REJ_NETWORK_FAILURE] = \ + { "cm_serv_rej:network_failure", + "MSC sent CM Service Reject with cause NETWORK_FAILURE" }, + [BTS_CTR_CM_SERV_REJ_SYNCH_FAILURE] = \ + { "cm_serv_rej:synch_failure", + "MSC sent CM Service Reject with cause SYNCH_FAILURE" }, + [BTS_CTR_CM_SERV_REJ_CONGESTION] = \ + { "cm_serv_rej:congestion", + "MSC sent CM Service Reject with cause CONGESTION" }, + [BTS_CTR_CM_SERV_REJ_SRV_OPT_NOT_SUPPORTED] = \ + { "cm_serv_rej:srv_opt_not_supported", + "MSC sent CM Service Reject with cause SRV_OPT_NOT_SUPPORTED" }, + [BTS_CTR_CM_SERV_REJ_RQD_SRV_OPT_NOT_SUPPORTED] = \ + { "cm_serv_rej:rqd_srv_opt_not_supported", + "MSC sent CM Service Reject with cause RQD_SRV_OPT_NOT_SUPPORTED" }, + [BTS_CTR_CM_SERV_REJ_SRV_OPT_TMP_OUT_OF_ORDER] = \ + { "cm_serv_rej:srv_opt_tmp_out_of_order", + "MSC sent CM Service Reject with cause SRV_OPT_TMP_OUT_OF_ORDER" }, + [BTS_CTR_CM_SERV_REJ_CALL_CAN_NOT_BE_IDENTIFIED] = \ + { "cm_serv_rej:call_can_not_be_identified", + "MSC sent CM Service Reject with cause CALL_CAN_NOT_BE_IDENTIFIED" }, + [BTS_CTR_CM_SERV_REJ_INCORRECT_MESSAGE] = \ + { "cm_serv_rej:incorrect_message", + "MSC sent CM Service Reject with cause INCORRECT_MESSAGE" }, + [BTS_CTR_CM_SERV_REJ_INVALID_MANDANTORY_INF] = \ + { "cm_serv_rej:invalid_mandantory_inf", + "MSC sent CM Service Reject with cause INVALID_MANDANTORY_INF" }, + [BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_IMPLEMENTED] = \ + { "cm_serv_rej:msg_type_not_implemented", + "MSC sent CM Service Reject with cause MSG_TYPE_NOT_IMPLEMENTED" }, + [BTS_CTR_CM_SERV_REJ_MSG_TYPE_NOT_COMPATIBLE] = \ + { "cm_serv_rej:msg_type_not_compatible", + "MSC sent CM Service Reject with cause MSG_TYPE_NOT_COMPATIBLE" }, + [BTS_CTR_CM_SERV_REJ_INF_ELEME_NOT_IMPLEMENTED] = \ + { "cm_serv_rej:inf_eleme_not_implemented", + "MSC sent CM Service Reject with cause INF_ELEME_NOT_IMPLEMENTED" }, + [BTS_CTR_CM_SERV_REJ_CONDTIONAL_IE_ERROR] = \ + { "cm_serv_rej:condtional_ie_error", + "MSC sent CM Service Reject with cause CONDTIONAL_IE_ERROR" }, + [BTS_CTR_CM_SERV_REJ_MSG_NOT_COMPATIBLE] = \ + { "cm_serv_rej:msg_not_compatible", + "MSC sent CM Service Reject with cause MSG_NOT_COMPATIBLE" }, + [BTS_CTR_CM_SERV_REJ_PROTOCOL_ERROR] = \ + { "cm_serv_rej:protocol_error", + "MSC sent CM Service Reject with cause PROTOCOL_ERROR" }, + [BTS_CTR_CM_SERV_REJ_RETRY_IN_NEW_CELL] = \ + { "cm_serv_rej:retry_in_new_cell", + "MSC sent CM Service Reject with cause 00110000..00111111, Retry upon entry in a new cell" }, }; const struct rate_ctr_group_desc bts_ctrg_desc = { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79b1261e5a281d9797eaaf9c27d90edd8e27c78b Gerrit-Change-Number: 26142 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 11 03:40:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 11 Nov 2021 03:40:36 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618c90c244a4a_6f3a2aaac00b65f4328412@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 290s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 290s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 290s] [ 291s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 291s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 291s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 291s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 291s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 291s] 4/4 Test #4: websocket ........................ Passed 0.87 sec [ 291s] [ 291s] 75% tests passed, 1 tests failed out of 4 [ 291s] [ 291s] Total Test time (real) = 0.95 sec [ 291s] [ 291s] The following tests FAILED: [ 291s] 3 - framework (Failed) [ 291s] Errors while running CTest [ 291s] make[1]: *** [Makefile:129: test] Error 8 [ 291s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 291s] dh_auto_test: error: cd build && make -j8 test ARGS\+=--verbose ARGS\+=-j8 returned exit code 2 [ 291s] make: *** [debian/rules:9: build] Error 25 [ 291s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 291s] ### VM INTERACTION START ### [ 294s] [ 246.617190] sysrq: Power Off [ 294s] [ 246.645089] reboot: Power down [ 294s] ### VM INTERACTION END ### [ 294s] [ 294s] lamb62 failed "build ulfius_2.5.2-4.2.dsc" at Thu Nov 11 03:40:23 UTC 2021. [ 294s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 11 03:41:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 11 Nov 2021 03:41:10 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618c90e14bded_6f3a2aaac00b65f43285ee@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 210s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 210s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 210s] [ 210s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 210s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 210s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 210s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 210s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 210s] 4/4 Test #4: websocket ........................ Passed 0.80 sec [ 210s] [ 210s] 75% tests passed, 1 tests failed out of 4 [ 210s] [ 210s] Total Test time (real) = 0.82 sec [ 210s] [ 210s] The following tests FAILED: [ 210s] 3 - framework (Failed) [ 210s] Errors while running CTest [ 210s] make[1]: *** [Makefile:129: test] Error 8 [ 210s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 210s] dh_auto_test: error: cd build && make -j4 test ARGS\+=--verbose ARGS\+=-j4 returned exit code 2 [ 210s] make: *** [debian/rules:9: build] Error 25 [ 210s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 210s] ### VM INTERACTION START ### [ 213s] [ 163.501921] sysrq: Power Off [ 213s] [ 163.515542] reboot: Power down [ 213s] ### VM INTERACTION END ### [ 213s] [ 213s] cloud102 failed "build ulfius_2.5.2-4.2.dsc" at Thu Nov 11 03:41:04 UTC 2021. [ 213s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:33:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:33:42 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 3: (5 comments) https://gerrit.osmocom.org/c/pysim/+/26165/1/pySim/filesystem.py File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/26165/1/pySim/filesystem.py at 1509 PS1, Line 1509: match_witch_card which, not witch. Halloween is over :P https://gerrit.osmocom.org/c/pysim/+/26165/1/pySim/filesystem.py at 1511 PS1, Line 1511: dirived derived https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py at 31 PS3, Line 31: _ you can simply use CardProfile.__subclasses__() which returns a list of all derived classes of CardProfile. This way it works automatically without having to manually maintain a list here. You also don't even need to import the CardProfileUICC... but a simple "import pySim.ts_102_221" should be sufficient, as then the code is loaded and the subclass is known. https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py at 751 PS3, Line 751: match_witch_card still no witches or witchcraft involved :) I guess you meant "which" https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py at 977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: why have this as a separate method outside of the class, only to wrap it into a @staticmethod below? You could just move this completely inside the @staticmethod below. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 08:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:33:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:33:57 +0000 Subject: Change in pysim[master]: filesystem: CardProfile: initialize empty sw table as empty dict In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26202 ) Change subject: filesystem: CardProfile: initialize empty sw table as empty dict ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3cae83f0f6ab274546991ecd14425f094b2816b2 Gerrit-Change-Number: 26202 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 08:33:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:34:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:34:08 +0000 Subject: Change in pysim[master]: ts_51_011: add status word definition In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26203 ) Change subject: ts_51_011: add status word definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01f2643a93e4a9b2ce2f95134aa5d773179d9b1c Gerrit-Change-Number: 26203 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 08:34:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:37:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:37:39 +0000 Subject: Change in pysim[master]: pySim-shell: guess number of records when not specified In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26204 ) Change subject: pySim-shell: guess number of records when not specified ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG at 7 PS1, Line 7: pySim-shell: guess number of records when not specified I guess the message should state this is only related to the "export" command and not some general problem. https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG at 13 PS1, Line 13: u This is flawed: * a record containing 0xfffff... is an existing record, and not the end of the file * it is perfectly legal to have records filled with ffff e.g. at position 5 and then records filled with valid data in records 6...25. This is what happens if you delete phone book entries or SMS from a card. * end of the file can implicitly only be detected by reading the first invalid record, which will return with a related status word. You then know the last valid record number is one lower than the first failing one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 08:37:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:42:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:42:38 +0000 Subject: Change in pysim[master]: filesystem: CardProfile: initialize empty sw table as empty dict In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26202 ) Change subject: filesystem: CardProfile: initialize empty sw table as empty dict ...................................................................... filesystem: CardProfile: initialize empty sw table as empty dict The table that holds the status word descriptions is initialized as an empty list '[]'. This is not correct since the interpret_sw method processes this data as dictionary, so lets initialize the sw member with an empty dict '{}' when not status word description is given. Change-Id: I3cae83f0f6ab274546991ecd14425f094b2816b2 Related: OS#5274 --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 24872c0..0238c97 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1461,7 +1461,7 @@ self.name = name self.desc = kw.get("desc", None) self.files_in_mf = kw.get("files_in_mf", []) - self.sw = kw.get("sw", []) + self.sw = kw.get("sw", {}) self.applications = kw.get("applications", []) self.shell_cmdsets = kw.get("shell_cmdsets", []) self.cla = kw.get("cla", "00") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3cae83f0f6ab274546991ecd14425f094b2816b2 Gerrit-Change-Number: 26202 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:54:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:54:07 +0000 Subject: Change in pysim[master]: ts_51_011: add status word definition In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26203 ) Change subject: ts_51_011: add status word definition ...................................................................... ts_51_011: add status word definition There is no status word definition given in the SIM profile. Lets add one to be complete Change-Id: I01f2643a93e4a9b2ce2f95134aa5d773179d9b1c --- M pySim/ts_51_011.py 1 file changed, 38 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index c146a79..73d569e 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -976,6 +976,43 @@ class CardProfileSIM(CardProfile): def __init__(self): - super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()]) + sw = { + 'Normal': { + '9000': 'Normal ending of the command', + '91xx': 'normal ending of the command, with extra information from the proactive SIM containing a command for the ME', + '9exx': 'length XX of the response data given in case of a SIM data download error', + '9fxx': 'length XX of the response data', + }, + 'Postponed processing': { + '9300': 'SIM Application Toolkit is busy. Command cannot be executed at present, further normal commands are allowed', + }, + 'Memory management': { + '920x': 'command successful but after using an internal update retry routine X times', + '9240': 'memory problem', + }, + 'Referencing management': { + '9400': 'no EF selected', + '9402': 'out of range (invalid address)', + '9404': 'file ID not found or pattern not found', + '9408': 'file is inconsistent with the command', + }, + 'Security management': { + '9802': 'no CHV initialized', + '9804': 'access condition not fulfilled, unsuccessful CHV verification or authentication failed', + '9808': 'in contradiction with CHV status', + '9810': 'in contradiction with invalidation status', + '9840': 'unsuccessful verification, CHV blocked, UNBLOCK CHV blocked', + '9850': 'increase cannot be performed, Max value reached', + }, + 'Application independent errors': { + '67xx': 'incorrect parameter P3', + '6bxx': 'incorrect parameter P1 or P2', + '6dxx': 'unknown instruction code given in the command', + '6exx': 'wrong instruction class given in the command', + '6fxx': 'technical problem with no diagnostic given', + }, + } + + super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) def decode_select_response(self, data_hex:str) -> Any: return _decode_select_response(data_hex) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01f2643a93e4a9b2ce2f95134aa5d773179d9b1c Gerrit-Change-Number: 26203 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:55:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:55:12 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 08:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:55:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:55:32 +0000 Subject: Change in osmo-pcu[master]: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26198 ) Change subject: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c Gerrit-Change-Number: 26198 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: iedemam Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 11 Nov 2021 08:55:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:55:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:55:53 +0000 Subject: Change in osmo-pcu[master]: pdch: Increase log level of line informing about TS control change In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26200 ) Change subject: pdch: Increase log level of line informing about TS control change ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia32d835ee4c14d7d48391452b5e3d05ed88e0483 Gerrit-Change-Number: 26200 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 08:55:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:56:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:56:13 +0000 Subject: Change in osmo-pcu[master]: tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26201 ) Change subject: tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If475560aab16b0a89743139189ff7720389132a5 Gerrit-Change-Number: 26201 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 08:56:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:58:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:58:17 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c at a545 PS6, Line 545: return rc; I think it doesn't hurt to do the check_bts already at startup time (and then re-check it again on OML startup)? Or is it illegal to call check_bts() several times? The point is that currently the user got an error message right at BSC start-up if check_bts fails, and I think we shouldn't remove that u nless there is a strict reason. bootstrap_bts can of course be removed here and only called during oml startup. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 08:58:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 08:58:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 08:58:38 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26187 ) Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 08:58:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:00:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:00:37 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_ctrl: make sure strtok results are checked In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26127 ) Change subject: osmo_bsc_ctrl: make sure strtok results are checked ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Gerrit-Change-Number: 26127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 09:00:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:00:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:00:39 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_ctrl: make sure strtok results are checked In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26127 ) Change subject: osmo_bsc_ctrl: make sure strtok results are checked ...................................................................... osmo_bsc_ctrl: make sure strtok results are checked The function set_bts_loc does not check the string pointers resturned by strtok_r. In this particular case this is not a problem because the function set_bts_lock will only see verfied input. However, lets check the results anyway to avoid creating false positives in coverity scan. Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Fixes: CID#240849 --- M src/osmo-bsc/osmo_bsc_ctrl.c 1 file changed, 14 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_ctrl.c b/src/osmo-bsc/osmo_bsc_ctrl.c index 1eea690..969efb5 100644 --- a/src/osmo-bsc/osmo_bsc_ctrl.c +++ b/src/osmo-bsc/osmo_bsc_ctrl.c @@ -428,6 +428,20 @@ if (!tmp) goto oom; + tstamp = strtok_r(tmp, ",", &saveptr); + valid = strtok_r(NULL, ",", &saveptr); + lat = strtok_r(NULL, ",", &saveptr); + lon = strtok_r(NULL, ",", &saveptr); + height = strtok_r(NULL, "\0", &saveptr); + + /* Check if one of the strtok results was NULL. This will probably never occur since we will only see verified + * input in this code path */ + if ((tstamp == NULL) || (valid == NULL) || (lat == NULL) || (lon == NULL) || (height == NULL)) { + talloc_free(tmp); + cmd->reply = "parse error"; + return CTRL_CMD_ERROR; + } + curloc = talloc_zero(tall_bsc_ctx, struct bts_location); if (!curloc) { talloc_free(tmp); @@ -435,13 +449,6 @@ } INIT_LLIST_HEAD(&curloc->list); - - tstamp = strtok_r(tmp, ",", &saveptr); - valid = strtok_r(NULL, ",", &saveptr); - lat = strtok_r(NULL, ",", &saveptr); - lon = strtok_r(NULL, ",", &saveptr); - height = strtok_r(NULL, "\0", &saveptr); - curloc->tstamp = atol(tstamp); curloc->valid = get_string_value(bts_loc_fix_names, valid); curloc->lat = atof(lat); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie21c392e0405fc45811c6d55bf5508e9eb6784de Gerrit-Change-Number: 26127 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:00:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:00:55 +0000 Subject: Change in osmo-bts[master]: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26129 ) Change subject: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I89dab55e39fe49c8b4d3afb4b46d1b7f2bf3663c Gerrit-Change-Number: 26129 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 09:00:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:01:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:01:06 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): fix band calculation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26128 ) Change subject: gsm_lchan_interf_meas_calc_avg(): fix band calculation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Gerrit-Change-Number: 26128 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 09:01:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:01:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:01:15 +0000 Subject: Change in osmo-bts[master]: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26129 ) Change subject: oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() ...................................................................... oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() Change-Id: I89dab55e39fe49c8b4d3afb4b46d1b7f2bf3663c --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/oml.c b/src/common/oml.c index 30caad5..a434ad3 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -598,7 +598,7 @@ /* 9.4.25 Interference Level Boundaries */ if (TLVP_PRES_LEN(&tp, NM_ATT_INTERF_BOUND, 6)) { payload = TLVP_VAL(&tp, NM_ATT_INTERF_BOUND); - for (i = 0; i < 6; i++) { + for (i = 0; i < ARRAY_SIZE(bts->interference.boundary); i++) { const int16_t boundary = payload[i]; bts->interference.boundary[i] = -1 * boundary; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I89dab55e39fe49c8b4d3afb4b46d1b7f2bf3663c Gerrit-Change-Number: 26129 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:01:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:01:15 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): fix band calculation In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26128 ) Change subject: gsm_lchan_interf_meas_calc_avg(): fix band calculation ...................................................................... gsm_lchan_interf_meas_calc_avg(): fix band calculation This patch makes osmo-bts bahave similar to ip.access nanoBTS. Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Related: SYS#5313 --- M src/common/lchan.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/lchan.c b/src/common/lchan.c index 29fd247..ec1b175 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -464,8 +464,11 @@ /* Calculate the average of all collected samples */ meas_avg = meas_sum / (int) meas_num; - /* Determine the band using interference boundaries from BSC */ - for (b = 0; b < ARRAY_SIZE(bts->interference.boundary); b++) { + /* 3GPP TS 48.008 defines 5 interference bands, and 6 interference level + * boundaries (0, X1, ... X5). It's not clear how to handle values + * exceeding the outer boundaries (0 or X5), because bands 0 and 6 do + * not exist (sigh). Let's map such values to closest bands 1 and 5. */ + for (b = 1; b < ARRAY_SIZE(bts->interference.boundary) - 1; b++) { if (meas_avg >= bts->interference.boundary[b]) break; /* Current 'b' is the band value */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bcc6d6ba154f82aef95d05fb9af0eab490923c9 Gerrit-Change-Number: 26128 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:02:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:02:24 +0000 Subject: Change in libosmocore[master]: include: add enum for UTRAN cipher In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26106 ) Change subject: include: add enum for UTRAN cipher ...................................................................... include: add enum for UTRAN cipher Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf --- M include/Makefile.am A include/osmocom/crypt/utran_cipher.h 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/Makefile.am b/include/Makefile.am index 7df651a..49402d0 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -64,6 +64,7 @@ osmocom/crypt/auth.h \ osmocom/crypt/gprs_cipher.h \ osmocom/crypt/kdf.h \ + osmocom/crypt/utran_cipher.h \ osmocom/ctrl/control_cmd.h \ osmocom/ctrl/control_if.h \ osmocom/ctrl/ports.h \ diff --git a/include/osmocom/crypt/utran_cipher.h b/include/osmocom/crypt/utran_cipher.h new file mode 100644 index 0000000..7dab3bc --- /dev/null +++ b/include/osmocom/crypt/utran_cipher.h @@ -0,0 +1,19 @@ +/*! \file utran_cipher.h */ + +#pragma once + +/* 3GPP TS 25.413 ? 9.2.1.11 */ +enum osmo_utran_integrity_algo { + OSMO_UTRAN_UIA1 = 0, + OSMO_UTRAN_UIA2 = 1, + _OSMO_UTRAN_UIA_NUM +}; + +/* 3GPP TS 25.413 ? 9.2.1.12 */ +enum osmo_utran_encryption_algo { + OSMO_UTRAN_UEA0 = 0, + OSMO_UTRAN_UEA1 = 1, + OSMO_UTRAN_UEA2 = 2, + _OSMO_UTRAN_UEA_NUM +}; + -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:03:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:03:51 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require encryption into own function In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require encryption into own function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 11 Nov 2021 09:03:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:07:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:07:04 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 3: assigning this to dexter to investigate. In general, the UICC specification is quite clear in the fact that it is not required to specify the full AID. From Section 11.1.1.2 of TS 102 221: > When P1 = '04' (i.e. for selection by AID), a right truncated AID can be specified in the data field. Not sure why this is failing for some older cards in the tester? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Thu, 11 Nov 2021 09:07:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:11:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:11:58 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 ) Change subject: adjust mgcp response context ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c at 187 PS6, Line 187: msgb_reserve(msg, 128); > Ah I see, so there's no msgb_alloc_headroom_c() I guess. There is msgb_alloc_headroom_c() since 2019: commit 179f35702ece13f4ab7fd1b331bef664834d8473 Author: Harald Welte Date: Mon Mar 18 18:38:47 2019 +0100 So I would argue to use it. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 09:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:24:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:24:44 +0000 Subject: Change in pysim[master]: ARA-M related command support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25885 ) Change subject: ARA-M related command support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia9107a4629c3d68320f32bbd4dd26e1f430717da Gerrit-Change-Number: 25885 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: herlesupreeth Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 09:24:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 09:24:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 09:24:47 +0000 Subject: Change in pysim[master]: ARA-M related command support In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/25885 ) Change subject: ARA-M related command support ...................................................................... ARA-M related command support This introduces support for talking to the ARA-M application on a card, as specified in the GlobalPlatform "Secure Element Access Control" specification v1.1. Change-Id: Ia9107a4629c3d68320f32bbd4dd26e1f430717da --- M docs/shell.rst M pySim-shell.py A pySim/ara_m.py 3 files changed, 454 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved herlesupreeth: Looks good to me, but someone else must approve diff --git a/docs/shell.rst b/docs/shell.rst index e5d70a0..3ab1113 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -443,6 +443,94 @@ :func: ADF_USIM.AddlShellCommands.authenticate_parser +ARA-M commands +-------------- + +The ARA-M commands exist to manage the access rules stored in an ARA-M applet on the card. + +ARA-M in the context of SIM cards is primarily used to enable Android UICC Carrier Privileges, +please see https://source.android.com/devices/tech/config/uicc for more details on the background. + + +aram_get_all +~~~~~~~~~~~~ + +Obtain and decode all access rules from the ARA-M applet on the card. + +NOTE: if the total size of the access rules exceeds 255 bytes, this command will fail, as +it doesn't yet implement fragmentation/reassembly on rule retrieval. YMMV + +:: + + pySIM-shell (MF/ADF.ARA-M)> aram_get_all + [ + { + "ResponseAllRefArDO": [ + { + "RefArDO": [ + { + "RefDO": [ + { + "AidRefDO": "ffffffffffff" + }, + { + "DevAppIdRefDO": "e46872f28b350b7e1f140de535c2a8d5804f0be3" + } + ] + }, + { + "ArDO": [ + { + "ApduArDO": { + "generic_access_rule": "always" + } + }, + { + "PermArDO": { + "permissions": "0000000000000001" + } + } + ] + } + ] + } + ] + } + ] + +aram_get_config +~~~~~~~~~~~~~~~ +Perform Config handshake with ARA-M applet: Tell it our version and retrieve its version. + +NOTE: Not supported in all ARA-M implementations. + +.. argparse:: + :module: pySim.ara_m + :func: ADF_ARAM.AddlShellCommands.get_config_parser + + +aram_store_ref_ar_do +~~~~~~~~~~~~~~~~~~~~ +Store a [new] access rule on the ARA-M applet. + +.. argparse:: + :module: pySim.ara_m + :func: ADF_ARAM.AddlShellCommands.store_ref_ar_do_parse + +For example, to store an Android UICC carrier privilege rule for the SHA1 hash of the certificate used to sign the CoIMS android app of Supreeth Herle (https://github.com/herlesupreeth/CoIMS_Wiki) you can use the following command: + +:: + + pySIM-shell (MF/ADF.ARA-M)> aram_store_ref_ar_do --aid FFFFFFFFFFFF --device-app-id E46872F28B350B7E1F140DE535C2A8D5804F0BE3 --android-permissions 0000000000000001 --apdu-always + + +aram_delete_all +~~~~~~~~~~~~~~~ +This command will request deletion of all access rules stored within the +ARA-M applet. Use it with caution, there is no undo. Any rules later +intended must be manually inserted again using `aram_store_ref_ar_do` + + cmd2 settable parameters ------------------------ diff --git a/pySim-shell.py b/pySim-shell.py index 037b843..128c0ea 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -49,6 +49,7 @@ from pySim.ts_102_221 import CardProfileUICC from pySim.ts_31_102 import CardApplicationUSIM from pySim.ts_31_103 import CardApplicationISIM +from pySim.ara_m import CardApplicationARAM from pySim.gsm_r import DF_EIRENE # we need to import this module so that the SysmocomSJA2 sub-class of @@ -86,6 +87,7 @@ profile = CardProfileUICC() profile.add_application(CardApplicationUSIM()) profile.add_application(CardApplicationISIM()) + profile.add_application(CardApplicationARAM()) rs = RuntimeState(card, profile) # FIXME: do this dynamically diff --git a/pySim/ara_m.py b/pySim/ara_m.py new file mode 100644 index 0000000..5dee3e0 --- /dev/null +++ b/pySim/ara_m.py @@ -0,0 +1,364 @@ +# -*- coding: utf-8 -*- + +# without this, pylint will fail when inner classes are used +# within the 'nested' kwarg of our TlvMeta metaclass on python 3.7 :( +# pylint: disable=undefined-variable + +""" +Support for the Secure Element Access Control, specifically the ARA-M inside an UICC. +""" + +# +# Copyright (C) 2021 Harald Welte +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + + +from construct import * +from construct import Optional as COptional +from pySim.construct import * +from pySim.filesystem import * +from pySim.tlv import * + +# various BER-TLV encoded Data Objects (DOs) + +class AidRefDO(BER_TLV_IE, tag=0x4f): + # SEID v1.1 Table 6-3 + _construct = HexAdapter(GreedyBytes) + +class AidRefEmptyDO(BER_TLV_IE, tag=0xc0): + # SEID v1.1 Table 6-3 + pass + +class DevAppIdRefDO(BER_TLV_IE, tag=0xc1): + # SEID v1.1 Table 6-4 + _construct = HexAdapter(GreedyBytes) + +class PkgRefDO(BER_TLV_IE, tag=0xca): + # Android UICC Carrier Privileges specific extension, see https://source.android.com/devices/tech/config/uicc + _construct = Struct('package_name_string'/GreedyString("ascii")) + +class RefDO(BER_TLV_IE, tag=0xe1, nested=[AidRefDO,AidRefEmptyDO,DevAppIdRefDO,PkgRefDO]): + # SEID v1.1 Table 6-5 + pass + +class ApduArDO(BER_TLV_IE, tag=0xd0): + # SEID v1.1 Table 6-8 + def _from_bytes(self, do:bytes): + if len(do) == 1: + if do[0] == 0x00: + self.decoded = {'generic_access_rule': 'never'} + return self.decoded + elif do[0] == 0x01: + self.decoded = {'generic_access_rule': 'always'} + return self.decoded + else: + return ValueError('Invalid 1-byte generic APDU access rule') + else: + if len(do) % 8: + return ValueError('Invalid non-modulo-8 length of APDU filter: %d' % len(do)) + self.decoded['apdu_filter'] = [] + offset = 0 + while offset < len(do): + self.decoded['apdu_filter'] += {'header': b2h(do[offset:offset+4]), + 'mask': b2h(do[offset+4:offset+8])} + self.decoded = res + return res + def _to_bytes(self): + if 'generic_access_rule' in self.decoded: + if self.decoded['generic_access_rule'] == 'never': + return b'\x00' + elif self.decoded['generic_access_rule'] == 'always': + return b'\x01' + else: + return ValueError('Invalid 1-byte generic APDU access rule') + else: + if not 'apdu_filter' in self.decoded: + return ValueError('Invalid APDU AR DO') + filters = self.decoded['apdu_filter'] + res = b'' + for f in filters: + if not 'header' in f or not 'mask' in f: + return ValueError('APDU filter must contain header and mask') + header_b = h2b(f['header']) + mask_b = h2b(f['mask']) + if len(header_b) != 4 or len(mask_b) != 4: + return ValueError('APDU filter header and mask must each be 4 bytes') + res += header_b + mask_b + return res + +class NfcArDO(BER_TLV_IE, tag=0xd1): + # SEID v1.1 Table 6-9 + _construct = Struct('nfc_event_access_rule'/Enum(Int8ub, never=0, always=1)) + +class PermArDO(BER_TLV_IE, tag=0xdb): + # Android UICC Carrier Privileges specific extension, see https://source.android.com/devices/tech/config/uicc + _construct = Struct('permissions'/HexAdapter(Bytes(8))) + +class ArDO(BER_TLV_IE, tag=0xe3, nested=[ApduArDO, NfcArDO, PermArDO]): + # SEID v1.1 Table 6-7 + pass + +class RefArDO(BER_TLV_IE, tag=0xe2, nested=[RefDO, ArDO]): + # SEID v1.1 Table 6-6 + pass + +class ResponseAllRefArDO(BER_TLV_IE, tag=0xff40, nested=[RefArDO]): + # SEID v1.1 Table 4-2 + pass + +class ResponseArDO(BER_TLV_IE, tag=0xff50, nested=[ArDO]): + # SEID v1.1 Table 4-3 + pass + +class ResponseRefreshTagDO(BER_TLV_IE, tag=0xdf20): + # SEID v1.1 Table 4-4 + _construct = Struct('refresh_tag'/HexAdapter(Bytes(8))) + +class DeviceInterfaceVersionDO(BER_TLV_IE, tag=0xe6): + # SEID v1.1 Table 6-12 + _construct = Struct('major'/Int8ub, 'minor'/Int8ub, 'patch'/Int8ub) + +class DeviceConfigDO(BER_TLV_IE, tag=0xe4, nested=[DeviceInterfaceVersionDO]): + # SEID v1.1 Table 6-10 + pass + +class ResponseDeviceConfigDO(BER_TLV_IE, tag=0xff7f, nested=[DeviceConfigDO]): + # SEID v1.1 Table 5-14 + pass + +class AramConfigDO(BER_TLV_IE, tag=0xe5, nested=[DeviceInterfaceVersionDO]): + # SEID v1.1 Table 6-11 + pass + +class ResponseAramConfigDO(BER_TLV_IE, tag=0xdf21, nested=[AramConfigDO]): + # SEID v1.1 Table 4-5 + pass + +class CommandStoreRefArDO(BER_TLV_IE, tag=0xf0, nested=[RefArDO]): + # SEID v1.1 Table 5-2 + pass + +class CommandDelete(BER_TLV_IE, tag=0xf1, nested=[AidRefDO, AidRefEmptyDO, RefDO, RefArDO]): + # SEID v1.1 Table 5-4 + pass + +class CommandUpdateRefreshTagDO(BER_TLV_IE, tag=0xf2): + # SEID V1.1 Table 5-6 + pass + +class CommandRegisterClientAidsDO(BER_TLV_IE, tag=0xf7, nested=[AidRefDO, AidRefEmptyDO]): + # SEID v1.1 Table 5-7 + pass + +class CommandGet(BER_TLV_IE, tag=0xf3, nested=[AidRefDO, AidRefEmptyDO]): + # SEID v1.1 Table 5-8 + pass + +class CommandGetAll(BER_TLV_IE, tag=0xf4): + # SEID v1.1 Table 5-9 + pass + +class CommandGetClientAidsDO(BER_TLV_IE, tag=0xf6): + # SEID v1.1 Table 5-10 + pass + +class CommandGetNext(BER_TLV_IE, tag=0xf5): + # SEID v1.1 Table 5-11 + pass + +class CommandGetDeviceConfigDO(BER_TLV_IE, tag=0xf8): + # SEID v1.1 Table 5-12 + pass + +class ResponseAracAidDO(BER_TLV_IE, tag=0xff70, nested=[AidRefDO, AidRefEmptyDO]): + # SEID v1.1 Table 5-13 + pass + +class BlockDO(BER_TLV_IE, tag=0xe7): + # SEID v1.1 Table 6-13 + _construct = Struct('offset'/Int16ub, 'length'/Int8ub) + + +# SEID v1.1 Table 4-1 +class GetCommandDoCollection(TLV_IE_Collection, nested=[RefDO, DeviceConfigDO]): + pass + +# SEID v1.1 Table 4-2 +class GetResponseDoCollection(TLV_IE_Collection, nested=[ResponseAllRefArDO, ResponseArDO, + ResponseRefreshTagDO, ResponseAramConfigDO]): + pass + +# SEID v1.1 Table 5-1 +class StoreCommandDoCollection(TLV_IE_Collection, + nested=[BlockDO, CommandStoreRefArDO, CommandDelete, + CommandUpdateRefreshTagDO, CommandRegisterClientAidsDO, + CommandGet, CommandGetAll, CommandGetClientAidsDO, + CommandGetNext, CommandGetDeviceConfigDO]): + pass + + +# SEID v1.1 Section 5.1.2 +class StoreResponseDoCollection(TLV_IE_Collection, + nested=[ResponseAllRefArDO, ResponseAracAidDO, ResponseDeviceConfigDO]): + pass + +class ADF_ARAM(CardADF): + def __init__(self, aid='a00000015141434c00', name='ADF.ARA-M', fid=None, sfid=None, + desc='ARA-M Application'): + super().__init__(aid=aid, fid=fid, sfid=sfid, name=name, desc=desc) + self.shell_commands += [self.AddlShellCommands()] + files = [] + self.add_files(files) + + @staticmethod + def xceive_apdu_tlv(tp, hdr:Hexstr, cmd_do, resp_cls, exp_sw='9000'): + """Transceive an APDU with the card, transparently encoding the command data from TLV + and decoding the response data tlv.""" + if cmd_do: + cmd_do_enc = cmd_do.to_ie() + cmd_do_len = len(cmd_do_enc) + if cmd_do_len > 255: + return ValueError('DO > 255 bytes not supported yet') + else: + cmd_do_enc = b'' + cmd_do_len = 0 + c_apdu = hdr + ('%02x' % cmd_do_len) + b2h(cmd_do_enc) + (data, sw) = tp.send_apdu_checksw(c_apdu, exp_sw) + if data: + if resp_cls: + resp_do = resp_cls() + resp_do.from_tlv(h2b(data)) + return resp_do + else: + return data + else: + return None + + @staticmethod + def store_data(tp, do) -> bytes: + """Build the Command APDU for STORE DATA.""" + return ADF_ARAM.xceive_apdu_tlv(tp, '80e29000', do, StoreResponseDoCollection) + + @staticmethod + def get_all(tp): + return ADF_ARAM.xceive_apdu_tlv(tp, '80caff40', None, GetResponseDoCollection) + + @staticmethod + def get_config(tp, v_major=0, v_minor=0, v_patch=1): + cmd_do = DeviceConfigDO() + cmd_do.from_dict([{'DeviceInterfaceVersionDO': {'major': v_major, 'minor': v_minor, 'patch': v_patch }}]) + return ADF_ARAM.xceive_apdu_tlv(tp, '80cadf21', cmd_do, ResponseAramConfigDO) + + @with_default_category('Application-Specific Commands') + class AddlShellCommands(CommandSet): + def __init(self): + super().__init__() + + def do_aram_get_all(self, opts): + """GET DATA [All] on the ARA-M Applet""" + res_do = ADF_ARAM.get_all(self._cmd.card._scc._tp) + if res_do: + self._cmd.poutput_json(res_do.to_dict()) + + def do_aram_get_config(self, opts): + """GET DATA [Config] on the ARA-M Applet""" + res_do = ADF_ARAM.get_config(self._cmd.card._scc._tp) + if res_do: + self._cmd.poutput_json(res_do.to_dict()) + + store_ref_ar_do_parse = argparse.ArgumentParser() + # REF-DO + store_ref_ar_do_parse.add_argument('--device-app-id', required=True, help='Identifies the specific device application that the rule appplies to. Hash of Certificate of Application Provider, or UUID. (20/32 hex bytes)') + aid_grp = store_ref_ar_do_parse.add_mutually_exclusive_group() + aid_grp.add_argument('--aid', help='Identifies the specific SE application for which rules are to be stored. Can be a partial AID, containing for example only the RID. (5-16 hex bytes)') + aid_grp.add_argument('--aid-empty', action='store_true', help='No specific SE application, applies to all applications') + store_ref_ar_do_parse.add_argument('--pkg-ref', help='Full Android Java package name (up to 127 chars ASCII)') + # AR-DO + apdu_grp = store_ref_ar_do_parse.add_mutually_exclusive_group() + apdu_grp.add_argument('--apdu-never', action='store_true', help='APDU access is not allowed') + apdu_grp.add_argument('--apdu-always', action='store_true', help='APDU access is allowed') + apdu_grp.add_argument('--apdu-filter', help='APDU filter: 4 byte CLA/INS/P1/P2 followed by 4 byte mask (8 hex bytes)') + nfc_grp = store_ref_ar_do_parse.add_mutually_exclusive_group() + nfc_grp.add_argument('--nfc-always', action='store_true', help='NFC event access is allowed') + nfc_grp.add_argument('--nfc-never', action='store_true', help='NFC event access is not allowed') + store_ref_ar_do_parse.add_argument('--android-permissions', help='Android UICC Carrier Privilege Permissions (8 hex bytes)') + + @cmd2.with_argparser(store_ref_ar_do_parse) + def do_aram_store_ref_ar_do(self, opts): + """Perform STORE DATA [Command-Store-REF-AR-DO] to store a new access rule.""" + # REF + ref_do_content = [] + if opts.aid: + ref_do_content += [{'AidRefDO': opts.aid}] + elif opts.aid_empty: + ref_do_content += [{'AidRefEmptyDO': None}] + ref_do_content += [{'DevAppIdRefDO': opts.device_app_id}] + if opts.pkg_ref: + ref_do_content += [{'PkgRefDO': opts.pkg_ref}] + # AR + ar_do_content = [] + if opts.apdu_never: + ar_do_content += [{'ApduArDO': {'generic_access_rule': 'never'}}] + elif opts.apdu_always: + ar_do_content += [{'ApduArDO': {'generic_access_rule': 'always'}}] + elif opts.apdu_filter: + # TODO: multiple filters + ar_do_content += [{'ApduArDO': {'apdu_filter': [opts.apdu_filter]}}] + if opts.nfc_always: + ar_do_content += [{'NfcArDO': {'nfc_event_access_rule': 'always'}}] + elif opts.nfc_never: + ar_do_content += [{'NfcArDO': {'nfc_event_access_rule': 'never'}}] + if opts.android_permissions: + ar_do_content += [{'PermArDO': {'permissions': opts.android_permissions}}] + d = [{'RefArDO': [{ 'RefDO': ref_do_content}, {'ArDO': ar_do_content }]}] + csrado = CommandStoreRefArDO() + csrado.from_dict(d) + res_do = ADF_ARAM.store_data(self._cmd.card._scc._tp, csrado) + if res_do: + self._cmd.poutput_json(res_do.to_dict()) + + def do_aram_delete_all(self, opts): + """Perform STORE DATA [Command-Delete[all]] to delete all access rules.""" + deldo = CommandDelete() + res_do = ADF_ARAM.store_data(self._cmd.card._scc._tp, deldo) + if res_do: + self._cmd.poutput_json(res_do.to_dict()) + + +# SEAC v1.1 Section 4.1.2.2 + 5.1.2.2 +sw_aram = { + 'ARA-M': { + '6381': 'Rule successfully stored but an access rule already exists', + '6382': 'Rule successfully stored bu contained at least one unknown (discarded) BER-TLV', + '6581': 'Memory Problem', + '6700': 'Wrong Length in Lc', + '6981': 'DO is not supported by the ARA-M/ARA-C', + '6982': 'Security status not satisfied', + '6984': 'Rules have been updated and must be read again / logical channels in use', + '6985': 'Conditions not satisfied', + '6a80': 'Incorrect values in the command data', + '6a84': 'Rules have been updated and must be read again', + '6a86': 'Incorrect P1 P2', + '6a88': 'Referenced data not found', + '6a89': 'Conflicting access rule already exists in the Secure Element', + '6d00': 'Invalid instruction', + '6e00': 'Invalid class', + } +} + +class CardApplicationARAM(CardApplication): + def __init__(self): + super().__init__('ARA-M', adf=ADF_ARAM(), sw=sw_aram) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia9107a4629c3d68320f32bbd4dd26e1f430717da Gerrit-Change-Number: 25885 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: herlesupreeth Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:41:29 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 11 Nov 2021 11:41:29 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26165 to look at the new patch set (#4). Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 5 files changed, 166 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:41:29 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 11 Nov 2021 11:41:29 +0000 Subject: Change in pysim[master]: pySim-shell: export command: guess number of records when not specified In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26204 to look at the new patch set (#2). Change subject: pySim-shell: export command: guess number of records when not specified ...................................................................... pySim-shell: export command: guess number of records when not specified The select response of an UICC will always return the number of records of a file. However, older SIM will not include the number of records in the select response. In those cases, simply guess the number of records by reading until the first invalid record is hit. Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Related: OS#5274 --- M pySim-shell.py 1 file changed, 22 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/26204/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:41:30 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 11 Nov 2021 11:41:30 +0000 Subject: Change in pysim[master]: ts_51_011: move _decode_select_response into profile class References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26205 ) Change subject: ts_51_011: move _decode_select_response into profile class ...................................................................... ts_51_011: move _decode_select_response into profile class The method decode_select_response just calls the function _decode_select_response. But the function _decode_select_response is not called from any other location, so we can move it into the profile class. Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11 --- M pySim/ts_51_011.py 1 file changed, 38 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/05/26205/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 2742218..3bec516 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -932,48 +932,6 @@ ] self.add_files(files) - - -def _decode_select_response(resp_hex): - - resp_bin = h2b(resp_hex) - struct_of_file_map = { - 0: 'transparent', - 1: 'linear_fixed', - 3: 'cyclic' - } - type_of_file_map = { - 1: 'mf', - 2: 'df', - 4: 'working_ef' - } - ret = { - 'file_descriptor': {}, - 'proprietary_info': {}, - } - ret['file_id'] = b2h(resp_bin[4:6]) - ret['proprietary_info']['available_memory'] = int.from_bytes(resp_bin[2:4], 'big') - file_type = type_of_file_map[resp_bin[6]] if resp_bin[6] in type_of_file_map else resp_bin[6] - ret['file_descriptor']['file_type'] = file_type - if file_type in ['mf', 'df']: - ret['file_characteristics'] = b2h(resp_bin[13:14]) - ret['num_direct_child_df'] = resp_bin[14] - ret['num_direct_child_ef'] = resp_bin[15] - ret['num_chv_unblock_adm_codes'] = int(resp_bin[16]) - # CHV / UNBLOCK CHV stats - elif file_type in ['working_ef']: - file_struct = struct_of_file_map[resp_bin[13]] if resp_bin[13] in struct_of_file_map else resp_bin[13] - ret['file_descriptor']['structure'] = file_struct - ret['access_conditions'] = b2h(resp_bin[8:10]) - if resp_bin[11] & 0x01 == 0: - ret['life_cycle_status_int'] = 'operational_activated' - elif resp_bin[11] & 0x04: - ret['life_cycle_status_int'] = 'operational_deactivated' - else: - ret['life_cycle_status_int'] = 'terminated' - - return ret - class CardProfileSIM(CardProfile): def __init__(self): sw = { @@ -1014,8 +972,44 @@ } super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) - def decode_select_response(self, data_hex:str) -> Any: - return _decode_select_response(data_hex) + + def decode_select_response(self, resp_hex:str) -> Any: + resp_bin = h2b(resp_hex) + struct_of_file_map = { + 0: 'transparent', + 1: 'linear_fixed', + 3: 'cyclic' + } + type_of_file_map = { + 1: 'mf', + 2: 'df', + 4: 'working_ef' + } + ret = { + 'file_descriptor': {}, + 'proprietary_info': {}, + } + ret['file_id'] = b2h(resp_bin[4:6]) + ret['proprietary_info']['available_memory'] = int.from_bytes(resp_bin[2:4], 'big') + file_type = type_of_file_map[resp_bin[6]] if resp_bin[6] in type_of_file_map else resp_bin[6] + ret['file_descriptor']['file_type'] = file_type + if file_type in ['mf', 'df']: + ret['file_characteristics'] = b2h(resp_bin[13:14]) + ret['num_direct_child_df'] = resp_bin[14] + ret['num_direct_child_ef'] = resp_bin[15] + ret['num_chv_unblock_adm_codes'] = int(resp_bin[16]) + # CHV / UNBLOCK CHV stats + elif file_type in ['working_ef']: + file_struct = struct_of_file_map[resp_bin[13]] if resp_bin[13] in struct_of_file_map else resp_bin[13] + ret['file_descriptor']['structure'] = file_struct + ret['access_conditions'] = b2h(resp_bin[8:10]) + if resp_bin[11] & 0x01 == 0: + ret['life_cycle_status_int'] = 'operational_activated' + elif resp_bin[11] & 0x04: + ret['life_cycle_status_int'] = 'operational_deactivated' + else: + ret['life_cycle_status_int'] = 'terminated' + return ret @staticmethod def match_with_card(scc:SimCardCommands) -> bool: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11 Gerrit-Change-Number: 26205 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:41:30 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 11 Nov 2021 11:41:30 +0000 Subject: Change in pysim[master]: commands: use send_apdu_checksw() in method read_record References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26206 ) Change subject: commands: use send_apdu_checksw() in method read_record ...................................................................... commands: use send_apdu_checksw() in method read_record At the moment the non checking send_apdu() method is used when records are read. Lets use read_record_checksw so that we get an exception in case there is a problem to read the specified record. Change-Id: I9fc411e1b12e8d9fd89b9964209808c0706011bd --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/06/26206/1 diff --git a/pySim/commands.py b/pySim/commands.py index cea330e..674e184 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -228,7 +228,7 @@ r = self.select_path(ef) rec_length = self.__record_len(r) pdu = self.cla_byte + 'b2%02x04%02x' % (rec_no, rec_length) - return self._tp.send_apdu(pdu) + return self._tp.send_apdu_checksw(pdu) def update_record(self, ef, rec_no:int, data:str, force_len:bool=False, verify:bool=False, conserve:bool=False): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9fc411e1b12e8d9fd89b9964209808c0706011bd Gerrit-Change-Number: 26206 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:42:20 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 11 Nov 2021 11:42:20 +0000 Subject: Change in pysim[master]: pySim-shell: export command: guess number of records when not specified In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26204 ) Change subject: pySim-shell: export command: guess number of records when not specified ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG at 7 PS1, Line 7: pySim-shell: guess number of records when not specified > I guess the message should state this is only related to the "export" command and not some general p [?] Done https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG at 13 PS1, Line 13: u > This is flawed: [?] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 11:42:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:43:58 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 11 Nov 2021 11:43:58 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py at 31 PS3, Line 31: _ > you can simply use CardProfile. [?] I don't think that it is so simple. The order matches. With __subclasses__() we get a random order. Also it seems to return only classes directly inherited from CardProfile, but the CardProfileUICCSIM is inherited from CardProfileUICC and does not appear in the list. import pySim.ts_102_221 did not work, but from pySim.ts_102_221 import * worked. However, if using __subclasses__() does not work its probably better to list the classes individually anyway. https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py at 751 PS3, Line 751: match_witch_card > still no witches or witchcraft involved :) I guess you meant "which" oops. I ment "with" https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py at 977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: > why have this as a separate method outside of the class, only to wrap it into a @staticmethod below? [?] I thought that this would help to make the actual class more readable because it is shorter then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 11:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:53:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 11:53:07 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26199/2/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/2/src/gb/gprs_ns2.c at 1407 PS2, Line 1407: /* wait until both data_weight and sig_weight are != 0 before declaring NSE as alive */ so if nse is null, it goes over here and crashes when accessing nse->sum_data_weigth. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 11:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:53:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 11:53:50 +0000 Subject: Change in osmo-pcu[master]: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26198 ) Change subject: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA ...................................................................... pdch: Drop previous UL TBF from MS who sent PktResReq through SBA If the MS has a pending UL TBF but we just received a PktResReq on an allocated SBA from it (same TLLI, hence same MS), then it means it allocated the SBA through RACH req and hence it was on CCCH. That means it was not active on any PDCH, hence for sure the previous UL TBF can be dropped. Related: OS#5293 Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c --- M src/pdch.cpp 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/pdch.cpp b/src/pdch.cpp index 4d82ab1..c48b078 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -680,6 +680,16 @@ "MS requests UL TBF throguh SBA\n", fn); ms_set_ta(ms, sba->ta); sba_free(sba); + /* If MS identified by TLLI sent us a PktResReq through SBA, it means it came + * from CCCH, so it's for sure not using previous UL + * TBF; drop it if it still exits on our end: */ + if ((ul_tbf = ms_ul_tbf(ms))) { + /* Get rid of previous finished UL TBF before providing a new one */ + LOGPTBFUL(ul_tbf, LOGL_NOTICE, + "Got PACKET RESOURCE REQ while TBF not finished, killing pending UL TBF\n"); + tbf_free(ul_tbf); + ul_tbf = NULL; + } /* MS seized the PDCH answering on the SBA: */ bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c Gerrit-Change-Number: 26198 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: iedemam Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:53:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 11:53:53 +0000 Subject: Change in osmo-pcu[master]: pdch: Increase log level of line informing about TS control change In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26200 ) Change subject: pdch: Increase log level of line informing about TS control change ...................................................................... pdch: Increase log level of line informing about TS control change This way it's the same log level as the one used in all other paths using tbf_assign_control_ts() to assign tbf->control_ts = tbf->first_common_ts, and this specific event is not lost from logs. Change-Id: Ia32d835ee4c14d7d48391452b5e3d05ed88e0483 --- M src/pdch.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/pdch.cpp b/src/pdch.cpp index c48b078..a942b01 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -763,7 +763,7 @@ * sent to tbf_fsm which will call tbf_assign_control_ts(), * effectively setting back control_ts to * tbf->initial_common_ts. */ - LOGPTBF(ul_tbf, LOGL_DEBUG, "change control TS %d -> %d until assignment is complete.\n", + LOGPTBF(ul_tbf, LOGL_INFO, "change control TS %d -> %d until assignment is complete.\n", ul_tbf->control_ts, ts_no); ul_tbf->control_ts = ts_no; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia32d835ee4c14d7d48391452b5e3d05ed88e0483 Gerrit-Change-Number: 26200 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:53:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 11:53:54 +0000 Subject: Change in osmo-pcu[master]: tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26201 ) Change subject: tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for new one Change-Id: If475560aab16b0a89743139189ff7720389132a5 --- M src/tbf_ul_ass_fsm.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index ab23fbd..d2dea46 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -110,7 +110,12 @@ }; bitvec_unhex(&bv, DUMMY_VEC); - LOGPTBFUL((const struct gprs_rlcmac_tbf *)new_tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); + if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_tbf) + LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH) for %s\n", + tbf_name((const struct gprs_rlcmac_tbf *)new_tbf)); + else + LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); + mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); tlli = ms_tlli(ms); write_packet_uplink_assignment(mac_control_block, tbf_tfi(ctx->tbf), -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If475560aab16b0a89743139189ff7720389132a5 Gerrit-Change-Number: 26201 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:54:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 11:54:19 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: ping 4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 11:54:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:55:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 11:55:57 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c at a545 PS6, Line 545: return rc; > I think it doesn't hurt to do the check_bts already at startup time (and then re-check it again on O [?] Makes sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 11:55:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 11:57:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 11:57:12 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 ) Change subject: adjust mgcp response context ...................................................................... Patch Set 6: -Code-Review Then please do use it. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 11:57:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 12:19:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 11 Nov 2021 12:19:04 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c at a213 PS3, Line 213: if (i < ts->max_primary_lchans) Can we do the check this way? if (i < ts->max_primary_lchans || i >= max_lchans_possible_vamos) lchan->vamos.is_secondary = false; else lchan->vamos.is_secondary = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 12:19:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 12:29:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 12:29:28 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26207 ) Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 --- M src/tbf_dl_ass_fsm.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/26207/1 diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index 37ced61..b7b3d88 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -77,9 +77,6 @@ return NULL; } - if (new_dl_tbf == as_dl_tbf(ctx->tbf)) - LOGPTBF(ctx->tbf, LOGL_DEBUG, "New and old TBF are the same.\n"); - if (old_tfi_is_valid && ms_tlli(ms) == GSM_RESERVED_TMSI) { LOGPTBF(ctx->tbf, LOGL_ERROR, "The old TFI is not assigned and there is no TLLI. New TBF %s\n", @@ -99,7 +96,12 @@ }; bitvec_unhex(&bv, DUMMY_VEC); - LOGPTBF((struct gprs_rlcmac_tbf *)new_dl_tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); + if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_tbf) + LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n", + tbf_name((const struct gprs_rlcmac_tbf *)new_tbf)); + else + LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); + mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); write_packet_downlink_assignment(mac_control_block, old_tfi_is_valid, tbf_tfi(ctx->tbf), (tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF), -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 Gerrit-Change-Number: 26207 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 12:29:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 12:29:28 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26208 ) Change subject: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent ...................................................................... tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent If by the time the PktDlAss is to be scheduled by the scheduler the DL TBF is gone, the FSM will abort the assignment and go back to state NONE. However, the transition was missing, ending up in the scheduler trying to schedule the message unsuccessfuly lots of times per second, clogging the logs and disrupting normal operation. Related: OS#5293 Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 --- M src/tbf_dl_ass_fsm.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/26208/1 diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index b7b3d88..18db659 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -208,7 +208,9 @@ }, [TBF_DL_ASS_SEND_ASS] = { .in_event_mask = X(TBF_DL_ASS_EV_CREATE_RLCMAC_MSG), - .out_state_mask = X(TBF_DL_ASS_WAIT_ACK), + .out_state_mask = + X(TBF_DL_ASS_WAIT_ACK) | + X(TBF_DL_ASS_NONE), .name = "SEND_ASS", .action = st_send_ass, }, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 Gerrit-Change-Number: 26208 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 12:40:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 12:40:20 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 to look at the new patch set (#2). Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 --- M src/tbf_dl_ass_fsm.c M tests/tbf/TbfTest.err 2 files changed, 10 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/26207/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 Gerrit-Change-Number: 26207 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 12:50:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 12:50:08 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c at a213 PS3, Line 213: if (i < ts->max_primary_lchans) > Can we do the check this way? [?] No, because AFAIK max_lchans_possible_vamos is the count of maximum secondary lchan possible, but they are located AFTER the primary ones. I guess it could be written: if (i < ts->max_primary_lchans || i >= (ts->max_primary_lchans + max_lchans_possible_vamos)) lchan->vamos.is_secondary = false; else lchan->vamos.is_secondary = true; But in the end it's the same as what I wrote, just switching the branches. And IMHO it makes more sense to have the =true branch in the "if" condition, since that's the main purpose of the loop (or at least what it does from changing the expected default value). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 12:50:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 13:11:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 13:11:46 +0000 Subject: Change in osmo-pcu[master]: cosmetic: gprs_pcu.h: Fix typo in comment References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26209 ) Change subject: cosmetic: gprs_pcu.h: Fix typo in comment ...................................................................... cosmetic: gprs_pcu.h: Fix typo in comment Change-Id: I7140decb50e822bf412fa380dc8b6ef6486a5681 --- M src/gprs_pcu.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/09/26209/1 diff --git a/src/gprs_pcu.h b/src/gprs_pcu.h index 86fe8eb..fdcf5f7 100644 --- a/src/gprs_pcu.h +++ b/src/gprs_pcu.h @@ -118,7 +118,7 @@ struct gsmtap_inst *gsmtap; uint32_t gsmtap_categ_mask; - struct llist_head bts_list; /* list of gprs_rlcmac_tbf */ + struct llist_head bts_list; /* list of gprs_rlcmac_bts */ struct gprs_ns2_inst *nsi; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7140decb50e822bf412fa380dc8b6ef6486a5681 Gerrit-Change-Number: 26209 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 15:53:28 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 11 Nov 2021 15:53:28 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26199 to look at the new patch set (#3). Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails alive_timeout_handler() changes the state to RECOVERING which calls ns2_st_alive_onenter()->ns2_nse_notify_unblocked(unblocked=false)-> ns2_sns_notify_alive(unblocked=false) When all (signalling) NSVCs have failed and gss->role is SGSN and not persistent sns_failed() calls gprs_ns2_free_nse() which talloc_free()s the nse before returning. The next line in ns2_nse_notify_unblocked() tries to read nse->alive which then causes the use-after-free. Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Related: OS#5302 --- M src/gb/gprs_ns2.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/26199/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 15:53:29 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 11 Nov 2021 15:53:29 +0000 Subject: Change in libosmocore[master]: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26211 ) Change subject: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct ...................................................................... frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct Fix typo and remove any reference to GRE from gprs_ns2_fr.c. GRE code is in gprs_ns2_frgre.c Change-Id: I51c756f3c9d918552591bf87861cb4799721ac37 --- M src/gb/frame_relay.c M src/gb/gprs_ns2_fr.c 2 files changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/26211/1 diff --git a/src/gb/frame_relay.c b/src/gb/frame_relay.c index 4d1df67..2c252fd 100644 --- a/src/gb/frame_relay.c +++ b/src/gb/frame_relay.c @@ -652,7 +652,7 @@ /* check for mandatory IEs */ if (!TLVP_PRES_LEN(tp, Q933_IEI_REPORT_TYPE, 1)) { - LOGPFRL(link, LOGL_NOTICE, "Rx STATUSL: Missing TLV Q933 Report Type\n"); + LOGPFRL(link, LOGL_NOTICE, "Rx STATUS: Missing TLV Q933 Report Type\n"); return -1; } diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c index 35e0dd9..4e848be 100644 --- a/src/gb/gprs_ns2_fr.c +++ b/src/gb/gprs_ns2_fr.c @@ -83,11 +83,6 @@ /* nanoseconds per bit (504) */ #define BIT_DURATION_NS (1000000000 / SUPERCHANNEL_LINERATE) -struct gre_hdr { - uint16_t flags; - uint16_t ptype; -} __attribute__ ((packed)); - static void free_bind(struct gprs_ns2_vc_bind *bind); static int fr_dlci_rx_cb(void *cb_data, struct msgb *msg); @@ -256,13 +251,13 @@ if (!(what & OSMO_FD_READ)) return 0; - msg = msgb_alloc(NS_ALLOC_SIZE, "Gb/NS/FR/GRE Rx"); + msg = msgb_alloc(NS_ALLOC_SIZE, "Gb/NS/FR Rx"); if (!msg) return -ENOMEM; rc = recvfrom(bfd->fd, msg->data, NS_ALLOC_SIZE, 0, (struct sockaddr *)&sll, &sll_len); if (rc < 0) { - LOGBIND(bind, LOGL_ERROR, "recv error %s during NS-FR-GRE recv\n", strerror(errno)); + LOGBIND(bind, LOGL_ERROR, "recv error %s during NS-FR recv\n", strerror(errno)); goto out_err; } else if (rc == 0) { goto out_err; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51c756f3c9d918552591bf87861cb4799721ac37 Gerrit-Change-Number: 26211 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 17:14:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 17:14:10 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 17:14:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 17:14:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 17:14:44 +0000 Subject: Change in libosmocore[master]: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26211 ) Change subject: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51c756f3c9d918552591bf87861cb4799721ac37 Gerrit-Change-Number: 26211 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 17:14:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 17:25:30 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Nov 2021 17:25:30 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 17:25:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 17:26:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Nov 2021 17:26:14 +0000 Subject: Change in libosmocore[master]: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26211 ) Change subject: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51c756f3c9d918552591bf87861cb4799721ac37 Gerrit-Change-Number: 26211 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 17:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 17:30:30 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Nov 2021 17:30:30 +0000 Subject: Change in osmo-pcu[master]: cosmetic: gprs_pcu.h: Fix typo in comment In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26209 ) Change subject: cosmetic: gprs_pcu.h: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7140decb50e822bf412fa380dc8b6ef6486a5681 Gerrit-Change-Number: 26209 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 17:30:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:22:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:22:35 +0000 Subject: Change in pysim[master]: pySim-shell: export command: guess number of records when not specified In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26204 ) Change subject: pySim-shell: export command: guess number of records when not specified ...................................................................... Patch Set 2: ************* Module pySim-shell pySim-shell.py:536:10: E1101: Instance of 'Exception' has no 'sw_actual' member (no-member) Build step 'Execute shell' marked build as failure -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 18:22:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:27:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:27:49 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py at 31 PS3, Line 31: _ > I don't think that it is so simple. The order matches. With __subclasses__() we get a random order. [?] Ok, then it's not that simple, I stand corrected. I still think there should be more elegant ways than manually maintaining a list of those classes, but we can revisit that at a later point, and shouldn't postpone this patch for this. https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py at 977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: > I thought that this would help to make the actual class more readable because it is shorter then. sorry, but this argument doesn't hold up. In this line of thinking, every method of every class would first be defined as a global/public function, and then called from the class. I would argue that in OO programming you want to avoid any global/public functions in general, and everything should be methods (normal, staticemthod, classmethod). In reality you may need some functions, but unless there is a clear-cut use case for a non-OO function, the code should be a method. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 18:27:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:28:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:28:03 +0000 Subject: Change in pysim[master]: ts_51_011: move _decode_select_response into profile class In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26205 ) Change subject: ts_51_011: move _decode_select_response into profile class ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11 Gerrit-Change-Number: 26205 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 18:28:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:28:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:28:30 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Nov 2021 18:28:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:28:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:28:41 +0000 Subject: Change in pysim[master]: commands: use send_apdu_checksw() in method read_record In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26206 ) Change subject: commands: use send_apdu_checksw() in method read_record ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9fc411e1b12e8d9fd89b9964209808c0706011bd Gerrit-Change-Number: 26206 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Nov 2021 18:28:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:29:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:29:24 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 18:29:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:29:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:29:40 +0000 Subject: Change in libosmocore[master]: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26211 ) Change subject: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51c756f3c9d918552591bf87861cb4799721ac37 Gerrit-Change-Number: 26211 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 18:29:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:29:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:29:42 +0000 Subject: Change in libosmocore[master]: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails alive_timeout_handler() changes the state to RECOVERING which calls ns2_st_alive_onenter()->ns2_nse_notify_unblocked(unblocked=false)-> ns2_sns_notify_alive(unblocked=false) When all (signalling) NSVCs have failed and gss->role is SGSN and not persistent sns_failed() calls gprs_ns2_free_nse() which talloc_free()s the nse before returning. The next line in ns2_nse_notify_unblocked() tries to read nse->alive which then causes the use-after-free. Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Related: OS#5302 --- M src/gb/gprs_ns2.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 3bb04ae..02d2266 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -1392,11 +1392,16 @@ void ns2_nse_notify_unblocked(struct gprs_ns2_vc *nsvc, bool unblocked) { struct gprs_ns2_nse *nse = nsvc->nse; + struct gprs_ns2_inst *nsi = nse->nsi; + uint16_t nsei = nse->nsei; ns2_nse_data_sum(nse); ns2_sns_notify_alive(nse, nsvc, unblocked); - if (unblocked == nse->alive) + /* NSE could have been freed, try to get it again */ + nse = gprs_ns2_nse_by_nsei(nsi, nsei); + + if (!nse || unblocked == nse->alive) return; /* wait until both data_weight and sig_weight are != 0 before declaring NSE as alive */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:29:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:29:42 +0000 Subject: Change in libosmocore[master]: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26211 ) Change subject: frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct ...................................................................... frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct Fix typo and remove any reference to GRE from gprs_ns2_fr.c. GRE code is in gprs_ns2_frgre.c Change-Id: I51c756f3c9d918552591bf87861cb4799721ac37 --- M src/gb/frame_relay.c M src/gb/gprs_ns2_fr.c 2 files changed, 3 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/gb/frame_relay.c b/src/gb/frame_relay.c index 4d1df67..2c252fd 100644 --- a/src/gb/frame_relay.c +++ b/src/gb/frame_relay.c @@ -652,7 +652,7 @@ /* check for mandatory IEs */ if (!TLVP_PRES_LEN(tp, Q933_IEI_REPORT_TYPE, 1)) { - LOGPFRL(link, LOGL_NOTICE, "Rx STATUSL: Missing TLV Q933 Report Type\n"); + LOGPFRL(link, LOGL_NOTICE, "Rx STATUS: Missing TLV Q933 Report Type\n"); return -1; } diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c index 35e0dd9..4e848be 100644 --- a/src/gb/gprs_ns2_fr.c +++ b/src/gb/gprs_ns2_fr.c @@ -83,11 +83,6 @@ /* nanoseconds per bit (504) */ #define BIT_DURATION_NS (1000000000 / SUPERCHANNEL_LINERATE) -struct gre_hdr { - uint16_t flags; - uint16_t ptype; -} __attribute__ ((packed)); - static void free_bind(struct gprs_ns2_vc_bind *bind); static int fr_dlci_rx_cb(void *cb_data, struct msgb *msg); @@ -256,13 +251,13 @@ if (!(what & OSMO_FD_READ)) return 0; - msg = msgb_alloc(NS_ALLOC_SIZE, "Gb/NS/FR/GRE Rx"); + msg = msgb_alloc(NS_ALLOC_SIZE, "Gb/NS/FR Rx"); if (!msg) return -ENOMEM; rc = recvfrom(bfd->fd, msg->data, NS_ALLOC_SIZE, 0, (struct sockaddr *)&sll, &sll_len); if (rc < 0) { - LOGBIND(bind, LOGL_ERROR, "recv error %s during NS-FR-GRE recv\n", strerror(errno)); + LOGBIND(bind, LOGL_ERROR, "recv error %s during NS-FR recv\n", strerror(errno)); goto out_err; } else if (rc == 0) { goto out_err; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51c756f3c9d918552591bf87861cb4799721ac37 Gerrit-Change-Number: 26211 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:33:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Nov 2021 18:33:00 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c at 425 PS2, Line 425: for (int i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { > Ack I also noticed both of these but decided not to comment on it to avoid further delays. This is the kind of "sense of coding style" that I would assume every one of us should have from working in this code base for many years. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 18:33:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 18:56:52 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Nov 2021 18:56:52 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c at 425 PS2, Line 425: for (int i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { > I also noticed both of these but decided not to comment on it to avoid further delays. [?] Yeah I'm sorry I'm just used to properly scope variables instead of cluttering parent scopes for absolutely no reason and forgot to undo that. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Nov 2021 18:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 11 19:35:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 11 Nov 2021 19:35:22 +0000 Subject: Change in osmo-pcu[master]: cosmetic: gprs_pcu.h: Fix typo in comment In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26209 ) Change subject: cosmetic: gprs_pcu.h: Fix typo in comment ...................................................................... cosmetic: gprs_pcu.h: Fix typo in comment Change-Id: I7140decb50e822bf412fa380dc8b6ef6486a5681 --- M src/gprs_pcu.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/gprs_pcu.h b/src/gprs_pcu.h index 86fe8eb..fdcf5f7 100644 --- a/src/gprs_pcu.h +++ b/src/gprs_pcu.h @@ -118,7 +118,7 @@ struct gsmtap_inst *gsmtap; uint32_t gsmtap_categ_mask; - struct llist_head bts_list; /* list of gprs_rlcmac_tbf */ + struct llist_head bts_list; /* list of gprs_rlcmac_bts */ struct gprs_ns2_inst *nsi; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7140decb50e822bf412fa380dc8b6ef6486a5681 Gerrit-Change-Number: 26209 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 00:09:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 00:09:02 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries ...................................................................... Patch Set 5: While answering Neels' questions I realized that my approach is overcomplicated. It works as expected, but the code is harder to understand (e.g why 6 - i), and performance gain is not clear. Rolling back to the initial approach by Neels. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Fri, 12 Nov 2021 00:09:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 00:09:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 00:09:08 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 to look at the new patch set (#6). Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries ...................................................................... gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries The order of interference level boundaries is not clearly defined by 3GPP, so we should support both ascending and descending variants. Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Related: SYS#5313 --- M src/common/lchan.c 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/25734/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 00:22:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 00:22:28 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries ...................................................................... Patch Set 6: Code-Review+2 Merging ASAP on my responsibility. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Fri, 12 Nov 2021 00:22:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 00:22:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 00:22:47 +0000 Subject: Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 ) Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries ...................................................................... gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries The order of interference level boundaries is not clearly defined by 3GPP, so we should support both ascending and descending variants. Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Related: SYS#5313 --- M src/common/lchan.c 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/common/lchan.c b/src/common/lchan.c index ec1b175..fe5efd5 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -468,9 +468,18 @@ * boundaries (0, X1, ... X5). It's not clear how to handle values * exceeding the outer boundaries (0 or X5), because bands 0 and 6 do * not exist (sigh). Let's map such values to closest bands 1 and 5. */ - for (b = 1; b < ARRAY_SIZE(bts->interference.boundary) - 1; b++) { - if (meas_avg >= bts->interference.boundary[b]) - break; /* Current 'b' is the band value */ + if (bts->interference.boundary[0] < bts->interference.boundary[5]) { + /* Ascending order (band=1 indicates lowest interference) */ + for (b = 1; b < ARRAY_SIZE(bts->interference.boundary) - 1; b++) { + if (meas_avg < bts->interference.boundary[b]) + break; /* Current 'b' is the band value */ + } + } else { + /* Descending order (band=1 indicates highest interference) */ + for (b = 1; b < ARRAY_SIZE(bts->interference.boundary) - 1; b++) { + if (meas_avg >= bts->interference.boundary[b]) + break; /* Current 'b' is the band value */ + } } LOGPLCHAN(lchan, DL1C, LOGL_DEBUG, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e Gerrit-Change-Number: 25734 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Nov 12 00:43:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 12 Nov 2021 00:43:07 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_11/x86_64 In-Reply-To: References: Message-ID: <618db8b23e72e_3e42ae6d3a445e01940db@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_11/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 213s] | #define HAVE_INTTYPES_H 1 [ 213s] | #define HAVE_STDINT_H 1 [ 213s] | #define HAVE_UNISTD_H 1 [ 213s] | #define HAVE_DLFCN_H 1 [ 213s] | #define LT_OBJDIR ".libs/" [ 213s] | #define STDC_HEADERS 1 [ 213s] | #define HAVE_EXECINFO_H 1 [ 213s] | #define HAVE_SYS_SELECT_H 1 [ 213s] | #define HAVE_SYS_SOCKET_H 1 [ 213s] | #define HAVE_SYSLOG_H 1 [ 213s] | #define HAVE_CTYPE_H 1 [ 213s] | #define HAVE_NETINET_SCTP_H 1 [ 213s] | #define HAVE_LIBOSMOCORE 1 [ 213s] | #define HAVE_LIBSCTP 1 [ 213s] | #define HAVE_PCAP_H 1 [ 213s] | [ 213s] | configure: exit 0 [ 213s] [ 213s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 213s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 213s] make: *** [debian/rules:13: build] Error 2 [ 213s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 213s] ### VM INTERACTION START ### [ 216s] [ 196.323936] sysrq: Power Off [ 216s] [ 196.334714] reboot: Power down [ 216s] ### VM INTERACTION END ### [ 216s] [ 216s] lamb24 failed "build libosmo-netif_1.1.0.202111120026.dsc" at Fri Nov 12 00:42:56 UTC 2021. [ 216s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Nov 12 01:28:02 2021 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Fri, 12 Nov 2021 01:28:02 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26208 ) Change subject: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent ...................................................................... Patch Set 2: Code-Review+1 Again, I'm not so familiar with this code, but this patch appears to do as it says running on site. ? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 Gerrit-Change-Number: 26208 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Comment-Date: Fri, 12 Nov 2021 01:28:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Nov 12 02:58:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 12 Nov 2021 02:58:04 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618dd8551790b_3e42ae6d3a445e0216344@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 92s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 92s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 92s] [ 92s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 92s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 92s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 92s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 92s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 92s] 4/4 Test #4: websocket ........................ Passed 0.84 sec [ 92s] [ 92s] 75% tests passed, 1 tests failed out of 4 [ 92s] [ 92s] Total Test time (real) = 0.86 sec [ 92s] [ 92s] The following tests FAILED: [ 92s] 3 - framework (Failed) [ 92s] Errors while running CTest [ 92s] make[1]: *** [Makefile:129: test] Error 8 [ 92s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 92s] dh_auto_test: error: cd build && make -j8 test ARGS\+=--verbose ARGS\+=-j8 returned exit code 2 [ 92s] make: *** [debian/rules:9: build] Error 25 [ 92s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 92s] ### VM INTERACTION START ### [ 96s] [ 84.377796] sysrq: Power Off [ 96s] [ 84.390044] reboot: Power down [ 96s] ### VM INTERACTION END ### [ 96s] [ 96s] goat05 failed "build ulfius_2.5.2-4.2.dsc" at Fri Nov 12 02:58:03 UTC 2021. [ 96s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Nov 12 03:02:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 12 Nov 2021 03:02:53 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <618dd96282de9_3e42ae6d3a445e021682b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 93s] ./test/framework.c:742:P:test_ulfius_framework:test_ulfius_server_ca_trust:0: Passed [ 93s] ./test/framework.c:787:P:test_ulfius_framework:test_ulfius_client_certificate:0: Passed [ 93s] [ 94s] 4: 100%: Checks: 4, Failures: 0, Errors: 0 [ 94s] 4: ./test/websocket.c:73:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_response:0: Passed [ 94s] 4: ./test/websocket.c:89:P:test_ulfius_websocket:test_websocket_ulfius_set_websocket_request:0: Passed [ 94s] 4: ./test/websocket.c:106:P:test_ulfius_websocket:test_websocket_ulfius_open_websocket_client_connection_error:0: Passed [ 94s] 4: ./test/websocket.c:133:P:test_ulfius_websocket:test_websocket_ulfius_websocket_client:0: Passed [ 94s] 4/4 Test #4: websocket ........................ Passed 0.74 sec [ 94s] [ 94s] 75% tests passed, 1 tests failed out of 4 [ 94s] [ 94s] Total Test time (real) = 0.76 sec [ 94s] [ 94s] The following tests FAILED: [ 94s] 3 - framework (Failed) [ 94s] Errors while running CTest [ 94s] make[1]: *** [Makefile:129: test] Error 8 [ 94s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 94s] dh_auto_test: error: cd build && make -j3 test ARGS\+=--verbose ARGS\+=-j3 returned exit code 2 [ 94s] make: *** [debian/rules:9: build] Error 25 [ 94s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 94s] ### VM INTERACTION START ### [ 97s] [ 84.182488] sysrq: Power Off [ 97s] [ 84.184512] reboot: Power down [ 97s] ### VM INTERACTION END ### [ 97s] [ 97s] build84 failed "build ulfius_2.5.2-4.2.dsc" at Fri Nov 12 03:02:44 UTC 2021. [ 97s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Nov 12 10:48:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 10:48:53 +0000 Subject: Change in libusrp[master]: migrate to python3 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/19675 ) Change subject: migrate to python3 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py File firmware/src/common/build_eeprom.py: https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py at 87 PS2, Line 87: key=lambda a: a.addr > Not sure if this change is correct. looks correct according to https://stackoverflow.com/a/403426 also I've verified that the generated files are the same in both versions. $ git checkout master $ autoreconf -fi $ ./configure $ make $ cp firmware/src/usrp2/burn-usrp* /tmp/ $ make distclean $ git review -d 19675 $ autoreconf -fi $ ./configure $ make $ diff -s /tmp/burn-usrp2-eeprom firmware/src/usrp2/burn-usrp2-eeprom Files /tmp/burn-usrp2-eeprom and firmware/src/usrp2/burn-usrp2-eeprom are identical $ diff -s /tmp/burn-usrp4-eeprom firmware/src/usrp2/burn-usrp4-eeprom Files /tmp/burn-usrp4-eeprom and firmware/src/usrp2/burn-usrp4-eeprom are identical -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/19675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ib1604b36c32630e1360e06567cbd5f63a78df547 Gerrit-Change-Number: 19675 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-CC: roox Gerrit-Comment-Date: Fri, 12 Nov 2021 10:48:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 11:28:51 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 11:28:51 +0000 Subject: Change in osmo-hnodeb[master]: contrib/jenkins.sh: use --enable-werror References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 ) Change subject: contrib/jenkins.sh: use --enable-werror ...................................................................... contrib/jenkins.sh: use --enable-werror Fixes: OS#5290 Change-Id: Ic32464b9a52a5de4ee81fc3a4dbb5717b3b43e39 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/12/26212/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7001013..7c462c8 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -52,7 +52,7 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize --enable-external-tests $CONFIG +./configure --enable-sanitize --enable-external-tests --enable-werror $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic32464b9a52a5de4ee81fc3a4dbb5717b3b43e39 Gerrit-Change-Number: 26212 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 11:28:52 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 11:28:52 +0000 Subject: Change in osmo-hnodeb[master]: configure: don't turn some warnings into errors References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 ) Change subject: configure: don't turn some warnings into errors ...................................................................... configure: don't turn some warnings into errors Do not turn some compiler warnings into errors by default. This part was copied from openbsc.git 34f012 ("Turn some compiler warnings into errors"), where it was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. Related: OS#5289 Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/13/26213/1 diff --git a/configure.ac b/configure.ac index 5b4ca8b..1b06e42 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -114,13 +109,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 Gerrit-Change-Number: 26213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 11:34:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 11:34:17 +0000 Subject: Change in osmo-hnodeb[master]: contrib/jenkins.sh: use --enable-werror In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 ) Change subject: contrib/jenkins.sh: use --enable-werror ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic32464b9a52a5de4ee81fc3a4dbb5717b3b43e39 Gerrit-Change-Number: 26212 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 11:34:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 11:34:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 11:34:49 +0000 Subject: Change in osmo-hnodeb[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 Gerrit-Change-Number: 26213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 11:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 11:58:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 11:58:39 +0000 Subject: Change in libusrp[master]: migrate to python3 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/19675 ) Change subject: migrate to python3 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/19675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ib1604b36c32630e1360e06567cbd5f63a78df547 Gerrit-Change-Number: 19675 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: roox Gerrit-Comment-Date: Fri, 12 Nov 2021 11:58:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 11:58:44 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 12 Nov 2021 11:58:44 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26208 ) Change subject: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 Gerrit-Change-Number: 26208 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: keith Gerrit-Comment-Date: Fri, 12 Nov 2021 11:58:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:00:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:00:34 +0000 Subject: Change in osmo-hnodeb[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 Gerrit-Change-Number: 26213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 12:00:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:02:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:02:58 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26207 ) Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 Gerrit-Change-Number: 26207 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 12:02:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:03:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:03:00 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26207 ) Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 --- M src/tbf_dl_ass_fsm.c M tests/tbf/TbfTest.err 2 files changed, 10 insertions(+), 20 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index 37ced61..efc872a 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -77,9 +77,6 @@ return NULL; } - if (new_dl_tbf == as_dl_tbf(ctx->tbf)) - LOGPTBF(ctx->tbf, LOGL_DEBUG, "New and old TBF are the same.\n"); - if (old_tfi_is_valid && ms_tlli(ms) == GSM_RESERVED_TMSI) { LOGPTBF(ctx->tbf, LOGL_ERROR, "The old TFI is not assigned and there is no TLLI. New TBF %s\n", @@ -99,7 +96,12 @@ }; bitvec_unhex(&bv, DUMMY_VEC); - LOGPTBF((struct gprs_rlcmac_tbf *)new_dl_tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); + if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_dl_tbf) + LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n", + tbf_name((const struct gprs_rlcmac_tbf *)new_dl_tbf)); + else + LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); + mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); write_packet_downlink_assignment(mac_control_block, old_tfi_is_valid, tbf_tfi(ctx->tbf), (tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF), diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index ec0981c..892b31e 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -87,7 +87,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) appending 200 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -201,7 +200,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) appending 200 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -315,7 +313,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) appending 200 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -2010,7 +2007,7 @@ PDCH(bts=0,trx=0,ts=7) Received RTS for PDCH: FN=2654275 block_nr=9 scheduling USF=0 for TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), expect answer on UL FN=2654279 DL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654275 + 13 = 2654288 -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) start Packet Downlink Assignment (PACCH) +TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) start Packet Downlink Assignment (PACCH) for TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) Scheduled DL Assignment polling on PACCH (FN=2654288, TS=7) @@ -2663,7 +2660,7 @@ PDCH(bts=0,trx=0,ts=7) Received RTS for PDCH: FN=2654275 block_nr=9 scheduling USF=0 for TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW), expect answer on UL FN=2654279 DL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654275 + 13 = 2654288 -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) start Packet Downlink Assignment (PACCH) +TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) start Packet Downlink Assignment (PACCH) for TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) Scheduled DL Assignment polling on PACCH (FN=2654288, TS=7) @@ -3362,7 +3359,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=RELEASING) N3101 27 => 28 (< MAX 10) DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654400 + 13 = 2654413 -TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) start Packet Downlink Assignment (PACCH) +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) start Packet Downlink Assignment (PACCH) for TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) Scheduled DL Assignment polling on PACCH (FN=2654413, TS=7) @@ -4085,7 +4082,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -4393,7 +4389,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -4651,7 +4646,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -4869,7 +4863,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -5071,7 +5064,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -5257,7 +5249,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -5419,7 +5410,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -5590,7 +5580,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -5752,7 +5741,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) appending 10 bytes DL_ASS_TBF(DL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=4) POLL scheduled at FN 0 + 13 = 13 -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) New and old TBF are the same. TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- @@ -8118,7 +8106,7 @@ PDCH(bts=0,trx=0,ts=7) Received RTS for PDCH: FN=2654279 block_nr=10 scheduling USF=0 for TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS), expect answer on UL FN=2654283 DL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654279 + 13 = 2654292 -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) start Packet Downlink Assignment (PACCH) +TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) start Packet Downlink Assignment (PACCH) for TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) +++++++++++++++++++++++++ TX : Packet Downlink Assignment +++++++++++++++++++++++++ ------------------------- TX : Packet Downlink Assignment ------------------------- TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) Scheduled DL Assignment polling on PACCH (FN=2654292, TS=7) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 Gerrit-Change-Number: 26207 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:03:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:03:01 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26208 ) Change subject: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent ...................................................................... tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent If by the time the PktDlAss is to be scheduled by the scheduler the DL TBF is gone, the FSM will abort the assignment and go back to state NONE. However, the transition was missing, ending up in the scheduler trying to schedule the message unsuccessfuly lots of times per second, clogging the logs and disrupting normal operation. Related: OS#5293 Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 --- M src/tbf_dl_ass_fsm.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved keith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index efc872a..555380d 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -208,7 +208,9 @@ }, [TBF_DL_ASS_SEND_ASS] = { .in_event_mask = X(TBF_DL_ASS_EV_CREATE_RLCMAC_MSG), - .out_state_mask = X(TBF_DL_ASS_WAIT_ACK), + .out_state_mask = + X(TBF_DL_ASS_WAIT_ACK) | + X(TBF_DL_ASS_NONE), .name = "SEND_ASS", .action = st_send_ass, }, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 Gerrit-Change-Number: 26208 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:05:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 12:05:28 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26207 ) Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 Gerrit-Change-Number: 26207 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 12:05:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:06:00 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 12 Nov 2021 12:06:00 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26207 ) Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26207/3/src/tbf_dl_ass_fsm.c File src/tbf_dl_ass_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26207/3/src/tbf_dl_ass_fsm.c at 100 PS3, Line 100: LOGPTBFDL At least in the tests below this is logging a UL TBF. not sure if it matters for the macro or why we have different macros for UL/DL in the first place. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 Gerrit-Change-Number: 26207 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Fri, 12 Nov 2021 12:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:15:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:15:55 +0000 Subject: Change in osmo-pcu[master]: tbf_{dl, ul}_ass_fsm.c: use proper macro to log tbf References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26214 ) Change subject: tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf ...................................................................... tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf TBF can be either UL or DL in that FSM. Change-Id: Ief0cd5298e062f11b0f39716162a67b87c9ff35f --- M src/tbf_dl_ass_fsm.c M src/tbf_ul_ass_fsm.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/14/26214/1 diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index 555380d..1d44c91 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -97,10 +97,10 @@ bitvec_unhex(&bv, DUMMY_VEC); if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_dl_tbf) - LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n", + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n", tbf_name((const struct gprs_rlcmac_tbf *)new_dl_tbf)); else - LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); write_packet_downlink_assignment(mac_control_block, old_tfi_is_valid, diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index d2dea46..ef75360 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -111,10 +111,10 @@ bitvec_unhex(&bv, DUMMY_VEC); if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_tbf) - LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH) for %s\n", + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH) for %s\n", tbf_name((const struct gprs_rlcmac_tbf *)new_tbf)); else - LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); tlli = ms_tlli(ms); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ief0cd5298e062f11b0f39716162a67b87c9ff35f Gerrit-Change-Number: 26214 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:16:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:16:29 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26207 ) Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26207/3/src/tbf_dl_ass_fsm.c File src/tbf_dl_ass_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26207/3/src/tbf_dl_ass_fsm.c at 100 PS3, Line 100: LOGPTBFDL > At least in the tests below this is logging a UL TBF. [?] Good catch, it was also wrong from a prior commit where I changed it for tbf_ul_ass_fsm. See fix for both here: https://gerrit.osmocom.org/c/osmo-pcu/+/26214 tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9 Gerrit-Change-Number: 26207 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Fri, 12 Nov 2021 12:16:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:23:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:23:06 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... pcu_main: Mark -r cmdline param as deprecated We have VTY support for it enabled in osmo-pcu since a while ago. Let's mark it as depcreated now so that we can drop this cmdline arg in the future. Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f --- M src/pcu_main.cpp 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/15/26215/1 diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index 003cabb..38cf63b 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -165,6 +165,8 @@ break; case 'r': rt_prio = atoi(optarg); + fprintf(stderr, "Command line argument '-r' is deprecated, use VTY " + "cpu-sched node setting 'policy rr %d' instead.\n", rt_prio); break; case 'D': daemonize = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:39:26 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 12 Nov 2021 12:39:26 +0000 Subject: Change in osmo-pcu[master]: tbf_{dl, ul}_ass_fsm.c: use proper macro to log tbf In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26214 ) Change subject: tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ief0cd5298e062f11b0f39716162a67b87c9ff35f Gerrit-Change-Number: 26214 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Fri, 12 Nov 2021 12:39:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:40:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 12:40:53 +0000 Subject: Change in osmo-pcu[master]: tbf_{dl, ul}_ass_fsm.c: use proper macro to log tbf In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26214 ) Change subject: tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf ...................................................................... tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf TBF can be either UL or DL in that FSM. Change-Id: Ief0cd5298e062f11b0f39716162a67b87c9ff35f --- M src/tbf_dl_ass_fsm.c M src/tbf_ul_ass_fsm.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index 555380d..1d44c91 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -97,10 +97,10 @@ bitvec_unhex(&bv, DUMMY_VEC); if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_dl_tbf) - LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n", + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n", tbf_name((const struct gprs_rlcmac_tbf *)new_dl_tbf)); else - LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n"); mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); write_packet_downlink_assignment(mac_control_block, old_tfi_is_valid, diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index d2dea46..ef75360 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -111,10 +111,10 @@ bitvec_unhex(&bv, DUMMY_VEC); if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_tbf) - LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH) for %s\n", + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH) for %s\n", tbf_name((const struct gprs_rlcmac_tbf *)new_tbf)); else - LOGPTBFUL(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); + LOGPTBF(ctx->tbf, LOGL_INFO, "start Packet Uplink Assignment (PACCH)\n"); mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t); tlli = ms_tlli(ms); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ief0cd5298e062f11b0f39716162a67b87c9ff35f Gerrit-Change-Number: 26214 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 12:52:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 12:52:18 +0000 Subject: Change in libusrp[master]: migrate to python3 In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/19675 ) Change subject: migrate to python3 ...................................................................... migrate to python3 Let's move to python3, it's 2020 and the conversion seemed actually rather trivial (famous last words). Change-Id: Ib1604b36c32630e1360e06567cbd5f63a78df547 --- M contrib/libusrp.spec.in M debian/control M firmware/include/generate_regs.py M firmware/src/common/build_eeprom.py M firmware/src/common/edit-gpif M firmware/src/usrp2/edit-gpif 6 files changed, 14 insertions(+), 17 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/libusrp.spec.in b/contrib/libusrp.spec.in index 75ceeaa..de4404c 100644 --- a/contrib/libusrp.spec.in +++ b/contrib/libusrp.spec.in @@ -29,11 +29,7 @@ BuildRequires: libtool BuildRequires: pkgconfig BuildRequires: sdcc -%if 0%{?suse_version} < 1320 -BuildRequires: python -%else -BuildRequires: python2 -%endif +BuildRequires: python3 BuildRequires: pkgconfig(libusb-1.0) %if 0%{?suse_version} > 1325 BuildRequires: libboost_date_time-devel diff --git a/debian/control b/debian/control index 247a661..cb3b90d 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ doxygen, libtool, pkg-config, - python, + python3, sdcc, libusb-1.0-0-dev, libboost-all-dev diff --git a/firmware/include/generate_regs.py b/firmware/include/generate_regs.py index f11baad..7416302 100755 --- a/firmware/include/generate_regs.py +++ b/firmware/include/generate_regs.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 import os, os.path import re @@ -8,7 +8,7 @@ # set srcdir to the directory that contains Makefile.am try: srcdir = os.environ['srcdir'] -except KeyError, e: +except KeyError as e: srcdir = "." srcdir = srcdir + '/' diff --git a/firmware/src/common/build_eeprom.py b/firmware/src/common/build_eeprom.py index 6092d61..435b826 100755 --- a/firmware/src/common/build_eeprom.py +++ b/firmware/src/common/build_eeprom.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # # Copyright 2004,2006 Free Software Foundation, Inc. # @@ -24,6 +24,7 @@ import sys import os, os.path from optparse import OptionParser +from functools import reduce # USB Vendor and Product ID's @@ -33,7 +34,7 @@ def hex_to_bytes (s): if len (s) & 0x1: - raise ValueError, "Length must be even" + raise ValueError("Length must be even") r = [] for i in range (0, len(s), 2): r.append (int (s[i:i+2], 16)) @@ -59,17 +60,17 @@ for line in file: line = line.strip().upper () if not self.pat.match (line): - raise ValueError, "Invalid hex record format" + raise ValueError("Invalid hex record format") bytes = hex_to_bytes (line[1:]) sum = reduce (lambda x, y: x + y, bytes, 0) % 256 if sum != 0: - raise ValueError, "Bad hex checksum" + raise ValueError("Bad hex checksum") lenx = bytes[0] addr = (bytes[1] << 8) + bytes[2] type = bytes[3] data = bytes[4:-1] if lenx != len (data): - raise ValueError, "Invalid hex record (bad length)" + raise ValueError("Invalid hex record (bad length)") if type != 0: break; r.append (ihx_rec (addr, type, data)) @@ -83,7 +84,7 @@ f = open (filename, 'r') ifx = ihx_file () r = ifx.read (f) - r.sort (lambda a,b: a.addr - b.addr) + r.sort (key=lambda a: a.addr) code_start = r[0].addr code_end = r[-1].addr + len (r[-1].data) code_len = code_end - code_start @@ -153,7 +154,7 @@ i2c_addr = 0x50 rom_addr = 0x00 - hex_image = map (lambda x : "%02x" % (x,), image) + hex_image = ["%02x" % (x,) for x in image] while (len (hex_image) > 0): l = min (len (hex_image), 16) diff --git a/firmware/src/common/edit-gpif b/firmware/src/common/edit-gpif index 87e16eb..1a63791 100755 --- a/firmware/src/common/edit-gpif +++ b/firmware/src/common/edit-gpif @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # -*- Python -*- # # Copyright 2003 Free Software Foundation, Inc. diff --git a/firmware/src/usrp2/edit-gpif b/firmware/src/usrp2/edit-gpif index 87e16eb..1a63791 100755 --- a/firmware/src/usrp2/edit-gpif +++ b/firmware/src/usrp2/edit-gpif @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # -*- Python -*- # # Copyright 2003 Free Software Foundation, Inc. -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/19675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ib1604b36c32630e1360e06567cbd5f63a78df547 Gerrit-Change-Number: 19675 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: roox Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 13:02:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 13:02:37 +0000 Subject: Change in osmo-pcu[master]: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enab... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26216 ) Change subject: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' ...................................................................... vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' Related: OS#5306 Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 --- M doc/manuals/chapters/configuration.adoc M src/gprs_pcu.h M src/pcu_main.cpp M src/pcu_vty.c 4 files changed, 150 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/16/26216/1 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index d778929..8bdf4b8 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -422,3 +422,71 @@ accomplished and there's no penalty. However, if only EGPRS downlink data is sent over that time frame, then the scheduler will force sending a RLCMAC Dummy Block. + +[[gsmtap]] +=== Configuring GSMTAP tracing + +In addition to being able to obtain pcap protocol traces of the NS/BSSGP +communication and the text-based logging from the OsmoPCU software, there is +also the capability of tracing all communication on the radio interface related +to PS. To do so, OsmoPCU can encapsulate MAC blocks (23byte messages at the +L2-L1 interface) into _GSMTAP_ and send them via UDP/IP. At that point, they can +be captured with utilities like *tcpdump* or *tshark* for further analysis by +the *wireshark* protocol analyzer. + +In order to activate this feature, you first need to make sure to specify +the remote address of _GSMTAP_ host in the configuration file. In most +cases, using 127.0.0.1 for passing the messages over the loopback (`lo`) +device will be sufficient: + +.Example: Enabling GSMTAP Um-frame logging to localhost +---- +pcu + gsmtap-remote-host 127.0.0.1 <1> +---- +<1> Destination address for _GSMTAP_ Um-frames + +NOTE: Changing this parameter at run-time will not affect the existing +_GSMTAP_ connection, full program restart is required. + +NOTE: Command line parameters `-i` and `--gsmtap-ip` have been deprecated. + +OsmoPCU can selectively trace such messages based on different categories, for +both Ul and Dl. For a complete list of cateogry values, please refer to the +_OsmoPCU VTY reference manual_ <>. + +For example, to enable GSMTAP tracing for all DL EGPRS rlcmac data blocks, you +can use the `gsmtap-category dl-data-egprs` command at the `pcu` node of the +OsmoPCU VTY. + +.Example: Enabling GSMTAP for for all DL EGPRS rlcmac data blocks +---- +OsmoPCU> enable +OsmoPCU# configure terminal +OsmoPCU(config)# pcu +OsmoPCU(pcu)# gsmtap-category dl-data-egprs +OsmoPCU(trx)# write <1> +---- +<1> the `write` command will make the configuration persistent in the +configuration file. This is not required if you wish to enable GSMTAP +only in the current session of OsmoPCU. + +De-activation can be performed similarly by using the `no gsmtap-category +dl-data-egprs` command at the `pcu` node of the OsmoPCU VTY. + +It may be useful to enable all categories with a few exceptions, or vice versa +disable everything using one command. For this purpose, the VTY provides +`gsmtap-category enable-all` and `gsmtap-category disable-all` commands. + +.Example: Enabling all categoriess except _dl-dummy_ +---- +pcu + gsmtap-category enable-all <1> + no gsmtap-category dl-dummy <2> +---- +<1> Enable all available SAPIs +<2> Exclude DL RLCMAC blocks + +From the moment they are enabled via VTY, GSMTAP messages will be +generated and sent in UDP encapsulation to the IANA-registered UDP port +for GSMTAP (4729) of the specified remote address. diff --git a/src/gprs_pcu.h b/src/gprs_pcu.h index fdcf5f7..ed00221 100644 --- a/src/gprs_pcu.h +++ b/src/gprs_pcu.h @@ -117,6 +117,7 @@ struct gsmtap_inst *gsmtap; uint32_t gsmtap_categ_mask; + char *gsmtap_remote_host; struct llist_head bts_list; /* list of gprs_rlcmac_bts */ diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index 38cf63b..16ca4d7 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -162,6 +162,8 @@ break; case 'i': gsmtap_addr = optarg; + fprintf(stderr, "Command line argument '-i' is deprecated, use VTY " + "parameter 'gsmtap-remote-host %s' instead.\n", gsmtap_addr); break; case 'r': rt_prio = atoi(optarg); @@ -284,6 +286,32 @@ fprintf(stderr, "No config file: '%s' Using default config.\n", config_file); + /* Accept a GSMTAP host from VTY config, but a commandline option overrides that. */ + if (gsmtap_addr != NULL) { + if (pcu->gsmtap_remote_host != NULL) { + LOGP(DLGLOBAL, LOGL_NOTICE, + "Command line argument '-i %s' overrides " + "'gsmtap-remote-host %s' from the config file\n", + gsmtap_addr, pcu->gsmtap_remote_host); + talloc_free(pcu->gsmtap_remote_host); + } + pcu->gsmtap_remote_host = talloc_strdup(pcu, gsmtap_addr); + } + + /* TODO: move this to gsm_bts_alloc() */ + if (pcu->gsmtap_remote_host) { + LOGP(DLGLOBAL, LOGL_NOTICE, + "Setting up GSMTAP Um forwarding to '%s:%u'\n", + pcu->gsmtap_remote_host, GSMTAP_UDP_PORT); + pcu->gsmtap = gsmtap_source_init(pcu->gsmtap_remote_host, + GSMTAP_UDP_PORT, 1); + if (pcu->gsmtap == NULL) { + fprintf(stderr, "Failed during gsmtap_source_init()\n"); + exit(1); + } + gsmtap_source_add_sink(pcu->gsmtap); + } + rc = telnet_init_dynif(tall_pcu_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_PCU); if (rc < 0) { diff --git a/src/pcu_vty.c b/src/pcu_vty.c index c85e324..6201d60 100644 --- a/src/pcu_vty.c +++ b/src/pcu_vty.c @@ -70,6 +70,49 @@ { 0, NULL } }; +DEFUN(cfg_pcu_gsmtap_remote_host, + cfg_pcu_gsmtap_remote_host_cmd, + "gsmtap-remote-host [HOSTNAME]", + "Enable GSMTAP Um logging (see also 'gsmtap-category')\n" + "Remote IP address or hostname ('localhost' if omitted)\n") +{ + osmo_talloc_replace_string(the_pcu, &the_pcu->gsmtap_remote_host, + argc > 0 ? argv[0] : "localhost"); + + if (vty->type != VTY_FILE) + vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE); + + return CMD_SUCCESS; +} + +DEFUN(cfg_pcu_no_gsmtap_remote_host, + cfg_pcu_no_gsmtap_remote_host_cmd, + "no gsmtap-remote-host", + NO_STR "Disable GSMTAP Um logging\n") +{ + if (the_pcu->gsmtap_remote_host) + TALLOC_FREE(the_pcu->gsmtap_remote_host); + + if (vty->type != VTY_FILE) + vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE); + + return CMD_SUCCESS; +} + +DEFUN(cfg_pcu_gsmtap_sapi_all, cfg_pcu_gsmtap_sapi_all_cmd, + "gsmtap-sapi (enable-all|disable-all)", + "Enable/disable sending of UL/DL messages over GSMTAP\n" + "Enable all kinds of messages (all SAPI)\n" + "Disable all kinds of messages (all SAPI)\n") +{ + + if (strcmp(argv[0], "enable-all") == 0) + the_pcu->gsmtap_categ_mask = UINT32_MAX; + else + the_pcu->gsmtap_categ_mask = 0x00; + + return CMD_SUCCESS; +} DEFUN(cfg_pcu_gsmtap_categ, cfg_pcu_gsmtap_categ_cmd, "HIDDEN", "HIDDEN") { @@ -238,11 +281,14 @@ if (strcmp(the_pcu->pcu_sock_path, PCU_SOCK_DEFAULT)) vty_out(vty, " pcu-socket %s%s", the_pcu->pcu_sock_path, VTY_NEWLINE); + if (the_pcu->gsmtap_remote_host) + vty_out(vty, " gsmtap-remote-host %s%s", the_pcu->gsmtap_remote_host, VTY_NEWLINE); for (i = 0; i < 32; i++) { - uint32_t cs = ((uint32_t)1 << i); - if (the_pcu->gsmtap_categ_mask & cs) { - vty_out(vty, " gsmtap-category %s%s", - get_value_string(pcu_gsmtap_categ_names, i), VTY_NEWLINE); + if (the_pcu->gsmtap_categ_mask & ((uint32_t)1 << i)) { + const char* category_buf; + if(!(category_buf = get_value_string_or_null(pcu_gsmtap_categ_names, i))) + continue; + vty_out(vty, " gsmtap-category %s%s", category_buf, VTY_NEWLINE); } } @@ -1294,6 +1340,9 @@ install_element(PCU_NODE, &cfg_pcu_no_dl_tbf_preemptive_retransmission_cmd); install_element(PCU_NODE, &cfg_pcu_ms_idle_time_cmd); install_element(PCU_NODE, &cfg_pcu_no_ms_idle_time_cmd); + install_element(PCU_NODE, &cfg_pcu_gsmtap_remote_host_cmd); + install_element(PCU_NODE, &cfg_pcu_no_gsmtap_remote_host_cmd); + install_element(PCU_NODE, &cfg_pcu_gsmtap_sapi_all_cmd); install_element(PCU_NODE, &cfg_pcu_gsmtap_categ_cmd); install_element(PCU_NODE, &cfg_pcu_no_gsmtap_categ_cmd); install_element(PCU_NODE, &cfg_pcu_sock_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 Gerrit-Change-Number: 26216 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 13:08:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 13:08:47 +0000 Subject: Change in osmo-pcu[master]: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enab... In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/26216 ) Change subject: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' ...................................................................... vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' Related: OS#5306 Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 --- M doc/manuals/chapters/configuration.adoc M src/gprs_pcu.h M src/pcu_main.cpp M src/pcu_vty.c 4 files changed, 150 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/16/26216/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 Gerrit-Change-Number: 26216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 13:16:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 13:16:13 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 1: Code-Review+1 Let's also remove it from the help message? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 13:16:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 14:25:48 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 14:25:48 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 14:25:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 14:39:23 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 14:39:23 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 6: (2 comments) looks good besides also doing the check on startup. (I didn't realize that there were already lots of reviews here.) https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c at a545 PS6, Line 545: return rc; > Makes sense. +1 https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c at 496 PS6, Line 496: LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap BTS\n", trx->bts->nr); (very long line, break before trx->bts->nr? same below) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 14:39:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 14:52:23 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 14:52:23 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: add --auto-distclean In-Reply-To: References: Message-ID: Hello neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/25738 to look at the new patch set (#2). Change subject: gen_makefile.py: add --auto-distclean ...................................................................... gen_makefile.py: add --auto-distclean Add a new option that avoids stopping the build with: configure: error: source directory already configured; run "make distclean" there first I run into this frequently, when e.g. running './configure; make release' inside Osmocom repositories and then attempting to build them with osmo-dev. It is annoying as it does not fail immediatelly, and I need to manually go to the source directories where it failed, run 'make distclean' and then attempt to build again. Then it may fail on another directory with the same problem. Check for config.status, as that is also what ./configure checks for before printing the error. Change-Id: Iac71333e8c5da8dee4e8f34e2af8db12d2c08021 --- M gen_makefile.py 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/38/25738/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iac71333e8c5da8dee4e8f34e2af8db12d2c08021 Gerrit-Change-Number: 25738 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 14:52:23 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 14:52:23 +0000 Subject: Change in osmo-dev[master]: all.deps: remove duplicate osmo-pcu, osmo-trx References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/26217 ) Change subject: all.deps: remove duplicate osmo-pcu, osmo-trx ...................................................................... all.deps: remove duplicate osmo-pcu, osmo-trx Fix warnings about duplicate make targets. Change-Id: I7c6023f1c8bc23beff3bb512f059ce1b692d2adf --- M all.deps 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/17/26217/1 diff --git a/all.deps b/all.deps index 368a53e..65bdf27 100644 --- a/all.deps +++ b/all.deps @@ -15,8 +15,6 @@ osmo-sip-connector libosmocore osmo-bts libosmo-netif osmo-smlc libosmo-sccp -osmo-pcu libosmocore -osmo-trx libosmocore # osmo-trx can build with --enable-sanitize, but then won't work reliably. # When omitting --enable-sanitize from osmo-trx only, its 'make check' will fail. # So if you want osmo-trx, use no sanitize.opts, or use LD_PRELOAD for osmo-trx binaries. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7c6023f1c8bc23beff3bb512f059ce1b692d2adf Gerrit-Change-Number: 26217 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:15:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 15:15:50 +0000 Subject: Change in osmo-dev[master]: all.deps: remove duplicate osmo-pcu, osmo-trx In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26217 ) Change subject: all.deps: remove duplicate osmo-pcu, osmo-trx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7c6023f1c8bc23beff3bb512f059ce1b692d2adf Gerrit-Change-Number: 26217 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 15:15:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:16:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 15:16:59 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: proj_files: ignore config.h In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25737 ) Change subject: gen_makefile.py: proj_files: ignore config.h ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I10d970f2cadacb5071dcde975c76b15404038a3c Gerrit-Change-Number: 25737 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Fri, 12 Nov 2021 15:16:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:22:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 15:22:31 +0000 Subject: Change in osmo-iuh[master]: Cosmetic: put asn1c parameters in separate lines References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26218 ) Change subject: Cosmetic: put asn1c parameters in separate lines ...................................................................... Cosmetic: put asn1c parameters in separate lines Change-Id: Id1425753f9b4cbce172a1b875a680aa189bb5737 --- M src/hnbap/Makefile.am M src/ranap/Makefile.am M src/rua/Makefile.am M src/sabp/Makefile.am 4 files changed, 32 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/18/26218/1 diff --git a/src/hnbap/Makefile.am b/src/hnbap/Makefile.am index 15bee55..ca1df17 100644 --- a/src/hnbap/Makefile.am +++ b/src/hnbap/Makefile.am @@ -243,7 +243,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="HNBAP_" asn1c -R -fcompound-names -gen-PER $(HNBAP_ASN1)/HNBAP-CommonDataTypes.asn $(HNBAP_ASN1)/HNBAP-Constants.asn $(HNBAP_ASN1)/HNBAP-IEs.asn $(HNBAP_ASN1)/HNBAP-PDU.asn + ASN1C_PREFIX="HNBAP_" asn1c \ + -R \ + -fcompound-names \ + -gen-PER \ + $(HNBAP_ASN1)/HNBAP-CommonDataTypes.asn \ + $(HNBAP_ASN1)/HNBAP-Constants.asn \ + $(HNBAP_ASN1)/HNBAP-IEs.asn \ + $(HNBAP_ASN1)/HNBAP-PDU.asn # change include style to `#include ' $(top_srcdir)/move-asn1-header-files.sh osmocom/hnbap $(ASN_MODULE_INC) # Finally copy *.c from buildir to srcdir: diff --git a/src/ranap/Makefile.am b/src/ranap/Makefile.am index 1193dce..0ef9523 100644 --- a/src/ranap/Makefile.am +++ b/src/ranap/Makefile.am @@ -1169,7 +1169,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="RANAP_" asn1c -fcompound-names -R -gen-PER $(top_srcdir)/asn1/ranap/RANAP-CommonDataTypes.asn $(top_srcdir)/asn1/ranap/RANAP-Constants.asn $(top_srcdir)/asn1/ranap/RANAP-IEs.asn $(top_srcdir)/asn1/ranap/RANAP-PDU.asn + ASN1C_PREFIX="RANAP_" asn1c \ + -fcompound-names \ + -R \ + -gen-PER \ + $(top_srcdir)/asn1/ranap/RANAP-CommonDataTypes.asn \ + $(top_srcdir)/asn1/ranap/RANAP-Constants.asn \ + $(top_srcdir)/asn1/ranap/RANAP-IEs.asn \ + $(top_srcdir)/asn1/ranap/RANAP-PDU.asn sed -i '7i#include ' RANAP_ChosenEncryptionAlgorithm.h RANAP_ChosenIntegrityProtectionAlgorithm.h RANAP_IMSI.h RANAP_PLMNidentity.h RANAP_RAB-ReleaseFailedList.c RANAP_RAB-ReleaseList.c RANAP_RAB-SetupOrModifyList.c RANAP_ResetResourceList.c RANAP_ResetResourceAckList.c # change include style to `#include ' $(top_srcdir)/move-asn1-header-files.sh osmocom/ranap $(ASN_MODULE_INC) diff --git a/src/rua/Makefile.am b/src/rua/Makefile.am index 8cb2e7d..23ff20e 100644 --- a/src/rua/Makefile.am +++ b/src/rua/Makefile.am @@ -81,7 +81,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="RUA_" asn1c -R -fcompound-names -gen-PER $(top_srcdir)/asn1/rua/RUA-CommonDataTypes.asn $(top_srcdir)/asn1/rua/RUA-Constants.asn $(top_srcdir)/asn1/rua/RUA-IEs.asn $(top_srcdir)/asn1/rua/RUA-PDU.asn + ASN1C_PREFIX="RUA_" asn1c \ + -R \ + -fcompound-names \ + -gen-PER \ + $(top_srcdir)/asn1/rua/RUA-CommonDataTypes.asn \ + $(top_srcdir)/asn1/rua/RUA-Constants.asn \ + $(top_srcdir)/asn1/rua/RUA-IEs.asn \ + $(top_srcdir)/asn1/rua/RUA-PDU.asn # change include style to `#include ' $(top_srcdir)/move-asn1-header-files.sh osmocom/rua $(ASN_MODULE_INC) # Finally copy *.c from buildir to srcdir: diff --git a/src/sabp/Makefile.am b/src/sabp/Makefile.am index 0665db4..8dc1390 100644 --- a/src/sabp/Makefile.am +++ b/src/sabp/Makefile.am @@ -135,7 +135,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="SABP_" asn1c -R -fcompound-names -gen-PER $(top_srcdir)/asn1/sabp/SABP-CommonDataTypes.asn $(top_srcdir)/asn1/sabp/SABP-Constants.asn $(top_srcdir)/asn1/sabp/SABP-IEs.asn $(top_srcdir)/asn1/sabp/SABP-PDU.asn + ASN1C_PREFIX="SABP_" asn1c \ + -R \ + -fcompound-names \ + -gen-PER \ + $(top_srcdir)/asn1/sabp/SABP-CommonDataTypes.asn \ + $(top_srcdir)/asn1/sabp/SABP-Constants.asn \ + $(top_srcdir)/asn1/sabp/SABP-IEs.asn \ + $(top_srcdir)/asn1/sabp/SABP-PDU.asn # add missing includes sed -i '/#include "SABP_Serial-Number.h"/a #include ' SABP_Old-Serial-Number.h SABP_New-Serial-Number.h # change include style to `#include ' -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id1425753f9b4cbce172a1b875a680aa189bb5737 Gerrit-Change-Number: 26218 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:34:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 15:34:26 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: add --auto-distclean In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25738 ) Change subject: gen_makefile.py: add --auto-distclean ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iac71333e8c5da8dee4e8f34e2af8db12d2c08021 Gerrit-Change-Number: 25738 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 15:34:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:34:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 15:34:39 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: proj_files: ignore config.h In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25737 ) Change subject: gen_makefile.py: proj_files: ignore config.h ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I10d970f2cadacb5071dcde975c76b15404038a3c Gerrit-Change-Number: 25737 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 15:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:34:45 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 15:34:45 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: add --auto-distclean In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25738 ) Change subject: gen_makefile.py: add --auto-distclean ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iac71333e8c5da8dee4e8f34e2af8db12d2c08021 Gerrit-Change-Number: 25738 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 15:34:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:35:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 15:35:02 +0000 Subject: Change in osmo-iuh[master]: Cosmetic: put asn1c parameters in separate lines In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26218 ) Change subject: Cosmetic: put asn1c parameters in separate lines ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id1425753f9b4cbce172a1b875a680aa189bb5737 Gerrit-Change-Number: 26218 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 15:35:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:39:58 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 12 Nov 2021 15:39:58 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Remove duplicate struct gprs_ra_id handling References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 ) Change subject: gbproxy: Remove duplicate struct gprs_ra_id handling ...................................................................... gbproxy: Remove duplicate struct gprs_ra_id handling The ra_id as well as the cell_id are already present in struct gbproxy_cell which is reachable from bvc->cell. Remove the ra_id in struct gbproxy_bvc and also remove some unused/unneeded code. The FSM reset_notif callback already takes care of updating the cell. Related: OS#4894 Change-Id: Ibc9f42a60706612c17e5f8f0468c7faced5ae4c8 --- M include/osmocom/gbproxy/gb_proxy.h M src/gb_proxy.c 2 files changed, 11 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/19/26219/1 diff --git a/include/osmocom/gbproxy/gb_proxy.h b/include/osmocom/gbproxy/gb_proxy.h index 07373ad..0657df7 100644 --- a/include/osmocom/gbproxy/gb_proxy.h +++ b/include/osmocom/gbproxy/gb_proxy.h @@ -142,9 +142,6 @@ /* Whether this BVC is inactive (removed from BSS-side) */ bool inactive; - /* Routing Area that this BVC is part of */ - struct gprs_ra_id raid; - /* Counter */ struct rate_ctr_group *ctrg; diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 9845a09..3d76a33 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -710,7 +710,7 @@ } /* Reallocate SGSN-side BVCs of the cell, and reset them - * Removing and reallocating is needed becaus the ra_id/cell_id might have changed */ + * Removing and reallocating is needed because the ra_id/cell_id might have changed */ hash_for_each(cfg->sgsn_nses, i, sgsn_nse, list) { struct gbproxy_bvc *sgsn_bvc = gbproxy_bvc_by_bvci(sgsn_nse, bvci); if (!sgsn_bvc) @@ -721,7 +721,6 @@ sgsn_bvc = gbproxy_bvc_alloc(sgsn_nse, bvci); OSMO_ASSERT(sgsn_bvc); sgsn_bvc->cell = bvc->cell; - memcpy(&sgsn_bvc->raid, &bvc->cell->id.raid, sizeof(sgsn_bvc->raid)); sgsn_bvc->fi = bssgp_bvc_fsm_alloc_ptp_bss(sgsn_bvc, cfg->nsi, sgsn_nse->nsei, bvci, ra_id, cell_id); OSMO_ASSERT(sgsn_bvc->fi); @@ -888,34 +887,6 @@ bssgp_bvc_fsm_set_max_pdu_len(from_bvc->fi, nse->max_sdu_len); bssgp_bvc_fsm_set_ops(from_bvc->fi, &bss_ptp_bvc_fsm_ops, from_bvc); } -#if 0 - /* Could have moved to a different NSE */ - if (!check_bvc_nsei(from_bvc, nsei)) { - LOGPBVC(from_bvc, LOGL_NOTICE, "moving bvc to NSE(%05u)\n", nsei); - - struct gbproxy_nse *nse_new = gbproxy_nse_by_nsei(cfg, nsei, false); - if (!nse_new) { - LOGP(DGPRS, LOGL_NOTICE, "NSE(%05u) Got PtP BVC reset before signalling reset for " - "BVCI=%05u\n", bvci, nsei); - tx_status(nse, ns_bvci, BSSGP_CAUSE_PDU_INCOMP_STATE, NULL, msg); - return 0; - } - - /* Move bvc to different NSE */ - gbproxy_bvc_move(from_bvc, nse_new); - } -#endif - /* FIXME: do we need this, if it happens within FSM? */ - if (TLVP_PRES_LEN(tp, BSSGP_IE_CELL_ID, 8)) { - struct gprs_ra_id raid; - /* We have a Cell Identifier present in this - * PDU, this means we can extend our local - * state information about this particular cell - * */ - gsm48_parse_ra(&raid, TLVP_VAL(tp, BSSGP_IE_CELL_ID)); - memcpy(&from_bvc->raid, &raid, sizeof(from_bvc->raid)); - LOGPBVC(from_bvc, LOGL_INFO, "Cell ID %s\n", osmo_rai_name(&raid)); - } } /* hand into FSM for further processing */ osmo_fsm_inst_dispatch(from_bvc->fi, BSSGP_BVCFSM_E_RX_RESET, msg); @@ -1267,7 +1238,11 @@ /* iterate over all bvcs and dispatch the paging to each matching one */ hash_for_each(cfg->bss_nses, i, nse, list) { hash_for_each(nse->bvcs, j, bss_bvc, list) { - if (gsm48_ra_equal(&bss_bvc->raid, &raid)) { + /* Skip BVCs without a cell (e.g. signalling) */ + if (!bss_bvc->cell) + continue; + + if (gsm48_ra_equal(&bss_bvc->cell->id.raid, &raid)) { LOGPNSE(nse, LOGL_INFO, "Rx %s: routing to NSE (RAI match)\n", pdut_name); gbprox_relay2peer(msg, bss_bvc, ns_bvci); @@ -1283,7 +1258,11 @@ /* iterate over all bvcs and dispatch the paging to each matching one */ hash_for_each(cfg->bss_nses, i, nse, list) { hash_for_each(nse->bvcs, j, bss_bvc, list) { - gsm48_encode_ra(&lac, &bss_bvc->raid); + /* Skip BVCs without a cell (e.g. signalling) */ + if (!bss_bvc->cell) + continue; + + gsm48_encode_ra(&lac, &bss_bvc->cell->id.raid); if (!memcmp(&lac, TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA), 5)) { LOGPNSE(nse, LOGL_INFO, "Rx %s: routing to NSE (LAI match)\n", pdut_name); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ibc9f42a60706612c17e5f8f0468c7faced5ae4c8 Gerrit-Change-Number: 26219 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:44:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 15:44:14 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 to look at the new patch set (#2). Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... pcu_main: Mark -r cmdline param as deprecated We have VTY support for it enabled in osmo-pcu since a while ago. Let's mark it as depcreated now so that we can drop this cmdline arg in the future. Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f --- M doc/manuals/chapters/running.adoc M src/pcu_main.cpp 2 files changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/15/26215/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:44:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 15:44:52 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Remove duplicate struct gprs_ra_id handling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 ) Change subject: gbproxy: Remove duplicate struct gprs_ra_id handling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ibc9f42a60706612c17e5f8f0468c7faced5ae4c8 Gerrit-Change-Number: 26219 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 15:44:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:47:18 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 15:47:18 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp File src/pcu_main.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp at 77 PS2, Line 77: " -r --realtime PRIO Use SCHED_RR with the specified priority\n" remove here too? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 15:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:48:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 15:48:30 +0000 Subject: Change in osmo-pcu[master]: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enab... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26216 ) Change subject: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 Gerrit-Change-Number: 26216 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 15:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:49:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 15:49:33 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp File src/pcu_main.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp at 77 PS2, Line 77: " -r --realtime PRIO Use SCHED_RR with the specified priority\n" > remove here too? Ack! -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 15:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 15:59:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 15:59:34 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp File src/pcu_main.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp at 77 PS2, Line 77: " -r --realtime PRIO Use SCHED_RR with the specified priority\n" > Ack! ah! I got you wrong, I though you meant the .adoc file. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 15:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:00:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 16:00:39 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp File src/pcu_main.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26215/2/src/pcu_main.cpp at 77 PS2, Line 77: " -r --realtime PRIO Use SCHED_RR with the specified priority\n" > ah! I got you wrong, I though you meant the .adoc file. I didn't even know that we have the command line options in *.adoc :) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 16:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:01:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 16:01:31 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 to look at the new patch set (#3). Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... pcu_main: Mark -r cmdline param as deprecated We have VTY support for it enabled in osmo-pcu since a while ago. Let's mark it as depcreated now so that we can drop this cmdline arg in the future. Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f --- M doc/manuals/chapters/running.adoc M src/pcu_main.cpp 2 files changed, 2 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/15/26215/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:01:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 16:01:31 +0000 Subject: Change in osmo-pcu[master]: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enab... In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26216 to look at the new patch set (#5). Change subject: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' ...................................................................... vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' Related: OS#5306 Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 --- M doc/manuals/chapters/configuration.adoc M doc/manuals/chapters/running.adoc M src/gprs_pcu.h M src/pcu_main.cpp M src/pcu_vty.c 5 files changed, 150 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/16/26216/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 Gerrit-Change-Number: 26216 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:03:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 16:03:04 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 16:03:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:03:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 16:03:46 +0000 Subject: Change in osmo-pcu[master]: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enab... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26216 ) Change subject: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 Gerrit-Change-Number: 26216 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 16:03:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:09:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Nov 2021 16:09:14 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 16:09:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:28:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 16:28:56 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 12 Nov 2021 16:28:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:28:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 16:28:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 ) Change subject: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 Gerrit-Change-Number: 26221 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 12 Nov 2021 16:28:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:39:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 16:39:08 +0000 Subject: Change in osmo-pcu[master]: pcu_main: Mark -r cmdline param as deprecated In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... pcu_main: Mark -r cmdline param as deprecated We have VTY support for it enabled in osmo-pcu since a while ago. Let's mark it as depcreated now so that we can drop this cmdline arg in the future. Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f --- M doc/manuals/chapters/running.adoc M src/pcu_main.cpp 2 files changed, 2 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 5daecf8..78f79b6 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -21,12 +21,6 @@ Specify the file and path name of the configuration file to be used. If none is specified, use `osmo-pcu.cfg` in the current working directory. -*-r, --realtime 'PRIO'*:: - Enable use of the Linux kernel realtime priority scheduler with - the specified priority. - It is recommended you use this option on low-performance - embedded systems or systems that encounter high non-GSM/GPRS - load. *-m, --mcc 'MCC'*:: Use the given MCC instead of that provided by BTS via PCU socket *-n, --mnc 'MNC'*:: diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index 003cabb..7992853 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -74,7 +74,6 @@ " -m --mcc MCC Use given MCC instead of value provided by BTS\n" " -n --mnc MNC Use given MNC instead of value provided by BTS\n" " -V --version Print version\n" - " -r --realtime PRIO Use SCHED_RR with the specified priority\n" " -D --daemonize Fork the process into a background daemon\n" " -i --gsmtap-ip The destination IP used for GSMTAP\n" "\nVTY reference generation:\n" @@ -165,6 +164,8 @@ break; case 'r': rt_prio = atoi(optarg); + fprintf(stderr, "Command line argument '-r' is deprecated, use VTY " + "cpu-sched node setting 'policy rr %d' instead.\n", rt_prio); break; case 'D': daemonize = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 16:39:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 16:39:09 +0000 Subject: Change in osmo-pcu[master]: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enab... In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26216 ) Change subject: vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' ...................................................................... vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' Related: OS#5306 Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 --- M doc/manuals/chapters/configuration.adoc M doc/manuals/chapters/running.adoc M src/gprs_pcu.h M src/pcu_main.cpp M src/pcu_vty.c 5 files changed, 150 insertions(+), 15 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index d778929..ca3963d 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -422,3 +422,71 @@ accomplished and there's no penalty. However, if only EGPRS downlink data is sent over that time frame, then the scheduler will force sending a RLCMAC Dummy Block. + +[[gsmtap]] +=== Configuring GSMTAP tracing + +In addition to being able to obtain pcap protocol traces of the NS/BSSGP +communication and the text-based logging from the OsmoPCU software, there is +also the capability of tracing all communication on the radio interface related +to PS. To do so, OsmoPCU can encapsulate MAC blocks (23-155 byte messages at the +L2-L1 interface depending on coding scheme) into _GSMTAP_ and send them via +UDP/IP. At that point, they can be captured with utilities like *tcpdump* or +*tshark* for further analysis by the *wireshark* protocol analyzer. + +In order to activate this feature, you first need to make sure to specify +the remote address of _GSMTAP_ host in the configuration file. In most +cases, using 127.0.0.1 for passing the messages over the loopback (`lo`) +device will be sufficient: + +.Example: Enabling GSMTAP Um-frame logging to localhost +---- +pcu + gsmtap-remote-host 127.0.0.1 <1> +---- +<1> Destination address for _GSMTAP_ Um-frames + +NOTE: Changing this parameter at run-time will not affect the existing +_GSMTAP_ connection, full program restart is required. + +NOTE: Command line parameters `-i` and `--gsmtap-ip` have been deprecated. + +OsmoPCU can selectively trace such messages based on different categories, for +both Ul and Dl. For a complete list of cateogry values, please refer to the +_OsmoPCU VTY reference manual_ <>. + +For example, to enable GSMTAP tracing for all DL EGPRS rlcmac data blocks, you +can use the `gsmtap-category dl-data-egprs` command at the `pcu` node of the +OsmoPCU VTY. + +.Example: Enabling GSMTAP for for all DL EGPRS rlcmac data blocks +---- +OsmoPCU> enable +OsmoPCU# configure terminal +OsmoPCU(config)# pcu +OsmoPCU(pcu)# gsmtap-category dl-data-egprs +OsmoPCU(trx)# write <1> +---- +<1> the `write` command will make the configuration persistent in the +configuration file. This is not required if you wish to enable GSMTAP +only in the current session of OsmoPCU. + +De-activation can be performed similarly by using the `no gsmtap-category +dl-data-egprs` command at the `pcu` node of the OsmoPCU VTY. + +It may be useful to enable all categories with a few exceptions, or vice versa +disable everything using one command. For this purpose, the VTY provides +`gsmtap-category enable-all` and `gsmtap-category disable-all` commands. + +.Example: Enabling all categoriess except _dl-dummy_ +---- +pcu + gsmtap-category enable-all <1> + no gsmtap-category dl-dummy <2> +---- +<1> Enable all available SAPIs +<2> Exclude DL RLCMAC blocks + +From the moment they are enabled via VTY, GSMTAP messages will be +generated and sent in UDP encapsulation to the IANA-registered UDP port +for GSMTAP (4729) of the specified remote address. diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 78f79b6..c763974 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -25,5 +25,3 @@ Use the given MCC instead of that provided by BTS via PCU socket *-n, --mnc 'MNC'*:: Use the given MNC instead of that provided by BTS via PCU socket -*-i, --gsmtap-ip 'A.B.C.D'*:: - Send Um interface trace via GSMTAP to specified IP address diff --git a/src/gprs_pcu.h b/src/gprs_pcu.h index fdcf5f7..ed00221 100644 --- a/src/gprs_pcu.h +++ b/src/gprs_pcu.h @@ -117,6 +117,7 @@ struct gsmtap_inst *gsmtap; uint32_t gsmtap_categ_mask; + char *gsmtap_remote_host; struct llist_head bts_list; /* list of gprs_rlcmac_bts */ diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index 7992853..fe391b9 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -64,7 +64,7 @@ static int quit = 0; static int rt_prio = -1; static bool daemonize = false; -static const char *gsmtap_addr = "localhost"; // FIXME: use gengetopt's default value instead +static const char *gsmtap_addr; static void print_help() { @@ -75,7 +75,6 @@ " -n --mnc MNC Use given MNC instead of value provided by BTS\n" " -V --version Print version\n" " -D --daemonize Fork the process into a background daemon\n" - " -i --gsmtap-ip The destination IP used for GSMTAP\n" "\nVTY reference generation:\n" " --vty-ref-mode MODE VTY reference generation mode (e.g. 'expert').\n" " --vty-ref-xml Generate the VTY reference XML output and exit.\n" @@ -161,6 +160,8 @@ break; case 'i': gsmtap_addr = optarg; + fprintf(stderr, "Command line argument '-i' is deprecated, use VTY " + "parameter 'gsmtap-remote-host %s' instead.\n", gsmtap_addr); break; case 'r': rt_prio = atoi(optarg); @@ -258,13 +259,6 @@ exit(0); } - pcu->gsmtap = gsmtap_source_init(gsmtap_addr, GSMTAP_UDP_PORT, 1); - - if (pcu->gsmtap) - gsmtap_source_add_sink(pcu->gsmtap); - else - fprintf(stderr, "Failed to initialize GSMTAP for %s\n", gsmtap_addr); - pcu->nsi = gprs_ns2_instantiate(tall_pcu_ctx, gprs_ns_prim_cb, NULL); if (!pcu->nsi) { LOGP(DBSSGP, LOGL_ERROR, "Failed to create NS instance\n"); @@ -283,6 +277,31 @@ fprintf(stderr, "No config file: '%s' Using default config.\n", config_file); + /* Accept a GSMTAP host from VTY config, but a commandline option overrides that. */ + if (gsmtap_addr) { + if (pcu->gsmtap_remote_host != NULL) { + LOGP(DLGLOBAL, LOGL_NOTICE, + "Command line argument '-i %s' overrides " + "'gsmtap-remote-host %s' from the config file\n", + gsmtap_addr, pcu->gsmtap_remote_host); + talloc_free(pcu->gsmtap_remote_host); + } + pcu->gsmtap_remote_host = talloc_strdup(pcu, gsmtap_addr); + } + + if (pcu->gsmtap_remote_host) { + LOGP(DLGLOBAL, LOGL_NOTICE, + "Setting up GSMTAP Um forwarding to '%s:%u'\n", + pcu->gsmtap_remote_host, GSMTAP_UDP_PORT); + pcu->gsmtap = gsmtap_source_init(pcu->gsmtap_remote_host, + GSMTAP_UDP_PORT, 1); + if (pcu->gsmtap == NULL) { + fprintf(stderr, "Failed during gsmtap_source_init()\n"); + exit(1); + } + gsmtap_source_add_sink(pcu->gsmtap); + } + rc = telnet_init_dynif(tall_pcu_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_PCU); if (rc < 0) { diff --git a/src/pcu_vty.c b/src/pcu_vty.c index c85e324..6b33e29 100644 --- a/src/pcu_vty.c +++ b/src/pcu_vty.c @@ -70,6 +70,49 @@ { 0, NULL } }; +DEFUN(cfg_pcu_gsmtap_remote_host, + cfg_pcu_gsmtap_remote_host_cmd, + "gsmtap-remote-host [HOSTNAME]", + "Enable GSMTAP Um logging (see also 'gsmtap-category')\n" + "Remote IP address or hostname ('localhost' if omitted)\n") +{ + osmo_talloc_replace_string(the_pcu, &the_pcu->gsmtap_remote_host, + argc > 0 ? argv[0] : "localhost"); + + if (vty->type != VTY_FILE) + vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE); + + return CMD_SUCCESS; +} + +DEFUN(cfg_pcu_no_gsmtap_remote_host, + cfg_pcu_no_gsmtap_remote_host_cmd, + "no gsmtap-remote-host", + NO_STR "Disable GSMTAP Um logging\n") +{ + if (the_pcu->gsmtap_remote_host) + TALLOC_FREE(the_pcu->gsmtap_remote_host); + + if (vty->type != VTY_FILE) + vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE); + + return CMD_SUCCESS; +} + +DEFUN(cfg_pcu_gsmtap_sapi_all, pcucfg_pcu_gsmtap_categ_all_cmd, + "gsmtap-category (enable-all|disable-all)", + "Enable/disable sending of UL/DL messages over GSMTAP\n" + "Enable all kinds of messages (all categories)\n" + "Disable all kinds of messages (all categories)\n") +{ + + if (strcmp(argv[0], "enable-all") == 0) + the_pcu->gsmtap_categ_mask = UINT32_MAX; + else + the_pcu->gsmtap_categ_mask = 0x00; + + return CMD_SUCCESS; +} DEFUN(cfg_pcu_gsmtap_categ, cfg_pcu_gsmtap_categ_cmd, "HIDDEN", "HIDDEN") { @@ -238,11 +281,14 @@ if (strcmp(the_pcu->pcu_sock_path, PCU_SOCK_DEFAULT)) vty_out(vty, " pcu-socket %s%s", the_pcu->pcu_sock_path, VTY_NEWLINE); + if (the_pcu->gsmtap_remote_host) + vty_out(vty, " gsmtap-remote-host %s%s", the_pcu->gsmtap_remote_host, VTY_NEWLINE); for (i = 0; i < 32; i++) { - uint32_t cs = ((uint32_t)1 << i); - if (the_pcu->gsmtap_categ_mask & cs) { - vty_out(vty, " gsmtap-category %s%s", - get_value_string(pcu_gsmtap_categ_names, i), VTY_NEWLINE); + if (the_pcu->gsmtap_categ_mask & ((uint32_t)1 << i)) { + const char *category_buf; + if (!(category_buf = get_value_string_or_null(pcu_gsmtap_categ_names, i))) + continue; + vty_out(vty, " gsmtap-category %s%s", category_buf, VTY_NEWLINE); } } @@ -1294,6 +1340,9 @@ install_element(PCU_NODE, &cfg_pcu_no_dl_tbf_preemptive_retransmission_cmd); install_element(PCU_NODE, &cfg_pcu_ms_idle_time_cmd); install_element(PCU_NODE, &cfg_pcu_no_ms_idle_time_cmd); + install_element(PCU_NODE, &cfg_pcu_gsmtap_remote_host_cmd); + install_element(PCU_NODE, &cfg_pcu_no_gsmtap_remote_host_cmd); + install_element(PCU_NODE, &pcucfg_pcu_gsmtap_categ_all_cmd); install_element(PCU_NODE, &cfg_pcu_gsmtap_categ_cmd); install_element(PCU_NODE, &cfg_pcu_no_gsmtap_categ_cmd); install_element(PCU_NODE, &cfg_pcu_sock_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibc6f78c46831b3c90ee3e97300fc13dc441df4c8 Gerrit-Change-Number: 26216 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:25:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 17:25:58 +0000 Subject: Change in osmo-pcu[master]: Fix MS ending up with assigned imsi 000 References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26222 ) Change subject: Fix MS ending up with assigned imsi 000 ...................................................................... Fix MS ending up with assigned imsi 000 The whole paging path and data structre is cleaned up. New MS helpers ms_imsi_is_valid() and ms_paging_group() are introduced to help in the process and keep implementation details inside GprsMs class. Related: OS#5303 Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b --- M src/gprs_bssgp_pcu.c M src/gprs_ms.c M src/gprs_ms.h M src/gprs_ms_storage.cpp M src/tbf_dl.cpp M tests/tbf/TbfTest.cpp 6 files changed, 35 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/22/26222/1 diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 4328e07..8cb5302 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -108,12 +108,8 @@ uint8_t egprs_ms_class = 0; int rc; MS_Radio_Access_capability_t rac; - /* TODO: is it really necessary to initialize this as a "000" IMSI? It seems, the function should just return an - * error if no IMSI IE was found. */ - struct osmo_mobile_identity mi_imsi = { - .type = GSM_MI_TYPE_TMSI, - }; - OSMO_STRLCPY_ARRAY(mi_imsi.imsi, "000"); + const char *imsi = NULL; + struct osmo_mobile_identity mi_imsi; budh = (struct bssgp_ud_hdr *)msgb_bssgph(msg); tlli = ntohl(budh->tlli); @@ -144,6 +140,7 @@ LOGP(DBSSGP, LOGL_NOTICE, "Failed to parse IMSI IE (rc=%d)\n", rc); return bssgp_tx_status(BSSGP_CAUSE_COND_IE_ERR, NULL, msg); } + imsi = &mi_imsi.imsi[0]; } /* parse ms radio access capability */ @@ -180,10 +177,11 @@ "TLLI (old) IE\n"); } - LOGP(DBSSGP, LOGL_INFO, "LLC [SGSN -> PCU] = TLLI: 0x%08x IMSI: %s len: %d\n", tlli, mi_imsi.imsi, len); + LOGP(DBSSGP, LOGL_INFO, "LLC [SGSN -> PCU] = TLLI: 0x%08x IMSI: %s len: %d\n", + tlli, imsi ? : "none", len); - return dl_tbf_handle(the_pcu->bssgp.bts, tlli, tlli_old, mi_imsi.imsi, - ms_class, egprs_ms_class, delay_csec, data, len); + return dl_tbf_handle(the_pcu->bssgp.bts, tlli, tlli_old, imsi, ms_class, + egprs_ms_class, delay_csec, data, len); } /* 3GPP TS 48.018 Table 10.3.2. Returns 0 on success, suggested BSSGP cause otherwise */ diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 0d6be4d..5e75d06 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -522,6 +522,18 @@ osmo_strlcpy(ms->imsi, imsi, sizeof(ms->imsi)); } +uint16_t ms_paging_group(struct GprsMs *ms) +{ + uint16_t pgroup; + if (!ms_imsi_is_valid(ms)) + return 0; /* 000 is the special "all paging" group */ + if ((pgroup = imsi2paging_group(ms_imsi(ms))) > 999) { + LOGPMS(ms, DRLCMAC, LOGL_ERROR, "IMSI to paging group failed!\n"); + return 0; + } + return pgroup; +} + void ms_set_ta(struct GprsMs *ms, uint8_t ta_) { if (ta_ == ms->ta) diff --git a/src/gprs_ms.h b/src/gprs_ms.h index 4438a4c..c579cf5 100644 --- a/src/gprs_ms.h +++ b/src/gprs_ms.h @@ -132,6 +132,7 @@ void ms_set_tlli(struct GprsMs *ms, uint32_t tlli); bool ms_confirm_tlli(struct GprsMs *ms, uint32_t tlli); void ms_set_imsi(struct GprsMs *ms, const char *imsi); +uint16_t ms_paging_group(struct GprsMs *ms); void ms_update_l1_meas(struct GprsMs *ms, const struct pcu_l1_meas *meas); @@ -186,6 +187,11 @@ return ms->imsi; } +static inline bool ms_imsi_is_valid(const struct GprsMs *ms) +{ + return ms->imsi[0] != '\0'; +} + static inline uint8_t ms_ta(const struct GprsMs *ms) { return ms->ta; diff --git a/src/gprs_ms_storage.cpp b/src/gprs_ms_storage.cpp index 6245ed9..db3a7f9 100644 --- a/src/gprs_ms_storage.cpp +++ b/src/gprs_ms_storage.cpp @@ -29,8 +29,6 @@ #include } -#define GPRS_UNDEFINED_IMSI "000" - static void ms_storage_ms_idle_cb(struct GprsMs *ms) { llist_del(&ms->list); @@ -89,10 +87,10 @@ /* not found by TLLI */ - if (imsi && imsi[0] && strcmp(imsi, GPRS_UNDEFINED_IMSI) != 0) { + if (imsi && imsi[0] != '\0') { llist_for_each(tmp, &m_list) { ms = llist_entry(tmp, typeof(*ms), list); - if (strcmp(imsi, ms_imsi(ms)) == 0) + if (ms_imsi_is_valid(ms) && strcmp(imsi, ms_imsi(ms)) == 0) return ms; } } diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 05d5ad3..20811ac 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -296,7 +296,9 @@ /* check for existing TBF */ ms = bts_ms_store(bts)->get_ms(tlli, tlli_old, imsi); - if (ms && strlen(ms_imsi(ms)) == 0) { + /* If we got MS by TLLI above let's see if we already have another MS + * object identified by IMSI and merge them */ + if (ms && !ms_imsi_is_valid(ms) && imsi) { ms_old = bts_ms_store(bts)->get_ms(0, 0, imsi); if (ms_old && ms_old != ms) { /* The TLLI has changed (RAU), so there are two MS @@ -310,7 +312,7 @@ if (!ms_dl_tbf(ms) && ms_dl_tbf(ms_old)) { LOGP(DTBF, LOGL_NOTICE, "IMSI %s, old TBF %s: moving DL TBF to new MS object\n", - imsi, ms_dl_tbf(ms_old)->name()); + imsi ? : "unknown", ms_dl_tbf(ms_old)->name()); dl_tbf = ms_dl_tbf(ms_old); /* Move the DL TBF to the new MS */ dl_tbf->set_ms(ms); @@ -323,7 +325,8 @@ if (!ms) ms = bts_alloc_ms(bts, ms_class, egprs_ms_class); - ms_set_imsi(ms, imsi); + if (imsi) + ms_set_imsi(ms, imsi); ms_confirm_tlli(ms, tlli); if (!ms_ms_class(ms) && ms_class) { ms_set_ms_class(ms, ms_class); @@ -618,8 +621,7 @@ osmo_fsm_inst_dispatch(this->state_fsm.fi, TBF_EV_ASSIGN_ADD_CCCH, NULL); /* send immediate assignment */ - if ((pgroup = imsi2paging_group(imsi())) > 999) - LOGPTBFDL(this, LOGL_ERROR, "IMSI to paging group failed! (%s)\n", imsi()); + pgroup = ms_paging_group(ms()); bts_snd_dl_ass(bts, this, pgroup); } } diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index 8700347..9bea528 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -1718,7 +1718,7 @@ OSMO_ASSERT(ms != NULL); OSMO_ASSERT(ms_dl_tbf(ms) != NULL); - if (imsi[0] && strcmp(imsi, "000") != 0) { + if (imsi[0] != '\0') { ms2 = bts_ms_by_tlli(bts, tlli, GSM_RESERVED_TMSI); OSMO_ASSERT(ms == ms2); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b Gerrit-Change-Number: 26222 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:28:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 17:28:58 +0000 Subject: Change in osmo-msc[master]: manuals: remove deprecated -C / --no-dbcounter options References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26223 ) Change subject: manuals: remove deprecated -C / --no-dbcounter options ...................................................................... manuals: remove deprecated -C / --no-dbcounter options Change-Id: I0a7bc537ed84c5f3e203d106893b1cf1ee8b599a --- M doc/manuals/chapters/running.adoc 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/23/26223/1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 565c8d0..445a164 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -5,7 +5,7 @@ === SYNOPSIS -*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH'] [-C] +*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH'] === OPTIONS @@ -42,9 +42,6 @@ <> for further information. *-m, --mncc-sock*:: Same as option -M (deprecated). -*-C, --no-dbcounter*:: - Deprecated. DB statistics and counter has been removed. - This option is only valid for compatibility and does nothing. === Multiple instances -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0a7bc537ed84c5f3e203d106893b1cf1ee8b599a Gerrit-Change-Number: 26223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:28:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 17:28:59 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -M / --mncc-sock-path options References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26224 ) Change subject: Do not mention deprecated -M / --mncc-sock-path options ...................................................................... Do not mention deprecated -M / --mncc-sock-path options Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5 --- M doc/manuals/chapters/running.adoc M src/osmo-msc/msc_main.c 2 files changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/24/26224/1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 445a164..988b84d 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -5,7 +5,7 @@ === SYNOPSIS -*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH'] +*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] === OPTIONS @@ -37,11 +37,6 @@ <> for more information. *-l, --database 'DATABASE'*:: Specify the file name of the SQLite3 database to use as SMS storage -*-M, --mncc-sock-path*:: - Enable the MNCC socket for an external MNCC handler. See - <> for further information. -*-m, --mncc-sock*:: - Same as option -M (deprecated). === Multiple instances diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index cd91d54..07d76dd 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -131,7 +131,6 @@ printf(" -T --timestamp Prefix every log line with a timestamp.\n"); printf(" -V --version Print the version of OsmoMSC.\n"); printf(" -e --log-level number Set a global loglevel.\n"); - printf(" -M --mncc-sock-path PATH Disable built-in MNCC handler and offer socket.\n"); printf("\nVTY reference generation:\n"); printf(" --vty-ref-mode MODE VTY reference generation mode (e.g. 'expert').\n"); @@ -178,7 +177,7 @@ {"timestamp", 0, 0, 'T'}, {"version", 0, 0, 'V' }, {"log-level", 1, 0, 'e'}, - {"mncc-sock-path", 1, 0, 'M'}, + {"mncc-sock-path", 1, 0, 'M'}, /* deprecated */ {"no-dbcounter", 0, 0, 'C'}, /* deprecated */ {"vty-ref-mode", 1, &long_option, 1}, {"vty-ref-xml", 0, &long_option, 2}, @@ -221,6 +220,8 @@ break; case 'M': msc_cmdline_config.mncc_sock_path = optarg; + fprintf(stderr, "Command line argument '-%c' is deprecated, use VTY " + "parameter 'msc' / 'mncc external %s' instead.\n", c, optarg); break; case 'C': fprintf(stderr, "-C is deprecated and does nothing."); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5 Gerrit-Change-Number: 26224 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:29:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 17:29:00 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -l / --database options References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26225 ) Change subject: Do not mention deprecated -l / --database options ...................................................................... Do not mention deprecated -l / --database options Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b --- M doc/manuals/chapters/running.adoc M src/osmo-msc/msc_main.c 2 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/25/26225/1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 988b84d..8665395 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -5,7 +5,7 @@ === SYNOPSIS -*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] +*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] === OPTIONS @@ -35,8 +35,6 @@ Set the global log level for logging to stderr. This has mostly been deprecated by VTY based logging configuration, see <> for more information. -*-l, --database 'DATABASE'*:: - Specify the file name of the SQLite3 database to use as SMS storage === Multiple instances diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 07d76dd..9657c71 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -127,7 +127,6 @@ printf(" -D --daemonize Fork the process into a background daemon.\n"); printf(" -c --config-file filename The config file to use.\n"); printf(" -s --disable-color\n"); - printf(" -l --database db-name The database to use.\n"); printf(" -T --timestamp Prefix every log line with a timestamp.\n"); printf(" -V --version Print the version of OsmoMSC.\n"); printf(" -e --log-level number Set a global loglevel.\n"); @@ -173,7 +172,7 @@ {"daemonize", 0, 0, 'D'}, {"config-file", 1, 0, 'c'}, {"disable-color", 0, 0, 's'}, - {"database", 1, 0, 'l'}, + {"database", 1, 0, 'l'}, /* deprecated */ {"timestamp", 0, 0, 'T'}, {"version", 0, 0, 'V' }, {"log-level", 1, 0, 'e'}, @@ -208,6 +207,8 @@ break; case 'l': msc_cmdline_config.database_name = optarg; + fprintf(stderr, "Command line argument '-%c' is deprecated, use VTY " + "parameter 'msc' / 'sms-database %s' instead.\n", c, optarg); break; case 'c': msc_cmdline_config.config_file = optarg; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b Gerrit-Change-Number: 26225 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:29:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 17:29:04 +0000 Subject: Change in osmo-gsm-manuals[master]: mncc: do not mention deprecated -m / --mncc-sock options References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26226 ) Change subject: mncc: do not mention deprecated -m / --mncc-sock options ...................................................................... mncc: do not mention deprecated -m / --mncc-sock options Change-Id: Icb18fb9e95c5a7f32a85a1b269185298c07354ee --- M common/chapters/mncc.adoc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/26/26226/1 diff --git a/common/chapters/mncc.adoc b/common/chapters/mncc.adoc index 15c9982..3c67998 100644 --- a/common/chapters/mncc.adoc +++ b/common/chapters/mncc.adoc @@ -53,7 +53,8 @@ external MNCC program connected via the MNCC socket. If you intend to operate {program-name} with external MNCC handler, you have -to start it with the `-m` or `--mncc-sock` command line option. +to disable the internal MNCC handler and specify the MNCC socket path in +the configuration file. At the time of this writing, the only external application implementing the MNCC interface compatible with the Osmocom MNCC socket is `lcr`, the Linux Call -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Icb18fb9e95c5a7f32a85a1b269185298c07354ee Gerrit-Change-Number: 26226 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:31:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 17:31:33 +0000 Subject: Change in osmo-msc[master]: manuals: remove deprecated -C / --no-dbcounter options In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26223 ) Change subject: manuals: remove deprecated -C / --no-dbcounter options ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0a7bc537ed84c5f3e203d106893b1cf1ee8b599a Gerrit-Change-Number: 26223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 12 Nov 2021 17:31:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:31:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 17:31:53 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -M / --mncc-sock-path options In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26224 ) Change subject: Do not mention deprecated -M / --mncc-sock-path options ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5 Gerrit-Change-Number: 26224 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 12 Nov 2021 17:31:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:32:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 17:32:08 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -l / --database options In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26225 ) Change subject: Do not mention deprecated -l / --database options ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b Gerrit-Change-Number: 26225 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 12 Nov 2021 17:32:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:38:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 17:38:50 +0000 Subject: Change in osmo-pcu[master]: Fix MS ending up with assigned imsi 000 In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26222 to look at the new patch set (#2). Change subject: Fix MS ending up with assigned imsi 000 ...................................................................... Fix MS ending up with assigned imsi 000 The whole paging path and data structre is cleaned up. New MS helpers ms_imsi_is_valid() and ms_paging_group() are introduced to help in the process and keep implementation details inside GprsMs class. Related: OS#5303 Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b --- M src/bts.cpp M src/bts.h M src/gprs_bssgp_pcu.c M src/gprs_ms.c M src/gprs_ms.h M src/gprs_ms_storage.cpp M src/tbf_dl.cpp M src/tbf_fsm.c M tests/tbf/TbfTest.cpp 9 files changed, 40 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/22/26222/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b Gerrit-Change-Number: 26222 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 17:58:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 17:58:26 +0000 Subject: Change in osmo-pcu[master]: Fix MS ending up with assigned imsi 000 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26222 ) Change subject: Fix MS ending up with assigned imsi 000 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b Gerrit-Change-Number: 26222 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 17:58:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:02:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 18:02:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn at 562 PS1, Line 562: inout GprsMS ms This parameter is not used. And why 'inout'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 18:02:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:03:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 18:03:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 ) Change subject: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 Gerrit-Change-Number: 26221 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 18:03:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:05:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 18:05:39 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn at 562 PS1, Line 562: inout GprsMS ms > This parameter is not used. [?] It's the same as with as_ms_rx_ignore_dummy above. I think we already discussed this before, I don't remember the reason right now, but it probably has to due with extending later on the scheduling to take some MS related configuration into account, and this way the tests already provide the related needed object. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 18:05:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:19:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 18:19:37 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn at 562 PS1, Line 562: inout GprsMS ms > It's the same as with as_ms_rx_ignore_dummy above. [?] I expected this kind of answer, but neither dummy nor empty DATA.req messages contain MS specific info. I simply don't see how GprsMS might be used in the context of empty DATA.req messages, or how can this altstep might evolve in the future so that GprsMS is needed. And same applies to as_ms_rx_ignore_dummy() - requiring the API user to pass aruments for no real need is a bad idea. IMO, both altsteps should not require GprsMS and rather use "as_pcuif_" prefix. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 18:19:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:19:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:19:52 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 ) Change subject: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 Gerrit-Change-Number: 26221 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 12 Nov 2021 18:19:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:12 +0000 Subject: Change in osmo-pcu[master]: Fix MS ending up with assigned imsi 000 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26222 ) Change subject: Fix MS ending up with assigned imsi 000 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b Gerrit-Change-Number: 26222 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Nov 2021 18:21:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:24 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -l / --database options In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26225 ) Change subject: Do not mention deprecated -l / --database options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b Gerrit-Change-Number: 26225 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 18:21:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:31 +0000 Subject: Change in osmo-msc[master]: manuals: remove deprecated -C / --no-dbcounter options In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26223 ) Change subject: manuals: remove deprecated -C / --no-dbcounter options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0a7bc537ed84c5f3e203d106893b1cf1ee8b599a Gerrit-Change-Number: 26223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 18:21:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:39 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -M / --mncc-sock-path options In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26224 ) Change subject: Do not mention deprecated -M / --mncc-sock-path options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5 Gerrit-Change-Number: 26224 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 18:21:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:43 +0000 Subject: Change in osmo-msc[master]: manuals: remove deprecated -C / --no-dbcounter options In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26223 ) Change subject: manuals: remove deprecated -C / --no-dbcounter options ...................................................................... manuals: remove deprecated -C / --no-dbcounter options Change-Id: I0a7bc537ed84c5f3e203d106893b1cf1ee8b599a --- M doc/manuals/chapters/running.adoc 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 565c8d0..445a164 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -5,7 +5,7 @@ === SYNOPSIS -*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH'] [-C] +*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH'] === OPTIONS @@ -42,9 +42,6 @@ <> for further information. *-m, --mncc-sock*:: Same as option -M (deprecated). -*-C, --no-dbcounter*:: - Deprecated. DB statistics and counter has been removed. - This option is only valid for compatibility and does nothing. === Multiple instances -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0a7bc537ed84c5f3e203d106893b1cf1ee8b599a Gerrit-Change-Number: 26223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:43 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -M / --mncc-sock-path options In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26224 ) Change subject: Do not mention deprecated -M / --mncc-sock-path options ...................................................................... Do not mention deprecated -M / --mncc-sock-path options Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5 --- M doc/manuals/chapters/running.adoc M src/osmo-msc/msc_main.c 2 files changed, 4 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 445a164..988b84d 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -5,7 +5,7 @@ === SYNOPSIS -*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] [-M 'SOCKETPATH'] +*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] === OPTIONS @@ -37,11 +37,6 @@ <> for more information. *-l, --database 'DATABASE'*:: Specify the file name of the SQLite3 database to use as SMS storage -*-M, --mncc-sock-path*:: - Enable the MNCC socket for an external MNCC handler. See - <> for further information. -*-m, --mncc-sock*:: - Same as option -M (deprecated). === Multiple instances diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index cd91d54..07d76dd 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -131,7 +131,6 @@ printf(" -T --timestamp Prefix every log line with a timestamp.\n"); printf(" -V --version Print the version of OsmoMSC.\n"); printf(" -e --log-level number Set a global loglevel.\n"); - printf(" -M --mncc-sock-path PATH Disable built-in MNCC handler and offer socket.\n"); printf("\nVTY reference generation:\n"); printf(" --vty-ref-mode MODE VTY reference generation mode (e.g. 'expert').\n"); @@ -178,7 +177,7 @@ {"timestamp", 0, 0, 'T'}, {"version", 0, 0, 'V' }, {"log-level", 1, 0, 'e'}, - {"mncc-sock-path", 1, 0, 'M'}, + {"mncc-sock-path", 1, 0, 'M'}, /* deprecated */ {"no-dbcounter", 0, 0, 'C'}, /* deprecated */ {"vty-ref-mode", 1, &long_option, 1}, {"vty-ref-xml", 0, &long_option, 2}, @@ -221,6 +220,8 @@ break; case 'M': msc_cmdline_config.mncc_sock_path = optarg; + fprintf(stderr, "Command line argument '-%c' is deprecated, use VTY " + "parameter 'msc' / 'mncc external %s' instead.\n", c, optarg); break; case 'C': fprintf(stderr, "-C is deprecated and does nothing."); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34387f561446aa5bf5db5264f0aca6bf6469d0e5 Gerrit-Change-Number: 26224 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:43 +0000 Subject: Change in osmo-msc[master]: Do not mention deprecated -l / --database options In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26225 ) Change subject: Do not mention deprecated -l / --database options ...................................................................... Do not mention deprecated -l / --database options Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b --- M doc/manuals/chapters/running.adoc M src/osmo-msc/msc_main.c 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 988b84d..8665395 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -5,7 +5,7 @@ === SYNOPSIS -*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE'] +*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] === OPTIONS @@ -35,8 +35,6 @@ Set the global log level for logging to stderr. This has mostly been deprecated by VTY based logging configuration, see <> for more information. -*-l, --database 'DATABASE'*:: - Specify the file name of the SQLite3 database to use as SMS storage === Multiple instances diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 07d76dd..9657c71 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -127,7 +127,6 @@ printf(" -D --daemonize Fork the process into a background daemon.\n"); printf(" -c --config-file filename The config file to use.\n"); printf(" -s --disable-color\n"); - printf(" -l --database db-name The database to use.\n"); printf(" -T --timestamp Prefix every log line with a timestamp.\n"); printf(" -V --version Print the version of OsmoMSC.\n"); printf(" -e --log-level number Set a global loglevel.\n"); @@ -173,7 +172,7 @@ {"daemonize", 0, 0, 'D'}, {"config-file", 1, 0, 'c'}, {"disable-color", 0, 0, 's'}, - {"database", 1, 0, 'l'}, + {"database", 1, 0, 'l'}, /* deprecated */ {"timestamp", 0, 0, 'T'}, {"version", 0, 0, 'V' }, {"log-level", 1, 0, 'e'}, @@ -208,6 +207,8 @@ break; case 'l': msc_cmdline_config.database_name = optarg; + fprintf(stderr, "Command line argument '-%c' is deprecated, use VTY " + "parameter 'msc' / 'sms-database %s' instead.\n", c, optarg); break; case 'c': msc_cmdline_config.config_file = optarg; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b Gerrit-Change-Number: 26225 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:52 +0000 Subject: Change in osmo-gsm-manuals[master]: mncc: do not mention deprecated -m / --mncc-sock options In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26226 ) Change subject: mncc: do not mention deprecated -m / --mncc-sock options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Icb18fb9e95c5a7f32a85a1b269185298c07354ee Gerrit-Change-Number: 26226 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 12 Nov 2021 18:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:21:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:21:54 +0000 Subject: Change in osmo-gsm-manuals[master]: mncc: do not mention deprecated -m / --mncc-sock options In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26226 ) Change subject: mncc: do not mention deprecated -m / --mncc-sock options ...................................................................... mncc: do not mention deprecated -m / --mncc-sock options Change-Id: Icb18fb9e95c5a7f32a85a1b269185298c07354ee --- M common/chapters/mncc.adoc 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/mncc.adoc b/common/chapters/mncc.adoc index 15c9982..3c67998 100644 --- a/common/chapters/mncc.adoc +++ b/common/chapters/mncc.adoc @@ -53,7 +53,8 @@ external MNCC program connected via the MNCC socket. If you intend to operate {program-name} with external MNCC handler, you have -to start it with the `-m` or `--mncc-sock` command line option. +to disable the internal MNCC handler and specify the MNCC socket path in +the configuration file. At the time of this writing, the only external application implementing the MNCC interface compatible with the Osmocom MNCC socket is `lcr`, the Linux Call -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Icb18fb9e95c5a7f32a85a1b269185298c07354ee Gerrit-Change-Number: 26226 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:22:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:22:24 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Remove duplicate struct gprs_ra_id handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 ) Change subject: gbproxy: Remove duplicate struct gprs_ra_id handling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ibc9f42a60706612c17e5f8f0468c7faced5ae4c8 Gerrit-Change-Number: 26219 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 18:22:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:22:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:22:36 +0000 Subject: Change in osmo-iuh[master]: Cosmetic: put asn1c parameters in separate lines In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26218 ) Change subject: Cosmetic: put asn1c parameters in separate lines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id1425753f9b4cbce172a1b875a680aa189bb5737 Gerrit-Change-Number: 26218 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 18:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:22:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:22:39 +0000 Subject: Change in osmo-iuh[master]: Cosmetic: put asn1c parameters in separate lines In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26218 ) Change subject: Cosmetic: put asn1c parameters in separate lines ...................................................................... Cosmetic: put asn1c parameters in separate lines Change-Id: Id1425753f9b4cbce172a1b875a680aa189bb5737 --- M src/hnbap/Makefile.am M src/ranap/Makefile.am M src/rua/Makefile.am M src/sabp/Makefile.am 4 files changed, 32 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/hnbap/Makefile.am b/src/hnbap/Makefile.am index 15bee55..ca1df17 100644 --- a/src/hnbap/Makefile.am +++ b/src/hnbap/Makefile.am @@ -243,7 +243,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="HNBAP_" asn1c -R -fcompound-names -gen-PER $(HNBAP_ASN1)/HNBAP-CommonDataTypes.asn $(HNBAP_ASN1)/HNBAP-Constants.asn $(HNBAP_ASN1)/HNBAP-IEs.asn $(HNBAP_ASN1)/HNBAP-PDU.asn + ASN1C_PREFIX="HNBAP_" asn1c \ + -R \ + -fcompound-names \ + -gen-PER \ + $(HNBAP_ASN1)/HNBAP-CommonDataTypes.asn \ + $(HNBAP_ASN1)/HNBAP-Constants.asn \ + $(HNBAP_ASN1)/HNBAP-IEs.asn \ + $(HNBAP_ASN1)/HNBAP-PDU.asn # change include style to `#include ' $(top_srcdir)/move-asn1-header-files.sh osmocom/hnbap $(ASN_MODULE_INC) # Finally copy *.c from buildir to srcdir: diff --git a/src/ranap/Makefile.am b/src/ranap/Makefile.am index 1193dce..0ef9523 100644 --- a/src/ranap/Makefile.am +++ b/src/ranap/Makefile.am @@ -1169,7 +1169,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="RANAP_" asn1c -fcompound-names -R -gen-PER $(top_srcdir)/asn1/ranap/RANAP-CommonDataTypes.asn $(top_srcdir)/asn1/ranap/RANAP-Constants.asn $(top_srcdir)/asn1/ranap/RANAP-IEs.asn $(top_srcdir)/asn1/ranap/RANAP-PDU.asn + ASN1C_PREFIX="RANAP_" asn1c \ + -fcompound-names \ + -R \ + -gen-PER \ + $(top_srcdir)/asn1/ranap/RANAP-CommonDataTypes.asn \ + $(top_srcdir)/asn1/ranap/RANAP-Constants.asn \ + $(top_srcdir)/asn1/ranap/RANAP-IEs.asn \ + $(top_srcdir)/asn1/ranap/RANAP-PDU.asn sed -i '7i#include ' RANAP_ChosenEncryptionAlgorithm.h RANAP_ChosenIntegrityProtectionAlgorithm.h RANAP_IMSI.h RANAP_PLMNidentity.h RANAP_RAB-ReleaseFailedList.c RANAP_RAB-ReleaseList.c RANAP_RAB-SetupOrModifyList.c RANAP_ResetResourceList.c RANAP_ResetResourceAckList.c # change include style to `#include ' $(top_srcdir)/move-asn1-header-files.sh osmocom/ranap $(ASN_MODULE_INC) diff --git a/src/rua/Makefile.am b/src/rua/Makefile.am index 8cb2e7d..23ff20e 100644 --- a/src/rua/Makefile.am +++ b/src/rua/Makefile.am @@ -81,7 +81,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="RUA_" asn1c -R -fcompound-names -gen-PER $(top_srcdir)/asn1/rua/RUA-CommonDataTypes.asn $(top_srcdir)/asn1/rua/RUA-Constants.asn $(top_srcdir)/asn1/rua/RUA-IEs.asn $(top_srcdir)/asn1/rua/RUA-PDU.asn + ASN1C_PREFIX="RUA_" asn1c \ + -R \ + -fcompound-names \ + -gen-PER \ + $(top_srcdir)/asn1/rua/RUA-CommonDataTypes.asn \ + $(top_srcdir)/asn1/rua/RUA-Constants.asn \ + $(top_srcdir)/asn1/rua/RUA-IEs.asn \ + $(top_srcdir)/asn1/rua/RUA-PDU.asn # change include style to `#include ' $(top_srcdir)/move-asn1-header-files.sh osmocom/rua $(ASN_MODULE_INC) # Finally copy *.c from buildir to srcdir: diff --git a/src/sabp/Makefile.am b/src/sabp/Makefile.am index 0665db4..8dc1390 100644 --- a/src/sabp/Makefile.am +++ b/src/sabp/Makefile.am @@ -135,7 +135,14 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="SABP_" asn1c -R -fcompound-names -gen-PER $(top_srcdir)/asn1/sabp/SABP-CommonDataTypes.asn $(top_srcdir)/asn1/sabp/SABP-Constants.asn $(top_srcdir)/asn1/sabp/SABP-IEs.asn $(top_srcdir)/asn1/sabp/SABP-PDU.asn + ASN1C_PREFIX="SABP_" asn1c \ + -R \ + -fcompound-names \ + -gen-PER \ + $(top_srcdir)/asn1/sabp/SABP-CommonDataTypes.asn \ + $(top_srcdir)/asn1/sabp/SABP-Constants.asn \ + $(top_srcdir)/asn1/sabp/SABP-IEs.asn \ + $(top_srcdir)/asn1/sabp/SABP-PDU.asn # add missing includes sed -i '/#include "SABP_Serial-Number.h"/a #include ' SABP_Old-Serial-Number.h SABP_New-Serial-Number.h # change include style to `#include ' -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id1425753f9b4cbce172a1b875a680aa189bb5737 Gerrit-Change-Number: 26218 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:22:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 18:22:56 +0000 Subject: Change in osmo-hnodeb[master]: configure: don't turn some warnings into errors In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 Gerrit-Change-Number: 26213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 18:22:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:31:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 18:31:48 +0000 Subject: Change in osmo-pcu[master]: Fix MS ending up with assigned imsi 000 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26222 ) Change subject: Fix MS ending up with assigned imsi 000 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b Gerrit-Change-Number: 26222 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 18:31:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:31:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 18:31:50 +0000 Subject: Change in osmo-pcu[master]: Fix MS ending up with assigned imsi 000 In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26222 ) Change subject: Fix MS ending up with assigned imsi 000 ...................................................................... Fix MS ending up with assigned imsi 000 The whole paging path and data structre is cleaned up. New MS helpers ms_imsi_is_valid() and ms_paging_group() are introduced to help in the process and keep implementation details inside GprsMs class. Related: OS#5303 Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b --- M src/bts.cpp M src/bts.h M src/gprs_bssgp_pcu.c M src/gprs_ms.c M src/gprs_ms.h M src/gprs_ms_storage.cpp M src/tbf_dl.cpp M src/tbf_fsm.c M tests/tbf/TbfTest.cpp 9 files changed, 40 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/bts.cpp b/src/bts.cpp index dc20259..6fabc90 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -1037,10 +1037,11 @@ return 0; } -void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf, uint16_t pgroup) +void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf) { uint8_t trx_no = tbf->trx->trx_no; uint8_t ts_no = tbf->first_ts; + uint16_t pgroup = ms_paging_group(tbf_ms(tbf)); int plen; LOGPTBF(tbf, LOGL_INFO, "TX: START Immediate Assignment Downlink (PCH)\n"); diff --git a/src/bts.h b/src/bts.h index 3a58c63..f947a55 100644 --- a/src/bts.h +++ b/src/bts.h @@ -301,7 +301,7 @@ struct gprs_rlcmac_dl_tbf *bts_dl_tbf_by_tfi(struct gprs_rlcmac_bts *bts, uint8_t tfi, uint8_t trx, uint8_t ts); struct gprs_rlcmac_ul_tbf *bts_ul_tbf_by_tfi(struct gprs_rlcmac_bts *bts, uint8_t tfi, uint8_t trx, uint8_t ts); -void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf, uint16_t pgroup); +void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, struct gprs_rlcmac_tbf *tbf); void bts_set_current_frame_number(struct gprs_rlcmac_bts *bts, uint32_t frame_number); void bts_set_current_block_frame_number(struct gprs_rlcmac_bts *bts, int frame_number); diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 4328e07..8cb5302 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -108,12 +108,8 @@ uint8_t egprs_ms_class = 0; int rc; MS_Radio_Access_capability_t rac; - /* TODO: is it really necessary to initialize this as a "000" IMSI? It seems, the function should just return an - * error if no IMSI IE was found. */ - struct osmo_mobile_identity mi_imsi = { - .type = GSM_MI_TYPE_TMSI, - }; - OSMO_STRLCPY_ARRAY(mi_imsi.imsi, "000"); + const char *imsi = NULL; + struct osmo_mobile_identity mi_imsi; budh = (struct bssgp_ud_hdr *)msgb_bssgph(msg); tlli = ntohl(budh->tlli); @@ -144,6 +140,7 @@ LOGP(DBSSGP, LOGL_NOTICE, "Failed to parse IMSI IE (rc=%d)\n", rc); return bssgp_tx_status(BSSGP_CAUSE_COND_IE_ERR, NULL, msg); } + imsi = &mi_imsi.imsi[0]; } /* parse ms radio access capability */ @@ -180,10 +177,11 @@ "TLLI (old) IE\n"); } - LOGP(DBSSGP, LOGL_INFO, "LLC [SGSN -> PCU] = TLLI: 0x%08x IMSI: %s len: %d\n", tlli, mi_imsi.imsi, len); + LOGP(DBSSGP, LOGL_INFO, "LLC [SGSN -> PCU] = TLLI: 0x%08x IMSI: %s len: %d\n", + tlli, imsi ? : "none", len); - return dl_tbf_handle(the_pcu->bssgp.bts, tlli, tlli_old, mi_imsi.imsi, - ms_class, egprs_ms_class, delay_csec, data, len); + return dl_tbf_handle(the_pcu->bssgp.bts, tlli, tlli_old, imsi, ms_class, + egprs_ms_class, delay_csec, data, len); } /* 3GPP TS 48.018 Table 10.3.2. Returns 0 on success, suggested BSSGP cause otherwise */ diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 0d6be4d..5e75d06 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -522,6 +522,18 @@ osmo_strlcpy(ms->imsi, imsi, sizeof(ms->imsi)); } +uint16_t ms_paging_group(struct GprsMs *ms) +{ + uint16_t pgroup; + if (!ms_imsi_is_valid(ms)) + return 0; /* 000 is the special "all paging" group */ + if ((pgroup = imsi2paging_group(ms_imsi(ms))) > 999) { + LOGPMS(ms, DRLCMAC, LOGL_ERROR, "IMSI to paging group failed!\n"); + return 0; + } + return pgroup; +} + void ms_set_ta(struct GprsMs *ms, uint8_t ta_) { if (ta_ == ms->ta) diff --git a/src/gprs_ms.h b/src/gprs_ms.h index 4438a4c..c579cf5 100644 --- a/src/gprs_ms.h +++ b/src/gprs_ms.h @@ -132,6 +132,7 @@ void ms_set_tlli(struct GprsMs *ms, uint32_t tlli); bool ms_confirm_tlli(struct GprsMs *ms, uint32_t tlli); void ms_set_imsi(struct GprsMs *ms, const char *imsi); +uint16_t ms_paging_group(struct GprsMs *ms); void ms_update_l1_meas(struct GprsMs *ms, const struct pcu_l1_meas *meas); @@ -186,6 +187,11 @@ return ms->imsi; } +static inline bool ms_imsi_is_valid(const struct GprsMs *ms) +{ + return ms->imsi[0] != '\0'; +} + static inline uint8_t ms_ta(const struct GprsMs *ms) { return ms->ta; diff --git a/src/gprs_ms_storage.cpp b/src/gprs_ms_storage.cpp index 6245ed9..db3a7f9 100644 --- a/src/gprs_ms_storage.cpp +++ b/src/gprs_ms_storage.cpp @@ -29,8 +29,6 @@ #include } -#define GPRS_UNDEFINED_IMSI "000" - static void ms_storage_ms_idle_cb(struct GprsMs *ms) { llist_del(&ms->list); @@ -89,10 +87,10 @@ /* not found by TLLI */ - if (imsi && imsi[0] && strcmp(imsi, GPRS_UNDEFINED_IMSI) != 0) { + if (imsi && imsi[0] != '\0') { llist_for_each(tmp, &m_list) { ms = llist_entry(tmp, typeof(*ms), list); - if (strcmp(imsi, ms_imsi(ms)) == 0) + if (ms_imsi_is_valid(ms) && strcmp(imsi, ms_imsi(ms)) == 0) return ms; } } diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 05d5ad3..6e898da 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -296,7 +296,9 @@ /* check for existing TBF */ ms = bts_ms_store(bts)->get_ms(tlli, tlli_old, imsi); - if (ms && strlen(ms_imsi(ms)) == 0) { + /* If we got MS by TLLI above let's see if we already have another MS + * object identified by IMSI and merge them */ + if (ms && !ms_imsi_is_valid(ms) && imsi) { ms_old = bts_ms_store(bts)->get_ms(0, 0, imsi); if (ms_old && ms_old != ms) { /* The TLLI has changed (RAU), so there are two MS @@ -310,7 +312,7 @@ if (!ms_dl_tbf(ms) && ms_dl_tbf(ms_old)) { LOGP(DTBF, LOGL_NOTICE, "IMSI %s, old TBF %s: moving DL TBF to new MS object\n", - imsi, ms_dl_tbf(ms_old)->name()); + imsi ? : "unknown", ms_dl_tbf(ms_old)->name()); dl_tbf = ms_dl_tbf(ms_old); /* Move the DL TBF to the new MS */ dl_tbf->set_ms(ms); @@ -323,7 +325,8 @@ if (!ms) ms = bts_alloc_ms(bts, ms_class, egprs_ms_class); - ms_set_imsi(ms, imsi); + if (imsi) + ms_set_imsi(ms, imsi); ms_confirm_tlli(ms, tlli); if (!ms_ms_class(ms) && ms_class) { ms_set_ms_class(ms, ms_class); @@ -599,7 +602,6 @@ /* depending on the current TBF, we assign on PACCH or AGCH */ void gprs_rlcmac_dl_tbf::trigger_ass(struct gprs_rlcmac_tbf *old_tbf) { - uint16_t pgroup; /* stop pending timer */ stop_timers("assignment (DL-TBF)"); @@ -618,9 +620,7 @@ osmo_fsm_inst_dispatch(this->state_fsm.fi, TBF_EV_ASSIGN_ADD_CCCH, NULL); /* send immediate assignment */ - if ((pgroup = imsi2paging_group(imsi())) > 999) - LOGPTBFDL(this, LOGL_ERROR, "IMSI to paging group failed! (%s)\n", imsi()); - bts_snd_dl_ass(bts, this, pgroup); + bts_snd_dl_ass(bts, this); } } diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c index af2b34e..39f2080 100644 --- a/src/tbf_fsm.c +++ b/src/tbf_fsm.c @@ -214,15 +214,11 @@ if ((ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH)) && !(ctx->state_flags & (1 << GPRS_RLCMAC_FLAG_DL_ACK))) { struct GprsMs *ms = tbf_ms(ctx->tbf); - const char *imsi = ms_imsi(ms); - uint16_t pgroup; LOGPTBF(ctx->tbf, LOGL_DEBUG, "Re-send downlink assignment on PCH (IMSI=%s)\n", - imsi); + ms_imsi_is_valid(ms) ? ms_imsi(ms) : ""); tbf_fsm_state_chg(fi, TBF_ST_ASSIGN); /* send immediate assignment */ - if ((pgroup = imsi2paging_group(imsi)) > 999) - LOGPTBF(ctx->tbf, LOGL_ERROR, "IMSI to paging group failed! (%s)\n", imsi); - bts_snd_dl_ass(ms->bts, ctx->tbf, pgroup); + bts_snd_dl_ass(ms->bts, ctx->tbf); } break; case TBF_EV_LAST_DL_DATA_SENT: diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index 8700347..9bea528 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -1718,7 +1718,7 @@ OSMO_ASSERT(ms != NULL); OSMO_ASSERT(ms_dl_tbf(ms) != NULL); - if (imsi[0] && strcmp(imsi, "000") != 0) { + if (imsi[0] != '\0') { ms2 = bts_ms_by_tlli(bts, tlli, GSM_RESERVED_TMSI); OSMO_ASSERT(ms == ms2); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4c0838b26ede58e4b711410eee2a8e4f71e9414b Gerrit-Change-Number: 26222 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 18:34:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 18:34:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn at 562 PS1, Line 562: inout GprsMS ms > I expected this kind of answer, but neither dummy nor empty DATA. [?] In the event of multi-ts TBF, you want to schedule the next TS fore the MS in line 569. We are not doing that yet, but that will require access to MS specific data. That's why. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 18:34:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 19:44:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 19:44:58 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for Temporary ACCH Overpower References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26227 ) Change subject: doc/manuals: add documentation for Temporary ACCH Overpower ...................................................................... doc/manuals: add documentation for Temporary ACCH Overpower Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc 1 file changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/26227/1 diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc index f94dd2e..e76bd82 100644 --- a/doc/manuals/chapters/power_control.adoc +++ b/doc/manuals/chapters/power_control.adoc @@ -565,3 +565,61 @@ ---- <1> Remote address of the host running osmo-bsc (localhost in this example) <2> Maximum BCCH carrier power reduction currently applied + +=== Temporary ACCH overpower + +Temporary overpower (TOP) is a power control technique that allows to improve +SACCH/FACCH performance in case of bad C/I. The key idea of TOP is to +increment the BS transmit power by 2..4 dB only for FACCH/SACCH bursts, while +keeping all voice bursts at the lower (normal) level as determined by the +downlink power control loop. This allows to reduce call drop rate and +increase capacity in deployments with tight frequence reuse. + +NOTE: It's not possible to increase the current BS power beyond the maximum +transmit power level supported by the PHY. Thus if the BTS is already +transmitting at full power, the overpower logic cannot increase it even +further. This is also why TOP must be employed *together with BS power +control*, either static or dynamic. + +The main area of use for TOP is traffic channels employing the AMR (Adaptive +Multi Rate) codec, that is more robust to interference than the associated +signalling channels. While AMR provides sufficient speech quality even at +very low C/I levels, the associated signalling channels may be suffering from +channel coding errors. This imbalance can be compensated by employing TOP, +which can be efficiently combined with the ACCH repetition technique. + +This feature requires no support on the mobile station side and can be used +with UEs implementing the most recent 3GPP relese features, as well as legacy +UEs. However, it needs to be implemented in the BTS. Given that TOP itself +is not specified in 3GPP specifications, osmo-bsc uses Osmocom specific +A-bis/RSL IEs in order to activate it. Therefore, only the recent osmo-bts +versions may be instructed to activate this feature. Make sure that feature +#023 "FACCH/SACCH Temporary overpower" is present in the feature vector. +This can be checked by issuing `show bts` command in OsmoBSC's VTY interface. + +TOP is disabled by default. Below is a configuration example enabling it: + +---- +network + bts 0 + overpower dl-acch 2 <1> + overpower rxqual 4 <2> +---- +<1> Overpower of maximum 2 dB for both SACCH and FACCH. +<2> Enable TOP only if RxQual is worse than 4 (BER >= 1.6%). + +It's also possible to enable TOP only for FACCH or SACCH selectively, or +or keep it enabled permanently regardless of the reported RxQual: + +---- +OsmoBSC(config-net-bts)# overpower ? + dl-acch Enable overpower for both SACCH and FACCH + dl-sacch Enable overpower for SACCH only + dl-facch Enable overpower for FACCH only + +OsmoBSC(config-net-bts)# overpower rxqual 0? + 0 BER >= 0% (always on) +---- + +These parameters are indicated to the BTS during a logical channel activation +or modifications procedures, so they can be changed at run-time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Gerrit-Change-Number: 26227 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 19:51:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 19:51:31 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for Temporary ACCH Overpower In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26227 ) Change subject: doc/manuals: add documentation for Temporary ACCH Overpower ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26227/1/doc/manuals/chapters/power_control.adoc File doc/manuals/chapters/power_control.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/26227/1/doc/manuals/chapters/power_control.adoc at 585 PS1, Line 585: that which -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Gerrit-Change-Number: 26227 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 19:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 19:52:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 19:52:07 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for Temporary ACCH Overpower In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 to look at the new patch set (#2). Change subject: doc/manuals: add documentation for Temporary ACCH Overpower ...................................................................... doc/manuals: add documentation for Temporary ACCH Overpower Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc 1 file changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/26227/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Gerrit-Change-Number: 26227 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 20:01:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 12 Nov 2021 20:01:08 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for Temporary ACCH Overpower In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26227 ) Change subject: doc/manuals: add documentation for Temporary ACCH Overpower ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Gerrit-Change-Number: 26227 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 20:01:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 20:04:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 20:04:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn at 562 PS1, Line 562: inout GprsMS ms > In the event of multi-ts TBF, you want to schedule the next TS fore the MS in line 569. [?] My understanding is that here we send RTS.req exactly for the same timeslot as indicated in the received DATA.req. The timeslot number is determined by TsTrxBtsNum, not GprsMS. If we start sending RTS.req with different timeslot numbers from here, or even for multiple timeslots, then it's a mess. If we ever want to make this altstep handle several timeslots, then one can change it to accept a receive TsTrxBtsNum template, which would match several TRX/TS values. In the end, you can always introduce GprsMS parameter when you actually start using it. Having it now is meaningless and confusing. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 20:04:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 20:06:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 20:06:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn at 562 PS1, Line 562: inout GprsMS ms > My understanding is that here we send RTS. [?] I mean, it's like buying shoes or clots with greater/lower size in hope that some day in the future they'll fit :D -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 12 Nov 2021 20:06:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 20:36:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 12 Nov 2021 20:36:06 +0000 Subject: Change in osmo-e1d[master]: make compile-time default logging configuration less verbose References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26228 ) Change subject: make compile-time default logging configuration less verbose ...................................................................... make compile-time default logging configuration less verbose As Keith pointed out we shouldn't spam the stderr with debug level logging by default. Change-Id: I909affb3b798c13950f95628275a6ec3a38c76ca --- M src/log.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/28/26228/1 diff --git a/src/log.c b/src/log.c index c50efe5..e2b90dc 100644 --- a/src/log.c +++ b/src/log.c @@ -30,12 +30,12 @@ static const struct log_info_cat default_categories[] = { [DE1D] = { .name = "DE1D", - .loglevel = LOGL_DEBUG, + .loglevel = LOGL_INFO, .enabled = 1, }, [DXFR] = { .name = "DXFR", - .loglevel = LOGL_DEBUG, + .loglevel = LOGL_NOTICE, .enabled = 1, }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I909affb3b798c13950f95628275a6ec3a38c76ca Gerrit-Change-Number: 26228 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 21:10:56 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 12 Nov 2021 21:10:56 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for Temporary ACCH Overpower In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26227 ) Change subject: doc/manuals: add documentation for Temporary ACCH Overpower ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Gerrit-Change-Number: 26227 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 21:10:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 21:31:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 21:31:13 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for Temporary ACCH Overpower In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26227 ) Change subject: doc/manuals: add documentation for Temporary ACCH Overpower ...................................................................... Patch Set 2: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Gerrit-Change-Number: 26227 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Nov 2021 21:31:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 12 21:31:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 12 Nov 2021 21:31:20 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: add documentation for Temporary ACCH Overpower In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26227 ) Change subject: doc/manuals: add documentation for Temporary ACCH Overpower ...................................................................... doc/manuals: add documentation for Temporary ACCH Overpower Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc 1 file changed, 58 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc index f94dd2e..dee0470 100644 --- a/doc/manuals/chapters/power_control.adoc +++ b/doc/manuals/chapters/power_control.adoc @@ -565,3 +565,61 @@ ---- <1> Remote address of the host running osmo-bsc (localhost in this example) <2> Maximum BCCH carrier power reduction currently applied + +=== Temporary ACCH overpower + +Temporary overpower (TOP) is a power control technique that allows to improve +SACCH/FACCH performance in case of bad C/I. The key idea of TOP is to +increment the BS transmit power by 2..4 dB only for FACCH/SACCH bursts, while +keeping all voice bursts at the lower (normal) level as determined by the +downlink power control loop. This allows to reduce call drop rate and +increase capacity in deployments with tight frequency reuse. + +NOTE: It's not possible to increase the current BS power beyond the maximum +transmit power level supported by the PHY. Thus if the BTS is already +transmitting at full power, the overpower logic cannot increase it even +further. This is also why TOP must be employed *together with BS power +control*, either static or dynamic. + +The main area of use for TOP is traffic channels employing the AMR (Adaptive +Multi Rate) codec, which is more robust to interference than the associated +signalling channels. While AMR provides sufficient speech quality even at +very low C/I levels, the associated signalling channels may be suffering from +channel coding errors. This imbalance can be compensated by employing TOP, +which can be efficiently combined with the ACCH repetition technique. + +This feature requires no support on the mobile station side and can be used +with UEs implementing the most recent 3GPP relese features, as well as legacy +UEs. However, it needs to be implemented in the BTS. Given that TOP itself +is not specified in 3GPP specifications, osmo-bsc uses Osmocom specific +A-bis/RSL IEs in order to activate it. Therefore, only the recent osmo-bts +versions may be instructed to activate this feature. Make sure that feature +#023 "FACCH/SACCH Temporary overpower" is present in the feature vector. +This can be checked by issuing `show bts` command in OsmoBSC's VTY interface. + +TOP is disabled by default. Below is a configuration example enabling it: + +---- +network + bts 0 + overpower dl-acch 2 <1> + overpower rxqual 4 <2> +---- +<1> Overpower of maximum 2 dB for both SACCH and FACCH. +<2> Enable TOP only if RxQual is worse than 4 (BER >= 1.6%). + +It's also possible to enable TOP only for FACCH or SACCH selectively, or +or keep it enabled permanently regardless of the reported RxQual: + +---- +OsmoBSC(config-net-bts)# overpower ? + dl-acch Enable overpower for both SACCH and FACCH + dl-sacch Enable overpower for SACCH only + dl-facch Enable overpower for FACCH only + +OsmoBSC(config-net-bts)# overpower rxqual 0? + 0 BER >= 0% (always on) +---- + +These parameters are indicated to the BTS during a logical channel activation +or modifications procedures, so they can be changed at run-time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie995dac6c7083a2b0b4d582f71f55b3736381edb Gerrit-Change-Number: 26227 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 00:38:56 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 13 Nov 2021 00:38:56 +0000 Subject: Change in osmo-e1d[master]: make compile-time default logging configuration less verbose In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26228 ) Change subject: make compile-time default logging configuration less verbose ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I909affb3b798c13950f95628275a6ec3a38c76ca Gerrit-Change-Number: 26228 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 13 Nov 2021 00:38:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 08:58:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 13 Nov 2021 08:58:49 +0000 Subject: Change in libosmo-abis[master]: lapd: don't add parenthesis around datalink name References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26229 ) Change subject: lapd: don't add parenthesis around datalink name ...................................................................... lapd: don't add parenthesis around datalink name The name [printing] works like this: * libosmo-abis:lapd tells libosmogsm:lapd_core a name for each data link * libosmgsm:lapd_core assumes this name has no paranthesis and puts additional parenthesis around it in macros like LOGDL However, current libosmo-abis:lapd [before this patch] adds its own set of parenthesis, causing all ISDN-LAPD related log messages generated by libosmgsm:lapd_core to have double-parenthesis. So we have to remove the parenthesis from lapd_datalink.name and lapd_instance.name to fix the log lines printed in libosmocore. This in turn means we have to add parenthesis to some log statements here in libosmo-abis:lapd. Why can't we instead modify libosmogsm:lapd_core to drop parenthesis there? Becaus it is also used by LAPDm code in osmo-bts, and those two get it right :) Change-Id: I688cf2a73a8c31cb3cf66ec005d02a14de197008 Related: Ie6742843fff809edffcac24c4dce4edf66bc71be Related: OS#1938 --- M src/input/lapd.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/29/26229/1 diff --git a/src/input/lapd.c b/src/input/lapd.c index d8c67e4..6f1e270 100644 --- a/src/input/lapd.c +++ b/src/input/lapd.c @@ -74,13 +74,13 @@ #define LAPD_SET_K(n, o) {n,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o} #define LOGLI(li, level, fmt, args ...) \ - LOGP(DLLAPD, level, "%s: " fmt, (li)->name, ## args) + LOGP(DLLAPD, level, "(%s): " fmt, (li)->name, ## args) #define LOGTEI(teip, level, fmt, args ...) \ LOGP(DLLAPD, level, "(%s-T%u): " fmt, (teip)->li->name, (teip)->tei, ## args) #define LOGSAP(sap, level, fmt, args ...) \ - LOGP(DLLAPD, level, "%s: " fmt, (sap)->dl.name, ## args) + LOGP(DLLAPD, level, "(%s): " fmt, (sap)->dl.name, ## args) #define DLSAP_MSGB_SIZE 128 #define DLSAP_MSGB_HEADROOM 56 @@ -240,14 +240,14 @@ char name[256]; int k; - snprintf(name, sizeof(name), "(%s-T%u-S%u)", li->name, teip->tei, sapi); + snprintf(name, sizeof(name), "%s-T%u-S%u", li->name, teip->tei, sapi); sap = talloc_zero(teip, struct lapd_sap); if (!sap) return NULL; LOGP(DLLAPD, LOGL_NOTICE, - "%s: LAPD Allocating SAP for SAPI=%u / TEI=%u (dl=%p, sap=%p)\n", + "(%s): LAPD Allocating SAP for SAPI=%u / TEI=%u (dl=%p, sap=%p)\n", name, sapi, teip->tei, &sap->dl, sap); sap->sapi = sapi; @@ -256,7 +256,7 @@ profile = &li->profile; k = profile->k[sapi & 0x3f]; - LOGP(DLLAPD, LOGL_NOTICE, "%s: k=%d N200=%d N201=%d T200=%d.%d T203=%d.%d\n", + LOGP(DLLAPD, LOGL_NOTICE, "(%s): k=%d N200=%d N201=%d T200=%d.%d T203=%d.%d\n", name, k, profile->n200, profile->n201, profile->t200_sec, profile->t200_usec, profile->t203_sec, profile->t203_usec); lapd_dl_init2(dl, k, 128, profile->n201, name); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I688cf2a73a8c31cb3cf66ec005d02a14de197008 Gerrit-Change-Number: 26229 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 09:01:17 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Sat, 13 Nov 2021 09:01:17 +0000 Subject: Change in osmo-e1d[master]: make compile-time default logging configuration less verbose In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26228 ) Change subject: make compile-time default logging configuration less verbose ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I909affb3b798c13950f95628275a6ec3a38c76ca Gerrit-Change-Number: 26228 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: tnt Gerrit-Comment-Date: Sat, 13 Nov 2021 09:01:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 09:13:39 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Sat, 13 Nov 2021 09:13:39 +0000 Subject: Change in libosmo-abis[master]: lapd: don't add parenthesis around datalink name In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26229 ) Change subject: lapd: don't add parenthesis around datalink name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I688cf2a73a8c31cb3cf66ec005d02a14de197008 Gerrit-Change-Number: 26229 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Sat, 13 Nov 2021 09:13:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 20:38:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sat, 13 Nov 2021 20:38:01 +0000 Subject: Change in libosmo-abis[master]: lapd: don't add parenthesis around datalink name In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26229 ) Change subject: lapd: don't add parenthesis around datalink name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I688cf2a73a8c31cb3cf66ec005d02a14de197008 Gerrit-Change-Number: 26229 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Sat, 13 Nov 2021 20:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:29:59 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:29:59 +0000 Subject: Change in osmo-dev[master]: all.deps: remove duplicate osmo-pcu, osmo-trx In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26217 ) Change subject: all.deps: remove duplicate osmo-pcu, osmo-trx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7c6023f1c8bc23beff3bb512f059ce1b692d2adf Gerrit-Change-Number: 26217 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Sat, 13 Nov 2021 22:29:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:30:52 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:30:52 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: proj_files: ignore config.h In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25737 ) Change subject: gen_makefile.py: proj_files: ignore config.h ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I10d970f2cadacb5071dcde975c76b15404038a3c Gerrit-Change-Number: 25737 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 13 Nov 2021 22:30:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:32:30 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:32:30 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: add --auto-distclean In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25738 ) Change subject: gen_makefile.py: add --auto-distclean ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iac71333e8c5da8dee4e8f34e2af8db12d2c08021 Gerrit-Change-Number: 25738 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 13 Nov 2021 22:32:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:33:06 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:33:06 +0000 Subject: Change in osmo-dev[master]: ttcn3.sh: use --auto-distclean In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25739 ) Change subject: ttcn3.sh: use --auto-distclean ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7d61405dc989eed4935bc6de00e36c1f3b18a428 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: neels Gerrit-Comment-Date: Sat, 13 Nov 2021 22:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:33:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:33:36 +0000 Subject: Change in osmo-dev[master]: all.deps: remove duplicate osmo-pcu, osmo-trx In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26217 ) Change subject: all.deps: remove duplicate osmo-pcu, osmo-trx ...................................................................... all.deps: remove duplicate osmo-pcu, osmo-trx Fix warnings about duplicate make targets. Change-Id: I7c6023f1c8bc23beff3bb512f059ce1b692d2adf --- M all.deps 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/all.deps b/all.deps index 368a53e..65bdf27 100644 --- a/all.deps +++ b/all.deps @@ -15,8 +15,6 @@ osmo-sip-connector libosmocore osmo-bts libosmo-netif osmo-smlc libosmo-sccp -osmo-pcu libosmocore -osmo-trx libosmocore # osmo-trx can build with --enable-sanitize, but then won't work reliably. # When omitting --enable-sanitize from osmo-trx only, its 'make check' will fail. # So if you want osmo-trx, use no sanitize.opts, or use LD_PRELOAD for osmo-trx binaries. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7c6023f1c8bc23beff3bb512f059ce1b692d2adf Gerrit-Change-Number: 26217 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:33:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:33:36 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: proj_files: ignore config.h In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25737 ) Change subject: gen_makefile.py: proj_files: ignore config.h ...................................................................... gen_makefile.py: proj_files: ignore config.h Do not consider config.h inside the source tree as modified source file. This file gets generated when running ./configure to build in-tree, whereas osmo-dev always builds out-of-tree. Having config.h inside proj_files causes problems with the next patch, where conflicting in-tree builds will be automatically be cleaned with "make distclean". For example: * "make libosmocore" runs with a previously configured in-tree build * proj_files contains config.h. * Before attempting to build libosmocore out-of-tree, with the next patch, "make distclean" gets executed. * config.h is now removed * .make.libosmocore.build target expects all proj_files to exist and fails with: make: *** No rule to make target '../src/libosmocore/config.h', needed by '.make.libosmocore.build'. Stop. Change-Id: I10d970f2cadacb5071dcde975c76b15404038a3c --- M gen_makefile.py 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/gen_makefile.py b/gen_makefile.py index 90a7476..c36b5ff 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -176,11 +176,14 @@ -and -not -name "Makefile.in" \ -and -not -name "config.h.in" ) {proj}_files := $(shell find {src_proj} \ - -name "*.[hc]" \ - -or -name "*.py" \ - -or -name "*.cpp" \ - -or -name "*.tpl" \ - -or -name "*.map") + \( \ + -name "*.[hc]" \ + -or -name "*.py" \ + -or -name "*.cpp" \ + -or -name "*.tpl" \ + -or -name "*.map" \ + \) \ + -and -not -name "config.h") .make.{proj}.clone: @echo -e "\n\n\n===== $@\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I10d970f2cadacb5071dcde975c76b15404038a3c Gerrit-Change-Number: 25737 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:33:37 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:33:37 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: add --auto-distclean In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25738 ) Change subject: gen_makefile.py: add --auto-distclean ...................................................................... gen_makefile.py: add --auto-distclean Add a new option that avoids stopping the build with: configure: error: source directory already configured; run "make distclean" there first I run into this frequently, when e.g. running './configure; make release' inside Osmocom repositories and then attempting to build them with osmo-dev. It is annoying as it does not fail immediatelly, and I need to manually go to the source directories where it failed, run 'make distclean' and then attempt to build again. Then it may fail on another directory with the same problem. Check for config.status, as that is also what ./configure checks for before printing the error. Change-Id: Iac71333e8c5da8dee4e8f34e2af8db12d2c08021 --- M gen_makefile.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/gen_makefile.py b/gen_makefile.py index c36b5ff..7c780a5 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -110,6 +110,9 @@ parser.add_argument('-g', '--build-debug', dest='build_debug', default=False, action='store_true', help='''set 'CFLAGS=-g' when calling src/configure''') +parser.add_argument('-a', '--auto-distclean', action='store_true', + help='''run "make distclean" automatically if source directory already configured''') + args = parser.parse_args() class listdict(dict): @@ -193,6 +196,7 @@ touch $@ .make.{proj}.autoconf: .make.{proj}.clone {src_proj}/configure.ac + if {distclean_cond}; then $(MAKE) {proj}-distclean; fi @echo -e "\n\n\n===== $@\n" -rm -f {src_proj}/.version cd {src_proj}; autoreconf -fi @@ -200,6 +204,7 @@ touch $@ .make.{proj}.configure: .make.{proj}.autoconf {deps_installed} $({proj}_configure_files) + if {distclean_cond}; then $(MAKE) {proj}-distclean .make.{proj}.autoconf; fi @echo -e "\n\n\n===== $@\n" -chmod -R ug+w {build_proj} -rm -rf {build_proj} @@ -209,6 +214,7 @@ touch $@ .make.{proj}.build: .make.{proj}.configure $({proj}_files) + if {distclean_cond}; then $(MAKE) {proj}-distclean .make.{proj}.configure; fi @echo -e "\n\n\n===== $@\n" {docker_cmd}$(MAKE) -C {build_proj} -j {jobs} {check} sync @@ -234,6 +240,12 @@ -chmod -R ug+w {build_proj} -rm -rf {build_proj} -rm -rf .make.{proj}.* + +.PHONY: {proj}-distclean +{proj}-distclean: {proj}-clean + @echo -e "\n\n\n===== $@\n" + $(MAKE) -C {src_proj} distclean + '''.format( url=url, push_url=push_url or url, @@ -252,6 +264,7 @@ check='check' if make_check else '', docker_cmd=f'{args.docker_cmd} ' if args.docker_cmd else '', cflags='CFLAGS=-g ' if args.build_debug else '', + distclean_cond=f'[ -e {make_to_src_proj}/config.status ]' if args.auto_distclean else 'false' ) @@ -328,7 +341,7 @@ -o {makefile} \ -s {src_dir} \ -b {build_dir} \ - -u "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug} + -u "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} '''.format( script=os.path.relpath(sys.argv[0], make_dir), @@ -345,6 +358,7 @@ make_check='' if args.make_check else " \\\n\t\t--no-make-check", docker_cmd=f' \\\n\t\t--docker-cmd "{args.docker_cmd}"' if args.docker_cmd else '', build_debug=f' \\\n\t\t--build-debug' if args.build_debug else '', + auto_distclean=' \\\n\t\t--auto-distclean' if args.auto_distclean else '', )) # convenience target: clone all repositories first -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iac71333e8c5da8dee4e8f34e2af8db12d2c08021 Gerrit-Change-Number: 25738 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:33:37 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:33:37 +0000 Subject: Change in osmo-dev[master]: ttcn3.sh: use --auto-distclean In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/25739 ) Change subject: ttcn3.sh: use --auto-distclean ...................................................................... ttcn3.sh: use --auto-distclean Change-Id: I7d61405dc989eed4935bc6de00e36c1f3b18a428 --- M ttcn3/ttcn3.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved diff --git a/ttcn3/ttcn3.sh b/ttcn3/ttcn3.sh index 2cb4b3a..ab82fc7 100755 --- a/ttcn3/ttcn3.sh +++ b/ttcn3/ttcn3.sh @@ -110,7 +110,8 @@ --docker-cmd "$docker_cmd" \ --make-dir "$DIR_MAKE" \ --no-ldconfig \ - --no-make-check + --no-make-check \ + --auto-distclean } # $1: name of repository (e.g. osmo-ttcn3-hacks) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7d61405dc989eed4935bc6de00e36c1f3b18a428 Gerrit-Change-Number: 25739 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:48:06 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:48:06 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26230 ) Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... add osmo_time_cc, moved from osmo-bsc Related: SYS#4878 Related: Ica9f908a1a30f334a24c59471affa11225117e12 (osmo-bsc) Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd --- M include/Makefile.am A include/osmocom/core/time_cc.h M src/Makefile.am A src/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 8 files changed, 1,523 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/26230/1 diff --git a/include/Makefile.am b/include/Makefile.am index 49402d0..e3246cf 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -60,6 +60,7 @@ osmocom/core/utils.h \ osmocom/core/write_queue.h \ osmocom/core/sockaddr_str.h \ + osmocom/core/time_cc.h \ osmocom/core/use_count.h \ osmocom/crypt/auth.h \ osmocom/crypt/gprs_cipher.h \ diff --git a/include/osmocom/core/time_cc.h b/include/osmocom/core/time_cc.h new file mode 100644 index 0000000..36fdee4 --- /dev/null +++ b/include/osmocom/core/time_cc.h @@ -0,0 +1,187 @@ +/*! \file time_cc.h + * Report the cumulative counter of time for which a flag is true as rate counter. + */ +/* Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH + * + * All Rights Reserved + * + * Author: Neels Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +#include + +/*! \defgroup time_cc Cumulative counter of time as rate counter. + * @{ + * \file time_cc.h + */ + +struct osmo_tdef; +struct rate_ctr; + +/*! Configuration for osmo_time_cc. + * Report the cumulative counter of time for which a flag is true as rate counter. + * For example, for each second that the flag is true, increment a rate counter. + * + * The flag to be monitored is reported by osmo_time_cc_set_flag(). + * + * The granularity defines how much time one rate counter increment represents: + * the default configuration is gran_usec = 1000000, i.e. one rate counter increment represents one second. + * + * Reporting as rate counter is configurable by round_threshold_usec and forget_sum_usec, examples: + * + * round_threshold_usec: + * - To get "ceil()" behavior, set round_threshold_usec = 1. This increments the rate counter for each gran_usec period + * where the flag was seen true, even if it was true for only a very short fraction of a gran_usec period. + * - To get "round()" behavior, set round_threshold_usec = half of gran_usec. The rate counter increments when the flag + * has been true for 0.5 of a gran_usec (and then again at 1.5 * gran_usec) of 'true' flag. round_threshold_usec = 0 + * is a special value that means to use half of gran_usec. + * - To get "floor()" behavior, set round_threshold_usec >= gran_usec. The rate counter increments when reaching full + * gran_usec periods of the flag being true. + * + * forget_sum_usec: + * This is a tradeoff between the accuracy of the reported rate counter and making sure that the events reported are not + * irrelevantly long ago. + * - To keep sub-granularity-period surplus time forever, set forget_sum_usec = 0. + * - To keep surplus time for up to a minute, set forget_sum_usec = 60000000 (60 seconds). + * - To get rid of "leftover" time (almost) immediately after the flag goes false, set forget_sum_usec = 1. + * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a + * possible inaccuracy of 1/60th, but makes sure that no timings older than a minute affect the current reports. + * + * Reporting modes in detail: + * + * The rate_ctr increments when the cumulative counter passes round_threshold_usec (default: half of gran_usec). + * + * sum ^ + * | ________ + * | / + * | / + * | / + * 3*gran --+--------------------------------------+ + * | /: + * | / : + * | - - - - - - - - - - - - - - - - - / : + * | /. : + * | / . : + * 2*gran --+--------------------------------+ . : + * | /: . : + * | / : . : + * | - - - - - - - - - -_________/ : . : + * | / . : . : + * | / . : . : + * 1*gran --+-----------------+ . : . : + * | /: . : . : + * | / : . : . : + * | - - - - - - -/ : . : . : + * | /. : . : . : + * | ....-------' . : . : . : + * 0 +------------------------------------------------------------------------> elapsed time + * . : . : . : + * _ _ _______ ____________ + * flag: __| |_| |____| . : |_______|. : . : |__________ + * f t f t f t . : f t. : . : f + * round_threshold_usec : . : . : . : + * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" + * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" + * >= gran_usec: 0 1 2 3 = "floor()" + * + */ +struct osmo_time_cc_cfg { + /*! Granularity in microseconds: nr of microseconds that one rate_ctr increment represents. A typical value is + * gran_usec = 1000000, meaning one rate counter increment represents one second. When zero, use 1000000. */ + uint64_t gran_usec; + /*! Nr of microseconds above n * gran_usec at which to trigger a counter increment. When zero, use half a + * gran_usec. */ + uint64_t round_threshold_usec; + /*! Forget counted sub-gran time after the flag was false for this long. */ + uint64_t forget_sum_usec; + /*! Rate counter to report to, or NULL to not use it. */ + struct rate_ctr *rate_ctr; + + /*! Update gran_usec from this T timer value, or zero to not use any T timer. */ + int T_gran; + /*! Update round_threshold_usec from this T timer value, or zero to not use any T timer. */ + int T_round_threshold; + /*! Update forget_sum_usec from this T timer value, or zero to not use any T timer. */ + int T_forget_sum; + /*! Look up T_gran and T_forget_sum in this list of timers, or NULL to not use any T timers. */ + struct osmo_tdef *T_defs; +}; + +/*! Report the cumulative counter of time for which a flag is true as rate counter. + * See also osmo_time_cc_cfg for details on configuring. + * + * Usage: + * + * struct my_obj { + * struct osmo_time_cc flag_cc; + * }; + * + * void my_obj_init(struct my_obj *my_obj) + * { + * osmo_time_cc_init(&my_obj->flag_cc); + * my_obj->flag_cc.cfg = (struct osmo_time_cc_cfg){ + * .gran_usec = 1000000, + * .forget_sum_usec = 60000000, + * .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, MY_CTR_IDX), + * }; + * // optional: set initial flag state, default is 'false': + * // osmo_time_cc_set_flag(&my_obj->flag_cc, false); + * } + * + * void my_obj_event(struct my_obj *my_obj, bool flag) + * { + * osmo_time_cc_set_flag(&my_obj->flag_cc, flag); + * } + * + * void my_obj_destruct(struct my_obj *my_obj) + * { + * osmo_time_cc_cleanup(&my_obj->flag_cc); + * } + */ +struct osmo_time_cc { + struct osmo_time_cc_cfg cfg; + + bool flag_state; + + /*! Overall cumulative sum. Does not get reset for the entire lifetime of an osmo_time_cc. + * (Informational only, not used by the osmo_time_cc implementation.) */ + uint64_t total_sum; + + struct osmo_timer_list timer; + + /*! CLOCK_MONOTONIC reading in microseconds, at the time when the osmo_time_cc instance started counting. */ + uint64_t start_time; + /*! CLOCK_MONOTONIC reading in microseconds, at the time when the osmo_time_cc last evaluated the flag state and + * possibly added to the cumulated sum. */ + uint64_t last_counted_time; + + /*! Internal cumulative counter of time that flag_state was true. It may get reset to zero regularly, depending + * on cfg.forget_sum_usec. This is the basis for incrementing cfg.rate_ctr. */ + uint64_t sum; + /*! The amount of time that already reported cfg.rate_ctr increments account for. This may be ahead of or behind + * 'sum', depending on cfg.round_threshold_usec. */ + uint64_t reported_sum; +}; + +void osmo_time_cc_init(struct osmo_time_cc *tc); +void osmo_time_cc_set_flag(struct osmo_time_cc *tc, bool flag); +void osmo_time_cc_cleanup(struct osmo_time_cc *tc); + +/*! @} */ diff --git a/src/Makefile.am b/src/Makefile.am index 328d2c7..6875aa5 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -26,6 +26,7 @@ isdnhdlc.c \ tdef.c \ thread.c \ + time_cc.c \ sockaddr_str.c \ use_count.c \ exec.c \ diff --git a/src/time_cc.c b/src/time_cc.c new file mode 100644 index 0000000..72e3892 --- /dev/null +++ b/src/time_cc.c @@ -0,0 +1,225 @@ +/*! \file foo.c + * Report the cumulative counter of time for which a flag is true as rate counter. + */ +/* Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH + * + * All Rights Reserved + * + * Author: Neels Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +/*! \addtogroup time_cc + * + * Report the cumulative counter of time for which a flag is true as rate counter. + * + * Useful for reporting cumulative time counters as defined in 3GPP TS 52.402, for example allAvailableSDCCHAllocated, + * allAvailableTCHAllocated, availablePDCHAllocatedTime. + * + * For a usage example, see the description of struct osmo_time_cc. + * + * @{ + * \file time_cc.c + */ + +#include + +#include +#include +#include + +#define GRAN_USEC(TIME_CC) ((TIME_CC)->cfg.gran_usec ? : 1000000) +#define ROUND_THRESHOLD_USEC(TIME_CC) ((TIME_CC)->cfg.round_threshold_usec ? \ + OSMO_MIN((TIME_CC)->cfg.round_threshold_usec, GRAN_USEC(TIME_CC)) \ + : (GRAN_USEC(TIME_CC) / 2)) + +static uint64_t time_now_usec() +{ + struct timespec tp; + if (osmo_clock_gettime(CLOCK_MONOTONIC, &tp)) + return 0; + return (uint64_t)tp.tv_sec * 1000000 + tp.tv_nsec / 1000; +} + +static void osmo_time_cc_forget_sum(struct osmo_time_cc *tc, uint64_t now); + +static void osmo_time_cc_update_from_tdef(struct osmo_time_cc *tc, uint64_t now) +{ + bool do_forget_sum = false; + if (!tc->cfg.T_defs) + return; + if (tc->cfg.T_gran) { + uint64_t was = GRAN_USEC(tc); + tc->cfg.gran_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_gran, OSMO_TDEF_US, -1); + if (was != GRAN_USEC(tc)) + do_forget_sum = true; + } + if (tc->cfg.T_round_threshold) + tc->cfg.round_threshold_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_round_threshold, + OSMO_TDEF_US, -1); + if (tc->cfg.T_forget_sum) { + uint64_t was = tc->cfg.forget_sum_usec; + tc->cfg.forget_sum_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_forget_sum, OSMO_TDEF_US, -1); + if (tc->cfg.forget_sum_usec && was != tc->cfg.forget_sum_usec) + do_forget_sum = true; + } + + if (do_forget_sum && tc->sum) + osmo_time_cc_forget_sum(tc, now); +} + +static void osmo_time_cc_schedule_timer(struct osmo_time_cc *tc, uint64_t now); + +/*! Clear out osmo_timer and internal counting state of struct osmo_time_cc. The .cfg remains unaffected. After calling, + * the osmo_time_cc instance can be used again to accumulate state as if it had just been initialized. */ +void osmo_time_cc_cleanup(struct osmo_time_cc *tc) +{ + osmo_timer_del(&tc->timer); + *tc = (struct osmo_time_cc){ + .cfg = tc->cfg, + }; +} + +static void osmo_time_cc_start(struct osmo_time_cc *tc, uint64_t now) +{ + osmo_time_cc_cleanup(tc); + tc->start_time = now; + tc->last_counted_time = now; + osmo_time_cc_update_from_tdef(tc, now); + osmo_time_cc_schedule_timer(tc, now); +} + +static void osmo_time_cc_count_time(struct osmo_time_cc *tc, uint64_t now) +{ + uint64_t time_delta; + tc->last_counted_time = now; + if (!tc->flag_state) + return; + /* Flag is currently true, cumulate the elapsed time */ + time_delta = now - tc->last_counted_time; + tc->total_sum += time_delta; + tc->sum += time_delta; +} + +static void osmo_time_cc_report(struct osmo_time_cc *tc, uint64_t now) +{ + uint64_t delta; + uint64_t n; + if (!tc->cfg.rate_ctr) + return; + /* We report a sum "rounded up", ahead of time. If the granularity period has not yet elapsed after the last + * reporting, do not report again yet. */ + if (tc->reported_sum > tc->sum) + return; + delta = tc->sum - tc->reported_sum; + /* elapsed full periods */ + n = delta / GRAN_USEC(tc); + /* If the delta has passed round_threshold (normally half of gran_usec), increment. */ + delta -= n * GRAN_USEC(tc); + if (delta >= ROUND_THRESHOLD_USEC(tc)) + n++; + if (!n) + return; + + /* integer sanity, since rate_ctr_add() takes an int argument. */ + if (n > INT_MAX) + n = INT_MAX; + rate_ctr_add(tc->cfg.rate_ctr, n); + /* Store the increments of gran_usec that were counted. */ + tc->reported_sum += n * GRAN_USEC(tc); +} + +static void osmo_time_cc_forget_sum(struct osmo_time_cc *tc, uint64_t now) +{ + tc->reported_sum = 0; + tc->sum = 0; + + if (tc->last_counted_time < now) + tc->last_counted_time = now; +} + +/*! Initialize struct osmo_time_cc. Call this once before use, and before setting up the .cfg items. */ +void osmo_time_cc_init(struct osmo_time_cc *tc) +{ + *tc = (struct osmo_time_cc){0}; +} + +/*! Report state to be recorded by osmo_time_cc instance. Setting an unchanged state repeatedly has no effect. */ +void osmo_time_cc_set_flag(struct osmo_time_cc *tc, bool flag) +{ + uint64_t now = time_now_usec(); + if (!tc->start_time) + osmo_time_cc_start(tc, now); + /* No flag change == no effect */ + if (flag == tc->flag_state) + return; + /* Sum up elapsed time, report increments for that. */ + osmo_time_cc_count_time(tc, now); + osmo_time_cc_report(tc, now); + tc->flag_state = flag; + osmo_time_cc_schedule_timer(tc, now); +} + +static void osmo_time_cc_timer_cb(void *data) +{ + struct osmo_time_cc *tc = data; + uint64_t now = time_now_usec(); + + osmo_time_cc_update_from_tdef(tc, now); + + if (tc->flag_state) { + osmo_time_cc_count_time(tc, now); + osmo_time_cc_report(tc, now); + } else if (tc->cfg.forget_sum_usec && tc->sum + && (now >= tc->last_counted_time + tc->cfg.forget_sum_usec)) { + osmo_time_cc_forget_sum(tc, now); + } + osmo_time_cc_schedule_timer(tc, now); +} + +/*! Figure out the next time we should do anything, if the flag state remains unchanged. */ +static void osmo_time_cc_schedule_timer(struct osmo_time_cc *tc, uint64_t now) +{ + uint64_t next_event = UINT64_MAX; + + osmo_time_cc_update_from_tdef(tc, now); + + /* If it is required, when will the next forget_sum happen? */ + if (tc->cfg.forget_sum_usec && !tc->flag_state && tc->sum > 0) { + uint64_t next_forget_time = tc->last_counted_time + tc->cfg.forget_sum_usec; + next_event = OSMO_MIN(next_event, next_forget_time); + } + /* Next rate_ctr increment? */ + if (tc->flag_state && tc->cfg.rate_ctr) { + uint64_t next_inc = now + (tc->reported_sum - tc->sum) + ROUND_THRESHOLD_USEC(tc); + next_event = OSMO_MIN(next_event, next_inc); + } + + /* No event coming up? */ + if (next_event == UINT64_MAX) + return; + + if (next_event <= now) + next_event = 0; + else + next_event -= now; + + osmo_timer_setup(&tc->timer, osmo_time_cc_timer_cb, tc); + osmo_timer_del(&tc->timer); + osmo_timer_schedule(&tc->timer, next_event / 1000000, next_event % 1000000); +} + +/*! @} */ diff --git a/tests/Makefile.am b/tests/Makefile.am index b72619f..5201056 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -42,6 +42,7 @@ bsslap/bsslap_test \ bssmap_le/bssmap_le_test \ it_q/it_q_test \ + time_cc/time_cc_test \ gsm48/rest_octets_test \ base64/base64_test \ $(NULL) @@ -324,6 +325,9 @@ it_q_it_q_test_SOURCES = it_q/it_q_test.c it_q_it_q_test_LDADD = $(LDADD) +time_cc_time_cc_test_SOURCES = time_cc/time_cc_test.c +time_cc_time_cc_test_LDADD = $(LDADD) + # The `:;' works around a Bash 3.2 bug when the output is not writeable. $(srcdir)/package.m4: $(top_srcdir)/configure.ac :;{ \ @@ -413,6 +417,7 @@ bsslap/bsslap_test.ok \ bssmap_le/bssmap_le_test.ok \ it_q/it_q_test.ok \ + time_cc/time_cc.ok \ gsm48/rest_octets_test.ok \ base64/base64_test.ok \ $(NULL) @@ -609,6 +614,8 @@ >$(srcdir)/bssmap_le/bssmap_le_test.ok it_q/it_q_test \ >$(srcdir)/it_q/it_q_test.ok + time_cc/time_cc_test \ + >$(srcdir)/time_cc/time_cc_test.ok check-local: atconfig $(TESTSUITE) [ -e /proc/cpuinfo ] && cat /proc/cpuinfo diff --git a/tests/testsuite.at b/tests/testsuite.at index 6ac5970..975b51e 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -452,3 +452,9 @@ cat $abs_srcdir/base64/base64_test.ok > expout AT_CHECK([$abs_top_builddir/tests/base64/base64_test], [0], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([time_cc]) +AT_KEYWORDS([time_cc]) +cat $abs_srcdir/time_cc/time_cc_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/time_cc/time_cc_test], [0], [expout], [ignore]) +AT_CLEANUP diff --git a/tests/time_cc/time_cc_test.c b/tests/time_cc/time_cc_test.c new file mode 100644 index 0000000..22ea7f6 --- /dev/null +++ b/tests/time_cc/time_cc_test.c @@ -0,0 +1,768 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Neels Janosch Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include + +#include +#include +#include +#include +#include +#include +#include + +enum my_ctrs { + CTR_CEIL, + CTR_ROUND, + CTR_FLOOR, +}; + +const struct rate_ctr_desc my_ctr_desc[] = { + [CTR_CEIL] = {"ceil", "testing round_threshold_usec = 1"}, + [CTR_ROUND] = {"round", "testing round_threshold_usec = 0 = gran_usec/2"}, + [CTR_FLOOR] = {"floor", "testing round_threshold_usec = gran_usec"}, +}; + +const struct rate_ctr_group_desc my_ctrg_desc = { + "time_cc_test", + "Counters for osmo_time_cc test", + 0, + ARRAY_SIZE(my_ctr_desc), + my_ctr_desc, +}; + +struct rate_ctr_group *my_ctrg; + + +enum my_obj_timers { + T_GRAN = -23, + T_ROUND_THRESH = -24, + T_FORGET_SUM = -25, +}; + +struct osmo_tdef g_my_obj_tdefs[] = { + { .T = T_GRAN, .default_val = 0, .unit = OSMO_TDEF_MS, .desc = "flag_cc granularity, or zero for 1 second" }, + { .T = T_ROUND_THRESH, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "flag_cc rounding threshold, or zero for half a granularity" }, + { .T = T_FORGET_SUM, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "flag_cc inactivity forget period, or zero to not forget any timings" }, + {} +}; + + +struct my_obj { + struct osmo_time_cc flag_cc_ceil; + struct osmo_time_cc flag_cc_round; + struct osmo_time_cc flag_cc_floor; +}; + +void my_obj_init(struct my_obj *my_obj) +{ + osmo_time_cc_init(&my_obj->flag_cc_ceil); + my_obj->flag_cc_ceil.cfg = (struct osmo_time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_CEIL), + .round_threshold_usec = 1, + .T_gran = T_GRAN, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; + + osmo_time_cc_init(&my_obj->flag_cc_round); + my_obj->flag_cc_round.cfg = (struct osmo_time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_ROUND), + .T_gran = T_GRAN, + .T_round_threshold = T_ROUND_THRESH, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; + + osmo_time_cc_init(&my_obj->flag_cc_floor); + my_obj->flag_cc_floor.cfg = (struct osmo_time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_FLOOR), + .round_threshold_usec = UINT64_MAX, /* always >= gran_usec */ + .T_gran = T_GRAN, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; +} + +void my_obj_event(struct my_obj *my_obj, bool flag) +{ + osmo_time_cc_set_flag(&my_obj->flag_cc_ceil, flag); + osmo_time_cc_set_flag(&my_obj->flag_cc_round, flag); + osmo_time_cc_set_flag(&my_obj->flag_cc_floor, flag); +} + +void my_obj_destruct(struct my_obj *my_obj) +{ + osmo_time_cc_cleanup(&my_obj->flag_cc_ceil); + osmo_time_cc_cleanup(&my_obj->flag_cc_round); + osmo_time_cc_cleanup(&my_obj->flag_cc_floor); +} + +static const struct log_info_cat log_categories[] = { +}; + +static const struct log_info log_info = { + .cat = log_categories, + .num_cat = ARRAY_SIZE(log_categories), +}; + +int main() +{ + void *ctx = talloc_named_const(NULL, 0, "time_cc_test"); + struct timespec *now; + struct my_obj my_obj = {0}; + + osmo_init_logging2(ctx, &log_info); + + /* enable override for CLOCK_MONOTONIC */ + osmo_clock_override_enable(CLOCK_MONOTONIC, true); + now = osmo_clock_override_gettimespec(CLOCK_MONOTONIC); + now->tv_sec = 23000; + now->tv_nsec = 0; + + /* enable override for osmo_gettimeofday(), for osmo_timer_schedule() */ + osmo_gettimeofday_override = true; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_ctrg = rate_ctr_group_alloc(ctx, &my_ctrg_desc, 0); + +#define CHECK_RATE_CTRS(exp_ceil, exp_round, exp_floor) do { \ + printf("%d CHECK_RATE_CTRS(" #exp_ceil ", " #exp_round ", " #exp_floor ")", \ + my_obj.flag_cc_round.flag_state); \ + while (osmo_select_main_ctx(1) > 0); \ + if (exp_ceil != my_obj.flag_cc_ceil.cfg.rate_ctr->current \ + || exp_round != my_obj.flag_cc_round.cfg.rate_ctr->current \ + || exp_floor != my_obj.flag_cc_floor.cfg.rate_ctr->current) \ + printf("\n ERROR on line %d: ctr_ceil=%"PRIu64" ctr_round=%"PRIu64" ctr_floor=%"PRIu64"\n", \ + __LINE__, \ + my_obj.flag_cc_ceil.cfg.rate_ctr->current, \ + my_obj.flag_cc_round.cfg.rate_ctr->current, \ + my_obj.flag_cc_floor.cfg.rate_ctr->current); \ + else \ + printf(" ok\n"); \ + } while (0) + +#define ADD_MILLISECS_NO_SELECT(ms) do { \ + osmo_clock_override_add(CLOCK_MONOTONIC, ms / 1000, (uint64_t)(ms % 1000) * 1000000); \ + osmo_gettimeofday_override_add(ms / 1000, (uint64_t)(ms % 1000) * 1000); \ + printf("%d ADD_MILLISECS(" #ms ") --> %ld.%03ld", my_obj.flag_cc_round.flag_state, \ + now->tv_sec, now->tv_nsec/1000000); \ + printf("\n"); \ + } while (0) + +#define ADD_MILLISECS(ms) do { \ + ADD_MILLISECS_NO_SELECT(ms); \ + while (osmo_select_main_ctx(1) > 0); \ + } while (0) + +#define FLAG(VAL) do { \ + printf(" flag: %s -> %s\n", my_obj.flag_cc_round.flag_state ? "TRUE" : "FALSE", VAL ? "TRUE" : "FALSE"); \ + my_obj_event(&my_obj, VAL); \ + } while (0) + + /* + * sum ^ + * | ________ + * | / + * | / + * | / + * 3*gran --+--------------------------------------+ + * | /: + * | / : + * | - - - - - - - - - - - - - - - - - / : + * | /. : + * | / . : + * 2*gran --+--------------------------------+ . : + * | /: . : + * | / : . : + * | - - - - - - - - - -_________/ : . : + * | / . : . : + * | / . : . : + * 1*gran --+-----------------+ . : . : + * | /: . : . : + * | / : . : . : + * | - - - - - - -/ : . : . : + * | /. : . : . : + * | ....-------' . : . : . : + * 0 +----------------------------------------------------------> elapsed time + * . : . : . : + * _ _ _______ ____________ + * flag: __| |_| |____| . : |_______|. : . : |__________ + * f t f t f t . : f t. : . : f + * round_threshold_usec : . : . : . : + * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" + * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" + * = gran_usec: 0 1 2 3 = "floor()" + */ + + printf("\n----------- cumulating time, without forget_sum\n\n"); + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.001s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(99); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(100); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(100); + /* flag has been true for 0.2s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(300); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(299); + /* flag has been true for 0.499s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.5s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(499); + /* flag has been true for 0.999s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(1); + /* flag has been true for 1.0s */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* flag has been true for 1.001s */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(299); + /* flag has been true for 1.3s */ + CHECK_RATE_CTRS(2, 1, 1); + FLAG(false); + CHECK_RATE_CTRS(2, 1, 1); + + ADD_MILLISECS(400); + + CHECK_RATE_CTRS(2, 1, 1); + FLAG(true); + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(199); + /* flag has been true for 1.499s */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(2); + /* flag has been true for 1.501s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(498); + /* flag has been true for 1.999s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(2); + /* flag has been true for 2.001s */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(500); + /* flag has been true for 2.501s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(498); + /* flag has been true for 2.999s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(3); + /* flag has been true for 3.003s */ + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(200); + /* flag has been true for 3.203s */ + CHECK_RATE_CTRS(4, 3, 3); + FLAG(false); + CHECK_RATE_CTRS(4, 3, 3); + + ADD_MILLISECS(4321); + CHECK_RATE_CTRS(4, 3, 3); + + FLAG(true); + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(5678); + CHECK_RATE_CTRS(9, 9, 8); + FLAG(false); + CHECK_RATE_CTRS(9, 9, 8); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + printf("\n----------- test forget_sum_usec\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); + + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(1000); + /* 1 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(8999); + /* 9.999 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(1); + /* 10 s of being false, forget_sum_usec has occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* Since previous sums were forgotton, ceil() triggers again */ + CHECK_RATE_CTRS(2, 0, 0); + /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify + * that this does not occur, since now full 500 ms are required */ + ADD_MILLISECS(399); + CHECK_RATE_CTRS(2, 0, 0); + /* Adding another 100 ms will trigger round() */ + ADD_MILLISECS(99); + CHECK_RATE_CTRS(2, 0, 0); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(2, 1, 0); + /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify + * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ + ADD_MILLISECS(400); + CHECK_RATE_CTRS(2, 1, 0); + /* Adding another 100 ms will trigger floor() */ + ADD_MILLISECS(99); + CHECK_RATE_CTRS(2, 1, 0); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(2, 1, 1); + + /* Test that durations of false below forget_sum_usec never trigger a forget */ + ADD_MILLISECS(300); + CHECK_RATE_CTRS(3, 1, 1); + /* internal counter is now at 0.3s above the last reported rate counter */ + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + /* internal counter is now at 0.4s above the last reported rate counter */ + CHECK_RATE_CTRS(3, 1, 1); + ADD_MILLISECS(100); + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS(500); + CHECK_RATE_CTRS(3, 2, 2); + + /* Test that repeated osmo_time_cc_set_flag(false) does not cancel a forget_sum_usec */ + ADD_MILLISECS(300); + /* internal counter is now at 0.3s above the last reported rate counter */ + CHECK_RATE_CTRS(4, 2, 2); + FLAG(false); + ADD_MILLISECS(5000); + /* Repeat 'false', must not affect forget_sum_usec */ + FLAG(false); + ADD_MILLISECS(5000); + CHECK_RATE_CTRS(4, 2, 2); + /* 10 s have passed, forget_sum_usec has occurred. + * Hence ceil() will trigger again right away: */ + FLAG(true); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 2, 2); + /* Adding 200 ms to the initial 300 ms would have triggered round(), but no more after forget_sum_usec */ + ADD_MILLISECS(199); + CHECK_RATE_CTRS(5, 2, 2); + /* Adding another 300 ms will trigger round() */ + ADD_MILLISECS(299); + CHECK_RATE_CTRS(5, 2, 2); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 3, 2); + /* Adding 700 ms to the initial 300 ms would have triggered ceil(), but no more after forget_sum_usec */ + ADD_MILLISECS(200); + CHECK_RATE_CTRS(5, 3, 2); + /* Adding another 300 ms will trigger ceil() */ + ADD_MILLISECS(299); + CHECK_RATE_CTRS(5, 3, 2); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 3, 3); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + + /* Verify correctness when select() lags and runs timer callbacks too late */ + printf("\n----------- cumulating time, without forget_sum, when timer cb are invoked late\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 0, OSMO_TDEF_S); + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS_NO_SELECT(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(100); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.2s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(300); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(799); + /* flag has been true for 0.999s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 1.0s */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS_NO_SELECT(300); + /* flag has been true for 1.3s */ + CHECK_RATE_CTRS(2, 1, 1); + FLAG(false); + CHECK_RATE_CTRS(2, 1, 1); + + ADD_MILLISECS_NO_SELECT(400); + + CHECK_RATE_CTRS(2, 1, 1); + FLAG(true); + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS_NO_SELECT(699); + /* flag has been true for 1.999s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 2.0s */ + CHECK_RATE_CTRS(2, 2, 2); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 2.001s */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS_NO_SELECT(499); + /* flag has been true for 2.5s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS_NO_SELECT(499); + /* flag has been true for 2.999s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 3.0s */ + CHECK_RATE_CTRS(3, 3, 3); + ADD_MILLISECS_NO_SELECT(200); + /* flag has been true for 3.2s */ + CHECK_RATE_CTRS(4, 3, 3); + FLAG(false); + CHECK_RATE_CTRS(4, 3, 3); + + ADD_MILLISECS_NO_SELECT(4321); + CHECK_RATE_CTRS(4, 3, 3); + + FLAG(true); + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS_NO_SELECT(5678); + CHECK_RATE_CTRS(9, 9, 8); + FLAG(false); + CHECK_RATE_CTRS(9, 9, 8); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + + printf("\n----------- test forget_sum, when timer cb are invoked late\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); + + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(1000); + /* 1 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(8999); + /* 9.999 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(1); + /* 10 s of being false, forget_sum_usec has occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(1); + /* Since previous sums were forgotton, ceil() triggers again */ + CHECK_RATE_CTRS(2, 0, 0); + /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify + * that this does not occur, since now full 500 ms are required */ + ADD_MILLISECS_NO_SELECT(399); + CHECK_RATE_CTRS(2, 0, 0); + /* Adding another 100 ms will trigger round() */ + ADD_MILLISECS_NO_SELECT(99); + CHECK_RATE_CTRS(2, 0, 0); + ADD_MILLISECS_NO_SELECT(1); + CHECK_RATE_CTRS(2, 1, 0); + /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify + * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ + ADD_MILLISECS_NO_SELECT(400); + CHECK_RATE_CTRS(2, 1, 0); + /* Adding another 100 ms will trigger floor() */ + ADD_MILLISECS_NO_SELECT(99); + CHECK_RATE_CTRS(2, 1, 0); + ADD_MILLISECS_NO_SELECT(1); + CHECK_RATE_CTRS(2, 1, 1); + + /* Test that durations of false below forget_sum_usec never trigger a forget */ + ADD_MILLISECS_NO_SELECT(300); + CHECK_RATE_CTRS(3, 1, 1); + /* internal counter is now at 0.3s above the last reported rate counter */ + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + /* internal counter is now at 0.4s above the last reported rate counter */ + CHECK_RATE_CTRS(3, 1, 1); + ADD_MILLISECS_NO_SELECT(100); + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS_NO_SELECT(500); + CHECK_RATE_CTRS(3, 2, 2); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + +#define SET_TDEFS(gran, round_thresh, forget_sum) do { \ + osmo_tdef_set(g_my_obj_tdefs, T_GRAN, gran, OSMO_TDEF_MS); \ + osmo_tdef_set(g_my_obj_tdefs, T_ROUND_THRESH, round_thresh, OSMO_TDEF_MS); \ + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, forget_sum, OSMO_TDEF_S); \ + printf("T_defs: T_gran=%luusec T_round_threshold=%luusec T_forget_sum=%luusec\n", \ + osmo_tdef_get(g_my_obj_tdefs, T_GRAN, OSMO_TDEF_US, -1), \ + osmo_tdef_get(g_my_obj_tdefs, T_ROUND_THRESH, OSMO_TDEF_US, -1), \ + osmo_tdef_get(g_my_obj_tdefs, T_FORGET_SUM, OSMO_TDEF_US, -1)); \ + } while (0) + + printf("\n----------- test T_defs\n\n"); + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + SET_TDEFS(100, 10, 0); + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(9); + /* flag has been true for 0.009s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.010s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(90); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 1, 1); + + SET_TDEFS(200, 190, 1); + /* gran is changed to 200ms, but still continues until the next scheduled event until the change is picked up. + * For ceil(), it is 1 ms ahead. + * For round(), it is 10 ms ahead. + * For floor(), it is at the next full (previous) gran 100 ms ahead. + * When T_defs change, all internal sums are reset to zero without reporting. + */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* 1ms elapsed: ceil() picks up the T_gran change, starts anew. */ + /* elapsed: ceil 0 ms */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 1 ms */ + /* ceil() increments because flag has been true for more than 1 us after reset */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(8); + /* 10 ms elapsed: round() picks up the T_gran change, starts anew */ + /* elapsed: ceil 9 ms, round 0 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(90); + /* 100 ms elapsed: floor() picks up the T_gran change, starts anew */ + /* elapsed: ceil 99 ms, round 90 ms, floor 0 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(99); + /* elapsed: ceil 198 ms, round 189 ms, floor 99 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 199 ms, round 190 ms, floor 100 ms */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 200 ms, round 191 ms, floor 101 ms */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 201 ms, round 192 ms, floor 102 ms */ + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS(98); + /* elapsed: ceil 299 ms, round 290 ms, floor 200 ms */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(99); + /* elapsed: ceil 398 ms, round 389 ms, floor 299 ms */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 399 ms, round 390 ms, floor 300 ms */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 400 ms, round 391 ms, floor 301 ms */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 401 ms, round 392 ms, floor 302 ms */ + CHECK_RATE_CTRS(4, 3, 2); + ADD_MILLISECS(98); + /* elapsed: ceil 499 ms, round 490 ms, floor 400 ms */ + CHECK_RATE_CTRS(4, 3, 3); + + + SET_TDEFS(100, 0, 0); + /* T_defs change, but they only get picked up upon the next event: + * For ceil(), it is 102 ms ahead. + * For round(), it is 100 ms ahead (thresh is still 190, currently at 90). + * For floor(), it is 200 ms ahead. + * When T_defs change, all internal sums are reset to zero without reporting. + */ + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(100); + CHECK_RATE_CTRS(4, 3, 3); + /* round() picks up the new T_defs. Internal sum resets, nothing else happens yet. + * round() schedules the next event 50 ms ahead. */ + ADD_MILLISECS(2); + CHECK_RATE_CTRS(4, 3, 3); + /* ceil() picks up the change, its next event is 1 ms ahead. */ + ADD_MILLISECS(1); + /* ceil: 0.001 + * round: 0.003 + * floor: still 97 ms until it picks up the change */ + CHECK_RATE_CTRS(5, 3, 3); + ADD_MILLISECS(46); + CHECK_RATE_CTRS(5, 3, 3); + ADD_MILLISECS(1); + /* round() has first counter trigger after T_defs change. */ + CHECK_RATE_CTRS(5, 4, 3); + /* ceil: 0.048 + * round: 0.050 + * floor: still 50 ms until it picks up the change */ + ADD_MILLISECS(50); + /* floor() picks up the change. nothing happens yet. */ + /* ceil: 0.098 + * round: 0.100 + * floor: 0.0 */ + ADD_MILLISECS(2); + /* ceil: 0.100 + * round: 0.102 + * floor: 0.002 */ + CHECK_RATE_CTRS(5, 4, 3); + ADD_MILLISECS(1); + /* ceil: 0.101 + * round: 0.103 + * floor: 0.003 */ + CHECK_RATE_CTRS(6, 4, 3); + ADD_MILLISECS(46); + /* ceil: 0.147 + * round: 0.149 + * floor: 0.049 */ + CHECK_RATE_CTRS(6, 4, 3); + ADD_MILLISECS(1); + /* ceil: 0.148 + * round: 0.150 + * floor: 0.050 */ + CHECK_RATE_CTRS(6, 5, 3); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + return 0; +} diff --git a/tests/time_cc/time_cc_test.ok b/tests/time_cc/time_cc_test.ok new file mode 100644 index 0000000..ccf84d9 --- /dev/null +++ b/tests/time_cc/time_cc_test.ok @@ -0,0 +1,328 @@ + +----------- cumulating time, without forget_sum + +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(1) --> 23000.101 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(99) --> 23000.200 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.300 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.400 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(300) --> 23000.700 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(299) --> 23000.999 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23001.000 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(499) --> 23001.499 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(1) --> 23001.500 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23001.501 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(299) --> 23001.800 +1 CHECK_RATE_CTRS(2, 1, 1) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(2, 1, 1) ok +0 ADD_MILLISECS(400) --> 23002.200 +0 CHECK_RATE_CTRS(2, 1, 1) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(199) --> 23002.399 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(2) --> 23002.401 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(498) --> 23002.899 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(2) --> 23002.901 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(500) --> 23003.401 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(498) --> 23003.899 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(3) --> 23003.902 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(200) --> 23004.102 +1 CHECK_RATE_CTRS(4, 3, 3) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(4, 3, 3) ok +0 ADD_MILLISECS(4321) --> 23008.423 +0 CHECK_RATE_CTRS(4, 3, 3) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(5678) --> 23014.101 +1 CHECK_RATE_CTRS(9, 9, 8) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(9, 9, 8) ok + +----------- test forget_sum_usec + +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.100 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1000) --> 23001.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(8999) --> 23010.099 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1) --> 23010.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.101 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(399) --> 23010.500 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(99) --> 23010.599 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.600 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(400) --> 23011.000 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(99) --> 23011.099 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(1) --> 23011.100 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(300) --> 23011.400 +1 CHECK_RATE_CTRS(3, 1, 1) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23021.399 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23021.424 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23031.423 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23031.448 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23041.447 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23041.472 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23051.471 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23051.496 +1 CHECK_RATE_CTRS(3, 1, 1) ok +1 ADD_MILLISECS(100) --> 23051.596 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(500) --> 23052.096 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(300) --> 23052.396 +1 CHECK_RATE_CTRS(4, 2, 2) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(5000) --> 23057.396 + flag: FALSE -> FALSE +0 ADD_MILLISECS(5000) --> 23062.396 +0 CHECK_RATE_CTRS(4, 2, 2) ok + flag: FALSE -> TRUE +1 ADD_MILLISECS(1) --> 23062.397 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(199) --> 23062.596 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(299) --> 23062.895 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(1) --> 23062.896 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(200) --> 23063.096 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(299) --> 23063.395 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(1) --> 23063.396 +1 CHECK_RATE_CTRS(5, 3, 3) ok + +----------- cumulating time, without forget_sum, when timer cb are invoked late + +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.200 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.300 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.400 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(300) --> 23000.700 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(799) --> 23001.499 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(1) --> 23001.500 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(300) --> 23001.800 +1 CHECK_RATE_CTRS(2, 1, 1) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(2, 1, 1) ok +0 ADD_MILLISECS(400) --> 23002.200 +0 CHECK_RATE_CTRS(2, 1, 1) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(699) --> 23002.899 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23002.900 +1 CHECK_RATE_CTRS(2, 2, 2) ok +1 ADD_MILLISECS(1) --> 23002.901 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(499) --> 23003.400 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(499) --> 23003.899 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23003.900 +1 CHECK_RATE_CTRS(3, 3, 3) ok +1 ADD_MILLISECS(200) --> 23004.100 +1 CHECK_RATE_CTRS(4, 3, 3) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(4, 3, 3) ok +0 ADD_MILLISECS(4321) --> 23008.421 +0 CHECK_RATE_CTRS(4, 3, 3) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(5678) --> 23014.099 +1 CHECK_RATE_CTRS(9, 9, 8) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(9, 9, 8) ok + +----------- test forget_sum, when timer cb are invoked late + +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.100 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1000) --> 23001.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(8999) --> 23010.099 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1) --> 23010.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.101 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(399) --> 23010.500 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(99) --> 23010.599 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.600 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(400) --> 23011.000 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(99) --> 23011.099 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(1) --> 23011.100 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(300) --> 23011.400 +1 CHECK_RATE_CTRS(3, 1, 1) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23021.399 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23021.424 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23031.423 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23031.448 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23041.447 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23041.472 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23051.471 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23051.496 +1 CHECK_RATE_CTRS(3, 1, 1) ok +1 ADD_MILLISECS(100) --> 23051.596 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(500) --> 23052.096 +1 CHECK_RATE_CTRS(3, 2, 2) ok + +----------- test T_defs + +T_defs: T_gran=100000usec T_round_threshold=10000usec T_forget_sum=0usec +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(9) --> 23000.109 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23000.110 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(90) --> 23000.200 +1 CHECK_RATE_CTRS(1, 1, 1) ok +T_defs: T_gran=200000usec T_round_threshold=190000usec T_forget_sum=1000000usec +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.201 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.202 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(8) --> 23000.210 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(90) --> 23000.300 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(99) --> 23000.399 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.400 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23000.401 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23000.402 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(98) --> 23000.500 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(99) --> 23000.599 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(1) --> 23000.600 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23000.601 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23000.602 +1 CHECK_RATE_CTRS(4, 3, 2) ok +1 ADD_MILLISECS(98) --> 23000.700 +1 CHECK_RATE_CTRS(4, 3, 3) ok +T_defs: T_gran=100000usec T_round_threshold=0usec T_forget_sum=0usec +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(100) --> 23000.800 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(2) --> 23000.802 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(1) --> 23000.803 +1 CHECK_RATE_CTRS(5, 3, 3) ok +1 ADD_MILLISECS(46) --> 23000.849 +1 CHECK_RATE_CTRS(5, 3, 3) ok +1 ADD_MILLISECS(1) --> 23000.850 +1 CHECK_RATE_CTRS(5, 4, 3) ok +1 ADD_MILLISECS(50) --> 23000.900 +1 ADD_MILLISECS(2) --> 23000.902 +1 CHECK_RATE_CTRS(5, 4, 3) ok +1 ADD_MILLISECS(1) --> 23000.903 +1 CHECK_RATE_CTRS(6, 4, 3) ok +1 ADD_MILLISECS(46) --> 23000.949 +1 CHECK_RATE_CTRS(6, 4, 3) ok +1 ADD_MILLISECS(1) --> 23000.950 +1 CHECK_RATE_CTRS(6, 5, 3) ok -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:48:33 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:48:33 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26231 ) Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... move time_cc to libosmocore osmo_time_cc Related: SYS#4878 Depends: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd (libosmocore) Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 --- M configure.ac M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h D include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c D src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at D tests/time_cc/Makefile.am D tests/time_cc/time_cc_test.c D tests/time_cc/time_cc_test.ok 15 files changed, 49 insertions(+), 1,557 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/31/26231/1 diff --git a/configure.ac b/configure.ac index 989ad7d..bcf91ba 100644 --- a/configure.ac +++ b/configure.ac @@ -238,7 +238,6 @@ tests/subscr/Makefile tests/nanobts_omlattr/Makefile tests/handover/Makefile - tests/time_cc/Makefile doc/Makefile doc/examples/Makefile doc/manuals/Makefile diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am index 8831533..3ddad45 100644 --- a/include/osmocom/bsc/Makefile.am +++ b/include/osmocom/bsc/Makefile.am @@ -58,7 +58,6 @@ signal.h \ system_information.h \ timeslot_fsm.h \ - time_cc.h \ vty.h \ gsm_08_08.h \ penalty_timers.h \ diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 89512f3..ab04d31 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -620,10 +620,10 @@ /* At what point in the channel allocation sequence to dispatch the Immediate Assignment (Abis optimization) */ enum imm_ass_time imm_ass_time; - struct time_cc all_allocated_sdcch; - struct time_cc all_allocated_static_sdcch; - struct time_cc all_allocated_tch; - struct time_cc all_allocated_static_tch; + struct osmo_time_cc all_allocated_sdcch; + struct osmo_time_cc all_allocated_static_sdcch; + struct osmo_time_cc all_allocated_tch; + struct osmo_time_cc all_allocated_static_tch; }; #define GSM_BTS_SI2Q(bts, i) (struct gsm48_system_information_type_2quater *)((bts)->si_buf[SYSINFO_TYPE_2quater][i]) diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 2823922..238b2f7 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -18,6 +18,7 @@ #include #include #include +#include #include @@ -32,7 +33,6 @@ #include #include #include -#include #define GSM_T3122_DEFAULT 10 @@ -1262,10 +1262,10 @@ struct smlc_config *smlc; - struct time_cc all_allocated_sdcch; - struct time_cc all_allocated_static_sdcch; - struct time_cc all_allocated_tch; - struct time_cc all_allocated_static_tch; + struct osmo_time_cc all_allocated_sdcch; + struct osmo_time_cc all_allocated_static_sdcch; + struct osmo_time_cc all_allocated_tch; + struct osmo_time_cc all_allocated_static_tch; }; struct gsm_audio_support { diff --git a/include/osmocom/bsc/time_cc.h b/include/osmocom/bsc/time_cc.h deleted file mode 100644 index abddbcf..0000000 --- a/include/osmocom/bsc/time_cc.h +++ /dev/null @@ -1,157 +0,0 @@ -/* Report the cumulative counter of time for which a flag is true as rate counter. */ -#pragma once - -#include - -#include - -struct osmo_tdef; -struct rate_ctr; - -/*! Configuration for time_cc. - * Report the cumulative counter of time for which a flag is true as rate counter. - * For example, for each second that the flag is true, increment a rate counter. - * - * The flag to be monitored is reported by time_cc_set_flag(). - * - * The granularity defines how much time one rate counter increment represents: - * the default configuration is gran_usec = 1000000, i.e. one rate counter increment represents one second. - * - * Reporting as rate counter is configurable by round_threshold_usec and forget_sum_usec, examples: - * - * round_threshold_usec: - * - To get "ceil()" behavior, set round_threshold_usec = 1. This increments the rate counter for each gran_usec period - * where the flag was seen true, even if it was true for only a very short fraction of a gran_usec period. - * - To get "round()" behavior, set round_threshold_usec = half of gran_usec. The rate counter increments when the flag - * has been true for 0.5 of a gran_usec (and then again at 1.5 * gran_usec of 'true' flag). round_threshold_usec = 0 - * is a special value that means to use half of gran_usec. - * - To get "floor()" behavior, set round_threshold_usec >= gran_usec. The rate counter increments when reaching full - * gran_usec periods of the flag being true. - * - * forget_sum_usec: - * This is a tradeoff between the accuracy of the reported rate counter and making sure that the events reported are not - * irrelevantly long ago. - * - To keep sub-granularity-period surplus time forever, set forget_sum_usec = 0. - * - To keep surplus time for up to a minute, set forget_sum_usec = 60000000 (60 seconds). - * - To get rid of "leftover" time (almost) immediately after the flag goes false, set forget_sum_usec = 1. - * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a - * possible inaccuracy of 1/60th, but makes sure that no timings older than a minute affect the current reports. - * - * Reporting modes in detail: - * - * The rate_ctr increments when the cumulative counter passes round_threshold_usec (default: half of gran_usec). - * - * sum ^ - * | ________ - * | / - * | / - * | / - * 3*gran --+--------------------------------------+ - * | /: - * | / : - * | - - - - - - - - - - - - - - - - - / : - * | /. : - * | / . : - * 2*gran --+--------------------------------+ . : - * | /: . : - * | / : . : - * | - - - - - - - - - -_________/ : . : - * | / . : . : - * | / . : . : - * 1*gran --+-----------------+ . : . : - * | /: . : . : - * | / : . : . : - * | - - - - - - -/ : . : . : - * | /. : . : . : - * | ....-------' . : . : . : - * 0 +------------------------------------------------------------------------> elapsed time - * . : . : . : - * _ _ _______ ____________ - * flag: __| |_| |____| . : |_______|. : . : |__________ - * f t f t f t . : f t. : . : f - * round_threshold_usec : . : . : . : - * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" - * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" - * >= gran_usec: 0 1 2 3 = "floor()" - * - */ -struct time_cc_cfg { - /*! Granularity in microseconds: nr of microseconds that one rate_ctr increment represents. A typical value is - * gran_usec = 1000000, meaning one rate counter increment represents one second. */ - uint64_t gran_usec; - /*! Nr of microseconds above a full gran_usec at which to trigger rate_ctr_round. When zero, half a gran_usec. */ - uint64_t round_threshold_usec; - /*! Forget counted sub-gran time after the flag was false for this long. */ - uint64_t forget_sum_usec; - /*! Rate counter to report to, or NULL to not use it. */ - struct rate_ctr *rate_ctr; - - /*! Update gran_usec from this T timer value, or zero to not use any T timer. */ - int T_gran; - /*! Update round_threshold_usec from this T timer value, or zero to not use any T timer. */ - int T_round_threshold; - /*! Update forget_sum_usec from this T timer value, or zero to not use any T timer. */ - int T_forget_sum; - /*! Look up T_gran and T_forget_sum in this list of timers, or NULL to not use any T timers. */ - struct osmo_tdef *T_defs; -}; - -/*! Report the cumulative counter of time for which a flag is true as rate counter. - * See also time_cc_cfg for details on configuring. - * - * Usage: - * - * struct my_obj { - * struct time_cc flag_cc; - * }; - * - * void my_obj_init(struct my_obj *my_obj) - * { - * time_cc_init(&my_obj->flag_cc); - * my_obj->flag_cc.cfg = (struct time_cc_cfg){ - * .gran_usec = 1000000, - * .forget_sum_usec = 60000000, - * .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, MY_CTR_IDX), - * }; - * // optional: set initial flag state, default is 'false': - * // time_cc_set_flag(&my_obj->flag_cc, false); - * } - * - * void my_obj_event(struct my_obj *my_obj, bool flag) - * { - * time_cc_set_flag(&my_obj->flag_cc, flag); - * } - * - * void my_obj_destruct(struct my_obj *my_obj) - * { - * time_cc_cleanup(&my_obj->flag_cc); - * } - */ -struct time_cc { - struct time_cc_cfg cfg; - - bool flag_state; - - /** Overall cumulative sum. Does not get reset for the entire lifetime of a time_cc. - * (Informational only, not used by the time_cc implementation.) */ - uint64_t total_sum; - - struct osmo_timer_list timer; - - /** CLOCK_MONOTONIC reading in microseconds, at the time when the time_cc instance started counting. */ - uint64_t start_time; - /** CLOCK_MONOTONIC reading in microseconds, at the time when the time_cc last evaluated the flag state and - * possibly added to the cumulated sum. */ - uint64_t last_counted_time; - - /** Internal cumulative counter of time that flag_state was true. It may get reset to zero regularly, depending - * on cfg.forget_sum_usec. This is the basis for incrementing cfg.rate_ctr. */ - uint64_t sum; - /** The amount of time that already reported cfg.rate_ctr increments account for. This may be ahead of or behind - * 'sum', depending on cfg.round_threshold_usec. */ - uint64_t reported_sum; -}; - -void time_cc_init(struct time_cc *tc); -void time_cc_set_flag(struct time_cc *tc, bool flag); -void time_cc_cleanup(struct time_cc *tc); diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index cebbaeb..583fb79 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -105,7 +105,6 @@ bssmap_reset.c \ system_information.c \ timeslot_fsm.c \ - time_cc.c \ smscb.c \ cbch_scheduler.c \ cbsp_link.c \ diff --git a/src/osmo-bsc/bsc_init.c b/src/osmo-bsc/bsc_init.c index 9328707..0412f6b 100644 --- a/src/osmo-bsc/bsc_init.c +++ b/src/osmo-bsc/bsc_init.c @@ -120,7 +120,7 @@ if (!net->bts_unknown_statg) goto err_free_all; - net->all_allocated_sdcch = (struct time_cc){ + net->all_allocated_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -131,7 +131,7 @@ .T_defs = net->T_defs, }, }; - net->all_allocated_static_sdcch = (struct time_cc){ + net->all_allocated_static_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -142,7 +142,7 @@ .T_defs = net->T_defs, }, }; - net->all_allocated_tch = (struct time_cc){ + net->all_allocated_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -153,7 +153,7 @@ .T_defs = net->T_defs, }, }; - net->all_allocated_static_tch = (struct time_cc){ + net->all_allocated_static_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index 0da3a6c..c789aea 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -215,46 +215,46 @@ chan_counts_add(&bts_counts, &trx_counts); } - time_cc_set_flag(&bts->all_allocated_sdcch, - bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&bts->all_allocated_sdcch, + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&bts->all_allocated_static_sdcch, - bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&bts->all_allocated_static_sdcch, + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&bts->all_allocated_tch, - (bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&bts->all_allocated_tch, + (bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); - time_cc_set_flag(&bts->all_allocated_static_tch, - (bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&bts->all_allocated_static_tch, + (bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); chan_counts_add(&bsc_counts, &bts_counts); } - time_cc_set_flag(&net->all_allocated_sdcch, - bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&net->all_allocated_sdcch, + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&net->all_allocated_static_sdcch, - bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&net->all_allocated_static_sdcch, + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&net->all_allocated_tch, - (bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&net->all_allocated_tch, + (bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); - time_cc_set_flag(&net->all_allocated_static_tch, - (bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&net->all_allocated_static_tch, + (bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); } diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 71cf4da..2fecfd7 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -211,7 +211,7 @@ } bts->bts_statg = osmo_stat_item_group_alloc(bts, &bts_statg_desc, bts->nr); - bts->all_allocated_sdcch = (struct time_cc){ + bts->all_allocated_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -222,7 +222,7 @@ .T_defs = net->T_defs, }, }; - bts->all_allocated_static_sdcch = (struct time_cc){ + bts->all_allocated_static_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -233,7 +233,7 @@ .T_defs = net->T_defs, }, }; - bts->all_allocated_tch = (struct time_cc){ + bts->all_allocated_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -244,7 +244,7 @@ .T_defs = net->T_defs, }, }; - bts->all_allocated_static_tch = (struct time_cc){ + bts->all_allocated_static_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, diff --git a/src/osmo-bsc/time_cc.c b/src/osmo-bsc/time_cc.c deleted file mode 100644 index e78e48d..0000000 --- a/src/osmo-bsc/time_cc.c +++ /dev/null @@ -1,208 +0,0 @@ -/* Report the cumulative counter of time for which a flag is true as rate counter. */ -/* Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH - * - * All Rights Reserved - * - * Author: Neels Hofmeyr - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#include - -#include -#include - -#include - -#define GRAN_USEC(TIME_CC) ((TIME_CC)->cfg.gran_usec ? : 1000000) -#define ROUND_THRESHOLD_USEC(TIME_CC) ((TIME_CC)->cfg.round_threshold_usec ? \ - OSMO_MIN((TIME_CC)->cfg.round_threshold_usec, GRAN_USEC(TIME_CC)) \ - : (GRAN_USEC(TIME_CC) / 2)) - -static uint64_t time_now_usec() -{ - struct timespec tp; - if (osmo_clock_gettime(CLOCK_MONOTONIC, &tp)) - return 0; - return (uint64_t)tp.tv_sec * 1000000 + tp.tv_nsec / 1000; -} - -static void time_cc_forget_sum(struct time_cc *tc, uint64_t now); - -static void time_cc_update_from_tdef(struct time_cc *tc, uint64_t now) -{ - bool do_forget_sum = false; - if (!tc->cfg.T_defs) - return; - if (tc->cfg.T_gran) { - uint64_t was = GRAN_USEC(tc); - tc->cfg.gran_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_gran, OSMO_TDEF_US, -1); - if (was != GRAN_USEC(tc)) - do_forget_sum = true; - } - if (tc->cfg.T_round_threshold) - tc->cfg.round_threshold_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_round_threshold, - OSMO_TDEF_US, -1); - if (tc->cfg.T_forget_sum) { - uint64_t was = tc->cfg.forget_sum_usec; - tc->cfg.forget_sum_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_forget_sum, OSMO_TDEF_US, -1); - if (tc->cfg.forget_sum_usec && was != tc->cfg.forget_sum_usec) - do_forget_sum = true; - } - - if (do_forget_sum && tc->sum) - time_cc_forget_sum(tc, now); -} - -static void time_cc_schedule_timer(struct time_cc *tc, uint64_t now); - -/* Clear out osmo_timer and internal counting state of struct time_cc. The .cfg remains unaffected. After calling, the - * time_cc instance can be used again to accumulate state as if it had just been initialized. */ -void time_cc_cleanup(struct time_cc *tc) -{ - osmo_timer_del(&tc->timer); - *tc = (struct time_cc){ - .cfg = tc->cfg, - }; -} - -static void time_cc_start(struct time_cc *tc, uint64_t now) -{ - time_cc_cleanup(tc); - /* Set the default of 1 second of granularity */ - tc->start_time = now; - tc->last_counted_time = now; - time_cc_update_from_tdef(tc, now); - time_cc_schedule_timer(tc, now); -} - -static void time_cc_count_time(struct time_cc *tc, uint64_t now) -{ - uint64_t time_delta = now - tc->last_counted_time; - tc->last_counted_time = now; - if (!tc->flag_state) - return; - /* Flag is currently true, cumulate the elapsed time */ - tc->total_sum += time_delta; - tc->sum += time_delta; -} - -static void time_cc_report(struct time_cc *tc, uint64_t now) -{ - uint64_t delta; - uint64_t n; - if (!tc->cfg.rate_ctr) - return; - /* We report a sum "rounded up", ahead of time. If the granularity period has not yet elapsed after the last - * reporting, do not report again yet. */ - if (tc->reported_sum > tc->sum) - return; - delta = tc->sum - tc->reported_sum; - /* elapsed full periods */ - n = delta / GRAN_USEC(tc); - /* If the delta has passed round_threshold (normally half of gran_usec), increment. */ - delta -= n * GRAN_USEC(tc); - if (delta >= ROUND_THRESHOLD_USEC(tc)) - n++; - if (!n) - return; - - /* integer sanity, since rate_ctr_add() takes an int argument. */ - if (n > INT_MAX) - n = INT_MAX; - rate_ctr_add(tc->cfg.rate_ctr, n); - /* Store the increments of gran_usec that were counted. */ - tc->reported_sum += n * GRAN_USEC(tc); -} - -static void time_cc_forget_sum(struct time_cc *tc, uint64_t now) -{ - tc->reported_sum = 0; - tc->sum = 0; - - if (tc->last_counted_time < now) - tc->last_counted_time = now; -} - -/* Initialize struct time_cc. Call this once before use, and before setting up the .cfg items. */ -void time_cc_init(struct time_cc *tc) -{ - *tc = (struct time_cc){0}; -} - -void time_cc_set_flag(struct time_cc *tc, bool flag) -{ - uint64_t now = time_now_usec(); - if (!tc->start_time) - time_cc_start(tc, now); - /* No flag change == no effect */ - if (flag == tc->flag_state) - return; - /* Sum up elapsed time, report increments for that. */ - time_cc_count_time(tc, now); - time_cc_report(tc, now); - tc->flag_state = flag; - time_cc_schedule_timer(tc, now); -} - -static void time_cc_timer_cb(void *data) -{ - struct time_cc *tc = data; - uint64_t now = time_now_usec(); - - time_cc_update_from_tdef(tc, now); - - if (tc->flag_state) { - time_cc_count_time(tc, now); - time_cc_report(tc, now); - } else if (tc->cfg.forget_sum_usec && tc->sum - && (now >= tc->last_counted_time + tc->cfg.forget_sum_usec)) { - time_cc_forget_sum(tc, now); - } - time_cc_schedule_timer(tc, now); -} - -static void time_cc_schedule_timer(struct time_cc *tc, uint64_t now) -{ - uint64_t next_event = UINT64_MAX; - - time_cc_update_from_tdef(tc, now); - - /* Figure out the next time we should do anything, if the flag state remains unchanged. */ - /* If it is required, when will the next forget_sum happen? */ - if (tc->cfg.forget_sum_usec && !tc->flag_state && tc->sum > 0) { - uint64_t next_forget_time = tc->last_counted_time + tc->cfg.forget_sum_usec; - next_event = OSMO_MIN(next_event, next_forget_time); - } - /* Next rate_ctr increment? */ - if (tc->flag_state && tc->cfg.rate_ctr) { - uint64_t next_inc = now + (tc->reported_sum - tc->sum) + ROUND_THRESHOLD_USEC(tc); - next_event = OSMO_MIN(next_event, next_inc); - } - - /* No event coming up? */ - if (next_event == UINT64_MAX) - return; - - if (next_event <= now) - next_event = 0; - else - next_event -= now; - - osmo_timer_setup(&tc->timer, time_cc_timer_cb, tc); - osmo_timer_del(&tc->timer); - osmo_timer_schedule(&tc->timer, next_event / 1000000, next_event % 1000000); -} diff --git a/tests/Makefile.am b/tests/Makefile.am index aefaae8..762561e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -7,7 +7,6 @@ subscr \ nanobts_omlattr \ handover \ - time_cc \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. diff --git a/tests/testsuite.at b/tests/testsuite.at index 094117f..e7eb76b 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -49,9 +49,3 @@ cat $abs_srcdir/handover/handover_tests.ok > expout AT_CHECK([$abs_srcdir/handover/handover_tests.sh $abs_srcdir/handover $abs_builddir/handover], [], [expout], [ignore]) AT_CLEANUP - -AT_SETUP([time_cc_test]) -AT_KEYWORDS([time_cc_test]) -cat $abs_srcdir/time_cc/time_cc_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/time_cc/time_cc_test], [], [expout], [ignore]) -AT_CLEANUP diff --git a/tests/time_cc/Makefile.am b/tests/time_cc/Makefile.am deleted file mode 100644 index de407e7..0000000 --- a/tests/time_cc/Makefile.am +++ /dev/null @@ -1,36 +0,0 @@ -AM_CPPFLAGS = \ - $(all_includes) \ - -I$(top_srcdir)/include \ - $(NULL) - -AM_CFLAGS = \ - -Wall \ - -ggdb3 \ - $(LIBOSMOCORE_CFLAGS) \ - $(COVERAGE_CFLAGS) \ - $(NULL) - -AM_LDFLAGS = \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - -EXTRA_DIST = \ - time_cc_test.ok \ - $(NULL) - -noinst_PROGRAMS = \ - time_cc_test \ - $(NULL) - -time_cc_test_SOURCES = \ - time_cc_test.c \ - $(NULL) - -time_cc_test_LDADD = \ - $(top_builddir)/src/osmo-bsc/libbsc.la \ - $(LIBOSMOCORE_LIBS) \ - $(NULL) - -.PHONY: update_exp -update_exp: - $(builddir)/time_cc_test >$(srcdir)/time_cc_test.ok diff --git a/tests/time_cc/time_cc_test.c b/tests/time_cc/time_cc_test.c deleted file mode 100644 index 4c5396d..0000000 --- a/tests/time_cc/time_cc_test.c +++ /dev/null @@ -1,769 +0,0 @@ -/* (C) 2021 by sysmocom - s.f.m.c. GmbH - * All Rights Reserved - * - * Author: Neels Janosch Hofmeyr - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#include - -#include -#include -#include -#include -#include -#include - -#include - -enum my_ctrs { - CTR_CEIL, - CTR_ROUND, - CTR_FLOOR, -}; - -const struct rate_ctr_desc my_ctr_desc[] = { - [CTR_CEIL] = {"ceil", "testing round_threshold_usec = 1"}, - [CTR_ROUND] = {"round", "testing round_threshold_usec = 0 = gran_usec/2"}, - [CTR_FLOOR] = {"floor", "testing round_threshold_usec = gran_usec"}, -}; - -const struct rate_ctr_group_desc my_ctrg_desc = { - "time_cc_test", - "Counters for time_cc test", - 0, - ARRAY_SIZE(my_ctr_desc), - my_ctr_desc, -}; - -struct rate_ctr_group *my_ctrg; - - -enum my_obj_timers { - T_GRAN = -23, - T_ROUND_THRESH = -24, - T_FORGET_SUM = -25, -}; - -struct osmo_tdef g_my_obj_tdefs[] = { - { .T = T_GRAN, .default_val = 0, .unit = OSMO_TDEF_MS, .desc = "flag_cc granularity, or zero for 1 second" }, - { .T = T_ROUND_THRESH, .default_val = 0, .unit = OSMO_TDEF_MS, - .desc = "flag_cc rounding threshold, or zero for half a granularity" }, - { .T = T_FORGET_SUM, .default_val = 0, .unit = OSMO_TDEF_MS, - .desc = "flag_cc inactivity forget period, or zero to not forget any timings" }, - {} -}; - - -struct my_obj { - struct time_cc flag_cc_ceil; - struct time_cc flag_cc_round; - struct time_cc flag_cc_floor; -}; - -void my_obj_init(struct my_obj *my_obj) -{ - time_cc_init(&my_obj->flag_cc_ceil); - my_obj->flag_cc_ceil.cfg = (struct time_cc_cfg){ - .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_CEIL), - .round_threshold_usec = 1, - .T_gran = T_GRAN, - .T_forget_sum = T_FORGET_SUM, - .T_defs = g_my_obj_tdefs, - }; - - time_cc_init(&my_obj->flag_cc_round); - my_obj->flag_cc_round.cfg = (struct time_cc_cfg){ - .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_ROUND), - .T_gran = T_GRAN, - .T_round_threshold = T_ROUND_THRESH, - .T_forget_sum = T_FORGET_SUM, - .T_defs = g_my_obj_tdefs, - }; - - time_cc_init(&my_obj->flag_cc_floor); - my_obj->flag_cc_floor.cfg = (struct time_cc_cfg){ - .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_FLOOR), - .round_threshold_usec = UINT64_MAX, /* always >= gran_usec */ - .T_gran = T_GRAN, - .T_forget_sum = T_FORGET_SUM, - .T_defs = g_my_obj_tdefs, - }; -} - -void my_obj_event(struct my_obj *my_obj, bool flag) -{ - time_cc_set_flag(&my_obj->flag_cc_ceil, flag); - time_cc_set_flag(&my_obj->flag_cc_round, flag); - time_cc_set_flag(&my_obj->flag_cc_floor, flag); -} - -void my_obj_destruct(struct my_obj *my_obj) -{ - time_cc_cleanup(&my_obj->flag_cc_ceil); - time_cc_cleanup(&my_obj->flag_cc_round); - time_cc_cleanup(&my_obj->flag_cc_floor); -} - -static const struct log_info_cat log_categories[] = { -}; - -static const struct log_info log_info = { - .cat = log_categories, - .num_cat = ARRAY_SIZE(log_categories), -}; - -int main() -{ - void *ctx = talloc_named_const(NULL, 0, "time_cc_test"); - struct timespec *now; - struct my_obj my_obj = {0}; - - osmo_init_logging2(ctx, &log_info); - - /* enable override for CLOCK_MONOTONIC */ - osmo_clock_override_enable(CLOCK_MONOTONIC, true); - now = osmo_clock_override_gettimespec(CLOCK_MONOTONIC); - now->tv_sec = 23000; - now->tv_nsec = 0; - - /* enable override for osmo_gettimeofday(), for osmo_timer_schedule() */ - osmo_gettimeofday_override = true; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_ctrg = rate_ctr_group_alloc(ctx, &my_ctrg_desc, 0); - -#define CHECK_RATE_CTRS(exp_ceil, exp_round, exp_floor) do { \ - printf("%d CHECK_RATE_CTRS(" #exp_ceil ", " #exp_round ", " #exp_floor ")", \ - my_obj.flag_cc_round.flag_state); \ - while (osmo_select_main_ctx(1) > 0); \ - if (exp_ceil != my_obj.flag_cc_ceil.cfg.rate_ctr->current \ - || exp_round != my_obj.flag_cc_round.cfg.rate_ctr->current \ - || exp_floor != my_obj.flag_cc_floor.cfg.rate_ctr->current) \ - printf("\n ERROR on line %d: ctr_ceil=%"PRIu64" ctr_round=%"PRIu64" ctr_floor=%"PRIu64"\n", \ - __LINE__, \ - my_obj.flag_cc_ceil.cfg.rate_ctr->current, \ - my_obj.flag_cc_round.cfg.rate_ctr->current, \ - my_obj.flag_cc_floor.cfg.rate_ctr->current); \ - else \ - printf(" ok\n"); \ - } while (0) - -#define ADD_MILLISECS_NO_SELECT(ms) do { \ - osmo_clock_override_add(CLOCK_MONOTONIC, ms / 1000, (uint64_t)(ms % 1000) * 1000000); \ - osmo_gettimeofday_override_add(ms / 1000, (uint64_t)(ms % 1000) * 1000); \ - printf("%d ADD_MILLISECS(" #ms ") --> %ld.%03ld", my_obj.flag_cc_round.flag_state, \ - now->tv_sec, now->tv_nsec/1000000); \ - printf("\n"); \ - } while (0) - -#define ADD_MILLISECS(ms) do { \ - ADD_MILLISECS_NO_SELECT(ms); \ - while (osmo_select_main_ctx(1) > 0); \ - } while (0) - -#define FLAG(VAL) do { \ - printf(" flag: %s -> %s\n", my_obj.flag_cc_round.flag_state ? "TRUE" : "FALSE", VAL ? "TRUE" : "FALSE"); \ - my_obj_event(&my_obj, VAL); \ - } while (0) - - /* - * sum ^ - * | ________ - * | / - * | / - * | / - * 3*gran --+--------------------------------------+ - * | /: - * | / : - * | - - - - - - - - - - - - - - - - - / : - * | /. : - * | / . : - * 2*gran --+--------------------------------+ . : - * | /: . : - * | / : . : - * | - - - - - - - - - -_________/ : . : - * | / . : . : - * | / . : . : - * 1*gran --+-----------------+ . : . : - * | /: . : . : - * | / : . : . : - * | - - - - - - -/ : . : . : - * | /. : . : . : - * | ....-------' . : . : . : - * 0 +----------------------------------------------------------> elapsed time - * . : . : . : - * _ _ _______ ____________ - * flag: __| |_| |____| . : |_______|. : . : |__________ - * f t f t f t . : f t. : . : f - * round_threshold_usec : . : . : . : - * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" - * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" - * = gran_usec: 0 1 2 3 = "floor()" - */ - - printf("\n----------- cumulating time, without forget_sum\n\n"); - - my_obj_init(&my_obj); - CHECK_RATE_CTRS(0, 0, 0); - - ADD_MILLISECS(100); - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS(1); - /* flag has been true for 0.001s */ - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(99); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(100); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(100); - /* flag has been true for 0.2s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(300); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(299); - /* flag has been true for 0.499s */ - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(1); - /* flag has been true for 0.5s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS(499); - /* flag has been true for 0.999s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS(1); - /* flag has been true for 1.0s */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS(1); - /* flag has been true for 1.001s */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(299); - /* flag has been true for 1.3s */ - CHECK_RATE_CTRS(2, 1, 1); - FLAG(false); - CHECK_RATE_CTRS(2, 1, 1); - - ADD_MILLISECS(400); - - CHECK_RATE_CTRS(2, 1, 1); - FLAG(true); - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(199); - /* flag has been true for 1.499s */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(2); - /* flag has been true for 1.501s */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(498); - /* flag has been true for 1.999s */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(2); - /* flag has been true for 2.001s */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS(500); - /* flag has been true for 2.501s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(498); - /* flag has been true for 2.999s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(3); - /* flag has been true for 3.003s */ - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS(200); - /* flag has been true for 3.203s */ - CHECK_RATE_CTRS(4, 3, 3); - FLAG(false); - CHECK_RATE_CTRS(4, 3, 3); - - ADD_MILLISECS(4321); - CHECK_RATE_CTRS(4, 3, 3); - - FLAG(true); - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS(5678); - CHECK_RATE_CTRS(9, 9, 8); - FLAG(false); - CHECK_RATE_CTRS(9, 9, 8); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - printf("\n----------- test forget_sum_usec\n\n"); - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); - - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_obj_init(&my_obj); - - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS(100); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(1000); - /* 1 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(8999); - /* 9.999 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(1); - /* 10 s of being false, forget_sum_usec has occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(1); - /* Since previous sums were forgotton, ceil() triggers again */ - CHECK_RATE_CTRS(2, 0, 0); - /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify - * that this does not occur, since now full 500 ms are required */ - ADD_MILLISECS(399); - CHECK_RATE_CTRS(2, 0, 0); - /* Adding another 100 ms will trigger round() */ - ADD_MILLISECS(99); - CHECK_RATE_CTRS(2, 0, 0); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(2, 1, 0); - /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify - * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ - ADD_MILLISECS(400); - CHECK_RATE_CTRS(2, 1, 0); - /* Adding another 100 ms will trigger floor() */ - ADD_MILLISECS(99); - CHECK_RATE_CTRS(2, 1, 0); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(2, 1, 1); - - /* Test that durations of false below forget_sum_usec never trigger a forget */ - ADD_MILLISECS(300); - CHECK_RATE_CTRS(3, 1, 1); - /* internal counter is now at 0.3s above the last reported rate counter */ - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - /* internal counter is now at 0.4s above the last reported rate counter */ - CHECK_RATE_CTRS(3, 1, 1); - ADD_MILLISECS(100); - CHECK_RATE_CTRS(3, 2, 1); - ADD_MILLISECS(500); - CHECK_RATE_CTRS(3, 2, 2); - - /* Test that repeated time_cc_set_flag(false) does not cancel a forget_sum_usec */ - ADD_MILLISECS(300); - /* internal counter is now at 0.3s above the last reported rate counter */ - CHECK_RATE_CTRS(4, 2, 2); - FLAG(false); - ADD_MILLISECS(5000); - /* Repeat 'false', must not affect forget_sum_usec */ - FLAG(false); - ADD_MILLISECS(5000); - CHECK_RATE_CTRS(4, 2, 2); - /* 10 s have passed, forget_sum_usec has occurred. - * Hence ceil() will trigger again right away: */ - FLAG(true); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(5, 2, 2); - /* Adding 200 ms to the initial 300 ms would have triggered round(), but no more after forget_sum_usec */ - ADD_MILLISECS(199); - CHECK_RATE_CTRS(5, 2, 2); - /* Adding another 300 ms will trigger round() */ - ADD_MILLISECS(299); - CHECK_RATE_CTRS(5, 2, 2); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(5, 3, 2); - /* Adding 700 ms to the initial 300 ms would have triggered ceil(), but no more after forget_sum_usec */ - ADD_MILLISECS(200); - CHECK_RATE_CTRS(5, 3, 2); - /* Adding another 300 ms will trigger ceil() */ - ADD_MILLISECS(299); - CHECK_RATE_CTRS(5, 3, 2); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(5, 3, 3); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - - /* Verify correctness when select() lags and runs timer callbacks too late */ - printf("\n----------- cumulating time, without forget_sum, when timer cb are invoked late\n\n"); - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 0, OSMO_TDEF_S); - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_obj_init(&my_obj); - CHECK_RATE_CTRS(0, 0, 0); - - ADD_MILLISECS_NO_SELECT(100); - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS_NO_SELECT(100); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(100); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS_NO_SELECT(100); - /* flag has been true for 0.2s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(300); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS_NO_SELECT(799); - /* flag has been true for 0.999s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 1.0s */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS_NO_SELECT(300); - /* flag has been true for 1.3s */ - CHECK_RATE_CTRS(2, 1, 1); - FLAG(false); - CHECK_RATE_CTRS(2, 1, 1); - - ADD_MILLISECS_NO_SELECT(400); - - CHECK_RATE_CTRS(2, 1, 1); - FLAG(true); - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS_NO_SELECT(699); - /* flag has been true for 1.999s */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 2.0s */ - CHECK_RATE_CTRS(2, 2, 2); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 2.001s */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS_NO_SELECT(499); - /* flag has been true for 2.5s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS_NO_SELECT(499); - /* flag has been true for 2.999s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 3.0s */ - CHECK_RATE_CTRS(3, 3, 3); - ADD_MILLISECS_NO_SELECT(200); - /* flag has been true for 3.2s */ - CHECK_RATE_CTRS(4, 3, 3); - FLAG(false); - CHECK_RATE_CTRS(4, 3, 3); - - ADD_MILLISECS_NO_SELECT(4321); - CHECK_RATE_CTRS(4, 3, 3); - - FLAG(true); - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS_NO_SELECT(5678); - CHECK_RATE_CTRS(9, 9, 8); - FLAG(false); - CHECK_RATE_CTRS(9, 9, 8); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - - printf("\n----------- test forget_sum, when timer cb are invoked late\n\n"); - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); - - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_obj_init(&my_obj); - - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS_NO_SELECT(100); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(1000); - /* 1 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(8999); - /* 9.999 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(1); - /* 10 s of being false, forget_sum_usec has occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS_NO_SELECT(1); - /* Since previous sums were forgotton, ceil() triggers again */ - CHECK_RATE_CTRS(2, 0, 0); - /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify - * that this does not occur, since now full 500 ms are required */ - ADD_MILLISECS_NO_SELECT(399); - CHECK_RATE_CTRS(2, 0, 0); - /* Adding another 100 ms will trigger round() */ - ADD_MILLISECS_NO_SELECT(99); - CHECK_RATE_CTRS(2, 0, 0); - ADD_MILLISECS_NO_SELECT(1); - CHECK_RATE_CTRS(2, 1, 0); - /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify - * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ - ADD_MILLISECS_NO_SELECT(400); - CHECK_RATE_CTRS(2, 1, 0); - /* Adding another 100 ms will trigger floor() */ - ADD_MILLISECS_NO_SELECT(99); - CHECK_RATE_CTRS(2, 1, 0); - ADD_MILLISECS_NO_SELECT(1); - CHECK_RATE_CTRS(2, 1, 1); - - /* Test that durations of false below forget_sum_usec never trigger a forget */ - ADD_MILLISECS_NO_SELECT(300); - CHECK_RATE_CTRS(3, 1, 1); - /* internal counter is now at 0.3s above the last reported rate counter */ - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - /* internal counter is now at 0.4s above the last reported rate counter */ - CHECK_RATE_CTRS(3, 1, 1); - ADD_MILLISECS_NO_SELECT(100); - CHECK_RATE_CTRS(3, 2, 1); - ADD_MILLISECS_NO_SELECT(500); - CHECK_RATE_CTRS(3, 2, 2); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - -#define SET_TDEFS(gran, round_thresh, forget_sum) do { \ - osmo_tdef_set(g_my_obj_tdefs, T_GRAN, gran, OSMO_TDEF_MS); \ - osmo_tdef_set(g_my_obj_tdefs, T_ROUND_THRESH, round_thresh, OSMO_TDEF_MS); \ - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, forget_sum, OSMO_TDEF_S); \ - printf("T_defs: T_gran=%luusec T_round_threshold=%luusec T_forget_sum=%luusec\n", \ - osmo_tdef_get(g_my_obj_tdefs, T_GRAN, OSMO_TDEF_US, -1), \ - osmo_tdef_get(g_my_obj_tdefs, T_ROUND_THRESH, OSMO_TDEF_US, -1), \ - osmo_tdef_get(g_my_obj_tdefs, T_FORGET_SUM, OSMO_TDEF_US, -1)); \ - } while (0) - - printf("\n----------- test T_defs\n\n"); - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - SET_TDEFS(100, 10, 0); - - my_obj_init(&my_obj); - CHECK_RATE_CTRS(0, 0, 0); - - ADD_MILLISECS(100); - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS(9); - /* flag has been true for 0.009s */ - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(1); - /* flag has been true for 0.010s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS(90); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 1, 1); - - SET_TDEFS(200, 190, 1); - /* gran is changed to 200ms, but still continues until the next scheduled event until the change is picked up. - * For ceil(), it is 1 ms ahead. - * For round(), it is 10 ms ahead. - * For floor(), it is at the next full (previous) gran 100 ms ahead. - * When T_defs change, all internal sums are reset to zero without reporting. - */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS(1); - /* 1ms elapsed: ceil() picks up the T_gran change, starts anew. */ - /* elapsed: ceil 0 ms */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 1 ms */ - /* ceil() increments because flag has been true for more than 1 us after reset */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(8); - /* 10 ms elapsed: round() picks up the T_gran change, starts anew */ - /* elapsed: ceil 9 ms, round 0 ms */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(90); - /* 100 ms elapsed: floor() picks up the T_gran change, starts anew */ - /* elapsed: ceil 99 ms, round 90 ms, floor 0 ms */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(99); - /* elapsed: ceil 198 ms, round 189 ms, floor 99 ms */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 199 ms, round 190 ms, floor 100 ms */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 200 ms, round 191 ms, floor 101 ms */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 201 ms, round 192 ms, floor 102 ms */ - CHECK_RATE_CTRS(3, 2, 1); - ADD_MILLISECS(98); - /* elapsed: ceil 299 ms, round 290 ms, floor 200 ms */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS(99); - /* elapsed: ceil 398 ms, round 389 ms, floor 299 ms */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS(1); - /* elapsed: ceil 399 ms, round 390 ms, floor 300 ms */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(1); - /* elapsed: ceil 400 ms, round 391 ms, floor 301 ms */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(1); - /* elapsed: ceil 401 ms, round 392 ms, floor 302 ms */ - CHECK_RATE_CTRS(4, 3, 2); - ADD_MILLISECS(98); - /* elapsed: ceil 499 ms, round 490 ms, floor 400 ms */ - CHECK_RATE_CTRS(4, 3, 3); - - - SET_TDEFS(100, 0, 0); - /* T_defs change, but they only get picked up upon the next event: - * For ceil(), it is 102 ms ahead. - * For round(), it is 100 ms ahead (thresh is still 190, currently at 90). - * For floor(), it is 200 ms ahead. - * When T_defs change, all internal sums are reset to zero without reporting. - */ - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS(100); - CHECK_RATE_CTRS(4, 3, 3); - /* round() picks up the new T_defs. Internal sum resets, nothing else happens yet. - * round() schedules the next event 50 ms ahead. */ - ADD_MILLISECS(2); - CHECK_RATE_CTRS(4, 3, 3); - /* ceil() picks up the change, its next event is 1 ms ahead. */ - ADD_MILLISECS(1); - /* ceil: 0.001 - * round: 0.003 - * floor: still 97 ms until it picks up the change */ - CHECK_RATE_CTRS(5, 3, 3); - ADD_MILLISECS(46); - CHECK_RATE_CTRS(5, 3, 3); - ADD_MILLISECS(1); - /* round() has first counter trigger after T_defs change. */ - CHECK_RATE_CTRS(5, 4, 3); - /* ceil: 0.048 - * round: 0.050 - * floor: still 50 ms until it picks up the change */ - ADD_MILLISECS(50); - /* floor() picks up the change. nothing happens yet. */ - /* ceil: 0.098 - * round: 0.100 - * floor: 0.0 */ - ADD_MILLISECS(2); - /* ceil: 0.100 - * round: 0.102 - * floor: 0.002 */ - CHECK_RATE_CTRS(5, 4, 3); - ADD_MILLISECS(1); - /* ceil: 0.101 - * round: 0.103 - * floor: 0.003 */ - CHECK_RATE_CTRS(6, 4, 3); - ADD_MILLISECS(46); - /* ceil: 0.147 - * round: 0.149 - * floor: 0.049 */ - CHECK_RATE_CTRS(6, 4, 3); - ADD_MILLISECS(1); - /* ceil: 0.148 - * round: 0.150 - * floor: 0.050 */ - CHECK_RATE_CTRS(6, 5, 3); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - return 0; -} diff --git a/tests/time_cc/time_cc_test.ok b/tests/time_cc/time_cc_test.ok deleted file mode 100644 index ccf84d9..0000000 --- a/tests/time_cc/time_cc_test.ok +++ /dev/null @@ -1,328 +0,0 @@ - ------------ cumulating time, without forget_sum - -0 CHECK_RATE_CTRS(0, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.100 -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(1) --> 23000.101 -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(99) --> 23000.200 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.300 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.400 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(300) --> 23000.700 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(299) --> 23000.999 -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23001.000 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(499) --> 23001.499 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(1) --> 23001.500 -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(1) --> 23001.501 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(299) --> 23001.800 -1 CHECK_RATE_CTRS(2, 1, 1) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(2, 1, 1) ok -0 ADD_MILLISECS(400) --> 23002.200 -0 CHECK_RATE_CTRS(2, 1, 1) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(199) --> 23002.399 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(2) --> 23002.401 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(498) --> 23002.899 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(2) --> 23002.901 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(500) --> 23003.401 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(498) --> 23003.899 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(3) --> 23003.902 -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(200) --> 23004.102 -1 CHECK_RATE_CTRS(4, 3, 3) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(4, 3, 3) ok -0 ADD_MILLISECS(4321) --> 23008.423 -0 CHECK_RATE_CTRS(4, 3, 3) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(5678) --> 23014.101 -1 CHECK_RATE_CTRS(9, 9, 8) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(9, 9, 8) ok - ------------ test forget_sum_usec - -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.100 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1000) --> 23001.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(8999) --> 23010.099 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1) --> 23010.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.101 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(399) --> 23010.500 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(99) --> 23010.599 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.600 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(400) --> 23011.000 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(99) --> 23011.099 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(1) --> 23011.100 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(300) --> 23011.400 -1 CHECK_RATE_CTRS(3, 1, 1) ok - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23021.399 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23021.424 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23031.423 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23031.448 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23041.447 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23041.472 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23051.471 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23051.496 -1 CHECK_RATE_CTRS(3, 1, 1) ok -1 ADD_MILLISECS(100) --> 23051.596 -1 CHECK_RATE_CTRS(3, 2, 1) ok -1 ADD_MILLISECS(500) --> 23052.096 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(300) --> 23052.396 -1 CHECK_RATE_CTRS(4, 2, 2) ok - flag: TRUE -> FALSE -0 ADD_MILLISECS(5000) --> 23057.396 - flag: FALSE -> FALSE -0 ADD_MILLISECS(5000) --> 23062.396 -0 CHECK_RATE_CTRS(4, 2, 2) ok - flag: FALSE -> TRUE -1 ADD_MILLISECS(1) --> 23062.397 -1 CHECK_RATE_CTRS(5, 2, 2) ok -1 ADD_MILLISECS(199) --> 23062.596 -1 CHECK_RATE_CTRS(5, 2, 2) ok -1 ADD_MILLISECS(299) --> 23062.895 -1 CHECK_RATE_CTRS(5, 2, 2) ok -1 ADD_MILLISECS(1) --> 23062.896 -1 CHECK_RATE_CTRS(5, 3, 2) ok -1 ADD_MILLISECS(200) --> 23063.096 -1 CHECK_RATE_CTRS(5, 3, 2) ok -1 ADD_MILLISECS(299) --> 23063.395 -1 CHECK_RATE_CTRS(5, 3, 2) ok -1 ADD_MILLISECS(1) --> 23063.396 -1 CHECK_RATE_CTRS(5, 3, 3) ok - ------------ cumulating time, without forget_sum, when timer cb are invoked late - -0 CHECK_RATE_CTRS(0, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.100 -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.200 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.300 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.400 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(300) --> 23000.700 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(799) --> 23001.499 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(1) --> 23001.500 -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(300) --> 23001.800 -1 CHECK_RATE_CTRS(2, 1, 1) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(2, 1, 1) ok -0 ADD_MILLISECS(400) --> 23002.200 -0 CHECK_RATE_CTRS(2, 1, 1) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(699) --> 23002.899 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(1) --> 23002.900 -1 CHECK_RATE_CTRS(2, 2, 2) ok -1 ADD_MILLISECS(1) --> 23002.901 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(499) --> 23003.400 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(499) --> 23003.899 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(1) --> 23003.900 -1 CHECK_RATE_CTRS(3, 3, 3) ok -1 ADD_MILLISECS(200) --> 23004.100 -1 CHECK_RATE_CTRS(4, 3, 3) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(4, 3, 3) ok -0 ADD_MILLISECS(4321) --> 23008.421 -0 CHECK_RATE_CTRS(4, 3, 3) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(5678) --> 23014.099 -1 CHECK_RATE_CTRS(9, 9, 8) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(9, 9, 8) ok - ------------ test forget_sum, when timer cb are invoked late - -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.100 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1000) --> 23001.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(8999) --> 23010.099 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1) --> 23010.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.101 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(399) --> 23010.500 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(99) --> 23010.599 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.600 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(400) --> 23011.000 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(99) --> 23011.099 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(1) --> 23011.100 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(300) --> 23011.400 -1 CHECK_RATE_CTRS(3, 1, 1) ok - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23021.399 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23021.424 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23031.423 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23031.448 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23041.447 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23041.472 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23051.471 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23051.496 -1 CHECK_RATE_CTRS(3, 1, 1) ok -1 ADD_MILLISECS(100) --> 23051.596 -1 CHECK_RATE_CTRS(3, 2, 1) ok -1 ADD_MILLISECS(500) --> 23052.096 -1 CHECK_RATE_CTRS(3, 2, 2) ok - ------------ test T_defs - -T_defs: T_gran=100000usec T_round_threshold=10000usec T_forget_sum=0usec -0 CHECK_RATE_CTRS(0, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.100 -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(9) --> 23000.109 -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23000.110 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(90) --> 23000.200 -1 CHECK_RATE_CTRS(1, 1, 1) ok -T_defs: T_gran=200000usec T_round_threshold=190000usec T_forget_sum=1000000usec -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(1) --> 23000.201 -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(1) --> 23000.202 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(8) --> 23000.210 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(90) --> 23000.300 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(99) --> 23000.399 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(1) --> 23000.400 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(1) --> 23000.401 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(1) --> 23000.402 -1 CHECK_RATE_CTRS(3, 2, 1) ok -1 ADD_MILLISECS(98) --> 23000.500 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(99) --> 23000.599 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(1) --> 23000.600 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(1) --> 23000.601 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(1) --> 23000.602 -1 CHECK_RATE_CTRS(4, 3, 2) ok -1 ADD_MILLISECS(98) --> 23000.700 -1 CHECK_RATE_CTRS(4, 3, 3) ok -T_defs: T_gran=100000usec T_round_threshold=0usec T_forget_sum=0usec -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(100) --> 23000.800 -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(2) --> 23000.802 -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(1) --> 23000.803 -1 CHECK_RATE_CTRS(5, 3, 3) ok -1 ADD_MILLISECS(46) --> 23000.849 -1 CHECK_RATE_CTRS(5, 3, 3) ok -1 ADD_MILLISECS(1) --> 23000.850 -1 CHECK_RATE_CTRS(5, 4, 3) ok -1 ADD_MILLISECS(50) --> 23000.900 -1 ADD_MILLISECS(2) --> 23000.902 -1 CHECK_RATE_CTRS(5, 4, 3) ok -1 ADD_MILLISECS(1) --> 23000.903 -1 CHECK_RATE_CTRS(6, 4, 3) ok -1 ADD_MILLISECS(46) --> 23000.949 -1 CHECK_RATE_CTRS(6, 4, 3) ok -1 ADD_MILLISECS(1) --> 23000.950 -1 CHECK_RATE_CTRS(6, 5, 3) ok -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 22:59:35 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 22:59:35 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26230 to look at the new patch set (#2). Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... add osmo_time_cc, moved from osmo-bsc Related: SYS#4878 Related: Ica9f908a1a30f334a24c59471affa11225117e12 (osmo-bsc) Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd --- M include/Makefile.am A include/osmocom/core/time_cc.h M src/Makefile.am A src/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 8 files changed, 1,522 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/26230/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 23:10:27 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 23:10:27 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26230 to look at the new patch set (#3). Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... add osmo_time_cc, moved from osmo-bsc Related: SYS#4878 Related: Ica9f908a1a30f334a24c59471affa11225117e12 (osmo-bsc) Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd --- M include/Makefile.am A include/osmocom/core/time_cc.h M src/Makefile.am A src/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 8 files changed, 1,522 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/26230/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 23:15:27 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 23:15:27 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26230 to look at the new patch set (#4). Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... add osmo_time_cc, moved from osmo-bsc Related: SYS#4878 Related: Ica9f908a1a30f334a24c59471affa11225117e12 (osmo-bsc) Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd --- M include/Makefile.am A include/osmocom/core/time_cc.h M src/Makefile.am A src/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 8 files changed, 1,527 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/26230/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 23:17:31 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 23:17:31 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26230 to look at the new patch set (#5). Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... add osmo_time_cc, moved from osmo-bsc Related: SYS#4878 Related: Ica9f908a1a30f334a24c59471affa11225117e12 (osmo-bsc) Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd --- M include/Makefile.am A include/osmocom/core/time_cc.h M src/Makefile.am A src/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 8 files changed, 1,523 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/26230/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 13 23:19:50 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Nov 2021 23:19:50 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26230 to look at the new patch set (#6). Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... add osmo_time_cc, moved from osmo-bsc Related: SYS#4878 Related: Ica9f908a1a30f334a24c59471affa11225117e12 (osmo-bsc) Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd --- M include/Makefile.am A include/osmocom/core/time_cc.h M src/Makefile.am A src/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 8 files changed, 1,527 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/26230/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 03:52:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 03:52:07 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26230 ) Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26230/5/src/time_cc.c File src/time_cc.c: https://gerrit.osmocom.org/c/libosmocore/+/26230/5/src/time_cc.c at 45 PS5, Line 45: #define GRAN_USEC(TIME_CC) ((TIME_CC)->cfg.gran_usec ? : 1000000) No OSMO_ prefix here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 14 Nov 2021 03:52:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 16:36:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 16:36:30 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: fix wrong CI in the inter-BSC handover diagram References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26232 ) Change subject: doc/manuals: fix wrong CI in the inter-BSC handover diagram ...................................................................... doc/manuals: fix wrong CI in the inter-BSC handover diagram The 'bts0' in BSS 'Beta' has LAC=42/CI=3. There is no LAC=42/CI=6. Change-Id: I0f2e351e802311d4601579c2e755ca13a9056348 --- M doc/manuals/chapters/handover_inter_bsc.dot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/26232/1 diff --git a/doc/manuals/chapters/handover_inter_bsc.dot b/doc/manuals/chapters/handover_inter_bsc.dot index 42decef..3ff8093 100644 --- a/doc/manuals/chapters/handover_inter_bsc.dot +++ b/doc/manuals/chapters/handover_inter_bsc.dot @@ -27,7 +27,7 @@ {BSC_a,BSC_b} -> MSC [arrowhead=none,label=A] -BSC_a -> MSC [label="(6) --> Handover Required\nto LAC=42 CI=6\n(10) <-- Handover Command",style=dashed,constraint=false,arrowhead=none] +BSC_a -> MSC [label="(6) --> Handover Required\nto LAC=42 CI=3\n(10) <-- Handover Command",style=dashed,constraint=false,arrowhead=none] MSC -> BSC_b [label="(7) <-- Handover Request\n(9) --> Handover Request ACK",style=dashed,constraint=false,arrowhead=none] BSC_b -> BTS_b0 [label="(8) activate new lchan",style=dashed,constraint=false] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e351e802311d4601579c2e755ca13a9056348 Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:36:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:36:35 +0000 Subject: Change in libosmo-sccp[master]: sccp_scmg: Add missing line eneding to log statement References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26233 ) Change subject: sccp_scmg: Add missing line eneding to log statement ...................................................................... sccp_scmg: Add missing line eneding to log statement Change-Id: I7ec5c86fbef429cd1e23be87b773823f2e736f2f --- M src/sccp_scmg.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/33/26233/1 diff --git a/src/sccp_scmg.c b/src/sccp_scmg.c index a5d6226..aba2416 100644 --- a/src/sccp_scmg.c +++ b/src/sccp_scmg.c @@ -261,7 +261,7 @@ case SCCP_SCMG_MSGT_SOG: case SCCP_SCMG_MSGT_SSC: default: - LOGP(DLSCCP, LOGL_NOTICE, "Rx unsupported SCCP SCMG %s, ignoring", + LOGP(DLSCCP, LOGL_NOTICE, "Rx unsupported SCCP SCMG %s, ignoring\n", sccp_scmg_msgt_name(scmg->msg_type)); break; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7ec5c86fbef429cd1e23be87b773823f2e736f2f Gerrit-Change-Number: 26233 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:36:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:36:35 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... stp: Add basic RX/TX rate counters on AS and ASP level This adds some very basic rx/px rate counters to the SS7 AS and ASP OsmoSTP> show rate-counters SIGTRAN Application Server 0 (as-rkm-1): rx:msu:total: 86078 (1888/s 86078/m 0/h 0/d) tx:msu:total: 0 (0/s 0/m 0/h 0/d) SIGTRAN Application Server Process 0 (asp-dyn-0): rx:packets:total: 86081 (1888/s 86081/m 0/h 0/d) tx:packets:total: 5 (0/s 5/m 0/h 0/d) Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 --- M include/osmocom/sigtran/osmo_ss7.h M src/ipa.c M src/m3ua.c M src/osmo_ss7.c M src/osmo_ss7_hmrt.c M src/ss7_internal.h M src/sua.c M stp/stp_main.c 8 files changed, 79 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/34/26234/1 diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 3d13b6a..1755859 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -9,6 +9,7 @@ #include #include #include +#include extern struct llist_head osmo_ss7_instances; @@ -310,6 +311,9 @@ /*! Were we allocated by "simple client" support? */ bool simple_client_allocated; + /*! Rate Counter Group */ + struct rate_ctr_group *ctrg; + struct { char *name; char *description; @@ -412,6 +416,9 @@ /*! Were we allocated by "simple client" support? */ bool simple_client_allocated; + /*! Rate Counter Group */ + struct rate_ctr_group *ctrg; + /*! Pending message for non-blocking IPA read */ struct msgb *pending_msg; diff --git a/src/ipa.c b/src/ipa.c index 93edef8..5b1eb54 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -47,6 +47,7 @@ #include #include "xua_internal.h" +#include "ss7_internal.h" #include "xua_asp_fsm.h" @@ -224,6 +225,8 @@ return -1; } + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + /* pull the IPA header */ msgb_pull_to_l2(msg); diff --git a/src/m3ua.c b/src/m3ua.c index 607813f..26acc1b 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -44,6 +44,7 @@ #include "xua_as_fsm.h" #include "xua_asp_fsm.h" #include "xua_internal.h" +#include "ss7_internal.h" #define M3UA_MSGB_SIZE 1500 @@ -553,6 +554,8 @@ if (rc) return rc; + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + /* FIXME: check for AS state == ACTIVE */ /* store the MTP-level information in the xua_msg for use by diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 38206fb..7610533 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -48,6 +48,7 @@ #include "sccp_internal.h" #include "xua_internal.h" +#include "ss7_internal.h" #include "xua_asp_fsm.h" #include "xua_as_fsm.h" @@ -895,6 +896,19 @@ * SS7 Application Server ***********************************************************************/ +static const struct rate_ctr_desc ss7_as_rcd[] = { + [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "" }, + [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "" }, +}; + +static const struct rate_ctr_group_desc ss7_as_rcgd = { + .group_name_prefix = "sigtran.as", + .group_description = "SIGTRAN Application Server", + .num_ctr = ARRAY_SIZE(ss7_as_rcd), + .ctr_desc = ss7_as_rcd, +}; +static unsigned int g_ss7_as_rcg_idx; + /*! \brief Find Application Server by given name * \param[in] inst SS7 Instance on which we operate * \param[in] name Name of AS @@ -1002,6 +1016,12 @@ as = talloc_zero(inst, struct osmo_ss7_as); if (!as) return NULL; + as->ctrg = rate_ctr_group_alloc(as, &ss7_as_rcgd, g_ss7_as_rcg_idx++); + if (!as->ctrg) { + talloc_free(as); + return NULL; + } + rate_ctr_group_set_name(as->ctrg, name); as->inst = inst; as->cfg.name = talloc_strdup(as, name); as->cfg.proto = proto; @@ -1125,6 +1145,24 @@ * SS7 Application Server Process ***********************************************************************/ +enum ss7_asp_ctr { + SS7_ASP_CTR_PKT_RX_TOTAL, + SS7_ASP_CTR_PKT_TX_TOTAL, +}; + +static const struct rate_ctr_desc ss7_asp_rcd[] = { + [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "" }, + [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx.packets.total", "" }, +}; + +static const struct rate_ctr_group_desc ss7_asp_rcgd = { + .group_name_prefix = "sigtran.asp", + .group_description = "SIGTRAN Application Server Process", + .num_ctr = ARRAY_SIZE(ss7_asp_rcd), + .ctr_desc = ss7_asp_rcd, +}; +static unsigned int g_ss7_asp_rcg_idx; + int osmo_ss7_asp_peer_snprintf(char* buf, size_t buf_len, struct osmo_ss7_asp_peer *peer) { int len = 0, offset = 0, rem = buf_len; @@ -1485,6 +1523,12 @@ if (!asp) { /* FIXME: check if local port has SCTP? */ asp = talloc_zero(inst, struct osmo_ss7_asp); + asp->ctrg = rate_ctr_group_alloc(asp, &ss7_asp_rcgd, g_ss7_asp_rcg_idx++); + if (!asp->ctrg) { + talloc_free(asp); + return NULL; + } + rate_ctr_group_set_name(asp->ctrg, name); asp->inst = inst; asp->cfg.remote.port = remote_port; asp->cfg.local.port = local_port; @@ -1781,6 +1825,8 @@ msgb_sctp_stream(msg) = sinfo.sinfo_stream; msg->dst = asp; + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); + if (ppid == SUA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_SUA) rc = sua_rx_msg(asp, msg); else if (ppid == M3UA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_M3UA) @@ -1860,6 +1906,7 @@ return -1; } msg->dst = asp; + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); return ipa_rx_msg(asp, msg); } @@ -1918,6 +1965,8 @@ msgb_sctp_stream(msg) = sinfo.sinfo_stream; msg->dst = asp; + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); + if (ppid == SUA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_SUA) rc = sua_rx_msg(asp, msg); else if (ppid == M3UA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_M3UA) @@ -2086,6 +2135,8 @@ OSMO_ASSERT(0); } + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_TX_TOTAL); + if (asp->cfg.is_server) { if (!asp->server) { LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, no asp->server\n"); diff --git a/src/osmo_ss7_hmrt.c b/src/osmo_ss7_hmrt.c index 882d85d..f5fcd64 100644 --- a/src/osmo_ss7_hmrt.c +++ b/src/osmo_ss7_hmrt.c @@ -35,6 +35,7 @@ #include #include "xua_internal.h" +#include "ss7_internal.h" /* convert from M3UA message to MTP-TRANSFER.ind osmo_mtp_prim */ struct osmo_mtp_prim *m3ua_to_xfer_ind(struct xua_msg *xua) @@ -227,6 +228,8 @@ dpc, osmo_ss7_pointcode_print(inst, dpc), rt_name); } + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TX_MSU_TOTAL); + switch (as->cfg.proto) { case OSMO_SS7_ASP_PROT_M3UA: DEBUGP(DLSS7, "rt->dest.as proto is M3UA for dpc=%u=%s\n", diff --git a/src/ss7_internal.h b/src/ss7_internal.h index 28e239c..712a6ed 100644 --- a/src/ss7_internal.h +++ b/src/ss7_internal.h @@ -7,3 +7,8 @@ bool osmo_ss7_asp_set_default_peer_hosts(struct osmo_ss7_asp *asp); bool osmo_ss7_xua_server_set_default_local_hosts(struct osmo_xua_server *oxs); + +enum ss7_as_ctr { + SS7_AS_CTR_RX_MSU_TOTAL, + SS7_AS_CTR_TX_MSU_TOTAL, +}; diff --git a/src/sua.c b/src/sua.c index 8415fa3..000f064 100644 --- a/src/sua.c +++ b/src/sua.c @@ -46,6 +46,7 @@ #include "xua_asp_fsm.h" #include "xua_internal.h" #include "sccp_internal.h" +#include "ss7_internal.h" /* Appendix C.4 of Q.714 (all in milliseconds) */ #define CONNECTION_TIMER ( 1 * 60 * 100) @@ -521,6 +522,8 @@ if (rc) return rc; + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + switch (xua->hdr.msg_type) { case 0: /* Reserved, permitted by ETSI TS 101 592 5.2.3.2 */ case SUA_CL_CLDT: @@ -549,6 +552,8 @@ if (rc) return rc; + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + switch (xua->hdr.msg_type) { case 0: /* Reserved, permitted by ETSI TS 101 592 5.2.3.2 */ case SUA_CO_CORE: diff --git a/stp/stp_main.c b/stp/stp_main.c index 1e83615..569cf8e 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -254,6 +255,7 @@ signal(SIGUSR1, &signal_handler); signal(SIGUSR2, &signal_handler); osmo_init_ignore_signals(); + rate_ctr_init(tall_stp_ctx); if (cmdline_config.daemonize) { rc = osmo_daemonize(); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:39:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:39:22 +0000 Subject: Change in libosmo-sccp[master]: sccp_scmg: Add missing line eneding to log statement In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26233 ) Change subject: sccp_scmg: Add missing line eneding to log statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7ec5c86fbef429cd1e23be87b773823f2e736f2f Gerrit-Change-Number: 26233 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Nov 2021 19:39:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:39:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:39:24 +0000 Subject: Change in libosmo-sccp[master]: sccp_scmg: Add missing line eneding to log statement In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26233 ) Change subject: sccp_scmg: Add missing line eneding to log statement ...................................................................... sccp_scmg: Add missing line eneding to log statement Change-Id: I7ec5c86fbef429cd1e23be87b773823f2e736f2f --- M src/sccp_scmg.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sccp_scmg.c b/src/sccp_scmg.c index a5d6226..aba2416 100644 --- a/src/sccp_scmg.c +++ b/src/sccp_scmg.c @@ -261,7 +261,7 @@ case SCCP_SCMG_MSGT_SOG: case SCCP_SCMG_MSGT_SSC: default: - LOGP(DLSCCP, LOGL_NOTICE, "Rx unsupported SCCP SCMG %s, ignoring", + LOGP(DLSCCP, LOGL_NOTICE, "Rx unsupported SCCP SCMG %s, ignoring\n", sccp_scmg_msgt_name(scmg->msg_type)); break; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7ec5c86fbef429cd1e23be87b773823f2e736f2f Gerrit-Change-Number: 26233 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:43:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:43:22 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26230 ) Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26230/5/src/time_cc.c File src/time_cc.c: https://gerrit.osmocom.org/c/libosmocore/+/26230/5/src/time_cc.c at 45 PS5, Line 45: #define GRAN_USEC(TIME_CC) ((TIME_CC)->cfg.gran_usec ? : 1000000) > No OSMO_ prefix here? this is a private #define in the .c file, and not a publicly exposed #define in a .h file. So no need for a prefix at all. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 14 Nov 2021 19:43:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:44:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:44:07 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26231 ) Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... Patch Set 1: TODO-RELEASE entry for updating libosmocore dependency on next release? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 14 Nov 2021 19:44:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:44:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:44:11 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26231 ) Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Nov 2021 19:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:46:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Nov 2021 19:46:18 +0000 Subject: Change in libosmocore[master]: rate_ctr: Make it safe to call rate_ctr_init() several times References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26235 ) Change subject: rate_ctr: Make it safe to call rate_ctr_init() several times ...................................................................... rate_ctr: Make it safe to call rate_ctr_init() several times There might be library code that has rate counters, and if the main program calls rate_ctr_init() a second time, we can skip the second initialization. Change-Id: I6f5342a77518599eb5ac9a0f0605917a78fcc387 --- M src/rate_ctr.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/26235/1 diff --git a/src/rate_ctr.c b/src/rate_ctr.c index 4d99699..283858d 100644 --- a/src/rate_ctr.c +++ b/src/rate_ctr.c @@ -354,6 +354,10 @@ * \returns 0 on success; negative on error */ int rate_ctr_init(void *tall_ctx) { + /* ignore repeated initialization */ + if (osmo_timer_pending(&rate_ctr_timer)) + return 0; + tall_rate_ctr_ctx = tall_ctx; osmo_timer_setup(&rate_ctr_timer, rate_ctr_timer_cb, NULL); osmo_timer_schedule(&rate_ctr_timer, 1, 0); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f5342a77518599eb5ac9a0f0605917a78fcc387 Gerrit-Change-Number: 26235 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:54:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 14 Nov 2021 19:54:06 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: fix wrong CI in the inter-BSC handover diagram In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26232 ) Change subject: doc/manuals: fix wrong CI in the inter-BSC handover diagram ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e351e802311d4601579c2e755ca13a9056348 Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 14 Nov 2021 19:54:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 19:59:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 14 Nov 2021 19:59:16 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/1/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/1/src/osmo_ss7.c at 900 PS1, Line 900: [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "" }, no description for the counters? https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/1/src/osmo_ss7.c at 1154 PS1, Line 1154: [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "" }, same -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Sun, 14 Nov 2021 19:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 20:00:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 14 Nov 2021 20:00:55 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26230 ) Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 14 Nov 2021 20:00:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 20:01:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 14 Nov 2021 20:01:49 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26231 ) Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... Patch Set 1: > Patch Set 1: > > TODO-RELEASE entry for updating libosmocore dependency on next release? Agree. Take my +1 once you add it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sun, 14 Nov 2021 20:01:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 20:02:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 14 Nov 2021 20:02:57 +0000 Subject: Change in libosmocore[master]: rate_ctr: Make it safe to call rate_ctr_init() several times In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26235 ) Change subject: rate_ctr: Make it safe to call rate_ctr_init() several times ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f5342a77518599eb5ac9a0f0605917a78fcc387 Gerrit-Change-Number: 26235 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 14 Nov 2021 20:02:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:18:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:18:52 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: simplify checking if channel mode is AMR References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26236 ) Change subject: abis_rsl: simplify checking if channel mode is AMR ...................................................................... abis_rsl: simplify checking if channel mode is AMR Change-Id: If933ce0fa0a162c4518ddab840f186ebaa1bcff9 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/36/26236/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0186024..f7a2de7 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -689,7 +689,7 @@ add_power_control_params(msg, RSL_IE_BS_POWER_PARAM, lchan); add_power_control_params(msg, RSL_IE_MS_POWER_PARAM, lchan); - if (gsm48_chan_mode_to_non_vamos(lchan->activate.ch_mode_rate.chan_mode) == GSM48_CMODE_SPEECH_AMR) { + if (cm.chan_rate == RSL_CMOD_SP_GSM3) { rc = put_mr_config_for_bts(msg, &lchan->activate.mr_conf_filtered, (lchan->type == GSM_LCHAN_TCH_F) ? &bts->mr_full : &bts->mr_half); if (rc) { @@ -761,7 +761,7 @@ } } - if (gsm48_chan_mode_to_non_vamos(lchan->modify.ch_mode_rate.chan_mode) == GSM48_CMODE_SPEECH_AMR) { + if (cm.chan_rate == RSL_CMOD_SP_GSM3) { rc = put_mr_config_for_bts(msg, &lchan->modify.mr_conf_filtered, (lchan->type == GSM_LCHAN_TCH_F) ? &bts->mr_full : &bts->mr_half); if (rc) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If933ce0fa0a162c4518ddab840f186ebaa1bcff9 Gerrit-Change-Number: 26236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:18:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:18:53 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: simplify comments for ACCH repetition/overpower References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26237 ) Change subject: struct gsm_bts: simplify comments for ACCH repetition/overpower ...................................................................... struct gsm_bts: simplify comments for ACCH repetition/overpower Change-Id: I75b0e289c47841aea22b5966487535cbe855c84f --- M include/osmocom/bsc/bts.h 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/26237/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 89512f3..b42c4ff 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -590,13 +590,10 @@ struct llist_head oml_fail_rep; struct llist_head chan_rqd_queue; - /* osmocom specific FACCH/SACCH repetition mode flags set by VTY to - * enable/disable certain ACCH repeation features individually */ + /* ACCH Repetition capabilities */ struct abis_rsl_osmo_rep_acch_cap repeated_acch_policy; - /* osmocom specific FACCH/SACCH temporary overpower value. This value - * is set to a constant value by the VTY. Temporary overpower is only - * applied when FACCH/SACCH repetition is not applicable or disabled */ + /* ACCH Temporary overpower capabilities */ struct abis_rsl_osmo_temp_ovp_acch_cap temporary_overpower; /* MS/BS Power Control parameters */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75b0e289c47841aea22b5966487535cbe855c84f Gerrit-Change-Number: 26237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:18:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:18:53 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26238 ) Change subject: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g ...................................................................... struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g Let's have a short and consistent naming for both ACCH repetition and temporary ACCH overpower structures, like it's done in osmo-bts. Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Related: Ib1d51f91139b4c2fe794e37fc8543b2d7a9b9c07 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c 4 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/26238/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index b42c4ff..31f14a1 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -591,7 +591,7 @@ struct llist_head chan_rqd_queue; /* ACCH Repetition capabilities */ - struct abis_rsl_osmo_rep_acch_cap repeated_acch_policy; + struct abis_rsl_osmo_rep_acch_cap rep_acch_cap; /* ACCH Temporary overpower capabilities */ struct abis_rsl_osmo_temp_ovp_acch_cap temporary_overpower; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index f7a2de7..aa2f83e 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -540,7 +540,7 @@ cap = (struct abis_rsl_osmo_rep_acch_cap*) msg->tail; msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(*cap), - (uint8_t*) &bts->repeated_acch_policy); + (uint8_t*) &bts->rep_acch_cap); if (!(lchan->conn && lchan->conn->cm3_valid && lchan->conn->cm3.repeated_acch_capability)) { diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 71cf4da..f1cb441 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -398,7 +398,7 @@ acc_ramp_init(&bts->acc_ramp, bts); /* Default RxQual threshold for ACCH repetition/overpower */ - bts->repeated_acch_policy.rxqual = 4; + bts->rep_acch_cap.rxqual = 4; bts->temporary_overpower.rxqual = 4; /* MS Power Control parameters (defaults) */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 8c2b100..037eb93 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -650,11 +650,11 @@ } if (!strcmp(argv[0], "command")) { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = false; + bts->rep_acch_cap.dl_facch_cmd = true; + bts->rep_acch_cap.dl_facch_all = false; } else { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = true; + bts->rep_acch_cap.dl_facch_cmd = true; + bts->rep_acch_cap.dl_facch_all = true; } return CMD_SUCCESS; } @@ -668,8 +668,8 @@ { struct gsm_bts *bts = vty->index; - bts->repeated_acch_policy.dl_facch_cmd = false; - bts->repeated_acch_policy.dl_facch_all = false; + bts->rep_acch_cap.dl_facch_cmd = false; + bts->rep_acch_cap.dl_facch_all = false; return CMD_SUCCESS; } @@ -691,9 +691,9 @@ } if (strcmp(argv[0], "ul-sacch") == 0) - bts->repeated_acch_policy.ul_sacch = true; + bts->rep_acch_cap.ul_sacch = true; else - bts->repeated_acch_policy.dl_sacch = true; + bts->rep_acch_cap.dl_sacch = true; return CMD_SUCCESS; } @@ -709,9 +709,9 @@ struct gsm_bts *bts = vty->index; if (strcmp(argv[0], "ul-sacch") == 0) - bts->repeated_acch_policy.ul_sacch = false; + bts->rep_acch_cap.ul_sacch = false; else - bts->repeated_acch_policy.dl_sacch = false; + bts->rep_acch_cap.dl_sacch = false; return CMD_SUCCESS; } @@ -745,7 +745,7 @@ } /* See also: GSM 05.08, section 8.2.4 */ - bts->repeated_acch_policy.rxqual = atoi(argv[0]); + bts->rep_acch_cap.rxqual = atoi(argv[0]); return CMD_SUCCESS; } @@ -4313,18 +4313,18 @@ top->rxqual, VTY_NEWLINE); } - if (bts->repeated_acch_policy.dl_facch_all) + if (bts->rep_acch_cap.dl_facch_all) vty_out(vty, " repeat dl-facch all%s", VTY_NEWLINE); - else if (bts->repeated_acch_policy.dl_facch_cmd) + else if (bts->rep_acch_cap.dl_facch_cmd) vty_out(vty, " repeat dl-facch command%s", VTY_NEWLINE); - if (bts->repeated_acch_policy.dl_sacch) + if (bts->rep_acch_cap.dl_sacch) vty_out(vty, " repeat dl-sacch%s", VTY_NEWLINE); - if (bts->repeated_acch_policy.ul_sacch) + if (bts->rep_acch_cap.ul_sacch) vty_out(vty, " repeat ul-sacch%s", VTY_NEWLINE); - if (bts->repeated_acch_policy.ul_sacch - || bts->repeated_acch_policy.dl_facch_cmd - || bts->repeated_acch_policy.dl_facch_cmd) - vty_out(vty, " repeat rxqual %u%s", bts->repeated_acch_policy.rxqual, VTY_NEWLINE); + if (bts->rep_acch_cap.ul_sacch + || bts->rep_acch_cap.dl_facch_cmd + || bts->rep_acch_cap.dl_facch_cmd) + vty_out(vty, " repeat rxqual %u%s", bts->rep_acch_cap.rxqual, VTY_NEWLINE); if (bts->interf_meas_params_cfg.avg_period != interf_meas_params_def.avg_period) { vty_out(vty, " interference-meas avg-period %u%s", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Gerrit-Change-Number: 26238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:18:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:18:54 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/temporary_overpower/top_acch_cap/g References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26239 ) Change subject: struct gsm_bts: s/temporary_overpower/top_acch_cap/g ...................................................................... struct gsm_bts: s/temporary_overpower/top_acch_cap/g Let's have a short and consistent naming for both ACCH repetition and temporary ACCH overpower structures, like it's done in osmo-bts. Change-Id: I39b98dcd14219402959646524315d5afea7c08cf Related: Ib1d51f91139b4c2fe794e37fc8543b2d7a9b9c07 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c 4 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/39/26239/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 31f14a1..f582232 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -594,7 +594,7 @@ struct abis_rsl_osmo_rep_acch_cap rep_acch_cap; /* ACCH Temporary overpower capabilities */ - struct abis_rsl_osmo_temp_ovp_acch_cap temporary_overpower; + struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap; /* MS/BS Power Control parameters */ struct gsm_power_ctrl_params ms_power_ctrl; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index aa2f83e..f0cec7b 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -563,8 +563,8 @@ return; msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, - sizeof(bts->temporary_overpower), - (void *)&bts->temporary_overpower); + sizeof(bts->top_acch_cap), + (void *)&bts->top_acch_cap); } /* Write RSL_IE_OSMO_TRAINING_SEQUENCE to msgb. The tsc_set argument's range is 1-4, tsc argument range is 0-7. */ diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index f1cb441..0fdb636 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -399,7 +399,7 @@ /* Default RxQual threshold for ACCH repetition/overpower */ bts->rep_acch_cap.rxqual = 4; - bts->temporary_overpower.rxqual = 4; + bts->top_acch_cap.rxqual = 4; /* MS Power Control parameters (defaults) */ power_ctrl_params_def_reset(&bts->ms_power_ctrl, GSM_PWR_CTRL_DIR_UL); diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 037eb93..8c49be9 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -770,15 +770,15 @@ return CMD_WARNING; } - bts->temporary_overpower.sacch_enable = 0; - bts->temporary_overpower.facch_enable = 0; + bts->top_acch_cap.sacch_enable = 0; + bts->top_acch_cap.facch_enable = 0; if (!strcmp(argv[0], "dl-acch") || !strcmp(argv[0], "dl-sacch")) - bts->temporary_overpower.sacch_enable = 1; + bts->top_acch_cap.sacch_enable = 1; if (!strcmp(argv[0], "dl-acch") || !strcmp(argv[0], "dl-facch")) - bts->temporary_overpower.facch_enable = 1; + bts->top_acch_cap.facch_enable = 1; - bts->temporary_overpower.overpower_db = atoi(argv[1]); + bts->top_acch_cap.overpower_db = atoi(argv[1]); return CMD_SUCCESS; } @@ -792,9 +792,9 @@ { struct gsm_bts *bts = vty->index; - bts->temporary_overpower.overpower_db = 0; - bts->temporary_overpower.sacch_enable = 0; - bts->temporary_overpower.facch_enable = 0; + bts->top_acch_cap.overpower_db = 0; + bts->top_acch_cap.sacch_enable = 0; + bts->top_acch_cap.facch_enable = 0; return CMD_SUCCESS; } @@ -813,7 +813,7 @@ return CMD_WARNING; } - bts->temporary_overpower.rxqual = atoi(argv[0]); + bts->top_acch_cap.rxqual = atoi(argv[0]); return CMD_SUCCESS; } @@ -4293,9 +4293,9 @@ ho_vty_write_bts(vty, bts); - if (bts->temporary_overpower.overpower_db > 0) { + if (bts->top_acch_cap.overpower_db > 0) { const struct abis_rsl_osmo_temp_ovp_acch_cap *top = \ - &bts->temporary_overpower; + &bts->top_acch_cap; const char *mode = NULL; if (top->sacch_enable && top->facch_enable) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39b98dcd14219402959646524315d5afea7c08cf Gerrit-Change-Number: 26239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:18:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:18:54 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: {rep, top}_acch_cap_for_bts(): make *lchan const References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26240 ) Change subject: abis_rsl: {rep,top}_acch_cap_for_bts(): make *lchan const ...................................................................... abis_rsl: {rep,top}_acch_cap_for_bts(): make *lchan const Change-Id: I3e71bb88db7b1eadff5a73fdb98fe7eee2fc2540 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/26240/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index f0cec7b..3a6bec9 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -526,11 +526,11 @@ /* indicate FACCH/SACCH Repetition to be performed by BTS, * see also: 3GPP TS 44.006, section 10 and 11 */ -static void rep_acch_cap_for_bts(struct gsm_lchan *lchan, +static void rep_acch_cap_for_bts(const struct gsm_lchan *lchan, struct msgb *msg) { struct abis_rsl_osmo_rep_acch_cap *cap; - struct gsm_bts *bts = lchan->ts->trx->bts; + const struct gsm_bts *bts = lchan->ts->trx->bts; /* The RSL_IE_OSMO_REP_ACCH_CAP IE is a proprietary IE, that can only * be used with osmo-bts type BTSs */ @@ -554,9 +554,9 @@ } /* indicate Temporary overpower of SACCH and FACCH channels */ -static void top_acch_cap_for_bts(struct gsm_lchan *lchan, struct msgb *msg) +static void top_acch_cap_for_bts(const struct gsm_lchan *lchan, struct msgb *msg) { - struct gsm_bts *bts = lchan->ts->trx->bts; + const struct gsm_bts *bts = lchan->ts->trx->bts; /* The BTS_FEAT_ACCH_TEMP_OVP IE is a proprietary IE, that can only be used with osmo-bts type BTSs */ if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS && osmo_bts_has_feature(&bts->features, BTS_FEAT_ACCH_TEMP_OVP))) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e71bb88db7b1eadff5a73fdb98fe7eee2fc2540 Gerrit-Change-Number: 26240 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:18:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:18:54 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26241 ) Change subject: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g ...................................................................... abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/41/26241/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 3a6bec9..c86234b 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -526,8 +526,8 @@ /* indicate FACCH/SACCH Repetition to be performed by BTS, * see also: 3GPP TS 44.006, section 10 and 11 */ -static void rep_acch_cap_for_bts(const struct gsm_lchan *lchan, - struct msgb *msg) +static void put_rep_acch_cap_ie(const struct gsm_lchan *lchan, + struct msgb *msg) { struct abis_rsl_osmo_rep_acch_cap *cap; const struct gsm_bts *bts = lchan->ts->trx->bts; @@ -554,7 +554,7 @@ } /* indicate Temporary overpower of SACCH and FACCH channels */ -static void top_acch_cap_for_bts(const struct gsm_lchan *lchan, struct msgb *msg) +static void put_top_acch_cap_ie(const struct gsm_lchan *lchan, struct msgb *msg) { const struct gsm_bts *bts = lchan->ts->trx->bts; @@ -699,8 +699,8 @@ } } - rep_acch_cap_for_bts(lchan, msg); - top_acch_cap_for_bts(lchan, msg); + put_rep_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode */ if (lchan->activate.info.vamos && lchan->activate.tsc_set >= 1) @@ -771,8 +771,8 @@ } } - rep_acch_cap_for_bts(lchan, msg); - top_acch_cap_for_bts(lchan, msg); + put_rep_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode. Send this Osmocom specific IE only to OsmoBTS * types. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 Gerrit-Change-Number: 26241 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:20:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:20:27 +0000 Subject: Change in osmo-bsc[master]: [overpower] Allow configuring specific channel mode(s) References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26242 ) Change subject: [overpower] Allow configuring specific channel mode(s) ...................................................................... [overpower] Allow configuring specific channel mode(s) Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts_vty.c M tests/acch_overpower.vty 5 files changed, 79 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/26242/1 diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc index dee0470..7200b0e 100644 --- a/doc/manuals/chapters/power_control.adoc +++ b/doc/manuals/chapters/power_control.adoc @@ -604,9 +604,11 @@ bts 0 overpower dl-acch 2 <1> overpower rxqual 4 <2> + overpower chan-mode any <3> ---- <1> Overpower of maximum 2 dB for both SACCH and FACCH. <2> Enable TOP only if RxQual is worse than 4 (BER >= 1.6%). +<3> Permit TOP for any kinds of dedicated channels. It's also possible to enable TOP only for FACCH or SACCH selectively, or or keep it enabled permanently regardless of the reported RxQual: diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index f582232..8861c32 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -595,6 +595,11 @@ /* ACCH Temporary overpower capabilities */ struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap; + /* Channel mode(s) for which to allow TOP */ + enum { + TOP_ACCH_CHAN_MODE_ANY = 0, /* Any kind of channel mode */ + TOP_ACCH_CHAN_MODE_SPEECH_V3, /* Speech channels using AMR codec */ + } top_acch_chan_mode; /* MS/BS Power Control parameters */ struct gsm_power_ctrl_params ms_power_ctrl; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index c86234b..c9d1369 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -554,7 +554,9 @@ } /* indicate Temporary overpower of SACCH and FACCH channels */ -static void put_top_acch_cap_ie(const struct gsm_lchan *lchan, struct msgb *msg) +static void put_top_acch_cap_ie(const struct gsm_lchan *lchan, + const struct rsl_ie_chan_mode *cm, + struct msgb *msg) { const struct gsm_bts *bts = lchan->ts->trx->bts; @@ -562,6 +564,18 @@ if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS && osmo_bts_has_feature(&bts->features, BTS_FEAT_ACCH_TEMP_OVP))) return; + /* Check if TOP is permitted for the given Channel Mode */ + switch (bts->top_acch_chan_mode) { + case TOP_ACCH_CHAN_MODE_SPEECH_V3: + if (cm->spd_ind != RSL_CMOD_SPD_SPEECH) + return; + if (cm->chan_rate != RSL_CMOD_SP_GSM3) + return; + break; + case TOP_ACCH_CHAN_MODE_ANY: + break; + } + msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(bts->top_acch_cap), (void *)&bts->top_acch_cap); @@ -700,7 +714,7 @@ } put_rep_acch_cap_ie(lchan, msg); - put_top_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, &cm, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode */ if (lchan->activate.info.vamos && lchan->activate.tsc_set >= 1) @@ -772,7 +786,7 @@ } put_rep_acch_cap_ie(lchan, msg); - put_top_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, &cm, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode. Send this Osmocom specific IE only to OsmoBTS * types. */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 8c49be9..f0125f3 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -818,6 +818,34 @@ return CMD_SUCCESS; } +static const struct value_string top_acch_chan_mode_name[] = { + { TOP_ACCH_CHAN_MODE_ANY, "any" }, + { TOP_ACCH_CHAN_MODE_SPEECH_V3, "speech-amr" }, + { 0, NULL } +}; + +DEFUN_USRATTR(cfg_bts_top_dl_acch_chan_mode, + cfg_bts_top_dl_acch_chan_mode_cmd, + X(BSC_VTY_ATTR_NEW_LCHAN), + "overpower chan-mode (speech-amr|any)", + TOP_ACCH_STR + "Allow temporary overpower for specific Channel mode(s)\n" + "Speech channels using AMR codec\n" + "Any kind of channel mode (default)\n") +{ + struct gsm_bts *bts = vty->index; + + if (bts->model->type != GSM_BTS_TYPE_OSMOBTS) { + vty_out(vty, "%% ACCH overpower is not supported by BTS %u%s", + bts->nr, VTY_NEWLINE); + return CMD_WARNING; + } + + bts->top_acch_chan_mode = get_string_value(top_acch_chan_mode_name, argv[0]); + + return CMD_SUCCESS; +} + #define CD_STR "Channel Description\n" DEFUN_USRATTR(cfg_bts_chan_desc_att, @@ -4311,6 +4339,10 @@ mode, top->overpower_db, VTY_NEWLINE); vty_out(vty, " overpower rxqual %u%s", top->rxqual, VTY_NEWLINE); + vty_out(vty, " overpower chan-mode %s%s", + get_value_string(top_acch_chan_mode_name, + bts->top_acch_chan_mode), + VTY_NEWLINE); } if (bts->rep_acch_cap.dl_facch_all) @@ -4531,6 +4563,7 @@ install_element(BTS_NODE, &cfg_bts_top_dl_acch_cmd); install_element(BTS_NODE, &cfg_bts_top_no_dl_acch_cmd); install_element(BTS_NODE, &cfg_bts_top_dl_acch_rxqual_cmd); + install_element(BTS_NODE, &cfg_bts_top_dl_acch_chan_mode_cmd); install_element(BTS_NODE, &cfg_bts_interf_meas_avg_period_cmd); install_element(BTS_NODE, &cfg_bts_interf_meas_level_bounds_cmd); install_element(BTS_NODE, &cfg_bts_srvcc_fast_return_cmd); diff --git a/tests/acch_overpower.vty b/tests/acch_overpower.vty index 0fc8a45..d2b87ef 100644 --- a/tests/acch_overpower.vty +++ b/tests/acch_overpower.vty @@ -12,15 +12,17 @@ . ..l overpower (dl-acch|dl-sacch|dl-facch) <1-4> . ..l no overpower dl-acch . ..l overpower rxqual (0|1|2|3|4|5|6|7) + . ..l overpower chan-mode (speech-amr|any) ... OsmoBSC(config-net-bts)# overpower? overpower Temporary ACCH overpower OsmoBSC(config-net-bts)# overpower ? - dl-acch Enable overpower for both SACCH and FACCH - dl-sacch Enable overpower for SACCH only - dl-facch Enable overpower for FACCH only - rxqual Set RxQual (BER) threshold (default 4) + dl-acch Enable overpower for both SACCH and FACCH + dl-sacch Enable overpower for SACCH only + dl-facch Enable overpower for FACCH only + rxqual Set RxQual (BER) threshold (default 4) + chan-mode Allow temporary overpower for specific Channel mode(s) OsmoBSC(config-net-bts)# overpower dl-acch ? <1-4> Overpower value in dB @@ -29,18 +31,21 @@ ... overpower dl-acch 2 overpower rxqual 4 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower dl-sacch 3 OsmoBSC(config-net-bts)# show running-config ... overpower dl-sacch 3 overpower rxqual 4 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower dl-facch 4 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 4 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower rxqual ? @@ -57,12 +62,25 @@ ... overpower dl-facch 4 overpower rxqual 0 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower rxqual 7 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 7 + overpower chan-mode any +... + +OsmoBSC(config-net-bts)# overpower chan-mode ? + speech-amr Speech channels using AMR codec + any Any kind of channel mode (default) +OsmoBSC(config-net-bts)# overpower chan-mode speech-amr +OsmoBSC(config-net-bts)# show running-config +... + overpower dl-facch 4 + overpower rxqual 7 + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# no overpower dl-acch -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Gerrit-Change-Number: 26242 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:20:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:20:27 +0000 Subject: Change in osmo-bsc[master]: [overpower] By default, permit only for speech channels using AMR References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26243 ) Change subject: [overpower] By default, permit only for speech channels using AMR ...................................................................... [overpower] By default, permit only for speech channels using AMR Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17 Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M tests/acch_overpower.vty 4 files changed, 25 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/26243/1 diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc index 7200b0e..f5f94f6 100644 --- a/doc/manuals/chapters/power_control.adoc +++ b/doc/manuals/chapters/power_control.adoc @@ -604,14 +604,17 @@ bts 0 overpower dl-acch 2 <1> overpower rxqual 4 <2> - overpower chan-mode any <3> + overpower chan-mode speech-amr <3> ---- <1> Overpower of maximum 2 dB for both SACCH and FACCH. <2> Enable TOP only if RxQual is worse than 4 (BER >= 1.6%). -<3> Permit TOP for any kinds of dedicated channels. +<3> Permit TOP only for speech channels using AMR codec. -It's also possible to enable TOP only for FACCH or SACCH selectively, or -or keep it enabled permanently regardless of the reported RxQual: +For advanced use cases, OsmoBSC can be configured to: + +* enable TOP only for FACCH or SACCH selectively, and/or +* keep TOP enabled permanently regardless of the reported RxQual, and/or +* permit TOP for any kind of dedicated channels. ---- OsmoBSC(config-net-bts)# overpower ? @@ -621,6 +624,10 @@ OsmoBSC(config-net-bts)# overpower rxqual 0? 0 BER >= 0% (always on) + +OsmoBSC(config-net-bts)# overpower chan-mode ? + speech-amr Speech channels using AMR codec (default) + any Any kind of channel mode ---- These parameters are indicated to the BTS during a logical channel activation diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 0fdb636..8af1254 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -401,6 +401,9 @@ bts->rep_acch_cap.rxqual = 4; bts->top_acch_cap.rxqual = 4; + /* Permit ACCH overpower only for speech channels using AMR */ + bts->top_acch_chan_mode = TOP_ACCH_CHAN_MODE_SPEECH_V3; + /* MS Power Control parameters (defaults) */ power_ctrl_params_def_reset(&bts->ms_power_ctrl, GSM_PWR_CTRL_DIR_UL); diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index f0125f3..33e026c 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -830,8 +830,8 @@ "overpower chan-mode (speech-amr|any)", TOP_ACCH_STR "Allow temporary overpower for specific Channel mode(s)\n" - "Speech channels using AMR codec\n" - "Any kind of channel mode (default)\n") + "Speech channels using AMR codec (default)\n" + "Any kind of channel mode\n") { struct gsm_bts *bts = vty->index; diff --git a/tests/acch_overpower.vty b/tests/acch_overpower.vty index d2b87ef..70090a4 100644 --- a/tests/acch_overpower.vty +++ b/tests/acch_overpower.vty @@ -31,21 +31,21 @@ ... overpower dl-acch 2 overpower rxqual 4 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower dl-sacch 3 OsmoBSC(config-net-bts)# show running-config ... overpower dl-sacch 3 overpower rxqual 4 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower dl-facch 4 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 4 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower rxqual ? @@ -62,25 +62,25 @@ ... overpower dl-facch 4 overpower rxqual 0 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower rxqual 7 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 7 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower chan-mode ? - speech-amr Speech channels using AMR codec - any Any kind of channel mode (default) -OsmoBSC(config-net-bts)# overpower chan-mode speech-amr + speech-amr Speech channels using AMR codec (default) + any Any kind of channel mode +OsmoBSC(config-net-bts)# overpower chan-mode any OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 7 - overpower chan-mode speech-amr + overpower chan-mode any ... OsmoBSC(config-net-bts)# no overpower dl-acch -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17 Gerrit-Change-Number: 26243 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:45:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:45:49 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26238 to look at the new patch set (#2). Change subject: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g ...................................................................... struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g Let's have a short and consistent naming for both ACCH repetition and temporary ACCH overpower structures, like it's done in osmo-bts. Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Related: Ib1d51f91139b4c2fe794e37fc8543b2d7a9b9c07 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c 4 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/26238/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Gerrit-Change-Number: 26238 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:45:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:45:50 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26244 ) Change subject: abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() ...................................................................... abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() The linter (executed by Jenkins) complains: src/osmo-bsc/abis_rsl.c:543: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" and blocks changes, adding V-1 when I am changing the related code. Change-Id: I0cf00ff898e69734850659e8ba0e2ff023f9b2dd --- M src/osmo-bsc/abis_rsl.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/26244/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index f7a2de7..d596fdd 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -540,7 +540,7 @@ cap = (struct abis_rsl_osmo_rep_acch_cap*) msg->tail; msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(*cap), - (uint8_t*) &bts->repeated_acch_policy); + (uint8_t *)&bts->repeated_acch_policy); if (!(lchan->conn && lchan->conn->cm3_valid && lchan->conn->cm3.repeated_acch_capability)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0cf00ff898e69734850659e8ba0e2ff023f9b2dd Gerrit-Change-Number: 26244 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:45:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:45:50 +0000 Subject: Change in osmo-bsc[master]: bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26245 ) Change subject: bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch ...................................................................... bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch The linter (executed by Jenkins) complains: src/osmo-bsc/bts_vty.c:653: ERROR:CODE_INDENT: code indent should use tabs where possible src/osmo-bsc/bts_vty.c:654: ERROR:CODE_INDENT: code indent should use tabs where possible src/osmo-bsc/bts_vty.c:656: ERROR:CODE_INDENT: code indent should use tabs where possible src/osmo-bsc/bts_vty.c:657: ERROR:CODE_INDENT: code indent should use tabs where possible and blocks changes, adding V-1 when I am changing the related code. Change-Id: If3c8c09ddff7cb945425e74344ceb4da989ddffc --- M src/osmo-bsc/bts_vty.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/26245/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 8c2b100..1306a03 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -650,11 +650,11 @@ } if (!strcmp(argv[0], "command")) { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = false; + bts->repeated_acch_policy.dl_facch_cmd = true; + bts->repeated_acch_policy.dl_facch_all = false; } else { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = true; + bts->repeated_acch_policy.dl_facch_cmd = true; + bts->repeated_acch_policy.dl_facch_all = true; } return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3c8c09ddff7cb945425e74344ceb4da989ddffc Gerrit-Change-Number: 26245 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:59:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:59:17 +0000 Subject: Change in osmo-sgsn[master]: tests/Makefile.am: do not try removing non-existing files References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 ) Change subject: tests/Makefile.am: do not try removing non-existing files ...................................................................... tests/Makefile.am: do not try removing non-existing files Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b --- M tests/Makefile.am 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/46/26246/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index cb6d343..6c4a0a0 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -54,7 +54,7 @@ osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count + rm -f $(top_builddir)/gtphub_restart_count # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: @@ -64,7 +64,6 @@ -n OsmoSGSN -p 4245 \ -r "$(top_builddir)/src/sgsn/osmo-sgsn -c $(top_srcdir)/doc/examples/osmo-sgsn/osmo-sgsn.cfg" \ $(U) $${T:-$(srcdir)/osmo-sgsn*.vty} - rm -f $(builddir)/sms.db $(builddir)/gsn_restart # don't run multiple tests concurrently so that the ports don't conflict vty-test: @@ -73,7 +72,7 @@ ctrl-python-test: $(BUILT_SOURCES) $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count + rm -f $(top_builddir)/gtphub_restart_count check-local: atconfig $(TESTSUITE) $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b Gerrit-Change-Number: 26246 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 21:59:21 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 21:59:21 +0000 Subject: Change in osmo-bsc[master]: tests/Makefile.am: do not try removing non-existing files References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26247 ) Change subject: tests/Makefile.am: do not try removing non-existing files ...................................................................... tests/Makefile.am: do not try removing non-existing files Change-Id: I4be60c858cea891aa49fd9b8ca1dec9a6e3fc305 --- M tests/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/26247/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index aefaae8..c2d348b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -62,7 +62,6 @@ osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count else python-tests: $(BUILT_SOURCES) echo "Not running python-based tests (determined at configure-time)" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4be60c858cea891aa49fd9b8ca1dec9a6e3fc305 Gerrit-Change-Number: 26247 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 22:09:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 22:09:40 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26241 to look at the new patch set (#3). Change subject: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g ...................................................................... abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/41/26241/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 Gerrit-Change-Number: 26241 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 14 22:09:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Nov 2021 22:09:40 +0000 Subject: Change in osmo-bsc[master]: [overpower] Allow configuring specific channel mode(s) In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26242 to look at the new patch set (#3). Change subject: [overpower] Allow configuring specific channel mode(s) ...................................................................... [overpower] Allow configuring specific channel mode(s) Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts_vty.c M tests/acch_overpower.vty 5 files changed, 79 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/26242/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Gerrit-Change-Number: 26242 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 01:33:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 01:33:36 +0000 Subject: Change in libosmocore[master]: rate_ctr: Make it safe to call rate_ctr_init() several times In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26235 ) Change subject: rate_ctr: Make it safe to call rate_ctr_init() several times ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f5342a77518599eb5ac9a0f0605917a78fcc387 Gerrit-Change-Number: 26235 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 01:33:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 01:37:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 01:37:49 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 01:37:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 01:40:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 01:40:02 +0000 Subject: Change in osmo-sgsn[master]: tests/Makefile.am: do not try removing non-existing files In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 to look at the new patch set (#2). Change subject: tests/Makefile.am: do not try removing non-existing files ...................................................................... tests/Makefile.am: do not try removing non-existing files Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b --- M tests/Makefile.am 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/46/26246/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b Gerrit-Change-Number: 26246 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Nov 15 08:10:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 15 Nov 2021 08:10:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61921617a2a92_1d822b20f0f6e5f01037542@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 230s] building additional files... [ 230s] checking if compiling is necessary... [ 230s] the output file doesn't exist [ 230s] pdflatex -interaction=batchmode rtp-amr.tex [ 230s] pdflatex failed [ 230s] [ 230s] A possible reason for transformation failure is invalid DocBook [ 230s] (as reported by xmllint) [ 230s] [ 230s] Error: pdflatex compilation failed [ 230s] [ 230s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 230s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 230s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 230s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 230s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 230s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 230s] make[1]: *** [Makefile:375: all] Error 2 [ 230s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 230s] dh_auto_build: error: make -j1 returned exit code 2 [ 230s] make: *** [debian/rules:12: build] Error 25 [ 230s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 230s] ### VM INTERACTION START ### [ 231s] Powering off. [ 231s] [ 221.997961] reboot: Power down [ 231s] ### VM INTERACTION END ### [ 231s] [ 231s] goat17 failed "build osmo-bts_1.3.0.348.f422.202111150026.dsc" at Mon Nov 15 08:10:43 UTC 2021. [ 231s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 15 08:16:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 15 Nov 2021 08:16:47 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <619217807998c_1d822b20f0f6e5f010381b7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 436s] building additional files... [ 436s] checking if compiling is necessary... [ 436s] the output file doesn't exist [ 436s] pdflatex -interaction=batchmode rtp-amr.tex [ 436s] pdflatex failed [ 436s] [ 436s] A possible reason for transformation failure is invalid DocBook [ 436s] (as reported by xmllint) [ 436s] [ 436s] Error: pdflatex compilation failed [ 436s] [ 436s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 436s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 436s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 436s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 436s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 436s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 436s] make[1]: *** [Makefile:375: all] Error 2 [ 436s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 436s] dh_auto_build: error: make -j1 returned exit code 2 [ 436s] make: *** [debian/rules:12: build] Error 25 [ 436s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 436s] ### VM INTERACTION START ### [ 437s] Powering off. [ 437s] [ 417.592181] reboot: Power down [ 437s] ### VM INTERACTION END ### [ 437s] [ 437s] lamb05 failed "build osmo-bts_1.3.0.348.f422.202111150026.dsc" at Mon Nov 15 08:16:41 UTC 2021. [ 437s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 15 08:25:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 15 Nov 2021 08:25:00 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <619219631aff8_1d822b20f0f6e5f0103950@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 426s] building additional files... [ 426s] checking if compiling is necessary... [ 426s] the output file doesn't exist [ 426s] pdflatex -interaction=batchmode rtp-amr.tex [ 426s] pdflatex failed [ 426s] [ 426s] A possible reason for transformation failure is invalid DocBook [ 426s] (as reported by xmllint) [ 426s] [ 426s] Error: pdflatex compilation failed [ 426s] [ 426s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 426s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 426s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 426s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 426s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 426s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 426s] make[1]: *** [Makefile:371: all] Error 2 [ 426s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 426s] dh_auto_build: error: make -j1 returned exit code 2 [ 426s] make: *** [debian/rules:12: build] Error 25 [ 426s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 426s] ### VM INTERACTION START ### [ 427s] Powering off. [ 428s] [ 411.695569] reboot: Power down [ 428s] ### VM INTERACTION END ### [ 428s] [ 428s] lamb16 failed "build osmo-bts_1.3.3.dsc" at Mon Nov 15 08:24:57 UTC 2021. [ 428s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Nov 15 08:25:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 15 Nov 2021 08:25:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6192199bbcd1f_1d822b20f0f6e5f01040676@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 303s] building additional files... [ 303s] checking if compiling is necessary... [ 303s] the output file doesn't exist [ 303s] pdflatex -interaction=batchmode rtp-amr.tex [ 303s] pdflatex failed [ 303s] [ 303s] A possible reason for transformation failure is invalid DocBook [ 303s] (as reported by xmllint) [ 303s] [ 303s] Error: pdflatex compilation failed [ 303s] [ 303s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 303s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 303s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 303s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 303s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 303s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 303s] make[1]: *** [Makefile:371: all] Error 2 [ 303s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 303s] dh_auto_build: error: make -j1 returned exit code 2 [ 303s] make: *** [debian/rules:12: build] Error 25 [ 303s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 303s] ### VM INTERACTION START ### [ 304s] Powering off. [ 304s] [ 293.926959] reboot: Power down [ 305s] ### VM INTERACTION END ### [ 305s] [ 305s] build73 failed "build osmo-bts_1.3.3.dsc" at Mon Nov 15 08:25:36 UTC 2021. [ 305s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:51:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:51:39 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 to look at the new patch set (#2). Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... stp: Add basic RX/TX rate counters on AS and ASP level This adds some very basic rx/px rate counters to the SS7 AS and ASP OsmoSTP> show rate-counters SIGTRAN Application Server 0 (as-rkm-1): rx:msu:total: 86078 (1888/s 86078/m 0/h 0/d) tx:msu:total: 0 (0/s 0/m 0/h 0/d) SIGTRAN Application Server Process 0 (asp-dyn-0): rx:packets:total: 86081 (1888/s 86081/m 0/h 0/d) tx:packets:total: 5 (0/s 5/m 0/h 0/d) Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 --- M include/osmocom/sigtran/osmo_ss7.h M src/ipa.c M src/m3ua.c M src/osmo_ss7.c M src/osmo_ss7_hmrt.c M src/ss7_internal.h M src/sua.c M stp/stp_main.c 8 files changed, 83 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/34/26234/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:51:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:51:56 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/1/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/1/src/osmo_ss7.c at 1154 PS1, Line 1154: [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "" }, > same Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 08:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:57:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:57:33 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: fix wrong CI in the inter-BSC handover diagram In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26232 ) Change subject: doc/manuals: fix wrong CI in the inter-BSC handover diagram ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e351e802311d4601579c2e755ca13a9056348 Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 08:57:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:57:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:57:35 +0000 Subject: Change in osmo-bsc[master]: doc/manuals: fix wrong CI in the inter-BSC handover diagram In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26232 ) Change subject: doc/manuals: fix wrong CI in the inter-BSC handover diagram ...................................................................... doc/manuals: fix wrong CI in the inter-BSC handover diagram The 'bts0' in BSS 'Beta' has LAC=42/CI=3. There is no LAC=42/CI=6. Change-Id: I0f2e351e802311d4601579c2e755ca13a9056348 --- M doc/manuals/chapters/handover_inter_bsc.dot 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/handover_inter_bsc.dot b/doc/manuals/chapters/handover_inter_bsc.dot index 42decef..3ff8093 100644 --- a/doc/manuals/chapters/handover_inter_bsc.dot +++ b/doc/manuals/chapters/handover_inter_bsc.dot @@ -27,7 +27,7 @@ {BSC_a,BSC_b} -> MSC [arrowhead=none,label=A] -BSC_a -> MSC [label="(6) --> Handover Required\nto LAC=42 CI=6\n(10) <-- Handover Command",style=dashed,constraint=false,arrowhead=none] +BSC_a -> MSC [label="(6) --> Handover Required\nto LAC=42 CI=3\n(10) <-- Handover Command",style=dashed,constraint=false,arrowhead=none] MSC -> BSC_b [label="(7) <-- Handover Request\n(9) --> Handover Request ACK",style=dashed,constraint=false,arrowhead=none] BSC_b -> BTS_b0 [label="(8) activate new lchan",style=dashed,constraint=false] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e351e802311d4601579c2e755ca13a9056348 Gerrit-Change-Number: 26232 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:57:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:57:59 +0000 Subject: Change in libosmocore[master]: rate_ctr: Make it safe to call rate_ctr_init() several times In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26235 ) Change subject: rate_ctr: Make it safe to call rate_ctr_init() several times ...................................................................... rate_ctr: Make it safe to call rate_ctr_init() several times There might be library code that has rate counters, and if the main program calls rate_ctr_init() a second time, we can skip the second initialization. Change-Id: I6f5342a77518599eb5ac9a0f0605917a78fcc387 --- M src/rate_ctr.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/rate_ctr.c b/src/rate_ctr.c index 4d99699..283858d 100644 --- a/src/rate_ctr.c +++ b/src/rate_ctr.c @@ -354,6 +354,10 @@ * \returns 0 on success; negative on error */ int rate_ctr_init(void *tall_ctx) { + /* ignore repeated initialization */ + if (osmo_timer_pending(&rate_ctr_timer)) + return 0; + tall_rate_ctr_ctx = tall_ctx; osmo_timer_setup(&rate_ctr_timer, rate_ctr_timer_cb, NULL); osmo_timer_schedule(&rate_ctr_timer, 1, 0); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f5342a77518599eb5ac9a0f0605917a78fcc387 Gerrit-Change-Number: 26235 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:58:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:58:26 +0000 Subject: Change in osmo-sgsn[master]: tests/Makefile.am: do not try removing non-existing files In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 ) Change subject: tests/Makefile.am: do not try removing non-existing files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b Gerrit-Change-Number: 26246 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 08:58:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:58:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:58:29 +0000 Subject: Change in osmo-sgsn[master]: tests/Makefile.am: do not try removing non-existing files In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 ) Change subject: tests/Makefile.am: do not try removing non-existing files ...................................................................... tests/Makefile.am: do not try removing non-existing files Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b --- M tests/Makefile.am 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index cb6d343..c3dc695 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -54,7 +54,7 @@ osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count + rm -f $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: @@ -64,7 +64,7 @@ -n OsmoSGSN -p 4245 \ -r "$(top_builddir)/src/sgsn/osmo-sgsn -c $(top_srcdir)/doc/examples/osmo-sgsn/osmo-sgsn.cfg" \ $(U) $${T:-$(srcdir)/osmo-sgsn*.vty} - rm -f $(builddir)/sms.db $(builddir)/gsn_restart + rm -f $(builddir)/gsn_restart # don't run multiple tests concurrently so that the ports don't conflict vty-test: @@ -73,7 +73,7 @@ ctrl-python-test: $(BUILT_SOURCES) $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count + rm -f $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count check-local: atconfig $(TESTSUITE) $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b Gerrit-Change-Number: 26246 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:59:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:59:32 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: simplify checking if channel mode is AMR In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26236 ) Change subject: abis_rsl: simplify checking if channel mode is AMR ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If933ce0fa0a162c4518ddab840f186ebaa1bcff9 Gerrit-Change-Number: 26236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 08:59:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:59:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:59:41 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26244 ) Change subject: abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0cf00ff898e69734850659e8ba0e2ff023f9b2dd Gerrit-Change-Number: 26244 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 08:59:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 08:59:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 08:59:52 +0000 Subject: Change in osmo-bsc[master]: bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26245 ) Change subject: bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3c8c09ddff7cb945425e74344ceb4da989ddffc Gerrit-Change-Number: 26245 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 08:59:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:00:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:00:13 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: simplify comments for ACCH repetition/overpower In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26237 ) Change subject: struct gsm_bts: simplify comments for ACCH repetition/overpower ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75b0e289c47841aea22b5966487535cbe855c84f Gerrit-Change-Number: 26237 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:00:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:00:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:00:52 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26238 ) Change subject: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g ...................................................................... Patch Set 2: Code-Review+1 not really sure if this patch serves much purpose, but ok, if the BTS calls it differently... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Gerrit-Change-Number: 26238 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:00:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:01:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:01:06 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/temporary_overpower/top_acch_cap/g In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26239 ) Change subject: struct gsm_bts: s/temporary_overpower/top_acch_cap/g ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39b98dcd14219402959646524315d5afea7c08cf Gerrit-Change-Number: 26239 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:01:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:01:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:01:16 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: {rep, top}_acch_cap_for_bts(): make *lchan const In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26240 ) Change subject: abis_rsl: {rep,top}_acch_cap_for_bts(): make *lchan const ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e71bb88db7b1eadff5a73fdb98fe7eee2fc2540 Gerrit-Change-Number: 26240 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:01:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:01:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:01:47 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26241 ) Change subject: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 Gerrit-Change-Number: 26241 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:01:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:02:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:02:14 +0000 Subject: Change in osmo-bsc[master]: [overpower] Allow configuring specific channel mode(s) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26242 ) Change subject: [overpower] Allow configuring specific channel mode(s) ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Gerrit-Change-Number: 26242 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:02:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:05:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:05:03 +0000 Subject: Change in osmo-bsc[master]: [overpower] By default, permit only for speech channels using AMR In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26243 ) Change subject: [overpower] By default, permit only for speech channels using AMR ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17 Gerrit-Change-Number: 26243 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:05:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:05:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:05:51 +0000 Subject: Change in osmo-bsc[master]: tests/Makefile.am: do not try removing non-existing files In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26247 ) Change subject: tests/Makefile.am: do not try removing non-existing files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4be60c858cea891aa49fd9b8ca1dec9a6e3fc305 Gerrit-Change-Number: 26247 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 09:05:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:05:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:05:53 +0000 Subject: Change in osmo-bsc[master]: tests/Makefile.am: do not try removing non-existing files In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26247 ) Change subject: tests/Makefile.am: do not try removing non-existing files ...................................................................... tests/Makefile.am: do not try removing non-existing files Change-Id: I4be60c858cea891aa49fd9b8ca1dec9a6e3fc305 --- M tests/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index aefaae8..c2d348b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -62,7 +62,6 @@ osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count else python-tests: $(BUILT_SOURCES) echo "Not running python-based tests (determined at configure-time)" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4be60c858cea891aa49fd9b8ca1dec9a6e3fc305 Gerrit-Change-Number: 26247 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:06:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:06:03 +0000 Subject: Change in libosmocore[master]: add osmo_time_cc, moved from osmo-bsc In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26230 ) Change subject: add osmo_time_cc, moved from osmo-bsc ...................................................................... add osmo_time_cc, moved from osmo-bsc Related: SYS#4878 Related: Ica9f908a1a30f334a24c59471affa11225117e12 (osmo-bsc) Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd --- M include/Makefile.am A include/osmocom/core/time_cc.h M src/Makefile.am A src/time_cc.c M tests/Makefile.am M tests/testsuite.at A tests/time_cc/time_cc_test.c A tests/time_cc/time_cc_test.ok 8 files changed, 1,527 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/Makefile.am b/include/Makefile.am index 49402d0..e3246cf 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -60,6 +60,7 @@ osmocom/core/utils.h \ osmocom/core/write_queue.h \ osmocom/core/sockaddr_str.h \ + osmocom/core/time_cc.h \ osmocom/core/use_count.h \ osmocom/crypt/auth.h \ osmocom/crypt/gprs_cipher.h \ diff --git a/include/osmocom/core/time_cc.h b/include/osmocom/core/time_cc.h new file mode 100644 index 0000000..36fdee4 --- /dev/null +++ b/include/osmocom/core/time_cc.h @@ -0,0 +1,187 @@ +/*! \file time_cc.h + * Report the cumulative counter of time for which a flag is true as rate counter. + */ +/* Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH + * + * All Rights Reserved + * + * Author: Neels Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +#include + +/*! \defgroup time_cc Cumulative counter of time as rate counter. + * @{ + * \file time_cc.h + */ + +struct osmo_tdef; +struct rate_ctr; + +/*! Configuration for osmo_time_cc. + * Report the cumulative counter of time for which a flag is true as rate counter. + * For example, for each second that the flag is true, increment a rate counter. + * + * The flag to be monitored is reported by osmo_time_cc_set_flag(). + * + * The granularity defines how much time one rate counter increment represents: + * the default configuration is gran_usec = 1000000, i.e. one rate counter increment represents one second. + * + * Reporting as rate counter is configurable by round_threshold_usec and forget_sum_usec, examples: + * + * round_threshold_usec: + * - To get "ceil()" behavior, set round_threshold_usec = 1. This increments the rate counter for each gran_usec period + * where the flag was seen true, even if it was true for only a very short fraction of a gran_usec period. + * - To get "round()" behavior, set round_threshold_usec = half of gran_usec. The rate counter increments when the flag + * has been true for 0.5 of a gran_usec (and then again at 1.5 * gran_usec) of 'true' flag. round_threshold_usec = 0 + * is a special value that means to use half of gran_usec. + * - To get "floor()" behavior, set round_threshold_usec >= gran_usec. The rate counter increments when reaching full + * gran_usec periods of the flag being true. + * + * forget_sum_usec: + * This is a tradeoff between the accuracy of the reported rate counter and making sure that the events reported are not + * irrelevantly long ago. + * - To keep sub-granularity-period surplus time forever, set forget_sum_usec = 0. + * - To keep surplus time for up to a minute, set forget_sum_usec = 60000000 (60 seconds). + * - To get rid of "leftover" time (almost) immediately after the flag goes false, set forget_sum_usec = 1. + * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a + * possible inaccuracy of 1/60th, but makes sure that no timings older than a minute affect the current reports. + * + * Reporting modes in detail: + * + * The rate_ctr increments when the cumulative counter passes round_threshold_usec (default: half of gran_usec). + * + * sum ^ + * | ________ + * | / + * | / + * | / + * 3*gran --+--------------------------------------+ + * | /: + * | / : + * | - - - - - - - - - - - - - - - - - / : + * | /. : + * | / . : + * 2*gran --+--------------------------------+ . : + * | /: . : + * | / : . : + * | - - - - - - - - - -_________/ : . : + * | / . : . : + * | / . : . : + * 1*gran --+-----------------+ . : . : + * | /: . : . : + * | / : . : . : + * | - - - - - - -/ : . : . : + * | /. : . : . : + * | ....-------' . : . : . : + * 0 +------------------------------------------------------------------------> elapsed time + * . : . : . : + * _ _ _______ ____________ + * flag: __| |_| |____| . : |_______|. : . : |__________ + * f t f t f t . : f t. : . : f + * round_threshold_usec : . : . : . : + * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" + * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" + * >= gran_usec: 0 1 2 3 = "floor()" + * + */ +struct osmo_time_cc_cfg { + /*! Granularity in microseconds: nr of microseconds that one rate_ctr increment represents. A typical value is + * gran_usec = 1000000, meaning one rate counter increment represents one second. When zero, use 1000000. */ + uint64_t gran_usec; + /*! Nr of microseconds above n * gran_usec at which to trigger a counter increment. When zero, use half a + * gran_usec. */ + uint64_t round_threshold_usec; + /*! Forget counted sub-gran time after the flag was false for this long. */ + uint64_t forget_sum_usec; + /*! Rate counter to report to, or NULL to not use it. */ + struct rate_ctr *rate_ctr; + + /*! Update gran_usec from this T timer value, or zero to not use any T timer. */ + int T_gran; + /*! Update round_threshold_usec from this T timer value, or zero to not use any T timer. */ + int T_round_threshold; + /*! Update forget_sum_usec from this T timer value, or zero to not use any T timer. */ + int T_forget_sum; + /*! Look up T_gran and T_forget_sum in this list of timers, or NULL to not use any T timers. */ + struct osmo_tdef *T_defs; +}; + +/*! Report the cumulative counter of time for which a flag is true as rate counter. + * See also osmo_time_cc_cfg for details on configuring. + * + * Usage: + * + * struct my_obj { + * struct osmo_time_cc flag_cc; + * }; + * + * void my_obj_init(struct my_obj *my_obj) + * { + * osmo_time_cc_init(&my_obj->flag_cc); + * my_obj->flag_cc.cfg = (struct osmo_time_cc_cfg){ + * .gran_usec = 1000000, + * .forget_sum_usec = 60000000, + * .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, MY_CTR_IDX), + * }; + * // optional: set initial flag state, default is 'false': + * // osmo_time_cc_set_flag(&my_obj->flag_cc, false); + * } + * + * void my_obj_event(struct my_obj *my_obj, bool flag) + * { + * osmo_time_cc_set_flag(&my_obj->flag_cc, flag); + * } + * + * void my_obj_destruct(struct my_obj *my_obj) + * { + * osmo_time_cc_cleanup(&my_obj->flag_cc); + * } + */ +struct osmo_time_cc { + struct osmo_time_cc_cfg cfg; + + bool flag_state; + + /*! Overall cumulative sum. Does not get reset for the entire lifetime of an osmo_time_cc. + * (Informational only, not used by the osmo_time_cc implementation.) */ + uint64_t total_sum; + + struct osmo_timer_list timer; + + /*! CLOCK_MONOTONIC reading in microseconds, at the time when the osmo_time_cc instance started counting. */ + uint64_t start_time; + /*! CLOCK_MONOTONIC reading in microseconds, at the time when the osmo_time_cc last evaluated the flag state and + * possibly added to the cumulated sum. */ + uint64_t last_counted_time; + + /*! Internal cumulative counter of time that flag_state was true. It may get reset to zero regularly, depending + * on cfg.forget_sum_usec. This is the basis for incrementing cfg.rate_ctr. */ + uint64_t sum; + /*! The amount of time that already reported cfg.rate_ctr increments account for. This may be ahead of or behind + * 'sum', depending on cfg.round_threshold_usec. */ + uint64_t reported_sum; +}; + +void osmo_time_cc_init(struct osmo_time_cc *tc); +void osmo_time_cc_set_flag(struct osmo_time_cc *tc, bool flag); +void osmo_time_cc_cleanup(struct osmo_time_cc *tc); + +/*! @} */ diff --git a/src/Makefile.am b/src/Makefile.am index 328d2c7..6875aa5 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -26,6 +26,7 @@ isdnhdlc.c \ tdef.c \ thread.c \ + time_cc.c \ sockaddr_str.c \ use_count.c \ exec.c \ diff --git a/src/time_cc.c b/src/time_cc.c new file mode 100644 index 0000000..ae99b58 --- /dev/null +++ b/src/time_cc.c @@ -0,0 +1,229 @@ +/*! \file foo.c + * Report the cumulative counter of time for which a flag is true as rate counter. + */ +/* Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH + * + * All Rights Reserved + * + * Author: Neels Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +/*! \addtogroup time_cc + * + * Report the cumulative counter of time for which a flag is true as rate counter. + * + * Useful for reporting cumulative time counters as defined in 3GPP TS 52.402, for example allAvailableSDCCHAllocated, + * allAvailableTCHAllocated, availablePDCHAllocatedTime. + * + * For a usage example, see the description of struct osmo_time_cc. + * + * @{ + * \file time_cc.c + */ +#include "config.h" +#ifdef HAVE_CLOCK_GETTIME + +#include +#include + +#include +#include +#include + +#define GRAN_USEC(TIME_CC) ((TIME_CC)->cfg.gran_usec ? : 1000000) +#define ROUND_THRESHOLD_USEC(TIME_CC) ((TIME_CC)->cfg.round_threshold_usec ? \ + OSMO_MIN((TIME_CC)->cfg.round_threshold_usec, GRAN_USEC(TIME_CC)) \ + : (GRAN_USEC(TIME_CC) / 2)) + +static uint64_t time_now_usec() +{ + struct timespec tp; + if (osmo_clock_gettime(CLOCK_MONOTONIC, &tp)) + return 0; + return (uint64_t)tp.tv_sec * 1000000 + tp.tv_nsec / 1000; +} + +static void osmo_time_cc_forget_sum(struct osmo_time_cc *tc, uint64_t now); + +static void osmo_time_cc_update_from_tdef(struct osmo_time_cc *tc, uint64_t now) +{ + bool do_forget_sum = false; + if (!tc->cfg.T_defs) + return; + if (tc->cfg.T_gran) { + uint64_t was = GRAN_USEC(tc); + tc->cfg.gran_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_gran, OSMO_TDEF_US, -1); + if (was != GRAN_USEC(tc)) + do_forget_sum = true; + } + if (tc->cfg.T_round_threshold) + tc->cfg.round_threshold_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_round_threshold, + OSMO_TDEF_US, -1); + if (tc->cfg.T_forget_sum) { + uint64_t was = tc->cfg.forget_sum_usec; + tc->cfg.forget_sum_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_forget_sum, OSMO_TDEF_US, -1); + if (tc->cfg.forget_sum_usec && was != tc->cfg.forget_sum_usec) + do_forget_sum = true; + } + + if (do_forget_sum && tc->sum) + osmo_time_cc_forget_sum(tc, now); +} + +static void osmo_time_cc_schedule_timer(struct osmo_time_cc *tc, uint64_t now); + +/*! Clear out osmo_timer and internal counting state of struct osmo_time_cc. The .cfg remains unaffected. After calling, + * the osmo_time_cc instance can be used again to accumulate state as if it had just been initialized. */ +void osmo_time_cc_cleanup(struct osmo_time_cc *tc) +{ + osmo_timer_del(&tc->timer); + *tc = (struct osmo_time_cc){ + .cfg = tc->cfg, + }; +} + +static void osmo_time_cc_start(struct osmo_time_cc *tc, uint64_t now) +{ + osmo_time_cc_cleanup(tc); + tc->start_time = now; + tc->last_counted_time = now; + osmo_time_cc_update_from_tdef(tc, now); + osmo_time_cc_schedule_timer(tc, now); +} + +static void osmo_time_cc_count_time(struct osmo_time_cc *tc, uint64_t now) +{ + uint64_t time_delta = now - tc->last_counted_time; + tc->last_counted_time = now; + if (!tc->flag_state) + return; + /* Flag is currently true, cumulate the elapsed time */ + tc->total_sum += time_delta; + tc->sum += time_delta; +} + +static void osmo_time_cc_report(struct osmo_time_cc *tc, uint64_t now) +{ + uint64_t delta; + uint64_t n; + if (!tc->cfg.rate_ctr) + return; + /* We report a sum "rounded up", ahead of time. If the granularity period has not yet elapsed after the last + * reporting, do not report again yet. */ + if (tc->reported_sum > tc->sum) + return; + delta = tc->sum - tc->reported_sum; + /* elapsed full periods */ + n = delta / GRAN_USEC(tc); + /* If the delta has passed round_threshold (normally half of gran_usec), increment. */ + delta -= n * GRAN_USEC(tc); + if (delta >= ROUND_THRESHOLD_USEC(tc)) + n++; + if (!n) + return; + + /* integer sanity, since rate_ctr_add() takes an int argument. */ + if (n > INT_MAX) + n = INT_MAX; + rate_ctr_add(tc->cfg.rate_ctr, n); + /* Store the increments of gran_usec that were counted. */ + tc->reported_sum += n * GRAN_USEC(tc); +} + +static void osmo_time_cc_forget_sum(struct osmo_time_cc *tc, uint64_t now) +{ + tc->reported_sum = 0; + tc->sum = 0; + + if (tc->last_counted_time < now) + tc->last_counted_time = now; +} + +/*! Initialize struct osmo_time_cc. Call this once before use, and before setting up the .cfg items. */ +void osmo_time_cc_init(struct osmo_time_cc *tc) +{ + *tc = (struct osmo_time_cc){0}; +} + +/*! Report state to be recorded by osmo_time_cc instance. Setting an unchanged state repeatedly has no effect. */ +void osmo_time_cc_set_flag(struct osmo_time_cc *tc, bool flag) +{ + uint64_t now = time_now_usec(); + if (!tc->start_time) + osmo_time_cc_start(tc, now); + /* No flag change == no effect */ + if (flag == tc->flag_state) + return; + /* Sum up elapsed time, report increments for that. */ + osmo_time_cc_count_time(tc, now); + osmo_time_cc_report(tc, now); + tc->flag_state = flag; + osmo_time_cc_schedule_timer(tc, now); +} + +static void osmo_time_cc_timer_cb(void *data) +{ + struct osmo_time_cc *tc = data; + uint64_t now = time_now_usec(); + + osmo_time_cc_update_from_tdef(tc, now); + + if (tc->flag_state) { + osmo_time_cc_count_time(tc, now); + osmo_time_cc_report(tc, now); + } else if (tc->cfg.forget_sum_usec && tc->sum + && (now >= tc->last_counted_time + tc->cfg.forget_sum_usec)) { + osmo_time_cc_forget_sum(tc, now); + } + osmo_time_cc_schedule_timer(tc, now); +} + +/*! Figure out the next time we should do anything, if the flag state remains unchanged. */ +static void osmo_time_cc_schedule_timer(struct osmo_time_cc *tc, uint64_t now) +{ + uint64_t next_event = UINT64_MAX; + + osmo_time_cc_update_from_tdef(tc, now); + + /* If it is required, when will the next forget_sum happen? */ + if (tc->cfg.forget_sum_usec && !tc->flag_state && tc->sum > 0) { + uint64_t next_forget_time = tc->last_counted_time + tc->cfg.forget_sum_usec; + next_event = OSMO_MIN(next_event, next_forget_time); + } + /* Next rate_ctr increment? */ + if (tc->flag_state && tc->cfg.rate_ctr) { + uint64_t next_inc = now + (tc->reported_sum - tc->sum) + ROUND_THRESHOLD_USEC(tc); + next_event = OSMO_MIN(next_event, next_inc); + } + + /* No event coming up? */ + if (next_event == UINT64_MAX) + return; + + if (next_event <= now) + next_event = 0; + else + next_event -= now; + + osmo_timer_setup(&tc->timer, osmo_time_cc_timer_cb, tc); + osmo_timer_del(&tc->timer); + osmo_timer_schedule(&tc->timer, next_event / 1000000, next_event % 1000000); +} + +#endif /* HAVE_CLOCK_GETTIME */ + +/*! @} */ diff --git a/tests/Makefile.am b/tests/Makefile.am index b72619f..c44b6f0 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -42,6 +42,7 @@ bsslap/bsslap_test \ bssmap_le/bssmap_le_test \ it_q/it_q_test \ + time_cc/time_cc_test \ gsm48/rest_octets_test \ base64/base64_test \ $(NULL) @@ -324,6 +325,9 @@ it_q_it_q_test_SOURCES = it_q/it_q_test.c it_q_it_q_test_LDADD = $(LDADD) +time_cc_time_cc_test_SOURCES = time_cc/time_cc_test.c +time_cc_time_cc_test_LDADD = $(LDADD) + # The `:;' works around a Bash 3.2 bug when the output is not writeable. $(srcdir)/package.m4: $(top_srcdir)/configure.ac :;{ \ @@ -413,6 +417,7 @@ bsslap/bsslap_test.ok \ bssmap_le/bssmap_le_test.ok \ it_q/it_q_test.ok \ + time_cc/time_cc_test.ok \ gsm48/rest_octets_test.ok \ base64/base64_test.ok \ $(NULL) @@ -609,6 +614,8 @@ >$(srcdir)/bssmap_le/bssmap_le_test.ok it_q/it_q_test \ >$(srcdir)/it_q/it_q_test.ok + time_cc/time_cc_test \ + >$(srcdir)/time_cc/time_cc_test.ok check-local: atconfig $(TESTSUITE) [ -e /proc/cpuinfo ] && cat /proc/cpuinfo diff --git a/tests/testsuite.at b/tests/testsuite.at index 6ac5970..975b51e 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -452,3 +452,9 @@ cat $abs_srcdir/base64/base64_test.ok > expout AT_CHECK([$abs_top_builddir/tests/base64/base64_test], [0], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([time_cc]) +AT_KEYWORDS([time_cc]) +cat $abs_srcdir/time_cc/time_cc_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/time_cc/time_cc_test], [0], [expout], [ignore]) +AT_CLEANUP diff --git a/tests/time_cc/time_cc_test.c b/tests/time_cc/time_cc_test.c new file mode 100644 index 0000000..22ea7f6 --- /dev/null +++ b/tests/time_cc/time_cc_test.c @@ -0,0 +1,768 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Neels Janosch Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include + +#include +#include +#include +#include +#include +#include +#include + +enum my_ctrs { + CTR_CEIL, + CTR_ROUND, + CTR_FLOOR, +}; + +const struct rate_ctr_desc my_ctr_desc[] = { + [CTR_CEIL] = {"ceil", "testing round_threshold_usec = 1"}, + [CTR_ROUND] = {"round", "testing round_threshold_usec = 0 = gran_usec/2"}, + [CTR_FLOOR] = {"floor", "testing round_threshold_usec = gran_usec"}, +}; + +const struct rate_ctr_group_desc my_ctrg_desc = { + "time_cc_test", + "Counters for osmo_time_cc test", + 0, + ARRAY_SIZE(my_ctr_desc), + my_ctr_desc, +}; + +struct rate_ctr_group *my_ctrg; + + +enum my_obj_timers { + T_GRAN = -23, + T_ROUND_THRESH = -24, + T_FORGET_SUM = -25, +}; + +struct osmo_tdef g_my_obj_tdefs[] = { + { .T = T_GRAN, .default_val = 0, .unit = OSMO_TDEF_MS, .desc = "flag_cc granularity, or zero for 1 second" }, + { .T = T_ROUND_THRESH, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "flag_cc rounding threshold, or zero for half a granularity" }, + { .T = T_FORGET_SUM, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "flag_cc inactivity forget period, or zero to not forget any timings" }, + {} +}; + + +struct my_obj { + struct osmo_time_cc flag_cc_ceil; + struct osmo_time_cc flag_cc_round; + struct osmo_time_cc flag_cc_floor; +}; + +void my_obj_init(struct my_obj *my_obj) +{ + osmo_time_cc_init(&my_obj->flag_cc_ceil); + my_obj->flag_cc_ceil.cfg = (struct osmo_time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_CEIL), + .round_threshold_usec = 1, + .T_gran = T_GRAN, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; + + osmo_time_cc_init(&my_obj->flag_cc_round); + my_obj->flag_cc_round.cfg = (struct osmo_time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_ROUND), + .T_gran = T_GRAN, + .T_round_threshold = T_ROUND_THRESH, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; + + osmo_time_cc_init(&my_obj->flag_cc_floor); + my_obj->flag_cc_floor.cfg = (struct osmo_time_cc_cfg){ + .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_FLOOR), + .round_threshold_usec = UINT64_MAX, /* always >= gran_usec */ + .T_gran = T_GRAN, + .T_forget_sum = T_FORGET_SUM, + .T_defs = g_my_obj_tdefs, + }; +} + +void my_obj_event(struct my_obj *my_obj, bool flag) +{ + osmo_time_cc_set_flag(&my_obj->flag_cc_ceil, flag); + osmo_time_cc_set_flag(&my_obj->flag_cc_round, flag); + osmo_time_cc_set_flag(&my_obj->flag_cc_floor, flag); +} + +void my_obj_destruct(struct my_obj *my_obj) +{ + osmo_time_cc_cleanup(&my_obj->flag_cc_ceil); + osmo_time_cc_cleanup(&my_obj->flag_cc_round); + osmo_time_cc_cleanup(&my_obj->flag_cc_floor); +} + +static const struct log_info_cat log_categories[] = { +}; + +static const struct log_info log_info = { + .cat = log_categories, + .num_cat = ARRAY_SIZE(log_categories), +}; + +int main() +{ + void *ctx = talloc_named_const(NULL, 0, "time_cc_test"); + struct timespec *now; + struct my_obj my_obj = {0}; + + osmo_init_logging2(ctx, &log_info); + + /* enable override for CLOCK_MONOTONIC */ + osmo_clock_override_enable(CLOCK_MONOTONIC, true); + now = osmo_clock_override_gettimespec(CLOCK_MONOTONIC); + now->tv_sec = 23000; + now->tv_nsec = 0; + + /* enable override for osmo_gettimeofday(), for osmo_timer_schedule() */ + osmo_gettimeofday_override = true; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_ctrg = rate_ctr_group_alloc(ctx, &my_ctrg_desc, 0); + +#define CHECK_RATE_CTRS(exp_ceil, exp_round, exp_floor) do { \ + printf("%d CHECK_RATE_CTRS(" #exp_ceil ", " #exp_round ", " #exp_floor ")", \ + my_obj.flag_cc_round.flag_state); \ + while (osmo_select_main_ctx(1) > 0); \ + if (exp_ceil != my_obj.flag_cc_ceil.cfg.rate_ctr->current \ + || exp_round != my_obj.flag_cc_round.cfg.rate_ctr->current \ + || exp_floor != my_obj.flag_cc_floor.cfg.rate_ctr->current) \ + printf("\n ERROR on line %d: ctr_ceil=%"PRIu64" ctr_round=%"PRIu64" ctr_floor=%"PRIu64"\n", \ + __LINE__, \ + my_obj.flag_cc_ceil.cfg.rate_ctr->current, \ + my_obj.flag_cc_round.cfg.rate_ctr->current, \ + my_obj.flag_cc_floor.cfg.rate_ctr->current); \ + else \ + printf(" ok\n"); \ + } while (0) + +#define ADD_MILLISECS_NO_SELECT(ms) do { \ + osmo_clock_override_add(CLOCK_MONOTONIC, ms / 1000, (uint64_t)(ms % 1000) * 1000000); \ + osmo_gettimeofday_override_add(ms / 1000, (uint64_t)(ms % 1000) * 1000); \ + printf("%d ADD_MILLISECS(" #ms ") --> %ld.%03ld", my_obj.flag_cc_round.flag_state, \ + now->tv_sec, now->tv_nsec/1000000); \ + printf("\n"); \ + } while (0) + +#define ADD_MILLISECS(ms) do { \ + ADD_MILLISECS_NO_SELECT(ms); \ + while (osmo_select_main_ctx(1) > 0); \ + } while (0) + +#define FLAG(VAL) do { \ + printf(" flag: %s -> %s\n", my_obj.flag_cc_round.flag_state ? "TRUE" : "FALSE", VAL ? "TRUE" : "FALSE"); \ + my_obj_event(&my_obj, VAL); \ + } while (0) + + /* + * sum ^ + * | ________ + * | / + * | / + * | / + * 3*gran --+--------------------------------------+ + * | /: + * | / : + * | - - - - - - - - - - - - - - - - - / : + * | /. : + * | / . : + * 2*gran --+--------------------------------+ . : + * | /: . : + * | / : . : + * | - - - - - - - - - -_________/ : . : + * | / . : . : + * | / . : . : + * 1*gran --+-----------------+ . : . : + * | /: . : . : + * | / : . : . : + * | - - - - - - -/ : . : . : + * | /. : . : . : + * | ....-------' . : . : . : + * 0 +----------------------------------------------------------> elapsed time + * . : . : . : + * _ _ _______ ____________ + * flag: __| |_| |____| . : |_______|. : . : |__________ + * f t f t f t . : f t. : . : f + * round_threshold_usec : . : . : . : + * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" + * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" + * = gran_usec: 0 1 2 3 = "floor()" + */ + + printf("\n----------- cumulating time, without forget_sum\n\n"); + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.001s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(99); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(100); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(100); + /* flag has been true for 0.2s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(300); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(299); + /* flag has been true for 0.499s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.5s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(499); + /* flag has been true for 0.999s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(1); + /* flag has been true for 1.0s */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* flag has been true for 1.001s */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(299); + /* flag has been true for 1.3s */ + CHECK_RATE_CTRS(2, 1, 1); + FLAG(false); + CHECK_RATE_CTRS(2, 1, 1); + + ADD_MILLISECS(400); + + CHECK_RATE_CTRS(2, 1, 1); + FLAG(true); + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(199); + /* flag has been true for 1.499s */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(2); + /* flag has been true for 1.501s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(498); + /* flag has been true for 1.999s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(2); + /* flag has been true for 2.001s */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(500); + /* flag has been true for 2.501s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(498); + /* flag has been true for 2.999s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(3); + /* flag has been true for 3.003s */ + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(200); + /* flag has been true for 3.203s */ + CHECK_RATE_CTRS(4, 3, 3); + FLAG(false); + CHECK_RATE_CTRS(4, 3, 3); + + ADD_MILLISECS(4321); + CHECK_RATE_CTRS(4, 3, 3); + + FLAG(true); + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(5678); + CHECK_RATE_CTRS(9, 9, 8); + FLAG(false); + CHECK_RATE_CTRS(9, 9, 8); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + printf("\n----------- test forget_sum_usec\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); + + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(1000); + /* 1 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(8999); + /* 9.999 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS(1); + /* 10 s of being false, forget_sum_usec has occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* Since previous sums were forgotton, ceil() triggers again */ + CHECK_RATE_CTRS(2, 0, 0); + /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify + * that this does not occur, since now full 500 ms are required */ + ADD_MILLISECS(399); + CHECK_RATE_CTRS(2, 0, 0); + /* Adding another 100 ms will trigger round() */ + ADD_MILLISECS(99); + CHECK_RATE_CTRS(2, 0, 0); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(2, 1, 0); + /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify + * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ + ADD_MILLISECS(400); + CHECK_RATE_CTRS(2, 1, 0); + /* Adding another 100 ms will trigger floor() */ + ADD_MILLISECS(99); + CHECK_RATE_CTRS(2, 1, 0); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(2, 1, 1); + + /* Test that durations of false below forget_sum_usec never trigger a forget */ + ADD_MILLISECS(300); + CHECK_RATE_CTRS(3, 1, 1); + /* internal counter is now at 0.3s above the last reported rate counter */ + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + FLAG(false); + ADD_MILLISECS(9999); + FLAG(true); + ADD_MILLISECS(25); + /* internal counter is now at 0.4s above the last reported rate counter */ + CHECK_RATE_CTRS(3, 1, 1); + ADD_MILLISECS(100); + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS(500); + CHECK_RATE_CTRS(3, 2, 2); + + /* Test that repeated osmo_time_cc_set_flag(false) does not cancel a forget_sum_usec */ + ADD_MILLISECS(300); + /* internal counter is now at 0.3s above the last reported rate counter */ + CHECK_RATE_CTRS(4, 2, 2); + FLAG(false); + ADD_MILLISECS(5000); + /* Repeat 'false', must not affect forget_sum_usec */ + FLAG(false); + ADD_MILLISECS(5000); + CHECK_RATE_CTRS(4, 2, 2); + /* 10 s have passed, forget_sum_usec has occurred. + * Hence ceil() will trigger again right away: */ + FLAG(true); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 2, 2); + /* Adding 200 ms to the initial 300 ms would have triggered round(), but no more after forget_sum_usec */ + ADD_MILLISECS(199); + CHECK_RATE_CTRS(5, 2, 2); + /* Adding another 300 ms will trigger round() */ + ADD_MILLISECS(299); + CHECK_RATE_CTRS(5, 2, 2); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 3, 2); + /* Adding 700 ms to the initial 300 ms would have triggered ceil(), but no more after forget_sum_usec */ + ADD_MILLISECS(200); + CHECK_RATE_CTRS(5, 3, 2); + /* Adding another 300 ms will trigger ceil() */ + ADD_MILLISECS(299); + CHECK_RATE_CTRS(5, 3, 2); + ADD_MILLISECS(1); + CHECK_RATE_CTRS(5, 3, 3); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + + /* Verify correctness when select() lags and runs timer callbacks too late */ + printf("\n----------- cumulating time, without forget_sum, when timer cb are invoked late\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 0, OSMO_TDEF_S); + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS_NO_SELECT(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(100); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.2s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(300); + + CHECK_RATE_CTRS(1, 0, 0); + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(799); + /* flag has been true for 0.999s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 1.0s */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS_NO_SELECT(300); + /* flag has been true for 1.3s */ + CHECK_RATE_CTRS(2, 1, 1); + FLAG(false); + CHECK_RATE_CTRS(2, 1, 1); + + ADD_MILLISECS_NO_SELECT(400); + + CHECK_RATE_CTRS(2, 1, 1); + FLAG(true); + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS_NO_SELECT(699); + /* flag has been true for 1.999s */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 2.0s */ + CHECK_RATE_CTRS(2, 2, 2); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 2.001s */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS_NO_SELECT(499); + /* flag has been true for 2.5s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS_NO_SELECT(499); + /* flag has been true for 2.999s */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS_NO_SELECT(1); + /* flag has been true for 3.0s */ + CHECK_RATE_CTRS(3, 3, 3); + ADD_MILLISECS_NO_SELECT(200); + /* flag has been true for 3.2s */ + CHECK_RATE_CTRS(4, 3, 3); + FLAG(false); + CHECK_RATE_CTRS(4, 3, 3); + + ADD_MILLISECS_NO_SELECT(4321); + CHECK_RATE_CTRS(4, 3, 3); + + FLAG(true); + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS_NO_SELECT(5678); + CHECK_RATE_CTRS(9, 9, 8); + FLAG(false); + CHECK_RATE_CTRS(9, 9, 8); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + + printf("\n----------- test forget_sum, when timer cb are invoked late\n\n"); + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); + + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + my_obj_init(&my_obj); + + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS_NO_SELECT(100); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 0, 0); + FLAG(false); + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(1000); + /* 1 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(8999); + /* 9.999 s of being false, forget_sum_usec has not yet occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + ADD_MILLISECS_NO_SELECT(1); + /* 10 s of being false, forget_sum_usec has occurred */ + CHECK_RATE_CTRS(1, 0, 0); + + FLAG(true); + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS_NO_SELECT(1); + /* Since previous sums were forgotton, ceil() triggers again */ + CHECK_RATE_CTRS(2, 0, 0); + /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify + * that this does not occur, since now full 500 ms are required */ + ADD_MILLISECS_NO_SELECT(399); + CHECK_RATE_CTRS(2, 0, 0); + /* Adding another 100 ms will trigger round() */ + ADD_MILLISECS_NO_SELECT(99); + CHECK_RATE_CTRS(2, 0, 0); + ADD_MILLISECS_NO_SELECT(1); + CHECK_RATE_CTRS(2, 1, 0); + /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify + * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ + ADD_MILLISECS_NO_SELECT(400); + CHECK_RATE_CTRS(2, 1, 0); + /* Adding another 100 ms will trigger floor() */ + ADD_MILLISECS_NO_SELECT(99); + CHECK_RATE_CTRS(2, 1, 0); + ADD_MILLISECS_NO_SELECT(1); + CHECK_RATE_CTRS(2, 1, 1); + + /* Test that durations of false below forget_sum_usec never trigger a forget */ + ADD_MILLISECS_NO_SELECT(300); + CHECK_RATE_CTRS(3, 1, 1); + /* internal counter is now at 0.3s above the last reported rate counter */ + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + FLAG(false); + ADD_MILLISECS_NO_SELECT(9999); + FLAG(true); + ADD_MILLISECS_NO_SELECT(25); + /* internal counter is now at 0.4s above the last reported rate counter */ + CHECK_RATE_CTRS(3, 1, 1); + ADD_MILLISECS_NO_SELECT(100); + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS_NO_SELECT(500); + CHECK_RATE_CTRS(3, 2, 2); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + +#define SET_TDEFS(gran, round_thresh, forget_sum) do { \ + osmo_tdef_set(g_my_obj_tdefs, T_GRAN, gran, OSMO_TDEF_MS); \ + osmo_tdef_set(g_my_obj_tdefs, T_ROUND_THRESH, round_thresh, OSMO_TDEF_MS); \ + osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, forget_sum, OSMO_TDEF_S); \ + printf("T_defs: T_gran=%luusec T_round_threshold=%luusec T_forget_sum=%luusec\n", \ + osmo_tdef_get(g_my_obj_tdefs, T_GRAN, OSMO_TDEF_US, -1), \ + osmo_tdef_get(g_my_obj_tdefs, T_ROUND_THRESH, OSMO_TDEF_US, -1), \ + osmo_tdef_get(g_my_obj_tdefs, T_FORGET_SUM, OSMO_TDEF_US, -1)); \ + } while (0) + + printf("\n----------- test T_defs\n\n"); + now->tv_sec = 23000; + now->tv_nsec = 0; + osmo_gettimeofday_override_time = (struct timeval){23000, 0}; + + SET_TDEFS(100, 10, 0); + + my_obj_init(&my_obj); + CHECK_RATE_CTRS(0, 0, 0); + + ADD_MILLISECS(100); + CHECK_RATE_CTRS(0, 0, 0); + + FLAG(true); + /* flag has just turned true the first time */ + CHECK_RATE_CTRS(0, 0, 0); + ADD_MILLISECS(9); + /* flag has been true for 0.009s */ + CHECK_RATE_CTRS(1, 0, 0); + ADD_MILLISECS(1); + /* flag has been true for 0.010s */ + CHECK_RATE_CTRS(1, 1, 0); + ADD_MILLISECS(90); + /* flag has been true for 0.1s */ + CHECK_RATE_CTRS(1, 1, 1); + + SET_TDEFS(200, 190, 1); + /* gran is changed to 200ms, but still continues until the next scheduled event until the change is picked up. + * For ceil(), it is 1 ms ahead. + * For round(), it is 10 ms ahead. + * For floor(), it is at the next full (previous) gran 100 ms ahead. + * When T_defs change, all internal sums are reset to zero without reporting. + */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* 1ms elapsed: ceil() picks up the T_gran change, starts anew. */ + /* elapsed: ceil 0 ms */ + CHECK_RATE_CTRS(1, 1, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 1 ms */ + /* ceil() increments because flag has been true for more than 1 us after reset */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(8); + /* 10 ms elapsed: round() picks up the T_gran change, starts anew */ + /* elapsed: ceil 9 ms, round 0 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(90); + /* 100 ms elapsed: floor() picks up the T_gran change, starts anew */ + /* elapsed: ceil 99 ms, round 90 ms, floor 0 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(99); + /* elapsed: ceil 198 ms, round 189 ms, floor 99 ms */ + CHECK_RATE_CTRS(2, 1, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 199 ms, round 190 ms, floor 100 ms */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 200 ms, round 191 ms, floor 101 ms */ + CHECK_RATE_CTRS(2, 2, 1); + ADD_MILLISECS(1); + /* elapsed: ceil 201 ms, round 192 ms, floor 102 ms */ + CHECK_RATE_CTRS(3, 2, 1); + ADD_MILLISECS(98); + /* elapsed: ceil 299 ms, round 290 ms, floor 200 ms */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(99); + /* elapsed: ceil 398 ms, round 389 ms, floor 299 ms */ + CHECK_RATE_CTRS(3, 2, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 399 ms, round 390 ms, floor 300 ms */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 400 ms, round 391 ms, floor 301 ms */ + CHECK_RATE_CTRS(3, 3, 2); + ADD_MILLISECS(1); + /* elapsed: ceil 401 ms, round 392 ms, floor 302 ms */ + CHECK_RATE_CTRS(4, 3, 2); + ADD_MILLISECS(98); + /* elapsed: ceil 499 ms, round 490 ms, floor 400 ms */ + CHECK_RATE_CTRS(4, 3, 3); + + + SET_TDEFS(100, 0, 0); + /* T_defs change, but they only get picked up upon the next event: + * For ceil(), it is 102 ms ahead. + * For round(), it is 100 ms ahead (thresh is still 190, currently at 90). + * For floor(), it is 200 ms ahead. + * When T_defs change, all internal sums are reset to zero without reporting. + */ + CHECK_RATE_CTRS(4, 3, 3); + ADD_MILLISECS(100); + CHECK_RATE_CTRS(4, 3, 3); + /* round() picks up the new T_defs. Internal sum resets, nothing else happens yet. + * round() schedules the next event 50 ms ahead. */ + ADD_MILLISECS(2); + CHECK_RATE_CTRS(4, 3, 3); + /* ceil() picks up the change, its next event is 1 ms ahead. */ + ADD_MILLISECS(1); + /* ceil: 0.001 + * round: 0.003 + * floor: still 97 ms until it picks up the change */ + CHECK_RATE_CTRS(5, 3, 3); + ADD_MILLISECS(46); + CHECK_RATE_CTRS(5, 3, 3); + ADD_MILLISECS(1); + /* round() has first counter trigger after T_defs change. */ + CHECK_RATE_CTRS(5, 4, 3); + /* ceil: 0.048 + * round: 0.050 + * floor: still 50 ms until it picks up the change */ + ADD_MILLISECS(50); + /* floor() picks up the change. nothing happens yet. */ + /* ceil: 0.098 + * round: 0.100 + * floor: 0.0 */ + ADD_MILLISECS(2); + /* ceil: 0.100 + * round: 0.102 + * floor: 0.002 */ + CHECK_RATE_CTRS(5, 4, 3); + ADD_MILLISECS(1); + /* ceil: 0.101 + * round: 0.103 + * floor: 0.003 */ + CHECK_RATE_CTRS(6, 4, 3); + ADD_MILLISECS(46); + /* ceil: 0.147 + * round: 0.149 + * floor: 0.049 */ + CHECK_RATE_CTRS(6, 4, 3); + ADD_MILLISECS(1); + /* ceil: 0.148 + * round: 0.150 + * floor: 0.050 */ + CHECK_RATE_CTRS(6, 5, 3); + + my_obj_destruct(&my_obj); + rate_ctr_group_reset(my_ctrg); + + return 0; +} diff --git a/tests/time_cc/time_cc_test.ok b/tests/time_cc/time_cc_test.ok new file mode 100644 index 0000000..ccf84d9 --- /dev/null +++ b/tests/time_cc/time_cc_test.ok @@ -0,0 +1,328 @@ + +----------- cumulating time, without forget_sum + +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(1) --> 23000.101 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(99) --> 23000.200 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.300 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.400 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(300) --> 23000.700 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(299) --> 23000.999 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23001.000 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(499) --> 23001.499 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(1) --> 23001.500 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23001.501 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(299) --> 23001.800 +1 CHECK_RATE_CTRS(2, 1, 1) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(2, 1, 1) ok +0 ADD_MILLISECS(400) --> 23002.200 +0 CHECK_RATE_CTRS(2, 1, 1) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(199) --> 23002.399 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(2) --> 23002.401 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(498) --> 23002.899 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(2) --> 23002.901 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(500) --> 23003.401 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(498) --> 23003.899 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(3) --> 23003.902 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(200) --> 23004.102 +1 CHECK_RATE_CTRS(4, 3, 3) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(4, 3, 3) ok +0 ADD_MILLISECS(4321) --> 23008.423 +0 CHECK_RATE_CTRS(4, 3, 3) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(5678) --> 23014.101 +1 CHECK_RATE_CTRS(9, 9, 8) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(9, 9, 8) ok + +----------- test forget_sum_usec + +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.100 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1000) --> 23001.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(8999) --> 23010.099 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1) --> 23010.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.101 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(399) --> 23010.500 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(99) --> 23010.599 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.600 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(400) --> 23011.000 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(99) --> 23011.099 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(1) --> 23011.100 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(300) --> 23011.400 +1 CHECK_RATE_CTRS(3, 1, 1) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23021.399 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23021.424 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23031.423 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23031.448 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23041.447 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23041.472 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23051.471 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23051.496 +1 CHECK_RATE_CTRS(3, 1, 1) ok +1 ADD_MILLISECS(100) --> 23051.596 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(500) --> 23052.096 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(300) --> 23052.396 +1 CHECK_RATE_CTRS(4, 2, 2) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(5000) --> 23057.396 + flag: FALSE -> FALSE +0 ADD_MILLISECS(5000) --> 23062.396 +0 CHECK_RATE_CTRS(4, 2, 2) ok + flag: FALSE -> TRUE +1 ADD_MILLISECS(1) --> 23062.397 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(199) --> 23062.596 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(299) --> 23062.895 +1 CHECK_RATE_CTRS(5, 2, 2) ok +1 ADD_MILLISECS(1) --> 23062.896 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(200) --> 23063.096 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(299) --> 23063.395 +1 CHECK_RATE_CTRS(5, 3, 2) ok +1 ADD_MILLISECS(1) --> 23063.396 +1 CHECK_RATE_CTRS(5, 3, 3) ok + +----------- cumulating time, without forget_sum, when timer cb are invoked late + +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.200 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.300 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.400 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(300) --> 23000.700 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(799) --> 23001.499 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(1) --> 23001.500 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(300) --> 23001.800 +1 CHECK_RATE_CTRS(2, 1, 1) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(2, 1, 1) ok +0 ADD_MILLISECS(400) --> 23002.200 +0 CHECK_RATE_CTRS(2, 1, 1) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(699) --> 23002.899 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23002.900 +1 CHECK_RATE_CTRS(2, 2, 2) ok +1 ADD_MILLISECS(1) --> 23002.901 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(499) --> 23003.400 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(499) --> 23003.899 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23003.900 +1 CHECK_RATE_CTRS(3, 3, 3) ok +1 ADD_MILLISECS(200) --> 23004.100 +1 CHECK_RATE_CTRS(4, 3, 3) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(4, 3, 3) ok +0 ADD_MILLISECS(4321) --> 23008.421 +0 CHECK_RATE_CTRS(4, 3, 3) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(5678) --> 23014.099 +1 CHECK_RATE_CTRS(9, 9, 8) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(9, 9, 8) ok + +----------- test forget_sum, when timer cb are invoked late + +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(100) --> 23000.100 +1 CHECK_RATE_CTRS(1, 0, 0) ok + flag: TRUE -> FALSE +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1000) --> 23001.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(8999) --> 23010.099 +0 CHECK_RATE_CTRS(1, 0, 0) ok +0 ADD_MILLISECS(1) --> 23010.100 +0 CHECK_RATE_CTRS(1, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.101 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(399) --> 23010.500 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(99) --> 23010.599 +1 CHECK_RATE_CTRS(2, 0, 0) ok +1 ADD_MILLISECS(1) --> 23010.600 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(400) --> 23011.000 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(99) --> 23011.099 +1 CHECK_RATE_CTRS(2, 1, 0) ok +1 ADD_MILLISECS(1) --> 23011.100 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(300) --> 23011.400 +1 CHECK_RATE_CTRS(3, 1, 1) ok + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23021.399 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23021.424 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23031.423 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23031.448 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23041.447 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23041.472 + flag: TRUE -> FALSE +0 ADD_MILLISECS(9999) --> 23051.471 + flag: FALSE -> TRUE +1 ADD_MILLISECS(25) --> 23051.496 +1 CHECK_RATE_CTRS(3, 1, 1) ok +1 ADD_MILLISECS(100) --> 23051.596 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(500) --> 23052.096 +1 CHECK_RATE_CTRS(3, 2, 2) ok + +----------- test T_defs + +T_defs: T_gran=100000usec T_round_threshold=10000usec T_forget_sum=0usec +0 CHECK_RATE_CTRS(0, 0, 0) ok +0 ADD_MILLISECS(100) --> 23000.100 +0 CHECK_RATE_CTRS(0, 0, 0) ok + flag: FALSE -> TRUE +1 CHECK_RATE_CTRS(0, 0, 0) ok +1 ADD_MILLISECS(9) --> 23000.109 +1 CHECK_RATE_CTRS(1, 0, 0) ok +1 ADD_MILLISECS(1) --> 23000.110 +1 CHECK_RATE_CTRS(1, 1, 0) ok +1 ADD_MILLISECS(90) --> 23000.200 +1 CHECK_RATE_CTRS(1, 1, 1) ok +T_defs: T_gran=200000usec T_round_threshold=190000usec T_forget_sum=1000000usec +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.201 +1 CHECK_RATE_CTRS(1, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.202 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(8) --> 23000.210 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(90) --> 23000.300 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(99) --> 23000.399 +1 CHECK_RATE_CTRS(2, 1, 1) ok +1 ADD_MILLISECS(1) --> 23000.400 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23000.401 +1 CHECK_RATE_CTRS(2, 2, 1) ok +1 ADD_MILLISECS(1) --> 23000.402 +1 CHECK_RATE_CTRS(3, 2, 1) ok +1 ADD_MILLISECS(98) --> 23000.500 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(99) --> 23000.599 +1 CHECK_RATE_CTRS(3, 2, 2) ok +1 ADD_MILLISECS(1) --> 23000.600 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23000.601 +1 CHECK_RATE_CTRS(3, 3, 2) ok +1 ADD_MILLISECS(1) --> 23000.602 +1 CHECK_RATE_CTRS(4, 3, 2) ok +1 ADD_MILLISECS(98) --> 23000.700 +1 CHECK_RATE_CTRS(4, 3, 3) ok +T_defs: T_gran=100000usec T_round_threshold=0usec T_forget_sum=0usec +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(100) --> 23000.800 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(2) --> 23000.802 +1 CHECK_RATE_CTRS(4, 3, 3) ok +1 ADD_MILLISECS(1) --> 23000.803 +1 CHECK_RATE_CTRS(5, 3, 3) ok +1 ADD_MILLISECS(46) --> 23000.849 +1 CHECK_RATE_CTRS(5, 3, 3) ok +1 ADD_MILLISECS(1) --> 23000.850 +1 CHECK_RATE_CTRS(5, 4, 3) ok +1 ADD_MILLISECS(50) --> 23000.900 +1 ADD_MILLISECS(2) --> 23000.902 +1 CHECK_RATE_CTRS(5, 4, 3) ok +1 ADD_MILLISECS(1) --> 23000.903 +1 CHECK_RATE_CTRS(6, 4, 3) ok +1 ADD_MILLISECS(46) --> 23000.949 +1 CHECK_RATE_CTRS(6, 4, 3) ok +1 ADD_MILLISECS(1) --> 23000.950 +1 CHECK_RATE_CTRS(6, 5, 3) ok -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd Gerrit-Change-Number: 26230 Gerrit-PatchSet: 7 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:07:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:07:07 +0000 Subject: Change in osmo-e1d[master]: make compile-time default logging configuration less verbose In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26228 ) Change subject: make compile-time default logging configuration less verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I909affb3b798c13950f95628275a6ec3a38c76ca Gerrit-Change-Number: 26228 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Mon, 15 Nov 2021 09:07:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:07:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:07:09 +0000 Subject: Change in osmo-e1d[master]: make compile-time default logging configuration less verbose In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26228 ) Change subject: make compile-time default logging configuration less verbose ...................................................................... make compile-time default logging configuration less verbose As Keith pointed out we shouldn't spam the stderr with debug level logging by default. Change-Id: I909affb3b798c13950f95628275a6ec3a38c76ca --- M src/log.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve tnt: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/log.c b/src/log.c index c50efe5..e2b90dc 100644 --- a/src/log.c +++ b/src/log.c @@ -30,12 +30,12 @@ static const struct log_info_cat default_categories[] = { [DE1D] = { .name = "DE1D", - .loglevel = LOGL_DEBUG, + .loglevel = LOGL_INFO, .enabled = 1, }, [DXFR] = { .name = "DXFR", - .loglevel = LOGL_DEBUG, + .loglevel = LOGL_NOTICE, .enabled = 1, }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I909affb3b798c13950f95628275a6ec3a38c76ca Gerrit-Change-Number: 26228 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:07:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:07:38 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Nov 2021 09:07:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:08:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:08:43 +0000 Subject: Change in osmo-mgw[master]: fix up some docstrings that lost their dot In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26188 ) Change subject: fix up some docstrings that lost their dot ...................................................................... fix up some docstrings that lost their dot Change-Id: I88333c165f1dc11ae29f4c1726c15656386d1f0e --- M src/libosmo-mgcp/mgcp_endp.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 247baac..a41e0d0 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -224,9 +224,9 @@ } /*! Find an endpoint of a trunk specified by its name. - * \param[in] epname endpoint name to check - * \param[in] trunk mgcp_trunk that might have this endpoint - * \returns NULL if no ep found, else endpoint */ + * \param[in] epname endpoint name to check. + * \param[in] trunk mgcp_trunk that might have this endpoint. + * \returns NULL if no ep found, else endpoint. */ struct mgcp_endpoint *mgcp_endp_find_specific(const char *epname, const struct mgcp_trunk *trunk) { -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I88333c165f1dc11ae29f4c1726c15656386d1f0e Gerrit-Change-Number: 26188 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:38:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 09:38:00 +0000 Subject: Change in libosmo-sccp[master]: spelling fixes in comments References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 ) Change subject: spelling fixes in comments ...................................................................... spelling fixes in comments Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f --- M src/ipa.c M src/m3ua.c M src/osmo_ss7.c M src/sccp_sclc.c M src/sccp_scoc.c M src/sccp_scrc.c 6 files changed, 21 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/48/26248/1 diff --git a/src/ipa.c b/src/ipa.c index 5b1eb54..8daa5e0 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -135,7 +135,7 @@ { struct osmo_ss7_as *as; - /* in the IPA case, weassume there is a 1:1 mapping between the + /* in the IPA case, we assume there is a 1:1 mapping between the * ASP and the AS. An AS without ASP means there is no * connection, and an ASP without AS means that we don't (yet?) * know the identity of the peer */ @@ -301,7 +301,7 @@ OSMO_ASSERT(asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA); /* osmo_ipa_process_msg() will already have verified length - * consistency and set up l2h poiter */ + * consistency and set up l2h pointer */ hh = (struct ipaccess_head *) msg->l1h; switch (hh->proto) { diff --git a/src/m3ua.c b/src/m3ua.c index 26acc1b..741063c 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -449,7 +449,7 @@ } /*********************************************************************** - * Transmitting M3UA messsages to SCTP + * Transmitting M3UA messages to SCTP ***********************************************************************/ /* Convert M3UA from xua_msg to msgb and set PPID/stream */ @@ -512,7 +512,7 @@ } /*********************************************************************** - * Receiving M3UA messsages from SCTP + * Receiving M3UA messages from SCTP ***********************************************************************/ /* obtain the destination point code from a M3UA message in XUA fmt * */ @@ -694,7 +694,7 @@ OSMO_ASSERT(asp->cfg.proto == OSMO_SS7_ASP_PROT_M3UA); /* caller owns msg memory, we shall neither free it here nor - * keep references beyond the executin of this function and its + * keep references beyond the execution of this function and its * callees */ xua = xua_from_msg(M3UA_VERSION, msgb_length(msg), msgb_data(msg)); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 22e3c37..be39f8e 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -615,7 +615,7 @@ * SS7 Link ***********************************************************************/ -/*! \brief Destryo SS7 Link +/*! \brief Destroy SS7 Link * \param[in] link SS7 Link to be destroyed */ void osmo_ss7_link_destroy(struct osmo_ss7_link *link) { @@ -897,7 +897,7 @@ ***********************************************************************/ static const struct rate_ctr_desc ss7_as_rcd[] = { - [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU receivved" }, + [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU received" }, [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "Total number of MSU transmitted" }, }; @@ -999,7 +999,7 @@ * \param[in] inst SS7 Instance on which we operate * \param[in] name Name of Application Server * \param[in] proto Protocol of Application Server - * \returns pointer to Application Server on suuccess; NULL otherwise */ + * \returns pointer to Application Server on success; NULL otherwise */ struct osmo_ss7_as * osmo_ss7_as_find_or_create(struct osmo_ss7_instance *inst, const char *name, enum osmo_ss7_asp_protocol proto) @@ -1201,7 +1201,7 @@ * \param[in] talloc_ctx talloc context used to allocate new addresses. * \param[in] hosts Array of strings containing IP addresses. * \param[in] host_cnt Number of strings in hosts - * \returns 0 on success; negtive otherwise */ + * \returns 0 on success; negative otherwise */ int osmo_ss7_asp_peer_set_hosts(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char* const* hosts, size_t host_cnt) { int i = 0; @@ -1231,7 +1231,7 @@ } /*! \brief Append (copy) address to a given ASP peer. Previous addresses are kept. - * \param[in] peer Application Server Process peer the address is appened to. + * \param[in] peer Application Server Process peer the address is appended to. * \param[in] talloc_ctx talloc context used to allocate new address. * \param[in] host string containing an IP addresses. * \returns 0 on success; negative otherwise */ diff --git a/src/sccp_sclc.c b/src/sccp_sclc.c index 218fb56..186efbd 100644 --- a/src/sccp_sclc.c +++ b/src/sccp_sclc.c @@ -36,7 +36,7 @@ * However, all SCCP features can be expressed in SUA. * * The code only supports Class 2. No support for Class 3 is intended, - * but patches are of course alwys welcome. + * but patches are of course always welcome. * * Missing other features: * * Segmentation/Reassembly support @@ -119,7 +119,7 @@ * The caller is required to free oph->msg, otherwise the same as sccp_sclc_user_sap_down(). * \param[in] scu SCCP User who is sending the primitive * \param[on] oph Osmocom primitive header of the primitive - * \returns 0 on success; negtive in case of error */ + * \returns 0 on success; negative in case of error */ int sccp_sclc_user_sap_down_nofree(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph) { struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph; @@ -143,7 +143,7 @@ * Implies a msgb_free(oph->msg), otherwise the same as sccp_sclc_user_sap_down_nofree(). * \param[in] scu SCCP User who is sending the primitive * \param[on] oph Osmocom primitive header of the primitive - * \returns 0 on success; negtive in case of error */ + * \returns 0 on success; negative in case of error */ int sccp_sclc_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph) { struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph; diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 244e6d3..5f109b3 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -36,7 +36,7 @@ * However, all SCCP features can be expressed in SUA. * * The code only supports Class 2. No support for Class 3 is intended, - * but patches are of course alwys welcome. + * but patches are of course always welcome. * * Missing other features: * * Segmentation/Reassembly support @@ -80,7 +80,7 @@ /* remote point code */ uint32_t remote_pc; - /* local/remote addresses and identiies */ + /* local/remote addresses and identities */ struct osmo_sccp_addr calling_addr; struct osmo_sccp_addr called_addr; /* SCCP connection identifier. Only relevant across the SCCP User SAP, @@ -90,7 +90,7 @@ /* SCCP Remote Connection Reference. Allocated by the remote * SCCP stack to uniquely identify a SCCP connection on its end. * We don't interpret it, but simply cache it here so we can use - * it whever sending data to the peer. Only relevant over the + * it whenever sending data to the peer. Only relevant over the * wire, not to be used across the SCCP user SAP */ uint32_t remote_ref; @@ -1521,7 +1521,7 @@ xua_msg_free(xua); } -/* process received message for unasigned local reference */ +/* process received message for unassigned local reference */ static void sccp_scoc_rx_unass_local_ref(struct osmo_sccp_instance *inst, struct xua_msg *xua) { @@ -1631,7 +1631,7 @@ /* we basically try to convert the SUA message into an event, * and then dispatch the event to the connection-specific FSM. * If it is a CORE (Connect REquest), we create the connection - * (and imlpicitly its FSM) first */ + * (and implicitly its FSM) first */ if (xua->hdr.msg_type == SUA_CO_CORE) { scu = sccp_find_user(inst, xua); diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c index 1da3890..be23c21 100644 --- a/src/sccp_scrc.c +++ b/src/sccp_scrc.c @@ -85,7 +85,7 @@ return -1; } - /* 2) wrap into MTP-TRANSFER.req primtiive */ + /* 2) wrap into MTP-TRANSFER.req primitive */ msg->l2h = msg->data; omp = (struct osmo_mtp_prim *) msgb_push(msg, sizeof(*omp)); osmo_prim_init(&omp->oph, MTP_SAP_USER, @@ -109,7 +109,7 @@ return osmo_ss7_user_mtp_xfer_req(s7i, omp); } -/* Gererate MTP-TRANSFER.req from xUA message */ +/* Generate MTP-TRANSFER.req from xUA message */ static int gen_mtp_transfer_req_xua(struct osmo_sccp_instance *inst, struct xua_msg *xua, const struct osmo_sccp_addr *called) @@ -230,7 +230,7 @@ /* Connection Oriented? */ if (sua_is_connectionless(xua)) { /* TODO: Perform Capability Test */ - /* TODO: Canges Needed? */ + /* TODO: Changes Needed? */ if (0) { /* Changes Needed -> SCLC */ return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f Gerrit-Change-Number: 26248 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:42:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:42:52 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: simplify checking if channel mode is AMR In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26236 ) Change subject: abis_rsl: simplify checking if channel mode is AMR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If933ce0fa0a162c4518ddab840f186ebaa1bcff9 Gerrit-Change-Number: 26236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:42:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:44:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:44:02 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: simplify comments for ACCH repetition/overpower In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26237 ) Change subject: struct gsm_bts: simplify comments for ACCH repetition/overpower ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75b0e289c47841aea22b5966487535cbe855c84f Gerrit-Change-Number: 26237 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:44:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:44:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:44:43 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26238 ) Change subject: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Gerrit-Change-Number: 26238 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:44:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:44:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:44:57 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/temporary_overpower/top_acch_cap/g In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26239 ) Change subject: struct gsm_bts: s/temporary_overpower/top_acch_cap/g ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39b98dcd14219402959646524315d5afea7c08cf Gerrit-Change-Number: 26239 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:45:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:45:26 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26241 ) Change subject: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 Gerrit-Change-Number: 26241 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:47:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:47:39 +0000 Subject: Change in osmo-bsc[master]: [overpower] Allow configuring specific channel mode(s) In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26242 ) Change subject: [overpower] Allow configuring specific channel mode(s) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Gerrit-Change-Number: 26242 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:48:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:48:54 +0000 Subject: Change in osmo-bsc[master]: [overpower] By default, permit only for speech channels using AMR In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26243 ) Change subject: [overpower] By default, permit only for speech channels using AMR ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17 Gerrit-Change-Number: 26243 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:48:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:49:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:49:37 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:49:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:49:41 +0000 Subject: Change in osmo-bsc[master]: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Properly handle dyn TS TCH with vamos after updating subslots_per_pchan In the case of ts->pchan_from_config=GSM_PCHAN_OSMO_DYN, ts->max_primary_lchans will be 8 due to SDCCH8 support, and we don't want to set lchan->vamos.is_secondary=true for lchans at the end of the array. Related: OS#5278 Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 93fc380..86fea3c 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -201,19 +201,24 @@ { int i; struct gsm_lchan *lchan; + uint8_t max_lchans_possible_vamos; + ts->pchan_is = pchan_is; ts->max_primary_lchans = pchan_subslots(ts->pchan_is); - LOG_TS(ts, LOGL_DEBUG, "pchan_is=%s max_primary_lchans=%d max_lchans_possible=%d\n", - gsm_pchan_name(ts->pchan_is), ts->max_primary_lchans, ts->max_lchans_possible); + max_lchans_possible_vamos = pchan_subslots_vamos(ts->pchan_is); + LOG_TS(ts, LOGL_DEBUG, "pchan_is=%s max_primary_lchans=%d max_lchans_possible=%d (%u VAMOS)\n", + gsm_pchan_name(ts->pchan_is), ts->max_primary_lchans, ts->max_lchans_possible, + max_lchans_possible_vamos); switch (ts->pchan_is) { case GSM_PCHAN_TCH_F: case GSM_PCHAN_TCH_H: for (i = 0; i < ts->max_lchans_possible; i++) { lchan = &ts->lchan[i]; - if (i < ts->max_primary_lchans) - lchan->vamos.is_secondary = false; - else + if (i >= ts->max_primary_lchans && + (i - ts->max_primary_lchans) < (int)max_lchans_possible_vamos) lchan->vamos.is_secondary = true; + else + lchan->vamos.is_secondary = false; lchan_fsm_update_id(lchan); } break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:50:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:50:35 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c at 900 PS2, Line 900: [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU receivved" }, typo in received -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:50:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:51:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:51:42 +0000 Subject: Change in libosmo-sccp[master]: spelling fixes in comments In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 ) Change subject: spelling fixes in comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f Gerrit-Change-Number: 26248 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 09:51:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 09:59:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 09:59:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn at 562 PS1, Line 562: inout GprsMS ms > I mean, it's like buying shoes or clots with greater/lower size in hope that some day in the future [?] I don't think code development has nothing to do with wearing clothes, so no point in there. I really don't see the point in not accepting this as it is and having to waste time changing it, but ok, I'll do it, I just want to get this merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 15 Nov 2021 09:59:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 10:15:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 10:15:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 to look at the new patch set (#2). Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... pcu: Introduce as_ms_rx_ignore_empty helper It will be further used in follow-up patches. Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c --- M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 2 files changed, 18 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/26220/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 10:15:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 10:15:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 to look at the new patch set (#2). Change subject: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 ...................................................................... pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 I cannot reproduce the issue in my local system with docker, probabluy due to different performance from jenkins builder. It triggers almost every time in jenkins nightly TTCN3 PCU_tests though. A similar fix was already introduced recently for TC_n3105_max_t3195 since PCU started submitting empty (idle) blocks when there's no TBF listening on that PDCH. We need to update the test to account for that, since our TTCN3 timers are not necessarily exactly matching the one at the PCU side. Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 --- M pcu/PCU_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/26221/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 Gerrit-Change-Number: 26221 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 10:37:23 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 10:37:23 +0000 Subject: Change in libosmo-sccp[master]: spelling fixes in comments In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 ) Change subject: spelling fixes in comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f Gerrit-Change-Number: 26248 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 10:37:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 10:38:57 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 15 Nov 2021 10:38:57 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Remove duplicate struct gprs_ra_id handling In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 ) Change subject: gbproxy: Remove duplicate struct gprs_ra_id handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ibc9f42a60706612c17e5f8f0468c7faced5ae4c8 Gerrit-Change-Number: 26219 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 10:38:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 10:39:00 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 15 Nov 2021 10:39:00 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Remove duplicate struct gprs_ra_id handling In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 ) Change subject: gbproxy: Remove duplicate struct gprs_ra_id handling ...................................................................... gbproxy: Remove duplicate struct gprs_ra_id handling The ra_id as well as the cell_id are already present in struct gbproxy_cell which is reachable from bvc->cell. Remove the ra_id in struct gbproxy_bvc and also remove some unused/unneeded code. The FSM reset_notif callback already takes care of updating the cell. Related: OS#4894 Change-Id: Ibc9f42a60706612c17e5f8f0468c7faced5ae4c8 --- M include/osmocom/gbproxy/gb_proxy.h M src/gb_proxy.c 2 files changed, 11 insertions(+), 35 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/include/osmocom/gbproxy/gb_proxy.h b/include/osmocom/gbproxy/gb_proxy.h index 07373ad..0657df7 100644 --- a/include/osmocom/gbproxy/gb_proxy.h +++ b/include/osmocom/gbproxy/gb_proxy.h @@ -142,9 +142,6 @@ /* Whether this BVC is inactive (removed from BSS-side) */ bool inactive; - /* Routing Area that this BVC is part of */ - struct gprs_ra_id raid; - /* Counter */ struct rate_ctr_group *ctrg; diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 9845a09..3d76a33 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -710,7 +710,7 @@ } /* Reallocate SGSN-side BVCs of the cell, and reset them - * Removing and reallocating is needed becaus the ra_id/cell_id might have changed */ + * Removing and reallocating is needed because the ra_id/cell_id might have changed */ hash_for_each(cfg->sgsn_nses, i, sgsn_nse, list) { struct gbproxy_bvc *sgsn_bvc = gbproxy_bvc_by_bvci(sgsn_nse, bvci); if (!sgsn_bvc) @@ -721,7 +721,6 @@ sgsn_bvc = gbproxy_bvc_alloc(sgsn_nse, bvci); OSMO_ASSERT(sgsn_bvc); sgsn_bvc->cell = bvc->cell; - memcpy(&sgsn_bvc->raid, &bvc->cell->id.raid, sizeof(sgsn_bvc->raid)); sgsn_bvc->fi = bssgp_bvc_fsm_alloc_ptp_bss(sgsn_bvc, cfg->nsi, sgsn_nse->nsei, bvci, ra_id, cell_id); OSMO_ASSERT(sgsn_bvc->fi); @@ -888,34 +887,6 @@ bssgp_bvc_fsm_set_max_pdu_len(from_bvc->fi, nse->max_sdu_len); bssgp_bvc_fsm_set_ops(from_bvc->fi, &bss_ptp_bvc_fsm_ops, from_bvc); } -#if 0 - /* Could have moved to a different NSE */ - if (!check_bvc_nsei(from_bvc, nsei)) { - LOGPBVC(from_bvc, LOGL_NOTICE, "moving bvc to NSE(%05u)\n", nsei); - - struct gbproxy_nse *nse_new = gbproxy_nse_by_nsei(cfg, nsei, false); - if (!nse_new) { - LOGP(DGPRS, LOGL_NOTICE, "NSE(%05u) Got PtP BVC reset before signalling reset for " - "BVCI=%05u\n", bvci, nsei); - tx_status(nse, ns_bvci, BSSGP_CAUSE_PDU_INCOMP_STATE, NULL, msg); - return 0; - } - - /* Move bvc to different NSE */ - gbproxy_bvc_move(from_bvc, nse_new); - } -#endif - /* FIXME: do we need this, if it happens within FSM? */ - if (TLVP_PRES_LEN(tp, BSSGP_IE_CELL_ID, 8)) { - struct gprs_ra_id raid; - /* We have a Cell Identifier present in this - * PDU, this means we can extend our local - * state information about this particular cell - * */ - gsm48_parse_ra(&raid, TLVP_VAL(tp, BSSGP_IE_CELL_ID)); - memcpy(&from_bvc->raid, &raid, sizeof(from_bvc->raid)); - LOGPBVC(from_bvc, LOGL_INFO, "Cell ID %s\n", osmo_rai_name(&raid)); - } } /* hand into FSM for further processing */ osmo_fsm_inst_dispatch(from_bvc->fi, BSSGP_BVCFSM_E_RX_RESET, msg); @@ -1267,7 +1238,11 @@ /* iterate over all bvcs and dispatch the paging to each matching one */ hash_for_each(cfg->bss_nses, i, nse, list) { hash_for_each(nse->bvcs, j, bss_bvc, list) { - if (gsm48_ra_equal(&bss_bvc->raid, &raid)) { + /* Skip BVCs without a cell (e.g. signalling) */ + if (!bss_bvc->cell) + continue; + + if (gsm48_ra_equal(&bss_bvc->cell->id.raid, &raid)) { LOGPNSE(nse, LOGL_INFO, "Rx %s: routing to NSE (RAI match)\n", pdut_name); gbprox_relay2peer(msg, bss_bvc, ns_bvci); @@ -1283,7 +1258,11 @@ /* iterate over all bvcs and dispatch the paging to each matching one */ hash_for_each(cfg->bss_nses, i, nse, list) { hash_for_each(nse->bvcs, j, bss_bvc, list) { - gsm48_encode_ra(&lac, &bss_bvc->raid); + /* Skip BVCs without a cell (e.g. signalling) */ + if (!bss_bvc->cell) + continue; + + gsm48_encode_ra(&lac, &bss_bvc->cell->id.raid); if (!memcmp(&lac, TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA), 5)) { LOGPNSE(nse, LOGL_INFO, "Rx %s: routing to NSE (LAI match)\n", pdut_name); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ibc9f42a60706612c17e5f8f0468c7faced5ae4c8 Gerrit-Change-Number: 26219 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 10:44:45 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 10:44:45 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... Patch Set 2: Code-Review+1 (type should be fixed, otherwise this looks good to me) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 10:44:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:43:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:43:39 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c at 900 PS2, Line 900: [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU receivved" }, > typo in received Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c at 1157 PS2, Line 1157: received transmitted -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 11:43:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:56:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 11:56:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ratectr_all_available_allocated References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26249 ) Change subject: pcu: Introduce test TC_ratectr_all_available_allocated ...................................................................... pcu: Introduce test TC_ratectr_all_available_allocated Related: SYS#4878 Change-Id: Ide1254954b5cf02a19e190b19d06c7aaeedb6ede --- M pcu/PCU_Tests.ttcn 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/26249/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 5bc2959..a191cc5 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -6504,6 +6504,54 @@ f_tc_stat_pdch_avail_occ_ms_not_known(true); } +/* Make sure that bts.0.pdch.all_allocated is set when we allocate all resources */ +testcase TC_ratectr_all_available_allocated() runs on RAW_PCU_Test_CT { + var PCUIF_info_ind info_ind; + var template IARRestOctets rest; + var BIT11 ra11; + + info_ind := valueof(ts_PCUIF_INFO_default); + info_ind.t3142 := 3; + + /* Only the first TRX is enabled. */ + f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); + f_PCUIF_PDCHMask_set(info_ind, '00000001'B, 0); + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), info_ind); + f_statsd_reset(); + + var EGPRSPktChRequest req := { + one_phase := { + tag := '0'B, + multislot_class := '10101'B, + priority := '01'B, + random_bits := '101'B + } + }; + + /* We send 7 requests, the IUT gives us all available USFs (0..6) */ + for (var integer i := 0; i < 7; i := i + 1) { + req.one_phase.random_bits := int2bit(f_rnd_int(8), 3); + f_TC_egprs_pkt_chan_req(req, tr_IMM_TBF_ASS); + } + + ra11 := enc_EGPRSPktChRequest2bits(req); + rest := tr_IARRestOctets({ *, tr_ExtRAOpt(substr(ra11, 6, 5)), * }); + + /* At this point, the IUT should run out of free USFs */ + f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); + + /* bts.0.pdch.all_allocated is updated once per second, wait some time to make sure it was updated. */ + f_sleep(2.0); + var StatsDExpects expect := { + { name := "TTCN3.bts.0.pdch.all_allocated", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + + f_shutdown(__BFILE__, __LINE__, final := true); +} + control { execute( TC_pcuif_suspend() ); execute( TC_pcuif_suspend_active_tbf() ); @@ -6618,6 +6666,7 @@ execute( TC_stat_pdch_avail_occ() ); execute( TC_stat_pdch_avail_occ_ms_not_known_gprs() ); execute( TC_stat_pdch_avail_occ_ms_not_known_egprs() ); + execute( TC_ratectr_all_available_allocated() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide1254954b5cf02a19e190b19d06c7aaeedb6ede Gerrit-Change-Number: 26249 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:56:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 11:56:52 +0000 Subject: Change in osmo-pcu[master]: bts: Add counter availablePDCHAllocatedTime In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26210 ) Change subject: bts: Add counter availablePDCHAllocatedTime ...................................................................... Patch Set 4: Code-Review+1 This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie0f0c451558817bddc3fe1a0f0df531f14c9f1d3 Gerrit-Change-Number: 26210 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 11:56:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:03 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: simplify checking if channel mode is AMR In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26236 ) Change subject: abis_rsl: simplify checking if channel mode is AMR ...................................................................... abis_rsl: simplify checking if channel mode is AMR Change-Id: If933ce0fa0a162c4518ddab840f186ebaa1bcff9 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0186024..f7a2de7 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -689,7 +689,7 @@ add_power_control_params(msg, RSL_IE_BS_POWER_PARAM, lchan); add_power_control_params(msg, RSL_IE_MS_POWER_PARAM, lchan); - if (gsm48_chan_mode_to_non_vamos(lchan->activate.ch_mode_rate.chan_mode) == GSM48_CMODE_SPEECH_AMR) { + if (cm.chan_rate == RSL_CMOD_SP_GSM3) { rc = put_mr_config_for_bts(msg, &lchan->activate.mr_conf_filtered, (lchan->type == GSM_LCHAN_TCH_F) ? &bts->mr_full : &bts->mr_half); if (rc) { @@ -761,7 +761,7 @@ } } - if (gsm48_chan_mode_to_non_vamos(lchan->modify.ch_mode_rate.chan_mode) == GSM48_CMODE_SPEECH_AMR) { + if (cm.chan_rate == RSL_CMOD_SP_GSM3) { rc = put_mr_config_for_bts(msg, &lchan->modify.mr_conf_filtered, (lchan->type == GSM_LCHAN_TCH_F) ? &bts->mr_full : &bts->mr_half); if (rc) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If933ce0fa0a162c4518ddab840f186ebaa1bcff9 Gerrit-Change-Number: 26236 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:05 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26244 ) Change subject: abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() ...................................................................... abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() The linter (executed by Jenkins) complains: src/osmo-bsc/abis_rsl.c:543: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" and blocks changes, adding V-1 when I am changing the related code. Change-Id: I0cf00ff898e69734850659e8ba0e2ff023f9b2dd --- M src/osmo-bsc/abis_rsl.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index f7a2de7..d596fdd 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -540,7 +540,7 @@ cap = (struct abis_rsl_osmo_rep_acch_cap*) msg->tail; msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(*cap), - (uint8_t*) &bts->repeated_acch_policy); + (uint8_t *)&bts->repeated_acch_policy); if (!(lchan->conn && lchan->conn->cm3_valid && lchan->conn->cm3.repeated_acch_capability)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0cf00ff898e69734850659e8ba0e2ff023f9b2dd Gerrit-Change-Number: 26244 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:06 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:06 +0000 Subject: Change in osmo-bsc[master]: bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26245 ) Change subject: bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch ...................................................................... bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch The linter (executed by Jenkins) complains: src/osmo-bsc/bts_vty.c:653: ERROR:CODE_INDENT: code indent should use tabs where possible src/osmo-bsc/bts_vty.c:654: ERROR:CODE_INDENT: code indent should use tabs where possible src/osmo-bsc/bts_vty.c:656: ERROR:CODE_INDENT: code indent should use tabs where possible src/osmo-bsc/bts_vty.c:657: ERROR:CODE_INDENT: code indent should use tabs where possible and blocks changes, adding V-1 when I am changing the related code. Change-Id: If3c8c09ddff7cb945425e74344ceb4da989ddffc --- M src/osmo-bsc/bts_vty.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 8c2b100..1306a03 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -650,11 +650,11 @@ } if (!strcmp(argv[0], "command")) { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = false; + bts->repeated_acch_policy.dl_facch_cmd = true; + bts->repeated_acch_policy.dl_facch_all = false; } else { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = true; + bts->repeated_acch_policy.dl_facch_cmd = true; + bts->repeated_acch_policy.dl_facch_all = true; } return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3c8c09ddff7cb945425e74344ceb4da989ddffc Gerrit-Change-Number: 26245 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:06 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:06 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: simplify comments for ACCH repetition/overpower In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26237 ) Change subject: struct gsm_bts: simplify comments for ACCH repetition/overpower ...................................................................... struct gsm_bts: simplify comments for ACCH repetition/overpower Change-Id: I75b0e289c47841aea22b5966487535cbe855c84f --- M include/osmocom/bsc/bts.h 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 89512f3..b42c4ff 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -590,13 +590,10 @@ struct llist_head oml_fail_rep; struct llist_head chan_rqd_queue; - /* osmocom specific FACCH/SACCH repetition mode flags set by VTY to - * enable/disable certain ACCH repeation features individually */ + /* ACCH Repetition capabilities */ struct abis_rsl_osmo_rep_acch_cap repeated_acch_policy; - /* osmocom specific FACCH/SACCH temporary overpower value. This value - * is set to a constant value by the VTY. Temporary overpower is only - * applied when FACCH/SACCH repetition is not applicable or disabled */ + /* ACCH Temporary overpower capabilities */ struct abis_rsl_osmo_temp_ovp_acch_cap temporary_overpower; /* MS/BS Power Control parameters */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75b0e289c47841aea22b5966487535cbe855c84f Gerrit-Change-Number: 26237 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:07 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26238 ) Change subject: struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g ...................................................................... struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g Let's have a short and consistent naming for both ACCH repetition and temporary ACCH overpower structures, like it's done in osmo-bts. Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Related: Ib1d51f91139b4c2fe794e37fc8543b2d7a9b9c07 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c 4 files changed, 22 insertions(+), 22 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index b42c4ff..31f14a1 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -591,7 +591,7 @@ struct llist_head chan_rqd_queue; /* ACCH Repetition capabilities */ - struct abis_rsl_osmo_rep_acch_cap repeated_acch_policy; + struct abis_rsl_osmo_rep_acch_cap rep_acch_cap; /* ACCH Temporary overpower capabilities */ struct abis_rsl_osmo_temp_ovp_acch_cap temporary_overpower; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index d596fdd..0e3809e 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -540,7 +540,7 @@ cap = (struct abis_rsl_osmo_rep_acch_cap*) msg->tail; msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(*cap), - (uint8_t *)&bts->repeated_acch_policy); + (uint8_t *)&bts->rep_acch_cap); if (!(lchan->conn && lchan->conn->cm3_valid && lchan->conn->cm3.repeated_acch_capability)) { diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 71cf4da..f1cb441 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -398,7 +398,7 @@ acc_ramp_init(&bts->acc_ramp, bts); /* Default RxQual threshold for ACCH repetition/overpower */ - bts->repeated_acch_policy.rxqual = 4; + bts->rep_acch_cap.rxqual = 4; bts->temporary_overpower.rxqual = 4; /* MS Power Control parameters (defaults) */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 1306a03..ddc5785 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -650,11 +650,11 @@ } if (!strcmp(argv[0], "command")) { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = false; + bts->rep_acch_cap.dl_facch_cmd = true; + bts->rep_acch_cap.dl_facch_all = false; } else { - bts->repeated_acch_policy.dl_facch_cmd = true; - bts->repeated_acch_policy.dl_facch_all = true; + bts->rep_acch_cap.dl_facch_cmd = true; + bts->rep_acch_cap.dl_facch_all = true; } return CMD_SUCCESS; } @@ -668,8 +668,8 @@ { struct gsm_bts *bts = vty->index; - bts->repeated_acch_policy.dl_facch_cmd = false; - bts->repeated_acch_policy.dl_facch_all = false; + bts->rep_acch_cap.dl_facch_cmd = false; + bts->rep_acch_cap.dl_facch_all = false; return CMD_SUCCESS; } @@ -691,9 +691,9 @@ } if (strcmp(argv[0], "ul-sacch") == 0) - bts->repeated_acch_policy.ul_sacch = true; + bts->rep_acch_cap.ul_sacch = true; else - bts->repeated_acch_policy.dl_sacch = true; + bts->rep_acch_cap.dl_sacch = true; return CMD_SUCCESS; } @@ -709,9 +709,9 @@ struct gsm_bts *bts = vty->index; if (strcmp(argv[0], "ul-sacch") == 0) - bts->repeated_acch_policy.ul_sacch = false; + bts->rep_acch_cap.ul_sacch = false; else - bts->repeated_acch_policy.dl_sacch = false; + bts->rep_acch_cap.dl_sacch = false; return CMD_SUCCESS; } @@ -745,7 +745,7 @@ } /* See also: GSM 05.08, section 8.2.4 */ - bts->repeated_acch_policy.rxqual = atoi(argv[0]); + bts->rep_acch_cap.rxqual = atoi(argv[0]); return CMD_SUCCESS; } @@ -4313,18 +4313,18 @@ top->rxqual, VTY_NEWLINE); } - if (bts->repeated_acch_policy.dl_facch_all) + if (bts->rep_acch_cap.dl_facch_all) vty_out(vty, " repeat dl-facch all%s", VTY_NEWLINE); - else if (bts->repeated_acch_policy.dl_facch_cmd) + else if (bts->rep_acch_cap.dl_facch_cmd) vty_out(vty, " repeat dl-facch command%s", VTY_NEWLINE); - if (bts->repeated_acch_policy.dl_sacch) + if (bts->rep_acch_cap.dl_sacch) vty_out(vty, " repeat dl-sacch%s", VTY_NEWLINE); - if (bts->repeated_acch_policy.ul_sacch) + if (bts->rep_acch_cap.ul_sacch) vty_out(vty, " repeat ul-sacch%s", VTY_NEWLINE); - if (bts->repeated_acch_policy.ul_sacch - || bts->repeated_acch_policy.dl_facch_cmd - || bts->repeated_acch_policy.dl_facch_cmd) - vty_out(vty, " repeat rxqual %u%s", bts->repeated_acch_policy.rxqual, VTY_NEWLINE); + if (bts->rep_acch_cap.ul_sacch + || bts->rep_acch_cap.dl_facch_cmd + || bts->rep_acch_cap.dl_facch_cmd) + vty_out(vty, " repeat rxqual %u%s", bts->rep_acch_cap.rxqual, VTY_NEWLINE); if (bts->interf_meas_params_cfg.avg_period != interf_meas_params_def.avg_period) { vty_out(vty, " interference-meas avg-period %u%s", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia12c83ad1af4744ce28ba655ac806784f746e88a Gerrit-Change-Number: 26238 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:07 +0000 Subject: Change in osmo-bsc[master]: struct gsm_bts: s/temporary_overpower/top_acch_cap/g In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26239 ) Change subject: struct gsm_bts: s/temporary_overpower/top_acch_cap/g ...................................................................... struct gsm_bts: s/temporary_overpower/top_acch_cap/g Let's have a short and consistent naming for both ACCH repetition and temporary ACCH overpower structures, like it's done in osmo-bts. Change-Id: I39b98dcd14219402959646524315d5afea7c08cf Related: Ib1d51f91139b4c2fe794e37fc8543b2d7a9b9c07 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c 4 files changed, 15 insertions(+), 15 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 31f14a1..f582232 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -594,7 +594,7 @@ struct abis_rsl_osmo_rep_acch_cap rep_acch_cap; /* ACCH Temporary overpower capabilities */ - struct abis_rsl_osmo_temp_ovp_acch_cap temporary_overpower; + struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap; /* MS/BS Power Control parameters */ struct gsm_power_ctrl_params ms_power_ctrl; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0e3809e..90ceec1 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -563,8 +563,8 @@ return; msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, - sizeof(bts->temporary_overpower), - (void *)&bts->temporary_overpower); + sizeof(bts->top_acch_cap), + (void *)&bts->top_acch_cap); } /* Write RSL_IE_OSMO_TRAINING_SEQUENCE to msgb. The tsc_set argument's range is 1-4, tsc argument range is 0-7. */ diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index f1cb441..0fdb636 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -399,7 +399,7 @@ /* Default RxQual threshold for ACCH repetition/overpower */ bts->rep_acch_cap.rxqual = 4; - bts->temporary_overpower.rxqual = 4; + bts->top_acch_cap.rxqual = 4; /* MS Power Control parameters (defaults) */ power_ctrl_params_def_reset(&bts->ms_power_ctrl, GSM_PWR_CTRL_DIR_UL); diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index ddc5785..683f2c3 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -770,15 +770,15 @@ return CMD_WARNING; } - bts->temporary_overpower.sacch_enable = 0; - bts->temporary_overpower.facch_enable = 0; + bts->top_acch_cap.sacch_enable = 0; + bts->top_acch_cap.facch_enable = 0; if (!strcmp(argv[0], "dl-acch") || !strcmp(argv[0], "dl-sacch")) - bts->temporary_overpower.sacch_enable = 1; + bts->top_acch_cap.sacch_enable = 1; if (!strcmp(argv[0], "dl-acch") || !strcmp(argv[0], "dl-facch")) - bts->temporary_overpower.facch_enable = 1; + bts->top_acch_cap.facch_enable = 1; - bts->temporary_overpower.overpower_db = atoi(argv[1]); + bts->top_acch_cap.overpower_db = atoi(argv[1]); return CMD_SUCCESS; } @@ -792,9 +792,9 @@ { struct gsm_bts *bts = vty->index; - bts->temporary_overpower.overpower_db = 0; - bts->temporary_overpower.sacch_enable = 0; - bts->temporary_overpower.facch_enable = 0; + bts->top_acch_cap.overpower_db = 0; + bts->top_acch_cap.sacch_enable = 0; + bts->top_acch_cap.facch_enable = 0; return CMD_SUCCESS; } @@ -813,7 +813,7 @@ return CMD_WARNING; } - bts->temporary_overpower.rxqual = atoi(argv[0]); + bts->top_acch_cap.rxqual = atoi(argv[0]); return CMD_SUCCESS; } @@ -4293,9 +4293,9 @@ ho_vty_write_bts(vty, bts); - if (bts->temporary_overpower.overpower_db > 0) { + if (bts->top_acch_cap.overpower_db > 0) { const struct abis_rsl_osmo_temp_ovp_acch_cap *top = \ - &bts->temporary_overpower; + &bts->top_acch_cap; const char *mode = NULL; if (top->sacch_enable && top->facch_enable) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39b98dcd14219402959646524315d5afea7c08cf Gerrit-Change-Number: 26239 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:08 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: {rep, top}_acch_cap_for_bts(): make *lchan const In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26240 ) Change subject: abis_rsl: {rep,top}_acch_cap_for_bts(): make *lchan const ...................................................................... abis_rsl: {rep,top}_acch_cap_for_bts(): make *lchan const Change-Id: I3e71bb88db7b1eadff5a73fdb98fe7eee2fc2540 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 90ceec1..6760e94 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -526,11 +526,11 @@ /* indicate FACCH/SACCH Repetition to be performed by BTS, * see also: 3GPP TS 44.006, section 10 and 11 */ -static void rep_acch_cap_for_bts(struct gsm_lchan *lchan, +static void rep_acch_cap_for_bts(const struct gsm_lchan *lchan, struct msgb *msg) { struct abis_rsl_osmo_rep_acch_cap *cap; - struct gsm_bts *bts = lchan->ts->trx->bts; + const struct gsm_bts *bts = lchan->ts->trx->bts; /* The RSL_IE_OSMO_REP_ACCH_CAP IE is a proprietary IE, that can only * be used with osmo-bts type BTSs */ @@ -554,9 +554,9 @@ } /* indicate Temporary overpower of SACCH and FACCH channels */ -static void top_acch_cap_for_bts(struct gsm_lchan *lchan, struct msgb *msg) +static void top_acch_cap_for_bts(const struct gsm_lchan *lchan, struct msgb *msg) { - struct gsm_bts *bts = lchan->ts->trx->bts; + const struct gsm_bts *bts = lchan->ts->trx->bts; /* The BTS_FEAT_ACCH_TEMP_OVP IE is a proprietary IE, that can only be used with osmo-bts type BTSs */ if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS && osmo_bts_has_feature(&bts->features, BTS_FEAT_ACCH_TEMP_OVP))) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e71bb88db7b1eadff5a73fdb98fe7eee2fc2540 Gerrit-Change-Number: 26240 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:08 +0000 Subject: Change in osmo-bsc[master]: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26241 ) Change subject: abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g ...................................................................... abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 6760e94..f93dee2 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -526,8 +526,8 @@ /* indicate FACCH/SACCH Repetition to be performed by BTS, * see also: 3GPP TS 44.006, section 10 and 11 */ -static void rep_acch_cap_for_bts(const struct gsm_lchan *lchan, - struct msgb *msg) +static void put_rep_acch_cap_ie(const struct gsm_lchan *lchan, + struct msgb *msg) { struct abis_rsl_osmo_rep_acch_cap *cap; const struct gsm_bts *bts = lchan->ts->trx->bts; @@ -554,7 +554,7 @@ } /* indicate Temporary overpower of SACCH and FACCH channels */ -static void top_acch_cap_for_bts(const struct gsm_lchan *lchan, struct msgb *msg) +static void put_top_acch_cap_ie(const struct gsm_lchan *lchan, struct msgb *msg) { const struct gsm_bts *bts = lchan->ts->trx->bts; @@ -699,8 +699,8 @@ } } - rep_acch_cap_for_bts(lchan, msg); - top_acch_cap_for_bts(lchan, msg); + put_rep_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode */ if (lchan->activate.info.vamos && lchan->activate.tsc_set >= 1) @@ -771,8 +771,8 @@ } } - rep_acch_cap_for_bts(lchan, msg); - top_acch_cap_for_bts(lchan, msg); + put_rep_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode. Send this Osmocom specific IE only to OsmoBTS * types. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I663023adb4f2381d4b8debb01786801803b3d741 Gerrit-Change-Number: 26241 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:09 +0000 Subject: Change in osmo-bsc[master]: [overpower] Allow configuring specific channel mode(s) In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26242 ) Change subject: [overpower] Allow configuring specific channel mode(s) ...................................................................... [overpower] Allow configuring specific channel mode(s) Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts_vty.c M tests/acch_overpower.vty 5 files changed, 79 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc index dee0470..7200b0e 100644 --- a/doc/manuals/chapters/power_control.adoc +++ b/doc/manuals/chapters/power_control.adoc @@ -604,9 +604,11 @@ bts 0 overpower dl-acch 2 <1> overpower rxqual 4 <2> + overpower chan-mode any <3> ---- <1> Overpower of maximum 2 dB for both SACCH and FACCH. <2> Enable TOP only if RxQual is worse than 4 (BER >= 1.6%). +<3> Permit TOP for any kinds of dedicated channels. It's also possible to enable TOP only for FACCH or SACCH selectively, or or keep it enabled permanently regardless of the reported RxQual: diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index f582232..8861c32 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -595,6 +595,11 @@ /* ACCH Temporary overpower capabilities */ struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap; + /* Channel mode(s) for which to allow TOP */ + enum { + TOP_ACCH_CHAN_MODE_ANY = 0, /* Any kind of channel mode */ + TOP_ACCH_CHAN_MODE_SPEECH_V3, /* Speech channels using AMR codec */ + } top_acch_chan_mode; /* MS/BS Power Control parameters */ struct gsm_power_ctrl_params ms_power_ctrl; diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index f93dee2..52008a5 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -554,7 +554,9 @@ } /* indicate Temporary overpower of SACCH and FACCH channels */ -static void put_top_acch_cap_ie(const struct gsm_lchan *lchan, struct msgb *msg) +static void put_top_acch_cap_ie(const struct gsm_lchan *lchan, + const struct rsl_ie_chan_mode *cm, + struct msgb *msg) { const struct gsm_bts *bts = lchan->ts->trx->bts; @@ -562,6 +564,18 @@ if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS && osmo_bts_has_feature(&bts->features, BTS_FEAT_ACCH_TEMP_OVP))) return; + /* Check if TOP is permitted for the given Channel Mode */ + switch (bts->top_acch_chan_mode) { + case TOP_ACCH_CHAN_MODE_SPEECH_V3: + if (cm->spd_ind != RSL_CMOD_SPD_SPEECH) + return; + if (cm->chan_rate != RSL_CMOD_SP_GSM3) + return; + break; + case TOP_ACCH_CHAN_MODE_ANY: + break; + } + msgb_tlv_put(msg, RSL_IE_OSMO_TEMP_OVP_ACCH_CAP, sizeof(bts->top_acch_cap), (void *)&bts->top_acch_cap); @@ -700,7 +714,7 @@ } put_rep_acch_cap_ie(lchan, msg); - put_top_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, &cm, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode */ if (lchan->activate.info.vamos && lchan->activate.tsc_set >= 1) @@ -772,7 +786,7 @@ } put_rep_acch_cap_ie(lchan, msg); - put_top_acch_cap_ie(lchan, msg); + put_top_acch_cap_ie(lchan, &cm, msg); /* Selecting a specific TSC Set is only applicable to VAMOS mode. Send this Osmocom specific IE only to OsmoBTS * types. */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 683f2c3..2da789a 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -818,6 +818,34 @@ return CMD_SUCCESS; } +static const struct value_string top_acch_chan_mode_name[] = { + { TOP_ACCH_CHAN_MODE_ANY, "any" }, + { TOP_ACCH_CHAN_MODE_SPEECH_V3, "speech-amr" }, + { 0, NULL } +}; + +DEFUN_USRATTR(cfg_bts_top_dl_acch_chan_mode, + cfg_bts_top_dl_acch_chan_mode_cmd, + X(BSC_VTY_ATTR_NEW_LCHAN), + "overpower chan-mode (speech-amr|any)", + TOP_ACCH_STR + "Allow temporary overpower for specific Channel mode(s)\n" + "Speech channels using AMR codec\n" + "Any kind of channel mode (default)\n") +{ + struct gsm_bts *bts = vty->index; + + if (bts->model->type != GSM_BTS_TYPE_OSMOBTS) { + vty_out(vty, "%% ACCH overpower is not supported by BTS %u%s", + bts->nr, VTY_NEWLINE); + return CMD_WARNING; + } + + bts->top_acch_chan_mode = get_string_value(top_acch_chan_mode_name, argv[0]); + + return CMD_SUCCESS; +} + #define CD_STR "Channel Description\n" DEFUN_USRATTR(cfg_bts_chan_desc_att, @@ -4311,6 +4339,10 @@ mode, top->overpower_db, VTY_NEWLINE); vty_out(vty, " overpower rxqual %u%s", top->rxqual, VTY_NEWLINE); + vty_out(vty, " overpower chan-mode %s%s", + get_value_string(top_acch_chan_mode_name, + bts->top_acch_chan_mode), + VTY_NEWLINE); } if (bts->rep_acch_cap.dl_facch_all) @@ -4531,6 +4563,7 @@ install_element(BTS_NODE, &cfg_bts_top_dl_acch_cmd); install_element(BTS_NODE, &cfg_bts_top_no_dl_acch_cmd); install_element(BTS_NODE, &cfg_bts_top_dl_acch_rxqual_cmd); + install_element(BTS_NODE, &cfg_bts_top_dl_acch_chan_mode_cmd); install_element(BTS_NODE, &cfg_bts_interf_meas_avg_period_cmd); install_element(BTS_NODE, &cfg_bts_interf_meas_level_bounds_cmd); install_element(BTS_NODE, &cfg_bts_srvcc_fast_return_cmd); diff --git a/tests/acch_overpower.vty b/tests/acch_overpower.vty index 0fc8a45..d2b87ef 100644 --- a/tests/acch_overpower.vty +++ b/tests/acch_overpower.vty @@ -12,15 +12,17 @@ . ..l overpower (dl-acch|dl-sacch|dl-facch) <1-4> . ..l no overpower dl-acch . ..l overpower rxqual (0|1|2|3|4|5|6|7) + . ..l overpower chan-mode (speech-amr|any) ... OsmoBSC(config-net-bts)# overpower? overpower Temporary ACCH overpower OsmoBSC(config-net-bts)# overpower ? - dl-acch Enable overpower for both SACCH and FACCH - dl-sacch Enable overpower for SACCH only - dl-facch Enable overpower for FACCH only - rxqual Set RxQual (BER) threshold (default 4) + dl-acch Enable overpower for both SACCH and FACCH + dl-sacch Enable overpower for SACCH only + dl-facch Enable overpower for FACCH only + rxqual Set RxQual (BER) threshold (default 4) + chan-mode Allow temporary overpower for specific Channel mode(s) OsmoBSC(config-net-bts)# overpower dl-acch ? <1-4> Overpower value in dB @@ -29,18 +31,21 @@ ... overpower dl-acch 2 overpower rxqual 4 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower dl-sacch 3 OsmoBSC(config-net-bts)# show running-config ... overpower dl-sacch 3 overpower rxqual 4 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower dl-facch 4 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 4 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower rxqual ? @@ -57,12 +62,25 @@ ... overpower dl-facch 4 overpower rxqual 0 + overpower chan-mode any ... OsmoBSC(config-net-bts)# overpower rxqual 7 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 7 + overpower chan-mode any +... + +OsmoBSC(config-net-bts)# overpower chan-mode ? + speech-amr Speech channels using AMR codec + any Any kind of channel mode (default) +OsmoBSC(config-net-bts)# overpower chan-mode speech-amr +OsmoBSC(config-net-bts)# show running-config +... + overpower dl-facch 4 + overpower rxqual 7 + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# no overpower dl-acch -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I34d29d7d0f66c629367f3d6e8a660e199ecbe080 Gerrit-Change-Number: 26242 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 11:59:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 11:59:10 +0000 Subject: Change in osmo-bsc[master]: [overpower] By default, permit only for speech channels using AMR In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26243 ) Change subject: [overpower] By default, permit only for speech channels using AMR ...................................................................... [overpower] By default, permit only for speech channels using AMR Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17 Related: SYS#5319 --- M doc/manuals/chapters/power_control.adoc M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M tests/acch_overpower.vty 4 files changed, 25 insertions(+), 15 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/power_control.adoc b/doc/manuals/chapters/power_control.adoc index 7200b0e..f5f94f6 100644 --- a/doc/manuals/chapters/power_control.adoc +++ b/doc/manuals/chapters/power_control.adoc @@ -604,14 +604,17 @@ bts 0 overpower dl-acch 2 <1> overpower rxqual 4 <2> - overpower chan-mode any <3> + overpower chan-mode speech-amr <3> ---- <1> Overpower of maximum 2 dB for both SACCH and FACCH. <2> Enable TOP only if RxQual is worse than 4 (BER >= 1.6%). -<3> Permit TOP for any kinds of dedicated channels. +<3> Permit TOP only for speech channels using AMR codec. -It's also possible to enable TOP only for FACCH or SACCH selectively, or -or keep it enabled permanently regardless of the reported RxQual: +For advanced use cases, OsmoBSC can be configured to: + +* enable TOP only for FACCH or SACCH selectively, and/or +* keep TOP enabled permanently regardless of the reported RxQual, and/or +* permit TOP for any kind of dedicated channels. ---- OsmoBSC(config-net-bts)# overpower ? @@ -621,6 +624,10 @@ OsmoBSC(config-net-bts)# overpower rxqual 0? 0 BER >= 0% (always on) + +OsmoBSC(config-net-bts)# overpower chan-mode ? + speech-amr Speech channels using AMR codec (default) + any Any kind of channel mode ---- These parameters are indicated to the BTS during a logical channel activation diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 0fdb636..8af1254 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -401,6 +401,9 @@ bts->rep_acch_cap.rxqual = 4; bts->top_acch_cap.rxqual = 4; + /* Permit ACCH overpower only for speech channels using AMR */ + bts->top_acch_chan_mode = TOP_ACCH_CHAN_MODE_SPEECH_V3; + /* MS Power Control parameters (defaults) */ power_ctrl_params_def_reset(&bts->ms_power_ctrl, GSM_PWR_CTRL_DIR_UL); diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 2da789a..0c7259b 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -830,8 +830,8 @@ "overpower chan-mode (speech-amr|any)", TOP_ACCH_STR "Allow temporary overpower for specific Channel mode(s)\n" - "Speech channels using AMR codec\n" - "Any kind of channel mode (default)\n") + "Speech channels using AMR codec (default)\n" + "Any kind of channel mode\n") { struct gsm_bts *bts = vty->index; diff --git a/tests/acch_overpower.vty b/tests/acch_overpower.vty index d2b87ef..70090a4 100644 --- a/tests/acch_overpower.vty +++ b/tests/acch_overpower.vty @@ -31,21 +31,21 @@ ... overpower dl-acch 2 overpower rxqual 4 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower dl-sacch 3 OsmoBSC(config-net-bts)# show running-config ... overpower dl-sacch 3 overpower rxqual 4 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower dl-facch 4 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 4 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower rxqual ? @@ -62,25 +62,25 @@ ... overpower dl-facch 4 overpower rxqual 0 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower rxqual 7 OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 7 - overpower chan-mode any + overpower chan-mode speech-amr ... OsmoBSC(config-net-bts)# overpower chan-mode ? - speech-amr Speech channels using AMR codec - any Any kind of channel mode (default) -OsmoBSC(config-net-bts)# overpower chan-mode speech-amr + speech-amr Speech channels using AMR codec (default) + any Any kind of channel mode +OsmoBSC(config-net-bts)# overpower chan-mode any OsmoBSC(config-net-bts)# show running-config ... overpower dl-facch 4 overpower rxqual 7 - overpower chan-mode speech-amr + overpower chan-mode any ... OsmoBSC(config-net-bts)# no overpower dl-acch -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I087025f9db59348f2f70d4a291f8d887644d6b17 Gerrit-Change-Number: 26243 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:00:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 12:00:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 15 Nov 2021 12:00:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:00:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 12:00:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 ) Change subject: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 Gerrit-Change-Number: 26221 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 12:00:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:05:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 12:05:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ratectr_all_available_allocated In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26249 ) Change subject: pcu: Introduce test TC_ratectr_all_available_allocated ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide1254954b5cf02a19e190b19d06c7aaeedb6ede Gerrit-Change-Number: 26249 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 15 Nov 2021 12:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:10:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 12:10:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 ) Change subject: pcu: Introduce as_ms_rx_ignore_empty helper ...................................................................... pcu: Introduce as_ms_rx_ignore_empty helper It will be further used in follow-up patches. Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c --- M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 2 files changed, 18 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 1014498..d6749d7 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -559,6 +559,21 @@ } } +altstep as_pcuif_rx_ignore_empty(template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) +runs on MS_BTS_IFACE_CT { + var BTS_PDTCH_Block data_msg; + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + omit)) -> value data_msg { + + BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, + sapi := PCU_IF_SAPI_PDTCH, fn := 0, + arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), + block_nr := nr.blk_nr)); + repeat; + } +} + altstep as_rx_fail_dummy(template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) runs on MS_BTS_IFACE_CT { var BTS_PDTCH_Block data_msg; diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 2cc6fad..c347761 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1984,19 +1984,9 @@ block_nr := nr.blk_nr)); repeat; } - [mp_osmo_pcu_newer_than_0_9_0 and N3105 == N3105_MAX] - BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, - tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - omit)) -> value data_msg { - /* We may already receive idle blocks before our own TTCN3 timer - * triggers due to the TBF being released. Keep going until our T_3195 triggers. */ - nr := ts_TsTrxBtsNum; - BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, - sapi := PCU_IF_SAPI_PDTCH, fn := 0, - arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), - block_nr := nr.blk_nr)); - repeat; - } + /* We may already receive idle blocks before our own TTCN3 timer + * triggers due to the TBF being released. Keep going until our T_3195 triggers. */ + [mp_osmo_pcu_newer_than_0_9_0 and N3105 == N3105_MAX] as_pcuif_rx_ignore_empty(nr); [T_3195.running] T_3195.timeout { log("T_3195 timeout"); /* Done in alt, wait for pending RTS initiated previously in -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c Gerrit-Change-Number: 26220 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:10:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 12:10:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 ) Change subject: pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 ...................................................................... pcu: Fix race condition in TC_n3101_max_t3169 and TC_n3103_max_t3169 I cannot reproduce the issue in my local system with docker, probabluy due to different performance from jenkins builder. It triggers almost every time in jenkins nightly TTCN3 PCU_tests though. A similar fix was already introduced recently for TC_n3105_max_t3195 since PCU started submitting empty (idle) blocks when there's no TBF listening on that PDCH. We need to update the test to account for that, since our TTCN3 timers are not necessarily exactly matching the one at the PCU side. Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 --- M pcu/PCU_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index c347761..5bc2959 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1524,6 +1524,9 @@ block_nr := nr.blk_nr)); repeat; } + /* We may already receive empty (idle) blocks before our own TTCN3 timer + * triggers due to the TBF being released. Keep going until our T_3169 triggers. */ + [mp_osmo_pcu_newer_than_0_9_0 and n3101 == N3101_MAX + 1] as_pcuif_rx_ignore_empty(nr); [] T_3169.timeout { log("T_3169 expired"); /* Done in alt */ @@ -1622,6 +1625,7 @@ f_shutdown(__BFILE__, __LINE__); } [] as_ms_rx_ignore_dummy(ms, nr); + [] as_pcuif_rx_ignore_empty(nr); [T_3169.running] T_3169.timeout { log("T_3169 timeout"); /* Done in alt, wait for pending RTS initiated previously in -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5344df15c612c70a6cdd7bb6f12dc7524a23bf4 Gerrit-Change-Number: 26221 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:10:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 12:10:46 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ratectr_all_available_allocated In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26249 ) Change subject: pcu: Introduce test TC_ratectr_all_available_allocated ...................................................................... pcu: Introduce test TC_ratectr_all_available_allocated Related: SYS#4878 Change-Id: Ide1254954b5cf02a19e190b19d06c7aaeedb6ede --- M pcu/PCU_Tests.ttcn 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 5bc2959..a191cc5 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -6504,6 +6504,54 @@ f_tc_stat_pdch_avail_occ_ms_not_known(true); } +/* Make sure that bts.0.pdch.all_allocated is set when we allocate all resources */ +testcase TC_ratectr_all_available_allocated() runs on RAW_PCU_Test_CT { + var PCUIF_info_ind info_ind; + var template IARRestOctets rest; + var BIT11 ra11; + + info_ind := valueof(ts_PCUIF_INFO_default); + info_ind.t3142 := 3; + + /* Only the first TRX is enabled. */ + f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); + f_PCUIF_PDCHMask_set(info_ind, '00000001'B, 0); + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), info_ind); + f_statsd_reset(); + + var EGPRSPktChRequest req := { + one_phase := { + tag := '0'B, + multislot_class := '10101'B, + priority := '01'B, + random_bits := '101'B + } + }; + + /* We send 7 requests, the IUT gives us all available USFs (0..6) */ + for (var integer i := 0; i < 7; i := i + 1) { + req.one_phase.random_bits := int2bit(f_rnd_int(8), 3); + f_TC_egprs_pkt_chan_req(req, tr_IMM_TBF_ASS); + } + + ra11 := enc_EGPRSPktChRequest2bits(req); + rest := tr_IARRestOctets({ *, tr_ExtRAOpt(substr(ra11, 6, 5)), * }); + + /* At this point, the IUT should run out of free USFs */ + f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); + + /* bts.0.pdch.all_allocated is updated once per second, wait some time to make sure it was updated. */ + f_sleep(2.0); + var StatsDExpects expect := { + { name := "TTCN3.bts.0.pdch.all_allocated", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); + + f_shutdown(__BFILE__, __LINE__, final := true); +} + control { execute( TC_pcuif_suspend() ); execute( TC_pcuif_suspend_active_tbf() ); @@ -6618,6 +6666,7 @@ execute( TC_stat_pdch_avail_occ() ); execute( TC_stat_pdch_avail_occ_ms_not_known_gprs() ); execute( TC_stat_pdch_avail_occ_ms_not_known_egprs() ); + execute( TC_ratectr_all_available_allocated() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide1254954b5cf02a19e190b19d06c7aaeedb6ede Gerrit-Change-Number: 26249 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:22:42 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 12:22:42 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26231 ) Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 12:22:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:39:12 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 12:39:12 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 to look at the new patch set (#7). Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... osmo_bsc_main: call bootstrap_bts when OML TEI comes up At the moment check_bts and bootstrap_bts is called only once on startup. When a new BTS is set up during runtime bootstrap_bts, nor check_bts is called. This means that some parameters of the BTS stay uninitalized until osmo-bsc is restarted. Lets rather call check_bts() and then bootstrap_bts() when the OML TEI of the BTS comes up. Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/25767/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:39:12 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 12:39:12 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 to look at the new patch set (#5). Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/osmo_bsc_main.c 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:39:27 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 12:39:27 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 7: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c at a545 PS6, Line 545: return rc; > +1 Done https://gerrit.osmocom.org/c/osmo-bsc/+/25767/6/src/osmo-bsc/osmo_bsc_main.c at 496 PS6, Line 496: LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap BTS\n", trx->bts->nr); > (very long line, break before trx->bts->nr? same below) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Mon, 15 Nov 2021 12:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:39:56 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 12:39:56 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26197/4/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/4/src/osmo-bsc/abis_nm.c at 939 PS4, Line 939: LOGPFOH(DNM, LOGL_NOTICE, foh, "(bts=%u) BTS configuration invalid, rejecting OML NM Message from BTS -- check and correct configuratin!\n", > This line is way too long. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 12:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:42:22 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 12:42:22 +0000 Subject: Change in libosmo-abis[master]: lapd: don't add parenthesis around datalink name In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26229 ) Change subject: lapd: don't add parenthesis around datalink name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I688cf2a73a8c31cb3cf66ec005d02a14de197008 Gerrit-Change-Number: 26229 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Mon, 15 Nov 2021 12:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:43:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 12:43:11 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Drop unsued X2000 timer callback References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26250 ) Change subject: tbf_dl_ass_fsm: Drop unsued X2000 timer callback ...................................................................... tbf_dl_ass_fsm: Drop unsued X2000 timer callback That timer is only relevant for transmission of Packet Access Reject, which happens only for Uplink assignment, and hence is only set in the timer of tbf_ul_ass_fsm, never in tbf_dl_ass_fsm. This is probably a copy-paste artifact when implementing both FSMs. Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b --- M src/tbf_dl_ass_fsm.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/50/26250/1 diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index 1d44c91..5a5d669 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -187,9 +187,6 @@ { struct tbf_dl_ass_fsm_ctx *ctx = (struct tbf_dl_ass_fsm_ctx *)fi->priv; switch (fi->T) { - case -2000: - tbf_free(ctx->tbf); - break; default: OSMO_ASSERT(0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b Gerrit-Change-Number: 26250 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:46:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 12:46:57 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 5: I <3 how being in version 5 my comments from version 1 still are not addressed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 12:46:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:47:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 12:47:37 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Drop unsued X2000 timer callback In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26250 to look at the new patch set (#2). Change subject: tbf_dl_ass_fsm: Drop unsued X2000 timer callback ...................................................................... tbf_dl_ass_fsm: Drop unsued X2000 timer callback That timer is only relevant for transmission of Packet Access Reject, which happens only for Uplink assignment, and hence is only set in the timer of tbf_ul_ass_fsm, never in tbf_dl_ass_fsm. This is probably a copy-paste artifact when implementing both FSMs. Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b --- M src/tbf_dl_ass_fsm.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/50/26250/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b Gerrit-Change-Number: 26250 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 12:54:13 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Nov 2021 12:54:13 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 12:54:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 13:08:47 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 13:08:47 +0000 Subject: Change in osmo-pcu[master]: bts: Add counter availablePDCHAllocatedTime In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26210 ) Change subject: bts: Add counter availablePDCHAllocatedTime ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie0f0c451558817bddc3fe1a0f0df531f14c9f1d3 Gerrit-Change-Number: 26210 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 13:08:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 13:40:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 13:40:59 +0000 Subject: Change in osmo-pcu[master]: bts: Add counter availablePDCHAllocatedTime In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26210 ) Change subject: bts: Add counter availablePDCHAllocatedTime ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie0f0c451558817bddc3fe1a0f0df531f14c9f1d3 Gerrit-Change-Number: 26210 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 13:40:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 13:41:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 13:41:01 +0000 Subject: Change in osmo-pcu[master]: bts: Add counter availablePDCHAllocatedTime In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26210 ) Change subject: bts: Add counter availablePDCHAllocatedTime ...................................................................... bts: Add counter availablePDCHAllocatedTime We basically want to probe whether it's possible to allocate TBFs, or whether we know it will fail due to all main resources being already in use (TFI, USF). Having bts_all_pdch_allocated() return false doesn't mean though that an MS will be able to allocate a TBF for sure. That's because further restrictions are applied based on MS: whether it was already attached to a specific TRX, whether the ms_class allows for a certain multislot combination, etc. However, it should provide a general idea on whether for sure the PCU is unable to provide more allocations. More fine grained state about failures can still be followed by looking at tbf:alloc:failed:* rate counters. Related: SYS#4878 Depends: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd (libosmocore) Change-Id: Ie0f0c451558817bddc3fe1a0f0df531f14c9f1d3 --- M src/bts.cpp M src/bts.h M src/gprs_pcu.c M src/gprs_pcu.h M src/pdch.cpp M src/pdch.h M tests/alloc/AllocTest.cpp 7 files changed, 83 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/bts.cpp b/src/bts.cpp index 6fabc90..05a9cc0 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -83,6 +83,20 @@ { .T=3191, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s) after sending (1) last RLC Data Block on TBF(s), or (2) PACKET TBF RELEASE for an MBMS radio bearer", .val=0 }, { .T=3193, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Reuse of TFI(s) after reception of final PACKET DOWNLINK ACK/NACK from MS for TBF", .val=0 }, { .T=3195, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s) upon no response from the MS (radio failure or cell change) for TBF/MBMS radio bearer", .val=0 }, + { .T = -16, .default_val = 1000, .unit = OSMO_TDEF_MS, + .desc = "Granularity for *:all_allocated rate counters: amount of milliseconds that one counter increment" + " represents. See also X17, X18" }, + { .T = -17, .default_val = 0, .unit = OSMO_TDEF_MS, + .desc = "Rounding threshold for *:all_allocated rate counters: round up to the next counter increment" + " after this many milliseconds. If set to half of X16 (or 0), employ the usual round() behavior:" + " round up after half of a granularity period. If set to 1, behave like ceil(): already" + " increment the counter immediately when all channels are allocated. If set >= X16, behave like" + " floor(): only increment after a full X16 period of all channels being occupied." + " See also X16, X18" }, + { .T = -18, .default_val = 60000, .unit = OSMO_TDEF_MS, + .desc = "Forget-sum period for *:all_allocated rate counters:" + " after this amount of idle time, forget internally cumulated time remainders. Zero to always" + " keep remainders. See also X16, X17." }, { .T=0, .default_val=0, .unit=OSMO_TDEF_S, .desc=NULL, .val=0 } /* empty item at the end */ }; @@ -92,6 +106,7 @@ * the code below. */ static const struct rate_ctr_desc bts_ctr_description[] = { + { "pdch:all_allocated", "Cumulative counter of seconds where all enabled PDCH resources were allocated"}, { "tbf:dl:alloc", "TBF DL Allocated "}, { "tbf:dl:freed", "TBF DL Freed "}, { "tbf:dl:aborted", "TBF DL Aborted "}, @@ -231,6 +246,8 @@ bts->ms_store->cleanup(); delete bts->ms_store; + osmo_time_cc_cleanup(&bts->all_allocated_pdch); + if (bts->ratectrs) { rate_ctr_group_free(bts->ratectrs); bts->ratectrs = NULL; @@ -300,6 +317,16 @@ bts->statg = osmo_stat_item_group_alloc(tall_pcu_ctx, &bts_statg_desc, 0); OSMO_ASSERT(bts->statg); + osmo_time_cc_init(&bts->all_allocated_pdch); + struct osmo_time_cc_cfg *cc_cfg = &bts->all_allocated_pdch.cfg; + cc_cfg->gran_usec = 1*1000000, + cc_cfg->forget_sum_usec = 60*1000000, + cc_cfg->rate_ctr = rate_ctr_group_get_ctr(bts->ratectrs, CTR_PDCH_ALL_ALLOCATED), + cc_cfg->T_gran = -16, + cc_cfg->T_round_threshold = -17, + cc_cfg->T_forget_sum = -18, + cc_cfg->T_defs = T_defs_bts, + llist_add_tail(&bts->list, &pcu->bts_list); INIT_LLIST_HEAD(&bts->pch_timer); @@ -1371,3 +1398,20 @@ * B.2 Closed loop control */ return 0; } + +/* Used by counter availablePDCHAllocatedTime, TS 52.402 B.2.1.45 "All available PDCH allocated time" */ +bool bts_all_pdch_allocated(const struct gprs_rlcmac_bts *bts) +{ + unsigned trx_no, ts_no; + for (trx_no = 0; trx_no < ARRAY_SIZE(bts->trx); trx_no++) { + const struct gprs_rlcmac_trx *trx = &bts->trx[trx_no]; + for (ts_no = 0; ts_no < ARRAY_SIZE(trx->pdch); ts_no++) { + const struct gprs_rlcmac_pdch *pdch = &trx->pdch[ts_no]; + if (!pdch_is_enabled(pdch)) + continue; + if(!pdch_is_full(pdch)) + return false; + } + } + return true; +} diff --git a/src/bts.h b/src/bts.h index f947a55..6bf62c7 100644 --- a/src/bts.h +++ b/src/bts.h @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -84,6 +85,7 @@ enum { + CTR_PDCH_ALL_ALLOCATED, CTR_TBF_DL_ALLOCATED, CTR_TBF_DL_FREED, CTR_TBF_DL_ABORTED, @@ -278,6 +280,8 @@ /* List of struct bts_pch_timer for active PCH pagings */ struct llist_head pch_timer; + + struct osmo_time_cc all_allocated_pdch; }; #ifdef __cplusplus @@ -381,6 +385,7 @@ bool bts_cs_dl_is_supported(const struct gprs_rlcmac_bts *bts, enum CodingScheme cs); const struct llist_head* bts_ms_list(struct gprs_rlcmac_bts *bts); uint8_t bts_get_ms_pwr_alpha(const struct gprs_rlcmac_bts *bts); +bool bts_all_pdch_allocated(const struct gprs_rlcmac_bts *bts); #ifdef __cplusplus } #endif diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index 5ed9d7d..8b8e46b 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -47,8 +47,21 @@ { .T=0, .default_val=0, .unit=OSMO_TDEF_S, .desc=NULL, .val=0 } /* empty item at the end */ }; +static void _update_stats_timer_cb(void *data) +{ + struct gprs_pcu *pcu = (struct gprs_pcu *)data; + struct gprs_rlcmac_bts *bts; + + llist_for_each_entry(bts, &pcu->bts_list, list) + osmo_time_cc_set_flag(&bts->all_allocated_pdch, bts_all_pdch_allocated(bts)); + + osmo_timer_schedule(&pcu->update_stats_timer, 1, 0); +} + static int gprs_pcu_talloc_destructor(struct gprs_pcu *pcu) { + if (osmo_timer_pending(&pcu->update_stats_timer)) + osmo_timer_del(&pcu->update_stats_timer); neigh_cache_free(pcu->neigh_cache); si_cache_free(pcu->si_cache); return 0; @@ -125,6 +138,9 @@ pcu->neigh_cache = neigh_cache_alloc(pcu, osmo_tdef_get(pcu->T_defs, PCU_TDEF_NEIGH_CACHE_ALIVE, OSMO_TDEF_S, -1)); pcu->si_cache = si_cache_alloc(pcu, osmo_tdef_get(pcu->T_defs, PCU_TDEF_SI_CACHE_ALIVE, OSMO_TDEF_S, -1)); + osmo_timer_setup(&pcu->update_stats_timer, _update_stats_timer_cb, pcu); + osmo_timer_schedule(&pcu->update_stats_timer, 1, 0); + return pcu; } diff --git a/src/gprs_pcu.h b/src/gprs_pcu.h index ed00221..a9e40ea 100644 --- a/src/gprs_pcu.h +++ b/src/gprs_pcu.h @@ -25,6 +25,7 @@ #include #include +#include #include "gprs_bssgp_pcu.h" #include "coding_scheme.h" @@ -131,6 +132,8 @@ struct neigh_cache *neigh_cache; /* ARFC+BSIC -> CGI PS cache */ struct si_cache *si_cache; /* ARFC+BSIC -> CGI PS cache */ + + struct osmo_timer_list update_stats_timer; /* Used to update some time_cc stats periodically */ }; diff --git a/src/pdch.cpp b/src/pdch.cpp index a942b01..a5eb080 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -1286,3 +1286,13 @@ { return pdch->is_enabled(); } + +/* To be called only on enabled PDCHs. Used to gather information on whether the + * PDCH is currently unable to allocate more TBFs due to any resource being + * full. Used by bts_all_pdch_allocated() for counting purposes. */ +bool pdch_is_full(const struct gprs_rlcmac_pdch *pdch) +{ + return pdch->assigned_tfi(GPRS_RLCMAC_UL_TBF) == NO_FREE_TFI || + pdch->assigned_tfi(GPRS_RLCMAC_DL_TBF) == NO_FREE_TFI || + find_free_usf(pdch->assigned_usf()) < 0; +} diff --git a/src/pdch.h b/src/pdch.h index 9405606..759d7f9 100644 --- a/src/pdch.h +++ b/src/pdch.h @@ -194,6 +194,7 @@ void pdch_free_all_tbf(struct gprs_rlcmac_pdch *pdch); void pdch_disable(struct gprs_rlcmac_pdch *pdch); bool pdch_is_enabled(const struct gprs_rlcmac_pdch *pdch); +bool pdch_is_full(const struct gprs_rlcmac_pdch *pdch); #ifdef __cplusplus } #endif diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index 1f2bbda..6f3de43 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -152,6 +152,8 @@ OSMO_ASSERT(i == count); + OSMO_ASSERT(bts_all_pdch_allocated(bts)); + for (i = 0; i < count; ++i) if (tbfs[i]) tbf_free(tbfs[i]); @@ -479,6 +481,7 @@ tbf_free(ms_ul_tbf(old_ms)); tbf = tbf_alloc_ul_tbf(bts, old_ms, trx_no, false); if (tbf == NULL) { + OSMO_ASSERT(trx_no != -1 || bts_all_pdch_allocated(bts)); ms_unref(old_ms); return NULL; } @@ -490,6 +493,7 @@ tbf_free(ms_dl_tbf(old_ms)); tbf = tbf_alloc_dl_tbf(bts, old_ms, trx_no, false); if (tbf == NULL) { + OSMO_ASSERT(trx_no != -1 || bts_all_pdch_allocated(bts)); ms_unref(old_ms); return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie0f0c451558817bddc3fe1a0f0df531f14c9f1d3 Gerrit-Change-Number: 26210 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 13:53:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 13:53:00 +0000 Subject: Change in osmo-pcu[master]: T_defs_pcu: Set default val for X2000 to 0 ms References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26251 ) Change subject: T_defs_pcu: Set default val for X2000 to 0 ms ...................................................................... T_defs_pcu: Set default val for X2000 to 0 ms That timer is really only useful to free the tbf asyncrhonously after generating the Pkt Access Reject message, since we have nothing to do with it after the message is sent, and the dummt TBF doesn't really hold any reserved resource such as USF or TFI. The timer is useful to still do the freeing asyncrhonously, since the scheduler is interacting with the TBF during the code path, but there's no real need to keep the object alive for 2 ms afterwards. Having a default value of 0 ms is enough, since it fullfills the requirement of freeing asnchronously. Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be --- M src/gprs_pcu.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/26251/1 diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index 5ed9d7d..8fe784d 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -39,7 +39,7 @@ { .T=PCU_TDEF_SI_CACHE_ALIVE, .default_val=5, .unit=OSMO_TDEF_S, .desc="[RAC+CI]->[SI] resolution cache entry storage timeout (s)", .val=0 }, { .T=-101, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP (un)blocking procedures timer (s)", .val=0 }, { .T=-102, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP reset procedure timer (s)", .val=0 }, - { .T=-2000, .default_val=2, .unit=OSMO_TDEF_MS, .desc="Delay release of UL TBF after tx Packet Access Reject (PACCH) (ms)", .val=0 }, + { .T=-2000, .default_val=0, .unit=OSMO_TDEF_MS, .desc="Delay release of UL TBF after tx Packet Access Reject (PACCH) (ms)", .val=0 }, { .T=-2001, .default_val=2, .unit=OSMO_TDEF_S, .desc="PACCH assignment timeout (s)", .val=0 }, { .T=-2002, .default_val=200, .unit=OSMO_TDEF_MS, .desc="Waiting after IMM.ASS confirm timer (ms)", .val=0 }, { .T=-2030, .default_val=60, .unit=OSMO_TDEF_S, .desc="Time to keep an idle MS object alive (s)", .val=0 }, /* slightly above T3314 (default 44s, 24.008, 11.2.2) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be Gerrit-Change-Number: 26251 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 13:54:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 13:54:17 +0000 Subject: Change in osmo-pcu[master]: T_defs_pcu: Set default val for X2000 to 0 ms In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/26251 ) Change subject: T_defs_pcu: Set default val for X2000 to 0 ms ...................................................................... T_defs_pcu: Set default val for X2000 to 0 ms That timer is really only useful to free the tbf asyncrhonously after generating the Pkt Access Reject message, since we have nothing to do with it after the message is sent, and the dummt TBF doesn't really hold any reserved resource such as USF or TFI. The timer is useful to still do the freeing asyncrhonously, since the scheduler is interacting with the TBF during the code path, but there's no real need to keep the object alive for 2 ms afterwards. Having a default value of 0 ms is enough, since it fullfills the requirement of freeing asnchronously. The value of 2 ms was set initially when the reject support was added here (e9a138e11111f509f988807bbdc5ca8cce2b3d3d), with no specific explanation on the 2 ms value. It was just probably picked as a convinience one, but 0 is actually more convinient. Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be --- M src/gprs_pcu.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/26251/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be Gerrit-Change-Number: 26251 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 14:24:15 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 14:24:15 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26165 to look at the new patch set (#5). Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 5 files changed, 166 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 14:24:15 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 14:24:15 +0000 Subject: Change in pysim[master]: pySim-shell: export command: guess number of records when not specified In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26204 to look at the new patch set (#3). Change subject: pySim-shell: export command: guess number of records when not specified ...................................................................... pySim-shell: export command: guess number of records when not specified The select response of an UICC will always return the number of records of a file. However, older SIM will not include the number of records in the select response. In those cases, simply guess the number of records by reading until the first invalid record is hit. Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Related: OS#5274 --- M pySim-shell.py 1 file changed, 22 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/26204/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 15:12:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 15:12:51 +0000 Subject: Change in osmo-pcu[master]: T_defs_pcu: Set default val for X2000 to 0 ms In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26251 ) Change subject: T_defs_pcu: Set default val for X2000 to 0 ms ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be Gerrit-Change-Number: 26251 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 15:13:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 15:13:01 +0000 Subject: Change in osmo-pcu[master]: T_defs_pcu: Set default val for X2000 to 0 ms In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26251 ) Change subject: T_defs_pcu: Set default val for X2000 to 0 ms ...................................................................... Patch Set 2: Verified+1 linter doesn't apply here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be Gerrit-Change-Number: 26251 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 15:13:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 15:26:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 15:26:38 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: No need to set t3142 in TC_ratectr_all_available_allocated References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 ) Change subject: pcu: No need to set t3142 in TC_ratectr_all_available_allocated ...................................................................... pcu: No need to set t3142 in TC_ratectr_all_available_allocated That's a copy-past arfifact from another test. Change-Id: Ib0ec4a9bb4f48330ab5ced94fe6b705a9fc69603 --- M pcu/PCU_Tests.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/26252/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index a191cc5..40dd400 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -6511,7 +6511,6 @@ var BIT11 ra11; info_ind := valueof(ts_PCUIF_INFO_default); - info_ind.t3142 := 3; /* Only the first TRX is enabled. */ f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); @@ -6540,7 +6539,7 @@ rest := tr_IARRestOctets({ *, tr_ExtRAOpt(substr(ra11, 6, 5)), * }); /* At this point, the IUT should run out of free USFs */ - f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); + f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest); /* bts.0.pdch.all_allocated is updated once per second, wait some time to make sure it was updated. */ f_sleep(2.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0ec4a9bb4f48330ab5ced94fe6b705a9fc69603 Gerrit-Change-Number: 26252 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 16:30:16 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 16:30:16 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: dexter has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... cards: Make select_adf_by_aid() use prefix AID selection There is no need for us to expand a partial AID to the full AID before selecting that ADF. The UICC specifications permit AID selection by prefix only. So we can pass the prefix to the card, and the card will do the prefix matching. >From the API user point of view, this allows us to select applications not listed in EF.DIR Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 --- M pySim/cards.py 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/25873/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 16:30:17 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 16:30:17 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... pySim-read: put try/catch block around select_adf_by_aid() Selecting an application may fail, especially when the application does not exist on the card. Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef --- M pySim-read.py 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/26253/1 diff --git a/pySim-read.py b/pySim-read.py index 00194b4..0c09dac 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -219,7 +219,11 @@ # Check whether we have th AID of USIM, if so select it by its AID # EF.UST - File Id in ADF USIM : 6f38 - data, sw = card.select_adf_by_aid(adf="usim") + try: + sw = 0 + data, sw = card.select_adf_by_aid(adf="usim") + except Exception as e: + print("ADF.USIM: Can't select application -- " + str(e)) if sw == '9000': # Select USIM profile usim_card = UsimCard(scc) @@ -269,7 +273,11 @@ print("ePDGSelection: Can't read file -- " + str(e)) # Select ISIM application by its AID - data, sw = card.select_adf_by_aid(adf="isim") + try: + sw = 0 + data, sw = card.select_adf_by_aid(adf="isim") + except Exception as e: + print("ADF.ISIM: Can't select application -- " + str(e)) if sw == '9000': # Select USIM profile isim_card = IsimCard(scc) @@ -320,10 +328,6 @@ except Exception as e: print("UICC IARI: Can't read file -- " + str(e)) - # Check whether we have th AID of ISIM, if so select it by its AID - # EF.IST - File Id in ADF ISIM : 6f07 - data, sw = card.select_adf_by_aid(adf="isim") - if sw == '9000': # EF.IST (res, sw) = card.read_binary('6f07') if sw == '9000': -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 16:50:08 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 16:50:08 +0000 Subject: Change in pysim[master]: test References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26254 ) Change subject: test ...................................................................... test Change-Id: I612fdd6341db5bc5114dbdc29e04faa4e9b22238 --- M pySim-read.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/26254/1 diff --git a/pySim-read.py b/pySim-read.py index 0c09dac..aa38a55 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -223,7 +223,8 @@ sw = 0 data, sw = card.select_adf_by_aid(adf="usim") except Exception as e: - print("ADF.USIM: Can't select application -- " + str(e)) + pass +# print("ADF.USIM: Can't select application -- " + str(e)) if sw == '9000': # Select USIM profile usim_card = UsimCard(scc) @@ -277,7 +278,8 @@ sw = 0 data, sw = card.select_adf_by_aid(adf="isim") except Exception as e: - print("ADF.ISIM: Can't select application -- " + str(e)) + pass +# print("ADF.ISIM: Can't select application -- " + str(e)) if sw == '9000': # Select USIM profile isim_card = IsimCard(scc) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I612fdd6341db5bc5114dbdc29e04faa4e9b22238 Gerrit-Change-Number: 26254 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 16:57:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 16:57:12 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 16:57:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 16:59:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 16:59:28 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 16:59:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:00:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:00:00 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: call bootstrap_bts when OML TEI comes up In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25767 ) Change subject: osmo_bsc_main: call bootstrap_bts when OML TEI comes up ...................................................................... osmo_bsc_main: call bootstrap_bts when OML TEI comes up At the moment check_bts and bootstrap_bts is called only once on startup. When a new BTS is set up during runtime bootstrap_bts, nor check_bts is called. This means that some parameters of the BTS stay uninitalized until osmo-bsc is restarted. Lets rather call check_bts() and then bootstrap_bts() when the OML TEI of the BTS comes up. Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index fae2ef2..ae9bd69 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -477,6 +477,7 @@ { struct input_signal_data *isd = signal_data; struct gsm_bts_trx *trx = isd->trx; + int rc; if (subsys != SS_L_INPUT) return -EINVAL; @@ -489,9 +490,24 @@ /* Generate Mobile Allocation bit-masks for all timeslots. * This needs to be done here, because it's used for TS configuration. */ generate_ma_for_bts(trx->bts); + /* Check parameters and apply vty config dependent parameters */ + rc = check_bts(trx->bts); + if (rc < 0) { + LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap BTS\n", + trx->bts->nr); + return rc; + } + bootstrap_bts(trx->bts); } - if (isd->link_type == E1INP_SIGN_RSL) + if (isd->link_type == E1INP_SIGN_RSL) { + rc = check_bts(trx->bts); + if (rc < 0) { + LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap RSL\n", + trx->bts->nr); + return rc; + } bootstrap_rsl(trx); + } break; case S_L_INP_TEI_DN: LOG_TRX(trx, DLMI, LOGL_ERROR, "Lost E1 %s link\n", e1inp_signtype_name(isd->link_type)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie599f809623efd6ea4ab3f39294195fc1ef84b85 Gerrit-Change-Number: 25767 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:00:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:00:01 +0000 Subject: Change in osmo-bsc[master]: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26187 ) Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() The function generate_ma_for_bts() is called when the OML TEI comes up. In the same code path boostrap_bts() is called as well. It would be more logical to call generate_ma_for_bts() from boostrap_bts() since it is also part of the bootstrapping process. Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index ae9bd69..2436641 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -469,6 +469,10 @@ /* Initialize the BTS state */ gsm_bts_sm_mo_reset(bts->site_mgr); + + /* Generate Mobile Allocation bit-masks for all timeslots. + * This needs to be done here, because it's used for TS configuration. */ + generate_ma_for_bts(bts); } /* Callback function to be called every time we receive a signal from INPUT */ @@ -487,9 +491,6 @@ switch (signal) { case S_L_INP_TEI_UP: if (isd->link_type == E1INP_SIGN_OML) { - /* Generate Mobile Allocation bit-masks for all timeslots. - * This needs to be done here, because it's used for TS configuration. */ - generate_ma_for_bts(trx->bts); /* Check parameters and apply vty config dependent parameters */ rc = check_bts(trx->bts); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:02:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:02:09 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py at 977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: > sorry, but this argument doesn't hold up. [?] I see no change or feedback regarding this in the latest patch version -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Nov 2021 17:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:05:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:05:12 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 to look at the new patch set (#3). Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... stp: Add basic RX/TX rate counters on AS and ASP level This adds some very basic rx/px rate counters to the SS7 AS and ASP OsmoSTP> show rate-counters SIGTRAN Application Server 0 (as-rkm-1): rx:msu:total: 86078 (1888/s 86078/m 0/h 0/d) tx:msu:total: 0 (0/s 0/m 0/h 0/d) SIGTRAN Application Server Process 0 (asp-dyn-0): rx:packets:total: 86081 (1888/s 86081/m 0/h 0/d) tx:packets:total: 5 (0/s 5/m 0/h 0/d) Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 --- M include/osmocom/sigtran/osmo_ss7.h M src/ipa.c M src/m3ua.c M src/osmo_ss7.c M src/osmo_ss7_hmrt.c M src/ss7_internal.h M src/sua.c M stp/stp_main.c 8 files changed, 83 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/34/26234/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:05:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:05:34 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... Patch Set 3: Code-Review+2 (2 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c at 900 PS2, Line 900: [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU receivved" }, > Ack Done https://gerrit.osmocom.org/c/libosmo-sccp/+/26234/2/src/osmo_ss7.c at 1157 PS2, Line 1157: received > transmitted Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 17:05:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:07:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:07:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: No need to set t3142 in TC_ratectr_all_available_allocated In-Reply-To: References: Message-ID: laforge has uploaded a new patch set (#2) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 ) Change subject: pcu: No need to set t3142 in TC_ratectr_all_available_allocated ...................................................................... pcu: No need to set t3142 in TC_ratectr_all_available_allocated That's a copy-paste artefact from another test. Change-Id: Ib0ec4a9bb4f48330ab5ced94fe6b705a9fc69603 --- M pcu/PCU_Tests.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/26252/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0ec4a9bb4f48330ab5ced94fe6b705a9fc69603 Gerrit-Change-Number: 26252 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:07:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:07:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: No need to set t3142 in TC_ratectr_all_available_allocated In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 ) Change subject: pcu: No need to set t3142 in TC_ratectr_all_available_allocated ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0ec4a9bb4f48330ab5ced94fe6b705a9fc69603 Gerrit-Change-Number: 26252 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 17:07:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:07:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:07:52 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: No need to set t3142 in TC_ratectr_all_available_allocated In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 ) Change subject: pcu: No need to set t3142 in TC_ratectr_all_available_allocated ...................................................................... pcu: No need to set t3142 in TC_ratectr_all_available_allocated That's a copy-paste artefact from another test. Change-Id: Ib0ec4a9bb4f48330ab5ced94fe6b705a9fc69603 --- M pcu/PCU_Tests.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index a191cc5..40dd400 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -6511,7 +6511,6 @@ var BIT11 ra11; info_ind := valueof(ts_PCUIF_INFO_default); - info_ind.t3142 := 3; /* Only the first TRX is enabled. */ f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); @@ -6540,7 +6539,7 @@ rest := tr_IARRestOctets({ *, tr_ExtRAOpt(substr(ra11, 6, 5)), * }); /* At this point, the IUT should run out of free USFs */ - f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); + f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest); /* bts.0.pdch.all_allocated is updated once per second, wait some time to make sure it was updated. */ f_sleep(2.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0ec4a9bb4f48330ab5ced94fe6b705a9fc69603 Gerrit-Change-Number: 26252 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:09:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:09:05 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Drop unsued X2000 timer callback In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26250 ) Change subject: tbf_dl_ass_fsm: Drop unsued X2000 timer callback ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b Gerrit-Change-Number: 26250 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 15 Nov 2021 17:09:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:10:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:10:32 +0000 Subject: Change in osmo-pcu[master]: T_defs_pcu: Set default val for X2000 to 0 ms In-Reply-To: References: Message-ID: laforge has uploaded a new patch set (#3) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26251 ) Change subject: T_defs_pcu: Set default val for X2000 to 0 ms ...................................................................... T_defs_pcu: Set default val for X2000 to 0 ms That timer is really only useful to free the tbf asynchronously after generating the Pkt Access Reject message, since we have nothing to do with it after the message is sent, and the dummt TBF doesn't really hold any reserved resource such as USF or TFI. The timer is useful to still do the freeing asyncrhonously, since the scheduler is interacting with the TBF during the code path, but there's no real need to keep the object alive for 2 ms afterwards. Having a default value of 0 ms is enough, since it fullfills the requirement of freeing asnchronously. The value of 2 ms was set initially when the reject support was added here (e9a138e11111f509f988807bbdc5ca8cce2b3d3d), with no specific explanation on the 2 ms value. It was just probably picked as a convinience one, but 0 is actually more convinient. Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be --- M src/gprs_pcu.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/26251/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be Gerrit-Change-Number: 26251 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:10:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:10:35 +0000 Subject: Change in osmo-pcu[master]: T_defs_pcu: Set default val for X2000 to 0 ms In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26251 ) Change subject: T_defs_pcu: Set default val for X2000 to 0 ms ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be Gerrit-Change-Number: 26251 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 17:10:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:10:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:10:55 +0000 Subject: Change in osmo-pcu[master]: tbf_dl_ass_fsm: Drop unsued X2000 timer callback In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26250 ) Change subject: tbf_dl_ass_fsm: Drop unsued X2000 timer callback ...................................................................... tbf_dl_ass_fsm: Drop unsued X2000 timer callback That timer is only relevant for transmission of Packet Access Reject, which happens only for Uplink assignment, and hence is only set in the timer of tbf_ul_ass_fsm, never in tbf_dl_ass_fsm. This is probably a copy-paste artifact when implementing both FSMs. Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b --- M src/tbf_dl_ass_fsm.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index 1d44c91..a5948e7 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -185,11 +185,7 @@ static int tbf_dl_ass_fsm_timer_cb(struct osmo_fsm_inst *fi) { - struct tbf_dl_ass_fsm_ctx *ctx = (struct tbf_dl_ass_fsm_ctx *)fi->priv; switch (fi->T) { - case -2000: - tbf_free(ctx->tbf); - break; default: OSMO_ASSERT(0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b Gerrit-Change-Number: 26250 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:10:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:10:56 +0000 Subject: Change in osmo-pcu[master]: T_defs_pcu: Set default val for X2000 to 0 ms In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26251 ) Change subject: T_defs_pcu: Set default val for X2000 to 0 ms ...................................................................... T_defs_pcu: Set default val for X2000 to 0 ms That timer is really only useful to free the tbf asynchronously after generating the Pkt Access Reject message, since we have nothing to do with it after the message is sent, and the dummt TBF doesn't really hold any reserved resource such as USF or TFI. The timer is useful to still do the freeing asyncrhonously, since the scheduler is interacting with the TBF during the code path, but there's no real need to keep the object alive for 2 ms afterwards. Having a default value of 0 ms is enough, since it fullfills the requirement of freeing asnchronously. The value of 2 ms was set initially when the reject support was added here (e9a138e11111f509f988807bbdc5ca8cce2b3d3d), with no specific explanation on the 2 ms value. It was just probably picked as a convinience one, but 0 is actually more convinient. Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be --- M src/gprs_pcu.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Verified diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index 8b8e46b..76dd5be 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -39,7 +39,7 @@ { .T=PCU_TDEF_SI_CACHE_ALIVE, .default_val=5, .unit=OSMO_TDEF_S, .desc="[RAC+CI]->[SI] resolution cache entry storage timeout (s)", .val=0 }, { .T=-101, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP (un)blocking procedures timer (s)", .val=0 }, { .T=-102, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP reset procedure timer (s)", .val=0 }, - { .T=-2000, .default_val=2, .unit=OSMO_TDEF_MS, .desc="Delay release of UL TBF after tx Packet Access Reject (PACCH) (ms)", .val=0 }, + { .T=-2000, .default_val=0, .unit=OSMO_TDEF_MS, .desc="Delay release of UL TBF after tx Packet Access Reject (PACCH) (ms)", .val=0 }, { .T=-2001, .default_val=2, .unit=OSMO_TDEF_S, .desc="PACCH assignment timeout (s)", .val=0 }, { .T=-2002, .default_val=200, .unit=OSMO_TDEF_MS, .desc="Waiting after IMM.ASS confirm timer (ms)", .val=0 }, { .T=-2030, .default_val=60, .unit=OSMO_TDEF_S, .desc="Time to keep an idle MS object alive (s)", .val=0 }, /* slightly above T3314 (default 44s, 24.008, 11.2.2) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be Gerrit-Change-Number: 26251 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:11:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:11:05 +0000 Subject: Change in libosmo-sccp[master]: stp: Add basic RX/TX rate counters on AS and ASP level In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 ) Change subject: stp: Add basic RX/TX rate counters on AS and ASP level ...................................................................... stp: Add basic RX/TX rate counters on AS and ASP level This adds some very basic rx/px rate counters to the SS7 AS and ASP OsmoSTP> show rate-counters SIGTRAN Application Server 0 (as-rkm-1): rx:msu:total: 86078 (1888/s 86078/m 0/h 0/d) tx:msu:total: 0 (0/s 0/m 0/h 0/d) SIGTRAN Application Server Process 0 (asp-dyn-0): rx:packets:total: 86081 (1888/s 86081/m 0/h 0/d) tx:packets:total: 5 (0/s 5/m 0/h 0/d) Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 --- M include/osmocom/sigtran/osmo_ss7.h M src/ipa.c M src/m3ua.c M src/osmo_ss7.c M src/osmo_ss7_hmrt.c M src/ss7_internal.h M src/sua.c M stp/stp_main.c 8 files changed, 83 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 3d13b6a..1755859 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -9,6 +9,7 @@ #include #include #include +#include extern struct llist_head osmo_ss7_instances; @@ -310,6 +311,9 @@ /*! Were we allocated by "simple client" support? */ bool simple_client_allocated; + /*! Rate Counter Group */ + struct rate_ctr_group *ctrg; + struct { char *name; char *description; @@ -412,6 +416,9 @@ /*! Were we allocated by "simple client" support? */ bool simple_client_allocated; + /*! Rate Counter Group */ + struct rate_ctr_group *ctrg; + /*! Pending message for non-blocking IPA read */ struct msgb *pending_msg; diff --git a/src/ipa.c b/src/ipa.c index 93edef8..5b1eb54 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -47,6 +47,7 @@ #include #include "xua_internal.h" +#include "ss7_internal.h" #include "xua_asp_fsm.h" @@ -224,6 +225,8 @@ return -1; } + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + /* pull the IPA header */ msgb_pull_to_l2(msg); diff --git a/src/m3ua.c b/src/m3ua.c index 607813f..26acc1b 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -44,6 +44,7 @@ #include "xua_as_fsm.h" #include "xua_asp_fsm.h" #include "xua_internal.h" +#include "ss7_internal.h" #define M3UA_MSGB_SIZE 1500 @@ -553,6 +554,8 @@ if (rc) return rc; + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + /* FIXME: check for AS state == ACTIVE */ /* store the MTP-level information in the xua_msg for use by diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 38206fb..5dd4a26 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -48,6 +48,7 @@ #include "sccp_internal.h" #include "xua_internal.h" +#include "ss7_internal.h" #include "xua_asp_fsm.h" #include "xua_as_fsm.h" @@ -895,6 +896,19 @@ * SS7 Application Server ***********************************************************************/ +static const struct rate_ctr_desc ss7_as_rcd[] = { + [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU received" }, + [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "Total number of MSU transmitted" }, +}; + +static const struct rate_ctr_group_desc ss7_as_rcgd = { + .group_name_prefix = "sigtran.as", + .group_description = "SIGTRAN Application Server", + .num_ctr = ARRAY_SIZE(ss7_as_rcd), + .ctr_desc = ss7_as_rcd, +}; +static unsigned int g_ss7_as_rcg_idx; + /*! \brief Find Application Server by given name * \param[in] inst SS7 Instance on which we operate * \param[in] name Name of AS @@ -1002,6 +1016,12 @@ as = talloc_zero(inst, struct osmo_ss7_as); if (!as) return NULL; + as->ctrg = rate_ctr_group_alloc(as, &ss7_as_rcgd, g_ss7_as_rcg_idx++); + if (!as->ctrg) { + talloc_free(as); + return NULL; + } + rate_ctr_group_set_name(as->ctrg, name); as->inst = inst; as->cfg.name = talloc_strdup(as, name); as->cfg.proto = proto; @@ -1125,6 +1145,26 @@ * SS7 Application Server Process ***********************************************************************/ +enum ss7_asp_ctr { + SS7_ASP_CTR_PKT_RX_TOTAL, + SS7_ASP_CTR_PKT_RX_UNKNOWN, + SS7_ASP_CTR_PKT_TX_TOTAL, +}; + +static const struct rate_ctr_desc ss7_asp_rcd[] = { + [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "Total number of packets received" }, + [SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx.packets.unknown", "Number of packets received for unknown PPID" }, + [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx.packets.total", "Total number of packets transmitted" }, +}; + +static const struct rate_ctr_group_desc ss7_asp_rcgd = { + .group_name_prefix = "sigtran.asp", + .group_description = "SIGTRAN Application Server Process", + .num_ctr = ARRAY_SIZE(ss7_asp_rcd), + .ctr_desc = ss7_asp_rcd, +}; +static unsigned int g_ss7_asp_rcg_idx; + int osmo_ss7_asp_peer_snprintf(char* buf, size_t buf_len, struct osmo_ss7_asp_peer *peer) { int len = 0, offset = 0, rem = buf_len; @@ -1485,6 +1525,12 @@ if (!asp) { /* FIXME: check if local port has SCTP? */ asp = talloc_zero(inst, struct osmo_ss7_asp); + asp->ctrg = rate_ctr_group_alloc(asp, &ss7_asp_rcgd, g_ss7_asp_rcg_idx++); + if (!asp->ctrg) { + talloc_free(asp); + return NULL; + } + rate_ctr_group_set_name(asp->ctrg, name); asp->inst = inst; asp->cfg.remote.port = remote_port; asp->cfg.local.port = local_port; @@ -1781,6 +1827,8 @@ msgb_sctp_stream(msg) = sinfo.sinfo_stream; msg->dst = asp; + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); + if (ppid == SUA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_SUA) rc = sua_rx_msg(asp, msg); else if (ppid == M3UA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_M3UA) @@ -1860,6 +1908,7 @@ return -1; } msg->dst = asp; + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); return ipa_rx_msg(asp, msg); } @@ -1918,6 +1967,8 @@ msgb_sctp_stream(msg) = sinfo.sinfo_stream; msg->dst = asp; + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); + if (ppid == SUA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_SUA) rc = sua_rx_msg(asp, msg); else if (ppid == M3UA_PPID && asp->cfg.proto == OSMO_SS7_ASP_PROT_M3UA) @@ -2086,6 +2137,8 @@ OSMO_ASSERT(0); } + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_TX_TOTAL); + if (asp->cfg.is_server) { if (!asp->server) { LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, no asp->server\n"); @@ -2361,6 +2414,8 @@ int ss7_asp_rx_unknown(struct osmo_ss7_asp *asp, int ppid_mux, struct msgb *msg) { + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_UNKNOWN); + if (g_osmo_ss7_asp_rx_unknown_cb) return (*g_osmo_ss7_asp_rx_unknown_cb)(asp, ppid_mux, msg); diff --git a/src/osmo_ss7_hmrt.c b/src/osmo_ss7_hmrt.c index 882d85d..f5fcd64 100644 --- a/src/osmo_ss7_hmrt.c +++ b/src/osmo_ss7_hmrt.c @@ -35,6 +35,7 @@ #include #include "xua_internal.h" +#include "ss7_internal.h" /* convert from M3UA message to MTP-TRANSFER.ind osmo_mtp_prim */ struct osmo_mtp_prim *m3ua_to_xfer_ind(struct xua_msg *xua) @@ -227,6 +228,8 @@ dpc, osmo_ss7_pointcode_print(inst, dpc), rt_name); } + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TX_MSU_TOTAL); + switch (as->cfg.proto) { case OSMO_SS7_ASP_PROT_M3UA: DEBUGP(DLSS7, "rt->dest.as proto is M3UA for dpc=%u=%s\n", diff --git a/src/ss7_internal.h b/src/ss7_internal.h index 28e239c..712a6ed 100644 --- a/src/ss7_internal.h +++ b/src/ss7_internal.h @@ -7,3 +7,8 @@ bool osmo_ss7_asp_set_default_peer_hosts(struct osmo_ss7_asp *asp); bool osmo_ss7_xua_server_set_default_local_hosts(struct osmo_xua_server *oxs); + +enum ss7_as_ctr { + SS7_AS_CTR_RX_MSU_TOTAL, + SS7_AS_CTR_TX_MSU_TOTAL, +}; diff --git a/src/sua.c b/src/sua.c index 8415fa3..000f064 100644 --- a/src/sua.c +++ b/src/sua.c @@ -46,6 +46,7 @@ #include "xua_asp_fsm.h" #include "xua_internal.h" #include "sccp_internal.h" +#include "ss7_internal.h" /* Appendix C.4 of Q.714 (all in milliseconds) */ #define CONNECTION_TIMER ( 1 * 60 * 100) @@ -521,6 +522,8 @@ if (rc) return rc; + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + switch (xua->hdr.msg_type) { case 0: /* Reserved, permitted by ETSI TS 101 592 5.2.3.2 */ case SUA_CL_CLDT: @@ -549,6 +552,8 @@ if (rc) return rc; + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_MSU_TOTAL); + switch (xua->hdr.msg_type) { case 0: /* Reserved, permitted by ETSI TS 101 592 5.2.3.2 */ case SUA_CO_CORE: diff --git a/stp/stp_main.c b/stp/stp_main.c index 1e83615..569cf8e 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -254,6 +255,7 @@ signal(SIGUSR1, &signal_handler); signal(SIGUSR2, &signal_handler); osmo_init_ignore_signals(); + rate_ctr_init(tall_stp_ctx); if (cmdline_config.daemonize) { rc = osmo_daemonize(); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idb811ca81adfe47152d484f6b981e661dc569e15 Gerrit-Change-Number: 26234 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:11:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:11:06 +0000 Subject: Change in libosmo-sccp[master]: spelling fixes in comments In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 ) Change subject: spelling fixes in comments ...................................................................... spelling fixes in comments Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f --- M src/ipa.c M src/m3ua.c M src/osmo_ss7.c M src/sccp_sclc.c M src/sccp_scoc.c M src/sccp_scrc.c 6 files changed, 20 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved dexter: Looks good to me, approved diff --git a/src/ipa.c b/src/ipa.c index 5b1eb54..8daa5e0 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -135,7 +135,7 @@ { struct osmo_ss7_as *as; - /* in the IPA case, weassume there is a 1:1 mapping between the + /* in the IPA case, we assume there is a 1:1 mapping between the * ASP and the AS. An AS without ASP means there is no * connection, and an ASP without AS means that we don't (yet?) * know the identity of the peer */ @@ -301,7 +301,7 @@ OSMO_ASSERT(asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA); /* osmo_ipa_process_msg() will already have verified length - * consistency and set up l2h poiter */ + * consistency and set up l2h pointer */ hh = (struct ipaccess_head *) msg->l1h; switch (hh->proto) { diff --git a/src/m3ua.c b/src/m3ua.c index 26acc1b..741063c 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -449,7 +449,7 @@ } /*********************************************************************** - * Transmitting M3UA messsages to SCTP + * Transmitting M3UA messages to SCTP ***********************************************************************/ /* Convert M3UA from xua_msg to msgb and set PPID/stream */ @@ -512,7 +512,7 @@ } /*********************************************************************** - * Receiving M3UA messsages from SCTP + * Receiving M3UA messages from SCTP ***********************************************************************/ /* obtain the destination point code from a M3UA message in XUA fmt * */ @@ -694,7 +694,7 @@ OSMO_ASSERT(asp->cfg.proto == OSMO_SS7_ASP_PROT_M3UA); /* caller owns msg memory, we shall neither free it here nor - * keep references beyond the executin of this function and its + * keep references beyond the execution of this function and its * callees */ xua = xua_from_msg(M3UA_VERSION, msgb_length(msg), msgb_data(msg)); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 5dd4a26..76fbdbd 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -615,7 +615,7 @@ * SS7 Link ***********************************************************************/ -/*! \brief Destryo SS7 Link +/*! \brief Destroy SS7 Link * \param[in] link SS7 Link to be destroyed */ void osmo_ss7_link_destroy(struct osmo_ss7_link *link) { @@ -999,7 +999,7 @@ * \param[in] inst SS7 Instance on which we operate * \param[in] name Name of Application Server * \param[in] proto Protocol of Application Server - * \returns pointer to Application Server on suuccess; NULL otherwise */ + * \returns pointer to Application Server on success; NULL otherwise */ struct osmo_ss7_as * osmo_ss7_as_find_or_create(struct osmo_ss7_instance *inst, const char *name, enum osmo_ss7_asp_protocol proto) @@ -1201,7 +1201,7 @@ * \param[in] talloc_ctx talloc context used to allocate new addresses. * \param[in] hosts Array of strings containing IP addresses. * \param[in] host_cnt Number of strings in hosts - * \returns 0 on success; negtive otherwise */ + * \returns 0 on success; negative otherwise */ int osmo_ss7_asp_peer_set_hosts(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char* const* hosts, size_t host_cnt) { int i = 0; @@ -1231,7 +1231,7 @@ } /*! \brief Append (copy) address to a given ASP peer. Previous addresses are kept. - * \param[in] peer Application Server Process peer the address is appened to. + * \param[in] peer Application Server Process peer the address is appended to. * \param[in] talloc_ctx talloc context used to allocate new address. * \param[in] host string containing an IP addresses. * \returns 0 on success; negative otherwise */ diff --git a/src/sccp_sclc.c b/src/sccp_sclc.c index 218fb56..186efbd 100644 --- a/src/sccp_sclc.c +++ b/src/sccp_sclc.c @@ -36,7 +36,7 @@ * However, all SCCP features can be expressed in SUA. * * The code only supports Class 2. No support for Class 3 is intended, - * but patches are of course alwys welcome. + * but patches are of course always welcome. * * Missing other features: * * Segmentation/Reassembly support @@ -119,7 +119,7 @@ * The caller is required to free oph->msg, otherwise the same as sccp_sclc_user_sap_down(). * \param[in] scu SCCP User who is sending the primitive * \param[on] oph Osmocom primitive header of the primitive - * \returns 0 on success; negtive in case of error */ + * \returns 0 on success; negative in case of error */ int sccp_sclc_user_sap_down_nofree(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph) { struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph; @@ -143,7 +143,7 @@ * Implies a msgb_free(oph->msg), otherwise the same as sccp_sclc_user_sap_down_nofree(). * \param[in] scu SCCP User who is sending the primitive * \param[on] oph Osmocom primitive header of the primitive - * \returns 0 on success; negtive in case of error */ + * \returns 0 on success; negative in case of error */ int sccp_sclc_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph) { struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph; diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 244e6d3..5f109b3 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -36,7 +36,7 @@ * However, all SCCP features can be expressed in SUA. * * The code only supports Class 2. No support for Class 3 is intended, - * but patches are of course alwys welcome. + * but patches are of course always welcome. * * Missing other features: * * Segmentation/Reassembly support @@ -80,7 +80,7 @@ /* remote point code */ uint32_t remote_pc; - /* local/remote addresses and identiies */ + /* local/remote addresses and identities */ struct osmo_sccp_addr calling_addr; struct osmo_sccp_addr called_addr; /* SCCP connection identifier. Only relevant across the SCCP User SAP, @@ -90,7 +90,7 @@ /* SCCP Remote Connection Reference. Allocated by the remote * SCCP stack to uniquely identify a SCCP connection on its end. * We don't interpret it, but simply cache it here so we can use - * it whever sending data to the peer. Only relevant over the + * it whenever sending data to the peer. Only relevant over the * wire, not to be used across the SCCP user SAP */ uint32_t remote_ref; @@ -1521,7 +1521,7 @@ xua_msg_free(xua); } -/* process received message for unasigned local reference */ +/* process received message for unassigned local reference */ static void sccp_scoc_rx_unass_local_ref(struct osmo_sccp_instance *inst, struct xua_msg *xua) { @@ -1631,7 +1631,7 @@ /* we basically try to convert the SUA message into an event, * and then dispatch the event to the connection-specific FSM. * If it is a CORE (Connect REquest), we create the connection - * (and imlpicitly its FSM) first */ + * (and implicitly its FSM) first */ if (xua->hdr.msg_type == SUA_CO_CORE) { scu = sccp_find_user(inst, xua); diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c index 1da3890..be23c21 100644 --- a/src/sccp_scrc.c +++ b/src/sccp_scrc.c @@ -85,7 +85,7 @@ return -1; } - /* 2) wrap into MTP-TRANSFER.req primtiive */ + /* 2) wrap into MTP-TRANSFER.req primitive */ msg->l2h = msg->data; omp = (struct osmo_mtp_prim *) msgb_push(msg, sizeof(*omp)); osmo_prim_init(&omp->oph, MTP_SAP_USER, @@ -109,7 +109,7 @@ return osmo_ss7_user_mtp_xfer_req(s7i, omp); } -/* Gererate MTP-TRANSFER.req from xUA message */ +/* Generate MTP-TRANSFER.req from xUA message */ static int gen_mtp_transfer_req_xua(struct osmo_sccp_instance *inst, struct xua_msg *xua, const struct osmo_sccp_addr *called) @@ -230,7 +230,7 @@ /* Connection Oriented? */ if (sua_is_connectionless(xua)) { /* TODO: Perform Capability Test */ - /* TODO: Canges Needed? */ + /* TODO: Changes Needed? */ if (0) { /* Changes Needed -> SCLC */ return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4ecd9a1c5241cfd3a3e1daf05f7826876371369f Gerrit-Change-Number: 26248 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:12:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:12:20 +0000 Subject: Change in osmocom-bb[master]: logging: use meaningful default loglevels In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16892 ) Change subject: logging: use meaningful default loglevels ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/16892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3faefccae2218b17bd942bc2afac7d8e515897b7 Gerrit-Change-Number: 16892 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 17:12:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:12:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Nov 2021 17:12:22 +0000 Subject: Change in osmocom-bb[master]: logging: use meaningful default loglevels In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16892 ) Change subject: logging: use meaningful default loglevels ...................................................................... logging: use meaningful default loglevels Some logging categories use LOGL_INFO or even LOGL_DEBUG. Lets set those to LOGL_NOTICE to have a less crowded default log output. Change-Id: I3faefccae2218b17bd942bc2afac7d8e515897b7 Related: OS#2577 --- M src/host/layer23/src/common/logging.c M src/host/virt_phy/src/logging.c 2 files changed, 20 insertions(+), 20 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/layer23/src/common/logging.c b/src/host/layer23/src/common/logging.c index ed79991..636a615 100644 --- a/src/host/layer23/src/common/logging.c +++ b/src/host/layer23/src/common/logging.c @@ -36,7 +36,7 @@ .name = "DCS", .description = "Cell selection", .color = "\033[34m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DNB] = { .name = "DNB", @@ -48,54 +48,54 @@ .name = "DPLMN", .description = "PLMN selection", .color = "\033[32m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DRR] = { .name = "DRR", .description = "Radio Resource", .color = "\033[1;34m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DMM] = { .name = "DMM", .description = "Mobility Management", .color = "\033[1;32m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DCC] = { .name = "DCC", .description = "Call Control", .color = "\033[1;33m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DSS] = { .name = "DSS", .description = "Supplenmentary Services", .color = "\033[1;35m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DSMS] = { .name = "DSMS", .description = "Short Message Service", .color = "\033[1;37m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DMNCC] = { .name = "DMNCC", .description = "Mobile Network Call Control", .color = "\033[1;37m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DMEAS] = { .name = "DMEAS", .description = "MEasurement Reporting", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DPAG] = { .name = "DPAG", .description = "Paging", .color = "\033[33m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DL1C] = { .name = "DL1C", @@ -107,37 +107,37 @@ .name = "DSAP", .description = "SAP Control", .color = "\033[1;31m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DSUM] = { .name = "DSUM", .description = "Summary of Process", .color = "\033[1;37m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DSIM] = { .name = "DSIM", .description = "SIM client", .color = "\033[0;35m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DGPS] = { .name = "DGPS", .description = "GPS", .color = "\033[1;35m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DMOB] = { .name = "DMOB", .description = "Mobile", .color = "\033[1;35m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DPRIM] = { .name = "DPRIM", .description = "PRIM", .color = "\033[1;32m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, [DLUA] = { .name = "DLUA", diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c index 11a21a3..f898a08 100644 --- a/src/host/virt_phy/src/logging.c +++ b/src/host/virt_phy/src/logging.c @@ -70,28 +70,28 @@ .description = "Layer 1 Control", .color = "\033[1;31m", .enabled = 1, - .loglevel = LOGL_INFO, + .loglevel = LOGL_NOTICE, }, [DL1P] = { .name = "DL1P", .description = "Layer 1 Data", .color = "\033[1;31m", .enabled = 1, - .loglevel = LOGL_INFO, + .loglevel = LOGL_NOTICE, }, [DVIRPHY] = { .name = "DVIRPHY", .description = "Virtual Layer 1 Interface", .color = "\033[1;31m", .enabled = 1, - .loglevel = LOGL_INFO, + .loglevel = LOGL_NOTICE, }, [DMAIN] = { .name = "DMAIN", .description = "Main Program / Data Structures", .color = "\033[1;32m", .enabled = 1, - .loglevel = LOGL_INFO, + .loglevel = LOGL_NOTICE, }, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/16892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3faefccae2218b17bd942bc2afac7d8e515897b7 Gerrit-Change-Number: 16892 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:25:59 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 15 Nov 2021 17:25:59 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 5: The reason why this failed in the first place was just because it tried to select an ADF.USIM on a sysmo-sim-gr1, this does not work of course but can also be fixed very easily by catching the exceptions. However, until now I found two cards that seem not to tolerate the select with the short AIDs. sysmo-usim-sjs1 and farwaves-sim are those two. They come back with SW=6a82, which is "File not found". Maybe the select command needs some additional flags. I will have a look in the spec and retry this if necessary. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Mon, 15 Nov 2021 17:25:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:45:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 17:45:45 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY The timers in T_defs_bts are actually set by BTS over PCUIF. That's not the case for T3172, hence let's move it to T_defs_pcu so it can be configured over VTY. Change-Id: If24191b2305007aa5be5b551c913738a97597c77 --- M src/bts.cpp M src/gprs_pcu.c M src/tbf_ul_ass_fsm.c 3 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/26255/1 diff --git a/src/bts.cpp b/src/bts.cpp index 05a9cc0..5c870af 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -79,7 +79,6 @@ static struct osmo_tdef T_defs_bts[] = { { .T=3142, .default_val=20, .unit=OSMO_TDEF_S, .desc="Wait Indication used in Imm Ass Reject during TBF Establishment (CCCH)", .val=0, .min_val = 0, .max_val = 255 }, /* TS 44.018 10.5.2.43, TS 44.060 7.1.3.2.1 (T3172) */ { .T=3169, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of USF and TFI(s) after the MS uplink TBF assignment is invalid", .val=0 }, - { .T=3172, .default_val=5000,.unit=OSMO_TDEF_MS, .desc="Wait Indication used in Imm Ass Reject during TBF Establishment (PACCH)", .val=0, .min_val = 0, .max_val = 255000 }, /* TS 44.060 7.1.3.2.1 */ { .T=3191, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s) after sending (1) last RLC Data Block on TBF(s), or (2) PACKET TBF RELEASE for an MBMS radio bearer", .val=0 }, { .T=3193, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Reuse of TFI(s) after reception of final PACKET DOWNLINK ACK/NACK from MS for TBF", .val=0 }, { .T=3195, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s) upon no response from the MS (radio failure or cell change) for TBF/MBMS radio bearer", .val=0 }, diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index 76dd5be..bcdb011 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -33,6 +33,7 @@ { .T=3113, .default_val=7, .unit=OSMO_TDEF_S, .desc="Timeout for paging", .val=0 }, { .T=3190, .default_val=5, .unit=OSMO_TDEF_S, .desc="Return to packet idle mode after Packet DL Assignment on CCCH (s)", .val=0}, { .T=3141, .default_val=10, .unit=OSMO_TDEF_S, .desc="Timeout for contention resolution procedure (s)", .val=0 }, + { .T=3172, .default_val=5000,.unit=OSMO_TDEF_MS, .desc="Wait Indication used in Imm Ass Reject during TBF Establishment (PACCH)", .val=0, .min_val = 0, .max_val = 255000 }, /* TS 44.060 7.1.3.2.1 */ { .T=PCU_TDEF_NEIGH_RESOLVE_TO, .default_val=1000, .unit=OSMO_TDEF_MS, .desc="[ARFCN+BSIC]->[RAC+CI] resolution timeout (ms)", .val=0 }, { .T=PCU_TDEF_SI_RESOLVE_TO, .default_val=1000, .unit=OSMO_TDEF_MS, .desc="RIM RAN-INFO response timeout (ms)", .val=0 }, { .T=PCU_TDEF_NEIGH_CACHE_ALIVE, .default_val=5, .unit=OSMO_TDEF_S, .desc="[ARFCN+BSIC]->[RAC+CI] resolution cache entry storage timeout (s)", .val=0 }, diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index ef75360..90fe828 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -64,7 +64,7 @@ bitvec_unhex(packet_access_rej, DUMMY_VEC); write_packet_access_reject(packet_access_rej, ms_tlli(ms), - osmo_tdef_get(ms->bts->T_defs_bts, 3172, OSMO_TDEF_MS, -1)); + osmo_tdef_get(ms->bts->pcu->T_defs, 3172, OSMO_TDEF_MS, -1)); bts_do_rate_ctr_inc(ms->bts, CTR_PKT_ACCESS_REJ); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 17:46:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 17:46:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3172_* References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 ) Change subject: pcu: Introduce test TC_t3172_* ...................................................................... pcu: Introduce test TC_t3172_* Related: OS#3928 Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 --- M library/RLCMAC_CSN1_Templates.ttcn M library/RLCMAC_CSN1_Types.ttcn M pcu/PCU_Tests.ttcn 3 files changed, 176 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/26256/1 diff --git a/library/RLCMAC_CSN1_Templates.ttcn b/library/RLCMAC_CSN1_Templates.ttcn index 254983a..df50609 100644 --- a/library/RLCMAC_CSN1_Templates.ttcn +++ b/library/RLCMAC_CSN1_Templates.ttcn @@ -19,6 +19,28 @@ import from MobileL3_GMM_SM_Types all; import from RLCMAC_CSN1_Types all; + /* 11.2.1 Packet Access Reject */ + template PacketAccessRejectStruct tr_RlcMacDlCtrl_PKT_ACC_REJ_ID_TLLI(template GprsTlli tlli := ?) := { + id_type := '0'B, + id := { + tlli := tlli + } + } + template RlcmacDlCtrlMsg tr_RlcMacDlCtrl_PKT_ACC_REJ(template PacketAccessRejectStruct rej := ?, + template uint8_t wait_ind := *, + template BIT1 wait_ind_size := *) := { + msg_type := PACKET_ACCESS_REJECT, + u := { + access_reject := { + page_mode := ?, + reject_struct := rej, + wait_ind_presence := ?, + wait_ind := wait_ind, + wait_ind_size := wait_ind_size + } + } + } + template (value) RlcmacUlCtrlMsg ts_RlcMacUlCtrl_PKT_CTRL_ACK(GprsTlli tlli, CtrlAck ack := MS_RCVD_TWO_RLC_SAME_RTI_DIFF_RBSN) := { msg_type := PACKET_CONTROL_ACK, @@ -77,7 +99,19 @@ rlc_mode := RLC_MODE_ACKNOWLEDGED, llc_pdu_type := LLC_PDU_IS_NOT_SACK_OR_ACK, RlcOctetCount := 0 - } + }; + + template (value) ChannelReqDescription ts_ChannelReqDescription(uint4_t peak_tput_class := 0, + uint2_t priority := 0, + RlcMode rlc_mode := RLC_MODE_ACKNOWLEDGED, + LlcPduType llc_pdu_type := LLC_PDU_IS_NOT_SACK_OR_ACK, + uint16_t RlcOctetCount := 0) := { + peak_tput_class := peak_tput_class, + priority := priority, + rlc_mode := rlc_mode, + llc_pdu_type := llc_pdu_type, + RlcOctetCount := RlcOctetCount + }; /* TS 44.060 sec 11.2.16 */ template (value) RlcmacUlCtrlMsg ts_RlcMacUlCtrl_PKT_RES_REQ(GprsTlli tlli, diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn index d9a5662..e1dbc16 100644 --- a/library/RLCMAC_CSN1_Types.ttcn +++ b/library/RLCMAC_CSN1_Types.ttcn @@ -705,6 +705,7 @@ /* 11.2.0.1 */ type union RlcmacDlCtrlUnion { + PacketAccessReject access_reject, PacketDlAssignment dl_assignment, PacketMeasOrder meas_order, PacketUlAssignment ul_assignment, @@ -721,7 +722,8 @@ RlcmacDlCtrlMsgType msg_type, RlcmacDlCtrlUnion u } with { - variant (u) "CROSSTAG(dl_assignment, msg_type = PACKET_DL_ASSIGNMENT; + variant (u) "CROSSTAG(access_reject, msg_type = PACKET_ACCESS_REJECT; + dl_assignment, msg_type = PACKET_DL_ASSIGNMENT; meas_order, msg_type = PACKET_MEASUREMENT_ORDER; ul_assignment, msg_type = PACKET_UL_ASSIGNMENT; paging, msg_type = PACKET_PAGING_REQUEST; @@ -739,6 +741,34 @@ external function dec_RlcmacDlCtrlMsg(in octetstring stream) return RlcmacDlCtrlMsg with { extension "prototype(convert) decode(RAW)" }; + /* 11.2.1 Packet Access Reject */ + type record PacketAccessRejectIDSub { + BIT1 id_type, + PacketRequestReference req_ref optional, + GlobalTfi gtfi optional + } with { variant (req_ref) "PRESENCE(id_type = '0'B)" + variant (gtfi) "PRESENCE(id_type = '1'B)" + }; + type union PacketAccessRejectID { + GprsTlli tlli, + PacketAccessRejectIDSub id_sub + } with { variant (tlli) "BYTEORDER(first)" }; + type record PacketAccessRejectStruct { + BIT1 id_type, + PacketAccessRejectID id + } with { variant (id) "CROSSTAG(tlli, id_type = '0'B; id_sub, id_type = '1'B)" }; + type record PacketAccessReject { + PageMode page_mode, + PacketAccessRejectStruct reject_struct, + BIT1 wait_ind_presence, + uint8_t wait_ind, + BIT1 wait_ind_size + /* TODO: Additional Reject */ + /* TODO: Rel5 additions */ + } with { variant (wait_ind) "PRESENCE(wait_ind_presence = '1'B)" + variant (wait_ind_size) "PRESENCE(wait_ind_presence = '1'B)" + }; + /* 11.2.6 Packet Downlink Ack/Nack */ type record ILevel { diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 40dd400..336a4e0 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -246,6 +246,15 @@ } } +private function f_pcuvty_set_timer(integer t, integer val) +runs on RAW_PCU_Test_CT { + if (t >= 0) { + f_vty_config2(PCUVTY, {"pcu"}, "timer T" & int2str(t) & " " & int2str(val)); + } else { + f_vty_config2(PCUVTY, {"pcu"}, "timer X" & int2str(t * -1) & " " & int2str(val)); + } +} + private function f_init_vty(charstring id, boolean egprs_only) runs on RAW_PCU_Test_CT { map(self:PCUVTY, system:PCUVTY); f_vty_set_prompts(PCUVTY); @@ -2027,6 +2036,105 @@ f_shutdown(__BFILE__, __LINE__, final := true); } +/* Verify configured T3172 is properly transmitted as WAIT_INDICATION in Pkt Access Reject in PACCH. */ +function f_TC_t3172(integer t3172_ms, BIT1 wait_ind_size) runs on RAW_PCU_Test_CT { + var PCUIF_info_ind info_ind; + var template IARRestOctets rest; + var BIT11 ra11; + var GprsMS ms; + var octetstring data := f_rnd_octstring(10); + var RlcmacDlBlock dl_block; + var template RlcmacDlBlock rej_tmpl; + var uint32_t dl_fn; + var uint32_t sched_fn; + var uint8_t wait_ind_val; + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + + info_ind := valueof(ts_PCUIF_INFO_default); + + /* Only the first TRX is enabled. */ + f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); + f_PCUIF_PDCHMask_set(info_ind, '00000001'B, 0); + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), info_ind); + + f_pcuvty_set_timer(3172, t3172_ms); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + var EGPRSPktChRequest req := { + one_phase := { + tag := '0'B, + multislot_class := '10101'B, + priority := '01'B, + random_bits := '101'B + } + }; + + /* We send 7 requests, the IUT gives us all available USFs (0..6) */ + for (var integer i := 0; i < 7; i := i + 1) { + req.one_phase.random_bits := int2bit(f_rnd_int(8), 3); + f_TC_egprs_pkt_chan_req(req, tr_IMM_TBF_ASS); + } + + /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); + f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + + /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ + f_sleep(X2002); + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + + /* ACK the DL block */ + f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); + f_ms_tx_ul_block(ms, ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf.tfi, ms.dl_tbf.acknack_desc, false, ts_ChannelReqDescription()), + f_dl_block_ack_fn(dl_block, dl_fn)); + + /* Since all USF are taken, we should receive a Reject: */ + + if (wait_ind_size == '0'B) { + wait_ind_val := t3172_ms / 1000; + } else { + wait_ind_val := t3172_ms / 20; + } + rej_tmpl := tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_ACC_REJ(tr_RlcMacDlCtrl_PKT_ACC_REJ_ID_TLLI(ms.tlli), + wait_ind_val, wait_ind_size)); + template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum; + BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, + sapi := PCU_IF_SAPI_PDTCH, fn := 0, + arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), + block_nr := nr.blk_nr)); + alt { + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + rej_tmpl)); + [] BTS.receive { + setverdict(fail, "Unexpected BTS message"); + f_shutdown(__BFILE__, __LINE__); + } + } + f_shutdown(__BFILE__, __LINE__, final := true); +} +testcase TC_t3172_wait_ind_size0() runs on RAW_PCU_Test_CT { + /* size=0 means value is provided in seconds. De to value being 8 + * bit, in the 20ms step case (size=1) the maximum value possible is 20 * 255 + * = 5100. Hence, values above it should use size=0 to be able to + * provide values in range. Let's use 6 seconds, 6000ms + */ + f_TC_t3172(6000, '0'B); +} +testcase TC_t3172_wait_ind_size1() runs on RAW_PCU_Test_CT { + f_TC_t3172(3000, '1'B); +} + /* Verify PCU handles correctly Countdown Procedure based on BS_CV_MAX */ testcase TC_countdown_procedure() runs on RAW_PCU_Test_CT { var RlcmacDlBlock dl_block; @@ -6576,6 +6684,8 @@ execute( TC_zero_x2031_t3191() ); execute( TC_t3193() ); execute( TC_n3105_max_t3195() ); + execute( TC_t3172_wait_ind_size0() ); + execute( TC_t3172_wait_ind_size1() ); execute( TC_countdown_procedure() ); execute( TC_ul_all_sizes() ); execute( TC_ul_data_toolong_fills_padding() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 Gerrit-Change-Number: 26256 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 18:10:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 18:10:00 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 18:10:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 18:10:07 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Patch Set 1: Verified+1 linter doesn't apply here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 18:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 15 18:23:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 15 Nov 2021 18:23:11 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 ) Change subject: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack ...................................................................... pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack Change-Id: I2058862cf11d0027b040eb6d9c0a27524df593b5 --- M pcu/PCU_Tests.ttcn 1 file changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/26257/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 336a4e0..db57755 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -3398,6 +3398,60 @@ f_shutdown(__BFILE__, __LINE__, final := true); } +/* Test scenario where MS wants to request a new UL TBF using a DL (EGPRS) ACK/NACK + * transmitted on ul slot provided by its DL TBF. + * See 3GPP TS 44.060 sec 9.3.2.4.2 "Non-extended uplink TBF mode" */ +function f_TC_ul_tbf_reestablish_with_pkt_dl_ack_nack(boolean use_egprs) runs on RAW_PCU_Test_CT { + var GprsMS ms; + var octetstring data := f_rnd_octstring(10); + var RlcmacDlBlock dl_block; + var template RlcmacDlBlock rej_tmpl; + var uint32_t dl_fn; + var uint32_t sched_fn; + var template (value) MSRadioAccessCapabilityV_BSSGP racap_tmpl; + + if (use_egprs == true) { + racap_tmpl := bssgp_ms_racap_egprs_def; + } else { + racap_tmpl := bssgp_ms_racap_gprs_def; + } + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename()); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, racap_tmpl)); + f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + + /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ + f_sleep(X2002); + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + + /* ACK the DL block, asking for new UL TBF by including ChanReqDesc */ + f_dltbf_ack_block(ms.dl_tbf, dl_block, '1'B); + f_ms_tx_ul_block(ms, f_dltbf_ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf, use_egprs, ts_ChannelReqDescription()), + f_dl_block_ack_fn(dl_block, dl_fn)); + + /* We should receive a Pkt Ul ASS */ + f_ms_rx_pkt_ass_pacch(ms, sched_fn, tr_RLCMAC_UL_PACKET_ASS); + f_shutdown(__BFILE__, __LINE__, final := true); +} +testcase TC_ul_tbf_reestablish_with_pkt_dl_ack_nack() runs on RAW_PCU_Test_CT { + f_TC_ul_tbf_reestablish_with_pkt_dl_ack_nack(false); +} +testcase TC_ul_tbf_reestablish_with_pkt_dl_ack_nack_egprs() runs on RAW_PCU_Test_CT { + f_TC_ul_tbf_reestablish_with_pkt_dl_ack_nack(true); +} + /* Test CS paging over the BTS<->PCU socket. * When a (class B or C, not A) MS has an active TBF (or is on the PDCH), the MS can not react on CS paging over CCCH. * Paging should be send on the PACCH. @@ -6740,6 +6794,8 @@ execute( TC_ul_multislot_tbf_ms_class_from_2phase() ); execute( TC_ul_tbf_reestablish_with_pkt_resource_req() ); execute( TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max() ); + execute( TC_ul_tbf_reestablish_with_pkt_dl_ack_nack() ); + execute( TC_ul_tbf_reestablish_with_pkt_dl_ack_nack_egprs() ); execute( TC_multiplex_dl_gprs_egprs() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2058862cf11d0027b040eb6d9c0a27524df593b5 Gerrit-Change-Number: 26257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Nov 15 21:28:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 15 Nov 2021 21:28:20 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6192d0f89bc76_54a92b20986ac5f02963bb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 341s] building additional files... [ 341s] checking if compiling is necessary... [ 341s] the output file doesn't exist [ 341s] pdflatex -interaction=batchmode rtp-amr.tex [ 341s] pdflatex failed [ 341s] [ 341s] A possible reason for transformation failure is invalid DocBook [ 341s] (as reported by xmllint) [ 341s] [ 341s] Error: pdflatex compilation failed [ 341s] [ 341s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 341s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 341s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 341s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 341s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 341s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 341s] make[1]: *** [Makefile:371: all] Error 2 [ 341s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 341s] dh_auto_build: error: make -j1 returned exit code 2 [ 341s] make: *** [debian/rules:12: build] Error 25 [ 341s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 341s] ### VM INTERACTION START ### [ 342s] Powering off. [ 342s] [ 324.940967] reboot: Power down [ 342s] ### VM INTERACTION END ### [ 342s] [ 342s] sheep87 failed "build osmo-bts_1.3.3.dsc" at Mon Nov 15 21:28:03 UTC 2021. [ 342s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Nov 15 21:47:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Nov 2021 21:47:59 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Nov 2021 21:47:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Nov 15 21:48:15 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 15 Nov 2021 21:48:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6192d5a7460d4_54a92b20986ac5f02993d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 1359s] building additional files... [ 1359s] checking if compiling is necessary... [ 1359s] the output file doesn't exist [ 1359s] pdflatex -interaction=batchmode rtp-amr.tex [ 1359s] pdflatex failed [ 1359s] [ 1359s] A possible reason for transformation failure is invalid DocBook [ 1359s] (as reported by xmllint) [ 1359s] [ 1359s] Error: pdflatex compilation failed [ 1359s] [ 1359s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 1359s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 1359s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 1359s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 1359s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 1359s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1359s] make[1]: *** [Makefile:375: all] Error 2 [ 1359s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1359s] dh_auto_build: error: make -j1 returned exit code 2 [ 1359s] make: *** [debian/rules:12: build] Error 25 [ 1359s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1359s] ### VM INTERACTION START ### [ 1361s] Powering off. [ 1361s] [ 1281.464953] reboot: Power down [ 1361s] ### VM INTERACTION END ### [ 1361s] [ 1361s] old-atreju5 failed "build osmo-bts_1.3.0.348.f422.202111150026.dsc" at Mon Nov 15 21:48:06 UTC 2021. [ 1361s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 00:32:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 00:32:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3172_* In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 ) Change subject: pcu: Introduce test TC_t3172_* ...................................................................... Patch Set 1: Code-Review-1 (9 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/library/RLCMAC_CSN1_Templates.ttcn File library/RLCMAC_CSN1_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/library/RLCMAC_CSN1_Templates.ttcn at 23 PS1, Line 23: tr_RlcMacDlCtrl_PKT_ACC_REJ_ID_TLLI Not critical, but having 'RlcMacDlCtrl' in the name of this template looks a bit confusing to me, because it may look like a template of 'RlcmacDlCtrlMsg'. I would expect something like 'tr_PacketAccessRejectStruct_TLLI' or so. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/library/RLCMAC_CSN1_Templates.ttcn at 102 PS1, Line 102: ; Why are you adding this semicolon here (in this patch I mean)? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/library/RLCMAC_CSN1_Types.ttcn File library/RLCMAC_CSN1_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/library/RLCMAC_CSN1_Types.ttcn at 756 PS1, Line 756: PacketAccessRejectStruct I had a quick look into the specs: the '< Reject struct >' actually contains an ID *and* the optional '< WAIT_INDICATION >', while in your definition only an ID is present. So I propose to move the '< WAIT_INDICATION >' stuff here. After that, we can easily implement the recursion '{ 1 < Reject struct > ** 0 }'. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/library/RLCMAC_CSN1_Types.ttcn at 764 PS1, Line 764: uint8_t wait_ind, Missing 'optional' keyword for both 'wait_ind' and 'wait_ind_size'. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2073 PS1, Line 2073: var EGPRSPktChRequest req := { Is there a reason why you're specifically using EGPRS Packet Channel Request here? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2082 PS1, Line 2082: /* We send 7 requests, the IUT gives us all available USFs (0..6) */ You could simply tell f_init_gprs_ms() to allocate 7 GprsMS instances, and then just call f_multi_ms_establish_tbf(). This would make the test case shorter and easier to follow/read. I mean, you were the one introducing multi-GprsMS capable API, but somehow you're not using it :P https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2086 PS1, Line 2086: } So if we send another RACH.ind here, the IUT would send the reject over the BCCH/AGCH in form of Immediate Assignment Reject. This message does contain the Wait Indication too, however as per 3GPP TS 44.018 section 9.1.20.3 it reflects the value of T3142, not T3172. And while writing this comment, I found out that we already test it implicitly in TC_egprs_pkt_chan_req_reject_exhaustion. Good. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2101 PS1, Line 2101: /* Since all USF are taken, we should receive a Reject: */ Took me a while to understand what exactly causes the Reject. I looked above, read the comment 'ACK the DL block', and was like: what? How could an ACK/NACK message trigger the resource allocation? Then I noticed that it actually contains an optional ChannelReqDescription! I didn't know it was possible to request an Uplink resource allocation using the ACK/NACK messages. Thanks for giving me a chance to learn something new, really. Now I am wondering if it would have been simpler to use one of the allocated Uplink TBFs to request additional resources instead of using the ACK/NACK message? Just wondering, not saying that it must be done this way. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2127 PS1, Line 2127: De Due -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 Gerrit-Change-Number: 26256 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 00:32:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 00:36:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 00:36:39 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 ) Change subject: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2058862cf11d0027b040eb6d9c0a27524df593b5 Gerrit-Change-Number: 26257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 00:36:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 16 00:47:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 00:47:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6192ffb816db9_54a92b20986ac5f034500@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 437s] building additional files... [ 437s] checking if compiling is necessary... [ 437s] the output file doesn't exist [ 437s] pdflatex -interaction=batchmode rtp-amr.tex [ 437s] pdflatex failed [ 437s] [ 437s] A possible reason for transformation failure is invalid DocBook [ 437s] (as reported by xmllint) [ 437s] [ 437s] Error: pdflatex compilation failed [ 437s] [ 437s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 437s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 437s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 437s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 437s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 437s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 437s] make[1]: *** [Makefile:375: all] Error 2 [ 437s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 437s] dh_auto_build: error: make -j1 returned exit code 2 [ 437s] make: *** [debian/rules:12: build] Error 25 [ 437s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 437s] ### VM INTERACTION START ### [ 438s] Powering off. [ 438s] [ 419.019879] reboot: Power down [ 438s] ### VM INTERACTION END ### [ 438s] [ 438s] lamb61 failed "build osmo-bts_1.3.0.348.f422.202111160026.dsc" at Tue Nov 16 00:47:37 UTC 2021. [ 438s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 00:49:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 00:49:43 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6193003359c89_54a92b20986ac5f034538a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 415s] building additional files... [ 415s] checking if compiling is necessary... [ 415s] the output file doesn't exist [ 415s] pdflatex -interaction=batchmode rtp-amr.tex [ 415s] pdflatex failed [ 415s] [ 415s] A possible reason for transformation failure is invalid DocBook [ 415s] (as reported by xmllint) [ 415s] [ 415s] Error: pdflatex compilation failed [ 415s] [ 415s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 415s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 415s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 415s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 415s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 415s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 415s] make[1]: *** [Makefile:375: all] Error 2 [ 415s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 415s] dh_auto_build: error: make -j1 returned exit code 2 [ 415s] make: *** [debian/rules:12: build] Error 25 [ 415s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 415s] ### VM INTERACTION START ### [ 416s] Powering off. [ 416s] [ 400.550920] reboot: Power down [ 416s] ### VM INTERACTION END ### [ 416s] [ 416s] lamb19 failed "build osmo-bts_1.3.0.348.f422.202111160026.dsc" at Tue Nov 16 00:49:36 UTC 2021. [ 416s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 02:12:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 02:12:46 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 5: Code-Review-1 (9 comments) https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim-shell.py at 101 PS5, Line 101: if type(profile) is CardProfileUICC or type(profile) is CardProfileUICCSIM: In terms of readability, this is a better approach: if type(profile) in (CardProfileUICC, CardProfileUICCSIM): but given that CardProfileUICCSIM is a child of CardProfileUICC, you better do: if isinstance(profile, CardProfileUICC): which is the right way taking inheritance into account. See https://stackoverflow.com/questions/1549801/what-are-the-differences-between-type-and-isinstance. https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/filesystem.py File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/filesystem.py at 1508 PS5, Line 1508: that is overloaded by specific dirived classes If I understand correctly, this is an *abstract* static method. In Python you should mark it as such using the '@abc.abstractmethod', so it would be impossible to inherit this class without defining the child-specific implementation of this method. See examples below, e.g. CardModel.add_files(), which is an abstract class method. https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 29 PS5, Line 29: # In order for autodetection ... So AFAIU, the order is important here. And this is why you're not using __subclasses__(). https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 32 PS5, Line 32: def profile_detect(scc:SimCardCommands): Missing type definition for returned value: -> Optional[CardProfile] https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 32 PS5, Line 32: profile_detect I find it confusing that you create a new module called 'profile', which itself does not define class CardProfile, but provides some API for this class. Ideally, I would expect to see this API as a @classmethod of the CardProfile. If we go for this, then we can do something like: profile = CardProfile.pick(scc) and it looks logical: CardProfile (being an abstract class) picks a suitable child for the given card. Indeed, we would have to use the __subclasses__(). The problem with sub-classes of sub-classes you mentioned can be solved by doing recursion: def all_subclasses(cls): return set(cls.__subclasses__()).union( [s for c in cls.__subclasses__() for s in all_subclasses(c)]) The problem with specific ordering is more critical, because this is an implementation specific detail of Python; thus it may (actually does) vary from one version to another. You can solve it by assigning some kind of priority to all children of the CardProfile, so that would then allow you to sort() them. https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 33 PS5, Line 33: ws https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py at 631 PS5, Line 631: _match_sim So this is basically a copy of CardProfileSIM.match_with_card()? Also, the only difference from _match_uicc() here seems to be the CTRL byte? You need to generalize this somehow to avoid copy-paste... https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py at 746 PS5, Line 746: # Add GSM specific files tabs vs spaces https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py at 977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: > I see no change or feedback regarding this in the latest patch version I agree with Harald here. This principle applies to functions: it's easier to read shorter ones doing one specific thing. But for classes... I don't think you win anything; rather loose in terms of the code structure. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 02:12:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 02:18:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 02:18:46 +0000 Subject: Change in pysim[master]: ts_51_011: move _decode_select_response into profile class In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26205 ) Change subject: ts_51_011: move _decode_select_response into profile class ...................................................................... Patch Set 2: Code-Review+1 (2 comments) All my comments are ideas for separate changes. https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py at 976 PS2, Line 976: Any More specific type of the returned value is 'object'. https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py at 976 PS2, Line 976: def decode_select_response(self, resp_hex:str) -> Any: If self is not used, then it's a @staticmethod. We can mark it as such in a separate commit. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11 Gerrit-Change-Number: 26205 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 02:18:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 02:19:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 02:19:13 +0000 Subject: Change in pysim[master]: commands: use send_apdu_checksw() in method read_record In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26206 ) Change subject: commands: use send_apdu_checksw() in method read_record ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9fc411e1b12e8d9fd89b9964209808c0706011bd Gerrit-Change-Number: 26206 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 02:19:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 02:25:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 02:25:54 +0000 Subject: Change in pysim[master]: pySim-shell: export command: guess number of records when not specified In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26204 ) Change subject: pySim-shell: export command: guess number of records when not specified ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 02:25:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 16 02:32:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 02:32:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <619318352422d_54a92b20986ac5f0357395@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-pcu failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 1078s] | #define LT_OBJDIR ".libs/" [ 1078s] | #define STDC_HEADERS 1 [ 1078s] | [ 1078s] | configure: exit 0 [ 1078s] [ 1078s] # -*- compilation -*- [ 1078s] 4. testsuite.at:25: testing tbf ... [ 1078s] ./testsuite.at:28: $OSMO_QEMU $abs_top_builddir/tests/tbf/TbfTest [ 1078s] --- experr 2021-11-16 02:31:59.010000000 +0000 [ 1078s] +++ /usr/src/packages/BUILD/tests/testsuite.dir/at-groups/4/stderr 2021-11-16 02:31:59.845000000 +0000 [ 1078s] @@ -9154,4 +9154,5 @@ [ 1078s] TBF(UL-TFI_-1){ASSIGN}: Deallocated [ 1078s] UL_ASS_TBF(UL-TFI_-1){NONE}: Deallocated [ 1078s] DL_ASS_TBF(UL-TFI_-1){NONE}: Deallocated [ 1078s] +TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) LLC receive timeout, requesting DL ACK [ 1078s] === end test_packet_access_rej_prr_no_other_tbfs === [ 1078s] stdout: [ 1078s] 4. testsuite.at:25: 4. tbf (testsuite.at:25): FAILED (testsuite.at:28) [ 1078s] make[1]: *** [debian/rules:24: override_dh_auto_test] Error 1 [ 1078s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1078s] make: *** [debian/rules:12: build] Error 2 [ 1078s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1078s] ### VM INTERACTION START ### [ 1081s] [ 1042.573468] sysrq: SysRq : Power Off [ 1081s] [ 1042.580371] reboot: Power down [ 1083s] ### VM INTERACTION END ### [ 1083s] [ 1083s] obs-arm-6 failed "build osmo-pcu_0.9.0.279.683c.202111160026.dsc" at Tue Nov 16 02:32:13 UTC 2021. [ 1083s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:02:20 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 10:02:20 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26197/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/1/src/osmo-bsc/abis_nm.c at 937 PS1, Line 937: if (!bts->valid_config) { > why doing this in this generic path? I't make more sense to drop the connection when the connection [?] I was thinking of that, but as far as I understand this dropping feature works only for ip-access BTSs. That is why I took that route. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 10:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:20:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 10:20:22 +0000 Subject: Change in libosmo-sccp[master]: rate_ctr: Use legal counter group prefixes / names (no '.' allowed) References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26258 ) Change subject: rate_ctr: Use legal counter group prefixes / names (no '.' allowed) ...................................................................... rate_ctr: Use legal counter group prefixes / names (no '.' allowed) This avoids log messages like DLGLOBAL <0016> rate_ctr.c:92 'sigtran.as' is not a valid counter group identifier Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf --- M src/osmo_ss7.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/58/26258/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 76fbdbd..1cb6c82 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -897,12 +897,12 @@ ***********************************************************************/ static const struct rate_ctr_desc ss7_as_rcd[] = { - [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU received" }, - [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "Total number of MSU transmitted" }, + [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx:msu:total", "Total number of MSU received" }, + [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx:msu:total", "Total number of MSU transmitted" }, }; static const struct rate_ctr_group_desc ss7_as_rcgd = { - .group_name_prefix = "sigtran.as", + .group_name_prefix = "sigtran_as", .group_description = "SIGTRAN Application Server", .num_ctr = ARRAY_SIZE(ss7_as_rcd), .ctr_desc = ss7_as_rcd, @@ -1152,13 +1152,13 @@ }; static const struct rate_ctr_desc ss7_asp_rcd[] = { - [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "Total number of packets received" }, - [SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx.packets.unknown", "Number of packets received for unknown PPID" }, - [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx.packets.total", "Total number of packets transmitted" }, + [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx:packets:total", "Total number of packets received" }, + [SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx:packets:unknown", "Number of packets received for unknown PPID" }, + [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx:packets:total", "Total number of packets transmitted" }, }; static const struct rate_ctr_group_desc ss7_asp_rcgd = { - .group_name_prefix = "sigtran.asp", + .group_name_prefix = "sigtran_asp", .group_description = "SIGTRAN Application Server Process", .num_ctr = ARRAY_SIZE(ss7_asp_rcd), .ctr_desc = ss7_asp_rcd, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf Gerrit-Change-Number: 26258 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:20:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 10:20:23 +0000 Subject: Change in libosmo-sccp[master]: osmo_ss7: properly unlink rate_counter on AS/ASP free References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26259 ) Change subject: osmo_ss7: properly unlink rate_counter on AS/ASP free ...................................................................... osmo_ss7: properly unlink rate_counter on AS/ASP free When introducing rate_couters, I forgot to call rate_ctr_group_free(). I thought free'ing the parent object via talloc is sufficient, but that obviously misses the point that rate_counters have an internal linked list from which they must be unlinked. Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974 --- M src/osmo_ss7.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/59/26259/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 1cb6c82..b4c0b51 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -1111,6 +1111,7 @@ as->inst = NULL; llist_del(&as->list); + rate_ctr_group_free(as->ctrg); talloc_free(as); } @@ -1574,6 +1575,7 @@ /* unlink from ss7_instance */ asp->inst = NULL; llist_del(&asp->list); + rate_ctr_group_free(asp->ctrg); /* release memory */ talloc_free(asp); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974 Gerrit-Change-Number: 26259 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:23:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 10:23:32 +0000 Subject: Change in libosmo-sccp[master]: rate_ctr: Use legal counter group prefixes / names (no '.' allowed) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26258 ) Change subject: rate_ctr: Use legal counter group prefixes / names (no '.' allowed) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf Gerrit-Change-Number: 26258 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 10:23:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:23:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 10:23:38 +0000 Subject: Change in libosmo-sccp[master]: osmo_ss7: properly unlink rate_counter on AS/ASP free In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26259 ) Change subject: osmo_ss7: properly unlink rate_counter on AS/ASP free ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974 Gerrit-Change-Number: 26259 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 10:23:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:23:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 10:23:40 +0000 Subject: Change in libosmo-sccp[master]: rate_ctr: Use legal counter group prefixes / names (no '.' allowed) In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26258 ) Change subject: rate_ctr: Use legal counter group prefixes / names (no '.' allowed) ...................................................................... rate_ctr: Use legal counter group prefixes / names (no '.' allowed) This avoids log messages like DLGLOBAL <0016> rate_ctr.c:92 'sigtran.as' is not a valid counter group identifier Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf --- M src/osmo_ss7.c 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 76fbdbd..1cb6c82 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -897,12 +897,12 @@ ***********************************************************************/ static const struct rate_ctr_desc ss7_as_rcd[] = { - [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU received" }, - [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "Total number of MSU transmitted" }, + [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx:msu:total", "Total number of MSU received" }, + [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx:msu:total", "Total number of MSU transmitted" }, }; static const struct rate_ctr_group_desc ss7_as_rcgd = { - .group_name_prefix = "sigtran.as", + .group_name_prefix = "sigtran_as", .group_description = "SIGTRAN Application Server", .num_ctr = ARRAY_SIZE(ss7_as_rcd), .ctr_desc = ss7_as_rcd, @@ -1152,13 +1152,13 @@ }; static const struct rate_ctr_desc ss7_asp_rcd[] = { - [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "Total number of packets received" }, - [SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx.packets.unknown", "Number of packets received for unknown PPID" }, - [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx.packets.total", "Total number of packets transmitted" }, + [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx:packets:total", "Total number of packets received" }, + [SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx:packets:unknown", "Number of packets received for unknown PPID" }, + [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx:packets:total", "Total number of packets transmitted" }, }; static const struct rate_ctr_group_desc ss7_asp_rcgd = { - .group_name_prefix = "sigtran.asp", + .group_name_prefix = "sigtran_asp", .group_description = "SIGTRAN Application Server Process", .num_ctr = ARRAY_SIZE(ss7_asp_rcd), .ctr_desc = ss7_asp_rcd, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf Gerrit-Change-Number: 26258 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:23:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 10:23:40 +0000 Subject: Change in libosmo-sccp[master]: osmo_ss7: properly unlink rate_counter on AS/ASP free In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26259 ) Change subject: osmo_ss7: properly unlink rate_counter on AS/ASP free ...................................................................... osmo_ss7: properly unlink rate_counter on AS/ASP free When introducing rate_couters, I forgot to call rate_ctr_group_free(). I thought free'ing the parent object via talloc is sufficient, but that obviously misses the point that rate_counters have an internal linked list from which they must be unlinked. Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974 --- M src/osmo_ss7.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 1cb6c82..b4c0b51 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -1111,6 +1111,7 @@ as->inst = NULL; llist_del(&as->list); + rate_ctr_group_free(as->ctrg); talloc_free(as); } @@ -1574,6 +1575,7 @@ /* unlink from ss7_instance */ asp->inst = NULL; llist_del(&asp->list); + rate_ctr_group_free(asp->ctrg); /* release memory */ talloc_free(asp); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974 Gerrit-Change-Number: 26259 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:24:41 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 10:24:41 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 10:24:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:25:54 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 10:25:54 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 5: (2 comments) Thanks for reviewing this. The feedback was there, but unfortunately not sent yet. (Its probably because I forgot to click the send REPLY button. In any case this is very hard to operate, especially with multiple patches. All patches need a click on the REPLY button. Maybe that's just my imagination, but there was a time where comments were automatically posted along with the patches that were pushed. This even makes sense, the reply-comments are published along with the patch that is just pushed. It simply makes no sense to publish replays before handing in a new patch set.) https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py at 31 PS3, Line 31: _ > Ok, then it's not that simple, I stand corrected. [?] Done https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py at 977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: > sorry, but this argument doesn't hold up. [?] This makes sense - agreed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 10:25:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:27:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 10:27:39 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26255/1/src/gprs_pcu.c File src/gprs_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26255/1/src/gprs_pcu.c at 36 PS1, Line 36: ,. space missing here, that's what the linter complains about - not sure if that's intentional. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 10:27:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:33:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 10:33:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3172_* In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 to look at the new patch set (#2). Change subject: pcu: Introduce test TC_t3172_* ...................................................................... pcu: Introduce test TC_t3172_* Related: OS#3928 Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 --- M library/RLCMAC_CSN1_Templates.ttcn M library/RLCMAC_CSN1_Types.ttcn M pcu/PCU_Tests.ttcn 3 files changed, 178 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/26256/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 Gerrit-Change-Number: 26256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:34:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 10:34:39 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26255/1/src/gprs_pcu.c File src/gprs_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26255/1/src/gprs_pcu.c at 36 PS1, Line 36: ,. > space missing here, that's what the linter complains about - not sure if that's intentional. I though it was warning about T=3172 (equal sign with no spaces). Let me fix that space you mention. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 10:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:37:51 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 10:37:51 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26255/1/src/gprs_pcu.c File src/gprs_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26255/1/src/gprs_pcu.c at 36 PS1, Line 36: ,. > I though it was warning about T=3172 (equal sign with no spaces). Let me fix that space you mention. the linter knows that we write timers like this already ;) https://gerrit.osmocom.org/c/osmo-ci/+/24961 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 10:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:37:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 10:37:55 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 to look at the new patch set (#2). Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY The timers in T_defs_bts are actually set by BTS over PCUIF. That's not the case for T3172, hence let's move it to T_defs_pcu so it can be configured over VTY. Change-Id: If24191b2305007aa5be5b551c913738a97597c77 --- M src/bts.cpp M src/gprs_pcu.c M src/tbf_ul_ass_fsm.c 3 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/26255/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:38:23 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 10:38:23 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 10:38:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:39:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 10:39:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3172_* In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 ) Change subject: pcu: Introduce test TC_t3172_* ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2073 PS1, Line 2073: var EGPRSPktChRequest req := { > Is there a reason why you're specifically using EGPRS Packet Channel Request here? Not really. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2086 PS1, Line 2086: } > So if we send another RACH. [?] Yes, I took that test as a base since half of the work was already done. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256/1/pcu/PCU_Tests.ttcn at 2101 PS1, Line 2101: /* Since all USF are taken, we should receive a Reject: */ > Took me a while to understand what exactly causes the Reject. [?] No, because allocating a new UL TBF from the existing UL TBF maybe releases the previous TBF before allocating the new one. I wanted to be sure I triggered the USF exhaustion and I got a Pkt Access Reject and this scenario wasn't tested so it's fine this way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 Gerrit-Change-Number: 26256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 10:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:47:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 10:47:32 +0000 Subject: Change in osmo-pcu[master]: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26255 ) Change subject: Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY ...................................................................... Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY The timers in T_defs_bts are actually set by BTS over PCUIF. That's not the case for T3172, hence let's move it to T_defs_pcu so it can be configured over VTY. Change-Id: If24191b2305007aa5be5b551c913738a97597c77 --- M src/bts.cpp M src/gprs_pcu.c M src/tbf_ul_ass_fsm.c 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 05a9cc0..5c870af 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -79,7 +79,6 @@ static struct osmo_tdef T_defs_bts[] = { { .T=3142, .default_val=20, .unit=OSMO_TDEF_S, .desc="Wait Indication used in Imm Ass Reject during TBF Establishment (CCCH)", .val=0, .min_val = 0, .max_val = 255 }, /* TS 44.018 10.5.2.43, TS 44.060 7.1.3.2.1 (T3172) */ { .T=3169, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of USF and TFI(s) after the MS uplink TBF assignment is invalid", .val=0 }, - { .T=3172, .default_val=5000,.unit=OSMO_TDEF_MS, .desc="Wait Indication used in Imm Ass Reject during TBF Establishment (PACCH)", .val=0, .min_val = 0, .max_val = 255000 }, /* TS 44.060 7.1.3.2.1 */ { .T=3191, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s) after sending (1) last RLC Data Block on TBF(s), or (2) PACKET TBF RELEASE for an MBMS radio bearer", .val=0 }, { .T=3193, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Reuse of TFI(s) after reception of final PACKET DOWNLINK ACK/NACK from MS for TBF", .val=0 }, { .T=3195, .default_val=5, .unit=OSMO_TDEF_S, .desc="Reuse of TFI(s) upon no response from the MS (radio failure or cell change) for TBF/MBMS radio bearer", .val=0 }, diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index 76dd5be..e8dba06 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -33,6 +33,7 @@ { .T=3113, .default_val=7, .unit=OSMO_TDEF_S, .desc="Timeout for paging", .val=0 }, { .T=3190, .default_val=5, .unit=OSMO_TDEF_S, .desc="Return to packet idle mode after Packet DL Assignment on CCCH (s)", .val=0}, { .T=3141, .default_val=10, .unit=OSMO_TDEF_S, .desc="Timeout for contention resolution procedure (s)", .val=0 }, + { .T=3172, .default_val=5000, .unit=OSMO_TDEF_MS, .desc="Wait Indication used in Imm Ass Reject during TBF Establishment (PACCH)", .val=0, .min_val = 0, .max_val = 255000 }, /* TS 44.060 7.1.3.2.1 */ { .T=PCU_TDEF_NEIGH_RESOLVE_TO, .default_val=1000, .unit=OSMO_TDEF_MS, .desc="[ARFCN+BSIC]->[RAC+CI] resolution timeout (ms)", .val=0 }, { .T=PCU_TDEF_SI_RESOLVE_TO, .default_val=1000, .unit=OSMO_TDEF_MS, .desc="RIM RAN-INFO response timeout (ms)", .val=0 }, { .T=PCU_TDEF_NEIGH_CACHE_ALIVE, .default_val=5, .unit=OSMO_TDEF_S, .desc="[ARFCN+BSIC]->[RAC+CI] resolution cache entry storage timeout (s)", .val=0 }, diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index ef75360..90fe828 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -64,7 +64,7 @@ bitvec_unhex(packet_access_rej, DUMMY_VEC); write_packet_access_reject(packet_access_rej, ms_tlli(ms), - osmo_tdef_get(ms->bts->T_defs_bts, 3172, OSMO_TDEF_MS, -1)); + osmo_tdef_get(ms->bts->pcu->T_defs, 3172, OSMO_TDEF_MS, -1)); bts_do_rate_ctr_inc(ms->bts, CTR_PKT_ACCESS_REJ); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If24191b2305007aa5be5b551c913738a97597c77 Gerrit-Change-Number: 26255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:52:23 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 10:52:23 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 to look at the new patch set (#3). Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... move time_cc to libosmocore osmo_time_cc Related: SYS#4878 Depends: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd (libosmocore) Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 --- M TODO-RELEASE M configure.ac M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h D include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c D src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at D tests/time_cc/Makefile.am D tests/time_cc/time_cc_test.c D tests/time_cc/time_cc_test.ok 16 files changed, 50 insertions(+), 1,557 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/31/26231/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:52:24 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 10:52:24 +0000 Subject: Change in osmo-bsc[master]: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26260 ) Change subject: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 ...................................................................... fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 1.5.x is a branch with fix backports only. The required items are not present in 1.5.2, so actually those items require 1.6. Change-Id: Id3c51c144cf31a002eb0ef9ba9326d1ab45fbd60 --- M TODO-RELEASE 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/26260/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 89bc1cb..f66753c 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,12 +7,12 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore >1.5.1 needs osmo_bts_features_name(), osmo_bts_features_desc() -libosmogsm >1.5.1 enum entry GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID -libosmogsm >1.5.1 introduced struct needed gsm0808_old_bss_to_new_bss_info->last_eutran_plmn_id +libosmocore >=1.6 needs osmo_bts_features_name(), osmo_bts_features_desc() +libosmogsm >=1.6 enum entry GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID +libosmogsm >=1.6 introduced struct needed gsm0808_old_bss_to_new_bss_info->last_eutran_plmn_id libosmo-mgcp-client >1.8.0 need osmo_mgcpc_ep_ci_get_remote_rtp_info() -libosmovty >1.5.1 needs vty_read_config_filep() -libosmosgsm >1.5.1 needs GSM_PCHAN_OSMO_DYN -libosmocore >1.5.1 RSL_IPAC_EIE_OSMO*, struct osmo_preproc_* -libosmocore >1.5.1 needs osmo_str_to_int() -libosmocore >1.5.1 needs new osmo_stat_item implementation (omits FIFO size for stat item) +libosmovty >=1.6 needs vty_read_config_filep() +libosmosgsm >=1.6 needs GSM_PCHAN_OSMO_DYN +libosmocore >=1.6 RSL_IPAC_EIE_OSMO*, struct osmo_preproc_* +libosmocore >=1.6 needs osmo_str_to_int() +libosmocore >=1.6 needs new osmo_stat_item implementation (omits FIFO size for stat item) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id3c51c144cf31a002eb0ef9ba9326d1ab45fbd60 Gerrit-Change-Number: 26260 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 10:58:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 10:58:10 +0000 Subject: =?UTF-8?Q?Change_in_libusrp=5Bmaster=5D=3A_Bump_version=3A_3=2E4=2E5=2E5-d40e_=E2=86=92_3=2E4=2E6?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libusrp/+/26261 ) Change subject: Bump version: 3.4.5.5-d40e ? 3.4.6 ...................................................................... Bump version: 3.4.5.5-d40e ? 3.4.6 Change-Id: I4415a6fc189ffff9ea7d640d28debae70807a242 --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/61/26261/1 diff --git a/debian/changelog b/debian/changelog index 4dff165..916fc03 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,18 @@ +libusrp (3.4.6) unstable; urgency=medium + + [ Oliver Smith ] + * configure.ac: set -std=gnu11 + + [ Vadim Yanitskiy ] + * usrp_standard: fix out-of-bounds read in set_rx_freq() + * usrp_prims_common: fix use-after-free in get_proto_filename() + * libusb_get_device_list() may return a negative number + + [ Harald Welte ] + * migrate to python3 + + -- Pau Espin Pedrol Tue, 16 Nov 2021 11:57:22 +0100 + libusrp (3.4.5) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/26261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I4415a6fc189ffff9ea7d640d28debae70807a242 Gerrit-Change-Number: 26261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 11:01:29 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 11:01:29 +0000 Subject: =?UTF-8?Q?Change_in_libusrp=5Bmaster=5D=3A_Bump_version=3A_3=2E4=2E5=2E5-d40e_=E2=86=92_3=2E4=2E6?= In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/26261 ) Change subject: Bump version: 3.4.5.5-d40e ? 3.4.6 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/26261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I4415a6fc189ffff9ea7d640d28debae70807a242 Gerrit-Change-Number: 26261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 11:01:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 11:07:39 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 11:07:39 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 to look at the new patch set (#4). Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... move time_cc to libosmocore osmo_time_cc Related: SYS#4878 Depends: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd (libosmocore) Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 --- M TODO-RELEASE M configure.ac M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h D include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c D src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at D tests/time_cc/Makefile.am D tests/time_cc/time_cc_test.c D tests/time_cc/time_cc_test.ok 16 files changed, 50 insertions(+), 1,557 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/31/26231/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 11:07:39 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 11:07:39 +0000 Subject: Change in osmo-bsc[master]: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26260 to look at the new patch set (#2). Change subject: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 ...................................................................... fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 1.5.x is a branch with fix backports only. The required items are not present in 1.5.2, so actually those items require 1.6. Change-Id: Id3c51c144cf31a002eb0ef9ba9326d1ab45fbd60 --- M TODO-RELEASE 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/26260/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id3c51c144cf31a002eb0ef9ba9326d1ab45fbd60 Gerrit-Change-Number: 26260 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 11:07:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 11:07:49 +0000 Subject: =?UTF-8?Q?Change_in_libusrp=5Bmaster=5D=3A_Bump_version=3A_3=2E4=2E5=2E5-d40e_=E2=86=92_3=2E4=2E6?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/26261 ) Change subject: Bump version: 3.4.5.5-d40e ? 3.4.6 ...................................................................... Bump version: 3.4.5.5-d40e ? 3.4.6 Change-Id: I4415a6fc189ffff9ea7d640d28debae70807a242 --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 4dff165..916fc03 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,18 @@ +libusrp (3.4.6) unstable; urgency=medium + + [ Oliver Smith ] + * configure.ac: set -std=gnu11 + + [ Vadim Yanitskiy ] + * usrp_standard: fix out-of-bounds read in set_rx_freq() + * usrp_prims_common: fix use-after-free in get_proto_filename() + * libusb_get_device_list() may return a negative number + + [ Harald Welte ] + * migrate to python3 + + -- Pau Espin Pedrol Tue, 16 Nov 2021 11:57:22 +0100 + libusrp (3.4.5) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/26261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I4415a6fc189ffff9ea7d640d28debae70807a242 Gerrit-Change-Number: 26261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 11:09:14 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 11:09:14 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26231 ) Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... Patch Set 4: Code-Review+2 re-add +2 after rebasing without changes -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 11:09:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:08:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:08:32 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... contrib/libosmocore.spec.in: Depends on talloc 2.1.0 With recent commit (see below) libosmocore started using talloc API talloc_pooled_object(), which is available only startinf from talloc 2.1.0. Let's bump required version check accordingly. Issue found by osmo-release.sh: ERROR: configure.ac does NOT match contrib/*.spec.in ! Fixes: b72867f0e68c96ca25e1f9929ce92be0a802db6b Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 --- M contrib/libosmocore.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/26262/1 diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in index df36e89..a3e0601 100644 --- a/contrib/libosmocore.spec.in +++ b/contrib/libosmocore.spec.in @@ -29,7 +29,7 @@ BuildRequires: pkgconfig(gnutls) >= 2.12.0 BuildRequires: pkgconfig(libpcsclite) BuildRequires: pkgconfig(libusb-1.0) -BuildRequires: pkgconfig(talloc) >= 2.0.1 +BuildRequires: pkgconfig(talloc) >= 2.1.0 BuildRequires: pkgconfig(libmnl) BuildRequires: pkgconfig(libsystemd) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:08:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:08:34 +0000 Subject: Change in libosmocore[master]: osmo-release.sh: Blacklist script file from LIBVERS matches References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26263 ) Change subject: osmo-release.sh: Blacklist script file from LIBVERS matches ...................................................................... osmo-release.sh: Blacklist script file from LIBVERS matches The file itself appears in the list of matches when run in libosmocore.git. Let's prevent it: """ expr: non-integer argument WARN: Found 19 files matching debian/lib*.install for LIBVERSION=`gitdiff--cached-GLIBVERSION--stat|grepMakefile.am`, manual check required! """ Change-Id: I6d750d312017ebb434650a6e19707ec60faf4020 --- M osmo-release.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/26263/1 diff --git a/osmo-release.sh b/osmo-release.sh index aecbfd1..3566ef9 100755 --- a/osmo-release.sh +++ b/osmo-release.sh @@ -223,7 +223,7 @@ exit 1 fi GIT_TOPDIR="$(git rev-parse --show-toplevel)" -LIBVERS=`git grep -n LIBVERSION | grep '=' | grep am | grep -v LDFLAGS` +LIBVERS=`git grep -n LIBVERSION | grep '=' | grep am | grep -v LDFLAGS | grep -v osmo-release.sh` MAKEMOD=`git diff --cached -GLIBVERSION --stat | grep Makefile.am` ISODATE=`date -I` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d750d312017ebb434650a6e19707ec60faf4020 Gerrit-Change-Number: 26263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:08:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:08:34 +0000 Subject: =?UTF-8?Q?Change_in_libosmocore=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E1=2E282-ab5e-dirty_=E2=86=92_1=2E6=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26264 ) Change subject: Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 ...................................................................... Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 --- M TODO-RELEASE M contrib/libosmocore.spec.in M debian/changelog M debian/control R debian/libosmocore18.install R debian/libosmogsm17.install M src/Makefile.am M src/codec/Makefile.am M src/coding/Makefile.am M src/ctrl/Makefile.am M src/gb/Makefile.am M src/gsm/Makefile.am M src/sim/Makefile.am M src/vty/Makefile.am 14 files changed, 337 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/26264/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index ead2c50..8ccfa49 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,17 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmovty _LAST_OSMOVTY_NODE Raise _LAST_OSMOVTY_NODE by introducing some RESERVED*_NODE -libosmogsm gsm0808_old_bss_to_new_bss_info ABI break (struct changes size), gsm0808_old_bss_to_new_bss_info_att_tlvdef symbol added -libosmosim osim_card_hdl ABI + API breakage due to new struct members -libosmocore osmo_tdef_fsm_inst_state_chg change default_timeout arg from unsigned long to long type (API breakage, not ABI) -libosmovty vty_read_config_filep New API -libosmosim osim_card_{reset,close} New API -libosmocore struct rate_ctr_group, osmo_stat_item_group_desc ABI breakage due to new struct members -libosmgsm kdf functions New API -libosmocore osmo_stat_item API breakage: remove members stats_next_id, last_offs and values[], no users should exist. -libosmocore osmo_stat_item API breakage: remove functions osmo_stat_item_get_next(), osmo_stat_item_discard(), osmo_stat_item_discard_all(), no users should exist. -libosmocore osmo_stat_item_value API breakage: struct definition removed, because no known users exist / no users should exist. -libosmocore osmo_stat_item ABI breakage: struct osmo_stat_item made opaque. -libosmocore osmo_stat_item No FIFO buffer of values used anymore, the "skipped values" error is no longer possible. -libosmocore stats reporting for osmo_stat_item, values are now never repeated from one stats report to the next. diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in index a3e0601..3018280 100644 --- a/contrib/libosmocore.spec.in +++ b/contrib/libosmocore.spec.in @@ -111,13 +111,13 @@ This subpackage contains libraries and header files for developing applications that want to make use of libosmocoding. -%package -n libosmocore17 +%package -n libosmocore18 Summary: Osmocom core library # crc16.c has GPL2-only clauses, the rest (*.c) is GPL-2.0+ License: GPL-2.0-only AND GPL-2.0-or-later Group: System/Libraries -%description -n libosmocore17 +%description -n libosmocore18 libosmocore is a library with various utility functions shared between OpenBSC and OsmocomBB. @@ -126,7 +126,7 @@ # crc16.h has GPL2-only clauses, the rest (*.h) is GPL-2.0+ License: GPL-2.0-only AND GPL-2.0-or-later Group: Development/Libraries/C and C++ -Requires: libosmocore17 = %version +Requires: libosmocore18 = %version Requires: libtalloc-devel %description -n libosmocore-devel @@ -188,12 +188,12 @@ This subpackage contains libraries and header files for developing applications that want to make use of libosmogb. -%package -n libosmogsm16 +%package -n libosmogsm17 Summary: Osmocom GSM utility library License: GPL-2.0-or-later AND AGPL-3.0-or-later Group: System/Libraries -%description -n libosmogsm16 +%description -n libosmogsm17 libosmocore is a package with various utility functions that were originally developed as part of the OpenBSC project. @@ -208,7 +208,7 @@ License: GPL-2.0-or-later AND AGPL-3.0-or-later Group: Development/Libraries/C and C++ Requires: libosmocore-devel = %version -Requires: libosmogsm16 = %version +Requires: libosmogsm17 = %version %description -n libosmogsm-devel The libosmogsm library in particular is a collection of common code @@ -322,14 +322,14 @@ %postun -n libosmocodec0 -p /sbin/ldconfig %post -n libosmocoding0 -p /sbin/ldconfig %postun -n libosmocoding0 -p /sbin/ldconfig -%post -n libosmocore17 -p /sbin/ldconfig -%postun -n libosmocore17 -p /sbin/ldconfig +%post -n libosmocore18 -p /sbin/ldconfig +%postun -n libosmocore18 -p /sbin/ldconfig %post -n libosmoctrl0 -p /sbin/ldconfig %postun -n libosmoctrl0 -p /sbin/ldconfig %post -n libosmogb12 -p /sbin/ldconfig %postun -n libosmogb12 -p /sbin/ldconfig -%post -n libosmogsm16 -p /sbin/ldconfig -%postun -n libosmogsm16 -p /sbin/ldconfig +%post -n libosmogsm17 -p /sbin/ldconfig +%postun -n libosmogsm17 -p /sbin/ldconfig %post -n libosmosim2 -p /sbin/ldconfig %postun -n libosmosim2 -p /sbin/ldconfig %post -n libosmovty9 -p /sbin/ldconfig @@ -365,9 +365,9 @@ %_libdir/libosmocoding.so %_libdir/pkgconfig/libosmocoding.pc -%files -n libosmocore17 +%files -n libosmocore18 %defattr(-,root,root) -%_libdir/libosmocore.so.17* +%_libdir/libosmocore.so.18* %files -n libosmocore-devel %defattr(-,root,root) @@ -403,9 +403,9 @@ %_libdir/libosmogb.so %_libdir/pkgconfig/libosmogb.pc -%files -n libosmogsm16 +%files -n libosmogsm17 %defattr(-,root,root) -%_libdir/libosmogsm.so.16* +%_libdir/libosmogsm.so.17* %files -n libosmogsm-devel %defattr(-,root,root) diff --git a/debian/changelog b/debian/changelog index 8fffac5..8d44cf6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,311 @@ +libosmocore (1.6.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * osmo-release.sh: Check configure.ac dependency versions match those in rpm *.spec.in + * osmo-release.sh: Drop repeated DRY_RUN early exit + * osmo-release.sh: Check LIBVERSION matches rpm *.spec.in + * osmo-release.sh: Properly rearrange var init and sanity checks + * tests/gb: Fix printf format errors on ARM 32 bits + * Skip RPM checks if no *.spec.in available + * gsm_08_08.h: Add extra field elements defined in other sections + * cosmetic: tlv_parser: fix typo in func description + * cosmetic: Fix trailing whitespace + * gsm: Support Sending Last EUTRAN PLMN Id in Handover Required + * cosmetic: fix typo in comment + * gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef + * osmo_timer_pending: Make arg const + * gb: Fix naming and export symbol bssgp_enc_rim_pdu + * Revert "gb: Fix naming and export symbol bssgp_enc_rim_pdu" + * gb: Fix missing exporting symbol bssgp_encode_rim_pdu + * vty: Implement missing public API host_config_file() + * vty: Introduce API vty_read_config_filep + * range_enc_determine_range(): Don't dereference array on size=0 + * stat,rate_ctr: Introduce new API to get counter at given index + * Use new stat item/ctr getter APIs + * stat,rate_ctr: Allow setting group name and use it at report time + * ns2: Use NSVC bufid in stats report + * ipaccess: Add new osmo extension IPAC_PROTO_EXT_PCU + * bts_feature: Introduce feature to speak to PCU + * msgb_alloc_headroom: Change size args to be uint16_t + * ctrl: Pre-calculate required size before allocating msgb + * ctrl: Support recovering from short write + * cosmetic: gsm_12_21.h: Fix trailing whitespace + * Rename osmo dyn ts enums + * bts_feature: Introduce feature to confiure dyn ts as sdcch8 + * Make gcc 11.1.0 false positivies happy + * cosmetic: gb/gprs_ns.c: fix trailing whitespace + * gb/bssgp: Abort clearly if backward-compat API is used in wrong way + * utils: Fix c++ warn in OSMO_STRBUF_APPEND + * cosmetic: Fix missing space in comment + * gsm_08_58.h: Extend IPA Power Control Params IEs to pass C/I params + * gsm: Mark gsm0858_rsl_ul_meas_enc() pointer param const + * cosmetic: gsm: meas_rep.h: Fix typo in comment + * logging: Change LLAPD category color to purple-like one + * {ctrl,vty}/ports.h: Allocate ports for osmo-hnodeb + * configure.ac: Depend on talloc 2.1.0 + * logging: Fix double lock of log_tgt_mutex + * contrib/libosmocore.spec.in: Depends on talloc 2.1.0 + * osmo-release.sh: Blacklist script file from LIBVERS matches + + [ Oliver Smith ] + * osmo-release.sh: support epoch + * tests/stats: enable logging in test output + * stats: log error when missing stats values + * Revert "stats: log error when missing stats values" + * stat_item: make next_id argument name consistent + * stat_item: add comment with struct overview + * stat_item: make value ids item specific + * stats_test: restore stat_item_get_next asserts + * stats: log error when missing stats values (v2) + * stats: have_value is a bool, not int + * vty: add "show uptime" + * vty: add "show pid" + * vty: add "shutdown" + * vty: show uptime: use timespecsub + * vty: clear screen with ^L + * vty/ports: prepare formatting for a long define + * vty/ports: move pcap server/client ports + * tests: add 'make update_exp' target + * tests/stats: show how last item sent may be wrong + * stats: send real last value if no new values come + + [ Alexander Couzens ] + * gprs_bssgp: add support for SGSN oriented RESET + * gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1 + * gprs_ns2: don't OSMO_ASSERT() while freeing NS-VC. + * gprs_ns2: rework logging of Rx and Tx NS PDU + * gprs_ns2: always use the same method to print NSVCs + * gprs_ns2_vty: hide dynamic NSE information when ask for persistant only + * gprs_ns2_vty: make the `show ns entities` and `show ns binds` look similiar + * gprs_ns2: dump_nsvc: correct indention + * gprs_ns2: add vty command `nsvc reset` + * gprs_ns2: fix memory leaks when receiving SNS or invalid packets + * gprs_ns2: vty: remove a white space in `show binds` + * gprs_ns2: nsvc_fsm: reorder notification st_alive_on_enter() + * gprs_ns2: sns: ensure the sns->alive state is correct + * gprs_ns2: sns: remove the initial SNS NSVC if it's not part + * gprs_ns2_vty: print a response to vty `nsvc (block|unblock|reset) + * gprs_ns2: fix nsvc block and unblock vty command + * gprs_ns2: SNS: allow transition missing transition GPRS_SNS_ST_UNCONFIGURED + * gprs_ns2: add functions for SNS add/del/change-weight messages + * gprs_ns2: sns: fix del bind() + * gprs_ns2: vty: fix removing a bind from a SNS + * gprs_ns2: rework id strings of nsvcs + * gprs_ns2_sns: move selection of the next bind into own function + * gprs_ns2_sns: bss: improve validation of configuration + * gprs_ns2_sns: refactor local and remote entries into a struct + * gprs_ns2_sns: refactor ns2_clear_ipv46_entries_local to use new elems functions + * gprs_ns2_sns: use struct ns2_sns_elems in add/update/remove remote_elems + * gprs_ns2_sns: move gss->remote specific check out of add_ip4_elem/add_ip6_elem + * gprs_ns2_sns: add check for duplicates to add_ip6_elem() + * gprs_ns2_sns: refactor ip4_weight_sum/ip6_weight_sum + * gprs_ns2_sns: refactor nss_weight_sum_data -> ip46_weight_sum_data + * gprs_ns2_sns: replace ns2_sns_type with address family + * gprs_ns2_sns: bss: set gss->family + * gprs_ns2: use llist_add_tail to keep order + * gprs_ns2: fix missing notify towards the NSE when NSVC become blocked + * gprs_ns2_vc_fsm: reset the ALIVE response time when stopping test + * gprs_ns2: fix crash when changing the MTU + * gprs_ns2: fix check of MTU changes for frame relay + * gprs_ns2: correct mtu value in the log line + * gprs_ns2: use gprs_ns2_free_bind() to clean up a bind + * gprs_ns2: fix wrong format string in Tx Size logline + * gprs_ns2_vty: dump_nsvc: change output depending on NSVCI + * gprs_ns2: ensure the NSE becomes dead when FR link went down + * gprs_ns2_udp: don't start the NSVC fsm for SNS + * gprs_ns2_sns: refactor SNS failures into a function + * gprs_ns2_sns: free the NSE if the SIZE PDU is not valid + * gprs_ns2: add recursive anchor to protect against double free + * gprs_ns2: move sns_event into internal.h to direct emit events + * gprs_ns2_sns: rework sns clean up + * gprs_ns2: use an event to free the nsvscs when using SNS + * gprs_ns2: gprs_ns2_free_bind() should remove itself before removing nsvcs + * gprs_ns2: don't use llist_for_each when freeing an element + * gprs_ns2_sns: implement local change weight procedure + * gprs_ns2_sns: implement outbound SNS ADD procedures + * gprs_ns2_sns: implement outbound SNS DEL procedures + * gprs_ns2: also prevent recursive events when SGSN side cleans up + * gprs_ns2: calculate the nse->*_sums before notifing the sns fsm + * gprs_ns2: add correct filename/linenr to sns failed log message + * gprs_ns2: improve reselection protection + * gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NSVCs are present + * gprs_ns2: ensure the incoming NSVC is also the outgoing NSVC + * ns2: nsvc: reject UNITDATA when the remote BLOCK'ed + * ns2: fix a crash when receiving a SIZE while configured + * gprs_ns2: fix NS STATUS validation + * gprs_ns2: fix a white space + * gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSVC BLOCKED + * vty: add vty_out_uptime() print the uptime to the vty + * ns2: nse: add a uptime/downtime to track the last state change + * ns2: nsvc: add a uptime/downtime to track the last state change + * ns2: message: BLOCK/BLOCK ACK allow to use a given NSVCI instead of using the nsvc nsvci + * ns2: ensure the NSVC is in the correct mode for NSVC UNKNOWN/NSVC BLOCKED cause codes + * ns2: fsm: add comment don't answer on a STATUS with a STATUS + * ns2: message: allow to pass a foreign NSVCI to STATUS PDU + * ns2: correct parse a STATUS PDU which was received over a different NSVC + * ns2: improve log line when receving a PDU with wrong NSE + * ns2: don't forward an invalid RESET PDU to the FSM + * ns2: correct parse a BLOCK PDU which was received over a different NSVC + * include: add enum for UTRAN cipher + + [ Harald Welte ] + * cosmetic: ssn: some more comments + * gprs_ns2: Log all transmitted SNS messages + * gprs_ns2_sns: Dispatch inbound SNS-ACK to FSM + * gprs_ns2: Remove any references to DNS; we use DLNS in NS2. + * gprs_ns2: Pass peer/remote sockaddr argument to ns2_create_vc() + * TODO-RELEASE: Request increasing _LAST_OSMOVTY_NODE next release + * gprs_ns2_sns: Implement error log in case no binds found for NSE + * gprs_ns2_sns: Remove TODO (spec agrees, the correct cause code is used) + * gprs_ns2_vty: Clarify VTY help string wording + * gprs_ns2_sns: refactor ns2_sns_st_size_onenter() + * gprs_ns2_sns: Unify handling of SNS-CONFIG for IPv4 + IPv6 + * gprs_ns2: Encapsulate setting NSE dialect + * gprs_ns2_sns: Split allstate action in generic and BSS-specific part + * utils: osmo-aka-verify to verify UMTS AKA (SIM side) + * osmo-aka-verify: Fix use case with OP and not OPc + * gprs_ns2_sns: Support for SGSN-side IP-SNS + * gprs_ns2_sns: Add some more OSMO_ASSERT about BSS role + * gprs_ns2_sns: Rename BSS-side states to include 'bss' in name + * gprs_ns2: Introduce gprs_ns2_create_nse2() for SGSN side SNS + * gprs_ns2_vty: Allow creating NSE in sgsn-role + * gprs_ns2_sns: Don't clear remote IP endpoints in SGSN role + * gprs_ns2_sns: Verify mandatory IE presence in incoming SNS-SIZE + * gprs_ns2_sns: SNS-SIZE contains the actual number of local endpoints + * gprs_ns2_sns: Assume the SGSN has a very large number of max. NSVC + * gprs_ns2_sns: Implement checks during processing of inbound SNS-SIZE + * gprs_ns2_vty: Permit VTY configuration of bind->accept_sns + * gprs_ns2: dynamic NS-VC + NSE creation for IP-SNS in SGSN role + * gprs_ns2_sns: Allow VTY configuration of default binds for IP-SNS + * gprs_ns2: Add comments explaining the nsvc->sns_only field + * gprs_ns2_vc_fsm: In IP-SNS/ALIVE mode, initial state is ALIVE/UNBLOCKED + * gprs_ns2: Actually start Tns-test after SNS-CONFIG creates NS-VC + * gprs_ns2_sns: Compute local endpoints before using them + * gprs_ns2_sns: remove code duplication in create_missing_nsvcs() + * gprs_ns2_sns: Don't create NS-VCs for binds outside the NSE + * gprs_ns2_sns: Fix memory leak when creating ip[46]_local arrays + * sim: Obtain card ATR when opening the card + * sim: Remove 'printf' from library code + * frame_relay: Export osmo_fr_network_free() + * ns2: Dump frame relay state to VTY during "show ns" + * socket: Introduce osmo_sock_set_dscp() to set socket DSCP value + * ns2: Fix setting the DSCP value. + * socket: Introduce osmo_sock_set_priority() helper function + * socket: reduce code duplication, introduce socket_helper_tail() + * socket: QoS support for all our socket init functions + * socket: IPv6 support for osmo_sock_set_dscp() + * gprs_ns2: Fix yet another DSCP vs. TOS mix-up + * gprs_ns2_frgre: Ensure DSCP is sin premitted value range + * ns2: migrate from osmo_sock_set_dscp() to OSMO_SOCK_F_DSCP() + * gprs_ns: Fix another DSCP vs. TOS mistake in old NS code + * ns2: Allow setting the socket priority for a UDP bind + * Fix ipa_ccm_make_id_resp_from_req + * Fix ipa_ccm_make_id_resp_from_req to work at all + * ipa_ccm_make_id_resp: Make it work at all + * ns2: change the 'priority' setting name to 'socket-priority' + * osmo_sock_*_ofd(): Mark OSMO_FD_WRITE on non-blocking connect() + * sim: Add osim_card_{reset,close}() API + * osmo-auc-gen: Permit specifying the SQN in hex (0x12345) format + * copy base64 implementation from mbedtls + * base64: Migrate over to osmocom + * base64: reformat using Lindent to conform to our coding style + * osmo-auc-gen: Print RFC3310 IMS HTTP-AKA style base64 nonce/res + * logging: Change stderr + file target to use non-blocking write + * logging: Avoid memcpy from stack to msgb in _file_output() + * logging: Attempt a synchronous, non-blocking write first (file, stderr) + * rate_ctr: Make it safe to call rate_ctr_init() several times + + [ Daniel Willmann ] + * stats: Ensure that each osmo_stat_item only reports once per interval + * tlv: Fix length returned by t{l16,16l}v_put + * stats_vty: Improve generation of osmo counters + * ns2: Ignore NSVC with data_weight 0 for data + * Aggregate NSVC stats inside the NSE + * ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails + * frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct + + [ Vadim Yanitskiy ] + * utils/osmo-aka-verify: fix swapped CK/IK arguments + * vty/logging: use consistent quiting in warning messages + * vty/logging: ensure consistent '%' prefix for warnings + * vty/logging: logp: properly handle library specific sub-systems + * protocol/gsm_08_58.h: add RSL_CMOD_SP_{GSM4,GSM5,GSM6} + * protocol/gsm_08_58.h: add more 'Channel rate and type' values + * protocol/gsm_08_58.h: add asymmetric CSD data rates + * gsm/abis_nm: add missing NM_OC_IPAC_* value-string entries + * rsl: make rsl_dec_chan_nr() more readable, use RSL_CHAN_NR_MASK + * gsm_08_58.h: add Osmocom specific Bm/Lm CBITs for VAMOS + * gsm_08_58.h: add mask for Osmocom specific VAMOS C-bits + * fsm: cosmetic: fix weird spacing in osmo_fsm_inst_alloc() + * stats_vty: also show rate counter group name (if present) + * bts_features: add feature for BCCH carrier power reduction mode + * fix rsl_chan_nr_str_{buf,c}(): enlarge the buffer size + * utils: remove misleading comments for osmo_hexdump[_nospc]_c() + * utils: introduce osmo_talloc_replace_string_fmt() + * gsm_08_58: extend struct abis_rsl_osmo_temp_ovp_acch_cap + * Revert "Prevent GCR encoder/decoder functions from being used directly" + * gsm/protocol/gsm_44_004.h: fix missing include of 'endian.h' + * gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() + * tests/stats: add VTY transcript tests + * stats: use llist_add_tail() in osmo_stats_reporter_alloc() + * stats: allow configuring reporter's name in the VTY + * stats: cosmetic: print 'stats interval' before the reporters + * stats: don't mark reporter as 'disable' beforehand + * stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} + + [ Neels Hofmeyr ] + * add BTS_FEAT_VAMOS + * deprecate osmo_bts_feature_name(), add osmo_bts_features_desc() + * add osmo_bts_features_names: short BTS feature strings + * RR: add VAMOS channel modes + * RR: add missing Extended TSC Set IE + * gsm48_mr_cfg_from_gsm0808_sc_cfg(): drop bitmask without effect + * fix default_timeout type of osmo_tdef_fsm_inst_state_chg default_timeout + * add RSL_IE_OSMO_TRAINING_SEQUENCE + * add RSL_CMOD_CRT_OSMO_TCH_VAMOS_Bm, RSL_CMOD_CRT_OSMO_TCH_VAMOS_Lm + * fixup for gsm48_chan_mode_to_non_vamos() + * osmo_select_shutdown_request(): allow finishing pending writes on SIGTERM + * add Kc128 to gsm0808 Create Ciphering Command + * gsm0808: add Kc128 to Handover Request + * add fixme: enforce 8 byte length of Kc + * fix api doc of osmo_identifier_sanitize_buf() + * vty 'stats reset': do not reset stat_items + * utils: add osmo_str_to_int() and osmo_str_to_int64() + * add osmo_stat_item_get_group_by_name_idxname() + * CTRL: expose stat_item groups on CTRL + * stat_item: cosmetic: s/desc/group_desc in osmo_stat_item_group_alloc() + * stats_test: assert counter and stat item val counts separately + * refactor stat_item: get rid of FIFO and "skipped" error + * refactor stat_item: report only changed values + * cosmetic: get rid of 3 deprecation warnings + * revisit some calls of strtol(), stroul(), strtoull() + * add osmo_time_cc, moved from osmo-bsc + + [ Eric ] + * kdf: add key derivation functions + * vty: allow flushing + * gsmtap: allow 127.0.0.x local listeners + + [ Michael Iedema ] + * ns2: use same name in ctr_group as stat_item_group + + [ Philipp Maier ] + * control_cmd: fix typo + * vty: make function cmd_range_match() public + * linuxlist: add macro to get last element of a list + * command: fix sourcecode formatting + * codec: add missing osmo_amr_type_name function. + * gsm0503_coding: use ahs tables when encoding ahs codec id + * rsl: add new RSL IE to signal temporary overpower + * bts_features: Add new feature to indicate support for temporary overpower + * gsm_08_58: fix sourcecode formatting + * gsm_08_58: fix sourcecode formatting + + [ Keith ] + * GPRS: Add PDP_TYPE_N_IETF_IPv4v6 + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:08:22 +0100 + libosmocore (1.5.1) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/debian/control b/debian/control index b319132..05d0c02 100644 --- a/debian/control +++ b/debian/control @@ -31,9 +31,9 @@ Multi-Arch: foreign Depends: libosmocodec0 (= ${binary:Version}), libosmocoding0 (= ${binary:Version}), - libosmocore17 (= ${binary:Version}), + libosmocore18 (= ${binary:Version}), libosmogb12 (= ${binary:Version}), - libosmogsm16 (= ${binary:Version}), + libosmogsm17 (= ${binary:Version}), libosmovty9 (= ${binary:Version}), libosmoctrl0 (= ${binary:Version}), libosmosim2 (= ${binary:Version}), @@ -115,7 +115,7 @@ . This package contains the documentation for the libosmocoding library. -Package: libosmocore17 +Package: libosmocore18 Section: libs Architecture: any Multi-Arch: same @@ -129,14 +129,14 @@ (at least) other programs that are developed in the sphere of Free Software / Open Source mobile communication. . - The libosmocore17 library in particular is a collection of common code used in + The libosmocore18 library in particular is a collection of common code used in various sub-projects inside the Osmocom family of projects. Package: libosmocore-doc Architecture: all Section: doc Depends: ${misc:Depends}, - libosmocore17, + libosmocore18, libjs-jquery, libosmocodec-doc, libosmocoding-doc, @@ -183,7 +183,7 @@ . This package contains the documentation for the libosmogb library. -Package: libosmogsm16 +Package: libosmogsm17 Section: libs Architecture: any Multi-Arch: same @@ -207,7 +207,7 @@ Architecture: all Section: doc Depends: ${misc:Depends}, - libosmogsm16, + libosmogsm17, libjs-jquery Description: Documentation for the Osmo GSM utility library This is part of the libosmocore "meta"-library. The libosmocore library diff --git a/debian/libosmocore17.install b/debian/libosmocore18.install similarity index 100% rename from debian/libosmocore17.install rename to debian/libosmocore18.install diff --git a/debian/libosmogsm16.install b/debian/libosmogsm17.install similarity index 100% rename from debian/libosmogsm16.install rename to debian/libosmogsm17.install diff --git a/src/Makefile.am b/src/Makefile.am index 6875aa5..4bda456 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=17:0:0 +LIBVERSION=18:0:0 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS) $(LIBSCTP_CFLAGS) $(LIBMNL_CFLAGS) diff --git a/src/codec/Makefile.am b/src/codec/Makefile.am index 778eb2a..b85749d 100644 --- a/src/codec/Makefile.am +++ b/src/codec/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=2:0:2 +LIBVERSION=3:0:3 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS) AM_CFLAGS = -Wall diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am index b023668..a574f98 100644 --- a/src/coding/Makefile.am +++ b/src/coding/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=1:1:1 +LIBVERSION=1:2:1 AM_CPPFLAGS = \ -I"$(top_srcdir)/include" \ diff --git a/src/ctrl/Makefile.am b/src/ctrl/Makefile.am index a5f191d..807b672 100644 --- a/src/ctrl/Makefile.am +++ b/src/ctrl/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=5:0:5 +LIBVERSION=6:0:6 AM_CFLAGS = -Wall $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS) diff --git a/src/gb/Makefile.am b/src/gb/Makefile.am index 2ccb757..018342c 100644 --- a/src/gb/Makefile.am +++ b/src/gb/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=12:0:0 +LIBVERSION=13:0:1 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall ${GCC_FVISIBILITY_HIDDEN} -fno-strict-aliasing \ diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index b336239..580e397 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=16:0:0 +LIBVERSION=17:0:0 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS) AM_CFLAGS = -Wall ${GCC_FVISIBILITY_HIDDEN} diff --git a/src/sim/Makefile.am b/src/sim/Makefile.am index 52f3c6a..a88e341 100644 --- a/src/sim/Makefile.am +++ b/src/sim/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=2:1:0 +LIBVERSION=3:0:1 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -fPIC -Wall $(TALLOC_CFLAGS) diff --git a/src/vty/Makefile.am b/src/vty/Makefile.am index 794b96c..c73dbb2 100644 --- a/src/vty/Makefile.am +++ b/src/vty/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=9:0:0 +LIBVERSION=10:0:1 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 Gerrit-Change-Number: 26264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:15:19 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 12:15:19 +0000 Subject: Change in osmo-bsc[master]: move time_cc to libosmocore osmo_time_cc In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26231 ) Change subject: move time_cc to libosmocore osmo_time_cc ...................................................................... move time_cc to libosmocore osmo_time_cc Related: SYS#4878 Depends: Iabb17a08e6e1a86f168cdb008fba05ecd4776bdd (libosmocore) Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 --- M TODO-RELEASE M configure.ac M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h D include/osmocom/bsc/time_cc.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_init.c M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/bts.c D src/osmo-bsc/time_cc.c M tests/Makefile.am M tests/testsuite.at D tests/time_cc/Makefile.am D tests/time_cc/time_cc_test.c D tests/time_cc/time_cc_test.ok 16 files changed, 50 insertions(+), 1,557 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 89bc1cb..cfb9cf9 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -16,3 +16,4 @@ libosmocore >1.5.1 RSL_IPAC_EIE_OSMO*, struct osmo_preproc_* libosmocore >1.5.1 needs osmo_str_to_int() libosmocore >1.5.1 needs new osmo_stat_item implementation (omits FIFO size for stat item) +libosmocore >=1.6 need osmo_time_cc diff --git a/configure.ac b/configure.ac index 989ad7d..bcf91ba 100644 --- a/configure.ac +++ b/configure.ac @@ -238,7 +238,6 @@ tests/subscr/Makefile tests/nanobts_omlattr/Makefile tests/handover/Makefile - tests/time_cc/Makefile doc/Makefile doc/examples/Makefile doc/manuals/Makefile diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am index 8831533..3ddad45 100644 --- a/include/osmocom/bsc/Makefile.am +++ b/include/osmocom/bsc/Makefile.am @@ -58,7 +58,6 @@ signal.h \ system_information.h \ timeslot_fsm.h \ - time_cc.h \ vty.h \ gsm_08_08.h \ penalty_timers.h \ diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 8861c32..922753c 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -622,10 +622,10 @@ /* At what point in the channel allocation sequence to dispatch the Immediate Assignment (Abis optimization) */ enum imm_ass_time imm_ass_time; - struct time_cc all_allocated_sdcch; - struct time_cc all_allocated_static_sdcch; - struct time_cc all_allocated_tch; - struct time_cc all_allocated_static_tch; + struct osmo_time_cc all_allocated_sdcch; + struct osmo_time_cc all_allocated_static_sdcch; + struct osmo_time_cc all_allocated_tch; + struct osmo_time_cc all_allocated_static_tch; }; #define GSM_BTS_SI2Q(bts, i) (struct gsm48_system_information_type_2quater *)((bts)->si_buf[SYSINFO_TYPE_2quater][i]) diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 2823922..238b2f7 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -18,6 +18,7 @@ #include #include #include +#include #include @@ -32,7 +33,6 @@ #include #include #include -#include #define GSM_T3122_DEFAULT 10 @@ -1262,10 +1262,10 @@ struct smlc_config *smlc; - struct time_cc all_allocated_sdcch; - struct time_cc all_allocated_static_sdcch; - struct time_cc all_allocated_tch; - struct time_cc all_allocated_static_tch; + struct osmo_time_cc all_allocated_sdcch; + struct osmo_time_cc all_allocated_static_sdcch; + struct osmo_time_cc all_allocated_tch; + struct osmo_time_cc all_allocated_static_tch; }; struct gsm_audio_support { diff --git a/include/osmocom/bsc/time_cc.h b/include/osmocom/bsc/time_cc.h deleted file mode 100644 index abddbcf..0000000 --- a/include/osmocom/bsc/time_cc.h +++ /dev/null @@ -1,157 +0,0 @@ -/* Report the cumulative counter of time for which a flag is true as rate counter. */ -#pragma once - -#include - -#include - -struct osmo_tdef; -struct rate_ctr; - -/*! Configuration for time_cc. - * Report the cumulative counter of time for which a flag is true as rate counter. - * For example, for each second that the flag is true, increment a rate counter. - * - * The flag to be monitored is reported by time_cc_set_flag(). - * - * The granularity defines how much time one rate counter increment represents: - * the default configuration is gran_usec = 1000000, i.e. one rate counter increment represents one second. - * - * Reporting as rate counter is configurable by round_threshold_usec and forget_sum_usec, examples: - * - * round_threshold_usec: - * - To get "ceil()" behavior, set round_threshold_usec = 1. This increments the rate counter for each gran_usec period - * where the flag was seen true, even if it was true for only a very short fraction of a gran_usec period. - * - To get "round()" behavior, set round_threshold_usec = half of gran_usec. The rate counter increments when the flag - * has been true for 0.5 of a gran_usec (and then again at 1.5 * gran_usec of 'true' flag). round_threshold_usec = 0 - * is a special value that means to use half of gran_usec. - * - To get "floor()" behavior, set round_threshold_usec >= gran_usec. The rate counter increments when reaching full - * gran_usec periods of the flag being true. - * - * forget_sum_usec: - * This is a tradeoff between the accuracy of the reported rate counter and making sure that the events reported are not - * irrelevantly long ago. - * - To keep sub-granularity-period surplus time forever, set forget_sum_usec = 0. - * - To keep surplus time for up to a minute, set forget_sum_usec = 60000000 (60 seconds). - * - To get rid of "leftover" time (almost) immediately after the flag goes false, set forget_sum_usec = 1. - * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a - * possible inaccuracy of 1/60th, but makes sure that no timings older than a minute affect the current reports. - * - * Reporting modes in detail: - * - * The rate_ctr increments when the cumulative counter passes round_threshold_usec (default: half of gran_usec). - * - * sum ^ - * | ________ - * | / - * | / - * | / - * 3*gran --+--------------------------------------+ - * | /: - * | / : - * | - - - - - - - - - - - - - - - - - / : - * | /. : - * | / . : - * 2*gran --+--------------------------------+ . : - * | /: . : - * | / : . : - * | - - - - - - - - - -_________/ : . : - * | / . : . : - * | / . : . : - * 1*gran --+-----------------+ . : . : - * | /: . : . : - * | / : . : . : - * | - - - - - - -/ : . : . : - * | /. : . : . : - * | ....-------' . : . : . : - * 0 +------------------------------------------------------------------------> elapsed time - * . : . : . : - * _ _ _______ ____________ - * flag: __| |_| |____| . : |_______|. : . : |__________ - * f t f t f t . : f t. : . : f - * round_threshold_usec : . : . : . : - * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" - * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" - * >= gran_usec: 0 1 2 3 = "floor()" - * - */ -struct time_cc_cfg { - /*! Granularity in microseconds: nr of microseconds that one rate_ctr increment represents. A typical value is - * gran_usec = 1000000, meaning one rate counter increment represents one second. */ - uint64_t gran_usec; - /*! Nr of microseconds above a full gran_usec at which to trigger rate_ctr_round. When zero, half a gran_usec. */ - uint64_t round_threshold_usec; - /*! Forget counted sub-gran time after the flag was false for this long. */ - uint64_t forget_sum_usec; - /*! Rate counter to report to, or NULL to not use it. */ - struct rate_ctr *rate_ctr; - - /*! Update gran_usec from this T timer value, or zero to not use any T timer. */ - int T_gran; - /*! Update round_threshold_usec from this T timer value, or zero to not use any T timer. */ - int T_round_threshold; - /*! Update forget_sum_usec from this T timer value, or zero to not use any T timer. */ - int T_forget_sum; - /*! Look up T_gran and T_forget_sum in this list of timers, or NULL to not use any T timers. */ - struct osmo_tdef *T_defs; -}; - -/*! Report the cumulative counter of time for which a flag is true as rate counter. - * See also time_cc_cfg for details on configuring. - * - * Usage: - * - * struct my_obj { - * struct time_cc flag_cc; - * }; - * - * void my_obj_init(struct my_obj *my_obj) - * { - * time_cc_init(&my_obj->flag_cc); - * my_obj->flag_cc.cfg = (struct time_cc_cfg){ - * .gran_usec = 1000000, - * .forget_sum_usec = 60000000, - * .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, MY_CTR_IDX), - * }; - * // optional: set initial flag state, default is 'false': - * // time_cc_set_flag(&my_obj->flag_cc, false); - * } - * - * void my_obj_event(struct my_obj *my_obj, bool flag) - * { - * time_cc_set_flag(&my_obj->flag_cc, flag); - * } - * - * void my_obj_destruct(struct my_obj *my_obj) - * { - * time_cc_cleanup(&my_obj->flag_cc); - * } - */ -struct time_cc { - struct time_cc_cfg cfg; - - bool flag_state; - - /** Overall cumulative sum. Does not get reset for the entire lifetime of a time_cc. - * (Informational only, not used by the time_cc implementation.) */ - uint64_t total_sum; - - struct osmo_timer_list timer; - - /** CLOCK_MONOTONIC reading in microseconds, at the time when the time_cc instance started counting. */ - uint64_t start_time; - /** CLOCK_MONOTONIC reading in microseconds, at the time when the time_cc last evaluated the flag state and - * possibly added to the cumulated sum. */ - uint64_t last_counted_time; - - /** Internal cumulative counter of time that flag_state was true. It may get reset to zero regularly, depending - * on cfg.forget_sum_usec. This is the basis for incrementing cfg.rate_ctr. */ - uint64_t sum; - /** The amount of time that already reported cfg.rate_ctr increments account for. This may be ahead of or behind - * 'sum', depending on cfg.round_threshold_usec. */ - uint64_t reported_sum; -}; - -void time_cc_init(struct time_cc *tc); -void time_cc_set_flag(struct time_cc *tc, bool flag); -void time_cc_cleanup(struct time_cc *tc); diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index cebbaeb..583fb79 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -105,7 +105,6 @@ bssmap_reset.c \ system_information.c \ timeslot_fsm.c \ - time_cc.c \ smscb.c \ cbch_scheduler.c \ cbsp_link.c \ diff --git a/src/osmo-bsc/bsc_init.c b/src/osmo-bsc/bsc_init.c index 9328707..0412f6b 100644 --- a/src/osmo-bsc/bsc_init.c +++ b/src/osmo-bsc/bsc_init.c @@ -120,7 +120,7 @@ if (!net->bts_unknown_statg) goto err_free_all; - net->all_allocated_sdcch = (struct time_cc){ + net->all_allocated_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -131,7 +131,7 @@ .T_defs = net->T_defs, }, }; - net->all_allocated_static_sdcch = (struct time_cc){ + net->all_allocated_static_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -142,7 +142,7 @@ .T_defs = net->T_defs, }, }; - net->all_allocated_tch = (struct time_cc){ + net->all_allocated_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -153,7 +153,7 @@ .T_defs = net->T_defs, }, }; - net->all_allocated_static_tch = (struct time_cc){ + net->all_allocated_static_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index 0da3a6c..c789aea 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -215,46 +215,46 @@ chan_counts_add(&bts_counts, &trx_counts); } - time_cc_set_flag(&bts->all_allocated_sdcch, - bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&bts->all_allocated_sdcch, + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&bts->all_allocated_static_sdcch, - bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&bts->all_allocated_static_sdcch, + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&bts->all_allocated_tch, - (bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&bts->all_allocated_tch, + (bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); - time_cc_set_flag(&bts->all_allocated_static_tch, - (bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&bts->all_allocated_static_tch, + (bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bts_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); chan_counts_add(&bsc_counts, &bts_counts); } - time_cc_set_flag(&net->all_allocated_sdcch, - bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&net->all_allocated_sdcch, + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&net->all_allocated_static_sdcch, - bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] - && !bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); + osmo_time_cc_set_flag(&net->all_allocated_static_sdcch, + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_SDCCH] + && !bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_SDCCH]); - time_cc_set_flag(&net->all_allocated_tch, - (bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&net->all_allocated_tch, + (bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); - time_cc_set_flag(&net->all_allocated_static_tch, - (bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) - && !(bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] - + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); + osmo_time_cc_set_flag(&net->all_allocated_static_tch, + (bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_MAX_TOTAL][GSM_LCHAN_TCH_H]) + && !(bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F] + + bsc_counts.val[CHAN_COUNTS1_STATIC][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H])); } diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 8af1254..11b1ec3 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -211,7 +211,7 @@ } bts->bts_statg = osmo_stat_item_group_alloc(bts, &bts_statg_desc, bts->nr); - bts->all_allocated_sdcch = (struct time_cc){ + bts->all_allocated_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -222,7 +222,7 @@ .T_defs = net->T_defs, }, }; - bts->all_allocated_static_sdcch = (struct time_cc){ + bts->all_allocated_static_sdcch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -233,7 +233,7 @@ .T_defs = net->T_defs, }, }; - bts->all_allocated_tch = (struct time_cc){ + bts->all_allocated_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, @@ -244,7 +244,7 @@ .T_defs = net->T_defs, }, }; - bts->all_allocated_static_tch = (struct time_cc){ + bts->all_allocated_static_tch = (struct osmo_time_cc){ .cfg = { .gran_usec = 1*1000000, .forget_sum_usec = 60*1000000, diff --git a/src/osmo-bsc/time_cc.c b/src/osmo-bsc/time_cc.c deleted file mode 100644 index e78e48d..0000000 --- a/src/osmo-bsc/time_cc.c +++ /dev/null @@ -1,208 +0,0 @@ -/* Report the cumulative counter of time for which a flag is true as rate counter. */ -/* Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH - * - * All Rights Reserved - * - * Author: Neels Hofmeyr - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#include - -#include -#include - -#include - -#define GRAN_USEC(TIME_CC) ((TIME_CC)->cfg.gran_usec ? : 1000000) -#define ROUND_THRESHOLD_USEC(TIME_CC) ((TIME_CC)->cfg.round_threshold_usec ? \ - OSMO_MIN((TIME_CC)->cfg.round_threshold_usec, GRAN_USEC(TIME_CC)) \ - : (GRAN_USEC(TIME_CC) / 2)) - -static uint64_t time_now_usec() -{ - struct timespec tp; - if (osmo_clock_gettime(CLOCK_MONOTONIC, &tp)) - return 0; - return (uint64_t)tp.tv_sec * 1000000 + tp.tv_nsec / 1000; -} - -static void time_cc_forget_sum(struct time_cc *tc, uint64_t now); - -static void time_cc_update_from_tdef(struct time_cc *tc, uint64_t now) -{ - bool do_forget_sum = false; - if (!tc->cfg.T_defs) - return; - if (tc->cfg.T_gran) { - uint64_t was = GRAN_USEC(tc); - tc->cfg.gran_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_gran, OSMO_TDEF_US, -1); - if (was != GRAN_USEC(tc)) - do_forget_sum = true; - } - if (tc->cfg.T_round_threshold) - tc->cfg.round_threshold_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_round_threshold, - OSMO_TDEF_US, -1); - if (tc->cfg.T_forget_sum) { - uint64_t was = tc->cfg.forget_sum_usec; - tc->cfg.forget_sum_usec = osmo_tdef_get(tc->cfg.T_defs, tc->cfg.T_forget_sum, OSMO_TDEF_US, -1); - if (tc->cfg.forget_sum_usec && was != tc->cfg.forget_sum_usec) - do_forget_sum = true; - } - - if (do_forget_sum && tc->sum) - time_cc_forget_sum(tc, now); -} - -static void time_cc_schedule_timer(struct time_cc *tc, uint64_t now); - -/* Clear out osmo_timer and internal counting state of struct time_cc. The .cfg remains unaffected. After calling, the - * time_cc instance can be used again to accumulate state as if it had just been initialized. */ -void time_cc_cleanup(struct time_cc *tc) -{ - osmo_timer_del(&tc->timer); - *tc = (struct time_cc){ - .cfg = tc->cfg, - }; -} - -static void time_cc_start(struct time_cc *tc, uint64_t now) -{ - time_cc_cleanup(tc); - /* Set the default of 1 second of granularity */ - tc->start_time = now; - tc->last_counted_time = now; - time_cc_update_from_tdef(tc, now); - time_cc_schedule_timer(tc, now); -} - -static void time_cc_count_time(struct time_cc *tc, uint64_t now) -{ - uint64_t time_delta = now - tc->last_counted_time; - tc->last_counted_time = now; - if (!tc->flag_state) - return; - /* Flag is currently true, cumulate the elapsed time */ - tc->total_sum += time_delta; - tc->sum += time_delta; -} - -static void time_cc_report(struct time_cc *tc, uint64_t now) -{ - uint64_t delta; - uint64_t n; - if (!tc->cfg.rate_ctr) - return; - /* We report a sum "rounded up", ahead of time. If the granularity period has not yet elapsed after the last - * reporting, do not report again yet. */ - if (tc->reported_sum > tc->sum) - return; - delta = tc->sum - tc->reported_sum; - /* elapsed full periods */ - n = delta / GRAN_USEC(tc); - /* If the delta has passed round_threshold (normally half of gran_usec), increment. */ - delta -= n * GRAN_USEC(tc); - if (delta >= ROUND_THRESHOLD_USEC(tc)) - n++; - if (!n) - return; - - /* integer sanity, since rate_ctr_add() takes an int argument. */ - if (n > INT_MAX) - n = INT_MAX; - rate_ctr_add(tc->cfg.rate_ctr, n); - /* Store the increments of gran_usec that were counted. */ - tc->reported_sum += n * GRAN_USEC(tc); -} - -static void time_cc_forget_sum(struct time_cc *tc, uint64_t now) -{ - tc->reported_sum = 0; - tc->sum = 0; - - if (tc->last_counted_time < now) - tc->last_counted_time = now; -} - -/* Initialize struct time_cc. Call this once before use, and before setting up the .cfg items. */ -void time_cc_init(struct time_cc *tc) -{ - *tc = (struct time_cc){0}; -} - -void time_cc_set_flag(struct time_cc *tc, bool flag) -{ - uint64_t now = time_now_usec(); - if (!tc->start_time) - time_cc_start(tc, now); - /* No flag change == no effect */ - if (flag == tc->flag_state) - return; - /* Sum up elapsed time, report increments for that. */ - time_cc_count_time(tc, now); - time_cc_report(tc, now); - tc->flag_state = flag; - time_cc_schedule_timer(tc, now); -} - -static void time_cc_timer_cb(void *data) -{ - struct time_cc *tc = data; - uint64_t now = time_now_usec(); - - time_cc_update_from_tdef(tc, now); - - if (tc->flag_state) { - time_cc_count_time(tc, now); - time_cc_report(tc, now); - } else if (tc->cfg.forget_sum_usec && tc->sum - && (now >= tc->last_counted_time + tc->cfg.forget_sum_usec)) { - time_cc_forget_sum(tc, now); - } - time_cc_schedule_timer(tc, now); -} - -static void time_cc_schedule_timer(struct time_cc *tc, uint64_t now) -{ - uint64_t next_event = UINT64_MAX; - - time_cc_update_from_tdef(tc, now); - - /* Figure out the next time we should do anything, if the flag state remains unchanged. */ - /* If it is required, when will the next forget_sum happen? */ - if (tc->cfg.forget_sum_usec && !tc->flag_state && tc->sum > 0) { - uint64_t next_forget_time = tc->last_counted_time + tc->cfg.forget_sum_usec; - next_event = OSMO_MIN(next_event, next_forget_time); - } - /* Next rate_ctr increment? */ - if (tc->flag_state && tc->cfg.rate_ctr) { - uint64_t next_inc = now + (tc->reported_sum - tc->sum) + ROUND_THRESHOLD_USEC(tc); - next_event = OSMO_MIN(next_event, next_inc); - } - - /* No event coming up? */ - if (next_event == UINT64_MAX) - return; - - if (next_event <= now) - next_event = 0; - else - next_event -= now; - - osmo_timer_setup(&tc->timer, time_cc_timer_cb, tc); - osmo_timer_del(&tc->timer); - osmo_timer_schedule(&tc->timer, next_event / 1000000, next_event % 1000000); -} diff --git a/tests/Makefile.am b/tests/Makefile.am index c2d348b..a5f92ef 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -7,7 +7,6 @@ subscr \ nanobts_omlattr \ handover \ - time_cc \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. diff --git a/tests/testsuite.at b/tests/testsuite.at index 094117f..e7eb76b 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -49,9 +49,3 @@ cat $abs_srcdir/handover/handover_tests.ok > expout AT_CHECK([$abs_srcdir/handover/handover_tests.sh $abs_srcdir/handover $abs_builddir/handover], [], [expout], [ignore]) AT_CLEANUP - -AT_SETUP([time_cc_test]) -AT_KEYWORDS([time_cc_test]) -cat $abs_srcdir/time_cc/time_cc_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/time_cc/time_cc_test], [], [expout], [ignore]) -AT_CLEANUP diff --git a/tests/time_cc/Makefile.am b/tests/time_cc/Makefile.am deleted file mode 100644 index de407e7..0000000 --- a/tests/time_cc/Makefile.am +++ /dev/null @@ -1,36 +0,0 @@ -AM_CPPFLAGS = \ - $(all_includes) \ - -I$(top_srcdir)/include \ - $(NULL) - -AM_CFLAGS = \ - -Wall \ - -ggdb3 \ - $(LIBOSMOCORE_CFLAGS) \ - $(COVERAGE_CFLAGS) \ - $(NULL) - -AM_LDFLAGS = \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - -EXTRA_DIST = \ - time_cc_test.ok \ - $(NULL) - -noinst_PROGRAMS = \ - time_cc_test \ - $(NULL) - -time_cc_test_SOURCES = \ - time_cc_test.c \ - $(NULL) - -time_cc_test_LDADD = \ - $(top_builddir)/src/osmo-bsc/libbsc.la \ - $(LIBOSMOCORE_LIBS) \ - $(NULL) - -.PHONY: update_exp -update_exp: - $(builddir)/time_cc_test >$(srcdir)/time_cc_test.ok diff --git a/tests/time_cc/time_cc_test.c b/tests/time_cc/time_cc_test.c deleted file mode 100644 index 4c5396d..0000000 --- a/tests/time_cc/time_cc_test.c +++ /dev/null @@ -1,769 +0,0 @@ -/* (C) 2021 by sysmocom - s.f.m.c. GmbH - * All Rights Reserved - * - * Author: Neels Janosch Hofmeyr - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#include - -#include -#include -#include -#include -#include -#include - -#include - -enum my_ctrs { - CTR_CEIL, - CTR_ROUND, - CTR_FLOOR, -}; - -const struct rate_ctr_desc my_ctr_desc[] = { - [CTR_CEIL] = {"ceil", "testing round_threshold_usec = 1"}, - [CTR_ROUND] = {"round", "testing round_threshold_usec = 0 = gran_usec/2"}, - [CTR_FLOOR] = {"floor", "testing round_threshold_usec = gran_usec"}, -}; - -const struct rate_ctr_group_desc my_ctrg_desc = { - "time_cc_test", - "Counters for time_cc test", - 0, - ARRAY_SIZE(my_ctr_desc), - my_ctr_desc, -}; - -struct rate_ctr_group *my_ctrg; - - -enum my_obj_timers { - T_GRAN = -23, - T_ROUND_THRESH = -24, - T_FORGET_SUM = -25, -}; - -struct osmo_tdef g_my_obj_tdefs[] = { - { .T = T_GRAN, .default_val = 0, .unit = OSMO_TDEF_MS, .desc = "flag_cc granularity, or zero for 1 second" }, - { .T = T_ROUND_THRESH, .default_val = 0, .unit = OSMO_TDEF_MS, - .desc = "flag_cc rounding threshold, or zero for half a granularity" }, - { .T = T_FORGET_SUM, .default_val = 0, .unit = OSMO_TDEF_MS, - .desc = "flag_cc inactivity forget period, or zero to not forget any timings" }, - {} -}; - - -struct my_obj { - struct time_cc flag_cc_ceil; - struct time_cc flag_cc_round; - struct time_cc flag_cc_floor; -}; - -void my_obj_init(struct my_obj *my_obj) -{ - time_cc_init(&my_obj->flag_cc_ceil); - my_obj->flag_cc_ceil.cfg = (struct time_cc_cfg){ - .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_CEIL), - .round_threshold_usec = 1, - .T_gran = T_GRAN, - .T_forget_sum = T_FORGET_SUM, - .T_defs = g_my_obj_tdefs, - }; - - time_cc_init(&my_obj->flag_cc_round); - my_obj->flag_cc_round.cfg = (struct time_cc_cfg){ - .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_ROUND), - .T_gran = T_GRAN, - .T_round_threshold = T_ROUND_THRESH, - .T_forget_sum = T_FORGET_SUM, - .T_defs = g_my_obj_tdefs, - }; - - time_cc_init(&my_obj->flag_cc_floor); - my_obj->flag_cc_floor.cfg = (struct time_cc_cfg){ - .rate_ctr = rate_ctr_group_get_ctr(my_ctrg, CTR_FLOOR), - .round_threshold_usec = UINT64_MAX, /* always >= gran_usec */ - .T_gran = T_GRAN, - .T_forget_sum = T_FORGET_SUM, - .T_defs = g_my_obj_tdefs, - }; -} - -void my_obj_event(struct my_obj *my_obj, bool flag) -{ - time_cc_set_flag(&my_obj->flag_cc_ceil, flag); - time_cc_set_flag(&my_obj->flag_cc_round, flag); - time_cc_set_flag(&my_obj->flag_cc_floor, flag); -} - -void my_obj_destruct(struct my_obj *my_obj) -{ - time_cc_cleanup(&my_obj->flag_cc_ceil); - time_cc_cleanup(&my_obj->flag_cc_round); - time_cc_cleanup(&my_obj->flag_cc_floor); -} - -static const struct log_info_cat log_categories[] = { -}; - -static const struct log_info log_info = { - .cat = log_categories, - .num_cat = ARRAY_SIZE(log_categories), -}; - -int main() -{ - void *ctx = talloc_named_const(NULL, 0, "time_cc_test"); - struct timespec *now; - struct my_obj my_obj = {0}; - - osmo_init_logging2(ctx, &log_info); - - /* enable override for CLOCK_MONOTONIC */ - osmo_clock_override_enable(CLOCK_MONOTONIC, true); - now = osmo_clock_override_gettimespec(CLOCK_MONOTONIC); - now->tv_sec = 23000; - now->tv_nsec = 0; - - /* enable override for osmo_gettimeofday(), for osmo_timer_schedule() */ - osmo_gettimeofday_override = true; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_ctrg = rate_ctr_group_alloc(ctx, &my_ctrg_desc, 0); - -#define CHECK_RATE_CTRS(exp_ceil, exp_round, exp_floor) do { \ - printf("%d CHECK_RATE_CTRS(" #exp_ceil ", " #exp_round ", " #exp_floor ")", \ - my_obj.flag_cc_round.flag_state); \ - while (osmo_select_main_ctx(1) > 0); \ - if (exp_ceil != my_obj.flag_cc_ceil.cfg.rate_ctr->current \ - || exp_round != my_obj.flag_cc_round.cfg.rate_ctr->current \ - || exp_floor != my_obj.flag_cc_floor.cfg.rate_ctr->current) \ - printf("\n ERROR on line %d: ctr_ceil=%"PRIu64" ctr_round=%"PRIu64" ctr_floor=%"PRIu64"\n", \ - __LINE__, \ - my_obj.flag_cc_ceil.cfg.rate_ctr->current, \ - my_obj.flag_cc_round.cfg.rate_ctr->current, \ - my_obj.flag_cc_floor.cfg.rate_ctr->current); \ - else \ - printf(" ok\n"); \ - } while (0) - -#define ADD_MILLISECS_NO_SELECT(ms) do { \ - osmo_clock_override_add(CLOCK_MONOTONIC, ms / 1000, (uint64_t)(ms % 1000) * 1000000); \ - osmo_gettimeofday_override_add(ms / 1000, (uint64_t)(ms % 1000) * 1000); \ - printf("%d ADD_MILLISECS(" #ms ") --> %ld.%03ld", my_obj.flag_cc_round.flag_state, \ - now->tv_sec, now->tv_nsec/1000000); \ - printf("\n"); \ - } while (0) - -#define ADD_MILLISECS(ms) do { \ - ADD_MILLISECS_NO_SELECT(ms); \ - while (osmo_select_main_ctx(1) > 0); \ - } while (0) - -#define FLAG(VAL) do { \ - printf(" flag: %s -> %s\n", my_obj.flag_cc_round.flag_state ? "TRUE" : "FALSE", VAL ? "TRUE" : "FALSE"); \ - my_obj_event(&my_obj, VAL); \ - } while (0) - - /* - * sum ^ - * | ________ - * | / - * | / - * | / - * 3*gran --+--------------------------------------+ - * | /: - * | / : - * | - - - - - - - - - - - - - - - - - / : - * | /. : - * | / . : - * 2*gran --+--------------------------------+ . : - * | /: . : - * | / : . : - * | - - - - - - - - - -_________/ : . : - * | / . : . : - * | / . : . : - * 1*gran --+-----------------+ . : . : - * | /: . : . : - * | / : . : . : - * | - - - - - - -/ : . : . : - * | /. : . : . : - * | ....-------' . : . : . : - * 0 +----------------------------------------------------------> elapsed time - * . : . : . : - * _ _ _______ ____________ - * flag: __| |_| |____| . : |_______|. : . : |__________ - * f t f t f t . : f t. : . : f - * round_threshold_usec : . : . : . : - * = 1 usec: 0 1 . :2 . :3 . :4 = "ceil()" - * = 0 == gran_usec/2: 0 1 : 2 : 3 : = "round()" - * = gran_usec: 0 1 2 3 = "floor()" - */ - - printf("\n----------- cumulating time, without forget_sum\n\n"); - - my_obj_init(&my_obj); - CHECK_RATE_CTRS(0, 0, 0); - - ADD_MILLISECS(100); - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS(1); - /* flag has been true for 0.001s */ - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(99); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(100); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(100); - /* flag has been true for 0.2s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(300); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(299); - /* flag has been true for 0.499s */ - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(1); - /* flag has been true for 0.5s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS(499); - /* flag has been true for 0.999s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS(1); - /* flag has been true for 1.0s */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS(1); - /* flag has been true for 1.001s */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(299); - /* flag has been true for 1.3s */ - CHECK_RATE_CTRS(2, 1, 1); - FLAG(false); - CHECK_RATE_CTRS(2, 1, 1); - - ADD_MILLISECS(400); - - CHECK_RATE_CTRS(2, 1, 1); - FLAG(true); - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(199); - /* flag has been true for 1.499s */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(2); - /* flag has been true for 1.501s */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(498); - /* flag has been true for 1.999s */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(2); - /* flag has been true for 2.001s */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS(500); - /* flag has been true for 2.501s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(498); - /* flag has been true for 2.999s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(3); - /* flag has been true for 3.003s */ - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS(200); - /* flag has been true for 3.203s */ - CHECK_RATE_CTRS(4, 3, 3); - FLAG(false); - CHECK_RATE_CTRS(4, 3, 3); - - ADD_MILLISECS(4321); - CHECK_RATE_CTRS(4, 3, 3); - - FLAG(true); - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS(5678); - CHECK_RATE_CTRS(9, 9, 8); - FLAG(false); - CHECK_RATE_CTRS(9, 9, 8); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - printf("\n----------- test forget_sum_usec\n\n"); - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); - - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_obj_init(&my_obj); - - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS(100); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(1000); - /* 1 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(8999); - /* 9.999 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS(1); - /* 10 s of being false, forget_sum_usec has occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(1); - /* Since previous sums were forgotton, ceil() triggers again */ - CHECK_RATE_CTRS(2, 0, 0); - /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify - * that this does not occur, since now full 500 ms are required */ - ADD_MILLISECS(399); - CHECK_RATE_CTRS(2, 0, 0); - /* Adding another 100 ms will trigger round() */ - ADD_MILLISECS(99); - CHECK_RATE_CTRS(2, 0, 0); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(2, 1, 0); - /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify - * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ - ADD_MILLISECS(400); - CHECK_RATE_CTRS(2, 1, 0); - /* Adding another 100 ms will trigger floor() */ - ADD_MILLISECS(99); - CHECK_RATE_CTRS(2, 1, 0); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(2, 1, 1); - - /* Test that durations of false below forget_sum_usec never trigger a forget */ - ADD_MILLISECS(300); - CHECK_RATE_CTRS(3, 1, 1); - /* internal counter is now at 0.3s above the last reported rate counter */ - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - FLAG(false); - ADD_MILLISECS(9999); - FLAG(true); - ADD_MILLISECS(25); - /* internal counter is now at 0.4s above the last reported rate counter */ - CHECK_RATE_CTRS(3, 1, 1); - ADD_MILLISECS(100); - CHECK_RATE_CTRS(3, 2, 1); - ADD_MILLISECS(500); - CHECK_RATE_CTRS(3, 2, 2); - - /* Test that repeated time_cc_set_flag(false) does not cancel a forget_sum_usec */ - ADD_MILLISECS(300); - /* internal counter is now at 0.3s above the last reported rate counter */ - CHECK_RATE_CTRS(4, 2, 2); - FLAG(false); - ADD_MILLISECS(5000); - /* Repeat 'false', must not affect forget_sum_usec */ - FLAG(false); - ADD_MILLISECS(5000); - CHECK_RATE_CTRS(4, 2, 2); - /* 10 s have passed, forget_sum_usec has occurred. - * Hence ceil() will trigger again right away: */ - FLAG(true); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(5, 2, 2); - /* Adding 200 ms to the initial 300 ms would have triggered round(), but no more after forget_sum_usec */ - ADD_MILLISECS(199); - CHECK_RATE_CTRS(5, 2, 2); - /* Adding another 300 ms will trigger round() */ - ADD_MILLISECS(299); - CHECK_RATE_CTRS(5, 2, 2); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(5, 3, 2); - /* Adding 700 ms to the initial 300 ms would have triggered ceil(), but no more after forget_sum_usec */ - ADD_MILLISECS(200); - CHECK_RATE_CTRS(5, 3, 2); - /* Adding another 300 ms will trigger ceil() */ - ADD_MILLISECS(299); - CHECK_RATE_CTRS(5, 3, 2); - ADD_MILLISECS(1); - CHECK_RATE_CTRS(5, 3, 3); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - - /* Verify correctness when select() lags and runs timer callbacks too late */ - printf("\n----------- cumulating time, without forget_sum, when timer cb are invoked late\n\n"); - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 0, OSMO_TDEF_S); - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_obj_init(&my_obj); - CHECK_RATE_CTRS(0, 0, 0); - - ADD_MILLISECS_NO_SELECT(100); - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS_NO_SELECT(100); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(100); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS_NO_SELECT(100); - /* flag has been true for 0.2s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(300); - - CHECK_RATE_CTRS(1, 0, 0); - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS_NO_SELECT(799); - /* flag has been true for 0.999s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 1.0s */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS_NO_SELECT(300); - /* flag has been true for 1.3s */ - CHECK_RATE_CTRS(2, 1, 1); - FLAG(false); - CHECK_RATE_CTRS(2, 1, 1); - - ADD_MILLISECS_NO_SELECT(400); - - CHECK_RATE_CTRS(2, 1, 1); - FLAG(true); - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS_NO_SELECT(699); - /* flag has been true for 1.999s */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 2.0s */ - CHECK_RATE_CTRS(2, 2, 2); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 2.001s */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS_NO_SELECT(499); - /* flag has been true for 2.5s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS_NO_SELECT(499); - /* flag has been true for 2.999s */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS_NO_SELECT(1); - /* flag has been true for 3.0s */ - CHECK_RATE_CTRS(3, 3, 3); - ADD_MILLISECS_NO_SELECT(200); - /* flag has been true for 3.2s */ - CHECK_RATE_CTRS(4, 3, 3); - FLAG(false); - CHECK_RATE_CTRS(4, 3, 3); - - ADD_MILLISECS_NO_SELECT(4321); - CHECK_RATE_CTRS(4, 3, 3); - - FLAG(true); - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS_NO_SELECT(5678); - CHECK_RATE_CTRS(9, 9, 8); - FLAG(false); - CHECK_RATE_CTRS(9, 9, 8); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - - printf("\n----------- test forget_sum, when timer cb are invoked late\n\n"); - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, 10, OSMO_TDEF_S); - - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - my_obj_init(&my_obj); - - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS_NO_SELECT(100); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 0, 0); - FLAG(false); - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(1000); - /* 1 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(8999); - /* 9.999 s of being false, forget_sum_usec has not yet occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - ADD_MILLISECS_NO_SELECT(1); - /* 10 s of being false, forget_sum_usec has occurred */ - CHECK_RATE_CTRS(1, 0, 0); - - FLAG(true); - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS_NO_SELECT(1); - /* Since previous sums were forgotton, ceil() triggers again */ - CHECK_RATE_CTRS(2, 0, 0); - /* If the sum had not been forgotten, adding 400 ms to the initial 100 ms would have triggered round(). Verify - * that this does not occur, since now full 500 ms are required */ - ADD_MILLISECS_NO_SELECT(399); - CHECK_RATE_CTRS(2, 0, 0); - /* Adding another 100 ms will trigger round() */ - ADD_MILLISECS_NO_SELECT(99); - CHECK_RATE_CTRS(2, 0, 0); - ADD_MILLISECS_NO_SELECT(1); - CHECK_RATE_CTRS(2, 1, 0); - /* If the sum had not been forgotten, adding 900 ms to the initial 100 ms would have triggered floor(). Verify - * that this does not occur, since now full 1000 ms are required. We already added 500 ms above. */ - ADD_MILLISECS_NO_SELECT(400); - CHECK_RATE_CTRS(2, 1, 0); - /* Adding another 100 ms will trigger floor() */ - ADD_MILLISECS_NO_SELECT(99); - CHECK_RATE_CTRS(2, 1, 0); - ADD_MILLISECS_NO_SELECT(1); - CHECK_RATE_CTRS(2, 1, 1); - - /* Test that durations of false below forget_sum_usec never trigger a forget */ - ADD_MILLISECS_NO_SELECT(300); - CHECK_RATE_CTRS(3, 1, 1); - /* internal counter is now at 0.3s above the last reported rate counter */ - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - FLAG(false); - ADD_MILLISECS_NO_SELECT(9999); - FLAG(true); - ADD_MILLISECS_NO_SELECT(25); - /* internal counter is now at 0.4s above the last reported rate counter */ - CHECK_RATE_CTRS(3, 1, 1); - ADD_MILLISECS_NO_SELECT(100); - CHECK_RATE_CTRS(3, 2, 1); - ADD_MILLISECS_NO_SELECT(500); - CHECK_RATE_CTRS(3, 2, 2); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - -#define SET_TDEFS(gran, round_thresh, forget_sum) do { \ - osmo_tdef_set(g_my_obj_tdefs, T_GRAN, gran, OSMO_TDEF_MS); \ - osmo_tdef_set(g_my_obj_tdefs, T_ROUND_THRESH, round_thresh, OSMO_TDEF_MS); \ - osmo_tdef_set(g_my_obj_tdefs, T_FORGET_SUM, forget_sum, OSMO_TDEF_S); \ - printf("T_defs: T_gran=%luusec T_round_threshold=%luusec T_forget_sum=%luusec\n", \ - osmo_tdef_get(g_my_obj_tdefs, T_GRAN, OSMO_TDEF_US, -1), \ - osmo_tdef_get(g_my_obj_tdefs, T_ROUND_THRESH, OSMO_TDEF_US, -1), \ - osmo_tdef_get(g_my_obj_tdefs, T_FORGET_SUM, OSMO_TDEF_US, -1)); \ - } while (0) - - printf("\n----------- test T_defs\n\n"); - now->tv_sec = 23000; - now->tv_nsec = 0; - osmo_gettimeofday_override_time = (struct timeval){23000, 0}; - - SET_TDEFS(100, 10, 0); - - my_obj_init(&my_obj); - CHECK_RATE_CTRS(0, 0, 0); - - ADD_MILLISECS(100); - CHECK_RATE_CTRS(0, 0, 0); - - FLAG(true); - /* flag has just turned true the first time */ - CHECK_RATE_CTRS(0, 0, 0); - ADD_MILLISECS(9); - /* flag has been true for 0.009s */ - CHECK_RATE_CTRS(1, 0, 0); - ADD_MILLISECS(1); - /* flag has been true for 0.010s */ - CHECK_RATE_CTRS(1, 1, 0); - ADD_MILLISECS(90); - /* flag has been true for 0.1s */ - CHECK_RATE_CTRS(1, 1, 1); - - SET_TDEFS(200, 190, 1); - /* gran is changed to 200ms, but still continues until the next scheduled event until the change is picked up. - * For ceil(), it is 1 ms ahead. - * For round(), it is 10 ms ahead. - * For floor(), it is at the next full (previous) gran 100 ms ahead. - * When T_defs change, all internal sums are reset to zero without reporting. - */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS(1); - /* 1ms elapsed: ceil() picks up the T_gran change, starts anew. */ - /* elapsed: ceil 0 ms */ - CHECK_RATE_CTRS(1, 1, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 1 ms */ - /* ceil() increments because flag has been true for more than 1 us after reset */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(8); - /* 10 ms elapsed: round() picks up the T_gran change, starts anew */ - /* elapsed: ceil 9 ms, round 0 ms */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(90); - /* 100 ms elapsed: floor() picks up the T_gran change, starts anew */ - /* elapsed: ceil 99 ms, round 90 ms, floor 0 ms */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(99); - /* elapsed: ceil 198 ms, round 189 ms, floor 99 ms */ - CHECK_RATE_CTRS(2, 1, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 199 ms, round 190 ms, floor 100 ms */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 200 ms, round 191 ms, floor 101 ms */ - CHECK_RATE_CTRS(2, 2, 1); - ADD_MILLISECS(1); - /* elapsed: ceil 201 ms, round 192 ms, floor 102 ms */ - CHECK_RATE_CTRS(3, 2, 1); - ADD_MILLISECS(98); - /* elapsed: ceil 299 ms, round 290 ms, floor 200 ms */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS(99); - /* elapsed: ceil 398 ms, round 389 ms, floor 299 ms */ - CHECK_RATE_CTRS(3, 2, 2); - ADD_MILLISECS(1); - /* elapsed: ceil 399 ms, round 390 ms, floor 300 ms */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(1); - /* elapsed: ceil 400 ms, round 391 ms, floor 301 ms */ - CHECK_RATE_CTRS(3, 3, 2); - ADD_MILLISECS(1); - /* elapsed: ceil 401 ms, round 392 ms, floor 302 ms */ - CHECK_RATE_CTRS(4, 3, 2); - ADD_MILLISECS(98); - /* elapsed: ceil 499 ms, round 490 ms, floor 400 ms */ - CHECK_RATE_CTRS(4, 3, 3); - - - SET_TDEFS(100, 0, 0); - /* T_defs change, but they only get picked up upon the next event: - * For ceil(), it is 102 ms ahead. - * For round(), it is 100 ms ahead (thresh is still 190, currently at 90). - * For floor(), it is 200 ms ahead. - * When T_defs change, all internal sums are reset to zero without reporting. - */ - CHECK_RATE_CTRS(4, 3, 3); - ADD_MILLISECS(100); - CHECK_RATE_CTRS(4, 3, 3); - /* round() picks up the new T_defs. Internal sum resets, nothing else happens yet. - * round() schedules the next event 50 ms ahead. */ - ADD_MILLISECS(2); - CHECK_RATE_CTRS(4, 3, 3); - /* ceil() picks up the change, its next event is 1 ms ahead. */ - ADD_MILLISECS(1); - /* ceil: 0.001 - * round: 0.003 - * floor: still 97 ms until it picks up the change */ - CHECK_RATE_CTRS(5, 3, 3); - ADD_MILLISECS(46); - CHECK_RATE_CTRS(5, 3, 3); - ADD_MILLISECS(1); - /* round() has first counter trigger after T_defs change. */ - CHECK_RATE_CTRS(5, 4, 3); - /* ceil: 0.048 - * round: 0.050 - * floor: still 50 ms until it picks up the change */ - ADD_MILLISECS(50); - /* floor() picks up the change. nothing happens yet. */ - /* ceil: 0.098 - * round: 0.100 - * floor: 0.0 */ - ADD_MILLISECS(2); - /* ceil: 0.100 - * round: 0.102 - * floor: 0.002 */ - CHECK_RATE_CTRS(5, 4, 3); - ADD_MILLISECS(1); - /* ceil: 0.101 - * round: 0.103 - * floor: 0.003 */ - CHECK_RATE_CTRS(6, 4, 3); - ADD_MILLISECS(46); - /* ceil: 0.147 - * round: 0.149 - * floor: 0.049 */ - CHECK_RATE_CTRS(6, 4, 3); - ADD_MILLISECS(1); - /* ceil: 0.148 - * round: 0.150 - * floor: 0.050 */ - CHECK_RATE_CTRS(6, 5, 3); - - my_obj_destruct(&my_obj); - rate_ctr_group_reset(my_ctrg); - - return 0; -} diff --git a/tests/time_cc/time_cc_test.ok b/tests/time_cc/time_cc_test.ok deleted file mode 100644 index ccf84d9..0000000 --- a/tests/time_cc/time_cc_test.ok +++ /dev/null @@ -1,328 +0,0 @@ - ------------ cumulating time, without forget_sum - -0 CHECK_RATE_CTRS(0, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.100 -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(1) --> 23000.101 -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(99) --> 23000.200 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.300 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.400 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(300) --> 23000.700 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(299) --> 23000.999 -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23001.000 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(499) --> 23001.499 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(1) --> 23001.500 -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(1) --> 23001.501 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(299) --> 23001.800 -1 CHECK_RATE_CTRS(2, 1, 1) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(2, 1, 1) ok -0 ADD_MILLISECS(400) --> 23002.200 -0 CHECK_RATE_CTRS(2, 1, 1) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(199) --> 23002.399 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(2) --> 23002.401 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(498) --> 23002.899 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(2) --> 23002.901 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(500) --> 23003.401 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(498) --> 23003.899 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(3) --> 23003.902 -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(200) --> 23004.102 -1 CHECK_RATE_CTRS(4, 3, 3) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(4, 3, 3) ok -0 ADD_MILLISECS(4321) --> 23008.423 -0 CHECK_RATE_CTRS(4, 3, 3) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(5678) --> 23014.101 -1 CHECK_RATE_CTRS(9, 9, 8) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(9, 9, 8) ok - ------------ test forget_sum_usec - -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.100 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1000) --> 23001.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(8999) --> 23010.099 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1) --> 23010.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.101 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(399) --> 23010.500 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(99) --> 23010.599 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.600 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(400) --> 23011.000 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(99) --> 23011.099 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(1) --> 23011.100 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(300) --> 23011.400 -1 CHECK_RATE_CTRS(3, 1, 1) ok - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23021.399 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23021.424 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23031.423 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23031.448 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23041.447 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23041.472 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23051.471 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23051.496 -1 CHECK_RATE_CTRS(3, 1, 1) ok -1 ADD_MILLISECS(100) --> 23051.596 -1 CHECK_RATE_CTRS(3, 2, 1) ok -1 ADD_MILLISECS(500) --> 23052.096 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(300) --> 23052.396 -1 CHECK_RATE_CTRS(4, 2, 2) ok - flag: TRUE -> FALSE -0 ADD_MILLISECS(5000) --> 23057.396 - flag: FALSE -> FALSE -0 ADD_MILLISECS(5000) --> 23062.396 -0 CHECK_RATE_CTRS(4, 2, 2) ok - flag: FALSE -> TRUE -1 ADD_MILLISECS(1) --> 23062.397 -1 CHECK_RATE_CTRS(5, 2, 2) ok -1 ADD_MILLISECS(199) --> 23062.596 -1 CHECK_RATE_CTRS(5, 2, 2) ok -1 ADD_MILLISECS(299) --> 23062.895 -1 CHECK_RATE_CTRS(5, 2, 2) ok -1 ADD_MILLISECS(1) --> 23062.896 -1 CHECK_RATE_CTRS(5, 3, 2) ok -1 ADD_MILLISECS(200) --> 23063.096 -1 CHECK_RATE_CTRS(5, 3, 2) ok -1 ADD_MILLISECS(299) --> 23063.395 -1 CHECK_RATE_CTRS(5, 3, 2) ok -1 ADD_MILLISECS(1) --> 23063.396 -1 CHECK_RATE_CTRS(5, 3, 3) ok - ------------ cumulating time, without forget_sum, when timer cb are invoked late - -0 CHECK_RATE_CTRS(0, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.100 -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.200 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.300 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.400 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(300) --> 23000.700 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(799) --> 23001.499 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(1) --> 23001.500 -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(300) --> 23001.800 -1 CHECK_RATE_CTRS(2, 1, 1) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(2, 1, 1) ok -0 ADD_MILLISECS(400) --> 23002.200 -0 CHECK_RATE_CTRS(2, 1, 1) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(699) --> 23002.899 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(1) --> 23002.900 -1 CHECK_RATE_CTRS(2, 2, 2) ok -1 ADD_MILLISECS(1) --> 23002.901 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(499) --> 23003.400 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(499) --> 23003.899 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(1) --> 23003.900 -1 CHECK_RATE_CTRS(3, 3, 3) ok -1 ADD_MILLISECS(200) --> 23004.100 -1 CHECK_RATE_CTRS(4, 3, 3) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(4, 3, 3) ok -0 ADD_MILLISECS(4321) --> 23008.421 -0 CHECK_RATE_CTRS(4, 3, 3) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(5678) --> 23014.099 -1 CHECK_RATE_CTRS(9, 9, 8) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(9, 9, 8) ok - ------------ test forget_sum, when timer cb are invoked late - -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(100) --> 23000.100 -1 CHECK_RATE_CTRS(1, 0, 0) ok - flag: TRUE -> FALSE -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1000) --> 23001.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(8999) --> 23010.099 -0 CHECK_RATE_CTRS(1, 0, 0) ok -0 ADD_MILLISECS(1) --> 23010.100 -0 CHECK_RATE_CTRS(1, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.101 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(399) --> 23010.500 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(99) --> 23010.599 -1 CHECK_RATE_CTRS(2, 0, 0) ok -1 ADD_MILLISECS(1) --> 23010.600 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(400) --> 23011.000 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(99) --> 23011.099 -1 CHECK_RATE_CTRS(2, 1, 0) ok -1 ADD_MILLISECS(1) --> 23011.100 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(300) --> 23011.400 -1 CHECK_RATE_CTRS(3, 1, 1) ok - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23021.399 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23021.424 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23031.423 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23031.448 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23041.447 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23041.472 - flag: TRUE -> FALSE -0 ADD_MILLISECS(9999) --> 23051.471 - flag: FALSE -> TRUE -1 ADD_MILLISECS(25) --> 23051.496 -1 CHECK_RATE_CTRS(3, 1, 1) ok -1 ADD_MILLISECS(100) --> 23051.596 -1 CHECK_RATE_CTRS(3, 2, 1) ok -1 ADD_MILLISECS(500) --> 23052.096 -1 CHECK_RATE_CTRS(3, 2, 2) ok - ------------ test T_defs - -T_defs: T_gran=100000usec T_round_threshold=10000usec T_forget_sum=0usec -0 CHECK_RATE_CTRS(0, 0, 0) ok -0 ADD_MILLISECS(100) --> 23000.100 -0 CHECK_RATE_CTRS(0, 0, 0) ok - flag: FALSE -> TRUE -1 CHECK_RATE_CTRS(0, 0, 0) ok -1 ADD_MILLISECS(9) --> 23000.109 -1 CHECK_RATE_CTRS(1, 0, 0) ok -1 ADD_MILLISECS(1) --> 23000.110 -1 CHECK_RATE_CTRS(1, 1, 0) ok -1 ADD_MILLISECS(90) --> 23000.200 -1 CHECK_RATE_CTRS(1, 1, 1) ok -T_defs: T_gran=200000usec T_round_threshold=190000usec T_forget_sum=1000000usec -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(1) --> 23000.201 -1 CHECK_RATE_CTRS(1, 1, 1) ok -1 ADD_MILLISECS(1) --> 23000.202 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(8) --> 23000.210 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(90) --> 23000.300 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(99) --> 23000.399 -1 CHECK_RATE_CTRS(2, 1, 1) ok -1 ADD_MILLISECS(1) --> 23000.400 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(1) --> 23000.401 -1 CHECK_RATE_CTRS(2, 2, 1) ok -1 ADD_MILLISECS(1) --> 23000.402 -1 CHECK_RATE_CTRS(3, 2, 1) ok -1 ADD_MILLISECS(98) --> 23000.500 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(99) --> 23000.599 -1 CHECK_RATE_CTRS(3, 2, 2) ok -1 ADD_MILLISECS(1) --> 23000.600 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(1) --> 23000.601 -1 CHECK_RATE_CTRS(3, 3, 2) ok -1 ADD_MILLISECS(1) --> 23000.602 -1 CHECK_RATE_CTRS(4, 3, 2) ok -1 ADD_MILLISECS(98) --> 23000.700 -1 CHECK_RATE_CTRS(4, 3, 3) ok -T_defs: T_gran=100000usec T_round_threshold=0usec T_forget_sum=0usec -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(100) --> 23000.800 -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(2) --> 23000.802 -1 CHECK_RATE_CTRS(4, 3, 3) ok -1 ADD_MILLISECS(1) --> 23000.803 -1 CHECK_RATE_CTRS(5, 3, 3) ok -1 ADD_MILLISECS(46) --> 23000.849 -1 CHECK_RATE_CTRS(5, 3, 3) ok -1 ADD_MILLISECS(1) --> 23000.850 -1 CHECK_RATE_CTRS(5, 4, 3) ok -1 ADD_MILLISECS(50) --> 23000.900 -1 ADD_MILLISECS(2) --> 23000.902 -1 CHECK_RATE_CTRS(5, 4, 3) ok -1 ADD_MILLISECS(1) --> 23000.903 -1 CHECK_RATE_CTRS(6, 4, 3) ok -1 ADD_MILLISECS(46) --> 23000.949 -1 CHECK_RATE_CTRS(6, 4, 3) ok -1 ADD_MILLISECS(1) --> 23000.950 -1 CHECK_RATE_CTRS(6, 5, 3) ok -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ica9f908a1a30f334a24c59471affa11225117e12 Gerrit-Change-Number: 26231 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:18:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:18:15 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gsm-manuals=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E0=2E18-cec5_=E2=86=92_1=2E2=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 ) Change subject: Bump version: 1.1.0.18-cec5 ? 1.2.0 ...................................................................... Bump version: 1.1.0.18-cec5 ? 1.2.0 Change-Id: Id9167fa8aa474bb6feb349a2dcecb015b2a1d3b4 --- M debian/changelog 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/65/26265/1 diff --git a/debian/changelog b/debian/changelog index f19b6d4..8f9668b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,37 @@ +osmo-gsm-manuals-dev (1.2.0) unstable; urgency=medium + + [ Harald Welte ] + * add README.md to describe what this repo is about + * build: Switch from rita -> ftp.osmocom.org + * bibliography: Re-introduce RFC768 (UDP) + * Add new common chapter about QoS, IP DSCP and IEEE 802.1q PCP + * glossary: fix various typos I introduced. + + [ Vadim Yanitskiy ] + * fix tests/Makefile.am: exclude file 'mgcp_extension_osmux.adoc' + * fix missing and/or non-existent linked references + * TRXD: clarify modulation specific length of Soft-/Hard-bits + * TRXD: rework description of the NOPE / IDLE frame indication + * TRXD: generalize description of the 'RFU' ('PAD') field + * TRXD: add documentation for TRXDv2 protocol + * TRXDv2: add primary/shadow classification for VAMOS PDUs + * mncc: do not mention deprecated -m / --mncc-sock options + + [ Alexander Couzens ] + * common/chapters: extend gb/ns2 chapters + + [ Neels Hofmeyr ] + * bib: add reference to 3GPP TS 45.002, for Training Sequence definitions + + [ Oliver Smith ] + * port_numbers: add osmo-pcap-client, -server + * d/patches/build-for-debian8.patch: remove + + [ Pau Espin Pedrol ] + * cs7-config.adoc: Improve doc on default SS7 SCTP addresses + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:18:04 +0100 + osmo-gsm-manuals-dev (1.1.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id9167fa8aa474bb6feb349a2dcecb015b2a1d3b4 Gerrit-Change-Number: 26265 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:35:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:35:39 +0000 Subject: Change in osmo-pcap[master]: Explicitly depend on required libosmogb References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26266 ) Change subject: Explicitly depend on required libosmogb ...................................................................... Explicitly depend on required libosmogb the spec.in files already stated so expicitly, since some files include osmocom/gprs/*.h. Only some data types from there are used, so there's no need in linking the lib. Even more, doing so makes the build fail because there soft-linking symbols required to be implemented by libosmogb are not implemented here. Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 --- M configure.ac M src/Makefile.am 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/66/26266/1 diff --git a/configure.ac b/configure.ac index f4c004a..7856522 100644 --- a/configure.ac +++ b/configure.ac @@ -158,6 +158,7 @@ dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) diff --git a/src/Makefile.am b/src/Makefile.am index 17ed4e3..6b887d3 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,5 +1,5 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/ -AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(PCAP_CFLAGS) $(LIBGNUTLS_CFLAGS) +AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOGB_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(PCAP_CFLAGS) $(LIBGNUTLS_CFLAGS) bin_PROGRAMS = osmo-pcap-client osmo-pcap-server -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 Gerrit-Change-Number: 26266 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:36:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:36:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3172_* In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 ) Change subject: pcu: Introduce test TC_t3172_* ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 Gerrit-Change-Number: 26256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 12:36:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:36:23 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:36:23 +0000 Subject: Change in osmo-pcap[master]: Explicitly depend on required libosmogb In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcap/+/26266 ) Change subject: Explicitly depend on required libosmogb ...................................................................... Explicitly depend on required libosmogb the spec.in files already stated so expicitly, since some files include osmocom/gprs/*.h. Only some data types from there are used, so there's no need in linking the lib. Even more, doing so makes the build fail because there soft-linking symbols required to be implemented by libosmogb are not implemented here. Related: OS#5311 Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 --- M configure.ac M src/Makefile.am 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/66/26266/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 Gerrit-Change-Number: 26266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:40:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:40:31 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-30bc-dirty_=E2=86=92_0=2E2=2E1?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26267 ) Change subject: Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 ...................................................................... Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb --- M configure.ac M contrib/osmo-pcap.spec.in M debian/changelog M debian/control 4 files changed, 21 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/67/26267/1 diff --git a/configure.ac b/configure.ac index 7856522..abba918 100644 --- a/configure.ac +++ b/configure.ac @@ -157,10 +157,10 @@ AC_SUBST([PCAP_CFLAGS]) dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) PKG_CHECK_MODULES(LIBGNUTLS, gnutls) diff --git a/contrib/osmo-pcap.spec.in b/contrib/osmo-pcap.spec.in index db2dcf0..d4459b4 100644 --- a/contrib/osmo-pcap.spec.in +++ b/contrib/osmo-pcap.spec.in @@ -29,10 +29,10 @@ %endif BuildRequires: pkgconfig BuildRequires: pkgconfig(gnutls) -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(libzmq) >= 3.2.2 %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 4d9c065..90c0285 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,15 @@ +osmo-pcap (0.2.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * Explicitly depend on required libosmogb + + [ Oliver Smith ] + * README.md: fix typo + * Change default ports of client, server + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:40:07 +0100 + osmo-pcap (0.2.0) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index 68d38c7..5c65ee8 100644 --- a/debian/control +++ b/debian/control @@ -7,7 +7,7 @@ autotools-dev, libpcap0.8-dev, pkg-config, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), libgnutls28-dev, libzmq3-dev Standards-Version: 3.9.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb Gerrit-Change-Number: 26267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:40:44 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:40:44 +0000 Subject: Change in osmo-pcap[master]: Explicitly depend on required libosmogb In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26266 ) Change subject: Explicitly depend on required libosmogb ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 Gerrit-Change-Number: 26266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:40:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:42:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:42:52 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-30bc-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26267 ) Change subject: Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcap/+/26267/1/debian/control File debian/control: https://gerrit.osmocom.org/c/osmo-pcap/+/26267/1/debian/control at 12 PS1, Line 12: libzmq3-dev Unrelated: in the *.spec file we require '>= 3.2.2'. I guess we want here too? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb Gerrit-Change-Number: 26267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:42:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:46:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:46:02 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gsm-manuals=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E0=2E18-cec5_=E2=86=92_1=2E2=2E0?= In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 ) Change subject: Bump version: 1.1.0.18-cec5 ? 1.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id9167fa8aa474bb6feb349a2dcecb015b2a1d3b4 Gerrit-Change-Number: 26265 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:46:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:46:36 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-30bc-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26267 ) Change subject: Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcap/+/26267/1/debian/control File debian/control: https://gerrit.osmocom.org/c/osmo-pcap/+/26267/1/debian/control at 12 PS1, Line 12: libzmq3-dev > Unrelated: in the *.spec file we require '>= 3.2.2'. [?] Too much stuff to take care of already when doing the release to be side tracked by this missing info. Feel free to write those down and submit patches to get them merged for next release. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb Gerrit-Change-Number: 26267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:47:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:47:48 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... Patch Set 1: What about libtalloc-dev in 'debian/control'? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:47:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:48:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:48:05 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:48:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:48:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:48:27 +0000 Subject: Change in libosmocore[master]: osmo-release.sh: Blacklist script file from LIBVERS matches In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26263 ) Change subject: osmo-release.sh: Blacklist script file from LIBVERS matches ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d750d312017ebb434650a6e19707ec60faf4020 Gerrit-Change-Number: 26263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:48:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:49:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:49:32 +0000 Subject: =?UTF-8?Q?Change_in_osmo-ggsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E1=2E20-8cbd-dirty_=E2=86=92_1=2E8=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 ) Change subject: Bump version: 1.7.1.20-8cbd-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.1.20-8cbd-dirty ? 1.8.0 Change-Id: I21502c6e0b804237fe9bd8f5579dbabd519d6d51 --- M TODO-RELEASE M debian/changelog M gtp/Makefile.am 3 files changed, 31 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/26268/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 23c9b6d..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libgtp ADD gtp_ran_info_relay_req, gtp_set_cb_ran_info_relay_ind diff --git a/debian/changelog b/debian/changelog index 29f9d9c..0b73209 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,33 @@ +osmo-ggsn (1.8.0) unstable; urgency=medium + + [ Oliver Smith ] + * doc/examples/Makefile.am: add sgsnemu.conf + * doc/examples/osmo-ggsn-kernel-gtp.cfg: new file + * doc/manuals: describe GTP-U kernel module + * gitignore: add ggsn_vty_reference.xml + + [ Harald Welte ] + * Don't install osmo-ggsn-kernel-gtp.cfg to /etc/osmocom/ + * Don't install sgsnemu.conf to /etc/osmocom/ + * ggsn: Reject PDP CTX ACT for static IP addresses + * vty: Inform user that static IP addresses are not supported + + [ Pau Espin Pedrol ] + * gtp: Update teic_confirmed only on resp success + * gtp: Rework parsing logic of UpdatePdpCtxResponse + * ggsn: Improve logging on incoming DL data packets + * gtp: Improve logging of failing pdp ctx resolution from TEI/TID + * cosmetic: gtpie.c: Fix trailing whitespace + * gtp: constify pointer arg + * gtp: Support tx/rx RAN Information Relay message + * ggsn: Log tun fd write errors + * ggsn: Fix heap-use-after-free during Recovery without associated PDP + * cosmetic: configure.ac: Fix tabulation in line + * Introduce program gtp-echo-responder + * gtp_echo_responder: report invalid chars present in node-feautres cmdline arg as error + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:49:16 +0100 + osmo-ggsn (1.7.1) unstable; urgency=medium [ Harald Welte ] diff --git a/gtp/Makefile.am b/gtp/Makefile.am index 64f63b6..3047485 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -2,7 +2,7 @@ # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html # If major=current-age is increased, remember to update the dh_strip line in debian/rules! -LIBVERSION=7:0:1 +LIBVERSION=8:0:2 lib_LTLIBRARIES = libgtp.la -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I21502c6e0b804237fe9bd8f5579dbabd519d6d51 Gerrit-Change-Number: 26268 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:51:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 12:51:43 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... Patch Set 1: > Patch Set 1: > > What about libtalloc-dev in 'debian/control'? It contains no version info. As I said on the other patch, feel free to note those down and submit patches later. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:51:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:52:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:52:24 +0000 Subject: =?UTF-8?Q?Change_in_libosmocore=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E1=2E282-ab5e-dirty_=E2=86=92_1=2E6=2E0?= In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26264 ) Change subject: Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 Gerrit-Change-Number: 26264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:52:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:56:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:56:19 +0000 Subject: Change in osmo-pcap[master]: debian/control: minimum version for libzmq3-dev is 3.2.2 References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26269 ) Change subject: debian/control: minimum version for libzmq3-dev is 3.2.2 ...................................................................... debian/control: minimum version for libzmq3-dev is 3.2.2 We require this version in 'contrib/osmo-pcap.spec.in', and should here too. Change-Id: If76b4fcb8863ad5468a77113ad25142fe1145cda --- M debian/control 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/69/26269/1 diff --git a/debian/control b/debian/control index 68d38c7..0436530 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ pkg-config, libosmocore-dev (>= 1.5.0), libgnutls28-dev, - libzmq3-dev + libzmq3-dev (>= 3.2.2) Standards-Version: 3.9.1 Homepage: https://osmocom.org/projects/osmo-pcap Vcs-Git: git://git.osmocom.org/osmo-pcap.git -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If76b4fcb8863ad5468a77113ad25142fe1145cda Gerrit-Change-Number: 26269 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 12:56:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 12:56:36 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-30bc-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26267 ) Change subject: Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcap/+/26267/1/debian/control File debian/control: https://gerrit.osmocom.org/c/osmo-pcap/+/26267/1/debian/control at 12 PS1, Line 12: libzmq3-dev > Too much stuff to take care of already when doing the release to be side tracked by this missing inf [?] https://gerrit.osmocom.org/c/osmo-pcap/+/26269 debian/control: minimum version for libzmq3-dev is 3.2.2 [NEW] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb Gerrit-Change-Number: 26267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 12:56:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:02:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 13:02:22 +0000 Subject: Change in libosmocore[master]: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26270 ) Change subject: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 ...................................................................... debian/control: minimum version of libtalloc-dev must be >= 2.1.0 Change-Id: Id20871b76c4a5801defb4f534fad635b7f079a13 --- M debian/control 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/26270/1 diff --git a/debian/control b/debian/control index b319132..bc5e4f2 100644 --- a/debian/control +++ b/debian/control @@ -14,7 +14,7 @@ doxygen, libpcsclite-dev, pkg-config, - libtalloc-dev, + libtalloc-dev (>= 2.1.0), libsctp-dev, libusb-1.0-0-dev, libmnl-dev, @@ -319,7 +319,7 @@ Multi-Arch: same Section: libdevel Depends: libosmocore, - libtalloc-dev, + libtalloc-dev (>= 2.1.0), ${misc:Depends} Description: Development headers for Open Source MObile COMmunications CORE library The header files provided by this package may be used to develop -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id20871b76c4a5801defb4f534fad635b7f079a13 Gerrit-Change-Number: 26270 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:02:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 13:02:58 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > What about libtalloc-dev in 'debian/control'? > > It contains no version info. As I said on the other patch, feel free to note those down and submit patches later. https://gerrit.osmocom.org/c/libosmocore/+/26270 debian/control: minimum version of libtalloc-dev must be >= 2.1.0 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 13:02:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 16 13:04:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:04:00 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ac602aa0e_5b8b2ac6bd19e610143693@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/CentOS_8/aarch64 Package network:osmocom:nightly/libosmocore failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 11s] ### VM INTERACTION START ### [ 11s] Using UART console [ 11s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_39/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_39/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_39/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 20s] ### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: aarch64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] [ 7.862288] sysrq: Changing Loglevel [ 20s] [ 7.862535] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 20s] no label, UUID=df6af406-82dd-4451-ab49-366d8d8cc933 [ 20s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vda [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/libosmocore.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmocore.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 11.116305] sysrq: Power Off [ 23s] [ 11.119292] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] obs-arm-10 failed "build libosmocore.spec" at Tue Nov 16 13:03:49 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:04:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:04:51 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ac85398aa_5b8b2ac6bd19e6101446aa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/CentOS_8/aarch64 Package network:osmocom:nightly/osmocom-nightly failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 22s] ### VM INTERACTION START ### [ 22s] Using UART console [ 22s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_23/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_23/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_23/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 33s] ### VM INTERACTION END ### [ 33s] 2nd stage started in virtual machine [ 33s] machine type: aarch64 [ 33s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 33s] Increasing log level from now on... [ 33s] [ 10.518442] sysrq: Changing Loglevel [ 33s] [ 10.519209] sysrq: Loglevel set to 4 [ 33s] Enable sysrq operations [ 33s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 33s] no label, UUID=002f93f0-8e84-4350-a139-196fbbdfe4de [ 33s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 33s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 33s] swapon /dev/vda [ 34s] WARNING: udev not running, creating extra device nodes [ 34s] logging output to //.build.log... [ 34s] processing recipe /.build-srcdir/osmocom-nightly.spec ... [ 34s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmocom-nightly.spec build ... [ 34s] initializing rpm db... [ 34s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 34s] ### VM INTERACTION START ### [ 37s] [ 13.895752] sysrq: Power Off [ 37s] [ 13.897572] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] obs-arm-9 failed "build osmocom-nightly.spec" at Tue Nov 16 13:04:31 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:05:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:05:42 +0000 Subject: Build failure of network:osmocom:nightly/orcania in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193acbc98072_5b8b2ac6bd19e610146285@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/CentOS_8/aarch64 Package network:osmocom:nightly/orcania failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_37/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_37/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_37/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 31s] ### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: aarch64 [ 31s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 31s] Increasing log level from now on... [ 31s] [ 10.360748] sysrq: Changing Loglevel [ 31s] [ 10.361896] sysrq: Loglevel set to 4 [ 31s] Enable sysrq operations [ 31s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 31s] no label, UUID=06cda906-6c39-4807-9e76-b94e0d72f05b [ 31s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 31s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 31s] swapon /dev/vda [ 31s] WARNING: udev not running, creating extra device nodes [ 31s] logging output to //.build.log... [ 31s] processing recipe /.build-srcdir/orcania.spec ... [ 31s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/orcania.spec build ... [ 31s] initializing rpm db... [ 31s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 31s] ### VM INTERACTION START ### [ 34s] [ 13.708370] sysrq: Power Off [ 34s] [ 13.709435] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] obs-arm-9 failed "build orcania.spec" at Tue Nov 16 13:05:20 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:06:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:06:33 +0000 Subject: Build failure of network:osmocom:nightly/libdbi in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193acdc25c5d_5b8b2ac6bd19e61014733@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libdbi/CentOS_8/aarch64 Package network:osmocom:nightly/libdbi failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libdbi Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_32/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_32/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_32/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 31s] ### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: aarch64 [ 31s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 31s] Increasing log level from now on... [ 31s] [ 10.683446] sysrq: Changing Loglevel [ 31s] [ 10.684202] sysrq: Loglevel set to 4 [ 31s] Enable sysrq operations [ 31s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 31s] no label, UUID=dbbc0949-b324-4218-938d-670132dc180e [ 31s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 31s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 31s] swapon /dev/vda [ 32s] WARNING: udev not running, creating extra device nodes [ 32s] logging output to //.build.log... [ 32s] processing recipe /.build-srcdir/libdbi.spec ... [ 32s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libdbi.spec build ... [ 32s] initializing rpm db... [ 32s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 32s] ### VM INTERACTION START ### [ 35s] [ 14.072934] sysrq: Power Off [ 35s] [ 14.074421] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] obs-arm-9 failed "build libdbi.spec" at Tue Nov 16 13:06:05 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:06:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 13:06:46 +0000 Subject: =?UTF-8?Q?Change_in_osmo-ggsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E1=2E20-8cbd-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 ) Change subject: Bump version: 1.7.1.20-8cbd-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I21502c6e0b804237fe9bd8f5579dbabd519d6d51 Gerrit-Change-Number: 26268 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 13:06:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 16 13:11:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:11:05 +0000 Subject: Build failure of network:osmocom:nightly/libunwind in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae071c7c7_5b8b2ac6bd19e6101538bd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libunwind/CentOS_8/aarch64 Package network:osmocom:nightly/libunwind failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libunwind Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.789046] sysrq: Changing Loglevel [ 18s] [ 7.789276] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=1cf53b37-75c6-4711-9ec1-674fc6c71022 [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/libunwind.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libunwind.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 10.982055] sysrq: Power Off [ 21s] [ 11.000557] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-11 failed "build libunwind.spec" at Tue Nov 16 13:10:33 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:11:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:11:22 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae0d80a8a_5b8b2ac6bd19e61015473@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/CentOS_8/aarch64 Package network:osmocom:nightly/libasn1c failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 29s] ### VM INTERACTION END ### [ 29s] 2nd stage started in virtual machine [ 29s] machine type: aarch64 [ 29s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 29s] Increasing log level from now on... [ 29s] [ 10.224000] sysrq: Changing Loglevel [ 29s] [ 10.225053] sysrq: Loglevel set to 4 [ 29s] Enable sysrq operations [ 29s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 29s] no label, UUID=d68e969a-47c2-448f-8b0e-e0dd2f130265 [ 29s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 29s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 29s] swapon /dev/vda [ 30s] WARNING: udev not running, creating extra device nodes [ 30s] logging output to //.build.log... [ 30s] processing recipe /.build-srcdir/libasn1c.spec ... [ 30s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libasn1c.spec build ... [ 30s] initializing rpm db... [ 30s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 30s] ### VM INTERACTION START ### [ 33s] [ 13.594674] sysrq: Power Off [ 33s] [ 13.596660] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] obs-arm-9 failed "build libasn1c.spec" at Tue Nov 16 13:11:08 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:11:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:11:56 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae2810a3_5b8b2ac6bd19e6101562a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/CentOS_8/aarch64 Package network:osmocom:nightly/libosmo-netif failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 11s] ### VM INTERACTION START ### [ 11s] Using UART console [ 11s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_16/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_16/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_16/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 19s] ### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: aarch64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] [ 7.938660] sysrq: Changing Loglevel [ 19s] [ 7.938979] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=305d95ed-65de-44fc-990f-2734e1684b0a [ 19s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vda [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-netif.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-netif.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 11.154605] sysrq: Power Off [ 22s] [ 11.155132] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] obs-arm-10 failed "build libosmo-netif.spec" at Tue Nov 16 13:11:49 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:11:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:11:56 +0000 Subject: Build failure of network:osmocom:nightly/yder in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae2875dbe_5b8b2ac6bd19e610156314@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/yder/CentOS_8/aarch64 Package network:osmocom:nightly/yder failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly yder Last lines of build log: [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_29/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_29/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_29/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 31s] ### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: aarch64 [ 31s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 31s] Increasing log level from now on... [ 31s] [ 10.268991] sysrq: Changing Loglevel [ 31s] [ 10.269734] sysrq: Loglevel set to 4 [ 31s] Enable sysrq operations [ 31s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 31s] no label, UUID=421bcccf-8d06-47a2-a705-4f1b5589a96a [ 31s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 31s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 31s] swapon /dev/vda [ 31s] WARNING: udev not running, creating extra device nodes [ 31s] logging output to //.build.log... [ 31s] processing recipe /.build-srcdir/yder.spec ... [ 31s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/yder.spec build ... [ 31s] initializing rpm db... [ 31s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 31s] ### VM INTERACTION START ### [ 34s] [ 13.620783] sysrq: Power Off [ 34s] [ 13.621902] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] obs-arm-9 failed "build yder.spec" at Tue Nov 16 13:11:41 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:12:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:12:13 +0000 Subject: Build failure of network:osmocom:nightly/libsodium in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae446edd3_5b8b2ac6bd19e6101568c0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsodium/CentOS_8/aarch64 Package network:osmocom:nightly/libsodium failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libsodium Last lines of build log: [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_35/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_35/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_35/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 20s] ### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: aarch64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] [ 8.015750] sysrq: Changing Loglevel [ 20s] [ 8.016078] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 20s] no label, UUID=b8bbd4e1-de38-4046-ab24-a28b80900c0b [ 20s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vda [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/libsodium.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsodium.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 11.284002] sysrq: Power Off [ 23s] [ 11.284661] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] obs-arm-11 failed "build libsodium.spec" at Tue Nov 16 13:12:05 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:12:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:12:48 +0000 Subject: Build failure of network:osmocom:nightly/ortp in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae61916fd_5b8b2ac6bd19e6101577aa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ortp/CentOS_8/aarch64 Package network:osmocom:nightly/ortp failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly ortp Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_14/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_14/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_14/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.776216] sysrq: Changing Loglevel [ 18s] [ 7.776431] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=fe7ad1e9-b4b2-40e1-9fd1-43d87cc006c8 [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/ortp.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/ortp.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 22s] [ 10.992957] sysrq: Power Off [ 22s] [ 10.993559] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] obs-arm-10 failed "build ortp.spec" at Tue Nov 16 13:12:41 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:13:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:13:39 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae9cbdc06_5b8b2ac6bd19e610159528@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/CentOS_8/aarch64 Package network:osmocom:nightly/ulfius failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 11s] ### VM INTERACTION START ### [ 11s] Using UART console [ 11s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_17/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_17/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_17/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 19s] ### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: aarch64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] [ 7.949272] sysrq: Changing Loglevel [ 19s] [ 7.949556] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=c56e7d5d-9079-4162-bb5b-5e8d3018688f [ 20s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vda [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/ulfius.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/ulfius.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 11.203678] sysrq: Power Off [ 23s] [ 11.204201] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] obs-arm-10 failed "build ulfius.spec" at Tue Nov 16 13:13:36 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:13:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:13:56 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae9eb013e_5b8b2ac6bd19e6101601c3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/CentOS_8/aarch64 Package network:osmocom:nightly/libgtpnl failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_40/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_40/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_40/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 31s] ### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: aarch64 [ 31s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 31s] Increasing log level from now on... [ 31s] [ 10.642406] sysrq: Changing Loglevel [ 31s] [ 10.643179] sysrq: Loglevel set to 4 [ 31s] Enable sysrq operations [ 31s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 31s] no label, UUID=4aac9c8f-f444-423c-ba18-c06a156146b6 [ 31s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 31s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 31s] swapon /dev/vda [ 31s] WARNING: udev not running, creating extra device nodes [ 31s] logging output to //.build.log... [ 31s] processing recipe /.build-srcdir/libgtpnl.spec ... [ 31s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libgtpnl.spec build ... [ 32s] initializing rpm db... [ 32s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 32s] ### VM INTERACTION START ### [ 35s] [ 13.993689] sysrq: Power Off [ 35s] [ 13.994911] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] obs-arm-8 failed "build libgtpnl.spec" at Tue Nov 16 13:13:48 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:13:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:13:56 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193ae9f6e27a_5b8b2ac6bd19e610160411@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/CentOS_8/aarch64 Package network:osmocom:nightly/libosmo-sccp failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_23/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_23/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_23/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 32s] ### VM INTERACTION END ### [ 32s] 2nd stage started in virtual machine [ 33s] machine type: aarch64 [ 33s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 33s] Increasing log level from now on... [ 33s] [ 11.528123] sysrq: Changing Loglevel [ 33s] [ 11.528911] sysrq: Loglevel set to 4 [ 33s] Enable sysrq operations [ 33s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 33s] no label, UUID=835c698a-6857-4939-9060-d0378ef70409 [ 33s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 33s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 33s] swapon /dev/vda [ 33s] WARNING: udev not running, creating extra device nodes [ 33s] logging output to //.build.log... [ 33s] processing recipe /.build-srcdir/libosmo-sccp.spec ... [ 33s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-sccp.spec build ... [ 33s] initializing rpm db... [ 33s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 33s] ### VM INTERACTION START ### [ 36s] [ 14.991775] sysrq: Power Off [ 36s] [ 14.993133] reboot: Power down [ 36s] ### VM INTERACTION END ### [ 36s] [ 36s] obs-arm-8 failed "build libosmo-sccp.spec" at Tue Nov 16 13:13:43 UTC 2021. [ 36s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:14:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:14:47 +0000 Subject: Build failure of network:osmocom:nightly/libcsv in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193aed519e3c_5b8b2ac6bd19e6101629da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libcsv/CentOS_8/aarch64 Package network:osmocom:nightly/libcsv failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libcsv Last lines of build log: [ 21s] ### VM INTERACTION START ### [ 21s] Using UART console [ 21s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_17/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_17/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_17/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 33s] ### VM INTERACTION END ### [ 33s] 2nd stage started in virtual machine [ 34s] machine type: aarch64 [ 34s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 34s] Increasing log level from now on... [ 34s] [ 11.151720] sysrq: Changing Loglevel [ 34s] [ 11.152671] sysrq: Loglevel set to 4 [ 34s] Enable sysrq operations [ 34s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 34s] no label, UUID=55223a6d-1e20-4405-86ec-6ac7da0a882f [ 34s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 34s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 34s] swapon /dev/vda [ 34s] WARNING: udev not running, creating extra device nodes [ 34s] logging output to //.build.log... [ 34s] processing recipe /.build-srcdir/libcsv.spec ... [ 34s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libcsv.spec build ... [ 34s] initializing rpm db... [ 34s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 34s] ### VM INTERACTION START ### [ 37s] [ 14.588767] sysrq: Power Off [ 37s] [ 14.590511] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] obs-arm-8 failed "build libcsv.spec" at Tue Nov 16 13:14:42 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:15:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:15:21 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-abis in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193aef5156bd_5b8b2ac6bd19e610163486@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/CentOS_8/aarch64 Package network:osmocom:nightly/libosmo-abis failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_18/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_18/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_18/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 27s] ### VM INTERACTION END ### [ 27s] 2nd stage started in virtual machine [ 27s] machine type: aarch64 [ 27s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 27s] Increasing log level from now on... [ 27s] [ 7.793435] sysrq: Changing Loglevel [ 27s] [ 7.793829] sysrq: Loglevel set to 4 [ 27s] Enable sysrq operations [ 27s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 27s] no label, UUID=a9aabf98-52cb-449e-9c63-229696019a0d [ 27s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 27s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 27s] swapon /dev/vda [ 27s] WARNING: udev not running, creating extra device nodes [ 27s] logging output to //.build.log... [ 27s] processing recipe /.build-srcdir/libosmo-abis.spec ... [ 27s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-abis.spec build ... [ 27s] initializing rpm db... [ 27s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 27s] ### VM INTERACTION START ### [ 30s] [ 10.983644] sysrq: Power Off [ 30s] [ 10.984303] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] obs-arm-11 failed "build libosmo-abis.spec" at Tue Nov 16 13:15:10 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:16:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:16:12 +0000 Subject: Build failure of network:osmocom:nightly/fdupes in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193af312655d_5b8b2ac6bd19e6101645f1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/fdupes/CentOS_8/aarch64 Package network:osmocom:nightly/fdupes failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly fdupes Last lines of build log: [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 20s] ### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: aarch64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] [ 7.835835] sysrq: Changing Loglevel [ 20s] [ 7.836155] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 20s] no label, UUID=dfbda317-3b20-43f1-bc42-95de10e6e4fd [ 20s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vda [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/fdupes.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/fdupes.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 11.116483] sysrq: Power Off [ 23s] [ 11.117130] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] obs-arm-11 failed "build fdupes.spec" at Tue Nov 16 13:16:01 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:16:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:16:12 +0000 Subject: Build failure of network:osmocom:nightly/libdbi-drivers in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193af31892e4_5b8b2ac6bd19e6101646c5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libdbi-drivers/CentOS_8/aarch64 Package network:osmocom:nightly/libdbi-drivers failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libdbi-drivers Last lines of build log: [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_13/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_13/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_13/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 29s] ### VM INTERACTION END ### [ 29s] 2nd stage started in virtual machine [ 29s] machine type: aarch64 [ 29s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 29s] Increasing log level from now on... [ 29s] [ 10.246025] sysrq: Changing Loglevel [ 29s] [ 10.247307] sysrq: Loglevel set to 4 [ 29s] Enable sysrq operations [ 29s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 29s] no label, UUID=5dd225b4-1692-4d64-8d9a-6c845d55215b [ 29s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 29s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 29s] swapon /dev/vda [ 29s] WARNING: udev not running, creating extra device nodes [ 29s] logging output to //.build.log... [ 29s] processing recipe /.build-srcdir/libdbi-drivers.spec ... [ 29s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libdbi-drivers.spec build ... [ 29s] initializing rpm db... [ 29s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 29s] ### VM INTERACTION START ### [ 33s] [ 13.560207] sysrq: Power Off [ 33s] [ 13.561345] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] obs-arm-9 failed "build libdbi-drivers.spec" at Tue Nov 16 13:16:06 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:16:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:16:12 +0000 Subject: Build failure of network:osmocom:nightly/zeromq in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193af321886_5b8b2ac6bd19e610164867@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/zeromq/CentOS_8/aarch64 Package network:osmocom:nightly/zeromq failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly zeromq Last lines of build log: [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_16/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_16/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_16/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 30s] ### VM INTERACTION END ### [ 30s] 2nd stage started in virtual machine [ 30s] machine type: aarch64 [ 30s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 30s] Increasing log level from now on... [ 30s] [ 9.957303] sysrq: Changing Loglevel [ 30s] [ 9.958045] sysrq: Loglevel set to 4 [ 30s] Enable sysrq operations [ 30s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 30s] no label, UUID=fd693cbc-5eb4-47c5-b7f5-95ba5f1dced1 [ 30s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 30s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 30s] swapon /dev/vda [ 30s] WARNING: udev not running, creating extra device nodes [ 30s] logging output to //.build.log... [ 30s] processing recipe /.build-srcdir/zeromq.spec ... [ 30s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/zeromq.spec build ... [ 30s] initializing rpm db... [ 30s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 30s] ### VM INTERACTION START ### [ 34s] [ 13.337921] sysrq: Power Off [ 34s] [ 13.343889] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] obs-arm-9 failed "build zeromq.spec" at Tue Nov 16 13:16:10 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:16:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:16:29 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193af32d31e3_5b8b2ac6bd19e61016524@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/CentOS_8/aarch64 Package network:osmocom:nightly/libsmpp34 failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 17s] ### VM INTERACTION START ### [ 17s] Using UART console [ 17s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_32/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_32/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_32/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 28s] ### VM INTERACTION END ### [ 28s] 2nd stage started in virtual machine [ 28s] machine type: aarch64 [ 28s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 28s] Increasing log level from now on... [ 28s] [ 9.906652] sysrq: Changing Loglevel [ 28s] [ 9.907338] sysrq: Loglevel set to 4 [ 28s] Enable sysrq operations [ 28s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 28s] no label, UUID=dce8f190-f5a9-4866-90f3-5fa535922305 [ 28s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 28s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 28s] swapon /dev/vda [ 28s] WARNING: udev not running, creating extra device nodes [ 28s] logging output to //.build.log... [ 28s] processing recipe /.build-srcdir/libsmpp34.spec ... [ 28s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsmpp34.spec build ... [ 28s] initializing rpm db... [ 28s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 28s] ### VM INTERACTION START ### [ 31s] [ 13.244638] sysrq: Power Off [ 31s] [ 13.245779] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] obs-arm-9 failed "build libsmpp34.spec" at Tue Nov 16 13:16:24 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:16:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:16:29 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193af3341a53_5b8b2ac6bd19e61016539b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/CentOS_8/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.820720] sysrq: Changing Loglevel [ 18s] [ 7.820969] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=89d9a8c3-48b6-466a-b802-a1861ac47f41 [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/simtrace2.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/simtrace2.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 11.042047] sysrq: Power Off [ 21s] [ 11.043865] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-10 failed "build simtrace2.spec" at Tue Nov 16 13:16:14 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:17:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:17:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193af8d60de8_5b8b2ac6bd19e6101670ce@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-iuh failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_19/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_19/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_19/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 22s] ### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 23s] machine type: aarch64 [ 23s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 23s] Increasing log level from now on... [ 23s] [ 7.997062] sysrq: Changing Loglevel [ 23s] [ 7.997513] sysrq: Loglevel set to 4 [ 23s] Enable sysrq operations [ 23s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 23s] no label, UUID=be20b65c-1efe-4c71-b38c-0c612bcaeea8 [ 23s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 23s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 23s] swapon /dev/vda [ 23s] WARNING: udev not running, creating extra device nodes [ 23s] logging output to //.build.log... [ 23s] processing recipe /.build-srcdir/osmo-iuh.spec ... [ 23s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-iuh.spec build ... [ 23s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 11.229266] sysrq: Power Off [ 26s] [ 11.229917] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] obs-arm-11 failed "build osmo-iuh.spec" at Tue Nov 16 13:17:31 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:19:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 13:19:20 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-abis=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E1=2E14-57ff-dirty_=E2=86=92_1=2E2=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26271 ) Change subject: Bump version: 1.1.1.14-57ff-dirty ? 1.2.0 ...................................................................... Bump version: 1.1.1.14-57ff-dirty ? 1.2.0 Change-Id: I0536137e6221fd322536111dfda6e19d3c57de6c --- M TODO-RELEASE M configure.ac M contrib/libosmo-abis.spec.in M debian/changelog M debian/control M src/Makefile.am 6 files changed, 40 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/71/26271/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 8c417cd..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,6 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -update libosmocore dependency to > 1.5.1 for OSMO_SOCK_F_{DSCP,PRIO}() -libosmo-abis new member ipa_client_conn new struct members dscp, priority -libosmo-abis new member ipa_server_link new struct members dscp, priority diff --git a/configure.ac b/configure.ac index 0becff9..d183a05 100644 --- a/configure.ac +++ b/configure.ac @@ -66,10 +66,10 @@ dnl Generate the output AM_CONFIG_HEADER(config.h) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.6.0) PKG_CHECK_MODULES(ORTP, ortp >= 0.22.0) AC_ARG_ENABLE([dahdi], diff --git a/contrib/libosmo-abis.spec.in b/contrib/libosmo-abis.spec.in index 629db97..8add588 100644 --- a/contrib/libosmo-abis.spec.in +++ b/contrib/libosmo-abis.spec.in @@ -27,11 +27,11 @@ BuildRequires: libtool >= 2 BuildRequires: pkgconfig >= 0.20 BuildRequires: xz -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmocodec) >= 1.5.0 -BuildRequires: pkgconfig(ortp) >= 0.22 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmocodec) >= 1.6.0 +BuildRequires: pkgconfig(ortp) >= 0.22.0 BuildRequires: pkgconfig(talloc) %description @@ -59,8 +59,8 @@ License: AGPL-3.0-or-later Group: Development/Libraries/C and C++ Requires: libosmoabis10 = %version -Requires: libosmocore-devel >= 0.3.0 -Requires: libosmogsm-devel >= 0.3.10 +Requires: libosmocore-devel >= 1.6.0 +Requires: libosmogsm-devel >= 1.6.0 %description -n libosmoabis-devel This library contains common/shared code regarding the GSM A-bis diff --git a/debian/changelog b/debian/changelog index 0d69185..e889ba6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,29 @@ +libosmo-abis (1.2.0) unstable; urgency=medium + + [ Keith ] + * Configure E1 pcap file per line + * Log TRAU FSM at INFO not NOTICE + * Fix up vty 'show' commands for E1 line/timeslots + + [ Harald Welte ] + * ipa: Introduce support for user-specific DSCP and priority + * e1_input: Allow (vty) configuration of IP DSCP and socket priority + * trau: Introduce osmo_rtp_socket_set_priority() + + [ Philipp Maier ] + * ipaccess: do not block ipaccess_line_update on failure + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * osmo_ortp: Fix seqno reset to 0 upon ssrc_changed + * e1_input: Fix line not removed from e1inp_line_list when freed + * e1_input: Document e1inp_line_create() + * ipaccess: Allow reconfiguring the ipa line during line_update() + * ipaccess: e1inp_ipa_bts_rsl_connect: Fix memleak recreating ipa_client_conn + * e1inp_input: Fix e1inp_line_clone removing original line from global list when freed + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:18:45 +0100 + libosmo-abis (1.1.1) unstable; urgency=medium * attempt to fix RPM spec file after recent soversion bump diff --git a/debian/control b/debian/control index 4608ad6..3601b43 100644 --- a/debian/control +++ b/debian/control @@ -11,7 +11,7 @@ dh-autoreconf, libdpkg-perl, git, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), pkg-config, libortp-dev Standards-Version: 3.9.7 diff --git a/src/Makefile.am b/src/Makefile.am index 346e67b..96e38b1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,8 +1,8 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ABIS_LIBVERSION=10:0:0 -TRAU_LIBVERSION=6:0:4 +ABIS_LIBVERSION=11:0:1 +TRAU_LIBVERSION=7:0:5 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOE1D_CFLAGS) $(LIBOSMOCODEC_CFLAGS) $(COVERAGE_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0536137e6221fd322536111dfda6e19d3c57de6c Gerrit-Change-Number: 26271 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 16 13:19:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:19:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193afe283b0b_5b8b2ac6bd19e6101685bb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-pcu failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_15/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_15/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_15/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 33s] ### VM INTERACTION END ### [ 33s] 2nd stage started in virtual machine [ 33s] machine type: aarch64 [ 33s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 33s] Increasing log level from now on... [ 33s] [ 11.048357] sysrq: Changing Loglevel [ 33s] [ 11.049941] sysrq: Loglevel set to 4 [ 33s] Enable sysrq operations [ 33s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 33s] no label, UUID=e42bc7db-6bda-41c3-b77a-bd11b1dd5dd1 [ 33s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 33s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 33s] swapon /dev/vda [ 33s] WARNING: udev not running, creating extra device nodes [ 33s] logging output to //.build.log... [ 33s] processing recipe /.build-srcdir/osmo-pcu.spec ... [ 33s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-pcu.spec build ... [ 33s] initializing rpm db... [ 33s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 33s] ### VM INTERACTION START ### [ 36s] [ 14.489713] sysrq: Power Off [ 36s] [ 14.491391] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] obs-arm-8 failed "build osmo-pcu.spec" at Tue Nov 16 13:19:13 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:19:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:19:19 +0000 Subject: Build failure of network:osmocom:nightly/python-cheetah in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193afe2bb11d_5b8b2ac6bd19e6101686e4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/python-cheetah/CentOS_8/aarch64 Package network:osmocom:nightly/python-cheetah failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly python-cheetah Last lines of build log: [ 11s] ### VM INTERACTION START ### [ 11s] Using UART console [ 11s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_17/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_17/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_17/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 20s] ### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: aarch64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] [ 7.922224] sysrq: Changing Loglevel [ 20s] [ 7.922462] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 20s] no label, UUID=dfae5864-49af-4a06-9e9d-edd369640a40 [ 20s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vda [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/python-cheetah.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/python-cheetah.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 11.155496] sysrq: Power Off [ 23s] [ 11.156110] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] obs-arm-10 failed "build python-cheetah.spec" at Tue Nov 16 13:19:15 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:19:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:19:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193afe3499c9_5b8b2ac6bd19e610168846@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-ggsn failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_23/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_23/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_23/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 22s] ### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: aarch64 [ 22s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 22s] Increasing log level from now on... [ 22s] [ 8.023935] sysrq: Changing Loglevel [ 22s] [ 8.024374] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 22s] no label, UUID=05083a3d-9e49-4b64-ac00-49447c45fd7c [ 22s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 22s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 22s] swapon /dev/vda [ 22s] WARNING: udev not running, creating extra device nodes [ 22s] logging output to //.build.log... [ 22s] processing recipe /.build-srcdir/osmo-ggsn.spec ... [ 22s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-ggsn.spec build ... [ 22s] initializing rpm db... [ 22s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 22s] ### VM INTERACTION START ### [ 25s] [ 11.260865] sysrq: Power Off [ 25s] [ 11.261453] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] obs-arm-10 failed "build osmo-ggsn.spec" at Tue Nov 16 13:19:02 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:19:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:19:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193afe3d1d0e_5b8b2ac6bd19e61016904@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hlr failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 110s] ### VM INTERACTION START ### [ 110s] Using UART console [ 110s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 131s] ### VM INTERACTION END ### [ 131s] 2nd stage started in virtual machine [ 131s] machine type: aarch64 [ 131s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 131s] Increasing log level from now on... [ 131s] [ 19.018941] sysrq: Changing Loglevel [ 131s] [ 19.022483] sysrq: Loglevel set to 4 [ 131s] Enable sysrq operations [ 131s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 131s] no label, UUID=e50b2bcf-e82d-4ac0-948d-6901563555b1 [ 131s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 131s] swapon: /dev/vda: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 131s] swapon /dev/vda [ 131s] WARNING: udev not running, creating extra device nodes [ 132s] logging output to //.build.log... [ 132s] processing recipe /.build-srcdir/osmo-hlr.spec ... [ 132s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hlr.spec build ... [ 132s] initializing rpm db... [ 132s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 132s] ### VM INTERACTION START ### [ 135s] [ 22.994701] sysrq: Power Off [ 135s] [ 23.005277] reboot: Power down [ 135s] ### VM INTERACTION END ### [ 135s] [ 135s] obs-arm-1 failed "build osmo-hlr.spec" at Tue Nov 16 13:19:05 UTC 2021. [ 135s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:19:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:19:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193afe51b5a3_5b8b2ac6bd19e610169320@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-mgw failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_32/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_32/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_32/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 31s] ### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: aarch64 [ 31s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 31s] Increasing log level from now on... [ 31s] [ 10.123016] sysrq: Changing Loglevel [ 31s] [ 10.123758] sysrq: Loglevel set to 4 [ 31s] Enable sysrq operations [ 31s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 31s] no label, UUID=70cd1258-271c-4826-b9ea-aab15583b56a [ 31s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 31s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 31s] swapon /dev/vda [ 31s] WARNING: udev not running, creating extra device nodes [ 31s] logging output to //.build.log... [ 31s] processing recipe /.build-srcdir/osmo-mgw.spec ... [ 31s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-mgw.spec build ... [ 31s] initializing rpm db... [ 31s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 31s] ### VM INTERACTION START ### [ 34s] [ 13.577818] sysrq: Power Off [ 34s] [ 13.578968] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] obs-arm-9 failed "build osmo-mgw.spec" at Tue Nov 16 13:19:07 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:19:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:19:36 +0000 Subject: Build failure of network:osmocom:nightly/openpgm in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b0053898b_5b8b2ac6bd19e610169817@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openpgm/CentOS_8/aarch64 Package network:osmocom:nightly/openpgm failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly openpgm Last lines of build log: [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_19/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_19/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_19/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 21s] ### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: aarch64 [ 21s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] [ 8.111556] sysrq: Changing Loglevel [ 21s] [ 8.111897] sysrq: Loglevel set to 4 [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 21s] no label, UUID=9cfefad6-94f3-474d-8b9c-f064ebdcf94e [ 21s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 21s] swapon /dev/vda [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/openpgm.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/openpgm.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 11.327068] sysrq: Power Off [ 24s] [ 11.327781] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] obs-arm-10 failed "build openpgm.spec" at Tue Nov 16 13:19:24 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:19:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:19:53 +0000 Subject: Build failure of network:osmocom:nightly/sofia-sip in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b006c5e82_5b8b2ac6bd19e6101702ee@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/sofia-sip/CentOS_8/aarch64 Package network:osmocom:nightly/sofia-sip failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly sofia-sip Last lines of build log: [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_40/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_40/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_40/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 30s] ### VM INTERACTION END ### [ 30s] 2nd stage started in virtual machine [ 30s] machine type: aarch64 [ 30s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 30s] Increasing log level from now on... [ 30s] [ 9.856149] sysrq: Changing Loglevel [ 30s] [ 9.856873] sysrq: Loglevel set to 4 [ 30s] Enable sysrq operations [ 30s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 30s] no label, UUID=bab51358-cfcf-4b67-93a3-aa713968fd91 [ 30s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 30s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 30s] swapon /dev/vda [ 30s] WARNING: udev not running, creating extra device nodes [ 30s] logging output to //.build.log... [ 30s] processing recipe /.build-srcdir/sofia-sip.spec ... [ 30s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/sofia-sip.spec build ... [ 30s] initializing rpm db... [ 30s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 30s] ### VM INTERACTION START ### [ 33s] [ 13.174395] sysrq: Power Off [ 33s] [ 13.175535] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] obs-arm-9 failed "build sofia-sip.spec" at Tue Nov 16 13:19:36 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:18 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b061d2ce1_5b8b2ac6bd19e6101716e4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/CentOS_8/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.27-defa[ 4.487095] sysrq: Changing Loglevel [ 13s] ult #1 SMP Tue O[ 4.488099] sysrq: Loglevel set to 4 [ 13s] ct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=6db21c8f-e675-456f-a383-393bdb3e8005 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/osmocom-nightly.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmocom-nightly.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.598161] sysrq: Power Off [ 16s] [ 7.601996] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat09 failed "build osmocom-nightly.spec" at Tue Nov 16 13:21:16 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b062c3d1_5b8b2ac6bd19e6101717e3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-cbc failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 13s] ### VM INTERACTION START ### [ 13s] Using UART console [ 13s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_30/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_30/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_30/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 22s] ### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: aarch64 [ 22s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 22s] Increasing log level from now on... [ 22s] [ 8.260091] sysrq: Changing Loglevel [ 22s] [ 8.260329] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 22s] no label, UUID=951d0102-a0c7-4e46-b4d1-c31b7c4034a7 [ 22s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 22s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 22s] swapon /dev/vda [ 22s] WARNING: udev not running, creating extra device nodes [ 22s] logging output to //.build.log... [ 22s] processing recipe /.build-srcdir/osmo-cbc.spec ... [ 23s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-cbc.spec build ... [ 23s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 11.507713] sysrq: Power Off [ 26s] [ 11.521990] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] obs-arm-10 failed "build osmo-cbc.spec" at Tue Nov 16 13:21:07 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b07db662b_5b8b2ac6bd19e6101721fc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/CentOS_8/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 5.407751] sysrq: Changing Loglevel [ 18s] [ 5.408786] sysrq: Loglevel set to 4 [ 18s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=99c85d11-9050-4d81-8c3d-ec885737af27 [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/libgtpnl.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libgtpnl.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.570634] sysrq: Power Off [ 21s] [ 8.573114] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] old-atreju4 failed "build libgtpnl.spec" at Tue Nov 16 13:21:28 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/libsmpp34 in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b07df0334_5b8b2ac6bd19e6101722c7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsmpp34/CentOS_8/x86_64 Package network:osmocom:latest/libsmpp34 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libsmpp34 Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 4.901350] sysrq: Changing Loglevel [ 18s] [ 4.901997] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=669bd515-6ede-4253-aa13-a380da5f6547 [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/libsmpp34.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsmpp34.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.082411] sysrq: Power Off [ 21s] [ 8.085731] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] old-atreju5 failed "build libsmpp34.spec" at Tue Nov 16 13:21:28 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/osmocom-latest in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b07e3695d_5b8b2ac6bd19e61017235c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmocom-latest/CentOS_8/x86_64 Package network:osmocom:latest/osmocom-latest failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmocom-latest Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.913687] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.915350] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=4a0869a1-c16c-4c10-a9a8-5c1a9f259066 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/osmocom-latest.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmocom-latest.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 9.142327] sysrq: Power Off [ 23s] [ 9.151923] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb16 failed "build osmocom-latest.spec" at Tue Nov 16 13:21:29 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/ortp in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b07e882dc_5b8b2ac6bd19e6101725f8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ortp/CentOS_8/x86_64 Package network:osmocom:nightly/ortp failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ortp Last lines of build log: [ 11s] Using UART console [ 11s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 11s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 16s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 16s] 2nd stage started in virtual machine [ 16s] machine type: x86_64 [ 16s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 16s] Increasing log level from now on... [ 16s] [ 5.015829] sysrq: Changing Loglevel [ 16s] [ 5.016907] sysrq: Loglevel set to 4 [ 16s] Enable sysrq operations [ 16s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 16s] no label, UUID=a9beb437-526c-4f08-a491-3b40b9cda093 [ 16s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 16s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 16s] swapon /dev/vdb [ 16s] WARNING: udev not running, creating extra device nodes [ 16s] logging output to //.build.log... [ 16s] processing recipe /.build-srcdir/ortp.spec ... [ 16s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/ortp.spec build ... [ 16s] initializing rpm db... [ 16s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 16s] ### VM INTERACTION START ### [ 19s] [ 8.200560] sysrq: Power Off [ 19s] [ 8.205267] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] sheep87 failed "build ortp.spec" at Tue Nov 16 13:21:29 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b07ede70c_5b8b2ac6bd19e61017278c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/CentOS_8/x86_64 Package network:osmocom:nightly/libosmocore failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5[ 4.984141] sysrq: Changing Loglevel [ 17s] .3.18-59.27-defa[ 4.985500] sysrq: Loglevel set to 4 [ 17s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 17s] no label, UUID=18ee80ec-0364-442c-96eb-961b48dc43d3 [ 17s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 17s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 17s] swapon /dev/vdb [ 17s] WARNING: udev not running, creating extra device nodes [ 17s] logging output to //.build.log... [ 17s] processing recipe /.build-srcdir/libosmocore.spec ... [ 17s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmocore.spec build ... [ 17s] initializing rpm db... [ 17s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.191817] sysrq: Power Off [ 20s] [ 8.196096] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] sheep86 failed "build libosmocore.spec" at Tue Nov 16 13:21:29 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/python-cheetah in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b07f57fbd_5b8b2ac6bd19e61017296b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/python-cheetah/CentOS_8/x86_64 Package network:osmocom:latest/python-cheetah failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest python-cheetah Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.224756] sysrq: Changing Loglevel [ 19s] [ 5.225763] sysrq: Loglevel set to 4 [ 19s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=f2a8f78b-7bdb-4b9a-8380-1e33facce4bc [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/python-cheetah.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/python-cheetah.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.387851] sysrq: Power Off [ 22s] [ 8.390341] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] old-atreju2 failed "build python-cheetah.spec" at Tue Nov 16 13:21:30 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b07f8984d_5b8b2ac6bd19e610173036@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-smlc failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_13/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_13/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_13/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 26s] ### VM INTERACTION END ### [ 26s] 2nd stage started in virtual machine [ 26s] machine type: aarch64 [ 26s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 26s] Increasing log level from now on... [ 26s] [ 7.971171] sysrq: Changing Loglevel [ 26s] [ 7.971467] sysrq: Loglevel set to 4 [ 26s] Enable sysrq operations [ 26s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 26s] no label, UUID=fad49a41-4adc-48ac-a73e-a6354a1e149a [ 26s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 26s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 26s] swapon /dev/vda [ 26s] WARNING: udev not running, creating extra device nodes [ 26s] logging output to //.build.log... [ 26s] processing recipe /.build-srcdir/osmo-smlc.spec ... [ 26s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-smlc.spec build ... [ 26s] initializing rpm db... [ 26s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 26s] ### VM INTERACTION START ### [ 29s] [ 11.182722] sysrq: Power Off [ 29s] [ 11.186353] reboot: Power down [ 29s] ### VM INTERACTION END ### [ 29s] [ 29s] obs-arm-11 failed "build osmo-smlc.spec" at Tue Nov 16 13:21:30 UTC 2021. [ 29s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b07fb8fef_5b8b2ac6bd19e610173146@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-gbproxy failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_34/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_34/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_34/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 27s] ### VM INTERACTION END ### [ 27s] 2nd stage started in virtual machine [ 27s] machine type: aarch64 [ 27s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 27s] Increasing log level from now on... [ 27s] [ 8.045052] sysrq: Changing Loglevel [ 27s] [ 8.045348] sysrq: Loglevel set to 4 [ 27s] Enable sysrq operations [ 27s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 27s] no label, UUID=a0484e7e-f240-4439-b0e5-2ad1b22b97d3 [ 27s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 27s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 27s] swapon /dev/vda [ 27s] WARNING: udev not running, creating extra device nodes [ 27s] logging output to //.build.log... [ 27s] processing recipe /.build-srcdir/osmo-gbproxy.spec ... [ 27s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-gbproxy.spec build ... [ 27s] initializing rpm db... [ 27s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 27s] ### VM INTERACTION START ### [ 30s] [ 11.296606] sysrq: Power Off [ 30s] [ 11.297139] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] obs-arm-11 failed "build osmo-gbproxy.spec" at Tue Nov 16 13:21:30 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/orcania in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0801bd2d_5b8b2ac6bd19e61017338e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/CentOS_8/x86_64 Package network:osmocom:nightly/orcania failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM... [ 20s] c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] [ 5.481574] sysrq: Changing Loglevel [ 20s] Linux version: 5[ 5.482955] sysrq: Loglevel set to 4 [ 20s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=a86f4836-93a2-40f8-9776-b00a0d7399ee [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/orcania.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/orcania.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.688715] sysrq: Power Off [ 23s] [ 8.692894] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb52 failed "build orcania.spec" at Tue Nov 16 13:21:31 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/orcania in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0804b204_5b8b2ac6bd19e610173490@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/CentOS_8/x86_64 Package network:osmocom:latest/orcania failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.964270] sysrq: Changing Loglevel [ 20s] .3.18-59.27-defa[ 5.966473] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=0c431e35-af9a-40f3-a265-ffe467d256da [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/orcania.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/orcania.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 24s] [ 9.174448] sysrq: Power Off [ 24s] [ 9.180212] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb14 failed "build orcania.spec" at Tue Nov 16 13:21:31 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/ortp in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b080c5c2a_5b8b2ac6bd19e61017369@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ortp/CentOS_8/x86_64 Package network:osmocom:latest/ortp failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ortp Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] [ 4.487815] sysrq: Changing Loglevel [ 13s] [ 4.488293] sysrq: Loglevel set to 4 [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=e0df38c5-4a8a-475d-8b30-149c82cdcc16 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/ortp.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/ortp.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.614841] sysrq: Power Off [ 16s] [ 7.618734] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat19 failed "build ortp.spec" at Tue Nov 16 13:21:17 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/libdbi in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b080ea21e_5b8b2ac6bd19e610173726@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libdbi/CentOS_8/x86_64 Package network:osmocom:nightly/libdbi failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libdbi Last lines of build log: [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5.3.18-59.27-defa[ 4.423139] sysrq: Changing Loglevel [ 12s] ult #1 SMP Tue O[ 4.424020] sysrq: Loglevel set to 4 [ 12s] ct 5 10:00:40 UTC 2021 (7df2404) [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 12s] no label, UUID=41800773-a812-42ac-9f72-514f28937e86 [ 12s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 12s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 12s] swapon /dev/vdb [ 12s] WARNING: udev not running, creating extra device nodes [ 12s] logging output to //.build.log... [ 12s] processing recipe /.build-srcdir/libdbi.spec ... [ 12s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libdbi.spec build ... [ 12s] initializing rpm db... [ 12s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.560533] sysrq: Power Off [ 15s] [ 7.564552] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat17 failed "build libdbi.spec" at Tue Nov 16 13:21:17 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/libgtpnl in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0814fe6f_5b8b2ac6bd19e6101739eb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libgtpnl/CentOS_8/x86_64 Package network:osmocom:latest/libgtpnl failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libgtpnl Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_16/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_16/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_16/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UT[ 5.682920] sysrq: Changing Loglevel [ 19s] C 2021 (7df2404)[ 5.684159] sysrq: Loglevel set to 4 [ 19s] [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=62732016-7f6f-48b0-82ff-8a91148c8060 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libgtpnl.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libgtpnl.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.902805] sysrq: Power Off [ 22s] [ 8.909300] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb04 failed "build libgtpnl.spec" at Tue Nov 16 13:21:32 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/libdbi in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b081ca93b_5b8b2ac6bd19e61017412@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libdbi/CentOS_8/x86_64 Package network:osmocom:latest/libdbi failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libdbi Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.441982] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 4.443009] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=56dca320-edf7-45ab-bec1-8aebcc2e1022 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/libdbi.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libdbi.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.570893] sysrq: Power Off [ 16s] [ 7.574445] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat05 failed "build libdbi.spec" at Tue Nov 16 13:21:19 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/fdupes in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b08250afe_5b8b2ac6bd19e610174346@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/fdupes/CentOS_8/x86_64 Package network:osmocom:nightly/fdupes failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly fdupes Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_13/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_13/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_13/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] [ 5.725856] sysrq: Changing Loglevel [ 19s] [ 5.727158] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=9906f1f4-d0a1-4da5-a855-524671e7dd23 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/fdupes.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/fdupes.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.930661] sysrq: Power Off [ 22s] [ 8.936862] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb03 failed "build fdupes.spec" at Tue Nov 16 13:21:32 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/libunwind in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b08221fa4_5b8b2ac6bd19e610174269@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libunwind/CentOS_8/x86_64 Package network:osmocom:nightly/libunwind failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libunwind Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.469603] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 4.470177] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=a53f3f3a-9123-447f-a69e-f97e45bb4019 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/libunwind.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libunwind.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.590160] sysrq: Power Off [ 16s] [ 7.593150] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat11 failed "build libunwind.spec" at Tue Nov 16 13:21:20 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:latest/openpgm in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b08288681_5b8b2ac6bd19e610174494@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openpgm/CentOS_8/x86_64 Package network:osmocom:latest/openpgm failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openpgm Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.416195] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 4.417176] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=b970b33a-6bb1-40b1-a238-8adc79afaf58 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/openpgm.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/openpgm.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.533764] sysrq: Power Off [ 16s] [ 7.537108] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat07 failed "build openpgm.spec" at Tue Nov 16 13:21:20 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:35 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b082ee016_5b8b2ac6bd19e610174658@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/CentOS_8/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.463303] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 4.463898] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=6d2d8205-38ee-43c4-80aa-a038f2bcfd38 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/libsmpp34.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsmpp34.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.585567] sysrq: Power Off [ 16s] [ 7.589510] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat19 failed "build libsmpp34.spec" at Tue Nov 16 13:21:21 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:latest/fdupes in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0833bb0d_5b8b2ac6bd19e6101747d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/fdupes/CentOS_8/x86_64 Package network:osmocom:latest/fdupes failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest fdupes Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.648398] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.650069] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=ab7387f9-b3e3-4eba-9c24-48bea4a42ed3 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/fdupes.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/fdupes.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.912713] sysrq: Power Off [ 22s] [ 8.918716] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb23 failed "build fdupes.spec" at Tue Nov 16 13:21:34 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:latest/libunwind in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0836edb6_5b8b2ac6bd19e610174828@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libunwind/CentOS_8/x86_64 Package network:osmocom:latest/libunwind failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libunwind Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.710657] sysrq: Changing Loglevel [ 20s] .3.18-59.27-default #1 SMP Tue O[ 5.713051] sysrq: Loglevel set to 4 [ 20s] ct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=54934144-12e7-4828-9962-9877dbb85051 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/libunwind.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libunwind.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.923132] sysrq: Power Off [ 23s] [ 8.932551] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb54 failed "build libunwind.spec" at Tue Nov 16 13:21:35 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:latest/libosmocore in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0839d372_5b8b2ac6bd19e610174950@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/CentOS_8/x86_64 Package network:osmocom:latest/libosmocore failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 23s] Increasing log level from now on... [ 23s] [ 6.115009] sysrq: Changing Loglevel [ 23s] [ 6.116582] sysrq: Loglevel set to 4 [ 23s] Enable sysrq operations [ 23s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 23s] no label, UUID=38b892a6-0562-4756-ae5d-8d50cd5f7b26 [ 23s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 23s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 23s] swapon /dev/vdb [ 23s] WARNING: udev not running, creating extra device nodes [ 23s] logging output to //.build.log... [ 23s] processing recipe /.build-srcdir/libosmocore.spec ... [ 23s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmocore.spec build ... [ 23s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 9.347574] sysrq: Power Off [ 26s] [ 9.366099] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 27s] [ 27s] cloud111 failed "build libosmocore.spec" at Tue Nov 16 13:21:36 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:nightly/openpgm in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b083cbf2e_5b8b2ac6bd19e61017504b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openpgm/CentOS_8/x86_64 Package network:osmocom:nightly/openpgm failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openpgm Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.603977] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.605588] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=a7b2dd2d-ab55-4902-8398-316f7695d35d [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/openpgm.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/openpgm.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.803534] sysrq: Power Off [ 22s] [ 8.807432] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb59 failed "build openpgm.spec" at Tue Nov 16 13:21:36 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:latest/libsodium in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0841d297_5b8b2ac6bd19e61017516a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsodium/CentOS_8/x86_64 Package network:osmocom:latest/libsodium failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libsodium Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] [ 5.297202] sysrq: Changing Loglevel [ 20s] Linux version: 5[ 5.298622] sysrq: Loglevel set to 4 [ 20s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=84e0f0b9-bf66-42c3-954c-69afee53bc12 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/libsodium.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsodium.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.491918] sysrq: Power Off [ 23s] [ 8.499251] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb27 failed "build libsodium.spec" at Tue Nov 16 13:21:36 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:nightly/libsodium in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0844811f_5b8b2ac6bd19e610175229@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsodium/CentOS_8/x86_64 Package network:osmocom:nightly/libsodium failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsodium Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5[ 6.289074] sysrq: Changing Loglevel [ 21s] .3.18-59.27-defa[ 6.290004] sysrq: Loglevel set to 4 [ 21s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=4cba4f06-a756-406d-88b1-cd23a26ea509 [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/libsodium.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsodium.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 9.507856] sysrq: Power Off [ 24s] [ 9.512469] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb28 failed "build libsodium.spec" at Tue Nov 16 13:21:37 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:latest/libcsv in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b084b504c_5b8b2ac6bd19e6101754fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libcsv/CentOS_8/x86_64 Package network:osmocom:latest/libcsv failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libcsv Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.742683] sysrq: Changing Loglevel [ 20s] .3.18-59.27-defa[ 5.744449] sysrq: Loglevel set to 4 [ 20s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=5fc8f5aa-c059-4886-a6ef-8667091bc4a3 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/libcsv.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libcsv.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.950868] sysrq: Power Off [ 23s] [ 8.960696] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb21 failed "build libcsv.spec" at Tue Nov 16 13:21:38 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:21:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:21:52 +0000 Subject: Build failure of network:osmocom:nightly/python-cheetah in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0854bc35_5b8b2ac6bd19e610175636@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/python-cheetah/CentOS_8/x86_64 Package network:osmocom:nightly/python-cheetah failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly python-cheetah Last lines of build log: [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5[ 7.604763] sysrq: Changing Loglevel [ 24s] .3.18-59.27-defa[ 7.606081] sysrq: Loglevel set to 4 [ 24s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 24s] no label, UUID=8dd40492-391e-484b-b814-4bf2c80861d9 [ 24s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 24s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 24s] swapon /dev/vdb [ 24s] WARNING: udev not running, creating extra device nodes [ 24s] logging output to //.build.log... [ 24s] processing recipe /.build-srcdir/python-cheetah.spec ... [ 24s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/python-cheetah.spec build ... [ 24s] initializing rpm db... [ 24s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 24s] ### VM INTERACTION START ### [ 27s] [ 10.900649] sysrq: Power Off [ 27s] [ 10.924002] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] lamb18 failed "build python-cheetah.spec" at Tue Nov 16 13:21:41 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:09 +0000 Subject: Build failure of network:osmocom:nightly/libcsv in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09aee0c6_5b8b2ac6bd19e610176069@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libcsv/CentOS_8/x86_64 Package network:osmocom:nightly/libcsv failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libcsv Last lines of build log: [ 32s] Using UART console [ 32s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 33s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 42s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 42s] 2nd stage started in virtual machine [ 42s] machine type: x86_64 [ 42s] Linux version: 5[ 9.180608] sysrq: Changing Loglevel [ 42s] .3.18-59.27-defa[ 9.181684] sysrq: Loglevel set to 4 [ 42s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 42s] Increasing log level from now on... [ 42s] Enable sysrq operations [ 42s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 42s] no label, UUID=ff18c032-5823-46b3-bfc2-d6d151687470 [ 42s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 42s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 42s] swapon /dev/vdb [ 42s] WARNING: udev not running, creating extra device nodes [ 42s] logging output to //.build.log... [ 42s] processing recipe /.build-srcdir/libcsv.spec ... [ 43s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libcsv.spec build ... [ 43s] initializing rpm db... [ 43s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 43s] ### VM INTERACTION START ### [ 46s] [ 12.685841] sysrq: Power Off [ 46s] [ 12.708779] reboot: Power down [ 46s] ### VM INTERACTION END ### [ 46s] [ 46s] lamb02 failed "build libcsv.spec" at Tue Nov 16 13:21:58 UTC 2021. [ 46s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b09b36073_5b8b2ac6bd19e610176188@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 12s] ### VM INTERACTION START ### [ 12s] Using UART console [ 12s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 20s] ### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: aarch64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] [ 7.831472] sysrq: Changing Loglevel [ 20s] [ 7.831769] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 20s] no label, UUID=37468d85-662f-4c0a-ad93-12bdbbd95aa9 [ 20s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vda [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/osmo-hnodeb.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hnodeb.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 11.067563] sysrq: Power Off [ 23s] [ 11.068104] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] obs-arm-11 failed "build osmo-hnodeb.spec" at Tue Nov 16 13:21:58 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:09 +0000 Subject: Build failure of network:osmocom:latest/libdbi-drivers in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09c16144_5b8b2ac6bd19e61017641c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libdbi-drivers/CentOS_8/x86_64 Package network:osmocom:latest/libdbi-drivers failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libdbi-drivers Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] [ 4.493276] sysrq: Changing Loglevel [ 13s] Linux version: 5[ 4.493678] sysrq: Loglevel set to 4 [ 13s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=87b798a5-1e43-427b-b8c7-cc94ac39e34e [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/libdbi-drivers.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libdbi-drivers.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.604214] sysrq: Power Off [ 16s] [ 7.607509] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat03 failed "build libdbi-drivers.spec" at Tue Nov 16 13:22:03 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b09abf0e6_5b8b2ac6bd19e61017592f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-remsim failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 22s] ### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: aarch64 [ 22s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 22s] Increasing log level from now on... [ 22s] [ 8.043558] sysrq: Changing Loglevel [ 22s] [ 8.043856] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 22s] no label, UUID=d03e5f27-ad2b-40f6-9584-f1417f68bc86 [ 22s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 22s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 22s] swapon /dev/vda [ 22s] WARNING: udev not running, creating extra device nodes [ 22s] logging output to //.build.log... [ 22s] processing recipe /.build-srcdir/osmo-remsim.spec ... [ 22s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-remsim.spec build ... [ 22s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 11.270487] sysrq: Power Off [ 26s] [ 11.289793] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] obs-arm-11 failed "build osmo-remsim.spec" at Tue Nov 16 13:21:58 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:09 +0000 Subject: Build failure of network:osmocom:nightly/libdbi-drivers in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09b6ca56_5b8b2ac6bd19e6101762ef@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libdbi-drivers/CentOS_8/x86_64 Package network:osmocom:nightly/libdbi-drivers failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libdbi-drivers Last lines of build log: [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5.3.18-59.27-defa[ 4.492796] sysrq: Changing Loglevel [ 14s] ult #1 SMP Tue O[ 4.493507] sysrq: Loglevel set to 4 [ 14s] ct 5 10:00:40 UTC 2021 (7df2404) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 14s] no label, UUID=7d18214b-fc80-403a-a152-b2a7dba28b38 [ 14s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 14s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 14s] swapon /dev/vdb [ 14s] WARNING: udev not running, creating extra device nodes [ 14s] logging output to //.build.log... [ 14s] processing recipe /.build-srcdir/libdbi-drivers.spec ... [ 14s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libdbi-drivers.spec build ... [ 14s] initializing rpm db... [ 14s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.615268] sysrq: Power Off [ 17s] [ 7.619481] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat17 failed "build libdbi-drivers.spec" at Tue Nov 16 13:21:58 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:latest/yder in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09ce3ede_5b8b2ac6bd19e61017674f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/yder/CentOS_8/x86_64 Package network:osmocom:latest/yder failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest yder Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.525896] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.527755] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=3d4d1ac8-95d1-4c11-82d1-ec49e0816199 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/yder.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/yder.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.733703] sysrq: Power Off [ 22s] [ 8.741176] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb08 failed "build yder.spec" at Tue Nov 16 13:22:24 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:latest/libasn1c in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09d3a3b5_5b8b2ac6bd19e6101768af@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/CentOS_8/x86_64 Package network:osmocom:latest/libasn1c failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libasn1c Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 19s] [ 5.359059] sysrq: Changing Loglevel [ 19s] [ 5.360038] sysrq: Loglevel set to 4 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=bf88389e-86de-4e13-89e5-2db5fccd1f44 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libasn1c.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libasn1c.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.573960] sysrq: Power Off [ 22s] [ 8.580228] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb20 failed "build libasn1c.spec" at Tue Nov 16 13:22:25 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09d9c431_5b8b2ac6bd19e6101770c6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/CentOS_8/x86_64 Package network:osmocom:nightly/libasn1c failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.469153] sysrq: Changing Loglevel [ 14s] .3.18-59.27-defa[ 4.470160] sysrq: Loglevel set to 4 [ 14s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 14s] no label, UUID=ba2eb911-893e-4321-8f8c-edc8d40a0ab6 [ 14s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 14s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 14s] swapon /dev/vdb [ 14s] WARNING: udev not running, creating extra device nodes [ 14s] logging output to //.build.log... [ 14s] processing recipe /.build-srcdir/libasn1c.spec ... [ 14s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libasn1c.spec build ... [ 14s] initializing rpm db... [ 14s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.607481] sysrq: Power Off [ 17s] [ 7.610791] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat11 failed "build libasn1c.spec" at Tue Nov 16 13:22:11 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:latest/sofia-sip in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09e33e4d_5b8b2ac6bd19e610177242@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/sofia-sip/CentOS_8/x86_64 Package network:osmocom:latest/sofia-sip failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest sofia-sip Last lines of build log: [ 7s] Using UART console [ 7s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 5.3.18-59.27-defa[ 4.449200] sysrq: Changing Loglevel [ 12s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404)[ 4.450454] sysrq: Loglevel set to 4 [ 12s] [ 12s] Increasing log level from now on... [ 12s] Enable sysrq operations [ 12s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 12s] no label, UUID=9732e22a-7ca9-44fc-ac03-744e19341433 [ 12s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 12s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 12s] swapon /dev/vdb [ 12s] WARNING: udev not running, creating extra device nodes [ 12s] logging output to //.build.log... [ 12s] processing recipe /.build-srcdir/sofia-sip.spec ... [ 12s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/sofia-sip.spec build ... [ 12s] initializing rpm db... [ 12s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.577773] sysrq: Power Off [ 15s] [ 7.580514] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] goat07 failed "build sofia-sip.spec" at Tue Nov 16 13:22:13 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09f47046_5b8b2ac6bd19e6101776f5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 5.208133] sysrq: Changing Loglevel [ 18s] [ 5.209129] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=be4d4054-302d-4ad2-b744-ad2759c7fd46 [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/osmo-ggsn.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-ggsn.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.375300] sysrq: Power Off [ 21s] [ 8.377587] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] old-atreju2 failed "build osmo-ggsn.spec" at Tue Nov 16 13:22:18 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09f938e2_5b8b2ac6bd19e6101777e7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/CentOS_8/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.026845] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.027802] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=7d1c7efb-8043-4230-8d44-bf86db80afdf [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-netif.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-netif.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.257621] sysrq: Power Off [ 22s] [ 8.261643] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] old-cirrus3 failed "build libosmo-netif.spec" at Tue Nov 16 13:22:19 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09fc0820_5b8b2ac6bd19e61017785d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.27-defa[ 5.071831] sysrq: Changing Loglevel [ 19s] ult #1 SMP Tue O[ 5.073631] sysrq: Loglevel set to 4 [ 19s] ct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 20s] no label, UUID=19c71c6b-9570-48e8-a3ef-04b0b23c8705 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/osmo-pcu.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-pcu.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.302846] sysrq: Power Off [ 23s] [ 8.308619] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] old-cirrus1 failed "build osmo-pcu.spec" at Tue Nov 16 13:22:21 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b09feb8aa_5b8b2ac6bd19e610177968@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/CentOS_8/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 11s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 16s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 16s] 2nd stage started in virtual machine [ 16s] machine type: x86_64 [ 16s] Linux version: 5.3.18-59.27-defa[ 5.440879] sysrq: Changing Loglevel [ 16s] ult #1 SMP Tue O[ 5.441606] sysrq: Loglevel set to 4 [ 16s] ct 5 10:00:40 UTC 2021 (7df2404) [ 16s] Increasing log level from now on... [ 16s] Enable sysrq operations [ 16s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 16s] no label, UUID=d2bab520-d551-4f4a-8b04-03bf0403bd53 [ 17s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 17s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 17s] swapon /dev/vdb [ 17s] WARNING: udev not running, creating extra device nodes [ 17s] logging output to //.build.log... [ 17s] processing recipe /.build-srcdir/osmo-gbproxy.spec ... [ 17s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-gbproxy.spec build ... [ 17s] initializing rpm db... [ 17s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.575887] sysrq: Power Off [ 20s] [ 8.581258] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] hci-cnode1-m0 failed "build osmo-gbproxy.spec" at Tue Nov 16 13:22:21 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-abis in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0a0ac0f8_5b8b2ac6bd19e610178387@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/CentOS_8/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.596117] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.598566] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=d4535f7a-f7f5-461d-8ef7-d8935c7f6ff7 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-abis.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-abis.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.812317] sysrq: Power Off [ 22s] [ 8.818195] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb04 failed "build libosmo-abis.spec" at Tue Nov 16 13:22:21 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:26 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0a1a9a9_5b8b2ac6bd19e6101784f2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/CentOS_8/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.442705] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.445230] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=0c1b27b7-dbbb-4627-a7eb-13e4014aa457 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/simtrace2.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/simtrace2.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.656301] sysrq: Power Off [ 22s] [ 8.661890] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb11 failed "build simtrace2.spec" at Tue Nov 16 13:22:23 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:latest/zeromq in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b55898b_5b8b2ac6bd19e6101785c4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/zeromq/CentOS_8/x86_64 Package network:osmocom:latest/zeromq failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest zeromq Last lines of build log: [ 21s] Using UART console [ 21s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 21s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 31s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: x86_64 [ 31s] [ 9.101368] sysrq: Changing Loglevel [ 31s] [ 9.102308] sysrq: Loglevel set to 4 [ 31s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 31s] Increasing log level from now on... [ 31s] Enable sysrq operations [ 31s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 31s] no label, UUID=9c05f4b2-a204-4af5-9fff-516e244867da [ 31s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 31s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 31s] swapon /dev/vdb [ 31s] WARNING: udev not running, creating extra device nodes [ 31s] logging output to //.build.log... [ 31s] processing recipe /.build-srcdir/zeromq.spec ... [ 31s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/zeromq.spec build ... [ 31s] initializing rpm db... [ 32s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 32s] ### VM INTERACTION START ### [ 35s] [ 12.915348] sysrq: Power Off [ 35s] [ 12.943444] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] lamb21 failed "build zeromq.spec" at Tue Nov 16 13:22:41 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:nightly/uhd in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b584089_5b8b2ac6bd19e61017865e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/uhd/CentOS_8/x86_64 Package network:osmocom:nightly/uhd failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly uhd Last lines of build log: [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.27-defa[ 5.419301] sysrq: Changing Loglevel [ 21s] ult #1 SMP Tue O[ 5.420714] sysrq: Loglevel set to 4 [ 21s] ct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=a4e3a755-2574-4b93-9945-ea03d4bea7ff [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/uhd.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/uhd.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.629059] sysrq: Power Off [ 24s] [ 8.635557] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb62 failed "build uhd.spec" at Tue Nov 16 13:22:41 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b615c53_5b8b2ac6bd19e610178832@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/CentOS_8/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 23s] Increasing log level from now on... [ 23s] [ 5.957740] sysrq: Changing Loglevel [ 23s] [ 5.958958] sysrq: Loglevel set to 4 [ 23s] Enable sysrq operations [ 23s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 23s] no label, UUID=bcae1245-fb72-435a-a475-92dfb2990415 [ 23s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 23s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 23s] swapon /dev/vdb [ 23s] WARNING: udev not running, creating extra device nodes [ 23s] logging output to //.build.log... [ 23s] processing recipe /.build-srcdir/osmo-ggsn.spec ... [ 23s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-ggsn.spec build ... [ 23s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 9.150529] sysrq: Power Off [ 26s] [ 9.153420] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] cloud111 failed "build osmo-ggsn.spec" at Tue Nov 16 13:22:26 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b65987d_5b8b2ac6bd19e6101789a3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/CentOS_8/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.625154] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.626190] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=0a9e7522-0a72-43ee-9d2e-e549bf566e9f [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-pcu.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-pcu.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.840009] sysrq: Power Off [ 22s] [ 8.846530] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb17 failed "build osmo-pcu.spec" at Tue Nov 16 13:22:27 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b686e5f_5b8b2ac6bd19e6101790ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/CentOS_8/x86_64 Package network:osmocom:latest/libosmo-abis failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.578026] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.579306] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=c61ba34b-295d-4755-ad0f-5a0c653ebf74 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-abis.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-abis.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.791461] sysrq: Power Off [ 22s] [ 8.797835] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb59 failed "build libosmo-abis.spec" at Tue Nov 16 13:22:27 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b7688ae_5b8b2ac6bd19e61017949f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/CentOS_8/x86_64 Package network:osmocom:latest/libosmo-netif failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.700010] sysrq: Changing Loglevel [ 19s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UT[ 5.702423] sysrq: Loglevel set to 4 [ 19s] C 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=284874d2-0c5e-4ff4-ac32-9c55dc3877c9 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-netif.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-netif.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.901554] sysrq: Power Off [ 22s] [ 8.923639] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb23 failed "build libosmo-netif.spec" at Tue Nov 16 13:22:29 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:latest/uhd in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b7a291b_5b8b2ac6bd19e6101795f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/uhd/CentOS_8/x86_64 Package network:osmocom:latest/uhd failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest uhd Last lines of build log: [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 5[ 4.197315] sysrq: Changing Loglevel [ 14s] [ 4.198223] sysrq: Loglevel set to 4 [ 14s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 14s] Increasing log level from now on... [ 14s] Enable sysrq operations [ 14s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 14s] no label, UUID=b04af3ed-a1f2-4c83-8cad-ae87fe2a93d4 [ 14s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 14s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 14s] swapon /dev/vdb [ 14s] WARNING: udev not running, creating extra device nodes [ 14s] logging output to //.build.log... [ 14s] processing recipe /.build-srcdir/uhd.spec ... [ 14s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/uhd.spec build ... [ 14s] initializing rpm db... [ 14s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.396006] sysrq: Power Off [ 17s] [ 7.397696] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] build77 failed "build uhd.spec" at Tue Nov 16 13:22:28 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:nightly/zeromq in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b85852f_5b8b2ac6bd19e6101798d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/zeromq/CentOS_8/x86_64 Package network:osmocom:nightly/zeromq failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly zeromq Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] [ 5.648551] sysrq: Changing Loglevel [ 20s] [ 5.649650] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=cd8ca617-2afe-479b-bf3f-d18b082eb997 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/zeromq.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/zeromq.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.857439] sysrq: Power Off [ 23s] [ 8.862192] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb06 failed "build zeromq.spec" at Tue Nov 16 13:22:30 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b8aa612_5b8b2ac6bd19e6101799b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-gbproxy failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 23s] Increasing log level from now on... [ 23s] [ 6.584235] sysrq: Changing Loglevel [ 23s] [ 6.585044] sysrq: Loglevel set to 4 [ 23s] Enable sysrq operations [ 23s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 23s] no label, UUID=86172d91-42d8-49e1-968c-4b83aa316ac0 [ 23s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 23s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 23s] swapon /dev/vdb [ 23s] WARNING: udev not running, creating extra device nodes [ 23s] logging output to //.build.log... [ 23s] processing recipe /.build-srcdir/osmo-gbproxy.spec ... [ 23s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-gbproxy.spec build ... [ 23s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 9.817494] sysrq: Power Off [ 26s] [ 9.824550] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] lamb58 failed "build osmo-gbproxy.spec" at Tue Nov 16 13:22:31 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:nightly/sofia-sip in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b941aac_5b8b2ac6bd19e610180123@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/sofia-sip/CentOS_8/x86_64 Package network:osmocom:nightly/sofia-sip failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly sofia-sip Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] [ 6.566118] sysrq: Changing Loglevel [ 21s] [ 6.567111] sysrq: Loglevel set to 4 [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=ee45cdf0-bf8a-4c9c-a8d8-2a757283307b [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/sofia-sip.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/sofia-sip.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 9.802177] sysrq: Power Off [ 24s] [ 9.808831] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb25 failed "build sofia-sip.spec" at Tue Nov 16 13:22:34 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:22:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:22:43 +0000 Subject: Build failure of network:osmocom:nightly/yder in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0b8d2f44_5b8b2ac6bd19e610180034@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/yder/CentOS_8/x86_64 Package network:osmocom:nightly/yder failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly yder Last lines of build log: [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5.3.18-59.27-defa[ 6.480700] sysrq: Changing Loglevel [ 24s] ult #1 SMP Tue Oct 5 10:00:40 UT[ 6.482784] sysrq: Loglevel set to 4 [ 24s] C 2021 (7df2404) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 24s] no label, UUID=fafd2a2d-cf4f-4bb0-89bd-d1bb0fb4f38d [ 24s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 24s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 24s] swapon /dev/vdb [ 24s] WARNING: udev not running, creating extra device nodes [ 24s] logging output to //.build.log... [ 24s] processing recipe /.build-srcdir/yder.spec ... [ 24s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/yder.spec build ... [ 24s] initializing rpm db... [ 24s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 24s] ### VM INTERACTION START ### [ 27s] [ 9.719576] sysrq: Power Off [ 27s] [ 9.730715] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb27 failed "build yder.spec" at Tue Nov 16 13:22:32 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0ba6e13a_5b8b2ac6bd19e61018057d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5.3.18-59.27-defa[ 4.753230] sysrq: Changing Loglevel [ 17s] ult #1 SMP Tue O[ 4.754145] sysrq: Loglevel set to 4 [ 17s] ct 5 10:00:40 UTC 2021 (7df2404) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 17s] no label, UUID=dc99cb88-df4c-4b99-a389-e7eb91605c82 [ 17s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 17s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 17s] swapon /dev/vdb [ 17s] WARNING: udev not running, creating extra device nodes [ 17s] logging output to //.build.log... [ 17s] processing recipe /.build-srcdir/osmo-bts.spec ... [ 17s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-bts.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.998465] sysrq: Power Off [ 21s] [ 8.001665] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] old-atreju5 failed "build osmo-bts.spec" at Tue Nov 16 13:22:58 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0bba40c3_5b8b2ac6bd19e610180858@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.474592] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 4.475627] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=3a1f44a9-0fe4-4b32-a987-ab181b1aacff [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/osmo-mgw.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-mgw.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.594769] sysrq: Power Off [ 16s] [ 7.598613] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat07 failed "build osmo-mgw.spec" at Tue Nov 16 13:22:50 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:00 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0bdb519a_5b8b2ac6bd19e6101815c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/CentOS_8/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_14/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_14/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_14/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5.3.18-59.27-defa[ 4.873192] sysrq: Changing Loglevel [ 17s] ult #1 SMP Tue O[ 4.874395] sysrq: Loglevel set to 4 [ 17s] ct 5 10:00:40 UTC 2021 (7df2404) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 17s] no label, UUID=98f3d72c-e42f-4ae3-90da-a35a0176a201 [ 17s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 17s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 17s] swapon /dev/vdb [ 17s] WARNING: udev not running, creating extra device nodes [ 17s] logging output to //.build.log... [ 17s] processing recipe /.build-srcdir/osmo-sip-connector.spec ... [ 17s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sip-connector.spec build ... [ 17s] initializing rpm db... [ 17s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.048187] sysrq: Power Off [ 20s] [ 8.052767] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] sheep88 failed "build osmo-sip-connector.spec" at Tue Nov 16 13:22:54 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:17 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0d2f3a94_5b8b2ac6bd19e610181623@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/CentOS_8/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5[ 5.544971] sysrq: Changing Loglevel [ 20s] .3.18-59.27-default #1 SMP Tue O[ 5.546547] sysrq: Loglevel set to 4 [ 20s] ct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=f2f0c3b2-d65a-4695-86bb-ae263bb2a7bf [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/libosmo-sccp.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-sccp.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.753418] sysrq: Power Off [ 23s] [ 8.758280] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb07 failed "build libosmo-sccp.spec" at Tue Nov 16 13:23:04 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b0d35e588_5b8b2ac6bd19e6101818f1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 14s] ### VM INTERACTION START ### [ 14s] Using UART console [ 14s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_23/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_23/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_23/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 23s] ### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: aarch64 [ 23s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 23s] Increasing log level from now on... [ 23s] [ 8.167451] sysrq: Changing Loglevel [ 23s] [ 8.167708] sysrq: Loglevel set to 4 [ 23s] Enable sysrq operations [ 23s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 23s] no label, UUID=c6459ef3-dda7-4838-aa7b-2b4a8e94a102 [ 23s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 23s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 23s] swapon /dev/vda [ 23s] WARNING: udev not running, creating extra device nodes [ 23s] logging output to //.build.log... [ 23s] processing recipe /.build-srcdir/osmo-bsc.spec ... [ 23s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-bsc.spec build ... [ 23s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 11.512369] sysrq: Power Off [ 26s] [ 11.514280] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] obs-arm-10 failed "build osmo-bsc.spec" at Tue Nov 16 13:23:05 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0d3e519c_5b8b2ac6bd19e610181945@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5[ 5.683754] sysrq: Changing Loglevel [ 22s] [ 5.685588] sysrq: Loglevel set to 4 [ 22s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 22s] no label, UUID=3d45a0b3-83c0-4a76-bf6c-b9afc2eadcfc [ 22s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 22s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 22s] swapon /dev/vdb [ 22s] WARNING: udev not running, creating extra device nodes [ 22s] logging output to //.build.log... [ 22s] processing recipe /.build-srcdir/osmo-hlr.spec ... [ 22s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hlr.spec build ... [ 23s] initializing rpm db... [ 23s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 23s] ### VM INTERACTION START ### [ 26s] [ 8.906224] sysrq: Power Off [ 26s] [ 8.911126] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] cloud122 failed "build osmo-hlr.spec" at Tue Nov 16 13:23:10 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:17 +0000 Subject: Build failure of network:osmocom:latest/ulfius in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0d41b381_5b8b2ac6bd19e6101820a5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/CentOS_8/x86_64 Package network:osmocom:latest/ulfius failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.333561] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.335915] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=e584ddd6-cfa2-45bd-80f8-de0ecba8e40c [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/ulfius.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/ulfius.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.550501] sysrq: Power Off [ 23s] [ 8.557655] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb09 failed "build ulfius.spec" at Tue Nov 16 13:23:10 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f2a3b23_5b8b2ac6bd19e610182367@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/CentOS_8/x86_64 Package network:osmocom:latest/osmo-pcap failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 16s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 16s] 2nd stage started in virtual machine [ 16s] machine type: x86_64 [ 16s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 16s] Increasing log level from now on... [ 16s] [ 5.438511] sysrq: Changing Loglevel [ 16s] [ 5.439091] sysrq: Loglevel set to 4 [ 16s] Enable sysrq operations [ 16s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 16s] no label, UUID=7c9adf23-96d8-4794-829e-b9c39f43ab6d [ 16s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 16s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 16s] swapon /dev/vdb [ 16s] WARNING: udev not running, creating extra device nodes [ 16s] logging output to //.build.log... [ 16s] processing recipe /.build-srcdir/osmo-pcap.spec ... [ 16s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-pcap.spec build ... [ 16s] initializing rpm db... [ 16s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 16s] ### VM INTERACTION START ### [ 19s] [ 8.570397] sysrq: Power Off [ 19s] [ 8.572446] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] hci-cnode2-e5 failed "build osmo-pcap.spec" at Tue Nov 16 13:23:28 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcap in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f3782a3_5b8b2ac6bd19e61018263a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-pcap failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.27-default #1 SMP Tue O[ 5.610296] sysrq: Changing Loglevel [ 22s] [ 5.612064] sysrq: Loglevel set to 4 [ 22s] ct 5 10:00:40 UTC 2021 (7df2404) [ 22s] Increasing log level from now on... [ 22s] Enable sysrq operations [ 22s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 22s] no label, UUID=96da1fae-f13d-4735-8dab-8fe22d84a235 [ 22s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 22s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 22s] swapon /dev/vdb [ 22s] WARNING: udev not running, creating extra device nodes [ 22s] logging output to //.build.log... [ 22s] processing recipe /.build-srcdir/osmo-pcap.spec ... [ 22s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-pcap.spec build ... [ 22s] initializing rpm db... [ 22s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.803559] sysrq: Power Off [ 25s] [ 8.806913] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] cloud108 failed "build osmo-pcap.spec" at Tue Nov 16 13:23:31 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f3b16b4_5b8b2ac6bd19e610182770@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/CentOS_8/x86_64 Package network:osmocom:nightly/ulfius failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.27-defa[ 5.526965] sysrq: Changing Loglevel [ 19s] ult #1 SMP Tue O[ 5.528780] sysrq: Loglevel set to 4 [ 19s] ct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=e8e9419f-2c3f-4e33-a5c0-e78965d9c5ba [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/ulfius.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/ulfius.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.737197] sysrq: Power Off [ 22s] [ 8.742478] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb11 failed "build ulfius.spec" at Tue Nov 16 13:23:32 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f3df4c7_5b8b2ac6bd19e610182821@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.454146] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.456050] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=7b9e4b78-4a23-4056-8876-47a03bce94f4 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/osmo-sip-connector.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sip-connector.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.664435] sysrq: Power Off [ 23s] [ 8.670667] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb62 failed "build osmo-sip-connector.spec" at Tue Nov 16 13:23:32 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f453da0_5b8b2ac6bd19e61018305f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/CentOS_8/x86_64 Package network:osmocom:latest/osmo-trx failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.27-defa[ 6.298031] sysrq: Changing Loglevel [ 21s] ult #1 SMP Tue O[ 6.299134] sysrq: Loglevel set to 4 [ 21s] ct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=28f73517-30bd-48eb-9793-9cb38335ae95 [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/osmo-trx.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-trx.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 9.514470] sysrq: Power Off [ 24s] [ 9.542099] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb04 failed "build osmo-trx.spec" at Tue Nov 16 13:23:32 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f4d9867_5b8b2ac6bd19e610183378@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/CentOS_8/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.724609] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.725556] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=23991666-30e0-405e-a779-63660967aef4 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-mgw.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-mgw.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.933410] sysrq: Power Off [ 22s] [ 8.938816] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb22 failed "build osmo-mgw.spec" at Tue Nov 16 13:23:32 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b0f590992_5b8b2ac6bd19e61018367d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-bts failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 21s] ### VM INTERACTION START ### [ 21s] Using UART console [ 21s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 33s] ### VM INTERACTION END ### [ 33s] 2nd stage started in virtual machine [ 33s] machine type: aarch64 [ 33s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 33s] Increasing log level from now on... [ 33s] [ 11.072223] sysrq: Changing Loglevel [ 33s] [ 11.073587] sysrq: Loglevel set to 4 [ 33s] Enable sysrq operations [ 33s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 33s] no label, UUID=1007b454-4c11-4ab9-85d2-d7b34b9e6734 [ 33s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 33s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 33s] swapon /dev/vda [ 34s] WARNING: udev not running, creating extra device nodes [ 34s] logging output to //.build.log... [ 34s] processing recipe /.build-srcdir/osmo-bts.spec ... [ 34s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-bts.spec build ... [ 34s] initializing rpm db... [ 34s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 34s] ### VM INTERACTION START ### [ 37s] [ 14.447443] sysrq: Power Off [ 37s] [ 14.448926] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] obs-arm-9 failed "build osmo-bts.spec" at Tue Nov 16 13:23:19 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f5d831b_5b8b2ac6bd19e6101837d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/CentOS_8/x86_64 Package network:osmocom:latest/osmo-bts failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] [ 5.749046] sysrq: Changing Loglevel [ 21s] [ 5.749911] sysrq: Loglevel set to 4 [ 21s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=8b4cc5dc-a57a-40ed-a9aa-9d78bd4cdf41 [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/osmo-bts.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-bts.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.959601] sysrq: Power Off [ 24s] [ 8.964822] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb12 failed "build osmo-bts.spec" at Tue Nov 16 13:23:33 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b0f69b540_5b8b2ac6bd19e610184061@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-sgsn failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 21s] ### VM INTERACTION START ### [ 21s] Using UART console [ 21s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 34s] ### VM INTERACTION END ### [ 34s] 2nd stage started in virtual machine [ 34s] machine type: aarch64 [ 34s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 34s] Increasing log level from now on... [ 34s] [ 11.137976] sysrq: Changing Loglevel [ 34s] [ 11.138780] sysrq: Loglevel set to 4 [ 34s] Enable sysrq operations [ 34s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 34s] no label, UUID=89816f69-de93-4633-a215-9af63c085f1e [ 34s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 34s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 34s] swapon /dev/vda [ 34s] WARNING: udev not running, creating extra device nodes [ 34s] logging output to //.build.log... [ 34s] processing recipe /.build-srcdir/osmo-sgsn.spec ... [ 34s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sgsn.spec build ... [ 34s] initializing rpm db... [ 34s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 34s] ### VM INTERACTION START ### [ 37s] [ 14.491345] sysrq: Power Off [ 37s] [ 14.492742] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] obs-arm-9 failed "build osmo-sgsn.spec" at Tue Nov 16 13:23:22 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f63c5f7_5b8b2ac6bd19e610183829@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/CentOS_8/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 5.3.18-59.27-defa[ 4.922503] sysrq: Changing Loglevel [ 15s] [ 4.923776] sysrq: Loglevel set to 4 [ 15s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 15s] no label, UUID=9c2f902e-1dd8-4ae2-9de2-1f1747febae5 [ 15s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 15s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 15s] swapon /dev/vdb [ 15s] WARNING: udev not running, creating extra device nodes [ 15s] logging output to //.build.log... [ 15s] processing recipe /.build-srcdir/osmo-hlr.spec ... [ 15s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hlr.spec build ... [ 15s] initializing rpm db... [ 15s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 15s] ### VM INTERACTION START ### [ 19s] [ 8.082929] sysrq: Power Off [ 19s] [ 8.084441] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] build78 failed "build osmo-hlr.spec" at Tue Nov 16 13:23:21 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f7378b6_5b8b2ac6bd19e610184295@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 4.904922] sysrq: Changing Loglevel [ 18s] [ 4.906170] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 18s] no label, UUID=460b7e1a-5849-4f3b-8b14-b444458b8438 [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/osmo-trx.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-trx.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.058776] sysrq: Power Off [ 21s] [ 8.060768] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] build85 failed "build osmo-trx.spec" at Tue Nov 16 13:23:25 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:34 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f7bc77a_5b8b2ac6bd19e61018446b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/CentOS_8/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] [ 4.999941] sysrq: Changing Loglevel [ 19s] [ 5.000733] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=6b3b68fb-e71d-4248-94e0-94369229782f [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-sccp.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-sccp.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.213725] sysrq: Power Off [ 22s] [ 8.218169] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] old-cirrus2 failed "build libosmo-sccp.spec" at Tue Nov 16 13:23:27 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0f8ea3c4_5b8b2ac6bd19e61018481c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/CentOS_8/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 9s] Using UART console [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 5.3.18-59.27-defa[ 5.417443] sysrq: Changing Loglevel [ 15s] ult #1 SMP Tue O[ 5.418170] sysrq: Loglevel set to 4 [ 15s] ct 5 10:00:40 UTC 2021 (7df2404) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 15s] no label, UUID=b1da32f0-94aa-4538-8506-7c3176e2524d [ 15s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 15s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 15s] swapon /dev/vdb [ 15s] WARNING: udev not running, creating extra device nodes [ 15s] logging output to //.build.log... [ 15s] processing recipe /.build-srcdir/osmo-cbc.spec ... [ 15s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-cbc.spec build ... [ 15s] initializing rpm db... [ 15s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 15s] ### VM INTERACTION START ### [ 18s] [ 8.545803] sysrq: Power Off [ 18s] [ 8.553199] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] hci-cnode2-e5 failed "build osmo-cbc.spec" at Tue Nov 16 13:23:45 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcap in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b0fa1c9a9_5b8b2ac6bd19e610185061@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-pcap failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: [ 21s] ### VM INTERACTION START ### [ 21s] Using UART console [ 21s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_27/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_27/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_27/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 32s] ### VM INTERACTION END ### [ 32s] 2nd stage started in virtual machine [ 32s] machine type: aarch64 [ 32s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 33s] Increasing log level from now on... [ 33s] [ 10.319683] sysrq: Changing Loglevel [ 33s] [ 10.320619] sysrq: Loglevel set to 4 [ 33s] Enable sysrq operations [ 33s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 33s] no label, UUID=205b94ff-e2a1-46e4-8095-c0dac82962b4 [ 33s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 33s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 33s] swapon /dev/vda [ 33s] WARNING: udev not running, creating extra device nodes [ 33s] logging output to //.build.log... [ 33s] processing recipe /.build-srcdir/osmo-pcap.spec ... [ 33s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-pcap.spec build ... [ 33s] initializing rpm db... [ 33s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 33s] ### VM INTERACTION START ### [ 36s] [ 13.703763] sysrq: Power Off [ 36s] [ 13.706111] reboot: Power down [ 36s] ### VM INTERACTION END ### [ 36s] [ 36s] obs-arm-9 failed "build osmo-pcap.spec" at Tue Nov 16 13:23:34 UTC 2021. [ 36s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:23:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:23:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b0fb7186_5b8b2ac6bd19e610185420@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.458198] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 4.458731] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=04c5d424-5c7b-49ca-a18c-0eff04720d47 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/osmo-bsc.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-bsc.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.585226] sysrq: Power Off [ 16s] [ 7.587519] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat07 failed "build osmo-bsc.spec" at Tue Nov 16 13:23:38 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:08 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b10f57ef4_5b8b2ac6bd19e61018558c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/CentOS_8/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] [ 4.421600] sysrq: Changing Loglevel [ 13s] [ 4.421983] sysrq: Loglevel set to 4 [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=cbd69432-ccd2-4c32-a8ee-735227c811be [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/osmo-smlc.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-smlc.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.545613] sysrq: Power Off [ 16s] [ 7.549096] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat13 failed "build osmo-smlc.spec" at Tue Nov 16 13:23:57 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:08 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b10f98dd0_5b8b2ac6bd19e61018566c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/CentOS_8/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] [ 4.537665] sysrq: Changing Loglevel [ 13s] [ 4.538117] sysrq: Loglevel set to 4 [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=7097acec-b169-489d-8422-bb5b4f9261c7 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/osmo-iuh.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-iuh.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.660668] sysrq: Power Off [ 16s] [ 7.662759] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat05 failed "build osmo-iuh.spec" at Tue Nov 16 13:23:58 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b110c1a54_5b8b2ac6bd19e61018603f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-msc failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 22s] ### VM INTERACTION START ### [ 22s] Using UART console [ 22s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 34s] ### VM INTERACTION END ### [ 34s] 2nd stage started in virtual machine [ 34s] machine type: aarch64 [ 34s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 34s] Increasing log level from now on... [ 34s] [ 10.536800] sysrq: Changing Loglevel [ 34s] [ 10.537652] sysrq: Loglevel set to 4 [ 34s] Enable sysrq operations [ 34s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 34s] no label, UUID=3814b1fa-4901-48bb-a18e-48913db7a9cc [ 34s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 34s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 34s] swapon /dev/vda [ 34s] WARNING: udev not running, creating extra device nodes [ 34s] logging output to //.build.log... [ 34s] processing recipe /.build-srcdir/osmo-msc.spec ... [ 34s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-msc.spec build ... [ 34s] initializing rpm db... [ 34s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 34s] ### VM INTERACTION START ### [ 37s] [ 13.830618] sysrq: Power Off [ 37s] [ 13.832426] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] obs-arm-9 failed "build osmo-msc.spec" at Tue Nov 16 13:24:05 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b11133e3a_5b8b2ac6bd19e61018618c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-sip-connector failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 22s] ### VM INTERACTION START ### [ 22s] Using UART console [ 22s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_25/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_25/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_25/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 34s] ### VM INTERACTION END ### [ 34s] 2nd stage started in virtual machine [ 35s] machine type: aarch64 [ 35s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 35s] Increasing log level from now on... [ 35s] [ 11.243224] sysrq: Changing Loglevel [ 35s] [ 11.244374] sysrq: Loglevel set to 4 [ 35s] Enable sysrq operations [ 35s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 35s] no label, UUID=b4afdddc-dca2-4c51-988b-2d1ab0421d97 [ 35s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 35s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 35s] swapon /dev/vda [ 35s] WARNING: udev not running, creating extra device nodes [ 35s] logging output to //.build.log... [ 35s] processing recipe /.build-srcdir/osmo-sip-connector.spec ... [ 35s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sip-connector.spec build ... [ 35s] initializing rpm db... [ 35s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 35s] ### VM INTERACTION START ### [ 38s] [ 14.613881] sysrq: Power Off [ 38s] [ 14.615514] reboot: Power down [ 38s] ### VM INTERACTION END ### [ 38s] [ 38s] obs-arm-8 failed "build osmo-sip-connector.spec" at Tue Nov 16 13:23:52 UTC 2021. [ 38s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b1117a43d_5b8b2ac6bd19e610186294@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] [ 5.991115] sysrq: Changing Loglevel [ 21s] [ 5.991934] sysrq: Loglevel set to 4 [ 21s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=4daabbba-25bc-4f4e-ab06-c666bd1a07a1 [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/osmo-smlc.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-smlc.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 9.224139] sysrq: Power Off [ 24s] [ 9.228910] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb61 failed "build osmo-smlc.spec" at Tue Nov 16 13:23:53 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b111a9bb7_5b8b2ac6bd19e610186389@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5[ 5.700813] sysrq: Changing Loglevel [ 21s] .3.18-59.27-defa[ 5.702145] sysrq: Loglevel set to 4 [ 21s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=a06ed604-f099-4f8e-8812-3210a625f2d3 [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/osmo-iuh.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-iuh.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.915228] sysrq: Power Off [ 24s] [ 8.921313] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb54 failed "build osmo-iuh.spec" at Tue Nov 16 13:23:53 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:25 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b1124084_5b8b2ac6bd19e61018644d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/CentOS_8/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 15s] Using UART console [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5.3.18-59.27-default #1 SMP Tue O[ 5.492712] sysrq: Changing Loglevel [ 21s] [ 5.494127] sysrq: Loglevel set to 4 [ 21s] ct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=b40f46ed-90e7-4b7e-b095-fae353d41372 [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/osmo-bsc.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-bsc.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.686582] sysrq: Power Off [ 24s] [ 8.691211] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] cloud108 failed "build osmo-bsc.spec" at Tue Nov 16 13:24:15 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b112b3e86_5b8b2ac6bd19e61018661c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5.3.18-59.27-defa[ 4.462972] sysrq: Changing Loglevel [ 13s] ult #1 SMP Tue O[ 4.463860] sysrq: Loglevel set to 4 [ 13s] ct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=b0fb511f-7924-436d-9a9d-7615c52d93c9 [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/osmo-hnodeb.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hnodeb.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.589189] sysrq: Power Off [ 16s] [ 7.592994] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat05 failed "build osmo-hnodeb.spec" at Tue Nov 16 13:24:24 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b112ebaf9_5b8b2ac6bd19e6101867bd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5.3.18-59.27-defa[ 4.828427] sysrq: Changing Loglevel [ 18s] [ 4.829482] sysrq: Loglevel set to 4 [ 18s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 18s] no label, UUID=ec8fa453-da42-4306-afe2-73fadea4e47b [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/osmo-remsim.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-remsim.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.001153] sysrq: Power Off [ 21s] [ 8.004085] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] build78 failed "build osmo-remsim.spec" at Tue Nov 16 13:24:10 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b11346ecd_5b8b2ac6bd19e6101868f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5.3.18-59.27-defa[ 4.977757] sysrq: Changing Loglevel [ 18s] ult #1 SMP Tue O[ 4.978546] sysrq: Loglevel set to 4 [ 18s] ct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=682823a3-dbc6-4098-8b8b-9d7186c19f13 [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-cbc.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-cbc.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.142011] sysrq: Power Off [ 22s] [ 8.143793] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] old-atreju5 failed "build osmo-cbc.spec" at Tue Nov 16 13:24:13 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b131b0469_5b8b2ac6bd19e6101869e9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.057591] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.059571] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=5e99166b-2fc6-43ee-978b-cdcc9f056cef [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-sgsn.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sgsn.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.271680] sysrq: Power Off [ 22s] [ 8.275897] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] old-cirrus3 failed "build osmo-sgsn.spec" at Tue Nov 16 13:24:34 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b131e32c9_5b8b2ac6bd19e61018704b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/CentOS_8/x86_64 Package network:osmocom:latest/osmo-msc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 5.149654] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 5.150198] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 14s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 14s] no label, UUID=cf4f01cd-ec0f-4a6f-a5e1-a6ad7483eecb [ 14s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 14s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 14s] swapon /dev/vdb [ 14s] WARNING: udev not running, creating extra device nodes [ 14s] logging output to //.build.log... [ 14s] processing recipe /.build-srcdir/osmo-msc.spec ... [ 14s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-msc.spec build ... [ 14s] initializing rpm db... [ 14s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 14s] ### VM INTERACTION START ### [ 17s] [ 8.286235] sysrq: Power Off [ 17s] [ 8.293996] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat01 failed "build osmo-msc.spec" at Tue Nov 16 13:24:36 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:42 +0000 Subject: Build failure of network:osmocom:nightly/uhd in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <6193b1329195a_5b8b2ac6bd19e61018723d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/uhd/CentOS_8/aarch64 Package network:osmocom:nightly/uhd failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly uhd Last lines of build log: [ 18s] ### VM INTERACTION START ### [ 18s] Using UART console [ 18s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 27s] ### VM INTERACTION END ### [ 27s] 2nd stage started in virtual machine [ 27s] machine type: aarch64 [ 27s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 27s] Increasing log level from now on... [ 27s] [ 8.134281] sysrq: Changing Loglevel [ 27s] [ 8.134593] sysrq: Loglevel set to 4 [ 27s] Enable sysrq operations [ 27s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 27s] no label, UUID=0b2a7bf9-30df-4899-b915-cf39449f262f [ 27s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 27s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 27s] swapon /dev/vda [ 27s] WARNING: udev not running, creating extra device nodes [ 27s] logging output to //.build.log... [ 27s] processing recipe /.build-srcdir/uhd.spec ... [ 27s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/uhd.spec build ... [ 27s] initializing rpm db... [ 27s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 27s] ### VM INTERACTION START ### [ 30s] [ 11.403955] sysrq: Power Off [ 30s] [ 11.406958] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] obs-arm-11 failed "build uhd.spec" at Tue Nov 16 13:24:27 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:59 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b1331f65a_5b8b2ac6bd19e6101873cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/CentOS_8/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.732401] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.733526] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=dee09b80-f97b-4631-ab00-6f59cea28564 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-sgsn.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sgsn.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.925089] sysrq: Power Off [ 23s] [ 8.936011] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb60 failed "build osmo-sgsn.spec" at Tue Nov 16 13:24:51 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Nov 16 13:24:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 13:24:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6193b134afbe6_5b8b2ac6bd19e61018766d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 22s] Using UART console [ 22s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 22s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 29s] Booting from ROM...c[?7l### VM INTERACTION END ### [ 29s] 2nd stage started in virtual machine [ 29s] machine type: x86_64 [ 29s] Linux version: 5.3.18-59.27-default #1 SMP Tue O[ 5.934800] sysrq: Changing Loglevel [ 29s] ct 5 10:00:40 UT[ 5.936734] sysrq: Loglevel set to 4 [ 29s] C 2021 (7df2404) [ 29s] Increasing log level from now on... [ 29s] Enable sysrq operations [ 29s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 29s] no label, UUID=cd871682-bd96-48a0-ae35-ddb4d4e42c38 [ 29s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 29s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 29s] swapon /dev/vdb [ 29s] WARNING: udev not running, creating extra device nodes [ 29s] logging output to //.build.log... [ 29s] processing recipe /.build-srcdir/osmo-msc.spec ... [ 29s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-msc.spec build ... [ 29s] initializing rpm db... [ 29s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 29s] ### VM INTERACTION START ### [ 32s] [ 9.172103] sysrq: Power Off [ 32s] [ 9.180802] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] cloud132 failed "build osmo-msc.spec" at Tue Nov 16 13:24:48 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:44:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 13:44:57 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-sccp=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E39-484f-dirty_=E2=86=92_1=2E5=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 ) Change subject: Bump version: 1.4.0.39-484f-dirty ? 1.5.0 ...................................................................... Bump version: 1.4.0.39-484f-dirty ? 1.5.0 Change-Id: I963499ba9f78924660127312f4469b0781fed805 --- M contrib/libosmo-sccp.spec.in M debian/changelog M debian/control R debian/libosmo-sigtran7.install M debian/rules M src/Makefile.am 6 files changed, 69 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/72/26272/1 diff --git a/contrib/libosmo-sccp.spec.in b/contrib/libosmo-sccp.spec.in index f792f69..133d4a9 100644 --- a/contrib/libosmo-sccp.spec.in +++ b/contrib/libosmo-sccp.spec.in @@ -71,19 +71,19 @@ This subpackage contains the development files for the Osmocom SCCP library. -%package -n libosmo-sigtran5 +%package -n libosmo-sigtran7 Summary: Osmocom SIGTRAN library License: GPL-2.0-or-later Group: System/Libraries -%description -n libosmo-sigtran5 +%description -n libosmo-sigtran7 Osmocom implementation of (parts of) SIGTRAN. %package -n libosmo-sigtran-devel Summary: Development files for the Osmocom sigtran library License: GPL-2.0-or-later Group: Development/Libraries/C and C++ -Requires: libosmo-sigtran5 = %{version} +Requires: libosmo-sigtran7 = %{version} %description -n libosmo-sigtran-devel Osmocom implementation of (parts of) SIGTRAN. @@ -136,8 +136,8 @@ %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) -%post -n libosmo-sigtran5 -p /sbin/ldconfig -%postun -n libosmo-sigtran5 -p /sbin/ldconfig +%post -n libosmo-sigtran7 -p /sbin/ldconfig +%postun -n libosmo-sigtran7 -p /sbin/ldconfig %if 0%{?suse_version} %preun -n osmo-stp %service_del_preun osmo-stp.service %postun -n osmo-stp %service_del_postun osmo-stp.service @@ -159,8 +159,8 @@ %{_libdir}/libsccp.a %{_libdir}/pkgconfig/libosmo-sccp.pc -%files -n libosmo-sigtran5 -%{_libdir}/libosmo-sigtran.so.5* +%files -n libosmo-sigtran7 +%{_libdir}/libosmo-sigtran.so.7* %files -n libosmo-sigtran-devel %dir %{_includedir}/%{name} diff --git a/debian/changelog b/debian/changelog index 57964a9..a2500b3 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,58 @@ +libosmo-sccp (1.5.0) unstable; urgency=medium + + [ Harald Welte ] + * Add README.md describing what this repo is about + * ipa: Use VTY-configured default network indicator + * ipa_asp_fsm_del_route(): Log what happens if we bail out early + * don't log "SCTP connection close" if an IPA/TCP connection closes + * osmo_ss7: Log route destruction (like we log route creation) + * ipa_asp_fsm: Fix AS lookup from IPA ASP + * Don't create duplicate routes in osmo_ss7_route_create() + * ipa: Move automatic route add/del from ASP to AS level + * osmo_ss7: Truncate route 'mask' to point code bit length + * xua_as_fsm: Only delete a route for an IPA AS if we created one earlier + * xua_asp_fsm: Fix IPA client role + * don't do explicit NULL checks before calling talloc_free() + * osmo_ss7: free the sock_name string once an ASP socket is closed + * Revert "osmo_ss7: free the sock_name string once an ASP socket is closed" + * ss7_vty: Print actual connected port number in case of IPA server + * Constrain connection ID allocation to 24 bits + * ss7_asp_test.vty: Allow more asp node commands after shutdown + * osmo_ss7: introduce notion of configurable 'quirks' + * m3ua/sua: Add quirk for allowing inbound DAUD from SG in ASP role. + * m3ua/sua: Add new snm_inactive quirk + * sccp_scrc: Ensure we have not just SSN but at least OPC+SSN in CallingParty + * sccp: Add minimalistic support for XUDT / XUDTS + * sccp_scmg: Add missing line eneding to log statement + * stp: Add basic RX/TX rate counters on AS and ASP level + * spelling fixes in comments + * rate_ctr: Use legal counter group prefixes / names (no '.' allowed) + * osmo_ss7: properly unlink rate_counter on AS/ASP free + + [ Vadim Yanitskiy ] + * VTY: write_one_asp(): fix 1 << 31 cannot be represented by 'int' + + [ Pau Espin Pedrol ] + * cosmetic: xua_asp_fsm.c: reorder functions in file + * ipa_asp_fsm: Support server starting handshake with ID_GET or ID_ACK + * cosmetic: Fix extra empty line + * cosmetic: Fix typos in documentation + * osmo_sccp_simple_client_on_ss7_id(): Allow set internally proper IPv4/v6 default hosts + * osmo_ss7.c: Fix typo in doc for osmo_ss7_asp_peer_add_host() + + [ Philipp Maier ] + * osmo_ss7_vty: automatically create routes for routing key + * osmo_ss7_vty: allow users to inspect routes also in ASP role + + [ Eric ] + * m3ua: fix leaky usage of m3ua_tx_xua_asp + + [ Oliver Smith ] + * m3ua: reject deregistration of static routing keys + * m3ua: fix m3ua_encode_dupu + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:44:42 +0100 + libosmo-sccp (1.4.0) unstable; urgency=medium [ Vadim Yanitskiy ] diff --git a/debian/control b/debian/control index b12e247..7955055 100644 --- a/debian/control +++ b/debian/control @@ -34,7 +34,7 @@ . This package contains the development files for the library. -Package: libosmo-sigtran5 +Package: libosmo-sigtran7 Section: libs Architecture: any Multi-Arch: same @@ -53,7 +53,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-sigtran5 (= ${binary:Version}), +Depends: libosmo-sigtran7 (= ${binary:Version}), ${misc:Depends} Description: Documentation for the Osmocom SIGTRAN library libosmo-sigtran is a shared library containing SS7/SIGTRAN related functionality, @@ -68,7 +68,7 @@ Architecture: all Section: doc Depends: ${misc:Depends}, - libosmo-sigtran5 (= ${binary:Version}), + libosmo-sigtran7 (= ${binary:Version}), libjs-jquery Description: Documentation for the Osmocom SIGTRAN library libosmo-sigtran is a shared library containing SS7/SIGTRAN related functionality, @@ -83,7 +83,7 @@ Multi-Arch: same Section: libdevel Depends: ${misc:Depends}, - libosmo-sigtran5 (= ${binary:Version}), + libosmo-sigtran7 (= ${binary:Version}), libosmocore-dev, libosmo-netif-dev Description: Development headers for the Osmocom SIGTRAN library @@ -98,7 +98,7 @@ Architecture: any Multi-Arch: same Section: net -Depends: libosmo-sigtran5, +Depends: libosmo-sigtran7, ${shlibs:Depends}, ${misc:Depends} Description: Osmocom SIGTRAN STP (Signaling Transfer Point) diff --git a/debian/libosmo-sigtran5.install b/debian/libosmo-sigtran7.install similarity index 100% rename from debian/libosmo-sigtran5.install rename to debian/libosmo-sigtran7.install diff --git a/debian/rules b/debian/rules index 9c27539..8ad38cf 100755 --- a/debian/rules +++ b/debian/rules @@ -12,7 +12,7 @@ dh $@ --with autoreconf override_dh_strip: - dh_strip -plibosmo-sigtran5 --dbg-package=libosmo-sigtran-dbg + dh_strip -plibosmo-sigtran7 --dbg-package=libosmo-sigtran-dbg dh_strip -posmo-stp --dbg-package=osmo-stp-dbg override_dh_install: diff --git a/src/Makefile.am b/src/Makefile.am index 9d5e9a3..e2273e1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -25,7 +25,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=6:0:1 +LIBVERSION=7:0:0 libosmo_sigtran_la_SOURCES = sccp_sap.c sua.c m3ua.c xua_msg.c sccp_helpers.c \ sccp2sua.c sccp_scrc.c sccp_sclc.c sccp_scoc.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I963499ba9f78924660127312f4469b0781fed805 Gerrit-Change-Number: 26272 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:46:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 13:46:13 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sysmon=5Bmaster=5D=3A_Bump_version=3A_0=2E3=2E0=2E3-0d9d_=E2=86=92_0=2E3=2E1?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26273 ) Change subject: Bump version: 0.3.0.3-0d9d ? 0.3.1 ...................................................................... Bump version: 0.3.0.3-0d9d ? 0.3.1 Change-Id: I906f8046b599f2ad6824facfefd9c5cf96adf36d --- M debian/changelog 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/73/26273/1 diff --git a/debian/changelog b/debian/changelog index 2024e88..f90a056 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,14 @@ +osmo-sysmon (0.3.1) unstable; urgency=medium + + [ Oliver Smith ] + * configure.ac: set -std=gnu11 + * configure: don't turn some warnings into errors + + [ Harald Welte ] + * add README.md on what this repository is about + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:46:05 +0100 + osmo-sysmon (0.3.0) unstable; urgency=medium [ Daniel Willmann ] -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I906f8046b599f2ad6824facfefd9c5cf96adf36d Gerrit-Change-Number: 26273 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:52:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 13:52:18 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sip-connector=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E0=2E8-bd66_=E2=86=92_1=2E6=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/26274 ) Change subject: Bump version: 1.5.0.8-bd66 ? 1.6.0 ...................................................................... Bump version: 1.5.0.8-bd66 ? 1.6.0 Change-Id: I72fa9fdc5c6f1c5cfc6e4cb0b7d0e8ea4557b1ab --- M debian/changelog 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/74/26274/1 diff --git a/debian/changelog b/debian/changelog index e147a38..9a6b5e1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,23 @@ +osmo-sip-connector (1.6.0) unstable; urgency=medium + + [ Neels Hofmeyr ] + * fix use-after-free in SIP re-INVITE + * SIP re-INVITE: fix media connection change detection + * SIP re-INVITE: log media connection + + [ Oliver Smith ] + * debian/control: remove dh-systemd build-depend + + [ Keith ] + * MNCC v8: Implement Basic Support for Global Call Reference. + + [ Vadim Yanitskiy ] + * sip: fix memory leak (x_gcr) in send_invite() + * sip: use osmo_{enc,dec}_gcr() from libosmocore + * mncc: rework passing GCR over the MNCC interface + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:52:09 +0100 + osmo-sip-connector (1.5.0) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/26274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I72fa9fdc5c6f1c5cfc6e4cb0b7d0e8ea4557b1ab Gerrit-Change-Number: 26274 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 13:57:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 13:57:14 +0000 Subject: =?UTF-8?Q?Change_in_osmo-hlr=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E7-bfee_=E2=86=92_1=2E4=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26275 ) Change subject: Bump version: 1.3.0.7-bfee ? 1.4.0 ...................................................................... Bump version: 1.3.0.7-bfee ? 1.4.0 Change-Id: I39bbc42009bf6291884f652618bfdf94b329a295 --- M debian/changelog 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/75/26275/1 diff --git a/debian/changelog b/debian/changelog index 0ac618d..c8f93ae 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,24 @@ +osmo-hlr (1.4.0) unstable; urgency=medium + + [ Keith ] + * Correct configuration written from vty + * vty: enable show subscribers filtered by IMEI + + [ Harald Welte ] + * add README.md file as customary for cgit, github, gitlab, etc. + + [ Oliver Smith ] + * Add post-upgrade script for automatic db upgrade + * debian/control: remove dh-systemd build-depend + + [ Pau Espin Pedrol ] + * db: Avoid use uninitialized rc if running 0 statements + + [ Neels Hofmeyr ] + * db v6: determine 3G AUC IND from VLR name + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:56:41 +0100 + osmo-hlr (1.3.0) unstable; urgency=medium [ Alexander Couzens ] -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I39bbc42009bf6291884f652618bfdf94b329a295 Gerrit-Change-Number: 26275 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:03:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 14:03:40 +0000 Subject: =?UTF-8?Q?Change_in_osmo-ggsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E1=2E20-8cbd-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 ) Change subject: Bump version: 1.7.1.20-8cbd-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I21502c6e0b804237fe9bd8f5579dbabd519d6d51 Gerrit-Change-Number: 26268 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:03:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:06:03 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 14:06:03 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:06:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:11:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:11:13 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:11:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:11:37 +0000 Subject: Change in libosmocore[master]: osmo-release.sh: Blacklist script file from LIBVERS matches In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26263 ) Change subject: osmo-release.sh: Blacklist script file from LIBVERS matches ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d750d312017ebb434650a6e19707ec60faf4020 Gerrit-Change-Number: 26263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:11:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:11:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:11:40 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26262 ) Change subject: contrib/libosmocore.spec.in: Depends on talloc 2.1.0 ...................................................................... contrib/libosmocore.spec.in: Depends on talloc 2.1.0 With recent commit (see below) libosmocore started using talloc API talloc_pooled_object(), which is available only startinf from talloc 2.1.0. Let's bump required version check accordingly. Issue found by osmo-release.sh: ERROR: configure.ac does NOT match contrib/*.spec.in ! Fixes: b72867f0e68c96ca25e1f9929ce92be0a802db6b Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 --- M contrib/libosmocore.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved laforge: Looks good to me, approved diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in index df36e89..a3e0601 100644 --- a/contrib/libosmocore.spec.in +++ b/contrib/libosmocore.spec.in @@ -29,7 +29,7 @@ BuildRequires: pkgconfig(gnutls) >= 2.12.0 BuildRequires: pkgconfig(libpcsclite) BuildRequires: pkgconfig(libusb-1.0) -BuildRequires: pkgconfig(talloc) >= 2.0.1 +BuildRequires: pkgconfig(talloc) >= 2.1.0 BuildRequires: pkgconfig(libmnl) BuildRequires: pkgconfig(libsystemd) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6797e244118ce2ca7dd22050ff505d8442bba672 Gerrit-Change-Number: 26262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:11:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:11:40 +0000 Subject: Change in libosmocore[master]: osmo-release.sh: Blacklist script file from LIBVERS matches In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26263 ) Change subject: osmo-release.sh: Blacklist script file from LIBVERS matches ...................................................................... osmo-release.sh: Blacklist script file from LIBVERS matches The file itself appears in the list of matches when run in libosmocore.git. Let's prevent it: """ expr: non-integer argument WARN: Found 19 files matching debian/lib*.install for LIBVERSION=`gitdiff--cached-GLIBVERSION--stat|grepMakefile.am`, manual check required! """ Change-Id: I6d750d312017ebb434650a6e19707ec60faf4020 --- M osmo-release.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/osmo-release.sh b/osmo-release.sh index aecbfd1..3566ef9 100755 --- a/osmo-release.sh +++ b/osmo-release.sh @@ -223,7 +223,7 @@ exit 1 fi GIT_TOPDIR="$(git rev-parse --show-toplevel)" -LIBVERS=`git grep -n LIBVERSION | grep '=' | grep am | grep -v LDFLAGS` +LIBVERS=`git grep -n LIBVERSION | grep '=' | grep am | grep -v LDFLAGS | grep -v osmo-release.sh` MAKEMOD=`git diff --cached -GLIBVERSION --stat | grep Makefile.am` ISODATE=`date -I` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6d750d312017ebb434650a6e19707ec60faf4020 Gerrit-Change-Number: 26263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:13:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:13:40 +0000 Subject: =?UTF-8?Q?Change_in_libosmocore=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E1=2E282-ab5e-dirty_=E2=86=92_1=2E6=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26264 ) Change subject: Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 Gerrit-Change-Number: 26264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:13:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:14:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:14:23 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sysmon=5Bmaster=5D=3A_Bump_version=3A_0=2E3=2E0=2E3-0d9d_=E2=86=92_0=2E3=2E1?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26273 ) Change subject: Bump version: 0.3.0.3-0d9d ? 0.3.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I906f8046b599f2ad6824facfefd9c5cf96adf36d Gerrit-Change-Number: 26273 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:14:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:14:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:14:35 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sip-connector=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E0=2E8-bd66_=E2=86=92_1=2E6=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/26274 ) Change subject: Bump version: 1.5.0.8-bd66 ? 1.6.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/26274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I72fa9fdc5c6f1c5cfc6e4cb0b7d0e8ea4557b1ab Gerrit-Change-Number: 26274 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:14:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:15:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:15:02 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-sccp=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E39-484f-dirty_=E2=86=92_1=2E5=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 ) Change subject: Bump version: 1.4.0.39-484f-dirty ? 1.5.0 ...................................................................... Patch Set 1: it's interesting we jump from sigtran5 to sigtran7. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I963499ba9f78924660127312f4469b0781fed805 Gerrit-Change-Number: 26272 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:15:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:16:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:16:06 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-sccp=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E39-484f-dirty_=E2=86=92_1=2E5=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 ) Change subject: Bump version: 1.4.0.39-484f-dirty ? 1.5.0 ...................................................................... Patch Set 1: Code-Review+1 > it's interesting we jump from sigtran5 to sigtran7. ah, because age was "1" and hence it was version 6 - age 1 = 5. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I963499ba9f78924660127312f4469b0781fed805 Gerrit-Change-Number: 26272 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:16:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:16:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 14:16:59 +0000 Subject: Change in libosmocore[master]: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26270 ) Change subject: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id20871b76c4a5801defb4f534fad635b7f079a13 Gerrit-Change-Number: 26270 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:16:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:17:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:17:16 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-abis=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E1=2E14-57ff-dirty_=E2=86=92_1=2E2=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26271 ) Change subject: Bump version: 1.1.1.14-57ff-dirty ? 1.2.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0536137e6221fd322536111dfda6e19d3c57de6c Gerrit-Change-Number: 26271 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:17:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:17:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:17:37 +0000 Subject: Change in osmo-pcap[master]: Explicitly depend on required libosmogb In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26266 ) Change subject: Explicitly depend on required libosmogb ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 Gerrit-Change-Number: 26266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:17:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:17:38 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 14:17:38 +0000 Subject: =?UTF-8?Q?Change_in_libosmocore=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E1=2E282-ab5e-dirty_=E2=86=92_1=2E6=2E0?= In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26264 ) Change subject: Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 ...................................................................... Patch Set 1: Merge this one first and rebase? https://gerrit.osmocom.org/c/libosmocore/+/26270 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 Gerrit-Change-Number: 26264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:17:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:18:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:18:08 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-30bc-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26267 ) Change subject: Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb Gerrit-Change-Number: 26267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:18:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:18:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:18:23 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gsm-manuals=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E0=2E18-cec5_=E2=86=92_1=2E2=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 ) Change subject: Bump version: 1.1.0.18-cec5 ? 1.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id9167fa8aa474bb6feb349a2dcecb015b2a1d3b4 Gerrit-Change-Number: 26265 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:18:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:18:40 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3172_* In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 ) Change subject: pcu: Introduce test TC_t3172_* ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 Gerrit-Change-Number: 26256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:18:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:19:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:19:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 ) Change subject: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2058862cf11d0027b040eb6d9c0a27524df593b5 Gerrit-Change-Number: 26257 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:19:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:19:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:19:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_t3172_* In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 ) Change subject: pcu: Introduce test TC_t3172_* ...................................................................... pcu: Introduce test TC_t3172_* Related: OS#3928 Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 --- M library/RLCMAC_CSN1_Templates.ttcn M library/RLCMAC_CSN1_Types.ttcn M pcu/PCU_Tests.ttcn 3 files changed, 178 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/RLCMAC_CSN1_Templates.ttcn b/library/RLCMAC_CSN1_Templates.ttcn index 254983a..943717e 100644 --- a/library/RLCMAC_CSN1_Templates.ttcn +++ b/library/RLCMAC_CSN1_Templates.ttcn @@ -19,6 +19,28 @@ import from MobileL3_GMM_SM_Types all; import from RLCMAC_CSN1_Types all; + /* 11.2.1 Packet Access Reject */ + template PacketAccessRejectStruct tr_PacketAccessRejectStruct_TLLI(template GprsTlli tlli := ?, + template uint8_t wait_ind := *, + template BIT1 wait_ind_size := *) := { + id_type := '0'B, + id := { + tlli := tlli + }, + wait_ind_presence := ?, + wait_ind := wait_ind, + wait_ind_size := wait_ind_size + } + template RlcmacDlCtrlMsg tr_RlcMacDlCtrl_PKT_ACC_REJ(template PacketAccessRejectStruct rej := ?) := { + msg_type := PACKET_ACCESS_REJECT, + u := { + access_reject := { + page_mode := ?, + reject_struct := rej + } + } + } + template (value) RlcmacUlCtrlMsg ts_RlcMacUlCtrl_PKT_CTRL_ACK(GprsTlli tlli, CtrlAck ack := MS_RCVD_TWO_RLC_SAME_RTI_DIFF_RBSN) := { msg_type := PACKET_CONTROL_ACK, @@ -79,6 +101,18 @@ RlcOctetCount := 0 } + template (value) ChannelReqDescription ts_ChannelReqDescription(uint4_t peak_tput_class := 0, + uint2_t priority := 0, + RlcMode rlc_mode := RLC_MODE_ACKNOWLEDGED, + LlcPduType llc_pdu_type := LLC_PDU_IS_NOT_SACK_OR_ACK, + uint16_t RlcOctetCount := 0) := { + peak_tput_class := peak_tput_class, + priority := priority, + rlc_mode := rlc_mode, + llc_pdu_type := llc_pdu_type, + RlcOctetCount := RlcOctetCount + }; + /* TS 44.060 sec 11.2.16 */ template (value) RlcmacUlCtrlMsg ts_RlcMacUlCtrl_PKT_RES_REQ(GprsTlli tlli, template (omit) MSRadioAccessCapabilityV ms_rac, diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn index d9a5662..2093f55 100644 --- a/library/RLCMAC_CSN1_Types.ttcn +++ b/library/RLCMAC_CSN1_Types.ttcn @@ -705,6 +705,7 @@ /* 11.2.0.1 */ type union RlcmacDlCtrlUnion { + PacketAccessReject access_reject, PacketDlAssignment dl_assignment, PacketMeasOrder meas_order, PacketUlAssignment ul_assignment, @@ -721,7 +722,8 @@ RlcmacDlCtrlMsgType msg_type, RlcmacDlCtrlUnion u } with { - variant (u) "CROSSTAG(dl_assignment, msg_type = PACKET_DL_ASSIGNMENT; + variant (u) "CROSSTAG(access_reject, msg_type = PACKET_ACCESS_REJECT; + dl_assignment, msg_type = PACKET_DL_ASSIGNMENT; meas_order, msg_type = PACKET_MEASUREMENT_ORDER; ul_assignment, msg_type = PACKET_UL_ASSIGNMENT; paging, msg_type = PACKET_PAGING_REQUEST; @@ -739,6 +741,35 @@ external function dec_RlcmacDlCtrlMsg(in octetstring stream) return RlcmacDlCtrlMsg with { extension "prototype(convert) decode(RAW)" }; + /* 11.2.1 Packet Access Reject */ + type record PacketAccessRejectIDSub { + BIT1 id_type, + PacketRequestReference req_ref optional, + GlobalTfi gtfi optional + } with { variant (req_ref) "PRESENCE(id_type = '0'B)" + variant (gtfi) "PRESENCE(id_type = '1'B)" + }; + type union PacketAccessRejectID { + GprsTlli tlli, + PacketAccessRejectIDSub id_sub + } with { variant (tlli) "BYTEORDER(first)" }; + type record PacketAccessRejectStruct { + BIT1 id_type, + PacketAccessRejectID id, + BIT1 wait_ind_presence, + uint8_t wait_ind optional, + BIT1 wait_ind_size optional + } with { variant (id) "CROSSTAG(tlli, id_type = '0'B; id_sub, id_type = '1'B)" + variant (wait_ind) "PRESENCE(wait_ind_presence = '1'B)" + variant (wait_ind_size) "PRESENCE(wait_ind_presence = '1'B)" + }; + type record PacketAccessReject { + PageMode page_mode, + PacketAccessRejectStruct reject_struct + /* TODO: Additional Reject */ + /* TODO: Rel5 additions */ + } with { variant "" }; + /* 11.2.6 Packet Downlink Ack/Nack */ type record ILevel { diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 40dd400..6c59917 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -246,6 +246,15 @@ } } +private function f_pcuvty_set_timer(integer t, integer val) +runs on RAW_PCU_Test_CT { + if (t >= 0) { + f_vty_config2(PCUVTY, {"pcu"}, "timer T" & int2str(t) & " " & int2str(val)); + } else { + f_vty_config2(PCUVTY, {"pcu"}, "timer X" & int2str(t * -1) & " " & int2str(val)); + } +} + private function f_init_vty(charstring id, boolean egprs_only) runs on RAW_PCU_Test_CT { map(self:PCUVTY, system:PCUVTY); f_vty_set_prompts(PCUVTY); @@ -2027,6 +2036,107 @@ f_shutdown(__BFILE__, __LINE__, final := true); } +/* Verify configured T3172 is properly transmitted as WAIT_INDICATION in Pkt Access Reject in PACCH. */ +function f_TC_t3172(integer t3172_ms, BIT1 wait_ind_size) runs on RAW_PCU_Test_CT { + var PCUIF_info_ind info_ind; + var template IARRestOctets rest; + var BIT11 ra11; + var GprsMS ms; + var octetstring data := f_rnd_octstring(10); + var RlcmacDlBlock dl_block; + var template RlcmacDlBlock rej_tmpl; + var uint32_t dl_fn; + var uint32_t sched_fn; + var uint8_t wait_ind_val; + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + + info_ind := valueof(ts_PCUIF_INFO_default); + + /* Only the first TRX is enabled. */ + f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); + f_PCUIF_PDCHMask_set(info_ind, '00000001'B, 0); + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), info_ind); + + f_pcuvty_set_timer(3172, t3172_ms); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + var EGPRSPktChRequest req := { + one_phase := { + tag := '0'B, + multislot_class := '10101'B, + priority := '01'B, + random_bits := '101'B + } + }; + + /* We send 7 requests, the IUT gives us all available USFs (0..6) */ + for (var integer i := 0; i < 7; i := i + 1) { + req.one_phase.random_bits := int2bit(f_rnd_int(8), 3); + f_TC_egprs_pkt_chan_req(req, tr_IMM_TBF_ASS); + } + + /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); + f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + + /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ + f_sleep(X2002); + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + + /* ACK the DL block */ + f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B); + f_ms_tx_ul_block(ms, ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf.tfi, ms.dl_tbf.acknack_desc, false, ts_ChannelReqDescription()), + f_dl_block_ack_fn(dl_block, dl_fn)); + + /* Since all USF are taken, we should receive a Reject: */ + + if (wait_ind_size == '0'B) { + wait_ind_val := t3172_ms / 1000; + } else { + wait_ind_val := t3172_ms / 20; + } + rej_tmpl := tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_ACC_REJ( + tr_PacketAccessRejectStruct_TLLI(ms.tlli, + wait_ind_val, + wait_ind_size))); + template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum; + BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, + sapi := PCU_IF_SAPI_PDTCH, fn := 0, + arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), + block_nr := nr.blk_nr)); + alt { + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + rej_tmpl)); + [] BTS.receive { + setverdict(fail, "Unexpected BTS message"); + f_shutdown(__BFILE__, __LINE__); + } + } + f_shutdown(__BFILE__, __LINE__, final := true); +} +testcase TC_t3172_wait_ind_size0() runs on RAW_PCU_Test_CT { + /* size=0 means value is provided in seconds. Due to value being 8 + * bit, in the 20ms step case (size=1) the maximum value possible is 20 * 255 + * = 5100. Hence, values above it should use size=0 to be able to + * provide values in range. Let's use 6 seconds, 6000ms + */ + f_TC_t3172(6000, '0'B); +} +testcase TC_t3172_wait_ind_size1() runs on RAW_PCU_Test_CT { + f_TC_t3172(3000, '1'B); +} + /* Verify PCU handles correctly Countdown Procedure based on BS_CV_MAX */ testcase TC_countdown_procedure() runs on RAW_PCU_Test_CT { var RlcmacDlBlock dl_block; @@ -6576,6 +6686,8 @@ execute( TC_zero_x2031_t3191() ); execute( TC_t3193() ); execute( TC_n3105_max_t3195() ); + execute( TC_t3172_wait_ind_size0() ); + execute( TC_t3172_wait_ind_size1() ); execute( TC_countdown_procedure() ); execute( TC_ul_all_sizes() ); execute( TC_ul_data_toolong_fills_padding() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f4368c99b00453b471c3d741fecb8864ecdc628 Gerrit-Change-Number: 26256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:19:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:19:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 ) Change subject: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack ...................................................................... pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_dl_ack_nack Change-Id: I2058862cf11d0027b040eb6d9c0a27524df593b5 --- M pcu/PCU_Tests.ttcn 1 file changed, 56 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 6c59917..d7ab69b 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -3400,6 +3400,60 @@ f_shutdown(__BFILE__, __LINE__, final := true); } +/* Test scenario where MS wants to request a new UL TBF using a DL (EGPRS) ACK/NACK + * transmitted on ul slot provided by its DL TBF. + * See 3GPP TS 44.060 sec 9.3.2.4.2 "Non-extended uplink TBF mode" */ +function f_TC_ul_tbf_reestablish_with_pkt_dl_ack_nack(boolean use_egprs) runs on RAW_PCU_Test_CT { + var GprsMS ms; + var octetstring data := f_rnd_octstring(10); + var RlcmacDlBlock dl_block; + var template RlcmacDlBlock rej_tmpl; + var uint32_t dl_fn; + var uint32_t sched_fn; + var template (value) MSRadioAccessCapabilityV_BSSGP racap_tmpl; + + if (use_egprs == true) { + racap_tmpl := bssgp_ms_racap_egprs_def; + } else { + racap_tmpl := bssgp_ms_racap_gprs_def; + } + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename()); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, racap_tmpl)); + f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + + /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ + f_sleep(X2002); + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + + /* ACK the DL block, asking for new UL TBF by including ChanReqDesc */ + f_dltbf_ack_block(ms.dl_tbf, dl_block, '1'B); + f_ms_tx_ul_block(ms, f_dltbf_ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf, use_egprs, ts_ChannelReqDescription()), + f_dl_block_ack_fn(dl_block, dl_fn)); + + /* We should receive a Pkt Ul ASS */ + f_ms_rx_pkt_ass_pacch(ms, sched_fn, tr_RLCMAC_UL_PACKET_ASS); + f_shutdown(__BFILE__, __LINE__, final := true); +} +testcase TC_ul_tbf_reestablish_with_pkt_dl_ack_nack() runs on RAW_PCU_Test_CT { + f_TC_ul_tbf_reestablish_with_pkt_dl_ack_nack(false); +} +testcase TC_ul_tbf_reestablish_with_pkt_dl_ack_nack_egprs() runs on RAW_PCU_Test_CT { + f_TC_ul_tbf_reestablish_with_pkt_dl_ack_nack(true); +} + /* Test CS paging over the BTS<->PCU socket. * When a (class B or C, not A) MS has an active TBF (or is on the PDCH), the MS can not react on CS paging over CCCH. * Paging should be send on the PACCH. @@ -6742,6 +6796,8 @@ execute( TC_ul_multislot_tbf_ms_class_from_2phase() ); execute( TC_ul_tbf_reestablish_with_pkt_resource_req() ); execute( TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max() ); + execute( TC_ul_tbf_reestablish_with_pkt_dl_ack_nack() ); + execute( TC_ul_tbf_reestablish_with_pkt_dl_ack_nack_egprs() ); execute( TC_multiplex_dl_gprs_egprs() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2058862cf11d0027b040eb6d9c0a27524df593b5 Gerrit-Change-Number: 26257 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:19:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:19:32 +0000 Subject: =?UTF-8?Q?Change_in_osmo-hlr=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E7-bfee_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26275 ) Change subject: Bump version: 1.3.0.7-bfee ? 1.4.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I39bbc42009bf6291884f652618bfdf94b329a295 Gerrit-Change-Number: 26275 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:19:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:19:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 14:19:58 +0000 Subject: Change in osmo-bsc[master]: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26260 ) Change subject: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id3c51c144cf31a002eb0ef9ba9326d1ab45fbd60 Gerrit-Change-Number: 26260 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:19:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:20:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 14:20:00 +0000 Subject: Change in osmo-pcap[master]: debian/control: minimum version for libzmq3-dev is 3.2.2 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26269 ) Change subject: debian/control: minimum version for libzmq3-dev is 3.2.2 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If76b4fcb8863ad5468a77113ad25142fe1145cda Gerrit-Change-Number: 26269 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:20:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:23:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 14:23:40 +0000 Subject: Change in osmo-pcap[master]: Explicitly depend on required libosmogb In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26266 ) Change subject: Explicitly depend on required libosmogb ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 Gerrit-Change-Number: 26266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:23:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:49:07 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 14:49:07 +0000 Subject: Change in pysim[master]: ts_51_011: move _decode_select_response into profile class In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26205 ) Change subject: ts_51_011: move _decode_select_response into profile class ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py at 976 PS2, Line 976: Any > More specific type of the returned value is 'object'. Done https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py at 976 PS2, Line 976: def decode_select_response(self, resp_hex:str) -> Any: > If self is not used, then it's a @staticmethod. We can mark it as such in a separate commit. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11 Gerrit-Change-Number: 26205 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 14:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:53:33 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 14:53:33 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26165 to look at the new patch set (#6). Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py M pySim/utils.py 6 files changed, 228 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:53:34 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 14:53:34 +0000 Subject: Change in pysim[master]: profile: decode_select_response can be a static method References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26276 ) Change subject: profile: decode_select_response can be a static method ...................................................................... profile: decode_select_response can be a static method The method decode_select_response does not access any property of the object. This means the method can be static. Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b --- M pySim/profile.py M pySim/ts_102_221.py M pySim/ts_31_102.py M pySim/ts_31_103.py M pySim/ts_51_011.py 5 files changed, 26 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/26276/1 diff --git a/pySim/profile.py b/pySim/profile.py index 3601dac..d430f02 100644 --- a/pySim/profile.py +++ b/pySim/profile.py @@ -118,7 +118,8 @@ """ return interpret_sw(self.sw, sw) - def decode_select_response(self, data_hex:str) -> Any: + @staticmethod + def decode_select_response(data_hex:str) -> Any: """Decode the response to a SELECT command. This is the fall-back method which doesn't perform any decoding. It mostly diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 228fc23..0aa5e89 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -473,28 +473,6 @@ SC_DO = DataObjectChoice('security_condition', 'Security Condition', members=[Always_DO, Never_DO, SecCondByte_DO(), SecCondByte_DO(0x9e), CRT_DO()]) - -# ETSI TS 102 221 Section 11.1.1.3 -def decode_select_response(resp_hex): - fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) - resp_hex = resp_hex.upper() - # outer layer - fcp_base_tlv = TLV(['62']) - fcp_base = fcp_base_tlv.parse(resp_hex) - # actual FCP - fcp_tlv = TLV(FCP_TLV_MAP) - fcp = fcp_tlv.parse(fcp_base['62']) - # further decode the proprietary information - if fcp['A5']: - prop_tlv = TLV(FCP_Proprietary_TLV_MAP) - prop = prop_tlv.parse(fcp['A5']) - fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop) - fcp['A5'] = tlv_key_replace(FCP_Proprietary_TLV_MAP, fcp['A5']) - # finally make sure we get human-readable keys in the output dict - r = tlv_val_interpret(FCP_interpreter_map, fcp) - return tlv_key_replace(FCP_TLV_MAP, r) - - # TS 102 221 Section 13.1 class EF_DIR(LinFixedEF): def __init__(self, fid='2f00', sfid=0x1e, name='EF.DIR', desc='Application Directory'): @@ -694,8 +672,26 @@ super().__init__(name, desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) - def decode_select_response(self, data_hex:str) -> Any: - return decode_select_response(data_hex) + @staticmethod + def decode_select_response(resp_hex:str) -> Any: + """ETSI TS 102 221 Section 11.1.1.3""" + fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) + resp_hex = resp_hex.upper() + # outer layer + fcp_base_tlv = TLV(['62']) + fcp_base = fcp_base_tlv.parse(resp_hex) + # actual FCP + fcp_tlv = TLV(FCP_TLV_MAP) + fcp = fcp_tlv.parse(fcp_base['62']) + # further decode the proprietary information + if fcp['A5']: + prop_tlv = TLV(FCP_Proprietary_TLV_MAP) + prop = prop_tlv.parse(fcp['A5']) + fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop) + fcp['A5'] = tlv_key_replace(FCP_Proprietary_TLV_MAP, fcp['A5']) + # finally make sure we get human-readable keys in the output dict + r = tlv_val_interpret(FCP_interpreter_map, fcp) + return tlv_key_replace(FCP_TLV_MAP, r) @staticmethod def match_with_card(scc:SimCardCommands) -> bool: diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 14d7ec1..647a4d7 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1067,7 +1067,7 @@ self.add_files(files) def decode_select_response(self, data_hex): - return pySim.ts_102_221.decode_select_response(data_hex) + return pySim.ts_102_221.CardProfileUICC.decode_select_response(data_hex) @with_default_category('Application-Specific Commands') class AddlShellCommands(CommandSet): diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py index 63ef99e..9c7843f 100644 --- a/pySim/ts_31_103.py +++ b/pySim/ts_31_103.py @@ -213,7 +213,7 @@ self.shell_commands += [ADF_USIM.AddlShellCommands()] def decode_select_response(self, data_hex): - return pySim.ts_102_221.decode_select_response(data_hex) + return pySim.ts_102_221.CardProfileUICC.decode_select_response(data_hex) # TS 31.103 Section 7.1 sw_isim = { diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 29b184f..e10a61b 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -978,7 +978,8 @@ super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) - def decode_select_response(self, resp_hex:str) -> Any: + @staticmethod + def decode_select_response(resp_hex:str) -> Any: resp_bin = h2b(resp_hex) struct_of_file_map = { 0: 'transparent', -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b Gerrit-Change-Number: 26276 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:53:35 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 14:53:35 +0000 Subject: Change in pysim[master]: profile: decode_select_response use object instead 'Any' References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26277 ) Change subject: profile: decode_select_response use object instead 'Any' ...................................................................... profile: decode_select_response use object instead 'Any' the return type of decode_select_response is 'Any', lets be more specific and use 'object' Change-Id: Ic5c7ace234bc94ab1381d87e091369ade8011cab --- M pySim/filesystem.py M pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 4 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/77/26277/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6b20db5..4c3308c 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -34,7 +34,7 @@ from cmd2 import CommandSet, with_default_category, with_argparser import argparse -from typing import cast, Optional, Iterable, List, Any, Dict, Tuple +from typing import cast, Optional, Iterable, List, Dict, Tuple from smartcard.util import toBytes @@ -354,7 +354,7 @@ sels.update({x.name: x for x in self.applications.values() if x.name}) return sels - def decode_select_response(self, data_hex:str) -> Any: + def decode_select_response(self, data_hex:str) -> object: """Decode the response to a SELECT command. This is the fall-back method which automatically defers to the standard decoding diff --git a/pySim/profile.py b/pySim/profile.py index d430f02..13d54bb 100644 --- a/pySim/profile.py +++ b/pySim/profile.py @@ -24,7 +24,6 @@ from pySim.commands import SimCardCommands from pySim.filesystem import CardApplication, interpret_sw from pySim.utils import all_subclasses -from typing import Any import abc import operator @@ -119,7 +118,7 @@ return interpret_sw(self.sw, sw) @staticmethod - def decode_select_response(data_hex:str) -> Any: + def decode_select_response(data_hex:str) -> object: """Decode the response to a SELECT command. This is the fall-back method which doesn't perform any decoding. It mostly diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 0aa5e89..59244cc 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -673,7 +673,7 @@ super().__init__(name, desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) @staticmethod - def decode_select_response(resp_hex:str) -> Any: + def decode_select_response(resp_hex:str) -> object: """ETSI TS 102 221 Section 11.1.1.3""" fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) resp_hex = resp_hex.upper() diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index e10a61b..2c74c61 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -979,7 +979,7 @@ super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) @staticmethod - def decode_select_response(resp_hex:str) -> Any: + def decode_select_response(resp_hex:str) -> object: resp_bin = h2b(resp_hex) struct_of_file_map = { 0: 'transparent', -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic5c7ace234bc94ab1381d87e091369ade8011cab Gerrit-Change-Number: 26277 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:54:57 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 14:54:57 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 6: (8 comments) https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim-shell.py at 101 PS5, Line 101: if type(profile) is CardProfileUICC or type(profile) is CardProfileUICCSIM: > In terms of readability, this is a better approach: [?] Done https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/filesystem.py File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/filesystem.py at 1508 PS5, Line 1508: that is overloaded by specific dirived classes > If I understand correctly, this is an *abstract* static method. [?] Done https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 29 PS5, Line 29: # In order for autodetection ... > So AFAIU, the order is important here. And this is why you're not using __subclasses__(). Yes. You must first test for UICCSIM, then for UICC (without SIM) and the you can test for SIM. For example: When you test for SIM first, then you would e.g. recognize an UICCSIM as plain old SIM (which would even work, as they are compatible, but you would not be able to access its UICC features.) https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 32 PS5, Line 32: def profile_detect(scc:SimCardCommands): > Missing type definition for returned value: [?] Done https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 32 PS5, Line 32: profile_detect > I find it confusing that you create a new module called 'profile', which itself does not define clas [?] My plan was to implement it with a staticmethod, but I ran into problems with circular imports. I have tried it now again. Thanks to all_subcluasses function you provided it is not necessary to import the subclasses, so I managed to get around the problems and it worked this time. https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/profile.py at 33 PS5, Line 33: > ws Done https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py at 631 PS5, Line 631: _match_sim > So this is basically a copy of CardProfileSIM.match_with_card()? [?] Done https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py at 746 PS5, Line 746: # Add GSM specific files > tabs vs spaces There is a huge problem with tabs vs spaces in this project. Someone created parts with an editor that used 4 space wide tabs. I wonder if there is some tool like indent for python out there. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 14:59:52 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Nov 2021 14:59:52 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/5/pySim/ts_102_221.py at 746 PS5, Line 746: # Add GSM specific files > There is a huge problem with tabs vs spaces in this project. [?] python projects usually use spaces: https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces pysim is using pylint for linting, so you could add a patch that enables checking for proper indentation, similar to this patch: https://gerrit.osmocom.org/c/pysim/+/26123 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 14:59:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:00:38 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 15:00:38 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_TC_cm_serv_rej: tweak f_sleep()ing References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26278 ) Change subject: bsc: f_TC_cm_serv_rej: tweak f_sleep()ing ...................................................................... bsc: f_TC_cm_serv_rej: tweak f_sleep()ing Make the test more stable by sleeping a bit before stopping all components. Also reduce the f_sleep(3.0), an accidental leftover from initial debugging. Related: SYS#4878 Change-Id: I005af13baac4bca2a431b09b2a6bbfe7077342e0 --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/26278/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 4fdd059..229f8d6 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -10386,7 +10386,7 @@ { f_create_chan_and_exp(); BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); - f_sleep(3.0); + f_sleep(1.0); } testcase TC_cm_serv_rej() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); @@ -10404,6 +10404,7 @@ f_ctrs_bts_add(0, "cm_serv_rej:imsi_unknown_in_hlr", 1); f_ctrs_bts_verify(); + f_sleep(1.0); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I005af13baac4bca2a431b09b2a6bbfe7077342e0 Gerrit-Change-Number: 26278 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:01:41 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 15:01:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_TC_cm_serv_rej: tweak f_sleep()ing In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26278 ) Change subject: bsc: f_TC_cm_serv_rej: tweak f_sleep()ing ...................................................................... Patch Set 1: Code-Review+2 trivial -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I005af13baac4bca2a431b09b2a6bbfe7077342e0 Gerrit-Change-Number: 26278 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 16 Nov 2021 15:01:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:01:44 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 16 Nov 2021 15:01:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_TC_cm_serv_rej: tweak f_sleep()ing In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26278 ) Change subject: bsc: f_TC_cm_serv_rej: tweak f_sleep()ing ...................................................................... bsc: f_TC_cm_serv_rej: tweak f_sleep()ing Make the test more stable by sleeping a bit before stopping all components. Also reduce the f_sleep(3.0), an accidental leftover from initial debugging. Related: SYS#4878 Change-Id: I005af13baac4bca2a431b09b2a6bbfe7077342e0 --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 4fdd059..229f8d6 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -10386,7 +10386,7 @@ { f_create_chan_and_exp(); BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); - f_sleep(3.0); + f_sleep(1.0); } testcase TC_cm_serv_rej() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); @@ -10404,6 +10404,7 @@ f_ctrs_bts_add(0, "cm_serv_rej:imsi_unknown_in_hlr", 1); f_ctrs_bts_verify(); + f_sleep(1.0); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I005af13baac4bca2a431b09b2a6bbfe7077342e0 Gerrit-Change-Number: 26278 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:07:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:07:32 +0000 Subject: Change in osmo-bsc[master]: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26260 ) Change subject: fix entries in TODO-RELEASE, s/>1.5.1/>=1.6 ...................................................................... Patch Set 2: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id3c51c144cf31a002eb0ef9ba9326d1ab45fbd60 Gerrit-Change-Number: 26260 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 15:07:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:11:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:11:09 +0000 Subject: =?UTF-8?Q?Change_in_libosmocore=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E1=2E282-ab5e-dirty_=E2=86=92_1=2E6=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26264 ) Change subject: Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 Gerrit-Change-Number: 26264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 15:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:11:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:11:12 +0000 Subject: =?UTF-8?Q?Change_in_libosmocore=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E1=2E282-ab5e-dirty_=E2=86=92_1=2E6=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26264 ) Change subject: Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 ...................................................................... Bump version: 1.5.1.282-ab5e-dirty ? 1.6.0 Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 --- M TODO-RELEASE M contrib/libosmocore.spec.in M debian/changelog M debian/control R debian/libosmocore18.install R debian/libosmogsm17.install M src/Makefile.am M src/codec/Makefile.am M src/coding/Makefile.am M src/ctrl/Makefile.am M src/gb/Makefile.am M src/gsm/Makefile.am M src/sim/Makefile.am M src/vty/Makefile.am 14 files changed, 337 insertions(+), 43 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index ead2c50..8ccfa49 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,17 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmovty _LAST_OSMOVTY_NODE Raise _LAST_OSMOVTY_NODE by introducing some RESERVED*_NODE -libosmogsm gsm0808_old_bss_to_new_bss_info ABI break (struct changes size), gsm0808_old_bss_to_new_bss_info_att_tlvdef symbol added -libosmosim osim_card_hdl ABI + API breakage due to new struct members -libosmocore osmo_tdef_fsm_inst_state_chg change default_timeout arg from unsigned long to long type (API breakage, not ABI) -libosmovty vty_read_config_filep New API -libosmosim osim_card_{reset,close} New API -libosmocore struct rate_ctr_group, osmo_stat_item_group_desc ABI breakage due to new struct members -libosmgsm kdf functions New API -libosmocore osmo_stat_item API breakage: remove members stats_next_id, last_offs and values[], no users should exist. -libosmocore osmo_stat_item API breakage: remove functions osmo_stat_item_get_next(), osmo_stat_item_discard(), osmo_stat_item_discard_all(), no users should exist. -libosmocore osmo_stat_item_value API breakage: struct definition removed, because no known users exist / no users should exist. -libosmocore osmo_stat_item ABI breakage: struct osmo_stat_item made opaque. -libosmocore osmo_stat_item No FIFO buffer of values used anymore, the "skipped values" error is no longer possible. -libosmocore stats reporting for osmo_stat_item, values are now never repeated from one stats report to the next. diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in index a3e0601..3018280 100644 --- a/contrib/libosmocore.spec.in +++ b/contrib/libosmocore.spec.in @@ -111,13 +111,13 @@ This subpackage contains libraries and header files for developing applications that want to make use of libosmocoding. -%package -n libosmocore17 +%package -n libosmocore18 Summary: Osmocom core library # crc16.c has GPL2-only clauses, the rest (*.c) is GPL-2.0+ License: GPL-2.0-only AND GPL-2.0-or-later Group: System/Libraries -%description -n libosmocore17 +%description -n libosmocore18 libosmocore is a library with various utility functions shared between OpenBSC and OsmocomBB. @@ -126,7 +126,7 @@ # crc16.h has GPL2-only clauses, the rest (*.h) is GPL-2.0+ License: GPL-2.0-only AND GPL-2.0-or-later Group: Development/Libraries/C and C++ -Requires: libosmocore17 = %version +Requires: libosmocore18 = %version Requires: libtalloc-devel %description -n libosmocore-devel @@ -188,12 +188,12 @@ This subpackage contains libraries and header files for developing applications that want to make use of libosmogb. -%package -n libosmogsm16 +%package -n libosmogsm17 Summary: Osmocom GSM utility library License: GPL-2.0-or-later AND AGPL-3.0-or-later Group: System/Libraries -%description -n libosmogsm16 +%description -n libosmogsm17 libosmocore is a package with various utility functions that were originally developed as part of the OpenBSC project. @@ -208,7 +208,7 @@ License: GPL-2.0-or-later AND AGPL-3.0-or-later Group: Development/Libraries/C and C++ Requires: libosmocore-devel = %version -Requires: libosmogsm16 = %version +Requires: libosmogsm17 = %version %description -n libosmogsm-devel The libosmogsm library in particular is a collection of common code @@ -322,14 +322,14 @@ %postun -n libosmocodec0 -p /sbin/ldconfig %post -n libosmocoding0 -p /sbin/ldconfig %postun -n libosmocoding0 -p /sbin/ldconfig -%post -n libosmocore17 -p /sbin/ldconfig -%postun -n libosmocore17 -p /sbin/ldconfig +%post -n libosmocore18 -p /sbin/ldconfig +%postun -n libosmocore18 -p /sbin/ldconfig %post -n libosmoctrl0 -p /sbin/ldconfig %postun -n libosmoctrl0 -p /sbin/ldconfig %post -n libosmogb12 -p /sbin/ldconfig %postun -n libosmogb12 -p /sbin/ldconfig -%post -n libosmogsm16 -p /sbin/ldconfig -%postun -n libosmogsm16 -p /sbin/ldconfig +%post -n libosmogsm17 -p /sbin/ldconfig +%postun -n libosmogsm17 -p /sbin/ldconfig %post -n libosmosim2 -p /sbin/ldconfig %postun -n libosmosim2 -p /sbin/ldconfig %post -n libosmovty9 -p /sbin/ldconfig @@ -365,9 +365,9 @@ %_libdir/libosmocoding.so %_libdir/pkgconfig/libosmocoding.pc -%files -n libosmocore17 +%files -n libosmocore18 %defattr(-,root,root) -%_libdir/libosmocore.so.17* +%_libdir/libosmocore.so.18* %files -n libosmocore-devel %defattr(-,root,root) @@ -403,9 +403,9 @@ %_libdir/libosmogb.so %_libdir/pkgconfig/libosmogb.pc -%files -n libosmogsm16 +%files -n libosmogsm17 %defattr(-,root,root) -%_libdir/libosmogsm.so.16* +%_libdir/libosmogsm.so.17* %files -n libosmogsm-devel %defattr(-,root,root) diff --git a/debian/changelog b/debian/changelog index 8fffac5..8d44cf6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,311 @@ +libosmocore (1.6.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * osmo-release.sh: Check configure.ac dependency versions match those in rpm *.spec.in + * osmo-release.sh: Drop repeated DRY_RUN early exit + * osmo-release.sh: Check LIBVERSION matches rpm *.spec.in + * osmo-release.sh: Properly rearrange var init and sanity checks + * tests/gb: Fix printf format errors on ARM 32 bits + * Skip RPM checks if no *.spec.in available + * gsm_08_08.h: Add extra field elements defined in other sections + * cosmetic: tlv_parser: fix typo in func description + * cosmetic: Fix trailing whitespace + * gsm: Support Sending Last EUTRAN PLMN Id in Handover Required + * cosmetic: fix typo in comment + * gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef + * osmo_timer_pending: Make arg const + * gb: Fix naming and export symbol bssgp_enc_rim_pdu + * Revert "gb: Fix naming and export symbol bssgp_enc_rim_pdu" + * gb: Fix missing exporting symbol bssgp_encode_rim_pdu + * vty: Implement missing public API host_config_file() + * vty: Introduce API vty_read_config_filep + * range_enc_determine_range(): Don't dereference array on size=0 + * stat,rate_ctr: Introduce new API to get counter at given index + * Use new stat item/ctr getter APIs + * stat,rate_ctr: Allow setting group name and use it at report time + * ns2: Use NSVC bufid in stats report + * ipaccess: Add new osmo extension IPAC_PROTO_EXT_PCU + * bts_feature: Introduce feature to speak to PCU + * msgb_alloc_headroom: Change size args to be uint16_t + * ctrl: Pre-calculate required size before allocating msgb + * ctrl: Support recovering from short write + * cosmetic: gsm_12_21.h: Fix trailing whitespace + * Rename osmo dyn ts enums + * bts_feature: Introduce feature to confiure dyn ts as sdcch8 + * Make gcc 11.1.0 false positivies happy + * cosmetic: gb/gprs_ns.c: fix trailing whitespace + * gb/bssgp: Abort clearly if backward-compat API is used in wrong way + * utils: Fix c++ warn in OSMO_STRBUF_APPEND + * cosmetic: Fix missing space in comment + * gsm_08_58.h: Extend IPA Power Control Params IEs to pass C/I params + * gsm: Mark gsm0858_rsl_ul_meas_enc() pointer param const + * cosmetic: gsm: meas_rep.h: Fix typo in comment + * logging: Change LLAPD category color to purple-like one + * {ctrl,vty}/ports.h: Allocate ports for osmo-hnodeb + * configure.ac: Depend on talloc 2.1.0 + * logging: Fix double lock of log_tgt_mutex + * contrib/libosmocore.spec.in: Depends on talloc 2.1.0 + * osmo-release.sh: Blacklist script file from LIBVERS matches + + [ Oliver Smith ] + * osmo-release.sh: support epoch + * tests/stats: enable logging in test output + * stats: log error when missing stats values + * Revert "stats: log error when missing stats values" + * stat_item: make next_id argument name consistent + * stat_item: add comment with struct overview + * stat_item: make value ids item specific + * stats_test: restore stat_item_get_next asserts + * stats: log error when missing stats values (v2) + * stats: have_value is a bool, not int + * vty: add "show uptime" + * vty: add "show pid" + * vty: add "shutdown" + * vty: show uptime: use timespecsub + * vty: clear screen with ^L + * vty/ports: prepare formatting for a long define + * vty/ports: move pcap server/client ports + * tests: add 'make update_exp' target + * tests/stats: show how last item sent may be wrong + * stats: send real last value if no new values come + + [ Alexander Couzens ] + * gprs_bssgp: add support for SGSN oriented RESET + * gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1 + * gprs_ns2: don't OSMO_ASSERT() while freeing NS-VC. + * gprs_ns2: rework logging of Rx and Tx NS PDU + * gprs_ns2: always use the same method to print NSVCs + * gprs_ns2_vty: hide dynamic NSE information when ask for persistant only + * gprs_ns2_vty: make the `show ns entities` and `show ns binds` look similiar + * gprs_ns2: dump_nsvc: correct indention + * gprs_ns2: add vty command `nsvc reset` + * gprs_ns2: fix memory leaks when receiving SNS or invalid packets + * gprs_ns2: vty: remove a white space in `show binds` + * gprs_ns2: nsvc_fsm: reorder notification st_alive_on_enter() + * gprs_ns2: sns: ensure the sns->alive state is correct + * gprs_ns2: sns: remove the initial SNS NSVC if it's not part + * gprs_ns2_vty: print a response to vty `nsvc (block|unblock|reset) + * gprs_ns2: fix nsvc block and unblock vty command + * gprs_ns2: SNS: allow transition missing transition GPRS_SNS_ST_UNCONFIGURED + * gprs_ns2: add functions for SNS add/del/change-weight messages + * gprs_ns2: sns: fix del bind() + * gprs_ns2: vty: fix removing a bind from a SNS + * gprs_ns2: rework id strings of nsvcs + * gprs_ns2_sns: move selection of the next bind into own function + * gprs_ns2_sns: bss: improve validation of configuration + * gprs_ns2_sns: refactor local and remote entries into a struct + * gprs_ns2_sns: refactor ns2_clear_ipv46_entries_local to use new elems functions + * gprs_ns2_sns: use struct ns2_sns_elems in add/update/remove remote_elems + * gprs_ns2_sns: move gss->remote specific check out of add_ip4_elem/add_ip6_elem + * gprs_ns2_sns: add check for duplicates to add_ip6_elem() + * gprs_ns2_sns: refactor ip4_weight_sum/ip6_weight_sum + * gprs_ns2_sns: refactor nss_weight_sum_data -> ip46_weight_sum_data + * gprs_ns2_sns: replace ns2_sns_type with address family + * gprs_ns2_sns: bss: set gss->family + * gprs_ns2: use llist_add_tail to keep order + * gprs_ns2: fix missing notify towards the NSE when NSVC become blocked + * gprs_ns2_vc_fsm: reset the ALIVE response time when stopping test + * gprs_ns2: fix crash when changing the MTU + * gprs_ns2: fix check of MTU changes for frame relay + * gprs_ns2: correct mtu value in the log line + * gprs_ns2: use gprs_ns2_free_bind() to clean up a bind + * gprs_ns2: fix wrong format string in Tx Size logline + * gprs_ns2_vty: dump_nsvc: change output depending on NSVCI + * gprs_ns2: ensure the NSE becomes dead when FR link went down + * gprs_ns2_udp: don't start the NSVC fsm for SNS + * gprs_ns2_sns: refactor SNS failures into a function + * gprs_ns2_sns: free the NSE if the SIZE PDU is not valid + * gprs_ns2: add recursive anchor to protect against double free + * gprs_ns2: move sns_event into internal.h to direct emit events + * gprs_ns2_sns: rework sns clean up + * gprs_ns2: use an event to free the nsvscs when using SNS + * gprs_ns2: gprs_ns2_free_bind() should remove itself before removing nsvcs + * gprs_ns2: don't use llist_for_each when freeing an element + * gprs_ns2_sns: implement local change weight procedure + * gprs_ns2_sns: implement outbound SNS ADD procedures + * gprs_ns2_sns: implement outbound SNS DEL procedures + * gprs_ns2: also prevent recursive events when SGSN side cleans up + * gprs_ns2: calculate the nse->*_sums before notifing the sns fsm + * gprs_ns2: add correct filename/linenr to sns failed log message + * gprs_ns2: improve reselection protection + * gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NSVCs are present + * gprs_ns2: ensure the incoming NSVC is also the outgoing NSVC + * ns2: nsvc: reject UNITDATA when the remote BLOCK'ed + * ns2: fix a crash when receiving a SIZE while configured + * gprs_ns2: fix NS STATUS validation + * gprs_ns2: fix a white space + * gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSVC BLOCKED + * vty: add vty_out_uptime() print the uptime to the vty + * ns2: nse: add a uptime/downtime to track the last state change + * ns2: nsvc: add a uptime/downtime to track the last state change + * ns2: message: BLOCK/BLOCK ACK allow to use a given NSVCI instead of using the nsvc nsvci + * ns2: ensure the NSVC is in the correct mode for NSVC UNKNOWN/NSVC BLOCKED cause codes + * ns2: fsm: add comment don't answer on a STATUS with a STATUS + * ns2: message: allow to pass a foreign NSVCI to STATUS PDU + * ns2: correct parse a STATUS PDU which was received over a different NSVC + * ns2: improve log line when receving a PDU with wrong NSE + * ns2: don't forward an invalid RESET PDU to the FSM + * ns2: correct parse a BLOCK PDU which was received over a different NSVC + * include: add enum for UTRAN cipher + + [ Harald Welte ] + * cosmetic: ssn: some more comments + * gprs_ns2: Log all transmitted SNS messages + * gprs_ns2_sns: Dispatch inbound SNS-ACK to FSM + * gprs_ns2: Remove any references to DNS; we use DLNS in NS2. + * gprs_ns2: Pass peer/remote sockaddr argument to ns2_create_vc() + * TODO-RELEASE: Request increasing _LAST_OSMOVTY_NODE next release + * gprs_ns2_sns: Implement error log in case no binds found for NSE + * gprs_ns2_sns: Remove TODO (spec agrees, the correct cause code is used) + * gprs_ns2_vty: Clarify VTY help string wording + * gprs_ns2_sns: refactor ns2_sns_st_size_onenter() + * gprs_ns2_sns: Unify handling of SNS-CONFIG for IPv4 + IPv6 + * gprs_ns2: Encapsulate setting NSE dialect + * gprs_ns2_sns: Split allstate action in generic and BSS-specific part + * utils: osmo-aka-verify to verify UMTS AKA (SIM side) + * osmo-aka-verify: Fix use case with OP and not OPc + * gprs_ns2_sns: Support for SGSN-side IP-SNS + * gprs_ns2_sns: Add some more OSMO_ASSERT about BSS role + * gprs_ns2_sns: Rename BSS-side states to include 'bss' in name + * gprs_ns2: Introduce gprs_ns2_create_nse2() for SGSN side SNS + * gprs_ns2_vty: Allow creating NSE in sgsn-role + * gprs_ns2_sns: Don't clear remote IP endpoints in SGSN role + * gprs_ns2_sns: Verify mandatory IE presence in incoming SNS-SIZE + * gprs_ns2_sns: SNS-SIZE contains the actual number of local endpoints + * gprs_ns2_sns: Assume the SGSN has a very large number of max. NSVC + * gprs_ns2_sns: Implement checks during processing of inbound SNS-SIZE + * gprs_ns2_vty: Permit VTY configuration of bind->accept_sns + * gprs_ns2: dynamic NS-VC + NSE creation for IP-SNS in SGSN role + * gprs_ns2_sns: Allow VTY configuration of default binds for IP-SNS + * gprs_ns2: Add comments explaining the nsvc->sns_only field + * gprs_ns2_vc_fsm: In IP-SNS/ALIVE mode, initial state is ALIVE/UNBLOCKED + * gprs_ns2: Actually start Tns-test after SNS-CONFIG creates NS-VC + * gprs_ns2_sns: Compute local endpoints before using them + * gprs_ns2_sns: remove code duplication in create_missing_nsvcs() + * gprs_ns2_sns: Don't create NS-VCs for binds outside the NSE + * gprs_ns2_sns: Fix memory leak when creating ip[46]_local arrays + * sim: Obtain card ATR when opening the card + * sim: Remove 'printf' from library code + * frame_relay: Export osmo_fr_network_free() + * ns2: Dump frame relay state to VTY during "show ns" + * socket: Introduce osmo_sock_set_dscp() to set socket DSCP value + * ns2: Fix setting the DSCP value. + * socket: Introduce osmo_sock_set_priority() helper function + * socket: reduce code duplication, introduce socket_helper_tail() + * socket: QoS support for all our socket init functions + * socket: IPv6 support for osmo_sock_set_dscp() + * gprs_ns2: Fix yet another DSCP vs. TOS mix-up + * gprs_ns2_frgre: Ensure DSCP is sin premitted value range + * ns2: migrate from osmo_sock_set_dscp() to OSMO_SOCK_F_DSCP() + * gprs_ns: Fix another DSCP vs. TOS mistake in old NS code + * ns2: Allow setting the socket priority for a UDP bind + * Fix ipa_ccm_make_id_resp_from_req + * Fix ipa_ccm_make_id_resp_from_req to work at all + * ipa_ccm_make_id_resp: Make it work at all + * ns2: change the 'priority' setting name to 'socket-priority' + * osmo_sock_*_ofd(): Mark OSMO_FD_WRITE on non-blocking connect() + * sim: Add osim_card_{reset,close}() API + * osmo-auc-gen: Permit specifying the SQN in hex (0x12345) format + * copy base64 implementation from mbedtls + * base64: Migrate over to osmocom + * base64: reformat using Lindent to conform to our coding style + * osmo-auc-gen: Print RFC3310 IMS HTTP-AKA style base64 nonce/res + * logging: Change stderr + file target to use non-blocking write + * logging: Avoid memcpy from stack to msgb in _file_output() + * logging: Attempt a synchronous, non-blocking write first (file, stderr) + * rate_ctr: Make it safe to call rate_ctr_init() several times + + [ Daniel Willmann ] + * stats: Ensure that each osmo_stat_item only reports once per interval + * tlv: Fix length returned by t{l16,16l}v_put + * stats_vty: Improve generation of osmo counters + * ns2: Ignore NSVC with data_weight 0 for data + * Aggregate NSVC stats inside the NSE + * ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails + * frame_relay, gprs_ns2_fr: Fix log messages, remove unused struct + + [ Vadim Yanitskiy ] + * utils/osmo-aka-verify: fix swapped CK/IK arguments + * vty/logging: use consistent quiting in warning messages + * vty/logging: ensure consistent '%' prefix for warnings + * vty/logging: logp: properly handle library specific sub-systems + * protocol/gsm_08_58.h: add RSL_CMOD_SP_{GSM4,GSM5,GSM6} + * protocol/gsm_08_58.h: add more 'Channel rate and type' values + * protocol/gsm_08_58.h: add asymmetric CSD data rates + * gsm/abis_nm: add missing NM_OC_IPAC_* value-string entries + * rsl: make rsl_dec_chan_nr() more readable, use RSL_CHAN_NR_MASK + * gsm_08_58.h: add Osmocom specific Bm/Lm CBITs for VAMOS + * gsm_08_58.h: add mask for Osmocom specific VAMOS C-bits + * fsm: cosmetic: fix weird spacing in osmo_fsm_inst_alloc() + * stats_vty: also show rate counter group name (if present) + * bts_features: add feature for BCCH carrier power reduction mode + * fix rsl_chan_nr_str_{buf,c}(): enlarge the buffer size + * utils: remove misleading comments for osmo_hexdump[_nospc]_c() + * utils: introduce osmo_talloc_replace_string_fmt() + * gsm_08_58: extend struct abis_rsl_osmo_temp_ovp_acch_cap + * Revert "Prevent GCR encoder/decoder functions from being used directly" + * gsm/protocol/gsm_44_004.h: fix missing include of 'endian.h' + * gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() + * tests/stats: add VTY transcript tests + * stats: use llist_add_tail() in osmo_stats_reporter_alloc() + * stats: allow configuring reporter's name in the VTY + * stats: cosmetic: print 'stats interval' before the reporters + * stats: don't mark reporter as 'disable' beforehand + * stats: clarify error messages in cfg_no_stats_reporter_{statsd,log} + + [ Neels Hofmeyr ] + * add BTS_FEAT_VAMOS + * deprecate osmo_bts_feature_name(), add osmo_bts_features_desc() + * add osmo_bts_features_names: short BTS feature strings + * RR: add VAMOS channel modes + * RR: add missing Extended TSC Set IE + * gsm48_mr_cfg_from_gsm0808_sc_cfg(): drop bitmask without effect + * fix default_timeout type of osmo_tdef_fsm_inst_state_chg default_timeout + * add RSL_IE_OSMO_TRAINING_SEQUENCE + * add RSL_CMOD_CRT_OSMO_TCH_VAMOS_Bm, RSL_CMOD_CRT_OSMO_TCH_VAMOS_Lm + * fixup for gsm48_chan_mode_to_non_vamos() + * osmo_select_shutdown_request(): allow finishing pending writes on SIGTERM + * add Kc128 to gsm0808 Create Ciphering Command + * gsm0808: add Kc128 to Handover Request + * add fixme: enforce 8 byte length of Kc + * fix api doc of osmo_identifier_sanitize_buf() + * vty 'stats reset': do not reset stat_items + * utils: add osmo_str_to_int() and osmo_str_to_int64() + * add osmo_stat_item_get_group_by_name_idxname() + * CTRL: expose stat_item groups on CTRL + * stat_item: cosmetic: s/desc/group_desc in osmo_stat_item_group_alloc() + * stats_test: assert counter and stat item val counts separately + * refactor stat_item: get rid of FIFO and "skipped" error + * refactor stat_item: report only changed values + * cosmetic: get rid of 3 deprecation warnings + * revisit some calls of strtol(), stroul(), strtoull() + * add osmo_time_cc, moved from osmo-bsc + + [ Eric ] + * kdf: add key derivation functions + * vty: allow flushing + * gsmtap: allow 127.0.0.x local listeners + + [ Michael Iedema ] + * ns2: use same name in ctr_group as stat_item_group + + [ Philipp Maier ] + * control_cmd: fix typo + * vty: make function cmd_range_match() public + * linuxlist: add macro to get last element of a list + * command: fix sourcecode formatting + * codec: add missing osmo_amr_type_name function. + * gsm0503_coding: use ahs tables when encoding ahs codec id + * rsl: add new RSL IE to signal temporary overpower + * bts_features: Add new feature to indicate support for temporary overpower + * gsm_08_58: fix sourcecode formatting + * gsm_08_58: fix sourcecode formatting + + [ Keith ] + * GPRS: Add PDP_TYPE_N_IETF_IPv4v6 + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:08:22 +0100 + libosmocore (1.5.1) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/debian/control b/debian/control index b319132..05d0c02 100644 --- a/debian/control +++ b/debian/control @@ -31,9 +31,9 @@ Multi-Arch: foreign Depends: libosmocodec0 (= ${binary:Version}), libosmocoding0 (= ${binary:Version}), - libosmocore17 (= ${binary:Version}), + libosmocore18 (= ${binary:Version}), libosmogb12 (= ${binary:Version}), - libosmogsm16 (= ${binary:Version}), + libosmogsm17 (= ${binary:Version}), libosmovty9 (= ${binary:Version}), libosmoctrl0 (= ${binary:Version}), libosmosim2 (= ${binary:Version}), @@ -115,7 +115,7 @@ . This package contains the documentation for the libosmocoding library. -Package: libosmocore17 +Package: libosmocore18 Section: libs Architecture: any Multi-Arch: same @@ -129,14 +129,14 @@ (at least) other programs that are developed in the sphere of Free Software / Open Source mobile communication. . - The libosmocore17 library in particular is a collection of common code used in + The libosmocore18 library in particular is a collection of common code used in various sub-projects inside the Osmocom family of projects. Package: libosmocore-doc Architecture: all Section: doc Depends: ${misc:Depends}, - libosmocore17, + libosmocore18, libjs-jquery, libosmocodec-doc, libosmocoding-doc, @@ -183,7 +183,7 @@ . This package contains the documentation for the libosmogb library. -Package: libosmogsm16 +Package: libosmogsm17 Section: libs Architecture: any Multi-Arch: same @@ -207,7 +207,7 @@ Architecture: all Section: doc Depends: ${misc:Depends}, - libosmogsm16, + libosmogsm17, libjs-jquery Description: Documentation for the Osmo GSM utility library This is part of the libosmocore "meta"-library. The libosmocore library diff --git a/debian/libosmocore17.install b/debian/libosmocore18.install similarity index 100% rename from debian/libosmocore17.install rename to debian/libosmocore18.install diff --git a/debian/libosmogsm16.install b/debian/libosmogsm17.install similarity index 100% rename from debian/libosmogsm16.install rename to debian/libosmogsm17.install diff --git a/src/Makefile.am b/src/Makefile.am index 6875aa5..4bda456 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=17:0:0 +LIBVERSION=18:0:0 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS) $(LIBSCTP_CFLAGS) $(LIBMNL_CFLAGS) diff --git a/src/codec/Makefile.am b/src/codec/Makefile.am index 778eb2a..b85749d 100644 --- a/src/codec/Makefile.am +++ b/src/codec/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=2:0:2 +LIBVERSION=3:0:3 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS) AM_CFLAGS = -Wall diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am index b023668..a574f98 100644 --- a/src/coding/Makefile.am +++ b/src/coding/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=1:1:1 +LIBVERSION=1:2:1 AM_CPPFLAGS = \ -I"$(top_srcdir)/include" \ diff --git a/src/ctrl/Makefile.am b/src/ctrl/Makefile.am index a5f191d..807b672 100644 --- a/src/ctrl/Makefile.am +++ b/src/ctrl/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=5:0:5 +LIBVERSION=6:0:6 AM_CFLAGS = -Wall $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS) diff --git a/src/gb/Makefile.am b/src/gb/Makefile.am index 2ccb757..018342c 100644 --- a/src/gb/Makefile.am +++ b/src/gb/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=12:0:0 +LIBVERSION=13:0:1 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall ${GCC_FVISIBILITY_HIDDEN} -fno-strict-aliasing \ diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index b336239..580e397 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=16:0:0 +LIBVERSION=17:0:0 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include $(TALLOC_CFLAGS) AM_CFLAGS = -Wall ${GCC_FVISIBILITY_HIDDEN} diff --git a/src/sim/Makefile.am b/src/sim/Makefile.am index 52f3c6a..a88e341 100644 --- a/src/sim/Makefile.am +++ b/src/sim/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=2:1:0 +LIBVERSION=3:0:1 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -fPIC -Wall $(TALLOC_CFLAGS) diff --git a/src/vty/Makefile.am b/src/vty/Makefile.am index 794b96c..c73dbb2 100644 --- a/src/vty/Makefile.am +++ b/src/vty/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=9:0:0 +LIBVERSION=10:0:1 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia3ac0a36b9e898996f596c6d2787e03cd59bfc11 Gerrit-Change-Number: 26264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:11:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:11:58 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gsm-manuals=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E0=2E18-cec5_=E2=86=92_1=2E2=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 ) Change subject: Bump version: 1.1.0.18-cec5 ? 1.2.0 ...................................................................... Bump version: 1.1.0.18-cec5 ? 1.2.0 Change-Id: Id9167fa8aa474bb6feb349a2dcecb015b2a1d3b4 --- M debian/changelog 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index f19b6d4..8f9668b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,37 @@ +osmo-gsm-manuals-dev (1.2.0) unstable; urgency=medium + + [ Harald Welte ] + * add README.md to describe what this repo is about + * build: Switch from rita -> ftp.osmocom.org + * bibliography: Re-introduce RFC768 (UDP) + * Add new common chapter about QoS, IP DSCP and IEEE 802.1q PCP + * glossary: fix various typos I introduced. + + [ Vadim Yanitskiy ] + * fix tests/Makefile.am: exclude file 'mgcp_extension_osmux.adoc' + * fix missing and/or non-existent linked references + * TRXD: clarify modulation specific length of Soft-/Hard-bits + * TRXD: rework description of the NOPE / IDLE frame indication + * TRXD: generalize description of the 'RFU' ('PAD') field + * TRXD: add documentation for TRXDv2 protocol + * TRXDv2: add primary/shadow classification for VAMOS PDUs + * mncc: do not mention deprecated -m / --mncc-sock options + + [ Alexander Couzens ] + * common/chapters: extend gb/ns2 chapters + + [ Neels Hofmeyr ] + * bib: add reference to 3GPP TS 45.002, for Training Sequence definitions + + [ Oliver Smith ] + * port_numbers: add osmo-pcap-client, -server + * d/patches/build-for-debian8.patch: remove + + [ Pau Espin Pedrol ] + * cs7-config.adoc: Improve doc on default SS7 SCTP addresses + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:18:04 +0100 + osmo-gsm-manuals-dev (1.1.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/26265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Id9167fa8aa474bb6feb349a2dcecb015b2a1d3b4 Gerrit-Change-Number: 26265 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:13:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:13:29 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sip-connector=5Bmaster=5D=3A_Bump_version=3A_1=2E5=2E0=2E8-bd66_=E2=86=92_1=2E6=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/26274 ) Change subject: Bump version: 1.5.0.8-bd66 ? 1.6.0 ...................................................................... Bump version: 1.5.0.8-bd66 ? 1.6.0 Change-Id: I72fa9fdc5c6f1c5cfc6e4cb0b7d0e8ea4557b1ab --- M debian/changelog 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index e147a38..9a6b5e1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,23 @@ +osmo-sip-connector (1.6.0) unstable; urgency=medium + + [ Neels Hofmeyr ] + * fix use-after-free in SIP re-INVITE + * SIP re-INVITE: fix media connection change detection + * SIP re-INVITE: log media connection + + [ Oliver Smith ] + * debian/control: remove dh-systemd build-depend + + [ Keith ] + * MNCC v8: Implement Basic Support for Global Call Reference. + + [ Vadim Yanitskiy ] + * sip: fix memory leak (x_gcr) in send_invite() + * sip: use osmo_{enc,dec}_gcr() from libosmocore + * mncc: rework passing GCR over the MNCC interface + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:52:09 +0100 + osmo-sip-connector (1.5.0) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/26274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I72fa9fdc5c6f1c5cfc6e4cb0b7d0e8ea4557b1ab Gerrit-Change-Number: 26274 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:14:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:14:02 +0000 Subject: =?UTF-8?Q?Change_in_osmo-ggsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E1=2E20-8cbd-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 ) Change subject: Bump version: 1.7.1.20-8cbd-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.1.20-8cbd-dirty ? 1.8.0 Change-Id: I21502c6e0b804237fe9bd8f5579dbabd519d6d51 --- M TODO-RELEASE M debian/changelog M gtp/Makefile.am 3 files changed, 31 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 23c9b6d..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libgtp ADD gtp_ran_info_relay_req, gtp_set_cb_ran_info_relay_ind diff --git a/debian/changelog b/debian/changelog index 29f9d9c..0b73209 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,33 @@ +osmo-ggsn (1.8.0) unstable; urgency=medium + + [ Oliver Smith ] + * doc/examples/Makefile.am: add sgsnemu.conf + * doc/examples/osmo-ggsn-kernel-gtp.cfg: new file + * doc/manuals: describe GTP-U kernel module + * gitignore: add ggsn_vty_reference.xml + + [ Harald Welte ] + * Don't install osmo-ggsn-kernel-gtp.cfg to /etc/osmocom/ + * Don't install sgsnemu.conf to /etc/osmocom/ + * ggsn: Reject PDP CTX ACT for static IP addresses + * vty: Inform user that static IP addresses are not supported + + [ Pau Espin Pedrol ] + * gtp: Update teic_confirmed only on resp success + * gtp: Rework parsing logic of UpdatePdpCtxResponse + * ggsn: Improve logging on incoming DL data packets + * gtp: Improve logging of failing pdp ctx resolution from TEI/TID + * cosmetic: gtpie.c: Fix trailing whitespace + * gtp: constify pointer arg + * gtp: Support tx/rx RAN Information Relay message + * ggsn: Log tun fd write errors + * ggsn: Fix heap-use-after-free during Recovery without associated PDP + * cosmetic: configure.ac: Fix tabulation in line + * Introduce program gtp-echo-responder + * gtp_echo_responder: report invalid chars present in node-feautres cmdline arg as error + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:49:16 +0100 + osmo-ggsn (1.7.1) unstable; urgency=medium [ Harald Welte ] diff --git a/gtp/Makefile.am b/gtp/Makefile.am index 64f63b6..3047485 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -2,7 +2,7 @@ # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html # If major=current-age is increased, remember to update the dh_strip line in debian/rules! -LIBVERSION=7:0:1 +LIBVERSION=8:0:2 lib_LTLIBRARIES = libgtp.la -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/26268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I21502c6e0b804237fe9bd8f5579dbabd519d6d51 Gerrit-Change-Number: 26268 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:14:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:14:38 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sysmon=5Bmaster=5D=3A_Bump_version=3A_0=2E3=2E0=2E3-0d9d_=E2=86=92_0=2E3=2E1?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26273 ) Change subject: Bump version: 0.3.0.3-0d9d ? 0.3.1 ...................................................................... Bump version: 0.3.0.3-0d9d ? 0.3.1 Change-Id: I906f8046b599f2ad6824facfefd9c5cf96adf36d --- M debian/changelog 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 2024e88..f90a056 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,14 @@ +osmo-sysmon (0.3.1) unstable; urgency=medium + + [ Oliver Smith ] + * configure.ac: set -std=gnu11 + * configure: don't turn some warnings into errors + + [ Harald Welte ] + * add README.md on what this repository is about + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:46:05 +0100 + osmo-sysmon (0.3.0) unstable; urgency=medium [ Daniel Willmann ] -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I906f8046b599f2ad6824facfefd9c5cf96adf36d Gerrit-Change-Number: 26273 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:15:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:15:25 +0000 Subject: Change in osmo-pcap[master]: Explicitly depend on required libosmogb In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26266 ) Change subject: Explicitly depend on required libosmogb ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 Gerrit-Change-Number: 26266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 15:15:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:15:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:15:26 +0000 Subject: Change in osmo-pcap[master]: Explicitly depend on required libosmogb In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26266 ) Change subject: Explicitly depend on required libosmogb ...................................................................... Explicitly depend on required libosmogb the spec.in files already stated so expicitly, since some files include osmocom/gprs/*.h. Only some data types from there are used, so there's no need in linking the lib. Even more, doing so makes the build fail because there soft-linking symbols required to be implemented by libosmogb are not implemented here. Related: OS#5311 Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 --- M configure.ac M src/Makefile.am 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index f4c004a..7856522 100644 --- a/configure.ac +++ b/configure.ac @@ -158,6 +158,7 @@ dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) diff --git a/src/Makefile.am b/src/Makefile.am index 17ed4e3..6b887d3 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,5 +1,5 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)/ -AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(PCAP_CFLAGS) $(LIBGNUTLS_CFLAGS) +AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOGB_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(PCAP_CFLAGS) $(LIBGNUTLS_CFLAGS) bin_PROGRAMS = osmo-pcap-client osmo-pcap-server -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989 Gerrit-Change-Number: 26266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:16:05 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:16:05 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-30bc-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26267 ) Change subject: Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb Gerrit-Change-Number: 26267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 15:16:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:16:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:16:17 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-30bc-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26267 ) Change subject: Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 ...................................................................... Bump version: 0.2.0.4-30bc-dirty ? 0.2.1 Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb --- M configure.ac M contrib/osmo-pcap.spec.in M debian/changelog M debian/control 4 files changed, 21 insertions(+), 9 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 7856522..abba918 100644 --- a/configure.ac +++ b/configure.ac @@ -157,10 +157,10 @@ AC_SUBST([PCAP_CFLAGS]) dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) PKG_CHECK_MODULES(LIBGNUTLS, gnutls) diff --git a/contrib/osmo-pcap.spec.in b/contrib/osmo-pcap.spec.in index db2dcf0..d4459b4 100644 --- a/contrib/osmo-pcap.spec.in +++ b/contrib/osmo-pcap.spec.in @@ -29,10 +29,10 @@ %endif BuildRequires: pkgconfig BuildRequires: pkgconfig(gnutls) -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(libzmq) >= 3.2.2 %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 4d9c065..90c0285 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,15 @@ +osmo-pcap (0.2.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * Explicitly depend on required libosmogb + + [ Oliver Smith ] + * README.md: fix typo + * Change default ports of client, server + + -- Pau Espin Pedrol Tue, 16 Nov 2021 13:40:07 +0100 + osmo-pcap (0.2.0) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index 68d38c7..5c65ee8 100644 --- a/debian/control +++ b/debian/control @@ -7,7 +7,7 @@ autotools-dev, libpcap0.8-dev, pkg-config, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), libgnutls28-dev, libzmq3-dev Standards-Version: 3.9.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I345f288218a6459ffbadc5cae9feaf708c2188eb Gerrit-Change-Number: 26267 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:16:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:16:59 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-abis=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E1=2E14-57ff-dirty_=E2=86=92_1=2E2=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26271 ) Change subject: Bump version: 1.1.1.14-57ff-dirty ? 1.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0536137e6221fd322536111dfda6e19d3c57de6c Gerrit-Change-Number: 26271 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 15:16:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:17:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:17:01 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-abis=5Bmaster=5D=3A_Bump_version=3A_1=2E1=2E1=2E14-57ff-dirty_=E2=86=92_1=2E2=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26271 ) Change subject: Bump version: 1.1.1.14-57ff-dirty ? 1.2.0 ...................................................................... Bump version: 1.1.1.14-57ff-dirty ? 1.2.0 Change-Id: I0536137e6221fd322536111dfda6e19d3c57de6c --- M TODO-RELEASE M configure.ac M contrib/libosmo-abis.spec.in M debian/changelog M debian/control M src/Makefile.am 6 files changed, 40 insertions(+), 17 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 8c417cd..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,6 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -update libosmocore dependency to > 1.5.1 for OSMO_SOCK_F_{DSCP,PRIO}() -libosmo-abis new member ipa_client_conn new struct members dscp, priority -libosmo-abis new member ipa_server_link new struct members dscp, priority diff --git a/configure.ac b/configure.ac index 0becff9..d183a05 100644 --- a/configure.ac +++ b/configure.ac @@ -66,10 +66,10 @@ dnl Generate the output AM_CONFIG_HEADER(config.h) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.6.0) PKG_CHECK_MODULES(ORTP, ortp >= 0.22.0) AC_ARG_ENABLE([dahdi], diff --git a/contrib/libosmo-abis.spec.in b/contrib/libosmo-abis.spec.in index 629db97..8add588 100644 --- a/contrib/libosmo-abis.spec.in +++ b/contrib/libosmo-abis.spec.in @@ -27,11 +27,11 @@ BuildRequires: libtool >= 2 BuildRequires: pkgconfig >= 0.20 BuildRequires: xz -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmocodec) >= 1.5.0 -BuildRequires: pkgconfig(ortp) >= 0.22 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmocodec) >= 1.6.0 +BuildRequires: pkgconfig(ortp) >= 0.22.0 BuildRequires: pkgconfig(talloc) %description @@ -59,8 +59,8 @@ License: AGPL-3.0-or-later Group: Development/Libraries/C and C++ Requires: libosmoabis10 = %version -Requires: libosmocore-devel >= 0.3.0 -Requires: libosmogsm-devel >= 0.3.10 +Requires: libosmocore-devel >= 1.6.0 +Requires: libosmogsm-devel >= 1.6.0 %description -n libosmoabis-devel This library contains common/shared code regarding the GSM A-bis diff --git a/debian/changelog b/debian/changelog index 0d69185..e889ba6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,29 @@ +libosmo-abis (1.2.0) unstable; urgency=medium + + [ Keith ] + * Configure E1 pcap file per line + * Log TRAU FSM at INFO not NOTICE + * Fix up vty 'show' commands for E1 line/timeslots + + [ Harald Welte ] + * ipa: Introduce support for user-specific DSCP and priority + * e1_input: Allow (vty) configuration of IP DSCP and socket priority + * trau: Introduce osmo_rtp_socket_set_priority() + + [ Philipp Maier ] + * ipaccess: do not block ipaccess_line_update on failure + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * osmo_ortp: Fix seqno reset to 0 upon ssrc_changed + * e1_input: Fix line not removed from e1inp_line_list when freed + * e1_input: Document e1inp_line_create() + * ipaccess: Allow reconfiguring the ipa line during line_update() + * ipaccess: e1inp_ipa_bts_rsl_connect: Fix memleak recreating ipa_client_conn + * e1inp_input: Fix e1inp_line_clone removing original line from global list when freed + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:18:45 +0100 + libosmo-abis (1.1.1) unstable; urgency=medium * attempt to fix RPM spec file after recent soversion bump diff --git a/debian/control b/debian/control index 4608ad6..3601b43 100644 --- a/debian/control +++ b/debian/control @@ -11,7 +11,7 @@ dh-autoreconf, libdpkg-perl, git, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), pkg-config, libortp-dev Standards-Version: 3.9.7 diff --git a/src/Makefile.am b/src/Makefile.am index 346e67b..96e38b1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,8 +1,8 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ABIS_LIBVERSION=10:0:0 -TRAU_LIBVERSION=6:0:4 +ABIS_LIBVERSION=11:0:1 +TRAU_LIBVERSION=7:0:5 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOE1D_CFLAGS) $(LIBOSMOCODEC_CFLAGS) $(COVERAGE_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0536137e6221fd322536111dfda6e19d3c57de6c Gerrit-Change-Number: 26271 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:17:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:17:48 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-sccp=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E39-484f-dirty_=E2=86=92_1=2E5=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 ) Change subject: Bump version: 1.4.0.39-484f-dirty ? 1.5.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I963499ba9f78924660127312f4469b0781fed805 Gerrit-Change-Number: 26272 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 15:17:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:17:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:17:50 +0000 Subject: =?UTF-8?Q?Change_in_libosmo-sccp=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E39-484f-dirty_=E2=86=92_1=2E5=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 ) Change subject: Bump version: 1.4.0.39-484f-dirty ? 1.5.0 ...................................................................... Bump version: 1.4.0.39-484f-dirty ? 1.5.0 Change-Id: I963499ba9f78924660127312f4469b0781fed805 --- M contrib/libosmo-sccp.spec.in M debian/changelog M debian/control R debian/libosmo-sigtran7.install M debian/rules M src/Makefile.am 6 files changed, 69 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/contrib/libosmo-sccp.spec.in b/contrib/libosmo-sccp.spec.in index f792f69..133d4a9 100644 --- a/contrib/libosmo-sccp.spec.in +++ b/contrib/libosmo-sccp.spec.in @@ -71,19 +71,19 @@ This subpackage contains the development files for the Osmocom SCCP library. -%package -n libosmo-sigtran5 +%package -n libosmo-sigtran7 Summary: Osmocom SIGTRAN library License: GPL-2.0-or-later Group: System/Libraries -%description -n libosmo-sigtran5 +%description -n libosmo-sigtran7 Osmocom implementation of (parts of) SIGTRAN. %package -n libosmo-sigtran-devel Summary: Development files for the Osmocom sigtran library License: GPL-2.0-or-later Group: Development/Libraries/C and C++ -Requires: libosmo-sigtran5 = %{version} +Requires: libosmo-sigtran7 = %{version} %description -n libosmo-sigtran-devel Osmocom implementation of (parts of) SIGTRAN. @@ -136,8 +136,8 @@ %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) -%post -n libosmo-sigtran5 -p /sbin/ldconfig -%postun -n libosmo-sigtran5 -p /sbin/ldconfig +%post -n libosmo-sigtran7 -p /sbin/ldconfig +%postun -n libosmo-sigtran7 -p /sbin/ldconfig %if 0%{?suse_version} %preun -n osmo-stp %service_del_preun osmo-stp.service %postun -n osmo-stp %service_del_postun osmo-stp.service @@ -159,8 +159,8 @@ %{_libdir}/libsccp.a %{_libdir}/pkgconfig/libosmo-sccp.pc -%files -n libosmo-sigtran5 -%{_libdir}/libosmo-sigtran.so.5* +%files -n libosmo-sigtran7 +%{_libdir}/libosmo-sigtran.so.7* %files -n libosmo-sigtran-devel %dir %{_includedir}/%{name} diff --git a/debian/changelog b/debian/changelog index 57964a9..a2500b3 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,58 @@ +libosmo-sccp (1.5.0) unstable; urgency=medium + + [ Harald Welte ] + * Add README.md describing what this repo is about + * ipa: Use VTY-configured default network indicator + * ipa_asp_fsm_del_route(): Log what happens if we bail out early + * don't log "SCTP connection close" if an IPA/TCP connection closes + * osmo_ss7: Log route destruction (like we log route creation) + * ipa_asp_fsm: Fix AS lookup from IPA ASP + * Don't create duplicate routes in osmo_ss7_route_create() + * ipa: Move automatic route add/del from ASP to AS level + * osmo_ss7: Truncate route 'mask' to point code bit length + * xua_as_fsm: Only delete a route for an IPA AS if we created one earlier + * xua_asp_fsm: Fix IPA client role + * don't do explicit NULL checks before calling talloc_free() + * osmo_ss7: free the sock_name string once an ASP socket is closed + * Revert "osmo_ss7: free the sock_name string once an ASP socket is closed" + * ss7_vty: Print actual connected port number in case of IPA server + * Constrain connection ID allocation to 24 bits + * ss7_asp_test.vty: Allow more asp node commands after shutdown + * osmo_ss7: introduce notion of configurable 'quirks' + * m3ua/sua: Add quirk for allowing inbound DAUD from SG in ASP role. + * m3ua/sua: Add new snm_inactive quirk + * sccp_scrc: Ensure we have not just SSN but at least OPC+SSN in CallingParty + * sccp: Add minimalistic support for XUDT / XUDTS + * sccp_scmg: Add missing line eneding to log statement + * stp: Add basic RX/TX rate counters on AS and ASP level + * spelling fixes in comments + * rate_ctr: Use legal counter group prefixes / names (no '.' allowed) + * osmo_ss7: properly unlink rate_counter on AS/ASP free + + [ Vadim Yanitskiy ] + * VTY: write_one_asp(): fix 1 << 31 cannot be represented by 'int' + + [ Pau Espin Pedrol ] + * cosmetic: xua_asp_fsm.c: reorder functions in file + * ipa_asp_fsm: Support server starting handshake with ID_GET or ID_ACK + * cosmetic: Fix extra empty line + * cosmetic: Fix typos in documentation + * osmo_sccp_simple_client_on_ss7_id(): Allow set internally proper IPv4/v6 default hosts + * osmo_ss7.c: Fix typo in doc for osmo_ss7_asp_peer_add_host() + + [ Philipp Maier ] + * osmo_ss7_vty: automatically create routes for routing key + * osmo_ss7_vty: allow users to inspect routes also in ASP role + + [ Eric ] + * m3ua: fix leaky usage of m3ua_tx_xua_asp + + [ Oliver Smith ] + * m3ua: reject deregistration of static routing keys + * m3ua: fix m3ua_encode_dupu + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:44:42 +0100 + libosmo-sccp (1.4.0) unstable; urgency=medium [ Vadim Yanitskiy ] diff --git a/debian/control b/debian/control index b12e247..7955055 100644 --- a/debian/control +++ b/debian/control @@ -34,7 +34,7 @@ . This package contains the development files for the library. -Package: libosmo-sigtran5 +Package: libosmo-sigtran7 Section: libs Architecture: any Multi-Arch: same @@ -53,7 +53,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-sigtran5 (= ${binary:Version}), +Depends: libosmo-sigtran7 (= ${binary:Version}), ${misc:Depends} Description: Documentation for the Osmocom SIGTRAN library libosmo-sigtran is a shared library containing SS7/SIGTRAN related functionality, @@ -68,7 +68,7 @@ Architecture: all Section: doc Depends: ${misc:Depends}, - libosmo-sigtran5 (= ${binary:Version}), + libosmo-sigtran7 (= ${binary:Version}), libjs-jquery Description: Documentation for the Osmocom SIGTRAN library libosmo-sigtran is a shared library containing SS7/SIGTRAN related functionality, @@ -83,7 +83,7 @@ Multi-Arch: same Section: libdevel Depends: ${misc:Depends}, - libosmo-sigtran5 (= ${binary:Version}), + libosmo-sigtran7 (= ${binary:Version}), libosmocore-dev, libosmo-netif-dev Description: Development headers for the Osmocom SIGTRAN library @@ -98,7 +98,7 @@ Architecture: any Multi-Arch: same Section: net -Depends: libosmo-sigtran5, +Depends: libosmo-sigtran7, ${shlibs:Depends}, ${misc:Depends} Description: Osmocom SIGTRAN STP (Signaling Transfer Point) diff --git a/debian/libosmo-sigtran5.install b/debian/libosmo-sigtran7.install similarity index 100% rename from debian/libosmo-sigtran5.install rename to debian/libosmo-sigtran7.install diff --git a/debian/rules b/debian/rules index 9c27539..8ad38cf 100755 --- a/debian/rules +++ b/debian/rules @@ -12,7 +12,7 @@ dh $@ --with autoreconf override_dh_strip: - dh_strip -plibosmo-sigtran5 --dbg-package=libosmo-sigtran-dbg + dh_strip -plibosmo-sigtran7 --dbg-package=libosmo-sigtran-dbg dh_strip -posmo-stp --dbg-package=osmo-stp-dbg override_dh_install: diff --git a/src/Makefile.am b/src/Makefile.am index 9d5e9a3..e2273e1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -25,7 +25,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=6:0:1 +LIBVERSION=7:0:0 libosmo_sigtran_la_SOURCES = sccp_sap.c sua.c m3ua.c xua_msg.c sccp_helpers.c \ sccp2sua.c sccp_scrc.c sccp_sclc.c sccp_scoc.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I963499ba9f78924660127312f4469b0781fed805 Gerrit-Change-Number: 26272 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:19:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:19:00 +0000 Subject: =?UTF-8?Q?Change_in_osmo-hlr=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E7-bfee_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26275 ) Change subject: Bump version: 1.3.0.7-bfee ? 1.4.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I39bbc42009bf6291884f652618bfdf94b329a295 Gerrit-Change-Number: 26275 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 15:19:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:19:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:19:02 +0000 Subject: =?UTF-8?Q?Change_in_osmo-hlr=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E7-bfee_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26275 ) Change subject: Bump version: 1.3.0.7-bfee ? 1.4.0 ...................................................................... Bump version: 1.3.0.7-bfee ? 1.4.0 Change-Id: I39bbc42009bf6291884f652618bfdf94b329a295 --- M debian/changelog 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 0ac618d..c8f93ae 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,24 @@ +osmo-hlr (1.4.0) unstable; urgency=medium + + [ Keith ] + * Correct configuration written from vty + * vty: enable show subscribers filtered by IMEI + + [ Harald Welte ] + * add README.md file as customary for cgit, github, gitlab, etc. + + [ Oliver Smith ] + * Add post-upgrade script for automatic db upgrade + * debian/control: remove dh-systemd build-depend + + [ Pau Espin Pedrol ] + * db: Avoid use uninitialized rc if running 0 statements + + [ Neels Hofmeyr ] + * db v6: determine 3G AUC IND from VLR name + + -- Pau Espin Pedrol Tue, 16 Nov 2021 14:56:41 +0100 + osmo-hlr (1.3.0) unstable; urgency=medium [ Alexander Couzens ] -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I39bbc42009bf6291884f652618bfdf94b329a295 Gerrit-Change-Number: 26275 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:27:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:27:41 +0000 Subject: =?UTF-8?Q?Change_in_osmo-trx=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E1=2E28-019d-dirty_=E2=86=92_1=2E4=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/26279 ) Change subject: Bump version: 1.3.1.28-019d-dirty ? 1.4.0 ...................................................................... Bump version: 1.3.1.28-019d-dirty ? 1.4.0 Change-Id: Ie675909593b0c383b59b7b4a4edd46cd93283622 --- M TODO-RELEASE M configure.ac M contrib/osmo-trx.spec.in M debian/changelog M debian/control 5 files changed, 49 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/79/26279/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index ab54c42..e69de29 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1 +0,0 @@ -libosmocore > 1.5.1 require APIs osmo_stat_item_group_get_item, rate_ctr_group_get_ctr diff --git a/configure.ac b/configure.ac index 5706a39..422ad65 100644 --- a/configure.ac +++ b/configure.ac @@ -82,10 +82,10 @@ AC_HEADER_TIME AC_C_BIGENDIAN -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.6.0) AC_ARG_ENABLE(sanitize, [AS_HELP_STRING( diff --git a/contrib/osmo-trx.spec.in b/contrib/osmo-trx.spec.in index b80d8e2..3550aaf 100644 --- a/contrib/osmo-trx.spec.in +++ b/contrib/osmo-trx.spec.in @@ -34,10 +34,10 @@ BuildRequires: pkgconfig(usrp) >= 3.3 %endif BuildRequires: pkgconfig(fftw3f) -BuildRequires: pkgconfig(libosmocoding) >= 1.5.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocoding) >= 1.6.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(libusb-1.0) BuildRequires: pkgconfig(uhd) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 019fdf8..a6f6b70 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,43 @@ +osmo-trx (1.4.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Threads.cpp: Fix missing extern C around libosmocore include + * Drop logging pthread ID + * Threads: Avoid printing pthread_self() + * ipc: Makefile.am: Clean LDADD variable + * Use new stat item/ctr getter APIs + * detectBurst(): Clear downsampling code path + * detectBurst(): constify parameter + * computeCI(): Constify param and pass it as reference + * computeCI(): Rename verbose repeated getter to constant + * computeCI(): Constify read-only variable + * detectGeneralBurst(): Increase log level about clipping to INFO + * cosmetic: Fix typo in comment + * computeCI: Document hardcoded multiplier + * lms: Drop duplicated check + * lms,uhd: Validate band of RxFreq too + * lms,uhd: Skip re-assigning same band + * lms,uhd: Allow changing band between poweroff & poweron + + [ Vadim Yanitskiy ] + * gitignore: remove non-existing 'doc/manuals/osmomsc-usermanual.xml' + * ctrl_sock_handle_rx(): fix missing space in LOGCHAN() statement + * trx_rate_ctr: use thread safe strerror() in device_sig_cb() + * IPCDevice: use thread safe strerror_r() instead of strerror() + * IPCDevice: check value returned from select() + * LMSDevice: LMS_GetDeviceList() may return a negative number + + [ Eric ] + * add hidden fn adjustment command + * uhd: ensure configured clock source is actually used + * vty: printing fn offset should be signed + * lms: init band + + [ Oliver Smith ] + * d/patches/build-for-debian8.patch: remove + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:27:26 +0100 + osmo-trx (1.3.1) unstable; urgency=medium * mark uhddev_ipc.cpp as BUILT_SOURCES diff --git a/debian/control b/debian/control index d1532f2..16709f8 100644 --- a/debian/control +++ b/debian/control @@ -14,7 +14,7 @@ libtalloc-dev, libusrp-dev, liblimesuite-dev, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), osmo-gsm-manuals-dev Standards-Version: 3.9.6 Vcs-Browser: http://cgit.osmocom.org/osmo-trx -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie675909593b0c383b59b7b4a4edd46cd93283622 Gerrit-Change-Number: 26279 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:38:50 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 15:38:50 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26280 ) Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... cards: select_adf_by_aid: split off aid completion The function select_adf_by_aid first searches for the complete AID in the set of AIDs that were read from EF.DIR. Lets put this task into a separate helper method Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 --- M pySim/cards.py 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/80/26280/1 diff --git a/pySim/cards.py b/pySim/cards.py index 8f5004e..70c3956 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -278,13 +278,13 @@ self._aids = [] return self._aids - def select_adf_by_aid(self, adf="usim"): - """Select ADF.U/ISIM in the Card using its full AID""" + def _complete_aid(self, adf="usim"): + """find the complete version of an ADF.U/ISIM AID""" # Find full AID by partial AID: if is_hex(adf): for aid in self._aids: if len(aid) >= len(adf) and adf == aid[0:len(adf)]: - return self._scc.select_adf(aid) + return aid # Find full AID by application name: elif adf in ["usim", "isim"]: # First (known) halves of the U/ISIM AID @@ -293,7 +293,14 @@ aid_map["isim"] = "a0000000871004" for aid in self._aids: if aid_map[adf] in aid: - return self._scc.select_adf(aid) + return aid + return None + + def select_adf_by_aid(self, adf="usim"): + """Select ADF.U/ISIM in the Card using its full AID""" + aid = _complete_aid(self, adf="usim") + if aid: + return self._scc.select_adf(aid) return (None, None) def erase_binary(self, ef): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:40:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:40:41 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bts=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E348-f42287-dirty_=E2=86=92_1=2E4=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26281 ) Change subject: Bump version: 1.3.0.348-f42287-dirty ? 1.4.0 ...................................................................... Bump version: 1.3.0.348-f42287-dirty ? 1.4.0 Change-Id: Ibf3ce0bfd0cf67148229dd988ebde6e6b8d744cc --- M TODO-RELEASE M configure.ac M contrib/osmo-bts.spec.in M debian/changelog M debian/control 5 files changed, 391 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/81/26281/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index aa0b2fd..6b2de14 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,6 +1,2 @@ # When cleaning up this file: bump API version(s) in the following files: # configure.ac, debian/control, and contrib/osmo-bts.spec.in. -update libosmo-abis dependency to > 1.1.1 for osmo_rtp_socket_set_priority() -update libosmo-abis dependency to > 1.1.1 for new e1_input vty commands for DSCP + priority -update libosmocore dependency to > 1.5.1-73-g524b4f80 for osmo_bts_features_desc() -update libosmocore dependency to > 1.5.1-133-g09f075fa for name in (struct rate_ctr_group) diff --git a/configure.ac b/configure.ac index 91fe244..8e3a44c 100644 --- a/configure.ac +++ b/configure.ac @@ -69,14 +69,14 @@ fi dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.2.0) AC_MSG_CHECKING([whether to enable support for sysmobts calibration tool]) AC_ARG_ENABLE(sysmobts-calib, diff --git a/contrib/osmo-bts.spec.in b/contrib/osmo-bts.spec.in index a6d5e86..5fed7d6 100644 --- a/contrib/osmo-bts.spec.in +++ b/contrib/osmo-bts.spec.in @@ -27,14 +27,14 @@ %if 0%{?suse_version} BuildRequires: systemd-rpm-macros %endif -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocodec) >= 1.5.0 -BuildRequires: pkgconfig(libosmocoding) >= 1.5.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmotrau) >= 1.1.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocodec) >= 1.6.0 +BuildRequires: pkgconfig(libosmocoding) >= 1.6.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmotrau) >= 1.2.0 ### FIXME: DependencyHACK to include osmocom/gprs/protocol/gsm_04_60.h BuildRequires: pkgconfig(libosmogb) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index bc44837..3ad028b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,375 @@ +osmo-bts (1.4.0) unstable; urgency=medium + + [ Philipp Maier ] + * l1sap: Store status of SRR in an lchan struct memeber + * l1sap: add logging and VTY introspection for ACCH repetition + * sched_lchan_tchh: fix frame number and fill FACCH gap + * main,abis: change model name from sysmoBTS to osmo-bts + * paging: prioritize CS related paging over PS related pagings. + * allow to configure multiple oml remote-ip addresses + * sched_lchan_tch_x: do not use cmr as ft + * sched_lchan_tch_x: use functions to determine AMR tranmssion phase + * sched_lchan_tch_x: use ul_cmr and ul_ft when generating RTP bad frame + * rsl: simplfy parse_repeated_acch_capability + * rsl: parse temporary overpower value RSL CHAN ACT / MODIFY + + [ Vadim Yanitskiy ] + * doc/examples: remove obsolete power control parameters + * doc/examples: enable stderr logging for osmo-bts-virtual.cfg + * osmo-bts-trx: fix: do not call trx_if_close() two times + * osmo-bts-trx: fix segfault on trx_phy_inst_open() failure + * l1sap: use the passed 'trx' pointer in l1sap_chan_act() + * l1sap: use TLVP_PRES_LEN() macro in l1sap_chan_act() + * l1sap: check BTS_FEAT_MULTI_TSC in l1sap_chan_act() + * l1sap: fix wrong IEI and parsing in l1sap_chan_act() + * manuals: fix wrong VTY node for 'gsmtap-sapi' command + * manuals: document GSMTAP 'enable-all' / 'disable-all' + * osmo-bts-trx: correct definition of 'osmotrx rx-gain' command + * rsl: do not blindly ignore unhandled/unknown Channel Mode + * manuals: remove deprecated command line parameters + * manuals: document new 'gsmtap-remote-host' command + * l1sap: fix incorrect pointer cast in l1sap_chan_act() + * rsl: rename, fix and refactor lchan_tchmode_from_cmode() + * rsl: add missing Channel Mode values to rsl_handle_chan_mod_ie() + * lchan2lch_par(): fix missing default branch in switch + * osmo-bts-trx: cosmetic: TRXD 'header version' -> 'PDU version' + * osmo-bts-trx: remove outdated TRXD protocol documentation + * osmo-bts-trx: cosmetic: use '#pragma once' in trx_if.h + * osmo-bts-trx: define TRXC/TRXD message buffer size + * osmo-bts-trx: 'burst type' is actually modulation type + * osmo-bts-trx: move MTS parser into trx_data_parse_mts() + * osmo-bts-trx: discard TRXD PDUs with unexpected version + * osmo-bts-trx: move TDMA frame number check to trx_data_read_cb() + * osmo-bts-trx: cosmetic: get rid of TRX_CHDR_LEN macro + * osmo-bts-trx: generalize checking of TRXD header length + * osmo-bts-trx: pass 'struct phy_instance' to TRXD dissectors + * osmo-bts-trx: refactor handling of version specific TRXD parts + * osmo-bts-trx: enlarge and share TRXD message buffer + * osmo-bts-trx: assert PDU version in trx_if_send_burst() + * osmo-bts-trx: reduce code nasting in trx_if_send_burst() + * vty: fix the use of deprecated osmo_bts_feature_name() + * common/abis: fix the use of deprecated e1inp_line_get() API + * osmo-bts-trx: refactor parse_rsp(), fix compilation warnings + * rsl: fix wrong value printed in rsl_handle_chan_mod_ie() + * struct gsm_bts_trx: remove unused leftovers from openbsc + * common/sysinfo: make struct gsm_bts_trx const in num_agch() + * osmo-bts-{lc15,oc2g}: drop redundant checks in VTY commands + * [VAMOS] struct gsm_bts_trx: fix the PHY instance pointer + * [VAMOS] Merge bts_trx_init() into gsm_bts_trx_alloc() + * [VAMOS] osmo-bts-trx: move {chan,bid} to trx_{dl,ul}_burst_{req,ind} + * osmo-bts-trx: implement TRXDv2 protocol support + * scheduler.h: cosmetic: use #pragma once + * osmo-bts-trx: cosmetic: s/trx_sched_fn/bts_sched_fn/g + * osmo-bts-trx: remove redundant assert() in bts_sched_fn() + * osmo-bts-trx: fix hopping pointer bug in bts_sched_fn() + * [VAMOS] Re-organize osmo-bts-trx specific structures + * osmo-bts-trx: clarify logging messages in trx_if_{open,close}() + * osmo-bts-{trx,virtual}: fix: pinst->trx may be NULL + * common: make the arguments of phy_{link,instance}_name() const + * [VAMOS] common: make 'struct gsm_bts_trx_ts' pointers const + * [VAMOS] gsm_data.h: fix wrong bit-mask in BSIC2BCC macro + * [VAMOS] gsm_data.h: introduce and use BTS_TSC macro + * common: phy_links_open(): warn about dangling PHY instances + * [VAMOS] osmo-bts-trx: rework and split up bts_sched_fn() + * Fix regression in 'osmo-bts-trx: rework and split up bts_sched_fn()' + * [VAMOS] osmo-bts-trx: implement and enable PDU batching for TRXDv2 + * [VAMOS] osmo-bts-trx: indicate MTS in Downlink TRXDv2 PDUs + * [VAMOS] rsl_rx_mode_modif(): handle Channel Identification IE + * [VAMOS] rsl: call bts_supports_cm() from rsl_handle_chan_mod_ie() + * [VAMOS] bts_supports_cm(): handle RSL_CMOD_CRT_OSMO_TCH_VAMOS_{Bm,Lm} + * [VAMOS] common/scheduler: unify symbol names for training sequences + * [VAMOS] osmo-bts-trx: rework handling of Training Sequence + * [VAMOS] osmo-bts-trx: properly handle per-timeslot TSC values + * [VAMOS] scheduler: add new GMSK training sequences from 3GPP 45.002 + * [VAMOS] l1sap_chan_act(): handle Osmocom specific TSC IE + * [VAMOS] common/oml: generalize checking BTS_FEAT_MULTI_TSC + * [VAMOS] gsm_pchan2chan_nr(): use ABIS_RSL_CHAN_NR_CBITS_* macros + * [VAMOS] rsl_lchan_lookup(): use ABIS_RSL_CHAN_NR_CBITS_* macros + * [VAMOS] rsl_lchan_lookup(): make it more readable + * [VAMOS] gsm_data: rework and rename gsm_lchan_name_compute() + * [VAMOS] l1sap: get_lchan_by_chan_nr() may return NULL + * [VAMOS] oml_rx_set_chan_attr(): clarify NM_ATT_CHAN_COMB handling + * manuals/abis/rsl.adoc: s/TS 08.58/TS 48.058/ + * manuals/abis/rsl.adoc: rework Channel Number description + * manuals/abis/rsl.adoc: add missing CBCH Channel Number values + * manuals/abis/rsl.adoc: add VAMOS specific Channel Number values + * osmo-bts-trx: fix NULL pointer dereference in trx_if_send_burst() + * trx_sched_is_sacch_fn(): fix handling of dynamic timeslots + * [VAMOS] scheduler: drop meaningless channel number checks + * [VAMOS] conf_lchans_as_pchan(): improve readability + * [VAMOS] Implement the concept of 'shadow' timeslots + * [VAMOS] osmo-bts-trx: schedule bursts on 'shadow' timeslots + * l1sap: fix TDMA frame number wrap in l1sap_info_time_ind() + * conf_lchans_as_pchan(): fix GSM_LCHAN_{CCCH->CBCH} regression + * conf_lchans_as_pchan(): initialize all lchans with GSM_LCHAN_NONE + * measurement: remove over-defensive checks in is_meas_complete() + * [VAMOS] trx_sched_init_ts(): assign names to per-timeslot counters + * common/vty: facilitate finding duplicate PHY/TRX associations + * vty: ensure all warning messages are prefixed with '%%' + * osmo-bts-octphy: drop talloc_replace(), use osmo_talloc_replace_string() + * l1sap: fix TDMA frame number arithmetic in fn_ms_adj() + * osmo-bts-trx: fix typo: s/bisc/bsic/ in 'show transceiver' + * osmo-bts-trx: fix copy-pasted comment: s/sysmoBTS/osmo-bts-trx/ + * oml: fix handling of NM_ATT_INTERF_BOUND attribute + * Report interference levels in RSL RF RESource INDication + * scheduler: reorder enum trx_chan_type, add TRX_CHAN_IS_DEDIC() + * osmo-bts-trx: report interference levels to the upper layers + * osmo-bts-{trx,virtual}: get rid of dummy tx_idle_fn() + * scheduler: unset TRX_CHAN_FLAG_AUTO_ACTIVE for TRXC_IDLE + * osmo-bts-trx: print timeslot brief info in 'show transceiver' + * osmo-bts-trx: measure interference levels on TRXC_IDLE + * osmo-bts-trx: report PDCH interference levels to the PCU + * scheduler: fix wrong union field in trx_sched_tch_req() + * scheduler: fix: use ts_pchan() in trx_sched_set_cipher() + * Revert "power_control: BS power shall not be reduced on C0" + * osmo-bts-omldummy: indicate BTS_FEAT_BCCH_POWER_RED as supported + * osmo-bts-trx: implement BCCH carrier power reduction mode + * power_control: constrain BS power reduction on BCCH carrier + * manuals/abis/rsl.adoc: clarify RF Resource Indication conformance + * rsl: use tlvp_val16be() in rsl_rx_ipac_XXcx() + * gsm_lchan_interf_meas_calc_band(): also print number of AVG samples + * osmo-bts-trx: send dummy FACCH in the absense of RTP frames + * osmo-bts-trx: return -ENODEV if 'bursts_p' is NULL + * l1sap: unify channel (de)activation/modification messages + * gsm_lchan2chan_nr(): separate RSL specific variant of this API + * osmo-bts-trx: bts_model_l1sap_down(): remove chan_nr patching + * trx_sched_set_lchan(): use LOGL_INFO for logging messages + * osmo-bts-trx: remove an 'else' branch in _sched_dl_burst() + * osmo-bts-trx: implement Temporary Overpower for SACCH/FACCH + * scheduler: fix comments explaining the interleaving of TCH/H + * fix handle_ms_meas_report(): properly count measurement reports + * abis: fix memory leak in abis_oml_sendmsg() + * rsl: remove redundant logging in rsl_rx_chan_activ() + * .gitignore: add tests/amr/amr_test + * rsl: prevent race condition during timeslot re-configuration + * rsl_tx_rf_res(): separate interference AVG / band calculation + * rsl_tx_rf_res(): also report noise levels for PDTCH + * osmo-bts-trx: report PDCH interference levels to L1SAP + * l1sap: check if BTS model supports interference reporting + * vty: show interference level / band in 'show lchan' + * trx_sched_clean_ts(): also free() the associated 'struct l1sched_ts' + * trx_sched_clean(): also free() the shadow timeslot + * osmo-bts-trx: refactor 'maxdly' / 'maxdlynb' commands + * rsl: rsl_tx_meas_res() does not change l3, make it const + * rsl: send NACK if BTS_FEAT_ACCH_REP is not supported + * measurement: handle_ms_meas_report() accepts const gh + * measurement: move repeated_dl_facch_active_decision() here + * measurement: make sure that DL measurements are valid + * cosmetic: s/repeated_acch_capability/rep_acch_cap/g + * struct gsm_lchan: group ACCH repetition state fields + * struct gsm_lchan: move tch.rep_facch to rep_acch.dl_facch + * measurement: fix wrong operator used in handle_ms_meas_report() + * osmo-bts-trx: fix potential NULL pointer dereference + * lchan_set_state(): also free pending messages if any + * lchan: introduce and use lchan_is_tch() helper + * [overpower] rsl: store full content of RSL_IE_OSMO_TEMP_OVP_ACCH_CAP + * [overpower] lchan_dump_full_vty(): print overpower state + * [overpower] scheduler: handle {sacch,facch}_enabled flags + * l1sap: fix handling of lchan->pending_rel_ind_msg + * l1sap: move false PTCCH/U detection into PDCH branch + * l1sap: use designated initializers in process_l1sap_meas_data() + * l1sap: process_l1sap_meas_data() accepts pointer to lchan + * l1sap: make 'l1sap' argument of process_l1sap_meas_data() const + * rsl: fix a memory leak in handle_gprs_susp_req() + * l1sap: rework handling of DATA.ind on SACCH + * lchan_meas_handle_sacch(): check if Measurement Result is valid + * measurement: get rid of *le in lchan_meas_handle_sacch() + * measurement: pass *mr to repeated_dl_facch_active_decision() + * measurement: pass *mr to lchan_bs_pwr_ctrl() + * [overpower] Turn it on and off depending on DL RxQual + * measurement: make use of gsm48_meas_res_is_valid() + * common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} + * rsl: exclude disabled timeslots from interference reports + * oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() + * gsm_lchan_interf_meas_calc_avg(): fix band calculation + + [ Pau Espin Pedrol ] + * l1sap: Transmit pdtch invalid MAC blocks to PCU + * bts-trx: Always submit rx PDTCH DATA.ind to l1sap + * bts-trx: Avoid submitting first data_ind with FN=0 to upper layers + * bts-trx: Drop duplicate set of last_clk_ind + * bts-trx: reorder first timerfd schedule to decrease first timeout skew + * sysmo,oc2g,lc15: Make RadioChannel MO depend on RadioCarrier MO + * bts: Clean up TS selection in sign_link_up + * Fix regression in 'bts: Clean up TS selection in sign_link_up' + * Add missing value_string for NM_EV_* introduced recently + * pcuif: Set missing bsic field during Tx of info_ind + * Use new stat item/ctr getter APIs + * rsl: Use switch statement in rsl_rx_bcch_info() + * pcu_sock: Transmit SI2 + * doc: rsl.adoc: Fix trailing whitespace + * gsm_data: Drop unused function gsm_pchan_parse() + * pcuif_proto.h: Add new container messages + * Support forwarding proto IPAC_PROTO_EXT_PCU BSC<->PCU + * Rename osmo dyn ts enums to contain SDCCH8 + * Support SDCCH8 in osmo dyn ts + * Make gcc 11.1.0 false positivies happy + * rsl: Fix rx of multiple RSL_IPAC_EIE_MEAS_AVG_CFG IEs + * rsl: Support parsing up to 3 RSL_IPAC_EIE_MEAS_AVG_CFG IEs + * MS Power Control Loop: Take C/I into account + * MS Power Control Loop: Support EWMA algorithm for C/I measurements + * MS Power Control Loop: Improve logging + * BS Power Control Loop: refactor lchan_bs_pwr_ctrl() to look similar to lchan_ms_pwr_ctrl() + * BS Power Control Loop: Support EWMA average algo for RxQual meas + * BS Power Control Loop: Increase attenuation if RxQual is better than upper threshold + * MS/BS Power Control Loop: Do RxLEV meas avg & delta calculations directly on RxLevels + * MS/BS Power Control Loop: Fix downscaling averaging bug + * Power Control Loop: Move skip loop logic to function helper + * comsetic: measurement.c: fix typo in comment + * l1sap: Take L1SACCH MS_PWR from bitfield instead of manual parsing + * TA loop: Take into account UL SACCH 'Actual Timing advance' field + * ta_control: Allow switching TA quicker + * lchan: Move TA CTRL param to its own substruct + * MS Power Control Loop: Feed UL RSSI from correct measurement period + * MS Power Control Loop: Feed UL C/I from correct measurement period + * TA Control Loop: Change toa256 switch threshold to 75% of a symbol + * Power Control Loop: Set P_CON_INTERVAL to 1 by default + * Support configuring TA loop SACCH block rate + * MS Power Control Loop: Fix sub vs full being passed to algo + * abis: Clear code and drop code not executed + * abis.h: Drop unused state + * cosmetic: fix typo in comment + * abis.c: Rearrange code to follow logic state order + * abis.c: Convert early return to assert() + * power_control: Drop unused param in function + * tests: MS Power Control Loop: Show oscillation among good power levels + * cosmetic: Fix formatting of conditional operator + * abis: Move FSM registration to constructor function + * abis: Shorten string names of events + * abis.c: Transition to CONNECTED state only when OML link is up + * abis.c: Fix mess with priv->bsc_oml_host + * abis.c: Loop over list of BSCs until connection succeeds + * trx_provision_fsm: Add missing state transition OPEN_WAIT_POWEROFF_CNF => OPEN_POWEROFF + * nm_*_fsm: Add missing item in event mask list for state ENABLED + * Allow setting administrative state through oml_mo_state_chg() + * nm_*_fsm: Set adminsitrative state 'shutting down' when shutdown procedure starts + * MS Power Control Loop: Fix oscillations within good MS Power Levels + * nm_*_fsm: Move to state Disabled NotInstalled Locked when shtudown proc ends + * abis: Drop internal OML msg queue + * nm_*fsm: Make FSMs aware of object being properly configured or not + * bts_shutdown_fsm: Fix event name + * trx_if: Set pointer to null after freeing it + * trx_if: Allow calling trx_if_flush/close from within TRXC callback + * trx_if: delete retrans timer when flushing the Tx queue + * trx_provision_fsm: Properly reset FSM state upon starting listening for events + * bts-trx: Submit TRX_PROV_EV_CFG_ARFCN for C0 during SetBtsAttr + * bts-trx: Get rid of check_transceiver_availability_trx() + * MS Power Control Loop: Disable threshold comparison on {LOWER,UPPER}_CMP_N=0 + * l1sap: Support rx of empty rlcmac blocks from PCU + * bts-trx: Avoid race condition configuring TS-specific TSC values + * bts-trx: Submit TRX SW_ACT when PHY becomes connected + * trx_sched_clean_ts: Clean VAMOS shadow TS too + * phy_link: Introduce bts_model_phy_link_close() and use it in bts-trx + * nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it + * bts_shutdown_fsm: Allow configuring FSM to shutdown without exiting process + * abis: Call bts_model_abis_close() when Abis link goes down + * bts_trx: Drop non-executed path in trx_link_estab() + * Avoid sending Load Indications when BTS is not RSL-connected + * abis: Fix memory leak of bts->osmo_link upon link going down + * abis: Fix line leaked & recreated upon every reconnect + * bts-trx: Keep the process ongoing trying to reconnect on Abis link down + * Revert "bts-trx: Keep the process ongoing trying to reconnect on Abis link down" + * Revert "abis: Fix line leaked & recreated upon every reconnect" + * osmo-bts-omldummy: Fix crash accessing null phy + * bts-trx: Fix rxgain & maxdly VTY values being reset + * Decouple handling of Measurement Report from lapdm + * Move TA & Power Loops further up the stack, take DTXu flag into account + * scheduler: Fix lqual_cb not populated for TCH.ind + * abis: Fix line leaked & recreated upon every reconnect + * trx_provision_fsm: Fix TRX!=0 never going back to CLOSED state + * trx_provision_fsm: Support OPEN_POWEROFF->CLOSED transition + * bts-trx: Delay power ramp up until RCARRIER is ENABLED + * Delay abis reconnect while bts is shutting down + * bts-trx: Keep the process ongoing trying to reconnect on Abis link down + * trx_provision_fsm: Drop unneeded reset of fields + * trx_provision_fsm: Drop impossible paths + * trx_provision_fsm: poweronoff_sent flag: track POWERON and POWEROFF separately + * trx_provision_fsm: Fix shutdown while POWERON in transit + * rsl: NACK Chan Activation for lchans on disabled TS + * Introduce gsm_lchan_init() function helper + * MS Power Control Loop: Use P_CON_INTERVAL=2 by default + * load_indication.c: Avoid sending if CCCH is still not operational + * Move lchan,power_ctrl specific code from gsm_data.h to their own files + * Move lchan,power_control related code from gsm_data.c to their own files + * lchan.h: Add related ticket info to FIXME comment + * Introduce gsm_lchan_release function helper + * nm_channel_fsm: Release lchans after BTS shutdown + * nm_bts_fsm: Reset si_valid bitmask when BTS is shut down + * nm_*_fsm: Move reset state code to st_op_disabled_notinstalled_on_enter + * nm_*_fsm: reset mo.nm_attr from previous runs when entering state NOT_INSTALLED + * Add new gsm_bts_trx_free_shadow_ts() function + * Make sure lchan allocated memory from shadow_ts is properly freed + * rsl: Fix all shadow TS being Chan Act NACKed + * bts-trx: Guard call to trx_sched_clean with NULL trx ptr + * lchan: Setup early_rr_ia timer only once during init + * Move lchan related code to lchan.{c,h} + * lchan: Update log line level to use macro and level INFO + * lchan: Avoid applying transition changes if state new==old + * Move lchan_deactivate() to lchan.c + * Move lchan_init_lapdm inside lchan_set_state(LCHAN_S_ACTIVE) + * lchan: Call lapdm_channel_exit() when state changes to NONE + * bts_shutdown_fsm: Make sure pending power ramping are aborted before closing TRX + * gsm_pchan2chan_nr(): Properly assert if unexpected pchan is passed + * Reset CBCH state after BTS shutdown + * bts-trx: sched_lchan_pdtch: Refactor tx_pdtch_fn to get rid of goto tag + * bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly + * Revert "bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly" + * scheduler: Fix check against empty PDCH blocks + * bts-trx: sched: tx_pdtch_fn: Drop log line clogging logs + * l1sap: Avoid re-(de)activating already (de)active lchans + * scheduler: Avoid crash upon call to trx_sched_set_lchan if l1ts is uninitialized + * bts-trx: sched_lchan_tchf: Drop impossible code path + * scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors + * bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim + * abis: Drop unneded if condition in else clause + * abis: Try one reconnect to previously connected BSC before trying next one + * gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE + + [ Neels Hofmeyr ] + * osmobts-abis.adoc: add missing bibliography + * Abis manual: s/TS 12.21/TS 52.021 + * Abis manual: add Get Attributes, add BTS features + * Abis manual: add VAMOS to BTS features + * Abis manual: add RSL_IE_OSMO_TRAINING_SEQUENCE + * omldummy: introduce using getopt_long + * omldummy: add cmdline arg --features + * [VAMOS] osmo-bts-omldummy: allocate shadow timeslots + * remove unused LCHAN_S_INACTIVE + * enable Early Immediate Assignment + * add VTY transcript testing + * jenkins: enable new flag --enable-external-tests + * add osmo_tdef groups, exposing T timers on VTY config + * early IMM ASS: add configurable delay for RR IMM ASS + * early IA: change default X15 timer to 0 ms + * gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries + + [ Harald Welte ] + * Introduce ability to set socket priority of RTP sockets + * manual: Include QoS chapter and add osmo-bts specific example + * manual: Remove manual revision history; we don't use it anywawy + * manuals: Update copyright years + * l1sap/gsmtap: Don't log UI fill frames [zero information field] + * rsl: fix handling of REL IND in lapdm_rll_tx_cb() + * initial support for static userspace probes via systemtap + + [ Keith ] + * sysmobts-mgr: Fix path to hwmon in /sys + + [ Eric Wild ] + * osmo-bts-trx: indicate A5/4 support, handle Kc128 + + [ Oliver Smith ] + * debian/control: remove dh-systemd build-depend + + [ Eric ] + * lc15, oc2g, sysmo: fix show dsp-trace-flags + * osmo-trx: fix maxdly + + [ Martin Hauke ] + * osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:40:05 +0100 + osmo-bts (1.3.0) unstable; urgency=medium [ Michael McTernan ] diff --git a/debian/control b/debian/control index 3b8098b..0bdf48c 100644 --- a/debian/control +++ b/debian/control @@ -7,11 +7,11 @@ dh-autoreconf, autotools-dev, pkg-config, - libosmocore-dev (>= 1.5.0), - libosmo-abis-dev (>= 1.1.0), + libosmocore-dev (>= 1.6.0), + libosmo-abis-dev (>= 1.2.0), libgps-dev, txt2man, - osmo-gsm-manuals-dev (>= 1.1.0) + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Browser: http://git.osmocom.org/osmo-bts/ Vcs-Git: git://git.osmocom.org/osmo-bts -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibf3ce0bfd0cf67148229dd988ebde6e6b8d744cc Gerrit-Change-Number: 26281 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:48:20 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 15:48:20 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26280 to look at the new patch set (#2). Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... cards: select_adf_by_aid: split off aid completion The function select_adf_by_aid first searches for the complete AID in the set of AIDs that were read from EF.DIR. Lets put this task into a separate helper method Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 --- M pySim/cards.py 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/80/26280/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:48:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:48:22 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcu=5Bmaster=5D=3A_Bump_version=3A_0=2E9=2E0=2E280-56b7c-dirty_=E2=86=92_1=2E0=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26282 ) Change subject: Bump version: 0.9.0.280-56b7c-dirty ? 1.0.0 ...................................................................... Bump version: 0.9.0.280-56b7c-dirty ? 1.0.0 Change-Id: I38b083755e71eac5158e68ef958e210eeced9038 --- M TODO-RELEASE M configure.ac M contrib/osmo-pcu.spec.in M debian/changelog M debian/control 5 files changed, 310 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/26282/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 5b2720b..cbfda24 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,5 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore struct bssgp_bvc_ctx->is_sgsn field used available only on libosmocore >1.5.1 -libosmocore gprs_ns2_ip_bind_set_priority function used available only on libosmocore >1.5.1 diff --git a/configure.ac b/configure.ac index 31ead00..31ef189 100644 --- a/configure.ac +++ b/configure.ac @@ -82,11 +82,11 @@ fi dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) AC_MSG_CHECKING([whether to enable direct DSP access for PDCH of sysmocom-bts]) AC_ARG_ENABLE(sysmocom-dsp, diff --git a/contrib/osmo-pcu.spec.in b/contrib/osmo-pcu.spec.in index 96e9481..eec0ce2 100644 --- a/contrib/osmo-pcu.spec.in +++ b/contrib/osmo-pcu.spec.in @@ -28,11 +28,11 @@ %if 0%{?suse_version} BuildRequires: systemd-rpm-macros %endif -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 %{?systemd_requires} %description diff --git a/debian/changelog b/debian/changelog index dc42c0c..600969c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,301 @@ +osmo-pcu (1.0.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Support uplink multi-slot allocations + * tbf: Log timeslot allocation failure + * bts: Count TBF TS allocation failure + * pdch: Standarize and improve logging + * tbf: Improve logging when TBF being allocated or no TBF avail + * Remove uneeded ms param from alloc_algorithm_func_t func + * bts: Add new stats to detect TBF allocation failure reasons + * llc: use memset to fill llc dummy frame padding + * tbd_dl: Don't re-initialize class field twice + * tbf: log keep_open condition status + * tbf_dl: Fix m_last_dl_drained_fn not set under some conditions + * tbf_dl: fix FBI not set upon X2031 = 0 + * ms: clarify delayed MS release process related code and logging + * gprs_ms: Use standarized logging on more messages + * sched: sched_select_ctrl_msg(): Clean up param list and improve logging + * sched: sched_select_downlink(): Clean up param list and improve logging + * TODO-RELEASE: document requirement of master libosmocore + * tbf: Log N310* counter increments + * pdch: Silently ignore DATA.ind with len=0 + * direct_phy: Support submitting DATA.ind with len=0 to upper layers + * pcu_utils.h: Fix trailing whitespace + * Track TDMA clock with DATA.ind instead of TIME.ind + * Introduce init() APIs for PDCH and TRX objects + * tests: rlcmac: Fix C vs C++ linkage of extern symbol + * pdch.h: Drop uneeded include bts.h + * Improve DATA.ind logging + * Improve logging in DATA.req and ACT.req + * tbf: Fix wrong variable printed in log + * pdch: Log FN when decoding UL Ctrl block + * Add new PDCH UL Controller, drop SBAllocator class + * Replace PollController with newly added PDCH UL Controller + * sched: Use new PDCH UL Controller + * bts: Detect FN jumps + * cosmetic: tests/Makefile.am: Split content into several lines + * tests: Introduce unit tests for PDCH UL Controller + * tests: ulc: Show current bug with FN wrap around + * ulc: Fix FN store order upon wrap around + * sysmo: fix wrong FN jumps in rx RA.ind + * direct_phy: Fix condition dropping rx DATA.ind payload in in + * Fix: left shift cannot be repesented in type int + * sched: Fix scheduling UL TBF not matching conditions + * sched: Simplify usf selection code + * Set matching USF if available when polling a UL TBF + * pdch: Add mising pdch_ulc_release_node in Rx Cell Change Notif + * pdch_ulc: Create helper API pdch_ulc_release_node + * Track scheduled UL blocks through USF + * Properly implement N3101 + * sba: Document AGCH_START_OFFSET after some experimental tests + * pdch_ulc: Optimize rbtree FN search + * Pick unreserved UL FN when allocating an SBA + * pdch_ulc: Support picking RRBP other than N+13 + * Drop unused function tbf_check() + * pdch_ulc: Store TBF poll reason + * tbf: Get rid of unneeded poll_scheduled() + * tbf: Allow multiple concurrent polls + * Remove unneeded poll_state check + * tbf: get rid of poll_state completely + * Get rid of param 'poll' with constant value + * tbf: Get rid of attribute poll_fn + * tbf: Get rid of attribute poll_ts + * RIM: Improve logging + * sba: Drop unused function find_sba_rts + * pdch: rcv_resource_request: Improve robustness + * pdch: tbf_by_tfi(): Allow returning TBFs in state RELEASING + * Stop abusing T3169 + * Make use of T3142 received from BTS + * Use negative numbers for non-spec osmo-specific timers + * ul_tbf: Clean up handle_tbf_reject() + * Make WaitIndication T3172 configurable + * sched: Simplify else-if condition + * Clarify, document Assignment related timers + * doc/tbf.txt: Update and improve some information + * bts: constify arg in func bts_ms_store() + * sched: Rename func to describe its used only for RLCMAC CTRL blocks + * rim: Constify param in func + * Simplify helper function tbf_select_slot_set() + * alloc_algorithm_b: Rearrange variable initialization + * Rename function s/tbf_alloc_ul/tbf_alloc_ul_pacch/ + * Split ul_tbf alloc on CCCH into new function + * Implement T3141 + * tbf_ul: Use is_tlli_valid() API + * Tx ul ack/nack: Avoid sending invalid/unknown TLLI + * encoding: Use gsm48_ta_is_valid() API + * encoding: Encode TA in UL ACK/NACK if available + * sched: Clean up helper function and improve logging + * Drop existing tbf->ms() check condition + * ul_tbf: Simplify function rcv_data_block_acknowledged + * ul_tbf: Fix accessing zeroed block when checking if transfer is complete + * sched: Clean up param passing and improve logging + * pdch: Use llist_first_entry() API + * RIM: Refactor Rx path to decode stack in proper order + * Clean false positive in newer GCC version checking guard of else clause + * Use LOGPDCH macro in bts_add_paging() + * Optimize PAGING-CS PDCH set selection when target MS is known + * bts: Use ms_store when calculating set of target PDCHs for Pkt Paging Request + * tbf: Log error path in setup() failing to assign control TS + * Move TBF list from BTS to the TRX structure + * MsTest: Set up tbf talloc destructor + * tbf: Move existing tbf_state implementation to osmo_fsm + * cosmetic: Fix typo s/TIMSI/TMSI/ + * gsm_rlcmac.c: Fix arg list of 2 callbacks + * csn1: Implement CSN_CALLBACK type in encoder + * bts: Fix typo in field name + * Use new stat item/ctr getter APIs + * pdch: Log pdch_ulc reason upon rx of pkt ctrl ack + * pcuif: Support receiving System Information 2 + * pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack + * pcuif_proto.h: Add new container message + * Support proto IPAC_PROTO_EXT_PCU BSC<->PCU + * pdch: Fix heap-use-after-free in pdch->ulc + * Make gcc 11.1.0 false positivies happy + * tbf: Drop impossible paths in create_dl_ass() + * tests/tbf: Fix null pointer access if slowly stepping with gdb + * Revert "coverity: fix null deref from recent UL TBF leak fix" + * Revert "fix: handle NULL return of as_dl_tbf() and as_ul_tbf()" + * Revert "Revert "Stop abusing T3169"" + * Move NULL and ASSIGN tbf_state transition to tbf_fsm + * Move FLOW tbf_state transition to tbf_fsm. + * tests: tbf: Fix dl_tbf polled for data without being in FLOW state + * Move FINISHED tbf_state transition to tbf_fsm + * Move WAIT_RELEASE tbf_state transition to tbf_fsm + * Move RELEASING tbf_state transition to tbf_fsm + * Move T3169 and T3195 to tbf_fsm + * Drop duplicate log line + * Put dl_tbf::cleanup into destructor + * Drop logging last mas report before freeing TBF + * Remove duplicate call to gprs_rlcmac_lost_rep + * Move rate_ctr free to tbf subclass destructor + * Get rid of tbf_dl:abort() + * tbf_free: Get rid of uneeded tbf_state transition + * Replace ul_ass_state with osmocom FSM + * tbf: Reimplement rlcmac_diag() and make it available from C + * tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS + * replace dl_ass_state with osmocom FSM + * tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_DL_ASS + * tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_UL_DATA + * Move timer X2001 to tbf_fsm + * Get rid of lots of code only used by tests + * tbf: Merge handle_ack_nack() into rcvd_dl_ack() + * Fix typos in comments documenting fsm st chg macro + * tbf: Use type bool for upgrade_to_multislot + * Move timer X2002 to tbf_fsm + * tbf_dl: Clarify requirements for DL ACK/NACK + * tbf.h: Improve documentation on several flags + * Move tbf ul_ack_state to osmocom FSM + * Simplify tbf::set_polling() + * tbf: Move T3193 to tbf_state FSM + * fix typo 's/dowlink/downlink/g' + * cosmetic: Fix typo in comment + * sched: energy saving: Avoid Tx dummy blocks on empty PDCH TS + * Fix crash with dyn TS when using direct pcu + * Use LOGPDCH macro to standarize log line + * cosmetic: sysmo: Drop unneded comment line + * bts: Use public getter instead of class member + * sched: Lower log level of RTS on disabled pdch + * pdch: Make sure pending ImmAssRej scheduled for disabled pdch are dropped + * Support Neighbor Address Resolution over PCUIF IPA multiplex + * nacc_fsm: Move logic checking if SI is being waited for to a func helper + * scheduler: Skip Tx DL idle blocks in TRX0 when not in DIRECT_PHY mode + * PTCCH: skip Tx DL idle blocks when possible + * tbf_ul_ass_fsm.c: Fix missing state transition in FSM description + * tbf: poll_timeout(): Validate expected poll reason + * nacc: Introduce helper function nacc_fsm_exp_ctrl_ack() + * tbf: refactor poll_timeout() with a switch statement + * tests: TbfTest: Fix wrong behavior in test_tbf_dl_reuse() + * pdch: refactor rcv_control_ack() with a switch statement + * cosmetic: Fix missing space + * assert if tbf pointer for POLL event is NULL + * tbf_fsm: Ignore event DL_ACKNACK_MISS in state RELEASING + * tests: RLCMACTest: Add one more sample RA capabilities to suite + * rlcmac: Fix CSN1 definition for DownlinkDualCarrierCapability_r7_t in MS RA cap + * tbf: Assert if FSM allocation fails + * sched: Rename function + * pdch: Only release ULC entry if rx ul block matches the expected one + * pdch: Validate poll reason matches in rcv_control_(egprs)_dl_ack_nack() + * pdch: PktResReq: Avoid releasing ULC entry if expecting something else on UL + * Handle Final UL ACK/NACK Confirmation in tbf_fsm + * tbf_fsm: rename state NULL -> NEW + * pdch_ulc: Log POLL reason upon timeout + * tbf_dl_ass_fsm: Move block msg generation conditions to rts() function + * tbf_ul_ass_fsm: Fix use of incorrect log macro + * tbf_fsm: Handle MAX_N3105 in state ASSIGN + * tbf: Use define to flag control_ts unset special value + * tbf: Document temporary change of control_ts and move code assigning it back to FSM + * Return void in tbf_assign_control_ts() + * pdch: rcv_data_block: Avoid releasing ULC entry if expecting something else on UL + * tbf: Avoid keeping poll nodes in pdch_ulc of temporary control_ts used during PACCH assignment + * tbf_ul_ass_fsm: Avoid retrying Pkt Ul Ass if tbf is not in state ASSIGN + * Abort scheduling of pending Pkt Ul Ass if tbf goes into RELEASE step + * tbf: Drop pending polls during free also on states != ASSIGN + * pdch: Simplify code path allocating UL TBF + * pdch: Log reason of expected POLL when receiving unexpected UL data + * bts_rcv_rach(): Gather pointers to data objects early and use them later + * bts_rcv_rach(): Split code paths for Ass and Ass Rej + * Get rid of tbf tsc field + * ts_alloc: Rename s/tbf_/tbf/ + * tbf: Update FSM names when TFI change during tbf_update() + * tbf_fsm: Add assert verifying X2002 only triggers for DL TBF + * tbf: Assert if update() is called on UL TBF + * tbf: update(): return negative val on error + * tbf: Drop unneeded braces in one line condition + * cosmetic: Fix typo in comment + * pcuif: Submit data_req with len=0 as idle frames + * Split csn1.c into common, enc and dec files + * csn1: Add unit test showing RadioAccess Capability decoding failure + * csn1: Avoid failing if optional DownlinkDualCarrierCapability_r7 is missing + * csn1: Avoid storing existence bit as true if content was actually NULL + * csn1_dec.c: Fix stored bit in CSN_NEXT_EXIST_LH + * bts: Fix misleading log line in bts_rcv_rach() + * tbf_ul: Document context where tbf_alloc_ul_ccch() is used + * bts: Rename 11bit RACH request counter + * vty: Avoid crash in tbf_print_vty_info with null ptr ctrg + * vty: Log tbf_state when showing a TBF + * vty: show tbf: Drop unneeded check for non-null ms + * bts: Introduce new RACH req counters for one/two phase access + * bts: Improve logging to clarify RACH req is for 2 phase access + * bts: Count RACH Request with unexpected content + * tbf: Increase log level of line about unable to allocate poll for TBF + * pdch: Improve log line and increase log level + * tbf_ul: Set first_(common_)ts in handle_tbf_reject + * tbf: Set m_created_ts in constructor + * tbf: Mark initial first_(common_)ts with special value + * tbf: Set tfi to initial special value + * bts: Add counters for successful 1,2 phase pkt access + * tbf_ul: Update FSM names for dummy reject TBFs + * cosmetic: Add parenthesis around expression to clarify it + * pdch::rcv_resource_request(): Use local var to store bts pointer + * tbf_ul: Improve documentation of tbf_alloc_ul_pacch() + * Add counter for successful contention resolution procedures + * doc: Update counters_generated.adoc using osmo_vty_interact.py + * bts_pch_timer: Fix timer working only for MI type IMSI + * tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI + * bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed + * pdch: Log line detaching TBF at start of the function + * pdch: Log TS enable/disable transitions + * pdch: Log DL TBF originating the new UL TBF + * ts_alloc: Simplify tfi_find_free logic + * ts_alloc: rename function to clraify what it does + * ts_alloc: rename variable to clarify meaning + * pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled + * pdch: Drop previous UL TBF from MS who sent PktResReq through SBA + * pdch: Increase log level of line informing about TS control change + * tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for new one + * cosmetic: gprs_pcu.h: Fix typo in comment + * tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one + * tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent + * tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf + * pcu_main: Mark -r cmdline param as deprecated + * vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' + * Fix MS ending up with assigned imsi 000 + * bts: Add counter availablePDCHAllocatedTime + * tbf_dl_ass_fsm: Drop unsued X2000 timer callback + * T_defs_pcu: Set default val for X2000 to 0 ms + * Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY + + [ Alexander Couzens ] + * gprs_bssgp_pcu: rework BSSGP Reset messages to support SGSN originated BSSGP-RESET + * gprs_bssgp_pcu: ensure only known BVCI can be resetted by the SGSN + * gprs_bssgp_pcu: add comments to the pcu states + + [ Harald Welte ] + * pdch_ul_controller: Fix compiler warning on gcc-10.2 + * manual: remove revhistory, as we don't maintain it manually anyyway + * manual: Update copyright years + * vty: Add configuration for Gb DSCP and socket priority + * manual: Include QoS chapter and add osmo-pcu specific example + + [ Vadim Yanitskiy ] + * gprs_rlcmac_sched: fix incorrect length for CTR_RLC_DL_BYTES + * PCUIF protocol: add message definition for interference report + * pcu_l1_if: ignore PDCH interference reports, do not log errors + + [ Oliver Smith ] + * test: add 'make update_exp' target + * Add counters: pcu.sgsn.N.rx_paging_{cs,ps} + * Add counters: pcu.bts.N.pch.requests + * Add counters: pcu.bts.N.pch.requests.timeout + * bts: delete pch_timer list in destructor + * tests: make update_exp: build check_PROGRAMS first + * debian/control: remove dh-systemd build-depend + * Add stats: pcu.bts.N.pdch.available/occupied + * Add stats: pcu.bts.N.pdch.occupied.gprs/egprs + * pdch: has_gprs_only_tb_attached: use m_num_tbfs + + [ Neels Hofmeyr ] + * T_defs_bts: remove unit from doc strings + * Revert "Stop abusing T3169" + * fix: handle NULL return of as_dl_tbf() and as_ul_tbf() + * coverity: fix null deref from recent UL TBF leak fix + + [ Daniel Willmann ] + * gprs_bssgp_pcu: Fix crash when configuring an existing ns bind + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:47:29 +0100 + osmo-pcu (0.9.0) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/debian/control b/debian/control index 0e12f2e..b332ad6 100644 --- a/debian/control +++ b/debian/control @@ -6,8 +6,8 @@ dh-autoreconf, autotools-dev, pkg-config, - libosmocore-dev (>= 1.5.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmocore-dev (>= 1.6.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Homepage: http://osmocom.org/projects/osmopcu Vcs-Git: git://git.osmocom.org/osmo-pcu -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I38b083755e71eac5158e68ef958e210eeced9038 Gerrit-Change-Number: 26282 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 15:59:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 15:59:37 +0000 Subject: =?UTF-8?Q?Change_in_osmo-mgw=5Bmaster=5D=3A_Bump_version=3A_1=2E8=2E1=2E90-aac8-dirty_=E2=86=92_1=2E9=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26283 ) Change subject: Bump version: 1.8.1.90-aac8-dirty ? 1.9.0 ...................................................................... Bump version: 1.8.1.90-aac8-dirty ? 1.9.0 Change-Id: Icfc615c0d7d826269962b0d94fbe53c2f8adfdaf --- M TODO-RELEASE M configure.ac M contrib/osmo-mgw.spec.in M debian/changelog M debian/control R debian/libosmo-mgcp-client9.install M src/libosmo-mgcp-client/Makefile.am 7 files changed, 140 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/83/26283/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 3b31cde..c5a3b36 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -24,5 +24,3 @@ # If any interfaces have been removed or changed since the last public release, a=0. # #library what description / commit summary line -update dependency to libosmocore > 1.5.1 for our use of osmo_sock_set_dscp() -libosmo-mgcp-client struct mgcp_client_conf ABI breackage \ No newline at end of file diff --git a/configure.ac b/configure.ac index ddd8862..c0b7d03 100644 --- a/configure.ac +++ b/configure.ac @@ -44,13 +44,13 @@ AC_SUBST(LIBRARY_DLSYM) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.2.0) CFLAGS="$CFLAGS -pthread" LDFLAGS="$LDFLAGS -pthread" diff --git a/contrib/osmo-mgw.spec.in b/contrib/osmo-mgw.spec.in index ee85db3..c181d1f 100644 --- a/contrib/osmo-mgw.spec.in +++ b/contrib/osmo-mgw.spec.in @@ -30,29 +30,29 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmocoding) >= 1.5.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmotrau) >= 1.1.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmocoding) >= 1.6.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmotrau) >= 1.2.0 %{?systemd_requires} %description OsmoMGW is Osmocom's Media Gateway for 2G and 3G circuit-switched mobile networks. -%package -n libosmo-mgcp-client8 +%package -n libosmo-mgcp-client9 Summary: Osmocom's Media Gateway Control Protocol client library Group: System/Libraries -%description -n libosmo-mgcp-client8 +%description -n libosmo-mgcp-client9 Osmocom's Media Gateway Control Protocol client library. %package -n libosmo-mgcp-client-devel Summary: Development files for Osmocom's Media Gateway Control Protocol client library Group: Development/Libraries/C and C++ -Requires: libosmo-mgcp-client8 = %{version} +Requires: libosmo-mgcp-client9 = %{version} %description -n libosmo-mgcp-client-devel Osmocom's Media Gateway Control Protocol client librarary. @@ -90,8 +90,8 @@ %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) -%post -n libosmo-mgcp-client8 -p /sbin/ldconfig -%postun -n libosmo-mgcp-client8 -p /sbin/ldconfig +%post -n libosmo-mgcp-client9 -p /sbin/ldconfig +%postun -n libosmo-mgcp-client9 -p /sbin/ldconfig %if 0%{?suse_version} %preun @@ -119,8 +119,8 @@ %dir %{_sysconfdir}/osmocom %config(noreplace) %{_sysconfdir}/osmocom/osmo-mgw.cfg -%files -n libosmo-mgcp-client8 -%{_libdir}/libosmo-mgcp-client.so.8* +%files -n libosmo-mgcp-client9 +%{_libdir}/libosmo-mgcp-client.so.9* %files -n libosmo-mgcp-client-devel %{_libdir}/libosmo-mgcp-client.so diff --git a/debian/changelog b/debian/changelog index a2f5c4a..ec34937 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,117 @@ +osmo-mgw (1.9.0) unstable; urgency=medium + + [ Harald Welte ] + * TOS bits != DSCP + * manual: don't define fig-bsc twice + * switch from osmo_sock_set_dscp() to OSMO_SOCK_F_DSCP() + * mgw: Add support for setting socket priority from VTY + * manual: Include QoS chapter and add osmo-mgw specific example + + [ Keith ] + * Add vty command 'show mgcp active' + * Log some useful messages at ERROR/INFO instead of DEBUG + + [ Neels Hofmeyr ] + * send DLCX only once + * tweak termination DLCX log msg + * add osmo_mgcpc_ep_ci_get_remote_rtp_info() + * check_rtp_destin(): clarify log msg + * mgcp_client_fsm delete: set mgcp_client as ctx, not NULL + * mgcp_client_endpoint_fsm: on term, still let conns wait for DLCX OK + * mgcp_client_fsm: add missing log_subsys + * mgcp_client: add logging on received MGCP messages + + [ Philipp Maier ] + * mgcp_network: fix implicit address loopback + * mgcp_common, mgcp_udp_send: make parameter buf const + * mgcp_network: refactor MGCP_DUMMY_LOAD + * mgcp_client: drop nunnecessary else statement + * mgcp_client: fix error handling in mgcp message generation + * mgcp_protocol: fix loop that sends dummy RTP packets + * mgw_main: fix loop that resets all endpoints + * mgcp_trunk: drop ws line + * mgcp_ratectr: drop ws line + * mgcp_ratectr: fix sourcecode formatting + * mgcp_trunk: add value string for trunk type. + * mgcp_ratectr: refactor rate counter and set group name + * mgcp_protocol: forward declare mgcp_endpoint + * mgcp_endp: make wildcarded detection separate + * mgcp_protocol: refactor request handler array + * mgcp_trunk: use unsigned int instead of int as trunk_nr + * mgcp_protocol: refactor MGCP request handling + * mgcp_ratectr: add stats items to monitor trunk usage + * mgcp_msg: add trunk parameter to mgcp_check_param for logging + * mgcp_protocol: refactor function create_response_with_sdp + * mgcp_protocol: add support for wildcarded DLCX + * remove struct member wildcarded_req from struct mgcp_endpoint + * mgcp_lient: remove unsubstantial FIXME note + * mgcp_protocol: assert endp when it becomes mandatory + * mgcp_trunk: check MGW domain name earlier + * mgcp_ratectr: add stats items to monitor trunk usage + * mgcp_client: fix typo Initalize -> Initialize + * mgcp_protocol: get rid of policy_cb and change_cb + * mgcp_ratectr: do not set talloc destructor on library allocated item + * mgcp_client: allow to reset endpoints on startup + * mgcp_client_vty: remove unnecessary checks + * mgcp_client: do not print (null) when address is ANY + * mgcp_client: refactor function init_socket + * libosmo-mgcp-client: extend the mgcp_client for MGW pooling + * mgcp_client_vty: add missing docstrings + * mgcp_client_vty: add OSMO_ASSERT on pool parameter + * mgcp_client_vty: fix docstrings for mgw-pool + * mgcp_client_vty: cosmetic: doc string should terminated with \n + * mgcp_client_vty: fixing docstring + * mgcp_ratectr: remove unusued rate counters + * mgcp_client: fix typo in doxygen comment + * mgcp_client: add MGW name as logging context + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * constify arg in addr_is_any() + * Define patch_ssrc as bool type + * constify some function arg pointers + * mgcp_network.c: Reorder some functions in file + * mgcp_send_dummy: Check RTP destination is available before attempt tx + * mgw: rx CRCX: Avoid sending dummy rtp if remote address not provided + * Fail rx MDCX sendrecv with invalid remote addr + * Take into account Marker bit when patching RTP stream + * Use DLMGCP instead of DLGLOBAL in log lines + * Fix attribute parsing on gcc 11.1.0 + + [ neels ] + * Revert "mgcp_ratectr: add stats items to monitor trunk usage" + + [ Daniel Willmann ] + * contrib/jenkins: Use ASAN for osmo-mgw + + [ Oliver Smith ] + * mgcp_client_vty: add missing NO_STR + * Revert "Turn some compiler warnings into errors" + + [ Eric ] + * add vscode stuff to gitignore + * configure.ac: fix maybe-uninitialized for clang + * fix missing includes and forward declarations + * rename do_retransmission + * mgcp_sdp: fix potential leak + * stats: make sanitizers happy + * libosmo-mgcp: cleanup audio codex alloc + * libosmo-mgcp: atomic rate counter group indexes + * libosmo-mgcp: do not use the default msgb talloc context + * globally lock the portrange when trying to grab a port to prep for multithreading + * embed strings into structs + * adjust talloc context + * endp: do not cache cfg pointer + * add modified .clang-format + * rename strip_epname and find_specific_endpoint and make them available + * fix mgcp_conn_free_all + * fix up some docstrings that lost their dot + + [ Vadim Yanitskiy ] + * libosmo-mgcp: use OSMO_STRLCPY_ARRAY in mgcp_codec_add() + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:59:21 +0100 + osmo-mgw (1.8.1) unstable; urgency=medium * attempt to fix RPM spec file after recent soversion bump diff --git a/debian/control b/debian/control index 8246708..2ca9a13 100644 --- a/debian/control +++ b/debian/control @@ -6,10 +6,10 @@ dh-autoreconf, pkg-config, autotools-dev, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), libosmo-netif-dev (>= 1.1.0), - libosmo-abis-dev (>= 1.1.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-abis-dev (>= 1.2.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-mgw.git Vcs-Browser: https://git.osmocom.org/osmo-mgw/ @@ -21,7 +21,7 @@ Depends: ${misc:Depends}, ${shlibs:Depends} Description: OsmoMGW: Osmocom's Media Gateway for 2G and 3G circuit-switched mobile networks -Package: libosmo-mgcp-client8 +Package: libosmo-mgcp-client9 Section: libs Architecture: any Multi-Arch: same @@ -33,7 +33,7 @@ Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-mgcp-client8 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-mgcp-client9 (= ${binary:Version}), ${misc:Depends} Description: libosmo-mgcp-client: Osmocom's Media Gateway Control Protocol client utilities Package: osmo-mgw-doc diff --git a/debian/libosmo-mgcp-client8.install b/debian/libosmo-mgcp-client9.install similarity index 100% rename from debian/libosmo-mgcp-client8.install rename to debian/libosmo-mgcp-client9.install diff --git a/src/libosmo-mgcp-client/Makefile.am b/src/libosmo-mgcp-client/Makefile.am index c472ec1..4d9ec5f 100644 --- a/src/libosmo-mgcp-client/Makefile.am +++ b/src/libosmo-mgcp-client/Makefile.am @@ -21,7 +21,7 @@ # This is not at all related to the release version, but a range of supported # API versions. Read TODO_RELEASE in the source tree's root! -MGCP_CLIENT_LIBVERSION=8:0:0 +MGCP_CLIENT_LIBVERSION=9:0:0 lib_LTLIBRARIES = \ libosmo-mgcp-client.la \ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icfc615c0d7d826269962b0d94fbe53c2f8adfdaf Gerrit-Change-Number: 26283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:13:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:13:33 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E27-f8ed-dirty_=E2=86=92_0=2E8=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26284 ) Change subject: Bump version: 0.7.0.27-f8ed-dirty ? 0.8.0 ...................................................................... Bump version: 0.7.0.27-f8ed-dirty ? 0.8.0 Change-Id: Ibbef3cc3bf1f468309e73f5dda497dca1a03c815 --- M contrib/osmo-iuh.spec.in M debian/changelog M debian/control R debian/libosmo-ranap5.install R debian/libosmo-sabp1.install M debian/rules M src/Makefile.am 7 files changed, 61 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/84/26284/1 diff --git a/contrib/osmo-iuh.spec.in b/contrib/osmo-iuh.spec.in index f40c3db..977d35c 100644 --- a/contrib/osmo-iuh.spec.in +++ b/contrib/osmo-iuh.spec.in @@ -58,17 +58,17 @@ %description -n libosmo-hnbap-devel Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -%package -n libosmo-ranap3 +%package -n libosmo-ranap5 Summary: Shared Library part of libosmo-ranap Group: System/Libraries -%description -n libosmo-ranap3 +%description -n libosmo-ranap5 Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) %package -n libosmo-ranap-devel Summary: Development files for Osmocom RANAP library Group: Development/Libraries/C and C++ -Requires: libosmo-ranap3 = %{version} +Requires: libosmo-ranap5 = %{version} %description -n libosmo-ranap-devel Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) @@ -91,17 +91,17 @@ %description -n libosmo-rua-devel Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -%package -n libosmo-sabp0 +%package -n libosmo-sabp1 Summary: Shared Library part of libosmo-sabp Group: System/Libraries -%description -n libosmo-sabp0 +%description -n libosmo-sabp1 Osmocom code for the SABP (service area broadcast protocol) interface %package -n libosmo-sabp-devel Summary: Development files for Osmocom SABP library Group: Development/Libraries/C and C++ -Requires: libosmo-sabp0 = %{version} +Requires: libosmo-sabp1 = %{version} %description -n libosmo-sabp-devel Osmocom code for the SABP (service area broadcast protocol) interface @@ -131,12 +131,12 @@ %post -n libosmo-hnbap0 -p /sbin/ldconfig %postun -n libosmo-hnbap0 -p /sbin/ldconfig -%post -n libosmo-ranap3 -p /sbin/ldconfig -%postun -n libosmo-ranap3 -p /sbin/ldconfig +%post -n libosmo-ranap5 -p /sbin/ldconfig +%postun -n libosmo-ranap5 -p /sbin/ldconfig %post -n libosmo-rua0 -p /sbin/ldconfig %postun -n libosmo-rua0 -p /sbin/ldconfig -%post -n libosmo-sabp0 -p /sbin/ldconfig -%postun -n libosmo-sabp0 -p /sbin/ldconfig +%post -n libosmo-sabp1 -p /sbin/ldconfig +%postun -n libosmo-sabp1 -p /sbin/ldconfig %if 0%{?suse_version} %pre %service_add_pre osmo-hnbgw.service @@ -165,8 +165,8 @@ %{_libdir}/libosmo-hnbap.so %{_libdir}/pkgconfig/libosmo-hnbap.pc -%files -n libosmo-ranap3 -%{_libdir}/libosmo-ranap.so.3* +%files -n libosmo-ranap5 +%{_libdir}/libosmo-ranap.so.5* %files -n libosmo-ranap-devel %dir %{_includedir}/osmocom/ @@ -185,8 +185,8 @@ %{_libdir}/libosmo-rua.so %{_libdir}/pkgconfig/libosmo-rua.pc -%files -n libosmo-sabp0 -%{_libdir}/libosmo-sabp.so.0* +%files -n libosmo-sabp1 +%{_libdir}/libosmo-sabp.so.1* %files -n libosmo-sabp-devel %dir %{_includedir}/osmocom/ diff --git a/debian/changelog b/debian/changelog index 62ce110..bfdcb95 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,40 @@ +osmo-iuh (0.8.0) unstable; urgency=medium + + [ Harald Welte ] + * hnbgw: Add missing break statement + + [ Pau Espin Pedrol ] + * iu_client: Log event sent to upper layer callback + * ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE as a result + * hnb-test: Fix typo in vty cmd description + * cosmetic: src/ranap/Makefile.am: Drop trailing whitespace + * src/tests/Makefile.am: Drop reference to non-existent RANAP_FILES var + * src/*/Makefile.am: Fix trailing whitespace + * Provide libosmo-hnbap as a public shared library + * Provide libosmo-rua as a public shared library + * move-asn1-header-files.sh: Replace original asn file path in generated asn1 header files + * README.md: Document how to re-generate code from ASN1 files + * hnbgw_rua.c: Use proper type struct + * hnbgw_cn.c: Use proper type struct + * hnb-test: Fix rc var may be used uninitialized + * src/*/Makefile.am: Copy back to srcdir the generated .c files from ASN + * src/*/Makefile.am: Use asn1c -R to avoid generating runtime code + * Update generated .c/.h after using asn1c -R param + * hnbap: Use specific prefix for HNBAP generated code + * hnbap: Drop no longer existing asn1c param -fnative-types + * hnbap: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * rua: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * sabp: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * ranap: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * hnb-test: Fix memleak in hnb_read_cb + + [ Oliver Smith ] + * contrib/osmo-iuh.spec.in: fix header packaging + * contrib/osmo-iuh.spec: fix missing ldconfig lines + * Cosmetic: put asn1c parameters in separate lines + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:13:09 +0100 + osmo-iuh (0.7.0) unstable; urgency=medium [ Martin Hauke ] diff --git a/debian/control b/debian/control index f89869a..cceef39 100644 --- a/debian/control +++ b/debian/control @@ -67,7 +67,7 @@ Depends: libosmo-hnbap0 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -Package: libosmo-ranap3 +Package: libosmo-ranap5 Section: libs Architecture: any Multi-Arch: same @@ -79,14 +79,14 @@ Section: debug Architecture: any Multi-Arch: same -Depends: libosmo-ranap3 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-ranap5 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) Package: libosmo-ranap-dev Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-ranap3 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-ranap5 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) Package: libosmo-rua0 @@ -111,7 +111,7 @@ Depends: libosmo-rua0 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -Package: libosmo-sabp0 +Package: libosmo-sabp1 Section: libs Architecture: any Multi-Arch: same @@ -123,12 +123,12 @@ Section: debug Architecture: any Multi-Arch: same -Depends: libosmo-sabp0 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-sabp1 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (SABP) Package: libosmo-sabp-dev Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-sabp0 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-sabp1 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (SABP) diff --git a/debian/libosmo-ranap3.install b/debian/libosmo-ranap5.install similarity index 100% rename from debian/libosmo-ranap3.install rename to debian/libosmo-ranap5.install diff --git a/debian/libosmo-sabp0.install b/debian/libosmo-sabp1.install similarity index 100% rename from debian/libosmo-sabp0.install rename to debian/libosmo-sabp1.install diff --git a/debian/rules b/debian/rules index b85b0d2..9db7204 100755 --- a/debian/rules +++ b/debian/rules @@ -15,9 +15,9 @@ # See https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg override_dh_strip: dh_strip -plibosmo-hnbap0 --dbg-package=libosmo-hnbap-dbg - dh_strip -plibosmo-ranap3 --dbg-package=libosmo-ranap-dbg + dh_strip -plibosmo-ranap5 --dbg-package=libosmo-ranap-dbg dh_strip -plibosmo-rua0 --dbg-package=libosmo-rua-dbg - dh_strip -plibosmo-sabp0 --dbg-package=libosmo-sabp-dbg + dh_strip -plibosmo-sabp1 --dbg-package=libosmo-sabp-dbg dh_strip -posmo-hnbgw --dbg-package=osmo-hnbgw-dbg # Print test results in case of a failure diff --git a/src/Makefile.am b/src/Makefile.am index 6a8e7f4..b69d65f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -62,9 +62,9 @@ # build the shared RANAP + SABP library # HNBAP_LIBVERSION=0:0:0 -RANAP_LIBVERSION=4:0:1 +RANAP_LIBVERSION=5:0:0 RUA_LIBVERSION=0:0:0 -SABP_LIBVERSION=0:0:0 +SABP_LIBVERSION=1:0:0 lib_LTLIBRARIES = libosmo-hnbap.la libosmo-ranap.la libosmo-rua.la libosmo-sabp.la libosmo_hnbap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) libosmo_hnbap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ibbef3cc3bf1f468309e73f5dda497dca1a03c815 Gerrit-Change-Number: 26284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:22:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:22:08 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bsc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E359-d13ef-dirty_=E2=86=92_1=2E8=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26285 ) Change subject: Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 --- M TODO-RELEASE M configure.ac M contrib/osmo-bsc.spec.in M debian/changelog M debian/control 5 files changed, 407 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/26285/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index cfb9cf9..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,13 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore >1.5.1 needs osmo_bts_features_name(), osmo_bts_features_desc() -libosmogsm >1.5.1 enum entry GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID -libosmogsm >1.5.1 introduced struct needed gsm0808_old_bss_to_new_bss_info->last_eutran_plmn_id -libosmo-mgcp-client >1.8.0 need osmo_mgcpc_ep_ci_get_remote_rtp_info() -libosmovty >1.5.1 needs vty_read_config_filep() -libosmosgsm >1.5.1 needs GSM_PCHAN_OSMO_DYN -libosmocore >1.5.1 RSL_IPAC_EIE_OSMO*, struct osmo_preproc_* -libosmocore >1.5.1 needs osmo_str_to_int() -libosmocore >1.5.1 needs new osmo_stat_item implementation (omits FIFO size for stat item) -libosmocore >=1.6 need osmo_time_cc diff --git a/configure.ac b/configure.ac index bcf91ba..c4eac4a 100644 --- a/configure.ac +++ b/configure.ac @@ -46,14 +46,14 @@ AM_CONDITIONAL(BUILD_IPA_UTILS, test "x$osmo_ac_ipa_utils" = "xyes") AC_SUBST(osmo_ac_ipa_utils) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.8.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/osmo-bsc.spec.in b/contrib/osmo-bsc.spec.in index 9f7ef48..187242c 100644 --- a/contrib/osmo-bsc.spec.in +++ b/contrib/osmo-bsc.spec.in @@ -31,15 +31,15 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.8.0 +BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.9.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(talloc) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 8fc8b76..40b509d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,390 @@ +osmo-bsc (1.8.0) unstable; urgency=medium + + [ Harald Welte ] + * remove obsolete dependency on libosmo-sccp + * manual: Include QoS chapter and add osmo-bsc specific example + + [ Javi ] + * Add vty command for Ericsson RBS2000 sync + * Add command to enable RX diversity to RBS2000 + + [ Oliver Smith ] + * stats: T3122 related: num_values 16 -> 60 + * src/utils/meas_vis.c: fix bs_power -> bs_power_db + * handover_test: fix ts_str may be uninitialized + * bsc_ctrl_commands: fix uninitialized value (mode) + * Revert "Turn some compiler warnings into errors" + + [ Neels Hofmeyr ] + * refactor handover penalty timers + * drop neighbor_ident_test.c + * fix/refactor neighbor config + * debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state + * fixup for neighbor config for coverity + * drop unused func decl rsl_lchan_mark_broken() + * drop unused gsm_bts_trx->description + * deprecation: use osmo_bts_features_*() + * fix wrong ARFCNs in local-cell neighbor config + * update neighbor ARFCNs on startup and config changes + * manual: Location Services: clarify BSC side address + * abis_nm_ipaccess_rsl_connect(): use msgb to compose attr + * Lb: stop RESET FSM when sccp_user is unbound + * Lb: RESET FSM: never send sccp_user == NULL + * Lb: add missing X12 timer configurability + * Lb: make sure we never have missing timer configurability + * gsm_lchan_name_compute with ctx + * log: drop duplicate logging in ts_setup_lchans() + * comment: tweak pchan_subslots() description + * lchan_release(): do not release UNUSED lchan + * lchan_fsm: mode modify: fix missing timeouts and error transitions + * fix test_gsm48_multirate_config: dump the complete AMR lv buffer + * test_gsm48_multirate_config: rather keep 4x amr_mode + * assignment_fsm: fix failure log message for lchan unavailable + * select_codecs(): do not confuse bool 'true' with integer value 1 + * gsm48_send_rr_ass_cmd(): rename dest_lchan to current_lchan + * gsm48_send_rr_ass_cmd(): rename lchan to new_lchan + * log: show src file,line of lchan_set_last_error + * add missing arg braces in LOG_LCHAN macro + * gscon MGCP: properly skip redundant MDCX towards MSC + * cosmetic: rename FOR_* to ACTIVATE_FOR_* + * cosmetic: rename lchan_activate_mode to lchan_activate_for + * lchan and assignment FSMs: make Channel Mode Modify more sane + * assignment_fsm: tweak error log msg for mixed modes + * handover_test: ack release only when lchan is still waiting + * hodec2: remove code dup of rxlev averaging + * handover_test: add bspower to meas-rep cmd + * add test_bs_power.ho_vty to show BS Power HO oscillation + * assignment_fsm: send BSSMAP response only after Assignment Request + * cosmetic scoping in reuse_existing_lchan() + * potential segfault: vty chan act: do not set AMR bits for EFR + * make sure channel mode and s15_s0 are updated only after an ACK + * remove special case from assignment_count_result() + * eliminate lchan->rsl_cmode + * move lchan->csd_mode into channel_mode_and_rate + * AMR config cleanup step 1: split lchan_mr_config() + * AMR config cleanup step 2: filter modes also for VTY + * AMR config cleanup step 3: generate AMR LV on msg composition + * handover dot charts: fix wrong transitions regarding MGW + * handover_test: fix naming/wording: 'handover-req' should be 'handover-cmd' + * assignment_fsm: tweak state transitions (prep for reassignment) + * assignment_fsm: allow assignment to a specific lchan + * vty: actually trigger Assignment for 'assignment', not HO + * hodec 2: do intra-cell congestion resolution by Assignment + * RSL link: explicitly select rsl_link based on lchan + * add chan_mode_to_chan_type() + * gsm48_lchan2chan_desc(): expose TSC as param + * allow explixit TSC Set and TSC on chan activ / modif / assignment + * VTY: dump TSC Set and TSC for each timeslot + * add fields to reflect nr of lchans in ts struct + * replace ts_*_for_each_lchan() with ts_for_n_lchans() + * ensure chan_mode comparisons in non-VAMOS mode + * lchan_fsm: introduce lchan.modify.ch_mode_rate to allow tweaking + * Drop duplicated arfcn_range_encode.c available in libosmocore + * fixup for Mode Modify TSC + * fix rc handling in channel_mode_from_lchan() + * drop unused func decl gsm_lchan_as_pchan2chan_nr() + * handover: apply meas report BS Power to RXLEV, fix ho oscillation + * change bs_power to bs_power_db + * meas rep logging: replace a dozen DEBUGPC() with one DEBUGP() + * meas rep logging: use log_check_level() to skip a logging loop + * fixup: pass tsc = -1 for previous default training sequence code + * hodec2: add handover_test cases for upgrade of TCH/H -> TCH/F + * cosmetic prep: hodec2: move is_upgrade_to_tchf() further up + * hodec2: fix is_upgrade_to_tchf() for requirement A + * allow mode modify when RTP stream is active + * implement Channel Mode Modify to VAMOS mode + * vty: add lchan modify '(vamos|non-vamos)' command + * add lchan->vamos.is_secondary flag + * vty-test: osmo-bsc.vty: test doc of lchan activate cmd + * lchan_fsm: introduce lchan.activate.ch_mode_rate to allow tweaking + * add missing AMR config for RTP activation after mode modify + * implement CHANnel ACTIVate to VAMOS mode + * RR Assignment for VAMOS: send TSC Set + * add VAMOS secondary lchans to timeslot struct + * update the lchan name to always reflect VAMOS shadowness + * rsl_lchan_lookup(): turn cbits if-cascade into a switch() + * rsl_lchan_lookup(): add comment explaining ts_is_capable_of_pchan() + * RSL chan_nr: replace OSMO_ASSERT with error handling + * RSL: rx and tx VAMOS Channel Number cbits for VAMOS lchans + * VTY: 'show lchan': show that lchan is in VAMOS mode + * VTY: add 'vamos-subslot' to activate a secondary lchan + * VTY: add lchan re-assignment command + * log: assignment_fsm: drop newline from assignment_fail + * log: assignment_fsm: tweak err msg for incompatible chan + * clarify bts_chan_load + * get_any_lchan(): reduce minor code dup + * cosmetic loop simplification in gsm48_multirate_config() + * RSL: set default TEI according to TRX number + * lchan_fsm: lchan_fail() strings should not have a terminating newline + * gsm_data.h: add comments about immutable activ/modif/assign request info + * hodec2: implement upgrade TCH/H -> TCH/F (without AFS bias) + * fixup for vamos: fix wrong cbits in rsl_lchan_lookup() + * vty: reassign: add missing check for valid target lchan + * hodec2: don't apply AFS bias to same-cell lchans + * rsl_data_request() check lchan pointer before access + * rsl_lchan_lookup: drop redundant condition + * rewire build_encr_info() to return errors + * dissolve gsm0808_cipher_mode() into bssmap_handle_cipher_mode() + * implement A5/4 in Ciphering Mode procedure + * support A5/4 in inter-BSC Handover + * use osmo_select_shutdown to get rid of SIGTERM sleep + * vty: allow 5 encryption algo entries + * hodec2: add test case showing low rxlev tch/h<->tch/f oscillation + * hodec2: add test case showing low rxqual tch/h<->tch/f oscillation + * handover_decision_2.c: add is_low_rxlev() + * hodec2: fix low rxlev tch/h<->tch/f oscillation + * handover_decision_2.c: add current_rxqual() + * hodec2: fix low rxqual tch/h<->tch/f oscillation + * vty: fix doc: default value for 'nri bitlen' + * vty: add vty doc test for 'nri null' commands + * hodec2: [1/2] implement automatic choice between FULL and SUBSET measurements + * hodec2: [2/2] implement automatic choice between FULL and SUBSET measurements + * hodec1: use same automatic FULL/SUBSET choice as in hodec2 + * lchan: call reset() upon alloc + * RES IND: parse msg and store interference levels in lchans + * RES IND: add VTY: bts / channel allocator avoid-interference (0|1) + * RES IND: add test_resource_indication.ho_vty + * RES IND: pick lchan with least interference + * ensure trigger_ho() returns zero only when HO or AS was indeed triggered + * handover_test: also show when an lchan is busy + * switch handover penalty timers to CLOCK_MONOTONIC + * handover_test: add fake-time 'wait' + * test_penalty_timer.ho_vty: show lchan recovery + * handover tests: test passing of penalty timeout + * hodec2: add low-rxqual-assignment penalty timer (1/2) + * hodec2: add low-rxqual-assignment penalty timer (2/2) + * separate 'interference-meas level-bounds' cfg and used + * vty 'interference-meas level-bounds': explain duality in ordering + * add test_dyn_ts_favor_static_ts_as_target.ho_vty + * extend test_dyn_ts_favor_half_used_tch_h_as_target.ho_vty + * RES IND: allow empty Resource Information IE + * RES IND: tweak error code on missing Resource Information IE + * fix CM Re-Establishment Request: allocate new A conn + * log: fix missing newline in lchan_select.c + * debug log: indicate change of primary lchan on a conn + * vty: lchan deact: allow omitting the lchan type arg + * vty: improve err msg for invalid subslot nr + * coverity: quench null deref warning in gscon_change_primary_lchan() + * lchan_fsm_post_activ_ack(): return upon release + * introduce gsm48_lchan_and_pchan2chan_desc() + * error log: improve lchan lookup error msg + * early IMM ASS 1/n: add vty config option + * early IMM ASS 2/n: implement 'pre-chan-ack' + * early IMM ASS 3/n: implement 'pre-ts-ack' + * stat_item desc: add explicit indexes for clarity + * vty: add "msc N bssmap reset" command + * move BSC level stats and rate counters to new bsc_stats.[hc] + * add stat items bsc.0.num_msc:connected, .num_msc:total + * add stat_items for BTS and TRX connection stati + * fixup for Early IMM ASS: use proper TSC + * add CTRL 'rf_states' and 'bts.N.rf_states' + * add CTRL bts.N.trx.M.rf_locked (RW) + * fixup comments for 'rf_states' CTRL command + * fix comment in lchan_fsm.c: s/modification/activation + * fix TSC / TSC Set used for Handover + * tsc fixup: tweak condition for coverity + * drop obsolete comment + * stat: add bts.N.num_trx:total + * stat: add bts.N.num_trx:rsl_connected + * constify lchan_state_is() + * add chreq:successful_ rate counters + * drop unused gsm48_tx_mm_serv_ack() + * for linter: s/while(0)/while (0) + * cosmetic tweaks on handover counting code + * tweak intra-bsc ho counter descriptions + * implement incoming_intra_bsc_ho:* rate counters + * refactor lchan counting + * add time_cc API: cumlative counter for time, reported as rate_ctr + * implement all_allocated:{sdcch,tch} rate counters + * implement all_allocated:{static_sdcch,static_tch} rate counters + * implement bts.N.cm_serv_rej: rate counters + * move time_cc to libosmocore osmo_time_cc + + [ Keith ] + * Ignore CHANnel ReQuireD with Access Delay IE > 63 + * Fix MEAS parsing, as Ericsson RBS reports TA shifted by 2 bits. + * Add vty command to manually force MS Uplink Power + * Implement MS Uplink Power Control Loop + + [ Vadim Yanitskiy ] + * [hopping] vty: ensure no duplicate hopping ARFCN entries + * [hopping] generate_cell_chan_list(): make some pointers const + * [hopping] gsm48_send_rr_ass_cmd(): use Cell Channel Description from SI1 + * [hopping] generate_ma_for_ts() returns no meaningful value + * abis_nm: rework warnings about unknown / not supported features + * abis_nm: cosmetic: use osmo_bts_feature_name() + * [hopping] Rework generation of Cell/Mobile Allocation + * [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again + * vty: deprecate BTS type 'sysmobts' in favor of 'osmo-bts' + * Replace all references to 'sysmobts' with 'osmo-bts' + * VTY: fix NULL-pointer dereference in lchan_act_single() + * bts_uptime(): do not spam logs with 'OML link uptime unavailable' + * Make interference measurement parameters configurable + * VTY: fix typo in a command description: s/send/sent/ + * PCUIF protocol: add message definition for interference report + * abis_rsl: fix rsl_rx_ccch_load(): properly check the message length + * gsm_data.h: remove declaration of non-existing ts_pchan() + * power_control: omit BS Power Parameters IE if the maximum is 0 dB + * power_control: implement BCCH carrier power reduction operation + * power_control: constrain BS power reduction on BCCH carrier + * lchan_fsm: fix potential NULL-pointer dereference + * gsm_04_08_rr: silently ignore RR UTRAN Classmark Change + * rsl_rx_resource_indication(): check result of rsl_tlv_parse() + * rsl_lchan_lookup(): fix handling of ABIS_RSL_CHAN_NR_CBITS_OSMO_PDCH + * [overpower] VTY: cosmetic: fix lower case in command description + * [overpower] VTY: fix copy-pasted warning message + * [overpower] VTY: add more ACCH overpower related parameters + * [overpower] Add VTY transcript tests for all commands + * .gitignore: also ignore *.la files + * .gitignore: remove non-existing ipaccess-firmware binary + * lchan_fsm: cosmetic: move a 'case' below the 'default' branch + * rsl_tx_chan_activ(): fix manual channel activation for nanoBTS + * abis_rsl: do not pass lchan to print_meas_rep_buf() + * abis_rsl: print_meas_rep_{buf,uni}() accept const *mr + * abis_rsl: permit simultaneous ACCH repetition and overpower + * ipaccess-config: reduce verbosity of the OML logging + * ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] + * ipaccess-config: warn about unknown flag name + * doc/manuals: add documentation for interference reporting + * gsm_data: use ascending order for interference boundaries + * doc/manuals: add documentation for Temporary ACCH Overpower + * doc/manuals: fix wrong CI in the inter-BSC handover diagram + * tests/Makefile.am: do not try removing non-existing files + * abis_rsl: simplify checking if channel mode is AMR + * abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() + * bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch + * struct gsm_bts: simplify comments for ACCH repetition/overpower + * struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g + * struct gsm_bts: s/temporary_overpower/top_acch_cap/g + * abis_rsl: {rep,top}_acch_cap_for_bts(): make *lchan const + * abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g + * [overpower] Allow configuring specific channel mode(s) + * [overpower] By default, permit only for speech channels using AMR + + [ Alexander Chemeris ] + * stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal. + + [ Pau Espin Pedrol ] + * cosmetic: Fix typo in func description + * bssap: pass whole tlv_parsed to event GSCON_EV_A_COMMON_ID_IND + * Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID + * Revert "update neighbor ARFCNs on startup and config changes" + * SRVCC: Parse Last Used E-UTRAN PLMN Id in Handover Request + * SRVCC: Forward Last EUTRAN PLMN Id in Handover Required + * osmo-bsc: Avoid erroring every few secs about unconnected BTS + * Fix bts->description field not printed in config write + * ipaccess-config: Clean up sign_link setup helper + * bsc: Clean up TS selection in ipaccess_sign_link_up/down + * bsc: Use osmo_clock_gettime everywhere + * ctrl: Introduce CTRL SET cmd to apply VTY cfg file + * ctrl: Avoid fclose() on NULL pointer + * Use new stat item/ctr getter APIs + * vty: Drop unused old node enum fields + * Introduce VTY command to disable srvcc fast-return on target BTS + * Introduce counters to track SRVCC procedures + * pcuif_proto.h: Add new container messages + * Support proto IPAC_PROTO_EXT_PCU BSC<->PCU + * lchan-select: Avoid setting variable for no reason + * assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_ERROR + * assignment_fsm: Add assert to guard ptr access + * Rename osmo dyn ts enums to contain SDCCH8 + * Support SDCCH8 in osmo dyn ts + * lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in WAIT_RF_RELEASE_ACK + * doc: bts.adoc: Update dyn ts section to include SDCCH8 support + * lchan_fsm: Improve timeout logging line in state WAIT_RLL_RTP_ESTABLISH + * Avoid switching dyn ts to sdcch8 if it starves later TCH + * cosmetic: Small improvements to _select_sdcch_for_call + * Add new lchan_select_set_type() API helper + * _select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it + * lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in state BORKEN + * abis_rsl: Log chan rqd reason on resource exhaustion log message + * Fix recent regression in CHREQ allocation + * Split bsc_vty.c creating bts_vty.c + * Split bts_vty.c creating bts_trx_vty.c + * Introduce libbsc to avoid linking long lists of .o files + * Introduce VTY option to forbid use of TCH for non-voicecall signalling + * Clarify string name for GSM_CHREQ_REASON_CALL + * doc: Improve ACC ramp documentation + * doc: manual: Fix typo in text + * vty: Fix wrong TSC sent when activating lchan through VTY + * vty: Fix wrongs params passed in vty warning message + * cosmetic: power_ctrl_params_def: Fix typo in comment + * doc: power_control.adoc: Improve VTY snippet foot notes + * MS Power Control Loop: Support set up of C/I parameters for osmo-bts + * doc: power_control.adoc: Add small time graph showcasing P_CON_INTERVAL + * lchan_fsm: Fix comment + * lchan_fsm: Fix comment + * lchan_fsm: Avoid inheriting bs_power from old lchan + * Support Neighbor Address Resolution over PCUIF IPA multiplex + * Power Control Loop: Set P_CON_INTERVAL to 1 by default + * MS Power Control Loop: Support turn off C/I based logic + * bts_vty: Print C/I power params for osmo-bts only + * MS Power Control Loop: Allow Turn off/on C/I independent from value setting + * cosmetic: fix comment typos in signal.h + * cosmetic: Fix typo in comment + * MS Power Control Loop: Use P_CON_INTERVAL=2 by default + * bts_trx: Fix timeslot_fsm not properly freed during trx free() [1/4] + * Move global var bsc_gsmnet into libbsc [2/4] + * Move ts_fsm_init to static constructor [3/4] + * Get rid of lots of stubs [4/4] + * nm_channel_fsm: drop ipa link if SetChannelAttr fails + * gitignore: Fix typo + * jenkins.sh: Fix typo + * Set subslots_per_pchan[GSM_PCHAN_OSMO_DYN] = 8 + * timeslot_fsm: Add assert to make sure we never go out of bounds in ts->lchan array + * Set subslots_per_pchan_vamos[GSM_PCHAN_OSMO_DYN] = 0 + * assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() + * lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() + * Properly handle dyn TS TCH with vamos after updating subslots_per_pchan + + [ Michael Iedema ] + * stats: add BTS uptime counter + + [ Philipp Maier ] + * bts.adoc: fix typo BGSGP -> BSSGP + * handover_cfg: add missing VTY_CMD_PREFIX in comment + * bsc_ctrl_commands: add command to write vty config + * control.adoc: add doc for apply-config-file + * bsc_vty: add vty option to allow call-reestablishment + * handover_ctrl: add control interface for handover settings + * running.adoc: explain mgw reset-endpoint VTY setting + * osmo_bsc_main: remove unused commandline option -l + * bty_vty: add VTY settungs for temporary overpower + * osmo_bsc_main: integrate MGW pooling into osmo-bsc + * osmo_bsc_msc: do not initalize MGCP proxy for AoIP MSCs + * doc/mgwpool: update documentation + * assignment_fsm: make assignment_fsm_timer_cb static + * assignment_fsm: make assignment_fsm_allstate_action static + * assignment_fsm: Check for conn->lchan + * osmo_bsc_main: remove code dup in bootstrap_bts() + * bts: set R99 MSC flag in SI13 in bts_alloc + * bts: set pwrc value in bts_alloc + * bts: set acs value in bts_alloc + * drop chan_load_samples_idx initalization from bootstrap_bts() + * bts: set ncc_permitted from bts_alloc + * osmo_bsc_main: remove not longer needed fixme note + * osmo_bsc_main: remove unused option -t --testmode + * bsc_subscr_conn_fsm: fix mgw-pool ref counting + * neighbor_ident: add comment about Neighbor Address Resolution Service + * control.adoc: improve description of command bts.N.send-new-system-informations + * heighbor_ident: add/del neighbor cells via ctrl interface + * bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface + * control.adoc: comment out fixme note + * osmo_bsc_main: bootstrap_bts: print errornous ARFCN number + * osmo_bsc_main: separate checks from bootstrap_bts + * osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts + * osmo_bsc_ctrl: make sure strtok results are checked + * osmo_bsc_main: call bootstrap_bts when OML TEI comes up + * osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() + + [ Eric ] + * vty: allow A5/4 encryption in config + + [ Daniel Willmann ] + * bts: Clear BTS_STAT_CHAN_*_{TOTAL,USED} on bts disconnect + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:21:59 +0100 + osmo-bsc (1.7.0) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index a135119..7ed4694 100644 --- a/debian/control +++ b/debian/control @@ -12,12 +12,12 @@ python3-minimal, libcdk5-dev, libtalloc-dev, - libosmocore-dev (>= 1.5.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-abis-dev (>= 1.1.0), + libosmocore-dev (>= 1.6.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.2.0), libosmo-netif-dev (>= 1.1.0), - libosmo-mgcp-client-dev (>= 1.8.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-mgcp-client-dev (>= 1.9.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-bsc.git Vcs-Browser: https://git.osmocom.org/osmo-bsc/ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 Gerrit-Change-Number: 26285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:31:34 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 16 Nov 2021 16:31:34 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcu=5Bmaster=5D=3A_Bump_version=3A_0=2E9=2E0=2E280-56b7c-dirty_=E2=86=92_1=2E0=2E0?= In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26282 ) Change subject: Bump version: 0.9.0.280-56b7c-dirty ? 1.0.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I38b083755e71eac5158e68ef958e210eeced9038 Gerrit-Change-Number: 26282 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Tue, 16 Nov 2021 16:31:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:32:06 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 16 Nov 2021 16:32:06 +0000 Subject: =?UTF-8?Q?Change_in_osmo-trx=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E1=2E28-019d-dirty_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/26279 ) Change subject: Bump version: 1.3.1.28-019d-dirty ? 1.4.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie675909593b0c383b59b7b4a4edd46cd93283622 Gerrit-Change-Number: 26279 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Tue, 16 Nov 2021 16:32:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:32:54 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 16 Nov 2021 16:32:54 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bts=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E348-f42287-dirty_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26281 ) Change subject: Bump version: 1.3.0.348-f42287-dirty ? 1.4.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibf3ce0bfd0cf67148229dd988ebde6e6b8d744cc Gerrit-Change-Number: 26281 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Tue, 16 Nov 2021 16:32:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:37:00 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 16 Nov 2021 16:37:00 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bsc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E359-d13ef-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26285 ) Change subject: Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 ...................................................................... Patch Set 1: > checking for LIBOSMOMGCPCLIENT... no > configure: error: Package requirements (libosmo-mgcp-client >= 1.9.0) were not met: > > Requested 'libosmo-mgcp-client >= 1.9.0' but version of Osmocom Media Gateway Control Protocol Client library is 1.8.1.90-aac8 This fails because osmo-mgw isn't merged yet? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 Gerrit-Change-Number: 26285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel Gerrit-Comment-Date: Tue, 16 Nov 2021 16:37:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:37:43 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 16 Nov 2021 16:37:43 +0000 Subject: =?UTF-8?Q?Change_in_osmo-mgw=5Bmaster=5D=3A_Bump_version=3A_1=2E8=2E1=2E90-aac8-dirty_=E2=86=92_1=2E9=2E0?= In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26283 ) Change subject: Bump version: 1.8.1.90-aac8-dirty ? 1.9.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icfc615c0d7d826269962b0d94fbe53c2f8adfdaf Gerrit-Change-Number: 26283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Tue, 16 Nov 2021 16:37:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:38:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 16:38:28 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bsc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E359-d13ef-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26285 ) Change subject: Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 Gerrit-Change-Number: 26285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: daniel Gerrit-Comment-Date: Tue, 16 Nov 2021 16:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:38:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 16:38:54 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E27-f8ed-dirty_=E2=86=92_0=2E8=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26284 ) Change subject: Bump version: 0.7.0.27-f8ed-dirty ? 0.8.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ibbef3cc3bf1f468309e73f5dda497dca1a03c815 Gerrit-Change-Number: 26284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 16:38:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:39:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 16:39:53 +0000 Subject: =?UTF-8?Q?Change_in_osmo-mgw=5Bmaster=5D=3A_Bump_version=3A_1=2E8=2E1=2E90-aac8-dirty_=E2=86=92_1=2E9=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26283 ) Change subject: Bump version: 1.8.1.90-aac8-dirty ? 1.9.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icfc615c0d7d826269962b0d94fbe53c2f8adfdaf Gerrit-Change-Number: 26283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 16:39:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:40:02 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 16 Nov 2021 16:40:02 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E27-f8ed-dirty_=E2=86=92_0=2E8=2E0?= In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26284 ) Change subject: Bump version: 0.7.0.27-f8ed-dirty ? 0.8.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ibbef3cc3bf1f468309e73f5dda497dca1a03c815 Gerrit-Change-Number: 26284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 16:40:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:41:18 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 16:41:18 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26280 to look at the new patch set (#3). Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... cards: select_adf_by_aid: split off aid completion The function select_adf_by_aid first searches for the complete AID in the set of AIDs that were read from EF.DIR. Lets put this task into a separate helper method Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 --- M pySim/cards.py 1 file changed, 25 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/80/26280/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:43:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:43:45 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bsc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E359-d13ef-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26285 ) Change subject: Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 ...................................................................... Patch Set 1: > > This fails because osmo-mgw isn't merged yet? Yes! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 Gerrit-Change-Number: 26285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: daniel Gerrit-Comment-Date: Tue, 16 Nov 2021 16:43:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:45:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:45:16 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcu=5Bmaster=5D=3A_Bump_version=3A_0=2E9=2E0=2E280-56b7c-dirty_=E2=86=92_1=2E0=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26282 ) Change subject: Bump version: 0.9.0.280-56b7c-dirty ? 1.0.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I38b083755e71eac5158e68ef958e210eeced9038 Gerrit-Change-Number: 26282 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 16:45:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:45:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:45:18 +0000 Subject: =?UTF-8?Q?Change_in_osmo-pcu=5Bmaster=5D=3A_Bump_version=3A_0=2E9=2E0=2E280-56b7c-dirty_=E2=86=92_1=2E0=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26282 ) Change subject: Bump version: 0.9.0.280-56b7c-dirty ? 1.0.0 ...................................................................... Bump version: 0.9.0.280-56b7c-dirty ? 1.0.0 Change-Id: I38b083755e71eac5158e68ef958e210eeced9038 --- M TODO-RELEASE M configure.ac M contrib/osmo-pcu.spec.in M debian/changelog M debian/control 5 files changed, 310 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 5b2720b..cbfda24 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,5 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore struct bssgp_bvc_ctx->is_sgsn field used available only on libosmocore >1.5.1 -libosmocore gprs_ns2_ip_bind_set_priority function used available only on libosmocore >1.5.1 diff --git a/configure.ac b/configure.ac index 31ead00..31ef189 100644 --- a/configure.ac +++ b/configure.ac @@ -82,11 +82,11 @@ fi dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) AC_MSG_CHECKING([whether to enable direct DSP access for PDCH of sysmocom-bts]) AC_ARG_ENABLE(sysmocom-dsp, diff --git a/contrib/osmo-pcu.spec.in b/contrib/osmo-pcu.spec.in index 96e9481..eec0ce2 100644 --- a/contrib/osmo-pcu.spec.in +++ b/contrib/osmo-pcu.spec.in @@ -28,11 +28,11 @@ %if 0%{?suse_version} BuildRequires: systemd-rpm-macros %endif -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 %{?systemd_requires} %description diff --git a/debian/changelog b/debian/changelog index dc42c0c..600969c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,301 @@ +osmo-pcu (1.0.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Support uplink multi-slot allocations + * tbf: Log timeslot allocation failure + * bts: Count TBF TS allocation failure + * pdch: Standarize and improve logging + * tbf: Improve logging when TBF being allocated or no TBF avail + * Remove uneeded ms param from alloc_algorithm_func_t func + * bts: Add new stats to detect TBF allocation failure reasons + * llc: use memset to fill llc dummy frame padding + * tbd_dl: Don't re-initialize class field twice + * tbf: log keep_open condition status + * tbf_dl: Fix m_last_dl_drained_fn not set under some conditions + * tbf_dl: fix FBI not set upon X2031 = 0 + * ms: clarify delayed MS release process related code and logging + * gprs_ms: Use standarized logging on more messages + * sched: sched_select_ctrl_msg(): Clean up param list and improve logging + * sched: sched_select_downlink(): Clean up param list and improve logging + * TODO-RELEASE: document requirement of master libosmocore + * tbf: Log N310* counter increments + * pdch: Silently ignore DATA.ind with len=0 + * direct_phy: Support submitting DATA.ind with len=0 to upper layers + * pcu_utils.h: Fix trailing whitespace + * Track TDMA clock with DATA.ind instead of TIME.ind + * Introduce init() APIs for PDCH and TRX objects + * tests: rlcmac: Fix C vs C++ linkage of extern symbol + * pdch.h: Drop uneeded include bts.h + * Improve DATA.ind logging + * Improve logging in DATA.req and ACT.req + * tbf: Fix wrong variable printed in log + * pdch: Log FN when decoding UL Ctrl block + * Add new PDCH UL Controller, drop SBAllocator class + * Replace PollController with newly added PDCH UL Controller + * sched: Use new PDCH UL Controller + * bts: Detect FN jumps + * cosmetic: tests/Makefile.am: Split content into several lines + * tests: Introduce unit tests for PDCH UL Controller + * tests: ulc: Show current bug with FN wrap around + * ulc: Fix FN store order upon wrap around + * sysmo: fix wrong FN jumps in rx RA.ind + * direct_phy: Fix condition dropping rx DATA.ind payload in in + * Fix: left shift cannot be repesented in type int + * sched: Fix scheduling UL TBF not matching conditions + * sched: Simplify usf selection code + * Set matching USF if available when polling a UL TBF + * pdch: Add mising pdch_ulc_release_node in Rx Cell Change Notif + * pdch_ulc: Create helper API pdch_ulc_release_node + * Track scheduled UL blocks through USF + * Properly implement N3101 + * sba: Document AGCH_START_OFFSET after some experimental tests + * pdch_ulc: Optimize rbtree FN search + * Pick unreserved UL FN when allocating an SBA + * pdch_ulc: Support picking RRBP other than N+13 + * Drop unused function tbf_check() + * pdch_ulc: Store TBF poll reason + * tbf: Get rid of unneeded poll_scheduled() + * tbf: Allow multiple concurrent polls + * Remove unneeded poll_state check + * tbf: get rid of poll_state completely + * Get rid of param 'poll' with constant value + * tbf: Get rid of attribute poll_fn + * tbf: Get rid of attribute poll_ts + * RIM: Improve logging + * sba: Drop unused function find_sba_rts + * pdch: rcv_resource_request: Improve robustness + * pdch: tbf_by_tfi(): Allow returning TBFs in state RELEASING + * Stop abusing T3169 + * Make use of T3142 received from BTS + * Use negative numbers for non-spec osmo-specific timers + * ul_tbf: Clean up handle_tbf_reject() + * Make WaitIndication T3172 configurable + * sched: Simplify else-if condition + * Clarify, document Assignment related timers + * doc/tbf.txt: Update and improve some information + * bts: constify arg in func bts_ms_store() + * sched: Rename func to describe its used only for RLCMAC CTRL blocks + * rim: Constify param in func + * Simplify helper function tbf_select_slot_set() + * alloc_algorithm_b: Rearrange variable initialization + * Rename function s/tbf_alloc_ul/tbf_alloc_ul_pacch/ + * Split ul_tbf alloc on CCCH into new function + * Implement T3141 + * tbf_ul: Use is_tlli_valid() API + * Tx ul ack/nack: Avoid sending invalid/unknown TLLI + * encoding: Use gsm48_ta_is_valid() API + * encoding: Encode TA in UL ACK/NACK if available + * sched: Clean up helper function and improve logging + * Drop existing tbf->ms() check condition + * ul_tbf: Simplify function rcv_data_block_acknowledged + * ul_tbf: Fix accessing zeroed block when checking if transfer is complete + * sched: Clean up param passing and improve logging + * pdch: Use llist_first_entry() API + * RIM: Refactor Rx path to decode stack in proper order + * Clean false positive in newer GCC version checking guard of else clause + * Use LOGPDCH macro in bts_add_paging() + * Optimize PAGING-CS PDCH set selection when target MS is known + * bts: Use ms_store when calculating set of target PDCHs for Pkt Paging Request + * tbf: Log error path in setup() failing to assign control TS + * Move TBF list from BTS to the TRX structure + * MsTest: Set up tbf talloc destructor + * tbf: Move existing tbf_state implementation to osmo_fsm + * cosmetic: Fix typo s/TIMSI/TMSI/ + * gsm_rlcmac.c: Fix arg list of 2 callbacks + * csn1: Implement CSN_CALLBACK type in encoder + * bts: Fix typo in field name + * Use new stat item/ctr getter APIs + * pdch: Log pdch_ulc reason upon rx of pkt ctrl ack + * pcuif: Support receiving System Information 2 + * pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack + * pcuif_proto.h: Add new container message + * Support proto IPAC_PROTO_EXT_PCU BSC<->PCU + * pdch: Fix heap-use-after-free in pdch->ulc + * Make gcc 11.1.0 false positivies happy + * tbf: Drop impossible paths in create_dl_ass() + * tests/tbf: Fix null pointer access if slowly stepping with gdb + * Revert "coverity: fix null deref from recent UL TBF leak fix" + * Revert "fix: handle NULL return of as_dl_tbf() and as_ul_tbf()" + * Revert "Revert "Stop abusing T3169"" + * Move NULL and ASSIGN tbf_state transition to tbf_fsm + * Move FLOW tbf_state transition to tbf_fsm. + * tests: tbf: Fix dl_tbf polled for data without being in FLOW state + * Move FINISHED tbf_state transition to tbf_fsm + * Move WAIT_RELEASE tbf_state transition to tbf_fsm + * Move RELEASING tbf_state transition to tbf_fsm + * Move T3169 and T3195 to tbf_fsm + * Drop duplicate log line + * Put dl_tbf::cleanup into destructor + * Drop logging last mas report before freeing TBF + * Remove duplicate call to gprs_rlcmac_lost_rep + * Move rate_ctr free to tbf subclass destructor + * Get rid of tbf_dl:abort() + * tbf_free: Get rid of uneeded tbf_state transition + * Replace ul_ass_state with osmocom FSM + * tbf: Reimplement rlcmac_diag() and make it available from C + * tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS + * replace dl_ass_state with osmocom FSM + * tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_DL_ASS + * tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_UL_DATA + * Move timer X2001 to tbf_fsm + * Get rid of lots of code only used by tests + * tbf: Merge handle_ack_nack() into rcvd_dl_ack() + * Fix typos in comments documenting fsm st chg macro + * tbf: Use type bool for upgrade_to_multislot + * Move timer X2002 to tbf_fsm + * tbf_dl: Clarify requirements for DL ACK/NACK + * tbf.h: Improve documentation on several flags + * Move tbf ul_ack_state to osmocom FSM + * Simplify tbf::set_polling() + * tbf: Move T3193 to tbf_state FSM + * fix typo 's/dowlink/downlink/g' + * cosmetic: Fix typo in comment + * sched: energy saving: Avoid Tx dummy blocks on empty PDCH TS + * Fix crash with dyn TS when using direct pcu + * Use LOGPDCH macro to standarize log line + * cosmetic: sysmo: Drop unneded comment line + * bts: Use public getter instead of class member + * sched: Lower log level of RTS on disabled pdch + * pdch: Make sure pending ImmAssRej scheduled for disabled pdch are dropped + * Support Neighbor Address Resolution over PCUIF IPA multiplex + * nacc_fsm: Move logic checking if SI is being waited for to a func helper + * scheduler: Skip Tx DL idle blocks in TRX0 when not in DIRECT_PHY mode + * PTCCH: skip Tx DL idle blocks when possible + * tbf_ul_ass_fsm.c: Fix missing state transition in FSM description + * tbf: poll_timeout(): Validate expected poll reason + * nacc: Introduce helper function nacc_fsm_exp_ctrl_ack() + * tbf: refactor poll_timeout() with a switch statement + * tests: TbfTest: Fix wrong behavior in test_tbf_dl_reuse() + * pdch: refactor rcv_control_ack() with a switch statement + * cosmetic: Fix missing space + * assert if tbf pointer for POLL event is NULL + * tbf_fsm: Ignore event DL_ACKNACK_MISS in state RELEASING + * tests: RLCMACTest: Add one more sample RA capabilities to suite + * rlcmac: Fix CSN1 definition for DownlinkDualCarrierCapability_r7_t in MS RA cap + * tbf: Assert if FSM allocation fails + * sched: Rename function + * pdch: Only release ULC entry if rx ul block matches the expected one + * pdch: Validate poll reason matches in rcv_control_(egprs)_dl_ack_nack() + * pdch: PktResReq: Avoid releasing ULC entry if expecting something else on UL + * Handle Final UL ACK/NACK Confirmation in tbf_fsm + * tbf_fsm: rename state NULL -> NEW + * pdch_ulc: Log POLL reason upon timeout + * tbf_dl_ass_fsm: Move block msg generation conditions to rts() function + * tbf_ul_ass_fsm: Fix use of incorrect log macro + * tbf_fsm: Handle MAX_N3105 in state ASSIGN + * tbf: Use define to flag control_ts unset special value + * tbf: Document temporary change of control_ts and move code assigning it back to FSM + * Return void in tbf_assign_control_ts() + * pdch: rcv_data_block: Avoid releasing ULC entry if expecting something else on UL + * tbf: Avoid keeping poll nodes in pdch_ulc of temporary control_ts used during PACCH assignment + * tbf_ul_ass_fsm: Avoid retrying Pkt Ul Ass if tbf is not in state ASSIGN + * Abort scheduling of pending Pkt Ul Ass if tbf goes into RELEASE step + * tbf: Drop pending polls during free also on states != ASSIGN + * pdch: Simplify code path allocating UL TBF + * pdch: Log reason of expected POLL when receiving unexpected UL data + * bts_rcv_rach(): Gather pointers to data objects early and use them later + * bts_rcv_rach(): Split code paths for Ass and Ass Rej + * Get rid of tbf tsc field + * ts_alloc: Rename s/tbf_/tbf/ + * tbf: Update FSM names when TFI change during tbf_update() + * tbf_fsm: Add assert verifying X2002 only triggers for DL TBF + * tbf: Assert if update() is called on UL TBF + * tbf: update(): return negative val on error + * tbf: Drop unneeded braces in one line condition + * cosmetic: Fix typo in comment + * pcuif: Submit data_req with len=0 as idle frames + * Split csn1.c into common, enc and dec files + * csn1: Add unit test showing RadioAccess Capability decoding failure + * csn1: Avoid failing if optional DownlinkDualCarrierCapability_r7 is missing + * csn1: Avoid storing existence bit as true if content was actually NULL + * csn1_dec.c: Fix stored bit in CSN_NEXT_EXIST_LH + * bts: Fix misleading log line in bts_rcv_rach() + * tbf_ul: Document context where tbf_alloc_ul_ccch() is used + * bts: Rename 11bit RACH request counter + * vty: Avoid crash in tbf_print_vty_info with null ptr ctrg + * vty: Log tbf_state when showing a TBF + * vty: show tbf: Drop unneeded check for non-null ms + * bts: Introduce new RACH req counters for one/two phase access + * bts: Improve logging to clarify RACH req is for 2 phase access + * bts: Count RACH Request with unexpected content + * tbf: Increase log level of line about unable to allocate poll for TBF + * pdch: Improve log line and increase log level + * tbf_ul: Set first_(common_)ts in handle_tbf_reject + * tbf: Set m_created_ts in constructor + * tbf: Mark initial first_(common_)ts with special value + * tbf: Set tfi to initial special value + * bts: Add counters for successful 1,2 phase pkt access + * tbf_ul: Update FSM names for dummy reject TBFs + * cosmetic: Add parenthesis around expression to clarify it + * pdch::rcv_resource_request(): Use local var to store bts pointer + * tbf_ul: Improve documentation of tbf_alloc_ul_pacch() + * Add counter for successful contention resolution procedures + * doc: Update counters_generated.adoc using osmo_vty_interact.py + * bts_pch_timer: Fix timer working only for MI type IMSI + * tests/alloc: Extend test_bts_pch_timer() to validate MI type TMSI + * bts_pch_timer: Avoid resend Paging Request over PCUIF if T3113 is armed + * pdch: Log line detaching TBF at start of the function + * pdch: Log TS enable/disable transitions + * pdch: Log DL TBF originating the new UL TBF + * ts_alloc: Simplify tfi_find_free logic + * ts_alloc: rename function to clraify what it does + * ts_alloc: rename variable to clarify meaning + * pdch: Update ms_reserved_slots in GprsMS when TS becomes disabled + * pdch: Drop previous UL TBF from MS who sent PktResReq through SBA + * pdch: Increase log level of line informing about TS control change + * tbf_ul_ass_fsm: Log both TBFs if old TBF is handling assignment for new one + * cosmetic: gprs_pcu.h: Fix typo in comment + * tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one + * tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent + * tbf_{dl,ul}_ass_fsm.c: use proper macro to log tbf + * pcu_main: Mark -r cmdline param as deprecated + * vty: Introduce command 'gsmtap-remote-host' and 'gsmtap-category enable-all' + * Fix MS ending up with assigned imsi 000 + * bts: Add counter availablePDCHAllocatedTime + * tbf_dl_ass_fsm: Drop unsued X2000 timer callback + * T_defs_pcu: Set default val for X2000 to 0 ms + * Move T3172 T_defs_bts->T_defs_pcu to have it configurable in VTY + + [ Alexander Couzens ] + * gprs_bssgp_pcu: rework BSSGP Reset messages to support SGSN originated BSSGP-RESET + * gprs_bssgp_pcu: ensure only known BVCI can be resetted by the SGSN + * gprs_bssgp_pcu: add comments to the pcu states + + [ Harald Welte ] + * pdch_ul_controller: Fix compiler warning on gcc-10.2 + * manual: remove revhistory, as we don't maintain it manually anyyway + * manual: Update copyright years + * vty: Add configuration for Gb DSCP and socket priority + * manual: Include QoS chapter and add osmo-pcu specific example + + [ Vadim Yanitskiy ] + * gprs_rlcmac_sched: fix incorrect length for CTR_RLC_DL_BYTES + * PCUIF protocol: add message definition for interference report + * pcu_l1_if: ignore PDCH interference reports, do not log errors + + [ Oliver Smith ] + * test: add 'make update_exp' target + * Add counters: pcu.sgsn.N.rx_paging_{cs,ps} + * Add counters: pcu.bts.N.pch.requests + * Add counters: pcu.bts.N.pch.requests.timeout + * bts: delete pch_timer list in destructor + * tests: make update_exp: build check_PROGRAMS first + * debian/control: remove dh-systemd build-depend + * Add stats: pcu.bts.N.pdch.available/occupied + * Add stats: pcu.bts.N.pdch.occupied.gprs/egprs + * pdch: has_gprs_only_tb_attached: use m_num_tbfs + + [ Neels Hofmeyr ] + * T_defs_bts: remove unit from doc strings + * Revert "Stop abusing T3169" + * fix: handle NULL return of as_dl_tbf() and as_ul_tbf() + * coverity: fix null deref from recent UL TBF leak fix + + [ Daniel Willmann ] + * gprs_bssgp_pcu: Fix crash when configuring an existing ns bind + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:47:29 +0100 + osmo-pcu (0.9.0) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/debian/control b/debian/control index 0e12f2e..b332ad6 100644 --- a/debian/control +++ b/debian/control @@ -6,8 +6,8 @@ dh-autoreconf, autotools-dev, pkg-config, - libosmocore-dev (>= 1.5.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmocore-dev (>= 1.6.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Homepage: http://osmocom.org/projects/osmopcu Vcs-Git: git://git.osmocom.org/osmo-pcu -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I38b083755e71eac5158e68ef958e210eeced9038 Gerrit-Change-Number: 26282 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:45:35 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 16 Nov 2021 16:45:35 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bsc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E359-d13ef-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26285 ) Change subject: Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 Gerrit-Change-Number: 26285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 16:45:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:45:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:45:56 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E27-f8ed-dirty_=E2=86=92_0=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26284 ) Change subject: Bump version: 0.7.0.27-f8ed-dirty ? 0.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ibbef3cc3bf1f468309e73f5dda497dca1a03c815 Gerrit-Change-Number: 26284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 16:45:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:45:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:45:58 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E27-f8ed-dirty_=E2=86=92_0=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26284 ) Change subject: Bump version: 0.7.0.27-f8ed-dirty ? 0.8.0 ...................................................................... Bump version: 0.7.0.27-f8ed-dirty ? 0.8.0 Change-Id: Ibbef3cc3bf1f468309e73f5dda497dca1a03c815 --- M contrib/osmo-iuh.spec.in M debian/changelog M debian/control R debian/libosmo-ranap5.install R debian/libosmo-sabp1.install M debian/rules M src/Makefile.am 7 files changed, 61 insertions(+), 24 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/contrib/osmo-iuh.spec.in b/contrib/osmo-iuh.spec.in index f40c3db..977d35c 100644 --- a/contrib/osmo-iuh.spec.in +++ b/contrib/osmo-iuh.spec.in @@ -58,17 +58,17 @@ %description -n libosmo-hnbap-devel Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -%package -n libosmo-ranap3 +%package -n libosmo-ranap5 Summary: Shared Library part of libosmo-ranap Group: System/Libraries -%description -n libosmo-ranap3 +%description -n libosmo-ranap5 Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) %package -n libosmo-ranap-devel Summary: Development files for Osmocom RANAP library Group: Development/Libraries/C and C++ -Requires: libosmo-ranap3 = %{version} +Requires: libosmo-ranap5 = %{version} %description -n libosmo-ranap-devel Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) @@ -91,17 +91,17 @@ %description -n libosmo-rua-devel Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -%package -n libosmo-sabp0 +%package -n libosmo-sabp1 Summary: Shared Library part of libosmo-sabp Group: System/Libraries -%description -n libosmo-sabp0 +%description -n libosmo-sabp1 Osmocom code for the SABP (service area broadcast protocol) interface %package -n libosmo-sabp-devel Summary: Development files for Osmocom SABP library Group: Development/Libraries/C and C++ -Requires: libosmo-sabp0 = %{version} +Requires: libosmo-sabp1 = %{version} %description -n libosmo-sabp-devel Osmocom code for the SABP (service area broadcast protocol) interface @@ -131,12 +131,12 @@ %post -n libosmo-hnbap0 -p /sbin/ldconfig %postun -n libosmo-hnbap0 -p /sbin/ldconfig -%post -n libosmo-ranap3 -p /sbin/ldconfig -%postun -n libosmo-ranap3 -p /sbin/ldconfig +%post -n libosmo-ranap5 -p /sbin/ldconfig +%postun -n libosmo-ranap5 -p /sbin/ldconfig %post -n libosmo-rua0 -p /sbin/ldconfig %postun -n libosmo-rua0 -p /sbin/ldconfig -%post -n libosmo-sabp0 -p /sbin/ldconfig -%postun -n libosmo-sabp0 -p /sbin/ldconfig +%post -n libosmo-sabp1 -p /sbin/ldconfig +%postun -n libosmo-sabp1 -p /sbin/ldconfig %if 0%{?suse_version} %pre %service_add_pre osmo-hnbgw.service @@ -165,8 +165,8 @@ %{_libdir}/libosmo-hnbap.so %{_libdir}/pkgconfig/libosmo-hnbap.pc -%files -n libosmo-ranap3 -%{_libdir}/libosmo-ranap.so.3* +%files -n libosmo-ranap5 +%{_libdir}/libosmo-ranap.so.5* %files -n libosmo-ranap-devel %dir %{_includedir}/osmocom/ @@ -185,8 +185,8 @@ %{_libdir}/libosmo-rua.so %{_libdir}/pkgconfig/libosmo-rua.pc -%files -n libosmo-sabp0 -%{_libdir}/libosmo-sabp.so.0* +%files -n libosmo-sabp1 +%{_libdir}/libosmo-sabp.so.1* %files -n libosmo-sabp-devel %dir %{_includedir}/osmocom/ diff --git a/debian/changelog b/debian/changelog index 62ce110..bfdcb95 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,40 @@ +osmo-iuh (0.8.0) unstable; urgency=medium + + [ Harald Welte ] + * hnbgw: Add missing break statement + + [ Pau Espin Pedrol ] + * iu_client: Log event sent to upper layer callback + * ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE as a result + * hnb-test: Fix typo in vty cmd description + * cosmetic: src/ranap/Makefile.am: Drop trailing whitespace + * src/tests/Makefile.am: Drop reference to non-existent RANAP_FILES var + * src/*/Makefile.am: Fix trailing whitespace + * Provide libosmo-hnbap as a public shared library + * Provide libosmo-rua as a public shared library + * move-asn1-header-files.sh: Replace original asn file path in generated asn1 header files + * README.md: Document how to re-generate code from ASN1 files + * hnbgw_rua.c: Use proper type struct + * hnbgw_cn.c: Use proper type struct + * hnb-test: Fix rc var may be used uninitialized + * src/*/Makefile.am: Copy back to srcdir the generated .c files from ASN + * src/*/Makefile.am: Use asn1c -R to avoid generating runtime code + * Update generated .c/.h after using asn1c -R param + * hnbap: Use specific prefix for HNBAP generated code + * hnbap: Drop no longer existing asn1c param -fnative-types + * hnbap: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * rua: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * sabp: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * ranap: Use asn1c flag -fcompound-names to avoid name collisions with other libs + * hnb-test: Fix memleak in hnb_read_cb + + [ Oliver Smith ] + * contrib/osmo-iuh.spec.in: fix header packaging + * contrib/osmo-iuh.spec: fix missing ldconfig lines + * Cosmetic: put asn1c parameters in separate lines + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:13:09 +0100 + osmo-iuh (0.7.0) unstable; urgency=medium [ Martin Hauke ] diff --git a/debian/control b/debian/control index f89869a..cceef39 100644 --- a/debian/control +++ b/debian/control @@ -67,7 +67,7 @@ Depends: libosmo-hnbap0 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -Package: libosmo-ranap3 +Package: libosmo-ranap5 Section: libs Architecture: any Multi-Arch: same @@ -79,14 +79,14 @@ Section: debug Architecture: any Multi-Arch: same -Depends: libosmo-ranap3 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-ranap5 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) Package: libosmo-ranap-dev Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-ranap3 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-ranap5 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) Package: libosmo-rua0 @@ -111,7 +111,7 @@ Depends: libosmo-rua0 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (HNBAP, RUA, RANAP) -Package: libosmo-sabp0 +Package: libosmo-sabp1 Section: libs Architecture: any Multi-Arch: same @@ -123,12 +123,12 @@ Section: debug Architecture: any Multi-Arch: same -Depends: libosmo-sabp0 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-sabp1 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (SABP) Package: libosmo-sabp-dev Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-sabp0 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-sabp1 (= ${binary:Version}), ${misc:Depends} Description: Osmocom code for the Iuh interface (SABP) diff --git a/debian/libosmo-ranap3.install b/debian/libosmo-ranap5.install similarity index 100% rename from debian/libosmo-ranap3.install rename to debian/libosmo-ranap5.install diff --git a/debian/libosmo-sabp0.install b/debian/libosmo-sabp1.install similarity index 100% rename from debian/libosmo-sabp0.install rename to debian/libosmo-sabp1.install diff --git a/debian/rules b/debian/rules index b85b0d2..9db7204 100755 --- a/debian/rules +++ b/debian/rules @@ -15,9 +15,9 @@ # See https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg override_dh_strip: dh_strip -plibosmo-hnbap0 --dbg-package=libosmo-hnbap-dbg - dh_strip -plibosmo-ranap3 --dbg-package=libosmo-ranap-dbg + dh_strip -plibosmo-ranap5 --dbg-package=libosmo-ranap-dbg dh_strip -plibosmo-rua0 --dbg-package=libosmo-rua-dbg - dh_strip -plibosmo-sabp0 --dbg-package=libosmo-sabp-dbg + dh_strip -plibosmo-sabp1 --dbg-package=libosmo-sabp-dbg dh_strip -posmo-hnbgw --dbg-package=osmo-hnbgw-dbg # Print test results in case of a failure diff --git a/src/Makefile.am b/src/Makefile.am index 6a8e7f4..b69d65f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -62,9 +62,9 @@ # build the shared RANAP + SABP library # HNBAP_LIBVERSION=0:0:0 -RANAP_LIBVERSION=4:0:1 +RANAP_LIBVERSION=5:0:0 RUA_LIBVERSION=0:0:0 -SABP_LIBVERSION=0:0:0 +SABP_LIBVERSION=1:0:0 lib_LTLIBRARIES = libosmo-hnbap.la libosmo-ranap.la libosmo-rua.la libosmo-sabp.la libosmo_hnbap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) libosmo_hnbap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ibbef3cc3bf1f468309e73f5dda497dca1a03c815 Gerrit-Change-Number: 26284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:47:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:47:39 +0000 Subject: Change in osmo-iuh[master]: gitignore: Ignore libsmo-{hnbap,rua}.pc References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26286 ) Change subject: gitignore: Ignore libsmo-{hnbap,rua}.pc ...................................................................... gitignore: Ignore libsmo-{hnbap,rua}.pc Change-Id: Ib66ca43017447f23ea041b466a2bf122a0a4946e --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/86/26286/1 diff --git a/.gitignore b/.gitignore index 7041f69..91912b2 100644 --- a/.gitignore +++ b/.gitignore @@ -33,7 +33,9 @@ src/tests/testsuite.log src/osmo-hnbgw tags +libosmo-hnbap.pc libosmo-ranap.pc +libosmo-rua.pc libosmo-sabp.pc m4 gen_hnbap.stamp -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib66ca43017447f23ea041b466a2bf122a0a4946e Gerrit-Change-Number: 26286 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:47:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:47:51 +0000 Subject: =?UTF-8?Q?Change_in_osmo-mgw=5Bmaster=5D=3A_Bump_version=3A_1=2E8=2E1=2E90-aac8-dirty_=E2=86=92_1=2E9=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26283 ) Change subject: Bump version: 1.8.1.90-aac8-dirty ? 1.9.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icfc615c0d7d826269962b0d94fbe53c2f8adfdaf Gerrit-Change-Number: 26283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 16:47:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:47:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:47:53 +0000 Subject: =?UTF-8?Q?Change_in_osmo-mgw=5Bmaster=5D=3A_Bump_version=3A_1=2E8=2E1=2E90-aac8-dirty_=E2=86=92_1=2E9=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26283 ) Change subject: Bump version: 1.8.1.90-aac8-dirty ? 1.9.0 ...................................................................... Bump version: 1.8.1.90-aac8-dirty ? 1.9.0 Change-Id: Icfc615c0d7d826269962b0d94fbe53c2f8adfdaf --- M TODO-RELEASE M configure.ac M contrib/osmo-mgw.spec.in M debian/changelog M debian/control R debian/libosmo-mgcp-client9.install M src/libosmo-mgcp-client/Makefile.am 7 files changed, 140 insertions(+), 28 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 3b31cde..c5a3b36 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -24,5 +24,3 @@ # If any interfaces have been removed or changed since the last public release, a=0. # #library what description / commit summary line -update dependency to libosmocore > 1.5.1 for our use of osmo_sock_set_dscp() -libosmo-mgcp-client struct mgcp_client_conf ABI breackage \ No newline at end of file diff --git a/configure.ac b/configure.ac index ddd8862..c0b7d03 100644 --- a/configure.ac +++ b/configure.ac @@ -44,13 +44,13 @@ AC_SUBST(LIBRARY_DLSYM) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.2.0) CFLAGS="$CFLAGS -pthread" LDFLAGS="$LDFLAGS -pthread" diff --git a/contrib/osmo-mgw.spec.in b/contrib/osmo-mgw.spec.in index ee85db3..c181d1f 100644 --- a/contrib/osmo-mgw.spec.in +++ b/contrib/osmo-mgw.spec.in @@ -30,29 +30,29 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmocoding) >= 1.5.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmotrau) >= 1.1.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmocoding) >= 1.6.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmotrau) >= 1.2.0 %{?systemd_requires} %description OsmoMGW is Osmocom's Media Gateway for 2G and 3G circuit-switched mobile networks. -%package -n libosmo-mgcp-client8 +%package -n libosmo-mgcp-client9 Summary: Osmocom's Media Gateway Control Protocol client library Group: System/Libraries -%description -n libosmo-mgcp-client8 +%description -n libosmo-mgcp-client9 Osmocom's Media Gateway Control Protocol client library. %package -n libosmo-mgcp-client-devel Summary: Development files for Osmocom's Media Gateway Control Protocol client library Group: Development/Libraries/C and C++ -Requires: libosmo-mgcp-client8 = %{version} +Requires: libosmo-mgcp-client9 = %{version} %description -n libosmo-mgcp-client-devel Osmocom's Media Gateway Control Protocol client librarary. @@ -90,8 +90,8 @@ %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) -%post -n libosmo-mgcp-client8 -p /sbin/ldconfig -%postun -n libosmo-mgcp-client8 -p /sbin/ldconfig +%post -n libosmo-mgcp-client9 -p /sbin/ldconfig +%postun -n libosmo-mgcp-client9 -p /sbin/ldconfig %if 0%{?suse_version} %preun @@ -119,8 +119,8 @@ %dir %{_sysconfdir}/osmocom %config(noreplace) %{_sysconfdir}/osmocom/osmo-mgw.cfg -%files -n libosmo-mgcp-client8 -%{_libdir}/libosmo-mgcp-client.so.8* +%files -n libosmo-mgcp-client9 +%{_libdir}/libosmo-mgcp-client.so.9* %files -n libosmo-mgcp-client-devel %{_libdir}/libosmo-mgcp-client.so diff --git a/debian/changelog b/debian/changelog index a2f5c4a..ec34937 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,117 @@ +osmo-mgw (1.9.0) unstable; urgency=medium + + [ Harald Welte ] + * TOS bits != DSCP + * manual: don't define fig-bsc twice + * switch from osmo_sock_set_dscp() to OSMO_SOCK_F_DSCP() + * mgw: Add support for setting socket priority from VTY + * manual: Include QoS chapter and add osmo-mgw specific example + + [ Keith ] + * Add vty command 'show mgcp active' + * Log some useful messages at ERROR/INFO instead of DEBUG + + [ Neels Hofmeyr ] + * send DLCX only once + * tweak termination DLCX log msg + * add osmo_mgcpc_ep_ci_get_remote_rtp_info() + * check_rtp_destin(): clarify log msg + * mgcp_client_fsm delete: set mgcp_client as ctx, not NULL + * mgcp_client_endpoint_fsm: on term, still let conns wait for DLCX OK + * mgcp_client_fsm: add missing log_subsys + * mgcp_client: add logging on received MGCP messages + + [ Philipp Maier ] + * mgcp_network: fix implicit address loopback + * mgcp_common, mgcp_udp_send: make parameter buf const + * mgcp_network: refactor MGCP_DUMMY_LOAD + * mgcp_client: drop nunnecessary else statement + * mgcp_client: fix error handling in mgcp message generation + * mgcp_protocol: fix loop that sends dummy RTP packets + * mgw_main: fix loop that resets all endpoints + * mgcp_trunk: drop ws line + * mgcp_ratectr: drop ws line + * mgcp_ratectr: fix sourcecode formatting + * mgcp_trunk: add value string for trunk type. + * mgcp_ratectr: refactor rate counter and set group name + * mgcp_protocol: forward declare mgcp_endpoint + * mgcp_endp: make wildcarded detection separate + * mgcp_protocol: refactor request handler array + * mgcp_trunk: use unsigned int instead of int as trunk_nr + * mgcp_protocol: refactor MGCP request handling + * mgcp_ratectr: add stats items to monitor trunk usage + * mgcp_msg: add trunk parameter to mgcp_check_param for logging + * mgcp_protocol: refactor function create_response_with_sdp + * mgcp_protocol: add support for wildcarded DLCX + * remove struct member wildcarded_req from struct mgcp_endpoint + * mgcp_lient: remove unsubstantial FIXME note + * mgcp_protocol: assert endp when it becomes mandatory + * mgcp_trunk: check MGW domain name earlier + * mgcp_ratectr: add stats items to monitor trunk usage + * mgcp_client: fix typo Initalize -> Initialize + * mgcp_protocol: get rid of policy_cb and change_cb + * mgcp_ratectr: do not set talloc destructor on library allocated item + * mgcp_client: allow to reset endpoints on startup + * mgcp_client_vty: remove unnecessary checks + * mgcp_client: do not print (null) when address is ANY + * mgcp_client: refactor function init_socket + * libosmo-mgcp-client: extend the mgcp_client for MGW pooling + * mgcp_client_vty: add missing docstrings + * mgcp_client_vty: add OSMO_ASSERT on pool parameter + * mgcp_client_vty: fix docstrings for mgw-pool + * mgcp_client_vty: cosmetic: doc string should terminated with \n + * mgcp_client_vty: fixing docstring + * mgcp_ratectr: remove unusued rate counters + * mgcp_client: fix typo in doxygen comment + * mgcp_client: add MGW name as logging context + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * constify arg in addr_is_any() + * Define patch_ssrc as bool type + * constify some function arg pointers + * mgcp_network.c: Reorder some functions in file + * mgcp_send_dummy: Check RTP destination is available before attempt tx + * mgw: rx CRCX: Avoid sending dummy rtp if remote address not provided + * Fail rx MDCX sendrecv with invalid remote addr + * Take into account Marker bit when patching RTP stream + * Use DLMGCP instead of DLGLOBAL in log lines + * Fix attribute parsing on gcc 11.1.0 + + [ neels ] + * Revert "mgcp_ratectr: add stats items to monitor trunk usage" + + [ Daniel Willmann ] + * contrib/jenkins: Use ASAN for osmo-mgw + + [ Oliver Smith ] + * mgcp_client_vty: add missing NO_STR + * Revert "Turn some compiler warnings into errors" + + [ Eric ] + * add vscode stuff to gitignore + * configure.ac: fix maybe-uninitialized for clang + * fix missing includes and forward declarations + * rename do_retransmission + * mgcp_sdp: fix potential leak + * stats: make sanitizers happy + * libosmo-mgcp: cleanup audio codex alloc + * libosmo-mgcp: atomic rate counter group indexes + * libosmo-mgcp: do not use the default msgb talloc context + * globally lock the portrange when trying to grab a port to prep for multithreading + * embed strings into structs + * adjust talloc context + * endp: do not cache cfg pointer + * add modified .clang-format + * rename strip_epname and find_specific_endpoint and make them available + * fix mgcp_conn_free_all + * fix up some docstrings that lost their dot + + [ Vadim Yanitskiy ] + * libosmo-mgcp: use OSMO_STRLCPY_ARRAY in mgcp_codec_add() + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:59:21 +0100 + osmo-mgw (1.8.1) unstable; urgency=medium * attempt to fix RPM spec file after recent soversion bump diff --git a/debian/control b/debian/control index 8246708..2ca9a13 100644 --- a/debian/control +++ b/debian/control @@ -6,10 +6,10 @@ dh-autoreconf, pkg-config, autotools-dev, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), libosmo-netif-dev (>= 1.1.0), - libosmo-abis-dev (>= 1.1.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-abis-dev (>= 1.2.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-mgw.git Vcs-Browser: https://git.osmocom.org/osmo-mgw/ @@ -21,7 +21,7 @@ Depends: ${misc:Depends}, ${shlibs:Depends} Description: OsmoMGW: Osmocom's Media Gateway for 2G and 3G circuit-switched mobile networks -Package: libosmo-mgcp-client8 +Package: libosmo-mgcp-client9 Section: libs Architecture: any Multi-Arch: same @@ -33,7 +33,7 @@ Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-mgcp-client8 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-mgcp-client9 (= ${binary:Version}), ${misc:Depends} Description: libosmo-mgcp-client: Osmocom's Media Gateway Control Protocol client utilities Package: osmo-mgw-doc diff --git a/debian/libosmo-mgcp-client8.install b/debian/libosmo-mgcp-client9.install similarity index 100% rename from debian/libosmo-mgcp-client8.install rename to debian/libosmo-mgcp-client9.install diff --git a/src/libosmo-mgcp-client/Makefile.am b/src/libosmo-mgcp-client/Makefile.am index c472ec1..4d9ec5f 100644 --- a/src/libosmo-mgcp-client/Makefile.am +++ b/src/libosmo-mgcp-client/Makefile.am @@ -21,7 +21,7 @@ # This is not at all related to the release version, but a range of supported # API versions. Read TODO_RELEASE in the source tree's root! -MGCP_CLIENT_LIBVERSION=8:0:0 +MGCP_CLIENT_LIBVERSION=9:0:0 lib_LTLIBRARIES = \ libosmo-mgcp-client.la \ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icfc615c0d7d826269962b0d94fbe53c2f8adfdaf Gerrit-Change-Number: 26283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:48:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:48:57 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bts=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E348-f42287-dirty_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26281 ) Change subject: Bump version: 1.3.0.348-f42287-dirty ? 1.4.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibf3ce0bfd0cf67148229dd988ebde6e6b8d744cc Gerrit-Change-Number: 26281 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 16:48:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:48:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:48:59 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bts=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E0=2E348-f42287-dirty_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26281 ) Change subject: Bump version: 1.3.0.348-f42287-dirty ? 1.4.0 ...................................................................... Bump version: 1.3.0.348-f42287-dirty ? 1.4.0 Change-Id: Ibf3ce0bfd0cf67148229dd988ebde6e6b8d744cc --- M TODO-RELEASE M configure.ac M contrib/osmo-bts.spec.in M debian/changelog M debian/control 5 files changed, 391 insertions(+), 23 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index aa0b2fd..6b2de14 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,6 +1,2 @@ # When cleaning up this file: bump API version(s) in the following files: # configure.ac, debian/control, and contrib/osmo-bts.spec.in. -update libosmo-abis dependency to > 1.1.1 for osmo_rtp_socket_set_priority() -update libosmo-abis dependency to > 1.1.1 for new e1_input vty commands for DSCP + priority -update libosmocore dependency to > 1.5.1-73-g524b4f80 for osmo_bts_features_desc() -update libosmocore dependency to > 1.5.1-133-g09f075fa for name in (struct rate_ctr_group) diff --git a/configure.ac b/configure.ac index 91fe244..8e3a44c 100644 --- a/configure.ac +++ b/configure.ac @@ -69,14 +69,14 @@ fi dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.2.0) AC_MSG_CHECKING([whether to enable support for sysmobts calibration tool]) AC_ARG_ENABLE(sysmobts-calib, diff --git a/contrib/osmo-bts.spec.in b/contrib/osmo-bts.spec.in index a6d5e86..5fed7d6 100644 --- a/contrib/osmo-bts.spec.in +++ b/contrib/osmo-bts.spec.in @@ -27,14 +27,14 @@ %if 0%{?suse_version} BuildRequires: systemd-rpm-macros %endif -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocodec) >= 1.5.0 -BuildRequires: pkgconfig(libosmocoding) >= 1.5.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmotrau) >= 1.1.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocodec) >= 1.6.0 +BuildRequires: pkgconfig(libosmocoding) >= 1.6.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmotrau) >= 1.2.0 ### FIXME: DependencyHACK to include osmocom/gprs/protocol/gsm_04_60.h BuildRequires: pkgconfig(libosmogb) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index bc44837..3ad028b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,375 @@ +osmo-bts (1.4.0) unstable; urgency=medium + + [ Philipp Maier ] + * l1sap: Store status of SRR in an lchan struct memeber + * l1sap: add logging and VTY introspection for ACCH repetition + * sched_lchan_tchh: fix frame number and fill FACCH gap + * main,abis: change model name from sysmoBTS to osmo-bts + * paging: prioritize CS related paging over PS related pagings. + * allow to configure multiple oml remote-ip addresses + * sched_lchan_tch_x: do not use cmr as ft + * sched_lchan_tch_x: use functions to determine AMR tranmssion phase + * sched_lchan_tch_x: use ul_cmr and ul_ft when generating RTP bad frame + * rsl: simplfy parse_repeated_acch_capability + * rsl: parse temporary overpower value RSL CHAN ACT / MODIFY + + [ Vadim Yanitskiy ] + * doc/examples: remove obsolete power control parameters + * doc/examples: enable stderr logging for osmo-bts-virtual.cfg + * osmo-bts-trx: fix: do not call trx_if_close() two times + * osmo-bts-trx: fix segfault on trx_phy_inst_open() failure + * l1sap: use the passed 'trx' pointer in l1sap_chan_act() + * l1sap: use TLVP_PRES_LEN() macro in l1sap_chan_act() + * l1sap: check BTS_FEAT_MULTI_TSC in l1sap_chan_act() + * l1sap: fix wrong IEI and parsing in l1sap_chan_act() + * manuals: fix wrong VTY node for 'gsmtap-sapi' command + * manuals: document GSMTAP 'enable-all' / 'disable-all' + * osmo-bts-trx: correct definition of 'osmotrx rx-gain' command + * rsl: do not blindly ignore unhandled/unknown Channel Mode + * manuals: remove deprecated command line parameters + * manuals: document new 'gsmtap-remote-host' command + * l1sap: fix incorrect pointer cast in l1sap_chan_act() + * rsl: rename, fix and refactor lchan_tchmode_from_cmode() + * rsl: add missing Channel Mode values to rsl_handle_chan_mod_ie() + * lchan2lch_par(): fix missing default branch in switch + * osmo-bts-trx: cosmetic: TRXD 'header version' -> 'PDU version' + * osmo-bts-trx: remove outdated TRXD protocol documentation + * osmo-bts-trx: cosmetic: use '#pragma once' in trx_if.h + * osmo-bts-trx: define TRXC/TRXD message buffer size + * osmo-bts-trx: 'burst type' is actually modulation type + * osmo-bts-trx: move MTS parser into trx_data_parse_mts() + * osmo-bts-trx: discard TRXD PDUs with unexpected version + * osmo-bts-trx: move TDMA frame number check to trx_data_read_cb() + * osmo-bts-trx: cosmetic: get rid of TRX_CHDR_LEN macro + * osmo-bts-trx: generalize checking of TRXD header length + * osmo-bts-trx: pass 'struct phy_instance' to TRXD dissectors + * osmo-bts-trx: refactor handling of version specific TRXD parts + * osmo-bts-trx: enlarge and share TRXD message buffer + * osmo-bts-trx: assert PDU version in trx_if_send_burst() + * osmo-bts-trx: reduce code nasting in trx_if_send_burst() + * vty: fix the use of deprecated osmo_bts_feature_name() + * common/abis: fix the use of deprecated e1inp_line_get() API + * osmo-bts-trx: refactor parse_rsp(), fix compilation warnings + * rsl: fix wrong value printed in rsl_handle_chan_mod_ie() + * struct gsm_bts_trx: remove unused leftovers from openbsc + * common/sysinfo: make struct gsm_bts_trx const in num_agch() + * osmo-bts-{lc15,oc2g}: drop redundant checks in VTY commands + * [VAMOS] struct gsm_bts_trx: fix the PHY instance pointer + * [VAMOS] Merge bts_trx_init() into gsm_bts_trx_alloc() + * [VAMOS] osmo-bts-trx: move {chan,bid} to trx_{dl,ul}_burst_{req,ind} + * osmo-bts-trx: implement TRXDv2 protocol support + * scheduler.h: cosmetic: use #pragma once + * osmo-bts-trx: cosmetic: s/trx_sched_fn/bts_sched_fn/g + * osmo-bts-trx: remove redundant assert() in bts_sched_fn() + * osmo-bts-trx: fix hopping pointer bug in bts_sched_fn() + * [VAMOS] Re-organize osmo-bts-trx specific structures + * osmo-bts-trx: clarify logging messages in trx_if_{open,close}() + * osmo-bts-{trx,virtual}: fix: pinst->trx may be NULL + * common: make the arguments of phy_{link,instance}_name() const + * [VAMOS] common: make 'struct gsm_bts_trx_ts' pointers const + * [VAMOS] gsm_data.h: fix wrong bit-mask in BSIC2BCC macro + * [VAMOS] gsm_data.h: introduce and use BTS_TSC macro + * common: phy_links_open(): warn about dangling PHY instances + * [VAMOS] osmo-bts-trx: rework and split up bts_sched_fn() + * Fix regression in 'osmo-bts-trx: rework and split up bts_sched_fn()' + * [VAMOS] osmo-bts-trx: implement and enable PDU batching for TRXDv2 + * [VAMOS] osmo-bts-trx: indicate MTS in Downlink TRXDv2 PDUs + * [VAMOS] rsl_rx_mode_modif(): handle Channel Identification IE + * [VAMOS] rsl: call bts_supports_cm() from rsl_handle_chan_mod_ie() + * [VAMOS] bts_supports_cm(): handle RSL_CMOD_CRT_OSMO_TCH_VAMOS_{Bm,Lm} + * [VAMOS] common/scheduler: unify symbol names for training sequences + * [VAMOS] osmo-bts-trx: rework handling of Training Sequence + * [VAMOS] osmo-bts-trx: properly handle per-timeslot TSC values + * [VAMOS] scheduler: add new GMSK training sequences from 3GPP 45.002 + * [VAMOS] l1sap_chan_act(): handle Osmocom specific TSC IE + * [VAMOS] common/oml: generalize checking BTS_FEAT_MULTI_TSC + * [VAMOS] gsm_pchan2chan_nr(): use ABIS_RSL_CHAN_NR_CBITS_* macros + * [VAMOS] rsl_lchan_lookup(): use ABIS_RSL_CHAN_NR_CBITS_* macros + * [VAMOS] rsl_lchan_lookup(): make it more readable + * [VAMOS] gsm_data: rework and rename gsm_lchan_name_compute() + * [VAMOS] l1sap: get_lchan_by_chan_nr() may return NULL + * [VAMOS] oml_rx_set_chan_attr(): clarify NM_ATT_CHAN_COMB handling + * manuals/abis/rsl.adoc: s/TS 08.58/TS 48.058/ + * manuals/abis/rsl.adoc: rework Channel Number description + * manuals/abis/rsl.adoc: add missing CBCH Channel Number values + * manuals/abis/rsl.adoc: add VAMOS specific Channel Number values + * osmo-bts-trx: fix NULL pointer dereference in trx_if_send_burst() + * trx_sched_is_sacch_fn(): fix handling of dynamic timeslots + * [VAMOS] scheduler: drop meaningless channel number checks + * [VAMOS] conf_lchans_as_pchan(): improve readability + * [VAMOS] Implement the concept of 'shadow' timeslots + * [VAMOS] osmo-bts-trx: schedule bursts on 'shadow' timeslots + * l1sap: fix TDMA frame number wrap in l1sap_info_time_ind() + * conf_lchans_as_pchan(): fix GSM_LCHAN_{CCCH->CBCH} regression + * conf_lchans_as_pchan(): initialize all lchans with GSM_LCHAN_NONE + * measurement: remove over-defensive checks in is_meas_complete() + * [VAMOS] trx_sched_init_ts(): assign names to per-timeslot counters + * common/vty: facilitate finding duplicate PHY/TRX associations + * vty: ensure all warning messages are prefixed with '%%' + * osmo-bts-octphy: drop talloc_replace(), use osmo_talloc_replace_string() + * l1sap: fix TDMA frame number arithmetic in fn_ms_adj() + * osmo-bts-trx: fix typo: s/bisc/bsic/ in 'show transceiver' + * osmo-bts-trx: fix copy-pasted comment: s/sysmoBTS/osmo-bts-trx/ + * oml: fix handling of NM_ATT_INTERF_BOUND attribute + * Report interference levels in RSL RF RESource INDication + * scheduler: reorder enum trx_chan_type, add TRX_CHAN_IS_DEDIC() + * osmo-bts-trx: report interference levels to the upper layers + * osmo-bts-{trx,virtual}: get rid of dummy tx_idle_fn() + * scheduler: unset TRX_CHAN_FLAG_AUTO_ACTIVE for TRXC_IDLE + * osmo-bts-trx: print timeslot brief info in 'show transceiver' + * osmo-bts-trx: measure interference levels on TRXC_IDLE + * osmo-bts-trx: report PDCH interference levels to the PCU + * scheduler: fix wrong union field in trx_sched_tch_req() + * scheduler: fix: use ts_pchan() in trx_sched_set_cipher() + * Revert "power_control: BS power shall not be reduced on C0" + * osmo-bts-omldummy: indicate BTS_FEAT_BCCH_POWER_RED as supported + * osmo-bts-trx: implement BCCH carrier power reduction mode + * power_control: constrain BS power reduction on BCCH carrier + * manuals/abis/rsl.adoc: clarify RF Resource Indication conformance + * rsl: use tlvp_val16be() in rsl_rx_ipac_XXcx() + * gsm_lchan_interf_meas_calc_band(): also print number of AVG samples + * osmo-bts-trx: send dummy FACCH in the absense of RTP frames + * osmo-bts-trx: return -ENODEV if 'bursts_p' is NULL + * l1sap: unify channel (de)activation/modification messages + * gsm_lchan2chan_nr(): separate RSL specific variant of this API + * osmo-bts-trx: bts_model_l1sap_down(): remove chan_nr patching + * trx_sched_set_lchan(): use LOGL_INFO for logging messages + * osmo-bts-trx: remove an 'else' branch in _sched_dl_burst() + * osmo-bts-trx: implement Temporary Overpower for SACCH/FACCH + * scheduler: fix comments explaining the interleaving of TCH/H + * fix handle_ms_meas_report(): properly count measurement reports + * abis: fix memory leak in abis_oml_sendmsg() + * rsl: remove redundant logging in rsl_rx_chan_activ() + * .gitignore: add tests/amr/amr_test + * rsl: prevent race condition during timeslot re-configuration + * rsl_tx_rf_res(): separate interference AVG / band calculation + * rsl_tx_rf_res(): also report noise levels for PDTCH + * osmo-bts-trx: report PDCH interference levels to L1SAP + * l1sap: check if BTS model supports interference reporting + * vty: show interference level / band in 'show lchan' + * trx_sched_clean_ts(): also free() the associated 'struct l1sched_ts' + * trx_sched_clean(): also free() the shadow timeslot + * osmo-bts-trx: refactor 'maxdly' / 'maxdlynb' commands + * rsl: rsl_tx_meas_res() does not change l3, make it const + * rsl: send NACK if BTS_FEAT_ACCH_REP is not supported + * measurement: handle_ms_meas_report() accepts const gh + * measurement: move repeated_dl_facch_active_decision() here + * measurement: make sure that DL measurements are valid + * cosmetic: s/repeated_acch_capability/rep_acch_cap/g + * struct gsm_lchan: group ACCH repetition state fields + * struct gsm_lchan: move tch.rep_facch to rep_acch.dl_facch + * measurement: fix wrong operator used in handle_ms_meas_report() + * osmo-bts-trx: fix potential NULL pointer dereference + * lchan_set_state(): also free pending messages if any + * lchan: introduce and use lchan_is_tch() helper + * [overpower] rsl: store full content of RSL_IE_OSMO_TEMP_OVP_ACCH_CAP + * [overpower] lchan_dump_full_vty(): print overpower state + * [overpower] scheduler: handle {sacch,facch}_enabled flags + * l1sap: fix handling of lchan->pending_rel_ind_msg + * l1sap: move false PTCCH/U detection into PDCH branch + * l1sap: use designated initializers in process_l1sap_meas_data() + * l1sap: process_l1sap_meas_data() accepts pointer to lchan + * l1sap: make 'l1sap' argument of process_l1sap_meas_data() const + * rsl: fix a memory leak in handle_gprs_susp_req() + * l1sap: rework handling of DATA.ind on SACCH + * lchan_meas_handle_sacch(): check if Measurement Result is valid + * measurement: get rid of *le in lchan_meas_handle_sacch() + * measurement: pass *mr to repeated_dl_facch_active_decision() + * measurement: pass *mr to lchan_bs_pwr_ctrl() + * [overpower] Turn it on and off depending on DL RxQual + * measurement: make use of gsm48_meas_res_is_valid() + * common/Makefile.am: reformat {AM_CPPFLAGS,AM_CFLAGS,LDADD} + * rsl: exclude disabled timeslots from interference reports + * oml: use ARRAY_SIZE() in oml_rx_set_bts_attr() + * gsm_lchan_interf_meas_calc_avg(): fix band calculation + + [ Pau Espin Pedrol ] + * l1sap: Transmit pdtch invalid MAC blocks to PCU + * bts-trx: Always submit rx PDTCH DATA.ind to l1sap + * bts-trx: Avoid submitting first data_ind with FN=0 to upper layers + * bts-trx: Drop duplicate set of last_clk_ind + * bts-trx: reorder first timerfd schedule to decrease first timeout skew + * sysmo,oc2g,lc15: Make RadioChannel MO depend on RadioCarrier MO + * bts: Clean up TS selection in sign_link_up + * Fix regression in 'bts: Clean up TS selection in sign_link_up' + * Add missing value_string for NM_EV_* introduced recently + * pcuif: Set missing bsic field during Tx of info_ind + * Use new stat item/ctr getter APIs + * rsl: Use switch statement in rsl_rx_bcch_info() + * pcu_sock: Transmit SI2 + * doc: rsl.adoc: Fix trailing whitespace + * gsm_data: Drop unused function gsm_pchan_parse() + * pcuif_proto.h: Add new container messages + * Support forwarding proto IPAC_PROTO_EXT_PCU BSC<->PCU + * Rename osmo dyn ts enums to contain SDCCH8 + * Support SDCCH8 in osmo dyn ts + * Make gcc 11.1.0 false positivies happy + * rsl: Fix rx of multiple RSL_IPAC_EIE_MEAS_AVG_CFG IEs + * rsl: Support parsing up to 3 RSL_IPAC_EIE_MEAS_AVG_CFG IEs + * MS Power Control Loop: Take C/I into account + * MS Power Control Loop: Support EWMA algorithm for C/I measurements + * MS Power Control Loop: Improve logging + * BS Power Control Loop: refactor lchan_bs_pwr_ctrl() to look similar to lchan_ms_pwr_ctrl() + * BS Power Control Loop: Support EWMA average algo for RxQual meas + * BS Power Control Loop: Increase attenuation if RxQual is better than upper threshold + * MS/BS Power Control Loop: Do RxLEV meas avg & delta calculations directly on RxLevels + * MS/BS Power Control Loop: Fix downscaling averaging bug + * Power Control Loop: Move skip loop logic to function helper + * comsetic: measurement.c: fix typo in comment + * l1sap: Take L1SACCH MS_PWR from bitfield instead of manual parsing + * TA loop: Take into account UL SACCH 'Actual Timing advance' field + * ta_control: Allow switching TA quicker + * lchan: Move TA CTRL param to its own substruct + * MS Power Control Loop: Feed UL RSSI from correct measurement period + * MS Power Control Loop: Feed UL C/I from correct measurement period + * TA Control Loop: Change toa256 switch threshold to 75% of a symbol + * Power Control Loop: Set P_CON_INTERVAL to 1 by default + * Support configuring TA loop SACCH block rate + * MS Power Control Loop: Fix sub vs full being passed to algo + * abis: Clear code and drop code not executed + * abis.h: Drop unused state + * cosmetic: fix typo in comment + * abis.c: Rearrange code to follow logic state order + * abis.c: Convert early return to assert() + * power_control: Drop unused param in function + * tests: MS Power Control Loop: Show oscillation among good power levels + * cosmetic: Fix formatting of conditional operator + * abis: Move FSM registration to constructor function + * abis: Shorten string names of events + * abis.c: Transition to CONNECTED state only when OML link is up + * abis.c: Fix mess with priv->bsc_oml_host + * abis.c: Loop over list of BSCs until connection succeeds + * trx_provision_fsm: Add missing state transition OPEN_WAIT_POWEROFF_CNF => OPEN_POWEROFF + * nm_*_fsm: Add missing item in event mask list for state ENABLED + * Allow setting administrative state through oml_mo_state_chg() + * nm_*_fsm: Set adminsitrative state 'shutting down' when shutdown procedure starts + * MS Power Control Loop: Fix oscillations within good MS Power Levels + * nm_*_fsm: Move to state Disabled NotInstalled Locked when shtudown proc ends + * abis: Drop internal OML msg queue + * nm_*fsm: Make FSMs aware of object being properly configured or not + * bts_shutdown_fsm: Fix event name + * trx_if: Set pointer to null after freeing it + * trx_if: Allow calling trx_if_flush/close from within TRXC callback + * trx_if: delete retrans timer when flushing the Tx queue + * trx_provision_fsm: Properly reset FSM state upon starting listening for events + * bts-trx: Submit TRX_PROV_EV_CFG_ARFCN for C0 during SetBtsAttr + * bts-trx: Get rid of check_transceiver_availability_trx() + * MS Power Control Loop: Disable threshold comparison on {LOWER,UPPER}_CMP_N=0 + * l1sap: Support rx of empty rlcmac blocks from PCU + * bts-trx: Avoid race condition configuring TS-specific TSC values + * bts-trx: Submit TRX SW_ACT when PHY becomes connected + * trx_sched_clean_ts: Clean VAMOS shadow TS too + * phy_link: Introduce bts_model_phy_link_close() and use it in bts-trx + * nm_bts_fsm: Make sure PHYs are opened when SW_ACTivating it + * bts_shutdown_fsm: Allow configuring FSM to shutdown without exiting process + * abis: Call bts_model_abis_close() when Abis link goes down + * bts_trx: Drop non-executed path in trx_link_estab() + * Avoid sending Load Indications when BTS is not RSL-connected + * abis: Fix memory leak of bts->osmo_link upon link going down + * abis: Fix line leaked & recreated upon every reconnect + * bts-trx: Keep the process ongoing trying to reconnect on Abis link down + * Revert "bts-trx: Keep the process ongoing trying to reconnect on Abis link down" + * Revert "abis: Fix line leaked & recreated upon every reconnect" + * osmo-bts-omldummy: Fix crash accessing null phy + * bts-trx: Fix rxgain & maxdly VTY values being reset + * Decouple handling of Measurement Report from lapdm + * Move TA & Power Loops further up the stack, take DTXu flag into account + * scheduler: Fix lqual_cb not populated for TCH.ind + * abis: Fix line leaked & recreated upon every reconnect + * trx_provision_fsm: Fix TRX!=0 never going back to CLOSED state + * trx_provision_fsm: Support OPEN_POWEROFF->CLOSED transition + * bts-trx: Delay power ramp up until RCARRIER is ENABLED + * Delay abis reconnect while bts is shutting down + * bts-trx: Keep the process ongoing trying to reconnect on Abis link down + * trx_provision_fsm: Drop unneeded reset of fields + * trx_provision_fsm: Drop impossible paths + * trx_provision_fsm: poweronoff_sent flag: track POWERON and POWEROFF separately + * trx_provision_fsm: Fix shutdown while POWERON in transit + * rsl: NACK Chan Activation for lchans on disabled TS + * Introduce gsm_lchan_init() function helper + * MS Power Control Loop: Use P_CON_INTERVAL=2 by default + * load_indication.c: Avoid sending if CCCH is still not operational + * Move lchan,power_ctrl specific code from gsm_data.h to their own files + * Move lchan,power_control related code from gsm_data.c to their own files + * lchan.h: Add related ticket info to FIXME comment + * Introduce gsm_lchan_release function helper + * nm_channel_fsm: Release lchans after BTS shutdown + * nm_bts_fsm: Reset si_valid bitmask when BTS is shut down + * nm_*_fsm: Move reset state code to st_op_disabled_notinstalled_on_enter + * nm_*_fsm: reset mo.nm_attr from previous runs when entering state NOT_INSTALLED + * Add new gsm_bts_trx_free_shadow_ts() function + * Make sure lchan allocated memory from shadow_ts is properly freed + * rsl: Fix all shadow TS being Chan Act NACKed + * bts-trx: Guard call to trx_sched_clean with NULL trx ptr + * lchan: Setup early_rr_ia timer only once during init + * Move lchan related code to lchan.{c,h} + * lchan: Update log line level to use macro and level INFO + * lchan: Avoid applying transition changes if state new==old + * Move lchan_deactivate() to lchan.c + * Move lchan_init_lapdm inside lchan_set_state(LCHAN_S_ACTIVE) + * lchan: Call lapdm_channel_exit() when state changes to NONE + * bts_shutdown_fsm: Make sure pending power ramping are aborted before closing TRX + * gsm_pchan2chan_nr(): Properly assert if unexpected pchan is passed + * Reset CBCH state after BTS shutdown + * bts-trx: sched_lchan_pdtch: Refactor tx_pdtch_fn to get rid of goto tag + * bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly + * Revert "bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly" + * scheduler: Fix check against empty PDCH blocks + * bts-trx: sched: tx_pdtch_fn: Drop log line clogging logs + * l1sap: Avoid re-(de)activating already (de)active lchans + * scheduler: Avoid crash upon call to trx_sched_set_lchan if l1ts is uninitialized + * bts-trx: sched_lchan_tchf: Drop impossible code path + * scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors + * bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim + * abis: Drop unneded if condition in else clause + * abis: Try one reconnect to previously connected BSC before trying next one + * gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE + + [ Neels Hofmeyr ] + * osmobts-abis.adoc: add missing bibliography + * Abis manual: s/TS 12.21/TS 52.021 + * Abis manual: add Get Attributes, add BTS features + * Abis manual: add VAMOS to BTS features + * Abis manual: add RSL_IE_OSMO_TRAINING_SEQUENCE + * omldummy: introduce using getopt_long + * omldummy: add cmdline arg --features + * [VAMOS] osmo-bts-omldummy: allocate shadow timeslots + * remove unused LCHAN_S_INACTIVE + * enable Early Immediate Assignment + * add VTY transcript testing + * jenkins: enable new flag --enable-external-tests + * add osmo_tdef groups, exposing T timers on VTY config + * early IMM ASS: add configurable delay for RR IMM ASS + * early IA: change default X15 timer to 0 ms + * gsm_lchan_interf_meas_calc_avg(): adapt to the order of boundaries + + [ Harald Welte ] + * Introduce ability to set socket priority of RTP sockets + * manual: Include QoS chapter and add osmo-bts specific example + * manual: Remove manual revision history; we don't use it anywawy + * manuals: Update copyright years + * l1sap/gsmtap: Don't log UI fill frames [zero information field] + * rsl: fix handling of REL IND in lapdm_rll_tx_cb() + * initial support for static userspace probes via systemtap + + [ Keith ] + * sysmobts-mgr: Fix path to hwmon in /sys + + [ Eric Wild ] + * osmo-bts-trx: indicate A5/4 support, handle Kc128 + + [ Oliver Smith ] + * debian/control: remove dh-systemd build-depend + + [ Eric ] + * lc15, oc2g, sysmo: fix show dsp-trace-flags + * osmo-trx: fix maxdly + + [ Martin Hauke ] + * osmo-bts-trx-calypso.cfg: Adjust settings to work with current osmo-bts versions + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:40:05 +0100 + osmo-bts (1.3.0) unstable; urgency=medium [ Michael McTernan ] diff --git a/debian/control b/debian/control index 3b8098b..0bdf48c 100644 --- a/debian/control +++ b/debian/control @@ -7,11 +7,11 @@ dh-autoreconf, autotools-dev, pkg-config, - libosmocore-dev (>= 1.5.0), - libosmo-abis-dev (>= 1.1.0), + libosmocore-dev (>= 1.6.0), + libosmo-abis-dev (>= 1.2.0), libgps-dev, txt2man, - osmo-gsm-manuals-dev (>= 1.1.0) + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Browser: http://git.osmocom.org/osmo-bts/ Vcs-Git: git://git.osmocom.org/osmo-bts -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibf3ce0bfd0cf67148229dd988ebde6e6b8d744cc Gerrit-Change-Number: 26281 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:49:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:49:31 +0000 Subject: =?UTF-8?Q?Change_in_osmo-trx=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E1=2E28-019d-dirty_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/26279 ) Change subject: Bump version: 1.3.1.28-019d-dirty ? 1.4.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie675909593b0c383b59b7b4a4edd46cd93283622 Gerrit-Change-Number: 26279 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 16:49:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:49:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:49:33 +0000 Subject: =?UTF-8?Q?Change_in_osmo-trx=5Bmaster=5D=3A_Bump_version=3A_1=2E3=2E1=2E28-019d-dirty_=E2=86=92_1=2E4=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/26279 ) Change subject: Bump version: 1.3.1.28-019d-dirty ? 1.4.0 ...................................................................... Bump version: 1.3.1.28-019d-dirty ? 1.4.0 Change-Id: Ie675909593b0c383b59b7b4a4edd46cd93283622 --- M TODO-RELEASE M configure.ac M contrib/osmo-trx.spec.in M debian/changelog M debian/control 5 files changed, 49 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index ab54c42..e69de29 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1 +0,0 @@ -libosmocore > 1.5.1 require APIs osmo_stat_item_group_get_item, rate_ctr_group_get_ctr diff --git a/configure.ac b/configure.ac index 5706a39..422ad65 100644 --- a/configure.ac +++ b/configure.ac @@ -82,10 +82,10 @@ AC_HEADER_TIME AC_C_BIGENDIAN -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.6.0) AC_ARG_ENABLE(sanitize, [AS_HELP_STRING( diff --git a/contrib/osmo-trx.spec.in b/contrib/osmo-trx.spec.in index b80d8e2..3550aaf 100644 --- a/contrib/osmo-trx.spec.in +++ b/contrib/osmo-trx.spec.in @@ -34,10 +34,10 @@ BuildRequires: pkgconfig(usrp) >= 3.3 %endif BuildRequires: pkgconfig(fftw3f) -BuildRequires: pkgconfig(libosmocoding) >= 1.5.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocoding) >= 1.6.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(libusb-1.0) BuildRequires: pkgconfig(uhd) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 019fdf8..a6f6b70 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,43 @@ +osmo-trx (1.4.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Threads.cpp: Fix missing extern C around libosmocore include + * Drop logging pthread ID + * Threads: Avoid printing pthread_self() + * ipc: Makefile.am: Clean LDADD variable + * Use new stat item/ctr getter APIs + * detectBurst(): Clear downsampling code path + * detectBurst(): constify parameter + * computeCI(): Constify param and pass it as reference + * computeCI(): Rename verbose repeated getter to constant + * computeCI(): Constify read-only variable + * detectGeneralBurst(): Increase log level about clipping to INFO + * cosmetic: Fix typo in comment + * computeCI: Document hardcoded multiplier + * lms: Drop duplicated check + * lms,uhd: Validate band of RxFreq too + * lms,uhd: Skip re-assigning same band + * lms,uhd: Allow changing band between poweroff & poweron + + [ Vadim Yanitskiy ] + * gitignore: remove non-existing 'doc/manuals/osmomsc-usermanual.xml' + * ctrl_sock_handle_rx(): fix missing space in LOGCHAN() statement + * trx_rate_ctr: use thread safe strerror() in device_sig_cb() + * IPCDevice: use thread safe strerror_r() instead of strerror() + * IPCDevice: check value returned from select() + * LMSDevice: LMS_GetDeviceList() may return a negative number + + [ Eric ] + * add hidden fn adjustment command + * uhd: ensure configured clock source is actually used + * vty: printing fn offset should be signed + * lms: init band + + [ Oliver Smith ] + * d/patches/build-for-debian8.patch: remove + + -- Pau Espin Pedrol Tue, 16 Nov 2021 16:27:26 +0100 + osmo-trx (1.3.1) unstable; urgency=medium * mark uhddev_ipc.cpp as BUILT_SOURCES diff --git a/debian/control b/debian/control index d1532f2..16709f8 100644 --- a/debian/control +++ b/debian/control @@ -14,7 +14,7 @@ libtalloc-dev, libusrp-dev, liblimesuite-dev, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), osmo-gsm-manuals-dev Standards-Version: 3.9.6 Vcs-Browser: http://cgit.osmocom.org/osmo-trx -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie675909593b0c383b59b7b4a4edd46cd93283622 Gerrit-Change-Number: 26279 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:50:47 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 16:50:47 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26280 to look at the new patch set (#4). Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... cards: select_adf_by_aid: split off aid completion The function select_adf_by_aid first searches for the complete AID in the set of AIDs that were read from EF.DIR. Lets put this task into a separate helper method Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 --- M pySim/cards.py 1 file changed, 26 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/80/26280/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:51:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:51:12 +0000 Subject: =?UTF-8?Q?Change_in_osmo-msc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E43-aefbf-dirty_=E2=86=92_1=2E8=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26287 ) Change subject: Bump version: 1.7.0.43-aefbf-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.0.43-aefbf-dirty ? 1.8.0 Change-Id: I37aa63e1c4ed021c5cc8b186f073cf01ab9a9cb6 --- M TODO-RELEASE M configure.ac M contrib/osmo-msc.spec.in M debian/changelog M debian/control 5 files changed, 93 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/87/26287/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index d969e50..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore >1.5.1 A5/4 support requires new API gsm0808_create_cipher2(), and gsm0808_handover_request.kc128 diff --git a/configure.ac b/configure.ac index 702be9f..3395ecc 100644 --- a/configure.ac +++ b/configure.ac @@ -36,16 +36,16 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.8.0) -PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.3.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) +PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.4.0) old_LIBS=$LIBS AC_SEARCH_LIBS([sctp_send], [sctp], [ @@ -103,7 +103,7 @@ [osmo_ac_iu="$enableval"],[osmo_ac_iu="no"]) if test "x$osmo_ac_iu" = "xyes" ; then PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) - PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.7.0) + PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) AC_DEFINE(BUILD_IU, 1, [Define if we want to build IuPS and IuCS interfaces support]) fi AM_CONDITIONAL(BUILD_IU, test "x$osmo_ac_iu" = "xyes") diff --git a/contrib/osmo-msc.spec.in b/contrib/osmo-msc.spec.in index 3ead299..17c07b9 100644 --- a/contrib/osmo-msc.spec.in +++ b/contrib/osmo-msc.spec.in @@ -35,16 +35,16 @@ BuildRequires: pkgconfig >= 0.20 BuildRequires: pkgconfig(dbi) BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.3.0 -BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.8.0 +BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.4.0 +BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.9.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sccp) >= 1.4.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sccp) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(libsmpp34) >= 1.14.0 #### BuildRequires: lksctp-tools-devel @@ -52,7 +52,7 @@ %{?systemd_requires} %if %{with_iu} BuildRequires: pkgconfig(libasn1c) >= 0.9.30 -BuildRequires: pkgconfig(libosmo-ranap) >= 0.7.0 +BuildRequires: pkgconfig(libosmo-ranap) >= 0.8.0 %endif %if 0%{?suse_version} Requires: libdbi-drivers-dbd-sqlite3 diff --git a/debian/changelog b/debian/changelog index 758173b..54fbd03 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,68 @@ +osmo-msc (1.8.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * configure.ac: Depend on newer libosmo-ranap + * Fill Last Used E-UTRAN PLMN Id when in CSFB + * Use new osmo stat items/ctr APIs + * sgs: Use available API to set vlr subscr LastUsedEutranPLMNId + * vlr_sgs: Drop recorded LastEutranPlmnId when UE no longer associated + * sgs_iface.c: Improve logging when paging over SGs + * msc_a.c: Allow MSC_A_EV_CN_CLOSE in state MSC_A_ST_RELEASING + * cosmetic: fix typos in comments + * vlr_sgs.h: Set proper logic order of items in enum sgs_ue_fsm_state + * vlr_auth_fsm.c: Simplify function auth_fsm_wait_ai_resync + * vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach + * vlr_sgs: Balance use_count incremented in vlr_sgs_loc_update + * cosmetic: Fix typo in comment + + [ Oliver Smith ] + * contrib/osmo-msc.spec.in: depend on dbd-sqlite3 + * contrib/osmo-msc.spec.in: require libosmo-ranap >= 0.7.0 + * Revert "Turn some compiler warnings into errors" + + [ Vadim Yanitskiy ] + * SMS-over-GSUP: notify sender if no transaction found + * msc_tx_common_id(): fix potential NULL pointer dereference + * libmsc: fix NULL pointer dereference in trans_lcls_compose() + * libmsc: struct smsc: drop 'const' qualifier from bind_addr + * smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf() + * mncc: rework passing GCR over the MNCC interface + * manuals: remove deprecated -C / --no-dbcounter options + * Do not mention deprecated -M / --mncc-sock-path options + * Do not mention deprecated -l / --database options + + [ Neels Hofmeyr ] + * osmo-msc main: use osmo_select_shutdown() + * ran_msg_a.c: use gsm0808_create_cipher2() + * support A5/4 in Cipher Mode Command + * support A5/4 in inter-BSC handover + * improve logging on encryption, for Ciphering and HO + * add sequence_charts/call_reestablishment.msc + * add vlr_subscr_find_by_mi + * implement CM Re-Establish for voice calls + + [ Eric Wild ] + * vty: allow A5/4 encryption in config + + [ Philipp Maier ] + * running.adoc: add section about MGCP configuration + * msc_vlr_test: remove DLMGCP log messages from unit test output + + [ Harald Welte ] + * smpp: Fix help string in vty for "alert-notifications" + * smpp_mirror: Factor-out reset of SMPP read state + * smpp_mirror: Don't allocate msgb's for unrealistic amounts of memory + * Fix enabling of UMTS UEA encryption + * Make UTRAN encryption algorithms configurable + + [ Keith Whyte ] + * Add support for LCLS to the MSC + + [ Alexander Couzens ] + * Validate the choosen UTRAN encryption algorithm + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:44:54 +0100 + osmo-msc (1.7.0) unstable; urgency=medium [ Keith Whyte ] diff --git a/debian/control b/debian/control index 9b529c2..0b2ac6b 100644 --- a/debian/control +++ b/debian/control @@ -15,15 +15,15 @@ libtalloc-dev, libsmpp34-dev (>= 1.14.0), libasn1c-dev (>= 0.9.30), - libosmocore-dev (>= 1.5.0), - libosmo-sccp-dev (>= 1.4.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-abis-dev (>= 1.1.0), - libosmo-mgcp-client-dev (>= 1.8.0), - libosmo-gsup-client-dev (>= 1.3.0), + libosmocore-dev (>= 1.6.0), + libosmo-sccp-dev (>= 1.5.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.2.0), + libosmo-mgcp-client-dev (>= 1.9.0), + libosmo-gsup-client-dev (>= 1.4.0), libosmo-netif-dev (>= 1.1.0), - libosmo-ranap-dev (>= 0.7.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-ranap-dev (>= 0.8.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-msc.git Vcs-Browser: https://git.osmocom.org/osmo-msc/ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I37aa63e1c4ed021c5cc8b186f073cf01ab9a9cb6 Gerrit-Change-Number: 26287 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:58:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:58:12 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sgsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E28-245ac-dirty_=E2=86=92_1=2E8=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 ) Change subject: Bump version: 1.7.0.28-245ac-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.0.28-245ac-dirty ? 1.8.0 Change-Id: I62daba59b9dd1a0cade5292c8705ee5ec5b103c2 --- M TODO-RELEASE M configure.ac M contrib/osmo-sgsn.spec.in M debian/changelog M debian/control 5 files changed, 74 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/88/26288/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 44ee421..1c5d61f 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,3 +1 @@ #component what description / commit summary line -libosmogb > 1.5.1 bssgp_encode_rim_pdu symbol was not exported previously -libgtp > 1.7.1 use gtp_ran_info_relay_req(), gtp_set_cb_ran_info_relay_ind() diff --git a/configure.ac b/configure.ac index 9607373..4a2d683 100644 --- a/configure.ac +++ b/configure.ac @@ -45,29 +45,28 @@ AC_SUBST(LIBRARY_DLSYM) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.3.0) +PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.4.0) +PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.8.0) # Enable/disable 3G aka IuPS + IuCS support? AC_ARG_ENABLE([iu], [AS_HELP_STRING([--enable-iu], [Build 3G support, aka IuPS and IuCS interfaces])], [osmo_ac_iu="$enableval"],[osmo_ac_iu="no"]) if test "x$osmo_ac_iu" = "xyes" ; then - PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) + PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) - PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.7.0) + PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) AC_DEFINE(BUILD_IU, 1, [Define if we want to build IuPS and IuCS interfaces support]) fi AM_CONDITIONAL(BUILD_IU, test "x$osmo_ac_iu" = "xyes") AC_SUBST(osmo_ac_iu) - -PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.7.0) PKG_CHECK_MODULES(LIBCARES, libcares) dnl checks for header files diff --git a/contrib/osmo-sgsn.spec.in b/contrib/osmo-sgsn.spec.in index f661fa0..9cf18f6 100644 --- a/contrib/osmo-sgsn.spec.in +++ b/contrib/osmo-sgsn.spec.in @@ -34,20 +34,20 @@ %endif BuildRequires: pkgconfig(libcares) BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libgtp) >= 1.7.0 -BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.3.0 +BuildRequires: pkgconfig(libgtp) >= 1.8.0 +BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.4.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 %{?systemd_requires} %if %{with_iu} BuildRequires: pkgconfig(libasn1c) -BuildRequires: pkgconfig(libosmo-ranap) >= 0.7.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 +BuildRequires: pkgconfig(libosmo-ranap) >= 0.8.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 %endif %description diff --git a/debian/changelog b/debian/changelog index 2edc6e6..e1706df 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,49 @@ +osmo-sgsn (1.8.0) unstable; urgency=medium + + [ Harald Welte ] + * Remove bogus DNS log category + + [ Daniel Willmann ] + * manuals: Regenerate counters/VTY through docker + + [ Vadim Yanitskiy ] + * main: resurrect removed 'ns' logging category as deprecated + * doc/manuals: update configuration.adoc to use new command syntax + * tests/Makefile.am: do not try removing non-existing files + + [ Pau Espin Pedrol ] + * ranap: log ranap iu event type name instead of number + * gmm: log GMM msg type name instead of number + * gmm: Expect E_VLR_ANSWERED when in ST_IU_SECURITY_CMD + * gmm_fsm: Expect E_GMM_COMMON_PROC_INIT_REQ when in ST_GMM_COMMON_PROC_INIT + * mm_iu: Send event E_PMM_PS_CONN_ESTABLISH upon rx GMM SERVICE REQUEST + * mm_iu: Expect E_PMM_PS_ATTACH when in ST_PMM_IDLE + * gprs_gmm.c: State proper GMM prefix logging rx/tx of GMM messages + * mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED + * Iu: Drop timer X3314 + * gprs_ranap.c: Clean up code path releasing IU conn + * mm_state_{gb,iu}_fsm: Add missing license block, improve spec references + * mm_state_{gb,iu}_fsm: Improve naming for detach event + * Drop unused GBRPOXY enum field + * gtp: Delete ctx upon receive UpdateCtxResp with cause Non-existent + * Support forwarding RIM messages over GTPCv1 EUTRAN<->GERAN + * Use new stat item/ctr getter APIs + + [ Keith ] + * vty: Fix optional display of pdp with mm-context + * VTY: Don't display 'PDP Address: invalid' for IPv4v6 + + [ Eric ] + * add support for multiple encryption algorithms and a5/4 + + [ Oliver Smith ] + * gtphub: remove llist_first, llist_last macros + * vty: add "page imsi" + * debian/control: remove dh-systemd build-depend + * Revert "Turn some compiler warnings into errors" + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:57:50 +0100 + osmo-sgsn (1.7.0) unstable; urgency=medium [ Daniel Willmann ] diff --git a/debian/control b/debian/control index bc9c8ab..28637b3 100644 --- a/debian/control +++ b/debian/control @@ -11,16 +11,16 @@ pkg-config, libtalloc-dev, libc-ares-dev, - libgtp-dev (>= 1.7.0), - libosmocore-dev (>= 1.5.0), - libosmo-abis-dev (>= 1.1.0), + libgtp-dev (>= 1.8.0), + libosmocore-dev (>= 1.6.0), + libosmo-abis-dev (>= 1.2.0), libosmo-netif-dev (>= 1.1.0), - libosmo-gsup-client-dev (>= 1.3.0), + libosmo-gsup-client-dev (>= 1.4.0), libasn1c-dev (>= 0.9.30), - libosmo-ranap-dev (>= 0.7.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-sccp-dev (>= 1.4.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-ranap-dev (>= 0.8.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-sccp-dev (>= 1.5.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-sgsn.git Vcs-Browser: https://git.osmocom.org/osmo-sgsn -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I62daba59b9dd1a0cade5292c8705ee5ec5b103c2 Gerrit-Change-Number: 26288 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:58:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:58:35 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bsc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E359-d13ef-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26285 ) Change subject: Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 Gerrit-Change-Number: 26285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 16:58:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 16:58:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 16:58:37 +0000 Subject: =?UTF-8?Q?Change_in_osmo-bsc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E359-d13ef-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26285 ) Change subject: Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.0.359-d13ef-dirty ? 1.8.0 Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 --- M TODO-RELEASE M configure.ac M contrib/osmo-bsc.spec.in M debian/changelog M debian/control 5 files changed, 407 insertions(+), 30 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index cfb9cf9..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,13 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore >1.5.1 needs osmo_bts_features_name(), osmo_bts_features_desc() -libosmogsm >1.5.1 enum entry GSM0808_FE_IE_LAST_USED_EUTRAN_PLMN_ID -libosmogsm >1.5.1 introduced struct needed gsm0808_old_bss_to_new_bss_info->last_eutran_plmn_id -libosmo-mgcp-client >1.8.0 need osmo_mgcpc_ep_ci_get_remote_rtp_info() -libosmovty >1.5.1 needs vty_read_config_filep() -libosmosgsm >1.5.1 needs GSM_PCHAN_OSMO_DYN -libosmocore >1.5.1 RSL_IPAC_EIE_OSMO*, struct osmo_preproc_* -libosmocore >1.5.1 needs osmo_str_to_int() -libosmocore >1.5.1 needs new osmo_stat_item implementation (omits FIFO size for stat item) -libosmocore >=1.6 need osmo_time_cc diff --git a/configure.ac b/configure.ac index bcf91ba..c4eac4a 100644 --- a/configure.ac +++ b/configure.ac @@ -46,14 +46,14 @@ AM_CONDITIONAL(BUILD_IPA_UTILS, test "x$osmo_ac_ipa_utils" = "xyes") AC_SUBST(osmo_ac_ipa_utils) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.8.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/osmo-bsc.spec.in b/contrib/osmo-bsc.spec.in index 9f7ef48..187242c 100644 --- a/contrib/osmo-bsc.spec.in +++ b/contrib/osmo-bsc.spec.in @@ -31,15 +31,15 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.8.0 +BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.9.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(talloc) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 8fc8b76..40b509d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,390 @@ +osmo-bsc (1.8.0) unstable; urgency=medium + + [ Harald Welte ] + * remove obsolete dependency on libosmo-sccp + * manual: Include QoS chapter and add osmo-bsc specific example + + [ Javi ] + * Add vty command for Ericsson RBS2000 sync + * Add command to enable RX diversity to RBS2000 + + [ Oliver Smith ] + * stats: T3122 related: num_values 16 -> 60 + * src/utils/meas_vis.c: fix bs_power -> bs_power_db + * handover_test: fix ts_str may be uninitialized + * bsc_ctrl_commands: fix uninitialized value (mode) + * Revert "Turn some compiler warnings into errors" + + [ Neels Hofmeyr ] + * refactor handover penalty timers + * drop neighbor_ident_test.c + * fix/refactor neighbor config + * debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state + * fixup for neighbor config for coverity + * drop unused func decl rsl_lchan_mark_broken() + * drop unused gsm_bts_trx->description + * deprecation: use osmo_bts_features_*() + * fix wrong ARFCNs in local-cell neighbor config + * update neighbor ARFCNs on startup and config changes + * manual: Location Services: clarify BSC side address + * abis_nm_ipaccess_rsl_connect(): use msgb to compose attr + * Lb: stop RESET FSM when sccp_user is unbound + * Lb: RESET FSM: never send sccp_user == NULL + * Lb: add missing X12 timer configurability + * Lb: make sure we never have missing timer configurability + * gsm_lchan_name_compute with ctx + * log: drop duplicate logging in ts_setup_lchans() + * comment: tweak pchan_subslots() description + * lchan_release(): do not release UNUSED lchan + * lchan_fsm: mode modify: fix missing timeouts and error transitions + * fix test_gsm48_multirate_config: dump the complete AMR lv buffer + * test_gsm48_multirate_config: rather keep 4x amr_mode + * assignment_fsm: fix failure log message for lchan unavailable + * select_codecs(): do not confuse bool 'true' with integer value 1 + * gsm48_send_rr_ass_cmd(): rename dest_lchan to current_lchan + * gsm48_send_rr_ass_cmd(): rename lchan to new_lchan + * log: show src file,line of lchan_set_last_error + * add missing arg braces in LOG_LCHAN macro + * gscon MGCP: properly skip redundant MDCX towards MSC + * cosmetic: rename FOR_* to ACTIVATE_FOR_* + * cosmetic: rename lchan_activate_mode to lchan_activate_for + * lchan and assignment FSMs: make Channel Mode Modify more sane + * assignment_fsm: tweak error log msg for mixed modes + * handover_test: ack release only when lchan is still waiting + * hodec2: remove code dup of rxlev averaging + * handover_test: add bspower to meas-rep cmd + * add test_bs_power.ho_vty to show BS Power HO oscillation + * assignment_fsm: send BSSMAP response only after Assignment Request + * cosmetic scoping in reuse_existing_lchan() + * potential segfault: vty chan act: do not set AMR bits for EFR + * make sure channel mode and s15_s0 are updated only after an ACK + * remove special case from assignment_count_result() + * eliminate lchan->rsl_cmode + * move lchan->csd_mode into channel_mode_and_rate + * AMR config cleanup step 1: split lchan_mr_config() + * AMR config cleanup step 2: filter modes also for VTY + * AMR config cleanup step 3: generate AMR LV on msg composition + * handover dot charts: fix wrong transitions regarding MGW + * handover_test: fix naming/wording: 'handover-req' should be 'handover-cmd' + * assignment_fsm: tweak state transitions (prep for reassignment) + * assignment_fsm: allow assignment to a specific lchan + * vty: actually trigger Assignment for 'assignment', not HO + * hodec 2: do intra-cell congestion resolution by Assignment + * RSL link: explicitly select rsl_link based on lchan + * add chan_mode_to_chan_type() + * gsm48_lchan2chan_desc(): expose TSC as param + * allow explixit TSC Set and TSC on chan activ / modif / assignment + * VTY: dump TSC Set and TSC for each timeslot + * add fields to reflect nr of lchans in ts struct + * replace ts_*_for_each_lchan() with ts_for_n_lchans() + * ensure chan_mode comparisons in non-VAMOS mode + * lchan_fsm: introduce lchan.modify.ch_mode_rate to allow tweaking + * Drop duplicated arfcn_range_encode.c available in libosmocore + * fixup for Mode Modify TSC + * fix rc handling in channel_mode_from_lchan() + * drop unused func decl gsm_lchan_as_pchan2chan_nr() + * handover: apply meas report BS Power to RXLEV, fix ho oscillation + * change bs_power to bs_power_db + * meas rep logging: replace a dozen DEBUGPC() with one DEBUGP() + * meas rep logging: use log_check_level() to skip a logging loop + * fixup: pass tsc = -1 for previous default training sequence code + * hodec2: add handover_test cases for upgrade of TCH/H -> TCH/F + * cosmetic prep: hodec2: move is_upgrade_to_tchf() further up + * hodec2: fix is_upgrade_to_tchf() for requirement A + * allow mode modify when RTP stream is active + * implement Channel Mode Modify to VAMOS mode + * vty: add lchan modify '(vamos|non-vamos)' command + * add lchan->vamos.is_secondary flag + * vty-test: osmo-bsc.vty: test doc of lchan activate cmd + * lchan_fsm: introduce lchan.activate.ch_mode_rate to allow tweaking + * add missing AMR config for RTP activation after mode modify + * implement CHANnel ACTIVate to VAMOS mode + * RR Assignment for VAMOS: send TSC Set + * add VAMOS secondary lchans to timeslot struct + * update the lchan name to always reflect VAMOS shadowness + * rsl_lchan_lookup(): turn cbits if-cascade into a switch() + * rsl_lchan_lookup(): add comment explaining ts_is_capable_of_pchan() + * RSL chan_nr: replace OSMO_ASSERT with error handling + * RSL: rx and tx VAMOS Channel Number cbits for VAMOS lchans + * VTY: 'show lchan': show that lchan is in VAMOS mode + * VTY: add 'vamos-subslot' to activate a secondary lchan + * VTY: add lchan re-assignment command + * log: assignment_fsm: drop newline from assignment_fail + * log: assignment_fsm: tweak err msg for incompatible chan + * clarify bts_chan_load + * get_any_lchan(): reduce minor code dup + * cosmetic loop simplification in gsm48_multirate_config() + * RSL: set default TEI according to TRX number + * lchan_fsm: lchan_fail() strings should not have a terminating newline + * gsm_data.h: add comments about immutable activ/modif/assign request info + * hodec2: implement upgrade TCH/H -> TCH/F (without AFS bias) + * fixup for vamos: fix wrong cbits in rsl_lchan_lookup() + * vty: reassign: add missing check for valid target lchan + * hodec2: don't apply AFS bias to same-cell lchans + * rsl_data_request() check lchan pointer before access + * rsl_lchan_lookup: drop redundant condition + * rewire build_encr_info() to return errors + * dissolve gsm0808_cipher_mode() into bssmap_handle_cipher_mode() + * implement A5/4 in Ciphering Mode procedure + * support A5/4 in inter-BSC Handover + * use osmo_select_shutdown to get rid of SIGTERM sleep + * vty: allow 5 encryption algo entries + * hodec2: add test case showing low rxlev tch/h<->tch/f oscillation + * hodec2: add test case showing low rxqual tch/h<->tch/f oscillation + * handover_decision_2.c: add is_low_rxlev() + * hodec2: fix low rxlev tch/h<->tch/f oscillation + * handover_decision_2.c: add current_rxqual() + * hodec2: fix low rxqual tch/h<->tch/f oscillation + * vty: fix doc: default value for 'nri bitlen' + * vty: add vty doc test for 'nri null' commands + * hodec2: [1/2] implement automatic choice between FULL and SUBSET measurements + * hodec2: [2/2] implement automatic choice between FULL and SUBSET measurements + * hodec1: use same automatic FULL/SUBSET choice as in hodec2 + * lchan: call reset() upon alloc + * RES IND: parse msg and store interference levels in lchans + * RES IND: add VTY: bts / channel allocator avoid-interference (0|1) + * RES IND: add test_resource_indication.ho_vty + * RES IND: pick lchan with least interference + * ensure trigger_ho() returns zero only when HO or AS was indeed triggered + * handover_test: also show when an lchan is busy + * switch handover penalty timers to CLOCK_MONOTONIC + * handover_test: add fake-time 'wait' + * test_penalty_timer.ho_vty: show lchan recovery + * handover tests: test passing of penalty timeout + * hodec2: add low-rxqual-assignment penalty timer (1/2) + * hodec2: add low-rxqual-assignment penalty timer (2/2) + * separate 'interference-meas level-bounds' cfg and used + * vty 'interference-meas level-bounds': explain duality in ordering + * add test_dyn_ts_favor_static_ts_as_target.ho_vty + * extend test_dyn_ts_favor_half_used_tch_h_as_target.ho_vty + * RES IND: allow empty Resource Information IE + * RES IND: tweak error code on missing Resource Information IE + * fix CM Re-Establishment Request: allocate new A conn + * log: fix missing newline in lchan_select.c + * debug log: indicate change of primary lchan on a conn + * vty: lchan deact: allow omitting the lchan type arg + * vty: improve err msg for invalid subslot nr + * coverity: quench null deref warning in gscon_change_primary_lchan() + * lchan_fsm_post_activ_ack(): return upon release + * introduce gsm48_lchan_and_pchan2chan_desc() + * error log: improve lchan lookup error msg + * early IMM ASS 1/n: add vty config option + * early IMM ASS 2/n: implement 'pre-chan-ack' + * early IMM ASS 3/n: implement 'pre-ts-ack' + * stat_item desc: add explicit indexes for clarity + * vty: add "msc N bssmap reset" command + * move BSC level stats and rate counters to new bsc_stats.[hc] + * add stat items bsc.0.num_msc:connected, .num_msc:total + * add stat_items for BTS and TRX connection stati + * fixup for Early IMM ASS: use proper TSC + * add CTRL 'rf_states' and 'bts.N.rf_states' + * add CTRL bts.N.trx.M.rf_locked (RW) + * fixup comments for 'rf_states' CTRL command + * fix comment in lchan_fsm.c: s/modification/activation + * fix TSC / TSC Set used for Handover + * tsc fixup: tweak condition for coverity + * drop obsolete comment + * stat: add bts.N.num_trx:total + * stat: add bts.N.num_trx:rsl_connected + * constify lchan_state_is() + * add chreq:successful_ rate counters + * drop unused gsm48_tx_mm_serv_ack() + * for linter: s/while(0)/while (0) + * cosmetic tweaks on handover counting code + * tweak intra-bsc ho counter descriptions + * implement incoming_intra_bsc_ho:* rate counters + * refactor lchan counting + * add time_cc API: cumlative counter for time, reported as rate_ctr + * implement all_allocated:{sdcch,tch} rate counters + * implement all_allocated:{static_sdcch,static_tch} rate counters + * implement bts.N.cm_serv_rej: rate counters + * move time_cc to libosmocore osmo_time_cc + + [ Keith ] + * Ignore CHANnel ReQuireD with Access Delay IE > 63 + * Fix MEAS parsing, as Ericsson RBS reports TA shifted by 2 bits. + * Add vty command to manually force MS Uplink Power + * Implement MS Uplink Power Control Loop + + [ Vadim Yanitskiy ] + * [hopping] vty: ensure no duplicate hopping ARFCN entries + * [hopping] generate_cell_chan_list(): make some pointers const + * [hopping] gsm48_send_rr_ass_cmd(): use Cell Channel Description from SI1 + * [hopping] generate_ma_for_ts() returns no meaningful value + * abis_nm: rework warnings about unknown / not supported features + * abis_nm: cosmetic: use osmo_bts_feature_name() + * [hopping] Rework generation of Cell/Mobile Allocation + * [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again + * vty: deprecate BTS type 'sysmobts' in favor of 'osmo-bts' + * Replace all references to 'sysmobts' with 'osmo-bts' + * VTY: fix NULL-pointer dereference in lchan_act_single() + * bts_uptime(): do not spam logs with 'OML link uptime unavailable' + * Make interference measurement parameters configurable + * VTY: fix typo in a command description: s/send/sent/ + * PCUIF protocol: add message definition for interference report + * abis_rsl: fix rsl_rx_ccch_load(): properly check the message length + * gsm_data.h: remove declaration of non-existing ts_pchan() + * power_control: omit BS Power Parameters IE if the maximum is 0 dB + * power_control: implement BCCH carrier power reduction operation + * power_control: constrain BS power reduction on BCCH carrier + * lchan_fsm: fix potential NULL-pointer dereference + * gsm_04_08_rr: silently ignore RR UTRAN Classmark Change + * rsl_rx_resource_indication(): check result of rsl_tlv_parse() + * rsl_lchan_lookup(): fix handling of ABIS_RSL_CHAN_NR_CBITS_OSMO_PDCH + * [overpower] VTY: cosmetic: fix lower case in command description + * [overpower] VTY: fix copy-pasted warning message + * [overpower] VTY: add more ACCH overpower related parameters + * [overpower] Add VTY transcript tests for all commands + * .gitignore: also ignore *.la files + * .gitignore: remove non-existing ipaccess-firmware binary + * lchan_fsm: cosmetic: move a 'case' below the 'default' branch + * rsl_tx_chan_activ(): fix manual channel activation for nanoBTS + * abis_rsl: do not pass lchan to print_meas_rep_buf() + * abis_rsl: print_meas_rep_{buf,uni}() accept const *mr + * abis_rsl: permit simultaneous ACCH repetition and overpower + * ipaccess-config: reduce verbosity of the OML logging + * ipaccess-config: fix wrong flag name in ipa_nvflag_strs[] + * ipaccess-config: warn about unknown flag name + * doc/manuals: add documentation for interference reporting + * gsm_data: use ascending order for interference boundaries + * doc/manuals: add documentation for Temporary ACCH Overpower + * doc/manuals: fix wrong CI in the inter-BSC handover diagram + * tests/Makefile.am: do not try removing non-existing files + * abis_rsl: simplify checking if channel mode is AMR + * abis_rsl: cosmetic: fix coding style rep_acch_cap_for_bts() + * bts_vty: fix tabs-vs-spaces issues in cfg_bts_rep_dl_facch + * struct gsm_bts: simplify comments for ACCH repetition/overpower + * struct gsm_bts: s/repeated_acch_policy/rep_acch_cap/g + * struct gsm_bts: s/temporary_overpower/top_acch_cap/g + * abis_rsl: {rep,top}_acch_cap_for_bts(): make *lchan const + * abis_rsl: s/*_acch_cap_for_bts/put_*_acch_cap_ie/g + * [overpower] Allow configuring specific channel mode(s) + * [overpower] By default, permit only for speech channels using AMR + + [ Alexander Chemeris ] + * stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal. + + [ Pau Espin Pedrol ] + * cosmetic: Fix typo in func description + * bssap: pass whole tlv_parsed to event GSCON_EV_A_COMMON_ID_IND + * Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID + * Revert "update neighbor ARFCNs on startup and config changes" + * SRVCC: Parse Last Used E-UTRAN PLMN Id in Handover Request + * SRVCC: Forward Last EUTRAN PLMN Id in Handover Required + * osmo-bsc: Avoid erroring every few secs about unconnected BTS + * Fix bts->description field not printed in config write + * ipaccess-config: Clean up sign_link setup helper + * bsc: Clean up TS selection in ipaccess_sign_link_up/down + * bsc: Use osmo_clock_gettime everywhere + * ctrl: Introduce CTRL SET cmd to apply VTY cfg file + * ctrl: Avoid fclose() on NULL pointer + * Use new stat item/ctr getter APIs + * vty: Drop unused old node enum fields + * Introduce VTY command to disable srvcc fast-return on target BTS + * Introduce counters to track SRVCC procedures + * pcuif_proto.h: Add new container messages + * Support proto IPAC_PROTO_EXT_PCU BSC<->PCU + * lchan-select: Avoid setting variable for no reason + * assignment_fsm: Fix null pointer dereference rx ASSIGNMENT_EV_LCHAN_ERROR + * assignment_fsm: Add assert to guard ptr access + * Rename osmo dyn ts enums to contain SDCCH8 + * Support SDCCH8 in osmo dyn ts + * lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in WAIT_RF_RELEASE_ACK + * doc: bts.adoc: Update dyn ts section to include SDCCH8 support + * lchan_fsm: Improve timeout logging line in state WAIT_RLL_RTP_ESTABLISH + * Avoid switching dyn ts to sdcch8 if it starves later TCH + * cosmetic: Small improvements to _select_sdcch_for_call + * Add new lchan_select_set_type() API helper + * _select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it + * lchan_fsm: Allow rx LCHAN_EV_RLL_REL_IND in state BORKEN + * abis_rsl: Log chan rqd reason on resource exhaustion log message + * Fix recent regression in CHREQ allocation + * Split bsc_vty.c creating bts_vty.c + * Split bts_vty.c creating bts_trx_vty.c + * Introduce libbsc to avoid linking long lists of .o files + * Introduce VTY option to forbid use of TCH for non-voicecall signalling + * Clarify string name for GSM_CHREQ_REASON_CALL + * doc: Improve ACC ramp documentation + * doc: manual: Fix typo in text + * vty: Fix wrong TSC sent when activating lchan through VTY + * vty: Fix wrongs params passed in vty warning message + * cosmetic: power_ctrl_params_def: Fix typo in comment + * doc: power_control.adoc: Improve VTY snippet foot notes + * MS Power Control Loop: Support set up of C/I parameters for osmo-bts + * doc: power_control.adoc: Add small time graph showcasing P_CON_INTERVAL + * lchan_fsm: Fix comment + * lchan_fsm: Fix comment + * lchan_fsm: Avoid inheriting bs_power from old lchan + * Support Neighbor Address Resolution over PCUIF IPA multiplex + * Power Control Loop: Set P_CON_INTERVAL to 1 by default + * MS Power Control Loop: Support turn off C/I based logic + * bts_vty: Print C/I power params for osmo-bts only + * MS Power Control Loop: Allow Turn off/on C/I independent from value setting + * cosmetic: fix comment typos in signal.h + * cosmetic: Fix typo in comment + * MS Power Control Loop: Use P_CON_INTERVAL=2 by default + * bts_trx: Fix timeslot_fsm not properly freed during trx free() [1/4] + * Move global var bsc_gsmnet into libbsc [2/4] + * Move ts_fsm_init to static constructor [3/4] + * Get rid of lots of stubs [4/4] + * nm_channel_fsm: drop ipa link if SetChannelAttr fails + * gitignore: Fix typo + * jenkins.sh: Fix typo + * Set subslots_per_pchan[GSM_PCHAN_OSMO_DYN] = 8 + * timeslot_fsm: Add assert to make sure we never go out of bounds in ts->lchan array + * Set subslots_per_pchan_vamos[GSM_PCHAN_OSMO_DYN] = 0 + * assignment_fsm: Log modified lchan in assignment_fsm_allstate_action() + * lchan_fsm: Fix possible NULL ptr dereference in _lchan_on_mode_modify_failure() + * Properly handle dyn TS TCH with vamos after updating subslots_per_pchan + + [ Michael Iedema ] + * stats: add BTS uptime counter + + [ Philipp Maier ] + * bts.adoc: fix typo BGSGP -> BSSGP + * handover_cfg: add missing VTY_CMD_PREFIX in comment + * bsc_ctrl_commands: add command to write vty config + * control.adoc: add doc for apply-config-file + * bsc_vty: add vty option to allow call-reestablishment + * handover_ctrl: add control interface for handover settings + * running.adoc: explain mgw reset-endpoint VTY setting + * osmo_bsc_main: remove unused commandline option -l + * bty_vty: add VTY settungs for temporary overpower + * osmo_bsc_main: integrate MGW pooling into osmo-bsc + * osmo_bsc_msc: do not initalize MGCP proxy for AoIP MSCs + * doc/mgwpool: update documentation + * assignment_fsm: make assignment_fsm_timer_cb static + * assignment_fsm: make assignment_fsm_allstate_action static + * assignment_fsm: Check for conn->lchan + * osmo_bsc_main: remove code dup in bootstrap_bts() + * bts: set R99 MSC flag in SI13 in bts_alloc + * bts: set pwrc value in bts_alloc + * bts: set acs value in bts_alloc + * drop chan_load_samples_idx initalization from bootstrap_bts() + * bts: set ncc_permitted from bts_alloc + * osmo_bsc_main: remove not longer needed fixme note + * osmo_bsc_main: remove unused option -t --testmode + * bsc_subscr_conn_fsm: fix mgw-pool ref counting + * neighbor_ident: add comment about Neighbor Address Resolution Service + * control.adoc: improve description of command bts.N.send-new-system-informations + * heighbor_ident: add/del neighbor cells via ctrl interface + * bsc_ctrl_commands: change neighbor-list mode/arfcn via control interface + * control.adoc: comment out fixme note + * osmo_bsc_main: bootstrap_bts: print errornous ARFCN number + * osmo_bsc_main: separate checks from bootstrap_bts + * osmo_bsc_main: move inp_sig_cb() below check_bts and bootstrap_bts + * osmo_bsc_ctrl: make sure strtok results are checked + * osmo_bsc_main: call bootstrap_bts when OML TEI comes up + * osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() + + [ Eric ] + * vty: allow A5/4 encryption in config + + [ Daniel Willmann ] + * bts: Clear BTS_STAT_CHAN_*_{TOTAL,USED} on bts disconnect + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:21:59 +0100 + osmo-bsc (1.7.0) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index a135119..7ed4694 100644 --- a/debian/control +++ b/debian/control @@ -12,12 +12,12 @@ python3-minimal, libcdk5-dev, libtalloc-dev, - libosmocore-dev (>= 1.5.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-abis-dev (>= 1.1.0), + libosmocore-dev (>= 1.6.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.2.0), libosmo-netif-dev (>= 1.1.0), - libosmo-mgcp-client-dev (>= 1.8.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-mgcp-client-dev (>= 1.9.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-bsc.git Vcs-Browser: https://git.osmocom.org/osmo-bsc/ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd4f22f268aa5ec3c1b7839e334ffad69f2e50a9 Gerrit-Change-Number: 26285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:03:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:03:15 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gbproxy=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E0=2E49-f9902-dirty_=E2=86=92_0=2E2=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 ) Change subject: Bump version: 0.1.0.49-f9902-dirty ? 0.2.0 ...................................................................... Bump version: 0.1.0.49-f9902-dirty ? 0.2.0 Change-Id: I42647a35746c3cbd89e88d9f90f22f1c9275a919 --- M configure.ac M contrib/osmo-gbproxy.spec.in M debian/changelog M debian/control 4 files changed, 73 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/89/26289/1 diff --git a/configure.ac b/configure.ac index 11ebac4..353fc96 100644 --- a/configure.ac +++ b/configure.ac @@ -45,11 +45,11 @@ AC_SUBST(LIBRARY_DLSYM) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/osmo-gbproxy.spec.in b/contrib/osmo-gbproxy.spec.in index f1b5452..42c13cd 100644 --- a/contrib/osmo-gbproxy.spec.in +++ b/contrib/osmo-gbproxy.spec.in @@ -33,11 +33,11 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 %{?systemd_requires} %description diff --git a/debian/changelog b/debian/changelog index c6702cd..e6f31fd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,64 @@ +osmo-gbproxy (1:0.2.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Support setting rt-prio and cpu-affinity mask through VTY + * Avoid sending tx_status upon rx of RIM messages + * Use new stat item/ctr getter APIs + + [ Daniel Willmann ] + * gbproxy_main: Fix naming bsc_hack/nsip_proxy -> (osmo-)gbproxy + * manual: Update manuals, include sgsn pooling and NS variants + * manuals: Regenerate counters/VTY through docker + * Remove some outdated TODO/comments + * gb_proxy.h: Use pragma once instead of ifndef + * Update the max_sdu_len from NS + * Handle GPRS_NS2_AFF_CAUSE_FAILURE + * Remove osmo-sgsn relics + * gbproxy: Don't free NSE/BVC0 if SGSN NSE goes down + * gbproxy_main: Add ctrl vty commands + * gb_proxy: Ensure cell info is up to date when receiving PTP-BVC reset + * gbproxy_main: Process options after all initialization is done + * examples/manuals: Improve/update ns-related documentation + * Don't route messages to an SGSN if it is down + * manual: Update counters, add proper chapter for counters + * gbproxy_vty: Remove redundant command "show gbproxy links" + * manual: Add section describing show gbproxy command usage + * manual: Add chapter describing osmo counters in general + * gbproxy: Add usage flag to the imsi_cache + * gbproxy: Forward MS_REGISTR_ENQ/_RESP correctly + * gbproxy_peer: Set rate_ctr name for gbproxy_peer stats + * gbproxy_peer: Free a cell as soon as no BSS BVC uses it + * gbproxy_ctrl: Fix crash in nsvc-state ctrl command + * gbproxy_ctrl: Ignore SIG-BVCI in ctrl commands + * gbproxy: Remove SGSN-side BVC after sending BVC-BLOCK + * gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK + * gbproxy: Fix stats when no BVC could be found + * gbproxy: Use designated initializers for global_ctr_description + * gbproxy: Improve log message when no bvc is found (include bvci) + * gbproxy: Route BSSGP STATUS with PDU_IN_ERROR containing a TLLI + * gpproxy: Route BSSGP STATUS with PDU_IN_ERROR containing a TMSI + * gbproxy: Add comment, improve log message in gbproxy_tlli_from_status_pdu + * gbproxy: Improve STATUS handling from SGSN + * gbproxy: Route DL STATUS with BVCI on SIG-BVC + * gbproxy: Add comment, remove unused param in gbproxy_tlli_from_status_pdu + * gbproxy: Route STATUS in PtP-BVC by TLLI/TMSI as well + * gbproxy: Move BSSGP decoding into its own function and use it + * gbproxy: Increase correct counter when BSSGP decode from SGSN fails + * gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp + * gbproxy: Remove duplicate struct gprs_ra_id handling + + [ Harald Welte ] + * vty: Print CellId along with RA-ID + + [ Oliver Smith ] + * doc: include gb-ns2.adoc, not gb-variants.adoc + * gitignore: add gbproxy_vty_reference.xml + * examples/osmo-gbproxy.cfg: fix osmo-sgsn conflict + * debian/control: remove dh-systemd build-depend + * Revert "Turn some compiler warnings into errors" + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:03:02 +0100 + osmo-gbproxy (1:0.1.0) unstable; urgency=medium [ Philipp Maier ] diff --git a/debian/control b/debian/control index 2bdb50e..c71a321 100644 --- a/debian/control +++ b/debian/control @@ -10,8 +10,8 @@ libtool, pkg-config, libtalloc-dev, - libosmocore-dev (>= 1.5.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmocore-dev (>= 1.6.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-gbproxy.git Vcs-Browser: https://git.osmocom.org/osmo-gbproxy -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I42647a35746c3cbd89e88d9f90f22f1c9275a919 Gerrit-Change-Number: 26289 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:05:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:05:26 +0000 Subject: =?UTF-8?Q?Change_in_osmo-cbc=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E2=2E1-cf3c_=E2=86=92_0=2E2=2E3?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/26290 ) Change subject: Bump version: 0.2.2.1-cf3c ? 0.2.3 ...................................................................... Bump version: 0.2.2.1-cf3c ? 0.2.3 Change-Id: I145e8f4292f582b2656a66832e522e6010998828 --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/90/26290/1 diff --git a/debian/changelog b/debian/changelog index 334d300..b6e70e5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-cbc (0.2.3) unstable; urgency=medium + + [ Harald Welte ] + * varaible for atoi() result shouild be signed integer + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:05:21 +0100 + osmo-cbc (0.2.2) unstable; urgency=medium * rest_api.c: Add missing \n in log line after error message -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/26290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I145e8f4292f582b2656a66832e522e6010998828 Gerrit-Change-Number: 26290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:10:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:10:27 +0000 Subject: =?UTF-8?Q?Change_in_osmo-e1d=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E1=2E5-5e0d-dirty_=E2=86=92_0=2E2=2E2?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26291 ) Change subject: Bump version: 0.2.1.5-5e0d-dirty ? 0.2.2 ...................................................................... Bump version: 0.2.1.5-5e0d-dirty ? 0.2.2 Change-Id: I640c4503260e50d412a8c66260c61f9224fef8d2 --- M configure.ac M debian/changelog M debian/control 3 files changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/91/26291/1 diff --git a/configure.ac b/configure.ac index 6ecfe09..f5c15f2 100644 --- a/configure.ac +++ b/configure.ac @@ -34,9 +34,9 @@ PKG_CHECK_MODULES(TALLOC, [talloc >= 2.0.1]) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.6.0) PKG_CHECK_MODULES(LIBUSB, libusb-1.0 >= 1.0.21) AC_CONFIG_MACRO_DIR([m4]) diff --git a/debian/changelog b/debian/changelog index 2bd31b3..3e7dbb7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,16 @@ +osmo-e1d (0.2.2) unstable; urgency=medium + + [ Harald Welte ] + * e1d-prbs-test: Initialize libosmocore logging + * ctl: properly set the timeslot mode in E1DP_CMD_TS_QUERY + * make compile-time default logging configuration less verbose + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * gitignore: Add configure~ + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:10:15 +0100 + osmo-e1d (0.2.1) unstable; urgency=medium * add README.md describing what this repository is about diff --git a/debian/control b/debian/control index 1f35d65..f1e35b7 100644 --- a/debian/control +++ b/debian/control @@ -10,9 +10,9 @@ libtool, pkg-config, python3-minimal, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), libusb-1.0-0-dev, - osmo-gsm-manuals-dev (>= 1.1.0) + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-e1d.git Vcs-Browser: https://git.osmocom.org/osmo-e1d/ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I640c4503260e50d412a8c66260c61f9224fef8d2 Gerrit-Change-Number: 26291 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 16 17:13:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 17:13:46 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6193e6dca208a_5b8b2ac6bd19e6102468c4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 499s] building additional files... [ 499s] checking if compiling is necessary... [ 499s] the output file doesn't exist [ 499s] pdflatex -interaction=batchmode rtp-amr.tex [ 499s] pdflatex failed [ 499s] [ 499s] A possible reason for transformation failure is invalid DocBook [ 499s] (as reported by xmllint) [ 499s] [ 499s] Error: pdflatex compilation failed [ 499s] [ 499s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 499s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 499s] make[3]: *** [Makefile:380: all-recursive] Error 1 [ 499s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 499s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 499s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 499s] make[1]: *** [Makefile:371: all] Error 2 [ 499s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 499s] dh_auto_build: error: make -j1 returned exit code 2 [ 499s] make: *** [debian/rules:12: build] Error 25 [ 499s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 499s] ### VM INTERACTION START ### [ 500s] Powering off. [ 500s] [ 452.205195] reboot: Power down [ 500s] ### VM INTERACTION END ### [ 500s] [ 500s] cloud115 failed "build osmo-bts_1.3.3.dsc" at Tue Nov 16 17:13:36 UTC 2021. [ 500s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:14:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:14:26 +0000 Subject: =?UTF-8?Q?Change_in_osmo-smlc=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E2-ec37-dirty_=E2=86=92_0=2E2=2E1?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26292 ) Change subject: Bump version: 0.2.0.2-ec37-dirty ? 0.2.1 ...................................................................... Bump version: 0.2.0.2-ec37-dirty ? 0.2.1 Change-Id: I4a2e2ff8e5f8d08fb4f8bb1f75e92ede9bb5521f --- M configure.ac M contrib/osmo-smlc.spec.in M debian/changelog M debian/control 4 files changed, 26 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/92/26292/1 diff --git a/configure.ac b/configure.ac index eed5ee9..fbcdab5 100644 --- a/configure.ac +++ b/configure.ac @@ -34,12 +34,12 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.5.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/osmo-smlc.spec.in b/contrib/osmo-smlc.spec.in index ffaef03..4984efc 100644 --- a/contrib/osmo-smlc.spec.in +++ b/contrib/osmo-smlc.spec.in @@ -33,12 +33,12 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sccp) >= 1.4.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sccp) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(talloc) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 73f17c1..ebe1f22 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +osmo-smlc (0.2.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + + [ Oliver Smith ] + * configure: don't turn some warnings into errors + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:14:21 +0100 + osmo-smlc (0.2.0) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index c64b941..f599992 100644 --- a/debian/control +++ b/debian/control @@ -12,10 +12,10 @@ pkg-config, libsctp-dev, libtalloc-dev, - libosmocore-dev (>= 1.5.0), - libosmo-sccp-dev (>= 1.4.0), - libosmo-sigtran-dev (>= 1.4.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmocore-dev (>= 1.6.0), + libosmo-sccp-dev (>= 1.5.0), + libosmo-sigtran-dev (>= 1.5.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-smlc.git Vcs-Browser: https://git.osmocom.org/osmo-smlc/ -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I4a2e2ff8e5f8d08fb4f8bb1f75e92ede9bb5521f Gerrit-Change-Number: 26292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 16 17:14:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 16 Nov 2021 17:14:54 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6193e714b6df1_5b8b2ac6bd19e6102469a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 482s] building additional files... [ 482s] checking if compiling is necessary... [ 482s] the output file doesn't exist [ 482s] pdflatex -interaction=batchmode rtp-amr.tex [ 482s] pdflatex failed [ 482s] [ 482s] A possible reason for transformation failure is invalid DocBook [ 482s] (as reported by xmllint) [ 482s] [ 482s] Error: pdflatex compilation failed [ 482s] [ 482s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 482s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 482s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 482s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 482s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 482s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 482s] make[1]: *** [Makefile:375: all] Error 2 [ 482s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 482s] dh_auto_build: error: make -j1 returned exit code 2 [ 482s] make: *** [debian/rules:12: build] Error 25 [ 482s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 482s] ### VM INTERACTION START ### [ 483s] Powering off. [ 483s] [ 465.700696] reboot: Power down [ 483s] ### VM INTERACTION END ### [ 483s] [ 483s] lamb20 failed "build osmo-bts_1.3.0.348.f422.202111160026.dsc" at Tue Nov 16 17:14:50 UTC 2021. [ 483s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:23:51 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 17:23:51 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: dexter has uploaded a new patch set (#6) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... cards: Make select_adf_by_aid() use prefix AID selection There is no need for us to expand a partial AID to the full AID before selecting that ADF. The UICC specifications permit AID selection by prefix only. So we could pass the prefix to the card, and the card would do the prefix matching. In order to avoid problems with cards that fail to do the prefix matching themselves we will still do the AID completion, but in case we cannot complete the AID (AID not listed in EF.DIR), we will try with the AID prefix anyway. >From the API user point of view, this allows us to select applications not listed in EF.DIR Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 --- M pySim/cards.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/25873/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:30:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:30:11 +0000 Subject: =?UTF-8?Q?Change_in_osmo-hnodeb=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E0_=E2=86=92_0=2E0=2E1?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26293 ) Change subject: Bump version: 0.0.0 ? 0.0.1 ...................................................................... Bump version: 0.0.0 ? 0.0.1 Change-Id: I7c561ce54d8c2ff2cad8f66685016ab71991138e --- M configure.ac M contrib/osmo-hnodeb.spec.in M debian/changelog M debian/control 4 files changed, 59 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/93/26293/1 diff --git a/configure.ac b/configure.ac index 5b4ca8b..8453bc4 100644 --- a/configure.ac +++ b/configure.ac @@ -56,16 +56,16 @@ LIBS=$old_LIBS PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.7.0) -PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.7.0) -PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.7.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) +PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) +PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.8.0) dnl checks for header files diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index 57b3280..063e69a 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -34,16 +34,16 @@ %endif BuildRequires: pkgconfig(libcrypto) >= 0.9.5 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmo-hnbap) >= 0.7.0 -BuildRequires: pkgconfig(libosmo-ranap) >= 0.7.0 -BuildRequires: pkgconfig(libosmo-rua) >= 0.7.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmo-hnbap) >= 0.8.0 +BuildRequires: pkgconfig(libosmo-ranap) >= 0.8.0 +BuildRequires: pkgconfig(libosmo-rua) >= 0.8.0 BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(libasn1c) >= 0.9.30 %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 8e9a94d..5c0cfd7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,36 @@ +osmo-hnodeb (0.0.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * configure: link against libsctp + * Import hnb-test from osmo-iuh.git + * Move existing vty code to its own vty.c/h file + * main.c: Drop commented out code + * Move rua related code to rua.c/h + * Move hnbap related code to hnbap.c/h + * Allocate g_hnb as a pointer, move code to hnb.c/h + * Move protocol related code in main.c to related proto files + * main.c: Fix cap in naming for vty_info.name + * More work on main.c to add osmocom functionalitites + * Set up Iuh conn params through VTY + * Drop unused fields in struct hnb + * hnb: Move wqueue to .iuh, add wrapper to use it + * Use osmocom logging in non-main files + * use osmo_stream_cli to manage sctp Iuh conn + * Send HnbRegisterRequest when HnodeB connects on Iuh + * Configure PLMN over VTY and use it in HnbRegisterRequest + * Configure CI,LAC,RAC,SAC over VTY and use it in HnbRegisterRequest + * Configure HNB-Identity over VTY and use it in HnbRegisterRequest + * Generate proper rnc_id and plmn in LuRequest + * hnb.c: Fix memleak in hnb_iuh_read_cb + * ranap: Fix compiler warnings passing func callback + + [ Oliver Smith ] + * d/control, spec: add missing builddeps + * rpm spec: fix invalid file paths + * gitignore: add src/osmo-hnodeb/osmo-hnodeb + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:29:42 +0100 + osmo-hnodeb (0.0.0) unstable; urgency=medium * Initial debian package diff --git a/debian/control b/debian/control index fd5f4bb..a306e10 100644 --- a/debian/control +++ b/debian/control @@ -14,14 +14,14 @@ libtalloc-dev, libasn1c-dev (>= 0.9.30), libsctp-dev, - libosmocore-dev (>= 1.5.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-abis-dev (>= 1.1.0), + libosmocore-dev (>= 1.6.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.2.0), libosmo-netif-dev (>= 1.1.0), - libosmo-hnbap-dev (>= 0.7.0), - libosmo-ranap-dev (>= 0.7.0), - libosmo-rua-dev (>= 0.7.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-hnbap-dev (>= 0.8.0), + libosmo-ranap-dev (>= 0.8.0), + libosmo-rua-dev (>= 0.8.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-hnodeb.git Vcs-Browser: https://git.osmocom.org/osmo-hnodeb/ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I7c561ce54d8c2ff2cad8f66685016ab71991138e Gerrit-Change-Number: 26293 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:35:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:35:17 +0000 Subject: =?UTF-8?Q?Change_in_openbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E6-68740_=E2=86=92_1=2E4=2E1?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/openbsc/+/26294 ) Change subject: Bump version: 1.4.0.6-68740 ? 1.4.1 ...................................................................... Bump version: 1.4.0.6-68740 ? 1.4.1 Change-Id: I83c4ee3981e445ec83e9439adeb8a48355ce8a06 --- M debian/changelog 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/94/26294/1 diff --git a/debian/changelog b/debian/changelog index 6d6405b..f78784f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,19 @@ +openbsc (1.4.1) unstable; urgency=medium + + [ Oliver Smith ] + * contrib/jenkins: don't build osmo-gsm-manuals + * debian/control: remove dh-systemd build-depend + + [ Pau Espin Pedrol ] + * tests: Explicitly drop category from log + * gitignore: Ignore configure~ file + * tests: Replace deprecated API log_set_print_filename + + [ Harald Welte ] + * add README.md to indicate what this repo is about + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:35:09 +0100 + openbsc (1.4.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/26294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I83c4ee3981e445ec83e9439adeb8a48355ce8a06 Gerrit-Change-Number: 26294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:38:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 17:38:50 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 6: (3 comments) The patch looks a lot better now, thanks! Just a few minor things... https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py at 52 PS6, Line 52: match_sim I still don't like this code duplication. Both functions are basically doing the same thing: trying to select '3f00' using the given CLA/SEL bytes. I suggest to add a more generic method to CardProfile and call it e.g. try_select_3f00() or so. Then in child classes you could use it this way: if self.try_select_3f00(): # will use self.cla and self.sel_ctrl or even this way in CardProfileUICCSIM: if self.try_select_3f00() and self.try_select_3f00(sel_ctrl='0000'): https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py at 154 PS6, Line 154: key=operator.attrgetter('order') Alternatively: key=lambda cls: cls.order https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/ts_102_221.py at 615 PS6, Line 615: order Cosmetic: class properties are usually upper case. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Nov 2021 17:38:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:40:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:40:28 +0000 Subject: =?UTF-8?Q?Change_in_osmo-msc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E43-aefbf-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26287 ) Change subject: Bump version: 1.7.0.43-aefbf-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I37aa63e1c4ed021c5cc8b186f073cf01ab9a9cb6 Gerrit-Change-Number: 26287 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:40:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:40:52 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sgsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E28-245ac-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 ) Change subject: Bump version: 1.7.0.28-245ac-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I62daba59b9dd1a0cade5292c8705ee5ec5b103c2 Gerrit-Change-Number: 26288 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:40:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:41:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:41:20 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gbproxy=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E0=2E49-f9902-dirty_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 ) Change subject: Bump version: 0.1.0.49-f9902-dirty ? 0.2.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I42647a35746c3cbd89e88d9f90f22f1c9275a919 Gerrit-Change-Number: 26289 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:41:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:41:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:41:29 +0000 Subject: =?UTF-8?Q?Change_in_osmo-cbc=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E2=2E1-cf3c_=E2=86=92_0=2E2=2E3?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/26290 ) Change subject: Bump version: 0.2.2.1-cf3c ? 0.2.3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/26290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I145e8f4292f582b2656a66832e522e6010998828 Gerrit-Change-Number: 26290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:41:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:41:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:41:44 +0000 Subject: =?UTF-8?Q?Change_in_osmo-e1d=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E1=2E5-5e0d-dirty_=E2=86=92_0=2E2=2E2?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26291 ) Change subject: Bump version: 0.2.1.5-5e0d-dirty ? 0.2.2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I640c4503260e50d412a8c66260c61f9224fef8d2 Gerrit-Change-Number: 26291 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:41:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:41:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:41:54 +0000 Subject: =?UTF-8?Q?Change_in_osmo-smlc=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E2-ec37-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26292 ) Change subject: Bump version: 0.2.0.2-ec37-dirty ? 0.2.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I4a2e2ff8e5f8d08fb4f8bb1f75e92ede9bb5521f Gerrit-Change-Number: 26292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:41:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:41:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:41:56 +0000 Subject: =?UTF-8?Q?Change_in_osmo-cbc=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E2=2E1-cf3c_=E2=86=92_0=2E2=2E3?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/26290 ) Change subject: Bump version: 0.2.2.1-cf3c ? 0.2.3 ...................................................................... Bump version: 0.2.2.1-cf3c ? 0.2.3 Change-Id: I145e8f4292f582b2656a66832e522e6010998828 --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 334d300..b6e70e5 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-cbc (0.2.3) unstable; urgency=medium + + [ Harald Welte ] + * varaible for atoi() result shouild be signed integer + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:05:21 +0100 + osmo-cbc (0.2.2) unstable; urgency=medium * rest_api.c: Add missing \n in log line after error message -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/26290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I145e8f4292f582b2656a66832e522e6010998828 Gerrit-Change-Number: 26290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:42:25 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:42:25 +0000 Subject: =?UTF-8?Q?Change_in_openbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E6-68740_=E2=86=92_1=2E4=2E1?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/26294 ) Change subject: Bump version: 1.4.0.6-68740 ? 1.4.1 ...................................................................... Patch Set 1: note sure we want to tag new versions here? this is obsolete ... -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/26294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I83c4ee3981e445ec83e9439adeb8a48355ce8a06 Gerrit-Change-Number: 26294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:42:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:42:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:42:40 +0000 Subject: =?UTF-8?Q?Change_in_osmo-hnodeb=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E0_=E2=86=92_0=2E0=2E1?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26293 ) Change subject: Bump version: 0.0.0 ? 0.0.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I7c561ce54d8c2ff2cad8f66685016ab71991138e Gerrit-Change-Number: 26293 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:42:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:42:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:42:46 +0000 Subject: =?UTF-8?Q?Change_in_osmo-msc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E43-aefbf-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26287 ) Change subject: Bump version: 1.7.0.43-aefbf-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I37aa63e1c4ed021c5cc8b186f073cf01ab9a9cb6 Gerrit-Change-Number: 26287 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 17:42:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:42:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:42:48 +0000 Subject: =?UTF-8?Q?Change_in_osmo-msc=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E43-aefbf-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26287 ) Change subject: Bump version: 1.7.0.43-aefbf-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.0.43-aefbf-dirty ? 1.8.0 Change-Id: I37aa63e1c4ed021c5cc8b186f073cf01ab9a9cb6 --- M TODO-RELEASE M configure.ac M contrib/osmo-msc.spec.in M debian/changelog M debian/control 5 files changed, 93 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index d969e50..d0852fc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,3 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore >1.5.1 A5/4 support requires new API gsm0808_create_cipher2(), and gsm0808_handover_request.kc128 diff --git a/configure.ac b/configure.ac index 702be9f..3395ecc 100644 --- a/configure.ac +++ b/configure.ac @@ -36,16 +36,16 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.8.0) -PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.3.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) +PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.4.0) old_LIBS=$LIBS AC_SEARCH_LIBS([sctp_send], [sctp], [ @@ -103,7 +103,7 @@ [osmo_ac_iu="$enableval"],[osmo_ac_iu="no"]) if test "x$osmo_ac_iu" = "xyes" ; then PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) - PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.7.0) + PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) AC_DEFINE(BUILD_IU, 1, [Define if we want to build IuPS and IuCS interfaces support]) fi AM_CONDITIONAL(BUILD_IU, test "x$osmo_ac_iu" = "xyes") diff --git a/contrib/osmo-msc.spec.in b/contrib/osmo-msc.spec.in index 3ead299..17c07b9 100644 --- a/contrib/osmo-msc.spec.in +++ b/contrib/osmo-msc.spec.in @@ -35,16 +35,16 @@ BuildRequires: pkgconfig >= 0.20 BuildRequires: pkgconfig(dbi) BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.3.0 -BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.8.0 +BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.4.0 +BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.9.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sccp) >= 1.4.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sccp) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(libsmpp34) >= 1.14.0 #### BuildRequires: lksctp-tools-devel @@ -52,7 +52,7 @@ %{?systemd_requires} %if %{with_iu} BuildRequires: pkgconfig(libasn1c) >= 0.9.30 -BuildRequires: pkgconfig(libosmo-ranap) >= 0.7.0 +BuildRequires: pkgconfig(libosmo-ranap) >= 0.8.0 %endif %if 0%{?suse_version} Requires: libdbi-drivers-dbd-sqlite3 diff --git a/debian/changelog b/debian/changelog index 758173b..54fbd03 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,68 @@ +osmo-msc (1.8.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * configure.ac: Depend on newer libosmo-ranap + * Fill Last Used E-UTRAN PLMN Id when in CSFB + * Use new osmo stat items/ctr APIs + * sgs: Use available API to set vlr subscr LastUsedEutranPLMNId + * vlr_sgs: Drop recorded LastEutranPlmnId when UE no longer associated + * sgs_iface.c: Improve logging when paging over SGs + * msc_a.c: Allow MSC_A_EV_CN_CLOSE in state MSC_A_ST_RELEASING + * cosmetic: fix typos in comments + * vlr_sgs.h: Set proper logic order of items in enum sgs_ue_fsm_state + * vlr_auth_fsm.c: Simplify function auth_fsm_wait_ai_resync + * vlr_sgs.c: Fix missing use_count decrease in vlr_sgs_imsi_detach + * vlr_sgs: Balance use_count incremented in vlr_sgs_loc_update + * cosmetic: Fix typo in comment + + [ Oliver Smith ] + * contrib/osmo-msc.spec.in: depend on dbd-sqlite3 + * contrib/osmo-msc.spec.in: require libosmo-ranap >= 0.7.0 + * Revert "Turn some compiler warnings into errors" + + [ Vadim Yanitskiy ] + * SMS-over-GSUP: notify sender if no transaction found + * msc_tx_common_id(): fix potential NULL pointer dereference + * libmsc: fix NULL pointer dereference in trans_lcls_compose() + * libmsc: struct smsc: drop 'const' qualifier from bind_addr + * smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf() + * mncc: rework passing GCR over the MNCC interface + * manuals: remove deprecated -C / --no-dbcounter options + * Do not mention deprecated -M / --mncc-sock-path options + * Do not mention deprecated -l / --database options + + [ Neels Hofmeyr ] + * osmo-msc main: use osmo_select_shutdown() + * ran_msg_a.c: use gsm0808_create_cipher2() + * support A5/4 in Cipher Mode Command + * support A5/4 in inter-BSC handover + * improve logging on encryption, for Ciphering and HO + * add sequence_charts/call_reestablishment.msc + * add vlr_subscr_find_by_mi + * implement CM Re-Establish for voice calls + + [ Eric Wild ] + * vty: allow A5/4 encryption in config + + [ Philipp Maier ] + * running.adoc: add section about MGCP configuration + * msc_vlr_test: remove DLMGCP log messages from unit test output + + [ Harald Welte ] + * smpp: Fix help string in vty for "alert-notifications" + * smpp_mirror: Factor-out reset of SMPP read state + * smpp_mirror: Don't allocate msgb's for unrealistic amounts of memory + * Fix enabling of UMTS UEA encryption + * Make UTRAN encryption algorithms configurable + + [ Keith Whyte ] + * Add support for LCLS to the MSC + + [ Alexander Couzens ] + * Validate the choosen UTRAN encryption algorithm + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:44:54 +0100 + osmo-msc (1.7.0) unstable; urgency=medium [ Keith Whyte ] diff --git a/debian/control b/debian/control index 9b529c2..0b2ac6b 100644 --- a/debian/control +++ b/debian/control @@ -15,15 +15,15 @@ libtalloc-dev, libsmpp34-dev (>= 1.14.0), libasn1c-dev (>= 0.9.30), - libosmocore-dev (>= 1.5.0), - libosmo-sccp-dev (>= 1.4.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-abis-dev (>= 1.1.0), - libosmo-mgcp-client-dev (>= 1.8.0), - libosmo-gsup-client-dev (>= 1.3.0), + libosmocore-dev (>= 1.6.0), + libosmo-sccp-dev (>= 1.5.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.2.0), + libosmo-mgcp-client-dev (>= 1.9.0), + libosmo-gsup-client-dev (>= 1.4.0), libosmo-netif-dev (>= 1.1.0), - libosmo-ranap-dev (>= 0.7.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-ranap-dev (>= 0.8.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-msc.git Vcs-Browser: https://git.osmocom.org/osmo-msc/ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I37aa63e1c4ed021c5cc8b186f073cf01ab9a9cb6 Gerrit-Change-Number: 26287 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:43:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Nov 2021 17:43:06 +0000 Subject: Change in osmo-iuh[master]: gitignore: Ignore libsmo-{hnbap,rua}.pc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26286 ) Change subject: gitignore: Ignore libsmo-{hnbap,rua}.pc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib66ca43017447f23ea041b466a2bf122a0a4946e Gerrit-Change-Number: 26286 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:43:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:43:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:43:18 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sgsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E28-245ac-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 ) Change subject: Bump version: 1.7.0.28-245ac-dirty ? 1.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I62daba59b9dd1a0cade5292c8705ee5ec5b103c2 Gerrit-Change-Number: 26288 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 17:43:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:43:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:43:21 +0000 Subject: =?UTF-8?Q?Change_in_osmo-sgsn=5Bmaster=5D=3A_Bump_version=3A_1=2E7=2E0=2E28-245ac-dirty_=E2=86=92_1=2E8=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 ) Change subject: Bump version: 1.7.0.28-245ac-dirty ? 1.8.0 ...................................................................... Bump version: 1.7.0.28-245ac-dirty ? 1.8.0 Change-Id: I62daba59b9dd1a0cade5292c8705ee5ec5b103c2 --- M TODO-RELEASE M configure.ac M contrib/osmo-sgsn.spec.in M debian/changelog M debian/control 5 files changed, 74 insertions(+), 31 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 44ee421..1c5d61f 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,3 +1 @@ #component what description / commit summary line -libosmogb > 1.5.1 bssgp_encode_rim_pdu symbol was not exported previously -libgtp > 1.7.1 use gtp_ran_info_relay_req(), gtp_set_cb_ran_info_relay_ind() diff --git a/configure.ac b/configure.ac index 9607373..4a2d683 100644 --- a/configure.ac +++ b/configure.ac @@ -45,29 +45,28 @@ AC_SUBST(LIBRARY_DLSYM) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.3.0) +PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.4.0) +PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.8.0) # Enable/disable 3G aka IuPS + IuCS support? AC_ARG_ENABLE([iu], [AS_HELP_STRING([--enable-iu], [Build 3G support, aka IuPS and IuCS interfaces])], [osmo_ac_iu="$enableval"],[osmo_ac_iu="no"]) if test "x$osmo_ac_iu" = "xyes" ; then - PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) + PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) - PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.7.0) + PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) AC_DEFINE(BUILD_IU, 1, [Define if we want to build IuPS and IuCS interfaces support]) fi AM_CONDITIONAL(BUILD_IU, test "x$osmo_ac_iu" = "xyes") AC_SUBST(osmo_ac_iu) - -PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.7.0) PKG_CHECK_MODULES(LIBCARES, libcares) dnl checks for header files diff --git a/contrib/osmo-sgsn.spec.in b/contrib/osmo-sgsn.spec.in index f661fa0..9cf18f6 100644 --- a/contrib/osmo-sgsn.spec.in +++ b/contrib/osmo-sgsn.spec.in @@ -34,20 +34,20 @@ %endif BuildRequires: pkgconfig(libcares) BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libgtp) >= 1.7.0 -BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.3.0 +BuildRequires: pkgconfig(libgtp) >= 1.8.0 +BuildRequires: pkgconfig(libosmo-gsup-client) >= 1.4.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 %{?systemd_requires} %if %{with_iu} BuildRequires: pkgconfig(libasn1c) -BuildRequires: pkgconfig(libosmo-ranap) >= 0.7.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 +BuildRequires: pkgconfig(libosmo-ranap) >= 0.8.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 %endif %description diff --git a/debian/changelog b/debian/changelog index 2edc6e6..e1706df 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,49 @@ +osmo-sgsn (1.8.0) unstable; urgency=medium + + [ Harald Welte ] + * Remove bogus DNS log category + + [ Daniel Willmann ] + * manuals: Regenerate counters/VTY through docker + + [ Vadim Yanitskiy ] + * main: resurrect removed 'ns' logging category as deprecated + * doc/manuals: update configuration.adoc to use new command syntax + * tests/Makefile.am: do not try removing non-existing files + + [ Pau Espin Pedrol ] + * ranap: log ranap iu event type name instead of number + * gmm: log GMM msg type name instead of number + * gmm: Expect E_VLR_ANSWERED when in ST_IU_SECURITY_CMD + * gmm_fsm: Expect E_GMM_COMMON_PROC_INIT_REQ when in ST_GMM_COMMON_PROC_INIT + * mm_iu: Send event E_PMM_PS_CONN_ESTABLISH upon rx GMM SERVICE REQUEST + * mm_iu: Expect E_PMM_PS_ATTACH when in ST_PMM_IDLE + * gprs_gmm.c: State proper GMM prefix logging rx/tx of GMM messages + * mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED + * Iu: Drop timer X3314 + * gprs_ranap.c: Clean up code path releasing IU conn + * mm_state_{gb,iu}_fsm: Add missing license block, improve spec references + * mm_state_{gb,iu}_fsm: Improve naming for detach event + * Drop unused GBRPOXY enum field + * gtp: Delete ctx upon receive UpdateCtxResp with cause Non-existent + * Support forwarding RIM messages over GTPCv1 EUTRAN<->GERAN + * Use new stat item/ctr getter APIs + + [ Keith ] + * vty: Fix optional display of pdp with mm-context + * VTY: Don't display 'PDP Address: invalid' for IPv4v6 + + [ Eric ] + * add support for multiple encryption algorithms and a5/4 + + [ Oliver Smith ] + * gtphub: remove llist_first, llist_last macros + * vty: add "page imsi" + * debian/control: remove dh-systemd build-depend + * Revert "Turn some compiler warnings into errors" + + -- Pau Espin Pedrol Tue, 16 Nov 2021 17:57:50 +0100 + osmo-sgsn (1.7.0) unstable; urgency=medium [ Daniel Willmann ] diff --git a/debian/control b/debian/control index bc9c8ab..28637b3 100644 --- a/debian/control +++ b/debian/control @@ -11,16 +11,16 @@ pkg-config, libtalloc-dev, libc-ares-dev, - libgtp-dev (>= 1.7.0), - libosmocore-dev (>= 1.5.0), - libosmo-abis-dev (>= 1.1.0), + libgtp-dev (>= 1.8.0), + libosmocore-dev (>= 1.6.0), + libosmo-abis-dev (>= 1.2.0), libosmo-netif-dev (>= 1.1.0), - libosmo-gsup-client-dev (>= 1.3.0), + libosmo-gsup-client-dev (>= 1.4.0), libasn1c-dev (>= 0.9.30), - libosmo-ranap-dev (>= 0.7.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-sccp-dev (>= 1.4.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-ranap-dev (>= 0.8.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-sccp-dev (>= 1.5.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-sgsn.git Vcs-Browser: https://git.osmocom.org/osmo-sgsn -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I62daba59b9dd1a0cade5292c8705ee5ec5b103c2 Gerrit-Change-Number: 26288 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:43:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:43:51 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gbproxy=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E0=2E49-f9902-dirty_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 ) Change subject: Bump version: 0.1.0.49-f9902-dirty ? 0.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I42647a35746c3cbd89e88d9f90f22f1c9275a919 Gerrit-Change-Number: 26289 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Nov 2021 17:43:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:43:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:43:53 +0000 Subject: =?UTF-8?Q?Change_in_osmo-gbproxy=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E0=2E49-f9902-dirty_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 ) Change subject: Bump version: 0.1.0.49-f9902-dirty ? 0.2.0 ...................................................................... Bump version: 0.1.0.49-f9902-dirty ? 0.2.0 Change-Id: I42647a35746c3cbd89e88d9f90f22f1c9275a919 --- M configure.ac M contrib/osmo-gbproxy.spec.in M debian/changelog M debian/control 4 files changed, 73 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 11ebac4..353fc96 100644 --- a/configure.ac +++ b/configure.ac @@ -45,11 +45,11 @@ AC_SUBST(LIBRARY_DLSYM) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/osmo-gbproxy.spec.in b/contrib/osmo-gbproxy.spec.in index f1b5452..42c13cd 100644 --- a/contrib/osmo-gbproxy.spec.in +++ b/contrib/osmo-gbproxy.spec.in @@ -33,11 +33,11 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 %{?systemd_requires} %description diff --git a/debian/changelog b/debian/changelog index c6702cd..e6f31fd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,64 @@ +osmo-gbproxy (1:0.2.0) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Support setting rt-prio and cpu-affinity mask through VTY + * Avoid sending tx_status upon rx of RIM messages + * Use new stat item/ctr getter APIs + + [ Daniel Willmann ] + * gbproxy_main: Fix naming bsc_hack/nsip_proxy -> (osmo-)gbproxy + * manual: Update manuals, include sgsn pooling and NS variants + * manuals: Regenerate counters/VTY through docker + * Remove some outdated TODO/comments + * gb_proxy.h: Use pragma once instead of ifndef + * Update the max_sdu_len from NS + * Handle GPRS_NS2_AFF_CAUSE_FAILURE + * Remove osmo-sgsn relics + * gbproxy: Don't free NSE/BVC0 if SGSN NSE goes down + * gbproxy_main: Add ctrl vty commands + * gb_proxy: Ensure cell info is up to date when receiving PTP-BVC reset + * gbproxy_main: Process options after all initialization is done + * examples/manuals: Improve/update ns-related documentation + * Don't route messages to an SGSN if it is down + * manual: Update counters, add proper chapter for counters + * gbproxy_vty: Remove redundant command "show gbproxy links" + * manual: Add section describing show gbproxy command usage + * manual: Add chapter describing osmo counters in general + * gbproxy: Add usage flag to the imsi_cache + * gbproxy: Forward MS_REGISTR_ENQ/_RESP correctly + * gbproxy_peer: Set rate_ctr name for gbproxy_peer stats + * gbproxy_peer: Free a cell as soon as no BSS BVC uses it + * gbproxy_ctrl: Fix crash in nsvc-state ctrl command + * gbproxy_ctrl: Ignore SIG-BVCI in ctrl commands + * gbproxy: Remove SGSN-side BVC after sending BVC-BLOCK + * gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK + * gbproxy: Fix stats when no BVC could be found + * gbproxy: Use designated initializers for global_ctr_description + * gbproxy: Improve log message when no bvc is found (include bvci) + * gbproxy: Route BSSGP STATUS with PDU_IN_ERROR containing a TLLI + * gpproxy: Route BSSGP STATUS with PDU_IN_ERROR containing a TMSI + * gbproxy: Add comment, improve log message in gbproxy_tlli_from_status_pdu + * gbproxy: Improve STATUS handling from SGSN + * gbproxy: Route DL STATUS with BVCI on SIG-BVC + * gbproxy: Add comment, remove unused param in gbproxy_tlli_from_status_pdu + * gbproxy: Route STATUS in PtP-BVC by TLLI/TMSI as well + * gbproxy: Move BSSGP decoding into its own function and use it + * gbproxy: Increase correct counter when BSSGP decode from SGSN fails + * gbproxy: Only use one struct tlv_parsed for gbproxy_decode_bssgp + * gbproxy: Remove duplicate struct gprs_ra_id handling + + [ Harald Welte ] + * vty: Print CellId along with RA-ID + + [ Oliver Smith ] + * doc: include gb-ns2.adoc, not gb-variants.adoc + * gitignore: add gbproxy_vty_reference.xml + * examples/osmo-gbproxy.cfg: fix osmo-sgsn conflict + * debian/control: remove dh-systemd build-depend + * Revert "Turn some compiler warnings into errors" + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:03:02 +0100 + osmo-gbproxy (1:0.1.0) unstable; urgency=medium [ Philipp Maier ] diff --git a/debian/control b/debian/control index 2bdb50e..c71a321 100644 --- a/debian/control +++ b/debian/control @@ -10,8 +10,8 @@ libtool, pkg-config, libtalloc-dev, - libosmocore-dev (>= 1.5.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmocore-dev (>= 1.6.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-gbproxy.git Vcs-Browser: https://git.osmocom.org/osmo-gbproxy -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I42647a35746c3cbd89e88d9f90f22f1c9275a919 Gerrit-Change-Number: 26289 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:44:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:44:43 +0000 Subject: =?UTF-8?Q?Change_in_osmo-e1d=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E1=2E5-5e0d-dirty_=E2=86=92_0=2E2=2E2?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26291 ) Change subject: Bump version: 0.2.1.5-5e0d-dirty ? 0.2.2 ...................................................................... Bump version: 0.2.1.5-5e0d-dirty ? 0.2.2 Change-Id: I640c4503260e50d412a8c66260c61f9224fef8d2 --- M configure.ac M debian/changelog M debian/control 3 files changed, 18 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 6ecfe09..f5c15f2 100644 --- a/configure.ac +++ b/configure.ac @@ -34,9 +34,9 @@ PKG_CHECK_MODULES(TALLOC, [talloc >= 2.0.1]) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.6.0) PKG_CHECK_MODULES(LIBUSB, libusb-1.0 >= 1.0.21) AC_CONFIG_MACRO_DIR([m4]) diff --git a/debian/changelog b/debian/changelog index 2bd31b3..3e7dbb7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,16 @@ +osmo-e1d (0.2.2) unstable; urgency=medium + + [ Harald Welte ] + * e1d-prbs-test: Initialize libosmocore logging + * ctl: properly set the timeslot mode in E1DP_CMD_TS_QUERY + * make compile-time default logging configuration less verbose + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + * gitignore: Add configure~ + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:10:15 +0100 + osmo-e1d (0.2.1) unstable; urgency=medium * add README.md describing what this repository is about diff --git a/debian/control b/debian/control index 1f35d65..f1e35b7 100644 --- a/debian/control +++ b/debian/control @@ -10,9 +10,9 @@ libtool, pkg-config, python3-minimal, - libosmocore-dev (>= 1.5.0), + libosmocore-dev (>= 1.6.0), libusb-1.0-0-dev, - osmo-gsm-manuals-dev (>= 1.1.0) + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-e1d.git Vcs-Browser: https://git.osmocom.org/osmo-e1d/ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I640c4503260e50d412a8c66260c61f9224fef8d2 Gerrit-Change-Number: 26291 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:45:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 17:45:09 +0000 Subject: Change in pysim[master]: profile: decode_select_response use object instead 'Any' In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26277 ) Change subject: profile: decode_select_response use object instead 'Any' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic5c7ace234bc94ab1381d87e091369ade8011cab Gerrit-Change-Number: 26277 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 17:45:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:45:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:45:16 +0000 Subject: =?UTF-8?Q?Change_in_osmo-smlc=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E2-ec37-dirty_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26292 ) Change subject: Bump version: 0.2.0.2-ec37-dirty ? 0.2.1 ...................................................................... Bump version: 0.2.0.2-ec37-dirty ? 0.2.1 Change-Id: I4a2e2ff8e5f8d08fb4f8bb1f75e92ede9bb5521f --- M configure.ac M contrib/osmo-smlc.spec.in M debian/changelog M debian/control 4 files changed, 26 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index eed5ee9..fbcdab5 100644 --- a/configure.ac +++ b/configure.ac @@ -34,12 +34,12 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.5.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/osmo-smlc.spec.in b/contrib/osmo-smlc.spec.in index ffaef03..4984efc 100644 --- a/contrib/osmo-smlc.spec.in +++ b/contrib/osmo-smlc.spec.in @@ -33,12 +33,12 @@ BuildRequires: systemd-rpm-macros %endif BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sccp) >= 1.4.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sccp) >= 1.5.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 BuildRequires: pkgconfig(talloc) %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 73f17c1..ebe1f22 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +osmo-smlc (0.2.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * Use new stat item/ctr getter APIs + + [ Oliver Smith ] + * configure: don't turn some warnings into errors + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:14:21 +0100 + osmo-smlc (0.2.0) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index c64b941..f599992 100644 --- a/debian/control +++ b/debian/control @@ -12,10 +12,10 @@ pkg-config, libsctp-dev, libtalloc-dev, - libosmocore-dev (>= 1.5.0), - libosmo-sccp-dev (>= 1.4.0), - libosmo-sigtran-dev (>= 1.4.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmocore-dev (>= 1.6.0), + libosmo-sccp-dev (>= 1.5.0), + libosmo-sigtran-dev (>= 1.5.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-smlc.git Vcs-Browser: https://git.osmocom.org/osmo-smlc/ -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I4a2e2ff8e5f8d08fb4f8bb1f75e92ede9bb5521f Gerrit-Change-Number: 26292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:45:29 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 17:45:29 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: dexter has uploaded a new patch set (#8) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... cards: Make select_adf_by_aid() use prefix AID selection There is no need for us to expand a partial AID to the full AID before selecting that ADF. The UICC specifications permit AID selection by prefix only. So we could pass the prefix to the card, and the card would do the prefix matching. In order to avoid problems with cards that fail to do the prefix matching themselves we will still do the AID completion, but in case we cannot complete the AID (AID not listed in EF.DIR), we will try with the AID prefix anyway. >From the API user point of view, this allows us to select applications not listed in EF.DIR Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 --- M pySim/cards.py M pysim-testdata/fakemagicsim.ok M pysim-testdata/sysmosim-gr1.ok 3 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/25873/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:45:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:45:51 +0000 Subject: Change in osmo-iuh[master]: gitignore: Ignore libsmo-{hnbap,rua}.pc In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26286 ) Change subject: gitignore: Ignore libsmo-{hnbap,rua}.pc ...................................................................... gitignore: Ignore libsmo-{hnbap,rua}.pc Change-Id: Ib66ca43017447f23ea041b466a2bf122a0a4946e --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 7041f69..91912b2 100644 --- a/.gitignore +++ b/.gitignore @@ -33,7 +33,9 @@ src/tests/testsuite.log src/osmo-hnbgw tags +libosmo-hnbap.pc libosmo-ranap.pc +libosmo-rua.pc libosmo-sabp.pc m4 gen_hnbap.stamp -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib66ca43017447f23ea041b466a2bf122a0a4946e Gerrit-Change-Number: 26286 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:50:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:50:47 +0000 Subject: =?UTF-8?Q?Change_in_osmo-hnodeb=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E0_=E2=86=92_0=2E0=2E1?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26293 ) Change subject: Bump version: 0.0.0 ? 0.0.1 ...................................................................... Bump version: 0.0.0 ? 0.0.1 Change-Id: I7c561ce54d8c2ff2cad8f66685016ab71991138e --- M configure.ac M contrib/osmo-hnodeb.spec.in M debian/changelog M debian/control 4 files changed, 59 insertions(+), 26 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 5b4ca8b..8453bc4 100644 --- a/configure.ac +++ b/configure.ac @@ -56,16 +56,16 @@ LIBS=$old_LIBS PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) -PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.7.0) -PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.7.0) -PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.7.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) +PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) +PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.8.0) dnl checks for header files diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index 57b3280..063e69a 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -34,16 +34,16 @@ %endif BuildRequires: pkgconfig(libcrypto) >= 0.9.5 BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.4.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.1.0 -BuildRequires: pkgconfig(libosmocore) >= 1.5.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.5.0 -BuildRequires: pkgconfig(libosmogb) >= 1.5.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.5.0 -BuildRequires: pkgconfig(libosmovty) >= 1.5.0 -BuildRequires: pkgconfig(libosmo-hnbap) >= 0.7.0 -BuildRequires: pkgconfig(libosmo-ranap) >= 0.7.0 -BuildRequires: pkgconfig(libosmo-rua) >= 0.7.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(libosmo-hnbap) >= 0.8.0 +BuildRequires: pkgconfig(libosmo-ranap) >= 0.8.0 +BuildRequires: pkgconfig(libosmo-rua) >= 0.8.0 BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(libasn1c) >= 0.9.30 %{?systemd_requires} diff --git a/debian/changelog b/debian/changelog index 8e9a94d..5c0cfd7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,36 @@ +osmo-hnodeb (0.0.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * configure: link against libsctp + * Import hnb-test from osmo-iuh.git + * Move existing vty code to its own vty.c/h file + * main.c: Drop commented out code + * Move rua related code to rua.c/h + * Move hnbap related code to hnbap.c/h + * Allocate g_hnb as a pointer, move code to hnb.c/h + * Move protocol related code in main.c to related proto files + * main.c: Fix cap in naming for vty_info.name + * More work on main.c to add osmocom functionalitites + * Set up Iuh conn params through VTY + * Drop unused fields in struct hnb + * hnb: Move wqueue to .iuh, add wrapper to use it + * Use osmocom logging in non-main files + * use osmo_stream_cli to manage sctp Iuh conn + * Send HnbRegisterRequest when HnodeB connects on Iuh + * Configure PLMN over VTY and use it in HnbRegisterRequest + * Configure CI,LAC,RAC,SAC over VTY and use it in HnbRegisterRequest + * Configure HNB-Identity over VTY and use it in HnbRegisterRequest + * Generate proper rnc_id and plmn in LuRequest + * hnb.c: Fix memleak in hnb_iuh_read_cb + * ranap: Fix compiler warnings passing func callback + + [ Oliver Smith ] + * d/control, spec: add missing builddeps + * rpm spec: fix invalid file paths + * gitignore: add src/osmo-hnodeb/osmo-hnodeb + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:29:42 +0100 + osmo-hnodeb (0.0.0) unstable; urgency=medium * Initial debian package diff --git a/debian/control b/debian/control index fd5f4bb..a306e10 100644 --- a/debian/control +++ b/debian/control @@ -14,14 +14,14 @@ libtalloc-dev, libasn1c-dev (>= 0.9.30), libsctp-dev, - libosmocore-dev (>= 1.5.0), - libosmo-sigtran-dev (>= 1.4.0), - libosmo-abis-dev (>= 1.1.0), + libosmocore-dev (>= 1.6.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.2.0), libosmo-netif-dev (>= 1.1.0), - libosmo-hnbap-dev (>= 0.7.0), - libosmo-ranap-dev (>= 0.7.0), - libosmo-rua-dev (>= 0.7.0), - osmo-gsm-manuals-dev (>= 1.1.0) + libosmo-hnbap-dev (>= 0.8.0), + libosmo-ranap-dev (>= 0.8.0), + libosmo-rua-dev (>= 0.8.0), + osmo-gsm-manuals-dev (>= 1.2.0) Standards-Version: 3.9.8 Vcs-Git: git://git.osmocom.org/osmo-hnodeb.git Vcs-Browser: https://git.osmocom.org/osmo-hnodeb/ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I7c561ce54d8c2ff2cad8f66685016ab71991138e Gerrit-Change-Number: 26293 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:51:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:51:40 +0000 Subject: =?UTF-8?Q?Change_in_openbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E6-68740_=E2=86=92_1=2E4=2E1?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/26294 ) Change subject: Bump version: 1.4.0.6-68740 ? 1.4.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/26294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I83c4ee3981e445ec83e9439adeb8a48355ce8a06 Gerrit-Change-Number: 26294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:51:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:51:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:51:42 +0000 Subject: =?UTF-8?Q?Change_in_openbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E6-68740_=E2=86=92_1=2E4=2E1?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/openbsc/+/26294 ) Change subject: Bump version: 1.4.0.6-68740 ? 1.4.1 ...................................................................... Bump version: 1.4.0.6-68740 ? 1.4.1 Change-Id: I83c4ee3981e445ec83e9439adeb8a48355ce8a06 --- M debian/changelog 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 6d6405b..f78784f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,19 @@ +openbsc (1.4.1) unstable; urgency=medium + + [ Oliver Smith ] + * contrib/jenkins: don't build osmo-gsm-manuals + * debian/control: remove dh-systemd build-depend + + [ Pau Espin Pedrol ] + * tests: Explicitly drop category from log + * gitignore: Ignore configure~ file + * tests: Replace deprecated API log_set_print_filename + + [ Harald Welte ] + * add README.md to indicate what this repo is about + + -- Pau Espin Pedrol Tue, 16 Nov 2021 18:35:09 +0100 + openbsc (1.4.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/26294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I83c4ee3981e445ec83e9439adeb8a48355ce8a06 Gerrit-Change-Number: 26294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:52:27 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 16 Nov 2021 17:52:27 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: dexter has uploaded a new patch set (#9) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... cards: Make select_adf_by_aid() use prefix AID selection There is no need for us to expand a partial AID to the full AID before selecting that ADF. The UICC specifications permit AID selection by prefix only. So we could pass the prefix to the card, and the card would do the prefix matching. In order to avoid problems with cards that fail to do the prefix matching themselves we will still do the AID completion, but in case we cannot complete the AID (AID not listed in EF.DIR), we will try with the AID prefix anyway. >From the API user point of view, this allows us to select applications not listed in EF.DIR Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 --- M pySim/cards.py M pysim-testdata/Fairwaves-SIM.ok M pysim-testdata/Wavemobile-SIM.ok M pysim-testdata/fakemagicsim.ok M pysim-testdata/sysmoUSIM-SJS1.ok M pysim-testdata/sysmosim-gr1.ok 6 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/25873/9 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 9 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 17:57:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 17:57:00 +0000 Subject: =?UTF-8?Q?Change_in_openbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E4=2E0=2E6-68740_=E2=86=92_1=2E4=2E1?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/26294 ) Change subject: Bump version: 1.4.0.6-68740 ? 1.4.1 ...................................................................... Patch Set 1: Oh I just saw you message sorry. Well, at least a final version including the deprecation text :D -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/26294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I83c4ee3981e445ec83e9439adeb8a48355ce8a06 Gerrit-Change-Number: 26294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 17:57:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:02:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:02:46 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: Always enable dynts sdcch8 tests References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26295 ) Change subject: bsc: Always enable dynts sdcch8 tests ...................................................................... bsc: Always enable dynts sdcch8 tests Release 1.8.0 is already released, so latest should support this. Change-Id: Ifbbedde9878274d3008290ec69916e28d7adba3b --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/26295/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 229f8d6..5f1217b 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -705,10 +705,6 @@ }; boolean mp_enable_lcs_tests := true; - /* Whether to enable dyn TS SDCCH8 tests. Can be dropped completely and enable - unconditionally once new version of osmo-bsc is released (current - version: 1.7.0) */ - boolean mp_enable_dyn_sdcch8_test := true; /* Value set in osmo-bsc.cfg "ms max power" */ uint8_t mp_exp_ms_power_level := 7; } @@ -10872,12 +10868,10 @@ execute( TC_dyn_pdch_ipa_act_nack() ); execute( TC_dyn_pdch_osmo_act_deact() ); execute( TC_dyn_pdch_osmo_act_nack() ); - if (mp_enable_dyn_sdcch8_test) { - execute( TC_dyn_ts_sdcch8_act_deact() ); - execute( TC_dyn_ts_sdcch8_all_subslots_used() ); - execute( TC_dyn_ts_sdcch8_tch_call_act_deact() ); - execute( TC_dyn_ts_sdcch8_act_nack() ); - } + execute( TC_dyn_ts_sdcch8_act_deact() ); + execute( TC_dyn_ts_sdcch8_all_subslots_used() ); + execute( TC_dyn_ts_sdcch8_tch_call_act_deact() ); + execute( TC_dyn_ts_sdcch8_act_nack() ); execute( TC_chopped_ipa_ping() ); execute( TC_chopped_ipa_payload() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifbbedde9878274d3008290ec69916e28d7adba3b Gerrit-Change-Number: 26295 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:02:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:02:54 +0000 Subject: Change in docker-playground[master]: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26296 ) Change subject: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest ...................................................................... ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest Release 1.8.0 is already released, so latest should support this. Change-Id: I560cb7d0ab61b5373982160032040a65dc043ce4 --- M ttcn3-bsc-test/BSC_Tests.cfg M ttcn3-bsc-test/jenkins-sccplite.sh M ttcn3-bsc-test/jenkins.sh M ttcn3-bsc-test/sccplite/BSC_Tests.cfg 4 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/26296/1 diff --git a/ttcn3-bsc-test/BSC_Tests.cfg b/ttcn3-bsc-test/BSC_Tests.cfg index 8ec9409..80e06ee 100644 --- a/ttcn3-bsc-test/BSC_Tests.cfg +++ b/ttcn3-bsc-test/BSC_Tests.cfg @@ -12,7 +12,6 @@ [MODULE_PARAMETERS] BSC_Tests.mp_bsc_ip := "172.18.2.20"; BSC_Tests.mp_test_ip := "172.18.2.203"; -BSC_Tests.mp_enable_dyn_sdcch8_test := true; BSC_Tests.mp_bssap_cfg := { { transport := BSSAP_TRANSPORT_AoIP, diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index 7fb0525..bc6eaa0 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -16,11 +16,6 @@ mkdir $VOL_BASE_DIR/bsc-tester cp sccplite/BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ -# Dynamic TS SDCCH8 must be disabled until release AFTER osmo-bsc 1.7.0 is tagged -if image_suffix_is_latest; then - sed "s/BSC_Tests.mp_enable_dyn_sdcch8_test := true;/BSC_Tests.mp_enable_dyn_sdcch8_test := false;/g" -i $VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg -fi - mkdir $VOL_BASE_DIR/bsc cp sccplite/osmo-bsc.cfg $VOL_BASE_DIR/bsc/ diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index dfa1f6f..18236a2 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -14,11 +14,6 @@ mkdir $VOL_BASE_DIR/bsc-tester cp BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ -# Dynamic TS SDCCH8 must be disabled until release AFTER osmo-bsc 1.7.0 is tagged -if image_suffix_is_latest; then - sed "s/BSC_Tests.mp_enable_dyn_sdcch8_test := true;/BSC_Tests.mp_enable_dyn_sdcch8_test := false;/g" -i $VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg -fi - mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-bsc-test/sccplite/BSC_Tests.cfg b/ttcn3-bsc-test/sccplite/BSC_Tests.cfg index d5f8bd7..5103e2e 100644 --- a/ttcn3-bsc-test/sccplite/BSC_Tests.cfg +++ b/ttcn3-bsc-test/sccplite/BSC_Tests.cfg @@ -12,7 +12,6 @@ [MODULE_PARAMETERS] BSC_Tests.mp_bsc_ip := "172.18.12.20"; BSC_Tests.mp_test_ip := "172.18.12.203"; -BSC_Tests.mp_enable_dyn_sdcch8_test := true; BSC_Tests.mp_bssap_cfg := { { transport := BSSAP_TRANSPORT_SCCPlite_SERVER, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I560cb7d0ab61b5373982160032040a65dc043ce4 Gerrit-Change-Number: 26296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:05:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:05:04 +0000 Subject: Change in docker-playground[master]: ttcn3-sgsn: latest osmo-sgsn release supports RIM References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26297 ) Change subject: ttcn3-sgsn: latest osmo-sgsn release supports RIM ...................................................................... ttcn3-sgsn: latest osmo-sgsn release supports RIM osmo-sgsn 1.8.0 supporting the VTY commands was released, so no need to drop those. Change-Id: I803514a28491ebe142691062f6033f179474b064 --- M ttcn3-sgsn-test/jenkins.sh 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/97/26297/1 diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh index 7bb7afd..df500af 100755 --- a/ttcn3-sgsn-test/jenkins.sh +++ b/ttcn3-sgsn-test/jenkins.sh @@ -24,13 +24,6 @@ mkdir $VOL_BASE_DIR/unix -# Disable until osmo-sgsn.git release > 1.7.0 is available -if image_suffix_is_latest; then - sed "/mme test-mme0/d" -i $VOL_BASE_DIR/sgsn/osmo-sgsn.cfg - sed "/gtp remote-ip/d" -i $VOL_BASE_DIR/sgsn/osmo-sgsn.cfg - sed "/gtp ran-info-relay/d" -i $VOL_BASE_DIR/sgsn/osmo-sgsn.cfg -fi - echo Starting container with STP docker run --rm \ $(docker_network_params $SUBNET 200) \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I803514a28491ebe142691062f6033f179474b064 Gerrit-Change-Number: 26297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:06:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:06:36 +0000 Subject: Change in docker-playground[master]: ttcn3-sip: Don't force mncc version 7 for latest References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26298 ) Change subject: ttcn3-sip: Don't force mncc version 7 for latest ...................................................................... ttcn3-sip: Don't force mncc version 7 for latest osmo-sip-connector 1.6.0 supporting latest mncc version was released. Change-Id: Iff2bcbfb3e84140cccdf93b0924ede09e44793b0 --- M ttcn3-sip-test/jenkins.sh 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/98/26298/1 diff --git a/ttcn3-sip-test/jenkins.sh b/ttcn3-sip-test/jenkins.sh index 3e8fb94..ffec3d2 100755 --- a/ttcn3-sip-test/jenkins.sh +++ b/ttcn3-sip-test/jenkins.sh @@ -16,13 +16,6 @@ mkdir $VOL_BASE_DIR/sip-tester/unix cp SIP_Tests.cfg $VOL_BASE_DIR/sip-tester/ -# TODO: remove this block once we release a new version of the SUT -if image_suffix_is_latest; then - # Use MNCCv7 for the '-latest' - sed -i "/MODULE_PARAMETERS/a MNCC_Emulation.mp_mncc_version := 7" \ - "$VOL_BASE_DIR/sip-tester/SIP_Tests.cfg" -fi - mkdir $VOL_BASE_DIR/sip mkdir $VOL_BASE_DIR/sip/unix cp osmo-sip-connector.cfg $VOL_BASE_DIR/sip/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iff2bcbfb3e84140cccdf93b0924ede09e44793b0 Gerrit-Change-Number: 26298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:09:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:09:29 +0000 Subject: Change in docker-playground[master]: ttcn3-pcu: Update config for latest after new osmo-pcu release References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26299 ) Change subject: ttcn3-pcu: Update config for latest after new osmo-pcu release ...................................................................... ttcn3-pcu: Update config for latest after new osmo-pcu release New osmo-pcu 1.0.0 which supports all expected features. Hence we can drop special quirks to have tests passing in latest. Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b --- M ttcn3-pcu-test/PCU_Tests.cfg M ttcn3-pcu-test/jenkins.sh 2 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/99/26299/1 diff --git a/ttcn3-pcu-test/PCU_Tests.cfg b/ttcn3-pcu-test/PCU_Tests.cfg index cb37ee7..40b8e2c 100644 --- a/ttcn3-pcu-test/PCU_Tests.cfg +++ b/ttcn3-pcu-test/PCU_Tests.cfg @@ -14,7 +14,6 @@ [MODULE_PARAMETERS] PCU_Tests.mp_pcu_sock_path := "/data/unix/pcu_bts" PCU_Tests.mp_pcu_statsd_ip := "172.18.13.10" -PCU_Tests.mp_ctrl_neigh_ip := "172.18.13.10"; SGSN_Components.mp_nsconfig := { nsei := 1234, handle_sns := false, @@ -36,8 +35,6 @@ } } Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoPCU"; -PCUIF_Components.mp_send_all_data_ind := true; -PCU_Tests.mp_osmo_pcu_newer_than_0_9_0 := true; [MAIN_CONTROLLER] diff --git a/ttcn3-pcu-test/jenkins.sh b/ttcn3-pcu-test/jenkins.sh index 0bbfb31..f152dbd 100755 --- a/ttcn3-pcu-test/jenkins.sh +++ b/ttcn3-pcu-test/jenkins.sh @@ -16,15 +16,6 @@ mkdir $VOL_BASE_DIR/pcu-tester/unix cp PCU_Tests.cfg $VOL_BASE_DIR/pcu-tester/ -# Disable until osmo-pcu release > 0.9.0 -if image_suffix_is_latest; then - cfg="$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" - sed -i "s/^PCUIF_Components.mp_send_all_data_ind.*/PCUIF_Components.mp_send_all_data_ind := false;/" "$cfg" - sed -i "s/^PCU_Tests.mp_osmo_pcu_newer_than_0_9_0.*/PCU_Tests.mp_osmo_pcu_newer_than_0_9_0 := false;/" "$cfg" -else - sed "/PCU_Tests.mp_ctrl_neigh_ip/d" -i "$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" -fi - mkdir $VOL_BASE_DIR/pcu mkdir $VOL_BASE_DIR/pcu/unix cp osmo-pcu.cfg $VOL_BASE_DIR/pcu/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b Gerrit-Change-Number: 26299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:11:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:11:31 +0000 Subject: Change in docker-playground[master]: ttcn3-stp: osmo-stp in master is >1.4.0 now References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26300 ) Change subject: ttcn3-stp: osmo-stp in master is >1.4.0 now ...................................................................... ttcn3-stp: osmo-stp in master is >1.4.0 now osmo-stp 1.5.0 was released today, so we can drop those specific checks. Change-Id: I354c1487d9a32e2c7d48c57e7b63007f5360677e --- M ttcn3-stp-test/jenkins.sh 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/26300/1 diff --git a/ttcn3-stp-test/jenkins.sh b/ttcn3-stp-test/jenkins.sh index 8cf65ce..db2ffdd 100755 --- a/ttcn3-stp-test/jenkins.sh +++ b/ttcn3-stp-test/jenkins.sh @@ -15,11 +15,6 @@ mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ -# Disable until osmo-stp release > 1.4.0 -if image_suffix_is_latest; then - sed -i "s/^STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0.*/STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0 := false;/" $VOL_BASE_DIR/stp-tester/STP_Tests.cfg -fi - SUBNET=19 network_create $SUBNET -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I354c1487d9a32e2c7d48c57e7b63007f5360677e Gerrit-Change-Number: 26300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:12:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 18:12:13 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26280 ) Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py at 282 PS4, Line 282: def _get_aid(adf="usim"): Missing type definition (not critical): -> str https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py at 291 PS4, Line 291: def _complete_aid(self, aid): Same here: -> str -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Nov 2021 18:12:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:12:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:12:34 +0000 Subject: Change in docker-playground[master]: ttcn3-pcu: Update config for latest after new osmo-pcu release In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/26299 ) Change subject: ttcn3-pcu: Update config for latest after new osmo-pcu release ...................................................................... ttcn3-pcu: Update config for latest after new osmo-pcu release New osmo-pcu 1.0.0 which supports all expected features. Hence we can drop special quirks to have tests passing in latest. Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b --- M ttcn3-pcu-test/PCU_Tests.cfg M ttcn3-pcu-test/jenkins.sh M ttcn3-pcu-test/osmo-pcu.cfg 3 files changed, 0 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/99/26299/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b Gerrit-Change-Number: 26299 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:19:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:19:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_send_all_data_ind References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 ) Change subject: pcu: Drop mp_send_all_data_ind ...................................................................... pcu: Drop mp_send_all_data_ind osmo-pcu 1.0.0 was released, so we can drop references to older osmo-pcu versions. Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20 --- M pcu/PCUIF_Components.ttcn 1 file changed, 4 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/26301/1 diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn index 30982da..7f2d89d 100644 --- a/pcu/PCUIF_Components.ttcn +++ b/pcu/PCUIF_Components.ttcn @@ -51,7 +51,6 @@ */ modulepar { - boolean mp_send_all_data_ind := true; } /* Events are used by the components to indicate that something @@ -419,11 +418,9 @@ //log(prefix, "DATA.ind (len=0)"); } - if (use_msg or mp_send_all_data_ind) { - PCUIF.send(pcu_msg); /* Send to the PCU and notify the TC */ - if (use_msg) { - TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, fn)); - } + PCUIF.send(pcu_msg); /* Send to the PCU and notify the TC */ + if (use_msg) { + TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, fn)); } } } @@ -513,9 +510,7 @@ }); const integer start_fn := 0; - if (mp_send_all_data_ind) { - f_tx_first_data_ind(bts_nr, info_ind, start_fn); - } + f_tx_first_data_ind(bts_nr, info_ind, start_fn); /* Notify the test case that we're done with SI13 */ TC.send(ts_RAW_PCU_EV(BTS_EV_SI13_NEGO)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20 Gerrit-Change-Number: 26301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:19:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:19:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_osmo_pcu_newer_than_0_9_0 References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26302 ) Change subject: pcu: Drop mp_osmo_pcu_newer_than_0_9_0 ...................................................................... pcu: Drop mp_osmo_pcu_newer_than_0_9_0 osmo-pcu 1.0.0 was released, so we can drop references to older osmo-pcu versions. Change-Id: Ife37fc92c5b1ebf7e87b66c136ae900f44861510 --- M pcu/PCU_Tests.ttcn 1 file changed, 142 insertions(+), 183 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/02/26302/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index d7ab69b..7fcab4a 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -71,8 +71,6 @@ charstring mp_ctrl_neigh_ip := ""; /* Use new PCUIF over IPA multiplex for Neigh Addr Resolution */ integer mp_ctrl_neigh_port := 4248; - - boolean mp_osmo_pcu_newer_than_0_9_0 := true; /* Drop after OsmoPCU > 0.9.0 was released */ } @@ -465,14 +463,8 @@ /* Make sure we don't receive data for that TBF since it was released * before. Also check our TBF is not polled for UL. */ f_pcuif_rx_data_req_pdtch(data_msg); - if (mp_osmo_pcu_newer_than_0_9_0 and data_msg.dl_block == omit) { + if (data_msg.dl_block == omit) { /* IDLE block, expected on new PCU versions */ - } else if (not mp_osmo_pcu_newer_than_0_9_0 and match(data_msg.dl_block, tr_RLCMAC_DUMMY_CTRL())) { - /* Dummy RLCMAC block, expected on older PCU versions */ - if (data_msg.dl_block.ctrl.mac_hdr.usf != USF_UNUSED) { - setverdict(fail, "Unexpected USF ", data_msg.dl_block.ctrl.mac_hdr.usf); - f_shutdown(__BFILE__, __LINE__); - } } else { setverdict(fail, "Unexpected dl_block", data_msg.dl_block); f_shutdown(__BFILE__, __LINE__); @@ -620,16 +612,10 @@ [] BTS.receive(tr_PCUIF_DATA_PTCCH(0, tr_PCUIF_DATA(0, 7, sapi := PCU_IF_SAPI_PTCCH), omit)) { - if (not mp_osmo_pcu_newer_than_0_9_0) { - setverdict(fail, "Expected PTCCH/D block instead of IDLE block"); - f_shutdown(__BFILE__, __LINE__); - } } [] as_rx_ptcch(pcu_msg, tr_PTCCHDownlinkMsg) { - if (mp_osmo_pcu_newer_than_0_9_0) { - setverdict(fail, "Expected IDLE block instead of PTCCH/D block"); - f_shutdown(__BFILE__, __LINE__); - } + setverdict(fail, "Expected IDLE block instead of PTCCH/D block"); + f_shutdown(__BFILE__, __LINE__); } [] BTS.receive(PCUIF_Message:?) { repeat; } [] T.timeout { @@ -1535,7 +1521,7 @@ } /* We may already receive empty (idle) blocks before our own TTCN3 timer * triggers due to the TBF being released. Keep going until our T_3169 triggers. */ - [mp_osmo_pcu_newer_than_0_9_0 and n3101 == N3101_MAX + 1] as_pcuif_rx_ignore_empty(nr); + [n3101 == N3101_MAX + 1] as_pcuif_rx_ignore_empty(nr); [] T_3169.timeout { log("T_3169 expired"); /* Done in alt */ @@ -1999,17 +1985,12 @@ } /* We may already receive idle blocks before our own TTCN3 timer * triggers due to the TBF being released. Keep going until our T_3195 triggers. */ - [mp_osmo_pcu_newer_than_0_9_0 and N3105 == N3105_MAX] as_pcuif_rx_ignore_empty(nr); + [N3105 == N3105_MAX] as_pcuif_rx_ignore_empty(nr); [T_3195.running] T_3195.timeout { log("T_3195 timeout"); /* Done in alt, wait for pending RTS initiated previously in - * above case before continuing (expect empty blocks on new - * versions, Dummy block on older versions): */ - if (mp_osmo_pcu_newer_than_0_9_0) { - dl_block_exp := omit; - } else { - dl_block_exp := tr_RLCMAC_DUMMY_CTRL; - } + * above case before continuing (expect empty block): */ + dl_block_exp := omit; BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), dl_block_exp)); @@ -2488,21 +2469,19 @@ f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } testcase TC_mo_ping_pong_with_ul_racap_egprs_only() runs on RAW_PCU_Test_CT { @@ -2510,21 +2489,20 @@ var template (present) CodingScheme exp_dl_cs_mcs := mcs_egprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_default, ms_racap_egprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } testcase TC_force_two_phase_access() runs on RAW_PCU_Test_CT { @@ -2536,21 +2514,19 @@ f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } /* Test scenario where SGSN wants to send some data against MS and it is @@ -3246,21 +3222,19 @@ /* ACK the ACK */ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3598,16 +3572,14 @@ f_pcuif_rx_pch_pag_req1(tr_MI_IMSI(imsi), imsi_suff_tx); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.pcu.sgsn.0.rx_paging_ps", mtype := "c", min := 1, max := 1 }, - /* After the PCU receives the paging request from SGSN, - * and it doesn't have any errors, PCU sends it to the - * BTS to do paging over PCH. */ - { name := "TTCN3.bts.0.pch.requests", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.pcu.sgsn.0.rx_paging_ps", mtype := "c", min := 1, max := 1 }, + /* After the PCU receives the paging request from SGSN, + * and it doesn't have any errors, PCU sends it to the + * BTS to do paging over PCH. */ + { name := "TTCN3.bts.0.pch.requests", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } testcase TC_paging_ps_from_sgsn_sign_ptmsi() runs on RAW_PCU_Test_CT { @@ -3873,20 +3845,18 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3924,20 +3894,18 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3973,20 +3941,18 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -4054,19 +4020,17 @@ f_TC_egprs_pkt_chan_req_reject('111111'B & ext_ra, 1337 + i, rest); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -4099,19 +4063,17 @@ f_TC_egprs_pkt_chan_req_reject(ra11, 1337 + i, rest); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -4155,22 +4117,20 @@ /* At this point, the IUT should run out of free USFs */ f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 8, max := 8 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 8, max := 8 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 8, max := 8 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 7, max := 7 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 7, max := 7 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -6762,9 +6722,8 @@ execute( TC_paging_ps_from_sgsn_sign_ptmsi() ); execute( TC_paging_ps_from_sgsn_sign() ); execute( TC_paging_ps_from_sgsn_ptp() ); - if (mp_osmo_pcu_newer_than_0_9_0) { - execute( TC_paging_pch_timeout() ); - } + execute( TC_paging_pch_timeout() ); + execute( TC_paging_cs_multi_ms_imsi_tmsi() ); execute( TC_paging_cs_multi_ms_imsi() ); execute( TC_paging_cs_multi_ms_tmsi() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife37fc92c5b1ebf7e87b66c136ae900f44861510 Gerrit-Change-Number: 26302 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:23:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:23:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_send_all_data_ind In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 to look at the new patch set (#2). Change subject: pcu: Drop mp_send_all_data_ind ...................................................................... pcu: Drop mp_send_all_data_ind osmo-pcu 1.0.0 was released, so we can drop references to older osmo-pcu versions. Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20 --- M pcu/PCUIF_Components.ttcn 1 file changed, 4 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/26301/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20 Gerrit-Change-Number: 26301 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 18:25:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Nov 2021 18:25:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: stp: Drop mp_osmo_stp_newer_than_1_4_0 References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26303 ) Change subject: stp: Drop mp_osmo_stp_newer_than_1_4_0 ...................................................................... stp: Drop mp_osmo_stp_newer_than_1_4_0 osmo-stp 1.5.0 has been released, so we can drop this. Change-Id: I9a24b44be77d5ab615b833dda418748fb162fc3d --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 8 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/26303/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 1c3b01d..31bab93 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -72,9 +72,6 @@ }; integer mp_recovery_timeout_msec := 2000; charstring mp_sccp_service_type := "mtp3_itu"; - - /* is osmo-stp newer than 1.4.0? */ - boolean mp_osmo_stp_newer_than_1_4_0 := true; } type record M3uaConfig { @@ -1019,18 +1016,8 @@ execute( TC_rkm_reg_static_notpermitted() ); execute( TC_rkm_reg_static_permitted() ); execute( TC_rkm_reg_dynamic_permitted() ); - /* This test has never passed in osmo-stp <= 1.4.0, because it needs - * patch Ie5d84d06e7d5d32c8a22f770f71a5449f4a78484 which was added - * afterwards. Disable the test for <= 1.4.0, because the test does not - * clean up properly and - after other tests were extended - they are - * now failing in this not properly cleaned up state. After some hours - * of figuring out that it is definitively this test and trying to - * figure out what exactly is not cleaning up properly, I decided to - * just temporarily disable the test for -latest instead of spending - * even more time on it. */ - if (mp_osmo_stp_newer_than_1_4_0) { - execute( TC_rkm_unreg_never_registered() ); - } + execute( TC_rkm_unreg_never_registered() ); + execute( TC_rkm_unreg_invalid() ); execute( TC_rkm_unreg_registered() ); execute( TC_rkm_unreg_active() ); @@ -1044,14 +1031,12 @@ execute( TC_clnt_sg_to_asp() ); execute( TC_clnt_asp_to_sg() ); - /* remove the condition if osmo-stp > 1.4.0 is released */ - if (mp_osmo_stp_newer_than_1_4_0) { - execute( TC_clnt_quirk_no_notify_asp_act() ); - execute( TC_clnt_no_daud_in_asp() ); - execute( TC_clnt_quirk_daud_in_asp() ); - execute( TC_clnt_no_snm_inactive() ); - execute( TC_clnt_quirk_snm_inactive() ); - } + execute( TC_clnt_quirk_no_notify_asp_act() ); + execute( TC_clnt_no_daud_in_asp() ); + execute( TC_clnt_quirk_daud_in_asp() ); + execute( TC_clnt_no_snm_inactive() ); + execute( TC_clnt_quirk_snm_inactive() ); + /* M3UA SSNM tests */ execute( TC_ssnm_aspac_dava_aspia_duna() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a24b44be77d5ab615b833dda418748fb162fc3d Gerrit-Change-Number: 26303 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 19:47:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 19:47:47 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 9: (1 comment) https://gerrit.osmocom.org/c/pysim/+/25873/9/pysim-testdata/fakemagicsim.ok File pysim-testdata/fakemagicsim.ok: https://gerrit.osmocom.org/c/pysim/+/25873/9/pysim-testdata/fakemagicsim.ok at 58 PS9, Line 58: ADF.USIM: Can't select application -- SW match failed! Expected 9000 and got 6b00. Hmm, do we really want to have these warning/error messages printed for cards containing on USIM and/or ISUM apps? They might confuse the user. I mean, there is nothing wrong if let's say a SIM card is a pure SIM and has neither USIM nor ISIM apps. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 9 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Nov 2021 19:47:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 23:13:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 23:13:13 +0000 Subject: Change in libosmocore[master]: .gitignore: add utils/osmo-aka-verify binary References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26304 ) Change subject: .gitignore: add utils/osmo-aka-verify binary ...................................................................... .gitignore: add utils/osmo-aka-verify binary Change-Id: Ic7c69ee69f83a25d1ecec38dce7ea5f426e99a2d --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/26304/1 diff --git a/.gitignore b/.gitignore index f5e794a..269ce8a 100644 --- a/.gitignore +++ b/.gitignore @@ -70,6 +70,7 @@ utils/osmo-auc-gen utils/osmo-config-merge utils/osmo-sim-test +utils/osmo-aka-verify doc/codec doc/coding -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic7c69ee69f83a25d1ecec38dce7ea5f426e99a2d Gerrit-Change-Number: 26304 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 23:13:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 23:13:13 +0000 Subject: Change in libosmocore[master]: tests/tdef: rename the binaries to end with '_test' References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26305 ) Change subject: tests/tdef: rename the binaries to end with '_test' ...................................................................... tests/tdef: rename the binaries to end with '_test' It's the usual naming for unit test binaries. Without the '_test' endig, the tdef_vty_test_{config_root,config_subnode,dynamic} binaries do not match the 'tests/*/*_test' pattern and appear as untracked files in git. Change-Id: I828fa45132e11a41c527d4b25df850c19871cb75 --- M src/tdef.c M src/vty/tdef_vty.c M tests/Makefile.am R tests/tdef/tdef_vty_config_root_test.c R tests/tdef/tdef_vty_config_root_test.vty R tests/tdef/tdef_vty_config_subnode_test.c R tests/tdef/tdef_vty_config_subnode_test.vty R tests/tdef/tdef_vty_dynamic_test.c R tests/tdef/tdef_vty_dynamic_test.vty 9 files changed, 25 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/05/26305/1 diff --git a/src/tdef.c b/src/tdef.c index 9890f95..75b884a 100644 --- a/src/tdef.c +++ b/src/tdef.c @@ -52,18 +52,18 @@ * By keeping separate osmo_tdef arrays, several groups of timers can be kept * separately. The VTY tests in tests/tdef/ showcase different schemes: * - * - \ref tests/vty/tdef_vty_test_config_root.c: + * - \ref tests/vty/tdef_vty_config_root_test.c: * Keep several timer definitions in separately named groups: showcase the * osmo_tdef_vty_groups*() API. Each timer group exists exactly once. * - * - \ref tests/vty/tdef_vty_test_config_subnode.c: + * - \ref tests/vty/tdef_vty_config_subnode_test.c: * Keep a single list of timers without separate grouping. * Put this list on a specific subnode below the CONFIG_NODE. * There could be several separate subnodes with timers like this, i.e. * continuing from this example, sets of timers could be separated by placing * timers in specific config subnodes instead of using the global group name. * - * - \ref tests/vty/tdef_vty_test_dynamic.c: + * - \ref tests/vty/tdef_vty_dynamic_test.c: * Dynamically allocate timer definitions per each new created object. * Thus there can be an arbitrary number of independent timer definitions, one * per allocated object. diff --git a/src/vty/tdef_vty.c b/src/vty/tdef_vty.c index 09459f1..bd209ae 100644 --- a/src/vty/tdef_vty.c +++ b/src/vty/tdef_vty.c @@ -242,7 +242,7 @@ /*! Write current timer configuration arguments to the vty. Skip all entries that reflect their default value. * The passed prefix string must contain both necessary indent and the VTY command the specific implementation is using. - * See tdef_vty_test_config_subnode.c and tdef_vty_test_dynamic.c for examples. + * See tdef_vty_config_subnode_test.c and tdef_vty_dynamic_test.c for examples. * \param[in] vty VTY context. * \param[in] tdefs Array of timers to print, ended with a fully zero-initialized entry. * \param[in] prefix_fmt Arbitrary string to start each line with, with variable printf like arguments. diff --git a/tests/Makefile.am b/tests/Makefile.am index c44b6f0..a6f6017 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -28,9 +28,9 @@ oap/oap_client_test gsm29205/gsm29205_test \ logging/logging_vty_test \ vty/vty_transcript_test \ - tdef/tdef_test tdef/tdef_vty_test_config_root \ - tdef/tdef_vty_test_config_subnode \ - tdef/tdef_vty_test_dynamic \ + tdef/tdef_test tdef/tdef_vty_config_root_test \ + tdef/tdef_vty_config_subnode_test \ + tdef/tdef_vty_dynamic_test \ sockaddr_str/sockaddr_str_test \ use_count/use_count_test \ context/context_test \ @@ -286,14 +286,14 @@ tdef_tdef_test_SOURCES = tdef/tdef_test.c tdef_tdef_test_LDADD = $(LDADD) -tdef_tdef_vty_test_config_root_SOURCES = tdef/tdef_vty_test_config_root.c -tdef_tdef_vty_test_config_root_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la +tdef_tdef_vty_config_root_test_SOURCES = tdef/tdef_vty_config_root_test.c +tdef_tdef_vty_config_root_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la -tdef_tdef_vty_test_config_subnode_SOURCES = tdef/tdef_vty_test_config_subnode.c -tdef_tdef_vty_test_config_subnode_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la +tdef_tdef_vty_config_subnode_test_SOURCES = tdef/tdef_vty_config_subnode_test.c +tdef_tdef_vty_config_subnode_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la -tdef_tdef_vty_test_dynamic_SOURCES = tdef/tdef_vty_test_dynamic.c -tdef_tdef_vty_test_dynamic_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la +tdef_tdef_vty_dynamic_test_SOURCES = tdef/tdef_vty_dynamic_test.c +tdef_tdef_vty_dynamic_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la sockaddr_str_sockaddr_str_test_SOURCES = sockaddr_str/sockaddr_str_test.c sockaddr_str_sockaddr_str_test_LDADD = $(LDADD) @@ -402,9 +402,9 @@ vty/vty_transcript_test.vty \ tdef/tdef_test.ok \ tdef/tdef_test_range_64bit.ok \ - tdef/tdef_vty_test_config_root.vty \ - tdef/tdef_vty_test_config_subnode.vty \ - tdef/tdef_vty_test_dynamic.vty \ + tdef/tdef_vty_config_root_test.vty \ + tdef/tdef_vty_config_subnode_test.vty \ + tdef/tdef_vty_dynamic_test.vty \ sockaddr_str/sockaddr_str_test.ok \ use_count/use_count_test.ok use_count/use_count_test.err \ context/context_test.ok \ @@ -678,16 +678,16 @@ vty-test-tdef: osmo_verify_transcript_vty.py -v \ -p 42042 \ - -r "$(top_builddir)/tests/tdef/tdef_vty_test_config_root" \ - $(U) $(srcdir)/tdef/tdef_vty_test_config_root.vty + -r "$(top_builddir)/tests/tdef/tdef_vty_config_root_test" \ + $(U) $(srcdir)/tdef/tdef_vty_config_root_test.vty osmo_verify_transcript_vty.py -v \ -p 42042 \ - -r "$(top_builddir)/tests/tdef/tdef_vty_test_config_subnode" \ - $(U) $(srcdir)/tdef/tdef_vty_test_config_subnode.vty + -r "$(top_builddir)/tests/tdef/tdef_vty_config_subnode_test" \ + $(U) $(srcdir)/tdef/tdef_vty_config_subnode_test.vty osmo_verify_transcript_vty.py -v \ -p 42042 \ - -r "$(top_builddir)/tests/tdef/tdef_vty_test_dynamic" \ - $(U) $(srcdir)/tdef/tdef_vty_test_dynamic.vty + -r "$(top_builddir)/tests/tdef/tdef_vty_dynamic_test" \ + $(U) $(srcdir)/tdef/tdef_vty_dynamic_test.vty vty-test-stats: osmo_verify_transcript_vty.py -v \ diff --git a/tests/tdef/tdef_vty_test_config_root.c b/tests/tdef/tdef_vty_config_root_test.c similarity index 97% rename from tests/tdef/tdef_vty_test_config_root.c rename to tests/tdef/tdef_vty_config_root_test.c index 92113e8..0472ad5 100644 --- a/tests/tdef/tdef_vty_test_config_root.c +++ b/tests/tdef/tdef_vty_config_root_test.c @@ -45,7 +45,7 @@ /* ------------------- HERE IS THE INTERESTING TDEF RELEVANT PART ------------------- */ /* This example keeps several separate timer groups and offers 'timer' VTY commands at the root of the config node. See - * the tdef_vty_test_config_root.vty transcript test. + * the tdef_vty_config_root_test.vty transcript test. */ static struct osmo_tdef tdefs_test[] = { @@ -102,7 +102,7 @@ /* This example puts 'timer' configuration commands directly at the root of the CONFIG_NODE. * This TIMER_NODE is merely needed as a hook for the vty_write() command, but becomes an empty node in the VTY docs. * It is possible to cheat around needing this if you choose to config_write_timer() in another root nodes' write cb. - * Another example using a 'network' subnode is \ref tdef_vty_test_config_subnode.c */ + * Another example using a 'network' subnode is \ref tdef_vty_config_subnode_test.c */ static struct cmd_node timer_node = { TIMER_NODE, "%s(config-timer)# ", diff --git a/tests/tdef/tdef_vty_test_config_root.vty b/tests/tdef/tdef_vty_config_root_test.vty similarity index 100% rename from tests/tdef/tdef_vty_test_config_root.vty rename to tests/tdef/tdef_vty_config_root_test.vty diff --git a/tests/tdef/tdef_vty_test_config_subnode.c b/tests/tdef/tdef_vty_config_subnode_test.c similarity index 98% rename from tests/tdef/tdef_vty_test_config_subnode.c rename to tests/tdef/tdef_vty_config_subnode_test.c index ce851f5..ff19150 100644 --- a/tests/tdef/tdef_vty_test_config_subnode.c +++ b/tests/tdef/tdef_vty_config_subnode_test.c @@ -46,7 +46,7 @@ /* This example keeps a single global timer group and offers a custom 'timer' VTY command in a 'network' subnode below * the CONFIG_NODE. - * the tdef_vty_test_config_subnode.vty transcript test. + * the tdef_vty_config_subnode_test.vty transcript test. */ static struct osmo_tdef global_tdefs[] = { diff --git a/tests/tdef/tdef_vty_test_config_subnode.vty b/tests/tdef/tdef_vty_config_subnode_test.vty similarity index 100% rename from tests/tdef/tdef_vty_test_config_subnode.vty rename to tests/tdef/tdef_vty_config_subnode_test.vty diff --git a/tests/tdef/tdef_vty_test_dynamic.c b/tests/tdef/tdef_vty_dynamic_test.c similarity index 100% rename from tests/tdef/tdef_vty_test_dynamic.c rename to tests/tdef/tdef_vty_dynamic_test.c diff --git a/tests/tdef/tdef_vty_test_dynamic.vty b/tests/tdef/tdef_vty_dynamic_test.vty similarity index 100% rename from tests/tdef/tdef_vty_test_dynamic.vty rename to tests/tdef/tdef_vty_dynamic_test.vty -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I828fa45132e11a41c527d4b25df850c19871cb75 Gerrit-Change-Number: 26305 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 16 23:13:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Nov 2021 23:13:14 +0000 Subject: Change in libosmocore[master]: tdef: fix wrong path in documentation: tests/vty -> tests/tdef References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26306 ) Change subject: tdef: fix wrong path in documentation: tests/vty -> tests/tdef ...................................................................... tdef: fix wrong path in documentation: tests/vty -> tests/tdef Change-Id: I2ba9a7a0ba9ad440c879d6a1da110d2fda49eb23 --- M src/tdef.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/26306/1 diff --git a/src/tdef.c b/src/tdef.c index 75b884a..7741a44 100644 --- a/src/tdef.c +++ b/src/tdef.c @@ -52,18 +52,18 @@ * By keeping separate osmo_tdef arrays, several groups of timers can be kept * separately. The VTY tests in tests/tdef/ showcase different schemes: * - * - \ref tests/vty/tdef_vty_config_root_test.c: + * - \ref tests/tdef/tdef_vty_config_root_test.c: * Keep several timer definitions in separately named groups: showcase the * osmo_tdef_vty_groups*() API. Each timer group exists exactly once. * - * - \ref tests/vty/tdef_vty_config_subnode_test.c: + * - \ref tests/tdef/tdef_vty_config_subnode_test.c: * Keep a single list of timers without separate grouping. * Put this list on a specific subnode below the CONFIG_NODE. * There could be several separate subnodes with timers like this, i.e. * continuing from this example, sets of timers could be separated by placing * timers in specific config subnodes instead of using the global group name. * - * - \ref tests/vty/tdef_vty_dynamic_test.c: + * - \ref tests/tdef/tdef_vty_dynamic_test.c: * Dynamically allocate timer definitions per each new created object. * Thus there can be an arbitrary number of independent timer definitions, one * per allocated object. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ba9a7a0ba9ad440c879d6a1da110d2fda49eb23 Gerrit-Change-Number: 26306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Nov 17 00:29:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:29:21 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944ced72c01_5b8b2ac6bd19e61030662f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/CentOS_8/aarch64 Package network:osmocom:nightly/osmocom-nightly failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 22s] ### VM INTERACTION START ### [ 22s] Using UART console [ 22s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 34s] ### VM INTERACTION END ### [ 34s] 2nd stage started in virtual machine [ 34s] machine type: aarch64 [ 34s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 34s] Increasing log level from now on... [ 34s] [ 10.743870] sysrq: Changing Loglevel [ 34s] [ 10.745345] sysrq: Loglevel set to 4 [ 34s] Enable sysrq operations [ 34s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 34s] no label, UUID=312f8a09-1570-402c-a104-cddb6dbfa8d2 [ 34s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 34s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 34s] swapon /dev/vda [ 34s] WARNING: udev not running, creating extra device nodes [ 34s] logging output to //.build.log... [ 34s] processing recipe /.build-srcdir/osmocom-nightly.spec ... [ 34s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmocom-nightly.spec build ... [ 34s] initializing rpm db... [ 34s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 34s] ### VM INTERACTION START ### [ 37s] [ 14.220475] sysrq: Power Off [ 37s] [ 14.221864] reboot: Power down [ 38s] ### VM INTERACTION END ### [ 38s] [ 38s] obs-arm-9 failed "build osmocom-nightly.spec" at Wed Nov 17 00:29:07 UTC 2021. [ 38s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:29:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:29:38 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d0c33682_5b8b2ac6bd19e610306752@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/CentOS_8/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 10s] Using UART console [ 10s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 10s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] [ 4.877297] sysrq: Changing Loglevel [ 15s] Linux version: 5[ 4.877872] sysrq: Loglevel set to 4 [ 15s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 15s] Increasing log level from now on... [ 15s] Enable sysrq operations [ 15s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 15s] no label, UUID=7ec80e68-7573-4ec8-8b43-92257c92986c [ 15s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 15s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 15s] swapon /dev/vdb [ 15s] WARNING: udev not running, creating extra device nodes [ 15s] logging output to //.build.log... [ 15s] processing recipe /.build-srcdir/libgtpnl.spec ... [ 15s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libgtpnl.spec build ... [ 15s] initializing rpm db... [ 15s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 15s] ### VM INTERACTION START ### [ 18s] [ 8.040904] sysrq: Power Off [ 18s] [ 8.045479] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] sheep86 failed "build libgtpnl.spec" at Wed Nov 17 00:29:24 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:29:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:29:38 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d0cabc81_5b8b2ac6bd19e6103069e1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/CentOS_8/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 17s] Using UART console [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 17s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 23s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 23s] 2nd stage started in virtual machine [ 23s] machine type: x86_64 [ 23s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 23s] Increasing log level from now on... [ 23s] [ 5.950862] sysrq: Changing Loglevel [ 23s] [ 5.952150] sysrq: Loglevel set to 4 [ 23s] Enable sysrq operations [ 23s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 23s] no label, UUID=1176e60e-714d-430a-9e48-4d62bc0c21f5 [ 23s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 23s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 23s] swapon /dev/vdb [ 23s] WARNING: udev not running, creating extra device nodes [ 24s] logging output to //.build.log... [ 24s] processing recipe /.build-srcdir/osmocom-nightly.spec ... [ 24s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmocom-nightly.spec build ... [ 24s] initializing rpm db... [ 24s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 24s] ### VM INTERACTION START ### [ 27s] [ 9.186126] sysrq: Power Off [ 27s] [ 9.201907] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] cloud115 failed "build osmocom-nightly.spec" at Wed Nov 17 00:29:32 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:29:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:29:38 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d0cd9d48_5b8b2ac6bd19e610307066@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/CentOS_8/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 15s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 15s] Booting from ROM... [ 21s] c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 5[ 5.419886] sysrq: Changing Loglevel [ 21s] [ 5.421943] sysrq: Loglevel set to 4 [ 21s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 21s] Increasing log level from now on... [ 21s] Enable sysrq operations [ 21s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 21s] no label, UUID=2b037f66-7578-46e8-a92c-f45ccd9f1d1b [ 21s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 21s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 21s] swapon /dev/vdb [ 21s] WARNING: udev not running, creating extra device nodes [ 21s] logging output to //.build.log... [ 21s] processing recipe /.build-srcdir/libsmpp34.spec ... [ 21s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsmpp34.spec build ... [ 21s] initializing rpm db... [ 21s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.622124] sysrq: Power Off [ 24s] [ 8.625038] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] cloud124 failed "build libsmpp34.spec" at Wed Nov 17 00:29:32 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:29:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:29:38 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d0c8086a_5b8b2ac6bd19e61030682d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/CentOS_8/x86_64 Package network:osmocom:nightly/libosmocore failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 16s] Using UART console [ 16s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 16s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 22s] Increasing log level from now on... [ 22s] [ 5.704085] sysrq: Changing Loglevel [ 22s] [ 5.705734] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 22s] no label, UUID=68690879-335a-45a5-b139-0fce352d11cf [ 22s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 22s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 22s] swapon /dev/vdb [ 22s] WARNING: udev not running, creating extra device nodes [ 22s] logging output to //.build.log... [ 22s] processing recipe /.build-srcdir/libosmocore.spec ... [ 22s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmocore.spec build ... [ 22s] initializing rpm db... [ 22s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.938179] sysrq: Power Off [ 25s] [ 8.941274] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] cloud111 failed "build libosmocore.spec" at Wed Nov 17 00:29:31 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:29:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:29:55 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944d0d5af29_5b8b2ac6bd19e610307194@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/CentOS_8/aarch64 Package network:osmocom:nightly/libsmpp34 failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 31s] ### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 32s] machine type: aarch64 [ 32s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 32s] Increasing log level from now on... [ 32s] [ 10.553414] sysrq: Changing Loglevel [ 32s] [ 10.554259] sysrq: Loglevel set to 4 [ 32s] Enable sysrq operations [ 32s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 32s] no label, UUID=76a16436-57d8-4a09-99c1-11142f4c1712 [ 32s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 32s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 32s] swapon /dev/vda [ 32s] WARNING: udev not running, creating extra device nodes [ 32s] logging output to //.build.log... [ 32s] processing recipe /.build-srcdir/libsmpp34.spec ... [ 32s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libsmpp34.spec build ... [ 32s] initializing rpm db... [ 32s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 32s] ### VM INTERACTION START ### [ 35s] [ 13.927175] sysrq: Power Off [ 35s] [ 13.928351] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] obs-arm-8 failed "build libsmpp34.spec" at Wed Nov 17 00:29:44 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:29:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:29:55 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944d0de86b5_5b8b2ac6bd19e6103073ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/CentOS_8/aarch64 Package network:osmocom:nightly/libgtpnl failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_35/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_35/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_35/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 31s] ### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] machine type: aarch64 [ 31s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 31s] Increasing log level from now on... [ 31s] [ 10.711205] sysrq: Changing Loglevel [ 31s] [ 10.714929] sysrq: Loglevel set to 4 [ 31s] Enable sysrq operations [ 31s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 31s] no label, UUID=7dfedca6-a180-4fd7-a209-8069ff528c2f [ 31s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 31s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 31s] swapon /dev/vda [ 32s] WARNING: udev not running, creating extra device nodes [ 32s] logging output to //.build.log... [ 32s] processing recipe /.build-srcdir/libgtpnl.spec ... [ 32s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libgtpnl.spec build ... [ 32s] initializing rpm db... [ 32s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 32s] ### VM INTERACTION START ### [ 35s] [ 14.164424] sysrq: Power Off [ 35s] [ 14.165654] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] obs-arm-8 failed "build libgtpnl.spec" at Wed Nov 17 00:29:52 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:20 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d658c0c_5b8b2ac6bd19e61030754c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/CentOS_8/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 8s] Using UART console [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 8s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 5[ 4.427485] sysrq: Changing Loglevel [ 13s] .3.18-59.27-defa[ 4.428701] sysrq: Loglevel set to 4 [ 13s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 13s] Increasing log level from now on... [ 13s] Enable sysrq operations [ 13s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 13s] no label, UUID=6bf77743-70d3-4bf9-b1a4-310e0ef67a7d [ 13s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 13s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 13s] swapon /dev/vdb [ 13s] WARNING: udev not running, creating extra device nodes [ 13s] logging output to //.build.log... [ 13s] processing recipe /.build-srcdir/simtrace2.spec ... [ 13s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/simtrace2.spec build ... [ 13s] initializing rpm db... [ 13s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.552630] sysrq: Power Off [ 16s] [ 7.555663] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] goat13 failed "build simtrace2.spec" at Wed Nov 17 00:31:17 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:37 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d835113f_5b8b2ac6bd19e610307654@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/CentOS_8/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5.3.18-59.27-defa[ 4.711077] sysrq: Changing Loglevel [ 17s] ult #1 SMP Tue O[ 4.712488] sysrq: Loglevel set to 4 [ 17s] ct 5 10:00:40 UTC 2021 (7df2404) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 17s] no label, UUID=0b78e6c1-2129-48b0-89ae-49c47cf51438 [ 17s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 17s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 17s] swapon /dev/vdb [ 17s] WARNING: udev not running, creating extra device nodes [ 17s] logging output to //.build.log... [ 17s] processing recipe /.build-srcdir/libosmo-netif.spec ... [ 17s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-netif.spec build ... [ 17s] initializing rpm db... [ 17s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 17s] ### VM INTERACTION START ### [ 20s] [ 7.857244] sysrq: Power Off [ 20s] [ 7.858642] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] build85 failed "build libosmo-netif.spec" at Wed Nov 17 00:31:21 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d83804d5_5b8b2ac6bd19e6103077b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 11s] Using UART console [ 11s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5.3.18-59.27-defa[ 4.937634] sysrq: Changing Loglevel [ 17s] ult #1 SMP Tue O[ 4.939012] sysrq: Loglevel set to 4 [ 17s] ct 5 10:00:40 UTC 2021 (7df2404) [ 17s] Increasing log level from now on... [ 17s] Enable sysrq operations [ 17s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 17s] no label, UUID=be2f90fe-5b06-4b7d-8049-5fd450220a0b [ 17s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 17s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 17s] swapon /dev/vdb [ 17s] WARNING: udev not running, creating extra device nodes [ 17s] logging output to //.build.log... [ 17s] processing recipe /.build-srcdir/osmo-sip-connector.spec ... [ 17s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sip-connector.spec build ... [ 17s] initializing rpm db... [ 17s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.130762] sysrq: Power Off [ 20s] [ 8.135212] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] sheep85 failed "build osmo-sip-connector.spec" at Wed Nov 17 00:31:24 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d83b363e_5b8b2ac6bd19e6103078fb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.27-defa[ 4.965052] sysrq: Changing Loglevel [ 19s] ult #1 SMP Tue O[ 4.966813] sysrq: Loglevel set to 4 [ 19s] ct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=3216e6c1-d929-4df0-917b-560ec6809d65 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-hlr.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hlr.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.184941] sysrq: Power Off [ 22s] [ 8.191045] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] old-cirrus1 failed "build osmo-hlr.spec" at Wed Nov 17 00:31:27 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d83dd508_5b8b2ac6bd19e6103079fb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UT[ 5.259395] sysrq: Changing Loglevel [ 20s] C 2021 (7df2404)[ 5.262244] sysrq: Loglevel set to 4 [ 20s] [ 20s] Increasing log level from now on... [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 20s] no label, UUID=d911e928-6a8f-4b71-aad4-0c50d5bc9892 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/osmo-ggsn.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-ggsn.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.472014] sysrq: Power Off [ 23s] [ 8.476829] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] old-cirrus4 failed "build osmo-ggsn.spec" at Wed Nov 17 00:31:29 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:37 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d84138ad_5b8b2ac6bd19e6103080c4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/CentOS_8/x86_64 Package network:osmocom:nightly/libasn1c failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.708864] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.709939] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=681bcf0f-1919-4eb9-978c-4a5b641803db [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libasn1c.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libasn1c.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.908365] sysrq: Power Off [ 22s] [ 8.914143] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb26 failed "build libasn1c.spec" at Wed Nov 17 00:31:31 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:54 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944d84594ea_5b8b2ac6bd19e61030816d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/CentOS_8/aarch64 Package network:osmocom:nightly/libosmocore failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_25/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_25/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_25/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.617633] sysrq: Changing Loglevel [ 18s] [ 7.618434] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=c21ed6f5-555d-401b-8445-e2446aa2b700 [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/libosmocore.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmocore.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 10.811417] sysrq: Power Off [ 21s] [ 10.812005] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-10 failed "build libosmocore.spec" at Wed Nov 17 00:31:45 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:31:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:31:54 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d84db23a_5b8b2ac6bd19e61030839b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 17s] Increasing log level from now on... [ 17s] [ 4.824260] sysrq: Changing Loglevel [ 17s] [ 4.825130] sysrq: Loglevel set to 4 [ 17s] Enable sysrq operations [ 17s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 17s] no label, UUID=2be82e6f-bd59-4936-b095-556d26d140c1 [ 17s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 17s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 17s] swapon /dev/vdb [ 17s] WARNING: udev not running, creating extra device nodes [ 17s] logging output to //.build.log... [ 17s] processing recipe /.build-srcdir/osmo-cbc.spec ... [ 17s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-cbc.spec build ... [ 17s] initializing rpm db... [ 17s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 17s] ### VM INTERACTION START ### [ 20s] [ 7.975173] sysrq: Power Off [ 20s] [ 7.977086] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] build85 failed "build osmo-cbc.spec" at Wed Nov 17 00:31:50 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:32:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:32:11 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d9e623fa_5b8b2ac6bd19e610308472@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/CentOS_8/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] [ 5.335095] sysrq: Changing Loglevel [ 19s] Linux version: 5[ 5.336549] sysrq: Loglevel set to 4 [ 19s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=e4ae3086-43e2-45e9-81a9-03a9ad43c212 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-sccp.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-sccp.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.550103] sysrq: Power Off [ 22s] [ 8.557267] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb11 failed "build libosmo-sccp.spec" at Wed Nov 17 00:31:56 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:32:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:32:28 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944d9ed2353_5b8b2ac6bd19e61030855f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 14s] Using UART console [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 22s] Increasing log level from now on... [ 22s] [ 6.989948] sysrq: Changing Loglevel [ 22s] [ 6.990672] sysrq: Loglevel set to 4 [ 22s] Enable sysrq operations [ 22s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 22s] no label, UUID=486b178d-59b3-4bcd-9bf6-e5ae48bd4132 [ 22s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 22s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 22s] swapon /dev/vdb [ 22s] WARNING: udev not running, creating extra device nodes [ 22s] logging output to //.build.log... [ 22s] processing recipe /.build-srcdir/osmo-remsim.spec ... [ 22s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-remsim.spec build ... [ 22s] initializing rpm db... [ 22s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 22s] ### VM INTERACTION START ### [ 25s] [ 10.270626] sysrq: Power Off [ 25s] [ 10.279862] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb10 failed "build osmo-remsim.spec" at Wed Nov 17 00:32:16 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:32:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:32:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61944dbd5ffca_5b8b2ac6bd19e6103087c4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 5.433077] sysrq: Changing Loglevel [ 18s] .3.18-59.27-defa[ 5.434089] sysrq: Loglevel set to 4 [ 18s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 18s] no label, UUID=32c9d042-c081-4141-bf77-249968b74817 [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/osmo-iuh.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-iuh.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.653922] sysrq: Power Off [ 22s] [ 8.662050] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb09 failed "build osmo-iuh.spec" at Wed Nov 17 00:32:32 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:33:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:33:02 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944ddbd0301_5b8b2ac6bd19e610308835@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hlr failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 20s] ### VM INTERACTION START ### [ 20s] Using UART console [ 20s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_37/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_37/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_37/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 33s] ### VM INTERACTION END ### [ 33s] 2nd stage started in virtual machine [ 33s] machine type: aarch64 [ 33s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 33s] Increasing log level from now on... [ 33s] [ 11.187264] sysrq: Changing Loglevel [ 33s] [ 11.188568] sysrq: Loglevel set to 4 [ 33s] Enable sysrq operations [ 33s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 33s] no label, UUID=2a22c023-8b33-44c2-bd14-0c0e9e94e8a5 [ 33s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 33s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 33s] swapon /dev/vda [ 33s] WARNING: udev not running, creating extra device nodes [ 33s] logging output to //.build.log... [ 33s] processing recipe /.build-srcdir/osmo-hlr.spec ... [ 33s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hlr.spec build ... [ 33s] initializing rpm db... [ 33s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 33s] ### VM INTERACTION START ### [ 36s] [ 14.570776] sysrq: Power Off [ 36s] [ 14.572045] reboot: Power down [ 36s] ### VM INTERACTION END ### [ 36s] [ 36s] obs-arm-8 failed "build osmo-hlr.spec" at Wed Nov 17 00:32:46 UTC 2021. [ 36s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:33:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:33:19 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944ddc667fd_5b8b2ac6bd19e610308972@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/CentOS_8/aarch64 Package network:osmocom:nightly/libasn1c failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 46s] ### VM INTERACTION START ### [ 46s] Using UART console [ 46s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 10240 -drive file=/var/cache/obs/worker/root_14/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_14/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_14/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 60s] ### VM INTERACTION END ### [ 60s] 2nd stage started in virtual machine [ 60s] machine type: aarch64 [ 60s] Linux version: 5.3.18-59.16-default #1 SMP Thu Jul 15 11:28:57 UTC 2021 (0b62bdb) [ 60s] Increasing log level from now on... [ 60s] [ 13.097682] sysrq: Changing Loglevel [ 60s] [ 13.102382] sysrq: Loglevel set to 4 [ 60s] Enable sysrq operations [ 60s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 60s] no label, UUID=2bed8d12-f6ba-4d24-9ce4-8d0f3a17238b [ 60s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 60s] swapon: /dev/vda: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 60s] swapon /dev/vda [ 60s] WARNING: udev not running, creating extra device nodes [ 60s] logging output to //.build.log... [ 60s] processing recipe /.build-srcdir/libasn1c.spec ... [ 60s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libasn1c.spec build ... [ 60s] initializing rpm db... [ 60s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 60s] ### VM INTERACTION START ### [ 63s] [ 16.708042] sysrq: Power Off [ 63s] [ 16.714728] reboot: Power down [ 63s] ### VM INTERACTION END ### [ 64s] [ 64s] obs-arm-2 failed "build libasn1c.spec" at Wed Nov 17 00:33:08 UTC 2021. [ 64s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:33:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:33:36 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944dfb1469_5b8b2ac6bd19e61030916d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/CentOS_8/aarch64 Package network:osmocom:nightly/libosmo-netif failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_25/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_25/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_25/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.808354] sysrq: Changing Loglevel [ 18s] [ 7.808660] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=09bd378f-55a3-4ff5-aa5a-6f545ec3165c [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/libosmo-netif.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-netif.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 11.050495] sysrq: Power Off [ 21s] [ 11.051010] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-10 failed "build libosmo-netif.spec" at Wed Nov 17 00:33:31 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:34:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:34:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944e199dece_5b8b2ac6bd19e6103092bb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-ggsn failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_13/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_13/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_13/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.625863] sysrq: Changing Loglevel [ 18s] [ 7.626086] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=d10b6f0e-0395-4be9-82cf-5a89c732f798 [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/osmo-ggsn.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-ggsn.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 10.842300] sysrq: Power Off [ 21s] [ 10.842841] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-11 failed "build osmo-ggsn.spec" at Wed Nov 17 00:34:09 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:34:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:34:27 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944e1a44dff_5b8b2ac6bd19e61030933@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/CentOS_8/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 9s] cycle: perl-devel -> perl-ExtUtils-Install -> perl-ExtUtils-MakeMaker [ 9s] breaking dependency perl-ExtUtils-MakeMaker -> perl-devel [ 9s] done [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] Using UART console [ 9s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.952886] sysrq: Changing Loglevel [ 18s] [ 7.953129] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=36f6e0bf-9a77-45f3-a284-31b29403863c [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/simtrace2.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/simtrace2.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 11.154542] sysrq: Power Off [ 21s] [ 11.155199] reboot: Power down -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:34:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:34:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944e38f0023_5b8b2ac6bd19e6103095bd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-sip-connector failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] ### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: aarch64 [ 18s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] [ 7.846142] sysrq: Changing Loglevel [ 18s] [ 7.846456] sysrq: Loglevel set to 4 [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=4813791f-91f2-4135-b8ee-ceb564eb9b84 [ 18s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vda [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/osmo-sip-connector.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sip-connector.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 11.171199] sysrq: Power Off [ 21s] [ 11.171779] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-11 failed "build osmo-sip-connector.spec" at Wed Nov 17 00:34:32 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:35:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:35:01 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944e39359d9_5b8b2ac6bd19e610309612@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/CentOS_8/aarch64 Package network:osmocom:nightly/libosmo-sccp failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 30s] ### VM INTERACTION END ### [ 30s] 2nd stage started in virtual machine [ 30s] machine type: aarch64 [ 30s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 30s] Increasing log level from now on... [ 30s] [ 9.952615] sysrq: Changing Loglevel [ 30s] [ 9.953408] sysrq: Loglevel set to 4 [ 30s] Enable sysrq operations [ 30s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 30s] no label, UUID=1684fd57-ee01-4e6f-bdb0-73d64301c255 [ 30s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 30s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 30s] swapon /dev/vda [ 30s] WARNING: udev not running, creating extra device nodes [ 30s] logging output to //.build.log... [ 30s] processing recipe /.build-srcdir/libosmo-sccp.spec ... [ 30s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-sccp.spec build ... [ 30s] initializing rpm db... [ 30s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 30s] ### VM INTERACTION START ### [ 33s] [ 13.278602] sysrq: Power Off [ 33s] [ 13.279974] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] obs-arm-9 failed "build libosmo-sccp.spec" at Wed Nov 17 00:34:55 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:35:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:35:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944e70d01d1_5b8b2ac6bd19e6103097a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-cbc failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 10s] ### VM INTERACTION START ### [ 10s] Using UART console [ 10s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_22/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_22/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_22/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 19s] ### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: aarch64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] [ 7.880405] sysrq: Changing Loglevel [ 19s] [ 7.880639] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=7dadeb3b-b5f2-44e8-ab6c-1925d42c082c [ 19s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vda [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-cbc.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-cbc.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 11.079282] sysrq: Power Off [ 22s] [ 11.080016] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] obs-arm-10 failed "build osmo-cbc.spec" at Wed Nov 17 00:35:28 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:36:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:36:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944e8f4ae96_5b8b2ac6bd19e61030985a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-remsim failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 11s] ### VM INTERACTION START ### [ 11s] Using UART console [ 11s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 19s] ### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: aarch64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] [ 7.872772] sysrq: Changing Loglevel [ 19s] [ 7.873076] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=5237954b-fa70-4553-b7e7-ad4dd8e47e94 [ 19s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vda [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-remsim.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-remsim.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 11.059246] sysrq: Power Off [ 22s] [ 11.059993] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] obs-arm-10 failed "build osmo-remsim.spec" at Wed Nov 17 00:35:56 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:37:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:37:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61944eea85fc6_5b8b2ac6bd19e61030993d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-iuh failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 19s] ### VM INTERACTION START ### [ 19s] Using UART console [ 19s] /usr/bin/qemu-system-aarch64 -nodefaults -no-reboot -nographic -vga none -cpu host -enable-kvm -M virt,gic-version=host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-device,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyAMA0 init=/.build/build -m 5120 -drive file=/var/cache/obs/worker/root_29/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-device,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_29/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-device,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_29/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 30s] ### VM INTERACTION END ### [ 30s] 2nd stage started in virtual machine [ 30s] machine type: aarch64 [ 30s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 30s] Increasing log level from now on... [ 30s] [ 10.351456] sysrq: Changing Loglevel [ 30s] [ 10.352127] sysrq: Loglevel set to 4 [ 30s] Enable sysrq operations [ 30s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 30s] no label, UUID=5430768d-c775-4f21-a09f-549a00479d31 [ 30s] swapon: /dev/vda: found signature [pagesize=4096, signature=swap] [ 30s] swapon: /dev/vda: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 30s] swapon /dev/vda [ 30s] WARNING: udev not running, creating extra device nodes [ 30s] logging output to //.build.log... [ 30s] processing recipe /.build-srcdir/osmo-iuh.spec ... [ 30s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-iuh.spec build ... [ 30s] initializing rpm db... [ 30s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 30s] ### VM INTERACTION START ### [ 33s] [ 13.648619] sysrq: Power Off [ 33s] [ 13.649786] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] obs-arm-9 failed "build osmo-iuh.spec" at Wed Nov 17 00:37:31 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:44:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:44:56 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <619450901e76f_5b8b2ac6bd19e610312395@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 403s] building additional files... [ 403s] checking if compiling is necessary... [ 403s] the output file doesn't exist [ 403s] pdflatex -interaction=batchmode rtp-amr.tex [ 403s] pdflatex failed [ 403s] [ 403s] A possible reason for transformation failure is invalid DocBook [ 403s] (as reported by xmllint) [ 403s] [ 403s] Error: pdflatex compilation failed [ 403s] [ 403s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 403s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 403s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 403s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 403s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 403s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 403s] make[1]: *** [Makefile:375: all] Error 2 [ 403s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 403s] dh_auto_build: error: make -j1 returned exit code 2 [ 403s] make: *** [debian/rules:12: build] Error 25 [ 403s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 403s] ### VM INTERACTION START ### [ 404s] Powering off. [ 404s] [ 387.852413] reboot: Power down [ 404s] ### VM INTERACTION END ### [ 404s] [ 404s] old-atreju4 failed "build osmo-bts_1.4.0.202111170026.dsc" at Wed Nov 17 00:44:55 UTC 2021. [ 404s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:50:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:50:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <619451d988749_5b8b2ac6bd19e610313817@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 472s] building additional files... [ 472s] checking if compiling is necessary... [ 472s] the output file doesn't exist [ 472s] pdflatex -interaction=batchmode rtp-amr.tex [ 472s] pdflatex failed [ 472s] [ 472s] A possible reason for transformation failure is invalid DocBook [ 472s] (as reported by xmllint) [ 472s] [ 472s] Error: pdflatex compilation failed [ 472s] [ 472s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 472s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 472s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 472s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 472s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 472s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 472s] make[1]: *** [Makefile:375: all] Error 2 [ 472s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 472s] dh_auto_build: error: make -j1 returned exit code 2 [ 472s] make: *** [debian/rules:12: build] Error 25 [ 472s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 472s] ### VM INTERACTION START ### [ 473s] Powering off. [ 473s] [ 440.922948] reboot: Power down [ 473s] ### VM INTERACTION END ### [ 473s] [ 473s] cloud101 failed "build osmo-bts_1.4.0.202111170026.dsc" at Wed Nov 17 00:50:10 UTC 2021. [ 473s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:59:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:59:40 +0000 Subject: Build failure of network:osmocom:latest/libosmocore in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61945411bc22_5b8b2ac6bd19e610314160@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/CentOS_8/x86_64 Package network:osmocom:latest/libosmocore failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 20s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 20s] Increasing log level from now on... [ 20s] [ 5.649772] sysrq: Changing Loglevel [ 20s] [ 5.650647] sysrq: Loglevel set to 4 [ 20s] Enable sysrq operations [ 20s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 20s] no label, UUID=af021d6b-be93-44f8-a2e0-60a8ee339346 [ 20s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 20s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 20s] swapon /dev/vdb [ 20s] WARNING: udev not running, creating extra device nodes [ 20s] logging output to //.build.log... [ 20s] processing recipe /.build-srcdir/libosmocore.spec ... [ 20s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmocore.spec build ... [ 20s] initializing rpm db... [ 20s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.859889] sysrq: Power Off [ 23s] [ 8.866616] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb23 failed "build libosmocore.spec" at Wed Nov 17 00:59:34 UTC 2021. [ 23s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 00:59:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 00:59:57 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61945411bf649_5b8b2ac6bd19e6103143f0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/libosmo-sccp failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 38s] Making all in xua [ 38s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/libosmo-sccp-1.5.0/tests/xua' [ 38s] CC xua_test.o [ 38s] CC sccp_test_data.o [ 38s] CCLD xua_test [ 38s] /usr/lib64/gcc/aarch64-suse-linux/7/../../../../aarch64-suse-linux/bin/ld: ../../src/.libs/libosmo-sigtran.a(osmo_ss7.o): in function `osmo_ss7_as_find_or_create': [ 38s] osmo_ss7.c:(.text+0x2628): undefined reference to `rate_ctr_group_set_name' [ 38s] /usr/lib64/gcc/aarch64-suse-linux/7/../../../../aarch64-suse-linux/bin/ld: ../../src/.libs/libosmo-sigtran.a(osmo_ss7.o): in function `osmo_ss7_asp_find_or_create': [ 38s] osmo_ss7.c:(.text+0x332c): undefined reference to `rate_ctr_group_set_name' [ 38s] collect2: error: ld returned 1 exit status [ 38s] make[3]: *** [Makefile:376: xua_test] Error 1 [ 38s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-sccp-1.5.0/tests/xua' [ 38s] make[2]: *** [Makefile:377: all-recursive] Error 1 [ 38s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-sccp-1.5.0/tests' [ 38s] make[1]: *** [Makefile:506: all-recursive] Error 1 [ 38s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/libosmo-sccp-1.5.0' [ 38s] make: *** [Makefile:401: all] Error 2 [ 38s] error: Bad exit status from /var/tmp/rpm-tmp.k47qW8 (%build) [ 38s] [ 38s] [ 38s] RPM build errors: [ 38s] Bad exit status from /var/tmp/rpm-tmp.k47qW8 (%build) [ 38s] ### VM INTERACTION START ### [ 41s] [ 34.392663] sysrq: SysRq : Power Off [ 41s] [ 34.393257] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] obs-arm-10 failed "build libosmo-sccp.spec" at Wed Nov 17 00:59:40 UTC 2021. [ 41s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:00:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:00:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <619454303b41c_5b8b2ac6bd19e61031442f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/CentOS_8/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 12s] Using UART console [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 12s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 5[ 5.004722] sysrq: Changing Loglevel [ 18s] [ 5.005849] sysrq: Loglevel set to 4 [ 18s] .3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 18s] Increasing log level from now on... [ 18s] Enable sysrq operations [ 18s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 18s] no label, UUID=00fec938-afc1-4c69-b343-5052c4de5a54 [ 18s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 18s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 18s] swapon /dev/vdb [ 18s] WARNING: udev not running, creating extra device nodes [ 18s] logging output to //.build.log... [ 18s] processing recipe /.build-srcdir/osmo-ggsn.spec ... [ 18s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-ggsn.spec build ... [ 18s] initializing rpm db... [ 18s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.173041] sysrq: Power Off [ 21s] [ 8.175279] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] old-atreju4 failed "build osmo-ggsn.spec" at Wed Nov 17 01:00:06 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:00:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:00:14 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6194543066237_5b8b2ac6bd19e6103145fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/CentOS_8/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 4096 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 4.905870] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 4.907067] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2147479552 bytes) [ 19s] no label, UUID=2c225fc0-db69-4342-bd9e-e0d247816801 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2147483648, devsize=2147483648 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/libosmo-sccp.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/libosmo-sccp.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.141014] sysrq: Power Off [ 22s] [ 8.144971] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] old-cirrus2 failed "build libosmo-sccp.spec" at Wed Nov 17 01:00:07 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:00:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:00:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6194543098c55_5b8b2ac6bd19e6103146b9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/CentOS_8/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5[ 5.338151] sysrq: Changing Loglevel [ 19s] .3.18-59.27-defa[ 5.340092] sysrq: Loglevel set to 4 [ 19s] ult #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=e9904ebf-0188-4a17-b328-a63d8fc4e396 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-hlr.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-hlr.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.556871] sysrq: Power Off [ 22s] [ 8.564205] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb19 failed "build osmo-hlr.spec" at Wed Nov 17 01:00:10 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:00:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:00:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61945430c126c_5b8b2ac6bd19e6103147b2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/CentOS_8/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 13s] Using UART console [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UTC 2021 (7df2404) [ 19s] Increasing log level from now on... [ 19s] [ 5.326673] sysrq: Changing Loglevel [ 19s] [ 5.328344] sysrq: Loglevel set to 4 [ 19s] Enable sysrq operations [ 19s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 19s] no label, UUID=8e990111-10b9-4ec6-87df-307e3d4ade20 [ 19s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 19s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 19s] swapon /dev/vdb [ 19s] WARNING: udev not running, creating extra device nodes [ 19s] logging output to //.build.log... [ 19s] processing recipe /.build-srcdir/osmo-cbc.spec ... [ 19s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-cbc.spec build ... [ 19s] initializing rpm db... [ 19s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.533189] sysrq: Power Off [ 22s] [ 8.540113] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb56 failed "build osmo-cbc.spec" at Wed Nov 17 01:00:11 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:00:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:00:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <619454316378_5b8b2ac6bd19e6103148c7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/CentOS_8/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 18s] Using UART console [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/kernel.obs.guest -initrd /boot/initrd.obs.guest -append root=/dev/disk/by-id/virtio-0 rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 mitigations=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3072 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device virtio-blk-pci,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device virtio-blk-pci,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 18s] c[?7lSeaBIOS (version rel-1.14.0-0-g155821a-rebuilt.opensuse.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 5.3.18-59.27-default #1 SMP Tue Oct 5 10:00:40 UT[ 5.613955] sysrq: Changing Loglevel [ 24s] [ 5.616190] sysrq: Loglevel set to 4 [ 24s] C 2021 (7df2404) [ 24s] Increasing log level from now on... [ 24s] Enable sysrq operations [ 24s] Setting up swapspace version 1, size = 2 GiB (2097147904 bytes) [ 24s] no label, UUID=829bdf64-7f32-49b7-b186-e16df0c5e20d [ 24s] swapon: /dev/vdb: found signature [pagesize=4096, signature=swap] [ 24s] swapon: /dev/vdb: pagesize=4096, swapsize=2097152000, devsize=2097152000 [ 24s] swapon /dev/vdb [ 24s] WARNING: udev not running, creating extra device nodes [ 24s] logging output to //.build.log... [ 24s] processing recipe /.build-srcdir/osmo-sip-connector.spec ... [ 24s] init_buildsystem --configdir /.build/configs --cachedir /var/cache/build /.build-srcdir/osmo-sip-connector.spec build ... [ 24s] initializing rpm db... [ 24s] /usr/bin/rpmdb: error while loading shared libraries: libsqlite3.so.0: cannot open shared object file: No such file or directory [ 24s] ### VM INTERACTION START ### [ 27s] [ 8.866321] sysrq: Power Off [ 27s] [ 8.892698] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] cloud106 failed "build osmo-sip-connector.spec" at Wed Nov 17 01:00:13 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:07:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:07:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <619455f238d65_5b8b2ac6bd19e6103153ad@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 54s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 55s] AR libmsc.a [ 55s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 55s] Making all in osmo-msc [ 55s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 55s] CC msc_main.o [ 55s] CCLD osmo-msc [ 55s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_encode': [ 55s] ran_msg_iu.c:(.text+0x1038): undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 55s] collect2: error: ld returned 1 exit status [ 55s] make[3]: *** [Makefile:484: osmo-msc] Error 1 [ 55s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 55s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 55s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 55s] make[1]: *** [Makefile:470: all-recursive] Error 1 [ 55s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 55s] make: *** [Makefile:402: all] Error 2 [ 55s] error: Bad exit status from /var/tmp/rpm-tmp.0tYvzO (%build) [ 55s] [ 55s] [ 55s] RPM build errors: [ 55s] Bad exit status from /var/tmp/rpm-tmp.0tYvzO (%build) [ 55s] ### VM INTERACTION START ### [ 59s] [ 50.535444][ T419] sysrq: Power Off [ 59s] [ 50.541622][ T16] reboot: Power down [ 59s] ### VM INTERACTION END ### [ 59s] [ 59s] lamb04 failed "build osmo-msc.spec" at Wed Nov 17 01:07:32 UTC 2021. [ 59s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:07:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:07:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <619455f2cf8ce_5b8b2ac6bd19e6103154c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 55s] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 55s] AR libmsc.a [ 55s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 55s] Making all in osmo-msc [ 55s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 55s] CC msc_main.o [ 55s] CCLD osmo-msc [ 56s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_encode': [ 56s] ran_msg_iu.c:(.text+0x1243): undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 56s] collect2: error: ld returned 1 exit status [ 56s] make[3]: *** [Makefile:483: osmo-msc] Error 1 [ 56s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 56s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 56s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 56s] make[1]: *** [Makefile:468: all-recursive] Error 1 [ 56s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 56s] make: *** [Makefile:400: all] Error 2 [ 56s] error: Bad exit status from /var/tmp/rpm-tmp.TFP4gM (%build) [ 56s] [ 56s] [ 56s] RPM build errors: [ 56s] Bad exit status from /var/tmp/rpm-tmp.TFP4gM (%build) [ 56s] ### VM INTERACTION START ### [ 59s] [ 50.379146] sysrq: SysRq : Power Off [ 59s] [ 50.386895] reboot: Power down [ 59s] ### VM INTERACTION END ### [ 59s] [ 59s] lamb60 failed "build osmo-msc.spec" at Wed Nov 17 01:07:51 UTC 2021. [ 59s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:09:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:09:52 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <6194566d6af15_5b8b2ac6bd19e6103157c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 35s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 35s] AR libmsc.a [ 35s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 35s] Making all in osmo-msc [ 35s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 35s] CC msc_main.o [ 35s] CCLD osmo-msc [ 36s] /usr/lib/gcc/i586-suse-linux/11/../../../../i586-suse-linux/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `.L208': [ 36s] ran_msg_iu.c:(.text+0x1124): undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 36s] collect2: error: ld returned 1 exit status [ 36s] make[3]: *** [Makefile:484: osmo-msc] Error 1 [ 36s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 36s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 36s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 36s] make[1]: *** [Makefile:470: all-recursive] Error 1 [ 36s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 36s] make: *** [Makefile:402: all] Error 2 [ 36s] error: Bad exit status from /var/tmp/rpm-tmp.Ikc67t (%build) [ 36s] [ 36s] [ 36s] RPM build errors: [ 36s] Bad exit status from /var/tmp/rpm-tmp.Ikc67t (%build) [ 36s] ### VM INTERACTION START ### [ 39s] [ 33.434950][ T422] sysrq: Power Off [ 39s] [ 33.437322][ T7] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] hci-cnode1-m0 failed "build osmo-msc.spec" at Wed Nov 17 01:09:46 UTC 2021. [ 39s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:10:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:10:09 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <619456873182e_5b8b2ac6bd19e61031593a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 44s] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 44s] AR libmsc.a [ 44s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 44s] Making all in osmo-msc [ 44s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 44s] CC msc_main.o [ 44s] CCLD osmo-msc [ 44s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_encode': [ 44s] ran_msg_iu.c:(.text+0x1243): undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 44s] collect2: error: ld returned 1 exit status [ 44s] make[3]: *** [Makefile:483: osmo-msc] Error 1 [ 44s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 44s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 44s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 44s] make[1]: *** [Makefile:468: all-recursive] Error 1 [ 44s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 44s] make: *** [Makefile:400: all] Error 2 [ 44s] error: Bad exit status from /var/tmp/rpm-tmp.EOexAB (%build) [ 44s] [ 44s] [ 44s] RPM build errors: [ 44s] Bad exit status from /var/tmp/rpm-tmp.EOexAB (%build) [ 44s] ### VM INTERACTION START ### [ 48s] [ 40.070182] sysrq: Power Off [ 48s] [ 40.074019] reboot: Power down [ 48s] ### VM INTERACTION END ### [ 48s] [ 48s] sheep87 failed "build osmo-msc.spec" at Wed Nov 17 01:09:52 UTC 2021. [ 48s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:14:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:14:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6194577ad9d84_5b8b2ac6bd19e61031665f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 281s] building additional files... [ 281s] checking if compiling is necessary... [ 281s] the output file doesn't exist [ 281s] pdflatex -interaction=batchmode rtp-amr.tex [ 281s] pdflatex failed [ 281s] [ 281s] A possible reason for transformation failure is invalid DocBook [ 281s] (as reported by xmllint) [ 281s] [ 281s] Error: pdflatex compilation failed [ 281s] [ 281s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 281s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 281s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 281s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 281s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 281s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 281s] make[1]: *** [Makefile:375: all] Error 2 [ 281s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 281s] dh_auto_build: error: make -j1 returned exit code 2 [ 281s] make: *** [debian/rules:12: build] Error 25 [ 281s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 281s] ### VM INTERACTION START ### [ 282s] Powering off. [ 282s] [ 270.522518] reboot: Power down [ 282s] ### VM INTERACTION END ### [ 282s] [ 282s] build72 failed "build osmo-bts_1.4.0.dsc" at Wed Nov 17 01:14:11 UTC 2021. [ 282s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:15:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:15:49 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <619457d1becd5_5b8b2ac6bd19e6103168d7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 465s] building additional files... [ 465s] checking if compiling is necessary... [ 465s] the output file doesn't exist [ 465s] pdflatex -interaction=batchmode rtp-amr.tex [ 465s] pdflatex failed [ 465s] [ 465s] A possible reason for transformation failure is invalid DocBook [ 465s] (as reported by xmllint) [ 465s] [ 465s] Error: pdflatex compilation failed [ 465s] [ 465s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 465s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 465s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 465s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 465s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 465s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 465s] make[1]: *** [Makefile:375: all] Error 2 [ 465s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 465s] dh_auto_build: error: make -j1 returned exit code 2 [ 465s] make: *** [debian/rules:12: build] Error 25 [ 465s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 465s] ### VM INTERACTION START ### [ 466s] Powering off. [ 466s] [ 440.457906] reboot: Power down [ 466s] ### VM INTERACTION END ### [ 466s] [ 466s] cloud116 failed "build osmo-bts_1.4.0.dsc" at Wed Nov 17 01:15:32 UTC 2021. [ 466s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:16:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:16:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <619457f04afb7_5b8b2ac6bd19e61031697f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 35s] CC smpp_utils.o [ 35s] AR libmsc.a [ 35s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 35s] Making all in osmo-msc [ 35s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 35s] CC msc_main.o [ 35s] CCLD osmo-msc [ 35s] /usr/lib64/gcc/aarch64-suse-linux/7/../../../../aarch64-suse-linux/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_encode': [ 35s] ran_msg_iu.c:(.text+0x11c0): undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 35s] collect2: error: ld returned 1 exit status [ 35s] make[3]: *** [Makefile:483: osmo-msc] Error 1 [ 35s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 35s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 35s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 35s] make[1]: *** [Makefile:468: all-recursive] Error 1 [ 35s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 35s] make: *** [Makefile:400: all] Error 2 [ 35s] error: Bad exit status from /var/tmp/rpm-tmp.mVaRCB (%build) [ 35s] [ 35s] [ 35s] RPM build errors: [ 35s] Bad exit status from /var/tmp/rpm-tmp.mVaRCB (%build) [ 35s] ### VM INTERACTION START ### [ 39s] [ 32.764589] sysrq: SysRq : Power Off [ 39s] [ 32.765135] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] obs-arm-11 failed "build osmo-msc.spec" at Wed Nov 17 01:15:53 UTC 2021. [ 39s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:18:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:18:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_10/x86_64 In-Reply-To: References: Message-ID: <619458853eed8_5b8b2ac6bd19e6103172e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_10/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 150s] ar: `u' modifier ignored since `D' is the default (see `U') [ 150s] ranlib libmsc.a [ 150s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 150s] Making all in osmo-msc [ 150s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 150s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 150s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 150s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 150s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 150s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 150s] collect2: error: ld returned 1 exit status [ 150s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 150s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 150s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 150s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 150s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 150s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 150s] make[1]: *** [Makefile:401: all] Error 2 [ 150s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 150s] dh_auto_build: make -j1 returned exit code 2 [ 150s] make: *** [debian/rules:45: build] Error 2 [ 150s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 150s] ### VM INTERACTION START ### [ 153s] [ 145.372309] sysrq: Power Off [ 153s] [ 145.376289] reboot: Power down [ 153s] ### VM INTERACTION END ### [ 153s] [ 153s] goat13 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:18:26 UTC 2021. [ 153s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:26:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:26:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_11/x86_64 In-Reply-To: References: Message-ID: <61945a2de900c_5b8b2ac6bd19e61031852c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_11/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 312s] ar: `u' modifier ignored since `D' is the default (see `U') [ 312s] ranlib libmsc.a [ 312s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 312s] Making all in osmo-msc [ 312s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 312s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 312s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 312s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 312s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 312s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 312s] collect2: error: ld returned 1 exit status [ 312s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 312s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 312s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 312s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 312s] make[2]: *** [Makefile:471: all-recursive] Error 1 [ 312s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 312s] make[1]: *** [Makefile:403: all] Error 2 [ 312s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 312s] dh_auto_build: error: make -j1 returned exit code 2 [ 312s] make: *** [debian/rules:45: build] Error 25 [ 312s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 312s] ### VM INTERACTION START ### [ 314s] Powering off. [ 314s] [ 300.072037] reboot: Power down [ 314s] ### VM INTERACTION END ### [ 314s] [ 314s] sheep83 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:25:53 UTC 2021. [ 314s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:28:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:28:01 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61945aa493f37_5b8b2ac6bd19e610319055@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_10/aarch64 Package network:osmocom:latest/osmo-msc failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 300s] ar: `u' modifier ignored since `D' is the default (see `U') [ 300s] ranlib libmsc.a [ 300s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 300s] Making all in osmo-msc [ 300s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 300s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 301s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 301s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/aarch64-linux-gnu/libosmovty.so /usr/lib/aarch64-linux-gnu/libosmoctrl.so /usr/lib/aarch64-linux-gnu/libosmogsm.so /usr/lib/aarch64-linux-gnu/libosmocore.so /usr/lib/aarch64-linux-gnu/libosmoabis.so /usr/lib/aarch64-linux-gnu/libosmonetif.so /usr/lib/aarch64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/aarch64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/aarch64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 301s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 301s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 301s] collect2: error: ld returned 1 exit status [ 301s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 301s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 301s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 301s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 301s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 301s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 301s] make[1]: *** [Makefile:401: all] Error 2 [ 301s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 301s] dh_auto_build: make -j1 returned exit code 2 [ 301s] make: *** [debian/rules:45: build] Error 2 [ 301s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 301s] ### VM INTERACTION START ### [ 304s] [ 287.776905] sysrq: Power Off [ 304s] [ 287.778497] reboot: Power down [ 305s] ### VM INTERACTION END ### [ 305s] [ 305s] obs-arm-8 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:27:47 UTC 2021. [ 305s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:30:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:30:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <61945b56decc8_5b8b2ac6bd19e6103197d0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/aarch64 Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 251s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 252s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 253s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/aarch64-linux-gnu/libosmovty.so /usr/lib/aarch64-linux-gnu/libosmoctrl.so /usr/lib/aarch64-linux-gnu/libosmogsm.so /usr/lib/aarch64-linux-gnu/libosmocore.so /usr/lib/aarch64-linux-gnu/libosmoabis.so /usr/lib/aarch64-linux-gnu/libosmonetif.so /usr/lib/aarch64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/aarch64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/aarch64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 253s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 253s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 253s] collect2: error: ld returned 1 exit status [ 253s] Makefile:483: recipe for target 'osmo-msc' failed [ 253s] make[4]: *** [osmo-msc] Error 1 [ 253s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 253s] Makefile:422: recipe for target 'all-recursive' failed [ 253s] make[3]: *** [all-recursive] Error 1 [ 253s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 253s] Makefile:469: recipe for target 'all-recursive' failed [ 253s] make[2]: *** [all-recursive] Error 1 [ 253s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 253s] Makefile:401: recipe for target 'all' failed [ 253s] make[1]: *** [all] Error 2 [ 253s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 253s] dh_auto_build: make -j1 returned exit code 2 [ 253s] debian/rules:45: recipe for target 'build' failed [ 253s] make: *** [build] Error 2 [ 253s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 253s] ### VM INTERACTION START ### [ 256s] [ 241.844813] sysrq: Power Off [ 256s] [ 241.867009] reboot: Power down [ 256s] ### VM INTERACTION END ### [ 256s] [ 256s] obs-arm-7 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:30:49 UTC 2021. [ 256s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:31:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:31:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/i586 In-Reply-To: References: Message-ID: <61945b915f69_5b8b2ac6bd19e6103206f6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/i586 Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 232s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 232s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 233s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so /usr/lib/i386-linux-gnu/libosmocore.so /usr/lib/i386-linux-gnu/libosmoabis.so /usr/lib/i386-linux-gnu/libosmonetif.so /usr/lib/i386-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/i386-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/i386-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 233s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 233s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 233s] collect2: error: ld returned 1 exit status [ 233s] Makefile:483: recipe for target 'osmo-msc' failed [ 233s] make[4]: *** [osmo-msc] Error 1 [ 233s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 233s] Makefile:422: recipe for target 'all-recursive' failed [ 233s] make[3]: *** [all-recursive] Error 1 [ 233s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 233s] Makefile:469: recipe for target 'all-recursive' failed [ 233s] make[2]: *** [all-recursive] Error 1 [ 233s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 233s] Makefile:401: recipe for target 'all' failed [ 233s] make[1]: *** [all] Error 2 [ 233s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 233s] dh_auto_build: make -j1 returned exit code 2 [ 233s] debian/rules:45: recipe for target 'build' failed [ 233s] make: *** [build] Error 2 [ 233s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 233s] ### VM INTERACTION START ### [ 236s] [ 220.344444] sysrq: Power Off [ 236s] [ 220.348916] reboot: Power down [ 236s] ### VM INTERACTION END ### [ 236s] [ 236s] cloud119 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:31:37 UTC 2021. [ 236s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:31:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:31:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <61945b91432c3_5b8b2ac6bd19e6103207e6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 245s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 246s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 247s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 247s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 247s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 247s] collect2: error: ld returned 1 exit status [ 247s] Makefile:483: recipe for target 'osmo-msc' failed [ 247s] make[4]: *** [osmo-msc] Error 1 [ 247s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 247s] Makefile:422: recipe for target 'all-recursive' failed [ 247s] make[3]: *** [all-recursive] Error 1 [ 247s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 247s] Makefile:469: recipe for target 'all-recursive' failed [ 247s] make[2]: *** [all-recursive] Error 1 [ 247s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 247s] Makefile:401: recipe for target 'all' failed [ 247s] make[1]: *** [all] Error 2 [ 247s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 247s] dh_auto_build: make -j1 returned exit code 2 [ 247s] debian/rules:45: recipe for target 'build' failed [ 247s] make: *** [build] Error 2 [ 247s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 247s] ### VM INTERACTION START ### [ 250s] [ 237.696299] sysrq: Power Off [ 250s] [ 237.702795] reboot: Power down [ 250s] ### VM INTERACTION END ### [ 250s] [ 250s] lamb04 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:31:26 UTC 2021. [ 250s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:32:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:32:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <61945bb0c3abe_5b8b2ac6bd19e6103209bf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_19.04/x86_64 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 276s] ar: `u' modifier ignored since `D' is the default (see `U') [ 276s] ranlib libmsc.a [ 276s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 276s] Making all in osmo-msc [ 276s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 276s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 276s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 277s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 277s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 277s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 277s] collect2: error: ld returned 1 exit status [ 277s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 277s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 277s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 277s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 277s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 277s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 277s] make[1]: *** [Makefile:401: all] Error 2 [ 277s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 277s] dh_auto_build: make -j1 returned exit code 2 [ 277s] make: *** [debian/rules:45: build] Error 2 [ 277s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 277s] ### VM INTERACTION START ### [ 280s] [ 268.072301] sysrq: Power Off [ 280s] [ 268.077968] reboot: Power down [ 280s] ### VM INTERACTION END ### [ 280s] [ 280s] lamb07 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:31:59 UTC 2021. [ 280s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:32:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:32:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_19.04/i586 In-Reply-To: References: Message-ID: <61945bcf70cfa_5b8b2ac6bd19e6103210cc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_19.04/i586 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_19.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 326s] ar: `u' modifier ignored since `D' is the default (see `U') [ 326s] ranlib libmsc.a [ 326s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 326s] Making all in osmo-msc [ 326s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 326s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 326s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 327s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so /usr/lib/i386-linux-gnu/libosmocore.so /usr/lib/i386-linux-gnu/libosmoabis.so /usr/lib/i386-linux-gnu/libosmonetif.so /usr/lib/i386-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/i386-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/i386-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 327s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 327s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 327s] collect2: error: ld returned 1 exit status [ 327s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 327s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 327s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 327s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 327s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 327s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 327s] make[1]: *** [Makefile:401: all] Error 2 [ 327s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 327s] dh_auto_build: make -j1 returned exit code 2 [ 327s] make: *** [debian/rules:45: build] Error 2 [ 327s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 327s] ### VM INTERACTION START ### [ 330s] [ 318.373348] sysrq: Power Off [ 330s] [ 318.382697] reboot: Power down [ 330s] ### VM INTERACTION END ### [ 330s] [ 330s] lamb22 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:32:32 UTC 2021. [ 330s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:33:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:33:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_10/i586 In-Reply-To: References: Message-ID: <61945bebea914_5b8b2ac6bd19e6103214d6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_10/i586 Package network:osmocom:latest/osmo-msc failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 365s] ar: `u' modifier ignored since `D' is the default (see `U') [ 365s] ranlib libmsc.a [ 365s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 365s] Making all in osmo-msc [ 365s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 365s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 365s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 366s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so /usr/lib/i386-linux-gnu/libosmocore.so /usr/lib/i386-linux-gnu/libosmoabis.so /usr/lib/i386-linux-gnu/libosmonetif.so /usr/lib/i386-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/i386-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/i386-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 366s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 366s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 366s] collect2: error: ld returned 1 exit status [ 366s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 366s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 366s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 366s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 366s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 366s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 366s] make[1]: *** [Makefile:401: all] Error 2 [ 366s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 366s] dh_auto_build: make -j1 returned exit code 2 [ 366s] make: *** [debian/rules:45: build] Error 2 [ 366s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 366s] ### VM INTERACTION START ### [ 369s] [ 353.454118] sysrq: Power Off [ 369s] [ 353.460096] reboot: Power down [ 369s] ### VM INTERACTION END ### [ 369s] [ 369s] lamb02 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:33:04 UTC 2021. [ 369s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:33:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:33:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_20.10/x86_64 In-Reply-To: References: Message-ID: <61945beca7403_5b8b2ac6bd19e61032168@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_20.10/x86_64 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 305s] ar: `u' modifier ignored since `D' is the default (see `U') [ 305s] ranlib libmsc.a [ 305s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 305s] Making all in osmo-msc [ 305s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 305s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 305s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 305s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 305s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 305s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 305s] collect2: error: ld returned 1 exit status [ 305s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 305s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 305s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 305s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 305s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 305s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 305s] make[1]: *** [Makefile:401: all] Error 2 [ 305s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 305s] dh_auto_build: error: make -j1 returned exit code 2 [ 305s] make: *** [debian/rules:45: build] Error 25 [ 305s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 305s] ### VM INTERACTION START ### [ 306s] Powering off. [ 306s] [ 293.741214] reboot: Power down [ 306s] ### VM INTERACTION END ### [ 306s] [ 306s] sheep85 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:33:12 UTC 2021. [ 306s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:33:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:33:58 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61945c0bd09ae_5b8b2ac6bd19e610321850@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 155s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 156s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 156s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 156s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 156s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 156s] collect2: error: ld returned 1 exit status [ 156s] Makefile:483: recipe for target 'osmo-msc' failed [ 156s] make[4]: *** [osmo-msc] Error 1 [ 156s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 156s] Makefile:422: recipe for target 'all-recursive' failed [ 156s] make[3]: *** [all-recursive] Error 1 [ 156s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 156s] Makefile:469: recipe for target 'all-recursive' failed [ 156s] make[2]: *** [all-recursive] Error 1 [ 156s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 156s] Makefile:401: recipe for target 'all' failed [ 156s] make[1]: *** [all] Error 2 [ 156s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 156s] dh_auto_build: make -j1 returned exit code 2 [ 156s] debian/rules:45: recipe for target 'build' failed [ 156s] make: *** [build] Error 2 [ 156s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 156s] ### VM INTERACTION START ### [ 159s] [ 152.032141] sysrq: Power Off [ 159s] [ 152.035400] reboot: Power down [ 159s] ### VM INTERACTION END ### [ 159s] [ 159s] goat15 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:33:44 UTC 2021. [ 159s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:33:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:33:58 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <61945c0c294a7_5b8b2ac6bd19e61032194c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_21.10/x86_64 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 388s] ar: `u' modifier ignored since `D' is the default (see `U') [ 388s] ranlib libmsc.a [ 388s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 388s] Making all in osmo-msc [ 388s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 388s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 389s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 389s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 389s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 389s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 389s] collect2: error: ld returned 1 exit status [ 389s] make[4]: *** [Makefile:486: osmo-msc] Error 1 [ 389s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 389s] make[3]: *** [Makefile:423: all-recursive] Error 1 [ 389s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 389s] make[2]: *** [Makefile:471: all-recursive] Error 1 [ 389s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 389s] make[1]: *** [Makefile:403: all] Error 2 [ 389s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 389s] dh_auto_build: error: make -j1 returned exit code 2 [ 389s] make: *** [debian/rules:45: build] Error 25 [ 389s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 389s] ### VM INTERACTION START ### [ 390s] Powering off. [ 390s] [ 375.409891] reboot: Power down [ 391s] ### VM INTERACTION END ### [ 391s] [ 391s] old-cirrus1 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:33:47 UTC 2021. [ 391s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:34:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:34:49 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61945c46dffef_5b8b2ac6bd19e61032237@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 429s] ar: `u' modifier ignored since `D' is the default (see `U') [ 429s] ranlib libmsc.a [ 429s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 429s] Making all in osmo-msc [ 429s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 429s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 430s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 430s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 430s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 430s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 430s] collect2: error: ld returned 1 exit status [ 430s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 430s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 430s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 430s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 430s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 430s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 430s] make[1]: *** [Makefile:402: all] Error 2 [ 430s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 430s] dh_auto_build: error: make -j1 returned exit code 2 [ 430s] make: *** [debian/rules:45: build] Error 25 [ 430s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 430s] ### VM INTERACTION START ### [ 431s] Powering off. [ 431s] [ 405.513782] reboot: Power down [ 431s] ### VM INTERACTION END ### [ 431s] [ 431s] cloud120 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:34:40 UTC 2021. [ 431s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:35:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:35:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61945c81c4595_5b8b2ac6bd19e610322847@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 513s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 513s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 514s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so /usr/lib/i386-linux-gnu/libosmocore.so /usr/lib/i386-linux-gnu/libosmoabis.so /usr/lib/i386-linux-gnu/libosmonetif.so /usr/lib/i386-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/i386-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/i386-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 515s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 515s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 515s] collect2: error: ld returned 1 exit status [ 515s] Makefile:483: recipe for target 'osmo-msc' failed [ 515s] make[4]: *** [osmo-msc] Error 1 [ 515s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 515s] Makefile:422: recipe for target 'all-recursive' failed [ 515s] make[3]: *** [all-recursive] Error 1 [ 515s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 515s] Makefile:469: recipe for target 'all-recursive' failed [ 515s] make[2]: *** [all-recursive] Error 1 [ 515s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 515s] Makefile:401: recipe for target 'all' failed [ 515s] make[1]: *** [all] Error 2 [ 515s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 515s] dh_auto_build: make -j1 returned exit code 2 [ 515s] debian/rules:45: recipe for target 'build' failed [ 515s] make: *** [build] Error 2 [ 515s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 515s] ### VM INTERACTION START ### [ 518s] [ 499.135624] sysrq: Power Off [ 518s] [ 499.158475] reboot: Power down [ 518s] ### VM INTERACTION END ### [ 518s] [ 518s] lamb01 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:35:41 UTC 2021. [ 518s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:35:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:35:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <61945c82c4fd9_5b8b2ac6bd19e61032314f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_21.04/x86_64 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 403s] ar: `u' modifier ignored since `D' is the default (see `U') [ 403s] ranlib libmsc.a [ 403s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 403s] Making all in osmo-msc [ 403s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 403s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 403s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 403s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 404s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 404s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 404s] collect2: error: ld returned 1 exit status [ 404s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 404s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 404s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 404s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 404s] make[2]: *** [Makefile:471: all-recursive] Error 1 [ 404s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 404s] make[1]: *** [Makefile:403: all] Error 2 [ 404s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 404s] dh_auto_build: error: make -j1 returned exit code 2 [ 404s] make: *** [debian/rules:45: build] Error 25 [ 404s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 404s] ### VM INTERACTION START ### [ 405s] Powering off. [ 405s] [ 388.143277] reboot: Power down [ 405s] ### VM INTERACTION END ### [ 405s] [ 405s] old-cirrus1 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:35:44 UTC 2021. [ 405s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:36:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:36:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61945ca45c971_5b8b2ac6bd19e6103242b4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 433s] ar: `u' modifier ignored since `D' is the default (see `U') [ 433s] ranlib libmsc.a [ 433s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 433s] Making all in osmo-msc [ 433s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 433s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 434s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 434s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 434s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 434s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 434s] collect2: error: ld returned 1 exit status [ 434s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 434s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 434s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 434s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 434s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 434s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 434s] make[1]: *** [Makefile:402: all] Error 2 [ 434s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 434s] dh_auto_build: error: make -j1 returned exit code 2 [ 434s] make: *** [debian/rules:45: build] Error 25 [ 434s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 434s] ### VM INTERACTION START ### [ 435s] Powering off. [ 435s] [ 415.024374] reboot: Power down [ 436s] ### VM INTERACTION END ### [ 436s] [ 436s] cloud115 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:36:18 UTC 2021. [ 436s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:37:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:37:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in xUbuntu_20.04/x86_64 In-Reply-To: References: Message-ID: <61945cfccc494_5b8b2ac6bd19e610324966@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_20.04/x86_64 Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 189s] ar: `u' modifier ignored since `D' is the default (see `U') [ 189s] ranlib libmsc.a [ 189s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 189s] Making all in osmo-msc [ 189s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 189s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 189s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 189s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 189s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 189s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 189s] collect2: error: ld returned 1 exit status [ 189s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 189s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 189s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 189s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 189s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 189s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 189s] make[1]: *** [Makefile:401: all] Error 2 [ 189s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 189s] dh_auto_build: error: make -j1 returned exit code 2 [ 189s] make: *** [debian/rules:45: build] Error 25 [ 189s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 189s] ### VM INTERACTION START ### [ 193s] [ 184.400828] sysrq: Power Off [ 193s] [ 184.404311] reboot: Power down [ 193s] ### VM INTERACTION END ### [ 193s] [ 193s] goat15 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:37:24 UTC 2021. [ 193s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 01:41:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 01:41:20 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_11/i586 In-Reply-To: References: Message-ID: <61945dcba6836_5b8b2ac6bd19e6103281de@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_11/i586 Package network:osmocom:latest/osmo-msc failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 411s] ar: `u' modifier ignored since `D' is the default (see `U') [ 411s] ranlib libmsc.a [ 411s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 411s] Making all in osmo-msc [ 411s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 411s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 411s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 412s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so /usr/lib/i386-linux-gnu/libosmocore.so /usr/lib/i386-linux-gnu/libosmoabis.so /usr/lib/i386-linux-gnu/libosmonetif.so /usr/lib/i386-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/i386-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/i386-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 412s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 412s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 412s] collect2: error: ld returned 1 exit status [ 412s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 412s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 412s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 412s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 412s] make[2]: *** [Makefile:471: all-recursive] Error 1 [ 412s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 412s] make[1]: *** [Makefile:403: all] Error 2 [ 412s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 412s] dh_auto_build: error: make -j1 returned exit code 2 [ 412s] make: *** [debian/rules:45: build] Error 25 [ 412s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 412s] ### VM INTERACTION START ### [ 413s] Powering off. [ 413s] [ 401.730217] reboot: Power down [ 413s] ### VM INTERACTION END ### [ 413s] [ 413s] build81 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 01:41:17 UTC 2021. [ 413s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 03:03:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 03:03:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <619471234bee4_5b8b2ac6bd19e6103527e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 116s] CC smpp_utils.o [ 117s] AR libmsc.a [ 117s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 117s] Making all in osmo-msc [ 117s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 117s] CC msc_main.o [ 118s] CCLD osmo-msc [ 120s] /usr/lib/gcc/armv7hl-suse-linux-gnueabi/7/../../../../armv7hl-suse-linux-gnueabi/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_encode': [ 120s] ran_msg_iu.c:(.text+0x13d0): undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 120s] collect2: error: ld returned 1 exit status [ 120s] make[3]: *** [Makefile:483: osmo-msc] Error 1 [ 120s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 120s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 120s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 120s] make[1]: *** [Makefile:468: all-recursive] Error 1 [ 120s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 120s] make: *** [Makefile:400: all] Error 2 [ 120s] error: Bad exit status from /var/tmp/rpm-tmp.Ou4pe2 (%build) [ 120s] [ 120s] [ 120s] RPM build errors: [ 120s] Bad exit status from /var/tmp/rpm-tmp.Ou4pe2 (%build) [ 120s] ### VM INTERACTION START ### [ 123s] [ 101.226878] sysrq: SysRq : Power Off [ 123s] [ 101.232943] reboot: Power down [ 123s] ### VM INTERACTION END ### [ 123s] [ 123s] obs-arm-6 failed "build osmo-msc.spec" at Wed Nov 17 03:03:31 UTC 2021. [ 123s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Nov 17 03:38:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 03:38:28 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... bitvec_read_field(): indicate errors using errno This function returns an *unsigned* integer (uint64_t), so returning a negative value on error is a bad idea. A negative value turns into a huge positive value, what was demonstrated in the bitvec_test: bitvec_read_field(idx=512, len=16) => ffffffffffffffea bitvec_read_field(idx=0, len=65) => ffffffffffffffea bitvec_read_field(idx=64, len=16) => ffffffffffffffea The 0xffffffffffffffea above is basically: (uint64_t) -EINVAL, or (uint64_t) -22 + 1, or 0xffffffffffffffff - 0x16 + 1. Let's make use of the errno in order to indicate an error to the caller. Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Related: OS#4388 --- M src/bitvec.c M tests/bitvec/bitvec_test.c M tests/bitvec/bitvec_test.ok 3 files changed, 26 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/26307/1 diff --git a/src/bitvec.c b/src/bitvec.c index 2b4e8c9..b411a72 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -472,18 +472,23 @@ * \param[in] bv The boolean vector to work on * \param[in,out] read_index Where reading supposed to start in the vector * \param[in] len How many bits to read from vector - * \returns read bits or negative value on error + * \returns An integer made up of the bits read. + * + * In case of an error, errno is set to a non-zero value. Otherwise it holds 0. */ uint64_t bitvec_read_field(struct bitvec *bv, unsigned int *read_index, unsigned int len) { unsigned int i; uint64_t ui = 0; bv->cur_bit = *read_index; + errno = 0; for (i = 0; i < len; i++) { int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); - if (bit < 0) - return bit; + if (bit < 0) { + errno = -bit; + break; + } if (bit) ui |= ((uint64_t)1 << (len - i - 1)); bv->cur_bit++; diff --git a/tests/bitvec/bitvec_test.c b/tests/bitvec/bitvec_test.c index b4764e6..ea7ea9a 100644 --- a/tests/bitvec/bitvec_test.c +++ b/tests/bitvec/bitvec_test.c @@ -237,7 +237,8 @@ #define _bitvec_read_field(idx, len) \ readIndex = idx; \ field = bitvec_read_field(&bv, &readIndex, len); \ - printf("bitvec_read_field(idx=%u, len=%u) => %" PRIx64 "\n", idx, len, field); + printf("bitvec_read_field(idx=%u, len=%u) => %" PRIx64 " (%s)\n", \ + idx, len, field, errno == 0 ? "success" : "error"); _bitvec_read_field(0, 64); _bitvec_read_field(0, 32); diff --git a/tests/bitvec/bitvec_test.ok b/tests/bitvec/bitvec_test.ok index b118502..a0e31d3 100644 --- a/tests/bitvec/bitvec_test.ok +++ b/tests/bitvec/bitvec_test.ok @@ -171,21 +171,21 @@ bitvec bytes used. test bitvec_read_field(): -bitvec_read_field(idx=0, len=64) => deadbeeffeebdaed -bitvec_read_field(idx=0, len=32) => deadbeef -bitvec_read_field(idx=0, len=16) => dead -bitvec_read_field(idx=0, len=8) => de -bitvec_read_field(idx=0, len=0) => 0 -bitvec_read_field(idx=8, len=8) => ad -bitvec_read_field(idx=8, len=4) => a -bitvec_read_field(idx=8, len=0) => 0 -bitvec_read_field(idx=10, len=9) => 16d -bitvec_read_field(idx=10, len=7) => 5b -bitvec_read_field(idx=10, len=5) => 16 -bitvec_read_field(idx=10, len=3) => 5 -bitvec_read_field(idx=10, len=1) => 1 -bitvec_read_field(idx=512, len=16) => ffffffffffffffea -bitvec_read_field(idx=0, len=65) => ffffffffffffffea -bitvec_read_field(idx=64, len=16) => ffffffffffffffea +bitvec_read_field(idx=0, len=64) => deadbeeffeebdaed (success) +bitvec_read_field(idx=0, len=32) => deadbeef (success) +bitvec_read_field(idx=0, len=16) => dead (success) +bitvec_read_field(idx=0, len=8) => de (success) +bitvec_read_field(idx=0, len=0) => 0 (success) +bitvec_read_field(idx=8, len=8) => ad (success) +bitvec_read_field(idx=8, len=4) => a (success) +bitvec_read_field(idx=8, len=0) => 0 (success) +bitvec_read_field(idx=10, len=9) => 16d (success) +bitvec_read_field(idx=10, len=7) => 5b (success) +bitvec_read_field(idx=10, len=5) => 16 (success) +bitvec_read_field(idx=10, len=3) => 5 (success) +bitvec_read_field(idx=10, len=1) => 1 (success) +bitvec_read_field(idx=512, len=16) => 0 (error) +bitvec_read_field(idx=0, len=65) => bd5b7ddffdd7b5db (error) +bitvec_read_field(idx=64, len=16) => 0 (error) bitvec ok. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 03:38:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 03:38:30 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26308 ) Change subject: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan ...................................................................... bitvec_read_field(): fix incorrect bit-shift issue found by UBSan While running a sanitized version of the bitvec_test I get: bitvec.c:492:24: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int' This error is triggered by the following line in the bitvec_test: _bitvec_read_field(0, 8 * 8 + 1); /* too many bits */ which basically tries to parse more bits (65) than the test vector actually has (64). The problem is that we don't check if the given vector has enough data *before* entering the parsing loop, so we end up doing weird bit-shifts and getting weird values: bitvec_read_field(idx=0, len=65) => bd5b7ddffdd7b5db (error) Unfortunately, this problem remained unnoticed so far because in 'tests/testsuite.at' we don't check if stderr is empty. This is fixed in a follow up change [1]. Rather than checking for errors in every loop iteration, do this once and return early if the overrun is possible with the given offset and length arguments. Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Related: [1] Ia82b92eddb18dc596881abcef2f098dc7385538b --- M src/bitvec.c M tests/bitvec/bitvec_test.ok 2 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/26308/1 diff --git a/src/bitvec.c b/src/bitvec.c index b411a72..2303a0d 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -480,15 +480,18 @@ { unsigned int i; uint64_t ui = 0; + + /* Prevent bitvec overrun due to incorrect index and/or length */ + if (len && bytenum_from_bitnum(*read_index + len - 1) >= bv->data_len) { + errno = EOVERFLOW; + return 0; + } + bv->cur_bit = *read_index; errno = 0; for (i = 0; i < len; i++) { int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); - if (bit < 0) { - errno = -bit; - break; - } if (bit) ui |= ((uint64_t)1 << (len - i - 1)); bv->cur_bit++; diff --git a/tests/bitvec/bitvec_test.ok b/tests/bitvec/bitvec_test.ok index a0e31d3..d87ac7e 100644 --- a/tests/bitvec/bitvec_test.ok +++ b/tests/bitvec/bitvec_test.ok @@ -185,7 +185,7 @@ bitvec_read_field(idx=10, len=3) => 5 (success) bitvec_read_field(idx=10, len=1) => 1 (success) bitvec_read_field(idx=512, len=16) => 0 (error) -bitvec_read_field(idx=0, len=65) => bd5b7ddffdd7b5db (error) +bitvec_read_field(idx=0, len=65) => 0 (error) bitvec_read_field(idx=64, len=16) => 0 (error) bitvec ok. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Gerrit-Change-Number: 26308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 03:38:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 03:38:30 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... bitvec_read_field(): optimize by expanding bytenum_from_bitnum() The bitvec_read_field() is used in performance critical places, such as the CSN.1 decoder in osmo-pcu. Thus the less conditional statements we have in the parsing loop, the better. The bitvec_get_bit_pos() alone is quite a complex function, which does check the boundaries and even supports the L/H syntax. Even if it gets inlined by the compiler, we don't really want to run redundant checks and run bitval2mask() on each iteration. Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab --- M src/bitvec.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/26309/1 diff --git a/src/bitvec.c b/src/bitvec.c index 2303a0d..13deeff 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -491,8 +491,10 @@ errno = 0; for (i = 0; i < len; i++) { - int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); - if (bit) + unsigned int bytenum = bytenum_from_bitnum(bv->cur_bit); + unsigned int bitnum = 7 - (bv->cur_bit % 8); + + if (bv->data[bytenum] & (1 << bitnum)) ui |= ((uint64_t)1 << (len - i - 1)); bv->cur_bit++; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 03:38:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 03:38:31 +0000 Subject: Change in libosmocore[master]: tests/testsuite.at: ensure empty stderr for the bitvec_test References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26310 ) Change subject: tests/testsuite.at: ensure empty stderr for the bitvec_test ...................................................................... tests/testsuite.at: ensure empty stderr for the bitvec_test The address sanitizer may print errors and warnings to stderr, and this was actually the case for bitvec_test before [1]: bitvec.c:492:24: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int' Change-Id: Ia82b92eddb18dc596881abcef2f098dc7385538b Related: [1] I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 --- M tests/testsuite.at 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/10/26310/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index 975b51e..92c4e39 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -36,7 +36,7 @@ AT_SETUP([bitvec]) AT_KEYWORDS([bitvec]) cat $abs_srcdir/bitvec/bitvec_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/bitvec/bitvec_test], [0], [expout], [ignore]) +AT_CHECK([$abs_top_builddir/tests/bitvec/bitvec_test], [0], [expout]) AT_CLEANUP AT_SETUP([bitcomp]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia82b92eddb18dc596881abcef2f098dc7385538b Gerrit-Change-Number: 26310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Nov 17 04:26:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 04:26:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6194849576a9b_5b8b2ac6bd19e6103719d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 447s] building additional files... [ 447s] checking if compiling is necessary... [ 447s] the output file doesn't exist [ 447s] pdflatex -interaction=batchmode rtp-amr.tex [ 447s] pdflatex failed [ 447s] [ 447s] A possible reason for transformation failure is invalid DocBook [ 447s] (as reported by xmllint) [ 447s] [ 447s] Error: pdflatex compilation failed [ 447s] [ 447s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 447s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 447s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 447s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 447s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 447s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 447s] make[1]: *** [Makefile:375: all] Error 2 [ 447s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 447s] dh_auto_build: error: make -j1 returned exit code 2 [ 447s] make: *** [debian/rules:12: build] Error 25 [ 447s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 447s] ### VM INTERACTION START ### [ 448s] Powering off. [ 448s] [ 431.651673] reboot: Power down [ 448s] ### VM INTERACTION END ### [ 448s] [ 448s] lamb05 failed "build osmo-bts_1.4.0.dsc" at Wed Nov 17 04:26:40 UTC 2021. [ 448s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 04:28:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 04:28:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6194850cc2f0c_5b8b2ac6bd19e6103723ce@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 473s] building additional files... [ 473s] checking if compiling is necessary... [ 473s] the output file doesn't exist [ 473s] pdflatex -interaction=batchmode rtp-amr.tex [ 473s] pdflatex failed [ 473s] [ 473s] A possible reason for transformation failure is invalid DocBook [ 473s] (as reported by xmllint) [ 473s] [ 473s] Error: pdflatex compilation failed [ 473s] [ 473s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 473s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 473s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 473s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 473s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 473s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 473s] make[1]: *** [Makefile:375: all] Error 2 [ 473s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 473s] dh_auto_build: error: make -j1 returned exit code 2 [ 473s] make: *** [debian/rules:12: build] Error 25 [ 473s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 473s] ### VM INTERACTION START ### [ 474s] Powering off. [ 474s] [ 456.512115] reboot: Power down [ 474s] ### VM INTERACTION END ### [ 474s] [ 474s] lamb19 failed "build osmo-bts_1.4.0.202111170026.dsc" at Wed Nov 17 04:28:34 UTC 2021. [ 474s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Nov 17 04:39:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 04:39:59 +0000 Subject: Change in libosmocore[master]: tests/vty: fix use of GNU 'missing =' extension in designator References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26311 ) Change subject: tests/vty: fix use of GNU 'missing =' extension in designator ...................................................................... tests/vty: fix use of GNU 'missing =' extension in designator Change-Id: I66edb247898594b51cc9d7c1b3d0c60ba66fc637 --- M tests/vty/vty_test.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/26311/1 diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c index 1db0d5c..e068f19 100644 --- a/tests/vty/vty_test.c +++ b/tests/vty/vty_test.c @@ -542,9 +542,9 @@ /* Reserved for libraries */ [VTY_TEST_ATTR_UPPER] = 'X', /* Reserved for global attribues */ - [VTY_TEST_ATTR_RAFC_DOT] '.', - [VTY_TEST_ATTR_RAFC_EXCL] '!', - [VTY_TEST_ATTR_RAFC_AT] '@', + [VTY_TEST_ATTR_RAFC_DOT] = '.', + [VTY_TEST_ATTR_RAFC_EXCL] = '!', + [VTY_TEST_ATTR_RAFC_AT] = '@', }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I66edb247898594b51cc9d7c1b3d0c60ba66fc637 Gerrit-Change-Number: 26311 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Nov 17 04:51:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 04:51:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <61948a5520ea5_5b8b2ac6bd19e610376666@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 397s] ar: `u' modifier ignored since `D' is the default (see `U') [ 397s] ranlib libmsc.a [ 397s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 397s] Making all in osmo-msc [ 397s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 397s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 397s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 397s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -ffile-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libosmonetif.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/x86_64-linux-gnu/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/x86_64-linux-gnu/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 398s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 398s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 398s] collect2: error: ld returned 1 exit status [ 398s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 398s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 398s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 398s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 398s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 398s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 398s] make[1]: *** [Makefile:402: all] Error 2 [ 398s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 398s] dh_auto_build: error: make -j1 returned exit code 2 [ 398s] make: *** [debian/rules:45: build] Error 25 [ 398s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 398s] ### VM INTERACTION START ### [ 399s] Powering off. [ 399s] [ 382.598200] reboot: Power down [ 399s] ### VM INTERACTION END ### [ 399s] [ 399s] lamb05 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 04:51:10 UTC 2021. [ 399s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 07:56:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 07:56:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/armv7l In-Reply-To: References: Message-ID: <6194b5cdea6f2_5b8b2ac6bd19e610444938@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/armv7l Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 482s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 483s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 484s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/arm-linux-gnueabihf/libosmovty.so /usr/lib/arm-linux-gnueabihf/libosmoctrl.so /usr/lib/arm-linux-gnueabihf/libosmogsm.so /usr/lib/arm-linux-gnueabihf/libosmocore.so /usr/lib/arm-linux-gnueabihf/libosmoabis.so /usr/lib/arm-linux-gnueabihf/libosmonetif.so /usr/lib/arm-linux-gnueabihf/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/arm-linux-gnueabihf/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/arm-linux-gnueabihf/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 485s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 485s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 485s] collect2: error: ld returned 1 exit status [ 485s] Makefile:483: recipe for target 'osmo-msc' failed [ 485s] make[4]: *** [osmo-msc] Error 1 [ 485s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 485s] Makefile:422: recipe for target 'all-recursive' failed [ 485s] make[3]: *** [all-recursive] Error 1 [ 485s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 485s] Makefile:469: recipe for target 'all-recursive' failed [ 485s] make[2]: *** [all-recursive] Error 1 [ 485s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 485s] Makefile:401: recipe for target 'all' failed [ 485s] make[1]: *** [all] Error 2 [ 485s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 485s] dh_auto_build: make -j1 returned exit code 2 [ 485s] debian/rules:45: recipe for target 'build' failed [ 485s] make: *** [build] Error 2 [ 485s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 485s] ### VM INTERACTION START ### [ 488s] [ 467.633978] sysrq: SysRq : Power Off [ 488s] [ 467.674255] reboot: Power down [ 489s] ### VM INTERACTION END ### [ 489s] [ 489s] armbuild22 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 07:56:44 UTC 2021. [ 489s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 08:08:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 08:08:10 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <6194b888515dd_5b8b2ac6bd19e610448290@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:latest/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 585s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 585s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 587s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/arm-linux-gnueabihf/libosmovty.so /usr/lib/arm-linux-gnueabihf/libosmoctrl.so /usr/lib/arm-linux-gnueabihf/libosmogsm.so /usr/lib/arm-linux-gnueabihf/libosmocore.so /usr/lib/arm-linux-gnueabihf/libosmoabis.so /usr/lib/arm-linux-gnueabihf/libosmonetif.so /usr/lib/arm-linux-gnueabihf/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/arm-linux-gnueabihf/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/arm-linux-gnueabihf/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 587s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 587s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 587s] collect2: error: ld returned 1 exit status [ 587s] Makefile:483: recipe for target 'osmo-msc' failed [ 587s] make[4]: *** [osmo-msc] Error 1 [ 587s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 587s] Makefile:422: recipe for target 'all-recursive' failed [ 587s] make[3]: *** [all-recursive] Error 1 [ 587s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 587s] Makefile:469: recipe for target 'all-recursive' failed [ 587s] make[2]: *** [all-recursive] Error 1 [ 587s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 587s] Makefile:401: recipe for target 'all' failed [ 587s] make[1]: *** [all] Error 2 [ 587s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 587s] dh_auto_build: make -j1 returned exit code 2 [ 587s] debian/rules:45: recipe for target 'build' failed [ 587s] make: *** [build] Error 2 [ 587s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 587s] ### VM INTERACTION START ### [ 590s] [ 546.550578] sysrq: SysRq : Power Off [ 590s] [ 546.553086] reboot: Power down [ 591s] ### VM INTERACTION END ### [ 591s] [ 591s] obs-arm-5 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 08:08:01 UTC 2021. [ 591s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 08:35:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 08:35:23 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <6194bed579c49_5b8b2ac6bd19e61045905d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 82s] CC smpp_utils.o [ 82s] AR libmsc.a [ 82s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 82s] Making all in osmo-msc [ 82s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 82s] CC msc_main.o [ 82s] CCLD osmo-msc [ 83s] /usr/lib64/gcc/aarch64-suse-linux/11/../../../../aarch64-suse-linux/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_encode': [ 83s] ran_msg_iu.c:(.text+0x1284): undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 83s] collect2: error: ld returned 1 exit status [ 83s] make[3]: *** [Makefile:484: osmo-msc] Error 1 [ 83s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 83s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 83s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 83s] make[1]: *** [Makefile:470: all-recursive] Error 1 [ 83s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 83s] make: *** [Makefile:402: all] Error 2 [ 83s] error: Bad exit status from /var/tmp/rpm-tmp.0Xr5EN (%build) [ 83s] [ 83s] [ 83s] RPM build errors: [ 83s] Bad exit status from /var/tmp/rpm-tmp.0Xr5EN (%build) [ 83s] ### VM INTERACTION START ### [ 87s] [ 64.723393][ T383] sysrq: Power Off [ 87s] [ 64.724015][ T15] reboot: Power down [ 87s] ### VM INTERACTION END ### [ 87s] [ 87s] obs-arm-10 failed "build osmo-msc.spec" at Wed Nov 17 08:35:17 UTC 2021. [ 87s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 09:05:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 09:05:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <6194c5f8c839c_5b8b2ac6bd19e61047011@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/CentOS_8/x86_64 Package network:osmocom:latest/osmo-msc failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 127s] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [ 127s] AR libmsc.a [ 127s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc' [ 127s] Making all in osmo-msc [ 127s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 127s] CC msc_main.o [ 128s] CCLD osmo-msc [ 128s] ../../src/libmsc/libmsc.a(ran_msg_iu.o): In function `ran_iu_make_security_mode_command': [ 128s] /home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 128s] collect2: error: ld returned 1 exit status [ 128s] make[3]: *** [Makefile:484: osmo-msc] Error 1 [ 128s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src/osmo-msc' [ 128s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 128s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0/src' [ 128s] make[1]: *** [Makefile:468: all-recursive] Error 1 [ 128s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-msc-1.8.0' [ 128s] make: *** [Makefile:400: all] Error 2 [ 128s] error: Bad exit status from /var/tmp/rpm-tmp.rwIP0S (%build) [ 128s] [ 128s] [ 128s] RPM build errors: [ 128s] Bad exit status from /var/tmp/rpm-tmp.rwIP0S (%build) [ 128s] ### VM INTERACTION START ### [ 129s] Powering off. [ 129s] [ 102.355018] reboot: Power down [ 130s] ### VM INTERACTION END ### [ 130s] [ 130s] lamb06 failed "build osmo-msc.spec" at Wed Nov 17 09:05:41 UTC 2021. [ 130s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 09:26:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 09:26:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <6194cab342c93_62892ac0fd9586001952d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Raspbian_10/armv7l Package network:osmocom:latest/osmo-msc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 773s] ar: `u' modifier ignored since `D' is the default (see `U') [ 773s] ranlib libmsc.a [ 773s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 773s] Making all in osmo-msc [ 773s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 773s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 774s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 776s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/arm-linux-gnueabihf/libosmovty.so /usr/lib/arm-linux-gnueabihf/libosmoctrl.so /usr/lib/arm-linux-gnueabihf/libosmogsm.so /usr/lib/arm-linux-gnueabihf/libosmocore.so /usr/lib/arm-linux-gnueabihf/libosmoabis.so /usr/lib/arm-linux-gnueabihf/libosmonetif.so /usr/lib/arm-linux-gnueabihf/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/arm-linux-gnueabihf/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/arm-linux-gnueabihf/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 776s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 776s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 776s] collect2: error: ld returned 1 exit status [ 776s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 776s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 776s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 776s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 776s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 776s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 776s] make[1]: *** [Makefile:401: all] Error 2 [ 776s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 776s] dh_auto_build: make -j1 returned exit code 2 [ 776s] make: *** [debian/rules:45: build] Error 2 [ 776s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 776s] ### VM INTERACTION START ### [ 779s] [ 706.414478] sysrq: SysRq : Power Off [ 779s] [ 706.464400] reboot: Power down [ 780s] ### VM INTERACTION END ### [ 780s] [ 780s] obs-arm-5 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 09:25:49 UTC 2021. [ 780s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 09:27:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 09:27:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_10/armv7l In-Reply-To: References: Message-ID: <6194cb2732b2d_62892ac0fd95860020329@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_10/armv7l Package network:osmocom:latest/osmo-msc failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 708s] ar: `u' modifier ignored since `D' is the default (see `U') [ 709s] ranlib libmsc.a [ 709s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 709s] Making all in osmo-msc [ 709s] make[4]: Entering directory '/usr/src/packages/BUILD/src/osmo-msc' [ 709s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -c -o msc_main.o msc_main.c [ 710s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -losmonetif -lsmpp34 -losmo-ranap -ltalloc -lasn1c -losmo-sigtran -losmo-mgcp-client -losmo-gsup-client -ldbi -lsctp [ 711s] libtool: link: gcc -Wall -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=gnu11 -Wl,-z -Wl,relro -o osmo-msc msc_main.o ../../src/libmsc/libmsc.a ../../src/libvlr/libvlr.a /usr/lib/arm-linux-gnueabihf/libosmovty.so /usr/lib/arm-linux-gnueabihf/libosmoctrl.so /usr/lib/arm-linux-gnueabihf/libosmogsm.so /usr/lib/arm-linux-gnueabihf/libosmocore.so /usr/lib/arm-linux-gnueabihf/libosmoabis.so /usr/lib/arm-linux-gnueabihf/libosmonetif.so /usr/lib/arm-linux-gnueabihf/libsmpp34.so -losmo-ranap -ltalloc -lasn1c /usr/lib/arm-linux-gnueabihf/libosmo-sigtran.so -losmo-mgcp-client /usr/lib/arm-linux-gnueabihf/libosmo-gsup-client.so -ldbi -lsctp -pthread [ 711s] /usr/bin/ld: ../../src/libmsc/libmsc.a(ran_msg_iu.o): in function `ran_iu_make_security_mode_command': [ 711s] ./src/libmsc/ran_msg_iu.c:383: undefined reference to `ranap_new_msg_sec_mod_cmd2' [ 711s] collect2: error: ld returned 1 exit status [ 711s] make[4]: *** [Makefile:485: osmo-msc] Error 1 [ 711s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-msc' [ 711s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 711s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 711s] make[2]: *** [Makefile:469: all-recursive] Error 1 [ 711s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 711s] make[1]: *** [Makefile:401: all] Error 2 [ 711s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 711s] dh_auto_build: make -j1 returned exit code 2 [ 711s] make: *** [debian/rules:45: build] Error 2 [ 711s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 711s] ### VM INTERACTION START ### [ 714s] [ 688.898977] sysrq: SysRq : Power Off [ 714s] [ 688.951462] reboot: Power down [ 715s] ### VM INTERACTION END ### [ 715s] [ 715s] armbuild22 failed "build osmo-msc_1.8.0.dsc" at Wed Nov 17 09:27:38 UTC 2021. [ 715s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:11:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:11:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: Always enable dynts sdcch8 tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26295 ) Change subject: bsc: Always enable dynts sdcch8 tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifbbedde9878274d3008290ec69916e28d7adba3b Gerrit-Change-Number: 26295 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:11:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:12:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:12:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_send_all_data_ind In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 ) Change subject: pcu: Drop mp_send_all_data_ind ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20 Gerrit-Change-Number: 26301 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:12:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:13:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:13:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_osmo_pcu_newer_than_0_9_0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26302 ) Change subject: pcu: Drop mp_osmo_pcu_newer_than_0_9_0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife37fc92c5b1ebf7e87b66c136ae900f44861510 Gerrit-Change-Number: 26302 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:13:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:14:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:14:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: stp: Drop mp_osmo_stp_newer_than_1_4_0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26303 ) Change subject: stp: Drop mp_osmo_stp_newer_than_1_4_0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a24b44be77d5ab615b833dda418748fb162fc3d Gerrit-Change-Number: 26303 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:14:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:14:57 +0000 Subject: Change in docker-playground[master]: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26296 ) Change subject: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I560cb7d0ab61b5373982160032040a65dc043ce4 Gerrit-Change-Number: 26296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:14:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:15:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:15:23 +0000 Subject: Change in docker-playground[master]: ttcn3-sgsn: latest osmo-sgsn release supports RIM In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26297 ) Change subject: ttcn3-sgsn: latest osmo-sgsn release supports RIM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I803514a28491ebe142691062f6033f179474b064 Gerrit-Change-Number: 26297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:15:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:15:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:15:43 +0000 Subject: Change in docker-playground[master]: ttcn3-sip: Don't force mncc version 7 for latest In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26298 ) Change subject: ttcn3-sip: Don't force mncc version 7 for latest ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iff2bcbfb3e84140cccdf93b0924ede09e44793b0 Gerrit-Change-Number: 26298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:15:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:16:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:16:13 +0000 Subject: Change in docker-playground[master]: ttcn3-pcu: Update config for latest after new osmo-pcu release In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26299 ) Change subject: ttcn3-pcu: Update config for latest after new osmo-pcu release ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b Gerrit-Change-Number: 26299 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:16:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:16:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 10:16:26 +0000 Subject: Change in docker-playground[master]: ttcn3-stp: osmo-stp in master is >1.4.0 now In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26300 ) Change subject: ttcn3-stp: osmo-stp in master is >1.4.0 now ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I354c1487d9a32e2c7d48c57e7b63007f5360677e Gerrit-Change-Number: 26300 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 17 Nov 2021 10:16:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:33 +0000 Subject: Change in docker-playground[master]: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26296 ) Change subject: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I560cb7d0ab61b5373982160032040a65dc043ce4 Gerrit-Change-Number: 26296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:36:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:37 +0000 Subject: Change in docker-playground[master]: ttcn3-sgsn: latest osmo-sgsn release supports RIM In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26297 ) Change subject: ttcn3-sgsn: latest osmo-sgsn release supports RIM ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I803514a28491ebe142691062f6033f179474b064 Gerrit-Change-Number: 26297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:36:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:42 +0000 Subject: Change in docker-playground[master]: ttcn3-sip: Don't force mncc version 7 for latest In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26298 ) Change subject: ttcn3-sip: Don't force mncc version 7 for latest ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iff2bcbfb3e84140cccdf93b0924ede09e44793b0 Gerrit-Change-Number: 26298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:36:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:46 +0000 Subject: Change in docker-playground[master]: ttcn3-pcu: Update config for latest after new osmo-pcu release In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26299 ) Change subject: ttcn3-pcu: Update config for latest after new osmo-pcu release ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b Gerrit-Change-Number: 26299 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:36:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:50 +0000 Subject: Change in docker-playground[master]: ttcn3-stp: osmo-stp in master is >1.4.0 now In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26300 ) Change subject: ttcn3-stp: osmo-stp in master is >1.4.0 now ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I354c1487d9a32e2c7d48c57e7b63007f5360677e Gerrit-Change-Number: 26300 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:36:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:52 +0000 Subject: Change in docker-playground[master]: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26296 ) Change subject: ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest ...................................................................... ttcn3-bsc-test: Leave mp_enable_dyn_sdcch8_test enabled in latest Release 1.8.0 is already released, so latest should support this. Change-Id: I560cb7d0ab61b5373982160032040a65dc043ce4 --- M ttcn3-bsc-test/BSC_Tests.cfg M ttcn3-bsc-test/jenkins-sccplite.sh M ttcn3-bsc-test/jenkins.sh M ttcn3-bsc-test/sccplite/BSC_Tests.cfg 4 files changed, 0 insertions(+), 12 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved; Verified diff --git a/ttcn3-bsc-test/BSC_Tests.cfg b/ttcn3-bsc-test/BSC_Tests.cfg index 8ec9409..80e06ee 100644 --- a/ttcn3-bsc-test/BSC_Tests.cfg +++ b/ttcn3-bsc-test/BSC_Tests.cfg @@ -12,7 +12,6 @@ [MODULE_PARAMETERS] BSC_Tests.mp_bsc_ip := "172.18.2.20"; BSC_Tests.mp_test_ip := "172.18.2.203"; -BSC_Tests.mp_enable_dyn_sdcch8_test := true; BSC_Tests.mp_bssap_cfg := { { transport := BSSAP_TRANSPORT_AoIP, diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index 7fb0525..bc6eaa0 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -16,11 +16,6 @@ mkdir $VOL_BASE_DIR/bsc-tester cp sccplite/BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ -# Dynamic TS SDCCH8 must be disabled until release AFTER osmo-bsc 1.7.0 is tagged -if image_suffix_is_latest; then - sed "s/BSC_Tests.mp_enable_dyn_sdcch8_test := true;/BSC_Tests.mp_enable_dyn_sdcch8_test := false;/g" -i $VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg -fi - mkdir $VOL_BASE_DIR/bsc cp sccplite/osmo-bsc.cfg $VOL_BASE_DIR/bsc/ diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index dfa1f6f..18236a2 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -14,11 +14,6 @@ mkdir $VOL_BASE_DIR/bsc-tester cp BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ -# Dynamic TS SDCCH8 must be disabled until release AFTER osmo-bsc 1.7.0 is tagged -if image_suffix_is_latest; then - sed "s/BSC_Tests.mp_enable_dyn_sdcch8_test := true;/BSC_Tests.mp_enable_dyn_sdcch8_test := false;/g" -i $VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg -fi - mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-bsc-test/sccplite/BSC_Tests.cfg b/ttcn3-bsc-test/sccplite/BSC_Tests.cfg index d5f8bd7..5103e2e 100644 --- a/ttcn3-bsc-test/sccplite/BSC_Tests.cfg +++ b/ttcn3-bsc-test/sccplite/BSC_Tests.cfg @@ -12,7 +12,6 @@ [MODULE_PARAMETERS] BSC_Tests.mp_bsc_ip := "172.18.12.20"; BSC_Tests.mp_test_ip := "172.18.12.203"; -BSC_Tests.mp_enable_dyn_sdcch8_test := true; BSC_Tests.mp_bssap_cfg := { { transport := BSSAP_TRANSPORT_SCCPlite_SERVER, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I560cb7d0ab61b5373982160032040a65dc043ce4 Gerrit-Change-Number: 26296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:52 +0000 Subject: Change in docker-playground[master]: ttcn3-sgsn: latest osmo-sgsn release supports RIM In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26297 ) Change subject: ttcn3-sgsn: latest osmo-sgsn release supports RIM ...................................................................... ttcn3-sgsn: latest osmo-sgsn release supports RIM osmo-sgsn 1.8.0 supporting the VTY commands was released, so no need to drop those. Change-Id: I803514a28491ebe142691062f6033f179474b064 --- M ttcn3-sgsn-test/jenkins.sh 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Verified diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh index 7bb7afd..df500af 100755 --- a/ttcn3-sgsn-test/jenkins.sh +++ b/ttcn3-sgsn-test/jenkins.sh @@ -24,13 +24,6 @@ mkdir $VOL_BASE_DIR/unix -# Disable until osmo-sgsn.git release > 1.7.0 is available -if image_suffix_is_latest; then - sed "/mme test-mme0/d" -i $VOL_BASE_DIR/sgsn/osmo-sgsn.cfg - sed "/gtp remote-ip/d" -i $VOL_BASE_DIR/sgsn/osmo-sgsn.cfg - sed "/gtp ran-info-relay/d" -i $VOL_BASE_DIR/sgsn/osmo-sgsn.cfg -fi - echo Starting container with STP docker run --rm \ $(docker_network_params $SUBNET 200) \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I803514a28491ebe142691062f6033f179474b064 Gerrit-Change-Number: 26297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:52 +0000 Subject: Change in docker-playground[master]: ttcn3-sip: Don't force mncc version 7 for latest In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26298 ) Change subject: ttcn3-sip: Don't force mncc version 7 for latest ...................................................................... ttcn3-sip: Don't force mncc version 7 for latest osmo-sip-connector 1.6.0 supporting latest mncc version was released. Change-Id: Iff2bcbfb3e84140cccdf93b0924ede09e44793b0 --- M ttcn3-sip-test/jenkins.sh 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Verified diff --git a/ttcn3-sip-test/jenkins.sh b/ttcn3-sip-test/jenkins.sh index 3e8fb94..ffec3d2 100755 --- a/ttcn3-sip-test/jenkins.sh +++ b/ttcn3-sip-test/jenkins.sh @@ -16,13 +16,6 @@ mkdir $VOL_BASE_DIR/sip-tester/unix cp SIP_Tests.cfg $VOL_BASE_DIR/sip-tester/ -# TODO: remove this block once we release a new version of the SUT -if image_suffix_is_latest; then - # Use MNCCv7 for the '-latest' - sed -i "/MODULE_PARAMETERS/a MNCC_Emulation.mp_mncc_version := 7" \ - "$VOL_BASE_DIR/sip-tester/SIP_Tests.cfg" -fi - mkdir $VOL_BASE_DIR/sip mkdir $VOL_BASE_DIR/sip/unix cp osmo-sip-connector.cfg $VOL_BASE_DIR/sip/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iff2bcbfb3e84140cccdf93b0924ede09e44793b0 Gerrit-Change-Number: 26298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:52 +0000 Subject: Change in docker-playground[master]: ttcn3-pcu: Update config for latest after new osmo-pcu release In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26299 ) Change subject: ttcn3-pcu: Update config for latest after new osmo-pcu release ...................................................................... ttcn3-pcu: Update config for latest after new osmo-pcu release New osmo-pcu 1.0.0 which supports all expected features. Hence we can drop special quirks to have tests passing in latest. Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b --- M ttcn3-pcu-test/PCU_Tests.cfg M ttcn3-pcu-test/jenkins.sh M ttcn3-pcu-test/osmo-pcu.cfg 3 files changed, 0 insertions(+), 17 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved; Verified diff --git a/ttcn3-pcu-test/PCU_Tests.cfg b/ttcn3-pcu-test/PCU_Tests.cfg index cb37ee7..40b8e2c 100644 --- a/ttcn3-pcu-test/PCU_Tests.cfg +++ b/ttcn3-pcu-test/PCU_Tests.cfg @@ -14,7 +14,6 @@ [MODULE_PARAMETERS] PCU_Tests.mp_pcu_sock_path := "/data/unix/pcu_bts" PCU_Tests.mp_pcu_statsd_ip := "172.18.13.10" -PCU_Tests.mp_ctrl_neigh_ip := "172.18.13.10"; SGSN_Components.mp_nsconfig := { nsei := 1234, handle_sns := false, @@ -36,8 +35,6 @@ } } Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoPCU"; -PCUIF_Components.mp_send_all_data_ind := true; -PCU_Tests.mp_osmo_pcu_newer_than_0_9_0 := true; [MAIN_CONTROLLER] diff --git a/ttcn3-pcu-test/jenkins.sh b/ttcn3-pcu-test/jenkins.sh index 0bbfb31..11c77ad 100755 --- a/ttcn3-pcu-test/jenkins.sh +++ b/ttcn3-pcu-test/jenkins.sh @@ -16,22 +16,9 @@ mkdir $VOL_BASE_DIR/pcu-tester/unix cp PCU_Tests.cfg $VOL_BASE_DIR/pcu-tester/ -# Disable until osmo-pcu release > 0.9.0 -if image_suffix_is_latest; then - cfg="$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" - sed -i "s/^PCUIF_Components.mp_send_all_data_ind.*/PCUIF_Components.mp_send_all_data_ind := false;/" "$cfg" - sed -i "s/^PCU_Tests.mp_osmo_pcu_newer_than_0_9_0.*/PCU_Tests.mp_osmo_pcu_newer_than_0_9_0 := false;/" "$cfg" -else - sed "/PCU_Tests.mp_ctrl_neigh_ip/d" -i "$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" -fi - mkdir $VOL_BASE_DIR/pcu mkdir $VOL_BASE_DIR/pcu/unix cp osmo-pcu.cfg $VOL_BASE_DIR/pcu/ -# Disable until osmo-pcu release > 0.9.0 -if image_suffix_is_master; then - sed "/neighbor resolution/d" -i "$VOL_BASE_DIR/pcu/osmo-pcu.cfg" -fi mkdir $VOL_BASE_DIR/unix diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index 3d60d93..733cebe 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -32,7 +32,6 @@ alpha 0 gamma 0 pcu-socket /data/unix/pcu_bts - neighbor resolution 172.18.13.10 gsmtap-category dl-unknown gsmtap-category dl-dummy gsmtap-category dl-ctrl -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ieb85dac479e6960e4160767e514084b80edd297b Gerrit-Change-Number: 26299 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:53 +0000 Subject: Change in docker-playground[master]: ttcn3-stp: osmo-stp in master is >1.4.0 now In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26300 ) Change subject: ttcn3-stp: osmo-stp in master is >1.4.0 now ...................................................................... ttcn3-stp: osmo-stp in master is >1.4.0 now osmo-stp 1.5.0 was released today, so we can drop those specific checks. Change-Id: I354c1487d9a32e2c7d48c57e7b63007f5360677e --- M ttcn3-stp-test/jenkins.sh 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Verified diff --git a/ttcn3-stp-test/jenkins.sh b/ttcn3-stp-test/jenkins.sh index 8cf65ce..db2ffdd 100755 --- a/ttcn3-stp-test/jenkins.sh +++ b/ttcn3-stp-test/jenkins.sh @@ -15,11 +15,6 @@ mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ -# Disable until osmo-stp release > 1.4.0 -if image_suffix_is_latest; then - sed -i "s/^STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0.*/STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0 := false;/" $VOL_BASE_DIR/stp-tester/STP_Tests.cfg -fi - SUBNET=19 network_create $SUBNET -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I354c1487d9a32e2c7d48c57e7b63007f5360677e Gerrit-Change-Number: 26300 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:36:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:36:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: Always enable dynts sdcch8 tests In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26295 ) Change subject: bsc: Always enable dynts sdcch8 tests ...................................................................... bsc: Always enable dynts sdcch8 tests Release 1.8.0 is already released, so latest should support this. Change-Id: Ifbbedde9878274d3008290ec69916e28d7adba3b --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 229f8d6..5f1217b 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -705,10 +705,6 @@ }; boolean mp_enable_lcs_tests := true; - /* Whether to enable dyn TS SDCCH8 tests. Can be dropped completely and enable - unconditionally once new version of osmo-bsc is released (current - version: 1.7.0) */ - boolean mp_enable_dyn_sdcch8_test := true; /* Value set in osmo-bsc.cfg "ms max power" */ uint8_t mp_exp_ms_power_level := 7; } @@ -10872,12 +10868,10 @@ execute( TC_dyn_pdch_ipa_act_nack() ); execute( TC_dyn_pdch_osmo_act_deact() ); execute( TC_dyn_pdch_osmo_act_nack() ); - if (mp_enable_dyn_sdcch8_test) { - execute( TC_dyn_ts_sdcch8_act_deact() ); - execute( TC_dyn_ts_sdcch8_all_subslots_used() ); - execute( TC_dyn_ts_sdcch8_tch_call_act_deact() ); - execute( TC_dyn_ts_sdcch8_act_nack() ); - } + execute( TC_dyn_ts_sdcch8_act_deact() ); + execute( TC_dyn_ts_sdcch8_all_subslots_used() ); + execute( TC_dyn_ts_sdcch8_tch_call_act_deact() ); + execute( TC_dyn_ts_sdcch8_act_nack() ); execute( TC_chopped_ipa_ping() ); execute( TC_chopped_ipa_payload() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifbbedde9878274d3008290ec69916e28d7adba3b Gerrit-Change-Number: 26295 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:37:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:37:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_send_all_data_ind In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 ) Change subject: pcu: Drop mp_send_all_data_ind ...................................................................... pcu: Drop mp_send_all_data_ind osmo-pcu 1.0.0 was released, so we can drop references to older osmo-pcu versions. Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20 --- M pcu/PCUIF_Components.ttcn 1 file changed, 4 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn index 30982da..030da05 100644 --- a/pcu/PCUIF_Components.ttcn +++ b/pcu/PCUIF_Components.ttcn @@ -50,10 +50,6 @@ * +---------------------------+ */ -modulepar { - boolean mp_send_all_data_ind := true; -} - /* Events are used by the components to indicate that something * has happened, e.g. we have got a connection from the PCU. */ type enumerated RAW_PCU_EventType { @@ -419,11 +415,9 @@ //log(prefix, "DATA.ind (len=0)"); } - if (use_msg or mp_send_all_data_ind) { - PCUIF.send(pcu_msg); /* Send to the PCU and notify the TC */ - if (use_msg) { - TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, fn)); - } + PCUIF.send(pcu_msg); /* Send to the PCU and notify the TC */ + if (use_msg) { + TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, fn)); } } } @@ -513,9 +507,7 @@ }); const integer start_fn := 0; - if (mp_send_all_data_ind) { - f_tx_first_data_ind(bts_nr, info_ind, start_fn); - } + f_tx_first_data_ind(bts_nr, info_ind, start_fn); /* Notify the test case that we're done with SI13 */ TC.send(ts_RAW_PCU_EV(BTS_EV_SI13_NEGO)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20 Gerrit-Change-Number: 26301 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:37:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:37:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_osmo_pcu_newer_than_0_9_0 In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26302 ) Change subject: pcu: Drop mp_osmo_pcu_newer_than_0_9_0 ...................................................................... pcu: Drop mp_osmo_pcu_newer_than_0_9_0 osmo-pcu 1.0.0 was released, so we can drop references to older osmo-pcu versions. Change-Id: Ife37fc92c5b1ebf7e87b66c136ae900f44861510 --- M pcu/PCU_Tests.ttcn 1 file changed, 142 insertions(+), 183 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index d7ab69b..7fcab4a 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -71,8 +71,6 @@ charstring mp_ctrl_neigh_ip := ""; /* Use new PCUIF over IPA multiplex for Neigh Addr Resolution */ integer mp_ctrl_neigh_port := 4248; - - boolean mp_osmo_pcu_newer_than_0_9_0 := true; /* Drop after OsmoPCU > 0.9.0 was released */ } @@ -465,14 +463,8 @@ /* Make sure we don't receive data for that TBF since it was released * before. Also check our TBF is not polled for UL. */ f_pcuif_rx_data_req_pdtch(data_msg); - if (mp_osmo_pcu_newer_than_0_9_0 and data_msg.dl_block == omit) { + if (data_msg.dl_block == omit) { /* IDLE block, expected on new PCU versions */ - } else if (not mp_osmo_pcu_newer_than_0_9_0 and match(data_msg.dl_block, tr_RLCMAC_DUMMY_CTRL())) { - /* Dummy RLCMAC block, expected on older PCU versions */ - if (data_msg.dl_block.ctrl.mac_hdr.usf != USF_UNUSED) { - setverdict(fail, "Unexpected USF ", data_msg.dl_block.ctrl.mac_hdr.usf); - f_shutdown(__BFILE__, __LINE__); - } } else { setverdict(fail, "Unexpected dl_block", data_msg.dl_block); f_shutdown(__BFILE__, __LINE__); @@ -620,16 +612,10 @@ [] BTS.receive(tr_PCUIF_DATA_PTCCH(0, tr_PCUIF_DATA(0, 7, sapi := PCU_IF_SAPI_PTCCH), omit)) { - if (not mp_osmo_pcu_newer_than_0_9_0) { - setverdict(fail, "Expected PTCCH/D block instead of IDLE block"); - f_shutdown(__BFILE__, __LINE__); - } } [] as_rx_ptcch(pcu_msg, tr_PTCCHDownlinkMsg) { - if (mp_osmo_pcu_newer_than_0_9_0) { - setverdict(fail, "Expected IDLE block instead of PTCCH/D block"); - f_shutdown(__BFILE__, __LINE__); - } + setverdict(fail, "Expected IDLE block instead of PTCCH/D block"); + f_shutdown(__BFILE__, __LINE__); } [] BTS.receive(PCUIF_Message:?) { repeat; } [] T.timeout { @@ -1535,7 +1521,7 @@ } /* We may already receive empty (idle) blocks before our own TTCN3 timer * triggers due to the TBF being released. Keep going until our T_3169 triggers. */ - [mp_osmo_pcu_newer_than_0_9_0 and n3101 == N3101_MAX + 1] as_pcuif_rx_ignore_empty(nr); + [n3101 == N3101_MAX + 1] as_pcuif_rx_ignore_empty(nr); [] T_3169.timeout { log("T_3169 expired"); /* Done in alt */ @@ -1999,17 +1985,12 @@ } /* We may already receive idle blocks before our own TTCN3 timer * triggers due to the TBF being released. Keep going until our T_3195 triggers. */ - [mp_osmo_pcu_newer_than_0_9_0 and N3105 == N3105_MAX] as_pcuif_rx_ignore_empty(nr); + [N3105 == N3105_MAX] as_pcuif_rx_ignore_empty(nr); [T_3195.running] T_3195.timeout { log("T_3195 timeout"); /* Done in alt, wait for pending RTS initiated previously in - * above case before continuing (expect empty blocks on new - * versions, Dummy block on older versions): */ - if (mp_osmo_pcu_newer_than_0_9_0) { - dl_block_exp := omit; - } else { - dl_block_exp := tr_RLCMAC_DUMMY_CTRL; - } + * above case before continuing (expect empty block): */ + dl_block_exp := omit; BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), dl_block_exp)); @@ -2488,21 +2469,19 @@ f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } testcase TC_mo_ping_pong_with_ul_racap_egprs_only() runs on RAW_PCU_Test_CT { @@ -2510,21 +2489,20 @@ var template (present) CodingScheme exp_dl_cs_mcs := mcs_egprs_any; f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_default, ms_racap_egprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } testcase TC_force_two_phase_access() runs on RAW_PCU_Test_CT { @@ -2536,21 +2514,19 @@ f_TC_mo_ping_pong_2phase_access(c_PCUIF_Flags_noMCS, ms_racap_gprs_def, exp_ul_cs_mcs, exp_dl_cs_mcs); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } /* Test scenario where SGSN wants to send some data against MS and it is @@ -3246,21 +3222,19 @@ /* ACK the ACK */ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.pkt.ul_assignment", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3598,16 +3572,14 @@ f_pcuif_rx_pch_pag_req1(tr_MI_IMSI(imsi), imsi_suff_tx); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.pcu.sgsn.0.rx_paging_ps", mtype := "c", min := 1, max := 1 }, - /* After the PCU receives the paging request from SGSN, - * and it doesn't have any errors, PCU sends it to the - * BTS to do paging over PCH. */ - { name := "TTCN3.bts.0.pch.requests", mtype := "c", min := 1, max := 1 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.pcu.sgsn.0.rx_paging_ps", mtype := "c", min := 1, max := 1 }, + /* After the PCU receives the paging request from SGSN, + * and it doesn't have any errors, PCU sends it to the + * BTS to do paging over PCH. */ + { name := "TTCN3.bts.0.pch.requests", mtype := "c", min := 1, max := 1 } + }; + f_statsd_expect(expect); } testcase TC_paging_ps_from_sgsn_sign_ptmsi() runs on RAW_PCU_Test_CT { @@ -3873,20 +3845,18 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3924,20 +3894,18 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -3973,20 +3941,18 @@ f_TC_egprs_pkt_chan_req(req, imm_ass); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -4054,19 +4020,17 @@ f_TC_egprs_pkt_chan_req_reject('111111'B & ext_ra, 1337 + i, rest); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -4099,19 +4063,17 @@ f_TC_egprs_pkt_chan_req_reject(ra11, 1337 + i, rest); } - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := num_req, max := num_req }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -4155,22 +4117,20 @@ /* At this point, the IUT should run out of free USFs */ f_TC_egprs_pkt_chan_req_reject(ra11, 1870, rest, wi := info_ind.t3142); - if (mp_osmo_pcu_newer_than_0_9_0) { - var StatsDExpects expect := { - { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 8, max := 8 }, - { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 8, max := 8 }, - { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 8, max := 8 }, - { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 7, max := 7 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 7, max := 7 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, - { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := 1, max := 1 }, - { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } - }; - f_statsd_expect(expect); - } + var StatsDExpects expect := { + { name := "TTCN3.bts.0.rach.requests", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.11bit", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.one_phase", mtype := "c", min := 8, max := 8 }, + { name := "TTCN3.bts.0.rach.requests.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.rach.requests.unexpected", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_UL", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.one_phase", mtype := "c", min := 7, max := 7 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.two_phase", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_ul.contention_resolution_success", mtype := "c", min := 0, max := 0 }, + { name := "TTCN3.bts.0.immediate.assignment_rej", mtype := "c", min := 1, max := 1 }, + { name := "TTCN3.bts.0.immediate.assignment_DL", mtype := "c", min := 0, max := 0 } + }; + f_statsd_expect(expect); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -6762,9 +6722,8 @@ execute( TC_paging_ps_from_sgsn_sign_ptmsi() ); execute( TC_paging_ps_from_sgsn_sign() ); execute( TC_paging_ps_from_sgsn_ptp() ); - if (mp_osmo_pcu_newer_than_0_9_0) { - execute( TC_paging_pch_timeout() ); - } + execute( TC_paging_pch_timeout() ); + execute( TC_paging_cs_multi_ms_imsi_tmsi() ); execute( TC_paging_cs_multi_ms_imsi() ); execute( TC_paging_cs_multi_ms_tmsi() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife37fc92c5b1ebf7e87b66c136ae900f44861510 Gerrit-Change-Number: 26302 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:37:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:37:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: stp: Drop mp_osmo_stp_newer_than_1_4_0 In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26303 ) Change subject: stp: Drop mp_osmo_stp_newer_than_1_4_0 ...................................................................... stp: Drop mp_osmo_stp_newer_than_1_4_0 osmo-stp 1.5.0 has been released, so we can drop this. Change-Id: I9a24b44be77d5ab615b833dda418748fb162fc3d --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 8 insertions(+), 23 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 1c3b01d..31bab93 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -72,9 +72,6 @@ }; integer mp_recovery_timeout_msec := 2000; charstring mp_sccp_service_type := "mtp3_itu"; - - /* is osmo-stp newer than 1.4.0? */ - boolean mp_osmo_stp_newer_than_1_4_0 := true; } type record M3uaConfig { @@ -1019,18 +1016,8 @@ execute( TC_rkm_reg_static_notpermitted() ); execute( TC_rkm_reg_static_permitted() ); execute( TC_rkm_reg_dynamic_permitted() ); - /* This test has never passed in osmo-stp <= 1.4.0, because it needs - * patch Ie5d84d06e7d5d32c8a22f770f71a5449f4a78484 which was added - * afterwards. Disable the test for <= 1.4.0, because the test does not - * clean up properly and - after other tests were extended - they are - * now failing in this not properly cleaned up state. After some hours - * of figuring out that it is definitively this test and trying to - * figure out what exactly is not cleaning up properly, I decided to - * just temporarily disable the test for -latest instead of spending - * even more time on it. */ - if (mp_osmo_stp_newer_than_1_4_0) { - execute( TC_rkm_unreg_never_registered() ); - } + execute( TC_rkm_unreg_never_registered() ); + execute( TC_rkm_unreg_invalid() ); execute( TC_rkm_unreg_registered() ); execute( TC_rkm_unreg_active() ); @@ -1044,14 +1031,12 @@ execute( TC_clnt_sg_to_asp() ); execute( TC_clnt_asp_to_sg() ); - /* remove the condition if osmo-stp > 1.4.0 is released */ - if (mp_osmo_stp_newer_than_1_4_0) { - execute( TC_clnt_quirk_no_notify_asp_act() ); - execute( TC_clnt_no_daud_in_asp() ); - execute( TC_clnt_quirk_daud_in_asp() ); - execute( TC_clnt_no_snm_inactive() ); - execute( TC_clnt_quirk_snm_inactive() ); - } + execute( TC_clnt_quirk_no_notify_asp_act() ); + execute( TC_clnt_no_daud_in_asp() ); + execute( TC_clnt_quirk_daud_in_asp() ); + execute( TC_clnt_no_snm_inactive() ); + execute( TC_clnt_quirk_snm_inactive() ); + /* M3UA SSNM tests */ execute( TC_ssnm_aspac_dava_aspia_duna() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a24b44be77d5ab615b833dda418748fb162fc3d Gerrit-Change-Number: 26303 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:38:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:38:18 +0000 Subject: Change in libosmocore[master]: .gitignore: add utils/osmo-aka-verify binary In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26304 ) Change subject: .gitignore: add utils/osmo-aka-verify binary ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic7c69ee69f83a25d1ecec38dce7ea5f426e99a2d Gerrit-Change-Number: 26304 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:38:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:39:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:39:02 +0000 Subject: Change in libosmocore[master]: tests/tdef: rename the binaries to end with '_test' In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26305 ) Change subject: tests/tdef: rename the binaries to end with '_test' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I828fa45132e11a41c527d4b25df850c19871cb75 Gerrit-Change-Number: 26305 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:39:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:39:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:39:15 +0000 Subject: Change in libosmocore[master]: tdef: fix wrong path in documentation: tests/vty -> tests/tdef In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26306 ) Change subject: tdef: fix wrong path in documentation: tests/vty -> tests/tdef ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ba9a7a0ba9ad440c879d6a1da110d2fda49eb23 Gerrit-Change-Number: 26306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:39:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:43:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Nov 2021 10:43:56 +0000 Subject: Change in osmo-ci[master]: OBS: latest: enable osmo-hnodeb References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26312 ) Change subject: OBS: latest: enable osmo-hnodeb ...................................................................... OBS: latest: enable osmo-hnodeb Enable osmo-hnodeb for latest, now that we have a tagged version. Change-Id: I3037a43280dbb56ecaf4f2e067f0a1533d19d10a --- M scripts/osmocom-latest-packages.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/26312/1 diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index e218f1e..fa02c40 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -194,6 +194,7 @@ checkout osmo-smlc checkout osmo-cbc checkout osmo-gbproxy + checkout osmo-hnodeb cd "$TOP" @@ -231,6 +232,7 @@ build osmo-smlc build osmo-cbc build osmo-gbproxy + build osmo-hnodeb cd "$TOP/$PROJ" osc ci -m "$FEED versions of $DT" --noservice -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3037a43280dbb56ecaf4f2e067f0a1533d19d10a Gerrit-Change-Number: 26312 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:57:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:57:18 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E8=2E0=2E1-d5ce4_=E2=86=92_1=2E1=2E0?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26313 ) Change subject: Bump version: 0.8.0.1-d5ce4 ? 1.1.0 ...................................................................... Bump version: 0.8.0.1-d5ce4 ? 1.1.0 Bump version to overcome a previous out-of-master tag 1.0.0 which is messing some builds and creating confusion. Let's have a new 1.1.0 release tag on master. Change-Id: I53c25e74ece6fe22c6e29bf2dd4e223e49491888 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/13/26313/1 diff --git a/debian/changelog b/debian/changelog index bfdcb95..93593f0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-iuh (1.1.0) unstable; urgency=medium + + * gitignore: Ignore libsmo-{hnbap,rua}.pc + + -- Pau Espin Pedrol Wed, 17 Nov 2021 11:56:26 +0100 + osmo-iuh (0.8.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I53c25e74ece6fe22c6e29bf2dd4e223e49491888 Gerrit-Change-Number: 26313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:58:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Nov 2021 10:58:20 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E8=2E0=2E1-d5ce4_=E2=86=92_1=2E1=2E0?= In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26313 ) Change subject: Bump version: 0.8.0.1-d5ce4 ? 1.1.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I53c25e74ece6fe22c6e29bf2dd4e223e49491888 Gerrit-Change-Number: 26313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 17 Nov 2021 10:58:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:59:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 10:59:35 +0000 Subject: Change in osmo-ci[master]: OBS: latest: enable osmo-hnodeb In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26312 ) Change subject: OBS: latest: enable osmo-hnodeb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3037a43280dbb56ecaf4f2e067f0a1533d19d10a Gerrit-Change-Number: 26312 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 10:59:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 10:59:52 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Nov 2021 10:59:52 +0000 Subject: Change in osmo-ci[master]: OBS: latest: enable osmo-hnodeb In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26312 ) Change subject: OBS: latest: enable osmo-hnodeb ...................................................................... OBS: latest: enable osmo-hnodeb Enable osmo-hnodeb for latest, now that we have a tagged version. Change-Id: I3037a43280dbb56ecaf4f2e067f0a1533d19d10a --- M scripts/osmocom-latest-packages.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index e218f1e..fa02c40 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -194,6 +194,7 @@ checkout osmo-smlc checkout osmo-cbc checkout osmo-gbproxy + checkout osmo-hnodeb cd "$TOP" @@ -231,6 +232,7 @@ build osmo-smlc build osmo-cbc build osmo-gbproxy + build osmo-hnodeb cd "$TOP/$PROJ" osc ci -m "$FEED versions of $DT" --noservice -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3037a43280dbb56ecaf4f2e067f0a1533d19d10a Gerrit-Change-Number: 26312 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:01:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:01:18 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26307/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26307/1/src/bitvec.c at 479 PS1, Line 479: uint64_t bitvec_read_field(struct bitvec *bv, unsigned int *read_index, unsigned int len) I'm not really liking the idea of using errno in non libc code. I'd rather return (uint64_t)-1 in case of errnor, and document 0xfffffff(...)ff is returned in case of error. If others still think using errno is fine, then I'm OK with it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 11:01:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:01:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:01:36 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E8=2E0=2E1-d5ce4_=E2=86=92_1=2E1=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26313 ) Change subject: Bump version: 0.8.0.1-d5ce4 ? 1.1.0 ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I53c25e74ece6fe22c6e29bf2dd4e223e49491888 Gerrit-Change-Number: 26313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 17 Nov 2021 11:01:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:02:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:02:33 +0000 Subject: Change in libosmocore[master]: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26270 ) Change subject: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id20871b76c4a5801defb4f534fad635b7f079a13 Gerrit-Change-Number: 26270 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 11:02:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:02:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:02:48 +0000 Subject: Change in osmo-pcap[master]: debian/control: minimum version for libzmq3-dev is 3.2.2 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26269 ) Change subject: debian/control: minimum version for libzmq3-dev is 3.2.2 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If76b4fcb8863ad5468a77113ad25142fe1145cda Gerrit-Change-Number: 26269 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 11:02:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:06:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:06:34 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26308 ) Change subject: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c at 485 PS1, Line 485: if (len && bytenum_from_bitnum(*read_index + len - 1) >= bv->data_len) { why this -1? https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c at 494 PS1, Line 494: int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); I'd rather still keep the error checking here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Gerrit-Change-Number: 26308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 11:06:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:13:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:13:31 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c at 495 PS1, Line 495: unsigned int bitnum = 7 - (bv->cur_bit % 8); Calling it bitnum is confusing here, I'd rather call it bitnum_shift or alike. https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c at 497 PS1, Line 497: if (bv->data[bytenum] & (1 << bitnum)) You could also optimize and get rid of this branch: bit = bv->data[bytenum] & (1 << bitnum); shift = (len - i - 1); ui |= ((uint64_t)bit << shift); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 11:13:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:14:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:14:33 +0000 Subject: Change in libosmocore[master]: tests/testsuite.at: ensure empty stderr for the bitvec_test In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26310 ) Change subject: tests/testsuite.at: ensure empty stderr for the bitvec_test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia82b92eddb18dc596881abcef2f098dc7385538b Gerrit-Change-Number: 26310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 11:14:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:14:52 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:14:52 +0000 Subject: =?UTF-8?Q?Change_in_osmo-iuh=5Bmaster=5D=3A_Bump_version=3A_0=2E8=2E0=2E1-d5ce4_=E2=86=92_1=2E1=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26313 ) Change subject: Bump version: 0.8.0.1-d5ce4 ? 1.1.0 ...................................................................... Bump version: 0.8.0.1-d5ce4 ? 1.1.0 Bump version to overcome a previous out-of-master tag 1.0.0 which is messing some builds and creating confusion. Let's have a new 1.1.0 release tag on master. Change-Id: I53c25e74ece6fe22c6e29bf2dd4e223e49491888 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Verified Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index bfdcb95..93593f0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-iuh (1.1.0) unstable; urgency=medium + + * gitignore: Ignore libsmo-{hnbap,rua}.pc + + -- Pau Espin Pedrol Wed, 17 Nov 2021 11:56:26 +0100 + osmo-iuh (0.8.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I53c25e74ece6fe22c6e29bf2dd4e223e49491888 Gerrit-Change-Number: 26313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 11:17:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 11:17:10 +0000 Subject: Change in libosmocore[master]: tests/vty: fix use of GNU 'missing =' extension in designator In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26311 ) Change subject: tests/vty: fix use of GNU 'missing =' extension in designator ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I66edb247898594b51cc9d7c1b3d0c60ba66fc637 Gerrit-Change-Number: 26311 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 11:17:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 12:35:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 12:35:54 +0000 Subject: Change in meta-telephony[201705]: Update Osmocom recipes to latest tags (release 202111) References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/26314 ) Change subject: Update Osmocom recipes to latest tags (release 202111) ...................................................................... Update Osmocom recipes to latest tags (release 202111) Change-Id: I774dbdc4654c57d217664e94f02d72fbea76d791 --- M recipes-osmocom/libosmo-abis/libosmo-abis_git.bb M recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb M recipes-osmocom/libosmocore/libosmocore_git.bb M recipes-osmocom/openbsc/openbsc_git.bb M recipes-osmocom/osmo-bsc/osmo-bsc_git.bb M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb M recipes-osmocom/osmo-hlr/osmo-hlr_git.bb M recipes-osmocom/osmo-iuh/osmo-iuh_git.bb M recipes-osmocom/osmo-mgw/osmo-mgw_git.bb M recipes-osmocom/osmo-msc/osmo-msc_git.bb M recipes-osmocom/osmo-pcap/osmo-pcap_git.bb M recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb M recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb 13 files changed, 28 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/14/26314/1 diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb index 16124d8..9f35364 100644 --- a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb +++ b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.1.1" +SRCREV = "1.2.0" SRC_URI = "git://git.osmocom.org/libosmo-abis.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.1.1+gitr${SRCPV}" +PV = "1.2.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb index 62bd9e8..a90fae5 100644 --- a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb +++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.4.0" +SRCREV = "1.5.0" SRC_URI = "git://git.osmocom.org/libosmo-sccp.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.4.0+gitr${SRCPV}" +PV = "1.5.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb b/recipes-osmocom/libosmocore/libosmocore_git.bb index 062fb20..3c56eb7 100644 --- a/recipes-osmocom/libosmocore/libosmocore_git.bb +++ b/recipes-osmocom/libosmocore/libosmocore_git.bb @@ -1,10 +1,10 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.5.1" +SRCREV = "1.6.0" SRC_URI = "git://git.osmocom.org/libosmocore.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.5.1+gitr${SRCPV}" -PR = "${INC_PR}.1" +PV = "1.6.0+gitr${SRCPV}" +PR = "${INC_PR}.0" PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty osmo-arfcn osmo-auc-gen osmo-config-merge" FILES_libosmoctrl = "${libdir}/libosmoctrl${SOLIBS}" diff --git a/recipes-osmocom/openbsc/openbsc_git.bb b/recipes-osmocom/openbsc/openbsc_git.bb index af3e726..b763685 100644 --- a/recipes-osmocom/openbsc/openbsc_git.bb +++ b/recipes-osmocom/openbsc/openbsc_git.bb @@ -1,10 +1,10 @@ require ${PN}.inc -PV = "1.4.0+gitr${SRCPV}" +PV = "1.4.1+gitr${SRCPV}" PRINC = "0" PR = "${INC_PR}.0" -SRCREV = "a1c1a313e574748bf802eccd93a18fba42a8aa3a" +SRCREV = "83fbbeb56c45d84321fa3218c8afd5b3644a2ca2" SRC_URI += "git://git.osmocom.org/openbsc.git;protocol=git" S = "${WORKDIR}/git/openbsc" diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb index 73a5de3..c83e63e 100644 --- a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb +++ b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.0" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-bsc.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.7.0+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb index be12988..5498d3d 100644 --- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb +++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb @@ -1,9 +1,9 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.1" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-ggsn;protocol=git;tag=${SRCREV};nobranch=1 \ file://libgtp-queue_depth_32.patch \ " -PV = "1.7.1+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb index 3a0b446..8eaf2bb 100644 --- a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb +++ b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.3.0" +SRCREV = "1.4.0" SRC_URI = "git://git.osmocom.org/osmo-hlr.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.3.0+gitr${SRCPV}" +PV = "1.4.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb b/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb index a9104ce..d790774 100644 --- a/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb +++ b/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "0.7.0" +SRCREV = "1.1.0" SRC_URI = "git://git.osmocom.org/osmo-iuh.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.0.0+gitr${SRCPV}" -PR = "${INC_PR}.1" +PV = "1.1.0+gitr${SRCPV}" +PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb b/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb index 528295b..35eae67 100644 --- a/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb +++ b/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.8.1" +SRCREV = "1.9.0" SRC_URI = "git://git.osmocom.org/osmo-mgw.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.8.1+gitr${SRCPV}" +PV = "1.9.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-msc/osmo-msc_git.bb b/recipes-osmocom/osmo-msc/osmo-msc_git.bb index a279ad2..e6ae1f4 100644 --- a/recipes-osmocom/osmo-msc/osmo-msc_git.bb +++ b/recipes-osmocom/osmo-msc/osmo-msc_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.0" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-msc.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.7.0+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb index 02c5e35..4e351d6 100644 --- a/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb +++ b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "0.1.3" +SRCREV = "0.2.1" SRC_URI = "git://git.osmocom.org/osmo-pcap.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "0.1.3+gitr${SRCPV}" +PV = "0.2.1+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb b/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb index cb8a7ae..401ed24 100644 --- a/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb +++ b/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.0" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-sgsn.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.7.0+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb index 016781b..5087a40 100644 --- a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb +++ b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.5.0" +SRCREV = "1.6.0" SRC_URI = "git://git.osmocom.org/osmo-sip-connector.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.5.0+gitr${SRCPV}" +PV = "1.6.0+gitr${SRCPV}" PR = "${INC_PR}.0" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/26314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I774dbdc4654c57d217664e94f02d72fbea76d791 Gerrit-Change-Number: 26314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 12:35:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 12:35:54 +0000 Subject: Change in meta-telephony[201705]: osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/26315 ) Change subject: osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package ...................................................................... osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package Since osmo-hlr.git 60673e7f771c3362f9d0d26d4c03cfe85ed5a5b3, a new file /usr/share/osmocom/osmo-hlr-post-upgrade.sh is installed by "make install". However, that path is not included in any of the default path list in FILES_${PN} (see meta/conf/bitbake.conf). Hence, we must add it manually in order to fix following error: """ ERROR: osmo-hlr-1.3.0+gitrAUTOINC+60673e7f77-r2.18.0 do_package: QA Issue: osmo-hlr: Files/directories were installed but not shipped in any package: /usr/share/osmocom /usr/share/osmocom/osmo-hlr-post-upgrade.sh Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. osmo-hlr: 2 installed and not shipped files. [installed-vs-shipped] """ Related: OS#5138 Change-Id: Icdf060f519aaed043eed0dc79779258b0e39006a --- M recipes-osmocom/osmo-hlr/osmo-hlr.inc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/15/26315/1 diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc b/recipes-osmocom/osmo-hlr/osmo-hlr.inc index 7fa415b..c270746 100644 --- a/recipes-osmocom/osmo-hlr/osmo-hlr.inc +++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc @@ -38,6 +38,8 @@ ${bindir}/osmo-euse-demo \ " +FILES_${PN} =+ "${datadir}/osmocom/*" + SYSTEMD_SERVICE_${PN} = "${PN}.service" CONFFILES_osmo-hlr = "\ ${sysconfdir}/osmocom/osmo-hlr.cfg \ -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/26315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Icdf060f519aaed043eed0dc79779258b0e39006a Gerrit-Change-Number: 26315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 12:36:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 12:36:07 +0000 Subject: Change in meta-telephony[201705]: Update Osmocom recipes to latest tags (release 202111) In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/26314 ) Change subject: Update Osmocom recipes to latest tags (release 202111) ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/26314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I774dbdc4654c57d217664e94f02d72fbea76d791 Gerrit-Change-Number: 26314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 12:36:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 12:36:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 12:36:10 +0000 Subject: Change in meta-telephony[201705]: osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/26315 ) Change subject: osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/26315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Icdf060f519aaed043eed0dc79779258b0e39006a Gerrit-Change-Number: 26315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 12:36:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 12:36:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 12:36:17 +0000 Subject: Change in meta-telephony[201705]: Update Osmocom recipes to latest tags (release 202111) In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/26314 ) Change subject: Update Osmocom recipes to latest tags (release 202111) ...................................................................... Update Osmocom recipes to latest tags (release 202111) Change-Id: I774dbdc4654c57d217664e94f02d72fbea76d791 --- M recipes-osmocom/libosmo-abis/libosmo-abis_git.bb M recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb M recipes-osmocom/libosmocore/libosmocore_git.bb M recipes-osmocom/openbsc/openbsc_git.bb M recipes-osmocom/osmo-bsc/osmo-bsc_git.bb M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb M recipes-osmocom/osmo-hlr/osmo-hlr_git.bb M recipes-osmocom/osmo-iuh/osmo-iuh_git.bb M recipes-osmocom/osmo-mgw/osmo-mgw_git.bb M recipes-osmocom/osmo-msc/osmo-msc_git.bb M recipes-osmocom/osmo-pcap/osmo-pcap_git.bb M recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb M recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb 13 files changed, 28 insertions(+), 28 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb index 16124d8..9f35364 100644 --- a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb +++ b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.1.1" +SRCREV = "1.2.0" SRC_URI = "git://git.osmocom.org/libosmo-abis.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.1.1+gitr${SRCPV}" +PV = "1.2.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb index 62bd9e8..a90fae5 100644 --- a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb +++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.4.0" +SRCREV = "1.5.0" SRC_URI = "git://git.osmocom.org/libosmo-sccp.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.4.0+gitr${SRCPV}" +PV = "1.5.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb b/recipes-osmocom/libosmocore/libosmocore_git.bb index 062fb20..3c56eb7 100644 --- a/recipes-osmocom/libosmocore/libosmocore_git.bb +++ b/recipes-osmocom/libosmocore/libosmocore_git.bb @@ -1,10 +1,10 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.5.1" +SRCREV = "1.6.0" SRC_URI = "git://git.osmocom.org/libosmocore.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.5.1+gitr${SRCPV}" -PR = "${INC_PR}.1" +PV = "1.6.0+gitr${SRCPV}" +PR = "${INC_PR}.0" PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty osmo-arfcn osmo-auc-gen osmo-config-merge" FILES_libosmoctrl = "${libdir}/libosmoctrl${SOLIBS}" diff --git a/recipes-osmocom/openbsc/openbsc_git.bb b/recipes-osmocom/openbsc/openbsc_git.bb index af3e726..b763685 100644 --- a/recipes-osmocom/openbsc/openbsc_git.bb +++ b/recipes-osmocom/openbsc/openbsc_git.bb @@ -1,10 +1,10 @@ require ${PN}.inc -PV = "1.4.0+gitr${SRCPV}" +PV = "1.4.1+gitr${SRCPV}" PRINC = "0" PR = "${INC_PR}.0" -SRCREV = "a1c1a313e574748bf802eccd93a18fba42a8aa3a" +SRCREV = "83fbbeb56c45d84321fa3218c8afd5b3644a2ca2" SRC_URI += "git://git.osmocom.org/openbsc.git;protocol=git" S = "${WORKDIR}/git/openbsc" diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb index 73a5de3..c83e63e 100644 --- a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb +++ b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.0" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-bsc.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.7.0+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb index be12988..5498d3d 100644 --- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb +++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb @@ -1,9 +1,9 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.1" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-ggsn;protocol=git;tag=${SRCREV};nobranch=1 \ file://libgtp-queue_depth_32.patch \ " -PV = "1.7.1+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb index 3a0b446..8eaf2bb 100644 --- a/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb +++ b/recipes-osmocom/osmo-hlr/osmo-hlr_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.3.0" +SRCREV = "1.4.0" SRC_URI = "git://git.osmocom.org/osmo-hlr.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.3.0+gitr${SRCPV}" +PV = "1.4.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb b/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb index a9104ce..d790774 100644 --- a/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb +++ b/recipes-osmocom/osmo-iuh/osmo-iuh_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "0.7.0" +SRCREV = "1.1.0" SRC_URI = "git://git.osmocom.org/osmo-iuh.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.0.0+gitr${SRCPV}" -PR = "${INC_PR}.1" +PV = "1.1.0+gitr${SRCPV}" +PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb b/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb index 528295b..35eae67 100644 --- a/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb +++ b/recipes-osmocom/osmo-mgw/osmo-mgw_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.8.1" +SRCREV = "1.9.0" SRC_URI = "git://git.osmocom.org/osmo-mgw.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.8.1+gitr${SRCPV}" +PV = "1.9.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-msc/osmo-msc_git.bb b/recipes-osmocom/osmo-msc/osmo-msc_git.bb index a279ad2..e6ae1f4 100644 --- a/recipes-osmocom/osmo-msc/osmo-msc_git.bb +++ b/recipes-osmocom/osmo-msc/osmo-msc_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.0" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-msc.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.7.0+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb index 02c5e35..4e351d6 100644 --- a/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb +++ b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "0.1.3" +SRCREV = "0.2.1" SRC_URI = "git://git.osmocom.org/osmo-pcap.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "0.1.3+gitr${SRCPV}" +PV = "0.2.1+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb b/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb index cb8a7ae..401ed24 100644 --- a/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb +++ b/recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.7.0" +SRCREV = "1.8.0" SRC_URI = "git://git.osmocom.org/osmo-sgsn.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.7.0+gitr${SRCPV}" +PV = "1.8.0+gitr${SRCPV}" PR = "${INC_PR}.0" diff --git a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb index 016781b..5087a40 100644 --- a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb +++ b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb @@ -1,7 +1,7 @@ require ${PN}.inc S = "${WORKDIR}/git" -SRCREV = "1.5.0" +SRCREV = "1.6.0" SRC_URI = "git://git.osmocom.org/osmo-sip-connector.git;protocol=git;tag=${SRCREV};nobranch=1" -PV = "1.5.0+gitr${SRCPV}" +PV = "1.6.0+gitr${SRCPV}" PR = "${INC_PR}.0" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/26314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I774dbdc4654c57d217664e94f02d72fbea76d791 Gerrit-Change-Number: 26314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 12:36:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 12:36:17 +0000 Subject: Change in meta-telephony[201705]: osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/26315 ) Change subject: osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package ...................................................................... osmo-hlr: Fix /usr/share/osmocom/* not shipped in any package Since osmo-hlr.git 60673e7f771c3362f9d0d26d4c03cfe85ed5a5b3, a new file /usr/share/osmocom/osmo-hlr-post-upgrade.sh is installed by "make install". However, that path is not included in any of the default path list in FILES_${PN} (see meta/conf/bitbake.conf). Hence, we must add it manually in order to fix following error: """ ERROR: osmo-hlr-1.3.0+gitrAUTOINC+60673e7f77-r2.18.0 do_package: QA Issue: osmo-hlr: Files/directories were installed but not shipped in any package: /usr/share/osmocom /usr/share/osmocom/osmo-hlr-post-upgrade.sh Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. osmo-hlr: 2 installed and not shipped files. [installed-vs-shipped] """ Related: OS#5138 Change-Id: Icdf060f519aaed043eed0dc79779258b0e39006a --- M recipes-osmocom/osmo-hlr/osmo-hlr.inc 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc b/recipes-osmocom/osmo-hlr/osmo-hlr.inc index 7fa415b..c270746 100644 --- a/recipes-osmocom/osmo-hlr/osmo-hlr.inc +++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc @@ -38,6 +38,8 @@ ${bindir}/osmo-euse-demo \ " +FILES_${PN} =+ "${datadir}/osmocom/*" + SYSTEMD_SERVICE_${PN} = "${PN}.service" CONFFILES_osmo-hlr = "\ ${sysconfdir}/osmocom/osmo-hlr.cfg \ -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/26315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Icdf060f519aaed043eed0dc79779258b0e39006a Gerrit-Change-Number: 26315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 13:21:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 13:21:19 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#6). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 245 insertions(+), 215 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 13:24:51 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 13:24:51 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26193 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Abandoned multiple change ids -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5e3598f80cb062dbab376663ee51136b4508b78d Gerrit-Change-Number: 26193 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 14:14:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 14:14:05 +0000 Subject: Change in libosmocore[master]: .gitignore: add utils/osmo-aka-verify binary In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26304 ) Change subject: .gitignore: add utils/osmo-aka-verify binary ...................................................................... .gitignore: add utils/osmo-aka-verify binary Change-Id: Ic7c69ee69f83a25d1ecec38dce7ea5f426e99a2d --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/.gitignore b/.gitignore index f5e794a..269ce8a 100644 --- a/.gitignore +++ b/.gitignore @@ -70,6 +70,7 @@ utils/osmo-auc-gen utils/osmo-config-merge utils/osmo-sim-test +utils/osmo-aka-verify doc/codec doc/coding -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic7c69ee69f83a25d1ecec38dce7ea5f426e99a2d Gerrit-Change-Number: 26304 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 14:43:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 14:43:27 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26307/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26307/1/src/bitvec.c at 479 PS1, Line 479: uint64_t bitvec_read_field(struct bitvec *bv, unsigned int *read_index, unsigned int len) > I'm not really liking the idea of using errno in non libc code. [?] Why using errno outside of libc is bad? And what do we loose in this case? In general, it looks fundamentally wrong to me that we have to use 'special' values like -1 to indicate errors. Yes, this is because C does not offer standard means for that, like C++ has exceptions or Erlang allows to return tuples of several values. We're mixing up data types, and then ending up in situations like this, where it's not clear if such 0xfffffff(...) is a valid value that is actually in the vector or a special value indicated by the function itself. An alternative approach would be to deprecate this function and introduce bitvec_read_field2(), which would accept an additional pointer for the resulting value. This is what I also don't really like, because in reality the new function does exactly what the old function does, but requires different way of invocation. And you get tons of deprecation warnings in osmo-pcu, where we use this function a lot, whereas in some cases it's fine to not check if an error occurred during parsing. The approach involving errno allows to avoid deprecation and at the same time provides a way to check if parsing succeeded, but rather in a unobtrusive way. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 14:43:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 14:58:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 14:58:24 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26308 ) Change subject: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c at 485 PS1, Line 485: if (len && bytenum_from_bitnum(*read_index + len - 1) >= bv->data_len) { > why this -1? Because we check presence of the *last* bit here. If let's say len=32, then the last bit you're interested in the 31th bit because we count from 0. Without that -1 parsing e.g. 32 our of 32 bits in the vector won't work. // read_index=0, len=32, bv->data_len=4 if (bytenum_from_bitnum(0 + 32 - 1) >= 4) { ... } if (bytenum_from_bitnum(31) >= 4) { ... } if (31 / 8 >= 4) { ... } if (3 >= 4) { ... } // false This is also why below we do: ((uint64_t)1 << (len - i - 1)) https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c at 494 PS1, Line 494: int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); > I'd rather still keep the error checking here. Why not, if we can check once and then avoid additional 'if' statements in a loop? Moreover, the idea is to catch the error before entering the loop and doing: ((uint64_t)1 << (len - i - 1)) Otherwise it takes several iterations to realize that we're reading out of bounds. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Gerrit-Change-Number: 26308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 14:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 15:06:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Nov 2021 15:06:00 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c at 495 PS1, Line 495: unsigned int bitnum = 7 - (bv->cur_bit % 8); > Calling it bitnum is confusing here, I'd rather call it bitnum_shift or alike. This is exactly how it's called in bitvec_get_bit_pos(), and it's clear that the bit number in a byte determines the shift value. https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c at 497 PS1, Line 497: if (bv->data[bytenum] & (1 << bitnum)) > You could also optimize and get rid of this branch: [?] Are you sure this is going to work? The 'bit' must be either 0 or 1, like the value returned by bitvec_get_bit_pos(). In your proposal the 'bit' might be any value, so it's rather a mask... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 15:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 15:16:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 15:16:31 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26308 ) Change subject: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Gerrit-Change-Number: 26308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 15:16:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 15:19:24 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 15:19:24 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c File src/bitvec.c: https://gerrit.osmocom.org/c/libosmocore/+/26309/1/src/bitvec.c at 497 PS1, Line 497: if (bv->data[bytenum] & (1 << bitnum)) > Are you sure this is going to work? The 'bit' must be either 0 or 1, like the value returned by bitv [?] Ah good point. You'd need to do the following to convert it to 0/1: bit = !!(bv->data[bytenum] & (1 << bitnum)); It was just an idea, no need for you to implement it if you don't want. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 15:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 16:41:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 16:41:26 +0000 Subject: =?UTF-8?Q?Change_in_osmo-uecups=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E3=2E2-0ac9_=E2=86=92_0=2E1=2E4?= References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26316 ) Change subject: Bump version: 0.1.3.2-0ac9 ? 0.1.4 ...................................................................... Bump version: 0.1.3.2-0ac9 ? 0.1.4 Change-Id: I411002b62f47c57db76811535eefa08c53163754 --- M debian/changelog 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/16/26316/1 diff --git a/debian/changelog b/debian/changelog index a258c8d..cc5c6ea 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +osmo-uecups (0.1.4) unstable; urgency=medium + + [ Harald Welte ] + * daemon: Add VTY command to configure local bind IP of UECUPS socket + + [ Oliver Smith ] + * configure: don't turn some warnings into errors + + -- Pau Espin Pedrol Wed, 17 Nov 2021 17:41:19 +0100 + osmo-uecups (0.1.3) unstable; urgency=medium * debian: add dependency to autoconf-archive -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I411002b62f47c57db76811535eefa08c53163754 Gerrit-Change-Number: 26316 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 16:43:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 16:43:08 +0000 Subject: =?UTF-8?Q?Change_in_osmo-uecups=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E3=2E2-0ac9_=E2=86=92_0=2E1=2E4?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26316 ) Change subject: Bump version: 0.1.3.2-0ac9 ? 0.1.4 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I411002b62f47c57db76811535eefa08c53163754 Gerrit-Change-Number: 26316 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 16:43:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 16:43:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Nov 2021 16:43:10 +0000 Subject: =?UTF-8?Q?Change_in_osmo-uecups=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E3=2E2-0ac9_=E2=86=92_0=2E1=2E4?= In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26316 ) Change subject: Bump version: 0.1.3.2-0ac9 ? 0.1.4 ...................................................................... Bump version: 0.1.3.2-0ac9 ? 0.1.4 Change-Id: I411002b62f47c57db76811535eefa08c53163754 --- M debian/changelog 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index a258c8d..cc5c6ea 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +osmo-uecups (0.1.4) unstable; urgency=medium + + [ Harald Welte ] + * daemon: Add VTY command to configure local bind IP of UECUPS socket + + [ Oliver Smith ] + * configure: don't turn some warnings into errors + + -- Pau Espin Pedrol Wed, 17 Nov 2021 17:41:19 +0100 + osmo-uecups (0.1.3) unstable; urgency=medium * debian: add dependency to autoconf-archive -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I411002b62f47c57db76811535eefa08c53163754 Gerrit-Change-Number: 26316 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From jenkins at lists.osmocom.org Wed Nov 17 19:21:57 2021 From: jenkins at lists.osmocom.org (jenkins at lists.osmocom.org) Date: Wed, 17 Nov 2021 19:21:57 +0000 (UTC) Subject: =?UTF-8?Q?Build_failed_in_Jenkins:_mast?= =?UTF-8?Q?er-libosmo-dsp_=C2=BB_a1=3Ddefault,a2?= =?UTF-8?Q?=3Ddefault,a3=3Ddefault,a4=3Ddefaul?= =?UTF-8?Q?t,osmocom-master-debian9_#1402?= Message-ID: <1031061024.1350.1637176917728@jenkins.osmocom.org> See Changes: ------------------------------------------ Started by upstream project "master-libosmo-dsp" build number 1402 originally caused by: Started by timer Running as SYSTEM Building remotely on gtp0-deb9build (ttcn3 osmocom-gerrit-debian9 osmocom-master-debian9) in workspace /home/osmocom-build/jenkins/workspace/master-libosmo-dsp/a1/default/a2/default/a3/default/a4/default/label/osmocom-master-debian9 FATAL: java.io.IOException: Unexpected termination of the channel java.io.EOFException at java.base/java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2872) at java.base/java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3367) at java.base/java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:936) at java.base/java.io.ObjectInputStream.(ObjectInputStream.java:379) at hudson.remoting.ObjectInputStreamEx.(ObjectInputStreamEx.java:49) at hudson.remoting.Command.readFrom(Command.java:142) at hudson.remoting.Command.readFrom(Command.java:128) at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35) at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:61) Caused: java.io.IOException: Unexpected termination of the channel at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:75) Also: hudson.remoting.Channel$CallSiteStackTrace: Remote call to gtp0-deb9build at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1795) at hudson.remoting.Request.call(Request.java:199) at hudson.remoting.Channel.call(Channel.java:1000) at hudson.FilePath.act(FilePath.java:1165) at hudson.FilePath.act(FilePath.java:1154) at hudson.FilePath.mkdirs(FilePath.java:1340) at hudson.model.AbstractProject.checkout(AbstractProject.java:1207) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:637) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:85) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:509) at hudson.model.Run.execute(Run.java:1888) at hudson.matrix.MatrixRun.run(MatrixRun.java:153) at hudson.model.ResourceController.execute(ResourceController.java:99) at hudson.model.Executor.run(Executor.java:431) Caused: hudson.remoting.RequestAbortedException at hudson.remoting.Request.abort(Request.java:345) at hudson.remoting.Channel.terminate(Channel.java:1082) at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:90) From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:11:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:11:09 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... Patch Set 1: Code-Review+1 I also consider the use of errno a bit of a hack, but well, I can live with it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:11:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:11:31 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26308 ) Change subject: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Gerrit-Change-Number: 26308 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:11:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:11:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:11:58 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:11:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:12:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:12:06 +0000 Subject: Change in libosmocore[master]: tests/testsuite.at: ensure empty stderr for the bitvec_test In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26310 ) Change subject: tests/testsuite.at: ensure empty stderr for the bitvec_test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia82b92eddb18dc596881abcef2f098dc7385538b Gerrit-Change-Number: 26310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:12:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:13:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:13:16 +0000 Subject: Change in libosmocore[master]: tests/vty: fix use of GNU 'missing =' extension in designator In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26311 ) Change subject: tests/vty: fix use of GNU 'missing =' extension in designator ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I66edb247898594b51cc9d7c1b3d0c60ba66fc637 Gerrit-Change-Number: 26311 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:13:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:13:18 +0000 Subject: Change in libosmocore[master]: tests/vty: fix use of GNU 'missing =' extension in designator In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26311 ) Change subject: tests/vty: fix use of GNU 'missing =' extension in designator ...................................................................... tests/vty: fix use of GNU 'missing =' extension in designator Change-Id: I66edb247898594b51cc9d7c1b3d0c60ba66fc637 --- M tests/vty/vty_test.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c index 1db0d5c..e068f19 100644 --- a/tests/vty/vty_test.c +++ b/tests/vty/vty_test.c @@ -542,9 +542,9 @@ /* Reserved for libraries */ [VTY_TEST_ATTR_UPPER] = 'X', /* Reserved for global attribues */ - [VTY_TEST_ATTR_RAFC_DOT] '.', - [VTY_TEST_ATTR_RAFC_EXCL] '!', - [VTY_TEST_ATTR_RAFC_AT] '@', + [VTY_TEST_ATTR_RAFC_DOT] = '.', + [VTY_TEST_ATTR_RAFC_EXCL] = '!', + [VTY_TEST_ATTR_RAFC_AT] = '@', }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I66edb247898594b51cc9d7c1b3d0c60ba66fc637 Gerrit-Change-Number: 26311 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:13:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:13:33 +0000 Subject: Change in libosmocore[master]: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26270 ) Change subject: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id20871b76c4a5801defb4f534fad635b7f079a13 Gerrit-Change-Number: 26270 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:13:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:13:36 +0000 Subject: Change in libosmocore[master]: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26270 ) Change subject: debian/control: minimum version of libtalloc-dev must be >= 2.1.0 ...................................................................... debian/control: minimum version of libtalloc-dev must be >= 2.1.0 Change-Id: Id20871b76c4a5801defb4f534fad635b7f079a13 --- M debian/control 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 05d0c02..771fff2 100644 --- a/debian/control +++ b/debian/control @@ -14,7 +14,7 @@ doxygen, libpcsclite-dev, pkg-config, - libtalloc-dev, + libtalloc-dev (>= 2.1.0), libsctp-dev, libusb-1.0-0-dev, libmnl-dev, @@ -319,7 +319,7 @@ Multi-Arch: same Section: libdevel Depends: libosmocore, - libtalloc-dev, + libtalloc-dev (>= 2.1.0), ${misc:Depends} Description: Development headers for Open Source MObile COMmunications CORE library The header files provided by this package may be used to develop -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id20871b76c4a5801defb4f534fad635b7f079a13 Gerrit-Change-Number: 26270 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:13:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:13:48 +0000 Subject: Change in osmo-pcap[master]: debian/control: minimum version for libzmq3-dev is 3.2.2 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26269 ) Change subject: debian/control: minimum version for libzmq3-dev is 3.2.2 ...................................................................... debian/control: minimum version for libzmq3-dev is 3.2.2 We require this version in 'contrib/osmo-pcap.spec.in', and should here too. Change-Id: If76b4fcb8863ad5468a77113ad25142fe1145cda --- M debian/control 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 5c65ee8..4b23234 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ pkg-config, libosmocore-dev (>= 1.6.0), libgnutls28-dev, - libzmq3-dev + libzmq3-dev (>= 3.2.2) Standards-Version: 3.9.1 Homepage: https://osmocom.org/projects/osmo-pcap Vcs-Git: git://git.osmocom.org/osmo-pcap.git -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If76b4fcb8863ad5468a77113ad25142fe1145cda Gerrit-Change-Number: 26269 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:14:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:14:57 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26280 ) Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 17 Nov 2021 20:14:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:17:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:17:20 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 9: (1 comment) https://gerrit.osmocom.org/c/pysim/+/25873/9/pysim-testdata/fakemagicsim.ok File pysim-testdata/fakemagicsim.ok: https://gerrit.osmocom.org/c/pysim/+/25873/9/pysim-testdata/fakemagicsim.ok at 58 PS9, Line 58: ADF.USIM: Can't select application -- SW match failed! Expected 9000 and got 6b00. > Hmm, do we really want to have these warning/error messages printed for cards containing on USIM and [?] indeed this is a bit odd. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 9 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 17 Nov 2021 20:17:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:17:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:17:49 +0000 Subject: Change in libosmocore[master]: tests/tdef: rename the binaries to end with '_test' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26305 ) Change subject: tests/tdef: rename the binaries to end with '_test' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I828fa45132e11a41c527d4b25df850c19871cb75 Gerrit-Change-Number: 26305 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:17:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:17:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:17:56 +0000 Subject: Change in libosmocore[master]: tdef: fix wrong path in documentation: tests/vty -> tests/tdef In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26306 ) Change subject: tdef: fix wrong path in documentation: tests/vty -> tests/tdef ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ba9a7a0ba9ad440c879d6a1da110d2fda49eb23 Gerrit-Change-Number: 26306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:17:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:18:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:18:00 +0000 Subject: Change in libosmocore[master]: tests/tdef: rename the binaries to end with '_test' In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26305 ) Change subject: tests/tdef: rename the binaries to end with '_test' ...................................................................... tests/tdef: rename the binaries to end with '_test' It's the usual naming for unit test binaries. Without the '_test' endig, the tdef_vty_test_{config_root,config_subnode,dynamic} binaries do not match the 'tests/*/*_test' pattern and appear as untracked files in git. Change-Id: I828fa45132e11a41c527d4b25df850c19871cb75 --- M src/tdef.c M src/vty/tdef_vty.c M tests/Makefile.am R tests/tdef/tdef_vty_config_root_test.c R tests/tdef/tdef_vty_config_root_test.vty R tests/tdef/tdef_vty_config_subnode_test.c R tests/tdef/tdef_vty_config_subnode_test.vty R tests/tdef/tdef_vty_dynamic_test.c R tests/tdef/tdef_vty_dynamic_test.vty 9 files changed, 25 insertions(+), 25 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/tdef.c b/src/tdef.c index 9890f95..75b884a 100644 --- a/src/tdef.c +++ b/src/tdef.c @@ -52,18 +52,18 @@ * By keeping separate osmo_tdef arrays, several groups of timers can be kept * separately. The VTY tests in tests/tdef/ showcase different schemes: * - * - \ref tests/vty/tdef_vty_test_config_root.c: + * - \ref tests/vty/tdef_vty_config_root_test.c: * Keep several timer definitions in separately named groups: showcase the * osmo_tdef_vty_groups*() API. Each timer group exists exactly once. * - * - \ref tests/vty/tdef_vty_test_config_subnode.c: + * - \ref tests/vty/tdef_vty_config_subnode_test.c: * Keep a single list of timers without separate grouping. * Put this list on a specific subnode below the CONFIG_NODE. * There could be several separate subnodes with timers like this, i.e. * continuing from this example, sets of timers could be separated by placing * timers in specific config subnodes instead of using the global group name. * - * - \ref tests/vty/tdef_vty_test_dynamic.c: + * - \ref tests/vty/tdef_vty_dynamic_test.c: * Dynamically allocate timer definitions per each new created object. * Thus there can be an arbitrary number of independent timer definitions, one * per allocated object. diff --git a/src/vty/tdef_vty.c b/src/vty/tdef_vty.c index 09459f1..bd209ae 100644 --- a/src/vty/tdef_vty.c +++ b/src/vty/tdef_vty.c @@ -242,7 +242,7 @@ /*! Write current timer configuration arguments to the vty. Skip all entries that reflect their default value. * The passed prefix string must contain both necessary indent and the VTY command the specific implementation is using. - * See tdef_vty_test_config_subnode.c and tdef_vty_test_dynamic.c for examples. + * See tdef_vty_config_subnode_test.c and tdef_vty_dynamic_test.c for examples. * \param[in] vty VTY context. * \param[in] tdefs Array of timers to print, ended with a fully zero-initialized entry. * \param[in] prefix_fmt Arbitrary string to start each line with, with variable printf like arguments. diff --git a/tests/Makefile.am b/tests/Makefile.am index c44b6f0..a6f6017 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -28,9 +28,9 @@ oap/oap_client_test gsm29205/gsm29205_test \ logging/logging_vty_test \ vty/vty_transcript_test \ - tdef/tdef_test tdef/tdef_vty_test_config_root \ - tdef/tdef_vty_test_config_subnode \ - tdef/tdef_vty_test_dynamic \ + tdef/tdef_test tdef/tdef_vty_config_root_test \ + tdef/tdef_vty_config_subnode_test \ + tdef/tdef_vty_dynamic_test \ sockaddr_str/sockaddr_str_test \ use_count/use_count_test \ context/context_test \ @@ -286,14 +286,14 @@ tdef_tdef_test_SOURCES = tdef/tdef_test.c tdef_tdef_test_LDADD = $(LDADD) -tdef_tdef_vty_test_config_root_SOURCES = tdef/tdef_vty_test_config_root.c -tdef_tdef_vty_test_config_root_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la +tdef_tdef_vty_config_root_test_SOURCES = tdef/tdef_vty_config_root_test.c +tdef_tdef_vty_config_root_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la -tdef_tdef_vty_test_config_subnode_SOURCES = tdef/tdef_vty_test_config_subnode.c -tdef_tdef_vty_test_config_subnode_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la +tdef_tdef_vty_config_subnode_test_SOURCES = tdef/tdef_vty_config_subnode_test.c +tdef_tdef_vty_config_subnode_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la -tdef_tdef_vty_test_dynamic_SOURCES = tdef/tdef_vty_test_dynamic.c -tdef_tdef_vty_test_dynamic_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la +tdef_tdef_vty_dynamic_test_SOURCES = tdef/tdef_vty_dynamic_test.c +tdef_tdef_vty_dynamic_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la sockaddr_str_sockaddr_str_test_SOURCES = sockaddr_str/sockaddr_str_test.c sockaddr_str_sockaddr_str_test_LDADD = $(LDADD) @@ -402,9 +402,9 @@ vty/vty_transcript_test.vty \ tdef/tdef_test.ok \ tdef/tdef_test_range_64bit.ok \ - tdef/tdef_vty_test_config_root.vty \ - tdef/tdef_vty_test_config_subnode.vty \ - tdef/tdef_vty_test_dynamic.vty \ + tdef/tdef_vty_config_root_test.vty \ + tdef/tdef_vty_config_subnode_test.vty \ + tdef/tdef_vty_dynamic_test.vty \ sockaddr_str/sockaddr_str_test.ok \ use_count/use_count_test.ok use_count/use_count_test.err \ context/context_test.ok \ @@ -678,16 +678,16 @@ vty-test-tdef: osmo_verify_transcript_vty.py -v \ -p 42042 \ - -r "$(top_builddir)/tests/tdef/tdef_vty_test_config_root" \ - $(U) $(srcdir)/tdef/tdef_vty_test_config_root.vty + -r "$(top_builddir)/tests/tdef/tdef_vty_config_root_test" \ + $(U) $(srcdir)/tdef/tdef_vty_config_root_test.vty osmo_verify_transcript_vty.py -v \ -p 42042 \ - -r "$(top_builddir)/tests/tdef/tdef_vty_test_config_subnode" \ - $(U) $(srcdir)/tdef/tdef_vty_test_config_subnode.vty + -r "$(top_builddir)/tests/tdef/tdef_vty_config_subnode_test" \ + $(U) $(srcdir)/tdef/tdef_vty_config_subnode_test.vty osmo_verify_transcript_vty.py -v \ -p 42042 \ - -r "$(top_builddir)/tests/tdef/tdef_vty_test_dynamic" \ - $(U) $(srcdir)/tdef/tdef_vty_test_dynamic.vty + -r "$(top_builddir)/tests/tdef/tdef_vty_dynamic_test" \ + $(U) $(srcdir)/tdef/tdef_vty_dynamic_test.vty vty-test-stats: osmo_verify_transcript_vty.py -v \ diff --git a/tests/tdef/tdef_vty_test_config_root.c b/tests/tdef/tdef_vty_config_root_test.c similarity index 97% rename from tests/tdef/tdef_vty_test_config_root.c rename to tests/tdef/tdef_vty_config_root_test.c index 92113e8..0472ad5 100644 --- a/tests/tdef/tdef_vty_test_config_root.c +++ b/tests/tdef/tdef_vty_config_root_test.c @@ -45,7 +45,7 @@ /* ------------------- HERE IS THE INTERESTING TDEF RELEVANT PART ------------------- */ /* This example keeps several separate timer groups and offers 'timer' VTY commands at the root of the config node. See - * the tdef_vty_test_config_root.vty transcript test. + * the tdef_vty_config_root_test.vty transcript test. */ static struct osmo_tdef tdefs_test[] = { @@ -102,7 +102,7 @@ /* This example puts 'timer' configuration commands directly at the root of the CONFIG_NODE. * This TIMER_NODE is merely needed as a hook for the vty_write() command, but becomes an empty node in the VTY docs. * It is possible to cheat around needing this if you choose to config_write_timer() in another root nodes' write cb. - * Another example using a 'network' subnode is \ref tdef_vty_test_config_subnode.c */ + * Another example using a 'network' subnode is \ref tdef_vty_config_subnode_test.c */ static struct cmd_node timer_node = { TIMER_NODE, "%s(config-timer)# ", diff --git a/tests/tdef/tdef_vty_test_config_root.vty b/tests/tdef/tdef_vty_config_root_test.vty similarity index 100% rename from tests/tdef/tdef_vty_test_config_root.vty rename to tests/tdef/tdef_vty_config_root_test.vty diff --git a/tests/tdef/tdef_vty_test_config_subnode.c b/tests/tdef/tdef_vty_config_subnode_test.c similarity index 98% rename from tests/tdef/tdef_vty_test_config_subnode.c rename to tests/tdef/tdef_vty_config_subnode_test.c index ce851f5..ff19150 100644 --- a/tests/tdef/tdef_vty_test_config_subnode.c +++ b/tests/tdef/tdef_vty_config_subnode_test.c @@ -46,7 +46,7 @@ /* This example keeps a single global timer group and offers a custom 'timer' VTY command in a 'network' subnode below * the CONFIG_NODE. - * the tdef_vty_test_config_subnode.vty transcript test. + * the tdef_vty_config_subnode_test.vty transcript test. */ static struct osmo_tdef global_tdefs[] = { diff --git a/tests/tdef/tdef_vty_test_config_subnode.vty b/tests/tdef/tdef_vty_config_subnode_test.vty similarity index 100% rename from tests/tdef/tdef_vty_test_config_subnode.vty rename to tests/tdef/tdef_vty_config_subnode_test.vty diff --git a/tests/tdef/tdef_vty_test_dynamic.c b/tests/tdef/tdef_vty_dynamic_test.c similarity index 100% rename from tests/tdef/tdef_vty_test_dynamic.c rename to tests/tdef/tdef_vty_dynamic_test.c diff --git a/tests/tdef/tdef_vty_test_dynamic.vty b/tests/tdef/tdef_vty_dynamic_test.vty similarity index 100% rename from tests/tdef/tdef_vty_test_dynamic.vty rename to tests/tdef/tdef_vty_dynamic_test.vty -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I828fa45132e11a41c527d4b25df850c19871cb75 Gerrit-Change-Number: 26305 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:18:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:18:00 +0000 Subject: Change in libosmocore[master]: tdef: fix wrong path in documentation: tests/vty -> tests/tdef In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26306 ) Change subject: tdef: fix wrong path in documentation: tests/vty -> tests/tdef ...................................................................... tdef: fix wrong path in documentation: tests/vty -> tests/tdef Change-Id: I2ba9a7a0ba9ad440c879d6a1da110d2fda49eb23 --- M src/tdef.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/tdef.c b/src/tdef.c index 75b884a..7741a44 100644 --- a/src/tdef.c +++ b/src/tdef.c @@ -52,18 +52,18 @@ * By keeping separate osmo_tdef arrays, several groups of timers can be kept * separately. The VTY tests in tests/tdef/ showcase different schemes: * - * - \ref tests/vty/tdef_vty_config_root_test.c: + * - \ref tests/tdef/tdef_vty_config_root_test.c: * Keep several timer definitions in separately named groups: showcase the * osmo_tdef_vty_groups*() API. Each timer group exists exactly once. * - * - \ref tests/vty/tdef_vty_config_subnode_test.c: + * - \ref tests/tdef/tdef_vty_config_subnode_test.c: * Keep a single list of timers without separate grouping. * Put this list on a specific subnode below the CONFIG_NODE. * There could be several separate subnodes with timers like this, i.e. * continuing from this example, sets of timers could be separated by placing * timers in specific config subnodes instead of using the global group name. * - * - \ref tests/vty/tdef_vty_dynamic_test.c: + * - \ref tests/tdef/tdef_vty_dynamic_test.c: * Dynamically allocate timer definitions per each new created object. * Thus there can be an arbitrary number of independent timer definitions, one * per allocated object. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ba9a7a0ba9ad440c879d6a1da110d2fda49eb23 Gerrit-Change-Number: 26306 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:18:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:18:20 +0000 Subject: Change in osmo-msc[master]: utran: use new UTRAN encryption enum In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26107 ) Change subject: utran: use new UTRAN encryption enum ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa Gerrit-Change-Number: 26107 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:18:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:18:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:18:52 +0000 Subject: Change in osmo-msc[master]: utran: use new UTRAN encryption enum In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26107 ) Change subject: utran: use new UTRAN encryption enum ...................................................................... utran: use new UTRAN encryption enum Depends: libosmocore.git I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa --- M src/libmsc/gsm_04_08.c M src/libmsc/msc_net_init.c M src/libmsc/ran_msg_iu.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_tests.h 5 files changed, 17 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, approved dexter: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index fc1b2e2..075ef0f 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -51,6 +51,7 @@ #include #include #include +#include #include #include @@ -414,7 +415,7 @@ net->vlr, msc_a, vlr_lu_type, tmsi, imsi, &old_lai, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, lu->key_seq, osmo_gsm48_classmark1_is_r99(&lu->classmark1), is_utran, @@ -805,7 +806,7 @@ req->cm_service_type, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -931,7 +932,7 @@ VLR_PR_ARQ_T_CM_RE_ESTABLISH_REQ, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -1293,7 +1294,7 @@ net->vlr, msc_a, VLR_PR_ARQ_T_PAGING_RESP, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01, + is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, pr->key_seq, osmo_gsm48_classmark2_is_r99(cm2, classmark2_len), is_utran); diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index d53156b..af23fe5 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -24,6 +24,7 @@ #include "config.h" #include +#include #include #include @@ -68,7 +69,7 @@ /* Permit a compile-time default of A5/3 and A5/1 */ net->a5_encryption_mask = (1 << 3) | (1 << 1); /* Permit a compile-time default of UEA2 and UEA1 */ - net->uea_encryption_mask = (1 << 2) | (1 << 1); + net->uea_encryption_mask = (1 << OSMO_UTRAN_UEA2) | (1 << OSMO_UTRAN_UEA1); net->mncc_guard_timeout = 180; net->ncss_guard_timeout = 30; diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 81147cf..8ffdd93 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include @@ -377,10 +378,10 @@ LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, IK=%s, CK=%s\n", osmo_hexdump_nospc(cm->vec->ik, 16), - cm->utran.uea_encryption_mask > 0x01 ? osmo_hexdump_nospc(cm->vec->ck, 16) : "NONE"); + cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? osmo_hexdump_nospc(cm->vec->ck, 16) : "NONE"); /* TODO: Do we need to check if the UE supports all of the algorithms and build an intersection like * in the case of A5? */ - return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > 0x01 ? cm->vec->ck : NULL, + return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? cm->vec->ck : NULL, RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask); } diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index 655183b..f132cdf 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -50,7 +50,7 @@ "d3d36ff71c949e83c22072799e9687c5ec32a81d96afcbf4b4fb" "0c7ac3e9e9b7db05"; bool encryption = (via_ran == OSMO_RAT_GERAN_A && net->a5_encryption_mask > 0x1) - || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption_mask > 0x1); + || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0)); net->authentication_required = true; net->vlr->cfg.assign_tmsi = true; @@ -333,7 +333,7 @@ static void test_umts_authen_utran() { comment_start(); - net->uea_encryption_mask = 0x01; + net->uea_encryption_mask = (1 << OSMO_UTRAN_UEA0); _test_umts_authen(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -341,7 +341,7 @@ static void test_umts_auth_ciph_utran() { comment_start(); - net->uea_encryption_mask = 0x06; + net->uea_encryption_mask = (1 << OSMO_UTRAN_UEA1) | (1 << OSMO_UTRAN_UEA2); _test_umts_authen(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -361,7 +361,7 @@ struct vlr_subscr *vsub; const char *imsi = "901700000010650"; bool encryption = (via_ran == OSMO_RAT_GERAN_A && net->a5_encryption_mask > 0x1) - || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption_mask > 0x1); + || (via_ran == OSMO_RAT_UTRAN_IU && net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0)); net->authentication_required = true; net->vlr->cfg.assign_tmsi = true; @@ -588,7 +588,7 @@ static void test_umts_authen_resync_utran() { comment_start(); - net->uea_encryption_mask = 0x01; + net->uea_encryption_mask = (1 << OSMO_UTRAN_UEA0); _test_umts_authen_resync(OSMO_RAT_UTRAN_IU); comment_end(); } @@ -596,7 +596,7 @@ static void test_umts_auth_ciph_resync_utran() { comment_start(); - net->uea_encryption_mask = 0x06; + net->uea_encryption_mask = (1 << OSMO_UTRAN_UEA1) | (1 << OSMO_UTRAN_UEA2); _test_umts_authen_resync(OSMO_RAT_UTRAN_IU); comment_end(); } diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index a2b2f22..1f83013 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -26,6 +26,7 @@ #include #include +#include #include #include #include -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If6978d7ed1a78facc2591cfc30fda2721629bffa Gerrit-Change-Number: 26107 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:19:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 20:19:08 +0000 Subject: Change in libosmo-abis[master]: lapd: don't add parenthesis around datalink name In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26229 ) Change subject: lapd: don't add parenthesis around datalink name ...................................................................... lapd: don't add parenthesis around datalink name The name [printing] works like this: * libosmo-abis:lapd tells libosmogsm:lapd_core a name for each data link * libosmgsm:lapd_core assumes this name has no paranthesis and puts additional parenthesis around it in macros like LOGDL However, current libosmo-abis:lapd [before this patch] adds its own set of parenthesis, causing all ISDN-LAPD related log messages generated by libosmgsm:lapd_core to have double-parenthesis. So we have to remove the parenthesis from lapd_datalink.name and lapd_instance.name to fix the log lines printed in libosmocore. This in turn means we have to add parenthesis to some log statements here in libosmo-abis:lapd. Why can't we instead modify libosmogsm:lapd_core to drop parenthesis there? Becaus it is also used by LAPDm code in osmo-bts, and those two get it right :) Change-Id: I688cf2a73a8c31cb3cf66ec005d02a14de197008 Related: Ie6742843fff809edffcac24c4dce4edf66bc71be Related: OS#1938 --- M src/input/lapd.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: tnt: Looks good to me, but someone else must approve dexter: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/input/lapd.c b/src/input/lapd.c index d8c67e4..6f1e270 100644 --- a/src/input/lapd.c +++ b/src/input/lapd.c @@ -74,13 +74,13 @@ #define LAPD_SET_K(n, o) {n,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o,o} #define LOGLI(li, level, fmt, args ...) \ - LOGP(DLLAPD, level, "%s: " fmt, (li)->name, ## args) + LOGP(DLLAPD, level, "(%s): " fmt, (li)->name, ## args) #define LOGTEI(teip, level, fmt, args ...) \ LOGP(DLLAPD, level, "(%s-T%u): " fmt, (teip)->li->name, (teip)->tei, ## args) #define LOGSAP(sap, level, fmt, args ...) \ - LOGP(DLLAPD, level, "%s: " fmt, (sap)->dl.name, ## args) + LOGP(DLLAPD, level, "(%s): " fmt, (sap)->dl.name, ## args) #define DLSAP_MSGB_SIZE 128 #define DLSAP_MSGB_HEADROOM 56 @@ -240,14 +240,14 @@ char name[256]; int k; - snprintf(name, sizeof(name), "(%s-T%u-S%u)", li->name, teip->tei, sapi); + snprintf(name, sizeof(name), "%s-T%u-S%u", li->name, teip->tei, sapi); sap = talloc_zero(teip, struct lapd_sap); if (!sap) return NULL; LOGP(DLLAPD, LOGL_NOTICE, - "%s: LAPD Allocating SAP for SAPI=%u / TEI=%u (dl=%p, sap=%p)\n", + "(%s): LAPD Allocating SAP for SAPI=%u / TEI=%u (dl=%p, sap=%p)\n", name, sapi, teip->tei, &sap->dl, sap); sap->sapi = sapi; @@ -256,7 +256,7 @@ profile = &li->profile; k = profile->k[sapi & 0x3f]; - LOGP(DLLAPD, LOGL_NOTICE, "%s: k=%d N200=%d N201=%d T200=%d.%d T203=%d.%d\n", + LOGP(DLLAPD, LOGL_NOTICE, "(%s): k=%d N200=%d N201=%d T200=%d.%d T203=%d.%d\n", name, k, profile->n200, profile->n201, profile->t200_sec, profile->t200_usec, profile->t203_sec, profile->t203_usec); lapd_dl_init2(dl, k, 128, profile->n201, name); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I688cf2a73a8c31cb3cf66ec005d02a14de197008 Gerrit-Change-Number: 26229 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:34:30 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:34:30 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 32: (20 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h File include/osmocom/mgcp/mgcp_threads.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h at 73 PS32, Line 73: struct to_trunkthread_cfg_msg { > This "to" prefix here is very confusing imho. Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h at 115 PS32, Line 115: struct per_thread_info { > imho this "per_" prefix can also be dropped, it confuses more than helps. Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_threads.h at 121 PS32, Line 121: int tid; /* thread number handling this subtrunk */ > as in gettid()? or some posix threads id? as in "thread number handling this subtrunk" https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 319 PS32, Line 319: ssize_t rc = w->x.msglen; > this looks a bit weird, assigning a length to rc like this. Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 326 PS32, Line 326: if (rc < sizeof(rq->name) - 1) { > afaict you are only using rc here and in line 333 before setting it below, may be just more understa [?] Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 331 PS32, Line 331: memcpy(rq->name, (const char *)&w->msg[0], sizeof(rq->name) - 1); > no null char at the end of rq->name is required? this copies the 4 byte string into a 5 byte array in a zero-initialized struct. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 396 PS32, Line 396: ti->dlcx_in_queue++; > what's the relation between dlc_in_queue and having free endpoints? I cannot see the relation at fir [?] it might be not empty, and there might be other crcx in it that will be processed first, so just ignoring it means we could accidentally bother a thread that has no free eps after all. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 407 PS32, Line 407: return NULL; > Doesn't "w" need to be freed in any of these paths? no, w lives on the caller stack, and is copied to the queue, so always safe. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 1531 PS32, Line 1531: * endpoints, possible open connections are forcefully dropped */ > need to fix formatting here. Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 44 PS32, Line 44: #define GETF(yy, zz) \ > That's 10 lines for all the macro + definition stuff. [?] Macros are safe and idiot proof and it's not my fault that we enforce kernel style formatting which takes up a lot of space, I'm not going to make code difficult to work with and a copy-paste trap just because formatting makes this look ugly. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 337 PS32, Line 337: void *split_per_thead(void *info) > THis function name is misleading. [?] Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 344 PS32, Line 344: top_ctx = talloc_named_const(NULL, 0, "top_thread_ctx"); > idea: maybe add this_thread_number to the string here. Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 357 PS32, Line 357: struct mgcp_trunk *t = thread_info->this_trunk; > Please move this to the start, I was not finding it when looking for "t". Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 369 PS32, Line 369: t->ratectr = (struct mgcp_ratectr_trunk){ 0 }; > what about this? I think there's APIs to reset the counters? Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 377 PS32, Line 377: prctl(PR_SET_NAME, thrdname, NULL, NULL, NULL); > POSIX threads have pthread_setname_np() for that. Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 382 PS32, Line 382: log_enable_multithread(); > iirc this needs to be called only once per program? Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 383 PS32, Line 383: //msgb_talloc_ctx_init(OTC_GLOBAL,0); nooo is global! > what about this? Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 397 PS32, Line 397: osmo_stat_item_set(osmo_stat_item_group_get_item(t->stats.common, TRUNK_STAT_ENDPOINTS_TOTAL), > is this safe? No it's not, which is why the next patch that fixes the counters exists, since we don't want to fix libosmocore. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 413 PS32, Line 413: //FIXME: shutdown > something to do with this? Done https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_threads.c at 440 PS32, Line 440: /* currently unused > what about this? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 32 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 17 Nov 2021 20:34:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:35:41 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:35:41 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 6: (5 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h File include/osmocom/mgcp/mgcp_conn.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h at a134 PS5, Line 134: /* RTP connection related counters */ > So you are removing the counters from here but still using them immediatelly afterwards? how is that [?] Done https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_conn.h at 27 PS5, Line 27: #include > I don't see mgcp/mgcp_ratectr. [?] Done https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h File include/osmocom/mgcp/mgcp_ratectr.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/include/osmocom/mgcp/mgcp_ratectr.h at 15 PS5, Line 15: }; > yo should perhaps move the rate_ctr dscriptions here too? Done https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_endp.c at a129 PS5, Line 129: osmo_stat_item_dec(osmo_stat_item_group_get_item(endp->trunk->stats.common, > so we lost these counters? No, as the commit message states they get updated once per second in the rate timer cb. https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c at 498 PS5, Line 498: usleep(1000 * 100); > Let's rather have some volatile integer per thread or alike to check this, with a static bool done = [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:35:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:36:11 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:36:11 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26192 ) Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26192/1/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26192/1/src/libosmo-mgcp/mgcp_conn.c at 330 PS1, Line 330: __attribute__((no_sanitize("undefined"))) > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:36:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:36:31 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:36:31 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 ) Change subject: add a lock-free bounded spsc interthread queue ...................................................................... Patch Set 21: (3 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h File include/osmocom/mgcp/mgcp_threads_queue.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h at 27 PS21, Line 27: atomic_uint readptr; > I'd welcome some brief documentation for each of the fields, it's not like it's a simple data struct [?] Done https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/include/osmocom/mgcp/mgcp_threads_queue.h at 46 PS21, Line 46: ssize_t prep_pop(struct spsc *q); > probably worth adding a spsc_* prefix to all functions listed here. Done https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/src/libosmo-mgcp/mgcp_threads_queue.c File src/libosmo-mgcp/mgcp_threads_queue.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25431/21/src/libosmo-mgcp/mgcp_threads_queue.c at 38 PS21, Line 38: -> own ptr relaxed, other one not so much... > what do you mean here? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 21 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 20:36:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:55:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:55:19 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 to look at the new patch set (#7). Change subject: adjust mgcp response context ...................................................................... adjust mgcp response context This patch also prepares for threading. Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 53 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/47/25447/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:55:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:55:19 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 to look at the new patch set (#3). Change subject: rework message handling ...................................................................... rework message handling This was previously broken and a free endpoint was requirted to dlcx *, additionaly globally handling this is difficult due to different response codes, so just do it in the functions, they know best. Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 56 insertions(+), 57 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/89/26189/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:55:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:55:19 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 to look at the new patch set (#22). Change subject: add a lock-free bounded spsc interthread queue ...................................................................... add a lock-free bounded spsc interthread queue Not entirely wait-free: allows waiting on a fd, and in general fd notifications for poll-loop integration between threads. Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 --- A include/osmocom/mgcp/mgcp_threads_queue.h A src/libosmo-mgcp/mgcp_threads_queue.c 2 files changed, 259 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/31/25431/22 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 22 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:55:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:55:19 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 to look at the new patch set (#2). Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... fix mgcp_conn_free_all ubsan complaints ubsan still complains about a unaligned load that can't be explained, so silence it: /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime error: member access within misaligned address 0x612000000249 for type 'const struct llist_head', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime error: load of misaligned address 0x612000000249 for type 'struct llist_head *const', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in mgcp_conn.c:303:17: runtime error: member access within misaligned address 0x612000000249 for type 'struct llist_head', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:303:17 in mgcp_conn.c:303:17: runtime error: load of misaligned address 0x612000000249 for type 'struct llist_head *', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:303:17 in mgcp_conn.c:304:30: runtime error: member access within misaligned address 0x4800006120000002 for type 'struct mgcp_conn', which requires 8 byte alignment 0x4800006120000002: note: pointer points here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:304:30 in AddressSanitizer:DEADLYSIGNAL ================================================================= ==223426==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x0000004553f7 bp 0x7ffda5855080 sp 0x7ffda5855040 T0) ==223426==The signal is caused by a READ memory access. ==223426==Hint: this fault was caused by a dereference of a high value address (see register values below). Disassemble the provided pc to learn which register was used. /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:258:9 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:304:3 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_endp.c:124:2 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:670:3 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:923:2 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:2248:2 /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16 (/mgw-threads/osmo-mgw/tests/mgcp/mgcp_test+0x404c2d) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14 in mgcp_conn_get ==223426==ABORTING Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb --- M src/libosmo-mgcp/mgcp_conn.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/92/26192/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:55:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:55:19 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#33). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then answers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h A include/osmocom/mgcp/mgcp_threads.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 15 files changed, 1,163 insertions(+), 349 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/33 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 33 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 20:55:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 20:55:19 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#7). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 270 insertions(+), 247 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:18:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:18:41 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 ) Change subject: adjust mgcp response context ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 21:18:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:19:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:19:02 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 21:19:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:19:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:19:44 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 ) Change subject: add a lock-free bounded spsc interthread queue ...................................................................... Patch Set 22: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 22 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 21:19:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:20:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:20:04 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26192 ) Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Nov 2021 21:20:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:20:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:20:08 +0000 Subject: Change in osmo-mgw[master]: adjust mgcp response context In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 ) Change subject: adjust mgcp response context ...................................................................... adjust mgcp response context This patch also prepares for threading. Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 53 insertions(+), 56 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 6341f07..f4cdd76 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -173,12 +173,15 @@ } /* Helper function to allocate some memory for responses and retransmissions */ -static struct msgb *mgcp_msgb_alloc(void) +static struct msgb *mgcp_msgb_alloc(void *ctx) { struct msgb *msg; - msg = msgb_alloc_headroom(4096, 128, "MGCP msg"); - if (!msg) + msg = msgb_alloc_headroom_c(ctx, 4096, 128, "MGCP msg"); + + if (!msg) { LOGP(DLMGCP, LOGL_ERROR, "Failed to msgb for MGCP data.\n"); + return NULL; + } return msg; } @@ -186,7 +189,7 @@ /* Helper function for do_retransmission() and create_resp() */ static struct msgb *create_retransmission_response(const struct mgcp_endpoint *endp) { - struct msgb *msg = mgcp_msgb_alloc(); + struct msgb *msg = mgcp_msgb_alloc(endp->trunk); if (!msg) return NULL; @@ -196,15 +199,14 @@ return msg; } -static struct msgb *create_resp(struct mgcp_endpoint *endp, int code, - const char *txt, const char *msg, - const char *trans, const char *param, - const char *sdp) +static struct msgb *create_resp(void *msgctx, struct mgcp_endpoint *endp, int code, const char *txt, const char *msg, + const char *trans, const char *param, const char *sdp) { int len; struct msgb *res; - res = mgcp_msgb_alloc(); + OSMO_ASSERT(msgctx != 0); + res = mgcp_msgb_alloc(msgctx); if (!res) return NULL; @@ -236,26 +238,22 @@ return res; } -static struct msgb *create_ok_resp_with_param(struct mgcp_endpoint *endp, - int code, const char *msg, - const char *trans, - const char *param) +static struct msgb *create_ok_resp_with_param(void *msgctx, struct mgcp_endpoint *endp, int code, const char *msg, + const char *trans, const char *param) { - return create_resp(endp, code, " OK", msg, trans, param, NULL); + return create_resp(msgctx, endp, code, " OK", msg, trans, param, NULL); } -static struct msgb *create_ok_response(struct mgcp_endpoint *endp, - int code, const char *msg, +static struct msgb *create_ok_response(void *msgctx, struct mgcp_endpoint *endp, int code, const char *msg, const char *trans) { - return create_ok_resp_with_param(endp, code, msg, trans, NULL); + return create_ok_resp_with_param(msgctx, endp, code, msg, trans, NULL); } -static struct msgb *create_err_response(struct mgcp_endpoint *endp, - int code, const char *msg, +static struct msgb *create_err_response(void *msgctx, struct mgcp_endpoint *endp, int code, const char *msg, const char *trans) { - return create_resp(endp, code, " FAIL", msg, trans, NULL, NULL); + return create_resp(msgctx, endp, code, " FAIL", msg, trans, NULL, NULL); } /* Format MGCP response string (with SDP attached) */ @@ -278,7 +276,7 @@ int rc; struct msgb *result; - sdp = msgb_alloc_headroom(4096, 128, "sdp record"); + sdp = msgb_alloc_headroom_c(endp->trunk, 4096, 128, "sdp record"); if (!sdp) return NULL; @@ -309,7 +307,7 @@ rc = mgcp_write_response_sdp(endp, conn, sdp, addr); if (rc < 0) goto error; - result = create_resp(endp, 200, " OK", msg, trans_id, NULL, (char*) sdp->data); + result = create_resp(endp->trunk, endp, 200, " OK", msg, trans_id, NULL, (char *)sdp->data); msgb_free(sdp); return result; error: @@ -376,7 +374,7 @@ if (rc < 0) { LOGP(DLMGCP, LOGL_ERROR, "%s: failed to parse MCGP message\n", rq.name); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_GENERAL_RX_FAIL_MSG_PARSE)); - return create_err_response(NULL, -rc, rq.name, "000000"); + return create_err_response(cfg, NULL, -rc, rq.name, "000000"); } /* Locate endpoint and trunk, if no endpoint can be located try at least to identify the trunk. */ @@ -397,7 +395,7 @@ if (!rq.trunk) { LOGP(DLMGCP, LOGL_ERROR, "%s: failed to identify trunk for endpoint \"%s\" -- abort\n", rq.name, pdata.epname); - return create_err_response(NULL, -rq.mgcp_cause, rq.name, pdata.trans); + return create_err_response(cfg, NULL, -rq.mgcp_cause, rq.name, pdata.trans); } } else { /* If the endpoint name suggests that the request refers to a specific endpoint, then the @@ -405,7 +403,7 @@ LOGP(DLMGCP, LOGL_NOTICE, "%s: cannot find endpoint \"%s\", cause=%d -- abort\n", rq.name, pdata.epname, -rq.mgcp_cause); - return create_err_response(NULL, -rq.mgcp_cause, rq.name, pdata.trans); + return create_err_response(cfg, NULL, -rq.mgcp_cause, rq.name, pdata.trans); } } else { osmo_strlcpy(debug_last_endpoint_name, rq.endp->name, sizeof(debug_last_endpoint_name)); @@ -428,7 +426,7 @@ LOGP(DLMGCP, LOGL_ERROR, "%s: the request handler \"%s\" requires an endpoint resource for \"%s\", which is not available -- abort\n", rq.name, mgcp_requests[i].debug_name, pdata.epname); - return create_err_response(NULL, -rq.mgcp_cause, rq.name, pdata.trans); + return create_err_response(rq.trunk, NULL, -rq.mgcp_cause, rq.name, pdata.trans); } /* Execute request handler */ @@ -461,7 +459,7 @@ static struct msgb *handle_audit_endpoint(struct mgcp_request_data *rq) { LOGPENDP(rq->endp, DLMGCP, LOGL_NOTICE, "AUEP: auditing endpoint ...\n"); - return create_ok_response(rq->endp, 200, "AUEP", rq->pdata->trans); + return create_ok_response(rq->trunk, rq->endp, 200, "AUEP", rq->pdata->trans); } /* Try to find a free port by attempting to bind on it. Also handle the @@ -859,7 +857,7 @@ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: selected endpoint not available!\n"); - return create_err_response(NULL, 501, "CRCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 501, "CRCX", pdata->trans); } /* parse CallID C: and LocalParameters L: */ @@ -879,7 +877,7 @@ * together with a CRCX, the MGW will assign the * connection identifier by itself on CRCX */ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BAD_ACTION)); - return create_err_response(NULL, 523, "CRCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 523, "CRCX", pdata->trans); break; case 'M': mode = (const char *)line + 3; @@ -905,7 +903,7 @@ LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "CRCX: unhandled option: '%c'/%d\n", *line, *line); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_UNHANDLED_PARAM)); - return create_err_response(NULL, 539, "CRCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 539, "CRCX", pdata->trans); break; } } @@ -916,14 +914,14 @@ LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: insufficient parameters, missing callid\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_MISSING_CALLID)); - return create_err_response(endp, 516, "CRCX", pdata->trans); + return create_err_response(endp, endp, 516, "CRCX", pdata->trans); } if (!mode) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: insufficient parameters, missing mode\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); - return create_err_response(endp, 517, "CRCX", pdata->trans); + return create_err_response(endp, endp, 517, "CRCX", pdata->trans); } /* Check if we are able to accept the creation of another connection */ @@ -940,7 +938,7 @@ /* There is no more room for a connection, leave * everything as it is and return with an error */ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_LIMIT_EXCEEDED)); - return create_err_response(endp, 540, "CRCX", pdata->trans); + return create_err_response(endp, endp, 540, "CRCX", pdata->trans); } } @@ -958,7 +956,7 @@ /* This is not our call, leave everything as it is and * return with an error. */ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_UNKNOWN_CALLID)); - return create_err_response(endp, 400, "CRCX", pdata->trans); + return create_err_response(endp, endp, 400, "CRCX", pdata->trans); } } @@ -969,7 +967,7 @@ rc = mgcp_endp_claim(endp, callid); if (rc != 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_CLAIM)); - return create_err_response(endp, 502, "CRCX", pdata->trans); + return create_err_response(endp, endp, 502, "CRCX", pdata->trans); } } @@ -1088,7 +1086,7 @@ mgcp_endp_release(endp); LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "CRCX: unable to create connection\n"); - return create_err_response(endp, error_code, "CRCX", pdata->trans); + return create_err_response(endp, endp, error_code, "CRCX", pdata->trans); } /* MDCX command handler, processes the received command */ @@ -1116,7 +1114,7 @@ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_AVAIL)); LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: selected endpoint not available!\n"); - return create_err_response(NULL, 501, "MDCX", pdata->trans); + return create_err_response(endp, NULL, 501, "MDCX", pdata->trans); } /* Prohibit wildcarded requests */ @@ -1124,14 +1122,14 @@ LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: wildcarded endpoint names not supported.\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_WILDCARD)); - return create_err_response(endp, 507, "MDCX", pdata->trans); + return create_err_response(rq->trunk, endp, 507, "MDCX", pdata->trans); } if (llist_count(&endp->conns) <= 0) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: endpoint is not holding a connection.\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONN)); - return create_err_response(endp, 400, "MDCX", pdata->trans); + return create_err_response(endp, endp, 400, "MDCX", pdata->trans); } for_each_line(line, pdata->save) { @@ -1181,7 +1179,7 @@ "MDCX: Unhandled MGCP option: '%c'/%d\n", line[0], line[0]); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_UNHANDLED_PARAM)); - return create_err_response(NULL, 539, "MDCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 539, "MDCX", pdata->trans); break; } } @@ -1191,13 +1189,13 @@ LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: insufficient parameters, missing ci (connectionIdentifier)\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONNID)); - return create_err_response(endp, 515, "MDCX", pdata->trans); + return create_err_response(endp, endp, 515, "MDCX", pdata->trans); } conn = mgcp_conn_get_rtp(endp, conn_id); if (!conn) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_CONN_NOT_FOUND)); - return create_err_response(endp, 400, "MDCX", pdata->trans); + return create_err_response(endp, endp, 400, "MDCX", pdata->trans); } mgcp_conn_watchdog_kick(conn->conn); @@ -1304,7 +1302,7 @@ mgcp_endp_update(endp); return create_response_with_sdp(endp, conn, "MDCX", pdata->trans, false, false); error3: - return create_err_response(endp, error_code, "MDCX", pdata->trans); + return create_err_response(endp, endp, error_code, "MDCX", pdata->trans); out_silent: LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "MDCX: silent exit\n"); @@ -1335,14 +1333,14 @@ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_AVAIL)); LOGPENDP(endp, DLMGCP, LOGL_ERROR, "DLCX: selected endpoint not available!\n"); - return create_err_response(NULL, 501, "DLCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 501, "DLCX", pdata->trans); } if (endp && !rq->wildcarded && llist_empty(&endp->conns)) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "DLCX: endpoint is not holding a connection.\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_NO_CONN)); - return create_err_response(endp, 515, "DLCX", pdata->trans); + return create_err_response(endp, endp, 515, "DLCX", pdata->trans); } for_each_line(line, pdata->save) { @@ -1357,7 +1355,7 @@ LOGPTRUNK(trunk, DLMGCP, LOGL_NOTICE, "cannot handle requests with call-id (C) without endpoint -- abort!"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); - return create_err_response(NULL, 539, "DLCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); } if (mgcp_verify_call_id(endp, line + 3) != 0) { @@ -1373,7 +1371,7 @@ LOGPTRUNK(trunk, DLMGCP, LOGL_NOTICE, "cannot handle requests with conn-id (I) without endpoint -- abort!"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); - return create_err_response(NULL, 539, "DLCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); } conn_id = (const char *)line + 3; @@ -1389,7 +1387,7 @@ LOGPEPTR(endp, trunk, DLMGCP, LOGL_NOTICE, "DLCX: Unhandled MGCP option: '%c'/%d\n", line[0], line[0]); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_UNHANDLED_PARAM)); - return create_err_response(NULL, 539, "DLCX", pdata->trans); + return create_err_response(rq->trunk, NULL, 539, "DLCX", pdata->trans); break; } } @@ -1404,7 +1402,7 @@ mgcp_endp_release(trunk->endpoints[i]); } rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); - return create_ok_response(NULL, 200, "DLCX", pdata->trans); + return create_ok_response(trunk, NULL, 200, "DLCX", pdata->trans); } /* The logic does not permit to go past this point without having the @@ -1429,7 +1427,7 @@ /* Note: In this case we do not return any statistics, * as we assume that the client is not interested in * this case. */ - return create_ok_response(endp, 200, "DLCX", pdata->trans); + return create_ok_response(endp, endp, 200, "DLCX", pdata->trans); } /* Find the connection */ @@ -1458,10 +1456,10 @@ rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS)); if (silent) goto out_silent; - return create_ok_resp_with_param(endp, 250, "DLCX", pdata->trans, stats); + return create_ok_resp_with_param(endp, endp, 250, "DLCX", pdata->trans, stats); error3: - return create_err_response(endp, error_code, "DLCX", pdata->trans); + return create_err_response(endp, endp, error_code, "DLCX", pdata->trans); out_silent: LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "DLCX: silent exit\n"); @@ -1516,14 +1514,13 @@ /* we didn't see a signal request with a tone */ if (tone == CHAR_MAX) - return create_ok_response(rq->endp, 200, "RQNT", rq->pdata->trans); + return create_ok_response(rq->endp, rq->endp, 200, "RQNT", rq->pdata->trans); if (rq->pdata->cfg->rqnt_cb) res = rq->pdata->cfg->rqnt_cb(rq->endp, tone); - return res == 0 ? - create_ok_response(rq->endp, 200, "RQNT", rq->pdata->trans) : - create_err_response(rq->endp, res, "RQNT", rq->pdata->trans); + return res == 0 ? create_ok_response(rq->endp, rq->endp, 200, "RQNT", rq->pdata->trans) : + create_err_response(rq->endp, rq->endp, res, "RQNT", rq->pdata->trans); } /* Connection keepalive timer, will take care that dummy packets are send -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8 Gerrit-Change-Number: 25447 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:20:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:20:09 +0000 Subject: Change in osmo-mgw[master]: rework message handling In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 ) Change subject: rework message handling ...................................................................... rework message handling This was previously broken and a free endpoint was requirted to dlcx *, additionaly globally handling this is difficult due to different response codes, so just do it in the functions, they know best. Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 56 insertions(+), 57 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index f4cdd76..5b88c7a 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -97,10 +97,6 @@ /* function pointer to the request handler */ struct msgb *(*handle_request)(struct mgcp_request_data *data); - /* true if the request requires an endpoint, false if only a trunk - * is sufficient. (corner cases, e.g. wildcarded DLCX) */ - bool require_endp; - /* a human readable name that describes the request */ char *debug_name; }; @@ -112,32 +108,34 @@ static struct msgb *handle_rsip(struct mgcp_request_data *data); static struct msgb *handle_noti_req(struct mgcp_request_data *data); static const struct mgcp_request mgcp_requests[] = { - { .name = "AUEP", - .handle_request = handle_audit_endpoint, - .debug_name = "AuditEndpoint", - .require_endp = true }, - { .name = "CRCX", - .handle_request = handle_create_con, - .debug_name = "CreateConnection", - .require_endp = true }, - { .name = "DLCX", - .handle_request = handle_delete_con, - .debug_name = "DeleteConnection", - .require_endp = false }, - { .name = "MDCX", - .handle_request = handle_modify_con, - .debug_name = "ModifiyConnection", - .require_endp = true }, - { .name = "RQNT", - .handle_request = handle_noti_req, - .debug_name = "NotificationRequest", - .require_endp = true }, + { .name = "AUEP", .handle_request = handle_audit_endpoint, .debug_name = "AuditEndpoint" }, + { + .name = "CRCX", + .handle_request = handle_create_con, + .debug_name = "CreateConnection", + }, + { + .name = "DLCX", + .handle_request = handle_delete_con, + .debug_name = "DeleteConnection", + }, + { + .name = "MDCX", + .handle_request = handle_modify_con, + .debug_name = "ModifiyConnection", + }, + { + .name = "RQNT", + .handle_request = handle_noti_req, + .debug_name = "NotificationRequest", + }, /* SPEC extension */ - { .name = "RSIP", - .handle_request = handle_rsip, - .debug_name = "ReSetInProgress", - .require_endp = true }, + { + .name = "RSIP", + .handle_request = handle_rsip, + .debug_name = "ReSetInProgress", + }, }; /* Initalize transcoder */ @@ -420,15 +418,6 @@ /* Find an appropriate handler for the current request and execute it */ for (i = 0; i < ARRAY_SIZE(mgcp_requests); i++) { if (strcmp(mgcp_requests[i].name, rq.name) == 0) { - /* Check if the request requires and endpoint, if yes, check if we have it, otherwise don't - * execute the request handler. */ - if (mgcp_requests[i].require_endp && !rq.endp) { - LOGP(DLMGCP, LOGL_ERROR, - "%s: the request handler \"%s\" requires an endpoint resource for \"%s\", which is not available -- abort\n", - rq.name, mgcp_requests[i].debug_name, pdata.epname); - return create_err_response(rq.trunk, NULL, -rq.mgcp_cause, rq.name, pdata.trans); - } - /* Execute request handler */ if (rq.endp) LOGP(DLMGCP, LOGL_INFO, @@ -459,6 +448,11 @@ static struct msgb *handle_audit_endpoint(struct mgcp_request_data *rq) { LOGPENDP(rq->endp, DLMGCP, LOGL_NOTICE, "AUEP: auditing endpoint ...\n"); + if (!rq->endp || !mgcp_endp_avail(rq->endp)) { + LOGPENDP(rq->endp, DLMGCP, LOGL_ERROR, "AUEP: selected endpoint not available!\n"); + return create_err_response(rq->trunk, NULL, 501, "AUEP", rq->pdata->trans); + } + return create_ok_response(rq->trunk, rq->endp, 200, "AUEP", rq->pdata->trans); } @@ -853,6 +847,13 @@ LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "CRCX: creating new connection ...\n"); + /* we must have a free ep */ + if (!endp) { + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); + LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: no free endpoints available!\n"); + return create_err_response(rq->trunk, NULL, 403, "CRCX", pdata->trans); + } + if (!mgcp_endp_avail(endp)) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_AVAIL)); LOGPENDP(endp, DLMGCP, LOGL_ERROR, @@ -1110,13 +1111,6 @@ LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "MDCX: modifying existing connection ...\n"); - if (!mgcp_endp_avail(endp)) { - rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_AVAIL)); - LOGPENDP(endp, DLMGCP, LOGL_ERROR, - "MDCX: selected endpoint not available!\n"); - return create_err_response(endp, NULL, 501, "MDCX", pdata->trans); - } - /* Prohibit wildcarded requests */ if (rq->wildcarded) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, @@ -1125,6 +1119,11 @@ return create_err_response(rq->trunk, endp, 507, "MDCX", pdata->trans); } + if (!endp || !mgcp_endp_avail(endp)) { + rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_AVAIL)); + LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: selected endpoint not available!\n"); + return create_err_response(rq->trunk, NULL, 501, "MDCX", pdata->trans); + } if (llist_count(&endp->conns) <= 0) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: endpoint is not holding a connection.\n"); @@ -1343,6 +1342,19 @@ return create_err_response(endp, endp, 515, "DLCX", pdata->trans); } + /* Handle wildcarded DLCX that refers to the whole trunk. This means + * that we walk over all endpoints on the trunk in order to drop all + * connections on the trunk. (see also RFC3435 Annex F.7) */ + if (rq->wildcarded) { + int num_conns = 0; + for (i = 0; i < trunk->number_endpoints; i++) { + num_conns += llist_count(&trunk->endpoints[i]->conns); + mgcp_endp_release(trunk->endpoints[i]); + } + rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); + return create_ok_response(trunk, NULL, 200, "DLCX", pdata->trans); + } + for_each_line(line, pdata->save) { if (!mgcp_check_param(endp, trunk, line)) continue; @@ -1392,19 +1404,6 @@ } } - /* Handle wildcarded DLCX that refers to the whole trunk. This means - * that we walk over all endpoints on the trunk in order to drop all - * connections on the trunk. (see also RFC3435 Annex F.7) */ - if (rq->wildcarded) { - int num_conns = 0; - for (i = 0; i < trunk->number_endpoints; i++) { - num_conns += llist_count(&trunk->endpoints[i]->conns); - mgcp_endp_release(trunk->endpoints[i]); - } - rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); - return create_ok_response(trunk, NULL, 200, "DLCX", pdata->trans); - } - /* The logic does not permit to go past this point without having the * the endp pointer populated. */ OSMO_ASSERT(endp); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd Gerrit-Change-Number: 26189 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:20:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:20:10 +0000 Subject: Change in osmo-mgw[master]: add a lock-free bounded spsc interthread queue In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25431 ) Change subject: add a lock-free bounded spsc interthread queue ...................................................................... add a lock-free bounded spsc interthread queue Not entirely wait-free: allows waiting on a fd, and in general fd notifications for poll-loop integration between threads. Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 --- A include/osmocom/mgcp/mgcp_threads_queue.h A src/libosmo-mgcp/mgcp_threads_queue.c 2 files changed, 259 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/mgcp/mgcp_threads_queue.h b/include/osmocom/mgcp/mgcp_threads_queue.h new file mode 100644 index 0000000..bf094f5 --- /dev/null +++ b/include/osmocom/mgcp/mgcp_threads_queue.h @@ -0,0 +1,52 @@ +/* + * (C) 2021 by sysmocom s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Eric Wild + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include + +struct spsc { + atomic_uint readptr; + atomic_uint writeptr; + + int efd_r, efd_w; /* eventfds used to block/notify readers/writers */ + + int count; + int size_per_buf; + + void *buf; /* buffer size count*size_per_buf */ + uintptr_t data[0]; /* count sized array of pointers to size_per_buf chunks in buf array*/ +}; + +struct qchan { + struct spsc *a; + struct spsc *b; +}; + +bool spsc_push(struct spsc *q, void *elem); +bool spsc_pop(struct spsc *q, void *elem); +ssize_t spsc_prep_pop(struct spsc *q); +int spsc_get_a_rdfd(struct qchan *q); + +struct qchan spsc_chan_init(void *talloc_ctx, unsigned int count, unsigned int size_per_buf); +struct qchan spsc_chan_init_ex(void *talloc_ctx, unsigned int count, unsigned int size_per_buf, bool blockr_a, + bool blockw_a, bool blockr_b, bool blockw_b); +void spsc_chan_close(struct qchan *q); diff --git a/src/libosmo-mgcp/mgcp_threads_queue.c b/src/libosmo-mgcp/mgcp_threads_queue.c new file mode 100644 index 0000000..8d10e36 --- /dev/null +++ b/src/libosmo-mgcp/mgcp_threads_queue.c @@ -0,0 +1,207 @@ +/* + * (C) 2021 by sysmocom s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Eric Wild + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +/* +classic lamport circular lockfree spsc queue: +every "side" only writes its own ptr, but may read the other sides ptr + +notify reader using eventfd as soon as element is added, reader then reads until +read fails +-> reader pops in a loop until FALSE and might get spurious events because it +read before it was notified, which is fine +-> writing pushes *the same data* in a loop until TRUE, blocks + +shutting this down requires +1) to stop reading and pushing +2) ONE side to take care of the eventfds +*/ + +static struct spsc *spsc_init(void *talloc_ctx, unsigned int count, unsigned int size_per_buf, bool blockr, bool blockw) +{ + struct spsc *q = talloc_zero_size(talloc_ctx, sizeof(struct spsc) + sizeof(uintptr_t) * count); + atomic_init(&q->readptr, 0); + atomic_init(&q->writeptr, 0); + q->efd_r = eventfd(0, blockr ? 0 : EFD_NONBLOCK); + q->efd_w = eventfd(1, blockw ? 0 : EFD_NONBLOCK); + q->count = count; + q->size_per_buf = size_per_buf; + q->buf = talloc_zero_size(q, size_per_buf * count); + + for (int i = 0; i < count; i++) + q->data[i] = (uintptr_t)q->buf + i * size_per_buf; + return q; +} + +static void spsc_deinit(struct spsc *q) +{ + talloc_free(q->buf); + close(q->efd_r); + close(q->efd_w); + talloc_free(q); +} + +static ssize_t spsc_check_r(struct spsc *q) +{ + uint64_t efdr; + return read(q->efd_r, &efdr, sizeof(uint64_t)); +} +static ssize_t spsc_check_w(struct spsc *q) +{ + uint64_t efdr; + return read(q->efd_w, &efdr, sizeof(uint64_t)); +} +static void spsc_notify_r(struct spsc *q) +{ + uint64_t efdu = 1; + write(q->efd_r, &efdu, sizeof(uint64_t)); +} +static void spsc_notify_w(struct spsc *q) +{ + uint64_t efdu = 1; + write(q->efd_w, &efdu, sizeof(uint64_t)); +} + +/*! Adds element to the queue by copying the data. + * \param[in] q queue. + * \param[in] elem input buffer, must match the originally configured queue buffer size!. + * \returns true if queue was not full and element was successfully pushed */ +bool spsc_push(struct spsc *q, void *elem) +{ + size_t cur_wp, cur_rp; + cur_wp = atomic_load_explicit(&q->writeptr, memory_order_relaxed); + cur_rp = atomic_load_explicit(&q->readptr, memory_order_acquire); + if ((cur_wp + 1) % q->count == cur_rp) { + spsc_check_w(q); /* blocks, ensures next (!) call succeeds */ + return false; + } + memcpy((void *)q->data[cur_wp], elem, q->size_per_buf); + atomic_store_explicit(&q->writeptr, (cur_wp + 1) % q->count, memory_order_release); + spsc_notify_r(q); /* fine after release */ + return true; +} + +/*! Reads the read-fd of the queue, which, depending on settings passed on queue creation, blocks. + * This function can be used to deliberately wait for a non-empty queue on the read side. + * \param[in] q queue. + * \returns result of reading the fd. */ +ssize_t spsc_prep_pop(struct spsc *q) +{ + return spsc_check_r(q); +} + +/*! Removes element from the queue by copying the data. + * \param[in] q queue. + * \param[in] elem output buffer, must match the originally configured queue buffer size!. + * \returns true if queue was not empty and element was successfully removed */ +bool spsc_pop(struct spsc *q, void *elem) +{ + size_t cur_wp, cur_rp; + cur_wp = atomic_load_explicit(&q->writeptr, memory_order_acquire); + cur_rp = atomic_load_explicit(&q->readptr, memory_order_relaxed); + + if (cur_wp == cur_rp) /* blocks via prep_pop */ + return false; + memcpy(elem, (void *)q->data[cur_rp], q->size_per_buf); + atomic_store_explicit(&q->readptr, (cur_rp + 1) % q->count, memory_order_release); + spsc_notify_w(q); + return true; +} + +/*! Creates a bidirectional queue channel that consists of two queues, one in each direction, + * commonly referred to as a and b side. + * \param[in] talloc_ctx allocation context. + * \param[in] count number of buffers per queue. + * \param[in] size_per_buf size of buffers per queue. + * \param[in] blockr_a should reading the a-side read fd block?. + * \param[in] blockw_a should reading the a-side write fd block?. + * \param[in] blockr_b should reading the b-side read fd block?. + * \param[in] blockw_b should reading the b-side write fd block?. + * \returns queue channel */ +struct qchan spsc_chan_init_ex(void *talloc_ctx, unsigned int count, unsigned int size_per_buf, bool blockr_a, + bool blockw_a, bool blockr_b, bool blockw_b) +{ + struct qchan q; + q.a = spsc_init(talloc_ctx, count, size_per_buf, blockr_a, blockw_a); + q.b = spsc_init(talloc_ctx, count, size_per_buf, blockr_b, blockw_b); + return q; +} + +/*! Creates a bidirectional queue channel that consists of two queues, one in each direction, + * commonly referred to as a and b side. + * \param[in] talloc_ctx allocation context. + * \param[in] count number of buffers per queue. + * \param[in] size_per_buf size of buffers per queue. + * \returns queue channel */ +struct qchan spsc_chan_init(void *talloc_ctx, unsigned int count, unsigned int size_per_buf) +{ + return spsc_chan_init_ex(talloc_ctx, count, size_per_buf, false, true, false, true); +} + +/*! Closes a bidirectional queue channel. + * \param[in] q queue */ +void spsc_chan_close(struct qchan *q) +{ + spsc_deinit(q->a); + spsc_deinit(q->b); + free(q); +} + +/*! Gets queue channel read/write fd for a/b side according to function name. + * \param[in] q queue channel. + * \returns fd */ +int spsc_get_a_rdfd(struct qchan *q) +{ + return q->a->efd_r; +} +/*! Gets queue channel read/write fd for a/b side according to function name. + * \param[in] q queue channel. + * \returns fd */ +int spsc_get_b_rdfd(struct qchan *q) +{ + return q->b->efd_r; +} +/*! Gets queue channel read/write fd for a/b side according to function name. + * \param[in] q queue channel. + * \returns fd */ +int spsc_get_a_wrfd(struct qchan *q) +{ + return q->a->efd_w; +} +/*! Gets queue channel read/write fd for a/b side according to function name. + * \param[in] q queue channel. + * \returns fd */ +int spsc_get_b_wrfd(struct qchan *q) +{ + return q->b->efd_w; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f17042baf76d086ce6b20eb99402dc64c22c657 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 23 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:20:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:20:11 +0000 Subject: Change in osmo-mgw[master]: clang-format: remove foreach macros In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26191 ) Change subject: clang-format: remove foreach macros ...................................................................... clang-format: remove foreach macros We don't really care about the kernel style after all and the linter complains about proper formatting, so remove all for-like macros so we don't accidentally apply kernel style formatting. Change-Id: Ia1b5848b31470b694a2031ad83e84f3132212f94 --- M .clang-format 1 file changed, 0 insertions(+), 445 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/.clang-format b/.clang-format index 5d4791c..2abc64d 100644 --- a/.clang-format +++ b/.clang-format @@ -64,451 +64,6 @@ ExperimentalAutoDetectBinPacking: false #FixNamespaceComments: false # Unknown to clang-format-4.0 -# Taken from: -# git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' include/ \ -# | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$, - '\1'," \ -# | sort | uniq -ForEachMacros: - - 'apei_estatus_for_each_section' - - 'ata_for_each_dev' - - 'ata_for_each_link' - - '__ata_qc_for_each' - - 'ata_qc_for_each' - - 'ata_qc_for_each_raw' - - 'ata_qc_for_each_with_internal' - - 'ax25_for_each' - - 'ax25_uid_for_each' - - '__bio_for_each_bvec' - - 'bio_for_each_bvec' - - 'bio_for_each_bvec_all' - - 'bio_for_each_integrity_vec' - - '__bio_for_each_segment' - - 'bio_for_each_segment' - - 'bio_for_each_segment_all' - - 'bio_list_for_each' - - 'bip_for_each_vec' - - 'bitmap_for_each_clear_region' - - 'bitmap_for_each_set_region' - - 'blkg_for_each_descendant_post' - - 'blkg_for_each_descendant_pre' - - 'blk_queue_for_each_rl' - - 'bond_for_each_slave' - - 'bond_for_each_slave_rcu' - - 'bpf_for_each_spilled_reg' - - 'btree_for_each_safe128' - - 'btree_for_each_safe32' - - 'btree_for_each_safe64' - - 'btree_for_each_safel' - - 'card_for_each_dev' - - 'cgroup_taskset_for_each' - - 'cgroup_taskset_for_each_leader' - - 'cpufreq_for_each_entry' - - 'cpufreq_for_each_entry_idx' - - 'cpufreq_for_each_valid_entry' - - 'cpufreq_for_each_valid_entry_idx' - - 'css_for_each_child' - - 'css_for_each_descendant_post' - - 'css_for_each_descendant_pre' - - 'device_for_each_child_node' - - 'displayid_iter_for_each' - - 'dma_fence_chain_for_each' - - 'do_for_each_ftrace_op' - - 'drm_atomic_crtc_for_each_plane' - - 'drm_atomic_crtc_state_for_each_plane' - - 'drm_atomic_crtc_state_for_each_plane_state' - - 'drm_atomic_for_each_plane_damage' - - 'drm_client_for_each_connector_iter' - - 'drm_client_for_each_modeset' - - 'drm_connector_for_each_possible_encoder' - - 'drm_for_each_bridge_in_chain' - - 'drm_for_each_connector_iter' - - 'drm_for_each_crtc' - - 'drm_for_each_crtc_reverse' - - 'drm_for_each_encoder' - - 'drm_for_each_encoder_mask' - - 'drm_for_each_fb' - - 'drm_for_each_legacy_plane' - - 'drm_for_each_plane' - - 'drm_for_each_plane_mask' - - 'drm_for_each_privobj' - - 'drm_mm_for_each_hole' - - 'drm_mm_for_each_node' - - 'drm_mm_for_each_node_in_range' - - 'drm_mm_for_each_node_safe' - - 'flow_action_for_each' - - 'for_each_acpi_dev_match' - - 'for_each_active_dev_scope' - - 'for_each_active_drhd_unit' - - 'for_each_active_iommu' - - 'for_each_aggr_pgid' - - 'for_each_available_child_of_node' - - 'for_each_bio' - - 'for_each_board_func_rsrc' - - 'for_each_bvec' - - 'for_each_card_auxs' - - 'for_each_card_auxs_safe' - - 'for_each_card_components' - - 'for_each_card_dapms' - - 'for_each_card_pre_auxs' - - 'for_each_card_prelinks' - - 'for_each_card_rtds' - - 'for_each_card_rtds_safe' - - 'for_each_card_widgets' - - 'for_each_card_widgets_safe' - - 'for_each_cgroup_storage_type' - - 'for_each_child_of_node' - - 'for_each_clear_bit' - - 'for_each_clear_bit_from' - - 'for_each_cmsghdr' - - 'for_each_compatible_node' - - 'for_each_component_dais' - - 'for_each_component_dais_safe' - - 'for_each_comp_order' - - 'for_each_console' - - 'for_each_cpu' - - 'for_each_cpu_and' - - 'for_each_cpu_not' - - 'for_each_cpu_wrap' - - 'for_each_dapm_widgets' - - 'for_each_dev_addr' - - 'for_each_dev_scope' - - 'for_each_dma_cap_mask' - - 'for_each_dpcm_be' - - 'for_each_dpcm_be_rollback' - - 'for_each_dpcm_be_safe' - - 'for_each_dpcm_fe' - - 'for_each_drhd_unit' - - 'for_each_dss_dev' - - 'for_each_dtpm_table' - - 'for_each_efi_memory_desc' - - 'for_each_efi_memory_desc_in_map' - - 'for_each_element' - - 'for_each_element_extid' - - 'for_each_element_id' - - 'for_each_endpoint_of_node' - - 'for_each_evictable_lru' - - 'for_each_fib6_node_rt_rcu' - - 'for_each_fib6_walker_rt' - - 'for_each_free_mem_pfn_range_in_zone' - - 'for_each_free_mem_pfn_range_in_zone_from' - - 'for_each_free_mem_range' - - 'for_each_free_mem_range_reverse' - - 'for_each_func_rsrc' - - 'for_each_hstate' - - 'for_each_if' - - 'for_each_iommu' - - 'for_each_ip_tunnel_rcu' - - 'for_each_irq_nr' - - 'for_each_link_codecs' - - 'for_each_link_cpus' - - 'for_each_link_platforms' - - 'for_each_lru' - - 'for_each_matching_node' - - 'for_each_matching_node_and_match' - - 'for_each_member' - - 'for_each_memcg_cache_index' - - 'for_each_mem_pfn_range' - - '__for_each_mem_range' - - 'for_each_mem_range' - - '__for_each_mem_range_rev' - - 'for_each_mem_range_rev' - - 'for_each_mem_region' - - 'for_each_migratetype_order' - - 'for_each_msi_entry' - - 'for_each_msi_entry_safe' - - 'for_each_msi_vector' - - 'for_each_net' - - 'for_each_net_continue_reverse' - - 'for_each_netdev' - - 'for_each_netdev_continue' - - 'for_each_netdev_continue_rcu' - - 'for_each_netdev_continue_reverse' - - 'for_each_netdev_feature' - - 'for_each_netdev_in_bond_rcu' - - 'for_each_netdev_rcu' - - 'for_each_netdev_reverse' - - 'for_each_netdev_safe' - - 'for_each_net_rcu' - - 'for_each_new_connector_in_state' - - 'for_each_new_crtc_in_state' - - 'for_each_new_mst_mgr_in_state' - - 'for_each_new_plane_in_state' - - 'for_each_new_private_obj_in_state' - - 'for_each_node' - - 'for_each_node_by_name' - - 'for_each_node_by_type' - - 'for_each_node_mask' - - 'for_each_node_state' - - 'for_each_node_with_cpus' - - 'for_each_node_with_property' - - 'for_each_nonreserved_multicast_dest_pgid' - - 'for_each_of_allnodes' - - 'for_each_of_allnodes_from' - - 'for_each_of_cpu_node' - - 'for_each_of_pci_range' - - 'for_each_old_connector_in_state' - - 'for_each_old_crtc_in_state' - - 'for_each_old_mst_mgr_in_state' - - 'for_each_oldnew_connector_in_state' - - 'for_each_oldnew_crtc_in_state' - - 'for_each_oldnew_mst_mgr_in_state' - - 'for_each_oldnew_plane_in_state' - - 'for_each_oldnew_plane_in_state_reverse' - - 'for_each_oldnew_private_obj_in_state' - - 'for_each_old_plane_in_state' - - 'for_each_old_private_obj_in_state' - - 'for_each_online_cpu' - - 'for_each_online_node' - - 'for_each_online_pgdat' - - 'for_each_pci_bridge' - - 'for_each_pci_dev' - - 'for_each_pci_msi_entry' - - 'for_each_pcm_streams' - - 'for_each_physmem_range' - - 'for_each_populated_zone' - - 'for_each_possible_cpu' - - 'for_each_present_cpu' - - 'for_each_prime_number' - - 'for_each_prime_number_from' - - 'for_each_process' - - 'for_each_process_thread' - - 'for_each_prop_codec_conf' - - 'for_each_prop_dai_codec' - - 'for_each_prop_dai_cpu' - - 'for_each_prop_dlc_codecs' - - 'for_each_prop_dlc_cpus' - - 'for_each_prop_dlc_platforms' - - 'for_each_property_of_node' - - 'for_each_registered_fb' - - 'for_each_requested_gpio' - - 'for_each_requested_gpio_in_range' - - 'for_each_reserved_mem_range' - - 'for_each_reserved_mem_region' - - 'for_each_rtd_codec_dais' - - 'for_each_rtd_components' - - 'for_each_rtd_cpu_dais' - - 'for_each_rtd_dais' - - 'for_each_set_bit' - - 'for_each_set_bit_from' - - 'for_each_set_clump8' - - 'for_each_sg' - - 'for_each_sg_dma_page' - - 'for_each_sg_page' - - 'for_each_sgtable_dma_page' - - 'for_each_sgtable_dma_sg' - - 'for_each_sgtable_page' - - 'for_each_sgtable_sg' - - 'for_each_sibling_event' - - 'for_each_subelement' - - 'for_each_subelement_extid' - - 'for_each_subelement_id' - - '__for_each_thread' - - 'for_each_thread' - - 'for_each_unicast_dest_pgid' - - 'for_each_vsi' - - 'for_each_wakeup_source' - - 'for_each_zone' - - 'for_each_zone_zonelist' - - 'for_each_zone_zonelist_nodemask' - - 'fwnode_for_each_available_child_node' - - 'fwnode_for_each_child_node' - - 'fwnode_graph_for_each_endpoint' - - 'gadget_for_each_ep' - - 'genradix_for_each' - - 'genradix_for_each_from' - - 'hash_for_each' - - 'hash_for_each_possible' - - 'hash_for_each_possible_rcu' - - 'hash_for_each_possible_rcu_notrace' - - 'hash_for_each_possible_safe' - - 'hash_for_each_rcu' - - 'hash_for_each_safe' - - 'hctx_for_each_ctx' - - 'hlist_bl_for_each_entry' - - 'hlist_bl_for_each_entry_rcu' - - 'hlist_bl_for_each_entry_safe' - - 'hlist_for_each' - - 'hlist_for_each_entry' - - 'hlist_for_each_entry_continue' - - 'hlist_for_each_entry_continue_rcu' - - 'hlist_for_each_entry_continue_rcu_bh' - - 'hlist_for_each_entry_from' - - 'hlist_for_each_entry_from_rcu' - - 'hlist_for_each_entry_rcu' - - 'hlist_for_each_entry_rcu_bh' - - 'hlist_for_each_entry_rcu_notrace' - - 'hlist_for_each_entry_safe' - - 'hlist_for_each_entry_srcu' - - '__hlist_for_each_rcu' - - 'hlist_for_each_safe' - - 'hlist_nulls_for_each_entry' - - 'hlist_nulls_for_each_entry_from' - - 'hlist_nulls_for_each_entry_rcu' - - 'hlist_nulls_for_each_entry_safe' - - 'i3c_bus_for_each_i2cdev' - - 'i3c_bus_for_each_i3cdev' - - 'ide_host_for_each_port' - - 'ide_port_for_each_dev' - - 'ide_port_for_each_present_dev' - - 'idr_for_each_entry' - - 'idr_for_each_entry_continue' - - 'idr_for_each_entry_continue_ul' - - 'idr_for_each_entry_ul' - - 'in_dev_for_each_ifa_rcu' - - 'in_dev_for_each_ifa_rtnl' - - 'inet_bind_bucket_for_each' - - 'inet_lhash2_for_each_icsk_rcu' - - 'key_for_each' - - 'key_for_each_safe' - - 'klp_for_each_func' - - 'klp_for_each_func_safe' - - 'klp_for_each_func_static' - - 'klp_for_each_object' - - 'klp_for_each_object_safe' - - 'klp_for_each_object_static' - - 'kunit_suite_for_each_test_case' - - 'kvm_for_each_memslot' - - 'kvm_for_each_vcpu' - - 'list_for_each' - - 'list_for_each_codec' - - 'list_for_each_codec_safe' - - 'list_for_each_continue' - - 'list_for_each_entry' - - 'list_for_each_entry_continue' - - 'list_for_each_entry_continue_rcu' - - 'list_for_each_entry_continue_reverse' - - 'list_for_each_entry_from' - - 'list_for_each_entry_from_rcu' - - 'list_for_each_entry_from_reverse' - - 'list_for_each_entry_lockless' - - 'list_for_each_entry_rcu' - - 'list_for_each_entry_reverse' - - 'list_for_each_entry_safe' - - 'list_for_each_entry_safe_continue' - - 'list_for_each_entry_safe_from' - - 'list_for_each_entry_safe_reverse' - - 'list_for_each_entry_srcu' - - 'list_for_each_prev' - - 'list_for_each_prev_safe' - - 'list_for_each_safe' - - 'llist_for_each' - - 'llist_for_each_entry' - - 'llist_for_each_entry_safe' - - 'llist_for_each_safe' - - 'mci_for_each_dimm' - - 'media_device_for_each_entity' - - 'media_device_for_each_intf' - - 'media_device_for_each_link' - - 'media_device_for_each_pad' - - 'nanddev_io_for_each_page' - - 'netdev_for_each_lower_dev' - - 'netdev_for_each_lower_private' - - 'netdev_for_each_lower_private_rcu' - - 'netdev_for_each_mc_addr' - - 'netdev_for_each_uc_addr' - - 'netdev_for_each_upper_dev_rcu' - - 'netdev_hw_addr_list_for_each' - - 'nft_rule_for_each_expr' - - 'nla_for_each_attr' - - 'nla_for_each_nested' - - 'nlmsg_for_each_attr' - - 'nlmsg_for_each_msg' - - 'nr_neigh_for_each' - - 'nr_neigh_for_each_safe' - - 'nr_node_for_each' - - 'nr_node_for_each_safe' - - 'of_for_each_phandle' - - 'of_property_for_each_string' - - 'of_property_for_each_u32' - - 'pci_bus_for_each_resource' - - 'pcl_for_each_chunk' - - 'pcl_for_each_segment' - - 'pcm_for_each_format' - - 'ping_portaddr_for_each_entry' - - 'plist_for_each' - - 'plist_for_each_continue' - - 'plist_for_each_entry' - - 'plist_for_each_entry_continue' - - 'plist_for_each_entry_safe' - - 'plist_for_each_safe' - - 'pnp_for_each_card' - - 'pnp_for_each_dev' - - 'protocol_for_each_card' - - 'protocol_for_each_dev' - - 'queue_for_each_hw_ctx' - - 'radix_tree_for_each_slot' - - 'radix_tree_for_each_tagged' - - 'rb_for_each' - - 'rbtree_postorder_for_each_entry_safe' - - 'rdma_for_each_block' - - 'rdma_for_each_port' - - 'rdma_umem_for_each_dma_block' - - 'resource_list_for_each_entry' - - 'resource_list_for_each_entry_safe' - - 'rhl_for_each_entry_rcu' - - 'rhl_for_each_rcu' - - 'rht_for_each' - - 'rht_for_each_entry' - - 'rht_for_each_entry_from' - - 'rht_for_each_entry_rcu' - - 'rht_for_each_entry_rcu_from' - - 'rht_for_each_entry_safe' - - 'rht_for_each_from' - - 'rht_for_each_rcu' - - 'rht_for_each_rcu_from' - - '__rq_for_each_bio' - - 'rq_for_each_bvec' - - 'rq_for_each_segment' - - 'scsi_for_each_prot_sg' - - 'scsi_for_each_sg' - - 'sctp_for_each_hentry' - - 'sctp_skb_for_each' - - 'shdma_for_each_chan' - - '__shost_for_each_device' - - 'shost_for_each_device' - - 'sk_for_each' - - 'sk_for_each_bound' - - 'sk_for_each_entry_offset_rcu' - - 'sk_for_each_from' - - 'sk_for_each_rcu' - - 'sk_for_each_safe' - - 'sk_nulls_for_each' - - 'sk_nulls_for_each_from' - - 'sk_nulls_for_each_rcu' - - 'snd_array_for_each' - - 'snd_pcm_group_for_each_entry' - - 'snd_soc_dapm_widget_for_each_path' - - 'snd_soc_dapm_widget_for_each_path_safe' - - 'snd_soc_dapm_widget_for_each_sink_path' - - 'snd_soc_dapm_widget_for_each_source_path' - - 'tb_property_for_each' - - 'tcf_exts_for_each_action' - - 'udp_portaddr_for_each_entry' - - 'udp_portaddr_for_each_entry_rcu' - - 'usb_hub_for_each_child' - - 'v4l2_device_for_each_subdev' - - 'v4l2_m2m_for_each_dst_buf' - - 'v4l2_m2m_for_each_dst_buf_safe' - - 'v4l2_m2m_for_each_src_buf' - - 'v4l2_m2m_for_each_src_buf_safe' - - 'virtio_device_for_each_vq' - - 'while_for_each_ftrace_op' - - 'xa_for_each' - - 'xa_for_each_marked' - - 'xa_for_each_range' - - 'xa_for_each_start' - - 'xas_for_each' - - 'xas_for_each_conflict' - - 'xas_for_each_marked' - - 'xbc_array_for_each_value' - - 'xbc_for_each_key_value' - - 'xbc_node_for_each_array_value' - - 'xbc_node_for_each_child' - - 'xbc_node_for_each_key_value' - - 'zorro_for_each_dev' - - 'for_each_line' - - 'for_each_non_empty_line' - #IncludeBlocks: Preserve # Unknown to clang-format-5.0 IncludeCategories: - Regex: '.*' -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1b5848b31470b694a2031ad83e84f3132212f94 Gerrit-Change-Number: 26191 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:20:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Nov 2021 21:20:11 +0000 Subject: Change in osmo-mgw[master]: fix mgcp_conn_free_all ubsan complaints In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26192 ) Change subject: fix mgcp_conn_free_all ubsan complaints ...................................................................... fix mgcp_conn_free_all ubsan complaints ubsan still complains about a unaligned load that can't be explained, so silence it: /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime error: member access within misaligned address 0x612000000249 for type 'const struct llist_head', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15: runtime error: load of misaligned address 0x612000000249 for type 'struct llist_head *const', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mgw-threads/install/include/osmocom/core/linuxlist.h:171:15 in mgcp_conn.c:303:17: runtime error: member access within misaligned address 0x612000000249 for type 'struct llist_head', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:303:17 in mgcp_conn.c:303:17: runtime error: load of misaligned address 0x612000000249 for type 'struct llist_head *', which requires 8 byte alignment 0x612000000249: note: pointer points here 00 00 00 48 02 00 00 20 61 00 00 48 02 00 00 20 61 00 00 60 02 00 00 a0 62 00 00 80 1f 49 00 00 ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:303:17 in mgcp_conn.c:304:30: runtime error: member access within misaligned address 0x4800006120000002 for type 'struct mgcp_conn', which requires 8 byte alignment 0x4800006120000002: note: pointer points here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior mgcp_conn.c:304:30 in AddressSanitizer:DEADLYSIGNAL ================================================================= ==223426==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x0000004553f7 bp 0x7ffda5855080 sp 0x7ffda5855040 T0) ==223426==The signal is caused by a READ memory access. ==223426==Hint: this fault was caused by a dereference of a high value address (see register values below). Disassemble the provided pc to learn which register was used. /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:258:9 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:304:3 /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_endp.c:124:2 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:670:3 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:923:2 /mgw-threads/osmo-mgw/tests/mgcp/mgcp_test.c:2248:2 /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16 (/mgw-threads/osmo-mgw/tests/mgcp/mgcp_test+0x404c2d) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV /mgw-threads/osmo-mgw/src/libosmo-mgcp/mgcp_conn.c:199:14 in mgcp_conn_get ==223426==ABORTING Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb --- M src/libosmo-mgcp/mgcp_conn.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 4f6e1a2..5c3c60e 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -325,6 +325,11 @@ /*! free all connections at once. * \param[in] endp associated endpoint */ +#if defined(__has_attribute) +#if __has_attribute(no_sanitize) +__attribute__((no_sanitize("undefined"))) /* ubsan detects a misaligned load */ +#endif +#endif void mgcp_conn_free_all(struct mgcp_endpoint *endp) { struct mgcp_conn *conn; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd056eeb88966df164c07b9165b25faa4edbaadb Gerrit-Change-Number: 26192 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:42:16 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 21:42:16 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#34). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then answers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h A include/osmocom/mgcp/mgcp_threads.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 15 files changed, 1,162 insertions(+), 349 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/34 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 34 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:42:16 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 21:42:16 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#8). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 270 insertions(+), 247 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:45:07 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 21:45:07 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#35). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then answers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h A include/osmocom/mgcp/mgcp_threads.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 15 files changed, 1,162 insertions(+), 349 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/35 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 35 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 17 21:45:07 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 17 Nov 2021 21:45:07 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#9). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 15 files changed, 269 insertions(+), 246 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 9 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Nov 17 22:21:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 22:21:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6195805d2dbe2_15b02acb115fc600200694@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 457s] building additional files... [ 457s] checking if compiling is necessary... [ 457s] the output file doesn't exist [ 457s] pdflatex -interaction=batchmode rtp-amr.tex [ 457s] pdflatex failed [ 457s] [ 457s] A possible reason for transformation failure is invalid DocBook [ 457s] (as reported by xmllint) [ 457s] [ 457s] Error: pdflatex compilation failed [ 457s] [ 457s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 457s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 457s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 457s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 457s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 457s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 457s] make[1]: *** [Makefile:375: all] Error 2 [ 457s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 457s] dh_auto_build: error: make -j1 returned exit code 2 [ 457s] make: *** [debian/rules:12: build] Error 25 [ 457s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 457s] ### VM INTERACTION START ### [ 458s] Powering off. [ 458s] [ 414.834139] reboot: Power down [ 459s] ### VM INTERACTION END ### [ 459s] [ 459s] wildcard2 failed "build osmo-bts_1.4.0.202111170026.dsc" at Wed Nov 17 22:21:09 UTC 2021. [ 459s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Nov 17 22:22:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 17 Nov 2021 22:22:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <619580b5eb917_15b02acb115fc6002009f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 630s] building additional files... [ 630s] checking if compiling is necessary... [ 630s] the output file doesn't exist [ 630s] pdflatex -interaction=batchmode rtp-amr.tex [ 630s] pdflatex failed [ 630s] [ 630s] A possible reason for transformation failure is invalid DocBook [ 630s] (as reported by xmllint) [ 630s] [ 630s] Error: pdflatex compilation failed [ 630s] [ 630s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 630s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 630s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 630s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 630s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 630s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 630s] make[1]: *** [Makefile:375: all] Error 2 [ 630s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 630s] dh_auto_build: error: make -j1 returned exit code 2 [ 630s] make: *** [debian/rules:12: build] Error 25 [ 630s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 630s] ### VM INTERACTION START ### [ 631s] Powering off. [ 631s] [ 592.479998] reboot: Power down [ 631s] ### VM INTERACTION END ### [ 631s] [ 631s] lamb57 failed "build osmo-bts_1.4.0.dsc" at Wed Nov 17 22:22:15 UTC 2021. [ 631s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 18 00:45:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 18 Nov 2021 00:45:16 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6195a23a1ae93_15b02acb115fc60025049d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 243s] building additional files... [ 243s] checking if compiling is necessary... [ 243s] the output file doesn't exist [ 243s] pdflatex -interaction=batchmode rtp-amr.tex [ 243s] pdflatex failed [ 243s] [ 243s] A possible reason for transformation failure is invalid DocBook [ 243s] (as reported by xmllint) [ 243s] [ 243s] Error: pdflatex compilation failed [ 243s] [ 243s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 243s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 243s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 243s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 243s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 243s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 243s] make[1]: *** [Makefile:375: all] Error 2 [ 243s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 243s] dh_auto_build: error: make -j1 returned exit code 2 [ 243s] make: *** [debian/rules:12: build] Error 25 [ 243s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 243s] ### VM INTERACTION START ### [ 244s] Powering off. [ 244s] [ 232.761925] reboot: Power down [ 244s] ### VM INTERACTION END ### [ 244s] [ 244s] goat03 failed "build osmo-bts_1.4.0.202111180026.dsc" at Thu Nov 18 00:45:08 UTC 2021. [ 244s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 18 00:47:15 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 18 Nov 2021 00:47:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <6195a294ce048_15b02acb115fc60025066@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 270s] building additional files... [ 270s] checking if compiling is necessary... [ 270s] the output file doesn't exist [ 270s] pdflatex -interaction=batchmode rtp-amr.tex [ 270s] pdflatex failed [ 270s] [ 270s] A possible reason for transformation failure is invalid DocBook [ 270s] (as reported by xmllint) [ 270s] [ 270s] Error: pdflatex compilation failed [ 270s] [ 270s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 270s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 270s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 270s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 270s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 270s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 270s] make[1]: *** [Makefile:375: all] Error 2 [ 270s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 270s] dh_auto_build: error: make -j1 returned exit code 2 [ 270s] make: *** [debian/rules:12: build] Error 25 [ 270s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 270s] ### VM INTERACTION START ### [ 271s] Powering off. [ 271s] [ 261.285378] reboot: Power down [ 271s] ### VM INTERACTION END ### [ 271s] [ 271s] goat17 failed "build osmo-bts_1.4.0.202111180026.dsc" at Thu Nov 18 00:47:10 UTC 2021. [ 271s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:19:22 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 09:19:22 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26280 to look at the new patch set (#5). Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... cards: select_adf_by_aid: split off aid completion The function select_adf_by_aid first searches for the complete AID in the set of AIDs that were read from EF.DIR. Lets put this task into a separate helper method Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 --- M pySim/cards.py 1 file changed, 26 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/80/26280/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:19:22 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 09:19:22 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26280 ) Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py at 282 PS4, Line 282: def _get_aid(adf="usim"): > Missing type definition (not critical): [?] Done https://gerrit.osmocom.org/c/pysim/+/26280/4/pySim/cards.py at 291 PS4, Line 291: def _complete_aid(self, aid): > Same here: [?] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 09:19:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:23:13 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 09:23:13 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 18 Nov 2021 09:23:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:36:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 09:36:02 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26280 ) Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 09:36:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:37:08 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 09:37:08 +0000 Subject: Change in pysim[master]: cards: select_adf_by_aid: split off aid completion In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26280 ) Change subject: cards: select_adf_by_aid: split off aid completion ...................................................................... cards: select_adf_by_aid: split off aid completion The function select_adf_by_aid first searches for the complete AID in the set of AIDs that were read from EF.DIR. Lets put this task into a separate helper method Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 --- M pySim/cards.py 1 file changed, 26 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/cards.py b/pySim/cards.py index 8f5004e..2319a56 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -278,22 +278,35 @@ self._aids = [] return self._aids + @staticmethod + def _get_aid(adf="usim") -> str: + aid_map = {} + # First (known) halves of the U/ISIM AID + aid_map["usim"] = "a0000000871002" + aid_map["isim"] = "a0000000871004" + if adf in aid_map: + return aid_map[adf] + return None + + def _complete_aid(self, aid) -> str: + """find the complete version of an ADF.U/ISIM AID""" + # Find full AID by partial AID: + if is_hex(aid): + for aid_known in self._aids: + if len(aid_known) >= len(aid) and aid == aid_known[0:len(aid)]: + return aid_known + return None + def select_adf_by_aid(self, adf="usim"): """Select ADF.U/ISIM in the Card using its full AID""" - # Find full AID by partial AID: if is_hex(adf): - for aid in self._aids: - if len(aid) >= len(adf) and adf == aid[0:len(adf)]: - return self._scc.select_adf(aid) - # Find full AID by application name: - elif adf in ["usim", "isim"]: - # First (known) halves of the U/ISIM AID - aid_map = {} - aid_map["usim"] = "a0000000871002" - aid_map["isim"] = "a0000000871004" - for aid in self._aids: - if aid_map[adf] in aid: - return self._scc.select_adf(aid) + aid = adf + else: + aid = self._get_aid(adf) + if aid: + aid_full = self._complete_aid(aid) + if aid_full: + return self._scc.select_adf(aid_full) return (None, None) def erase_binary(self, ef): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88447d47bc96d0d4ff5cea694b46e854232cdf86 Gerrit-Change-Number: 26280 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:39:54 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 09:39:54 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/2/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/2/pySim-read.py at a323 PS2, Line 323: # Check whether we have th AID of ISIM, if so select it by its AID > I guess because it is selected alrady around line 271/275, and no other ADF is selected meanwhile. [?] Yes, this is indeed the case. It is already selected, so there is no need to select it again. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 18 Nov 2021 09:39:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:39:54 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 09:39:54 +0000 Subject: Change in pysim[master]: pySim-read: do not select ADF.ISIM again References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26317 ) Change subject: pySim-read: do not select ADF.ISIM again ...................................................................... pySim-read: do not select ADF.ISIM again Before reading EF.IST ADF.ISIM is selected again even though it was selected before. Lets skip this step since it is unnecessary. Change-Id: I75be18e3476cb1d093bc99775eeddd0c08b81d78 --- M pySim-read.py 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/17/26317/1 diff --git a/pySim-read.py b/pySim-read.py index 00194b4..959a7c5 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -320,10 +320,6 @@ except Exception as e: print("UICC IARI: Can't read file -- " + str(e)) - # Check whether we have th AID of ISIM, if so select it by its AID - # EF.IST - File Id in ADF ISIM : 6f07 - data, sw = card.select_adf_by_aid(adf="isim") - if sw == '9000': # EF.IST (res, sw) = card.read_binary('6f07') if sw == '9000': -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I75be18e3476cb1d093bc99775eeddd0c08b81d78 Gerrit-Change-Number: 26317 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 18 09:40:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 18 Nov 2021 09:40:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <6196209bb1c2e_269f2b1e3f32c5fc108356@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 237s] building additional files... [ 237s] checking if compiling is necessary... [ 237s] the output file doesn't exist [ 237s] pdflatex -interaction=batchmode rtp-amr.tex [ 237s] pdflatex failed [ 237s] [ 237s] A possible reason for transformation failure is invalid DocBook [ 237s] (as reported by xmllint) [ 237s] [ 237s] Error: pdflatex compilation failed [ 237s] [ 237s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 237s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 237s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 237s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 237s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 237s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 237s] make[1]: *** [Makefile:375: all] Error 2 [ 237s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 237s] dh_auto_build: error: make -j1 returned exit code 2 [ 237s] make: *** [debian/rules:12: build] Error 25 [ 237s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 237s] ### VM INTERACTION START ### [ 238s] Powering off. [ 238s] [ 226.834503] reboot: Power down [ 238s] ### VM INTERACTION END ### [ 238s] [ 238s] goat09 failed "build osmo-bts_1.4.0.202111180026.dsc" at Thu Nov 18 03:26:39 UTC 2021. [ 238s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 18 09:40:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 18 Nov 2021 09:40:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <619620c1e0ba5_269f2b1e3f32c5fc1089d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 499s] building additional files... [ 499s] checking if compiling is necessary... [ 499s] the output file doesn't exist [ 499s] pdflatex -interaction=batchmode rtp-amr.tex [ 499s] pdflatex failed [ 499s] [ 499s] A possible reason for transformation failure is invalid DocBook [ 499s] (as reported by xmllint) [ 499s] [ 499s] Error: pdflatex compilation failed [ 499s] [ 499s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 499s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 499s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 499s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 499s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 499s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 499s] make[1]: *** [Makefile:375: all] Error 2 [ 499s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 499s] dh_auto_build: error: make -j1 returned exit code 2 [ 499s] make: *** [debian/rules:12: build] Error 25 [ 499s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 499s] ### VM INTERACTION START ### [ 500s] Powering off. [ 500s] [ 475.829460] reboot: Power down [ 501s] ### VM INTERACTION END ### [ 501s] [ 501s] lamb04 failed "build osmo-bts_1.4.0.dsc" at Thu Nov 18 03:28:33 UTC 2021. [ 501s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 18 09:40:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 18 Nov 2021 09:40:23 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <619620c622c17_269f2b1e3f32c5fc10925@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 228s] building additional files... [ 228s] checking if compiling is necessary... [ 228s] the output file doesn't exist [ 228s] pdflatex -interaction=batchmode rtp-amr.tex [ 228s] pdflatex failed [ 228s] [ 228s] A possible reason for transformation failure is invalid DocBook [ 228s] (as reported by xmllint) [ 228s] [ 228s] Error: pdflatex compilation failed [ 228s] [ 228s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 228s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 228s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 228s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 228s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 228s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 228s] make[1]: *** [Makefile:375: all] Error 2 [ 228s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 228s] dh_auto_build: error: make -j1 returned exit code 2 [ 228s] make: *** [debian/rules:12: build] Error 25 [ 228s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 228s] ### VM INTERACTION START ### [ 229s] Powering off. [ 229s] [ 219.258405] reboot: Power down [ 229s] ### VM INTERACTION END ### [ 229s] [ 229s] goat17 failed "build osmo-bts_1.4.0.dsc" at Thu Nov 18 03:31:07 UTC 2021. [ 229s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Nov 18 09:40:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 18 Nov 2021 09:40:39 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <619620d85f619_269f2b1e3f32c5fc10941@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 380s] building additional files... [ 380s] checking if compiling is necessary... [ 380s] the output file doesn't exist [ 380s] pdflatex -interaction=batchmode rtp-amr.tex [ 380s] pdflatex failed [ 380s] [ 380s] A possible reason for transformation failure is invalid DocBook [ 380s] (as reported by xmllint) [ 380s] [ 380s] Error: pdflatex compilation failed [ 380s] [ 380s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: rtp-amr.pdf] Error 1 [ 380s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 380s] make[3]: *** [Makefile:384: all-recursive] Error 1 [ 380s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 380s] make[2]: *** [Makefile:443: all-recursive] Error 1 [ 380s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 380s] make[1]: *** [Makefile:375: all] Error 2 [ 380s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 380s] dh_auto_build: error: make -j1 returned exit code 2 [ 380s] make: *** [debian/rules:12: build] Error 25 [ 380s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 380s] ### VM INTERACTION START ### [ 381s] Powering off. [ 381s] [ 367.882067] reboot: Power down [ 382s] ### VM INTERACTION END ### [ 382s] [ 382s] build77 failed "build osmo-bts_1.4.0.202111180026.dsc" at Thu Nov 18 03:33:35 UTC 2021. [ 382s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:52:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 09:52:08 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 35: (6 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h at 30 PS35, Line 30: unsigned int why is this broken into 2 lines? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_protocol.c at 1554 PS35, Line 1554: { same line https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads.c at 199 PS35, Line 199: { same line https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads_vty.c File src/libosmo-mgcp/mgcp_threads_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads_vty.c at 162 PS35, Line 162: { same line https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_vty.c at 1379 PS35, Line 1379: if (strcmp(argv[3], "in") == 0) missing {} here. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c File src/osmo-mgw/mgw_main.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c at 326 PS35, Line 326: { This was changed to a new line but the code style specs it to be in the same one in for loops. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 35 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 09:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 09:59:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 09:59:30 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 9: (3 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h at 29 PS9, Line 29: atomic_int_least32_t thread_ready_counter; /* used to check if all child trunk threads are ready for action */ This is only used by the top trunk right? But this struct is duplicated for each thread iirc? https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c at 440 PS9, Line 440: { same line https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c at 498 PS9, Line 498: while (trunk->use_threads && trunk->thread_ready_counter != num_threads) iiuc there's no need to check trunk->us_threads here? or is num_threads 1 when we run in single thread? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 9 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 09:59:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 10:27:43 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 10:27:43 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26253 to look at the new patch set (#4). Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... pySim-read: put try/catch block around select_adf_by_aid() Selecting an application may fail, especially when the application does not exist on the card. Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef --- M pySim-read.py 1 file changed, 26 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/26253/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 10:27:43 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 10:27:43 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: dexter has uploaded a new patch set (#10) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... cards: Make select_adf_by_aid() use prefix AID selection There is no need for us to expand a partial AID to the full AID before selecting that ADF. The UICC specifications permit AID selection by prefix only. So we could pass the prefix to the card, and the card would do the prefix matching. In order to avoid problems with cards that fail to do the prefix matching themselves we will still do the AID completion, but in case we cannot complete the AID (AID not listed in EF.DIR), we will try with the AID prefix anyway. >From the API user point of view, this allows us to select applications not listed in EF.DIR Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 --- M pySim/cards.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/25873/10 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 10 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 10:27:43 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 10:27:43 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 10: (1 comment) https://gerrit.osmocom.org/c/pysim/+/25873/9/pysim-testdata/fakemagicsim.ok File pysim-testdata/fakemagicsim.ok: https://gerrit.osmocom.org/c/pysim/+/25873/9/pysim-testdata/fakemagicsim.ok at 58 PS9, Line 58: ADF.USIM: Can't select application -- SW match failed! Expected 9000 and got 6b00. > indeed this is a bit odd. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 10 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 10:27:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 10:49:01 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 10:49:01 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 7: (2 comments) https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/profile.py at 52 PS6, Line 52: match_sim > I still don't like this code duplication. [?] Done https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/6/pySim/ts_102_221.py at 615 PS6, Line 615: order > Cosmetic: class properties are usually upper case. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 10:49:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 10:57:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 10:57:03 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26165 to look at the new patch set (#8). Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py M pySim/utils.py 6 files changed, 216 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 10:57:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 10:57:03 +0000 Subject: Change in pysim[master]: profile: decode_select_response can be a static method In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26276 to look at the new patch set (#2). Change subject: profile: decode_select_response can be a static method ...................................................................... profile: decode_select_response can be a static method The method decode_select_response does not access any property of the object. This means the method can be static. Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b --- M pySim/profile.py M pySim/sysmocom_sja2.py M pySim/ts_102_221.py M pySim/ts_31_102.py M pySim/ts_31_103.py M pySim/ts_51_011.py 6 files changed, 27 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/26276/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b Gerrit-Change-Number: 26276 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 11:53:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 18 Nov 2021 11:53:55 +0000 Subject: Change in pysim[master]: pySim-read: do not select ADF.ISIM again In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26317 ) Change subject: pySim-read: do not select ADF.ISIM again ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I75be18e3476cb1d093bc99775eeddd0c08b81d78 Gerrit-Change-Number: 26317 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 11:53:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 11:56:03 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 18 Nov 2021 11:56:03 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/4/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/4/pySim-read.py at 296 PS4, Line 296: print("ADF.ISIM: Can't select application -- " + str(e)) Maybe put this in a function, since the code block is almost the same twice? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 18 Nov 2021 11:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 11:57:28 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 18 Nov 2021 11:57:28 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 10 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 11:57:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 12:05:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 18 Nov 2021 12:05:34 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... Patch Set 1: Code-Review+1 deprecating the function would be the clean solution IMHO, but if you say it's not worth it... fine with me. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 12:05:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 12:58:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 12:58:41 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/4/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/4/pySim-read.py at 296 PS4, Line 296: print("ADF.ISIM: Can't select application -- " + str(e)) > Maybe put this in a function, since the code block is almost the same twice? Ack, makes sense. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 18 Nov 2021 12:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 12:58:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 12:58:54 +0000 Subject: Change in pysim[master]: pySim-read: do not select ADF.ISIM again In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26317 ) Change subject: pySim-read: do not select ADF.ISIM again ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I75be18e3476cb1d093bc99775eeddd0c08b81d78 Gerrit-Change-Number: 26317 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 12:58:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 12:59:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 12:59:34 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 10 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 12:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:04:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:04:05 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 13:04:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:04:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:04:36 +0000 Subject: Change in pysim[master]: pySim-read: do not select ADF.ISIM again In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26317 ) Change subject: pySim-read: do not select ADF.ISIM again ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I75be18e3476cb1d093bc99775eeddd0c08b81d78 Gerrit-Change-Number: 26317 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 13:04:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:05:25 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:05:25 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 10 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 13:05:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:05:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:05:29 +0000 Subject: Change in pysim[master]: pySim-read: do not select ADF.ISIM again In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26317 ) Change subject: pySim-read: do not select ADF.ISIM again ...................................................................... pySim-read: do not select ADF.ISIM again Before reading EF.IST ADF.ISIM is selected again even though it was selected before. Lets skip this step since it is unnecessary. Change-Id: I75be18e3476cb1d093bc99775eeddd0c08b81d78 --- M pySim-read.py 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim-read.py b/pySim-read.py index 00194b4..959a7c5 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -320,10 +320,6 @@ except Exception as e: print("UICC IARI: Can't read file -- " + str(e)) - # Check whether we have th AID of ISIM, if so select it by its AID - # EF.IST - File Id in ADF ISIM : 6f07 - data, sw = card.select_adf_by_aid(adf="isim") - if sw == '9000': # EF.IST (res, sw) = card.read_binary('6f07') if sw == '9000': -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I75be18e3476cb1d093bc99775eeddd0c08b81d78 Gerrit-Change-Number: 26317 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:06:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:06:58 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 18 Nov 2021 13:06:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:07:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:07:40 +0000 Subject: Change in pysim[master]: pySim-shell: export command: guess number of records when not specified In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26204 ) Change subject: pySim-shell: export command: guess number of records when not specified ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 13:07:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:08:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:08:01 +0000 Subject: Change in pysim[master]: profile: decode_select_response can be a static method In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26276 ) Change subject: profile: decode_select_response can be a static method ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b Gerrit-Change-Number: 26276 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 13:08:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:08:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 13:08:19 +0000 Subject: Change in pysim[master]: profile: decode_select_response use object instead 'Any' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26277 ) Change subject: profile: decode_select_response use object instead 'Any' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic5c7ace234bc94ab1381d87e091369ade8011cab Gerrit-Change-Number: 26277 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 13:08:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:10:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 13:10:17 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > deprecating the function would be the clean solution IMHO, but if you say it's not worth it... fine with me. If we go for bitvec_read_field2(), we would have to rework a lot of stuff in osmo-pcu. Basically all invocations of this function, for example: uint64_t field = bitvec_read_field(bv, offset, len); would need to be rewritten to: uint64_t field; if (bitvec_read_field2(bv, &field, offset, len) != 0) // handle error The problem here is that oftentimes it makes more sense to check if the vector has enough data *once*, and then invoke bitvec_read_field() many times without any checks. Here is a good example from osmo-pcu: data->PAYLOAD_TYPE = bitvec_read_field(vector, &readIndex, 2); data->RRBP = bitvec_read_field(vector, &readIndex, 2); data->SP = bitvec_read_field(vector, &readIndex, 1); data->USF = bitvec_read_field(vector, &readIndex, 3); This is why I prefer the errno approach: you get a possibility to detect errors, but you don't force the user to use the new API, what makes sense in places where checking for errors is not needed. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 13:10:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:11:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 13:11:07 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... Patch Set 1: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 13:11:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:11:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 13:11:13 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 13:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:11:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 13:11:20 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 ) Change subject: bitvec_read_field(): indicate errors using errno ...................................................................... bitvec_read_field(): indicate errors using errno This function returns an *unsigned* integer (uint64_t), so returning a negative value on error is a bad idea. A negative value turns into a huge positive value, what was demonstrated in the bitvec_test: bitvec_read_field(idx=512, len=16) => ffffffffffffffea bitvec_read_field(idx=0, len=65) => ffffffffffffffea bitvec_read_field(idx=64, len=16) => ffffffffffffffea The 0xffffffffffffffea above is basically: (uint64_t) -EINVAL, or (uint64_t) -22 + 1, or 0xffffffffffffffff - 0x16 + 1. Let's make use of the errno in order to indicate an error to the caller. Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Related: OS#4388 --- M src/bitvec.c M tests/bitvec/bitvec_test.c M tests/bitvec/bitvec_test.ok 3 files changed, 26 insertions(+), 20 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/bitvec.c b/src/bitvec.c index 2b4e8c9..b411a72 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -472,18 +472,23 @@ * \param[in] bv The boolean vector to work on * \param[in,out] read_index Where reading supposed to start in the vector * \param[in] len How many bits to read from vector - * \returns read bits or negative value on error + * \returns An integer made up of the bits read. + * + * In case of an error, errno is set to a non-zero value. Otherwise it holds 0. */ uint64_t bitvec_read_field(struct bitvec *bv, unsigned int *read_index, unsigned int len) { unsigned int i; uint64_t ui = 0; bv->cur_bit = *read_index; + errno = 0; for (i = 0; i < len; i++) { int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); - if (bit < 0) - return bit; + if (bit < 0) { + errno = -bit; + break; + } if (bit) ui |= ((uint64_t)1 << (len - i - 1)); bv->cur_bit++; diff --git a/tests/bitvec/bitvec_test.c b/tests/bitvec/bitvec_test.c index b4764e6..ea7ea9a 100644 --- a/tests/bitvec/bitvec_test.c +++ b/tests/bitvec/bitvec_test.c @@ -237,7 +237,8 @@ #define _bitvec_read_field(idx, len) \ readIndex = idx; \ field = bitvec_read_field(&bv, &readIndex, len); \ - printf("bitvec_read_field(idx=%u, len=%u) => %" PRIx64 "\n", idx, len, field); + printf("bitvec_read_field(idx=%u, len=%u) => %" PRIx64 " (%s)\n", \ + idx, len, field, errno == 0 ? "success" : "error"); _bitvec_read_field(0, 64); _bitvec_read_field(0, 32); diff --git a/tests/bitvec/bitvec_test.ok b/tests/bitvec/bitvec_test.ok index b118502..a0e31d3 100644 --- a/tests/bitvec/bitvec_test.ok +++ b/tests/bitvec/bitvec_test.ok @@ -171,21 +171,21 @@ bitvec bytes used. test bitvec_read_field(): -bitvec_read_field(idx=0, len=64) => deadbeeffeebdaed -bitvec_read_field(idx=0, len=32) => deadbeef -bitvec_read_field(idx=0, len=16) => dead -bitvec_read_field(idx=0, len=8) => de -bitvec_read_field(idx=0, len=0) => 0 -bitvec_read_field(idx=8, len=8) => ad -bitvec_read_field(idx=8, len=4) => a -bitvec_read_field(idx=8, len=0) => 0 -bitvec_read_field(idx=10, len=9) => 16d -bitvec_read_field(idx=10, len=7) => 5b -bitvec_read_field(idx=10, len=5) => 16 -bitvec_read_field(idx=10, len=3) => 5 -bitvec_read_field(idx=10, len=1) => 1 -bitvec_read_field(idx=512, len=16) => ffffffffffffffea -bitvec_read_field(idx=0, len=65) => ffffffffffffffea -bitvec_read_field(idx=64, len=16) => ffffffffffffffea +bitvec_read_field(idx=0, len=64) => deadbeeffeebdaed (success) +bitvec_read_field(idx=0, len=32) => deadbeef (success) +bitvec_read_field(idx=0, len=16) => dead (success) +bitvec_read_field(idx=0, len=8) => de (success) +bitvec_read_field(idx=0, len=0) => 0 (success) +bitvec_read_field(idx=8, len=8) => ad (success) +bitvec_read_field(idx=8, len=4) => a (success) +bitvec_read_field(idx=8, len=0) => 0 (success) +bitvec_read_field(idx=10, len=9) => 16d (success) +bitvec_read_field(idx=10, len=7) => 5b (success) +bitvec_read_field(idx=10, len=5) => 16 (success) +bitvec_read_field(idx=10, len=3) => 5 (success) +bitvec_read_field(idx=10, len=1) => 1 (success) +bitvec_read_field(idx=512, len=16) => 0 (error) +bitvec_read_field(idx=0, len=65) => bd5b7ddffdd7b5db (error) +bitvec_read_field(idx=64, len=16) => 0 (error) bitvec ok. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e Gerrit-Change-Number: 26307 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:11:21 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 13:11:21 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26308 ) Change subject: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan ...................................................................... bitvec_read_field(): fix incorrect bit-shift issue found by UBSan While running a sanitized version of the bitvec_test I get: bitvec.c:492:24: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int' This error is triggered by the following line in the bitvec_test: _bitvec_read_field(0, 8 * 8 + 1); /* too many bits */ which basically tries to parse more bits (65) than the test vector actually has (64). The problem is that we don't check if the given vector has enough data *before* entering the parsing loop, so we end up doing weird bit-shifts and getting weird values: bitvec_read_field(idx=0, len=65) => bd5b7ddffdd7b5db (error) Unfortunately, this problem remained unnoticed so far because in 'tests/testsuite.at' we don't check if stderr is empty. This is fixed in a follow up change [1]. Rather than checking for errors in every loop iteration, do this once and return early if the overrun is possible with the given offset and length arguments. Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Related: [1] Ia82b92eddb18dc596881abcef2f098dc7385538b --- M src/bitvec.c M tests/bitvec/bitvec_test.ok 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/bitvec.c b/src/bitvec.c index b411a72..2303a0d 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -480,15 +480,18 @@ { unsigned int i; uint64_t ui = 0; + + /* Prevent bitvec overrun due to incorrect index and/or length */ + if (len && bytenum_from_bitnum(*read_index + len - 1) >= bv->data_len) { + errno = EOVERFLOW; + return 0; + } + bv->cur_bit = *read_index; errno = 0; for (i = 0; i < len; i++) { int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); - if (bit < 0) { - errno = -bit; - break; - } if (bit) ui |= ((uint64_t)1 << (len - i - 1)); bv->cur_bit++; diff --git a/tests/bitvec/bitvec_test.ok b/tests/bitvec/bitvec_test.ok index a0e31d3..d87ac7e 100644 --- a/tests/bitvec/bitvec_test.ok +++ b/tests/bitvec/bitvec_test.ok @@ -185,7 +185,7 @@ bitvec_read_field(idx=10, len=3) => 5 (success) bitvec_read_field(idx=10, len=1) => 1 (success) bitvec_read_field(idx=512, len=16) => 0 (error) -bitvec_read_field(idx=0, len=65) => bd5b7ddffdd7b5db (error) +bitvec_read_field(idx=0, len=65) => 0 (error) bitvec_read_field(idx=64, len=16) => 0 (error) bitvec ok. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 Gerrit-Change-Number: 26308 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:11:21 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 13:11:21 +0000 Subject: Change in libosmocore[master]: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26309 ) Change subject: bitvec_read_field(): optimize by expanding bytenum_from_bitnum() ...................................................................... bitvec_read_field(): optimize by expanding bytenum_from_bitnum() The bitvec_read_field() is used in performance critical places, such as the CSN.1 decoder in osmo-pcu. Thus the less conditional statements we have in the parsing loop, the better. The bitvec_get_bit_pos() alone is quite a complex function, which does check the boundaries and even supports the L/H syntax. Even if it gets inlined by the compiler, we don't really want to run redundant checks and run bitval2mask() on each iteration. Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab --- M src/bitvec.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/bitvec.c b/src/bitvec.c index 2303a0d..13deeff 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -491,8 +491,10 @@ errno = 0; for (i = 0; i < len; i++) { - int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit); - if (bit) + unsigned int bytenum = bytenum_from_bitnum(bv->cur_bit); + unsigned int bitnum = 7 - (bv->cur_bit % 8); + + if (bv->data[bytenum] & (1 << bitnum)) ui |= ((uint64_t)1 << (len - i - 1)); bv->cur_bit++; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I438fc82d33ab2edbabd4215ec7bc46afb07d50ab Gerrit-Change-Number: 26309 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:11:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 13:11:22 +0000 Subject: Change in libosmocore[master]: tests/testsuite.at: ensure empty stderr for the bitvec_test In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26310 ) Change subject: tests/testsuite.at: ensure empty stderr for the bitvec_test ...................................................................... tests/testsuite.at: ensure empty stderr for the bitvec_test The address sanitizer may print errors and warnings to stderr, and this was actually the case for bitvec_test before [1]: bitvec.c:492:24: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int' Change-Id: Ia82b92eddb18dc596881abcef2f098dc7385538b Related: [1] I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65 --- M tests/testsuite.at 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/testsuite.at b/tests/testsuite.at index 975b51e..92c4e39 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -36,7 +36,7 @@ AT_SETUP([bitvec]) AT_KEYWORDS([bitvec]) cat $abs_srcdir/bitvec/bitvec_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/bitvec/bitvec_test], [0], [expout], [ignore]) +AT_CHECK([$abs_top_builddir/tests/bitvec/bitvec_test], [0], [expout]) AT_CLEANUP AT_SETUP([bitcomp]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia82b92eddb18dc596881abcef2f098dc7385538b Gerrit-Change-Number: 26310 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 13:28:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 13:28:51 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26197/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/1/src/osmo-bsc/abis_nm.c at 937 PS1, Line 937: if (!bts->valid_config) { > I was thinking of that, but as far as I understand this dropping feature works only for ip-access BT [?] what's wrong with checking if the bts is ipa and only applying it then? See is_ipaccess_bts(). I'm sorry but I don't think this check should be done here, but rather when conn goes up. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 13:28:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:09:42 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 14:09:42 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 35: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h at 30 PS35, Line 30: unsigned int > why is this broken into 2 lines? because the useless comments are too long and this is kernel style formatting https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c File src/osmo-mgw/mgw_main.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/osmo-mgw/mgw_main.c at 326 PS35, Line 326: { > This was changed to a new line but the code style specs it to be in the same one in for loops. you got to be fucking kidding?! we've had kernel style formatting for for-like macros before, then you complained because we don't do kernel style formatting, so now it's formatted automagically without for-like macros according to kernel style rules, and now that is the problem? either we apply formatting rules and stop discussing or we keep finding new ways not to apply formatting rules and discuss this until eternity. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 35 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 14:09:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:35:06 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Nov 2021 14:35:06 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix error return value References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318 ) Change subject: gbproxy: Fix error return value ...................................................................... gbproxy: Fix error return value OSMO_TLVP_ERR_MAND_IE_MISSING is already negative Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb --- M src/gb_proxy.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/18/26318/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 3d76a33..6fd6f77 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -388,7 +388,7 @@ if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA || bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) { const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) bgph; if (msg_len < sizeof(*budh)) - return -OSMO_TLVP_ERR_MAND_IE_MISSING; + return OSMO_TLVP_ERR_MAND_IE_MISSING; rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, budh->pdu_type, budh->data, msg_len - sizeof(*budh), 0, 0, DGPRS, log_pfx); /* populate TLLI from the fixed headser into the TLV-parsed array so later code -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb Gerrit-Change-Number: 26318 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:35:06 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Nov 2021 14:35:06 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... gbproxy: Also try to route STATUS messages with truncated PDU in error Related: OS#4892 Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 --- M src/gb_proxy.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/19/26319/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 6fd6f77..73db215 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -982,9 +982,9 @@ struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; struct tlv_parsed tp_inner; - /* TODO: Parse partial messages as well */ rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); - if (rc < 0) + /* Ignore decode failure, due to trucated message */ + if (rc < 0 && rc != OSMO_TLVP_ERR_OFS_BEYOND_BUFFER) return rc; if (TLVP_PRESENT(&tp_inner, BSSGP_IE_TLLI)) { @@ -1010,9 +1010,9 @@ struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; struct tlv_parsed tp_inner; - /* TODO: Parse partial messages as well */ rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); - if (rc < 0) + /* Ignore decode failure, due to trucated message */ + if (rc < 0 && rc != OSMO_TLVP_ERR_OFS_BEYOND_BUFFER) return rc; if (TLVP_PRESENT(&tp_inner, BSSGP_IE_BVCI)) -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:39:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 14:39:12 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix error return value In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318 ) Change subject: gbproxy: Fix error return value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb Gerrit-Change-Number: 26318 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 18 Nov 2021 14:39:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:39:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 14:39:48 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 18 Nov 2021 14:39:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:44:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 14:44:20 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 1: (2 comments) Does this really make sense? expecting this kind of issue and forwarding. https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c at 986 PS1, Line 986: /* Ignore decode failure, due to trucated message */ truncated. And the comma can be removed imho. https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c at 1014 PS1, Line 1014: /* Ignore decode failure, due to trucated message */ same -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 14:44:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:47:11 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 14:47:11 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#36). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then answers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h A include/osmocom/mgcp/mgcp_threads.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 15 files changed, 1,166 insertions(+), 350 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/36 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 36 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 14:47:11 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 14:47:11 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#10). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 16 files changed, 273 insertions(+), 255 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 15:18:20 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Nov 2021 15:18:20 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 to look at the new patch set (#2). Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... gbproxy: Also try to route STATUS messages with truncated PDU in error Related: OS#4892 Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 --- M src/gb_proxy.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/19/26319/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 15:23:05 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Nov 2021 15:23:05 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 2: (2 comments) > Patch Set 1: > Does this really make sense? expecting this kind of issue and forwarding. Well, we specified doing this from the start. Truncated pdu-in-error can happen if the original pdu was close to the MTU already (e.g. unitdata, RIM messages). Since the BVC is established end-to-end we need to route the STATUS correctly so the offending side can take action and/or report the issue. https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c at 986 PS1, Line 986: /* Ignore decode failure, due to trucated message */ > truncated. And the comma can be removed imho. Ack https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319/1/src/gb_proxy.c at 1014 PS1, Line 1014: /* Ignore decode failure, due to trucated message */ > same Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 15:23:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 15:23:27 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Nov 2021 15:23:27 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix error return value In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318 ) Change subject: gbproxy: Fix error return value ...................................................................... gbproxy: Fix error return value OSMO_TLVP_ERR_MAND_IE_MISSING is already negative Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb --- M src/gb_proxy.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 3d76a33..6fd6f77 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -388,7 +388,7 @@ if (bgph->pdu_type == BSSGP_PDUT_UL_UNITDATA || bgph->pdu_type == BSSGP_PDUT_DL_UNITDATA) { const struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) bgph; if (msg_len < sizeof(*budh)) - return -OSMO_TLVP_ERR_MAND_IE_MISSING; + return OSMO_TLVP_ERR_MAND_IE_MISSING; rc = osmo_tlv_prot_parse(&osmo_pdef_bssgp, tp, 1, budh->pdu_type, budh->data, msg_len - sizeof(*budh), 0, 0, DGPRS, log_pfx); /* populate TLLI from the fixed headser into the TLV-parsed array so later code -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I17e438be50324684cebe0852ecab877097bb0cbb Gerrit-Change-Number: 26318 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 16:39:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 16:39:56 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 10: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c at 322 PS10, Line 322: LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); why has this changed to print rc, which is uniniaitlized? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 16:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 16:41:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 16:41:35 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 2: > Patch Set 2: > Well, we specified doing this from the start. Truncated pdu-in-error can happen if the original pdu was close to the MTU already (e.g. unitdata, RIM messages). Since the BVC is established end-to-end we need to route the STATUS correctly so the offending side can take action and/or report the issue. Ah indeed, STATUS contains the pdu-in-error, then that makes sense. May be worth adding that to the commit message, but it may be obvious to people working on this :) -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 16:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:07:01 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 17:07:01 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 10: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c at 322 PS10, Line 322: LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); > why has this changed to print rc, which is uniniaitlized? isn't it initialized by ssize_t rc, msglen = w->x.msglen;? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 17:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:11:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 17:11:50 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 10: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c at 322 PS10, Line 322: LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); > isn't it initialized by ssize_t rc, msglen = w->x. [?] No, in order to be initialized it should be: ssize_t rc, msglen; rc = msglen = w->x.msglen; In any case, I don't see why did that change, using mslen there seems fine? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 17:11:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:38:15 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 18 Nov 2021 17:38:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... MGCP_Test: fix TC_dlcx_wildcarded Due to the migration to a multithreading scheme the timing behavior of the stats items has slightly changed. There is now a 1 sec update cycle in which the stats items are regenerated. This means we have to wait 1 sec. before we can query the endpoints.used stats item. Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Related: OS#5316 --- M mgw/MGCP_Test.ttcn 1 file changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/26320/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index b5b91f0..069eb95 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1097,6 +1097,9 @@ resp := mgcp_transceive_mgw(cmd, tr_CRCX_ACK); } + /* Wait until the stats items have seteled and then check if we get the expected number (all) of + * occupied endpoints */ + f_sleep(1.0) expect := { { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := n_endpoints, max := n_endpoints} }; @@ -1114,15 +1117,8 @@ cmd := ts_DLCX(get_next_trans_id(), ep); mgcp_transceive_mgw(cmd, rtmpl); - /* The stats reporter collects multiple samples during the reporting interval and - * reports the highest back to the user. This means we will not immediately get - * the 0 endpoints but an intermediate result instead. */ - expect := { - { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := 0, max := n_endpoints} - }; - f_statsd_expect(expect); - /* The second interval must resturn a result with 0 endpoints in use. */ + f_sleep(1.0) expect := { { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := 0, max := 0} }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Gerrit-Change-Number: 26320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:40:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 17:40:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Gerrit-Change-Number: 26320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 17:40:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:42:19 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 17:42:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Gerrit-Change-Number: 26320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 17:42:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:50:12 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 17:50:12 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 to look at the new patch set (#37). Change subject: Add multithreading for the virtual trunk ...................................................................... Add multithreading for the virtual trunk The idea is rather easy: do not disturb the code too much, so each thread operates on a mgcp_trunk sub-trunk that has - (it is) a mgcp_trunk structure just like the parent trunk - some thread-specific information in struct per_thread_info * this exists in the sub-trunk, as a SINGLE pointer (this_thread_info) to the threads own info - a different endpoint begin offset - and different number of endpoint - a private copy (!) of the mgcp_config structure that allows selective updates of config settings during runtime using the vty The thread-trunks doen't really know that they are not a full trunk, as far as actual "mgw-operation" is concerned Most of the other changes deal with the (t)alloc contexts to ensure proper parent contexts that are not mixed between threads, the only talloc that is threadsafe is the null context with disabled null tracking, which is plain old malloc. A parent trunk is configured using the vty/config as usual, so it also has all the endpoints, but those are just not being used by anything, all of the structs just exist to allow parsing and configuring, but the updates are then also sent to the trunk threads. It contains the thread_info array which has one per_thread_info struct entry for every trunkthread of this trunk. Communication betwen the main threads and the trunk thread(s) work by sending messages through - the mgcp msg queue for mgcp commands, which the thread then answers by writing to the socket, the queue back to the main thread is currently unused. - the cfg/vty command queue for vty commands and vty settings, that are parsed and filtered by the threads own functions, the return queue to the main thread is only being used to block it during vty show commands that print in threads. MGCP message handling is therefore split between a quick parsing in the main thread to determine which endpoint (-> thread) should handle the command and wrapping the command in a interthread queue buffer before submitting it to one (or multiple) threads, and the usual processing within the sub-trunk threads. Multithreading is by default disabled unless "number threads" in the config file exists. Multithreading is disabled for e1 trunks due to the complexity of the code and a lack of test coverage that reliably proves the absence of threading related issues, so e1 is still being handled by the main thread. Multithreading is also disabled for all trunks if osmux is configured, also due to complexity and the fact that one osmux trunk is limited to 256 calls due to the CID anyway, which can be handled within one (main) thread. That being said the code is ready to enable threads for all of that, it's just not possible to prove that it will not implode at some point.. Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_endp.h A include/osmocom/mgcp/mgcp_threads.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_threads.c A src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 15 files changed, 1,165 insertions(+), 350 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/25432/37 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 37 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:50:12 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 17:50:12 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#11). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 16 files changed, 273 insertions(+), 255 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:55:15 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 17:55:15 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 to look at the new patch set (#12). Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... rework the counters and stats so they work with the threaded mgw Main thread has a one-second timer cb that aggregrates and updates the rate counters, as well as the stats, by reading the actual atomic counters that are being updated by the threads. Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_network.h M include/osmocom/mgcp/mgcp_ratectr.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_stat.c M src/libosmo-mgcp/mgcp_threads.c M src/libosmo-mgcp/mgcp_threads_vty.c M src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M tests/mgcp/mgcp_test.c 16 files changed, 272 insertions(+), 254 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26190/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 17:57:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 17:57:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Gerrit-Change-Number: 26320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 17:57:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 18:01:08 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Nov 2021 18:01:08 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 12: (3 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/include/osmocom/mgcp/mgcp_trunk.h at 29 PS9, Line 29: atomic_int_least32_t thread_ready_counter; /* used to check if all child trunk threads are ready for action */ > This is only used by the top trunk right? But this struct is duplicated for each thread iirc? yes. just like the 22kb e1 struct at the bottom. https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c at 322 PS10, Line 322: LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); > No, in order to be initialized it should be: [?] I've already fixed this yesterday, but accidentally dropped the changes for this patch again, because this patch existed a second time with a different gerrit id. https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/9/src/libosmo-mgcp/mgcp_threads.c at 498 PS9, Line 498: while (trunk->use_threads && trunk->thread_ready_counter != num_threads) > iiuc there's no need to check trunk->us_threads here? or is num_threads 1 when we run in single thre [?] yes, see 20 lines above. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 18:01:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 18:13:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 18:13:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 ) Change subject: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() ...................................................................... MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 15 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/26321/1 diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index cb93bfe..481abc0 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -840,26 +840,28 @@ var BIT5 inp := ch_desc.channelTypeandTDMAOffset; var uint3_t tn := bit2int(ch_desc.timeslotNumber); - if (match(inp, '00001'B)) { /* TCH/F */ + select (inp) { + case ('00001'B) { /* TCH/F */ chan_nr := valueof(t_RslChanNr_Bm(tn)); - } - else if (match(inp, '11101'B)) { /* VAMOS TCH/F */ + } + case ('11101'B) { /* VAMOS TCH/F */ chan_nr := valueof(t_RslChanNr_Osmo_VAMOS_Bm(tn)); - } - else if (match(inp, '0001?'B)) { /* TCH/H */ + } + case ('0001?'B) { /* TCH/H */ chan_nr := valueof(t_RslChanNr_Lm(tn, bit2int(substr(inp, 4, 1)))); - } - else if (match(inp, '1111?'B)) { /* VAMOS TCH/H */ + } + case ('1111?'B) { /* VAMOS TCH/H */ chan_nr := valueof(t_RslChanNr_Osmo_VAMOS_Lm(tn, bit2int(substr(inp, 4, 1)))); - } - else if (match(inp, '001??'B)) { /* SDCCH/4 */ + } + case ('001??'B) { /* SDCCH/4 */ chan_nr := valueof(t_RslChanNr_SDCCH4(tn, bit2int(substr(inp, 3, 2)))); - } - else if (match(inp, '01???'B)) { /* SDCCH/8 */ + } + case ('01???'B) { /* SDCCH/8 */ chan_nr := valueof(t_RslChanNr_SDCCH8(tn, bit2int(substr(inp, 2, 3)))); - } - else { + } + case else { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unknown ChDesc!"); + } } if (ch_desc.octet3 and4b '10'O == '10'O) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 Gerrit-Change-Number: 26321 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 18:13:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 18:13:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 ) Change subject: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd ...................................................................... BSC_Tests: fix a race condition in TC_fh_params_handover_cmd As can be seen from ttcn3-bsc-test run #1565 on Jenkins [1], it may happen that the VTY command requesting handover reaches the IUT earlier than the SCCP 'SACK CC' message. In this case, the 'SUBSCR_CONN' FSM remains in state 'WAIT_CC', so we get an error: (bts=0,trx=0,ts=0,ss=0) (ARFCN 871) --> BTS 1 Manually triggering Handover from VTY SUBSCR_CONN(msc0-conn204)[0x5633b2877af0]{WAIT_CC}: Received Event HANDOVER_START SUBSCR_CONN(msc0-conn204)[0x5633b2877af0]{WAIT_CC}: Event HANDOVER_START not permitted The easiest way to avoid this is to introduce and artificial delay after the connection establishment and before triggering the handover. [1] https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/1565/ Change-Id: I19f7ca942e22d7930a56d1a525414f137a9ef831 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/26322/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 4fdd059..dda1dcd 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -8888,6 +8888,7 @@ /* Establish a dedicated channel, so we can trigger handover */ dt := f_est_dchan(f_rnd_ra_cs(), 23, f_rnd_octstring(16)); + f_sleep(0.5); /* Trigger handover from BTS0 to BTS1 */ f_bts_0_cfg(BSCVTY, { "neighbor bts 1" }); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19f7ca942e22d7930a56d1a525414f137a9ef831 Gerrit-Change-Number: 26322 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 18:34:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 18:34:46 +0000 Subject: Change in docker-playground[master]: open5gs-master: there is no 'master' anymore, use 'main' References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26323 ) Change subject: open5gs-master: there is no 'master' anymore, use 'main' ...................................................................... open5gs-master: there is no 'master' anymore, use 'main' Change-Id: If02740d8ddb4775cc22e9d4ed78226d09c466626 Related: SYS#5602 --- M open5gs-master/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/23/26323/1 diff --git a/open5gs-master/Dockerfile b/open5gs-master/Dockerfile index 2af9f12..56fe1b8 100644 --- a/open5gs-master/Dockerfile +++ b/open5gs-master/Dockerfile @@ -60,7 +60,7 @@ ARG GITHUB_USER=open5gs ARG GITHUB_REPO=open5gs -ARG OPEN5GS_BRANCH=master +ARG OPEN5GS_BRANCH=main RUN git clone https://github.com/$GITHUB_USER/$GITHUB_REPO ADD https://api.github.com/repos/$GITHUB_USER/$GITHUB_REPO/git/refs/heads/$OPEN5GS_BRANCH /root/open5gs-ver.json -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If02740d8ddb4775cc22e9d4ed78226d09c466626 Gerrit-Change-Number: 26323 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 18:34:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 18:34:46 +0000 Subject: Change in docker-playground[master]: open5gs-master: add missing dependencies References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26324 ) Change subject: open5gs-master: add missing dependencies ...................................................................... open5gs-master: add missing dependencies Change-Id: I39806a8cc33a1f975b03839fb16466dabb57a26d Related: SYS#5602 --- M open5gs-master/Dockerfile 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/24/26324/1 diff --git a/open5gs-master/Dockerfile b/open5gs-master/Dockerfile index 56fe1b8..141f08a 100644 --- a/open5gs-master/Dockerfile +++ b/open5gs-master/Dockerfile @@ -22,6 +22,9 @@ libmongoc-dev \ libbson-dev \ libyaml-dev \ + libnghttp2-dev \ + libmicrohttpd-dev \ + libcurl4-gnutls-dev \ iproute2 \ ca-certificates \ netbase \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I39806a8cc33a1f975b03839fb16466dabb57a26d Gerrit-Change-Number: 26324 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:04:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 19:04:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 ) Change subject: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 Gerrit-Change-Number: 26321 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:04:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:05:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 19:05:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 ) Change subject: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19f7ca942e22d7930a56d1a525414f137a9ef831 Gerrit-Change-Number: 26322 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:05:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:05:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 19:05:55 +0000 Subject: Change in docker-playground[master]: open5gs-master: there is no 'master' anymore, use 'main' In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26323 ) Change subject: open5gs-master: there is no 'master' anymore, use 'main' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If02740d8ddb4775cc22e9d4ed78226d09c466626 Gerrit-Change-Number: 26323 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:05:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:06:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 19:06:04 +0000 Subject: Change in docker-playground[master]: open5gs-master: add missing dependencies In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26324 ) Change subject: open5gs-master: add missing dependencies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I39806a8cc33a1f975b03839fb16466dabb57a26d Gerrit-Change-Number: 26324 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:06:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:07:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 19:07:05 +0000 Subject: Change in docker-playground[master]: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26325 ) Change subject: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 ...................................................................... ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 Setting a non-existing parameter makes TITAN unhappy: HC at fd91bc0a2114: Error while setting parameter field 'STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0' to 'true': Module parameter cannot be set, because no parameter with name 'mp_osmo_stp_newer_than_1_4_0' exists in module 'STP_Tests_M3UA'. Change-Id: Ie4fba3eb73e0da60bc20859efddecc5ec816cb9e --- M ttcn3-stp-test/STP_Tests.cfg 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/25/26325/1 diff --git a/ttcn3-stp-test/STP_Tests.cfg b/ttcn3-stp-test/STP_Tests.cfg index f68726d..15baf7e 100644 --- a/ttcn3-stp-test/STP_Tests.cfg +++ b/ttcn3-stp-test/STP_Tests.cfg @@ -13,7 +13,6 @@ STP_Tests_M3UA.mp_stp_m3ua_ip := { "172.18.19.200", "fd02:db8:19::200" }; STP_Tests_IPA.mp_local_ipa_ip := "172.18.19.203"; STP_Tests_M3UA.mp_local_m3ua_ip := { "172.18.19.203", "fd02:db8:19::203" }; -STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0 := true; [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie4fba3eb73e0da60bc20859efddecc5ec816cb9e Gerrit-Change-Number: 26325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:09:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:09:03 +0000 Subject: Change in docker-playground[master]: open5gs-master: there is no 'master' anymore, use 'main' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26323 ) Change subject: open5gs-master: there is no 'master' anymore, use 'main' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If02740d8ddb4775cc22e9d4ed78226d09c466626 Gerrit-Change-Number: 26323 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:09:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:09:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:09:11 +0000 Subject: Change in docker-playground[master]: open5gs-master: add missing dependencies In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26324 ) Change subject: open5gs-master: add missing dependencies ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I39806a8cc33a1f975b03839fb16466dabb57a26d Gerrit-Change-Number: 26324 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:09:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:09:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:09:28 +0000 Subject: Change in docker-playground[master]: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26325 ) Change subject: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie4fba3eb73e0da60bc20859efddecc5ec816cb9e Gerrit-Change-Number: 26325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Nov 2021 19:09:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:10:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:10:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 ) Change subject: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19f7ca942e22d7930a56d1a525414f137a9ef831 Gerrit-Change-Number: 26322 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:10:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:10:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:10:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 ) Change subject: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 Gerrit-Change-Number: 26321 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:10:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:10:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:10:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 ) Change subject: MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() ...................................................................... MSC_ConnectionHandler: use select() in f_ChDesc2RslChanNr() Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index cb93bfe..481abc0 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -840,26 +840,28 @@ var BIT5 inp := ch_desc.channelTypeandTDMAOffset; var uint3_t tn := bit2int(ch_desc.timeslotNumber); - if (match(inp, '00001'B)) { /* TCH/F */ + select (inp) { + case ('00001'B) { /* TCH/F */ chan_nr := valueof(t_RslChanNr_Bm(tn)); - } - else if (match(inp, '11101'B)) { /* VAMOS TCH/F */ + } + case ('11101'B) { /* VAMOS TCH/F */ chan_nr := valueof(t_RslChanNr_Osmo_VAMOS_Bm(tn)); - } - else if (match(inp, '0001?'B)) { /* TCH/H */ + } + case ('0001?'B) { /* TCH/H */ chan_nr := valueof(t_RslChanNr_Lm(tn, bit2int(substr(inp, 4, 1)))); - } - else if (match(inp, '1111?'B)) { /* VAMOS TCH/H */ + } + case ('1111?'B) { /* VAMOS TCH/H */ chan_nr := valueof(t_RslChanNr_Osmo_VAMOS_Lm(tn, bit2int(substr(inp, 4, 1)))); - } - else if (match(inp, '001??'B)) { /* SDCCH/4 */ + } + case ('001??'B) { /* SDCCH/4 */ chan_nr := valueof(t_RslChanNr_SDCCH4(tn, bit2int(substr(inp, 3, 2)))); - } - else if (match(inp, '01???'B)) { /* SDCCH/8 */ + } + case ('01???'B) { /* SDCCH/8 */ chan_nr := valueof(t_RslChanNr_SDCCH8(tn, bit2int(substr(inp, 2, 3)))); - } - else { + } + case else { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unknown ChDesc!"); + } } if (ch_desc.octet3 and4b '10'O == '10'O) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iefef18b7f6330dbfb61a98c8c037c9c904cf0c24 Gerrit-Change-Number: 26321 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:10:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:10:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 ) Change subject: BSC_Tests: fix a race condition in TC_fh_params_handover_cmd ...................................................................... BSC_Tests: fix a race condition in TC_fh_params_handover_cmd As can be seen from ttcn3-bsc-test run #1565 on Jenkins [1], it may happen that the VTY command requesting handover reaches the IUT earlier than the SCCP 'SACK CC' message. In this case, the 'SUBSCR_CONN' FSM remains in state 'WAIT_CC', so we get an error: (bts=0,trx=0,ts=0,ss=0) (ARFCN 871) --> BTS 1 Manually triggering Handover from VTY SUBSCR_CONN(msc0-conn204)[0x5633b2877af0]{WAIT_CC}: Received Event HANDOVER_START SUBSCR_CONN(msc0-conn204)[0x5633b2877af0]{WAIT_CC}: Event HANDOVER_START not permitted The easiest way to avoid this is to introduce and artificial delay after the connection establishment and before triggering the handover. [1] https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/1565/ Change-Id: I19f7ca942e22d7930a56d1a525414f137a9ef831 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 5f1217b..1f4a615 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -8884,6 +8884,7 @@ /* Establish a dedicated channel, so we can trigger handover */ dt := f_est_dchan(f_rnd_ra_cs(), 23, f_rnd_octstring(16)); + f_sleep(0.5); /* Trigger handover from BTS0 to BTS1 */ f_bts_0_cfg(BSCVTY, { "neighbor bts 1" }); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19f7ca942e22d7930a56d1a525414f137a9ef831 Gerrit-Change-Number: 26322 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:10:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:10:54 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Gerrit-Change-Number: 26320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:10:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:10:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:10:56 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... MGCP_Test: fix TC_dlcx_wildcarded Due to the migration to a multithreading scheme the timing behavior of the stats items has slightly changed. There is now a 1 sec update cycle in which the stats items are regenerated. This means we have to wait 1 sec. before we can query the endpoints.used stats item. Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Related: OS#5316 --- M mgw/MGCP_Test.ttcn 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index b5b91f0..069eb95 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1097,6 +1097,9 @@ resp := mgcp_transceive_mgw(cmd, tr_CRCX_ACK); } + /* Wait until the stats items have seteled and then check if we get the expected number (all) of + * occupied endpoints */ + f_sleep(1.0) expect := { { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := n_endpoints, max := n_endpoints} }; @@ -1114,15 +1117,8 @@ cmd := ts_DLCX(get_next_trans_id(), ep); mgcp_transceive_mgw(cmd, rtmpl); - /* The stats reporter collects multiple samples during the reporting interval and - * reports the highest back to the user. This means we will not immediately get - * the 0 endpoints but an intermediate result instead. */ - expect := { - { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := 0, max := n_endpoints} - }; - f_statsd_expect(expect); - /* The second interval must resturn a result with 0 endpoints in use. */ + f_sleep(1.0) expect := { { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := 0, max := 0} }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90613616f9ff85ca59464dfd45d331ed1a54d9c5 Gerrit-Change-Number: 26320 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:11:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Nov 2021 19:11:35 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:11:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From jenkins at lists.osmocom.org Thu Nov 18 19:19:17 2021 From: jenkins at lists.osmocom.org (jenkins at lists.osmocom.org) Date: Thu, 18 Nov 2021 19:19:17 +0000 (UTC) Subject: =?UTF-8?Q?Jenkins_build_is_back_to_normal?= =?UTF-8?Q?_:_master-libosmo-dsp_=C2=BB_a1=3Ddefau?= =?UTF-8?Q?lt,a2=3Ddefault,a3=3Ddefault,a4=3Ddefa?= =?UTF-8?Q?ult,osmocom-master-debian9_#1403?= In-Reply-To: <1031061024.1350.1637176917728@jenkins.osmocom.org> References: <1031061024.1350.1637176917728@jenkins.osmocom.org> Message-ID: <533496904.1413.1637263157040@jenkins.osmocom.org> See From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:34:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Nov 2021 19:34:42 +0000 Subject: Change in docker-playground[master]: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26325 ) Change subject: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie4fba3eb73e0da60bc20859efddecc5ec816cb9e Gerrit-Change-Number: 26325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:34:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:38:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 19:38:32 +0000 Subject: Change in docker-playground[master]: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26325 ) Change subject: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie4fba3eb73e0da60bc20859efddecc5ec816cb9e Gerrit-Change-Number: 26325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Nov 2021 19:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 19:38:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 19:38:34 +0000 Subject: Change in docker-playground[master]: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26325 ) Change subject: ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 ...................................................................... ttcn3-stp-test: do not set mp_osmo_stp_newer_than_1_4_0 Setting a non-existing parameter makes TITAN unhappy: HC at fd91bc0a2114: Error while setting parameter field 'STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0' to 'true': Module parameter cannot be set, because no parameter with name 'mp_osmo_stp_newer_than_1_4_0' exists in module 'STP_Tests_M3UA'. Change-Id: Ie4fba3eb73e0da60bc20859efddecc5ec816cb9e --- M ttcn3-stp-test/STP_Tests.cfg 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve fixeria: Verified diff --git a/ttcn3-stp-test/STP_Tests.cfg b/ttcn3-stp-test/STP_Tests.cfg index f68726d..15baf7e 100644 --- a/ttcn3-stp-test/STP_Tests.cfg +++ b/ttcn3-stp-test/STP_Tests.cfg @@ -13,7 +13,6 @@ STP_Tests_M3UA.mp_stp_m3ua_ip := { "172.18.19.200", "fd02:db8:19::200" }; STP_Tests_IPA.mp_local_ipa_ip := "172.18.19.203"; STP_Tests_M3UA.mp_local_m3ua_ip := { "172.18.19.203", "fd02:db8:19::203" }; -STP_Tests_M3UA.mp_osmo_stp_newer_than_1_4_0 := true; [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie4fba3eb73e0da60bc20859efddecc5ec816cb9e Gerrit-Change-Number: 26325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 18 23:16:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Nov 2021 23:16:35 +0000 Subject: Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 ) Change subject: protocol: fix: properly declare value_string arrays ...................................................................... protocol: fix: properly declare value_string arrays Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef --- M src/protocol/diag_log_gprs_l1.h M src/protocol/diag_log_gsm.h 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-qcdiag refs/changes/26/26326/1 diff --git a/src/protocol/diag_log_gprs_l1.h b/src/protocol/diag_log_gprs_l1.h index eee9632..8f8585c 100644 --- a/src/protocol/diag_log_gprs_l1.h +++ b/src/protocol/diag_log_gprs_l1.h @@ -72,7 +72,7 @@ DIAG_TX_UL_CH_T_UL_PTCCH, DIAG_TX_UL_CH_T_UL_PACCH_PDTCH, }; -const struct value_string gprs_tx_ul_chans[4]; +extern const struct value_string gprs_tx_ul_chans[4]; enum gprs_coding_scheme { DIAG_GPRS_CS_CS1, @@ -91,7 +91,7 @@ DIAG_GPRS_CS_MCS8, DIAG_GPRS_CS_MCS9, }; -const struct value_string gprs_coding_schemes[16]; +extern const struct value_string gprs_coding_schemes[16]; struct gprs_tx_sched_res { uint32_t fn; diff --git a/src/protocol/diag_log_gsm.h b/src/protocol/diag_log_gsm.h index 378472f..d382f1a 100644 --- a/src/protocol/diag_log_gsm.h +++ b/src/protocol/diag_log_gsm.h @@ -192,7 +192,7 @@ DIAG_GPRS_LLMES_TLLI_ASS = 1, DIAG_GPRS_LLMES_TEST_MODE = 2, }; -const struct value_string diag_gprs_llme_st_vals[4]; +extern const struct value_string diag_gprs_llme_st_vals[4]; /* LOG_GPRS_LLC_ME_INFO_C */ struct diag_gprs_llme_info { @@ -282,7 +282,7 @@ DIAG_SAPI0_ST_LINK_SUSP, DIAG_SAPI0_ST_UA_PEND, }; -const struct value_string diag_gsm_l2_sapi0_st_vals[10]; +extern const struct value_string diag_gsm_l2_sapi0_st_vals[10]; enum diag_gsm_sapi3_state { DIAG_SAPI3_ST_NULL, @@ -294,7 +294,7 @@ DIAG_SAPI3_ST_TMR_RECOV, DIAG_SAPI3_ST_UA_PEND, }; -const struct value_string diag_gsm_l2_sapi3_st_vals[9]; +extern const struct value_string diag_gsm_l2_sapi3_st_vals[9]; enum diag_gsm_l2_event { DIAG_L2_EV_NO_EVENT, @@ -325,7 +325,7 @@ DIAG_L2_EV_UA_SENT, DIAG_L2_EV_FORCED_SUSPEND_REQ, }; -const struct value_string diag_gsm_l2_event_vals[28]; +extern const struct value_string diag_gsm_l2_event_vals[28]; struct diag_gsm_l2_state { uint8_t sapi; @@ -343,7 +343,7 @@ DIAG_L2_CHT_FACCH_F = 6, DIAG_L2_CHT_FACCH_H = 7, }; -const struct value_string diag_gsm_l2_chantype_vals[9]; +extern const struct value_string diag_gsm_l2_chantype_vals[9]; struct diag_gsm_l2_transm_status { uint8_t sapi; -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef Gerrit-Change-Number: 26326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 00:40:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 00:40:38 +0000 Subject: Change in docker-playground[master]: open5gs-master: add missing dependencies In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26324 ) Change subject: open5gs-master: add missing dependencies ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I39806a8cc33a1f975b03839fb16466dabb57a26d Gerrit-Change-Number: 26324 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 00:40:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 00:40:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 00:40:42 +0000 Subject: Change in docker-playground[master]: open5gs-master: there is no 'master' anymore, use 'main' In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26323 ) Change subject: open5gs-master: there is no 'master' anymore, use 'main' ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If02740d8ddb4775cc22e9d4ed78226d09c466626 Gerrit-Change-Number: 26323 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 00:40:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 00:40:45 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 00:40:45 +0000 Subject: Change in docker-playground[master]: open5gs-master: there is no 'master' anymore, use 'main' In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26323 ) Change subject: open5gs-master: there is no 'master' anymore, use 'main' ...................................................................... open5gs-master: there is no 'master' anymore, use 'main' Change-Id: If02740d8ddb4775cc22e9d4ed78226d09c466626 Related: SYS#5602 --- M open5gs-master/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve fixeria: Verified diff --git a/open5gs-master/Dockerfile b/open5gs-master/Dockerfile index 2af9f12..56fe1b8 100644 --- a/open5gs-master/Dockerfile +++ b/open5gs-master/Dockerfile @@ -60,7 +60,7 @@ ARG GITHUB_USER=open5gs ARG GITHUB_REPO=open5gs -ARG OPEN5GS_BRANCH=master +ARG OPEN5GS_BRANCH=main RUN git clone https://github.com/$GITHUB_USER/$GITHUB_REPO ADD https://api.github.com/repos/$GITHUB_USER/$GITHUB_REPO/git/refs/heads/$OPEN5GS_BRANCH /root/open5gs-ver.json -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If02740d8ddb4775cc22e9d4ed78226d09c466626 Gerrit-Change-Number: 26323 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 00:40:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 00:40:46 +0000 Subject: Change in docker-playground[master]: open5gs-master: add missing dependencies In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26324 ) Change subject: open5gs-master: add missing dependencies ...................................................................... open5gs-master: add missing dependencies Change-Id: I39806a8cc33a1f975b03839fb16466dabb57a26d Related: SYS#5602 --- M open5gs-master/Dockerfile 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve fixeria: Verified diff --git a/open5gs-master/Dockerfile b/open5gs-master/Dockerfile index 56fe1b8..141f08a 100644 --- a/open5gs-master/Dockerfile +++ b/open5gs-master/Dockerfile @@ -22,6 +22,9 @@ libmongoc-dev \ libbson-dev \ libyaml-dev \ + libnghttp2-dev \ + libmicrohttpd-dev \ + libcurl4-gnutls-dev \ iproute2 \ ca-certificates \ netbase \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I39806a8cc33a1f975b03839fb16466dabb57a26d Gerrit-Change-Number: 26324 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 07:12:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Nov 2021 07:12:15 +0000 Subject: Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 ) Change subject: protocol: fix: properly declare value_string arrays ...................................................................... Patch Set 1: Code-Review+1 thanks. at the same time we could remove the fixed array size in the declaration to ensure future extensions only require adding entries to the array, and not also the declaration. -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef Gerrit-Change-Number: 26326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 19 Nov 2021 07:12:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 10:43:34 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 10:43:34 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 to look at the new patch set (#6). Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/osmo_bsc_main.c 3 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 10:43:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 10:43:36 +0000 Subject: Change in osmo-bsc[master]: abis_nm: fix typo References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26327 ) Change subject: abis_nm: fix typo ...................................................................... abis_nm: fix typo Change-Id: I2cb7b986db9d394db2c912247db861704d2c7c23 --- M src/osmo-bsc/abis_nm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/26327/1 diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 7c04394..aeb4ba3 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -1363,7 +1363,7 @@ } if (strncmp(firmware_header.magic, " SDP", 4) != 0) { - LOGPMO(mo, DNM, LOGL_ERROR, "The magic number1 is wrong.\n"); + LOGPMO(mo, DNM, LOGL_ERROR, "The magic number is wrong.\n"); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2cb7b986db9d394db2c912247db861704d2c7c23 Gerrit-Change-Number: 26327 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 10:43:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 10:43:36 +0000 Subject: Change in osmo-bsc[master]: abis_nm: use struct sdp_firmware from libosmocore References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26328 ) Change subject: abis_nm: use struct sdp_firmware from libosmocore ...................................................................... abis_nm: use struct sdp_firmware from libosmocore abis_nm locally declares its own struct for the ipaccess firmware header, even though libosmocore defines it as well. Lets use the definition from libosmocore. Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 --- M src/osmo-bsc/abis_nm.c 1 file changed, 6 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/26328/1 diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index aeb4ba3..1c21bc2 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -51,6 +51,7 @@ #include #include #include +#include #define OM_ALLOC_SIZE 1024 #define OM_HEADROOM_SIZE 128 @@ -1342,13 +1343,6 @@ return abis_nm_sendmsg(sw->bts, msg); } -struct sdp_firmware { - char magic[4]; - char more_magic[4]; - unsigned int header_length; - unsigned int file_length; -} __attribute__ ((packed)); - static int parse_sdp_header(struct abis_nm_sw *sw) { const struct gsm_abis_mo *mo = &sw->bts->mo; @@ -1368,13 +1362,15 @@ } if (firmware_header.more_magic[0] != 0x10 || - firmware_header.more_magic[1] != 0x02 || - firmware_header.more_magic[2] != 0x00 || - firmware_header.more_magic[3] != 0x00) { + firmware_header.more_magic[1] != 0x02) { LOGPMO(mo, DNM, LOGL_ERROR, "The more magic number is wrong.\n"); return -1; } + if (firmware_header.more_more_magic != 0x0000) { + LOGPMO(mo, DNM, LOGL_ERROR, "The more more magic number is wrong.\n"); + return -1; + } if (fstat(sw->fd, &stat) == -1) { LOGPMO(mo, DNM, LOGL_ERROR, "Could not stat the file.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 Gerrit-Change-Number: 26328 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 11:59:39 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Nov 2021 11:59:39 +0000 Subject: Change in libosmocore[master]: fix isdigit taking unsigned as input References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26329 ) Change subject: fix isdigit taking unsigned as input ...................................................................... fix isdigit taking unsigned as input gcc complains because our char might or might not be signed depending on arch and phase of the moon: Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e error: array subscript has type 'char' [-Werror=charsubscripts] --- M src/utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/29/26329/1 diff --git a/src/utils.c b/src/utils.c index 626dcb4..300204a 100644 --- a/src/utils.c +++ b/src/utils.c @@ -1250,7 +1250,7 @@ if (point) return -EINVAL; point = p; - } else if (!isdigit(*p)) + } else if (!isdigit((unsigned char)*p)) return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e Gerrit-Change-Number: 26329 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 12:00:23 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Nov 2021 12:00:23 +0000 Subject: Change in libosmocore[master]: fix isdigit taking unsigned as input In-Reply-To: References: Message-ID: Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/26329 ) Change subject: fix isdigit taking unsigned as input ...................................................................... fix isdigit taking unsigned as input gcc complains because our char might or might not be signed depending on arch and phase of the moon: error: array subscript has type 'char' [-Werror=charsubscripts] Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e --- M src/utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/29/26329/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e Gerrit-Change-Number: 26329 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 12:03:07 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Nov 2021 12:03:07 +0000 Subject: Change in libosmocore[master]: fix isdigit taking unsigned as input In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26329 ) Change subject: fix isdigit taking unsigned as input ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e Gerrit-Change-Number: 26329 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 19 Nov 2021 12:03:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 12:03:10 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Nov 2021 12:03:10 +0000 Subject: Change in libosmocore[master]: fix isdigit taking unsigned as input In-Reply-To: References: Message-ID: Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26329 ) Change subject: fix isdigit taking unsigned as input ...................................................................... fix isdigit taking unsigned as input gcc complains because our char might or might not be signed depending on arch and phase of the moon: error: array subscript has type 'char' [-Werror=charsubscripts] Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e --- M src/utils.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/utils.c b/src/utils.c index 626dcb4..300204a 100644 --- a/src/utils.c +++ b/src/utils.c @@ -1250,7 +1250,7 @@ if (point) return -EINVAL; point = p; - } else if (!isdigit(*p)) + } else if (!isdigit((unsigned char)*p)) return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7c76f9a2318c4f0e5eedeea00ec380824b86567e Gerrit-Change-Number: 26329 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 12:21:56 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 12:21:56 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26165 to look at the new patch set (#9). Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py M pySim/utils.py 6 files changed, 216 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/26165/9 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 13:10:04 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 13:10:04 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26253 to look at the new patch set (#5). Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... pySim-read: put try/catch block around select_adf_by_aid() Selecting an application may fail, especially when the application does not exist on the card. Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef --- M pySim-read.py 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/26253/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 13:10:04 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 13:10:04 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/4/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/4/pySim-read.py at 296 PS4, Line 296: print("ADF.ISIM: Can't select application -- " + str(e)) > Ack, makes sense. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 19 Nov 2021 13:10:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 13:10:05 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 13:10:05 +0000 Subject: Change in pysim[master]: cards: make _get_aid case insensitive References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26330 ) Change subject: cards: make _get_aid case insensitive ...................................................................... cards: make _get_aid case insensitive There is no need to be case sensitive when the xSIM application name is given as AID. Change-Id: I9944d9180bf1ba35f44f0be2b05bdb725b5b8da9 --- M pySim/cards.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/30/26330/1 diff --git a/pySim/cards.py b/pySim/cards.py index 2319a56..a822161 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -284,6 +284,7 @@ # First (known) halves of the U/ISIM AID aid_map["usim"] = "a0000000871002" aid_map["isim"] = "a0000000871004" + adf = adf.lower() if adf in aid_map: return aid_map[adf] return None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9944d9180bf1ba35f44f0be2b05bdb725b5b8da9 Gerrit-Change-Number: 26330 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 13:25:00 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 19 Nov 2021 13:25:00 +0000 Subject: Change in libosmocore[master]: bssgp_bvc_fsm: Move log message to the correct place References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26331 ) Change subject: bssgp_bvc_fsm: Move log message to the correct place ...................................................................... bssgp_bvc_fsm: Move log message to the correct place The log message is very confusing if printed for PtP-BVCI as well. Move it into the correct if branch. Change-Id: I0359443ddc52108b492f741005c4699e06b40183 --- M src/gb/bssgp_bvc_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/26331/1 diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c index ce9079d..664ad09 100644 --- a/src/gb/bssgp_bvc_fsm.c +++ b/src/gb/bssgp_bvc_fsm.c @@ -415,8 +415,8 @@ rx = data; tp = (const struct tlv_parsed *) msgb_bcid(rx); /* If BVC-UNBLOCK-ACK PDU is received by an BSS for the signalling BVC, the PDU is ignored. */ - LOGPFSML(fi, LOGL_ERROR, "Rx BVC-UNBLOCK-ACK on BVCI=0 is illegal\n"); if (bfp->bvci == 0) { + LOGPFSML(fi, LOGL_ERROR, "Rx BVC-UNBLOCK-ACK on BVCI=0 is illegal\n"); if (!bfp->role_sgsn) break; _tx_status(fi, BSSGP_CAUSE_SEM_INCORR_PDU, rx); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0359443ddc52108b492f741005c4699e06b40183 Gerrit-Change-Number: 26331 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 13:28:11 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 19 Nov 2021 13:28:11 +0000 Subject: Change in pysim[master]: cards: make _get_aid case insensitive In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26330 ) Change subject: cards: make _get_aid case insensitive ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9944d9180bf1ba35f44f0be2b05bdb725b5b8da9 Gerrit-Change-Number: 26330 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Fri, 19 Nov 2021 13:28:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 13:43:13 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 19 Nov 2021 13:43:13 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 19 Nov 2021 13:43:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 14:11:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 14:11:07 +0000 Subject: Change in libosmocore[master]: bssgp_bvc_fsm: Move log message to the correct place In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26331 ) Change subject: bssgp_bvc_fsm: Move log message to the correct place ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0359443ddc52108b492f741005c4699e06b40183 Gerrit-Change-Number: 26331 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 19 Nov 2021 14:11:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 14:12:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 14:12:04 +0000 Subject: Change in osmo-qcdiag[master]: const struct value_string *[]: remove static array size References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 ) Change subject: const struct value_string *[]: remove static array size ...................................................................... const struct value_string *[]: remove static array size Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 --- M src/gprs_l1.c M src/gprs_rlc.c M src/protocol/diag_log_gprs_l1.h M src/protocol/diag_log_gprs_mac.h M src/protocol/diag_log_gprs_rlc.h M src/protocol/diag_log_gsm.h 6 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-qcdiag refs/changes/32/26332/1 diff --git a/src/gprs_l1.c b/src/gprs_l1.c index d830e60..d00bf5b 100644 --- a/src/gprs_l1.c +++ b/src/gprs_l1.c @@ -20,14 +20,14 @@ #include "protocol/diag_log_gprs_l1.h" -const struct value_string gprs_tx_ul_chans[4] = { +const struct value_string gprs_tx_ul_chans[] = { { DIAG_TX_UL_CH_T_PRACH, "PRACK" }, { DIAG_TX_UL_CH_T_UL_PTCCH, "UL-PTCCH" }, { DIAG_TX_UL_CH_T_UL_PACCH_PDTCH, "UL-PACCH-PDTCH" }, { 0, NULL } }; -const struct value_string gprs_coding_schemes[16] = { +const struct value_string gprs_coding_schemes[] = { { DIAG_GPRS_CS_CS1, "CS1" }, { DIAG_GPRS_CS_CS2, "CS2" }, { DIAG_GPRS_CS_CS3, "CS3" }, diff --git a/src/gprs_rlc.c b/src/gprs_rlc.c index be01a53..1b46c83 100644 --- a/src/gprs_rlc.c +++ b/src/gprs_rlc.c @@ -20,7 +20,7 @@ #include "protocol/diag_log_gprs_rlc.h" -struct value_string gprs_rlc_ul_state_vals[8] = { +struct value_string gprs_rlc_ul_state_vals[] = { { US_NULL, "US_NULL" }, { US_AWAIT_ASS, "US_AWAIT_ASS" }, { US_ACK_XFER, "US_AWAIT_XFER" }, @@ -31,7 +31,7 @@ { 0, NULL } }; -struct value_string gprs_rlc_ul_substate_vals[5] = { +struct value_string gprs_rlc_ul_substate_vals[] = { { RALS_NULL, "RALS_NULL" }, { RALS_AWAIT_TX_COMPLETE, "RALS_AWAIT_TX_COMPLETE" }, { RALS_CURRENT_PDU_TX_COMPLETED, "RALS_CURRENT_PDU_TX_COMPLETED" }, @@ -39,7 +39,7 @@ { 0, NULL } }; -struct value_string gprs_rlc_dl_state_vals[7] = { +struct value_string gprs_rlc_dl_state_vals[] = { { DS_NULL, "DS_NULL" }, { DS_RX_ACK, "DS_RX_ACK" }, { DS_RX_UNACK, "DS_RX_UNACK" }, diff --git a/src/protocol/diag_log_gprs_l1.h b/src/protocol/diag_log_gprs_l1.h index 8f8585c..995eff2 100644 --- a/src/protocol/diag_log_gprs_l1.h +++ b/src/protocol/diag_log_gprs_l1.h @@ -72,7 +72,7 @@ DIAG_TX_UL_CH_T_UL_PTCCH, DIAG_TX_UL_CH_T_UL_PACCH_PDTCH, }; -extern const struct value_string gprs_tx_ul_chans[4]; +extern const struct value_string gprs_tx_ul_chans[]; enum gprs_coding_scheme { DIAG_GPRS_CS_CS1, @@ -91,7 +91,7 @@ DIAG_GPRS_CS_MCS8, DIAG_GPRS_CS_MCS9, }; -extern const struct value_string gprs_coding_schemes[16]; +extern const struct value_string gprs_coding_schemes[]; struct gprs_tx_sched_res { uint32_t fn; diff --git a/src/protocol/diag_log_gprs_mac.h b/src/protocol/diag_log_gprs_mac.h index 536128d..16122ae 100644 --- a/src/protocol/diag_log_gprs_mac.h +++ b/src/protocol/diag_log_gprs_mac.h @@ -7,7 +7,7 @@ IDLE_MODE, TRANSFER_MODE, }; -extern struct value_string gprs_mac_mode_vals[4]; +extern struct value_string gprs_mac_mode_vals[]; enum gprs_mac_null_substates { NULL_INACTIVE, @@ -23,7 +23,7 @@ NULL_DTM_GTTP_UL_CON, NULL_RESET, }; -extern struct value_string gprs_mac_null_substate_vals[13]; +extern struct value_string gprs_mac_null_substate_vals[]; enum gprs_mac_idle_substates { IDLE_PASSIVE, @@ -35,7 +35,7 @@ IDLE_UL_1PHASE_CONT_RES, IDLE_DL_ASS, }; -extern struct value_string gprs_mac_idle_substate_vals[9]; +extern struct value_string gprs_mac_idle_substate_vals[]; enum gprs_mac_transfer_substates { TRANSFER_INACTIVE, @@ -52,7 +52,7 @@ TRANSFER_CONCURRENT_DYNAMIC_REALLOC, TRANSFER_CONCURRENT_DL_REASSIGN_DYNAMIC_REALLOC, }; -extern struct value_string gprs_mac_transfer_substate_vals[14]; +extern struct value_string gprs_mac_transfer_substate_vals[]; /* LOG_GPRS_MAC_STATE_C */ struct gprs_mac_state_change { @@ -126,7 +126,7 @@ PBCCH_CHANNEL = 0x82, DL_PACCH_CHANNEL = 0x83, }; -extern struct value_string gprs_mac_chan_type_vals[8]; +extern struct value_string gprs_mac_chan_type_vals[]; enum gprs_mac_msg_type { PACKET_CELL_CHANGE_FAILURE = 0x00, @@ -146,7 +146,7 @@ PACKET_CS_REQUEST = 0x0e, PACKET_CHANNEL_REQUEST = 0x20, }; -extern struct value_string gprs_mac_msg_type_vals[17]; +extern struct value_string gprs_mac_msg_type_vals[]; struct evt_gprs_mac_msg { uint8_t msg_type; diff --git a/src/protocol/diag_log_gprs_rlc.h b/src/protocol/diag_log_gprs_rlc.h index f59c662..49f1b2c 100644 --- a/src/protocol/diag_log_gprs_rlc.h +++ b/src/protocol/diag_log_gprs_rlc.h @@ -28,7 +28,7 @@ US_TEST_MODE, US_AWAIT_RECOVERY, }; -extern struct value_string gprs_rlc_ul_state_vals[8]; +extern struct value_string gprs_rlc_ul_state_vals[]; enum gprs_rlc_ul_substate { RALS_NULL, @@ -36,7 +36,7 @@ RALS_CURRENT_PDU_TX_COMPLETED, RALS_COMPLETE, }; -extern struct value_string gprs_rlc_ul_substate_vals[5]; +extern struct value_string gprs_rlc_ul_substate_vals[]; enum gprs_rlc_dl_state { DS_NULL, @@ -46,7 +46,7 @@ DS_RX_UNACK_PENDING_RELEASE, DS_TEST_MODE, }; -extern struct value_string gprs_rlc_dl_state_vals[7]; +extern struct value_string gprs_rlc_dl_state_vals[]; /* LOG_GPRS_RLC_UL_STATS_C */ struct gprs_rlc_ul_stats { @@ -125,7 +125,7 @@ EGPRS_HEADER_TYPE_2, EGPRS_HEADER_TYPE_3 }; -extern struct value_string gprs_rlc_hdr_type_vals[5]; +extern struct value_string gprs_rlc_hdr_type_vals[]; /* LOG_EGPRS_RLC_DL_HEADER_C */ diff --git a/src/protocol/diag_log_gsm.h b/src/protocol/diag_log_gsm.h index d382f1a..5d956b4 100644 --- a/src/protocol/diag_log_gsm.h +++ b/src/protocol/diag_log_gsm.h @@ -158,7 +158,7 @@ DIAG_RR_ST_RESET = 23, DIAG_RR_ST_W2G_BACKGROUND_PLN_SEARCH = 24, }; -extern const struct value_string diag_gsm_rr_st_vals[25]; +extern const struct value_string diag_gsm_rr_st_vals[]; /* LOG_GSM_RR_STATE_C */ struct diag_gsm_rr_state { @@ -178,7 +178,7 @@ DIAG_GRR_ST_BG_PLMN_SEARCH = 7, DIAG_GRR_ST_PCCO = 8, }; -extern const struct value_string diag_gprs_grr_st_vals[9]; +extern const struct value_string diag_gprs_grr_st_vals[]; /* LOG_GPRS_GRR_STATE_C */ struct diag_gprs_grr_state { @@ -192,7 +192,7 @@ DIAG_GPRS_LLMES_TLLI_ASS = 1, DIAG_GPRS_LLMES_TEST_MODE = 2, }; -extern const struct value_string diag_gprs_llme_st_vals[4]; +extern const struct value_string diag_gprs_llme_st_vals[]; /* LOG_GPRS_LLC_ME_INFO_C */ struct diag_gprs_llme_info { -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 Gerrit-Change-Number: 26332 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 14:12:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 14:12:39 +0000 Subject: Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 ) Change subject: protocol: fix: properly declare value_string arrays ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > thanks. at the same time we could remove the fixed array size in the declaration to ensure future extensions only require adding entries to the array, and not also the declaration. Done, see https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332. -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef Gerrit-Change-Number: 26326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 19 Nov 2021 14:12:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 14:13:21 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 19 Nov 2021 14:13:21 +0000 Subject: Change in libosmocore[master]: bssgp_bvc_fsm: Move log message to the correct place In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26331 ) Change subject: bssgp_bvc_fsm: Move log message to the correct place ...................................................................... bssgp_bvc_fsm: Move log message to the correct place The log message is very confusing if printed for PtP-BVCI as well. Move it into the correct if branch. Change-Id: I0359443ddc52108b492f741005c4699e06b40183 --- M src/gb/bssgp_bvc_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c index ce9079d..664ad09 100644 --- a/src/gb/bssgp_bvc_fsm.c +++ b/src/gb/bssgp_bvc_fsm.c @@ -415,8 +415,8 @@ rx = data; tp = (const struct tlv_parsed *) msgb_bcid(rx); /* If BVC-UNBLOCK-ACK PDU is received by an BSS for the signalling BVC, the PDU is ignored. */ - LOGPFSML(fi, LOGL_ERROR, "Rx BVC-UNBLOCK-ACK on BVCI=0 is illegal\n"); if (bfp->bvci == 0) { + LOGPFSML(fi, LOGL_ERROR, "Rx BVC-UNBLOCK-ACK on BVCI=0 is illegal\n"); if (!bfp->role_sgsn) break; _tx_status(fi, BSSGP_CAUSE_SEM_INCORR_PDU, rx); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0359443ddc52108b492f741005c4699e06b40183 Gerrit-Change-Number: 26331 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 15:33:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Nov 2021 15:33:35 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 6: I have the feeling you didn't understand fully my comment. My point is that checking config validity and dropping the connection should be done once, during sign_link_up or alike, not everytime a message is received on any connection. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 15:33:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 15:33:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Nov 2021 15:33:49 +0000 Subject: Change in osmo-bsc[master]: abis_nm: fix typo In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26327 ) Change subject: abis_nm: fix typo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2cb7b986db9d394db2c912247db861704d2c7c23 Gerrit-Change-Number: 26327 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 15:33:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 15:35:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Nov 2021 15:35:17 +0000 Subject: Change in osmo-bsc[master]: abis_nm: use struct sdp_firmware from libosmocore In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26328 ) Change subject: abis_nm: use struct sdp_firmware from libosmocore ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26328/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26328/1/src/osmo-bsc/abis_nm.c at 54 PS1, Line 54: #include looks like you'd want to include the relevant libosmocore header instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 Gerrit-Change-Number: 26328 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 15:35:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 15:36:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Nov 2021 15:36:30 +0000 Subject: Change in osmo-qcdiag[master]: const struct value_string *[]: remove static array size In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 ) Change subject: const struct value_string *[]: remove static array size ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 Gerrit-Change-Number: 26332 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 15:36:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 15:36:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Nov 2021 15:36:57 +0000 Subject: Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 ) Change subject: protocol: fix: properly declare value_string arrays ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef Gerrit-Change-Number: 26326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 15:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 16:08:46 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 16:08:46 +0000 Subject: Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 ) Change subject: protocol: fix: properly declare value_string arrays ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef Gerrit-Change-Number: 26326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 16:08:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 16:12:34 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 19 Nov 2021 16:12:34 +0000 Subject: Change in osmo-qcdiag[master]: const struct value_string *[]: remove static array size In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 ) Change subject: const struct value_string *[]: remove static array size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 Gerrit-Change-Number: 26332 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 16:12:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 16:45:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 16:45:18 +0000 Subject: Change in osmo-qcdiag[master]: const struct value_string *[]: remove static array size In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 ) Change subject: const struct value_string *[]: remove static array size ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 Gerrit-Change-Number: 26332 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 16:45:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 16:45:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 16:45:22 +0000 Subject: Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 ) Change subject: protocol: fix: properly declare value_string arrays ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef Gerrit-Change-Number: 26326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 16:45:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 16:45:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 16:45:25 +0000 Subject: Change in osmo-qcdiag[master]: protocol: fix: properly declare value_string arrays In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 ) Change subject: protocol: fix: properly declare value_string arrays ...................................................................... protocol: fix: properly declare value_string arrays Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef --- M src/protocol/diag_log_gprs_l1.h M src/protocol/diag_log_gsm.h 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved dexter: Looks good to me, approved fixeria: Verified diff --git a/src/protocol/diag_log_gprs_l1.h b/src/protocol/diag_log_gprs_l1.h index eee9632..8f8585c 100644 --- a/src/protocol/diag_log_gprs_l1.h +++ b/src/protocol/diag_log_gprs_l1.h @@ -72,7 +72,7 @@ DIAG_TX_UL_CH_T_UL_PTCCH, DIAG_TX_UL_CH_T_UL_PACCH_PDTCH, }; -const struct value_string gprs_tx_ul_chans[4]; +extern const struct value_string gprs_tx_ul_chans[4]; enum gprs_coding_scheme { DIAG_GPRS_CS_CS1, @@ -91,7 +91,7 @@ DIAG_GPRS_CS_MCS8, DIAG_GPRS_CS_MCS9, }; -const struct value_string gprs_coding_schemes[16]; +extern const struct value_string gprs_coding_schemes[16]; struct gprs_tx_sched_res { uint32_t fn; diff --git a/src/protocol/diag_log_gsm.h b/src/protocol/diag_log_gsm.h index 378472f..d382f1a 100644 --- a/src/protocol/diag_log_gsm.h +++ b/src/protocol/diag_log_gsm.h @@ -192,7 +192,7 @@ DIAG_GPRS_LLMES_TLLI_ASS = 1, DIAG_GPRS_LLMES_TEST_MODE = 2, }; -const struct value_string diag_gprs_llme_st_vals[4]; +extern const struct value_string diag_gprs_llme_st_vals[4]; /* LOG_GPRS_LLC_ME_INFO_C */ struct diag_gprs_llme_info { @@ -282,7 +282,7 @@ DIAG_SAPI0_ST_LINK_SUSP, DIAG_SAPI0_ST_UA_PEND, }; -const struct value_string diag_gsm_l2_sapi0_st_vals[10]; +extern const struct value_string diag_gsm_l2_sapi0_st_vals[10]; enum diag_gsm_sapi3_state { DIAG_SAPI3_ST_NULL, @@ -294,7 +294,7 @@ DIAG_SAPI3_ST_TMR_RECOV, DIAG_SAPI3_ST_UA_PEND, }; -const struct value_string diag_gsm_l2_sapi3_st_vals[9]; +extern const struct value_string diag_gsm_l2_sapi3_st_vals[9]; enum diag_gsm_l2_event { DIAG_L2_EV_NO_EVENT, @@ -325,7 +325,7 @@ DIAG_L2_EV_UA_SENT, DIAG_L2_EV_FORCED_SUSPEND_REQ, }; -const struct value_string diag_gsm_l2_event_vals[28]; +extern const struct value_string diag_gsm_l2_event_vals[28]; struct diag_gsm_l2_state { uint8_t sapi; @@ -343,7 +343,7 @@ DIAG_L2_CHT_FACCH_F = 6, DIAG_L2_CHT_FACCH_H = 7, }; -const struct value_string diag_gsm_l2_chantype_vals[9]; +extern const struct value_string diag_gsm_l2_chantype_vals[9]; struct diag_gsm_l2_transm_status { uint8_t sapi; -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I62b2977d6a130d5b1ea25ddf88b3475f0c6024ef Gerrit-Change-Number: 26326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 16:45:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 16:45:26 +0000 Subject: Change in osmo-qcdiag[master]: const struct value_string *[]: remove static array size In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 ) Change subject: const struct value_string *[]: remove static array size ...................................................................... const struct value_string *[]: remove static array size Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 --- M src/gprs_l1.c M src/gprs_rlc.c M src/protocol/diag_log_gprs_l1.h M src/protocol/diag_log_gprs_mac.h M src/protocol/diag_log_gprs_rlc.h M src/protocol/diag_log_gsm.h 6 files changed, 20 insertions(+), 20 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve dexter: Looks good to me, approved fixeria: Verified diff --git a/src/gprs_l1.c b/src/gprs_l1.c index d830e60..d00bf5b 100644 --- a/src/gprs_l1.c +++ b/src/gprs_l1.c @@ -20,14 +20,14 @@ #include "protocol/diag_log_gprs_l1.h" -const struct value_string gprs_tx_ul_chans[4] = { +const struct value_string gprs_tx_ul_chans[] = { { DIAG_TX_UL_CH_T_PRACH, "PRACK" }, { DIAG_TX_UL_CH_T_UL_PTCCH, "UL-PTCCH" }, { DIAG_TX_UL_CH_T_UL_PACCH_PDTCH, "UL-PACCH-PDTCH" }, { 0, NULL } }; -const struct value_string gprs_coding_schemes[16] = { +const struct value_string gprs_coding_schemes[] = { { DIAG_GPRS_CS_CS1, "CS1" }, { DIAG_GPRS_CS_CS2, "CS2" }, { DIAG_GPRS_CS_CS3, "CS3" }, diff --git a/src/gprs_rlc.c b/src/gprs_rlc.c index be01a53..1b46c83 100644 --- a/src/gprs_rlc.c +++ b/src/gprs_rlc.c @@ -20,7 +20,7 @@ #include "protocol/diag_log_gprs_rlc.h" -struct value_string gprs_rlc_ul_state_vals[8] = { +struct value_string gprs_rlc_ul_state_vals[] = { { US_NULL, "US_NULL" }, { US_AWAIT_ASS, "US_AWAIT_ASS" }, { US_ACK_XFER, "US_AWAIT_XFER" }, @@ -31,7 +31,7 @@ { 0, NULL } }; -struct value_string gprs_rlc_ul_substate_vals[5] = { +struct value_string gprs_rlc_ul_substate_vals[] = { { RALS_NULL, "RALS_NULL" }, { RALS_AWAIT_TX_COMPLETE, "RALS_AWAIT_TX_COMPLETE" }, { RALS_CURRENT_PDU_TX_COMPLETED, "RALS_CURRENT_PDU_TX_COMPLETED" }, @@ -39,7 +39,7 @@ { 0, NULL } }; -struct value_string gprs_rlc_dl_state_vals[7] = { +struct value_string gprs_rlc_dl_state_vals[] = { { DS_NULL, "DS_NULL" }, { DS_RX_ACK, "DS_RX_ACK" }, { DS_RX_UNACK, "DS_RX_UNACK" }, diff --git a/src/protocol/diag_log_gprs_l1.h b/src/protocol/diag_log_gprs_l1.h index 8f8585c..995eff2 100644 --- a/src/protocol/diag_log_gprs_l1.h +++ b/src/protocol/diag_log_gprs_l1.h @@ -72,7 +72,7 @@ DIAG_TX_UL_CH_T_UL_PTCCH, DIAG_TX_UL_CH_T_UL_PACCH_PDTCH, }; -extern const struct value_string gprs_tx_ul_chans[4]; +extern const struct value_string gprs_tx_ul_chans[]; enum gprs_coding_scheme { DIAG_GPRS_CS_CS1, @@ -91,7 +91,7 @@ DIAG_GPRS_CS_MCS8, DIAG_GPRS_CS_MCS9, }; -extern const struct value_string gprs_coding_schemes[16]; +extern const struct value_string gprs_coding_schemes[]; struct gprs_tx_sched_res { uint32_t fn; diff --git a/src/protocol/diag_log_gprs_mac.h b/src/protocol/diag_log_gprs_mac.h index 536128d..16122ae 100644 --- a/src/protocol/diag_log_gprs_mac.h +++ b/src/protocol/diag_log_gprs_mac.h @@ -7,7 +7,7 @@ IDLE_MODE, TRANSFER_MODE, }; -extern struct value_string gprs_mac_mode_vals[4]; +extern struct value_string gprs_mac_mode_vals[]; enum gprs_mac_null_substates { NULL_INACTIVE, @@ -23,7 +23,7 @@ NULL_DTM_GTTP_UL_CON, NULL_RESET, }; -extern struct value_string gprs_mac_null_substate_vals[13]; +extern struct value_string gprs_mac_null_substate_vals[]; enum gprs_mac_idle_substates { IDLE_PASSIVE, @@ -35,7 +35,7 @@ IDLE_UL_1PHASE_CONT_RES, IDLE_DL_ASS, }; -extern struct value_string gprs_mac_idle_substate_vals[9]; +extern struct value_string gprs_mac_idle_substate_vals[]; enum gprs_mac_transfer_substates { TRANSFER_INACTIVE, @@ -52,7 +52,7 @@ TRANSFER_CONCURRENT_DYNAMIC_REALLOC, TRANSFER_CONCURRENT_DL_REASSIGN_DYNAMIC_REALLOC, }; -extern struct value_string gprs_mac_transfer_substate_vals[14]; +extern struct value_string gprs_mac_transfer_substate_vals[]; /* LOG_GPRS_MAC_STATE_C */ struct gprs_mac_state_change { @@ -126,7 +126,7 @@ PBCCH_CHANNEL = 0x82, DL_PACCH_CHANNEL = 0x83, }; -extern struct value_string gprs_mac_chan_type_vals[8]; +extern struct value_string gprs_mac_chan_type_vals[]; enum gprs_mac_msg_type { PACKET_CELL_CHANGE_FAILURE = 0x00, @@ -146,7 +146,7 @@ PACKET_CS_REQUEST = 0x0e, PACKET_CHANNEL_REQUEST = 0x20, }; -extern struct value_string gprs_mac_msg_type_vals[17]; +extern struct value_string gprs_mac_msg_type_vals[]; struct evt_gprs_mac_msg { uint8_t msg_type; diff --git a/src/protocol/diag_log_gprs_rlc.h b/src/protocol/diag_log_gprs_rlc.h index f59c662..49f1b2c 100644 --- a/src/protocol/diag_log_gprs_rlc.h +++ b/src/protocol/diag_log_gprs_rlc.h @@ -28,7 +28,7 @@ US_TEST_MODE, US_AWAIT_RECOVERY, }; -extern struct value_string gprs_rlc_ul_state_vals[8]; +extern struct value_string gprs_rlc_ul_state_vals[]; enum gprs_rlc_ul_substate { RALS_NULL, @@ -36,7 +36,7 @@ RALS_CURRENT_PDU_TX_COMPLETED, RALS_COMPLETE, }; -extern struct value_string gprs_rlc_ul_substate_vals[5]; +extern struct value_string gprs_rlc_ul_substate_vals[]; enum gprs_rlc_dl_state { DS_NULL, @@ -46,7 +46,7 @@ DS_RX_UNACK_PENDING_RELEASE, DS_TEST_MODE, }; -extern struct value_string gprs_rlc_dl_state_vals[7]; +extern struct value_string gprs_rlc_dl_state_vals[]; /* LOG_GPRS_RLC_UL_STATS_C */ struct gprs_rlc_ul_stats { @@ -125,7 +125,7 @@ EGPRS_HEADER_TYPE_2, EGPRS_HEADER_TYPE_3 }; -extern struct value_string gprs_rlc_hdr_type_vals[5]; +extern struct value_string gprs_rlc_hdr_type_vals[]; /* LOG_EGPRS_RLC_DL_HEADER_C */ diff --git a/src/protocol/diag_log_gsm.h b/src/protocol/diag_log_gsm.h index d382f1a..5d956b4 100644 --- a/src/protocol/diag_log_gsm.h +++ b/src/protocol/diag_log_gsm.h @@ -158,7 +158,7 @@ DIAG_RR_ST_RESET = 23, DIAG_RR_ST_W2G_BACKGROUND_PLN_SEARCH = 24, }; -extern const struct value_string diag_gsm_rr_st_vals[25]; +extern const struct value_string diag_gsm_rr_st_vals[]; /* LOG_GSM_RR_STATE_C */ struct diag_gsm_rr_state { @@ -178,7 +178,7 @@ DIAG_GRR_ST_BG_PLMN_SEARCH = 7, DIAG_GRR_ST_PCCO = 8, }; -extern const struct value_string diag_gprs_grr_st_vals[9]; +extern const struct value_string diag_gprs_grr_st_vals[]; /* LOG_GPRS_GRR_STATE_C */ struct diag_gprs_grr_state { @@ -192,7 +192,7 @@ DIAG_GPRS_LLMES_TLLI_ASS = 1, DIAG_GPRS_LLMES_TEST_MODE = 2, }; -extern const struct value_string diag_gprs_llme_st_vals[4]; +extern const struct value_string diag_gprs_llme_st_vals[]; /* LOG_GPRS_LLC_ME_INFO_C */ struct diag_gprs_llme_info { -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/26332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I806c5053a36f9c74c6b80ac2f7541dad3da58900 Gerrit-Change-Number: 26332 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 18:06:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 18:06:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: type 'char' was substituted with 'charstring' References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 ) Change subject: library/DNS_Helpers: type 'char' was substituted with 'charstring' ...................................................................... library/DNS_Helpers: type 'char' was substituted with 'charstring' Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Related: SYS#5602 --- M library/DNS_Helpers.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/26333/1 diff --git a/library/DNS_Helpers.ttcn b/library/DNS_Helpers.ttcn index 85040fc..a1a347c 100644 --- a/library/DNS_Helpers.ttcn +++ b/library/DNS_Helpers.ttcn @@ -10,7 +10,7 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -private function f_strchr(charstring s, char c) return integer { +private function f_strchr(charstring s, charstring c) return integer { var integer i; for (i := 0; i < lengthof(s); i := i+1) { if (s[i] == c) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Gerrit-Change-Number: 26333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 19:03:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Nov 2021 19:03:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: type 'char' was substituted with 'charstring' In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 ) Change subject: library/DNS_Helpers: type 'char' was substituted with 'charstring' ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333/1//COMMIT_MSG at 7 PS1, Line 7: library/DNS_Helpers: type 'char' was substituted with 'charstring' what do you mean? in the ttcn3 specs? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Gerrit-Change-Number: 26333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 19:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 19 20:15:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Nov 2021 20:15:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: type 'char' was substituted with 'charstring' In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 ) Change subject: library/DNS_Helpers: type 'char' was substituted with 'charstring' ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333/1//COMMIT_MSG at 7 PS1, Line 7: library/DNS_Helpers: type 'char' was substituted with 'charstring' > what do you mean? in the ttcn3 specs? This is a warning message from TITAN. Not sure if 'char' ever was in the specs. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Gerrit-Change-Number: 26333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Nov 2021 20:15:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 20 16:13:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 20 Nov 2021 16:13:27 +0000 Subject: Change in osmo-bsc[master]: abis_nm: fix typo In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26327 ) Change subject: abis_nm: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2cb7b986db9d394db2c912247db861704d2c7c23 Gerrit-Change-Number: 26327 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 20 Nov 2021 16:13:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 20 16:14:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 20 Nov 2021 16:14:48 +0000 Subject: Change in osmo-bsc[master]: abis_nm: use struct sdp_firmware from libosmocore In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26328 ) Change subject: abis_nm: use struct sdp_firmware from libosmocore ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 Gerrit-Change-Number: 26328 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 20 Nov 2021 16:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 10:31:41 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 22 Nov 2021 10:31:41 +0000 Subject: Change in osmo-bsc[master]: abis_nm: fix typo In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26327 ) Change subject: abis_nm: fix typo ...................................................................... abis_nm: fix typo Change-Id: I2cb7b986db9d394db2c912247db861704d2c7c23 --- M src/osmo-bsc/abis_nm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 7c04394..aeb4ba3 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -1363,7 +1363,7 @@ } if (strncmp(firmware_header.magic, " SDP", 4) != 0) { - LOGPMO(mo, DNM, LOGL_ERROR, "The magic number1 is wrong.\n"); + LOGPMO(mo, DNM, LOGL_ERROR, "The magic number is wrong.\n"); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2cb7b986db9d394db2c912247db861704d2c7c23 Gerrit-Change-Number: 26327 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 10:37:30 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 22 Nov 2021 10:37:30 +0000 Subject: Change in osmo-bsc[master]: abis_nm: use struct sdp_firmware from libosmocore In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26328 ) Change subject: abis_nm: use struct sdp_firmware from libosmocore ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26328/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26328/1/src/osmo-bsc/abis_nm.c at 54 PS1, Line 54: #include > looks like you'd want to include the relevant libosmocore header instead? I also need ipaccess_drop_oml in a follow up patch. Also osmocom/bsc/ipaccess.h already includes smocom/gsm/protocol/ipaccess.h, no need to include it again. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 Gerrit-Change-Number: 26328 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 10:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 10:50:10 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 22 Nov 2021 10:50:10 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: type 'char' was substituted with 'charstring' In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 ) Change subject: library/DNS_Helpers: type 'char' was substituted with 'charstring' ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333/1//COMMIT_MSG at 7 PS1, Line 7: library/DNS_Helpers: type 'char' was substituted with 'charstring' > This is a warning message from TITAN. Not sure if 'char' ever was in the specs. I have had a quick look at the quick reference: http://www.cheat-sheets.org/saved-copy/TTCN3QRC_viewme.pdf - there seems to be no type "char", they only use "char" to describe valid ranges there, but not as a basic type. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Gerrit-Change-Number: 26333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 10:50:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 10:55:54 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 22 Nov 2021 10:55:54 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 10:55:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 14:14:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Nov 2021 14:14:06 +0000 Subject: Change in osmo-ci[master]: jobs: disable "next" repository References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26334 ) Change subject: jobs: disable "next" repository ...................................................................... jobs: disable "next" repository Related: OS#5322 Change-Id: I9efd020813540941f9afa2c03b9127c04465ce91 --- M jobs/osmocom-obs.yml M jobs/repo-install-test.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/26334/1 diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index 9bdadeb..3b8b1d8 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -6,7 +6,7 @@ type: - nightly - latest - - next + # - next (disabled: OS#5322) - job-template: name: 'Osmocom_OBS_{type}' diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index ad48f1b..313822e 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -5,7 +5,7 @@ - Osmocom-repo-install-{distro} distro: - centos8: - feeds: !!python/tuple [next, nightly] + feeds: !!python/tuple [nightly] # next: disabled (OS#5322) - debian9: feeds: !!python/tuple [nightly, latest] - debian10: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9efd020813540941f9afa2c03b9127c04465ce91 Gerrit-Change-Number: 26334 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 14:14:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Nov 2021 14:14:06 +0000 Subject: Change in osmo-ci[master]: jobs/repo-install-test: centos8: enable latest References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26335 ) Change subject: jobs/repo-install-test: centos8: enable latest ...................................................................... jobs/repo-install-test: centos8: enable latest Now that we made a new release including the new .spec.in files, from which the rpms are built, we have the rpms in the repository and can enable the repo install test for latest. Change-Id: I5da2b895d636b348e5aa0539a23fe4d99e8644ae --- M jobs/repo-install-test.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/35/26335/1 diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index 313822e..dbd5d91 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -5,7 +5,7 @@ - Osmocom-repo-install-{distro} distro: - centos8: - feeds: !!python/tuple [nightly] # next: disabled (OS#5322) + feeds: !!python/tuple [nightly, latest] # next: disabled (OS#5322) - debian9: feeds: !!python/tuple [nightly, latest] - debian10: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5da2b895d636b348e5aa0539a23fe4d99e8644ae Gerrit-Change-Number: 26335 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 14:55:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Nov 2021 14:55:48 +0000 Subject: Change in osmo-ci[master]: jobs: disable "next" repository In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26334 ) Change subject: jobs: disable "next" repository ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9efd020813540941f9afa2c03b9127c04465ce91 Gerrit-Change-Number: 26334 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 14:55:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:02:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:02:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: type 'char' was substituted with 'charstring' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 ) Change subject: library/DNS_Helpers: type 'char' was substituted with 'charstring' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Gerrit-Change-Number: 26333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 15:02:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:02:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:02:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: type 'char' was substituted with 'charstring' In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 ) Change subject: library/DNS_Helpers: type 'char' was substituted with 'charstring' ...................................................................... library/DNS_Helpers: type 'char' was substituted with 'charstring' Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Related: SYS#5602 --- M library/DNS_Helpers.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/DNS_Helpers.ttcn b/library/DNS_Helpers.ttcn index 85040fc..a1a347c 100644 --- a/library/DNS_Helpers.ttcn +++ b/library/DNS_Helpers.ttcn @@ -10,7 +10,7 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ -private function f_strchr(charstring s, char c) return integer { +private function f_strchr(charstring s, charstring c) return integer { var integer i; for (i := 0; i < lengthof(s); i := i+1) { if (s[i] == c) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c93002cf915a8ce7e63f208693b2b63ae52ac38 Gerrit-Change-Number: 26333 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:03:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:03:47 +0000 Subject: Change in osmo-ci[master]: jobs/repo-install-test: centos8: enable latest In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26335 ) Change subject: jobs/repo-install-test: centos8: enable latest ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5da2b895d636b348e5aa0539a23fe4d99e8644ae Gerrit-Change-Number: 26335 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Nov 2021 15:03:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:04:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:04:08 +0000 Subject: Change in osmo-ci[master]: jobs: disable "next" repository In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26334 ) Change subject: jobs: disable "next" repository ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9efd020813540941f9afa2c03b9127c04465ce91 Gerrit-Change-Number: 26334 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 15:04:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:04:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:04:11 +0000 Subject: Change in osmo-ci[master]: jobs: disable "next" repository In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26334 ) Change subject: jobs: disable "next" repository ...................................................................... jobs: disable "next" repository Related: OS#5322 Change-Id: I9efd020813540941f9afa2c03b9127c04465ce91 --- M jobs/osmocom-obs.yml M jobs/repo-install-test.yml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index 9bdadeb..3b8b1d8 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -6,7 +6,7 @@ type: - nightly - latest - - next + # - next (disabled: OS#5322) - job-template: name: 'Osmocom_OBS_{type}' diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index ad48f1b..313822e 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -5,7 +5,7 @@ - Osmocom-repo-install-{distro} distro: - centos8: - feeds: !!python/tuple [next, nightly] + feeds: !!python/tuple [nightly] # next: disabled (OS#5322) - debian9: feeds: !!python/tuple [nightly, latest] - debian10: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9efd020813540941f9afa2c03b9127c04465ce91 Gerrit-Change-Number: 26334 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:04:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:04:12 +0000 Subject: Change in osmo-ci[master]: jobs/repo-install-test: centos8: enable latest In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26335 ) Change subject: jobs/repo-install-test: centos8: enable latest ...................................................................... jobs/repo-install-test: centos8: enable latest Now that we made a new release including the new .spec.in files, from which the rpms are built, we have the rpms in the repository and can enable the repo install test for latest. Change-Id: I5da2b895d636b348e5aa0539a23fe4d99e8644ae --- M jobs/repo-install-test.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index 313822e..dbd5d91 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -5,7 +5,7 @@ - Osmocom-repo-install-{distro} distro: - centos8: - feeds: !!python/tuple [nightly] # next: disabled (OS#5322) + feeds: !!python/tuple [nightly, latest] # next: disabled (OS#5322) - debian9: feeds: !!python/tuple [nightly, latest] - debian10: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5da2b895d636b348e5aa0539a23fe4d99e8644ae Gerrit-Change-Number: 26335 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:44:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:44:13 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 15:44:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:44:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:44:15 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Also try to route STATUS messages with truncated PDU in error In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 ) Change subject: gbproxy: Also try to route STATUS messages with truncated PDU in error ...................................................................... gbproxy: Also try to route STATUS messages with truncated PDU in error Related: OS#4892 Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 --- M src/gb_proxy.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 6fd6f77..fbb6e79 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -982,9 +982,9 @@ struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; struct tlv_parsed tp_inner; - /* TODO: Parse partial messages as well */ rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); - if (rc < 0) + /* Ignore decode failure due to truncated message */ + if (rc < 0 && rc != OSMO_TLVP_ERR_OFS_BEYOND_BUFFER) return rc; if (TLVP_PRESENT(&tp_inner, BSSGP_IE_TLLI)) { @@ -1010,9 +1010,9 @@ struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *)pdu_data; struct tlv_parsed tp_inner; - /* TODO: Parse partial messages as well */ rc = gbproxy_decode_bssgp(bgph, pdu_len, &tp_inner, log_pfx); - if (rc < 0) + /* Ignore decode failure due to truncated message */ + if (rc < 0 && rc != OSMO_TLVP_ERR_OFS_BEYOND_BUFFER) return rc; if (TLVP_PRESENT(&tp_inner, BSSGP_IE_BVCI)) -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I173eb8ef6257248e3c893c31486575019a3ef873 Gerrit-Change-Number: 26319 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:03 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Nov 2021 15:45:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:15 +0000 Subject: Change in pysim[master]: pySim-shell: add method to match card profile to card In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 ) Change subject: pySim-shell: add method to match card profile to card ...................................................................... pySim-shell: add method to match card profile to card UICC and old SIM cards can be difficult to tell apart without prior knowledge of the card. The ATR won't tell if the card is UICC or not. The only remaining option is to try out if the card is able to handle UICC APDUs. The same is true for 2G SIM cards. It is not guranteed that every UICC card will have 2G functionality. Lets add functionality to match a profile to the currently plugged card by actively probing it. Lets also add another profile to distinguish between UICC-only cards and UICC cards that include SIM functionality. Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Related: OS#5274 --- M pySim-shell.py M pySim/filesystem.py A pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py M pySim/utils.py 6 files changed, 216 insertions(+), 70 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index 128c0ea..0519ec4 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -45,8 +45,10 @@ from pySim.card_handler import CardHandler, CardHandlerAuto from pySim.filesystem import CardMF, RuntimeState, CardDF, CardADF, CardModel +from pySim.profile import CardProfile from pySim.ts_51_011 import CardProfileSIM, DF_TELECOM, DF_GSM from pySim.ts_102_221 import CardProfileUICC +from pySim.ts_102_221 import CardProfileUICCSIM from pySim.ts_31_102 import CardApplicationUSIM from pySim.ts_31_103 import CardApplicationISIM from pySim.ara_m import CardApplicationARAM @@ -80,19 +82,32 @@ card = card_detect("auto", scc) if card is None: - print("Could not detect card type!") + print("Warning: Could not detect card type - assuming a generic card type...") + card = SimCard(scc) + + profile = CardProfile.pick(scc) + if profile is None: + print("Unsupported card type!") return None, None + print("Info: Card is of type: %s" % str(profile)) + + # FIXME: This shouln't be here, the profile should add the applications, + # however, we cannot simply put his into ts_102_221.py since we would + # have to e.g. import CardApplicationUSIM from ts_31_102.py, which already + # imports from ts_102_221.py. This means we will end up with a circular + # import, which needs to be resolved first. + if isinstance(profile, CardProfileUICC): + profile.add_application(CardApplicationUSIM()) + profile.add_application(CardApplicationISIM()) + profile.add_application(CardApplicationARAM()) + # Create runtime state with card profile - profile = CardProfileUICC() - profile.add_application(CardApplicationUSIM()) - profile.add_application(CardApplicationISIM()) - profile.add_application(CardApplicationARAM()) rs = RuntimeState(card, profile) - # FIXME: do this dynamically - rs.mf.add_file(DF_TELECOM()) - rs.mf.add_file(DF_GSM()) + # FIXME: This is an GSM-R related file, it needs to be added throughout, + # the profile. At the moment we add it for all cards, this won't hurt, + # but regular SIM and UICC will not have it and fail to select it. rs.mf.add_file(DF_EIRENE()) CardModel.apply_matching_models(scc, rs) diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 0238c97..6b20db5 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1443,65 +1443,6 @@ """ return interpret_sw(self.sw, sw) -class CardProfile(object): - """A Card Profile describes a card, it's filesystem hierarchy, an [initial] list of - applications as well as profile-specific SW and shell commands. Every card has - one card profile, but there may be multiple applications within that profile.""" - def __init__(self, name, **kw): - """ - Args: - desc (str) : Description - files_in_mf : List of CardEF instances present in MF - applications : List of CardApplications present on card - sw : List of status word definitions - shell_cmdsets : List of cmd2 shell command sets of profile-specific commands - cla : class byte that should be used with cards of this profile - sel_ctrl : selection control bytes class byte that should be used with cards of this profile - """ - self.name = name - self.desc = kw.get("desc", None) - self.files_in_mf = kw.get("files_in_mf", []) - self.sw = kw.get("sw", {}) - self.applications = kw.get("applications", []) - self.shell_cmdsets = kw.get("shell_cmdsets", []) - self.cla = kw.get("cla", "00") - self.sel_ctrl = kw.get("sel_ctrl", "0004") - - def __str__(self): - return self.name - - def add_application(self, app:CardApplication): - """Add an application to a card profile. - - Args: - app : CardApplication instance to be added to profile - """ - self.applications.append(app) - - def interpret_sw(self, sw:str): - """Interpret a given status word within the profile. - - Args: - sw : Status word as string of 4 hex digits - - Returns: - Tuple of two strings - """ - return interpret_sw(self.sw, sw) - - def decode_select_response(self, data_hex:str) -> Any: - """Decode the response to a SELECT command. - - This is the fall-back method which doesn't perform any decoding. It mostly - exists so specific derived classes can overload it for actual decoding. - This method is implemented in the profile and is only used when application - specific decoding cannot be performed (no ADF is selected). - - Args: - data_hex: Hex string of the select response - """ - return data_hex - class CardModel(abc.ABC): """A specific card model, typically having some additional vendor-specific files. All diff --git a/pySim/profile.py b/pySim/profile.py new file mode 100644 index 0000000..f068d7c --- /dev/null +++ b/pySim/profile.py @@ -0,0 +1,148 @@ +# -*- coding: utf-8 -*- + +""" pySim: tell old 2G SIMs apart from UICC +""" + +# +# (C) 2021 by Sysmocom s.f.m.c. GmbH +# All Rights Reserved +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +from pySim.commands import SimCardCommands +from pySim.filesystem import CardApplication, interpret_sw +from pySim.utils import all_subclasses +from typing import Any +import abc +import operator + +def _mf_select_test(scc:SimCardCommands, cla_byte:str, sel_ctrl:str) -> bool: + cla_byte_bak = scc.cla_byte + sel_ctrl_bak = scc.sel_ctrl + scc.reset_card() + + scc.cla_byte = cla_byte + scc.sel_ctrl = sel_ctrl + rc = True + try: + scc.select_file('3f00') + except: + rc = False + + scc.reset_card() + scc.cla_byte = cla_byte_bak + scc.sel_ctrl = sel_ctrl_bak + return rc + +def match_uicc(scc:SimCardCommands) -> bool: + """ Try to access MF via UICC APDUs (3GPP TS 102.221), if this works, the + card is considered a UICC card. + """ + return _mf_select_test(scc, "00", "0004") + +def match_sim(scc:SimCardCommands) -> bool: + """ Try to access MF via 2G APDUs (3GPP TS 11.11), if this works, the card + is also a simcard. This will be the case for most UICC cards, but there may + also be plain UICC cards without 2G support as well. + """ + return _mf_select_test(scc, "a0", "0000") + +class CardProfile(object): + """A Card Profile describes a card, it's filesystem hierarchy, an [initial] list of + applications as well as profile-specific SW and shell commands. Every card has + one card profile, but there may be multiple applications within that profile.""" + + def __init__(self, name, **kw): + """ + Args: + desc (str) : Description + files_in_mf : List of CardEF instances present in MF + applications : List of CardApplications present on card + sw : List of status word definitions + shell_cmdsets : List of cmd2 shell command sets of profile-specific commands + cla : class byte that should be used with cards of this profile + sel_ctrl : selection control bytes class byte that should be used with cards of this profile + """ + self.name = name + self.desc = kw.get("desc", None) + self.files_in_mf = kw.get("files_in_mf", []) + self.sw = kw.get("sw", {}) + self.applications = kw.get("applications", []) + self.shell_cmdsets = kw.get("shell_cmdsets", []) + self.cla = kw.get("cla", "00") + self.sel_ctrl = kw.get("sel_ctrl", "0004") + + def __str__(self): + return self.name + + def add_application(self, app:CardApplication): + """Add an application to a card profile. + + Args: + app : CardApplication instance to be added to profile + """ + self.applications.append(app) + + def interpret_sw(self, sw:str): + """Interpret a given status word within the profile. + + Args: + sw : Status word as string of 4 hex digits + + Returns: + Tuple of two strings + """ + return interpret_sw(self.sw, sw) + + def decode_select_response(self, data_hex:str) -> Any: + """Decode the response to a SELECT command. + + This is the fall-back method which doesn't perform any decoding. It mostly + exists so specific derived classes can overload it for actual decoding. + This method is implemented in the profile and is only used when application + specific decoding cannot be performed (no ADF is selected). + + Args: + data_hex: Hex string of the select response + """ + return data_hex + + @staticmethod + @abc.abstractmethod + def match_with_card(scc:SimCardCommands) -> bool: + """Check if the specific profile matches the card. This method is a + placeholder that is overloaded by specific dirived classes. The method + actively probes the card to make sure the profile class matches the + physical card. This usually also means that the card is reset during + the process, so this method must not be called at random times. It may + only be called on startup. + + Args: + scc: SimCardCommands class + Returns: + match = True, no match = False + """ + return False + + @staticmethod + def pick(scc:SimCardCommands): + profiles = list(all_subclasses(CardProfile)) + profiles.sort(key=operator.attrgetter('ORDER')) + + for p in profiles: + if p.match_with_card(scc): + return p() + + return None diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 61e236e..53cd118 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -23,6 +23,13 @@ from pySim.utils import * from pySim.filesystem import * from bidict import bidict +from pySim.profile import CardProfile +from pySim.profile import match_uicc +from pySim.profile import match_sim + +# A UICC will usually also support 2G functionality. If this is the case, we +# need to add DF_GSM and DF_TELECOM along with the UICC related files +from pySim.ts_51_011 import DF_GSM, DF_TELECOM ts_102_22x_cmdset = CardCommandSet('TS 102 22x', [ # TS 102 221 Section 10.1.2 Table 10.5 "Coding of Instruction Byte" @@ -603,9 +610,11 @@ addl_info = FlagsEnum(Byte, req_inc_idle_current=1, support_uicc_suspend=2) self._construct = Struct('max_current_mA'/Int8ub, 't_op_s'/Int8ub, 'addl_info'/addl_info) - class CardProfileUICC(CardProfile): - def __init__(self): + + ORDER = 1 + + def __init__(self, name = 'UICC'): files = [ EF_DIR(), EF_ICCID(), @@ -683,7 +692,27 @@ }, } - super().__init__('UICC', desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) + super().__init__(name, desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) def decode_select_response(self, data_hex:str) -> Any: return decode_select_response(data_hex) + + @staticmethod + def match_with_card(scc:SimCardCommands) -> bool: + return match_uicc(scc) + +class CardProfileUICCSIM(CardProfileUICC): + """Same as above, but including 2G SIM support""" + + ORDER = 0 + + def __init__(self): + super().__init__('UICC-SIM') + + # Add GSM specific files + self.files_in_mf.append(DF_TELECOM()) + self.files_in_mf.append(DF_GSM()) + + @staticmethod + def match_with_card(scc:SimCardCommands) -> bool: + return match_uicc(scc) and match_sim(scc) diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 73d569e..393277b 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -332,6 +332,8 @@ import enum from pySim.filesystem import * +from pySim.profile import CardProfile +from pySim.profile import match_sim ###################################################################### # DF.TELECOM @@ -975,6 +977,9 @@ return ret class CardProfileSIM(CardProfile): + + ORDER = 2 + def __init__(self): sw = { 'Normal': { @@ -1016,3 +1021,7 @@ super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) def decode_select_response(self, data_hex:str) -> Any: return _decode_select_response(data_hex) + + @staticmethod + def match_with_card(scc:SimCardCommands) -> bool: + return match_sim(scc) diff --git a/pySim/utils.py b/pySim/utils.py index 521abd6..e30c970 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -1530,3 +1530,7 @@ if cla and not cmd.match_cla(cla): return None return cmd + +def all_subclasses(cls) -> set: + """Recursively get all subclasses of a specified class""" + return set(cls.__subclasses__()).union([s for c in cls.__subclasses__() for s in all_subclasses(c)]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:15 +0000 Subject: Change in pysim[master]: ts_51_011: move _decode_select_response into profile class In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26205 ) Change subject: ts_51_011: move _decode_select_response into profile class ...................................................................... ts_51_011: move _decode_select_response into profile class The method decode_select_response just calls the function _decode_select_response. But the function _decode_select_response is not called from any other location, so we can move it into the profile class. Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11 --- M pySim/ts_51_011.py 1 file changed, 38 insertions(+), 44 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 393277b..2d3ad0c 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -934,48 +934,6 @@ ] self.add_files(files) - - -def _decode_select_response(resp_hex): - - resp_bin = h2b(resp_hex) - struct_of_file_map = { - 0: 'transparent', - 1: 'linear_fixed', - 3: 'cyclic' - } - type_of_file_map = { - 1: 'mf', - 2: 'df', - 4: 'working_ef' - } - ret = { - 'file_descriptor': {}, - 'proprietary_info': {}, - } - ret['file_id'] = b2h(resp_bin[4:6]) - ret['proprietary_info']['available_memory'] = int.from_bytes(resp_bin[2:4], 'big') - file_type = type_of_file_map[resp_bin[6]] if resp_bin[6] in type_of_file_map else resp_bin[6] - ret['file_descriptor']['file_type'] = file_type - if file_type in ['mf', 'df']: - ret['file_characteristics'] = b2h(resp_bin[13:14]) - ret['num_direct_child_df'] = resp_bin[14] - ret['num_direct_child_ef'] = resp_bin[15] - ret['num_chv_unblock_adm_codes'] = int(resp_bin[16]) - # CHV / UNBLOCK CHV stats - elif file_type in ['working_ef']: - file_struct = struct_of_file_map[resp_bin[13]] if resp_bin[13] in struct_of_file_map else resp_bin[13] - ret['file_descriptor']['structure'] = file_struct - ret['access_conditions'] = b2h(resp_bin[8:10]) - if resp_bin[11] & 0x01 == 0: - ret['life_cycle_status_int'] = 'operational_activated' - elif resp_bin[11] & 0x04: - ret['life_cycle_status_int'] = 'operational_deactivated' - else: - ret['life_cycle_status_int'] = 'terminated' - - return ret - class CardProfileSIM(CardProfile): ORDER = 2 @@ -1019,8 +977,44 @@ } super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) - def decode_select_response(self, data_hex:str) -> Any: - return _decode_select_response(data_hex) + + def decode_select_response(self, resp_hex:str) -> Any: + resp_bin = h2b(resp_hex) + struct_of_file_map = { + 0: 'transparent', + 1: 'linear_fixed', + 3: 'cyclic' + } + type_of_file_map = { + 1: 'mf', + 2: 'df', + 4: 'working_ef' + } + ret = { + 'file_descriptor': {}, + 'proprietary_info': {}, + } + ret['file_id'] = b2h(resp_bin[4:6]) + ret['proprietary_info']['available_memory'] = int.from_bytes(resp_bin[2:4], 'big') + file_type = type_of_file_map[resp_bin[6]] if resp_bin[6] in type_of_file_map else resp_bin[6] + ret['file_descriptor']['file_type'] = file_type + if file_type in ['mf', 'df']: + ret['file_characteristics'] = b2h(resp_bin[13:14]) + ret['num_direct_child_df'] = resp_bin[14] + ret['num_direct_child_ef'] = resp_bin[15] + ret['num_chv_unblock_adm_codes'] = int(resp_bin[16]) + # CHV / UNBLOCK CHV stats + elif file_type in ['working_ef']: + file_struct = struct_of_file_map[resp_bin[13]] if resp_bin[13] in struct_of_file_map else resp_bin[13] + ret['file_descriptor']['structure'] = file_struct + ret['access_conditions'] = b2h(resp_bin[8:10]) + if resp_bin[11] & 0x01 == 0: + ret['life_cycle_status_int'] = 'operational_activated' + elif resp_bin[11] & 0x04: + ret['life_cycle_status_int'] = 'operational_deactivated' + else: + ret['life_cycle_status_int'] = 'terminated' + return ret @staticmethod def match_with_card(scc:SimCardCommands) -> bool: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11 Gerrit-Change-Number: 26205 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:16 +0000 Subject: Change in pysim[master]: commands: use send_apdu_checksw() in method read_record In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26206 ) Change subject: commands: use send_apdu_checksw() in method read_record ...................................................................... commands: use send_apdu_checksw() in method read_record At the moment the non checking send_apdu() method is used when records are read. Lets use read_record_checksw so that we get an exception in case there is a problem to read the specified record. Change-Id: I9fc411e1b12e8d9fd89b9964209808c0706011bd --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/pySim/commands.py b/pySim/commands.py index cea330e..674e184 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -228,7 +228,7 @@ r = self.select_path(ef) rec_length = self.__record_len(r) pdu = self.cla_byte + 'b2%02x04%02x' % (rec_no, rec_length) - return self._tp.send_apdu(pdu) + return self._tp.send_apdu_checksw(pdu) def update_record(self, ef, rec_no:int, data:str, force_len:bool=False, verify:bool=False, conserve:bool=False): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9fc411e1b12e8d9fd89b9964209808c0706011bd Gerrit-Change-Number: 26206 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:16 +0000 Subject: Change in pysim[master]: pySim-shell: export command: guess number of records when not specified In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26204 ) Change subject: pySim-shell: export command: guess number of records when not specified ...................................................................... pySim-shell: export command: guess number of records when not specified The select response of an UICC will always return the number of records of a file. However, older SIM will not include the number of records in the select response. In those cases, simply guess the number of records by reading until the first invalid record is hit. Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Related: OS#5274 --- M pySim-shell.py 1 file changed, 22 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/pySim-shell.py b/pySim-shell.py index 0519ec4..8e8a1a6 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -517,10 +517,28 @@ result = self._cmd.rs.read_binary() self._cmd.poutput("update_binary " + str(result[0])) elif structure == 'cyclic' or structure == 'linear_fixed': - num_of_rec = fd['num_of_rec'] - for r in range(1, num_of_rec + 1): - result = self._cmd.rs.read_record(r) - self._cmd.poutput("update_record %d %s" % (r, str(result[0]))) + # Use number of records specified in select response + if 'num_of_rec' in fd: + num_of_rec = fd['num_of_rec'] + for r in range(1, num_of_rec + 1): + result = self._cmd.rs.read_record(r) + self._cmd.poutput("update_record %d %s" % (r, str(result[0]))) + # When the select response does not return the number of records, read until we hit the + # first record that cannot be read. + else: + r = 1 + while True: + try: + result = self._cmd.rs.read_record(r) + except SwMatchError as e: + # We are past the last valid record - stop + if e.sw_actual == "9402": + break + # Some other problem occurred + else: + raise e + self._cmd.poutput("update_record %d %s" % (r, str(result[0]))) + r = r + 1 elif structure == 'ber_tlv': tags = self._cmd.rs.retrieve_tags() for t in tags: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87 Gerrit-Change-Number: 26204 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:26 +0000 Subject: Change in pysim[master]: profile: decode_select_response can be a static method In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26276 ) Change subject: profile: decode_select_response can be a static method ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b Gerrit-Change-Number: 26276 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Nov 2021 15:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:31 +0000 Subject: Change in pysim[master]: profile: decode_select_response can be a static method In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26276 ) Change subject: profile: decode_select_response can be a static method ...................................................................... profile: decode_select_response can be a static method The method decode_select_response does not access any property of the object. This means the method can be static. Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b --- M pySim/profile.py M pySim/sysmocom_sja2.py M pySim/ts_102_221.py M pySim/ts_31_102.py M pySim/ts_31_103.py M pySim/ts_51_011.py 6 files changed, 27 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/profile.py b/pySim/profile.py index f068d7c..768064f 100644 --- a/pySim/profile.py +++ b/pySim/profile.py @@ -106,7 +106,8 @@ """ return interpret_sw(self.sw, sw) - def decode_select_response(self, data_hex:str) -> Any: + @staticmethod + def decode_select_response(data_hex:str) -> Any: """Decode the response to a SELECT command. This is the fall-back method which doesn't perform any decoding. It mostly diff --git a/pySim/sysmocom_sja2.py b/pySim/sysmocom_sja2.py index 263999d..6d49572 100644 --- a/pySim/sysmocom_sja2.py +++ b/pySim/sysmocom_sja2.py @@ -154,7 +154,7 @@ self.add_files(files) def decode_select_response(self, resp_hex): - return pySim.ts_102_221.decode_select_response(resp_hex) + return pySim.ts_102_221.CardProfileUICC.decode_select_response(resp_hex) class EF_USIM_SQN(TransparentEF): def __init__(self, fid='af30', name='EF.USIM_SQN'): diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 53cd118..1d10988 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -473,28 +473,6 @@ SC_DO = DataObjectChoice('security_condition', 'Security Condition', members=[Always_DO, Never_DO, SecCondByte_DO(), SecCondByte_DO(0x9e), CRT_DO()]) - -# ETSI TS 102 221 Section 11.1.1.3 -def decode_select_response(resp_hex): - fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) - resp_hex = resp_hex.upper() - # outer layer - fcp_base_tlv = TLV(['62']) - fcp_base = fcp_base_tlv.parse(resp_hex) - # actual FCP - fcp_tlv = TLV(FCP_TLV_MAP) - fcp = fcp_tlv.parse(fcp_base['62']) - # further decode the proprietary information - if fcp['A5']: - prop_tlv = TLV(FCP_Proprietary_TLV_MAP) - prop = prop_tlv.parse(fcp['A5']) - fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop) - fcp['A5'] = tlv_key_replace(FCP_Proprietary_TLV_MAP, fcp['A5']) - # finally make sure we get human-readable keys in the output dict - r = tlv_val_interpret(FCP_interpreter_map, fcp) - return tlv_key_replace(FCP_TLV_MAP, r) - - # TS 102 221 Section 13.1 class EF_DIR(LinFixedEF): def __init__(self, fid='2f00', sfid=0x1e, name='EF.DIR', desc='Application Directory'): @@ -694,8 +672,26 @@ super().__init__(name, desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) - def decode_select_response(self, data_hex:str) -> Any: - return decode_select_response(data_hex) + @staticmethod + def decode_select_response(resp_hex:str) -> Any: + """ETSI TS 102 221 Section 11.1.1.3""" + fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) + resp_hex = resp_hex.upper() + # outer layer + fcp_base_tlv = TLV(['62']) + fcp_base = fcp_base_tlv.parse(resp_hex) + # actual FCP + fcp_tlv = TLV(FCP_TLV_MAP) + fcp = fcp_tlv.parse(fcp_base['62']) + # further decode the proprietary information + if fcp['A5']: + prop_tlv = TLV(FCP_Proprietary_TLV_MAP) + prop = prop_tlv.parse(fcp['A5']) + fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop) + fcp['A5'] = tlv_key_replace(FCP_Proprietary_TLV_MAP, fcp['A5']) + # finally make sure we get human-readable keys in the output dict + r = tlv_val_interpret(FCP_interpreter_map, fcp) + return tlv_key_replace(FCP_TLV_MAP, r) @staticmethod def match_with_card(scc:SimCardCommands) -> bool: diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 14d7ec1..647a4d7 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1067,7 +1067,7 @@ self.add_files(files) def decode_select_response(self, data_hex): - return pySim.ts_102_221.decode_select_response(data_hex) + return pySim.ts_102_221.CardProfileUICC.decode_select_response(data_hex) @with_default_category('Application-Specific Commands') class AddlShellCommands(CommandSet): diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py index 63ef99e..9c7843f 100644 --- a/pySim/ts_31_103.py +++ b/pySim/ts_31_103.py @@ -213,7 +213,7 @@ self.shell_commands += [ADF_USIM.AddlShellCommands()] def decode_select_response(self, data_hex): - return pySim.ts_102_221.decode_select_response(data_hex) + return pySim.ts_102_221.CardProfileUICC.decode_select_response(data_hex) # TS 31.103 Section 7.1 sw_isim = { diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 2d3ad0c..f330460 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -978,7 +978,8 @@ super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) - def decode_select_response(self, resp_hex:str) -> Any: + @staticmethod + def decode_select_response(resp_hex:str) -> Any: resp_bin = h2b(resp_hex) struct_of_file_map = { 0: 'transparent', -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd7aaebcf1ab0099cd40a88b8938604e84d8a88b Gerrit-Change-Number: 26276 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:31 +0000 Subject: Change in pysim[master]: profile: decode_select_response use object instead 'Any' In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26277 ) Change subject: profile: decode_select_response use object instead 'Any' ...................................................................... profile: decode_select_response use object instead 'Any' the return type of decode_select_response is 'Any', lets be more specific and use 'object' Change-Id: Ic5c7ace234bc94ab1381d87e091369ade8011cab --- M pySim/filesystem.py M pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 4 files changed, 5 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6b20db5..4c3308c 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -34,7 +34,7 @@ from cmd2 import CommandSet, with_default_category, with_argparser import argparse -from typing import cast, Optional, Iterable, List, Any, Dict, Tuple +from typing import cast, Optional, Iterable, List, Dict, Tuple from smartcard.util import toBytes @@ -354,7 +354,7 @@ sels.update({x.name: x for x in self.applications.values() if x.name}) return sels - def decode_select_response(self, data_hex:str) -> Any: + def decode_select_response(self, data_hex:str) -> object: """Decode the response to a SELECT command. This is the fall-back method which automatically defers to the standard decoding diff --git a/pySim/profile.py b/pySim/profile.py index 768064f..8f3e986 100644 --- a/pySim/profile.py +++ b/pySim/profile.py @@ -24,7 +24,6 @@ from pySim.commands import SimCardCommands from pySim.filesystem import CardApplication, interpret_sw from pySim.utils import all_subclasses -from typing import Any import abc import operator @@ -107,7 +106,7 @@ return interpret_sw(self.sw, sw) @staticmethod - def decode_select_response(data_hex:str) -> Any: + def decode_select_response(data_hex:str) -> object: """Decode the response to a SELECT command. This is the fall-back method which doesn't perform any decoding. It mostly diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 1d10988..adb40c1 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -673,7 +673,7 @@ super().__init__(name, desc='ETSI TS 102 221', cla="00", sel_ctrl="0004", files_in_mf=files, sw=sw) @staticmethod - def decode_select_response(resp_hex:str) -> Any: + def decode_select_response(resp_hex:str) -> object: """ETSI TS 102 221 Section 11.1.1.3""" fixup_fcp_proprietary_tlv_map(FCP_Proprietary_TLV_MAP) resp_hex = resp_hex.upper() diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index f330460..847ed98 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -979,7 +979,7 @@ super().__init__('SIM', desc='GSM SIM Card', cla="a0", sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM()], sw=sw) @staticmethod - def decode_select_response(resp_hex:str) -> Any: + def decode_select_response(resp_hex:str) -> object: resp_bin = h2b(resp_hex) struct_of_file_map = { 0: 'transparent', -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic5c7ace234bc94ab1381d87e091369ade8011cab Gerrit-Change-Number: 26277 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:45:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:45:45 +0000 Subject: Change in pysim[master]: cards: make _get_aid case insensitive In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26330 ) Change subject: cards: make _get_aid case insensitive ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9944d9180bf1ba35f44f0be2b05bdb725b5b8da9 Gerrit-Change-Number: 26330 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Nov 2021 15:45:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 15:47:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Nov 2021 15:47:07 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py at 48 PS5, Line 48: def select_app(adf:str): I think 'card' should be passed as an argument to the function and not rely on a global variable -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 22 Nov 2021 15:47:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 17:37:00 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 22 Nov 2021 17:37:00 +0000 Subject: Change in pysim[master]: cards: make _get_aid case insensitive In-Reply-To: References: Message-ID: dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26330 ) Change subject: cards: make _get_aid case insensitive ...................................................................... cards: make _get_aid case insensitive There is no need to be case sensitive when the xSIM application name is given as AID. Change-Id: I9944d9180bf1ba35f44f0be2b05bdb725b5b8da9 --- M pySim/cards.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/cards.py b/pySim/cards.py index 2319a56..a822161 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -284,6 +284,7 @@ # First (known) halves of the U/ISIM AID aid_map["usim"] = "a0000000871002" aid_map["isim"] = "a0000000871004" + adf = adf.lower() if adf in aid_map: return aid_map[adf] return None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9944d9180bf1ba35f44f0be2b05bdb725b5b8da9 Gerrit-Change-Number: 26330 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 17:43:58 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 22 Nov 2021 17:43:58 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Nov 2021 17:43:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 22 19:39:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Nov 2021 19:39:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 ) Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... hnb: Introduce HNB_Tests testsuite A new Iuh CodecPort + Emulation is introduced to (de)mux RANAP and RUA in the same SCTP socket. The Iuh_CodecPort.ttcn file has currently a hack to be able to test HNBAP, since titan seem to be reporting sinfo_ppid=0 when in fact it received sinfo_ppid=20 (HNBAP). A couple tests are added to validate HNBAP HNBRegister Request + Accept or Reject. In current osmo-hnodeb state, both tests pass if run separately, but fail if run sequentially since osmo-hnodeb still doesn't re-connect properly after first test finishes and connection is dropped. Related: SYS#5516 Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 --- M Makefile A hnodeb/HNBGW_ConnectionHandler.ttcn A hnodeb/HNB_Tests.cfg A hnodeb/HNB_Tests.default A hnodeb/HNB_Tests.ttcn A hnodeb/README.md A hnodeb/README.txt A hnodeb/expected-results.xml A hnodeb/gen_links.sh A hnodeb/osmo-hnodeb.cfg A hnodeb/regen_makefile.sh A library/Iuh_CodecPort.ttcn A library/Iuh_CodecPort_CtrlFunct.ttcn A library/Iuh_CodecPort_CtrlFunctDef.cc A library/Iuh_Emulation.ttcn A library/Iuh_Types.ttcn A library/hnbap/HNBAP_Templates.ttcn A library/rua/RUA_Templates.ttcn 18 files changed, 1,237 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26336/1 diff --git a/Makefile b/Makefile index 0567081..f05ab48 100644 --- a/Makefile +++ b/Makefile @@ -24,6 +24,7 @@ gbproxy \ ggsn_tests \ hlr \ + hnodeb \ mgw \ mme \ msc \ diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn new file mode 100644 index 0000000..071e3e8 --- /dev/null +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -0,0 +1,112 @@ +module HNBGW_ConnectionHandler { + +/* HNBGW Connection Handler of HNB_Tests in TTCN-3 + * (C) 2021 by sysmocom - s.m.f.c. GmbH + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +import from Misc_Helpers all; +import from General_Types all; +import from Osmocom_Types all; +import from IPL4asp_Types all; +import from Native_Functions all; + +import from SDP_Types all; + +import from StatsD_Checker all; + +import from TELNETasp_PortType all; +import from Osmocom_VTY_Functions all; + +import from HNBAP_Templates all; + +import from Iuh_Emulation all; + +/* this component represents a single Iuh connection at the HNBGW. */ +type component HNBGW_ConnHdlr extends StatsD_ConnHdlr { + port TELNETasp_PT HNBVTY; + port HNBAP_PT HNBAP; + port RUA_PT RUA; + var TestHdlrParams g_pars; + + var boolean g_vty_initialized := false; +} + +function f_HNBGW_ConnHdlr_init_vty() runs on HNBGW_ConnHdlr { + if (not g_vty_initialized) { + map(self:HNBVTY, system:HNBVTY); + f_vty_set_prompts(HNBVTY); + f_vty_transceive(HNBVTY, "enable"); + g_vty_initialized := true; + } +} + +/* initialize all parameters */ +function f_HNBGW_ConnHdlr_init(TestHdlrParams pars) runs on HNBGW_ConnHdlr { + var integer i := 0; + var Iuh_Emulation_CT vc_Iuh; + + g_pars := valueof(pars); + vc_Iuh := Iuh_Emulation_CT.create("HNBGW" & int2str(i)); + connect(self:HNBAP, vc_Iuh:HNBAP); + connect(self:RUA, vc_Iuh:RUA); + + var Iuh_conn_parameters iuh_pars; + iuh_pars.remote_ip := g_pars.hnodeb_addr; + iuh_pars.remote_sctp_port := -1; + iuh_pars.local_ip := g_pars.hnbgw_addr; + iuh_pars.local_sctp_port := g_pars.hnbgw_port; + vc_Iuh.start(Iuh_Emulation.main(iuh_pars, "Iuh" & int2str(i))); + + f_HNBGW_ConnHdlr_init_vty(); +} + +type record TestHdlrParams { + charstring hnbgw_addr, + charstring hnodeb_addr, + integer hnbgw_port, + uint16_t rnc_id, + charstring hNB_Identity_Info, + OCT3 plmnid, + uint32_t cell_identity, + uint16_t lac, + uint8_t rac, + uint8_t sac +}; + +/* Note: Do not use valueof() to get a value of this template, use + * f_gen_test_hdlr_pars() instead in order to get a configuration. */ +template (value) TestHdlrParams t_def_TestHdlrPars := { + hnbgw_addr := "127.0.0.1", + hnodeb_addr := "127.0.0.1", + hnbgw_port := 29169, + rnc_id := 23, + hNB_Identity_Info := "OsmoHNodeB", + plmnid := '00F110'O, + cell_identity := 1, + lac := 2, + rac := 3, + sac := 4 +} + + +function f_handle_hnbap_hnb_register_req() +runs on HNBGW_ConnHdlr { + HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), + g_pars.plmnid, + int2bit(g_pars.cell_identity, 28), + int2oct(g_pars.lac, 2), + int2oct(g_pars.rac, 1), + int2oct(g_pars.sac, 2) + )); + HNBAP.send(ts_HNBAP_HNBRegisterAccept(g_pars.rnc_id)); +} + + + +} diff --git a/hnodeb/HNB_Tests.cfg b/hnodeb/HNB_Tests.cfg new file mode 100644 index 0000000..38d9cc7 --- /dev/null +++ b/hnodeb/HNB_Tests.cfg @@ -0,0 +1,18 @@ +[ORDERED_INCLUDE] +# Common configuration, shared between test suites +"../Common.cfg" +# testsuite specific configuration, not expected to change +"./HNB_Tests.default" + +# Local configuration below + +[LOGGING] + +[TESTPORT_PARAMETERS] + +[MODULE_PARAMETERS] + +[MAIN_CONTROLLER] + +[EXECUTE] +HNB_Tests.control diff --git a/hnodeb/HNB_Tests.default b/hnodeb/HNB_Tests.default new file mode 100644 index 0000000..a06dcc6 --- /dev/null +++ b/hnodeb/HNB_Tests.default @@ -0,0 +1,27 @@ +[LOGGING] +mtc.FileMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING | DEBUG_ENCDEC; + +[TESTPORT_PARAMETERS] +*.HNBVTY.CTRL_MODE := "client" +*.HNBVTY.CTRL_HOSTNAME := "127.0.0.1" +*.HNBVTY.CTRL_PORTNUM := "4273" +*.HNBVTY.CTRL_LOGIN_SKIPPED := "yes" +*.HNBVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.HNBVTY.CTRL_READMODE := "buffered" +*.HNBVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.HNBVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.HNBVTY.PROMPT1 := "OsmoHNodeB> " +*.STATSVTY.CTRL_MODE := "client" +*.STATSVTY.CTRL_HOSTNAME := "127.0.0.1" +*.STATSVTY.CTRL_PORTNUM := "4274" +*.STATSVTY.CTRL_LOGIN_SKIPPED := "yes" +*.STATSVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.STATSVTY.CTRL_READMODE := "buffered" +*.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.STATSVTY.PROMPT1 := "OsmoHNodeB> " + +[MODULE_PARAMETERS] +Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoHNodeB"; + +[EXECUTE] diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn new file mode 100644 index 0000000..0908a8f --- /dev/null +++ b/hnodeb/HNB_Tests.ttcn @@ -0,0 +1,216 @@ +module HNB_Tests { + +/* Integration Tests for OsmoHNodeB + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + * + * This test suite tests OsmoHNodB while emulating both multiple UE as + * well as the HNBGW. See README for more details. + * + * There are test cases that run in so-called 'handler mode' and test cases + * that run directly on top of the BSSAP and RSL CodecPorts. The "handler mode" + * tests abstract the multiplexing/demultiplexing of multiple SCCP connections + * and/or RSL channels and are hence suitable for higher-level test cases, while + * the "raw" tests directly on top of the CodecPorts are more suitable for lower- + * level testing. + */ + +import from Misc_Helpers all; +import from General_Types all; +import from Osmocom_Types all; +import from IPL4asp_Types all; + +import from Osmocom_CTRL_Functions all; +import from Osmocom_CTRL_Types all; +import from Osmocom_CTRL_Adapter all; + +import from StatsD_Types all; +import from StatsD_CodecPort all; +import from StatsD_CodecPort_CtrlFunct all; +import from StatsD_Checker all; + +import from Osmocom_VTY_Functions all; +import from TELNETasp_PortType all; + +import from HNBAP_Templates all; + +import from HNBGW_ConnectionHandler all; +import from Iuh_Emulation all; + +modulepar { + /* IP address at which the HNodeB can be reached */ + charstring mp_hnodeb_ip := "127.0.0.1"; + + /* IP address at which the test binds */ + charstring mp_hnbgw_iuh_ip := "127.0.0.1"; + integer mp_hnbgw_iuh_port := 29169; +} + +type component test_CT extends CTRL_Adapter_CT { + port TELNETasp_PT HNBVTY; + + /* global test case guard timer (actual timeout value is set in f_init()) */ + timer T_guard := 30.0; +} + +/* global altstep for global guard timer; */ +altstep as_Tguard() runs on test_CT { + [] T_guard.timeout { + setverdict(fail, "Timeout of T_guard"); + mtc.stop; + } +} + +friend function f_logp(TELNETasp_PT pt, charstring log_msg) +{ + // log on TTCN3 log output + log(log_msg); + // log in stderr log + f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); +} + +function f_init_vty(charstring id := "foo") runs on test_CT { + if (HNBVTY.checkstate("Mapped")) { + /* skip initialization if already executed once */ + return; + } + map(self:HNBVTY, system:HNBVTY); + f_vty_set_prompts(HNBVTY); + f_vty_transceive(HNBVTY, "enable"); +} +/* global initialization function */ +function f_init(float guard_timeout := 30.0) runs on test_CT { + var integer bssap_idx; + + T_guard.start(guard_timeout); + activate(as_Tguard()); + + f_init_vty("VirtHNBGW"); + + /* TODO: Wait for Iuh connection to be established */ +} + +friend function f_shutdown_helper() runs on test_CT { + all component.stop; + setverdict(pass); + mtc.stop; +} + +friend function f_gen_test_hdlr_pars() return TestHdlrParams { + + var TestHdlrParams pars := valueof(t_def_TestHdlrPars); + pars.hnodeb_addr := mp_hnodeb_ip; + pars.hnbgw_addr := mp_hnbgw_iuh_ip; + pars.hnbgw_port := mp_hnbgw_iuh_port; + return pars; +} + +type function void_fn(charstring id) runs on HNBGW_ConnHdlr; + +/* helper function to create and connect a HNBGW_ConnHdlr component */ +private function f_connect_handler(inout HNBGW_ConnHdlr vc_conn, integer bssap_idx := 0) runs on test_CT { + /*connect(vc_conn:RAN, g_bssap[bssap_idx].vc_RAN:PROC); + connect(vc_conn:MGCP_PROC, vc_MGCP:MGCP_PROC); + connect(vc_conn:RSL, bts[0].rsl.vc_RSL:CLIENT_PT); + connect(vc_conn:RSL_PROC, bts[0].rsl.vc_RSL:RSL_PROC); + if (isvalue(bts[1])) { + connect(vc_conn:RSL1, bts[1].rsl.vc_RSL:CLIENT_PT); + connect(vc_conn:RSL1_PROC, bts[1].rsl.vc_RSL:RSL_PROC); + } + if (isvalue(bts[2])) { + connect(vc_conn:RSL2, bts[2].rsl.vc_RSL:CLIENT_PT); + connect(vc_conn:RSL2_PROC, bts[2].rsl.vc_RSL:RSL_PROC); + } + connect(vc_conn:BSSAP, g_bssap[bssap_idx].vc_RAN:CLIENT); + if (mp_enable_lcs_tests) { + connect(vc_conn:BSSAP_LE, g_bssap_le.vc_BSSAP_LE:CLIENT); + connect(vc_conn:BSSAP_LE_PROC, g_bssap_le.vc_BSSAP_LE:PROC); + } + connect(vc_conn:MGCP, vc_MGCP:MGCP_CLIENT); + connect(vc_conn:MGCP_MULTI, vc_MGCP:MGCP_CLIENT_MULTI); + connect(vc_conn:STATSD_PROC, vc_STATSD:STATSD_PROC);*/ +} + +function f_start_handler_create(TestHdlrParams pars) +runs on test_CT return HNBGW_ConnHdlr { + var charstring id := testcasename(); + var HNBGW_ConnHdlr vc_conn; + vc_conn := HNBGW_ConnHdlr.create(id); + f_connect_handler(vc_conn); + return vc_conn; +} + +function f_start_handler_run(HNBGW_ConnHdlr vc_conn, void_fn fn, TestHdlrParams pars) +runs on test_CT return HNBGW_ConnHdlr { + var charstring id := testcasename(); + /* Emit a marker to appear in the SUT's own logging output */ + f_logp(HNBVTY, id & "() start"); + vc_conn.start(f_handler_init(fn, id, pars)); + return vc_conn; +} + +function f_start_handler(void_fn fn, template (omit) TestHdlrParams pars_tmpl := omit) +runs on test_CT return HNBGW_ConnHdlr { + var TestHdlrParams pars; + if (isvalue(pars)) { + pars := valueof(pars_tmpl); + } else { + pars := valueof(f_gen_test_hdlr_pars()); + } + return f_start_handler_run(f_start_handler_create(pars), fn, pars); +} + +/* first function inside ConnHdlr component; sets g_pars + starts function */ +private function f_handler_init(void_fn fn, charstring id, TestHdlrParams pars) +runs on HNBGW_ConnHdlr { + f_HNBGW_ConnHdlr_init(pars); + HNBAP.receive(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* Wait for HNB to connect to us */ + fn.apply(id); +} + +private function f_tc_hnb_register_request(charstring id) runs on HNBGW_ConnHdlr { + f_handle_hnbap_hnb_register_req(); + f_sleep(1.0); +} +testcase TC_hnb_register_request_accept() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_hnb_register_request)); + vc_conn.done; + f_logp(HNBVTY, "done"); + f_shutdown_helper(); +} + +private function f_tc_hnb_register_reject(charstring id) runs on HNBGW_ConnHdlr { + HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), + g_pars.plmnid, + int2bit(g_pars.cell_identity, 28), + int2oct(g_pars.lac, 2), + int2oct(g_pars.rac, 1), + int2oct(g_pars.sac, 2) + )); + HNBAP.send(ts_HNBAP_HNBRegisterReject(ts_HnbapCause(overload))); + f_sleep(1.0); +} +testcase TC_hnb_register_request_reject() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_hnb_register_reject)); + vc_conn.done; + f_logp(HNBVTY, "done"); + f_shutdown_helper(); +} + +control { + execute( TC_hnb_register_request_accept() ); + execute( TC_hnb_register_request_reject() ); +} + +} diff --git a/hnodeb/README.md b/hnodeb/README.md new file mode 100644 index 0000000..3b3fa9f --- /dev/null +++ b/hnodeb/README.md @@ -0,0 +1,30 @@ +# HNB_Tests.ttcn + +* external interfaces + * Iuh side (emulates HNBGW-side) + * SCTP/HNBAP + * SCTP/RUA/RANAP + * RTP side: emulates MGW + * GTP-U side: emulates GGSN + * UE side + * VTY + * CTRL + * StatsD + +{% dot hnb_tests.svg +digraph G { + graph [label="HNB_Tests", labelloc=t, fontsize=30]; + rankdir=LR; + { rank=same; ATS; HNB; }; + HNB [label="IUT\nosmo-bsc",shape="box"]; + ATS [label="ATS\nHNB_Tests.ttcn"]; + + HNB <- ATS [label="Uu (or some intermediate lower layer)"]; + HNB -> ATS [label="Iuh"]; + HNB -> ATS [label="RTP"]; + HNB -> ATS [label="GTP-U"]; + HNB <- ATS [label="CTRL"]; + HNB <- ATS [label="VTY"]; + HNB -> ATS [label="StatsD"]; +} +%} diff --git a/hnodeb/README.txt b/hnodeb/README.txt new file mode 100644 index 0000000..1cf81ee --- /dev/null +++ b/hnodeb/README.txt @@ -0,0 +1,32 @@ +Integration Tests for OsmoHnodeB +-------------------------------- + +This test suite tests OsmoHNodeB while emulating both multiple UE as +well as the HNBGW. + +The included jenkins.sh script, together with the Dockerfiles from +http://git.osmocom.org/docker-playground/ can be used to run both the +osmo-hnodeb-under-test as well as the extenal entities and the tester. + + +Further Test Ideas +------------------ + +This is a random list of things about things possible to test. +Asterisks '*' are TODO, while 'x' means already implemented. + += exhaustion of resources + += paging + += assignment + += hand-over + += erroneous channel release + += misc + += counters + += VTY based/corresponding tests diff --git a/hnodeb/expected-results.xml b/hnodeb/expected-results.xml new file mode 100644 index 0000000..39cea9f --- /dev/null +++ b/hnodeb/expected-results.xml @@ -0,0 +1,4 @@ + + + + diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh new file mode 100755 index 0000000..ba946e8 --- /dev/null +++ b/hnodeb/gen_links.sh @@ -0,0 +1,60 @@ +#!/bin/bash + +BASEDIR=../deps + +. ../gen_links.sh.inc + +#DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src +#FILES="UD_PT.cc UD_PT.hh UD_PortType.ttcn UD_Types.ttcn" +#gen_links $DIR $FILES + +DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src +FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn TCCConversion.cc TCCInterface.cc TCCInterface_ip.h" +FILES+=" TCCEncoding_Functions.ttcn TCCEncoding.cc " # GSM 7-bit coding +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src +FILES="Socket_API_Definitions.ttcn" +gen_links $DIR $FILES + +# Required by MGCP and IPA +DIR=$BASEDIR/titan.TestPorts.IPL4asp/src +FILES="IPL4asp_Functions.ttcn IPL4asp_PT.cc IPL4asp_PT.hh IPL4asp_PortType.ttcn IPL4asp_Types.ttcn IPL4asp_discovery.cc IPL4asp_protocol_L234.hh" +gen_links $DIR $FILES + +# required by M3UA_Emulation +DIR=$BASEDIR/titan.TestPorts.SCTPasp/src +FILES="SCTPasp_PT.cc SCTPasp_PT.hh SCTPasp_PortType.ttcn SCTPasp_Types.ttcn" +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.ProtocolModules.SDP/src +FILES="SDP_EncDec.cc SDP_Types.ttcn SDP_parse_.tab.c SDP_parse_.tab.h SDP_parse_parser.h SDP_parser.l +SDP_parser.y lex.SDP_parse_.c" +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.ProtocolModules.RTP/src +FILES="RTP_EncDec.cc RTP_Types.ttcn" +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.TestPorts.TELNETasp/src +FILES="TELNETasp_PT.cc TELNETasp_PT.hh TELNETasp_PortType.ttcn" +gen_links $DIR $FILES + +DIR=../library/hnbap +FILES="HNBAP_CommonDataTypes.asn HNBAP_Constants.asn HNBAP_Containers.asn HNBAP_IEs.asn HNBAP_PDU_Contents.asn HNBAP_PDU_Descriptions.asn " +FILES+="HNBAP_EncDec.cc HNBAP_Types.ttcn HNBAP_Templates.ttcn " +gen_links $DIR $FILES + +DIR=../library/rua +FILES="RUA_CommonDataTypes.asn RUA_Constants.asn RUA_Containers.asn RUA_IEs.asn RUA_PDU_Contents.asn RUA_PDU_Descriptions.asn " +FILES+="RUA_EncDec.cc RUA_Types.ttcn RUA_Templates.ttcn " +gen_links $DIR $FILES + +DIR=../library +FILES="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " +FILES+="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn " +FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " + +gen_links $DIR $FILES + +ignore_pp_results diff --git a/hnodeb/osmo-hnodeb.cfg b/hnodeb/osmo-hnodeb.cfg new file mode 100644 index 0000000..3ccd4b4 --- /dev/null +++ b/hnodeb/osmo-hnodeb.cfg @@ -0,0 +1,19 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category-hex 0 + logging print category 1 + logging print extended-timestamp 1 + logging print file basename + logging level set-all debug +line vty + no login +! +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 127.0.0.1 + remote-ip 127.0.0.1 diff --git a/hnodeb/regen_makefile.sh b/hnodeb/regen_makefile.sh new file mode 100755 index 0000000..9ebfaf2 --- /dev/null +++ b/hnodeb/regen_makefile.sh @@ -0,0 +1,35 @@ +#!/bin/sh + +NAME=HNB_Tests + +FILES=" + *.asn + *.c + *.ttcn + *.ttcnpp + IPA_CodecPort_CtrlFunctDef.cc + IPL4asp_PT.cc + IPL4asp_discovery.cc + IuUP_EncDec.cc + Iuh_CodecPort_CtrlFunctDef.cc + Native_FunctionDefs.cc + RTP_CodecPort_CtrlFunctDef.cc + RTP_EncDec.cc + SCTPasp_PT.cc + SDP_EncDec.cc + StatsD_CodecPort_CtrlFunctdef.cc + TCCConversion.cc + TCCEncoding.cc + TCCInterface.cc + TELNETasp_PT.cc + HNBAP_EncDec.cc + RUA_EncDec.cc +" + +export CPPFLAGS_TTCN3=" + -DIPA_EMULATION_CTRL +" + +../regen-makefile.sh -e $NAME $FILES + +sed -i -e 's/^LINUX_LIBS = -lxml2 -lsctp/LINUX_LIBS = -lxml2 -lsctp -lfftranscode/' Makefile diff --git a/library/Iuh_CodecPort.ttcn b/library/Iuh_CodecPort.ttcn new file mode 100644 index 0000000..1f9ddaa --- /dev/null +++ b/library/Iuh_CodecPort.ttcn @@ -0,0 +1,161 @@ +module Iuh_CodecPort { + +/* Simple Iuh Codec Port, translating between raw SCTP primitives with + * octetstring payload towards the IPL4asp provider, and Iuh primitives + * which carry the decoded Iuh data types as payload. + * + * (C) 2021 by sysmocom s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + + import from IPL4asp_PortType all; + import from IPL4asp_Types all; + import from HNBAP_PDU_Descriptions all; + import from HNBAP_Types all; + import from RUA_PDU_Descriptions all; + import from RUA_Types all; + import from Iuh_Types all; + + type record Iuh_RecvFrom { + ConnectionId connId, + HostName remName, + PortNumber remPort, + HostName locName, + PortNumber locPort, + Iuh_PDU msg + }; + + template Iuh_RecvFrom t_Iuh_RecvFrom(template Iuh_PDU msg) := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := msg + } + + template Iuh_RecvFrom t_Iuh_RecvFrom_HNBAP(template HNBAP_PDU hnbap_msg := ?) := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := { + pdu_type := IUH_MSG_TYPE_HNBAP, + u := { + hnbap := hnbap_msg + } + } + } + + template Iuh_RecvFrom t_Iuh_RecvFrom_RUA(template RUA_PDU rua_msg := ?) := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := { + pdu_type := IUH_MSG_TYPE_RUA, + u := { + rua := rua_msg + } + } + } + + type record Iuh_Send { + ConnectionId connId, + Iuh_PDU msg + }; + + template Iuh_Send t_Iuh_Send_HNBAP(template ConnectionId connId, template HNBAP_PDU hnbap_msg) := { + connId := connId, + msg := { + pdu_type := IUH_MSG_TYPE_HNBAP, + u := { + hnbap := hnbap_msg + } + } + } + + template Iuh_Send t_Iuh_Send_RUA(template ConnectionId connId, template RUA_PDU rua_msg) := { + connId := connId, + msg := { + pdu_type := IUH_MSG_TYPE_RUA, + u := { + rua := rua_msg + } + } + } + + private function IPL4_to_Iuh_RecvFrom(in ASP_RecvFrom pin, out Iuh_RecvFrom pout) { + pout.connId := pin.connId; + pout.remName := pin.remName; + pout.remPort := pin.remPort; + pout.locName := pin.locName; + pout.locPort := pin.locPort; + select (pin.proto.sctp.sinfo_ppid) { + case (19) { + pout.msg.pdu_type := IUH_MSG_TYPE_RUA; + pout.msg.u.rua := dec_RUA_PDU(pin.msg); + } + case (20) { + pout.msg.pdu_type := IUH_MSG_TYPE_HNBAP; + pout.msg.u.hnbap := dec_HNBAP_PDU(pin.msg); + } + case (0) { + /* FIXME: lower layers report sinfo_ppid=0: */ + pout.msg.pdu_type := IUH_MSG_TYPE_HNBAP; + pout.msg.u.hnbap := dec_HNBAP_PDU(pin.msg); + } + case else { + //pout.msg.pdu_type := IUH_MSG_TYPE_OTHER; + //pout.msg.u.payload := pin.msg; + } + } + } with { extension "prototype(fast)" }; + + private function Iuh_to_IPL4_Send(in Iuh_Send pin, out ASP_Send pout) { + var integer sctp_ppid; + select (pin.msg.pdu_type) { + case (IUH_MSG_TYPE_RUA) { + sctp_ppid := 19; + pout.msg := enc_RUA_PDU(pin.msg.u.rua); + } + case (IUH_MSG_TYPE_HNBAP) { + sctp_ppid := 20; + pout.msg := enc_HNBAP_PDU(pin.msg.u.hnbap); + } + case else { /*TODO: abort?*/ + sctp_ppid := 0; + pout.msg := pin.msg.u.payload; + } + } + pout.connId := pin.connId; + pout.proto := { + sctp := { + sinfo_stream := omit, + sinfo_ppid := sctp_ppid, + remSocks := omit, + assocId := omit + } + }; + } with { extension "prototype(fast)" }; + + type port Iuh_CODEC_PT message { + out Iuh_Send; + in Iuh_RecvFrom, + ASP_ConnId_ReadyToRelease, + ASP_Event; + } with { extension "user IPL4asp_PT + out(Iuh_Send -> ASP_Send:function(Iuh_to_IPL4_Send)) + in(ASP_RecvFrom -> Iuh_RecvFrom: function(IPL4_to_Iuh_RecvFrom); + ASP_ConnId_ReadyToRelease -> ASP_ConnId_ReadyToRelease: simple; + ASP_Event -> ASP_Event: simple)" + } +} diff --git a/library/Iuh_CodecPort_CtrlFunct.ttcn b/library/Iuh_CodecPort_CtrlFunct.ttcn new file mode 100644 index 0000000..c0c7003 --- /dev/null +++ b/library/Iuh_CodecPort_CtrlFunct.ttcn @@ -0,0 +1,43 @@ +module Iuh_CodecPort_CtrlFunct { + + import from Iuh_CodecPort all; + import from IPL4asp_Types all; + + external function f_IPL4_listen( + inout Iuh_CODEC_PT portRef, + in HostName locName, + in PortNumber locPort, + in ProtoTuple proto, + in OptionList options := {} + ) return Result; + + external function f_IPL4_connect( + inout Iuh_CODEC_PT portRef, + in HostName remName, + in PortNumber remPort, + in HostName locName, + in PortNumber locPort, + in ConnectionId connId, + in ProtoTuple proto, + in OptionList options := {} + ) return Result; + + external function f_IPL4_close( + inout Iuh_CODEC_PT portRef, + in ConnectionId id, + in ProtoTuple proto := { unspecified := {} } + ) return Result; + + external function f_IPL4_setUserData( + inout Iuh_CODEC_PT portRef, + in ConnectionId id, + in UserData userData + ) return Result; + + external function f_IPL4_getUserData( + inout Iuh_CODEC_PT portRef, + in ConnectionId id, + out UserData userData + ) return Result; + +} diff --git a/library/Iuh_CodecPort_CtrlFunctDef.cc b/library/Iuh_CodecPort_CtrlFunctDef.cc new file mode 100644 index 0000000..2f08dec --- /dev/null +++ b/library/Iuh_CodecPort_CtrlFunctDef.cc @@ -0,0 +1,55 @@ +#include "IPL4asp_PortType.hh" +#include "Iuh_CodecPort.hh" +#include "IPL4asp_PT.hh" + +namespace Iuh__CodecPort__CtrlFunct { + + IPL4asp__Types::Result f__IPL4__listen( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::HostName& locName, + const IPL4asp__Types::PortNumber& locPort, + const IPL4asp__Types::ProtoTuple& proto, + const IPL4asp__Types::OptionList& options) + { + return f__IPL4__PROVIDER__listen(portRef, locName, locPort, proto, options); + } + + IPL4asp__Types::Result f__IPL4__connect( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::HostName& remName, + const IPL4asp__Types::PortNumber& remPort, + const IPL4asp__Types::HostName& locName, + const IPL4asp__Types::PortNumber& locPort, + const IPL4asp__Types::ConnectionId& connId, + const IPL4asp__Types::ProtoTuple& proto, + const IPL4asp__Types::OptionList& options) + { + return f__IPL4__PROVIDER__connect(portRef, remName, remPort, + locName, locPort, connId, proto, options); + } + + IPL4asp__Types::Result f__IPL4__close( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::ConnectionId& connId, + const IPL4asp__Types::ProtoTuple& proto) + { + return f__IPL4__PROVIDER__close(portRef, connId, proto); + } + + IPL4asp__Types::Result f__IPL4__setUserData( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::ConnectionId& connId, + const IPL4asp__Types::UserData& userData) + { + return f__IPL4__PROVIDER__setUserData(portRef, connId, userData); + } + + IPL4asp__Types::Result f__IPL4__getUserData( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::ConnectionId& connId, + IPL4asp__Types::UserData& userData) + { + return f__IPL4__PROVIDER__getUserData(portRef, connId, userData); + } + +} diff --git a/library/Iuh_Emulation.ttcn b/library/Iuh_Emulation.ttcn new file mode 100644 index 0000000..dce8238 --- /dev/null +++ b/library/Iuh_Emulation.ttcn @@ -0,0 +1,213 @@ +module Iuh_Emulation { + +/* Iuh Emulation, runs on top of Iuh_CodecPort. It multiplexes/demultiplexes + * HNBAP and RUA. + * + * The Iuh_Emulation.main() function processes Iuh primitives from the Iuh + * socket via the Iuh_CodecPort, and dispatches them to HNBAP/RUA ports. + * + * (C) 2021 by sysmocom s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +import from Iuh_CodecPort all; +import from Iuh_CodecPort_CtrlFunct all; +import from HNBAP_Types all; +import from HNBAP_Constants all; +import from HNBAP_PDU_Contents all; +import from HNBAP_PDU_Descriptions all; +import from HNBAP_IEs all; +import from HNBAP_Templates all; +import from RUA_Types all; +import from RUA_Constants all; +import from RUA_PDU_Contents all; +import from RUA_PDU_Descriptions all; +import from RUA_IEs all; +import from RUA_Templates all; +import from Iuh_Types all; + +import from General_Types all; +import from Osmocom_Types all; +import from IPL4asp_Types all; +import from DNS_Helpers all; + +type enumerated IUHEM_EventUpDown { + IUHEM_EVENT_DOWN, + IUHEM_EVENT_UP +} + +/* an event indicating us whether or not a connection is physically up or down. */ +type union IUHEM_Event { + IUHEM_EventUpDown up_down +} + +type port HNBAP_PT message { + inout HNBAP_PDU, IUHEM_Event; +} with { extension "internal" }; +type port RUA_PT message { + inout RUA_PDU, IUHEM_Event; +} with { extension "internal" }; + +type component Iuh_Emulation_CT { + /* Port facing to the SCTP SUT */ + port Iuh_CODEC_PT Iuh; + /* Port facing to user upper side stack: */ + port HNBAP_PT HNBAP; + port RUA_PT RUA; + + var Iuh_conn_parameters g_pars; + var charstring g_Iuh_id; + var integer g_self_conn_id := -1; + var IPL4asp_Types.ConnectionId g_last_conn_id := -1; /* server only */ +} + +type record Iuh_conn_parameters { + HostName remote_ip, + PortNumber remote_sctp_port, + HostName local_ip, + PortNumber local_sctp_port +} + +function tr_Iuh_RecvFrom_R(template Iuh_PDU msg) +runs on Iuh_Emulation_CT return template Iuh_RecvFrom { + var template Iuh_RecvFrom mrf := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := msg + } + return mrf; +} + +private template (value) SctpTuple ts_SCTP(template (omit) integer ppid := omit) := { + sinfo_stream := omit, + sinfo_ppid := ppid, + remSocks := omit, + assocId := omit +}; + +private template PortEvent tr_SctpAssocChange := { + sctpEvent := { + sctpAssocChange := ? + } +} +private template PortEvent tr_SctpPeerAddrChange := { + sctpEvent := { + sctpPeerAddrChange := ? + } +} + +private function emu_is_server() runs on Iuh_Emulation_CT return boolean { + return g_pars.remote_sctp_port == -1 +} + +/* Resolve TCP/IP connection identifier depending on server/client mode */ +private function f_iuh_conn_id() runs on Iuh_Emulation_CT +return IPL4asp_Types.ConnectionId { + var IPL4asp_Types.ConnectionId conn_id; + + if (not emu_is_server()) { + conn_id := g_self_conn_id; + } else { + conn_id := g_last_conn_id; + } + + if (conn_id == -1) { /* Just to be sure */ + setverdict(fail, "Connection is not established"); + mtc.stop; + } + + return conn_id; +} + +function main(Iuh_conn_parameters p, charstring id) runs on Iuh_Emulation_CT { + var Result res; + g_pars := p; + g_Iuh_id := id; + + map(self:Iuh, system:Iuh_CODEC_PT); + if (emu_is_server()) { + res := Iuh_CodecPort_CtrlFunct.f_IPL4_listen(Iuh, p.local_ip, p.local_sctp_port, { sctp := valueof(ts_SCTP) }); + } else { + res := Iuh_CodecPort_CtrlFunct.f_IPL4_connect(Iuh, p.remote_ip, p.remote_sctp_port, + p.local_ip, p.local_sctp_port, -1, { sctp := valueof(ts_SCTP) }); + } + if (not ispresent(res.connId)) { + setverdict(fail, "Could not connect Iuh socket, check your configuration"); + mtc.stop; + } + g_self_conn_id := res.connId; + + /* notify user about SCTP establishment */ + if (p.remote_sctp_port != -1) { + HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); + } + + while (true) { + var Iuh_RecvFrom mrf; + var Iuh_PDU msg; + var HNBAP_PDU hnbap_msg; + var RUA_PDU rua_msg; + var integer ai; + var ASP_Event asp_evt; + + alt { + /* HNBAP from client: pass on transparently */ + [] HNBAP.receive(HNBAP_PDU:?) -> value hnbap_msg { + /* Pass message through */ + Iuh.send(t_Iuh_Send_HNBAP(f_iuh_conn_id(), hnbap_msg)); + } + /* RUA from client: pass on transparently */ + [] RUA.receive(RUA_PDU:?) -> value rua_msg { + /* Pass message through */ + Iuh.send(t_Iuh_Send_RUA(f_iuh_conn_id(), rua_msg)); + } + + /* Iuh received from peer (MME) */ + [] Iuh.receive(tr_Iuh_RecvFrom_R(?)) -> value mrf { + if (not match(mrf.connId, f_iuh_conn_id())) { + setverdict(fail, "Received message from unexpected conn_id!", mrf); + } + + if (match(mrf, t_Iuh_RecvFrom_HNBAP(?))) { + HNBAP.send(mrf.msg.u.hnbap); + } else if (match(mrf, t_Iuh_RecvFrom_RUA(?))) { + RUA.send(mrf.msg.u.rua); + } else { + /* TODO: special handling, as it contains multiple HNB connection ids */ + setverdict(fail, "UNEXPECTED MESSAGE RECEIVED!", mrf); + mtc.stop; + } + } + [] Iuh.receive(tr_SctpAssocChange) { } + [] Iuh.receive(tr_SctpPeerAddrChange) { } + + /* server only */ + [] Iuh.receive(ASP_Event:{connOpened:=?}) -> value asp_evt { + g_last_conn_id := asp_evt.connOpened.connId; + log("Established a new Iuh connection (conn_id=", g_last_conn_id, ")"); + + HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* TODO: send g_last_conn_id */ + } + + [] Iuh.receive(ASP_Event:{connClosed:=?}) -> value asp_evt { + log("Iuh: Closed"); + g_self_conn_id := -1; + HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_DOWN}); /* TODO: send asp_evt.connClosed.connId */ + if (not emu_is_server()) { + self.stop; + } + } + } + } +} + +} diff --git a/library/Iuh_Types.ttcn b/library/Iuh_Types.ttcn new file mode 100644 index 0000000..29d55d1 --- /dev/null +++ b/library/Iuh_Types.ttcn @@ -0,0 +1,54 @@ +/* Osmocom Iuh Interface Types + * (C) 2021 by sysmocom s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + + /* Iuh Codec Port Types + * + * (C) 2019 by Harald Welte + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module Iuh_Types { + +import from HNBAP_PDU_Descriptions all; +import from HNBAP_Types all; +import from RUA_PDU_Descriptions all; +import from RUA_Types all; + +type enumerated Iuh_MsgType { + IUH_MSG_TYPE_HNBAP ('00'O), + IUH_MSG_TYPE_RUA ('01'O), + IUH_MSG_TYPE_OTHER ('02'O) +}; + +type union Iuh_PDUUnion { + HNBAP_PDU hnbap, + RUA_PDU rua, + octetstring payload +} with { + encode "PER"; + variant "name as uncapitalized"; +} + +type record Iuh_PDU { + Iuh_MsgType pdu_type, + Iuh_PDUUnion u +} with { + variant (u) "CROSSTAG(hnbap, pdu_type = IUH_MSG_TYPE_HNBAP; + rua, pdu_type = IUH_MSG_TYPE_RUA; + payload, OTHERWISE)" +}; + +} with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/hnbap/HNBAP_Templates.ttcn b/library/hnbap/HNBAP_Templates.ttcn new file mode 100644 index 0000000..44704f8 --- /dev/null +++ b/library/hnbap/HNBAP_Templates.ttcn @@ -0,0 +1,135 @@ +/* HNBAP Templates in TTCN-3 + * (C) 2021 Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBAP_Templates { + +import from General_Types all; +import from Osmocom_Types all; + +import from HNBAP_IEs all; +import from HNBAP_CommonDataTypes all; +import from HNBAP_Constants all; +import from HNBAP_Containers all; +import from HNBAP_PDU_Contents all; +import from HNBAP_PDU_Descriptions all; + +/********************************************************************************* + * 3GPP TS 25.469 + *********************************************************************************/ + +template (value) Cause ts_HnbapCause(template (value) CauseRadioNetwork c) := { + radioNetwork := c +} + +/* 9.1.3 HNB REGISTER REQUEST */ +template (present) HNBAP_PDU +tr_HNBAP_HNBRegisterRequest(template (present) octetstring hNB_Identity_Info := ?, + template (present) OCT3 plmnid := ?, + template (present) BIT28 cell_identity := ?, + template (present) OCT2 lac := ?, + template (present) OCT1 rac := ?, + template (present) OCT2 sac := ?) := { + initiatingMessage := { + procedureCode := id_HNBRegister, + criticality := reject, + value_ := { + hNBRegisterRequest := { + protocolIEs := { + { + id := HNBAP_Constants.id_HNB_Identity, + criticality := reject, + value_ := { + hNB_Identity := { + hNB_Identity_Info := hNB_Identity_Info, + iE_Extensions := omit + } + } + }, { + id := 8, + criticality := reject, + value_ := { + hNB_Location_Information := { + macroCoverageInfo := omit, + geographicalCoordinates := omit, + iE_Extensions := omit + } + } + }, { + id := 9, + criticality := reject, + value_ := { pLMNidentity := plmnid } + }, { + id := 11, + criticality := reject, + value_ := { cellIdentity := cell_identity } + }, { + id := 6, + criticality := reject, + value_ := { lAC := lac } + }, { + id := 7, + criticality := reject, + value_ := { rAC := rac } + }, { + id := 10, + criticality := reject, + value_ := { sAC := sac } + } + }, + protocolExtensions := omit + } + } + } +} + + +/* 9.1.4 HNB REGISTER ACCEPT */ +template (value) HNBAP_PDU +ts_HNBAP_HNBRegisterAccept(template (value) uint16_t rnc_id) := { + successfulOutcome := { + procedureCode := id_HNBRegister, + criticality := reject, + value_ := { + hNBRegisterAccept := { + protocolIEs := { + { + id := HNBAP_Constants.id_RNC_ID, + criticality := reject, + value_ := { RNC_ID := rnc_id } + } + }, + protocolExtensions := omit /* TODO: Mux Port Number (optional) 9.2.29 */ + } + } + } +} + +/* 9.1.5 HNB REGISTER REJECT */ +template (value) HNBAP_PDU +ts_HNBAP_HNBRegisterReject(template (value) Cause cause) := { + unsuccessfulOutcome := { + procedureCode := id_HNBRegister, + criticality := reject, + value_ := { + HNBRegisterReject := { + protocolIEs := { + { + id := HNBAP_Constants.id_Cause, + criticality := ignore, + value_ := { Cause := cause } + } + }, + protocolExtensions := omit /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} + +} diff --git a/library/rua/RUA_Templates.ttcn b/library/rua/RUA_Templates.ttcn new file mode 100644 index 0000000..b7387bf --- /dev/null +++ b/library/rua/RUA_Templates.ttcn @@ -0,0 +1,22 @@ +/* RUA Templates in TTCN-3 + * (C) 2021 Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module RUA_Templates { + +import from RUA_IEs all; +import from RUA_CommonDataTypes all; +import from RUA_Constants all; +import from RUA_Containers all; +import from RUA_PDU_Contents all; +import from RUA_PDU_Descriptions all; + + +/* TODO: Add RUA Templates here */ +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 08:25:12 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 23 Nov 2021 08:25:12 +0000 Subject: Change in simtrace2[master]: firmware: remove dfu-dfu default target References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26337 ) Change subject: firmware: remove dfu-dfu default target ...................................................................... firmware: remove dfu-dfu default target It's useless, since blupdate does the same thing, just much faster and easier. Change-Id: I86dddfacea2e35f4d5a7f23ee4b3d12e3f1d35f1 --- M firmware/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/37/26337/1 diff --git a/firmware/Makefile b/firmware/Makefile index f6e8316..c30dc9a 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -49,7 +49,7 @@ # Defines which are the available memory targets for the SAM3S-EK board. ifeq ($(APP), dfu) -MEMORIES ?= flash dfu +MEMORIES ?= flash TRACE_LEVEL ?= 0 else MEMORIES ?= dfu -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I86dddfacea2e35f4d5a7f23ee4b3d12e3f1d35f1 Gerrit-Change-Number: 26337 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Tue Nov 23 08:31:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 23 Nov 2021 08:31:55 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_10/i586 In-Reply-To: References: Message-ID: <619ca708a69f4_53f22af2d2bc65fc3843ae@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_10/i586 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 205s] Processing triggers for tex-common (6.11) ... [ 205s] Running mktexlsr. This may take some time... done. [ 206s] Running updmap-sys. This may take some time... done. [ 206s] Running mktexlsr /var/lib/texmf ... done. [ 206s] Building latex-based formats --byhyphen language.dat. [ 209s] This may take some time... done. [ 209s] Building e-tex based formats --byhyphen language.def. [ 212s] This may take some time... done. [ 212s] [415/435] installing initscripts-2.93-8 [ 213s] invoke-rc.d: could not determine current runlevel [ 213s] invoke-rc.d: policy-rc.d denied execution of start. [ 213s] Processing triggers for man-db (2.8.5-2) ... [ 213s] [416/435] installing python-apt-1.8.4.3 [ 214s] [417/435] installing graphviz-2.40.1-6+deb10u1 [ 214s] Processing triggers for man-db (2.8.5-2) ... [ 215s] [418/435] installing adwaita-icon-theme-3.30.1-1 [ 217s] update-alternatives: using /usr/share/icons/Adwaita/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in auto mode [ 217s] [419/435] installing texlive-bibtex-extra-2018.20190227-2 [ 224s] Processing triggers for man-db (2.8.5-2) ... [ 224s] Processing triggers for tex-common (6.11) ... [ 225s] Running mktexlsr. This may take some time... done. [ 225s] [420/435] installing texlive-latex-recommended-2018.20190227-2 [29027s] qemu-kvm: terminating on signal 15 from pid 3361 () [29027s] ### VM INTERACTION END ### [29027s] No buildstatus set, either the base system is broken (kernel/initrd/udev/glibc/bash/perl) [29027s] or the build host has a kernel or hardware problem... Job seems to be stuck here, killed. (after 28800 seconds of inactivity) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Nov 23 09:20:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Nov 2021 09:20:17 +0000 Subject: Change in docker-playground[master]: make/Makefile: allow specifying optional command for 'run' References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26338 ) Change subject: make/Makefile: allow specifying optional command for 'run' ...................................................................... make/Makefile: allow specifying optional command for 'run' Change-Id: I676c5525effe8f34ae11f7b8ed4da0d8961209bf Related: SYS#5602 --- M make/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/38/26338/1 diff --git a/make/Makefile b/make/Makefile index edb0890..e357803 100644 --- a/make/Makefile +++ b/make/Makefile @@ -161,4 +161,4 @@ run: - docker run $(RUN_ARGS) -it $(IMAGE) + docker run $(RUN_ARGS) -it $(IMAGE) $(RUN_CMD) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I676c5525effe8f34ae11f7b8ed4da0d8961209bf Gerrit-Change-Number: 26338 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 09:20:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Nov 2021 09:20:18 +0000 Subject: Change in docker-playground[master]: open5gs-latest: new Dockerfile for latest open5gs from packages References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26339 ) Change subject: open5gs-latest: new Dockerfile for latest open5gs from packages ...................................................................... open5gs-latest: new Dockerfile for latest open5gs from packages Change-Id: I06b90b84d22ba8d34bed9f84861ff94bdcabe6c3 Related: SYS#5602 --- A open5gs-latest/Dockerfile A open5gs-latest/Makefile 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/39/26339/1 diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile new file mode 100644 index 0000000..ba8c866 --- /dev/null +++ b/open5gs-latest/Dockerfile @@ -0,0 +1,25 @@ +ARG REGISTRY=docker.io +FROM ${REGISTRY}/debian:buster + +MAINTAINER Vadim Yanitskiy + +# TODO: remove me! +ADD sources.list /etc/apt/sources.list + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + ca-certificates \ + gnupg \ + curl +RUN curl https://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/Debian_10/Release.key | apt-key add - +RUN curl https://www.mongodb.org/static/pgp/server-4.2.asc | apt-key add - + +RUN echo "deb http://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/Debian_10/ ./" \ + > /etc/apt/sources.list.d/open5gs.list +RUN echo "deb http://repo.mongodb.org/apt/debian buster/mongodb-org/4.2 main" \ + > /etc/apt/sources.list.d/mongodb-org.list + +RUN apt-get update && \ + apt-get install -y \ + mongodb-org \ + open5gs diff --git a/open5gs-latest/Makefile b/open5gs-latest/Makefile new file mode 100644 index 0000000..95c99bb --- /dev/null +++ b/open5gs-latest/Makefile @@ -0,0 +1,5 @@ +DATA_DIR?=$(shell pwd) +USER_ID?=$(shell id -u) +RUN_ARGS=-v $(DATA_DIR):/data --user $(USER_ID) --network host --rm + +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I06b90b84d22ba8d34bed9f84861ff94bdcabe6c3 Gerrit-Change-Number: 26339 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 09:27:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Nov 2021 09:27:53 +0000 Subject: Change in docker-playground[master]: open5gs-latest: new Dockerfile for latest open5gs from packages In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26339 ) Change subject: open5gs-latest: new Dockerfile for latest open5gs from packages ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I06b90b84d22ba8d34bed9f84861ff94bdcabe6c3 Gerrit-Change-Number: 26339 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Comment-Date: Tue, 23 Nov 2021 09:27:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:35:57 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Nov 2021 10:35:57 +0000 Subject: Change in osmo-gbproxy[master]: WIP STATUS handling In-Reply-To: References: Message-ID: daniel has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25079 ) Change subject: WIP STATUS handling ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I29adb77a94ab759f5d557dada60b4b7df9616f17 Gerrit-Change-Number: 25079 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:39:03 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Nov 2021 10:39:03 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py at 48 PS5, Line 48: def select_app(adf:str): > I think 'card' should be passed as an argument to the function and not rely on a global variable Sorry for the bike shedding, but I agree. Doesn't it make sense to have this as a method on the Card class and then call card.select_app()? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 23 Nov 2021 10:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:41:03 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Nov 2021 10:41:03 +0000 Subject: Change in osmo-bsc[master]: abis_nm: use struct sdp_firmware from libosmocore In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26328 ) Change subject: abis_nm: use struct sdp_firmware from libosmocore ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 Gerrit-Change-Number: 26328 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 23 Nov 2021 10:41:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:45:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:45:28 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py at 48 PS5, Line 48: def select_app(adf:str): > Sorry for the bike shedding, but I agree. [?] method on card class likely makes even more sense, yes. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 23 Nov 2021 10:45:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:46:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:46:26 +0000 Subject: Change in osmo-bsc[master]: abis_nm: use struct sdp_firmware from libosmocore In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26328 ) Change subject: abis_nm: use struct sdp_firmware from libosmocore ...................................................................... abis_nm: use struct sdp_firmware from libosmocore abis_nm locally declares its own struct for the ipaccess firmware header, even though libosmocore defines it as well. Lets use the definition from libosmocore. Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 --- M src/osmo-bsc/abis_nm.c 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index aeb4ba3..1c21bc2 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -51,6 +51,7 @@ #include #include #include +#include #define OM_ALLOC_SIZE 1024 #define OM_HEADROOM_SIZE 128 @@ -1342,13 +1343,6 @@ return abis_nm_sendmsg(sw->bts, msg); } -struct sdp_firmware { - char magic[4]; - char more_magic[4]; - unsigned int header_length; - unsigned int file_length; -} __attribute__ ((packed)); - static int parse_sdp_header(struct abis_nm_sw *sw) { const struct gsm_abis_mo *mo = &sw->bts->mo; @@ -1368,13 +1362,15 @@ } if (firmware_header.more_magic[0] != 0x10 || - firmware_header.more_magic[1] != 0x02 || - firmware_header.more_magic[2] != 0x00 || - firmware_header.more_magic[3] != 0x00) { + firmware_header.more_magic[1] != 0x02) { LOGPMO(mo, DNM, LOGL_ERROR, "The more magic number is wrong.\n"); return -1; } + if (firmware_header.more_more_magic != 0x0000) { + LOGPMO(mo, DNM, LOGL_ERROR, "The more more magic number is wrong.\n"); + return -1; + } if (fstat(sw->fd, &stat) == -1) { LOGPMO(mo, DNM, LOGL_ERROR, "Could not stat the file.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I69cb45fc40bd20ea2533cc8cd6a68363b59cc408 Gerrit-Change-Number: 26328 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:47:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:47:14 +0000 Subject: Change in docker-playground[master]: make/Makefile: allow specifying optional command for 'run' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26338 ) Change subject: make/Makefile: allow specifying optional command for 'run' ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I676c5525effe8f34ae11f7b8ed4da0d8961209bf Gerrit-Change-Number: 26338 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 10:47:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:47:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:47:30 +0000 Subject: Change in docker-playground[master]: open5gs-latest: new Dockerfile for latest open5gs from packages In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26339 ) Change subject: open5gs-latest: new Dockerfile for latest open5gs from packages ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I06b90b84d22ba8d34bed9f84861ff94bdcabe6c3 Gerrit-Change-Number: 26339 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 10:47:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:47:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:47:33 +0000 Subject: Change in docker-playground[master]: make/Makefile: allow specifying optional command for 'run' In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26338 ) Change subject: make/Makefile: allow specifying optional command for 'run' ...................................................................... make/Makefile: allow specifying optional command for 'run' Change-Id: I676c5525effe8f34ae11f7b8ed4da0d8961209bf Related: SYS#5602 --- M make/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/make/Makefile b/make/Makefile index edb0890..e357803 100644 --- a/make/Makefile +++ b/make/Makefile @@ -161,4 +161,4 @@ run: - docker run $(RUN_ARGS) -it $(IMAGE) + docker run $(RUN_ARGS) -it $(IMAGE) $(RUN_CMD) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I676c5525effe8f34ae11f7b8ed4da0d8961209bf Gerrit-Change-Number: 26338 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:47:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:47:33 +0000 Subject: Change in docker-playground[master]: open5gs-latest: new Dockerfile for latest open5gs from packages In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26339 ) Change subject: open5gs-latest: new Dockerfile for latest open5gs from packages ...................................................................... open5gs-latest: new Dockerfile for latest open5gs from packages Change-Id: I06b90b84d22ba8d34bed9f84861ff94bdcabe6c3 Related: SYS#5602 --- A open5gs-latest/Dockerfile A open5gs-latest/Makefile 2 files changed, 30 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile new file mode 100644 index 0000000..ba8c866 --- /dev/null +++ b/open5gs-latest/Dockerfile @@ -0,0 +1,25 @@ +ARG REGISTRY=docker.io +FROM ${REGISTRY}/debian:buster + +MAINTAINER Vadim Yanitskiy + +# TODO: remove me! +ADD sources.list /etc/apt/sources.list + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + ca-certificates \ + gnupg \ + curl +RUN curl https://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/Debian_10/Release.key | apt-key add - +RUN curl https://www.mongodb.org/static/pgp/server-4.2.asc | apt-key add - + +RUN echo "deb http://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/Debian_10/ ./" \ + > /etc/apt/sources.list.d/open5gs.list +RUN echo "deb http://repo.mongodb.org/apt/debian buster/mongodb-org/4.2 main" \ + > /etc/apt/sources.list.d/mongodb-org.list + +RUN apt-get update && \ + apt-get install -y \ + mongodb-org \ + open5gs diff --git a/open5gs-latest/Makefile b/open5gs-latest/Makefile new file mode 100644 index 0000000..95c99bb --- /dev/null +++ b/open5gs-latest/Makefile @@ -0,0 +1,5 @@ +DATA_DIR?=$(shell pwd) +USER_ID?=$(shell id -u) +RUN_ARGS=-v $(DATA_DIR):/data --user $(USER_ID) --network host --rm + +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I06b90b84d22ba8d34bed9f84861ff94bdcabe6c3 Gerrit-Change-Number: 26339 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:47:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:47:45 +0000 Subject: Change in simtrace2[master]: firmware: remove dfu-dfu default target In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26337 ) Change subject: firmware: remove dfu-dfu default target ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I86dddfacea2e35f4d5a7f23ee4b3d12e3f1d35f1 Gerrit-Change-Number: 26337 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 10:47:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:59:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:59:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 ) Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn File library/Iuh_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn at 156 PS1, Line 156: v seems like an unused variable? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn at 159 PS1, Line 159: v likewise, unused variable? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn at 174 PS1, Line 174: MME no MME involved in 3G https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Emulation.ttcn at 194 PS1, Line 194: [] Iuh.receive(ASP_Event:{connOpened:=?}) -> value asp_evt { if those are server-only, it might make sense to use a guard expression to constrain the clause to the server case. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Types.ttcn File library/Iuh_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/1/library/Iuh_Types.ttcn at 45 PS1, Line 45: type record Iuh_PDU { : Iuh_MsgType pdu_type, : Iuh_PDUUnion u : } with { : variant (u) "CROSSTAG(hnbap, pdu_type = IUH_MSG_TYPE_HNBAP; : rua, pdu_type = IUH_MSG_TYPE_RUA; : payload, OTHERWISE)" : }; I'm not quite sure about what you're doing here. In the wire encoding of the 3GPP specifications, do we ever have such a header as you describe here? with a pdu_type octet followed by that union? If not, then the "pdu_type" is useless, as unlike in C, a union in TTCN3 carries implicit knowledge about whihc of the alternatives is selected. Any code wanting to know which of the Iuh_PDUUnion alternatives is used in a given variable can use ischosen(foo.hnbap) or the like. Yes, you can of course add an explicit pdu_type, but I think it is not "native" TTCN3 programming, and it just makes the code more complex without any benefit. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 10:59:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 10:59:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 10:59:19 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Nov 2021 10:59:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 11:04:34 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 23 Nov 2021 11:04:34 +0000 Subject: Change in simtrace2[master]: firmware: increase dfu page size In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26120 ) Change subject: firmware: increase dfu page size ...................................................................... Patch Set 1: ..well that was the idea anyway, but dfu-util limits this to at most 4k. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I5dfdc04070cd9cae3bec2bf28e125876dd39d72c Gerrit-Change-Number: 26120 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 11:04:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 11:47:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 11:47:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 to look at the new patch set (#2). Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... hnb: Introduce HNB_Tests testsuite A new Iuh CodecPort + Emulation is introduced to (de)mux RANAP and RUA in the same SCTP socket. The Iuh_CodecPort.ttcn file has currently a hack to be able to test HNBAP, since titan seem to be reporting sinfo_ppid=0 when in fact it received sinfo_ppid=20 (HNBAP). A couple tests are added to validate HNBAP HNBRegister Request + Accept or Reject. In current osmo-hnodeb state, both tests pass if run separately, but fail if run sequentially since osmo-hnodeb still doesn't re-connect properly after first test finishes and connection is dropped. Related: SYS#5516 Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 --- M Makefile A hnodeb/HNBGW_ConnectionHandler.ttcn A hnodeb/HNB_Tests.cfg A hnodeb/HNB_Tests.default A hnodeb/HNB_Tests.ttcn A hnodeb/README.md A hnodeb/README.txt A hnodeb/expected-results.xml A hnodeb/gen_links.sh A hnodeb/osmo-hnodeb.cfg A hnodeb/regen_makefile.sh A library/Iuh_CodecPort.ttcn A library/Iuh_CodecPort_CtrlFunct.ttcn A library/Iuh_CodecPort_CtrlFunctDef.cc A library/Iuh_Emulation.ttcn A library/Iuh_Types.ttcn A library/hnbap/HNBAP_Templates.ttcn A library/rua/RUA_Templates.ttcn 18 files changed, 1,201 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26336/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 11:52:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 11:52:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 to look at the new patch set (#3). Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... hnb: Introduce HNB_Tests testsuite A new Iuh CodecPort + Emulation is introduced to (de)mux RANAP and RUA in the same SCTP socket. The Iuh_CodecPort.ttcn file has currently a hack to be able to test HNBAP, since titan seem to be reporting sinfo_ppid=0 when in fact it received sinfo_ppid=20 (HNBAP). A couple tests are added to validate HNBAP HNBRegister Request + Accept or Reject. In current osmo-hnodeb state, both tests pass if run separately, but fail if run sequentially since osmo-hnodeb still doesn't re-connect properly after first test finishes and connection is dropped. Related: SYS#5516 Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 --- M Makefile A hnodeb/HNBGW_ConnectionHandler.ttcn A hnodeb/HNB_Tests.cfg A hnodeb/HNB_Tests.default A hnodeb/HNB_Tests.ttcn A hnodeb/README.md A hnodeb/README.txt A hnodeb/expected-results.xml A hnodeb/gen_links.sh A hnodeb/osmo-hnodeb.cfg A hnodeb/regen_makefile.sh A library/Iuh_CodecPort.ttcn A library/Iuh_CodecPort_CtrlFunct.ttcn A library/Iuh_CodecPort_CtrlFunctDef.cc A library/Iuh_Emulation.ttcn A library/Iuh_Types.ttcn A library/hnbap/HNBAP_Templates.ttcn A library/rua/RUA_Templates.ttcn 18 files changed, 1,200 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26336/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 12:50:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 12:50:48 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Introduce sctp.h to provide SCTP related functionalities These value_strings are taken from existing private ones in libosmo-sccp.git osmo_ss7.c, and are moved here in order to be reused by other projects, such as osmo-hnodeb. Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 --- M include/osmocom/netif/Makefile.am A include/osmocom/netif/sctp.h M src/Makefile.am A src/sctp.c 4 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/40/26340/1 diff --git a/include/osmocom/netif/Makefile.am b/include/osmocom/netif/Makefile.am index 39df08a..d9d030b 100644 --- a/include/osmocom/netif/Makefile.am +++ b/include/osmocom/netif/Makefile.am @@ -8,4 +8,8 @@ rtp.h \ stream.h +if ENABLE_LIBSCTP +osmonetif_HEADERS += sctp.h +endif + osmonetifdir = $(includedir)/osmocom/netif diff --git a/include/osmocom/netif/sctp.h b/include/osmocom/netif/sctp.h new file mode 100644 index 0000000..2b2e072 --- /dev/null +++ b/include/osmocom/netif/sctp.h @@ -0,0 +1,13 @@ +#pragma once + +#include + +enum sctp_sac_state; +extern const struct value_string osmo_sctp_assoc_chg_strs[]; +static inline const char *osmo_sctp_assoc_chg_str(enum sctp_sac_state val) +{ return get_value_string(osmo_sctp_assoc_chg_strs, val); } + +enum sctp_sn_type; +extern const struct value_string osmo_sctp_sn_type_strs[]; +static inline const char *osmo_sctp_sn_type_str(enum sctp_sn_type val) +{ return get_value_string(osmo_sctp_sn_type_strs, val); } diff --git a/src/Makefile.am b/src/Makefile.am index 7e71c71..438b58e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -20,3 +20,7 @@ rs232.c \ rtp.c \ stream.c + +if ENABLE_LIBSCTP +libosmonetif_la_SOURCES += sctp.c +endif diff --git a/src/sctp.c b/src/sctp.c new file mode 100644 index 0000000..c24e0f7 --- /dev/null +++ b/src/sctp.c @@ -0,0 +1,28 @@ +#include +#include + +const struct value_string osmo_sctp_assoc_chg_strs[] = { + { SCTP_COMM_UP, "COMM_UP" }, + { SCTP_COMM_LOST, "COMM_LOST" }, + { SCTP_RESTART, "RESTART" }, + { SCTP_SHUTDOWN_COMP, "SHUTDOWN_COMP" }, + { SCTP_CANT_STR_ASSOC, "CANT_STR_ASSOC" }, + { 0, NULL } +}; + +const struct value_string osmo_sctp_sn_type_strs[] = { + { SCTP_ASSOC_CHANGE, "ASSOC_CHANGE" }, + { SCTP_PEER_ADDR_CHANGE, "PEER_ADDR_CHANGE" }, + { SCTP_SHUTDOWN_EVENT, "SHUTDOWN_EVENT" }, + { SCTP_SEND_FAILED, "SEND_FAILED" }, + { SCTP_REMOTE_ERROR, "REMOTE_ERROR" }, + { SCTP_PARTIAL_DELIVERY_EVENT, "PARTIAL_DELIVERY_EVENT" }, + { SCTP_ADAPTATION_INDICATION, "ADAPTATION_INDICATION" }, +#ifdef SCTP_AUTHENTICATION_INDICATION + { SCTP_AUTHENTICATION_INDICATION, "AUTHENTICATION_INDICATION" }, +#endif +#ifdef SCTP_SENDER_DRY_EVENT + { SCTP_SENDER_DRY_EVENT, "SENDER_DRY_EVENT" }, +#endif + { 0, NULL } +}; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 12:59:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 12:59:19 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Patch Set 1: I think the linter doesn't apply here. I'm not really understanding what is wrong there... @osmith? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 23 Nov 2021 12:59:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 13:18:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 13:18:46 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 to look at the new patch set (#2). Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Introduce sctp.h to provide SCTP related functionalities These value_strings are taken from existing private ones in libosmo-sccp.git osmo_ss7.c, and are moved here in order to be reused by other projects, such as osmo-hnodeb. Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 --- M TODO-RELEASE M include/osmocom/netif/Makefile.am A include/osmocom/netif/sctp.h M src/Makefile.am A src/sctp.c 5 files changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/40/26340/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 13:21:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 13:21:20 +0000 Subject: Change in osmo-hnodeb[master]: Move Iuh code to its own module References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 ) Change subject: Move Iuh code to its own module ...................................................................... Move Iuh code to its own module The Iuh code will be further extended next to properly support reconnect, and hnb will also gain proper shutdown support soon. Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/iuh.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 10 files changed, 219 insertions(+), 146 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/41/26341/1 diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 197568c..23adb2a 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,6 +1,7 @@ noinst_HEADERS = \ hnbap.h \ hnodeb.h \ + iuh.h \ nas.h \ ranap.h \ rua.h \ diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 5d6d088..4cc0831 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -36,18 +36,6 @@ }; extern const struct log_info hnb_log_info; -/* 25.467 Section 7.1 */ -#define IUH_DEFAULT_SCTP_PORT 29169 -#define RNA_DEFAULT_SCTP_PORT 25471 - -#define IUH_PPI_RUA 19 -#define IUH_PPI_HNBAP 20 -#define IUH_PPI_SABP 31 -#define IUH_PPI_RNA 42 -#define IUH_PPI_PUA 55 - -#define IUH_MSGB_SIZE 2048 - struct hnb_chan { int is_ps; uint32_t conn_id; @@ -77,11 +65,9 @@ struct hnb_chan *chan; } cs; }; + struct hnb *hnb_alloc(void *tall_ctx); void hnb_free(struct hnb *hnb); -int hnb_connect(struct hnb *hnb); - -int hnb_iuh_send(struct hnb *hnb, struct msgb *msg); extern void *tall_hnb_ctx; extern struct hnb *g_hnb; diff --git a/include/osmocom/hnodeb/iuh.h b/include/osmocom/hnodeb/iuh.h new file mode 100644 index 0000000..81ce1de --- /dev/null +++ b/include/osmocom/hnodeb/iuh.h @@ -0,0 +1,41 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +/* 25.467 Section 7.1 */ +#define IUH_DEFAULT_SCTP_PORT 29169 +#define RNA_DEFAULT_SCTP_PORT 25471 + +#define IUH_PPI_RUA 19 +#define IUH_PPI_HNBAP 20 +#define IUH_PPI_SABP 31 +#define IUH_PPI_RNA 42 +#define IUH_PPI_PUA 55 + +#define IUH_MSGB_SIZE 2048 + +struct hnb; + +void hnb_iuh_alloc(struct hnb *hnb); +void hnb_iuh_free(struct hnb *hnb); +int hnb_iuh_connect(struct hnb *hnb); +int hnb_iuh_send(struct hnb *hnb, struct msgb *msg); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 139b6b0..88f2571 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -33,6 +33,7 @@ debug.c \ hnbap.c \ hnb.c \ + iuh.c \ nas.c \ ranap.c \ rua.c \ diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 420095d..3344cfb 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -20,99 +20,17 @@ #include "config.h" -#include - -#include -#include -#include -#include -#include - #include #include #include -#include -#include #include +#include -static int hnb_iuh_read_cb(struct osmo_stream_cli *conn) -{ - struct osmo_fd *fd = osmo_stream_cli_get_ofd(conn); - struct hnb *hnb = osmo_stream_cli_get_data(conn); - struct sctp_sndrcvinfo sinfo; - struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); - int flags = 0; - int rc; - - if (!msg) - return -ENOMEM; - - rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), - NULL, NULL, &sinfo, &flags); - if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); - /* FIXME: clean up after disappeared HNB */ - osmo_stream_cli_close(conn); - goto free_ret; - } else if (rc == 0) { - LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); - osmo_stream_cli_close(conn); - rc = -1; - goto free_ret; - } else { - msgb_put(msg, rc); - } - - if (flags & MSG_NOTIFICATION) { - LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); - rc = 0; - goto free_ret; - } - - sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); - - switch (sinfo.sinfo_ppid) { - case IUH_PPI_HNBAP: - LOGP(DHNBAP, LOGL_INFO, "HNBAP message received\n"); - rc = hnb_hnbap_rx(hnb, msg); - break; - case IUH_PPI_RUA: - LOGP(DRUA, LOGL_INFO, "RUA message received\n"); - rc = hnb_rua_rx(hnb, msg); - break; - case IUH_PPI_SABP: - case IUH_PPI_RNA: - case IUH_PPI_PUA: - LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", - sinfo.sinfo_ppid); - rc = 0; - break; - default: - LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", - sinfo.sinfo_ppid); - rc = 0; - break; - } - -free_ret: - msgb_free(msg); - return rc; -} - -static int hnb_iuh_connect_cb(struct osmo_stream_cli *conn) -{ - LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); - struct hnb *hnb = osmo_stream_cli_get_data(conn); - - hnb_send_register_req(hnb); - return 0; -} struct hnb *hnb_alloc(void *tall_ctx) { struct hnb *hnb; - struct osmo_stream_cli *cli; hnb = talloc_zero(tall_ctx, struct hnb); if (!hnb) @@ -123,58 +41,13 @@ .mcc = 1, .mnc = 1, }; - - hnb->iuh.local_addr = talloc_strdup(hnb, "0.0.0.0"); - hnb->iuh.local_port = 0; - hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); - hnb->iuh.remote_port = IUH_DEFAULT_SCTP_PORT; - - cli = osmo_stream_cli_create(hnb); - OSMO_ASSERT(cli); - hnb->iuh.client = cli; - osmo_stream_cli_set_nodelay(cli, true); - osmo_stream_cli_set_proto(cli, IPPROTO_SCTP); - osmo_stream_cli_set_reconnect_timeout(cli, 5); - osmo_stream_cli_set_connect_cb(cli, hnb_iuh_connect_cb); - osmo_stream_cli_set_read_cb(cli, hnb_iuh_read_cb); - osmo_stream_cli_set_data(cli, hnb); + hnb_iuh_alloc(hnb); return hnb; } void hnb_free(struct hnb *hnb) { - if (hnb->iuh.client) { - osmo_stream_cli_destroy(hnb->iuh.client); - hnb->iuh.client = NULL; - } + hnb_iuh_free(hnb); talloc_free(hnb); } - -int hnb_connect(struct hnb *hnb) -{ - int rc; - - LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", - hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); - - osmo_stream_cli_set_addrs(hnb->iuh.client, (const char**)&hnb->iuh.remote_addr, 1); - osmo_stream_cli_set_port(hnb->iuh.client, hnb->iuh.remote_port); - osmo_stream_cli_set_local_addrs(hnb->iuh.client, (const char**)&hnb->iuh.local_addr, 1); - osmo_stream_cli_set_local_port(hnb->iuh.client, hnb->iuh.local_port); - rc = osmo_stream_cli_open(hnb->iuh.client); - if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", - hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); - /* we don't return error in here because osmo_stream_cli_open() - will continue to retry (due to timeout being explicitly set with - osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */ - } - return 0; -} - -int hnb_iuh_send(struct hnb *hnb, struct msgb *msg) -{ - osmo_stream_cli_send(hnb->iuh.client, msg); - return 0; -} diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index bcddfb3..585354b 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -32,6 +32,7 @@ #include #include +#include static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) { diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c new file mode 100644 index 0000000..481c841 --- /dev/null +++ b/src/osmo-hnodeb/iuh.c @@ -0,0 +1,167 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include + +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include +#include + +static int hnb_iuh_read_cb(struct osmo_stream_cli *conn) +{ + struct osmo_fd *fd = osmo_stream_cli_get_ofd(conn); + struct hnb *hnb = osmo_stream_cli_get_data(conn); + struct sctp_sndrcvinfo sinfo; + struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); + int flags = 0; + int rc; + + if (!msg) + return -ENOMEM; + + rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), + NULL, NULL, &sinfo, &flags); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); + /* FIXME: clean up after disappeared HNB */ + osmo_stream_cli_close(conn); + goto free_ret; + } else if (rc == 0) { + LOGP(DMAIN, LOGL_INFO, "Connection to HNBGW closed\n"); + osmo_stream_cli_close(conn); + rc = -1; + goto free_ret; + } else { + msgb_put(msg, rc); + } + + if (flags & MSG_NOTIFICATION) { + LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); + rc = 0; + goto free_ret; + } + + sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); + + switch (sinfo.sinfo_ppid) { + case IUH_PPI_HNBAP: + LOGP(DHNBAP, LOGL_INFO, "HNBAP message received\n"); + rc = hnb_hnbap_rx(hnb, msg); + break; + case IUH_PPI_RUA: + LOGP(DRUA, LOGL_INFO, "RUA message received\n"); + rc = hnb_rua_rx(hnb, msg); + break; + case IUH_PPI_SABP: + case IUH_PPI_RNA: + case IUH_PPI_PUA: + LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + default: + LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + } + +free_ret: + msgb_free(msg); + return rc; +} + +static int hnb_iuh_connect_cb(struct osmo_stream_cli *conn) +{ + LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); + struct hnb *hnb = osmo_stream_cli_get_data(conn); + + hnb_send_register_req(hnb); + return 0; +} + +void hnb_iuh_alloc(struct hnb *hnb) +{ + struct osmo_stream_cli *cli; + + hnb->iuh.local_addr = talloc_strdup(hnb, "0.0.0.0"); + hnb->iuh.local_port = 0; + hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); + hnb->iuh.remote_port = IUH_DEFAULT_SCTP_PORT; + + cli = osmo_stream_cli_create(hnb); + OSMO_ASSERT(cli); + hnb->iuh.client = cli; + osmo_stream_cli_set_nodelay(cli, true); + osmo_stream_cli_set_proto(cli, IPPROTO_SCTP); + osmo_stream_cli_set_reconnect_timeout(cli, 5); + osmo_stream_cli_set_connect_cb(cli, hnb_iuh_connect_cb); + osmo_stream_cli_set_read_cb(cli, hnb_iuh_read_cb); + osmo_stream_cli_set_data(cli, hnb); +} + +void hnb_iuh_free(struct hnb *hnb) +{ + if (!hnb->iuh.client) + return; + osmo_stream_cli_destroy(hnb->iuh.client); + hnb->iuh.client = NULL; +} + +int hnb_iuh_connect(struct hnb *hnb) +{ + int rc; + + LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", + hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); + + osmo_stream_cli_set_addrs(hnb->iuh.client, (const char**)&hnb->iuh.remote_addr, 1); + osmo_stream_cli_set_port(hnb->iuh.client, hnb->iuh.remote_port); + osmo_stream_cli_set_local_addrs(hnb->iuh.client, (const char**)&hnb->iuh.local_addr, 1); + osmo_stream_cli_set_local_port(hnb->iuh.client, hnb->iuh.local_port); + rc = osmo_stream_cli_open(hnb->iuh.client); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", + hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); + /* we don't return error in here because osmo_stream_cli_open() + will continue to retry (due to timeout being explicitly set with + osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */ + } + return 0; +} + +int hnb_iuh_send(struct hnb *hnb, struct msgb *msg) +{ + osmo_stream_cli_send(hnb->iuh.client, msg); + return 0; +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 3376d8e..12d98ff 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -48,6 +48,7 @@ #include #include #include +#include static const char * const osmohnodeb_copyright = "OsmoHNodeB - Osmocom 3G Home NodeB implementation\r\n" @@ -264,7 +265,7 @@ exit(1); } - rc = hnb_connect(g_hnb); + rc = hnb_iuh_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); exit(1); diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 0dd8c3a..907cd60 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -28,6 +28,7 @@ #include #include +#include int hnb_tx_dt(struct hnb *hnb, struct msgb *txm) { diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 61a3f4c..e11fc2d 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de Gerrit-Change-Number: 26341 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 13:21:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 13:21:21 +0000 Subject: Change in osmo-hnodeb[master]: Introduce iuh log category References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 ) Change subject: Introduce iuh log category ...................................................................... Introduce iuh log category Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/iuh.c 3 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/42/26342/1 diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 4cc0831..ed389c1 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -32,6 +32,7 @@ DHNBAP, DRUA, DRANAP, + DIUH, DNAS, }; extern const struct log_info hnb_log_info; diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index f50d8b0..92f76c4 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -42,6 +42,11 @@ .color = "\033[1;35m", .description = "RANAP User Adaptation", }, + [DIUH] = { + .name = "DIUH", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;36m", + .description = "Iuh protocol", + }, [DNAS] = { .name = "NAS", .loglevel = LOGL_NOTICE, .enabled = 1, .color = "\033[1;32m", diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c index 481c841..595181b 100644 --- a/src/osmo-hnodeb/iuh.c +++ b/src/osmo-hnodeb/iuh.c @@ -52,12 +52,12 @@ rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), NULL, NULL, &sinfo, &flags); if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); + LOGP(DIUH, LOGL_ERROR, "Error during sctp_recvmsg()\n"); /* FIXME: clean up after disappeared HNB */ osmo_stream_cli_close(conn); goto free_ret; } else if (rc == 0) { - LOGP(DMAIN, LOGL_INFO, "Connection to HNBGW closed\n"); + LOGP(DIUH, LOGL_INFO, "Connection to HNBGW closed\n"); osmo_stream_cli_close(conn); rc = -1; goto free_ret; @@ -66,7 +66,7 @@ } if (flags & MSG_NOTIFICATION) { - LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); + LOGP(DIUH, LOGL_DEBUG, "Ignoring SCTP notification\n"); rc = 0; goto free_ret; } @@ -85,12 +85,12 @@ case IUH_PPI_SABP: case IUH_PPI_RNA: case IUH_PPI_PUA: - LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", + LOGP(DIUH, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", sinfo.sinfo_ppid); rc = 0; break; default: - LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", + LOGP(DIUH, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", sinfo.sinfo_ppid); rc = 0; break; @@ -103,7 +103,7 @@ static int hnb_iuh_connect_cb(struct osmo_stream_cli *conn) { - LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); + LOGP(DIUH, LOGL_NOTICE, "Iuh connected to HNBGW\n"); struct hnb *hnb = osmo_stream_cli_get_data(conn); hnb_send_register_req(hnb); @@ -142,7 +142,7 @@ { int rc; - LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", + LOGP(DIUH, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); osmo_stream_cli_set_addrs(hnb->iuh.client, (const char**)&hnb->iuh.remote_addr, 1); @@ -151,7 +151,7 @@ osmo_stream_cli_set_local_port(hnb->iuh.client, hnb->iuh.local_port); rc = osmo_stream_cli_open(hnb->iuh.client); if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", + LOGP(DIUH, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); /* we don't return error in here because osmo_stream_cli_open() will continue to retry (due to timeout being explicitly set with -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 13:21:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 13:21:21 +0000 Subject: Change in osmo-hnodeb[master]: iuh: Improve logging of SCTP notifications References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 ) Change subject: iuh: Improve logging of SCTP notifications ...................................................................... iuh: Improve logging of SCTP notifications Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d --- M TODO-RELEASE M src/osmo-hnodeb/iuh.c 2 files changed, 50 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/43/26343/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index d0852fc..9e75c9a 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-netif >1.1.0 use of netif/sctp.h diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c index 595181b..71d805d 100644 --- a/src/osmo-hnodeb/iuh.c +++ b/src/osmo-hnodeb/iuh.c @@ -31,12 +31,59 @@ #include #include #include +#include #include #include #include #include +static int get_logevel_by_sn_type(int sn_type) +{ + switch (sn_type) { + case SCTP_ADAPTATION_INDICATION: + case SCTP_PEER_ADDR_CHANGE: +#ifdef SCTP_AUTHENTICATION_INDICATION + case SCTP_AUTHENTICATION_INDICATION: +#endif +#ifdef SCTP_SENDER_DRY_EVENT + case SCTP_SENDER_DRY_EVENT: +#endif + return LOGL_INFO; + case SCTP_ASSOC_CHANGE: + return LOGL_NOTICE; + case SCTP_SHUTDOWN_EVENT: + case SCTP_PARTIAL_DELIVERY_EVENT: + return LOGL_NOTICE; + case SCTP_SEND_FAILED: + case SCTP_REMOTE_ERROR: + return LOGL_ERROR; + default: + return LOGL_NOTICE; + } +} + +static void log_sctp_notification(union sctp_notification *notif) +{ + int log_level; + + LOGP(DIUH, LOGL_INFO, "Iuh SCTP NOTIFICATION %u flags=0x%0x\n", + notif->sn_header.sn_type, notif->sn_header.sn_flags); + + log_level = get_logevel_by_sn_type(notif->sn_header.sn_type); + + switch (notif->sn_header.sn_type) { + case SCTP_ASSOC_CHANGE: + LOGP(DIUH, log_level, "Iuh SCTP_ASSOC_CHANGE: %s\n", + osmo_sctp_assoc_chg_str(notif->sn_assoc_change.sac_state)); + break; + default: + LOGP(DIUH, log_level, "Iuh %s\n", + osmo_sctp_sn_type_str(notif->sn_header.sn_type)); + break; + } +} + static int hnb_iuh_read_cb(struct osmo_stream_cli *conn) { struct osmo_fd *fd = osmo_stream_cli_get_ofd(conn); @@ -66,7 +113,8 @@ } if (flags & MSG_NOTIFICATION) { - LOGP(DIUH, LOGL_DEBUG, "Ignoring SCTP notification\n"); + union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); + log_sctp_notification(notif); rc = 0; goto free_ret; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d Gerrit-Change-Number: 26343 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 13:24:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 13:24:38 +0000 Subject: Change in osmo-hnodeb[master]: Fix typos and non-related test content References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 ) Change subject: Fix typos and non-related test content ...................................................................... Fix typos and non-related test content Artifacts from initial commits adding the project skeleton. Change-Id: I00cce8fbfeef9688dd2fd235cb859c27bd864e8b --- M README.md M tests/ctrl_test_runner.py 2 files changed, 3 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/44/26344/1 diff --git a/README.md b/README.md index 2f09148..835415d 100644 --- a/README.md +++ b/README.md @@ -40,7 +40,7 @@ Mailing List ------------ -Discussions related to osmo-bts are happening on the +Discussions related to osmo-hnodeb are happening on the openbsc at lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive. @@ -60,5 +60,5 @@ https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details -The current patch queue for osmo-bts can be seen at +The current patch queue for osmo-hnodeb can be seen at https://gerrit.osmocom.org/#/q/project:osmo-hnodeb+status:open diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index 8908a65..c0e6a55 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -161,15 +161,7 @@ self.assertEqual(r['mtype'], 'ERROR') self.assertEqual(r['error'], 'Command not found') - r = self.do_set('rf_locked', '999') - self.assertEqual(r['mtype'], 'ERROR') - self.assertEqual(r['error'], 'Value failed verification.') - - r = self.do_get('bts') - self.assertEqual(r['mtype'], 'ERROR') - self.assertEqual(r['error'], 'Error while parsing the index.') - - r = self.do_get('bts.999') + r = self.do_get('hnodeb.999') self.assertEqual(r['mtype'], 'ERROR') self.assertEqual(r['error'], 'Error while resolving object') -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I00cce8fbfeef9688dd2fd235cb859c27bd864e8b Gerrit-Change-Number: 26344 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 13:33:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 13:33:04 +0000 Subject: Change in osmo-bts[master]: bts_shutdown_fsm.h: Remove wrong comment describing enum References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26345 ) Change subject: bts_shutdown_fsm.h: Remove wrong comment describing enum ...................................................................... bts_shutdown_fsm.h: Remove wrong comment describing enum Change-Id: I963234255ce5a648a842ae6dbfd9966a694d0c09 --- M include/osmo-bts/bts_shutdown_fsm.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/26345/1 diff --git a/include/osmo-bts/bts_shutdown_fsm.h b/include/osmo-bts/bts_shutdown_fsm.h index 76ac6ca..fe52625 100644 --- a/include/osmo-bts/bts_shutdown_fsm.h +++ b/include/osmo-bts/bts_shutdown_fsm.h @@ -24,7 +24,6 @@ #include -/* 3GPP TS 24.008 ? 4.1.3.3 GMM mobility management states on the network side */ enum bts_shutdown_fsm_states { BTS_SHUTDOWN_ST_NONE, BTS_SHUTDOWN_ST_WAIT_RAMP_DOWN_COMPL, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I963234255ce5a648a842ae6dbfd9966a694d0c09 Gerrit-Change-Number: 26345 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 13:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 13:42:36 +0000 Subject: Change in osmo-bts[master]: bts: Properly free bts->shutdown_fi when struct gsm_bts is freed References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26346 ) Change subject: bts: Properly free bts->shutdown_fi when struct gsm_bts is freed ...................................................................... bts: Properly free bts->shutdown_fi when struct gsm_bts is freed Change-Id: I8c59f030c39c83a91b8504d4c5ce3b2058206fcf --- M src/common/bts.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/26346/1 diff --git a/src/common/bts.c b/src/common/bts.c index 86140ba..93fb400 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -219,6 +219,10 @@ osmo_fsm_inst_free(bts->mo.fi); bts->mo.fi = NULL; } + if (bts->shutdown_fi) { + osmo_fsm_inst_free(bts->shutdown_fi); + bts->shutdown_fi = NULL; + } return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8c59f030c39c83a91b8504d4c5ce3b2058206fcf Gerrit-Change-Number: 26346 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:39:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:39:13 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 ) Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn File library/Iuh_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn at 35 PS3, Line 35: encode "PER"; you can even drop the PER encoding, as we don't encode/decode a Iuh_PDU anywhere, right? We just create it to pass it around a port between two components, but don't receive/transmit it over a socket? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336/3/library/Iuh_Types.ttcn at 38 PS3, Line 38: } with { encode "RAW" variant "BYTEORDER(first)" }; that then can also go, as a) the only type defined overrides it with PER anyway b) we don't expect to encode/decode any of this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:41:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:41:07 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:41:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:41:33 +0000 Subject: Change in osmo-bts[master]: bts_shutdown_fsm.h: Remove wrong comment describing enum In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26345 ) Change subject: bts_shutdown_fsm.h: Remove wrong comment describing enum ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I963234255ce5a648a842ae6dbfd9966a694d0c09 Gerrit-Change-Number: 26345 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:41:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:41:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:41:43 +0000 Subject: Change in osmo-bts[master]: bts: Properly free bts->shutdown_fi when struct gsm_bts is freed In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26346 ) Change subject: bts: Properly free bts->shutdown_fi when struct gsm_bts is freed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8c59f030c39c83a91b8504d4c5ce3b2058206fcf Gerrit-Change-Number: 26346 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:41:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:42:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:42:09 +0000 Subject: Change in osmo-hnodeb[master]: iuh: Improve logging of SCTP notifications In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 ) Change subject: iuh: Improve logging of SCTP notifications ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d Gerrit-Change-Number: 26343 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:42:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:42:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:42:20 +0000 Subject: Change in osmo-hnodeb[master]: Fix typos and non-related test content In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 ) Change subject: Fix typos and non-related test content ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I00cce8fbfeef9688dd2fd235cb859c27bd864e8b Gerrit-Change-Number: 26344 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:42:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:42:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:42:32 +0000 Subject: Change in osmo-hnodeb[master]: Introduce iuh log category In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 ) Change subject: Introduce iuh log category ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:42:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:42:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 14:42:53 +0000 Subject: Change in osmo-bts[master]: bts_shutdown_fsm.h: Remove wrong comment describing enum In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26345 ) Change subject: bts_shutdown_fsm.h: Remove wrong comment describing enum ...................................................................... bts_shutdown_fsm.h: Remove wrong comment describing enum Change-Id: I963234255ce5a648a842ae6dbfd9966a694d0c09 --- M include/osmo-bts/bts_shutdown_fsm.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmo-bts/bts_shutdown_fsm.h b/include/osmo-bts/bts_shutdown_fsm.h index 76ac6ca..fe52625 100644 --- a/include/osmo-bts/bts_shutdown_fsm.h +++ b/include/osmo-bts/bts_shutdown_fsm.h @@ -24,7 +24,6 @@ #include -/* 3GPP TS 24.008 ? 4.1.3.3 GMM mobility management states on the network side */ enum bts_shutdown_fsm_states { BTS_SHUTDOWN_ST_NONE, BTS_SHUTDOWN_ST_WAIT_RAMP_DOWN_COMPL, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I963234255ce5a648a842ae6dbfd9966a694d0c09 Gerrit-Change-Number: 26345 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:42:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 14:42:54 +0000 Subject: Change in osmo-bts[master]: bts: Properly free bts->shutdown_fi when struct gsm_bts is freed In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26346 ) Change subject: bts: Properly free bts->shutdown_fi when struct gsm_bts is freed ...................................................................... bts: Properly free bts->shutdown_fi when struct gsm_bts is freed Change-Id: I8c59f030c39c83a91b8504d4c5ce3b2058206fcf --- M src/common/bts.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/common/bts.c b/src/common/bts.c index 86140ba..93fb400 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -219,6 +219,10 @@ osmo_fsm_inst_free(bts->mo.fi); bts->mo.fi = NULL; } + if (bts->shutdown_fi) { + osmo_fsm_inst_free(bts->shutdown_fi); + bts->shutdown_fi = NULL; + } return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8c59f030c39c83a91b8504d4c5ce3b2058206fcf Gerrit-Change-Number: 26346 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:43:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Nov 2021 14:43:11 +0000 Subject: Change in osmo-hnodeb[master]: Introduce iuh log category In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 ) Change subject: Introduce iuh log category ...................................................................... Patch Set 1: not sure if it shouldn't be simply SCTP? Iuh includes HNBAP, RANAP, RUA, GTPv1U, RTP and IuUP, so it is a bit broad a term for a log category, IMHO -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:43:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:46:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 14:46:32 +0000 Subject: Change in osmo-hnodeb[master]: Introduce iuh log category In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 ) Change subject: Introduce iuh log category ...................................................................... Patch Set 1: > Patch Set 1: > > not sure if it shouldn't be simply SCTP? Iuh includes HNBAP, RANAP, RUA, GTPv1U, RTP and IuUP, so it is a bit broad a term for a log category, IMHO SCTP looks even more generic to me. At least for Iuh one knows it's mostly related to the conn HNB->HNBGW. I don't have a strong opinion though. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Nov 2021 14:46:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:46:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 14:46:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 to look at the new patch set (#4). Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... hnb: Introduce HNB_Tests testsuite A new Iuh CodecPort + Emulation is introduced to (de)mux RANAP and RUA in the same SCTP socket. The Iuh_CodecPort.ttcn file has currently a hack to be able to test HNBAP, since titan seem to be reporting sinfo_ppid=0 when in fact it received sinfo_ppid=20 (HNBAP). A couple tests are added to validate HNBAP HNBRegister Request + Accept or Reject. In current osmo-hnodeb state, both tests pass if run separately, but fail if run sequentially since osmo-hnodeb still doesn't re-connect properly after first test finishes and connection is dropped. Related: SYS#5516 Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 --- M Makefile A hnodeb/HNBGW_ConnectionHandler.ttcn A hnodeb/HNB_Tests.cfg A hnodeb/HNB_Tests.default A hnodeb/HNB_Tests.ttcn A hnodeb/README.md A hnodeb/README.txt A hnodeb/expected-results.xml A hnodeb/gen_links.sh A hnodeb/osmo-hnodeb.cfg A hnodeb/regen_makefile.sh A library/Iuh_CodecPort.ttcn A library/Iuh_CodecPort_CtrlFunct.ttcn A library/Iuh_CodecPort_CtrlFunctDef.cc A library/Iuh_Emulation.ttcn A library/Iuh_Types.ttcn A library/hnbap/HNBAP_Templates.ttcn A library/rua/RUA_Templates.ttcn 18 files changed, 1,198 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26336/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:50:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 14:50:43 +0000 Subject: Change in libosmo-sccp[master]: ss7: Use sctp value_string from libosmo-netif References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26347 ) Change subject: ss7: Use sctp value_string from libosmo-netif ...................................................................... ss7: Use sctp value_string from libosmo-netif Depends: libosmo-netif Change-Id Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Change-Id: I42323eb5d02d4f67daac7b0a4365f5f6f6057666 --- M TODO-RELEASE M src/osmo_ss7.c 2 files changed, 4 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/47/26347/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index d0852fc..9e75c9a 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-netif >1.1.0 use of netif/sctp.h diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index b4c0b51..649e3f7 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -45,6 +45,7 @@ #include #include +#include #include "sccp_internal.h" #include "xua_internal.h" @@ -1663,32 +1664,6 @@ * libosmo-netif integration for SCTP stream server/client ***********************************************************************/ -static const struct value_string sctp_assoc_chg_vals[] = { - { SCTP_COMM_UP, "COMM_UP" }, - { SCTP_COMM_LOST, "COMM_LOST" }, - { SCTP_RESTART, "RESTART" }, - { SCTP_SHUTDOWN_COMP, "SHUTDOWN_COMP" }, - { SCTP_CANT_STR_ASSOC, "CANT_STR_ASSOC" }, - { 0, NULL } -}; - -static const struct value_string sctp_sn_type_vals[] = { - { SCTP_ASSOC_CHANGE, "ASSOC_CHANGE" }, - { SCTP_PEER_ADDR_CHANGE, "PEER_ADDR_CHANGE" }, - { SCTP_SHUTDOWN_EVENT, "SHUTDOWN_EVENT" }, - { SCTP_SEND_FAILED, "SEND_FAILED" }, - { SCTP_REMOTE_ERROR, "REMOTE_ERROR" }, - { SCTP_PARTIAL_DELIVERY_EVENT, "PARTIAL_DELIVERY_EVENT" }, - { SCTP_ADAPTATION_INDICATION, "ADAPTATION_INDICATION" }, -#ifdef SCTP_AUTHENTICATION_INDICATION - { SCTP_AUTHENTICATION_INDICATION, "AUTHENTICATION_INDICATION" }, -#endif -#ifdef SCTP_SENDER_DRY_EVENT - { SCTP_SENDER_DRY_EVENT, "SENDER_DRY_EVENT" }, -#endif - { 0, NULL } -}; - static int get_logevel_by_sn_type(int sn_type) { switch (sn_type) { @@ -1728,13 +1703,11 @@ switch (notif->sn_header.sn_type) { case SCTP_ASSOC_CHANGE: LOGPASP(asp, DLSS7, log_level, "%s SCTP_ASSOC_CHANGE: %s\n", - pfx, get_value_string(sctp_assoc_chg_vals, - notif->sn_assoc_change.sac_state)); + pfx, osmo_sctp_assoc_chg_str(notif->sn_assoc_change.sac_state)); break; default: LOGPASP(asp, DLSS7, log_level, "%s %s\n", - pfx, get_value_string(sctp_sn_type_vals, - notif->sn_header.sn_type)); + pfx, osmo_sctp_sn_type_str(notif->sn_header.sn_type)); break; } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I42323eb5d02d4f67daac7b0a4365f5f6f6057666 Gerrit-Change-Number: 26347 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 14:52:42 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Nov 2021 14:52:42 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 23 Nov 2021 14:52:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 15:49:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 15:49:59 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 ) Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Implement initial shutdown + reconnect FSM The shutdown_fsm doesn't do much right now, but it's included there in order to allow easy clean up of resources upon Iuh reconnect in the future, as well as reset the lower layers. Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 --- M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_shutdown_fsm.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/hnb.c A src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/iuh.c 7 files changed, 202 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/48/26348/1 diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 23adb2a..b1acb7e 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,4 +1,5 @@ noinst_HEADERS = \ + hnb_shutdown_fsm.h \ hnbap.h \ hnodeb.h \ iuh.h \ diff --git a/include/osmocom/hnodeb/hnb_shutdown_fsm.h b/include/osmocom/hnodeb/hnb_shutdown_fsm.h new file mode 100644 index 0000000..dc9b357 --- /dev/null +++ b/include/osmocom/hnodeb/hnb_shutdown_fsm.h @@ -0,0 +1,42 @@ +/* hNodeB shutdown FSM */ + +/* (C) 2021 by sysmocom - s.m.f.c. GmbH + * Author: Pau Espin Pedrol + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#pragma once + +#include + +#include + +enum hnb_shutdown_fsm_states { + HNB_SHUTDOWN_ST_NONE, + HNB_SHUTDOWN_ST_EXIT, +}; + +enum hnb_shutdown_fsm_events { + HNB_SHUTDOWN_EV_START, +}; + +extern struct osmo_fsm hnb_shutdown_fsm; + +struct hnb; +void hnb_shutdown(struct hnb *hnb, const char *reason, bool exit_proc); +bool hnb_shutdown_in_progress(const struct hnb *hnb); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index ed389c1..a2016d5 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -26,6 +26,7 @@ #include #include #include +#include enum { DMAIN, @@ -62,6 +63,9 @@ uint32_t ctx_id; + struct osmo_fsm_inst *shutdown_fi; /* FSM instance to manage shutdown procedure during process exit */ + bool shutdown_fi_exit_proc; /* exit process when shutdown_fsm is finished? */ + struct { struct hnb_chan *chan; } cs; diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 88f2571..7325728 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -33,6 +33,7 @@ debug.c \ hnbap.c \ hnb.c \ + hnb_shutdown_fsm.c \ iuh.c \ nas.c \ ranap.c \ diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 3344cfb..b7be4ea 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -26,6 +26,7 @@ #include #include +#include struct hnb *hnb_alloc(void *tall_ctx) @@ -41,6 +42,10 @@ .mcc = 1, .mnc = 1, }; + + hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, + LOGL_INFO, NULL); + hnb_iuh_alloc(hnb); return hnb; @@ -48,6 +53,10 @@ void hnb_free(struct hnb *hnb) { + if (hnb->shutdown_fi) { + osmo_fsm_inst_free(hnb->shutdown_fi); + hnb->shutdown_fi = NULL; + } hnb_iuh_free(hnb); talloc_free(hnb); } diff --git a/src/osmo-hnodeb/hnb_shutdown_fsm.c b/src/osmo-hnodeb/hnb_shutdown_fsm.c new file mode 100644 index 0000000..7df591e --- /dev/null +++ b/src/osmo-hnodeb/hnb_shutdown_fsm.c @@ -0,0 +1,134 @@ +/* hNodeB shutdown FSM */ + +/* (C) 2021 by sysmocom - s.m.f.c. GmbH + * Author: Pau Espin Pedrol + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include + +#include +#include +#include +#define X(s) (1 << (s)) + +#define hnb_shutdown_fsm_state_chg(fi, NEXT_STATE) \ + osmo_fsm_inst_state_chg(fi, NEXT_STATE, 0, 0) + +static void st_none_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct hnb *hnb = (struct hnb *)fi->priv; + hnb_iuh_connect(hnb); /* Start reconnect once we are done with shutdown and we didn't exit process */ +} + +static void st_none(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct hnb *hnb = (struct hnb *)fi->priv; + switch(event) { + case HNB_SHUTDOWN_EV_START: + /* TODO: here we may want to communicate t lower layers over UDsocket that we are shutting down... + * TODO: Also, if Iuh link is still up, maybe send a Hnb deregister req towards HNBGW + * TODO: also signal the hnb object somehow that we are starting to shut down? + */ + if (osmo_stream_cli_is_connected(hnb->iuh.client)) { + osmo_stream_cli_close(hnb->iuh.client); + } + hnb_shutdown_fsm_state_chg(fi, HNB_SHUTDOWN_ST_EXIT); + break; + } +} + +static void st_exit_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct hnb *hnb = (struct hnb *)fi->priv; + /* TODO: here we may want to signal the hnb object somehow that we have completed the shut down? */ + + if (hnb->shutdown_fi_exit_proc) { + LOGPFSML(fi, LOGL_NOTICE, "Shutdown process completed successfully, exiting process\n"); + exit(0); + } + hnb_shutdown_fsm_state_chg(fi, HNB_SHUTDOWN_ST_NONE); +} + +static struct osmo_fsm_state hnb_shutdown_fsm_states[] = { + [HNB_SHUTDOWN_ST_NONE] = { + .in_event_mask = + X(HNB_SHUTDOWN_EV_START), + .out_state_mask = + X(HNB_SHUTDOWN_ST_EXIT), + .name = "NONE", + .onenter = st_none_on_enter, + .action = st_none, + }, + [HNB_SHUTDOWN_ST_EXIT] = { + .name = "EXIT", + .out_state_mask = + X(HNB_SHUTDOWN_ST_NONE), + .onenter = st_exit_on_enter, + } +}; + +const struct value_string hnb_shutdown_fsm_event_names[] = { + OSMO_VALUE_STRING(HNB_SHUTDOWN_EV_START), + { 0, NULL } +}; + +int hnb_shutdown_fsm_timer_cb(struct osmo_fsm_inst *fi) +{ + switch (fi->state) { + default: + OSMO_ASSERT(false); + } + return 0; +} + +struct osmo_fsm hnb_shutdown_fsm = { + .name = "HNB_SHUTDOWN", + .states = hnb_shutdown_fsm_states, + .num_states = ARRAY_SIZE(hnb_shutdown_fsm_states), + .event_names = hnb_shutdown_fsm_event_names, + .log_subsys = DMAIN, + .timer_cb = hnb_shutdown_fsm_timer_cb, +}; + +static __attribute__((constructor)) void hnb_shutdown_fsm_init(void) +{ + OSMO_ASSERT(osmo_fsm_register(&hnb_shutdown_fsm) == 0); +} + +bool hnb_shutdown_in_progress(const struct hnb *hnb) +{ + const struct osmo_fsm_inst *fi = hnb->shutdown_fi; + return fi->state != HNB_SHUTDOWN_ST_NONE; +} + +void hnb_shutdown(struct hnb *hnb, const char *reason, bool exit_proc) +{ + struct osmo_fsm_inst *fi = hnb->shutdown_fi; + if (hnb_shutdown_in_progress(hnb)) { + LOGPFSML(fi, LOGL_NOTICE, "hNodeB is already being shutdown.\n"); + if (exit_proc) + hnb->shutdown_fi_exit_proc = true; + return; + } + hnb->shutdown_fi_exit_proc = exit_proc; + LOGPFSML(fi, LOGL_NOTICE, "Shutting down hNodeB, exit %u, reason: %s\n", + exit_proc, reason); + osmo_fsm_inst_dispatch(fi, HNB_SHUTDOWN_EV_START, NULL); +} diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c index 71d805d..80ce225 100644 --- a/src/osmo-hnodeb/iuh.c +++ b/src/osmo-hnodeb/iuh.c @@ -37,6 +37,7 @@ #include #include #include +#include static int get_logevel_by_sn_type(int sn_type) { @@ -100,12 +101,13 @@ NULL, NULL, &sinfo, &flags); if (rc < 0) { LOGP(DIUH, LOGL_ERROR, "Error during sctp_recvmsg()\n"); - /* FIXME: clean up after disappeared HNB */ osmo_stream_cli_close(conn); + hnb_shutdown(hnb, "sctp_recvmsg() error", false); goto free_ret; } else if (rc == 0) { LOGP(DIUH, LOGL_INFO, "Connection to HNBGW closed\n"); osmo_stream_cli_close(conn); + hnb_shutdown(hnb, "Iuh HNBGW conn closed", false); rc = -1; goto free_ret; } else { @@ -115,6 +117,14 @@ if (flags & MSG_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); log_sctp_notification(notif); + switch (notif->sn_header.sn_type) { + case SCTP_SHUTDOWN_EVENT: + osmo_fsm_inst_dispatch(hnb->shutdown_fi, HNB_SHUTDOWN_EV_START, NULL); + hnb_shutdown(hnb, "Iuh HNBGW conn notification (SCTP_SHUTDOWN_EVENT)", false); + break; + default: + break; + } rc = 0; goto free_ret; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 15:50:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 15:50:00 +0000 Subject: Change in osmo-hnodeb[master]: hnbap: Improve rx path and implement HnbRegisterReject References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 ) Change subject: hnbap: Improve rx path and implement HnbRegisterReject ...................................................................... hnbap: Improve rx path and implement HnbRegisterReject The process is shut down if we receive such a message. Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a --- M src/osmo-hnodeb/hnbap.c 1 file changed, 78 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/49/26349/1 diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 585354b..0495ce0 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -33,6 +33,7 @@ #include #include #include +#include static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) { @@ -44,12 +45,31 @@ } hnb->rnc_id = accept.rnc_id; - LOGP(DHNBAP, LOGL_INFO, "HNB Register accept with RNC ID %u\n", hnb->rnc_id); + LOGP(DHNBAP, LOGL_INFO, "Rx HNB Register accept with RNC ID %u\n", hnb->rnc_id); hnbap_free_hnbregisteraccepties(&accept); return 0; } +static int hnb_rx_hnb_register_rej(struct hnb *hnb, ANY_t *in) +{ + int rc; + HNBAP_HNBRegisterRejectIEs_t reject; + + rc = hnbap_decode_hnbregisterrejecties(&reject, in); + if (rc < 0) { + LOGP(DHNBAP, LOGL_NOTICE, "Rx HNB Register Reject: parse failure\n"); + return -EINVAL; + } else { + LOGP(DHNBAP, LOGL_NOTICE, "Rx HNB Register Reject with cause %s\n", + hnbap_cause_str(&reject.cause)); + hnbap_free_hnbregisterrejecties(&reject); + } + + hnb_shutdown(hnb, "Rx HNB Register Reject", true); + return 0; +} + static int hnb_rx_ue_register_acc(struct hnb *hnb, ANY_t *in) { int rc; @@ -79,6 +99,53 @@ return 0; } +static int hnb_hnbap_rx_initiating(struct hnb *hnb, struct HNBAP_InitiatingMessage *init) +{ + int rc; + + switch (init->procedureCode) { + default: + LOGP(DHNBAP, LOGL_ERROR, "Rx HNBAP initiatingMessage %ld unsupported\n", init->procedureCode); + rc = -ENOSPC; + break; + } + return rc; +} + +static int hnb_hnbap_rx_successful(struct hnb *hnb, struct HNBAP_SuccessfulOutcome *succ) +{ + int rc; + + switch (succ->procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: + /* Get HNB id and send UE Register request */ + rc = hnb_rx_hnb_register_acc(hnb, &succ->value); + break; + case HNBAP_ProcedureCode_id_UERegister: + rc = hnb_rx_ue_register_acc(hnb, &succ->value); + break; + default: + rc = -ENOSPC; + break; + } + return rc; +} + +static int hnb_hnbap_rx_unsuccessful(struct hnb *hnb, struct HNBAP_UnsuccessfulOutcome *unsucc) +{ + int rc; + + switch (unsucc->procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: + rc = hnb_rx_hnb_register_rej(hnb, &unsucc->value); + break; + default: + rc = -ENOSPC; + break; + } + return rc; +} + int hnb_hnbap_rx(struct hnb *hnb, struct msgb *msg) { HNBAP_HNBAP_PDU_t _pdu, *pdu = &_pdu; @@ -93,21 +160,20 @@ return -EINVAL; } - if (pdu->present != HNBAP_HNBAP_PDU_PR_successfulOutcome) { - LOGP(DHNBAP, LOGL_ERROR, "Unexpected HNBAP message received\n"); - } - - switch (pdu->choice.successfulOutcome.procedureCode) { - case HNBAP_ProcedureCode_id_HNBRegister: - /* Get HNB id and send UE Register request */ - rc = hnb_rx_hnb_register_acc(hnb, &pdu->choice.successfulOutcome.value); + switch(pdu->present) { + case HNBAP_HNBAP_PDU_PR_initiatingMessage: + rc = hnb_hnbap_rx_initiating(hnb, &pdu->choice.initiatingMessage); break; - case HNBAP_ProcedureCode_id_UERegister: - rc = hnb_rx_ue_register_acc(hnb, &pdu->choice.successfulOutcome.value); + case HNBAP_HNBAP_PDU_PR_successfulOutcome: + rc = hnb_hnbap_rx_successful(hnb, &pdu->choice.successfulOutcome); break; + case HNBAP_HNBAP_PDU_PR_unsuccessfulOutcome: + rc = hnb_hnbap_rx_unsuccessful(hnb, &pdu->choice.unsuccessfulOutcome); + break; + case HNBAP_HNBAP_PDU_PR_NOTHING: /* No components present */ default: + LOGP(DHNBAP, LOGL_ERROR, "Unexpected HNBAP message received\n"); rc = -ENOSPC; - break; } return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a Gerrit-Change-Number: 26349 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 15:50:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Nov 2021 15:50:38 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 to look at the new patch set (#5). Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... hnb: Introduce HNB_Tests testsuite A new Iuh CodecPort + Emulation is introduced to (de)mux RANAP and RUA in the same SCTP socket. The Iuh_CodecPort.ttcn file has currently a hack to be able to test HNBAP, since titan seem to be reporting sinfo_ppid=0 when in fact it received sinfo_ppid=20 (HNBAP). A couple tests are added to validate HNBAP HNBRegister Request + Accept or Reject. In current osmo-hnodeb state, both tests pass if run separately, but fail if run sequentially since osmo-hnodeb still doesn't re-connect properly after first test finishes and connection is dropped. Related: SYS#5516 Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 --- M Makefile A hnodeb/HNBGW_ConnectionHandler.ttcn A hnodeb/HNB_Tests.cfg A hnodeb/HNB_Tests.default A hnodeb/HNB_Tests.ttcn A hnodeb/README.md A hnodeb/README.txt A hnodeb/expected-results.xml A hnodeb/gen_links.sh A hnodeb/osmo-hnodeb.cfg A hnodeb/regen_makefile.sh A library/Iuh_CodecPort.ttcn A library/Iuh_CodecPort_CtrlFunct.ttcn A library/Iuh_CodecPort_CtrlFunctDef.cc A library/Iuh_Emulation.ttcn A library/Iuh_Types.ttcn A library/hnbap/HNBAP_Templates.ttcn A library/rua/RUA_Templates.ttcn 18 files changed, 1,196 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26336/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 17:41:19 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 23 Nov 2021 17:41:19 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26253 to look at the new patch set (#6). Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... pySim-read: put try/catch block around select_adf_by_aid() Selecting an application may fail, especially when the application does not exist on the card. Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef --- M pySim-read.py 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/26253/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 23 17:41:19 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 23 Nov 2021 17:41:19 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/26253/5/pySim-read.py at 48 PS5, Line 48: def select_app(adf:str): > method on card class likely makes even more sense, yes. I don't get why this even works without card as parameter. This is now fixed. I won't put this into the card class, the card class is already a kitchen sink for a lot of stuff. Also this function contains print statements which are tuned to this program. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 23 Nov 2021 17:41:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 09:52:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 09:52:27 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 37: (4 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_endp.h File include/osmocom/mgcp/mgcp_endp.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/include/osmocom/mgcp/mgcp_endp.h at 139 PS32, Line 139: chop_epname_prefix exported function without mgcp_ prefix, maybe rather mgcp_epname_chop_prefix ? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/include/osmocom/mgcp/mgcp_trunk.h at 30 PS35, Line 30: unsigned int > because the useless comments are too long and this is kernel style formatting I really don't get your argument. In all the Linux kernel and osmocom code I've seen, I never saw that kind of line break at this position. If your comments are too long to fit after the variable, put the comment above the variable declaration. I really don't see why we need to discuss this again. Every one of us is reading osmocom code each day. It should be imprinted into everyone's brain by now? https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/32/src/libosmo-mgcp/mgcp_protocol.c at 395 PS32, Line 395: if (ti->dlcx_in_queue + 1 <= ti->eps_free) { : ti->dlcx_in_queue++; : thread_push_msg(rq->trunk, i, w); when enqueueing a CRCX, why are we incrementing dlcx_in_queue? I don't understand that logic. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/35/src/libosmo-mgcp/mgcp_threads.c at 199 PS35, Line 199: { > same line I agree, and don't get why this is something we do need to discuss. I doubt we have any existing code in osmo-* that formats it this way, so why is it even proposed? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 37 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 09:52:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 09:54:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 09:54:01 +0000 Subject: Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 09:54:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 10:52:32 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Nov 2021 10:52:32 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26350 ) Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... bsc_subscr_conn_fsm: fix crash if !conn Do not crash in gscon_ensure_mgw_endpoint() if conn is NULL. Such checks are also in gscon_is_sccplite() and gscon_is_aoip() already, so it will end up in the return NULL codepath. Related: SYS#5728 Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/26350/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index c18079f..f549ee1 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -521,7 +521,7 @@ const char *epname; struct mgcp_client *mgcp_client = NULL; - if (conn->user_plane.mgw_endpoint) + if (conn && conn->user_plane.mgw_endpoint) return conn->user_plane.mgw_endpoint; if (gscon_is_sccplite(conn) || gscon_is_aoip(conn)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 11:15:21 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Nov 2021 11:15:21 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 to look at the new patch set (#2). Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... bsc_subscr_conn_fsm: fix crash if !conn Do not crash in gscon_ensure_mgw_endpoint() if conn is NULL. gscon_is_sccplite() and gscon_is_aoip() are null pointer safe, so it will end up in the return NULL codepath. Related: SYS#5728 Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/26350/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 13:02:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Nov 2021 13:02:46 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26350 ) Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 24 Nov 2021 13:02:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 13:25:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 13:25:44 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26350 ) Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26350/2/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26350/2/src/osmo-bsc/bsc_subscr_conn_fsm.c at 524 PS2, Line 524: if (conn && conn->user_plane.mgw_endpoint) I'd rather do a: if (!conn) { log("no conn!") + return} This way code is clearer and doesn't look like a cascade of lucky check-against-nulls going through and returning at the end. Furthermore, we get a specific log line which is descriptive and not misleading like ""Conn is neither SCCPlite nor AoIP!?\n", because there's really no conn. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 13:25:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 13:38:28 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Nov 2021 13:38:28 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 to look at the new patch set (#3). Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... bsc_subscr_conn_fsm: fix crash if !conn Do not crash in gscon_ensure_mgw_endpoint() if conn is NULL. Related: SYS#5728 Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/26350/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 13:56:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 13:56:45 +0000 Subject: Change in osmo-bts[master]: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26351 ) Change subject: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() ...................................................................... cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() If a new default message is installed via RSL, and the old default message is currently being transmitted, we must set cur_msg to NULL. The old default message must be talloc_free()d unconditionally whenever a new default message is being set. We can do that by using the TALLOC_FREE macro. Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Closes: OS#5325 --- M src/common/cbch.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/26351/1 diff --git a/src/common/cbch.c b/src/common/cbch.c index addd68c..4677480 100644 --- a/src/common/cbch.c +++ b/src/common/cbch.c @@ -233,10 +233,10 @@ rate_ctr_inc2(bts_ss->ctrs, CBCH_CTR_RCVD_QUEUED); break; case RSL_CB_CMD_TYPE_DEFAULT: - /* old default msg will be free'd in get_smscb_block() if it is currently in transit - * and we set a new default_msg here */ + /* clear the cur_msg pointer if it is the old default message */ if (bts_ss->cur_msg && bts_ss->cur_msg == bts_ss->default_msg) - talloc_free(bts_ss->cur_msg); + bts_ss->cur_msg = NULL; + talloc_free(bts_ss->default_msg); if (cmd_type.def_bcast == RSL_CB_CMD_DEFBCAST_NORMAL) /* def_bcast == 0: normal message */ bts_ss->default_msg = scm; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Gerrit-Change-Number: 26351 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 14:11:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 14:11:59 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26350 ) Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 14:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 14:14:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 14:14:22 +0000 Subject: Change in osmo-bts[master]: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26351 ) Change subject: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Gerrit-Change-Number: 26351 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 14:14:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 14:24:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 24 Nov 2021 14:24:36 +0000 Subject: Change in osmo-bsc[master]: hodec2: fix segv for inter-BSC ho target References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26352 ) Change subject: hodec2: fix segv for inter-BSC ho target ...................................................................... hodec2: fix segv for inter-BSC ho target Related: OS#5324 SYS#5259 Change-Id: I5a3345ab0005a73597f5c27207480912a2f5aae6 --- M src/osmo-bsc/handover_decision_2.c 1 file changed, 30 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/26352/1 diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index 6730f26..14bc2d4 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -1027,27 +1027,39 @@ break; } - chan_counts_for_bts(&bts_counts, c->target.bts); - c->target.free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; - c->target.min_free_tchf = ho_get_hodec2_tchf_min_slots(c->target.bts->ho); - c->target.free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; - c->target.min_free_tchh = ho_get_hodec2_tchh_min_slots(c->target.bts->ho); + /* For inter-BSC handover, the target BTS is in a different BSC and hence NULL here. */ + if (c->target.bts) { + chan_counts_for_bts(&bts_counts, c->target.bts); + c->target.free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; + c->target.min_free_tchf = ho_get_hodec2_tchf_min_slots(c->target.bts->ho); + c->target.free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; + c->target.min_free_tchh = ho_get_hodec2_tchh_min_slots(c->target.bts->ho); - /* Would the next TCH/F lchan occupy a dynamic timeslot that currently counts for free TCH/H timeslots? */ - next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_F, false); - if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN) - c->target.next_tchf_reduces_tchh = 2; - else - c->target.next_tchf_reduces_tchh = 0; + /* Would the next TCH/F lchan occupy a dynamic timeslot that currently counts for free TCH/H timeslots? + */ + next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_F, false); + if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN) + c->target.next_tchf_reduces_tchh = 2; + else + c->target.next_tchf_reduces_tchh = 0; - /* Would the next TCH/H lchan occupy a dynamic timeslot that currently counts for free TCH/F timeslots? - * Note that a dyn TS already in TCH/H mode (half occupied) would not reduce free TCH/F. */ - next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_H, false); - if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN - && next_lchan->ts->pchan_is != GSM_PCHAN_TCH_H) - c->target.next_tchh_reduces_tchf = 1; - else + /* Would the next TCH/H lchan occupy a dynamic timeslot that currently counts for free TCH/F timeslots? + * Note that a dyn TS already in TCH/H mode (half occupied) would not reduce free TCH/F. */ + next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_H, false); + if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN + && next_lchan->ts->pchan_is != GSM_PCHAN_TCH_H) + c->target.next_tchh_reduces_tchf = 1; + else + c->target.next_tchh_reduces_tchf = 0; + } else { + + c->target.free_tchf = 0; + c->target.min_free_tchf = 0; c->target.next_tchh_reduces_tchf = 0; + c->target.free_tchh = 0; + c->target.min_free_tchh = 0; + c->target.next_tchf_reduces_tchh = 0; + } } /* add candidate for re-assignment within the current cell */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a3345ab0005a73597f5c27207480912a2f5aae6 Gerrit-Change-Number: 26352 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 14:24:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 24 Nov 2021 14:24:36 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... dbg log: abis_rsl print_meas_rep(): clarify rxlev Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb --- M src/osmo-bsc/abis_rsl.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/53/26353/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 52008a5..629d50b 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1345,7 +1345,7 @@ && log_check_level(DMEAS, LOGL_DEBUG)) { for (i = 0; i < mr->num_cell; i++) { const struct gsm_meas_rep_cell *mrc = &mr->cell[i]; - DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u => %d dBm\n", + DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u RXLEV=%ddBm\n", mrc->neigh_idx, mrc->arfcn, mrc->bsic, rxlev2dbm(mrc->rxlev)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 14:28:03 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 24 Nov 2021 14:28:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: show bug: do inter-BSC-out HO by measurement report References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 ) Change subject: bsc: show bug: do inter-BSC-out HO by measurement report ...................................................................... bsc: show bug: do inter-BSC-out HO by measurement report So far all handover tests trigger handover via VTY command. This means that any bugs introduced in measurement report handling and handover target selection are by definition not caught. Almost a year ago, fixing a handover oscillation bug for intra-BSC handover introduced a segfault for inter-BSC handover targets, because for those the target.bts is NULL. Show this bug. Related: OS#5324 SYS#5259 Related: I5a3345ab0005a73597f5c27207480912a2f5aae6 (osmo-bsc) Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d --- M bsc/BSC_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 60 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/26354/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 1f4a615..b34ad29 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5384,8 +5384,12 @@ private function f_ho_out_of_this_bsc(template (omit) BSSMAP_oldToNewBSSIEs exp_oldToNewBSSIEs := omit) runs on MSC_ConnHdlr { - f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"}); - f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any"); + var NcellReports neighbor_rep := { + { rxlev := 20, bcch_freq := 0, bsic := 11 } + }; + var octetstring l3_mr := enc_GsmRrL3Message(valueof(ts_MEAS_REP(true, 8, 8, reps := neighbor_rep))); + RSL.send(ts_RSL_MEAS_RES(g_chan_nr, 0, ts_RSL_IE_UplinkMeas, ts_RSL_IE_BS_Power(0), ts_RSL_IE_L1Info, + l3_mr, 0)); BSSAP.receive(tr_BSSMAP_HandoverRequired(exp_oldToNewBSSIEs)); @@ -5450,6 +5454,15 @@ testcase TC_ho_out_of_this_bsc() runs on test_CT { var MSC_ConnHdlr vc_conn; + f_init_vty(); + f_bts_0_cfg(BSCVTY, + {"neighbor-list mode automatic", + "handover 1", + "handover algorithm 2", + "handover2 window rxlev averaging 1", + "neighbor lac 99 arfcn 123 bsic any"}); + f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); + f_init(1, true); f_sleep(1.0); @@ -10831,7 +10844,7 @@ execute( TC_ho_int_a5_4() ); execute( TC_ho_int_radio_link_failure() ); - execute( TC_ho_out_of_this_bsc() ); + /* TC_ho_out_of_this_bsc is run last, see comment below */ execute( TC_ho_out_fail_no_msc_response() ); execute( TC_ho_out_fail_rr_ho_failure() ); execute( TC_ho_out_fail_no_result_after_ho_cmd() ); @@ -10954,6 +10967,10 @@ execute( TC_cm_serv_rej() ); execute( TC_lost_sdcch_during_assignment() ); + + /* Run TC_ho_out_of_this_bsc last, because it may trigger a segfault before osmo-bsc's patch + * with change-id I5a3345ab0005a73597f5c27207480912a2f5aae6 */ + execute( TC_ho_out_of_this_bsc() ); } } diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 1057f0b..70fb398 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -508,6 +508,13 @@ uint8_t actual_ta } + template (value) RSL_IE_L1Info ts_RSL_IE_L1Info := { + ms_power_lvl := 0, + fpc := false, + reserved := 0, + actual_ta := 0 + }; + /* 9.3.13 */ type record RSL_IE_MS_Power { uint2_t reserved, @@ -632,6 +639,19 @@ RSL_IE_UplinkMeasSuppMeasInfo supp_meas_info optional } with { variant (len) "LENGTHTO(rfu,dtx_d,rxlev_f_u,reserved1,rxlev_s_u,reserved2,rxq_f_u,rxq_s_u,supp_meas_info)" }; + template (value) RSL_IE_UplinkMeas ts_RSL_IE_UplinkMeas(uint6_t rxlev := 12, uint3_t rxqual := 0) := { + len := 0, /* overwritten */ + rfu := '0'B, + dtx_d := false, + rxlev_f_u := rxlev, + reserved1 := '00'B, + rxlev_s_u := rxlev, + reserved2 := '00'B, + rxq_f_u := rxqual, + rxq_s_u := rxqual, + supp_meas_info := omit + }; + /* 9.3.26 */ type enumerated RSL_Cause { /* normal event */ @@ -1549,6 +1569,26 @@ } } + template (value) RSL_Message ts_RSL_MEAS_RES(template (value) RslChannelNr chan_nr, + uint8_t meas_res_nr, + template (value) RSL_IE_UplinkMeas ul_meas, + template (value) RSL_IE_BS_Power bs_power, + template (value) RSL_IE_L1Info l1_info, + octetstring l3_info, + uint8_t ms_to) := { + msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), + msg_type := RSL_MT_MEAS_RES, + ies := { + t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}), + t_RSL_IE(RSL_IE_MEAS_RES_NR, RSL_IE_Body:{meas_res_nr := meas_res_nr}), + t_RSL_IE(RSL_IE_UPLINK_MEAS, RSL_IE_Body:{uplink_meas := ul_meas}), + t_RSL_IE(RSL_IE_BS_POWER, RSL_IE_Body:{bs_power := bs_power}), + t_RSL_IE(RSL_IE_L1_INFO, RSL_IE_Body:{l1_info := l1_info}), + t_RSL_IE(RSL_IE_L3_INFO, RSL_IE_Body:{l3_info := ts_RSL_L16V(l3_info)}), + t_RSL_IE(RSL_IE_MS_TIMING_OFFSET, RSL_IE_Body:{ms_timing_offset := ms_to}) + } + } + /* 8.4.9 BSC -> BTS */ template (value) RSL_Message ts_RSL_MODE_MODIFY_REQ(template (value) RslChannelNr chan_nr, template (value) RSL_IE_ChannelMode mode) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d Gerrit-Change-Number: 26354 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 15:34:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Nov 2021 15:34:42 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26350 ) Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 15:34:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 15:40:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 15:40:28 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c at 1348 PS1, Line 1348: DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u RXLEV=%ddBm\n", That's not rxlev, but RSSI afaiu. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 15:40:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 15:40:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 15:40:54 +0000 Subject: Change in osmo-bsc[master]: hodec2: fix segv for inter-BSC ho target In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26352 ) Change subject: hodec2: fix segv for inter-BSC ho target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a3345ab0005a73597f5c27207480912a2f5aae6 Gerrit-Change-Number: 26352 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 15:40:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 15:42:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 15:42:37 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: show bug: do inter-BSC-out HO by measurement report In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 ) Change subject: bsc: show bug: do inter-BSC-out HO by measurement report ...................................................................... Patch Set 1: Code-Review+1 We may want to make a patch release of osmo-bsc with the related patch. What do you think? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d Gerrit-Change-Number: 26354 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 15:42:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 16:27:24 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Nov 2021 16:27:24 +0000 Subject: Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix crash if !conn In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26350 ) Change subject: bsc_subscr_conn_fsm: fix crash if !conn ...................................................................... bsc_subscr_conn_fsm: fix crash if !conn Do not crash in gscon_ensure_mgw_endpoint() if conn is NULL. Related: SYS#5728 Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index c18079f..2140c9b 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -521,6 +521,11 @@ const char *epname; struct mgcp_client *mgcp_client = NULL; + if (!conn) { + LOG_LCHAN(for_lchan, LOGL_ERROR, "no conn!\n"); + return NULL; + } + if (conn->user_plane.mgw_endpoint) return conn->user_plane.mgw_endpoint; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id579243cc9ebbe8f315cd11754166970329dc9cf Gerrit-Change-Number: 26350 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:15:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:15:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: show bug: do inter-BSC-out HO by measurement report In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 ) Change subject: bsc: show bug: do inter-BSC-out HO by measurement report ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d Gerrit-Change-Number: 26354 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 17:15:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:15:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:15:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: show bug: do inter-BSC-out HO by measurement report In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 ) Change subject: bsc: show bug: do inter-BSC-out HO by measurement report ...................................................................... Patch Set 1: > We may want to make a patch release of osmo-bsc with the related patch. What do you think? agreed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d Gerrit-Change-Number: 26354 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 17:15:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:15:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:15:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: show bug: do inter-BSC-out HO by measurement report In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 ) Change subject: bsc: show bug: do inter-BSC-out HO by measurement report ...................................................................... bsc: show bug: do inter-BSC-out HO by measurement report So far all handover tests trigger handover via VTY command. This means that any bugs introduced in measurement report handling and handover target selection are by definition not caught. Almost a year ago, fixing a handover oscillation bug for intra-BSC handover introduced a segfault for inter-BSC handover targets, because for those the target.bts is NULL. Show this bug. Related: OS#5324 SYS#5259 Related: I5a3345ab0005a73597f5c27207480912a2f5aae6 (osmo-bsc) Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d --- M bsc/BSC_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 60 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 1f4a615..b34ad29 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5384,8 +5384,12 @@ private function f_ho_out_of_this_bsc(template (omit) BSSMAP_oldToNewBSSIEs exp_oldToNewBSSIEs := omit) runs on MSC_ConnHdlr { - f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"}); - f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any"); + var NcellReports neighbor_rep := { + { rxlev := 20, bcch_freq := 0, bsic := 11 } + }; + var octetstring l3_mr := enc_GsmRrL3Message(valueof(ts_MEAS_REP(true, 8, 8, reps := neighbor_rep))); + RSL.send(ts_RSL_MEAS_RES(g_chan_nr, 0, ts_RSL_IE_UplinkMeas, ts_RSL_IE_BS_Power(0), ts_RSL_IE_L1Info, + l3_mr, 0)); BSSAP.receive(tr_BSSMAP_HandoverRequired(exp_oldToNewBSSIEs)); @@ -5450,6 +5454,15 @@ testcase TC_ho_out_of_this_bsc() runs on test_CT { var MSC_ConnHdlr vc_conn; + f_init_vty(); + f_bts_0_cfg(BSCVTY, + {"neighbor-list mode automatic", + "handover 1", + "handover algorithm 2", + "handover2 window rxlev averaging 1", + "neighbor lac 99 arfcn 123 bsic any"}); + f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); + f_init(1, true); f_sleep(1.0); @@ -10831,7 +10844,7 @@ execute( TC_ho_int_a5_4() ); execute( TC_ho_int_radio_link_failure() ); - execute( TC_ho_out_of_this_bsc() ); + /* TC_ho_out_of_this_bsc is run last, see comment below */ execute( TC_ho_out_fail_no_msc_response() ); execute( TC_ho_out_fail_rr_ho_failure() ); execute( TC_ho_out_fail_no_result_after_ho_cmd() ); @@ -10954,6 +10967,10 @@ execute( TC_cm_serv_rej() ); execute( TC_lost_sdcch_during_assignment() ); + + /* Run TC_ho_out_of_this_bsc last, because it may trigger a segfault before osmo-bsc's patch + * with change-id I5a3345ab0005a73597f5c27207480912a2f5aae6 */ + execute( TC_ho_out_of_this_bsc() ); } } diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 1057f0b..70fb398 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -508,6 +508,13 @@ uint8_t actual_ta } + template (value) RSL_IE_L1Info ts_RSL_IE_L1Info := { + ms_power_lvl := 0, + fpc := false, + reserved := 0, + actual_ta := 0 + }; + /* 9.3.13 */ type record RSL_IE_MS_Power { uint2_t reserved, @@ -632,6 +639,19 @@ RSL_IE_UplinkMeasSuppMeasInfo supp_meas_info optional } with { variant (len) "LENGTHTO(rfu,dtx_d,rxlev_f_u,reserved1,rxlev_s_u,reserved2,rxq_f_u,rxq_s_u,supp_meas_info)" }; + template (value) RSL_IE_UplinkMeas ts_RSL_IE_UplinkMeas(uint6_t rxlev := 12, uint3_t rxqual := 0) := { + len := 0, /* overwritten */ + rfu := '0'B, + dtx_d := false, + rxlev_f_u := rxlev, + reserved1 := '00'B, + rxlev_s_u := rxlev, + reserved2 := '00'B, + rxq_f_u := rxqual, + rxq_s_u := rxqual, + supp_meas_info := omit + }; + /* 9.3.26 */ type enumerated RSL_Cause { /* normal event */ @@ -1549,6 +1569,26 @@ } } + template (value) RSL_Message ts_RSL_MEAS_RES(template (value) RslChannelNr chan_nr, + uint8_t meas_res_nr, + template (value) RSL_IE_UplinkMeas ul_meas, + template (value) RSL_IE_BS_Power bs_power, + template (value) RSL_IE_L1Info l1_info, + octetstring l3_info, + uint8_t ms_to) := { + msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), + msg_type := RSL_MT_MEAS_RES, + ies := { + t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}), + t_RSL_IE(RSL_IE_MEAS_RES_NR, RSL_IE_Body:{meas_res_nr := meas_res_nr}), + t_RSL_IE(RSL_IE_UPLINK_MEAS, RSL_IE_Body:{uplink_meas := ul_meas}), + t_RSL_IE(RSL_IE_BS_POWER, RSL_IE_Body:{bs_power := bs_power}), + t_RSL_IE(RSL_IE_L1_INFO, RSL_IE_Body:{l1_info := l1_info}), + t_RSL_IE(RSL_IE_L3_INFO, RSL_IE_Body:{l3_info := ts_RSL_L16V(l3_info)}), + t_RSL_IE(RSL_IE_MS_TIMING_OFFSET, RSL_IE_Body:{ms_timing_offset := ms_to}) + } + } + /* 8.4.9 BSC -> BTS */ template (value) RSL_Message ts_RSL_MODE_MODIFY_REQ(template (value) RslChannelNr chan_nr, template (value) RSL_IE_ChannelMode mode) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba033c32015173f57dbb1c211aefab1a9094e29d Gerrit-Change-Number: 26354 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:16:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:16:27 +0000 Subject: Change in osmo-bts[master]: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26351 ) Change subject: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() ...................................................................... Patch Set 1: this also warrants a patch release of osmo-bts :( -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Gerrit-Change-Number: 26351 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 17:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:16:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:16:56 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 24 Nov 2021 17:16:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:17:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:17:00 +0000 Subject: Change in pysim[master]: pySim-read: put try/catch block around select_adf_by_aid() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26253 ) Change subject: pySim-read: put try/catch block around select_adf_by_aid() ...................................................................... pySim-read: put try/catch block around select_adf_by_aid() Selecting an application may fail, especially when the application does not exist on the card. Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef --- M pySim-read.py 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim-read.py b/pySim-read.py index 959a7c5..5e48116 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -34,6 +34,7 @@ from pySim.commands import SimCardCommands from pySim.transport import init_reader, argparse_add_reader_args +from pySim.exceptions import SwMatchError from pySim.cards import card_detect, SimCard, UsimCard, IsimCard from pySim.utils import h2b, swap_nibbles, rpad, dec_imsi, dec_iccid, dec_msisdn from pySim.utils import format_xplmn_w_act, dec_st @@ -44,6 +45,24 @@ formatter_class=argparse.ArgumentDefaultsHelpFormatter) argparse_add_reader_args(option_parser) +def select_app(adf:str, card:SimCard): + """Select application by its AID""" + sw = 0 + try: + if card._scc.cla_byte == "00": + data, sw = card.select_adf_by_aid(adf) + except SwMatchError as e: + if e.sw_actual == "6a82": + # If we can't select the file because it does not exist, we just remain silent since it means + # that this card just does not have an USIM application installed, which is not an error. + pass + else: + print("ADF." + adf + ": Can't select application -- " + str(e)) + except Exception as e: + print("ADF." + adf + ": Can't select application -- " + str(e)) + + return sw + if __name__ == '__main__': # Parse options @@ -219,7 +238,7 @@ # Check whether we have th AID of USIM, if so select it by its AID # EF.UST - File Id in ADF USIM : 6f38 - data, sw = card.select_adf_by_aid(adf="usim") + sw = select_app("USIM", card) if sw == '9000': # Select USIM profile usim_card = UsimCard(scc) @@ -269,7 +288,7 @@ print("ePDGSelection: Can't read file -- " + str(e)) # Select ISIM application by its AID - data, sw = card.select_adf_by_aid(adf="isim") + sw = select_app("ISIM", card) if sw == '9000': # Select USIM profile isim_card = IsimCard(scc) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia904a74d672cf9551fb4ee062dd606b350b64cef Gerrit-Change-Number: 26253 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:17:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:17:01 +0000 Subject: Change in pysim[master]: cards: Make select_adf_by_aid() use prefix AID selection In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/25873 ) Change subject: cards: Make select_adf_by_aid() use prefix AID selection ...................................................................... cards: Make select_adf_by_aid() use prefix AID selection There is no need for us to expand a partial AID to the full AID before selecting that ADF. The UICC specifications permit AID selection by prefix only. So we could pass the prefix to the card, and the card would do the prefix matching. In order to avoid problems with cards that fail to do the prefix matching themselves we will still do the AID completion, but in case we cannot complete the AID (AID not listed in EF.DIR), we will try with the AID prefix anyway. >From the API user point of view, this allows us to select applications not listed in EF.DIR Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 --- M pySim/cards.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/cards.py b/pySim/cards.py index a822161..45e44a2 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -308,6 +308,9 @@ aid_full = self._complete_aid(aid) if aid_full: return self._scc.select_adf(aid_full) + else: + # If we cannot get the full AID, try with short AID + return self._scc.select_adf(aid) return (None, None) def erase_binary(self, ef): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0747b4e46ca7e30bd96d76053765080367ac1317 Gerrit-Change-Number: 25873 Gerrit-PatchSet: 12 Gerrit-Owner: laforge Gerrit-Assignee: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:18:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:18:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 ) Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 17:18:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:21:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:21:04 +0000 Subject: Change in osmo-hnodeb[master]: Introduce iuh log category In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 ) Change subject: Introduce iuh log category ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > not sure if it shouldn't be simply SCTP? Iuh includes HNBAP, RANAP, RUA, GTPv1U, RTP and IuUP, so it is a bit broad a term for a log category, IMHO > > SCTP looks even more generic to me. At least for Iuh one knows it's mostly related to the conn HNB->HNBGW. I don't have a strong opinion though. SCTP means (in my point of view) "SCTP only". It doesn't include whatever may be the payload. SCTP doesn't specify a group or sub-tree of protocols but one specific layer. And the messages you are putting into the new category in this patch all related to the use of the SCTP sockets interface, so I think it's better. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 17:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:26:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 17:26:59 +0000 Subject: Change in simtrace2[master]: firmware: remove dfu-dfu default target In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26337 ) Change subject: firmware: remove dfu-dfu default target ...................................................................... firmware: remove dfu-dfu default target It's useless, since blupdate does the same thing, just much faster and easier. Change-Id: I86dddfacea2e35f4d5a7f23ee4b3d12e3f1d35f1 --- M firmware/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/Makefile b/firmware/Makefile index f6e8316..c30dc9a 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -49,7 +49,7 @@ # Defines which are the available memory targets for the SAM3S-EK board. ifeq ($(APP), dfu) -MEMORIES ?= flash dfu +MEMORIES ?= flash TRACE_LEVEL ?= 0 else MEMORIES ?= dfu -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I86dddfacea2e35f4d5a7f23ee4b3d12e3f1d35f1 Gerrit-Change-Number: 26337 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 17:52:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 17:52:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnb: Introduce HNB_Tests testsuite In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 ) Change subject: hnb: Introduce HNB_Tests testsuite ...................................................................... hnb: Introduce HNB_Tests testsuite A new Iuh CodecPort + Emulation is introduced to (de)mux RANAP and RUA in the same SCTP socket. The Iuh_CodecPort.ttcn file has currently a hack to be able to test HNBAP, since titan seem to be reporting sinfo_ppid=0 when in fact it received sinfo_ppid=20 (HNBAP). A couple tests are added to validate HNBAP HNBRegister Request + Accept or Reject. In current osmo-hnodeb state, both tests pass if run separately, but fail if run sequentially since osmo-hnodeb still doesn't re-connect properly after first test finishes and connection is dropped. Related: SYS#5516 Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 --- M Makefile A hnodeb/HNBGW_ConnectionHandler.ttcn A hnodeb/HNB_Tests.cfg A hnodeb/HNB_Tests.default A hnodeb/HNB_Tests.ttcn A hnodeb/README.md A hnodeb/README.txt A hnodeb/expected-results.xml A hnodeb/gen_links.sh A hnodeb/osmo-hnodeb.cfg A hnodeb/regen_makefile.sh A library/Iuh_CodecPort.ttcn A library/Iuh_CodecPort_CtrlFunct.ttcn A library/Iuh_CodecPort_CtrlFunctDef.cc A library/Iuh_Emulation.ttcn A library/Iuh_Types.ttcn A library/hnbap/HNBAP_Templates.ttcn A library/rua/RUA_Templates.ttcn 18 files changed, 1,196 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile b/Makefile index 0567081..f05ab48 100644 --- a/Makefile +++ b/Makefile @@ -24,6 +24,7 @@ gbproxy \ ggsn_tests \ hlr \ + hnodeb \ mgw \ mme \ msc \ diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn new file mode 100644 index 0000000..071e3e8 --- /dev/null +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -0,0 +1,112 @@ +module HNBGW_ConnectionHandler { + +/* HNBGW Connection Handler of HNB_Tests in TTCN-3 + * (C) 2021 by sysmocom - s.m.f.c. GmbH + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +import from Misc_Helpers all; +import from General_Types all; +import from Osmocom_Types all; +import from IPL4asp_Types all; +import from Native_Functions all; + +import from SDP_Types all; + +import from StatsD_Checker all; + +import from TELNETasp_PortType all; +import from Osmocom_VTY_Functions all; + +import from HNBAP_Templates all; + +import from Iuh_Emulation all; + +/* this component represents a single Iuh connection at the HNBGW. */ +type component HNBGW_ConnHdlr extends StatsD_ConnHdlr { + port TELNETasp_PT HNBVTY; + port HNBAP_PT HNBAP; + port RUA_PT RUA; + var TestHdlrParams g_pars; + + var boolean g_vty_initialized := false; +} + +function f_HNBGW_ConnHdlr_init_vty() runs on HNBGW_ConnHdlr { + if (not g_vty_initialized) { + map(self:HNBVTY, system:HNBVTY); + f_vty_set_prompts(HNBVTY); + f_vty_transceive(HNBVTY, "enable"); + g_vty_initialized := true; + } +} + +/* initialize all parameters */ +function f_HNBGW_ConnHdlr_init(TestHdlrParams pars) runs on HNBGW_ConnHdlr { + var integer i := 0; + var Iuh_Emulation_CT vc_Iuh; + + g_pars := valueof(pars); + vc_Iuh := Iuh_Emulation_CT.create("HNBGW" & int2str(i)); + connect(self:HNBAP, vc_Iuh:HNBAP); + connect(self:RUA, vc_Iuh:RUA); + + var Iuh_conn_parameters iuh_pars; + iuh_pars.remote_ip := g_pars.hnodeb_addr; + iuh_pars.remote_sctp_port := -1; + iuh_pars.local_ip := g_pars.hnbgw_addr; + iuh_pars.local_sctp_port := g_pars.hnbgw_port; + vc_Iuh.start(Iuh_Emulation.main(iuh_pars, "Iuh" & int2str(i))); + + f_HNBGW_ConnHdlr_init_vty(); +} + +type record TestHdlrParams { + charstring hnbgw_addr, + charstring hnodeb_addr, + integer hnbgw_port, + uint16_t rnc_id, + charstring hNB_Identity_Info, + OCT3 plmnid, + uint32_t cell_identity, + uint16_t lac, + uint8_t rac, + uint8_t sac +}; + +/* Note: Do not use valueof() to get a value of this template, use + * f_gen_test_hdlr_pars() instead in order to get a configuration. */ +template (value) TestHdlrParams t_def_TestHdlrPars := { + hnbgw_addr := "127.0.0.1", + hnodeb_addr := "127.0.0.1", + hnbgw_port := 29169, + rnc_id := 23, + hNB_Identity_Info := "OsmoHNodeB", + plmnid := '00F110'O, + cell_identity := 1, + lac := 2, + rac := 3, + sac := 4 +} + + +function f_handle_hnbap_hnb_register_req() +runs on HNBGW_ConnHdlr { + HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), + g_pars.plmnid, + int2bit(g_pars.cell_identity, 28), + int2oct(g_pars.lac, 2), + int2oct(g_pars.rac, 1), + int2oct(g_pars.sac, 2) + )); + HNBAP.send(ts_HNBAP_HNBRegisterAccept(g_pars.rnc_id)); +} + + + +} diff --git a/hnodeb/HNB_Tests.cfg b/hnodeb/HNB_Tests.cfg new file mode 100644 index 0000000..38d9cc7 --- /dev/null +++ b/hnodeb/HNB_Tests.cfg @@ -0,0 +1,18 @@ +[ORDERED_INCLUDE] +# Common configuration, shared between test suites +"../Common.cfg" +# testsuite specific configuration, not expected to change +"./HNB_Tests.default" + +# Local configuration below + +[LOGGING] + +[TESTPORT_PARAMETERS] + +[MODULE_PARAMETERS] + +[MAIN_CONTROLLER] + +[EXECUTE] +HNB_Tests.control diff --git a/hnodeb/HNB_Tests.default b/hnodeb/HNB_Tests.default new file mode 100644 index 0000000..a06dcc6 --- /dev/null +++ b/hnodeb/HNB_Tests.default @@ -0,0 +1,27 @@ +[LOGGING] +mtc.FileMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING | DEBUG_ENCDEC; + +[TESTPORT_PARAMETERS] +*.HNBVTY.CTRL_MODE := "client" +*.HNBVTY.CTRL_HOSTNAME := "127.0.0.1" +*.HNBVTY.CTRL_PORTNUM := "4273" +*.HNBVTY.CTRL_LOGIN_SKIPPED := "yes" +*.HNBVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.HNBVTY.CTRL_READMODE := "buffered" +*.HNBVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.HNBVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.HNBVTY.PROMPT1 := "OsmoHNodeB> " +*.STATSVTY.CTRL_MODE := "client" +*.STATSVTY.CTRL_HOSTNAME := "127.0.0.1" +*.STATSVTY.CTRL_PORTNUM := "4274" +*.STATSVTY.CTRL_LOGIN_SKIPPED := "yes" +*.STATSVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.STATSVTY.CTRL_READMODE := "buffered" +*.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.STATSVTY.PROMPT1 := "OsmoHNodeB> " + +[MODULE_PARAMETERS] +Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoHNodeB"; + +[EXECUTE] diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn new file mode 100644 index 0000000..7a668dd --- /dev/null +++ b/hnodeb/HNB_Tests.ttcn @@ -0,0 +1,214 @@ +module HNB_Tests { + +/* Integration Tests for OsmoHNodeB + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + * + * This test suite tests OsmoHNodB while emulating both multiple UE as + * well as the HNBGW. See README for more details. + * + * There are test cases that run in so-called 'handler mode' and test cases + * that run directly on top of the BSSAP and RSL CodecPorts. The "handler mode" + * tests abstract the multiplexing/demultiplexing of multiple SCCP connections + * and/or RSL channels and are hence suitable for higher-level test cases, while + * the "raw" tests directly on top of the CodecPorts are more suitable for lower- + * level testing. + */ + +import from Misc_Helpers all; +import from General_Types all; +import from Osmocom_Types all; +import from IPL4asp_Types all; + +import from Osmocom_CTRL_Functions all; +import from Osmocom_CTRL_Types all; +import from Osmocom_CTRL_Adapter all; + +import from StatsD_Types all; +import from StatsD_CodecPort all; +import from StatsD_CodecPort_CtrlFunct all; +import from StatsD_Checker all; + +import from Osmocom_VTY_Functions all; +import from TELNETasp_PortType all; + +import from HNBAP_Templates all; + +import from HNBGW_ConnectionHandler all; +import from Iuh_Emulation all; + +modulepar { + /* IP address at which the HNodeB can be reached */ + charstring mp_hnodeb_ip := "127.0.0.1"; + + /* IP address at which the test binds */ + charstring mp_hnbgw_iuh_ip := "127.0.0.1"; + integer mp_hnbgw_iuh_port := 29169; +} + +type component test_CT extends CTRL_Adapter_CT { + port TELNETasp_PT HNBVTY; + + /* global test case guard timer (actual timeout value is set in f_init()) */ + timer T_guard := 30.0; +} + +/* global altstep for global guard timer; */ +altstep as_Tguard() runs on test_CT { + [] T_guard.timeout { + setverdict(fail, "Timeout of T_guard"); + mtc.stop; + } +} + +friend function f_logp(TELNETasp_PT pt, charstring log_msg) +{ + // log on TTCN3 log output + log(log_msg); + // log in stderr log + f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); +} + +function f_init_vty(charstring id := "foo") runs on test_CT { + if (HNBVTY.checkstate("Mapped")) { + /* skip initialization if already executed once */ + return; + } + map(self:HNBVTY, system:HNBVTY); + f_vty_set_prompts(HNBVTY); + f_vty_transceive(HNBVTY, "enable"); +} +/* global initialization function */ +function f_init(float guard_timeout := 30.0) runs on test_CT { + var integer bssap_idx; + + T_guard.start(guard_timeout); + activate(as_Tguard()); + + f_init_vty("VirtHNBGW"); + + /* TODO: Wait for Iuh connection to be established */ +} + +friend function f_shutdown_helper() runs on test_CT { + all component.stop; + setverdict(pass); + mtc.stop; +} + +friend function f_gen_test_hdlr_pars() return TestHdlrParams { + + var TestHdlrParams pars := valueof(t_def_TestHdlrPars); + pars.hnodeb_addr := mp_hnodeb_ip; + pars.hnbgw_addr := mp_hnbgw_iuh_ip; + pars.hnbgw_port := mp_hnbgw_iuh_port; + return pars; +} + +type function void_fn(charstring id) runs on HNBGW_ConnHdlr; + +/* helper function to create and connect a HNBGW_ConnHdlr component */ +private function f_connect_handler(inout HNBGW_ConnHdlr vc_conn, integer bssap_idx := 0) runs on test_CT { + /*connect(vc_conn:RAN, g_bssap[bssap_idx].vc_RAN:PROC); + connect(vc_conn:MGCP_PROC, vc_MGCP:MGCP_PROC); + connect(vc_conn:RSL, bts[0].rsl.vc_RSL:CLIENT_PT); + connect(vc_conn:RSL_PROC, bts[0].rsl.vc_RSL:RSL_PROC); + if (isvalue(bts[1])) { + connect(vc_conn:RSL1, bts[1].rsl.vc_RSL:CLIENT_PT); + connect(vc_conn:RSL1_PROC, bts[1].rsl.vc_RSL:RSL_PROC); + } + if (isvalue(bts[2])) { + connect(vc_conn:RSL2, bts[2].rsl.vc_RSL:CLIENT_PT); + connect(vc_conn:RSL2_PROC, bts[2].rsl.vc_RSL:RSL_PROC); + } + connect(vc_conn:BSSAP, g_bssap[bssap_idx].vc_RAN:CLIENT); + if (mp_enable_lcs_tests) { + connect(vc_conn:BSSAP_LE, g_bssap_le.vc_BSSAP_LE:CLIENT); + connect(vc_conn:BSSAP_LE_PROC, g_bssap_le.vc_BSSAP_LE:PROC); + } + connect(vc_conn:MGCP, vc_MGCP:MGCP_CLIENT); + connect(vc_conn:MGCP_MULTI, vc_MGCP:MGCP_CLIENT_MULTI); + connect(vc_conn:STATSD_PROC, vc_STATSD:STATSD_PROC);*/ +} + +function f_start_handler_create(TestHdlrParams pars) +runs on test_CT return HNBGW_ConnHdlr { + var charstring id := testcasename(); + var HNBGW_ConnHdlr vc_conn; + vc_conn := HNBGW_ConnHdlr.create(id); + f_connect_handler(vc_conn); + return vc_conn; +} + +function f_start_handler_run(HNBGW_ConnHdlr vc_conn, void_fn fn, TestHdlrParams pars) +runs on test_CT return HNBGW_ConnHdlr { + var charstring id := testcasename(); + /* Emit a marker to appear in the SUT's own logging output */ + f_logp(HNBVTY, id & "() start"); + vc_conn.start(f_handler_init(fn, id, pars)); + return vc_conn; +} + +function f_start_handler(void_fn fn, template (omit) TestHdlrParams pars_tmpl := omit) +runs on test_CT return HNBGW_ConnHdlr { + var TestHdlrParams pars; + if (isvalue(pars)) { + pars := valueof(pars_tmpl); + } else { + pars := valueof(f_gen_test_hdlr_pars()); + } + return f_start_handler_run(f_start_handler_create(pars), fn, pars); +} + +/* first function inside ConnHdlr component; sets g_pars + starts function */ +private function f_handler_init(void_fn fn, charstring id, TestHdlrParams pars) +runs on HNBGW_ConnHdlr { + f_HNBGW_ConnHdlr_init(pars); + HNBAP.receive(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* Wait for HNB to connect to us */ + fn.apply(id); +} + +private function f_tc_hnb_register_request(charstring id) runs on HNBGW_ConnHdlr { + f_handle_hnbap_hnb_register_req(); + f_sleep(1.0); +} +testcase TC_hnb_register_request_accept() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_hnb_register_request)); + vc_conn.done; + f_shutdown_helper(); +} + +private function f_tc_hnb_register_reject(charstring id) runs on HNBGW_ConnHdlr { + HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), + g_pars.plmnid, + int2bit(g_pars.cell_identity, 28), + int2oct(g_pars.lac, 2), + int2oct(g_pars.rac, 1), + int2oct(g_pars.sac, 2) + )); + HNBAP.send(ts_HNBAP_HNBRegisterReject(ts_HnbapCause(overload))); + f_sleep(1.0); +} +testcase TC_hnb_register_request_reject() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_hnb_register_reject)); + vc_conn.done; + f_shutdown_helper(); +} + +control { + execute( TC_hnb_register_request_accept() ); + execute( TC_hnb_register_request_reject() ); +} + +} diff --git a/hnodeb/README.md b/hnodeb/README.md new file mode 100644 index 0000000..3b3fa9f --- /dev/null +++ b/hnodeb/README.md @@ -0,0 +1,30 @@ +# HNB_Tests.ttcn + +* external interfaces + * Iuh side (emulates HNBGW-side) + * SCTP/HNBAP + * SCTP/RUA/RANAP + * RTP side: emulates MGW + * GTP-U side: emulates GGSN + * UE side + * VTY + * CTRL + * StatsD + +{% dot hnb_tests.svg +digraph G { + graph [label="HNB_Tests", labelloc=t, fontsize=30]; + rankdir=LR; + { rank=same; ATS; HNB; }; + HNB [label="IUT\nosmo-bsc",shape="box"]; + ATS [label="ATS\nHNB_Tests.ttcn"]; + + HNB <- ATS [label="Uu (or some intermediate lower layer)"]; + HNB -> ATS [label="Iuh"]; + HNB -> ATS [label="RTP"]; + HNB -> ATS [label="GTP-U"]; + HNB <- ATS [label="CTRL"]; + HNB <- ATS [label="VTY"]; + HNB -> ATS [label="StatsD"]; +} +%} diff --git a/hnodeb/README.txt b/hnodeb/README.txt new file mode 100644 index 0000000..1cf81ee --- /dev/null +++ b/hnodeb/README.txt @@ -0,0 +1,32 @@ +Integration Tests for OsmoHnodeB +-------------------------------- + +This test suite tests OsmoHNodeB while emulating both multiple UE as +well as the HNBGW. + +The included jenkins.sh script, together with the Dockerfiles from +http://git.osmocom.org/docker-playground/ can be used to run both the +osmo-hnodeb-under-test as well as the extenal entities and the tester. + + +Further Test Ideas +------------------ + +This is a random list of things about things possible to test. +Asterisks '*' are TODO, while 'x' means already implemented. + += exhaustion of resources + += paging + += assignment + += hand-over + += erroneous channel release + += misc + += counters + += VTY based/corresponding tests diff --git a/hnodeb/expected-results.xml b/hnodeb/expected-results.xml new file mode 100644 index 0000000..39cea9f --- /dev/null +++ b/hnodeb/expected-results.xml @@ -0,0 +1,4 @@ + + + + diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh new file mode 100755 index 0000000..ba946e8 --- /dev/null +++ b/hnodeb/gen_links.sh @@ -0,0 +1,60 @@ +#!/bin/bash + +BASEDIR=../deps + +. ../gen_links.sh.inc + +#DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src +#FILES="UD_PT.cc UD_PT.hh UD_PortType.ttcn UD_Types.ttcn" +#gen_links $DIR $FILES + +DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src +FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn TCCConversion.cc TCCInterface.cc TCCInterface_ip.h" +FILES+=" TCCEncoding_Functions.ttcn TCCEncoding.cc " # GSM 7-bit coding +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src +FILES="Socket_API_Definitions.ttcn" +gen_links $DIR $FILES + +# Required by MGCP and IPA +DIR=$BASEDIR/titan.TestPorts.IPL4asp/src +FILES="IPL4asp_Functions.ttcn IPL4asp_PT.cc IPL4asp_PT.hh IPL4asp_PortType.ttcn IPL4asp_Types.ttcn IPL4asp_discovery.cc IPL4asp_protocol_L234.hh" +gen_links $DIR $FILES + +# required by M3UA_Emulation +DIR=$BASEDIR/titan.TestPorts.SCTPasp/src +FILES="SCTPasp_PT.cc SCTPasp_PT.hh SCTPasp_PortType.ttcn SCTPasp_Types.ttcn" +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.ProtocolModules.SDP/src +FILES="SDP_EncDec.cc SDP_Types.ttcn SDP_parse_.tab.c SDP_parse_.tab.h SDP_parse_parser.h SDP_parser.l +SDP_parser.y lex.SDP_parse_.c" +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.ProtocolModules.RTP/src +FILES="RTP_EncDec.cc RTP_Types.ttcn" +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.TestPorts.TELNETasp/src +FILES="TELNETasp_PT.cc TELNETasp_PT.hh TELNETasp_PortType.ttcn" +gen_links $DIR $FILES + +DIR=../library/hnbap +FILES="HNBAP_CommonDataTypes.asn HNBAP_Constants.asn HNBAP_Containers.asn HNBAP_IEs.asn HNBAP_PDU_Contents.asn HNBAP_PDU_Descriptions.asn " +FILES+="HNBAP_EncDec.cc HNBAP_Types.ttcn HNBAP_Templates.ttcn " +gen_links $DIR $FILES + +DIR=../library/rua +FILES="RUA_CommonDataTypes.asn RUA_Constants.asn RUA_Containers.asn RUA_IEs.asn RUA_PDU_Contents.asn RUA_PDU_Descriptions.asn " +FILES+="RUA_EncDec.cc RUA_Types.ttcn RUA_Templates.ttcn " +gen_links $DIR $FILES + +DIR=../library +FILES="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " +FILES+="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn " +FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " + +gen_links $DIR $FILES + +ignore_pp_results diff --git a/hnodeb/osmo-hnodeb.cfg b/hnodeb/osmo-hnodeb.cfg new file mode 100644 index 0000000..3ccd4b4 --- /dev/null +++ b/hnodeb/osmo-hnodeb.cfg @@ -0,0 +1,19 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category-hex 0 + logging print category 1 + logging print extended-timestamp 1 + logging print file basename + logging level set-all debug +line vty + no login +! +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 127.0.0.1 + remote-ip 127.0.0.1 diff --git a/hnodeb/regen_makefile.sh b/hnodeb/regen_makefile.sh new file mode 100755 index 0000000..9ebfaf2 --- /dev/null +++ b/hnodeb/regen_makefile.sh @@ -0,0 +1,35 @@ +#!/bin/sh + +NAME=HNB_Tests + +FILES=" + *.asn + *.c + *.ttcn + *.ttcnpp + IPA_CodecPort_CtrlFunctDef.cc + IPL4asp_PT.cc + IPL4asp_discovery.cc + IuUP_EncDec.cc + Iuh_CodecPort_CtrlFunctDef.cc + Native_FunctionDefs.cc + RTP_CodecPort_CtrlFunctDef.cc + RTP_EncDec.cc + SCTPasp_PT.cc + SDP_EncDec.cc + StatsD_CodecPort_CtrlFunctdef.cc + TCCConversion.cc + TCCEncoding.cc + TCCInterface.cc + TELNETasp_PT.cc + HNBAP_EncDec.cc + RUA_EncDec.cc +" + +export CPPFLAGS_TTCN3=" + -DIPA_EMULATION_CTRL +" + +../regen-makefile.sh -e $NAME $FILES + +sed -i -e 's/^LINUX_LIBS = -lxml2 -lsctp/LINUX_LIBS = -lxml2 -lsctp -lfftranscode/' Makefile diff --git a/library/Iuh_CodecPort.ttcn b/library/Iuh_CodecPort.ttcn new file mode 100644 index 0000000..569a27f --- /dev/null +++ b/library/Iuh_CodecPort.ttcn @@ -0,0 +1,141 @@ +module Iuh_CodecPort { + +/* Simple Iuh Codec Port, translating between raw SCTP primitives with + * octetstring payload towards the IPL4asp provider, and Iuh primitives + * which carry the decoded Iuh data types as payload. + * + * (C) 2021 by sysmocom s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + + import from IPL4asp_PortType all; + import from IPL4asp_Types all; + import from HNBAP_PDU_Descriptions all; + import from HNBAP_Types all; + import from RUA_PDU_Descriptions all; + import from RUA_Types all; + import from Iuh_Types all; + + type record Iuh_RecvFrom { + ConnectionId connId, + HostName remName, + PortNumber remPort, + HostName locName, + PortNumber locPort, + Iuh_PDU msg + }; + + template Iuh_RecvFrom t_Iuh_RecvFrom(template Iuh_PDU msg) := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := msg + } + + template Iuh_RecvFrom t_Iuh_RecvFrom_HNBAP(template HNBAP_PDU hnbap_msg := ?) := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := { + hnbap := hnbap_msg + } + } + + template Iuh_RecvFrom t_Iuh_RecvFrom_RUA(template RUA_PDU rua_msg := ?) := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := { + rua := rua_msg + } + } + + type record Iuh_Send { + ConnectionId connId, + Iuh_PDU msg + }; + + template Iuh_Send t_Iuh_Send_HNBAP(template ConnectionId connId, template HNBAP_PDU hnbap_msg) := { + connId := connId, + msg := { + hnbap := hnbap_msg + } + } + + template Iuh_Send t_Iuh_Send_RUA(template ConnectionId connId, template RUA_PDU rua_msg) := { + connId := connId, + msg := { + rua := rua_msg + } + } + + private function IPL4_to_Iuh_RecvFrom(in ASP_RecvFrom pin, out Iuh_RecvFrom pout) { + pout.connId := pin.connId; + pout.remName := pin.remName; + pout.remPort := pin.remPort; + pout.locName := pin.locName; + pout.locPort := pin.locPort; + select (pin.proto.sctp.sinfo_ppid) { + case (19) { + pout.msg.rua := dec_RUA_PDU(pin.msg); + } + case (20) { + pout.msg.hnbap := dec_HNBAP_PDU(pin.msg); + } + case (0) { + /* FIXME: lower layers report sinfo_ppid=0: */ + pout.msg.hnbap := dec_HNBAP_PDU(pin.msg); + } + case else { + pout.msg.payload := pin.msg; + } + } + } with { extension "prototype(fast)" }; + + private function Iuh_to_IPL4_Send(in Iuh_Send pin, out ASP_Send pout) { + var integer sctp_ppid; + if (ischosen(pin.msg.rua)) { + sctp_ppid := 19; + pout.msg := enc_RUA_PDU(pin.msg.rua); + } else if (ischosen(pin.msg.hnbap)) { + sctp_ppid := 20; + pout.msg := enc_HNBAP_PDU(pin.msg.hnbap); + } else { /*TODO: abort?*/ + sctp_ppid := 0; + pout.msg := pin.msg.payload; + } + pout.connId := pin.connId; + pout.proto := { + sctp := { + sinfo_stream := omit, + sinfo_ppid := sctp_ppid, + remSocks := omit, + assocId := omit + } + }; + } with { extension "prototype(fast)" }; + + type port Iuh_CODEC_PT message { + out Iuh_Send; + in Iuh_RecvFrom, + ASP_ConnId_ReadyToRelease, + ASP_Event; + } with { extension "user IPL4asp_PT + out(Iuh_Send -> ASP_Send:function(Iuh_to_IPL4_Send)) + in(ASP_RecvFrom -> Iuh_RecvFrom: function(IPL4_to_Iuh_RecvFrom); + ASP_ConnId_ReadyToRelease -> ASP_ConnId_ReadyToRelease: simple; + ASP_Event -> ASP_Event: simple)" + } +} diff --git a/library/Iuh_CodecPort_CtrlFunct.ttcn b/library/Iuh_CodecPort_CtrlFunct.ttcn new file mode 100644 index 0000000..c0c7003 --- /dev/null +++ b/library/Iuh_CodecPort_CtrlFunct.ttcn @@ -0,0 +1,43 @@ +module Iuh_CodecPort_CtrlFunct { + + import from Iuh_CodecPort all; + import from IPL4asp_Types all; + + external function f_IPL4_listen( + inout Iuh_CODEC_PT portRef, + in HostName locName, + in PortNumber locPort, + in ProtoTuple proto, + in OptionList options := {} + ) return Result; + + external function f_IPL4_connect( + inout Iuh_CODEC_PT portRef, + in HostName remName, + in PortNumber remPort, + in HostName locName, + in PortNumber locPort, + in ConnectionId connId, + in ProtoTuple proto, + in OptionList options := {} + ) return Result; + + external function f_IPL4_close( + inout Iuh_CODEC_PT portRef, + in ConnectionId id, + in ProtoTuple proto := { unspecified := {} } + ) return Result; + + external function f_IPL4_setUserData( + inout Iuh_CODEC_PT portRef, + in ConnectionId id, + in UserData userData + ) return Result; + + external function f_IPL4_getUserData( + inout Iuh_CODEC_PT portRef, + in ConnectionId id, + out UserData userData + ) return Result; + +} diff --git a/library/Iuh_CodecPort_CtrlFunctDef.cc b/library/Iuh_CodecPort_CtrlFunctDef.cc new file mode 100644 index 0000000..2f08dec --- /dev/null +++ b/library/Iuh_CodecPort_CtrlFunctDef.cc @@ -0,0 +1,55 @@ +#include "IPL4asp_PortType.hh" +#include "Iuh_CodecPort.hh" +#include "IPL4asp_PT.hh" + +namespace Iuh__CodecPort__CtrlFunct { + + IPL4asp__Types::Result f__IPL4__listen( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::HostName& locName, + const IPL4asp__Types::PortNumber& locPort, + const IPL4asp__Types::ProtoTuple& proto, + const IPL4asp__Types::OptionList& options) + { + return f__IPL4__PROVIDER__listen(portRef, locName, locPort, proto, options); + } + + IPL4asp__Types::Result f__IPL4__connect( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::HostName& remName, + const IPL4asp__Types::PortNumber& remPort, + const IPL4asp__Types::HostName& locName, + const IPL4asp__Types::PortNumber& locPort, + const IPL4asp__Types::ConnectionId& connId, + const IPL4asp__Types::ProtoTuple& proto, + const IPL4asp__Types::OptionList& options) + { + return f__IPL4__PROVIDER__connect(portRef, remName, remPort, + locName, locPort, connId, proto, options); + } + + IPL4asp__Types::Result f__IPL4__close( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::ConnectionId& connId, + const IPL4asp__Types::ProtoTuple& proto) + { + return f__IPL4__PROVIDER__close(portRef, connId, proto); + } + + IPL4asp__Types::Result f__IPL4__setUserData( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::ConnectionId& connId, + const IPL4asp__Types::UserData& userData) + { + return f__IPL4__PROVIDER__setUserData(portRef, connId, userData); + } + + IPL4asp__Types::Result f__IPL4__getUserData( + Iuh__CodecPort::Iuh__CODEC__PT& portRef, + const IPL4asp__Types::ConnectionId& connId, + IPL4asp__Types::UserData& userData) + { + return f__IPL4__PROVIDER__getUserData(portRef, connId, userData); + } + +} diff --git a/library/Iuh_Emulation.ttcn b/library/Iuh_Emulation.ttcn new file mode 100644 index 0000000..75a95ba --- /dev/null +++ b/library/Iuh_Emulation.ttcn @@ -0,0 +1,212 @@ +module Iuh_Emulation { + +/* Iuh Emulation, runs on top of Iuh_CodecPort. It multiplexes/demultiplexes + * HNBAP and RUA. + * + * The Iuh_Emulation.main() function processes Iuh primitives from the Iuh + * socket via the Iuh_CodecPort, and dispatches them to HNBAP/RUA ports. + * + * (C) 2021 by sysmocom s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +import from Iuh_CodecPort all; +import from Iuh_CodecPort_CtrlFunct all; +import from HNBAP_Types all; +import from HNBAP_Constants all; +import from HNBAP_PDU_Contents all; +import from HNBAP_PDU_Descriptions all; +import from HNBAP_IEs all; +import from HNBAP_Templates all; +import from RUA_Types all; +import from RUA_Constants all; +import from RUA_PDU_Contents all; +import from RUA_PDU_Descriptions all; +import from RUA_IEs all; +import from RUA_Templates all; +import from Iuh_Types all; + +import from General_Types all; +import from Misc_Helpers all; +import from Osmocom_Types all; +import from IPL4asp_Types all; +import from DNS_Helpers all; + +type enumerated IUHEM_EventUpDown { + IUHEM_EVENT_DOWN, + IUHEM_EVENT_UP +} + +/* an event indicating us whether or not a connection is physically up or down. */ +type union IUHEM_Event { + IUHEM_EventUpDown up_down +} + +type port HNBAP_PT message { + inout HNBAP_PDU, IUHEM_Event; +} with { extension "internal" }; +type port RUA_PT message { + inout RUA_PDU, IUHEM_Event; +} with { extension "internal" }; + +type component Iuh_Emulation_CT { + /* Port facing to the SCTP SUT */ + port Iuh_CODEC_PT Iuh; + /* Port facing to user upper side stack: */ + port HNBAP_PT HNBAP; + port RUA_PT RUA; + + var Iuh_conn_parameters g_pars; + var charstring g_Iuh_id; + var integer g_self_conn_id := -1; + var IPL4asp_Types.ConnectionId g_last_conn_id := -1; /* server only */ +} + +type record Iuh_conn_parameters { + HostName remote_ip, + PortNumber remote_sctp_port, + HostName local_ip, + PortNumber local_sctp_port +} + +function tr_Iuh_RecvFrom_R(template Iuh_PDU msg) +runs on Iuh_Emulation_CT return template Iuh_RecvFrom { + var template Iuh_RecvFrom mrf := { + connId := ?, + remName := ?, + remPort := ?, + locName := ?, + locPort := ?, + msg := msg + } + return mrf; +} + +private template (value) SctpTuple ts_SCTP(template (omit) integer ppid := omit) := { + sinfo_stream := omit, + sinfo_ppid := ppid, + remSocks := omit, + assocId := omit +}; + +private template PortEvent tr_SctpAssocChange := { + sctpEvent := { + sctpAssocChange := ? + } +} +private template PortEvent tr_SctpPeerAddrChange := { + sctpEvent := { + sctpPeerAddrChange := ? + } +} + +private function emu_is_server() runs on Iuh_Emulation_CT return boolean { + return g_pars.remote_sctp_port == -1 +} + +/* Resolve TCP/IP connection identifier depending on server/client mode */ +private function f_iuh_conn_id() runs on Iuh_Emulation_CT +return IPL4asp_Types.ConnectionId { + var IPL4asp_Types.ConnectionId conn_id; + + if (not emu_is_server()) { + conn_id := g_self_conn_id; + } else { + conn_id := g_last_conn_id; + } + + if (conn_id == -1) { /* Just to be sure */ + f_shutdown(__FILE__, __LINE__, fail, "Connection is not established"); + } + + return conn_id; +} + +function main(Iuh_conn_parameters p, charstring id) runs on Iuh_Emulation_CT { + var Result res; + g_pars := p; + g_Iuh_id := id; + + map(self:Iuh, system:Iuh_CODEC_PT); + if (emu_is_server()) { + res := Iuh_CodecPort_CtrlFunct.f_IPL4_listen(Iuh, p.local_ip, p.local_sctp_port, { sctp := valueof(ts_SCTP) }); + } else { + res := Iuh_CodecPort_CtrlFunct.f_IPL4_connect(Iuh, p.remote_ip, p.remote_sctp_port, + p.local_ip, p.local_sctp_port, -1, { sctp := valueof(ts_SCTP) }); + } + if (not ispresent(res.connId)) { + f_shutdown(__FILE__, __LINE__, fail, "Could not connect Iuh socket, check your configuration"); + } + g_self_conn_id := res.connId; + + /* notify user about SCTP establishment */ + if (p.remote_sctp_port != -1) { + HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); + } + + while (true) { + var Iuh_RecvFrom mrf; + var HNBAP_PDU hnbap_msg; + var RUA_PDU rua_msg; + var ASP_Event asp_evt; + + alt { + /* HNBAP from client: pass on transparently */ + [] HNBAP.receive(HNBAP_PDU:?) -> value hnbap_msg { + /* Pass message through */ + Iuh.send(t_Iuh_Send_HNBAP(f_iuh_conn_id(), hnbap_msg)); + } + /* RUA from client: pass on transparently */ + [] RUA.receive(RUA_PDU:?) -> value rua_msg { + /* Pass message through */ + Iuh.send(t_Iuh_Send_RUA(f_iuh_conn_id(), rua_msg)); + } + + /* Iuh received from peer (HNBGW or HnodeB) */ + [] Iuh.receive(tr_Iuh_RecvFrom_R(?)) -> value mrf { + if (not match(mrf.connId, f_iuh_conn_id())) { + f_shutdown(__FILE__, __LINE__, fail, log2str("Received message from unexpected conn_id!", mrf)); + } + + if (match(mrf, t_Iuh_RecvFrom_HNBAP(?))) { + HNBAP.send(mrf.msg.hnbap); + } else if (match(mrf, t_Iuh_RecvFrom_RUA(?))) { + RUA.send(mrf.msg.rua); + } else { + /* TODO: special handling, as it contains multiple HNB connection ids */ + f_shutdown(__FILE__, __LINE__, fail, log2str("UNEXPECTED MESSAGE RECEIVED!", mrf)); + } + } + [] Iuh.receive(tr_SctpAssocChange) { } + [] Iuh.receive(tr_SctpPeerAddrChange) { } + + /* server only */ + [] Iuh.receive(ASP_Event:{connOpened:=?}) -> value asp_evt { + if (not emu_is_server()) { + f_shutdown(__FILE__, __LINE__, fail, log2str("Unexpected event receiver in client mode", asp_evt)); + } + g_last_conn_id := asp_evt.connOpened.connId; + log("Established a new Iuh connection (conn_id=", g_last_conn_id, ")"); + + HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* TODO: send g_last_conn_id */ + } + + [] Iuh.receive(ASP_Event:{connClosed:=?}) -> value asp_evt { + log("Iuh: Closed"); + g_self_conn_id := -1; + HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_DOWN}); /* TODO: send asp_evt.connClosed.connId */ + if (not emu_is_server()) { + self.stop; + } + } + } + } +} + +} diff --git a/library/Iuh_Types.ttcn b/library/Iuh_Types.ttcn new file mode 100644 index 0000000..17f9c5f --- /dev/null +++ b/library/Iuh_Types.ttcn @@ -0,0 +1,36 @@ +/* Osmocom Iuh Interface Types + * (C) 2021 by sysmocom s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + + /* Iuh Codec Port Types + * + * (C) 2019 by Harald Welte + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module Iuh_Types { + +import from HNBAP_PDU_Descriptions all; +import from HNBAP_Types all; +import from RUA_PDU_Descriptions all; +import from RUA_Types all; + +type union Iuh_PDU { + HNBAP_PDU hnbap, + RUA_PDU rua, + octetstring payload +} + +}; diff --git a/library/hnbap/HNBAP_Templates.ttcn b/library/hnbap/HNBAP_Templates.ttcn new file mode 100644 index 0000000..44704f8 --- /dev/null +++ b/library/hnbap/HNBAP_Templates.ttcn @@ -0,0 +1,135 @@ +/* HNBAP Templates in TTCN-3 + * (C) 2021 Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBAP_Templates { + +import from General_Types all; +import from Osmocom_Types all; + +import from HNBAP_IEs all; +import from HNBAP_CommonDataTypes all; +import from HNBAP_Constants all; +import from HNBAP_Containers all; +import from HNBAP_PDU_Contents all; +import from HNBAP_PDU_Descriptions all; + +/********************************************************************************* + * 3GPP TS 25.469 + *********************************************************************************/ + +template (value) Cause ts_HnbapCause(template (value) CauseRadioNetwork c) := { + radioNetwork := c +} + +/* 9.1.3 HNB REGISTER REQUEST */ +template (present) HNBAP_PDU +tr_HNBAP_HNBRegisterRequest(template (present) octetstring hNB_Identity_Info := ?, + template (present) OCT3 plmnid := ?, + template (present) BIT28 cell_identity := ?, + template (present) OCT2 lac := ?, + template (present) OCT1 rac := ?, + template (present) OCT2 sac := ?) := { + initiatingMessage := { + procedureCode := id_HNBRegister, + criticality := reject, + value_ := { + hNBRegisterRequest := { + protocolIEs := { + { + id := HNBAP_Constants.id_HNB_Identity, + criticality := reject, + value_ := { + hNB_Identity := { + hNB_Identity_Info := hNB_Identity_Info, + iE_Extensions := omit + } + } + }, { + id := 8, + criticality := reject, + value_ := { + hNB_Location_Information := { + macroCoverageInfo := omit, + geographicalCoordinates := omit, + iE_Extensions := omit + } + } + }, { + id := 9, + criticality := reject, + value_ := { pLMNidentity := plmnid } + }, { + id := 11, + criticality := reject, + value_ := { cellIdentity := cell_identity } + }, { + id := 6, + criticality := reject, + value_ := { lAC := lac } + }, { + id := 7, + criticality := reject, + value_ := { rAC := rac } + }, { + id := 10, + criticality := reject, + value_ := { sAC := sac } + } + }, + protocolExtensions := omit + } + } + } +} + + +/* 9.1.4 HNB REGISTER ACCEPT */ +template (value) HNBAP_PDU +ts_HNBAP_HNBRegisterAccept(template (value) uint16_t rnc_id) := { + successfulOutcome := { + procedureCode := id_HNBRegister, + criticality := reject, + value_ := { + hNBRegisterAccept := { + protocolIEs := { + { + id := HNBAP_Constants.id_RNC_ID, + criticality := reject, + value_ := { RNC_ID := rnc_id } + } + }, + protocolExtensions := omit /* TODO: Mux Port Number (optional) 9.2.29 */ + } + } + } +} + +/* 9.1.5 HNB REGISTER REJECT */ +template (value) HNBAP_PDU +ts_HNBAP_HNBRegisterReject(template (value) Cause cause) := { + unsuccessfulOutcome := { + procedureCode := id_HNBRegister, + criticality := reject, + value_ := { + HNBRegisterReject := { + protocolIEs := { + { + id := HNBAP_Constants.id_Cause, + criticality := ignore, + value_ := { Cause := cause } + } + }, + protocolExtensions := omit /* TODO: CriticalityDiagnostics, BackoffTimer */ + } + } + } +} + +} diff --git a/library/rua/RUA_Templates.ttcn b/library/rua/RUA_Templates.ttcn new file mode 100644 index 0000000..b7387bf --- /dev/null +++ b/library/rua/RUA_Templates.ttcn @@ -0,0 +1,22 @@ +/* RUA Templates in TTCN-3 + * (C) 2021 Pau Espin Pedrol + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module RUA_Templates { + +import from RUA_IEs all; +import from RUA_CommonDataTypes all; +import from RUA_Constants all; +import from RUA_Containers all; +import from RUA_PDU_Contents all; +import from RUA_PDU_Descriptions all; + + +/* TODO: Add RUA Templates here */ +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7227917148e98a2c777f4b05d8d2eca6e9c121b7 Gerrit-Change-Number: 26336 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:03:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 19:03:15 +0000 Subject: Change in osmo-bts[master]: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26351 to look at the new patch set (#2). Change subject: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() ...................................................................... cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() If a new default message is installed via RSL, and the old default message is currently being transmitted, we must set cur_msg to NULL. The old default message must be talloc_free()d unconditionally whenever a new default message is being set. We can do that by using the TALLOC_FREE macro. Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Related: OS#5325 --- M src/common/cbch.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/26351/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Gerrit-Change-Number: 26351 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:03:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 19:03:15 +0000 Subject: Change in osmo-bts[master]: cbch: Fix bts_smscb_state_reset() to avoid double-free References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26355 ) Change subject: cbch: Fix bts_smscb_state_reset() to avoid double-free ...................................................................... cbch: Fix bts_smscb_state_reset() to avoid double-free If the currently transmitted message is the default message, bts_ss->cur_msg == bts_ss->derfault_msg. In this case we cannot simply talloc_free() both of them, as it would result in a boudle-free. Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808 Closes: OS#5325 Fixes: Ib01d38c59ba9fa083fcc0682009c13d2db3664fe --- M src/common/cbch.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/55/26355/1 diff --git a/src/common/cbch.c b/src/common/cbch.c index addd68c..a3e1296 100644 --- a/src/common/cbch.c +++ b/src/common/cbch.c @@ -332,7 +332,10 @@ } bts_ss->queue_len = 0; rate_ctr_group_reset(bts_ss->ctrs); - TALLOC_FREE(bts_ss->cur_msg); + /* avoid double-free of default_msg in case cur_msg == default_msg */ + if (bts_ss->cur_msg && bts_ss->cur_msg != bts_ss->default_msg) + talloc_free(bts_ss->cur_msg); + bts_ss->cur_msg = NULL; TALLOC_FREE(bts_ss->default_msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808 Gerrit-Change-Number: 26355 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:09:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 19:09:49 +0000 Subject: Change in osmo-bts[master]: cbch: Fix bts_smscb_state_reset() to avoid double-free In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26355 ) Change subject: cbch: Fix bts_smscb_state_reset() to avoid double-free ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808 Gerrit-Change-Number: 26355 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 19:09:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:09:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 19:09:54 +0000 Subject: Change in osmo-bts[master]: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26351 ) Change subject: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Gerrit-Change-Number: 26351 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 19:09:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:10:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 19:10:18 +0000 Subject: Change in osmo-bts[master]: cbch: Fix bts_smscb_state_reset() to avoid double-free In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26355 ) Change subject: cbch: Fix bts_smscb_state_reset() to avoid double-free ...................................................................... Patch Set 1: Verified+1 verified the tests pass with this fix applied, no crash in asan/gdb anmymore. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808 Gerrit-Change-Number: 26355 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 19:10:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:10:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 19:10:28 +0000 Subject: Change in osmo-bts[master]: cbch: Fix bts_smscb_state_reset() to avoid double-free In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26355 ) Change subject: cbch: Fix bts_smscb_state_reset() to avoid double-free ...................................................................... cbch: Fix bts_smscb_state_reset() to avoid double-free If the currently transmitted message is the default message, bts_ss->cur_msg == bts_ss->derfault_msg. In this case we cannot simply talloc_free() both of them, as it would result in a boudle-free. Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808 Closes: OS#5325 Fixes: Ib01d38c59ba9fa083fcc0682009c13d2db3664fe --- M src/common/cbch.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified diff --git a/src/common/cbch.c b/src/common/cbch.c index addd68c..a3e1296 100644 --- a/src/common/cbch.c +++ b/src/common/cbch.c @@ -332,7 +332,10 @@ } bts_ss->queue_len = 0; rate_ctr_group_reset(bts_ss->ctrs); - TALLOC_FREE(bts_ss->cur_msg); + /* avoid double-free of default_msg in case cur_msg == default_msg */ + if (bts_ss->cur_msg && bts_ss->cur_msg != bts_ss->default_msg) + talloc_free(bts_ss->cur_msg); + bts_ss->cur_msg = NULL; TALLOC_FREE(bts_ss->default_msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d3645e34d31507b012a53ffe12d14223682f808 Gerrit-Change-Number: 26355 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:18:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 19:18:28 +0000 Subject: Change in osmo-bts[master]: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26351 ) Change subject: cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() ...................................................................... cbch: Fix dangling cur_msg leading to double-free in bts_cbch_reset() If a new default message is installed via RSL, and the old default message is currently being transmitted, we must set cur_msg to NULL. The old default message must be talloc_free()d unconditionally whenever a new default message is being set. We can do that by using the TALLOC_FREE macro. Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Related: OS#5325 --- M src/common/cbch.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/cbch.c b/src/common/cbch.c index a3e1296..f1f8b6a 100644 --- a/src/common/cbch.c +++ b/src/common/cbch.c @@ -233,10 +233,10 @@ rate_ctr_inc2(bts_ss->ctrs, CBCH_CTR_RCVD_QUEUED); break; case RSL_CB_CMD_TYPE_DEFAULT: - /* old default msg will be free'd in get_smscb_block() if it is currently in transit - * and we set a new default_msg here */ + /* clear the cur_msg pointer if it is the old default message */ if (bts_ss->cur_msg && bts_ss->cur_msg == bts_ss->default_msg) - talloc_free(bts_ss->cur_msg); + bts_ss->cur_msg = NULL; + talloc_free(bts_ss->default_msg); if (cmd_type.def_bcast == RSL_CB_CMD_DEFBCAST_NORMAL) /* def_bcast == 0: normal message */ bts_ss->default_msg = scm; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id32c2074b61cd1f09957b9d1558ffb3a7691a8e0 Gerrit-Change-Number: 26351 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:22:29 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 24 Nov 2021 19:22:29 +0000 Subject: Change in osmo-bsc[master]: hodec2: fix segv for inter-BSC ho target In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26352 ) Change subject: hodec2: fix segv for inter-BSC ho target ...................................................................... Patch Set 1: Code-Review+2 let me speed this patch up: fairly trivial as well as a regression fix -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a3345ab0005a73597f5c27207480912a2f5aae6 Gerrit-Change-Number: 26352 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 19:22:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:22:34 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 24 Nov 2021 19:22:34 +0000 Subject: Change in osmo-bsc[master]: hodec2: fix segv for inter-BSC ho target In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26352 ) Change subject: hodec2: fix segv for inter-BSC ho target ...................................................................... hodec2: fix segv for inter-BSC ho target Related: OS#5324 SYS#5259 Change-Id: I5a3345ab0005a73597f5c27207480912a2f5aae6 --- M src/osmo-bsc/handover_decision_2.c 1 file changed, 30 insertions(+), 18 deletions(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index 6730f26..14bc2d4 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -1027,27 +1027,39 @@ break; } - chan_counts_for_bts(&bts_counts, c->target.bts); - c->target.free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; - c->target.min_free_tchf = ho_get_hodec2_tchf_min_slots(c->target.bts->ho); - c->target.free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; - c->target.min_free_tchh = ho_get_hodec2_tchh_min_slots(c->target.bts->ho); + /* For inter-BSC handover, the target BTS is in a different BSC and hence NULL here. */ + if (c->target.bts) { + chan_counts_for_bts(&bts_counts, c->target.bts); + c->target.free_tchf = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_F]; + c->target.min_free_tchf = ho_get_hodec2_tchf_min_slots(c->target.bts->ho); + c->target.free_tchh = bts_counts.val[CHAN_COUNTS1_ALL][CHAN_COUNTS2_FREE][GSM_LCHAN_TCH_H]; + c->target.min_free_tchh = ho_get_hodec2_tchh_min_slots(c->target.bts->ho); - /* Would the next TCH/F lchan occupy a dynamic timeslot that currently counts for free TCH/H timeslots? */ - next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_F, false); - if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN) - c->target.next_tchf_reduces_tchh = 2; - else - c->target.next_tchf_reduces_tchh = 0; + /* Would the next TCH/F lchan occupy a dynamic timeslot that currently counts for free TCH/H timeslots? + */ + next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_F, false); + if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN) + c->target.next_tchf_reduces_tchh = 2; + else + c->target.next_tchf_reduces_tchh = 0; - /* Would the next TCH/H lchan occupy a dynamic timeslot that currently counts for free TCH/F timeslots? - * Note that a dyn TS already in TCH/H mode (half occupied) would not reduce free TCH/F. */ - next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_H, false); - if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN - && next_lchan->ts->pchan_is != GSM_PCHAN_TCH_H) - c->target.next_tchh_reduces_tchf = 1; - else + /* Would the next TCH/H lchan occupy a dynamic timeslot that currently counts for free TCH/F timeslots? + * Note that a dyn TS already in TCH/H mode (half occupied) would not reduce free TCH/F. */ + next_lchan = lchan_avail_by_type(c->target.bts, GSM_LCHAN_TCH_H, false); + if (next_lchan && next_lchan->ts->pchan_on_init == GSM_PCHAN_OSMO_DYN + && next_lchan->ts->pchan_is != GSM_PCHAN_TCH_H) + c->target.next_tchh_reduces_tchf = 1; + else + c->target.next_tchh_reduces_tchf = 0; + } else { + + c->target.free_tchf = 0; + c->target.min_free_tchf = 0; c->target.next_tchh_reduces_tchf = 0; + c->target.free_tchh = 0; + c->target.min_free_tchh = 0; + c->target.next_tchf_reduces_tchh = 0; + } } /* add candidate for re-assignment within the current cell */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a3345ab0005a73597f5c27207480912a2f5aae6 Gerrit-Change-Number: 26352 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:24:11 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 24 Nov 2021 19:24:11 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c at 1349 PS1, Line 1349: rxlev2dbm(mrc->rxlev) it's rxlev, or i know nothing about handover -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 19:24:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:25:11 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 24 Nov 2021 19:25:11 +0000 Subject: Change in libosmocore[master]: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LO... References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26356 ) Change subject: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LOGGING ...................................................................... logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LOGGING This was previously unconditionally defined, so embedded targets were unable to get rid of the log macros and functions. Change-Id: I589f93d98a6bc5cf6221c56e2fe3f27bfdd200e8 --- M include/osmocom/core/logging.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/26356/1 diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index a554adc..a95c478 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -15,6 +15,10 @@ #define DEBUG #endif +#ifdef LIBOSMOCORE_NO_LOGGING +#undef DEBUG +#endif + #ifdef DEBUG /*! Log a debug message through the Osmocom logging framework * \param[in] ss logging subsystem (e.g. \ref DLGLOBAL) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I589f93d98a6bc5cf6221c56e2fe3f27bfdd200e8 Gerrit-Change-Number: 26356 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 19:35:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 19:35:56 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c at 1349 PS1, Line 1349: rxlev2dbm(mrc->rxlev) > it's rxlev, or i know nothing about handover rxlev2dbm(foo) takes foo in RXLEV units and returns a value in RSSI units right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 19:35:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:06:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:06:50 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 20:06:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:06:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:06:51 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:06:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:06:57 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 20:06:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:07:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:07:00 +0000 Subject: Change in libosmo-netif[master]: Introduce sctp.h to provide SCTP related functionalities In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26340 ) Change subject: Introduce sctp.h to provide SCTP related functionalities ...................................................................... Introduce sctp.h to provide SCTP related functionalities These value_strings are taken from existing private ones in libosmo-sccp.git osmo_ss7.c, and are moved here in order to be reused by other projects, such as osmo-hnodeb. Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 --- M TODO-RELEASE M include/osmocom/netif/Makefile.am A include/osmocom/netif/sctp.h M src/Makefile.am A src/sctp.c 5 files changed, 50 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved; Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index d0852fc..1c9a2a6 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +sctp.h new APIs diff --git a/include/osmocom/netif/Makefile.am b/include/osmocom/netif/Makefile.am index 39df08a..d9d030b 100644 --- a/include/osmocom/netif/Makefile.am +++ b/include/osmocom/netif/Makefile.am @@ -8,4 +8,8 @@ rtp.h \ stream.h +if ENABLE_LIBSCTP +osmonetif_HEADERS += sctp.h +endif + osmonetifdir = $(includedir)/osmocom/netif diff --git a/include/osmocom/netif/sctp.h b/include/osmocom/netif/sctp.h new file mode 100644 index 0000000..2b2e072 --- /dev/null +++ b/include/osmocom/netif/sctp.h @@ -0,0 +1,13 @@ +#pragma once + +#include + +enum sctp_sac_state; +extern const struct value_string osmo_sctp_assoc_chg_strs[]; +static inline const char *osmo_sctp_assoc_chg_str(enum sctp_sac_state val) +{ return get_value_string(osmo_sctp_assoc_chg_strs, val); } + +enum sctp_sn_type; +extern const struct value_string osmo_sctp_sn_type_strs[]; +static inline const char *osmo_sctp_sn_type_str(enum sctp_sn_type val) +{ return get_value_string(osmo_sctp_sn_type_strs, val); } diff --git a/src/Makefile.am b/src/Makefile.am index 7e71c71..438b58e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -20,3 +20,7 @@ rs232.c \ rtp.c \ stream.c + +if ENABLE_LIBSCTP +libosmonetif_la_SOURCES += sctp.c +endif diff --git a/src/sctp.c b/src/sctp.c new file mode 100644 index 0000000..c24e0f7 --- /dev/null +++ b/src/sctp.c @@ -0,0 +1,28 @@ +#include +#include + +const struct value_string osmo_sctp_assoc_chg_strs[] = { + { SCTP_COMM_UP, "COMM_UP" }, + { SCTP_COMM_LOST, "COMM_LOST" }, + { SCTP_RESTART, "RESTART" }, + { SCTP_SHUTDOWN_COMP, "SHUTDOWN_COMP" }, + { SCTP_CANT_STR_ASSOC, "CANT_STR_ASSOC" }, + { 0, NULL } +}; + +const struct value_string osmo_sctp_sn_type_strs[] = { + { SCTP_ASSOC_CHANGE, "ASSOC_CHANGE" }, + { SCTP_PEER_ADDR_CHANGE, "PEER_ADDR_CHANGE" }, + { SCTP_SHUTDOWN_EVENT, "SHUTDOWN_EVENT" }, + { SCTP_SEND_FAILED, "SEND_FAILED" }, + { SCTP_REMOTE_ERROR, "REMOTE_ERROR" }, + { SCTP_PARTIAL_DELIVERY_EVENT, "PARTIAL_DELIVERY_EVENT" }, + { SCTP_ADAPTATION_INDICATION, "ADAPTATION_INDICATION" }, +#ifdef SCTP_AUTHENTICATION_INDICATION + { SCTP_AUTHENTICATION_INDICATION, "AUTHENTICATION_INDICATION" }, +#endif +#ifdef SCTP_SENDER_DRY_EVENT + { SCTP_SENDER_DRY_EVENT, "SENDER_DRY_EVENT" }, +#endif + { 0, NULL } +}; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Gerrit-Change-Number: 26340 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:12:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:12:48 +0000 Subject: Change in osmo-hnodeb[master]: Introduce SCTP log category In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 to look at the new patch set (#2). Change subject: Introduce SCTP log category ...................................................................... Introduce SCTP log category Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/iuh.c 3 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/42/26342/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:12:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:12:48 +0000 Subject: Change in osmo-hnodeb[master]: iuh: Improve logging of SCTP notifications In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 to look at the new patch set (#2). Change subject: iuh: Improve logging of SCTP notifications ...................................................................... iuh: Improve logging of SCTP notifications Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d --- M TODO-RELEASE M src/osmo-hnodeb/iuh.c 2 files changed, 50 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/43/26343/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d Gerrit-Change-Number: 26343 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:12:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:12:48 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 to look at the new patch set (#2). Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Implement initial shutdown + reconnect FSM The shutdown_fsm doesn't do much right now, but it's included there in order to allow easy clean up of resources upon Iuh reconnect in the future, as well as reset the lower layers. Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 --- M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_shutdown_fsm.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/hnb.c A src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/iuh.c 7 files changed, 202 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/48/26348/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:12:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:12:51 +0000 Subject: Change in osmo-hnodeb[master]: WIP References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: WIP ...................................................................... WIP Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_ctl.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 16 files changed, 1,041 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/1 diff --git a/doc/hnodeb.msc b/doc/hnodeb.msc new file mode 100644 index 0000000..a5f7a86 --- /dev/null +++ b/doc/hnodeb.msc @@ -0,0 +1,62 @@ +msc { + hscale="3"; + ue [label="Customer"], trx [label="Lower Layer TRX"], hnodeb [label="osmo-hnodeb"], hnbgw [label="HNBGW"], ggsn [label="GGSN"], mgw [label="MGW"]; + + |||; + --- [ label = "HnodeB starts up" ]; + hnodeb => hnbgw [label="HNBAP HnbRegisterRequest"]; + hnodeb <= hnbgw [label="HNBAP HnbRegisterResponse"]; + trx <= hnodeb [label="REQ(SAPI_IUH, HNB_IUH_PRIM_CONFIGURE)(PLMN,LAC,SAC,RAC,CI,RNC_ID from HnbRegisterResponse)"]; + |||; + ...; + |||; + |||; + --- [ label = "Subscriber Sign Up" ]; + ue => trx [label="..."]; + trx => hnodeb [label="IND(SAPI_IUH, CONN_ESTABLISH)[RANAP?]"]; + hnodeb => hnbgw [label="HNBAP UE Register Req(IMSI?)"]; + hnodeb <= hnbgw [label="HNBAP UE Register Acc(context_id)"]; + trx <= hnodeb [label="CNF(SAPI_IUH, CONN_ESTABLISH)(context_id])"]; + trx => hnodeb [label="IND(SAPI_IUH, CONN_DATA)[RANAP GMM ServiceRequest]"]; + hnodeb => hnbgw [label="RANAP GMM ServiceRequest"]; + hnodeb <= hnbgw [label="RANAP GMM ServiceAccept"]; + trx <= hnodeb [label="REQ(SAPI_IUH, CONN_DATA)[RANAP GMM ServiceAccept]"]; + --- [ label = "Subscriber set up PS data:" ]; + hnodeb <= hnbgw [label="RANAP RAB-Assignment Request(TEI, ADDR)"]; + trx <= hnodeb [label="REQ(SAPI_IUH, CONN_DATA)[RANAP RAB-Assignment Request(remote_ip, remote_port, remote_tei)]"]; + trx => hnodeb [label="IND(SAPI_GTP, CONN_ESTABLISH)(remote_ip,remote_port,remote_tei)"]; + ... [ label = "HnodeB sets up GTP-U connection" ]; + trx <= hnodeb [label="CNF(SAPI_GTP, CONN_ESTABLISH)(local_ip,local_port,local_tei,remote_tei)"]; + |||; + ...; + |||; + --- [ label = "PS data transmission over GTP-U:" ]; + ue => trx [label="..."]; + trx => hnodeb [label="IND(SAPI_GTP, CONN_DATA)[remote_tei,payload]"]; + hnodeb => ggsn [label="GTP-U(remote_tei, local_addr, remote_addr, payload)"]; + hnodeb <= ggsn [label="GTP-U(local_tei, remote_addr, local_addr, payload)"]; + trx <= hnodeb [label="REQ(SAPI_GTP, CONN_DATA)[local_tei,payload]"]; + ue <= trx [label="..."]; + |||; + ...; + |||; + --- [ label = "MO/MT PS data Release:" ]; + ue => trx [label="..."]; + trx => hnodeb [label="IND(SAPI_IUH, CONN_DATA)[RANAP IU Release Request]"]; + hnodeb => hnbgw [label="RANAP IU Release Request"]; + hnodeb <= hnbgw [label="RANAP IU Release Command"]; + trx <= hnodeb [label="REQ(SAPI_IUH, CONN_DATA)[RANAP IU Release Command]"]; + ...; + trx => hnodeb [label="IND(SAPI_GTP, CONN_RELEASE)(remote_tei)"]; + trx <= hnodeb [label="CNF(SAPI_GTP, CONN_RELEASE)(remote_tei)"]; + + trx => hnodeb [label="IND(SAPI_IUH, CONN_RELEASE)[RANAP IU Release Complete]"]; + hnodeb => hnbgw [label="RANAP IU Release Complete"]; + trx => hnodeb [label="CNF(SAPI_GTP, CONN_RELEASE)"]; + + |||; + ...; + |||; + --- [ label = "For voice call (CS): Similar to SAPI_GTP, but using SAPI_AUDIO and osmo-hnodeb sets up RTP stream" ]; + +} diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index b1acb7e..56d1033 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,8 +1,10 @@ noinst_HEADERS = \ hnb_shutdown_fsm.h \ + hnb_prim.h \ hnbap.h \ hnodeb.h \ iuh.h \ + llsk.h \ nas.h \ ranap.h \ rua.h \ diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h new file mode 100644 index 0000000..8cede29 --- /dev/null +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -0,0 +1,271 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include +#include +#include + +#include + +#define HNB_PRIM_API_VERSION 0 +#define HNB_PRIM_UD_SOCK_DEFAULT "/tmp/hnb_prim_sock" + +#define HNB_PRIM_SAPI_CTL 0 +#define HNB_PRIM_SAPI_IUH 1 +#define HNB_PRIM_SAPI_GTP 2 +#define HNB_PRIM_SAPI_AUDIO 3 + +struct hnb_prim_hdr { + uint32_t sap; /*!< Service Access Point Identifier */ + uint32_t primitive; /*!< Primitive number */ + uint32_t operation; /*! Primitive Operation */ +} __attribute__ ((packed)); + +/*! \brief HNB_CTL primitives */ +enum hnb_ctl_prim_type { + HNB_CTL_PRIM_HELLO, + _HNB_CTL_PRIM_MAX +}; + +/* HNB_CTL_PRIM_HELLO, UL */ +struct hnb_ctl_hello_ind_param { + uint16_t api_version; /* see HNB_PRIM_API_VERSION */ +} __attribute__ ((packed)); + +/* HNB_CTL_PRIM_HELLO, DL */ +struct hnb_ctl_hello_cnf_param { + uint16_t api_version; /* see HNB_PRIM_API_VERSION */ +} __attribute__ ((packed)); + +struct hnb_ctl_prim { + struct hnb_prim_hdr hdr; + union { + struct hnb_ctl_hello_ind_param hello_ind; + struct hnb_ctl_hello_cnf_param hello_cnf; + } u; +} __attribute__ ((packed)); + + +/*! \brief HNB_IUH primitives */ +enum hnb_iuh_prim_type { + HNB_IUH_PRIM_CONFIGURE, + HNB_IUH_PRIM_CONN_ESTABLISH, + HNB_IUH_PRIM_CONN_RELEASE, + HNB_IUH_PRIM_CONN_DATA, + HNB_IUH_PRIM_UNITDATA, + _HNB_IUH_PRIM_MAX +}; + +/* HNB_IUH_PRIM_CONFIGURE, DL */ +struct hnb_iuh_configure_req_param { + uint16_t mcc; + uint16_t mnc; + uint16_t cell_identity; + uint16_t lac; + uint8_t rac; + uint8_t reserved; + uint16_t sac; + uint16_t rnc_id; +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_ESTABLISH, DL */ +struct hnb_iuh_conn_establish_req_param { + uint32_t context_id; + uint8_t domain; + uint8_t cause; + uint8_t csg_membership_status; + uint8_t spare1; + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_ESTABLISH, UL */ +struct hnb_iuh_conn_establish_ind_param { + uint32_t context_id; + uint8_t domain; + uint8_t cause; + /* TODO: Check if we can copy it as an encoded buffer RRC <-> RUA + * RRC: 3GPP TS 25.331 10.3.1.6 Intra Domain NAS Node Selector + * RUA: 3GPP TS 25.468 9.2.4 */ + uint16_t nas_node_selector_bitlen; + uint8_t nas_node_selector[128]; /* TODO: check whether we can decrease this buffer size */ + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_RELEASE, DL */ +struct hnb_iuh_conn_release_req_param { + uint32_t context_id; + uint8_t domain; + uint8_t cause; + uint16_t spare1; + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_RELEASE, UL */ +struct hnb_iuh_conn_release_ind_param { + uint32_t context_id; + uint8_t domain; + uint8_t cause; + uint16_t spare1; + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_DATA, DL */ +struct hnb_iuh_conn_data_req_param { + uint32_t context_id; + uint8_t domain; + uint8_t spare1; + uint16_t spare2; + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_DATA, UL */ +struct hnb_iuh_conn_data_ind_param { + uint32_t context_id; + uint8_t domain; + uint8_t spare1; + uint16_t spare2; + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_UNITDATA, DL */ +struct hnb_iuh_unitdata_req_param { + uint8_t domain; + uint8_t spare1; + uint16_t spare2; + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_UNITDATA, UL */ +struct hnb_iuh_unitdata_ind_param { + uint8_t domain; + uint8_t spare1; + uint16_t spare2; + uint32_t data_len; /* RANAP message length in bytes */ + char data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +struct hnb_iuh_prim { + struct hnb_prim_hdr hdr; + union { + struct hnb_iuh_configure_req_param configure_req; + struct hnb_iuh_conn_establish_req_param conn_establish_req; + struct hnb_iuh_conn_establish_ind_param conn_establish_ind; + struct hnb_iuh_conn_release_req_param conn_reelase_req; + struct hnb_iuh_conn_release_ind_param conn_release_ind; + struct hnb_iuh_conn_data_req_param conn_data_req; + struct hnb_iuh_conn_data_ind_param conn_data_ind; + struct hnb_iuh_unitdata_req_param unitdata_req; + struct hnb_iuh_unitdata_ind_param unitdata_ind; + } u; +} __attribute__ ((packed)); + +struct hnb_iuh_prim *hnb_iuh_makeprim_conn_establish_req(uint32_t context_id, + uint8_t domain, + uint8_t cause, + uint8_t csg_membership_status, + uint8_t *data, + uint32_t data_len); +struct hnb_iuh_prim *hnb_iuh_makeprim_conn_release_req(uint32_t context_id, + uint8_t domain, + uint8_t cause, + uint8_t *data, + uint32_t data_len); +struct hnb_iuh_prim *hnb_iuh_makeprim_conn_data_req(uint32_t context_id, + uint8_t domain, + uint8_t *data, + uint32_t data_len); +struct hnb_iuh_prim *hnb_iuh_makeprim_unitdata_req(uint8_t domain, + uint8_t *data, + uint32_t data_len); + + +/*! \brief HNB_GTP primitives */ +enum hnb_gtp_prim_type { + HNB_GTP_PRIM_CONN_ESTABLISH, + HNB_GTP_PRIM_CONN_RELEASE, + HNB_GTP_PRIM_CONN_DATA +}; +union u_addr { + struct in_addr v4; + struct in6_addr v6; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_ESTABLISH, UL */ +struct hnb_gtp_conn_establish_ind_param { + uint32_t remote_tei; + uint16_t remote_gtpu_port; + uint8_t remote_gtpu_address_type; + uint8_t spare1; + union u_addr remote_gtpu_addr; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_ESTABLISH, DL */ +struct hnb_gtp_conn_establish_cnf_param { + uint32_t remote_tei; + uint32_t local_tei; + uint16_t local_gtpu_port; + uint8_t local_gtpu_address_type; + uint8_t spare1; + union u_addr remote_gtpu_addr; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_RELEASE, UL */ +struct hnb_gtp_conn_release_ind_param { + uint32_t remote_tei; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_RELEASE, DL */ +struct hnb_gtp_conn_release_cnf_param { + uint32_t remote_tei; +} __attribute__ ((packed)); +struct hnb_gtp_conn_release_req_param { + uint32_t remote_tei; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_DATA, DL */ +struct hnb_gtp_conn_data_req_param { + uint32_t local_tei; + uint32_t data_len; /* GTP-U payload length in bytes */ + char data[0]; /* GTP-U payload (aka IP packet) */ +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_DATA, UL */ +struct hnb_gtp_conn_data_ind_param { + uint32_t remote_tei; + uint32_t data_len; /* GTP-U payload length in bytes */ + char data[0]; /* GTP-U payload (aka IP packet) */ +} __attribute__ ((packed)); + +struct hnb_gtp_prim { + struct hnb_prim_hdr hdr; + union { + struct hnb_gtp_conn_establish_ind_param conn_establish_ind; + struct hnb_gtp_conn_establish_cnf_param conn_establish_cnf; + struct hnb_gtp_conn_data_req_param conn_data_req; + struct hnb_gtp_conn_data_ind_param conn_data_ind; + } u; +} __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 3bc2fb3..186798b 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -28,12 +28,15 @@ #include #include +#include + enum { DMAIN, DHNBAP, DRUA, DRANAP, DSCTP, + DLLSK, DNAS, }; extern const struct log_info hnb_log_info; @@ -59,7 +62,14 @@ struct osmo_stream_cli *client; } iuh; + /* Lower Layer UD socket */ + struct { + char *sock_path; + struct llsk_state *state; + } llsk; + uint16_t rnc_id; + bool registered; /* Set to true once HnbRegisterAccept was received from Iuh. rnc_id is valid iif registered==true */ uint32_t ctx_id; diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h new file mode 100644 index 0000000..a08c006 --- /dev/null +++ b/include/osmocom/hnodeb/llsk.h @@ -0,0 +1,56 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include +#include + +#include +#include + +#include + +struct hnb; +struct msgb; + +struct llsk_state { + struct hnb *hnb; + struct osmo_fd listen_bfd; /* fd for listen socket */ + struct osmo_fd conn_bfd; /* fd for connection to lcr */ + struct llist_head upqueue; /* queue for sending messages */ +}; + +struct llsk_state *llsk_alloc(struct hnb *hnb); +int llsk_open(struct llsk_state *state, const char *path); +void llsk_free(struct llsk_state *state); + +int llsk_send(struct llsk_state *state, struct msgb *msg); +bool llsk_connected(const struct llsk_state *state); + + +extern const struct value_string hnb_ctl_prim_type_names[]; +int llsk_rx_ctl(struct hnb *hnb, struct hnb_ctl_prim *ctl, unsigned len); + + +extern const struct value_string hnb_iuh_prim_type_names[]; +int llsk_rx_iuh(struct hnb *hnb, struct hnb_iuh_prim *iuh, unsigned len); +struct msgb *hnb_iuh_makeprim_configure_req(uint16_t mcc, uint16_t mnc, + uint16_t cell_identity, + uint16_t lac, uint8_t rac, + uint16_t sac, uint16_t rnc_id); diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h index 7144d3f..1624bfb 100644 --- a/include/osmocom/hnodeb/vty.h +++ b/include/osmocom/hnodeb/vty.h @@ -27,6 +27,7 @@ enum hnb_vty_nodes { HNODEB_NODE = _LAST_OSMOVTY_NODE, IUH_NODE, + LLSK_NODE, CHAN_NODE, }; diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 7325728..0117f28 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -35,6 +35,9 @@ hnb.c \ hnb_shutdown_fsm.c \ iuh.c \ + llsk.c \ + llsk_ctl.c \ + llsk_iuh.c \ nas.c \ ranap.c \ rua.c \ diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index 10d1655..e610ff0 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -24,7 +24,7 @@ static const struct log_info_cat log_cat[] = { [DMAIN] = { .name = "DMAIN", .loglevel = LOGL_NOTICE, .enabled = 1, - .color = "", + .color = "\033[1;37m", .description = "Main program", }, [DHNBAP] = { @@ -47,6 +47,11 @@ .color = "\033[1;36m", .description = "SCTP connection on the Iuh link", }, + [DLLSK] = { + .name = "DLLSK", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;31m", + .description = "Lower Layer Unix Domain Socket", + }, [DNAS] = { .name = "NAS", .loglevel = LOGL_NOTICE, .enabled = 1, .color = "\033[1;32m", diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index b7be4ea..d7cf886 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -27,6 +27,7 @@ #include #include #include +#include struct hnb *hnb_alloc(void *tall_ctx) @@ -43,6 +44,9 @@ .mnc = 1, }; + hnb->llsk.sock_path = talloc_strdup(hnb, HNB_PRIM_UD_SOCK_DEFAULT); + hnb->llsk.state = llsk_alloc(hnb); + hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); @@ -58,5 +62,9 @@ hnb->shutdown_fi = NULL; } hnb_iuh_free(hnb); + + llsk_free(hnb->llsk.state); + hnb->llsk.state = NULL; + talloc_free(hnb); } diff --git a/src/osmo-hnodeb/hnb_shutdown_fsm.c b/src/osmo-hnodeb/hnb_shutdown_fsm.c index 7df591e..14e8b32 100644 --- a/src/osmo-hnodeb/hnb_shutdown_fsm.c +++ b/src/osmo-hnodeb/hnb_shutdown_fsm.c @@ -34,6 +34,11 @@ static void st_none_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct hnb *hnb = (struct hnb *)fi->priv; + + /* Reset state: */ + hnb->registered = false; + hnb->rnc_id = 0; + hnb_iuh_connect(hnb); /* Start reconnect once we are done with shutdown and we didn't exit process */ } diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 0495ce0..4ea1342 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -39,16 +39,31 @@ { int rc; HNBAP_HNBRegisterAcceptIEs_t accept; + struct msgb *llsk_msg; rc = hnbap_decode_hnbregisteraccepties(&accept, in); if (rc < 0) { + hnb_shutdown(hnb, "Failed decoding HnbRegisterAccept IEs", false); + return rc; } hnb->rnc_id = accept.rnc_id; + hnb->registered = true; LOGP(DHNBAP, LOGL_INFO, "Rx HNB Register accept with RNC ID %u\n", hnb->rnc_id); hnbap_free_hnbregisteraccepties(&accept); - return 0; + + if (llsk_connected(hnb->llsk.state)) { + /* We are attached to the HNBGW, configure lower layers: */ + llsk_msg = hnb_iuh_makeprim_configure_req(hnb->plmn.mcc, hnb->plmn.mnc, + hnb->cell_identity, hnb->lac, + hnb->rac, hnb->sac, hnb->rnc_id); + rc = llsk_send(hnb->llsk.state, llsk_msg); + if (rc < 0) { + LOGP(DHNBAP, LOGL_NOTICE, "Failed configuring lower layers after HnbRegisterAccept\n"); + } + } + return rc; } static int hnb_rx_hnb_register_rej(struct hnb *hnb, ANY_t *in) @@ -56,6 +71,8 @@ int rc; HNBAP_HNBRegisterRejectIEs_t reject; + hnb->registered = false; + rc = hnbap_decode_hnbregisterrejecties(&reject, in); if (rc < 0) { LOGP(DHNBAP, LOGL_NOTICE, "Rx HNB Register Reject: parse failure\n"); diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c new file mode 100644 index 0000000..dee7477 --- /dev/null +++ b/src/osmo-hnodeb/llsk.c @@ -0,0 +1,306 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include + +static void llsk_close(struct llsk_state *state); + +struct llsk_state *llsk_alloc(struct hnb *hnb) +{ + struct llsk_state *state; + state = talloc_zero(NULL, struct llsk_state); + if (!state) + return NULL; + + INIT_LLIST_HEAD(&state->upqueue); + state->hnb = hnb; + state->conn_bfd.fd = -1; + state->listen_bfd.fd = -1; + return state; +} + +void llsk_free(struct llsk_state *state) +{ + struct osmo_fd *bfd, *conn_bfd; + + if (!state) + return; + + conn_bfd = &state->conn_bfd; + if (conn_bfd->fd > 0) + llsk_close(state); + bfd = &state->listen_bfd; + close(bfd->fd); + osmo_fd_unregister(bfd); + talloc_free(state); +} + +static int llsk_rx(struct hnb *hnb, struct hnb_prim_hdr *hdr, unsigned len) +{ + switch (hdr->sap) { + case HNB_PRIM_SAPI_CTL: + return llsk_rx_ctl(hnb, ((struct hnb_ctl_prim *)hdr), len); + case HNB_PRIM_SAPI_IUH: + return llsk_rx_iuh(hnb, ((struct hnb_iuh_prim *)hdr), len); + case HNB_PRIM_SAPI_GTP: + case HNB_PRIM_SAPI_AUDIO: + LOGP(DLLSK, LOGL_ERROR, "Rx SAPI %u not yet implemented (len=%u)\n", hdr->sap, len); + return -EINVAL; + default: + LOGP(DLLSK, LOGL_ERROR, "Rx for unknwon SAPI %u (len=%u)\n", hdr->sap, len); + return -EINVAL; + } +} + +static int llsk_read(struct osmo_fd *bfd) +{ + struct llsk_state *state = (struct llsk_state *)bfd->data; + struct hnb_prim_hdr *hdr; + struct msgb *msg; + int rc; + + msg = msgb_alloc(1000, "llsk_rx"); + if (!msg) + return -ENOMEM; + + hdr = (struct hnb_prim_hdr *) msg->tail; + + rc = recv(bfd->fd, msg->tail, msgb_tailroom(msg), 0); + if (rc == 0) + goto close; + + if (rc < 0) { + if (errno == EAGAIN) { + msgb_free(msg); + return 0; + } + goto close; + } + + if (rc < sizeof(struct hnb_prim_hdr)) { + LOGP(DLLSK, LOGL_ERROR, "Received %d bytes on PCU Socket, but primitive hdr size " + "is %zu, discarding\n", rc, sizeof(struct hnb_prim_hdr)); + msgb_free(msg); + return 0; + } + + rc = llsk_rx(state->hnb, hdr, rc); + + /* as we always synchronously process the message in llsk_rx() and + * its callbacks, we can free the message here. */ + msgb_free(msg); + + return rc; + +close: + msgb_free(msg); + llsk_close(state); + return -1; +} + +static int llsk_write(struct osmo_fd *bfd) +{ + struct llsk_state *state = bfd->data; + int rc; + + while (!llist_empty(&state->upqueue)) { + struct msgb *msg, *msg2; + + /* peek at the beginning of the queue */ + msg = llist_entry(state->upqueue.next, struct msgb, list); + + osmo_fd_write_disable(bfd); + + if (!msgb_length(msg)) { + LOGP(DLLSK, LOGL_ERROR, "message with ZERO " + "bytes!\n"); + goto dontsend; + } + + /* try to send it over the socket */ + rc = write(bfd->fd, msgb_data(msg), msgb_length(msg)); + if (rc == 0) + goto close; + if (rc < 0) { + if (errno == EAGAIN) { + osmo_fd_write_enable(bfd); + break; + } + goto close; + } + +dontsend: + /* _after_ we send it, we can deueue */ + msg2 = msgb_dequeue(&state->upqueue); + assert(msg == msg2); + msgb_free(msg); + } + return 0; + +close: + llsk_close(state); + + return -1; +} + +static int llsk_bfd_cb(struct osmo_fd *bfd, unsigned int flags) +{ + int rc = 0; + + if (flags & OSMO_FD_READ) + rc = llsk_read(bfd); + if (rc < 0) + return rc; + + if (flags & OSMO_FD_WRITE) + rc = llsk_write(bfd); + + return rc; +} + +/* accept connection coming from PCU */ +static int llsk_accept(struct osmo_fd *bfd, unsigned int flags) +{ + struct llsk_state *state = (struct llsk_state *)bfd->data; + struct osmo_fd *conn_bfd = &state->conn_bfd; + struct sockaddr_un un_addr; + socklen_t len; + int rc; + + len = sizeof(un_addr); + rc = accept(bfd->fd, (struct sockaddr *) &un_addr, &len); + if (rc < 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed to accept a new connection\n"); + return -1; + } + + if (conn_bfd->fd >= 0) { + LOGP(DLLSK, LOGL_NOTICE, "LL UD Socket connects but we already have " + "another active connection ?!?\n"); + /* We already have one LLSK connected, this is all we support */ + state->listen_bfd.when &= ~OSMO_FD_READ; + close(rc); + return 0; + } + + osmo_fd_setup(conn_bfd, rc, OSMO_FD_READ, llsk_bfd_cb, state, 0); + + if (osmo_fd_register(conn_bfd) != 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed to register new connection fd\n"); + close(conn_bfd->fd); + conn_bfd->fd = -1; + return -1; + } + + LOGP(DLLSK, LOGL_NOTICE, "LL UD socket connected\n"); + + return 0; +} + +int llsk_open(struct llsk_state *state, const char *path) +{ + struct osmo_fd *bfd = &state->listen_bfd; + int rc; + + rc = osmo_sock_unix_init(SOCK_SEQPACKET, 0, path, OSMO_SOCK_F_BIND); + if (rc < 0) { + LOGP(DLLSK, LOGL_ERROR, "Could not create %s unix socket: %s\n", + path, strerror(errno)); + return -1; + } + + osmo_fd_setup(bfd, rc, OSMO_FD_READ, llsk_accept, state, 0); + + rc = osmo_fd_register(bfd); + if (rc < 0) { + LOGP(DLLSK, LOGL_ERROR, "Could not register listen fd: %d\n", + rc); + close(bfd->fd); + bfd->fd = -1; + return rc; + } + + LOGP(DLLSK, LOGL_INFO, "Started listening on Lower Layer Unix Domain Socket: %s\n", path); + + return 0; +} + +static void llsk_close(struct llsk_state *state) +{ + struct osmo_fd *bfd = &state->conn_bfd; + + close(bfd->fd); + bfd->fd = -1; + osmo_fd_unregister(bfd); + + /* re-enable the generation of ACCEPT for new connections */ + osmo_fd_read_enable(&state->listen_bfd); + + /* flush the queue */ + while (!llist_empty(&state->upqueue)) { + struct msgb *msg = msgb_dequeue(&state->upqueue); + msgb_free(msg); + } +} + +int llsk_send(struct llsk_state *state, struct msgb *msg) +{ + struct osmo_fd *conn_bfd; + + if (!state) { + LOGP(DLLSK, LOGL_INFO, "LL UD socket not created, dropping message\n"); + msgb_free(msg); + return -EINVAL; + } + conn_bfd = &state->conn_bfd; + if (conn_bfd->fd <= 0) { + LOGP(DLLSK, LOGL_NOTICE, "LL UD socket not connected, dropping message\n"); + msgb_free(msg); + return -EIO; + } + msgb_enqueue(&state->upqueue, msg); + osmo_fd_write_enable(conn_bfd); + + return 0; +} + +bool llsk_connected(const struct llsk_state *state) +{ + if (!state) + return false; + if (state->conn_bfd.fd <= 0) + return false; + return true; +} diff --git a/src/osmo-hnodeb/llsk_ctl.c b/src/osmo-hnodeb/llsk_ctl.c new file mode 100644 index 0000000..c6b0f55 --- /dev/null +++ b/src/osmo-hnodeb/llsk_ctl.c @@ -0,0 +1,144 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include + +static size_t llsk_ctl_prim_size_tbl[4][_HNB_CTL_PRIM_MAX] = { + [PRIM_OP_REQUEST] = {}, + [PRIM_OP_RESPONSE] = {}, + [PRIM_OP_INDICATION] = { + [HNB_CTL_PRIM_HELLO] = sizeof(struct hnb_ctl_hello_ind_param), + }, + [PRIM_OP_CONFIRM] = { + [HNB_CTL_PRIM_HELLO] = sizeof(struct hnb_ctl_hello_cnf_param), + }, +}; +static inline size_t llsk_ctl_prim_size(enum hnb_ctl_prim_type ptype, enum osmo_prim_operation op) +{ + return llsk_ctl_prim_size_tbl[op][ptype]; +} + +const struct value_string hnb_ctl_prim_type_names[] = { + OSMO_VALUE_STRING(HNB_CTL_PRIM_HELLO), + { 0, NULL } +}; + +struct msgb *llsk_ctl_msgb_alloc(enum hnb_ctl_prim_type ptype, enum osmo_prim_operation op) +{ + struct msgb *msg; + struct hnb_ctl_prim *ctl_prim; + size_t len = sizeof(ctl_prim->hdr) + llsk_ctl_prim_size(ptype, op); + + msg = msgb_alloc(len, "llsk_ctl_tx"); + if (!msg) + return NULL; + msgb_put(msg, len); + ctl_prim = (struct hnb_ctl_prim *) msg->data; + ctl_prim->hdr.sap = HNB_PRIM_SAPI_CTL; + ctl_prim->hdr.primitive = ptype; + ctl_prim->hdr.operation = op; + + return msg; +} + +static struct msgb *hnb_ctl_makeprim_hello_cnf(uint16_t api_version) +{ + struct msgb *msg; + struct hnb_ctl_prim *ctl_prim; + + msg = llsk_ctl_msgb_alloc(HNB_CTL_PRIM_HELLO, PRIM_OP_CONFIRM); + ctl_prim = (struct hnb_ctl_prim *)msgb_data(msg); + ctl_prim->u.hello_cnf.api_version = api_version; + + return msg; +} + +static int llsk_rx_ctl_hello_ind(struct hnb *hnb, struct hnb_ctl_hello_ind_param *hello_ind) +{ + struct msgb *llsk_msg; + int rc; + + LOGP(DLLSK, LOGL_NOTICE, "Rx CTL::HELLO.ind API_VERSION=%u\n", hello_ind->api_version); + + LOGP(DLLSK, LOGL_NOTICE, "Tx CTL::HELLO.cnf API_VERSION=%u\n", hello_ind->api_version); + llsk_msg = hnb_ctl_makeprim_hello_cnf(HNB_CTL_PRIM_HELLO); + if ((rc = llsk_send(hnb->llsk.state, llsk_msg)) < 0) + LOGP(DHNBAP, LOGL_ERROR, "Failed sending CTL::HELLO.cnf\n"); + + if (hnb->registered) { + LOGP(DLLSK, LOGL_INFO, "Tx CTL::CONFIGURE.req API_VERSION=%u\n", hello_ind->api_version); + /* We are already registered, so configure the lower layers right now */ + llsk_msg = hnb_iuh_makeprim_configure_req(hnb->plmn.mcc, hnb->plmn.mnc, + hnb->cell_identity, hnb->lac, + hnb->rac, hnb->sac, hnb->rnc_id); + if ((rc = llsk_send(hnb->llsk.state, llsk_msg)) < 0) + LOGP(DHNBAP, LOGL_ERROR, "Failed sending IUH::CONFIGURE.req\n"); + } + return rc; +} + +int llsk_rx_ctl(struct hnb *hnb, struct hnb_ctl_prim *ctl, unsigned len) +{ + size_t prim_size = sizeof(ctl->hdr) + llsk_ctl_prim_size(ctl->hdr.primitive, ctl->hdr.operation); + + if (len < prim_size) { + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-ctl %s::%s with length %u < %zu\n", + get_value_string(hnb_iuh_prim_type_names, ctl->hdr.primitive), + get_value_string(osmo_prim_op_names, ctl->hdr.operation), + len, prim_size); + return -EINVAL; + } + + switch (ctl->hdr.operation) { + case PRIM_OP_INDICATION: + switch (ctl->hdr.primitive) { + case HNB_CTL_PRIM_HELLO: + return llsk_rx_ctl_hello_ind(hnb, &ctl->u.hello_ind); + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-ctl unknown primitive %u (len=%u)\n", ctl->hdr.primitive, len); + return -EINVAL; + } + break; + + case PRIM_OP_RESPONSE: + case PRIM_OP_REQUEST: + case PRIM_OP_CONFIRM: + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-ctl unexpected primitive operation %s::%s (len=%u)\n", + get_value_string(hnb_iuh_prim_type_names, ctl->hdr.primitive), + get_value_string(osmo_prim_op_names, ctl->hdr.operation), len); + return -EINVAL; + } +} diff --git a/src/osmo-hnodeb/llsk_iuh.c b/src/osmo-hnodeb/llsk_iuh.c new file mode 100644 index 0000000..b5c13d7 --- /dev/null +++ b/src/osmo-hnodeb/llsk_iuh.c @@ -0,0 +1,103 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include + +static size_t llsk_iuh_prim_size_tbl[4][_HNB_IUH_PRIM_MAX] = { + [PRIM_OP_REQUEST] = { + [HNB_IUH_PRIM_CONFIGURE] = sizeof(struct hnb_iuh_configure_req_param), + }, + [PRIM_OP_RESPONSE] = {}, + [PRIM_OP_INDICATION] = {}, + [PRIM_OP_CONFIRM] = {}, +}; +static inline size_t llsk_iuh_prim_size(enum hnb_iuh_prim_type ptype, enum osmo_prim_operation op) +{ + return llsk_iuh_prim_size_tbl[op][ptype]; +} + +const struct value_string hnb_iuh_prim_type_names[] = { + OSMO_VALUE_STRING(HNB_IUH_PRIM_CONFIGURE), + { 0, NULL } +}; + + +struct msgb *llsk_iuh_msgb_alloc(enum hnb_iuh_prim_type ptype, enum osmo_prim_operation op) +{ + struct msgb *msg; + struct hnb_iuh_prim *iuh_prim; + size_t len = sizeof(iuh_prim->hdr) + llsk_iuh_prim_size(ptype, op); + + msg = msgb_alloc(len, "llsk_iuh_tx"); + if (!msg) + return NULL; + msgb_put(msg, len); + iuh_prim = (struct hnb_iuh_prim *) msg->data; + iuh_prim->hdr.sap = HNB_PRIM_SAPI_IUH; + iuh_prim->hdr.primitive = ptype; + iuh_prim->hdr.operation = op; + + return msg; +} + +struct msgb *hnb_iuh_makeprim_configure_req(uint16_t mcc, uint16_t mnc, + uint16_t cell_identity, + uint16_t lac, uint8_t rac, + uint16_t sac, uint16_t rnc_id) +{ + struct msgb *msg; + struct hnb_iuh_prim *iuh_prim; + + msg = llsk_iuh_msgb_alloc(HNB_IUH_PRIM_CONFIGURE, PRIM_OP_REQUEST); + iuh_prim = (struct hnb_iuh_prim *)msgb_data(msg); + iuh_prim->u.configure_req.mcc = mcc; + iuh_prim->u.configure_req.mnc = mnc; + iuh_prim->u.configure_req.cell_identity = cell_identity; + iuh_prim->u.configure_req.lac = lac; + iuh_prim->u.configure_req.rac = rac; + iuh_prim->u.configure_req.sac = sac; + iuh_prim->u.configure_req.rnc_id = rnc_id; + + return msg; +} + +int llsk_rx_iuh(struct hnb *hnb, struct hnb_iuh_prim *iuh, unsigned len) +{ + switch (iuh->hdr.primitive) { + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-iuh unknown primitive %u (len=%u)\n", iuh->hdr.primitive, len); + return -EINVAL; + } +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 12d98ff..b8a883b 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -265,6 +265,13 @@ exit(1); } + /* Start listening on lower layer unix domain socket: */ + rc = llsk_open(g_hnb->llsk.state, g_hnb->llsk.sock_path); + if (rc < 0) { + perror("Error opening lower layer socket"); + exit(1); + } + rc = hnb_iuh_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index e11fc2d..1331e59 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -47,6 +47,10 @@ vty->node = HNODEB_NODE; vty->index = g_hnb; break; + case LLSK_NODE: + vty->node = HNODEB_NODE; + vty->index = g_hnb; + break; case HNODEB_NODE: vty->node = CONFIG_NODE; vty->index = g_hnb; @@ -247,6 +251,36 @@ return CMD_SUCCESS; } +static struct cmd_node llsk_node = { + LLSK_NODE, + "%s(config-ll-socket)# ", + 1, +}; + +#define LLSK_STR "Configure the Lower Layer Unix Domain Socket\n" + +DEFUN(cfg_hnodeb_llsk, + cfg_hnodeb_llsk_cmd, + "ll-socket", LLSK_STR) +{ + OSMO_ASSERT(g_hnb); + vty->index = g_hnb; + vty->node = LLSK_NODE; + + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_llsk_path, cfg_hnodeb_llsk_path_cmd, + "path PATH", + "Configure the Lower Layer Unix Domain Socket path\n" + "UNIX socket path\n") +{ + osmo_talloc_replace_string(g_hnb, &g_hnb->llsk.sock_path, argv[0]); + + /* FIXME: re-open the interface? */ + return CMD_SUCCESS; +} + static int config_write_hnodeb(struct vty *vty) { @@ -266,6 +300,8 @@ vty_out(vty, " local-port %u%s", g_hnb->iuh.local_port, VTY_NEWLINE); vty_out(vty, " remote-ip %s%s", g_hnb->iuh.remote_addr, VTY_NEWLINE); vty_out(vty, " remote-port %u%s", g_hnb->iuh.remote_port, VTY_NEWLINE); + vty_out(vty, " ll-socket%s", VTY_NEWLINE); + vty_out(vty, " path %s%s", g_hnb->llsk.sock_path, VTY_NEWLINE); return CMD_SUCCESS; } @@ -387,6 +423,9 @@ install_element(IUH_NODE, &cfg_hnodeb_iuh_local_port_cmd); install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_ip_cmd); install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_port_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_llsk_cmd); + install_node(&llsk_node, NULL); + install_element(LLSK_NODE, &cfg_hnodeb_llsk_path_cmd); install_element_ve(&asn_dbg_cmd); install_element_ve(&hnb_register_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:18:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:18:16 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for osmo-hnodeb-master References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26358 ) Change subject: Introduce Docker image for osmo-hnodeb-master ...................................................................... Introduce Docker image for osmo-hnodeb-master Change-Id: I35e5324d981be8130fbc4e6dcd3e8933181e6821 --- M make/Makefile A osmo-hnodeb-master/Dockerfile A osmo-hnodeb-master/Makefile A osmo-hnodeb-master/osmo-hnodeb.cfg 4 files changed, 78 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/58/26358/1 diff --git a/make/Makefile b/make/Makefile index edb0890..a9790cf 100644 --- a/make/Makefile +++ b/make/Makefile @@ -26,6 +26,7 @@ OSMO_GGSN_BRANCH?=master OSMO_GSM_TESTER_BRANCH?=master OSMO_HLR_BRANCH?=master +OSMO_HNODEB_BRANCH?=master OSMO_IUH_BRANCH?=master OSMO_MGW_BRANCH?=master OSMO_MSC_BRANCH?=master @@ -100,6 +101,7 @@ --build-arg OSMO_GGSN_BRANCH=$(OSMO_GGSN_BRANCH) \ --build-arg OSMO_GSM_TESTER_BRANCH=$(OSMO_GSM_TESTER_BRANCH) \ --build-arg OSMO_HLR_BRANCH=$(OSMO_HLR_BRANCH) \ + --build-arg OSMO_HNODEB_BRANCH=$(OSMO_HNODEB_BRANCH) \ --build-arg OSMO_IUH_BRANCH=$(OSMO_IUH_BRANCH) \ --build-arg OSMO_MGW_BRANCH=$(OSMO_MGW_BRANCH) \ --build-arg OSMO_MSC_BRANCH=$(OSMO_MSC_BRANCH) \ diff --git a/osmo-hnodeb-master/Dockerfile b/osmo-hnodeb-master/Dockerfile new file mode 100644 index 0000000..1a3ded9 --- /dev/null +++ b/osmo-hnodeb-master/Dockerfile @@ -0,0 +1,51 @@ +ARG USER +ARG DISTRO +FROM $USER/$DISTRO-build +# Arguments used after FROM must be specified again +ARG DISTRO + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + libosmocore-dev \ + libosmo-abis-dev \ + libosmo-netif-dev \ + libosmo-sigtran-dev \ + libasn1c-dev && \ + apt-get clean + +WORKDIR /tmp + +ARG OSMO_IUH_BRANCH="master" + +RUN git clone git://git.osmocom.org/osmo-iuh.git +ADD http://git.osmocom.org/osmo-iuh/patch?h=$OSMO_IUH_BRANCH /tmp/commit-osmo-iuh + +RUN cd osmo-iuh && \ + git fetch && git checkout $OSMO_IUH_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_IUH_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + autoreconf -fi && \ + ./configure && \ + make "-j$(nproc)" install && \ + ldconfig + +ARG OSMO_HNODEB_BRANCH="master" + +RUN git clone git://git.osmocom.org/osmo-hnodeb.git +ADD http://git.osmocom.org/osmo-hnodeb/patch?h=$OSMO_HNODEB_BRANCH /tmp/commit-osmo-hnodeb + +RUN cd osmo-hnodeb && \ + git fetch && git checkout $OSMO_HNODEB_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_HNODEB_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + autoreconf -fi && \ + ./configure && \ + make "-j$(nproc)" install && \ + ldconfig + +VOLUME /data + +COPY osmo-hnodeb.cfg /data/osmo-hnodeb.cfg + +WORKDIR /data +CMD ["/bin/sh", "-c", "/usr/local/bin/osmo-hnodeb -c /data/osmo-hnodeb.cfg >/data/osmo-hnodeb.log 2>&1"] diff --git a/osmo-hnodeb-master/Makefile b/osmo-hnodeb-master/Makefile new file mode 100644 index 0000000..47c3999 --- /dev/null +++ b/osmo-hnodeb-master/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=--rm --network sigtran --ip 172.18.0.170 -v hnbgw-vol:/data + +include ../make/Makefile diff --git a/osmo-hnodeb-master/osmo-hnodeb.cfg b/osmo-hnodeb-master/osmo-hnodeb.cfg new file mode 100644 index 0000000..b41c67b --- /dev/null +++ b/osmo-hnodeb-master/osmo-hnodeb.cfg @@ -0,0 +1,22 @@ +! +! OsmoHNodeB (0) configuration saved from vty +!! +! +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging timestamp 1 + logging print extended-timestamp 1 + logging level set-all debug +line vty + no login + bind 0.0.0.0 +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 0.0.0.0 + remote-ip 192.168.30.1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I35e5324d981be8130fbc4e6dcd3e8933181e6821 Gerrit-Change-Number: 26358 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:18:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:18:17 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for ttcn-hnodeb-test References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26359 ) Change subject: Introduce Docker image for ttcn-hnodeb-test ...................................................................... Introduce Docker image for ttcn-hnodeb-test Change-Id: I191b9a29c75d0a1f0bc38d4e29facfc45826cd31 --- A ttcn3-hnodeb-test/Dockerfile A ttcn3-hnodeb-test/HNB_Tests.cfg A ttcn3-hnodeb-test/Makefile A ttcn3-hnodeb-test/jenkins.sh A ttcn3-hnodeb-test/osmo-hnodeb.cfg 5 files changed, 101 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/59/26359/1 diff --git a/ttcn3-hnodeb-test/Dockerfile b/ttcn3-hnodeb-test/Dockerfile new file mode 100644 index 0000000..9659dd1 --- /dev/null +++ b/ttcn3-hnodeb-test/Dockerfile @@ -0,0 +1,13 @@ +ARG REGISTRY +ARG USER +FROM $REGISTRY/$USER/debian-stretch-titan +ARG OSMO_TTCN3_BRANCH="master" + +ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit +RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" hnodeb + +VOLUME /data + +COPY HNB_Tests.cfg /data/HNB_Tests.cfg + +CMD ttcn3-docker-run hnodeb HNB_Tests diff --git a/ttcn3-hnodeb-test/HNB_Tests.cfg b/ttcn3-hnodeb-test/HNB_Tests.cfg new file mode 100644 index 0000000..9190e1b --- /dev/null +++ b/ttcn3-hnodeb-test/HNB_Tests.cfg @@ -0,0 +1,19 @@ +[ORDERED_INCLUDE] +"/osmo-ttcn3-hacks/Common.cfg" +"/osmo-ttcn3-hacks/hnodeb/HNB_Tests.default" + +[LOGGING] +*.JUnitLogger.testsuite_name := "HNB_Tests" + +[TESTPORT_PARAMETERS] +*.HNBVTY.CTRL_HOSTNAME := "172.18.33.20"; +*.STATSVTY.CTRL_HOSTNAME := "172.18.33.20"; + +[MODULE_PARAMETERS] +HNB_Tests.mp_hnodeb_ip := "172.18.33.20"; +HNB_Tests.mp_hnbgw_iuh_ip := "172.18.33.203"; + +[MAIN_CONTROLLER] + +[EXECUTE] +HNB_Tests.control diff --git a/ttcn3-hnodeb-test/Makefile b/ttcn3-hnodeb-test/Makefile new file mode 100644 index 0000000..ce2919e --- /dev/null +++ b/ttcn3-hnodeb-test/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.33.202 -v ggsn-test-vol:/data + +include ../make/Makefile diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh new file mode 100755 index 0000000..6ffa98a --- /dev/null +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -0,0 +1,41 @@ +#!/bin/sh + +. ../jenkins-common.sh +IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" +docker_images_require \ + "osmo-hnodeb-$IMAGE_SUFFIX" \ + "ttcn3-hnodeb-test" + +set_clean_up_trap +set -e + +mkdir $VOL_BASE_DIR/hnodeb-tester +cp HNB_Tests.cfg $VOL_BASE_DIR/hnodeb-tester/ + +mkdir $VOL_BASE_DIR/hnodeb +cp osmo-hnodeb.cfg $VOL_BASE_DIR/hnodeb/ + +SUBNET=33 +network_create $SUBNET + +echo Starting container with HNodeB +docker run --rm \ + $(docker_network_params $SUBNET 20) \ + --ulimit core=-1 \ + -v $VOL_BASE_DIR/hnodeb:/data \ + --name ${BUILD_TAG}-hnodeb -d \ + $DOCKER_ARGS \ + $REPO_USER/osmo-hnodeb-$IMAGE_SUFFIX + +echo Starting container with HNodeB testsuite +docker run --rm \ + $(docker_network_params $SUBNET 203) \ + --ulimit core=-1 \ + -e "TTCN3_PCAP_PATH=/data" \ + -v $VOL_BASE_DIR/hnodeb-tester:/data \ + --name ${BUILD_TAG}-ttcn3-hnodeb-test \ + $DOCKER_ARGS \ + $REPO_USER/ttcn3-hnodeb-test + +echo Stopping containers +docker container kill ${BUILD_TAG}-hnodeb diff --git a/ttcn3-hnodeb-test/osmo-hnodeb.cfg b/ttcn3-hnodeb-test/osmo-hnodeb.cfg new file mode 100644 index 0000000..e3925e8 --- /dev/null +++ b/ttcn3-hnodeb-test/osmo-hnodeb.cfg @@ -0,0 +1,25 @@ +! +log gsmtap 172.18.33.203 + logging level set-all debug + logging filter all 1 +! +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging timestamp 1 + logging print extended-timestamp 1 + logging level set-all debug +! +line vty + no login + bind 172.18.33.20 +! +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 172.18.33.20 + remote-ip 172.18.33.203 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I191b9a29c75d0a1f0bc38d4e29facfc45826cd31 Gerrit-Change-Number: 26359 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:26:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:26:27 +0000 Subject: Change in osmo-hnodeb[master]: Move Iuh code to its own module In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 to look at the new patch set (#2). Change subject: Move Iuh code to its own module ...................................................................... Move Iuh code to its own module The Iuh code will be further extended next to properly support reconnect, and hnb will also gain proper shutdown support soon. Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/iuh.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 10 files changed, 219 insertions(+), 146 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/41/26341/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de Gerrit-Change-Number: 26341 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:26:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:26:27 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 to look at the new patch set (#3). Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Implement initial shutdown + reconnect FSM The shutdown_fsm doesn't do much right now, but it's included there in order to allow easy clean up of resources upon Iuh reconnect in the future, as well as reset the lower layers. Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 --- M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_shutdown_fsm.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/hnb.c A src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/iuh.c 7 files changed, 202 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/48/26348/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:26:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:26:27 +0000 Subject: Change in osmo-hnodeb[master]: hnbap: Improve rx path and implement HnbRegisterReject In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 to look at the new patch set (#3). Change subject: hnbap: Improve rx path and implement HnbRegisterReject ...................................................................... hnbap: Improve rx path and implement HnbRegisterReject The process is shut down if we receive such a message. Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a --- M src/osmo-hnodeb/hnbap.c 1 file changed, 78 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/49/26349/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a Gerrit-Change-Number: 26349 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 20:31:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 20:31:48 +0000 Subject: Change in osmo-hnodeb[master]: hnbap: Improve rx path and implement HnbRegisterReject In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 to look at the new patch set (#4). Change subject: hnbap: Improve rx path and implement HnbRegisterReject ...................................................................... hnbap: Improve rx path and implement HnbRegisterReject The process is shut down if we receive such a message. Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a --- M src/osmo-hnodeb/hnbap.c 1 file changed, 78 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/49/26349/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a Gerrit-Change-Number: 26349 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:48:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:48:00 +0000 Subject: Change in libosmocore[master]: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LO... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26356 ) Change subject: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LOGGING ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26356/1/include/osmocom/core/logging.h File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/26356/1/include/osmocom/core/logging.h at 20 PS1, Line 20: #endif style-wise I would have done #ifndef LIBOSMOCORE_NO_LOGGING #ifndef DEBUG #define DEBUG #endif #endif but I guess your version is equally understandable. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I589f93d98a6bc5cf6221c56e2fe3f27bfdd200e8 Gerrit-Change-Number: 26356 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:48:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:50:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:50:13 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c at 1349 PS1, Line 1349: rxlev2dbm(mrc->rxlev) > rxlev2dbm(foo) takes foo in RXLEV units and returns a value in RSSI units right? RXLEV is the GSM mnemonic for a value that is not normalized to 0 dBm but to -110 dBm. So if you want to print the raw value (positive 0..63) it will be RxLev. If you want to print the "receive level" or "received power" or whatever then it is the [negative] dBm value. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:50:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:50:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:50:27 +0000 Subject: Change in libosmo-sccp[master]: ss7: Use sctp value_string from libosmo-netif In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26347 ) Change subject: ss7: Use sctp value_string from libosmo-netif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I42323eb5d02d4f67daac7b0a4365f5f6f6057666 Gerrit-Change-Number: 26347 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:50:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:50:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:50:29 +0000 Subject: Change in libosmo-sccp[master]: ss7: Use sctp value_string from libosmo-netif In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26347 ) Change subject: ss7: Use sctp value_string from libosmo-netif ...................................................................... ss7: Use sctp value_string from libosmo-netif Depends: libosmo-netif Change-Id Ica6f01851fb94e31f4ef097494bb1b8a95597ba6 Change-Id: I42323eb5d02d4f67daac7b0a4365f5f6f6057666 --- M TODO-RELEASE M src/osmo_ss7.c 2 files changed, 4 insertions(+), 30 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index d0852fc..9e75c9a 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-netif >1.1.0 use of netif/sctp.h diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index b4c0b51..649e3f7 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -45,6 +45,7 @@ #include #include +#include #include "sccp_internal.h" #include "xua_internal.h" @@ -1663,32 +1664,6 @@ * libosmo-netif integration for SCTP stream server/client ***********************************************************************/ -static const struct value_string sctp_assoc_chg_vals[] = { - { SCTP_COMM_UP, "COMM_UP" }, - { SCTP_COMM_LOST, "COMM_LOST" }, - { SCTP_RESTART, "RESTART" }, - { SCTP_SHUTDOWN_COMP, "SHUTDOWN_COMP" }, - { SCTP_CANT_STR_ASSOC, "CANT_STR_ASSOC" }, - { 0, NULL } -}; - -static const struct value_string sctp_sn_type_vals[] = { - { SCTP_ASSOC_CHANGE, "ASSOC_CHANGE" }, - { SCTP_PEER_ADDR_CHANGE, "PEER_ADDR_CHANGE" }, - { SCTP_SHUTDOWN_EVENT, "SHUTDOWN_EVENT" }, - { SCTP_SEND_FAILED, "SEND_FAILED" }, - { SCTP_REMOTE_ERROR, "REMOTE_ERROR" }, - { SCTP_PARTIAL_DELIVERY_EVENT, "PARTIAL_DELIVERY_EVENT" }, - { SCTP_ADAPTATION_INDICATION, "ADAPTATION_INDICATION" }, -#ifdef SCTP_AUTHENTICATION_INDICATION - { SCTP_AUTHENTICATION_INDICATION, "AUTHENTICATION_INDICATION" }, -#endif -#ifdef SCTP_SENDER_DRY_EVENT - { SCTP_SENDER_DRY_EVENT, "SENDER_DRY_EVENT" }, -#endif - { 0, NULL } -}; - static int get_logevel_by_sn_type(int sn_type) { switch (sn_type) { @@ -1728,13 +1703,11 @@ switch (notif->sn_header.sn_type) { case SCTP_ASSOC_CHANGE: LOGPASP(asp, DLSS7, log_level, "%s SCTP_ASSOC_CHANGE: %s\n", - pfx, get_value_string(sctp_assoc_chg_vals, - notif->sn_assoc_change.sac_state)); + pfx, osmo_sctp_assoc_chg_str(notif->sn_assoc_change.sac_state)); break; default: LOGPASP(asp, DLSS7, log_level, "%s %s\n", - pfx, get_value_string(sctp_sn_type_vals, - notif->sn_header.sn_type)); + pfx, osmo_sctp_sn_type_str(notif->sn_header.sn_type)); break; } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I42323eb5d02d4f67daac7b0a4365f5f6f6057666 Gerrit-Change-Number: 26347 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:50:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:50:45 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for osmo-hnodeb-master In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26358 ) Change subject: Introduce Docker image for osmo-hnodeb-master ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I35e5324d981be8130fbc4e6dcd3e8933181e6821 Gerrit-Change-Number: 26358 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:50:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:51:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:51:05 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for ttcn-hnodeb-test In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26359 ) Change subject: Introduce Docker image for ttcn-hnodeb-test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I191b9a29c75d0a1f0bc38d4e29facfc45826cd31 Gerrit-Change-Number: 26359 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:51:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:02 +0000 Subject: Change in osmo-hnodeb[master]: Move Iuh code to its own module In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 ) Change subject: Move Iuh code to its own module ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de Gerrit-Change-Number: 26341 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:52:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:10 +0000 Subject: Change in osmo-hnodeb[master]: Introduce SCTP log category In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 ) Change subject: Introduce SCTP log category ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:52:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:21 +0000 Subject: Change in osmo-hnodeb[master]: iuh: Improve logging of SCTP notifications In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 ) Change subject: iuh: Improve logging of SCTP notifications ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d Gerrit-Change-Number: 26343 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:52:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:28 +0000 Subject: Change in osmo-hnodeb[master]: Fix typos and non-related test content In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 ) Change subject: Fix typos and non-related test content ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I00cce8fbfeef9688dd2fd235cb859c27bd864e8b Gerrit-Change-Number: 26344 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:37 +0000 Subject: Change in osmo-hnodeb[master]: Move Iuh code to its own module In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 ) Change subject: Move Iuh code to its own module ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de Gerrit-Change-Number: 26341 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:40 +0000 Subject: Change in osmo-hnodeb[master]: Move Iuh code to its own module In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 ) Change subject: Move Iuh code to its own module ...................................................................... Move Iuh code to its own module The Iuh code will be further extended next to properly support reconnect, and hnb will also gain proper shutdown support soon. Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/iuh.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 10 files changed, 219 insertions(+), 146 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 197568c..23adb2a 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,6 +1,7 @@ noinst_HEADERS = \ hnbap.h \ hnodeb.h \ + iuh.h \ nas.h \ ranap.h \ rua.h \ diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 5d6d088..4cc0831 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -36,18 +36,6 @@ }; extern const struct log_info hnb_log_info; -/* 25.467 Section 7.1 */ -#define IUH_DEFAULT_SCTP_PORT 29169 -#define RNA_DEFAULT_SCTP_PORT 25471 - -#define IUH_PPI_RUA 19 -#define IUH_PPI_HNBAP 20 -#define IUH_PPI_SABP 31 -#define IUH_PPI_RNA 42 -#define IUH_PPI_PUA 55 - -#define IUH_MSGB_SIZE 2048 - struct hnb_chan { int is_ps; uint32_t conn_id; @@ -77,11 +65,9 @@ struct hnb_chan *chan; } cs; }; + struct hnb *hnb_alloc(void *tall_ctx); void hnb_free(struct hnb *hnb); -int hnb_connect(struct hnb *hnb); - -int hnb_iuh_send(struct hnb *hnb, struct msgb *msg); extern void *tall_hnb_ctx; extern struct hnb *g_hnb; diff --git a/include/osmocom/hnodeb/iuh.h b/include/osmocom/hnodeb/iuh.h new file mode 100644 index 0000000..81ce1de --- /dev/null +++ b/include/osmocom/hnodeb/iuh.h @@ -0,0 +1,41 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +/* 25.467 Section 7.1 */ +#define IUH_DEFAULT_SCTP_PORT 29169 +#define RNA_DEFAULT_SCTP_PORT 25471 + +#define IUH_PPI_RUA 19 +#define IUH_PPI_HNBAP 20 +#define IUH_PPI_SABP 31 +#define IUH_PPI_RNA 42 +#define IUH_PPI_PUA 55 + +#define IUH_MSGB_SIZE 2048 + +struct hnb; + +void hnb_iuh_alloc(struct hnb *hnb); +void hnb_iuh_free(struct hnb *hnb); +int hnb_iuh_connect(struct hnb *hnb); +int hnb_iuh_send(struct hnb *hnb, struct msgb *msg); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 139b6b0..88f2571 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -33,6 +33,7 @@ debug.c \ hnbap.c \ hnb.c \ + iuh.c \ nas.c \ ranap.c \ rua.c \ diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 420095d..3344cfb 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -20,99 +20,17 @@ #include "config.h" -#include - -#include -#include -#include -#include -#include - #include #include #include -#include -#include #include +#include -static int hnb_iuh_read_cb(struct osmo_stream_cli *conn) -{ - struct osmo_fd *fd = osmo_stream_cli_get_ofd(conn); - struct hnb *hnb = osmo_stream_cli_get_data(conn); - struct sctp_sndrcvinfo sinfo; - struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); - int flags = 0; - int rc; - - if (!msg) - return -ENOMEM; - - rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), - NULL, NULL, &sinfo, &flags); - if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); - /* FIXME: clean up after disappeared HNB */ - osmo_stream_cli_close(conn); - goto free_ret; - } else if (rc == 0) { - LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); - osmo_stream_cli_close(conn); - rc = -1; - goto free_ret; - } else { - msgb_put(msg, rc); - } - - if (flags & MSG_NOTIFICATION) { - LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); - rc = 0; - goto free_ret; - } - - sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); - - switch (sinfo.sinfo_ppid) { - case IUH_PPI_HNBAP: - LOGP(DHNBAP, LOGL_INFO, "HNBAP message received\n"); - rc = hnb_hnbap_rx(hnb, msg); - break; - case IUH_PPI_RUA: - LOGP(DRUA, LOGL_INFO, "RUA message received\n"); - rc = hnb_rua_rx(hnb, msg); - break; - case IUH_PPI_SABP: - case IUH_PPI_RNA: - case IUH_PPI_PUA: - LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", - sinfo.sinfo_ppid); - rc = 0; - break; - default: - LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", - sinfo.sinfo_ppid); - rc = 0; - break; - } - -free_ret: - msgb_free(msg); - return rc; -} - -static int hnb_iuh_connect_cb(struct osmo_stream_cli *conn) -{ - LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); - struct hnb *hnb = osmo_stream_cli_get_data(conn); - - hnb_send_register_req(hnb); - return 0; -} struct hnb *hnb_alloc(void *tall_ctx) { struct hnb *hnb; - struct osmo_stream_cli *cli; hnb = talloc_zero(tall_ctx, struct hnb); if (!hnb) @@ -123,58 +41,13 @@ .mcc = 1, .mnc = 1, }; - - hnb->iuh.local_addr = talloc_strdup(hnb, "0.0.0.0"); - hnb->iuh.local_port = 0; - hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); - hnb->iuh.remote_port = IUH_DEFAULT_SCTP_PORT; - - cli = osmo_stream_cli_create(hnb); - OSMO_ASSERT(cli); - hnb->iuh.client = cli; - osmo_stream_cli_set_nodelay(cli, true); - osmo_stream_cli_set_proto(cli, IPPROTO_SCTP); - osmo_stream_cli_set_reconnect_timeout(cli, 5); - osmo_stream_cli_set_connect_cb(cli, hnb_iuh_connect_cb); - osmo_stream_cli_set_read_cb(cli, hnb_iuh_read_cb); - osmo_stream_cli_set_data(cli, hnb); + hnb_iuh_alloc(hnb); return hnb; } void hnb_free(struct hnb *hnb) { - if (hnb->iuh.client) { - osmo_stream_cli_destroy(hnb->iuh.client); - hnb->iuh.client = NULL; - } + hnb_iuh_free(hnb); talloc_free(hnb); } - -int hnb_connect(struct hnb *hnb) -{ - int rc; - - LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", - hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); - - osmo_stream_cli_set_addrs(hnb->iuh.client, (const char**)&hnb->iuh.remote_addr, 1); - osmo_stream_cli_set_port(hnb->iuh.client, hnb->iuh.remote_port); - osmo_stream_cli_set_local_addrs(hnb->iuh.client, (const char**)&hnb->iuh.local_addr, 1); - osmo_stream_cli_set_local_port(hnb->iuh.client, hnb->iuh.local_port); - rc = osmo_stream_cli_open(hnb->iuh.client); - if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", - hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); - /* we don't return error in here because osmo_stream_cli_open() - will continue to retry (due to timeout being explicitly set with - osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */ - } - return 0; -} - -int hnb_iuh_send(struct hnb *hnb, struct msgb *msg) -{ - osmo_stream_cli_send(hnb->iuh.client, msg); - return 0; -} diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index bcddfb3..585354b 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -32,6 +32,7 @@ #include #include +#include static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) { diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c new file mode 100644 index 0000000..bcd047b --- /dev/null +++ b/src/osmo-hnodeb/iuh.c @@ -0,0 +1,167 @@ +/* (C) 2015 by Daniel Willmann + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include + +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include +#include + +static int hnb_iuh_read_cb(struct osmo_stream_cli *conn) +{ + struct osmo_fd *fd = osmo_stream_cli_get_ofd(conn); + struct hnb *hnb = osmo_stream_cli_get_data(conn); + struct sctp_sndrcvinfo sinfo; + struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); + int flags = 0; + int rc; + + if (!msg) + return -ENOMEM; + + rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), + NULL, NULL, &sinfo, &flags); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); + /* FIXME: clean up after disappeared HNB */ + osmo_stream_cli_close(conn); + goto free_ret; + } else if (rc == 0) { + LOGP(DMAIN, LOGL_INFO, "Connection to HNBGW closed\n"); + osmo_stream_cli_close(conn); + rc = -1; + goto free_ret; + } else { + msgb_put(msg, rc); + } + + if (flags & MSG_NOTIFICATION) { + LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); + rc = 0; + goto free_ret; + } + + sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); + + switch (sinfo.sinfo_ppid) { + case IUH_PPI_HNBAP: + LOGP(DHNBAP, LOGL_INFO, "HNBAP message received\n"); + rc = hnb_hnbap_rx(hnb, msg); + break; + case IUH_PPI_RUA: + LOGP(DRUA, LOGL_INFO, "RUA message received\n"); + rc = hnb_rua_rx(hnb, msg); + break; + case IUH_PPI_SABP: + case IUH_PPI_RNA: + case IUH_PPI_PUA: + LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + default: + LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", + sinfo.sinfo_ppid); + rc = 0; + break; + } + +free_ret: + msgb_free(msg); + return rc; +} + +static int hnb_iuh_connect_cb(struct osmo_stream_cli *conn) +{ + LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); + struct hnb *hnb = osmo_stream_cli_get_data(conn); + + hnb_send_register_req(hnb); + return 0; +} + +void hnb_iuh_alloc(struct hnb *hnb) +{ + struct osmo_stream_cli *cli; + + hnb->iuh.local_addr = talloc_strdup(hnb, "0.0.0.0"); + hnb->iuh.local_port = 0; + hnb->iuh.remote_addr = talloc_strdup(hnb, "127.0.0.1"); + hnb->iuh.remote_port = IUH_DEFAULT_SCTP_PORT; + + cli = osmo_stream_cli_create(hnb); + OSMO_ASSERT(cli); + hnb->iuh.client = cli; + osmo_stream_cli_set_nodelay(cli, true); + osmo_stream_cli_set_proto(cli, IPPROTO_SCTP); + osmo_stream_cli_set_reconnect_timeout(cli, 5); + osmo_stream_cli_set_connect_cb(cli, hnb_iuh_connect_cb); + osmo_stream_cli_set_read_cb(cli, hnb_iuh_read_cb); + osmo_stream_cli_set_data(cli, hnb); +} + +void hnb_iuh_free(struct hnb *hnb) +{ + if (!hnb->iuh.client) + return; + osmo_stream_cli_destroy(hnb->iuh.client); + hnb->iuh.client = NULL; +} + +int hnb_iuh_connect(struct hnb *hnb) +{ + int rc; + + LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", + hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); + + osmo_stream_cli_set_addrs(hnb->iuh.client, (const char **)&hnb->iuh.remote_addr, 1); + osmo_stream_cli_set_port(hnb->iuh.client, hnb->iuh.remote_port); + osmo_stream_cli_set_local_addrs(hnb->iuh.client, (const char **)&hnb->iuh.local_addr, 1); + osmo_stream_cli_set_local_port(hnb->iuh.client, hnb->iuh.local_port); + rc = osmo_stream_cli_open(hnb->iuh.client); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", + hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); + /* we don't return error in here because osmo_stream_cli_open() + will continue to retry (due to timeout being explicitly set with + osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */ + } + return 0; +} + +int hnb_iuh_send(struct hnb *hnb, struct msgb *msg) +{ + osmo_stream_cli_send(hnb->iuh.client, msg); + return 0; +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 3376d8e..12d98ff 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -48,6 +48,7 @@ #include #include #include +#include static const char * const osmohnodeb_copyright = "OsmoHNodeB - Osmocom 3G Home NodeB implementation\r\n" @@ -264,7 +265,7 @@ exit(1); } - rc = hnb_connect(g_hnb); + rc = hnb_iuh_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); exit(1); diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 0dd8c3a..907cd60 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -28,6 +28,7 @@ #include #include +#include int hnb_tx_dt(struct hnb *hnb, struct msgb *txm) { diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 61a3f4c..e11fc2d 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -34,6 +34,7 @@ #include #include +#include #include #include #include -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6e94210ab06a34b70c61bb074c58d7b0f4ee75de Gerrit-Change-Number: 26341 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:41 +0000 Subject: Change in osmo-hnodeb[master]: Introduce SCTP log category In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 ) Change subject: Introduce SCTP log category ...................................................................... Introduce SCTP log category Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/iuh.c 3 files changed, 14 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 4cc0831..deb683f 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -32,6 +32,7 @@ DHNBAP, DRUA, DRANAP, + DSCTP, DNAS, }; extern const struct log_info hnb_log_info; diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index f50d8b0..10d1655 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -42,6 +42,11 @@ .color = "\033[1;35m", .description = "RANAP User Adaptation", }, + [DSCTP] = { + .name = "DSCTP", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;36m", + .description = "SCTP connection on the Iuh link", + }, [DNAS] = { .name = "NAS", .loglevel = LOGL_NOTICE, .enabled = 1, .color = "\033[1;32m", diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c index bcd047b..b81b83f 100644 --- a/src/osmo-hnodeb/iuh.c +++ b/src/osmo-hnodeb/iuh.c @@ -52,12 +52,12 @@ rc = sctp_recvmsg(fd->fd, msgb_data(msg), msgb_tailroom(msg), NULL, NULL, &sinfo, &flags); if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n"); + LOGP(DSCTP, LOGL_ERROR, "Error during sctp_recvmsg()\n"); /* FIXME: clean up after disappeared HNB */ osmo_stream_cli_close(conn); goto free_ret; } else if (rc == 0) { - LOGP(DMAIN, LOGL_INFO, "Connection to HNBGW closed\n"); + LOGP(DSCTP, LOGL_INFO, "Connection to HNBGW closed\n"); osmo_stream_cli_close(conn); rc = -1; goto free_ret; @@ -66,7 +66,7 @@ } if (flags & MSG_NOTIFICATION) { - LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); + LOGP(DSCTP, LOGL_DEBUG, "Ignoring SCTP notification\n"); rc = 0; goto free_ret; } @@ -85,12 +85,12 @@ case IUH_PPI_SABP: case IUH_PPI_RNA: case IUH_PPI_PUA: - LOGP(DMAIN, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", + LOGP(DSCTP, LOGL_ERROR, "Unimplemented SCTP PPID=%u received\n", sinfo.sinfo_ppid); rc = 0; break; default: - LOGP(DMAIN, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", + LOGP(DSCTP, LOGL_ERROR, "Unknown SCTP PPID=%u received\n", sinfo.sinfo_ppid); rc = 0; break; @@ -103,7 +103,7 @@ static int hnb_iuh_connect_cb(struct osmo_stream_cli *conn) { - LOGP(DMAIN, LOGL_NOTICE, "Iuh connected to HNBGW\n"); + LOGP(DSCTP, LOGL_NOTICE, "Iuh connected to HNBGW\n"); struct hnb *hnb = osmo_stream_cli_get_data(conn); hnb_send_register_req(hnb); @@ -142,7 +142,7 @@ { int rc; - LOGP(DMAIN, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", + LOGP(DSCTP, LOGL_INFO, "Iuh Connect: %s[:%u] => %s[:%u]\n", hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); osmo_stream_cli_set_addrs(hnb->iuh.client, (const char **)&hnb->iuh.remote_addr, 1); @@ -151,7 +151,7 @@ osmo_stream_cli_set_local_port(hnb->iuh.client, hnb->iuh.local_port); rc = osmo_stream_cli_open(hnb->iuh.client); if (rc < 0) { - LOGP(DMAIN, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", + LOGP(DSCTP, LOGL_ERROR, "Unable to open stream client for Iuh %s[:%u] => %s[:%u]\n", hnb->iuh.local_addr, hnb->iuh.local_port, hnb->iuh.remote_addr, hnb->iuh.remote_port); /* we don't return error in here because osmo_stream_cli_open() will continue to retry (due to timeout being explicitly set with -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2c9cb54958807bd68c04a4c0d3a0f355dd641282 Gerrit-Change-Number: 26342 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:42 +0000 Subject: Change in osmo-hnodeb[master]: iuh: Improve logging of SCTP notifications In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 ) Change subject: iuh: Improve logging of SCTP notifications ...................................................................... iuh: Improve logging of SCTP notifications Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d --- M TODO-RELEASE M src/osmo-hnodeb/iuh.c 2 files changed, 50 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index d0852fc..9e75c9a 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-netif >1.1.0 use of netif/sctp.h diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c index b81b83f..3153206 100644 --- a/src/osmo-hnodeb/iuh.c +++ b/src/osmo-hnodeb/iuh.c @@ -31,12 +31,59 @@ #include #include #include +#include #include #include #include #include +static int get_logevel_by_sn_type(int sn_type) +{ + switch (sn_type) { + case SCTP_ADAPTATION_INDICATION: + case SCTP_PEER_ADDR_CHANGE: +#ifdef SCTP_AUTHENTICATION_INDICATION + case SCTP_AUTHENTICATION_INDICATION: +#endif +#ifdef SCTP_SENDER_DRY_EVENT + case SCTP_SENDER_DRY_EVENT: +#endif + return LOGL_INFO; + case SCTP_ASSOC_CHANGE: + return LOGL_NOTICE; + case SCTP_SHUTDOWN_EVENT: + case SCTP_PARTIAL_DELIVERY_EVENT: + return LOGL_NOTICE; + case SCTP_SEND_FAILED: + case SCTP_REMOTE_ERROR: + return LOGL_ERROR; + default: + return LOGL_NOTICE; + } +} + +static void log_sctp_notification(union sctp_notification *notif) +{ + int log_level; + + LOGP(DSCTP, LOGL_INFO, "Iuh SCTP NOTIFICATION %u flags=0x%0x\n", + notif->sn_header.sn_type, notif->sn_header.sn_flags); + + log_level = get_logevel_by_sn_type(notif->sn_header.sn_type); + + switch (notif->sn_header.sn_type) { + case SCTP_ASSOC_CHANGE: + LOGP(DSCTP, log_level, "Iuh SCTP_ASSOC_CHANGE: %s\n", + osmo_sctp_assoc_chg_str(notif->sn_assoc_change.sac_state)); + break; + default: + LOGP(DSCTP, log_level, "Iuh %s\n", + osmo_sctp_sn_type_str(notif->sn_header.sn_type)); + break; + } +} + static int hnb_iuh_read_cb(struct osmo_stream_cli *conn) { struct osmo_fd *fd = osmo_stream_cli_get_ofd(conn); @@ -66,7 +113,8 @@ } if (flags & MSG_NOTIFICATION) { - LOGP(DSCTP, LOGL_DEBUG, "Ignoring SCTP notification\n"); + union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); + log_sctp_notification(notif); rc = 0; goto free_ret; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I08842665effec6e70a3c7f6b93ea62c45549d69d Gerrit-Change-Number: 26343 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:52:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:52:42 +0000 Subject: Change in osmo-hnodeb[master]: Fix typos and non-related test content In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 ) Change subject: Fix typos and non-related test content ...................................................................... Fix typos and non-related test content Artifacts from initial commits adding the project skeleton. Change-Id: I00cce8fbfeef9688dd2fd235cb859c27bd864e8b --- M README.md M tests/ctrl_test_runner.py 2 files changed, 3 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/README.md b/README.md index 2f09148..835415d 100644 --- a/README.md +++ b/README.md @@ -40,7 +40,7 @@ Mailing List ------------ -Discussions related to osmo-bts are happening on the +Discussions related to osmo-hnodeb are happening on the openbsc at lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive. @@ -60,5 +60,5 @@ https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details -The current patch queue for osmo-bts can be seen at +The current patch queue for osmo-hnodeb can be seen at https://gerrit.osmocom.org/#/q/project:osmo-hnodeb+status:open diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index 8908a65..c0e6a55 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -161,15 +161,7 @@ self.assertEqual(r['mtype'], 'ERROR') self.assertEqual(r['error'], 'Command not found') - r = self.do_set('rf_locked', '999') - self.assertEqual(r['mtype'], 'ERROR') - self.assertEqual(r['error'], 'Value failed verification.') - - r = self.do_get('bts') - self.assertEqual(r['mtype'], 'ERROR') - self.assertEqual(r['error'], 'Error while parsing the index.') - - r = self.do_get('bts.999') + r = self.do_get('hnodeb.999') self.assertEqual(r['mtype'], 'ERROR') self.assertEqual(r['error'], 'Error while resolving object') -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I00cce8fbfeef9688dd2fd235cb859c27bd864e8b Gerrit-Change-Number: 26344 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:53:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:53:13 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 ) Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:53:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 21:54:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Nov 2021 21:54:00 +0000 Subject: Change in osmo-hnodeb[master]: hnbap: Improve rx path and implement HnbRegisterReject In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 ) Change subject: hnbap: Improve rx path and implement HnbRegisterReject ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a Gerrit-Change-Number: 26349 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 21:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 22:20:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Nov 2021 22:20:26 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for osmo-hnodeb-master In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26358 ) Change subject: Introduce Docker image for osmo-hnodeb-master ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I35e5324d981be8130fbc4e6dcd3e8933181e6821 Gerrit-Change-Number: 26358 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Nov 2021 22:20:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 22:22:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 22:22:10 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for osmo-hnodeb-master In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26358 ) Change subject: Introduce Docker image for osmo-hnodeb-master ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I35e5324d981be8130fbc4e6dcd3e8933181e6821 Gerrit-Change-Number: 26358 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 22:22:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 22:22:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 22:22:13 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for ttcn-hnodeb-test In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26359 ) Change subject: Introduce Docker image for ttcn-hnodeb-test ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I191b9a29c75d0a1f0bc38d4e29facfc45826cd31 Gerrit-Change-Number: 26359 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Nov 2021 22:22:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 22:22:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 22:22:29 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for osmo-hnodeb-master In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26358 ) Change subject: Introduce Docker image for osmo-hnodeb-master ...................................................................... Introduce Docker image for osmo-hnodeb-master Change-Id: I35e5324d981be8130fbc4e6dcd3e8933181e6821 --- M make/Makefile A osmo-hnodeb-master/Dockerfile A osmo-hnodeb-master/Makefile A osmo-hnodeb-master/osmo-hnodeb.cfg 4 files changed, 78 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Verified diff --git a/make/Makefile b/make/Makefile index e357803..416fc18 100644 --- a/make/Makefile +++ b/make/Makefile @@ -26,6 +26,7 @@ OSMO_GGSN_BRANCH?=master OSMO_GSM_TESTER_BRANCH?=master OSMO_HLR_BRANCH?=master +OSMO_HNODEB_BRANCH?=master OSMO_IUH_BRANCH?=master OSMO_MGW_BRANCH?=master OSMO_MSC_BRANCH?=master @@ -100,6 +101,7 @@ --build-arg OSMO_GGSN_BRANCH=$(OSMO_GGSN_BRANCH) \ --build-arg OSMO_GSM_TESTER_BRANCH=$(OSMO_GSM_TESTER_BRANCH) \ --build-arg OSMO_HLR_BRANCH=$(OSMO_HLR_BRANCH) \ + --build-arg OSMO_HNODEB_BRANCH=$(OSMO_HNODEB_BRANCH) \ --build-arg OSMO_IUH_BRANCH=$(OSMO_IUH_BRANCH) \ --build-arg OSMO_MGW_BRANCH=$(OSMO_MGW_BRANCH) \ --build-arg OSMO_MSC_BRANCH=$(OSMO_MSC_BRANCH) \ diff --git a/osmo-hnodeb-master/Dockerfile b/osmo-hnodeb-master/Dockerfile new file mode 100644 index 0000000..1a3ded9 --- /dev/null +++ b/osmo-hnodeb-master/Dockerfile @@ -0,0 +1,51 @@ +ARG USER +ARG DISTRO +FROM $USER/$DISTRO-build +# Arguments used after FROM must be specified again +ARG DISTRO + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + libosmocore-dev \ + libosmo-abis-dev \ + libosmo-netif-dev \ + libosmo-sigtran-dev \ + libasn1c-dev && \ + apt-get clean + +WORKDIR /tmp + +ARG OSMO_IUH_BRANCH="master" + +RUN git clone git://git.osmocom.org/osmo-iuh.git +ADD http://git.osmocom.org/osmo-iuh/patch?h=$OSMO_IUH_BRANCH /tmp/commit-osmo-iuh + +RUN cd osmo-iuh && \ + git fetch && git checkout $OSMO_IUH_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_IUH_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + autoreconf -fi && \ + ./configure && \ + make "-j$(nproc)" install && \ + ldconfig + +ARG OSMO_HNODEB_BRANCH="master" + +RUN git clone git://git.osmocom.org/osmo-hnodeb.git +ADD http://git.osmocom.org/osmo-hnodeb/patch?h=$OSMO_HNODEB_BRANCH /tmp/commit-osmo-hnodeb + +RUN cd osmo-hnodeb && \ + git fetch && git checkout $OSMO_HNODEB_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_HNODEB_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + autoreconf -fi && \ + ./configure && \ + make "-j$(nproc)" install && \ + ldconfig + +VOLUME /data + +COPY osmo-hnodeb.cfg /data/osmo-hnodeb.cfg + +WORKDIR /data +CMD ["/bin/sh", "-c", "/usr/local/bin/osmo-hnodeb -c /data/osmo-hnodeb.cfg >/data/osmo-hnodeb.log 2>&1"] diff --git a/osmo-hnodeb-master/Makefile b/osmo-hnodeb-master/Makefile new file mode 100644 index 0000000..47c3999 --- /dev/null +++ b/osmo-hnodeb-master/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=--rm --network sigtran --ip 172.18.0.170 -v hnbgw-vol:/data + +include ../make/Makefile diff --git a/osmo-hnodeb-master/osmo-hnodeb.cfg b/osmo-hnodeb-master/osmo-hnodeb.cfg new file mode 100644 index 0000000..b41c67b --- /dev/null +++ b/osmo-hnodeb-master/osmo-hnodeb.cfg @@ -0,0 +1,22 @@ +! +! OsmoHNodeB (0) configuration saved from vty +!! +! +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging timestamp 1 + logging print extended-timestamp 1 + logging level set-all debug +line vty + no login + bind 0.0.0.0 +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 0.0.0.0 + remote-ip 192.168.30.1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I35e5324d981be8130fbc4e6dcd3e8933181e6821 Gerrit-Change-Number: 26358 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Nov 24 22:22:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Nov 2021 22:22:29 +0000 Subject: Change in docker-playground[master]: Introduce Docker image for ttcn-hnodeb-test In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26359 ) Change subject: Introduce Docker image for ttcn-hnodeb-test ...................................................................... Introduce Docker image for ttcn-hnodeb-test Change-Id: I191b9a29c75d0a1f0bc38d4e29facfc45826cd31 --- A ttcn3-hnodeb-test/Dockerfile A ttcn3-hnodeb-test/HNB_Tests.cfg A ttcn3-hnodeb-test/Makefile A ttcn3-hnodeb-test/jenkins.sh A ttcn3-hnodeb-test/osmo-hnodeb.cfg 5 files changed, 101 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Verified diff --git a/ttcn3-hnodeb-test/Dockerfile b/ttcn3-hnodeb-test/Dockerfile new file mode 100644 index 0000000..9659dd1 --- /dev/null +++ b/ttcn3-hnodeb-test/Dockerfile @@ -0,0 +1,13 @@ +ARG REGISTRY +ARG USER +FROM $REGISTRY/$USER/debian-stretch-titan +ARG OSMO_TTCN3_BRANCH="master" + +ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit +RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" hnodeb + +VOLUME /data + +COPY HNB_Tests.cfg /data/HNB_Tests.cfg + +CMD ttcn3-docker-run hnodeb HNB_Tests diff --git a/ttcn3-hnodeb-test/HNB_Tests.cfg b/ttcn3-hnodeb-test/HNB_Tests.cfg new file mode 100644 index 0000000..9190e1b --- /dev/null +++ b/ttcn3-hnodeb-test/HNB_Tests.cfg @@ -0,0 +1,19 @@ +[ORDERED_INCLUDE] +"/osmo-ttcn3-hacks/Common.cfg" +"/osmo-ttcn3-hacks/hnodeb/HNB_Tests.default" + +[LOGGING] +*.JUnitLogger.testsuite_name := "HNB_Tests" + +[TESTPORT_PARAMETERS] +*.HNBVTY.CTRL_HOSTNAME := "172.18.33.20"; +*.STATSVTY.CTRL_HOSTNAME := "172.18.33.20"; + +[MODULE_PARAMETERS] +HNB_Tests.mp_hnodeb_ip := "172.18.33.20"; +HNB_Tests.mp_hnbgw_iuh_ip := "172.18.33.203"; + +[MAIN_CONTROLLER] + +[EXECUTE] +HNB_Tests.control diff --git a/ttcn3-hnodeb-test/Makefile b/ttcn3-hnodeb-test/Makefile new file mode 100644 index 0000000..ce2919e --- /dev/null +++ b/ttcn3-hnodeb-test/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=--sysctl net.ipv6.conf.all.disable_ipv6=0 --rm --network sigtran --ip 172.18.33.202 -v ggsn-test-vol:/data + +include ../make/Makefile diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh new file mode 100755 index 0000000..6ffa98a --- /dev/null +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -0,0 +1,41 @@ +#!/bin/sh + +. ../jenkins-common.sh +IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" +docker_images_require \ + "osmo-hnodeb-$IMAGE_SUFFIX" \ + "ttcn3-hnodeb-test" + +set_clean_up_trap +set -e + +mkdir $VOL_BASE_DIR/hnodeb-tester +cp HNB_Tests.cfg $VOL_BASE_DIR/hnodeb-tester/ + +mkdir $VOL_BASE_DIR/hnodeb +cp osmo-hnodeb.cfg $VOL_BASE_DIR/hnodeb/ + +SUBNET=33 +network_create $SUBNET + +echo Starting container with HNodeB +docker run --rm \ + $(docker_network_params $SUBNET 20) \ + --ulimit core=-1 \ + -v $VOL_BASE_DIR/hnodeb:/data \ + --name ${BUILD_TAG}-hnodeb -d \ + $DOCKER_ARGS \ + $REPO_USER/osmo-hnodeb-$IMAGE_SUFFIX + +echo Starting container with HNodeB testsuite +docker run --rm \ + $(docker_network_params $SUBNET 203) \ + --ulimit core=-1 \ + -e "TTCN3_PCAP_PATH=/data" \ + -v $VOL_BASE_DIR/hnodeb-tester:/data \ + --name ${BUILD_TAG}-ttcn3-hnodeb-test \ + $DOCKER_ARGS \ + $REPO_USER/ttcn3-hnodeb-test + +echo Stopping containers +docker container kill ${BUILD_TAG}-hnodeb diff --git a/ttcn3-hnodeb-test/osmo-hnodeb.cfg b/ttcn3-hnodeb-test/osmo-hnodeb.cfg new file mode 100644 index 0000000..e3925e8 --- /dev/null +++ b/ttcn3-hnodeb-test/osmo-hnodeb.cfg @@ -0,0 +1,25 @@ +! +log gsmtap 172.18.33.203 + logging level set-all debug + logging filter all 1 +! +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging timestamp 1 + logging print extended-timestamp 1 + logging level set-all debug +! +line vty + no login + bind 172.18.33.20 +! +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 172.18.33.20 + remote-ip 172.18.33.203 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I191b9a29c75d0a1f0bc38d4e29facfc45826cd31 Gerrit-Change-Number: 26359 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Nov 25 00:40:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 25 Nov 2021 00:40:24 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_11/i586 In-Reply-To: References: Message-ID: <619edb8053eee_7c722b09fb2625fc1890b8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_11/i586 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 245s] +{11.000015} [NA|OK] Server's read_cb_srv(): callback triggered [ 245s] +{11.000015} [NA|OK] Server's read_cb_srv(): received 29(29) bytes: 48 69 21 20 66 72 6f 6d 20 63 6f 6e 6e 65 63 74 20 63 61 6c 6c 62 61 63 6b 20 3a 2d 50 [ 245s] +{11.000015} [NA|OK] Server's read_cb_srv(): sent 11 bytes message: 72 65 61 64 5f 63 62 5f 73 72 76 [ 245s] +{11.000015} [OK|OK] Server's read_cb_srv(): keep initial client connection [ 245s] +{11.000017} [NA] Client's read_cb_cli(): callback triggered [ 245s] +{11.000017} [NA] Client's read_cb_cli(): received 11(11) bytes: 72 65 61 64 5f 63 62 5f 73 72 76 [ 245s] +{11.000017} [NA] Client's read_cb_cli(): initial read, contacting server [ 245s] +{11.000017} [OK] Client's read_cb_cli(): sent 29 bytes message: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 245s] +{11.000019} [OK|OK] Server's read_cb_srv(): callback triggered [ 245s] +{11.000019} [OK|OK] Server's read_cb_srv(): received 29(29) bytes: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 245s] +{11.000019} [OK|OK] Server's read_cb_srv(): sent 11 bytes message: 72 65 61 64 5f 63 62 5f 73 72 76 [ 245s] +{11.000019} [OK|OK] Server's read_cb_srv(): force client disconnect on subsequent call [ 245s] +{11.000020} [OK] Client's read_cb_cli(): callback triggered [ 245s] +{11.000020} [OK] Client's read_cb_cli(): 0-byte read, auto-reconnect will be triggered if enabled [ 245s] +{20.000020} non-reconnecting test complete. [ 245s] [ 245s] Stream tests completed [ 245s] 1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8) [ 245s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 245s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 245s] make: *** [debian/rules:13: build] Error 2 [ 245s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 245s] ### VM INTERACTION START ### [ 248s] [ 204.634258] sysrq: Power Off [ 248s] [ 204.638116] reboot: Power down [ 248s] ### VM INTERACTION END ### [ 248s] [ 248s] old-atreju4 failed "build libosmo-netif_1.1.0.1.d4a1.202111250026.dsc" at Thu Nov 25 00:40:09 UTC 2021. [ 248s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Nov 25 11:10:58 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 25 Nov 2021 11:10:58 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 6: Probably I did not understand this correctly. I guess you mean that the dropping/rejecting should be done from osmo_bsc_main.c:inp_sig_cb. I have tried that, but all I get a segfault then. That is why I opted to do the rejecting from abis_nm.c:abis_nm_rcvmsg_fom A sign_link_up callback seems only to exist for ipaccess BTSs. So it seems logical to execute ipaccess_drop_oml() of the BTS from there as well. Surprisingly this does not work either. The problem now is that osmo_bsc_main.c:inp_sig_cb does not get the S_L_INP_TEI_UP event anymore, so the config is not re-checked and the BTS is permanently rejected. What we could do is to execute the check from bts_ipaccess_nanobts.c:ipaccess_sign_link_up() once more. Then it should work. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 11:10:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:41:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 12:41:59 +0000 Subject: Change in libosmocore[master]: logging: Fix memory leak in case async log write queue overflows References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26360 ) Change subject: logging: Fix memory leak in case async log write queue overflows ...................................................................... logging: Fix memory leak in case async log write queue overflows In case osmo_wqueue_enqueue_quiet() fails, msgb ownership is not transferred to the queue, but the caller is responsible for freeing the message buffer that we just failed to enqueue. Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810 Closes: OS#5328 Related: OS#5329 --- M src/logging.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/26360/1 diff --git a/src/logging.c b/src/logging.c index 9e2f5c2..b6c26d2 100644 --- a/src/logging.c +++ b/src/logging.c @@ -992,7 +992,10 @@ } /* if we reach here, either we already had elements in the write_queue, or the synchronous write * failed: enqueue the message to the write_queue (backlog) */ - osmo_wqueue_enqueue_quiet(target->tgt_file.wqueue, msg); + if (osmo_wqueue_enqueue_quiet(target->tgt_file.wqueue, msg) < 0) { + msgb_free(msg); + /* TODO: increment some counter so we can see that messages were dropped */ + } } #endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810 Gerrit-Change-Number: 26360 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:42:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 12:42:00 +0000 Subject: Change in libosmocore[master]: write_queue: Document it that caller is responsible if enqueue fails References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26361 ) Change subject: write_queue: Document it that caller is responsible if enqueue fails ...................................................................... write_queue: Document it that caller is responsible if enqueue fails This kind of API will likely cause memory leaks in case the caller fails to check the return value of the function and knows he must free the message. Change-Id: I7e61c19d32a75e28f08b74a8e3d9d63a2d8bf3d7 Related: OS#5329 --- M src/write_queue.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/26361/1 diff --git a/src/write_queue.c b/src/write_queue.c index b208b25..31b8427 100644 --- a/src/write_queue.c +++ b/src/write_queue.c @@ -106,7 +106,7 @@ /*! Enqueue a new \ref msgb into a write queue (without logging full queue events) * \param[in] queue Write queue to be used * \param[in] data to-be-enqueued message buffer - * \returns 0 on success; negative on error + * \returns 0 on success; negative on error (MESSAGE NOT FREED IN CASE OF ERROR). */ int osmo_wqueue_enqueue_quiet(struct osmo_wqueue *queue, struct msgb *data) { @@ -122,7 +122,7 @@ /*! Enqueue a new \ref msgb into a write queue * \param[in] queue Write queue to be used * \param[in] data to-be-enqueued message buffer - * \returns 0 on success; negative on error + * \returns 0 on success; negative on error (MESSAGE NOT FREED IN CASE OF ERROR). */ int osmo_wqueue_enqueue(struct osmo_wqueue *queue, struct msgb *data) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e61c19d32a75e28f08b74a8e3d9d63a2d8bf3d7 Gerrit-Change-Number: 26361 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:48:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Nov 2021 12:48:59 +0000 Subject: Change in libosmocore[master]: logging: Fix memory leak in case async log write queue overflows In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26360 ) Change subject: logging: Fix memory leak in case async log write queue overflows ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810 Gerrit-Change-Number: 26360 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 25 Nov 2021 12:48:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:49:29 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Nov 2021 12:49:29 +0000 Subject: Change in libosmocore[master]: write_queue: Document it that caller is responsible if enqueue fails In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26361 ) Change subject: write_queue: Document it that caller is responsible if enqueue fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e61c19d32a75e28f08b74a8e3d9d63a2d8bf3d7 Gerrit-Change-Number: 26361 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 25 Nov 2021 12:49:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:52:15 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 12:52:15 +0000 Subject: Change in libosmocore[master]: write_queue: Document it that caller is responsible if enqueue fails In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26361 ) Change subject: write_queue: Document it that caller is responsible if enqueue fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e61c19d32a75e28f08b74a8e3d9d63a2d8bf3d7 Gerrit-Change-Number: 26361 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 25 Nov 2021 12:52:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:52:37 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 12:52:37 +0000 Subject: Change in libosmocore[master]: logging: Fix memory leak in case async log write queue overflows In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26360 ) Change subject: logging: Fix memory leak in case async log write queue overflows ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810 Gerrit-Change-Number: 26360 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 25 Nov 2021 12:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:53:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 12:53:18 +0000 Subject: Change in osmo-bts[master]: [lc15, oc2g, octphy] Fix memory leak on write queue overflow References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26362 ) Change subject: [lc15,oc2g,octphy] Fix memory leak on write queue overflow ...................................................................... [lc15,oc2g,octphy] Fix memory leak on write queue overflow Callers of osmo_wqueue_enqueue must always check the return value and free the message themselves in the error case. Change-Id: Ic67fbef23e419c0c8a7bcfb16d134e1bf649de72 Related: OS#5329 --- M src/osmo-bts-lc15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-octphy/l1_if.c 3 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/62/26362/1 diff --git a/src/osmo-bts-lc15/l1_if.c b/src/osmo-bts-lc15/l1_if.c index 02c8646..ac165b8 100644 --- a/src/osmo-bts-lc15/l1_if.c +++ b/src/osmo-bts-lc15/l1_if.c @@ -553,7 +553,12 @@ empty_req_from_l1sap(l1p, fl1, u8Tn, u32Fn, sapi, subCh, u8BlockNbr); } /* send message to DSP's queue */ - osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg); + if (osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg) < 0) { + LOGPFN(DL1P, LOGL_ERROR, u32Fn, "MQ_L1_WRITE queue full. Dropping msg.\n"); + msgb_free(nmsg); + return -ENOBUFS; + } + if (dtx_is_first_p1(lchan)) dtx_dispatch(lchan, E_FIRST); else diff --git a/src/osmo-bts-oc2g/l1_if.c b/src/osmo-bts-oc2g/l1_if.c index 2cefc3b..194f82a 100644 --- a/src/osmo-bts-oc2g/l1_if.c +++ b/src/osmo-bts-oc2g/l1_if.c @@ -606,7 +606,11 @@ empty_req_from_l1sap(l1p, fl1, u8Tn, u32Fn, sapi, subCh, u8BlockNbr); } /* send message to DSP's queue */ - osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg); + if (osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg) < 0) { + LOGPFN(DL1P, LOGL_ERROR, u32Fn, "MQ_L1_WRITE queue full. Dropping msg.\n"); + msgb_free(nmsg); + return -ENOBUFS; + } if (dtx_is_first_p1(lchan)) dtx_dispatch(lchan, E_FIRST); else diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c index 294a65e..ebd960e 100644 --- a/src/osmo-bts-octphy/l1_if.c +++ b/src/osmo-bts-octphy/l1_if.c @@ -1302,7 +1302,11 @@ wlc->num_retrans++; msg = msgb_copy(wlc->cmd_msg, "PHY CMD Retrans"); msg_set_retrans_flag(msg); - osmo_wqueue_enqueue(&fl1h->phy_wq, msg); + if (osmo_wqueue_enqueue(&fl1h->phy_wq, msg) < 0) { + LOGP(DL1C, LOGL_ERROR, "Queue full on wlc retransmit\n"); + msgb_free(msg); + return 0; + } osmo_timer_schedule(&wlc->timer, CMD_TIMEOUT, 0); count++; LOGP(DL1C, LOGL_INFO, "Re-transmitting %s " -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic67fbef23e419c0c8a7bcfb16d134e1bf649de72 Gerrit-Change-Number: 26362 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:55:36 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 12:55:36 +0000 Subject: Change in osmo-bts[master]: [lc15, oc2g, octphy] Fix memory leak on write queue overflow In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26362 ) Change subject: [lc15,oc2g,octphy] Fix memory leak on write queue overflow ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic67fbef23e419c0c8a7bcfb16d134e1bf649de72 Gerrit-Change-Number: 26362 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: daniel Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 25 Nov 2021 12:55:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:56:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 12:56:01 +0000 Subject: Change in libosmocore[master]: logging: Fix memory leak in case async log write queue overflows In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26360 ) Change subject: logging: Fix memory leak in case async log write queue overflows ...................................................................... logging: Fix memory leak in case async log write queue overflows In case osmo_wqueue_enqueue_quiet() fails, msgb ownership is not transferred to the queue, but the caller is responsible for freeing the message buffer that we just failed to enqueue. Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810 Closes: OS#5328 Related: OS#5329 --- M src/logging.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved daniel: Looks good to me, approved diff --git a/src/logging.c b/src/logging.c index 9e2f5c2..b6c26d2 100644 --- a/src/logging.c +++ b/src/logging.c @@ -992,7 +992,10 @@ } /* if we reach here, either we already had elements in the write_queue, or the synchronous write * failed: enqueue the message to the write_queue (backlog) */ - osmo_wqueue_enqueue_quiet(target->tgt_file.wqueue, msg); + if (osmo_wqueue_enqueue_quiet(target->tgt_file.wqueue, msg) < 0) { + msgb_free(msg); + /* TODO: increment some counter so we can see that messages were dropped */ + } } #endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6306e34dc7289864c889e72adf31d74d4581a810 Gerrit-Change-Number: 26360 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 12:56:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 12:56:01 +0000 Subject: Change in libosmocore[master]: write_queue: Document it that caller is responsible if enqueue fails In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26361 ) Change subject: write_queue: Document it that caller is responsible if enqueue fails ...................................................................... write_queue: Document it that caller is responsible if enqueue fails This kind of API will likely cause memory leaks in case the caller fails to check the return value of the function and knows he must free the message. Change-Id: I7e61c19d32a75e28f08b74a8e3d9d63a2d8bf3d7 Related: OS#5329 --- M src/write_queue.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved daniel: Looks good to me, approved diff --git a/src/write_queue.c b/src/write_queue.c index b208b25..31b8427 100644 --- a/src/write_queue.c +++ b/src/write_queue.c @@ -106,7 +106,7 @@ /*! Enqueue a new \ref msgb into a write queue (without logging full queue events) * \param[in] queue Write queue to be used * \param[in] data to-be-enqueued message buffer - * \returns 0 on success; negative on error + * \returns 0 on success; negative on error (MESSAGE NOT FREED IN CASE OF ERROR). */ int osmo_wqueue_enqueue_quiet(struct osmo_wqueue *queue, struct msgb *data) { @@ -122,7 +122,7 @@ /*! Enqueue a new \ref msgb into a write queue * \param[in] queue Write queue to be used * \param[in] data to-be-enqueued message buffer - * \returns 0 on success; negative on error + * \returns 0 on success; negative on error (MESSAGE NOT FREED IN CASE OF ERROR). */ int osmo_wqueue_enqueue(struct osmo_wqueue *queue, struct msgb *data) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e61c19d32a75e28f08b74a8e3d9d63a2d8bf3d7 Gerrit-Change-Number: 26361 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 13:15:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 13:15:29 +0000 Subject: Change in osmo-bts[master]: [lc15, oc2g, octphy] Fix memory leak on write queue overflow In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26362 ) Change subject: [lc15,oc2g,octphy] Fix memory leak on write queue overflow ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic67fbef23e419c0c8a7bcfb16d134e1bf649de72 Gerrit-Change-Number: 26362 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 13:15:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 13:15:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 13:15:30 +0000 Subject: Change in osmo-bts[master]: [lc15, oc2g, octphy] Fix memory leak on write queue overflow In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26362 ) Change subject: [lc15,oc2g,octphy] Fix memory leak on write queue overflow ...................................................................... [lc15,oc2g,octphy] Fix memory leak on write queue overflow Callers of osmo_wqueue_enqueue must always check the return value and free the message themselves in the error case. Change-Id: Ic67fbef23e419c0c8a7bcfb16d134e1bf649de72 Related: OS#5329 --- M src/osmo-bts-lc15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-octphy/l1_if.c 3 files changed, 16 insertions(+), 3 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-lc15/l1_if.c b/src/osmo-bts-lc15/l1_if.c index 02c8646..ac165b8 100644 --- a/src/osmo-bts-lc15/l1_if.c +++ b/src/osmo-bts-lc15/l1_if.c @@ -553,7 +553,12 @@ empty_req_from_l1sap(l1p, fl1, u8Tn, u32Fn, sapi, subCh, u8BlockNbr); } /* send message to DSP's queue */ - osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg); + if (osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg) < 0) { + LOGPFN(DL1P, LOGL_ERROR, u32Fn, "MQ_L1_WRITE queue full. Dropping msg.\n"); + msgb_free(nmsg); + return -ENOBUFS; + } + if (dtx_is_first_p1(lchan)) dtx_dispatch(lchan, E_FIRST); else diff --git a/src/osmo-bts-oc2g/l1_if.c b/src/osmo-bts-oc2g/l1_if.c index 2cefc3b..194f82a 100644 --- a/src/osmo-bts-oc2g/l1_if.c +++ b/src/osmo-bts-oc2g/l1_if.c @@ -606,7 +606,11 @@ empty_req_from_l1sap(l1p, fl1, u8Tn, u32Fn, sapi, subCh, u8BlockNbr); } /* send message to DSP's queue */ - osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg); + if (osmo_wqueue_enqueue(&fl1->write_q[MQ_L1_WRITE], nmsg) < 0) { + LOGPFN(DL1P, LOGL_ERROR, u32Fn, "MQ_L1_WRITE queue full. Dropping msg.\n"); + msgb_free(nmsg); + return -ENOBUFS; + } if (dtx_is_first_p1(lchan)) dtx_dispatch(lchan, E_FIRST); else diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c index 294a65e..ebd960e 100644 --- a/src/osmo-bts-octphy/l1_if.c +++ b/src/osmo-bts-octphy/l1_if.c @@ -1302,7 +1302,11 @@ wlc->num_retrans++; msg = msgb_copy(wlc->cmd_msg, "PHY CMD Retrans"); msg_set_retrans_flag(msg); - osmo_wqueue_enqueue(&fl1h->phy_wq, msg); + if (osmo_wqueue_enqueue(&fl1h->phy_wq, msg) < 0) { + LOGP(DL1C, LOGL_ERROR, "Queue full on wlc retransmit\n"); + msgb_free(msg); + return 0; + } osmo_timer_schedule(&wlc->timer, CMD_TIMEOUT, 0); count++; LOGP(DL1C, LOGL_INFO, "Re-transmitting %s " -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic67fbef23e419c0c8a7bcfb16d134e1bf649de72 Gerrit-Change-Number: 26362 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 13:17:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 13:17:38 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 6: src/osmo-bsc/bts_ipaccess_nanobts.c:ipaccess_sign_link_up() sounds like a good place. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 13:17:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 13:50:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 13:50:17 +0000 Subject: Change in osmo-tetra[master]: fix memory leak in tetra_gsmtap_sendmsg() References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/26363 ) Change subject: fix memory leak in tetra_gsmtap_sendmsg() ...................................................................... fix memory leak in tetra_gsmtap_sendmsg() gsmtap_sendmsg() may return an error, and we need to free the msg. Likewise, if we don't even call gsmtap_sendmsg, the msgb must be free'd. Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Related: OS#5329 --- M src/tetra_gsmtap.c 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/63/26363/1 diff --git a/src/tetra_gsmtap.c b/src/tetra_gsmtap.c index 79b48a7..200ae3f 100644 --- a/src/tetra_gsmtap.c +++ b/src/tetra_gsmtap.c @@ -64,10 +64,15 @@ int tetra_gsmtap_sendmsg(struct msgb *msg) { - if (g_gti) - return gsmtap_sendmsg(g_gti, msg); - else + if (g_gti) { + int rc = gsmtap_sendmsg(g_gti, msg); + if (rc < 0) + msgb_free(msg); + return rc; + } else { + msgb_free(msg); return 0; + } } int tetra_gsmtap_init(const char *host, uint16_t port) -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/26363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Gerrit-Change-Number: 26363 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 13:50:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 13:50:20 +0000 Subject: Change in osmo-bsc[master]: Disable C/I based MS Power Control Loop by default References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26364 ) Change subject: Disable C/I based MS Power Control Loop by default ...................................................................... Disable C/I based MS Power Control Loop by default osmo-trx-uhd with a B200 has proven to provide bad (lower than usually considered good) C/I values due to high noise (even with band filters in place). Hence, default thresholds (gathered from literature on the topic) are too high and end up in bad algorithm output decisions. Furthermore, most users of Osmocom don't use it in densely populated areas, hence RXLEV based algorithm used when C/I based one is disabled is good enough. Let's disable C/I based one by default, and let advanced users which specific needs to enable and confiure thresholds specifically for their needs (hardware, cell surrounding conditions, etc.). Related: SYS#4917 Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279 --- M src/osmo-bsc/gsm_data.c M tests/power_ctrl.vty 2 files changed, 38 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/26364/1 diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 988d70e..38d8a7c 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -1200,7 +1200,7 @@ * above the target. */ .ci_fr_meas = { /* FR: Target C/I = 15 dB, Soft blocking threshold = 10 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 13, .upper_thresh = 17, @@ -1222,7 +1222,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_hr_meas = { /* HR: Target C/I = 18 dB, Soft blocking threshold = 13 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 16, .upper_thresh = 21, @@ -1244,7 +1244,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_amr_fr_meas = { /* AMR-FR: Target C/I = 9 dB, Soft blocking threshold = 4 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 7, .upper_thresh = 11, @@ -1266,7 +1266,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_amr_hr_meas = { /* AMR-HR: Target C/I = 15 dB, Soft blocking threshold = 10 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 13, .upper_thresh = 17, @@ -1288,7 +1288,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_sdcch_meas = { /* SDCCH: Target C/I = 14 dB, Soft blocking threshold = 9 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 12, .upper_thresh = 16, @@ -1310,7 +1310,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_gprs_meas = { /* GPRS: Target C/I = 20 dB, Soft blocking threshold = 15 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 18, .upper_thresh = 24, diff --git a/tests/power_ctrl.vty b/tests/power_ctrl.vty index 374002d..f0ef46e 100644 --- a/tests/power_ctrl.vty +++ b/tests/power_ctrl.vty @@ -143,22 +143,22 @@ rxlev-thresh-comp lower 10 12 upper 19 20 rxqual-thresh lower 3 upper 0 rxqual-thresh-comp lower 5 7 upper 15 18 - ci-thresh fr-efr enable + ci-thresh fr-efr disable ci-thresh fr-efr lower 13 upper 17 ci-thresh-comp fr-efr lower 5 7 upper 15 18 - ci-thresh hr enable + ci-thresh hr disable ci-thresh hr lower 16 upper 21 ci-thresh-comp hr lower 5 7 upper 15 18 - ci-thresh amr-fr enable + ci-thresh amr-fr disable ci-thresh amr-fr lower 7 upper 11 ci-thresh-comp amr-fr lower 5 7 upper 15 18 - ci-thresh amr-hr enable + ci-thresh amr-hr disable ci-thresh amr-hr lower 13 upper 17 ci-thresh-comp amr-hr lower 5 7 upper 15 18 - ci-thresh sdcch enable + ci-thresh sdcch disable ci-thresh sdcch lower 12 upper 16 ci-thresh-comp sdcch lower 5 7 upper 15 18 - ci-thresh gprs enable + ci-thresh gprs disable ci-thresh gprs lower 18 upper 24 ci-thresh-comp gprs lower 5 7 upper 15 18 ... @@ -304,12 +304,37 @@ rxqual-thresh-comp lower 5 7 upper 15 18 ... -OsmoBSC(config-net-bts)# ### Check 'ci-thresh-comp disable all' works properly: +OsmoBSC(config-net-bts)# ### Check 'ci-thresh-comp (enable|disable) all' works properly: OsmoBSC(config-net-bts)# ms-power-control OsmoBSC(config-ms-power-ctrl)# show running-config ... ms-power-control ... + ci-thresh fr-efr disable + ci-thresh fr-efr lower 13 upper 17 + ci-thresh-comp fr-efr lower 5 7 upper 15 18 + ci-thresh hr disable + ci-thresh hr lower 16 upper 21 + ci-thresh-comp hr lower 5 7 upper 15 18 + ci-thresh amr-fr disable + ci-thresh amr-fr lower 7 upper 11 + ci-thresh-comp amr-fr lower 5 7 upper 15 18 + ci-thresh amr-hr disable + ci-thresh amr-hr lower 13 upper 17 + ci-thresh-comp amr-hr lower 5 7 upper 15 18 + ci-thresh sdcch disable + ci-thresh sdcch lower 12 upper 16 + ci-thresh-comp sdcch lower 5 7 upper 15 18 + ci-thresh gprs disable + ci-thresh gprs lower 18 upper 24 + ci-thresh-comp gprs lower 5 7 upper 15 18 +... + +OsmoBSC(config-ms-power-ctrl)# ci-thresh all enable +OsmoBSC(config-ms-power-ctrl)# show running-config +... + ms-power-control +... ci-thresh fr-efr enable ci-thresh fr-efr lower 13 upper 17 ci-thresh-comp fr-efr lower 5 7 upper 15 18 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279 Gerrit-Change-Number: 26364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 13:55:23 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 13:55:23 +0000 Subject: Change in osmo-tetra[master]: fix memory leak in tetra_gsmtap_sendmsg() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/26363 ) Change subject: fix memory leak in tetra_gsmtap_sendmsg() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/26363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Gerrit-Change-Number: 26363 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 13:55:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:00:12 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 25 Nov 2021 14:00:12 +0000 Subject: Change in osmo-bsc[master]: Disable C/I based MS Power Control Loop by default In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26364 ) Change subject: Disable C/I based MS Power Control Loop by default ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279 Gerrit-Change-Number: 26364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 25 Nov 2021 14:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:08:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Nov 2021 14:08:25 +0000 Subject: Change in osmo-bsc[master]: Disable C/I based MS Power Control Loop by default In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26364 ) Change subject: Disable C/I based MS Power Control Loop by default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279 Gerrit-Change-Number: 26364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 25 Nov 2021 14:08:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:38:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:38:18 +0000 Subject: Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26365 ) Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() ...................................................................... gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() gsmtap_sendmsg() places the burden of freeing the msgb in case of erroneous return codes on the caller. A review of existing users shows that this is overly optimistic and many calls get it wrong, opening up memory leaks. Let's add a new function gsmtap_sendmsg_free() which behaves like gsmtap_sendmsg() but always takes ownership: Either it is sent + freed, or it is just freed. Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M include/osmocom/core/gsmtap_util.h M src/gsmtap_util.c 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/26365/1 diff --git a/include/osmocom/core/gsmtap_util.h b/include/osmocom/core/gsmtap_util.h index e564326..1cc8d75 100644 --- a/include/osmocom/core/gsmtap_util.h +++ b/include/osmocom/core/gsmtap_util.h @@ -48,6 +48,7 @@ int gsmtap_source_add_sink(struct gsmtap_inst *gti); int gsmtap_sendmsg(struct gsmtap_inst *gti, struct msgb *msg); +int gsmtap_sendmsg_free(struct gsmtap_inst *gti, struct msgb *msg); int gsmtap_send_ex(struct gsmtap_inst *gti, uint8_t type, uint16_t arfcn, uint8_t ts, uint8_t chan_type, uint8_t ss, uint32_t fn, diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c index 9ae06d6..cbf1e1e 100644 --- a/src/gsmtap_util.c +++ b/src/gsmtap_util.c @@ -304,9 +304,12 @@ if (!gti) return -ENODEV; - if (gti->ofd_wq_mode) - return osmo_wqueue_enqueue(>i->wq, msg); - else { + if (gti->ofd_wq_mode) { + int rc = osmo_wqueue_enqueue(>i->wq, msg); + if (rc < 0) + msgb_free(msg); + return rc; + } else { /* try immediate send and return error if any */ int rc; @@ -323,6 +326,20 @@ } } +/*! Send a \ref msgb through a GSMTAP source; free the message if tx queue full. + * \param[in] gti GSMTAP instance + * \param[in] msg message buffer + * \return 0 in case of success; negative in case of error + */ +int gsmtap_sendmsg_free(struct gsmtap_inst *gti, struct msgb *msg) +{ + int rc; + rc = gsmtap_sendmsg(gti, msg); + if (rc < 0) + msgb_free(msg); + return rc; +} + /*! send an arbitrary type through GSMTAP. * See \ref gsmtap_makemsg_ex for arguments */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Gerrit-Change-Number: 26365 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:40:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:40:41 +0000 Subject: Change in osmocom-bb[master]: gprsdecode: Don't leak memory in gsmtap_sendmsg() References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/26366 ) Change subject: gprsdecode: Don't leak memory in gsmtap_sendmsg() ...................................................................... gprsdecode: Don't leak memory in gsmtap_sendmsg() Change-Id: Ib9e439ad6f24c573abb6da1523713a669898d23f Depends: libosmocore I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M src/host/gprsdecode/gsmtap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/26366/1 diff --git a/src/host/gprsdecode/gsmtap.c b/src/host/gprsdecode/gsmtap.c index 5c124b2..1096c2d 100644 --- a/src/host/gprsdecode/gsmtap.c +++ b/src/host/gprsdecode/gsmtap.c @@ -100,6 +100,6 @@ memcpy(dst, data, len); /* Finally, send to the sink */ - gsmtap_sendmsg(gti, msg); + gsmtap_sendmsg_free(gti, msg); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/26366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib9e439ad6f24c573abb6da1523713a669898d23f Gerrit-Change-Number: 26366 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:43:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:43:14 +0000 Subject: Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26365 to look at the new patch set (#2). Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() ...................................................................... gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() gsmtap_sendmsg() places the burden of freeing the msgb in case of erroneous return codes on the caller. A review of existing users shows that this is overly optimistic and many calls get it wrong, opening up memory leaks. Let's add a new function gsmtap_sendmsg_free() which behaves like gsmtap_sendmsg() but always takes ownership: Either it is sent + freed, or it is just freed. Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M include/osmocom/core/gsmtap_util.h M src/gsmtap_util.c 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/26365/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Gerrit-Change-Number: 26365 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:43:37 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 25 Nov 2021 14:43:37 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26367 ) Change subject: bts-examples: add example for E1 connected BTS ...................................................................... bts-examples: add example for E1 connected BTS The manual lacks an example on how to set up an E1 connected BTS. Especially the relation between trunk number and E1 line number is not obvious. Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Related: OS#5308 --- M doc/manuals/chapters/bts-examples.adoc 1 file changed, 113 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/26367/1 diff --git a/doc/manuals/chapters/bts-examples.adoc b/doc/manuals/chapters/bts-examples.adoc index 58cb3ab..ba4c846 100644 --- a/doc/manuals/chapters/bts-examples.adoc +++ b/doc/manuals/chapters/bts-examples.adoc @@ -174,3 +174,116 @@ For building a multi-TRX setup, you also need to connect the TIB cables between the two nanoBTS units, as well as the coaxial/RF AUX cabling. ==== + +=== Example configuration for OsmoBSC with E1 BTS + +The following configuration sample illustrates the usage of BTSs that are +connected via an E1/T1 backhaul. + +.OsmoBSC configured for single-TRX E1 Ericsson DUG20 +==== +---- +network + network country code 901 + mobile network code 70 + neci 0 + paging any use tch 0 + handover 0 + handover window rxlev averaging 10 + handover window rxqual averaging 1 + handover window rxlev neighbor averaging 10 + handover power budget interval 6 + handover power budget hysteresis 3 + handover maximum distance 9999 + timer t3101 10 + timer t3105 40 + timer t3109 4 + timer t3113 60 + bts 0 + type rbs2000 + band GSM900 + om2000 version-limit oml gen 12 rev 10 + cell_identity 0 + location_area_code 1 + training_sequence_code 7 + base_station_id_code 63 + ms max power 15 + cell reselection hysteresis 4 + rxlev access min 0 + channel allocator descending + rach tx integer 9 + rach max transmission 7 + oml e1 line 0 timeslot 1 sub-slot full + oml e1 tei 62 + neighbor-list mode automatic + gprs mode none + is-connection-list add 4 512 12 + is-connection-list add 16 524 12 + is-connection-list add 28 536 12 + is-connection-list add 40 548 12 + trx 0 + rf_locked 0 + arfcn 123 + nominal power 42 + max_power_red 12 + rsl e1 line 0 timeslot 1 sub-slot full + rsl e1 tei 0 + timeslot 0 + phys_chan_config CCCH+SDCCH4 + hopping enabled 0 + e1 line 0 timeslot 1 sub-slot full + timeslot 1 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 2 sub-slot 1 + timeslot 2 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 2 sub-slot 2 + timeslot 3 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 2 sub-slot 3 + timeslot 4 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 0 + timeslot 5 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 1 + timeslot 6 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 2 + timeslot 7 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 3 +e1_input + e1_line 0 driver dahdi + e1_line 0 port 3 +---- +==== + +===== E1 Line number and MGCP trunk number +The switching of the voice channels is done via OsmoMGW, which acts as a media +converter between E1 and VoIP (RTP). OsmoBSC will use the E1 line number to +address the trunk via MGCP. + +When configuring OsmoMGW, one needs to make sure that the trunk number that is +set up on OsmoMGW, matches the line number that is set up on OsmoBSC. When those +numbers mismatch the trunk cannot be addressed correctly. + +Given there is no other switching in between, the E1 line number that is set up +on OsmoMGW must match the E1 line number that is set up on OsmoBSC. + +.OsmoMGW trunk configuration that matches the OsmoBSC configuration above +==== +---- + trunk 0 + rtp keep-alive once + no rtp keep-alive + line 0 +---- +==== \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:45:06 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 25 Nov 2021 14:45:06 +0000 Subject: Change in osmo-mgw[master]: configuration: point out difference between trunk-nr and e1 line nr References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26368 ) Change subject: configuration: point out difference between trunk-nr and e1 line nr ...................................................................... configuration: point out difference between trunk-nr and e1 line nr When configuring osmo-mgw the user may choose an arbitrary trunk number for the E1 trunk and sets a line number that must match the number of the physical line that is used with the particular trunk. This is easy to confuse, so lets add a note to the maual that mekes this clear. Change-Id: I4b647a60d21cae99663a8258d6636ec8a7609d97 Related OS#5308 Change-Id: Ide27fda6d9ee2627bb544d21aa65161eace35a34 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/68/26368/1 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 177c096..c50f635 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -91,6 +91,11 @@ trunk. However, it is important that the user assigns one of the E1 line numbers that were configured under the e1_input node. +NOTE: The endpoint name that is used on MGCP level will include the trunk number, +not the E1 line number. For simplicity (and compatibility with OsmoBSC) it is +recommended to use equal numbers for trunk and E1 line. However, if required any +E1 line can be mapped flexible on any trunk as long as the mapping is bijective. + .Example: A typical configuration with one E1 trunk ---- e1_input -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ide27fda6d9ee2627bb544d21aa65161eace35a34 Gerrit-Change-Number: 26368 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:45:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 14:45:13 +0000 Subject: Change in osmo-bsc[master]: Disable C/I based MS Power Control Loop by default In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26364 ) Change subject: Disable C/I based MS Power Control Loop by default ...................................................................... Disable C/I based MS Power Control Loop by default osmo-trx-uhd with a B200 has proven to provide bad (lower than usually considered good) C/I values due to high noise (even with band filters in place). Hence, default thresholds (gathered from literature on the topic) are too high and end up in bad algorithm output decisions. Furthermore, most users of Osmocom don't use it in densely populated areas, hence RXLEV based algorithm used when C/I based one is disabled is good enough. Let's disable C/I based one by default, and let advanced users which specific needs to enable and confiure thresholds specifically for their needs (hardware, cell surrounding conditions, etc.). Related: SYS#4917 Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279 --- M src/osmo-bsc/gsm_data.c M tests/power_ctrl.vty 2 files changed, 38 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 988d70e..38d8a7c 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -1200,7 +1200,7 @@ * above the target. */ .ci_fr_meas = { /* FR: Target C/I = 15 dB, Soft blocking threshold = 10 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 13, .upper_thresh = 17, @@ -1222,7 +1222,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_hr_meas = { /* HR: Target C/I = 18 dB, Soft blocking threshold = 13 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 16, .upper_thresh = 21, @@ -1244,7 +1244,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_amr_fr_meas = { /* AMR-FR: Target C/I = 9 dB, Soft blocking threshold = 4 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 7, .upper_thresh = 11, @@ -1266,7 +1266,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_amr_hr_meas = { /* AMR-HR: Target C/I = 15 dB, Soft blocking threshold = 10 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 13, .upper_thresh = 17, @@ -1288,7 +1288,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_sdcch_meas = { /* SDCCH: Target C/I = 14 dB, Soft blocking threshold = 9 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 12, .upper_thresh = 16, @@ -1310,7 +1310,7 @@ .h_reqt = 6, /* TODO: investigate a reasonable default value */ }, .ci_gprs_meas = { /* GPRS: Target C/I = 20 dB, Soft blocking threshold = 15 dB */ - .enabled = true, + .enabled = false, .lower_thresh = 18, .upper_thresh = 24, diff --git a/tests/power_ctrl.vty b/tests/power_ctrl.vty index 374002d..f0ef46e 100644 --- a/tests/power_ctrl.vty +++ b/tests/power_ctrl.vty @@ -143,22 +143,22 @@ rxlev-thresh-comp lower 10 12 upper 19 20 rxqual-thresh lower 3 upper 0 rxqual-thresh-comp lower 5 7 upper 15 18 - ci-thresh fr-efr enable + ci-thresh fr-efr disable ci-thresh fr-efr lower 13 upper 17 ci-thresh-comp fr-efr lower 5 7 upper 15 18 - ci-thresh hr enable + ci-thresh hr disable ci-thresh hr lower 16 upper 21 ci-thresh-comp hr lower 5 7 upper 15 18 - ci-thresh amr-fr enable + ci-thresh amr-fr disable ci-thresh amr-fr lower 7 upper 11 ci-thresh-comp amr-fr lower 5 7 upper 15 18 - ci-thresh amr-hr enable + ci-thresh amr-hr disable ci-thresh amr-hr lower 13 upper 17 ci-thresh-comp amr-hr lower 5 7 upper 15 18 - ci-thresh sdcch enable + ci-thresh sdcch disable ci-thresh sdcch lower 12 upper 16 ci-thresh-comp sdcch lower 5 7 upper 15 18 - ci-thresh gprs enable + ci-thresh gprs disable ci-thresh gprs lower 18 upper 24 ci-thresh-comp gprs lower 5 7 upper 15 18 ... @@ -304,12 +304,37 @@ rxqual-thresh-comp lower 5 7 upper 15 18 ... -OsmoBSC(config-net-bts)# ### Check 'ci-thresh-comp disable all' works properly: +OsmoBSC(config-net-bts)# ### Check 'ci-thresh-comp (enable|disable) all' works properly: OsmoBSC(config-net-bts)# ms-power-control OsmoBSC(config-ms-power-ctrl)# show running-config ... ms-power-control ... + ci-thresh fr-efr disable + ci-thresh fr-efr lower 13 upper 17 + ci-thresh-comp fr-efr lower 5 7 upper 15 18 + ci-thresh hr disable + ci-thresh hr lower 16 upper 21 + ci-thresh-comp hr lower 5 7 upper 15 18 + ci-thresh amr-fr disable + ci-thresh amr-fr lower 7 upper 11 + ci-thresh-comp amr-fr lower 5 7 upper 15 18 + ci-thresh amr-hr disable + ci-thresh amr-hr lower 13 upper 17 + ci-thresh-comp amr-hr lower 5 7 upper 15 18 + ci-thresh sdcch disable + ci-thresh sdcch lower 12 upper 16 + ci-thresh-comp sdcch lower 5 7 upper 15 18 + ci-thresh gprs disable + ci-thresh gprs lower 18 upper 24 + ci-thresh-comp gprs lower 5 7 upper 15 18 +... + +OsmoBSC(config-ms-power-ctrl)# ci-thresh all enable +OsmoBSC(config-ms-power-ctrl)# show running-config +... + ms-power-control +... ci-thresh fr-efr enable ci-thresh fr-efr lower 13 upper 17 ci-thresh-comp fr-efr lower 5 7 upper 15 18 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If1a73c60695379bcfcd0f44c6ec6dd659563e279 Gerrit-Change-Number: 26364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:46:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 14:46:19 +0000 Subject: Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26365 ) Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Gerrit-Change-Number: 26365 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 14:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:47:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 14:47:01 +0000 Subject: Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26365 ) Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26365/2/src/gsmtap_util.c File src/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/26365/2/src/gsmtap_util.c at 326 PS2, Line 326: /*! Send a \ref msgb through a GSMTAP source; free the message if tx queue full. Maybe express that the message is ALWAYS freed (even if the tx queue is full), as opposed to the other API. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Gerrit-Change-Number: 26365 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 14:47:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:49:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 14:49:12 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26367 ) Change subject: bts-examples: add example for E1 connected BTS ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26367/1/doc/manuals/chapters/bts-examples.adoc File doc/manuals/chapters/bts-examples.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/26367/1/doc/manuals/chapters/bts-examples.adoc at 192 PS1, Line 192: handover window rxlev averaging 10 I don't think we want tons of non-related config here. Better explain in the doc with several snippets which commands are needed in each node. We also have a doc/examples/*.cfg or alike, there you can put a full minimal config as a quick example too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 14:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:50:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 14:50:08 +0000 Subject: Change in osmo-mgw[master]: configuration: point out difference between trunk-nr and e1 line nr In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26368 ) Change subject: configuration: point out difference between trunk-nr and e1 line nr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ide27fda6d9ee2627bb544d21aa65161eace35a34 Gerrit-Change-Number: 26368 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 14:50:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:52:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:52:35 +0000 Subject: Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26365 to look at the new patch set (#3). Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() ...................................................................... gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() gsmtap_sendmsg() places the burden of freeing the msgb in case of erroneous return codes on the caller. A review of existing users shows that this is overly optimistic and many calls get it wrong, opening up memory leaks. Let's add a new function gsmtap_sendmsg_free() which behaves like gsmtap_sendmsg() but always takes ownership: Either it is sent + freed, or it is just freed. Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M include/osmocom/core/gsmtap_util.h M src/gsmtap_util.c 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/26365/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Gerrit-Change-Number: 26365 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:53:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:53:05 +0000 Subject: Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26365 ) Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26365/2/src/gsmtap_util.c File src/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/26365/2/src/gsmtap_util.c at 326 PS2, Line 326: /*! Send a \ref msgb through a GSMTAP source; free the message if tx queue full. > Maybe express that the message is ALWAYS freed (even if the tx queue is full), as opposed to the oth [?] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Gerrit-Change-Number: 26365 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 14:53:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:57:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:57:41 +0000 Subject: Change in osmo-mgw[master]: configuration: point out difference between trunk-nr and e1 line nr In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26368 ) Change subject: configuration: point out difference between trunk-nr and e1 line nr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ide27fda6d9ee2627bb544d21aa65161eace35a34 Gerrit-Change-Number: 26368 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 14:57:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:57:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:57:49 +0000 Subject: Change in osmo-mgw[master]: configuration: point out difference between trunk-nr and e1 line nr In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26368 ) Change subject: configuration: point out difference between trunk-nr and e1 line nr ...................................................................... configuration: point out difference between trunk-nr and e1 line nr When configuring osmo-mgw the user may choose an arbitrary trunk number for the E1 trunk and sets a line number that must match the number of the physical line that is used with the particular trunk. This is easy to confuse, so lets add a note to the maual that mekes this clear. Change-Id: I4b647a60d21cae99663a8258d6636ec8a7609d97 Related OS#5308 Change-Id: Ide27fda6d9ee2627bb544d21aa65161eace35a34 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 177c096..c50f635 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -91,6 +91,11 @@ trunk. However, it is important that the user assigns one of the E1 line numbers that were configured under the e1_input node. +NOTE: The endpoint name that is used on MGCP level will include the trunk number, +not the E1 line number. For simplicity (and compatibility with OsmoBSC) it is +recommended to use equal numbers for trunk and E1 line. However, if required any +E1 line can be mapped flexible on any trunk as long as the mapping is bijective. + .Example: A typical configuration with one E1 trunk ---- e1_input -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ide27fda6d9ee2627bb544d21aa65161eace35a34 Gerrit-Change-Number: 26368 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:58:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:58:10 +0000 Subject: Change in libosmocore[master]: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26365 ) Change subject: gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() ...................................................................... gsmtap: Add gsmtap_sendmsg_free() as alternative to gsmtap_sendmsg() gsmtap_sendmsg() places the burden of freeing the msgb in case of erroneous return codes on the caller. A review of existing users shows that this is overly optimistic and many calls get it wrong, opening up memory leaks. Let's add a new function gsmtap_sendmsg_free() which behaves like gsmtap_sendmsg() but always takes ownership: Either it is sent + freed, or it is just freed. Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M include/osmocom/core/gsmtap_util.h M src/gsmtap_util.c 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/gsmtap_util.h b/include/osmocom/core/gsmtap_util.h index e564326..1cc8d75 100644 --- a/include/osmocom/core/gsmtap_util.h +++ b/include/osmocom/core/gsmtap_util.h @@ -48,6 +48,7 @@ int gsmtap_source_add_sink(struct gsmtap_inst *gti); int gsmtap_sendmsg(struct gsmtap_inst *gti, struct msgb *msg); +int gsmtap_sendmsg_free(struct gsmtap_inst *gti, struct msgb *msg); int gsmtap_send_ex(struct gsmtap_inst *gti, uint8_t type, uint16_t arfcn, uint8_t ts, uint8_t chan_type, uint8_t ss, uint32_t fn, diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c index 9ae06d6..e5adb2f 100644 --- a/src/gsmtap_util.c +++ b/src/gsmtap_util.c @@ -323,6 +323,20 @@ } } +/*! Send a \ref msgb through a GSMTAP source; free the message even if tx queue full. + * \param[in] gti GSMTAP instance + * \param[in] msg message buffer; always freed, caller must not reference it later. + * \return 0 in case of success; negative in case of error + */ +int gsmtap_sendmsg_free(struct gsmtap_inst *gti, struct msgb *msg) +{ + int rc; + rc = gsmtap_sendmsg(gti, msg); + if (rc < 0) + msgb_free(msg); + return rc; +} + /*! send an arbitrary type through GSMTAP. * See \ref gsmtap_makemsg_ex for arguments */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Gerrit-Change-Number: 26365 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 14:58:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 14:58:59 +0000 Subject: Change in osmo-tetra[master]: fix memory leak in tetra_gsmtap_sendmsg() In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/26363 to look at the new patch set (#2). Change subject: fix memory leak in tetra_gsmtap_sendmsg() ...................................................................... fix memory leak in tetra_gsmtap_sendmsg() gsmtap_sendmsg() may return an error, and we need to free the msg. Likewise, if we don't even call gsmtap_sendmsg, the msgb must be free'd. Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Depends: libosmocore I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M src/tetra_gsmtap.c 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/63/26363/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/26363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Gerrit-Change-Number: 26363 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:00:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:00:17 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 --- M jobs/ttcn3-testsuites.yml 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/26369/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index e3e9f3e..91d854e 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -135,6 +135,9 @@ - ttcn3-bsc-test-vamos: blocking: "^(ttcn3|TTCN3-.*)-bsc-test.*" timer: 00 12 * * * + - ttcn3-hnodeb-test: + blocking: "^(ttcn3|TTCN3-.*)-hnodeb-test.*" + timer: 40 12 * * * # debian-stretch latest stable - nplab-m3ua-test-latest: @@ -202,6 +205,9 @@ - ttcn3-pcap-client-test-latest: blocking: "^(ttcn3|TTCN3-.*)-pcap-client-test.*" timer: 40 11 * * * + - ttcn3-hnodeb-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-hnodeb-test.*" + timer: 40 12 * * * # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:00:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:00:48 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 1: Jobs are already created through jenkins-jobs. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 15:00:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:00:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:00:51 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 15:00:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:03:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:03:32 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 1: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-hnodeb-test/test_results_analyzer/ https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-hnodeb-test-latest/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 15:03:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:07:49 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 25 Nov 2021 15:07:49 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 to look at the new patch set (#2). Change subject: bts-examples: add example for E1 connected BTS ...................................................................... bts-examples: add example for E1 connected BTS The manual lacks an example on how to set up an E1 connected BTS. Especially the relation between trunk number and E1 line number is not obvious. Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Related: OS#5308 --- M doc/manuals/chapters/bts-examples.adoc 1 file changed, 110 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/26367/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:35:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 15:35:00 +0000 Subject: Change in osmo-tetra[master]: fix memory leak in tetra_gsmtap_sendmsg() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/26363 ) Change subject: fix memory leak in tetra_gsmtap_sendmsg() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/26363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Gerrit-Change-Number: 26363 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 15:35:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:35:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 15:35:02 +0000 Subject: Change in osmo-tetra[master]: fix memory leak in tetra_gsmtap_sendmsg() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/26363 ) Change subject: fix memory leak in tetra_gsmtap_sendmsg() ...................................................................... fix memory leak in tetra_gsmtap_sendmsg() gsmtap_sendmsg() may return an error, and we need to free the msg. Likewise, if we don't even call gsmtap_sendmsg, the msgb must be free'd. Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Depends: libosmocore I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M src/tetra_gsmtap.c 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/tetra_gsmtap.c b/src/tetra_gsmtap.c index 79b48a7..3f872c5 100644 --- a/src/tetra_gsmtap.c +++ b/src/tetra_gsmtap.c @@ -64,10 +64,16 @@ int tetra_gsmtap_sendmsg(struct msgb *msg) { - if (g_gti) - return gsmtap_sendmsg(g_gti, msg); - else - return 0; + int rc; + + if (g_gti) { + rc = gsmtap_sendmsg_free(g_gti, msg); + } else { + msgb_free(msg); + rc = 0; + } + + return rc; } int tetra_gsmtap_init(const char *host, uint16_t port) -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/26363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I9b018165982996cafb2fd17e89646177462002c6 Gerrit-Change-Number: 26363 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:49:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Nov 2021 15:49:56 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 ) Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348/3/include/osmocom/hnodeb/hnodeb.h File include/osmocom/hnodeb/hnodeb.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348/3/include/osmocom/hnodeb/hnodeb.h at 29 PS3, Line 29: #include unrelated? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 15:49:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:54:58 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Nov 2021 15:54:58 +0000 Subject: Change in osmo-hnodeb[master]: hnbap: Improve rx path and implement HnbRegisterReject In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 ) Change subject: hnbap: Improve rx path and implement HnbRegisterReject ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a Gerrit-Change-Number: 26349 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 15:54:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:55:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:55:28 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 ) Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348/3/include/osmocom/hnodeb/hnodeb.h File include/osmocom/hnodeb/hnodeb.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348/3/include/osmocom/hnodeb/hnodeb.h at 29 PS3, Line 29: #include > unrelated? Not really. I'm starting to access the client struct in some C fileso I need this include, but I saw that actually this header file misses it, so I'm simply adding it once here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 15:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:55:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 15:55:30 +0000 Subject: Change in pysim[master]: fix: Decoder may raise KeyError References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26370 ) Change subject: fix: Decoder may raise KeyError ...................................................................... fix: Decoder may raise KeyError This fixes an issue where a KeyError may be raised when 'A5' is not present in `fcp` Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f --- M pySim/ts_102_221.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/70/26370/1 diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index adb40c1..f145d19 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -684,7 +684,7 @@ fcp_tlv = TLV(FCP_TLV_MAP) fcp = fcp_tlv.parse(fcp_base['62']) # further decode the proprietary information - if fcp['A5']: + if 'A5' in fcp: prop_tlv = TLV(FCP_Proprietary_TLV_MAP) prop = prop_tlv.parse(fcp['A5']) fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f Gerrit-Change-Number: 26370 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:55:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:55:36 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 ) Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 15:55:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:55:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:55:38 +0000 Subject: Change in osmo-hnodeb[master]: hnbap: Improve rx path and implement HnbRegisterReject In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 ) Change subject: hnbap: Improve rx path and implement HnbRegisterReject ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a Gerrit-Change-Number: 26349 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 15:55:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:55:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:55:40 +0000 Subject: Change in osmo-hnodeb[master]: Implement initial shutdown + reconnect FSM In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 ) Change subject: Implement initial shutdown + reconnect FSM ...................................................................... Implement initial shutdown + reconnect FSM The shutdown_fsm doesn't do much right now, but it's included there in order to allow easy clean up of resources upon Iuh reconnect in the future, as well as reset the lower layers. Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 --- M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_shutdown_fsm.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/hnb.c A src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/iuh.c 7 files changed, 202 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 23adb2a..b1acb7e 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,4 +1,5 @@ noinst_HEADERS = \ + hnb_shutdown_fsm.h \ hnbap.h \ hnodeb.h \ iuh.h \ diff --git a/include/osmocom/hnodeb/hnb_shutdown_fsm.h b/include/osmocom/hnodeb/hnb_shutdown_fsm.h new file mode 100644 index 0000000..dc9b357 --- /dev/null +++ b/include/osmocom/hnodeb/hnb_shutdown_fsm.h @@ -0,0 +1,42 @@ +/* hNodeB shutdown FSM */ + +/* (C) 2021 by sysmocom - s.m.f.c. GmbH + * Author: Pau Espin Pedrol + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#pragma once + +#include + +#include + +enum hnb_shutdown_fsm_states { + HNB_SHUTDOWN_ST_NONE, + HNB_SHUTDOWN_ST_EXIT, +}; + +enum hnb_shutdown_fsm_events { + HNB_SHUTDOWN_EV_START, +}; + +extern struct osmo_fsm hnb_shutdown_fsm; + +struct hnb; +void hnb_shutdown(struct hnb *hnb, const char *reason, bool exit_proc); +bool hnb_shutdown_in_progress(const struct hnb *hnb); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index deb683f..3bc2fb3 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -26,6 +26,7 @@ #include #include #include +#include enum { DMAIN, @@ -62,6 +63,9 @@ uint32_t ctx_id; + struct osmo_fsm_inst *shutdown_fi; /* FSM instance to manage shutdown procedure during process exit */ + bool shutdown_fi_exit_proc; /* exit process when shutdown_fsm is finished? */ + struct { struct hnb_chan *chan; } cs; diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 88f2571..7325728 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -33,6 +33,7 @@ debug.c \ hnbap.c \ hnb.c \ + hnb_shutdown_fsm.c \ iuh.c \ nas.c \ ranap.c \ diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 3344cfb..b7be4ea 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -26,6 +26,7 @@ #include #include +#include struct hnb *hnb_alloc(void *tall_ctx) @@ -41,6 +42,10 @@ .mcc = 1, .mnc = 1, }; + + hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, + LOGL_INFO, NULL); + hnb_iuh_alloc(hnb); return hnb; @@ -48,6 +53,10 @@ void hnb_free(struct hnb *hnb) { + if (hnb->shutdown_fi) { + osmo_fsm_inst_free(hnb->shutdown_fi); + hnb->shutdown_fi = NULL; + } hnb_iuh_free(hnb); talloc_free(hnb); } diff --git a/src/osmo-hnodeb/hnb_shutdown_fsm.c b/src/osmo-hnodeb/hnb_shutdown_fsm.c new file mode 100644 index 0000000..55de64c --- /dev/null +++ b/src/osmo-hnodeb/hnb_shutdown_fsm.c @@ -0,0 +1,134 @@ +/* hNodeB shutdown FSM */ + +/* (C) 2021 by sysmocom - s.m.f.c. GmbH + * Author: Pau Espin Pedrol + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include + +#include +#include +#include +#define X(s) (1 << (s)) + +#define hnb_shutdown_fsm_state_chg(fi, NEXT_STATE) \ + osmo_fsm_inst_state_chg(fi, NEXT_STATE, 0, 0) + +static void st_none_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct hnb *hnb = (struct hnb *)fi->priv; + hnb_iuh_connect(hnb); /* Start reconnect once we are done with shutdown and we didn't exit process */ +} + +static void st_none(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct hnb *hnb = (struct hnb *)fi->priv; + switch (event) { + case HNB_SHUTDOWN_EV_START: + /* TODO: here we may want to communicate t lower layers over UDsocket that we are shutting down... + * TODO: Also, if Iuh link is still up, maybe send a Hnb deregister req towards HNBGW + * TODO: also signal the hnb object somehow that we are starting to shut down? + */ + if (osmo_stream_cli_is_connected(hnb->iuh.client)) + osmo_stream_cli_close(hnb->iuh.client); + + hnb_shutdown_fsm_state_chg(fi, HNB_SHUTDOWN_ST_EXIT); + break; + } +} + +static void st_exit_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct hnb *hnb = (struct hnb *)fi->priv; + /* TODO: here we may want to signal the hnb object somehow that we have completed the shut down? */ + + if (hnb->shutdown_fi_exit_proc) { + LOGPFSML(fi, LOGL_NOTICE, "Shutdown process completed successfully, exiting process\n"); + exit(0); + } + hnb_shutdown_fsm_state_chg(fi, HNB_SHUTDOWN_ST_NONE); +} + +static struct osmo_fsm_state hnb_shutdown_fsm_states[] = { + [HNB_SHUTDOWN_ST_NONE] = { + .in_event_mask = + X(HNB_SHUTDOWN_EV_START), + .out_state_mask = + X(HNB_SHUTDOWN_ST_EXIT), + .name = "NONE", + .onenter = st_none_on_enter, + .action = st_none, + }, + [HNB_SHUTDOWN_ST_EXIT] = { + .name = "EXIT", + .out_state_mask = + X(HNB_SHUTDOWN_ST_NONE), + .onenter = st_exit_on_enter, + } +}; + +const struct value_string hnb_shutdown_fsm_event_names[] = { + OSMO_VALUE_STRING(HNB_SHUTDOWN_EV_START), + { 0, NULL } +}; + +int hnb_shutdown_fsm_timer_cb(struct osmo_fsm_inst *fi) +{ + switch (fi->state) { + default: + OSMO_ASSERT(false); + } + return 0; +} + +struct osmo_fsm hnb_shutdown_fsm = { + .name = "HNB_SHUTDOWN", + .states = hnb_shutdown_fsm_states, + .num_states = ARRAY_SIZE(hnb_shutdown_fsm_states), + .event_names = hnb_shutdown_fsm_event_names, + .log_subsys = DMAIN, + .timer_cb = hnb_shutdown_fsm_timer_cb, +}; + +static __attribute__((constructor)) void hnb_shutdown_fsm_init(void) +{ + OSMO_ASSERT(osmo_fsm_register(&hnb_shutdown_fsm) == 0); +} + +bool hnb_shutdown_in_progress(const struct hnb *hnb) +{ + const struct osmo_fsm_inst *fi = hnb->shutdown_fi; + return fi->state != HNB_SHUTDOWN_ST_NONE; +} + +void hnb_shutdown(struct hnb *hnb, const char *reason, bool exit_proc) +{ + struct osmo_fsm_inst *fi = hnb->shutdown_fi; + if (hnb_shutdown_in_progress(hnb)) { + LOGPFSML(fi, LOGL_NOTICE, "hNodeB is already being shutdown.\n"); + if (exit_proc) + hnb->shutdown_fi_exit_proc = true; + return; + } + hnb->shutdown_fi_exit_proc = exit_proc; + LOGPFSML(fi, LOGL_NOTICE, "Shutting down hNodeB, exit %u, reason: %s\n", + exit_proc, reason); + osmo_fsm_inst_dispatch(fi, HNB_SHUTDOWN_EV_START, NULL); +} diff --git a/src/osmo-hnodeb/iuh.c b/src/osmo-hnodeb/iuh.c index 3153206..79df371 100644 --- a/src/osmo-hnodeb/iuh.c +++ b/src/osmo-hnodeb/iuh.c @@ -37,6 +37,7 @@ #include #include #include +#include static int get_logevel_by_sn_type(int sn_type) { @@ -100,12 +101,13 @@ NULL, NULL, &sinfo, &flags); if (rc < 0) { LOGP(DSCTP, LOGL_ERROR, "Error during sctp_recvmsg()\n"); - /* FIXME: clean up after disappeared HNB */ osmo_stream_cli_close(conn); + hnb_shutdown(hnb, "sctp_recvmsg() error", false); goto free_ret; } else if (rc == 0) { LOGP(DSCTP, LOGL_INFO, "Connection to HNBGW closed\n"); osmo_stream_cli_close(conn); + hnb_shutdown(hnb, "Iuh HNBGW conn closed", false); rc = -1; goto free_ret; } else { @@ -115,6 +117,14 @@ if (flags & MSG_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); log_sctp_notification(notif); + switch (notif->sn_header.sn_type) { + case SCTP_SHUTDOWN_EVENT: + osmo_fsm_inst_dispatch(hnb->shutdown_fi, HNB_SHUTDOWN_EV_START, NULL); + hnb_shutdown(hnb, "Iuh HNBGW conn notification (SCTP_SHUTDOWN_EVENT)", false); + break; + default: + break; + } rc = 0; goto free_ret; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id35d692218af366843186b0966b62f65bb9eb620 Gerrit-Change-Number: 26348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:55:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 15:55:40 +0000 Subject: Change in osmo-hnodeb[master]: hnbap: Improve rx path and implement HnbRegisterReject In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 ) Change subject: hnbap: Improve rx path and implement HnbRegisterReject ...................................................................... hnbap: Improve rx path and implement HnbRegisterReject The process is shut down if we receive such a message. Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a --- M src/osmo-hnodeb/hnbap.c 1 file changed, 78 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 585354b..3287eeb 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -33,6 +33,7 @@ #include #include #include +#include static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) { @@ -44,12 +45,31 @@ } hnb->rnc_id = accept.rnc_id; - LOGP(DHNBAP, LOGL_INFO, "HNB Register accept with RNC ID %u\n", hnb->rnc_id); + LOGP(DHNBAP, LOGL_INFO, "Rx HNB Register accept with RNC ID %u\n", hnb->rnc_id); hnbap_free_hnbregisteraccepties(&accept); return 0; } +static int hnb_rx_hnb_register_rej(struct hnb *hnb, ANY_t *in) +{ + int rc; + HNBAP_HNBRegisterRejectIEs_t reject; + + rc = hnbap_decode_hnbregisterrejecties(&reject, in); + if (rc < 0) { + LOGP(DHNBAP, LOGL_NOTICE, "Rx HNB Register Reject: parse failure\n"); + return -EINVAL; + } + + LOGP(DHNBAP, LOGL_NOTICE, "Rx HNB Register Reject with cause %s\n", + hnbap_cause_str(&reject.cause)); + hnbap_free_hnbregisterrejecties(&reject); + + hnb_shutdown(hnb, "Rx HNB Register Reject", false); + return 0; +} + static int hnb_rx_ue_register_acc(struct hnb *hnb, ANY_t *in) { int rc; @@ -79,6 +99,53 @@ return 0; } +static int hnb_hnbap_rx_initiating(struct hnb *hnb, struct HNBAP_InitiatingMessage *init) +{ + int rc; + + switch (init->procedureCode) { + default: + LOGP(DHNBAP, LOGL_ERROR, "Rx HNBAP initiatingMessage %ld unsupported\n", init->procedureCode); + rc = -ENOSPC; + break; + } + return rc; +} + +static int hnb_hnbap_rx_successful(struct hnb *hnb, struct HNBAP_SuccessfulOutcome *succ) +{ + int rc; + + switch (succ->procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: + /* Get HNB id and send UE Register request */ + rc = hnb_rx_hnb_register_acc(hnb, &succ->value); + break; + case HNBAP_ProcedureCode_id_UERegister: + rc = hnb_rx_ue_register_acc(hnb, &succ->value); + break; + default: + rc = -ENOSPC; + break; + } + return rc; +} + +static int hnb_hnbap_rx_unsuccessful(struct hnb *hnb, struct HNBAP_UnsuccessfulOutcome *unsucc) +{ + int rc; + + switch (unsucc->procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: + rc = hnb_rx_hnb_register_rej(hnb, &unsucc->value); + break; + default: + rc = -ENOSPC; + break; + } + return rc; +} + int hnb_hnbap_rx(struct hnb *hnb, struct msgb *msg) { HNBAP_HNBAP_PDU_t _pdu, *pdu = &_pdu; @@ -93,21 +160,20 @@ return -EINVAL; } - if (pdu->present != HNBAP_HNBAP_PDU_PR_successfulOutcome) { - LOGP(DHNBAP, LOGL_ERROR, "Unexpected HNBAP message received\n"); - } - - switch (pdu->choice.successfulOutcome.procedureCode) { - case HNBAP_ProcedureCode_id_HNBRegister: - /* Get HNB id and send UE Register request */ - rc = hnb_rx_hnb_register_acc(hnb, &pdu->choice.successfulOutcome.value); + switch (pdu->present) { + case HNBAP_HNBAP_PDU_PR_initiatingMessage: + rc = hnb_hnbap_rx_initiating(hnb, &pdu->choice.initiatingMessage); break; - case HNBAP_ProcedureCode_id_UERegister: - rc = hnb_rx_ue_register_acc(hnb, &pdu->choice.successfulOutcome.value); + case HNBAP_HNBAP_PDU_PR_successfulOutcome: + rc = hnb_hnbap_rx_successful(hnb, &pdu->choice.successfulOutcome); break; + case HNBAP_HNBAP_PDU_PR_unsuccessfulOutcome: + rc = hnb_hnbap_rx_unsuccessful(hnb, &pdu->choice.unsuccessfulOutcome); + break; + case HNBAP_HNBAP_PDU_PR_NOTHING: /* No components present */ default: + LOGP(DHNBAP, LOGL_ERROR, "Unexpected HNBAP message received\n"); rc = -ENOSPC; - break; } return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id4656140b7f51b07860dcbeed449ed68c3a9f85a Gerrit-Change-Number: 26349 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:58:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 25 Nov 2021 15:58:05 +0000 Subject: Change in pysim[master]: fix invalid dependency References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26371 ) Change subject: fix invalid dependency ...................................................................... fix invalid dependency * serial is according to pypi: "A framework for serializing/deserializing JSON/YAML/XML into python class instances and vice versa" Change-Id: I154276fbadd70f6be94ba7d99e61f7e9eedbeb33 --- M requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/71/26371/1 diff --git a/requirements.txt b/requirements.txt index f547abf..b94bf24 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,5 +1,5 @@ pyscard -serial +pyserial pytlv cmd2==1.5 jsonpath-ng -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I154276fbadd70f6be94ba7d99e61f7e9eedbeb33 Gerrit-Change-Number: 26371 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 15:58:47 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Nov 2021 15:58:47 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 1: Diff looks good, but missing osmo-hnodeb-latest in docker-playground.git. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 15:58:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:00:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Nov 2021 16:00:10 +0000 Subject: Change in pysim[master]: fix: Decoder may raise KeyError In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26370 ) Change subject: fix: Decoder may raise KeyError ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f Gerrit-Change-Number: 26370 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 25 Nov 2021 16:00:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:01:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Nov 2021 16:01:14 +0000 Subject: Change in pysim[master]: fix invalid dependency In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26371 ) Change subject: fix invalid dependency ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I154276fbadd70f6be94ba7d99e61f7e9eedbeb33 Gerrit-Change-Number: 26371 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 25 Nov 2021 16:01:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:02:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 16:02:56 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 1: > Patch Set 1: > > Diff looks good, but missing osmo-hnodeb-latest in docker-playground.git. Ah indeed good point, I forgot I decided not to add that one yet because anyway it's going heavy development still. What about creating the job but mark it as disabled in jenkins (and also in this yml file?) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 16:02:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:04:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Nov 2021 16:04:14 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > Diff looks good, but missing osmo-hnodeb-latest in docker-playground.git. > > Ah indeed good point, I forgot I decided not to add that one yet because anyway it's going heavy development still. What about creating the job but mark it as disabled in jenkins (and also in this yml file?) that would work, and we use it already with other jobs in this file. just add: disabled: true -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 16:04:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:19:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 16:19:47 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 to look at the new patch set (#2). Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 --- M jobs/ttcn3-testsuites.yml 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/26369/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:19:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 16:19:57 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 16:19:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:22:53 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 25 Nov 2021 16:22:53 +0000 Subject: Change in pysim[master]: fix invalid dependency In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26371 ) Change subject: fix invalid dependency ...................................................................... Patch Set 1: Verified+1 Code-Review+2 I did not try it with a serial reader though but it looks good to me. a bit unrelated.: After installing pySim another program that also uses pyserial always complained: "When error: module 'serial' has no attribute 'Serial'" This was the fix: sudo pip3 uninstall serial sudo pip3 install pyserial Hopefully this problem is gone now. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I154276fbadd70f6be94ba7d99e61f7e9eedbeb33 Gerrit-Change-Number: 26371 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 16:22:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:24:41 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Nov 2021 16:24:41 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Nov 2021 16:24:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:24:54 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 25 Nov 2021 16:24:54 +0000 Subject: Change in pysim[master]: fix: Decoder may raise KeyError In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26370 ) Change subject: fix: Decoder may raise KeyError ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f Gerrit-Change-Number: 26370 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 16:24:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:27:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 16:27:51 +0000 Subject: Change in osmo-ci[master]: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26369 ) Change subject: jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) ...................................................................... jobs: Add jenkins jobs ttcn3-hnodeb-test(-latest) Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 --- M jobs/ttcn3-testsuites.yml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Verified osmith: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index e3e9f3e..515ac10 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -135,6 +135,9 @@ - ttcn3-bsc-test-vamos: blocking: "^(ttcn3|TTCN3-.*)-bsc-test.*" timer: 00 12 * * * + - ttcn3-hnodeb-test: + blocking: "^(ttcn3|TTCN3-.*)-hnodeb-test.*" + timer: 40 12 * * * # debian-stretch latest stable - nplab-m3ua-test-latest: @@ -202,6 +205,10 @@ - ttcn3-pcap-client-test-latest: blocking: "^(ttcn3|TTCN3-.*)-pcap-client-test.*" timer: 40 11 * * * + - ttcn3-hnodeb-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-hnodeb-test.*" + timer: 40 12 * * * + disabled: true # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I451741b77f925c7402de0342b8224e24e30e7b02 Gerrit-Change-Number: 26369 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 16:34:10 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 25 Nov 2021 16:34:10 +0000 Subject: Change in pysim[master]: fix invalid dependency In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26371 ) Change subject: fix invalid dependency ...................................................................... Patch Set 1: I forgot: README.md should be updated as well. Maybe we should consider to remove the dependencies listed there altogether and refer to requirements.txt only. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I154276fbadd70f6be94ba7d99e61f7e9eedbeb33 Gerrit-Change-Number: 26371 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 16:34:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 17:15:52 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 17:15:52 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... gbproxy: Add flush_ll test without new bvci Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Related: OS#5332 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 33 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/26372/1 diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index f569eaf..cb9ace7 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -2357,7 +2357,7 @@ * FLUSH-LL procedure ***********************************************************************/ -private function f_TC_flush_ll(charstring id) runs on BSSGP_ConnHdlr { +private function f_TC_flush_ll_bvci_new(charstring id) runs on BSSGP_ConnHdlr { var BssgpBvci bvci := g_pars.pcu[0].cfg.bvc[0].bvci; var integer i; for (i := 0; i < 10; i := i+1) { @@ -2375,10 +2375,38 @@ } setverdict(pass); } -testcase TC_flush_ll() runs on test_CT + +testcase TC_flush_ll_bvci_new() runs on test_CT { f_init(); - f_start_handlers(refers(f_TC_flush_ll), testcasename(), 6); + f_start_handlers(refers(f_TC_flush_ll_bvci_new), testcasename(), 6); + /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */ + f_cleanup(); +} + +private function f_TC_flush_ll_no_bvci_new(charstring id) runs on BSSGP_ConnHdlr { + var BssgpBvci bvci := g_pars.pcu[0].cfg.bvc[0].bvci; + var integer i; + for (i := 0; i < 10; i := i+1) { + var template (value) PDU_BSSGP pdu_tx := ts_BSSGP_FLUSH_LL(g_pars.tlli, bvci); + /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */ + var template (present) PDU_BSSGP pdu_rx := tr_BSSGP_FLUSH_LL(g_pars.tlli, bvci); + + f_sgsn2pcu(pdu_tx, pdu_rx, use_sig := true); + + pdu_tx := ts_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(0, 1), 23); + /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */ + pdu_rx := tr_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(0, 1), 23); + + f_pcu2sgsn(pdu_tx, pdu_rx, use_sig := true); + } + setverdict(pass); +} + +testcase TC_flush_ll_no_bvci_new() runs on test_CT +{ + f_init(); + f_start_handlers(refers(f_TC_flush_ll_no_bvci_new), testcasename(), 6); /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */ f_cleanup(); } @@ -3643,7 +3671,8 @@ execute( TC_rim_from_eutran() ); - execute( TC_flush_ll() ); + execute( TC_flush_ll_bvci_new() ); + execute( TC_flush_ll_no_bvci_new() ); execute( TC_fc_bvc() ); execute( TC_fc_ms() ); execute( TC_ms_reg_enq() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 17:16:36 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 17:16:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 1: Code-Review-1 Preventing merge before fix - this test will crash osmo-gbproxy -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Thu, 25 Nov 2021 17:16:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 17:21:05 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 17:21:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, lynxis lazus, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 to look at the new patch set (#2). Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... gbproxy: Add flush_ll test without new bvci Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Related: OS#5332 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 35 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/26372/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 17:36:20 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 17:36:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 17:36:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 18:04:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Nov 2021 18:04:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... hnodeb: Add initial infra to emulate HNB LL socket iface Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.default M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh A library/HNBLLIF_CodecPort.ttcn A library/HNBLLIF_Templates.ttcn A library/HNBLLIF_Types.ttcn 8 files changed, 444 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/26373/1 diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index 071e3e8..8743fcf 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -27,11 +27,19 @@ import from Iuh_Emulation all; +import from HNBLLIF_CodecPort all; +import from HNBLLIF_Types all; +import from HNBLLIF_Templates all; + /* this component represents a single Iuh connection at the HNBGW. */ type component HNBGW_ConnHdlr extends StatsD_ConnHdlr { port TELNETasp_PT HNBVTY; port HNBAP_PT HNBAP; port RUA_PT RUA; + /* HNBLLIF Interface of HNodeB */ + port HNBLLIF_CODEC_PT LLSK; + var integer g_llsk_conn_id; + var TestHdlrParams g_pars; var boolean g_vty_initialized := false; @@ -47,12 +55,11 @@ } /* initialize all parameters */ -function f_HNBGW_ConnHdlr_init(TestHdlrParams pars) runs on HNBGW_ConnHdlr { - var integer i := 0; +function f_HNBGW_ConnHdlr_init(charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { var Iuh_Emulation_CT vc_Iuh; g_pars := valueof(pars); - vc_Iuh := Iuh_Emulation_CT.create("HNBGW" & int2str(i)); + vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW"); connect(self:HNBAP, vc_Iuh:HNBAP); connect(self:RUA, vc_Iuh:RUA); @@ -61,18 +68,44 @@ iuh_pars.remote_sctp_port := -1; iuh_pars.local_ip := g_pars.hnbgw_addr; iuh_pars.local_sctp_port := g_pars.hnbgw_port; - vc_Iuh.start(Iuh_Emulation.main(iuh_pars, "Iuh" & int2str(i))); + vc_Iuh.start(Iuh_Emulation.main(iuh_pars, id & "-Iuh")); f_HNBGW_ConnHdlr_init_vty(); + + /* Connect to HNB on LLSK and do HELLO ping-pong */ + f_start_hnbllif(LLSK, id & "-LLSK", g_pars.hnbllif_sk_path, g_llsk_conn_id); +} + + +function f_start_hnbllif(HNBLLIF_CODEC_PT pt, charstring id, charstring hnbllif_sk_path, out integer hnbllif_conn_id) { + timer T := 2.0; + var HNBLLIF_send_data sd; + var HNBLLIF_Message last_hello_cnf; + if (hnbllif_sk_path == "") { + hnbllif_conn_id := -1; + return; + } + hnbllif_conn_id := f_hnbllif_connect(pt, hnbllif_sk_path); + + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_IND(HNBLLIF_Types.mp_hnbllif_version))); + T.start; + alt { + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLLIF_Types.mp_hnbllif_version); + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO_IND"); + } + } } type record TestHdlrParams { + charstring hnbllif_sk_path, /* "" means don't connect */ charstring hnbgw_addr, charstring hnodeb_addr, integer hnbgw_port, uint16_t rnc_id, charstring hNB_Identity_Info, - OCT3 plmnid, + uint16_t mcc, + uint16_t mnc, uint32_t cell_identity, uint16_t lac, uint8_t rac, @@ -82,23 +115,54 @@ /* Note: Do not use valueof() to get a value of this template, use * f_gen_test_hdlr_pars() instead in order to get a configuration. */ template (value) TestHdlrParams t_def_TestHdlrPars := { + hnbllif_sk_path := HNBLL_SOCK_DEFAULT, hnbgw_addr := "127.0.0.1", hnodeb_addr := "127.0.0.1", hnbgw_port := 29169, rnc_id := 23, hNB_Identity_Info := "OsmoHNodeB", - plmnid := '00F110'O, + mcc := 1, + mnc := 1, cell_identity := 1, lac := 2, rac := 3, sac := 4 } +/* HNBLLIF socket may at any time receive a new INFO.ind */ +altstep as_hnbllif_hello_cnf(HNBLLIF_CODEC_PT pt, integer hnbllif_conn_id, + out HNBLLIF_Message last_hello_cnf, template (present) HNBLLIF_Version exp_version := ?) { + var HNBLLIF_send_data sd; + [] pt.receive(t_SD_HNBLLIF(hnbllif_conn_id, tr_HNBLLIF_CTL_HELLO_CNF(HNBLLIF_Types.mp_hnbllif_version))) -> value sd { + last_hello_cnf := sd.data; + } + [] pt.receive(t_SD_HNBLLIF(hnbllif_conn_id, tr_HNBLLIF_CTL_HELLO_CNF(?))) -> value sd { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Invalid API_VERSION received"); + } +} + +function f_llsk_sd(template (present) HNBLLIF_Message exp_tmpl) runs on HNBGW_ConnHdlr +return template (present) HNBLLIF_send_data { + return t_SD_HNBLLIF(g_llsk_conn_id, exp_tmpl); +} + +function f_enc_mcc_mnc(uint16_t mcc_uint, uint16_t mnc_uint) return OCT3 { + var hexstring mnc; + var hexstring mcc := int2hex(mcc_uint, 3); + + if (mnc_uint < 100) { + mnc := int2hex(mnc_uint, 2); + return hex2oct(mcc[1] & mcc[0] & 'F'H & mcc[2] & mnc[1] & mnc[0]); + } else { + mnc := int2hex(mnc_uint, 3); + return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] & mnc[0]); + } +} function f_handle_hnbap_hnb_register_req() runs on HNBGW_ConnHdlr { HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), - g_pars.plmnid, + f_enc_mcc_mnc(g_pars.mcc, g_pars.mnc), int2bit(g_pars.cell_identity, 28), int2oct(g_pars.lac, 2), int2oct(g_pars.rac, 1), diff --git a/hnodeb/HNB_Tests.default b/hnodeb/HNB_Tests.default index a06dcc6..c385b9a 100644 --- a/hnodeb/HNB_Tests.default +++ b/hnodeb/HNB_Tests.default @@ -20,6 +20,7 @@ *.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" *.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" *.STATSVTY.PROMPT1 := "OsmoHNodeB> " +*.LLSK.socket_type := "SEQPACKET" [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoHNodeB"; diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 7a668dd..1039102 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -42,6 +42,10 @@ import from HNBGW_ConnectionHandler all; import from Iuh_Emulation all; +import from HNBLLIF_CodecPort all; +import from HNBLLIF_Types all; +import from HNBLLIF_Templates all; + modulepar { /* IP address at which the HNodeB can be reached */ charstring mp_hnodeb_ip := "127.0.0.1"; @@ -49,11 +53,17 @@ /* IP address at which the test binds */ charstring mp_hnbgw_iuh_ip := "127.0.0.1"; integer mp_hnbgw_iuh_port := 29169; + + charstring mp_hnbllif_sk_path := HNBLL_SOCK_DEFAULT; } type component test_CT extends CTRL_Adapter_CT { port TELNETasp_PT HNBVTY; + /* HNBLLIF Interface of HNodeB */ + port HNBLLIF_CODEC_PT LLSK; + var integer g_llsk_conn_id; + /* global test case guard timer (actual timeout value is set in f_init()) */ timer T_guard := 30.0; } @@ -83,6 +93,12 @@ f_vty_set_prompts(HNBVTY); f_vty_transceive(HNBVTY, "enable"); } + +private function f_init_hnbllif() runs on test_CT { + map(self:LLSK, system:LLSK); + f_start_hnbllif(LLSK, testcasename(), mp_hnbllif_sk_path, g_llsk_conn_id); +} + /* global initialization function */ function f_init(float guard_timeout := 30.0) runs on test_CT { var integer bssap_idx; @@ -91,8 +107,6 @@ activate(as_Tguard()); f_init_vty("VirtHNBGW"); - - /* TODO: Wait for Iuh connection to be established */ } friend function f_shutdown_helper() runs on test_CT { @@ -101,9 +115,10 @@ mtc.stop; } -friend function f_gen_test_hdlr_pars() return TestHdlrParams { +private function f_gen_test_hdlr_pars() runs on test_CT return TestHdlrParams { var TestHdlrParams pars := valueof(t_def_TestHdlrPars); + pars.hnbllif_sk_path := mp_hnbllif_sk_path; pars.hnodeb_addr := mp_hnodeb_ip; pars.hnbgw_addr := mp_hnbgw_iuh_ip; pars.hnbgw_port := mp_hnbgw_iuh_port; @@ -113,27 +128,10 @@ type function void_fn(charstring id) runs on HNBGW_ConnHdlr; /* helper function to create and connect a HNBGW_ConnHdlr component */ -private function f_connect_handler(inout HNBGW_ConnHdlr vc_conn, integer bssap_idx := 0) runs on test_CT { - /*connect(vc_conn:RAN, g_bssap[bssap_idx].vc_RAN:PROC); - connect(vc_conn:MGCP_PROC, vc_MGCP:MGCP_PROC); - connect(vc_conn:RSL, bts[0].rsl.vc_RSL:CLIENT_PT); - connect(vc_conn:RSL_PROC, bts[0].rsl.vc_RSL:RSL_PROC); - if (isvalue(bts[1])) { - connect(vc_conn:RSL1, bts[1].rsl.vc_RSL:CLIENT_PT); - connect(vc_conn:RSL1_PROC, bts[1].rsl.vc_RSL:RSL_PROC); +private function f_connect_handler(inout HNBGW_ConnHdlr vc_conn, TestHdlrParams pars) runs on test_CT { + if (pars.hnbllif_sk_path != "") { + map(vc_conn:LLSK, system:LLSK); } - if (isvalue(bts[2])) { - connect(vc_conn:RSL2, bts[2].rsl.vc_RSL:CLIENT_PT); - connect(vc_conn:RSL2_PROC, bts[2].rsl.vc_RSL:RSL_PROC); - } - connect(vc_conn:BSSAP, g_bssap[bssap_idx].vc_RAN:CLIENT); - if (mp_enable_lcs_tests) { - connect(vc_conn:BSSAP_LE, g_bssap_le.vc_BSSAP_LE:CLIENT); - connect(vc_conn:BSSAP_LE_PROC, g_bssap_le.vc_BSSAP_LE:PROC); - } - connect(vc_conn:MGCP, vc_MGCP:MGCP_CLIENT); - connect(vc_conn:MGCP_MULTI, vc_MGCP:MGCP_CLIENT_MULTI); - connect(vc_conn:STATSD_PROC, vc_STATSD:STATSD_PROC);*/ } function f_start_handler_create(TestHdlrParams pars) @@ -141,7 +139,7 @@ var charstring id := testcasename(); var HNBGW_ConnHdlr vc_conn; vc_conn := HNBGW_ConnHdlr.create(id); - f_connect_handler(vc_conn); + f_connect_handler(vc_conn, pars); return vc_conn; } @@ -168,27 +166,30 @@ /* first function inside ConnHdlr component; sets g_pars + starts function */ private function f_handler_init(void_fn fn, charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { - f_HNBGW_ConnHdlr_init(pars); + f_HNBGW_ConnHdlr_init(id, pars); HNBAP.receive(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* Wait for HNB to connect to us */ fn.apply(id); } -private function f_tc_hnb_register_request(charstring id) runs on HNBGW_ConnHdlr { +private function f_tc_hnb_register_request_accept(charstring id) runs on HNBGW_ConnHdlr { f_handle_hnbap_hnb_register_req(); + + LLSK.receive(f_llsk_sd(tr_HNBLLIF_IUH_CONFIGURE_REQ(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); f_sleep(1.0); } testcase TC_hnb_register_request_accept() runs on test_CT { var HNBGW_ConnHdlr vc_conn; f_init(); - vc_conn := f_start_handler(refers(f_tc_hnb_register_request)); + vc_conn := f_start_handler(refers(f_tc_hnb_register_request_accept)); vc_conn.done; f_shutdown_helper(); } private function f_tc_hnb_register_reject(charstring id) runs on HNBGW_ConnHdlr { HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), - g_pars.plmnid, + f_enc_mcc_mnc(g_pars.mcc, g_pars.mnc), int2bit(g_pars.cell_identity, 28), int2oct(g_pars.lac, 2), int2oct(g_pars.rac, 1), diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh index ba946e8..6ddb4c0 100755 --- a/hnodeb/gen_links.sh +++ b/hnodeb/gen_links.sh @@ -27,6 +27,10 @@ FILES="SCTPasp_PT.cc SCTPasp_PT.hh SCTPasp_PortType.ttcn SCTPasp_Types.ttcn" gen_links $DIR $FILES +DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src +FILES="UD_PT.cc UD_PT.hh UD_PortType.ttcn UD_Types.ttcn" +gen_links $DIR $FILES + DIR=$BASEDIR/titan.ProtocolModules.SDP/src FILES="SDP_EncDec.cc SDP_Types.ttcn SDP_parse_.tab.c SDP_parse_.tab.h SDP_parse_parser.h SDP_parser.l SDP_parser.y lex.SDP_parse_.c" @@ -51,7 +55,8 @@ gen_links $DIR $FILES DIR=../library -FILES="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " +FILES="HNBLLIF_Types.ttcn HNBLLIF_Templates.ttcn HNBLLIF_CodecPort.ttcn " +FILES+="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " FILES+="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " diff --git a/hnodeb/regen_makefile.sh b/hnodeb/regen_makefile.sh index 9ebfaf2..2d13504 100755 --- a/hnodeb/regen_makefile.sh +++ b/hnodeb/regen_makefile.sh @@ -24,6 +24,7 @@ TELNETasp_PT.cc HNBAP_EncDec.cc RUA_EncDec.cc + UD_PT.cc " export CPPFLAGS_TTCN3=" diff --git a/library/HNBLLIF_CodecPort.ttcn b/library/HNBLLIF_CodecPort.ttcn new file mode 100644 index 0000000..fed6c69 --- /dev/null +++ b/library/HNBLLIF_CodecPort.ttcn @@ -0,0 +1,90 @@ +/* OsmoHNodeB Lower Layer Socket Interface codec port in TTCN-3 + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * Author: Pau Espin Pedrol + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBLLIF_CodecPort { + +import from Osmocom_Types all; +import from HNBLLIF_Types all; +import from UD_PortType all; +import from UD_Types all; + +type record HNBLLIF_send_data { + HNBLLIF_Message data, + integer id +}; + +private function HNBLLIF_to_UD(in HNBLLIF_send_data pin, out UD_send_data pout) { + pout.id := pin.id; + pout.data := enc_HNBLLIF_Message(pin.data); +} with { extension "prototype(fast)" }; + +private function UD_to_HNBLLIF(in UD_send_data pin, out HNBLLIF_send_data pout) { + pout.id := pin.id; + pout.data := dec_HNBLLIF_Message(pin.data); +} with { extension "prototype(fast)" }; + +type port HNBLLIF_CODEC_PT message { + out UD_close, UD_listen, UD_shutdown, UD_connect, HNBLLIF_send_data; + in UD_listen_result, UD_connect_result, UD_connected, HNBLLIF_send_data; +} with { extension "user UD_PT + out ( + UD_close -> UD_close:simple; + UD_listen -> UD_listen:simple; + UD_shutdown -> UD_shutdown:simple; + UD_connect -> UD_connect:simple; + HNBLLIF_send_data -> UD_send_data: function(HNBLLIF_to_UD) + ) + in ( + UD_listen_result -> UD_listen_result:simple; + UD_connect_result -> UD_connect_result:simple; + UD_send_data -> HNBLLIF_send_data: function(UD_to_HNBLLIF); + UD_connected -> UD_connected:simple + )" +}; + +template HNBLLIF_send_data t_SD_HNBLLIF(integer id, template HNBLLIF_Message pdu) := { + data := pdu, + id := id +} +function f_hnbllif_connect(HNBLLIF_CODEC_PT pt, charstring sock) return integer { + var UD_connect_result res; + timer T := 5.0; + + T.start; + pt.send(UD_connect:{sock, -1}); + alt { + [] pt.receive(UD_connect_result:?) -> value res { + if (ispresent(res.result) and ispresent(res.result.result_code) and + res.result.result_code == ERROR) { + if (ispresent(res.result.err)) { + setverdict(fail, "Error connecting to HNBLL socket ", sock, ": ", res.result.err); + } else { + setverdict(fail, "Error connecting to HNBLL socket ", sock); + } + mtc.stop; + } else { + return res.id; + } + } + [] T.timeout { + setverdict(fail, "Timeout connecting to HNBLL socket ", sock); + mtc.stop; + } + } + return -23; +} + +function f_hnbllif_close(HNBLLIF_CODEC_PT pt, integer id) +{ + pt.send(UD_close:{id := id}); +} + +} diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn new file mode 100644 index 0000000..9b7fbb6 --- /dev/null +++ b/library/HNBLLIF_Templates.ttcn @@ -0,0 +1,96 @@ +/* Osmocom HNBLL Interface Templates, as per osmo-hnodeb/include/osmocom/hnodeb/hnb_prim.h + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * Author: Pau Espin Pedrol + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBLLIF_Templates { + +import from General_Types all; +import from Osmocom_Types all; +import from HNBLLIF_Types all; + +/********************** + * CTL SAPI + **********************/ +template (value) HNBLLIF_Message ts_HNBLLIF_CTL_HELLO_IND(template (value) uint32_t api_version) := { + sapi := HNBLL_IF_SAPI_CTL, + u := { + ctl := { + prim := HNBLL_IF_CTL_MSG_HELLO, + u := { + hello := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + api_version := api_version + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_CTL_HELLO_CNF(template (present) uint32_t api_version := ?) := { + sapi := HNBLL_IF_SAPI_CTL, + u := { + ctl := { + prim := HNBLL_IF_CTL_MSG_HELLO, + u := { + hello := { + op := HNBLL_IF_OP_CONFIRM, + u := { + cnf := { + api_version := api_version + } + } + } + } + } + } +} + + +/********************** + * IUH SAPI + **********************/ + +template (present) HNBLLIF_Message tr_HNBLLIF_IUH_CONFIGURE_REQ(template (present) uint16_t mcc := ?, + template (present) uint16_t mnc := ?, + template (present) uint16_t cell_identity := ?, + template (present) uint16_t lac := ?, + template (present) uint8_t rac := ?, + template (present) uint16_t sac := ?, + template (present) uint16_t rnc_id := ?) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_CONFIGURE, + u := { + configure := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + mcc := mcc, + mnc := mnc, + cell_identity := cell_identity, + lac := lac, + rac := rac, + reserved := ?, + sac := sac, + rnc_id := rnc_id + } + } + } + } + } + } +} + +} with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn new file mode 100644 index 0000000..9a3ee1b --- /dev/null +++ b/library/HNBLLIF_Types.ttcn @@ -0,0 +1,150 @@ +/* Osmocom HNBLL Interface Types, as per osmo-hnodeb/include/osmocom/hnodeb/hnb_prim.h + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * Author: Pau Espin Pedrol + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBLLIF_Types { + +import from General_Types all; +import from Osmocom_Types all; +import from Native_Functions all; + +modulepar { + /* HNBLLIF version supported by the IUT */ + HNBLLIF_Version mp_hnbllif_version := 0; +}; + +const charstring HNBLL_SOCK_DEFAULT := "/tmp/hnb_prim_sock"; +type integer HNBLLIF_Version (0); /* supported versions */ + +/********************** + * CTL SAPI + **********************/ + + +type enumerated HNBLLIF_CTL_MsgType { + HNBLL_IF_CTL_MSG_HELLO ('00000000'O) +} with { variant "FIELDLENGTH(32)" }; + +type record HNBLLIF_CTL_hello_ind { + uint16_t api_version +} with { variant "" }; + +type record HNBLLIF_CTL_hello_cnf { + uint16_t api_version +} with { variant "" }; + +type union HNBLLIF_CTL_PrimOpUnion_hello { + HNBLLIF_CTL_hello_ind ind, + HNBLLIF_CTL_hello_cnf cnf, + octetstring other +} with { variant "" }; + +type record HNBLLIF_CTL_PrimOp_hello { + HNBLLIF_Operation op, + HNBLLIF_CTL_PrimOpUnion_hello u +} with { variant (u) "CROSSTAG( ind, op = HNBLL_IF_OP_INDICATION; + cnf, op = HNBLL_IF_OP_CONFIRM; + other, OTHERWISE)" +}; + +type union HNBLLIF_CTL_PrimUnion { + HNBLLIF_CTL_PrimOp_hello hello, + octetstring other +} with { variant "" }; + +type record HNBLLIF_CTL_PrimHdr { + HNBLLIF_CTL_MsgType prim, + HNBLLIF_CTL_PrimUnion u +} with { variant (u) "CROSSTAG( hello, prim = HNBLL_IF_CTL_MSG_HELLO; + other, OTHERWISE)" +}; + +/********************** + * IUH SAPI + **********************/ +type enumerated HNBLLIF_IUH_MsgType { + HNBLL_IF_IUH_MSG_CONFIGURE ('00000000'O) +} with { variant "FIELDLENGTH(32)" }; + +type record HNBLLIF_IUH_configure_req { + uint16_t mcc, + uint16_t mnc, + uint16_t cell_identity, + uint16_t lac, + uint8_t rac, + uint8_t reserved, + uint16_t sac, + uint16_t rnc_id +} with { variant "" }; + +type union HNBLLIF_IUH_PrimOpUnion_configure { + HNBLLIF_IUH_configure_req req, + octetstring other +} with { variant "" }; + +type record HNBLLIF_IUH_PrimOp_configure { + HNBLLIF_Operation op, + HNBLLIF_IUH_PrimOpUnion_configure u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + other, OTHERWISE)" +}; + +type union HNBLLIF_IUH_PrimUnion { + HNBLLIF_IUH_PrimOp_configure configure, + octetstring other +} with { variant "" }; + +type record HNBLLIF_IUH_PrimHdr { + HNBLLIF_IUH_MsgType prim, + HNBLLIF_IUH_PrimUnion u +} with { variant (u) "CROSSTAG( configure, prim = HNBLL_IF_IUH_MSG_CONFIGURE; + other, OTHERWISE)" +}; + + +/********************** +* General +**********************/ +type enumerated HNBLLIF_Sapi { + HNBLL_IF_SAPI_CTL ('0000'O), + HNBLL_IF_SAPI_IUH ('0001'O)//, + //HNBLL_IF_SAPI_GTP ('0002'O), + //HNBLL_IF_SAPI_AUDIO ('0003'O), +} with { variant "FIELDLENGTH(32)" }; + +type enumerated HNBLLIF_Operation { + HNBLL_IF_OP_REQUEST ('00000000'O), + HNBLL_IF_OP_RESPONSE ('00000001'O), + HNBLL_IF_OP_INDICATION ('00000002'O), + HNBLL_IF_OP_CONFIRM ('00000003'O) +} with { variant "FIELDLENGTH(32)" }; + +type union HNBLLIF_SapiUnion { + HNBLLIF_CTL_PrimHdr ctl, + HNBLLIF_IUH_PrimHdr iuh, + octetstring other +} with { variant "" }; + +type record HNBLLIF_Message { + HNBLLIF_Sapi sapi, + HNBLLIF_SapiUnion u +} with { variant (u) "CROSSTAG( + ctl, sapi = HNBLL_IF_SAPI_CTL; + iuh, sapi = HNBLL_IF_SAPI_IUH; + other, OTHERWISE)" +}; + +external function enc_HNBLLIF_Message(in HNBLLIF_Message pdu) return octetstring + with { extension "prototype(convert) encode(RAW)" }; +external function dec_HNBLLIF_Message(in octetstring stream) return HNBLLIF_Message + with { extension "prototype(convert) decode(RAW)" }; + + +} with { encode "RAW" variant "BYTEORDER(first)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 21:08:12 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 21:08:12 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 ) Change subject: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE ...................................................................... gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE The BVCI IE is listed as conditional and is only included if the flush action indicates that LLC-PDUs are transferred. (3GPP TS 48.018 Ch. 10.4.2). The code in gbprox_rx_sig_from_bss unconditionally tries to get a BVCI from a FLUSH_LL message which could result in a segfault if no such IE is included. Routing towards the SGSN can happen simply based on TLLI (for pooling) since there is only one signalling BVC towards the SGSN. Related: OS#5332 Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7 --- M src/gb_proxy.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/74/26374/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index fbb6e79..d6d760f 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -1151,15 +1151,27 @@ rc = gbprox_rx_rim_from_bss(tp, nse, msg, log_pfx, pdut_name); break; case BSSGP_PDUT_LLC_DISCARD: - case BSSGP_PDUT_FLUSH_LL_ACK: /* route based on BVCI + TLLI */ ptp_bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI)); tlli = osmo_load32be(TLVP_VAL(&tp[0], BSSGP_IE_TLLI)); from_bvc = gbproxy_bvc_by_bvci(nse, ptp_bvci); if (!from_bvc) goto err_no_bvc; - gbprox_bss2sgsn_tlli(from_bvc->cell, msg, &tlli, true); + rc = gbprox_bss2sgsn_tlli(from_bvc->cell, msg, &tlli, true); break; + case BSSGP_PDUT_FLUSH_LL_ACK: + { + /* Route based on TLLI */ + tlli = osmo_load32be(TLVP_VAL(&tp[0], BSSGP_IE_TLLI)); + struct gbproxy_sgsn *sgsn = gbproxy_select_sgsn(nse->cfg, &tlli); + if (!sgsn) { + rc = -EINVAL; + break; + } + + rc = gbprox_relay2nse(msg, sgsn->nse, 0); + break; + } case BSSGP_PDUT_PAGING_PS_REJECT: case BSSGP_PDUT_DUMMY_PAGING_PS_RESP: { @@ -1459,6 +1471,10 @@ rc = osmo_fsm_inst_dispatch(sgsn_bvc->fi, BSSGP_BVCFSM_E_RX_UNBLOCK_ACK, msg); break; case BSSGP_PDUT_FLUSH_LL: + /* TODO: If new BVCI is on different NSE we should remove the new BVCI so the + * message is interpreted as a request to delete the PDUs, not forward them. + * If we negotiate Inter-NSE re-routing or LCS-procedures we can also + * add the NSEI TLV to trigger re-routing the PDUs */ /* simple case: BVCI IE is mandatory */ bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI)); sgsn_bvc = gbproxy_bvc_by_bvci(nse, bvci); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7 Gerrit-Change-Number: 26374 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Nov 25 21:20:08 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Nov 2021 21:20:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 2: The no_bvci_new test still fails although it doesn't seem to do anything significantly different from the other test. Misc_Helpers.ttcn:15 setverdict(fail): none -> fail reason: ""BSSGP_Emulation.ttcnpp:820 : Couldn't find Component for TL LI 'C2180023'O"", new component reason: ""BSSGP_Emulation.ttcnpp:820 : Couldn't find Component for TLLI 'C2180023'O"" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 25 Nov 2021 21:20:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 00:31:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Nov 2021 00:31:22 +0000 Subject: Change in pysim[master]: fix: Decoder may raise KeyError In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26370 ) Change subject: fix: Decoder may raise KeyError ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f Gerrit-Change-Number: 26370 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 26 Nov 2021 00:31:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 09:19:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Nov 2021 09:19:16 +0000 Subject: Change in pysim[master]: fix: Decoder may raise KeyError In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26370 ) Change subject: fix: Decoder may raise KeyError ...................................................................... fix: Decoder may raise KeyError This fixes an issue where a KeyError may be raised when 'A5' is not present in `fcp` Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f --- M pySim/ts_102_221.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve dexter: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index adb40c1..f145d19 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -684,7 +684,7 @@ fcp_tlv = TLV(FCP_TLV_MAP) fcp = fcp_tlv.parse(fcp_base['62']) # further decode the proprietary information - if fcp['A5']: + if 'A5' in fcp: prop_tlv = TLV(FCP_Proprietary_TLV_MAP) prop = prop_tlv.parse(fcp['A5']) fcp['A5'] = tlv_val_interpret(FCP_prorietary_interpreter_map, prop) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5bb6131bd76c7bae2a70034c429cae2b380d164f Gerrit-Change-Number: 26370 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 09:19:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Nov 2021 09:19:26 +0000 Subject: Change in pysim[master]: fix invalid dependency In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26371 ) Change subject: fix invalid dependency ...................................................................... fix invalid dependency * serial is according to pypi: "A framework for serializing/deserializing JSON/YAML/XML into python class instances and vice versa" Change-Id: I154276fbadd70f6be94ba7d99e61f7e9eedbeb33 --- M requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve dexter: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/requirements.txt b/requirements.txt index f547abf..b94bf24 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,5 +1,5 @@ pyscard -serial +pyserial pytlv cmd2==1.5 jsonpath-ng -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I154276fbadd70f6be94ba7d99e61f7e9eedbeb33 Gerrit-Change-Number: 26371 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 09:22:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Nov 2021 09:22:21 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 ) Change subject: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7 Gerrit-Change-Number: 26374 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 26 Nov 2021 09:22:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 09:23:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Nov 2021 09:23:24 +0000 Subject: Change in libosmocore[master]: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LO... In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26356 ) Change subject: logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LOGGING ...................................................................... logging: allow disabling macros using a new define: LIBOSMOCORE_NO_LOGGING This was previously unconditionally defined, so embedded targets were unable to get rid of the log macros and functions. Change-Id: I589f93d98a6bc5cf6221c56e2fe3f27bfdd200e8 --- M include/osmocom/core/logging.h 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index a554adc..a95c478 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -15,6 +15,10 @@ #define DEBUG #endif +#ifdef LIBOSMOCORE_NO_LOGGING +#undef DEBUG +#endif + #ifdef DEBUG /*! Log a debug message through the Osmocom logging framework * \param[in] ss logging subsystem (e.g. \ref DLGLOBAL) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I589f93d98a6bc5cf6221c56e2fe3f27bfdd200e8 Gerrit-Change-Number: 26356 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 10:19:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Nov 2021 10:19:27 +0000 Subject: Change in osmocom-bb[master]: gprsdecode: Don't leak memory in gsmtap_sendmsg() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/26366 ) Change subject: gprsdecode: Don't leak memory in gsmtap_sendmsg() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/26366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib9e439ad6f24c573abb6da1523713a669898d23f Gerrit-Change-Number: 26366 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Nov 2021 10:19:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 10:19:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Nov 2021 10:19:30 +0000 Subject: Change in osmocom-bb[master]: gprsdecode: Don't leak memory in gsmtap_sendmsg() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/26366 ) Change subject: gprsdecode: Don't leak memory in gsmtap_sendmsg() ...................................................................... gprsdecode: Don't leak memory in gsmtap_sendmsg() Change-Id: Ib9e439ad6f24c573abb6da1523713a669898d23f Depends: libosmocore I106b09f2a49bf24ce0e8d11fd4d4ee93e9cafdf5 Related: OS#5329 --- M src/host/gprsdecode/gsmtap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/gprsdecode/gsmtap.c b/src/host/gprsdecode/gsmtap.c index 5c124b2..1096c2d 100644 --- a/src/host/gprsdecode/gsmtap.c +++ b/src/host/gprsdecode/gsmtap.c @@ -100,6 +100,6 @@ memcpy(dst, data, len); /* Finally, send to the sink */ - gsmtap_sendmsg(gti, msg); + gsmtap_sendmsg_free(gti, msg); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/26366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib9e439ad6f24c573abb6da1523713a669898d23f Gerrit-Change-Number: 26366 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 11:05:40 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 11:05:40 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Handle FLUSH_LL_ACK differently References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 ) Change subject: BSSGP_Emulation: Handle FLUSH_LL_ACK differently ...................................................................... BSSGP_Emulation: Handle FLUSH_LL_ACK differently The BVCI that this message might contain should not be used to route it. It referes to the BVCI that the PDUs were transferred to (BVCI (new)). Instead broadcast to all components. Change-Id: Ia1df35da44ef28d91501bb898e1059bf1390129b --- M library/BSSGP_Emulation.ttcnpp 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/26382/1 diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp index 8d27fd1..23c8d03 100644 --- a/library/BSSGP_Emulation.ttcnpp +++ b/library/BSSGP_Emulation.ttcnpp @@ -333,6 +333,16 @@ } } + /* Broadcast FLUSH_LL_ACK no matter the BVCI */ + [] BSCP.receive(f_BnsUdInd(tr_BSSGP_FLUSH_LL_ACK(?, ?, ?), 0)) -> value udi { + log("Rx FLUSH_LL_ACK: broadcasting"); + for (var integer i := 0; i < lengthof(BvcTable); i := i+1) { + if (isbound(BvcTable[i].comp_ref) and BvcTable[i].comp_ref != null) { + BVC.send(udi) to BvcTable[i].comp_ref; + } + } + } + /* Route based on PTP BVCI in payload/IE of signaling PDU */ [] BSCP.receive(f_BnsUdInd(?, 0)) -> value udi { var template (omit) BssgpBvci ptp_bvci := f_BSSGP_BVCI_get(udi.bssgp); @@ -1163,6 +1173,19 @@ } } + [] BVC.receive(tr_ptp_BnsUdInd(tr_BSSGP_FLUSH_LL_ACK(?, ?, ?), 0)) -> value udi { + var BssgpDecoded dec := f_dec_bssgp(udi.bssgp); + + log("Broadcasting FLUSH_LL_ACK ", dec); + /* broadcast this message to all components */ + // TITAN DOESN'T DO THIS, *SIGH*: "BSSGP_SP.send(dec) to all component;" + for (var integer i := 0; i < sizeof(ClientTable); i := i+1) { + if (isbound(ClientTable[i].comp_ref) and ClientTable[i].comp_ref != null) { + f_send_bssgp_dec(dec, ClientTable[i].comp_ref, BSSGP_SP_SIG); + } + } + } + /* Any other SIG BSSGP message: If it has TLLI, route to component; otherwise broadcast */ [] BVC.receive(tr_ptp_BnsUdInd(?, 0)) -> value udi { var BssgpDecoded dec := f_dec_bssgp(udi.bssgp); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1df35da44ef28d91501bb898e1059bf1390129b Gerrit-Change-Number: 26382 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 11:06:08 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 11:06:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 26 Nov 2021 11:06:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 11:06:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Nov 2021 11:06:36 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 ) Change subject: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7 Gerrit-Change-Number: 26374 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 26 Nov 2021 11:06:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 11:06:47 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 11:06:47 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 ) Change subject: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7 Gerrit-Change-Number: 26374 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 26 Nov 2021 11:06:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 11:06:52 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 11:06:52 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 ) Change subject: gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE ...................................................................... gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE The BVCI IE is listed as conditional and is only included if the flush action indicates that LLC-PDUs are transferred. (3GPP TS 48.018 Ch. 10.4.2). The code in gbprox_rx_sig_from_bss unconditionally tries to get a BVCI from a FLUSH_LL message which could result in a segfault if no such IE is included. Routing towards the SGSN can happen simply based on TLLI (for pooling) since there is only one signalling BVC towards the SGSN. Related: OS#5332 Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7 --- M src/gb_proxy.c 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index fbb6e79..d6d760f 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -1151,15 +1151,27 @@ rc = gbprox_rx_rim_from_bss(tp, nse, msg, log_pfx, pdut_name); break; case BSSGP_PDUT_LLC_DISCARD: - case BSSGP_PDUT_FLUSH_LL_ACK: /* route based on BVCI + TLLI */ ptp_bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI)); tlli = osmo_load32be(TLVP_VAL(&tp[0], BSSGP_IE_TLLI)); from_bvc = gbproxy_bvc_by_bvci(nse, ptp_bvci); if (!from_bvc) goto err_no_bvc; - gbprox_bss2sgsn_tlli(from_bvc->cell, msg, &tlli, true); + rc = gbprox_bss2sgsn_tlli(from_bvc->cell, msg, &tlli, true); break; + case BSSGP_PDUT_FLUSH_LL_ACK: + { + /* Route based on TLLI */ + tlli = osmo_load32be(TLVP_VAL(&tp[0], BSSGP_IE_TLLI)); + struct gbproxy_sgsn *sgsn = gbproxy_select_sgsn(nse->cfg, &tlli); + if (!sgsn) { + rc = -EINVAL; + break; + } + + rc = gbprox_relay2nse(msg, sgsn->nse, 0); + break; + } case BSSGP_PDUT_PAGING_PS_REJECT: case BSSGP_PDUT_DUMMY_PAGING_PS_RESP: { @@ -1459,6 +1471,10 @@ rc = osmo_fsm_inst_dispatch(sgsn_bvc->fi, BSSGP_BVCFSM_E_RX_UNBLOCK_ACK, msg); break; case BSSGP_PDUT_FLUSH_LL: + /* TODO: If new BVCI is on different NSE we should remove the new BVCI so the + * message is interpreted as a request to delete the PDUs, not forward them. + * If we negotiate Inter-NSE re-routing or LCS-procedures we can also + * add the NSEI TLV to trigger re-routing the PDUs */ /* simple case: BVCI IE is mandatory */ bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI)); sgsn_bvc = gbproxy_bvc_by_bvci(nse, bvci); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7 Gerrit-Change-Number: 26374 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 11:16:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Nov 2021 11:16:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Handle FLUSH_LL_ACK differently In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 ) Change subject: BSSGP_Emulation: Handle FLUSH_LL_ACK differently ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1df35da44ef28d91501bb898e1059bf1390129b Gerrit-Change-Number: 26382 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 11:16:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 12:28:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 12:28:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Handle FLUSH_LL_ACK differently In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 ) Change subject: BSSGP_Emulation: Handle FLUSH_LL_ACK differently ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1df35da44ef28d91501bb898e1059bf1390129b Gerrit-Change-Number: 26382 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 12:28:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 12:30:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 12:30:46 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 12:30:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 13:30:28 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 13:30:28 +0000 Subject: Change in osmo-bsc[master]: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26383 ) Change subject: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting ...................................................................... Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting Change-Id: Icc4947e68fa46aab180f2047231e51b997cca71b --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 7 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/26383/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index aab2514..904da62 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -114,8 +114,7 @@ /* Page a subscriber based on TMSI and LAC via the specified BTS. * The msc parameter is the MSC which issued the corresponding paging request. * Log an error if paging failed. */ -static void -page_subscriber(const struct bsc_paging_params *params, struct gsm_bts *bts, uint32_t lac) +static void page_subscriber(const struct bsc_paging_params *params, struct gsm_bts *bts, uint32_t lac) { int ret; @@ -132,16 +131,14 @@ "Paging request failed, or repeated paging on LAC %u\n", lac); } -static void -page_all_bts(const struct bsc_paging_params *params) +static void page_all_bts(const struct bsc_paging_params *params) { struct gsm_bts *bts; llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) page_subscriber(params, bts, GSM_LAC_RESERVED_ALL_BTS); } -static void -page_cgi(const struct bsc_paging_params *params) +static void page_cgi(const struct bsc_paging_params *params) { int i; for (i = 0; i < params->cil.id_list_len; i++) { @@ -170,8 +167,7 @@ } } -static void -page_lac_and_ci(const struct bsc_paging_params *params) +static void page_lac_and_ci(const struct bsc_paging_params *params) { int i; @@ -193,8 +189,7 @@ } } -static void -page_ci(const struct bsc_paging_params *params) +static void page_ci(const struct bsc_paging_params *params) { int i; @@ -214,8 +209,7 @@ } } -static void -page_lai_and_lac(const struct bsc_paging_params *params) +static void page_lai_and_lac(const struct bsc_paging_params *params) { int i; @@ -242,8 +236,7 @@ } } -static void -page_lac(const struct bsc_paging_params *params) +static void page_lac(const struct bsc_paging_params *params) { int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc4947e68fa46aab180f2047231e51b997cca71b Gerrit-Change-Number: 26383 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 13:30:28 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 13:30:28 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... stats: add bsc.paging:expired Similar to paging:attempted, count paging:expired not only per BTS, but also for the whole BSC. Add the timer bsc_T3113 to increase the counter only once if paging expires, and not once per BTS where paging expired. Related: SYS#4878 Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bsc_subscriber.h M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/osmo_bsc_bssap.c M src/osmo-bsc/paging.c 5 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/26384/1 diff --git a/include/osmocom/bsc/bsc_stats.h b/include/osmocom/bsc/bsc_stats.h index 9140f85..801a2c1 100644 --- a/include/osmocom/bsc/bsc_stats.h +++ b/include/osmocom/bsc/bsc_stats.h @@ -76,6 +76,7 @@ BSC_CTR_PAGING_ATTEMPTED, BSC_CTR_PAGING_DETACHED, BSC_CTR_PAGING_RESPONDED, + BSC_CTR_PAGING_EXPIRED, BSC_CTR_PAGING_NO_ACTIVE_PAGING, BSC_CTR_UNKNOWN_UNIT_ID, BSC_CTR_MSCPOOL_SUBSCR_NO_MSC, diff --git a/include/osmocom/bsc/bsc_subscriber.h b/include/osmocom/bsc/bsc_subscriber.h index 6fffafd..7736f38 100644 --- a/include/osmocom/bsc/bsc_subscriber.h +++ b/include/osmocom/bsc/bsc_subscriber.h @@ -5,6 +5,7 @@ #include #include +#include #include #include #include @@ -17,6 +18,9 @@ char imsi[GSM23003_IMSI_MAX_DIGITS+1]; uint32_t tmsi; + + /* Paging expired timer to increase bsc.paging:expired */ + struct osmo_timer_list bsc_T3113; }; const char *bsc_subscr_name(struct bsc_subscr *bsub); diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index c789aea..b48c90a 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -93,6 +93,7 @@ [BSC_CTR_PAGING_ATTEMPTED] = {"paging:attempted", "Paging attempts for a subscriber"}, [BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging request send failures because no responsible BTS was found"}, [BSC_CTR_PAGING_RESPONDED] = {"paging:responded", "Paging attempts with successful response"}, + [BSC_CTR_PAGING_EXPIRED] = {"paging:expired", "Paging Request expired because of timeout T3113"}, [BSC_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)"}, [BSC_CTR_UNKNOWN_UNIT_ID] = {"abis:unknown_unit_id", "Connection attempts from unknown IPA CCM Unit ID"}, diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index 904da62..bac691a 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -335,6 +335,48 @@ return bsc_paging_start(&paging); } +static void bsc_paging_T3113_expired(void *data) +{ + struct bsc_paging_params *params = (struct bsc_paging_params *)data; + + log_set_context(LOG_CTX_BSC_SUBSCR, params->bsub); + LOGP(DPAG, LOGL_DEBUG, "T3113 expired for %s, increasing bsc.paging:expired\n", + bsc_subscr_name(params->bsub)); + log_set_context(LOG_CTX_BSC_SUBSCR, NULL); + + rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->bsc_ctrs, BSC_CTR_PAGING_EXPIRED)); +} + +/*! Start the BSC's T3113 to increase the bsc.paging:expired if needed */ +void bsc_paging_start_timer(struct bsc_paging_params *params) +{ + struct gsm_bts *bts_i; + unsigned int timeout_s = 0; + struct timeval now; + + osmo_gettimeofday(&now, NULL); + + /* T3113 may be different per BTS (especially if set to dynamic), so + * get the max of T3113 of all BTS where the subscriber was paged */ + llist_for_each_entry(bts_i, &bsc_gsmnet->bts_list, list) { + struct gsm_paging_request *req; + + llist_for_each_entry(req, &bts_i->paging.pending_requests, entry) { + struct timeval remaining; + + if (req->bsub != params->bsub) + continue; + + osmo_timer_remaining(&req->T3113, &now, &remaining); + timeout_s = OSMO_MAX(timeout_s, remaining.tv_sec); + break; + } + } + + osmo_timer_setup(¶ms->bsub->bsc_T3113, bsc_paging_T3113_expired, params); + osmo_timer_schedule(¶ms->bsub->bsc_T3113, timeout_s, 0); +} + int bsc_paging_start(struct bsc_paging_params *params) { rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->bsc_ctrs, BSC_CTR_PAGING_ATTEMPTED)); @@ -388,6 +430,8 @@ break; } + bsc_paging_start_timer(params); + bsc_subscr_put(params->bsub, BSUB_USE_PAGING_START); log_set_context(LOG_CTX_BSC_SUBSCR, NULL); return 0; diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 04512be..b4a3881 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -411,6 +411,8 @@ return 1; } + osmo_timer_del(&bsub->bsc_T3113); + return 0; } @@ -479,6 +481,9 @@ count++; } } + + osmo_timer_del(&bsub->bsc_T3113); + return count; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 13:30:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 13:30:35 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom stack version to configs References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom stack version to configs ...................................................................... ttcn3: write Osmocom stack version to configs Write a line like 'Misc_Helpers.mp_osmocom_stack_version := "nightly"' into the TTCN-3 config file (e.g. BSC_Tests.cfg), before starting the testsuite. This allows executing different code paths in the tests based on that version. Related: OS#5327 Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 --- M jenkins-common.sh M ttcn3-bsc-test-vamos/jenkins.sh M ttcn3-bsc-test/jenkins-sccplite.sh M ttcn3-bsc-test/jenkins.sh M ttcn3-bscnat-test/jenkins.sh M ttcn3-bts-test/jenkins.sh M ttcn3-cbc-test/jenkins.sh M ttcn3-fr-test/jenkins.sh M ttcn3-gbproxy-test-fr/jenkins.sh M ttcn3-gbproxy-test/jenkins.sh M ttcn3-ggsn-test/jenkins.sh M ttcn3-hlr-test/jenkins.sh M ttcn3-hnodeb-test/jenkins.sh M ttcn3-mgw-test/jenkins.sh M ttcn3-msc-test/jenkins.sh M ttcn3-ns-test/jenkins-fr.sh M ttcn3-ns-test/jenkins-sgsn-sns.sh M ttcn3-ns-test/jenkins-sns.sh M ttcn3-ns-test/jenkins.sh M ttcn3-pcap-client-test/jenkins.sh M ttcn3-pcu-test/jenkins-sns.sh M ttcn3-pcu-test/jenkins.sh M ttcn3-remsim-test/jenkins.sh M ttcn3-sccp-test/jenkins.sh M ttcn3-sgsn-test/jenkins.sh M ttcn3-sip-test/jenkins.sh M ttcn3-smlc-test/jenkins.sh M ttcn3-stp-test/jenkins.sh 28 files changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/85/26385/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index ef6fad9..7aedca4 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -355,6 +355,41 @@ esac } +# Write the Osmocom stack version to the TTCN3 config file, so the tests may +# take different code paths based on that version (OS#5327) +# $1: path to TTCN3 config file (e.g. BSC_Tests.cfg) +write_osmocom_stack_version() { + local version="nightly" + local config="$1" + local line + + if ! [ -e "$config" ]; then + set +x + echo + echo "ERROR: TTCN3 config file "$config" not found in $PWD" + echo + exit 1 + fi + + case "$IMAGE_SUFFIX" in + latest*) + version="latest" + ;; + 20*q*-*) # e.g. 2021q1-centos8 + version="$(echo "$IMAGE_SUFFIX" | cut -d- -f 1)" # e.g. 2021q1 + ;; + *) + ;; + esac + + line="Misc_Helpers.mp_osmocom_stack_version := \"$version\"" + + sed \ + -i \ + "s/\[MODULE_PARAMETERS\]/\[MODULE_PARAMETERS\]\n$line/g" \ + "$config" +} + set -x # non-jenkins execution: assume local user name diff --git a/ttcn3-bsc-test-vamos/jenkins.sh b/ttcn3-bsc-test-vamos/jenkins.sh index 6462977..68039de 100755 --- a/ttcn3-bsc-test-vamos/jenkins.sh +++ b/ttcn3-bsc-test-vamos/jenkins.sh @@ -13,6 +13,7 @@ mkdir $VOL_BASE_DIR/bsc-tester cp BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index bc6eaa0..f4cada6 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/bsc-tester cp sccplite/BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg" mkdir $VOL_BASE_DIR/bsc cp sccplite/osmo-bsc.cfg $VOL_BASE_DIR/bsc/ diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index 18236a2..2e1f2f3 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -13,6 +13,7 @@ mkdir $VOL_BASE_DIR/bsc-tester cp BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-bscnat-test/jenkins.sh b/ttcn3-bscnat-test/jenkins.sh index 1182df0..1b0b436 100755 --- a/ttcn3-bscnat-test/jenkins.sh +++ b/ttcn3-bscnat-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/bscnat-tester cp BSCNAT_Tests.cfg $VOL_BASE_DIR/bscnat-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/bscnat-tester/BSCNAT_Tests.cfg" mkdir $VOL_BASE_DIR/bscnat cp osmo-bsc-nat.cfg $VOL_BASE_DIR/bscnat/ diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 67c6d07..81caa84 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -119,12 +119,16 @@ mkdir $VOL_BASE_DIR/bts-tester-generic cp BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-generic/ +write_osmocom_stack_version "$VOL_BASE_DIR/bts-tester-generic/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-virtphy cp virtphy/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-virtphy/ +write_osmocom_stack_version "$VOL_BASE_DIR/bts-tester-virtphy/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-oml cp oml/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-oml/ +write_osmocom_stack_version "$VOL_BASE_DIR/bts-tester-oml/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-hopping cp fh/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-hopping/ +write_osmocom_stack_version "$VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg" cp $VOL_BASE_DIR/bts-tester-generic/BTS_Tests.cfg \ $VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg.inc diff --git a/ttcn3-cbc-test/jenkins.sh b/ttcn3-cbc-test/jenkins.sh index 347623f..b5c8eea 100755 --- a/ttcn3-cbc-test/jenkins.sh +++ b/ttcn3-cbc-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/cbc-tester cp CBC_Tests.cfg $VOL_BASE_DIR/cbc-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/cbc-tester/CBC_Tests.cfg" mkdir $VOL_BASE_DIR/cbc cp osmo-cbc.cfg $VOL_BASE_DIR/cbc/ diff --git a/ttcn3-fr-test/jenkins.sh b/ttcn3-fr-test/jenkins.sh index c878000..934c945 100755 --- a/ttcn3-fr-test/jenkins.sh +++ b/ttcn3-fr-test/jenkins.sh @@ -16,6 +16,7 @@ chmod a+w $VOL_BASE_DIR/fr-tester cp FR_Tests.cfg $VOL_BASE_DIR/fr-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/fr-tester/FR_Tests.cfg" mkdir $VOL_BASE_DIR/frnet cp FRNET_Tests.cfg $VOL_BASE_DIR/frnet/ diff --git a/ttcn3-gbproxy-test-fr/jenkins.sh b/ttcn3-gbproxy-test-fr/jenkins.sh index d1ecb0a..a76ba70 100755 --- a/ttcn3-gbproxy-test-fr/jenkins.sh +++ b/ttcn3-gbproxy-test-fr/jenkins.sh @@ -29,6 +29,7 @@ # if we don't change permissions, dumpcap fails to write (despite starting it as root!) chmod a+w $VOL_BASE_DIR/gbproxy-tester cp GBProxy_Tests.cfg $VOL_BASE_DIR/gbproxy-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/gbproxy-tester/GBProxy_Tests.cfg" mkdir $VOL_BASE_DIR/gbproxy cp osmo-gbproxy.cfg $VOL_BASE_DIR/gbproxy/ diff --git a/ttcn3-gbproxy-test/jenkins.sh b/ttcn3-gbproxy-test/jenkins.sh index 3595c16..ce57db6 100755 --- a/ttcn3-gbproxy-test/jenkins.sh +++ b/ttcn3-gbproxy-test/jenkins.sh @@ -17,6 +17,7 @@ chmod a+w $VOL_BASE_DIR/gbproxy-tester cp GBProxy_Tests.cfg $VOL_BASE_DIR/gbproxy-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/gbproxy-tester/GBProxy_Tests.cfg" mkdir $VOL_BASE_DIR/gbproxy cp osmo-gbproxy.cfg $VOL_BASE_DIR/gbproxy/ diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index ba5e76d..a721572 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -19,6 +19,7 @@ mkdir $VOL_BASE_DIR/ggsn-tester cp GGSN_Tests.cfg $VOL_BASE_DIR/ggsn-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/ggsn-tester/GGSN_Tests.cfg" mkdir $VOL_BASE_DIR/ggsn diff --git a/ttcn3-hlr-test/jenkins.sh b/ttcn3-hlr-test/jenkins.sh index e003e03..8fb6c9d 100755 --- a/ttcn3-hlr-test/jenkins.sh +++ b/ttcn3-hlr-test/jenkins.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/hlr-tester cp HLR_Tests.cfg $VOL_BASE_DIR/hlr-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/hlr-tester/HLR_Tests.cfg" mkdir $VOL_BASE_DIR/hlr cp osmo-hlr.cfg $VOL_BASE_DIR/hlr/ diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh index 6ffa98a..49e3fbb 100755 --- a/ttcn3-hnodeb-test/jenkins.sh +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/hnodeb-tester cp HNB_Tests.cfg $VOL_BASE_DIR/hnodeb-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/hnodeb-tester/HNB_Tests.cfg" mkdir $VOL_BASE_DIR/hnodeb cp osmo-hnodeb.cfg $VOL_BASE_DIR/hnodeb/ diff --git a/ttcn3-mgw-test/jenkins.sh b/ttcn3-mgw-test/jenkins.sh index f9d0133..5d139e4 100755 --- a/ttcn3-mgw-test/jenkins.sh +++ b/ttcn3-mgw-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/mgw-tester cp MGCP_Test.cfg $VOL_BASE_DIR/mgw-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/mgw-tester/MGCP_Test.cfg" mkdir $VOL_BASE_DIR/mgw cp osmo-mgw.cfg $VOL_BASE_DIR/mgw/ diff --git a/ttcn3-msc-test/jenkins.sh b/ttcn3-msc-test/jenkins.sh index dd91e24..43aa138 100755 --- a/ttcn3-msc-test/jenkins.sh +++ b/ttcn3-msc-test/jenkins.sh @@ -16,6 +16,7 @@ mkdir $VOL_BASE_DIR/msc-tester mkdir $VOL_BASE_DIR/msc-tester/unix cp MSC_Tests.cfg $VOL_BASE_DIR/msc-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/msc-tester/MSC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-ns-test/jenkins-fr.sh b/ttcn3-ns-test/jenkins-fr.sh index df23a35..e6883cd 100755 --- a/ttcn3-ns-test/jenkins-fr.sh +++ b/ttcn3-ns-test/jenkins-fr.sh @@ -27,6 +27,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp fr/NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp fr/osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-ns-test/jenkins-sgsn-sns.sh b/ttcn3-ns-test/jenkins-sgsn-sns.sh index 4460380..4d31163 100755 --- a/ttcn3-ns-test/jenkins-sgsn-sns.sh +++ b/ttcn3-ns-test/jenkins-sgsn-sns.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp sgsn-sns/NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp sgsn-sns/osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-ns-test/jenkins-sns.sh b/ttcn3-ns-test/jenkins-sns.sh index 7fb899e..ce3682d 100755 --- a/ttcn3-ns-test/jenkins-sns.sh +++ b/ttcn3-ns-test/jenkins-sns.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp sns/NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp sns/osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-ns-test/jenkins.sh b/ttcn3-ns-test/jenkins.sh index aeb1ba9..b3d32bb 100755 --- a/ttcn3-ns-test/jenkins.sh +++ b/ttcn3-ns-test/jenkins.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-pcap-client-test/jenkins.sh b/ttcn3-pcap-client-test/jenkins.sh index 60d44e6..f75298a 100755 --- a/ttcn3-pcap-client-test/jenkins.sh +++ b/ttcn3-pcap-client-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/pcap-client-tester cp OPCAP_CLIENT_Tests.cfg $VOL_BASE_DIR/pcap-client-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/pcap-client-tester/OPCAP_CLIENT_Tests.cfg" mkdir $VOL_BASE_DIR/pcap-client cp osmo-pcap-client.cfg $VOL_BASE_DIR/pcap-client/ diff --git a/ttcn3-pcu-test/jenkins-sns.sh b/ttcn3-pcu-test/jenkins-sns.sh index aaed27a..8c935c0 100755 --- a/ttcn3-pcu-test/jenkins-sns.sh +++ b/ttcn3-pcu-test/jenkins-sns.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/pcu-tester mkdir $VOL_BASE_DIR/pcu-tester/unix cp sns/PCU_Tests.cfg $VOL_BASE_DIR/pcu-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" mkdir $VOL_BASE_DIR/pcu mkdir $VOL_BASE_DIR/pcu/unix diff --git a/ttcn3-pcu-test/jenkins.sh b/ttcn3-pcu-test/jenkins.sh index 11c77ad..a34c37c 100755 --- a/ttcn3-pcu-test/jenkins.sh +++ b/ttcn3-pcu-test/jenkins.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/pcu-tester mkdir $VOL_BASE_DIR/pcu-tester/unix cp PCU_Tests.cfg $VOL_BASE_DIR/pcu-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" mkdir $VOL_BASE_DIR/pcu mkdir $VOL_BASE_DIR/pcu/unix diff --git a/ttcn3-remsim-test/jenkins.sh b/ttcn3-remsim-test/jenkins.sh index ae013d6..48395ec 100755 --- a/ttcn3-remsim-test/jenkins.sh +++ b/ttcn3-remsim-test/jenkins.sh @@ -75,6 +75,7 @@ # 1) server test suite start_server cp REMSIM_Tests.cfg $VOL_BASE_DIR/remsim-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/remsim-tester/REMSIM_Tests.cfg" start_testsuite docker container kill ${BUILD_TAG}-server @@ -82,6 +83,7 @@ echo "Changing to bankd configuration" start_bankd cp bankd/REMSIM_Tests.cfg $VOL_BASE_DIR/remsim-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/remsim-tester/REMSIM_Tests.cfg" start_testsuite docker container kill ${BUILD_TAG}-bankd @@ -89,4 +91,5 @@ echo "Changing to client configuration" start_client cp client/REMSIM_Tests.cfg $VOL_BASE_DIR/remsim-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/remsim-tester/REMSIM_Tests.cfg" start_testsuite diff --git a/ttcn3-sccp-test/jenkins.sh b/ttcn3-sccp-test/jenkins.sh index 40ff1f1..66c18a4 100755 --- a/ttcn3-sccp-test/jenkins.sh +++ b/ttcn3-sccp-test/jenkins.sh @@ -12,6 +12,7 @@ mkdir $VOL_BASE_DIR/sccp-tester cp SCCP_Tests.cfg $VOL_BASE_DIR/sccp-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/scpp-tester/SCCP_Tests.cfg" mkdir $VOL_BASE_DIR/sccp cp sccp_demo_user.cfg $VOL_BASE_DIR/sccp/ diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh index df500af..fb421c2 100755 --- a/ttcn3-sgsn-test/jenkins.sh +++ b/ttcn3-sgsn-test/jenkins.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/sgsn-tester cp SGSN_Tests.cfg $VOL_BASE_DIR/sgsn-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/sgsn-tester/SGSN_Tests.cfg" mkdir $VOL_BASE_DIR/sgsn cp osmo-sgsn.cfg $VOL_BASE_DIR/sgsn/ diff --git a/ttcn3-sip-test/jenkins.sh b/ttcn3-sip-test/jenkins.sh index ffec3d2..1f4b5c6 100755 --- a/ttcn3-sip-test/jenkins.sh +++ b/ttcn3-sip-test/jenkins.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/sip-tester mkdir $VOL_BASE_DIR/sip-tester/unix cp SIP_Tests.cfg $VOL_BASE_DIR/sip-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/sip-tester/SIP_Tests.cfg" mkdir $VOL_BASE_DIR/sip mkdir $VOL_BASE_DIR/sip/unix diff --git a/ttcn3-smlc-test/jenkins.sh b/ttcn3-smlc-test/jenkins.sh index f16536f..4b91542 100755 --- a/ttcn3-smlc-test/jenkins.sh +++ b/ttcn3-smlc-test/jenkins.sh @@ -12,6 +12,7 @@ mkdir $VOL_BASE_DIR/smlc-tester cp SMLC_Tests.cfg $VOL_BASE_DIR/smlc-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/smlc-tester/SMLC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-stp-test/jenkins.sh b/ttcn3-stp-test/jenkins.sh index db2ffdd..04801af 100755 --- a/ttcn3-stp-test/jenkins.sh +++ b/ttcn3-stp-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/stp-tester cp STP_Tests.cfg $VOL_BASE_DIR/stp-tester/ +write_osmocom_stack_version "$VOL_BASE_DIR/stp-tester/STP_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 13:30:47 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 13:30:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_is_osmocom_* functions References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_is_osmocom_* functions ...................................................................... library/Misc_Helpers: add f_is_osmocom_* functions Create functions to check which version of the Osmocom stack is running. Put it in Misc_Helpers instead of a new library file since Misc_Helpers is already available in many/all? tests and it fits there too. Depends: docker-playground Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Related: OS#5327 Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 --- M library/Misc_Helpers.ttcn 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/26386/1 diff --git a/library/Misc_Helpers.ttcn b/library/Misc_Helpers.ttcn index a402525..94007be 100644 --- a/library/Misc_Helpers.ttcn +++ b/library/Misc_Helpers.ttcn @@ -1,5 +1,24 @@ module Misc_Helpers { +modulepar { + charstring mp_osmocom_stack_version := "nightly"; +} + +/* Functions for having different test code paths based on the version of the + * Osmocom stack (nightly, latest, 2021q4, ...). See OS#4878. */ + +function f_is_osmocom_nightly() return boolean { + return mp_osmocom_stack_version == "nightly"; +} + +function f_is_osmocom_latest() return boolean { + return mp_osmocom_stack_version == "latest"; +} + +function f_is_osmocom_2021q4() return boolean { + return mp_osmocom_stack_version == "2021q4"; +} + /* Try to properly shutdown a testcase. * The reliable method to stop a testcase without running into dynamic * testcase errors due to unconnected ports receiving messages is to call -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 13:30:48 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 13:30:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... BSC_Tests: TC_paging_counter: add bsc pag expired Test the new bsc.N.paging:expired stat in TC_paging_counter too. Depends: osmo-bsc I9c118e7e3d61ed8c9f1951111255b196905eba4d Related: SYS#4878 Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/26387/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index b34ad29..faf4e63 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3312,6 +3312,7 @@ var integer i; var integer paging_attempted_bsc; var integer paging_attempted_bts[NUM_BTS]; + var integer paging_expired_bsc; var integer paging_expired_bts[NUM_BTS]; cid_list := valueof(ts_BSSMAP_CIL_noCell); @@ -3319,6 +3320,9 @@ /* read counters before paging */ paging_attempted_bsc := f_ctrl_get_ratectr_abs(IPA_CTRL, "bsc", 0, "paging:attempted"); + if (Misc_Helpers.f_is_osmocom_nightly()) { + paging_expired_bsc := f_ctrl_get_ratectr_abs(IPA_CTRL, "bsc", 0, "paging:expired"); + } for (i := 0; i < NUM_BTS; i := i+1) { paging_attempted_bts[i] := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", i, "paging:attempted"); paging_expired_bts[i] := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", i, "paging:expired"); @@ -3335,6 +3339,9 @@ /* assume that 12s later the paging on all BTSs have expired and hence incremented by 1 */ f_sleep(12.0); + if (Misc_Helpers.f_is_osmocom_nightly()) { + f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bsc", 0, "paging:expired", paging_expired_bsc+1); + } for (i := 0; i < NUM_BTS; i := i+1) { f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bts", i, "paging:expired", paging_expired_bts[i]+1); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:20:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 14:20:36 +0000 Subject: Change in osmo-bsc[master]: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26383 ) Change subject: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc4947e68fa46aab180f2047231e51b997cca71b Gerrit-Change-Number: 26383 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:20:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:24:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 14:24:00 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26384/1/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26384/1/src/osmo-bsc/osmo_bsc_bssap.c at 338 PS1, Line 338: static void bsc_paging_T3113_expired(void *data) I'm a bit lost here. How did paging requests expire before? There must be an existing code path already. Furthermore, I see no paging request being dropped here, this is only used to increase the counter. Why are not both things done in the same place? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:24:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:25:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 14:25:26 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom stack version to configs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom stack version to configs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:25:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:26:05 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 14:26:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_is_osmocom_* functions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_is_osmocom_* functions ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/1/library/Misc_Helpers.ttcn File library/Misc_Helpers.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/1/library/Misc_Helpers.ttcn at 11 PS1, Line 11: return mp_osmocom_stack_version == "nightly"; what about having constants defining these charstrings? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:26:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:26:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 14:26:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:26:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:27:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 14:27:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... Patch Set 1: -Code-Review (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387/1/bsc/BSC_Tests.ttcn at 3342 PS1, Line 3342: if (Misc_Helpers.f_is_osmocom_nightly()) { Please still write a comment explaining when this line can be dropped (eg. osmo-bsc>X.Y.Z). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:32:42 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 26 Nov 2021 14:32:42 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_is_osmocom_* functions In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_is_osmocom_* functions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/1/library/Misc_Helpers.ttcn File library/Misc_Helpers.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/1/library/Misc_Helpers.ttcn at 11 PS1, Line 11: return mp_osmocom_stack_version == "nightly"; > what about having constants defining these charstrings? This probably makes it more confusing. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:32:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 14:34:31 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 26 Nov 2021 14:34:31 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom stack version to configs In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom stack version to configs ...................................................................... Patch Set 1: Code-Review+1 be sure to test this with docker before merging, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 14:34:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 15:13:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Nov 2021 15:13:12 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_is_osmocom_* functions In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_is_osmocom_* functions ...................................................................... Patch Set 1: Code-Review-1 I don't like such kind of functions doing simple things like: return foo == "bar"; Probably you win shorter line length: if (Misc_Helpers.mp_osmocom_stack_version == "nightly") { ... } vs if (f_is_osmocom_nightly()) { ... } but still I would go for something more generic, like having an enumerated type: type enumerated OsmoSUTVer { OSMO_SUT_VER_NIGHTLY, OSMO_SUT_VER_LATEST, OSMO_SUT_VER_2021Q4 }; and then a single function: function f_osmo_sut_ver_is(template OsmoSUTVer ver) return boolean { return match(mp_osmocom_stack_version, ver); } This approach is cleaner IMO, and allows to match several variants at a time: if (f_osmo_sut_ver_is((OSMO_SUT_VER_LATEST, OSMO_SUT_VER_2021Q4))) { ... } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 15:13:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 15:21:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 15:21:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_is_osmocom_* functions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_is_osmocom_* functions ...................................................................... Patch Set 1: Ack, but the same with charstring constants instead of enums, so that in docker-playground.git we can still set them to "nightly", "latest", etc. which is what we are used to use there. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 15:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 15:34:53 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 15:34:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Handle FLUSH_LL_ACK differently In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 ) Change subject: BSSGP_Emulation: Handle FLUSH_LL_ACK differently ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1df35da44ef28d91501bb898e1059bf1390129b Gerrit-Change-Number: 26382 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 15:34:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 15:45:43 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 15:45:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, pespin, lynxis lazus, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 to look at the new patch set (#4). Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... gbproxy: Add flush_ll test without new bvci Depends: Ic33d08992ea84af006d133db6aec508a7b7c7f28 (osmo-ttcn3-hacks) Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Related: OS#5332 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 39 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/26372/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 15:45:45 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 15:45:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Update expected-results.xml References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 ) Change subject: Update expected-results.xml ...................................................................... Update expected-results.xml Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 --- M gbproxy/expected-results.xml A gbproxy/osmo-gbproxy.cfg-client A gbproxy/osmo-gbproxy.cfg-server 3 files changed, 117 insertions(+), 37 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/88/26388/1 diff --git a/gbproxy/expected-results.xml b/gbproxy/expected-results.xml index e2e4918..6221f10 100644 --- a/gbproxy/expected-results.xml +++ b/gbproxy/expected-results.xml @@ -20,6 +20,7 @@ + @@ -63,44 +64,16 @@ - + + - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN[0] side: { pDU_BSSGP_MS_REGISTRATION_ENQUIRY := { bssgpPduType := '14'O, iMSI := { iEI := '0D'O (\"\\r\"), ext := '1'B, lengthIndicator := ?, type_of_Identity := '001'B, oddevenIndicator := ?, digits := '262420000000000'H }, mME_Query := * } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_ms_reg_enq testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '2A1F84C218002304820926'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_sig_ul_tlli testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '070D8809101010325476980A82000004824E2B208442180023'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_sig_ul_tmsi testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '00C21800230050001682FFFF0E822342'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_ptp_ul_tlli testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '070D8809101010325476980A82000004824E2B208442180023'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_ptp_ul_tmsi testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on PCU side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '2C1F84123456780F811004824E2B2583000017'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_sig_dl_bvci testcase - - + + + + + + + diff --git a/gbproxy/osmo-gbproxy.cfg-client b/gbproxy/osmo-gbproxy.cfg-client new file mode 100644 index 0000000..51df36c --- /dev/null +++ b/gbproxy/osmo-gbproxy.cfg-client @@ -0,0 +1,52 @@ +! +! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty +!! +! +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging print category-hex 0 + logging timestamp 1 + logging print file 1 + logging level lns debug + logging level lbssgp debug + logging level gprs debug + logging level igpp debug +line vty + no login +! +gbproxy + nri bitlen 5 + igpp role secondary + igpp replicate nsei 1 + igpp replicate nsei 2 + igpp replicate nsei 3 + igpp replicate nsei 4 +sgsn nsei 101 + name first + nri add 3 +sgsn nsei 102 + name second + nri add 4 +ns + bind udp sgsn-side + listen 127.0.0.1 23000 + accept-ipaccess + nse 101 + ip-sns-bind sgsn-side + ip-sns-remote 127.0.0.10 7777 + nse 102 + ip-sns-bind sgsn-side + ip-sns-remote 127.0.0.11 8888 + bind udp bss-side + listen 127.0.0.2 23000 + accept-dynamic-ip-sns + ip-sns-default bind bss-side + timer tns-block 3 + timer tns-block-retries 3 + timer tns-reset 3 + timer tns-reset-retries 3 + timer tns-test 30 + timer tns-alive 3 + timer tns-alive-retries 10 diff --git a/gbproxy/osmo-gbproxy.cfg-server b/gbproxy/osmo-gbproxy.cfg-server new file mode 100644 index 0000000..f35e834 --- /dev/null +++ b/gbproxy/osmo-gbproxy.cfg-server @@ -0,0 +1,55 @@ +! +! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty +!! +! +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging print category-hex 0 + logging timestamp 1 + logging print file 1 + logging level lns debug + logging level lbssgp debug + logging level gprs debug + logging level igpp debug +line vty + no login + bind 127.0.0.11 +ctrl + bind 127.0.0.11 +! +gbproxy + nri bitlen 5 + igpp role primary + igpp replicate nsei 1 + igpp replicate nsei 2 + igpp replicate nsei 3 + igpp replicate nsei 4 +sgsn nsei 101 + name first + nri add 3 +sgsn nsei 102 + name second + nri add 4 +ns + bind udp sgsn-side + listen 127.0.0.11 23000 + accept-ipaccess + nse 101 + ip-sns-bind sgsn-side + ip-sns-remote 127.0.0.10 7777 + nse 102 + ip-sns-bind sgsn-side + ip-sns-remote 127.0.0.11 8888 + bind udp bss-side + listen 127.0.0.12 23000 + accept-dynamic-ip-sns + ip-sns-default bind bss-side + timer tns-block 3 + timer tns-block-retries 3 + timer tns-reset 3 + timer tns-reset-retries 3 + timer tns-test 30 + timer tns-alive 3 + timer tns-alive-retries 10 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 15:51:00 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Nov 2021 15:51:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Handle FLUSH_LL_ACK differently In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 ) Change subject: BSSGP_Emulation: Handle FLUSH_LL_ACK differently ...................................................................... BSSGP_Emulation: Handle FLUSH_LL_ACK differently The BVCI that this message might contain should not be used to route it. It referes to the BVCI that the PDUs were transferred to (BVCI (new)). Instead broadcast to all components. Change-Id: Ia1df35da44ef28d91501bb898e1059bf1390129b --- M library/BSSGP_Emulation.ttcnpp 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp index 8d27fd1..23c8d03 100644 --- a/library/BSSGP_Emulation.ttcnpp +++ b/library/BSSGP_Emulation.ttcnpp @@ -333,6 +333,16 @@ } } + /* Broadcast FLUSH_LL_ACK no matter the BVCI */ + [] BSCP.receive(f_BnsUdInd(tr_BSSGP_FLUSH_LL_ACK(?, ?, ?), 0)) -> value udi { + log("Rx FLUSH_LL_ACK: broadcasting"); + for (var integer i := 0; i < lengthof(BvcTable); i := i+1) { + if (isbound(BvcTable[i].comp_ref) and BvcTable[i].comp_ref != null) { + BVC.send(udi) to BvcTable[i].comp_ref; + } + } + } + /* Route based on PTP BVCI in payload/IE of signaling PDU */ [] BSCP.receive(f_BnsUdInd(?, 0)) -> value udi { var template (omit) BssgpBvci ptp_bvci := f_BSSGP_BVCI_get(udi.bssgp); @@ -1163,6 +1173,19 @@ } } + [] BVC.receive(tr_ptp_BnsUdInd(tr_BSSGP_FLUSH_LL_ACK(?, ?, ?), 0)) -> value udi { + var BssgpDecoded dec := f_dec_bssgp(udi.bssgp); + + log("Broadcasting FLUSH_LL_ACK ", dec); + /* broadcast this message to all components */ + // TITAN DOESN'T DO THIS, *SIGH*: "BSSGP_SP.send(dec) to all component;" + for (var integer i := 0; i < sizeof(ClientTable); i := i+1) { + if (isbound(ClientTable[i].comp_ref) and ClientTable[i].comp_ref != null) { + f_send_bssgp_dec(dec, ClientTable[i].comp_ref, BSSGP_SP_SIG); + } + } + } + /* Any other SIG BSSGP message: If it has TLLI, route to component; otherwise broadcast */ [] BVC.receive(tr_ptp_BnsUdInd(?, 0)) -> value udi { var BssgpDecoded dec := f_dec_bssgp(udi.bssgp); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1df35da44ef28d91501bb898e1059bf1390129b Gerrit-Change-Number: 26382 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 16:00:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 16:00:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Update expected-results.xml In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 ) Change subject: Update expected-results.xml ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 16:00:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 16:05:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 16:05:07 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26384/1/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26384/1/src/osmo-bsc/osmo_bsc_bssap.c at 338 PS1, Line 338: static void bsc_paging_T3113_expired(void *data) > I'm a bit lost here. [?] Yes, there is an existing code path to expire the paging per BTS, but not per BSC. Expiring per BTS also has its own counter. However, the per-BTS counter is not suitable for attTransOfPagingMessagesPerBSC (3GPP TS 52.402 ? C.3.2.4). When paging one subscriber with 1 BSC that has 3 BTS attached, and the paging fails for all 3 BTS, we need this new per BSC counter to know that 1 paging failed (and not 3, as one would get by summarizing the per-BTS counters). The TTCN-3 test has both the BTS and BSC paging:expired counters, might help to illustrate this too: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 16:05:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 16:24:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 16:24:44 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 1: Then why not having some sort of per-paging-req counter which is incremented for each BTS where it is scheduled, and decreased when it expires? Then if all fail and reaches 0, the expired counter is incremented. If one succeeds, the refcound is dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 16:24:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:13:50 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:13:50 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom repository to configs In-Reply-To: References: Message-ID: Hello pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26385 to look at the new patch set (#2). Change subject: ttcn3: write Osmocom repository to configs ...................................................................... ttcn3: write Osmocom repository to configs Write a line like 'Misc_Helpers.mp_osmo_repo := "nightly"' into the TTCN-3 config file (e.g. BSC_Tests.cfg), before starting the testsuite. This allows executing different code paths in the tests based on the repository. Related: OS#5327 Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 --- M jenkins-common.sh M ttcn3-bsc-test-vamos/jenkins.sh M ttcn3-bsc-test/jenkins-sccplite.sh M ttcn3-bsc-test/jenkins.sh M ttcn3-bscnat-test/jenkins.sh M ttcn3-bts-test/jenkins.sh M ttcn3-cbc-test/jenkins.sh M ttcn3-fr-test/jenkins.sh M ttcn3-gbproxy-test-fr/jenkins.sh M ttcn3-gbproxy-test/jenkins.sh M ttcn3-ggsn-test/jenkins.sh M ttcn3-hlr-test/jenkins.sh M ttcn3-hnodeb-test/jenkins.sh M ttcn3-mgw-test/jenkins.sh M ttcn3-msc-test/jenkins.sh M ttcn3-ns-test/jenkins-fr.sh M ttcn3-ns-test/jenkins-sgsn-sns.sh M ttcn3-ns-test/jenkins-sns.sh M ttcn3-ns-test/jenkins.sh M ttcn3-pcap-client-test/jenkins.sh M ttcn3-pcu-test/jenkins-sns.sh M ttcn3-pcu-test/jenkins.sh M ttcn3-remsim-test/jenkins.sh M ttcn3-sccp-test/jenkins.sh M ttcn3-sgsn-test/jenkins.sh M ttcn3-sip-test/jenkins.sh M ttcn3-smlc-test/jenkins.sh M ttcn3-stp-test/jenkins.sh 28 files changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/85/26385/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:13:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:13:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo() In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 to look at the new patch set (#2). Change subject: library/Misc_Helpers: add f_osmo_repo() ...................................................................... library/Misc_Helpers: add f_osmo_repo() Create functions to check which from Osmocom repository the SUT is running. Put it in Misc_Helpers instead of a new library file since Misc_Helpers is already available in many/all? tests and it fits there too. Depends: docker-playground Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Related: OS#5327 Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 --- M library/Misc_Helpers.ttcn 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/26386/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:13:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:13:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 to look at the new patch set (#2). Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... BSC_Tests: TC_paging_counter: add bsc pag expired Test the new bsc.N.paging:expired stat in TC_paging_counter too. Depends: osmo-bsc I9c118e7e3d61ed8c9f1951111255b196905eba4d Related: SYS#4878 Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/26387/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:16:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:16:10 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo() In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 to look at the new patch set (#3). Change subject: library/Misc_Helpers: add f_osmo_repo() ...................................................................... library/Misc_Helpers: add f_osmo_repo() Create functions to check which from Osmocom repository the SUT is running. Put it in Misc_Helpers instead of a new library file since Misc_Helpers is already available in many/all? tests and it fits there too. Depends: docker-playground Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Related: OS#5327 Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 --- M library/Misc_Helpers.ttcn 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/26386/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:16:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:16:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387/1/bsc/BSC_Tests.ttcn at 3342 PS1, Line 3342: if (Misc_Helpers.f_is_osmocom_nightly()) { > Please still write a comment explaining when this line can be dropped (eg. osmo-bsc>X.Y.Z). Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 17:16:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:19:09 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:19:09 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_osmo_repo() ...................................................................... Patch Set 3: Thanks for the reviews, updated with a combination of Vadim's and Pau's suggestions. Also renamed the function and variable to f_osmo_repo() so it's short. Renamed it in the docker-playground patch accordingly. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 17:19:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:20:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:20:39 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom repository to configs In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom repository to configs ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+1 > > be sure to test this with docker before merging, I've verified it works as intended with ttcn3-bsc-test. Probably a good idea to wait with merging until Monday, so in case there should be fallout I can fix it. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 17:20:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:45:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:45:54 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 1: > Patch Set 1: > > Then why not having some sort of per-paging-req counter which is incremented for each BTS where it is scheduled, and decreased when it expires? > Then if all fail and reaches 0, the expired counter is incremented. If one succeeds, the refcound is dropped. So in other words (to make sure I understood you correctly): * instead of bsc_T3113, add a counter of active pagings to struct bsc_subscr * decrease by 1 if one BTS paging fails * if it is going from 1 to 0 because a BTS failed, also increase bsc.paging:expired * if paging is successful for any BTS, set it to 0, don't increase bsc.paging:expired Should work as well. What's the advantage over the approach in the current patch? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 17:45:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:52:24 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:52:24 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372/4/gbproxy/GBProxy_Tests.ttcn File gbproxy/GBProxy_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372/4/gbproxy/GBProxy_Tests.ttcn at 3677 PS4, Line 3677: if (Misc_Helpers.f_is_osmocom_nightly()) { That got adopted quickly :D With the current version of the patch, it would be: if (Misc_Helpers.f_osmo_repo("nightly")) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 17:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 17:54:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Nov 2021 17:54:14 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Update expected-results.xml In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 ) Change subject: Update expected-results.xml ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388/1/gbproxy/osmo-gbproxy.cfg-client File gbproxy/osmo-gbproxy.cfg-client: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388/1/gbproxy/osmo-gbproxy.cfg-client at 1 PS1, Line 1: ! configs added on purpose? if so, I'd put them in a separate commit or at least mention it in the commit message -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Fri, 26 Nov 2021 17:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 23:02:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 23:02:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 23:02:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 23:07:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 23:07:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_osmo_repo() ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/3/library/Misc_Helpers.ttcn File library/Misc_Helpers.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/3/library/Misc_Helpers.ttcn at 16 PS3, Line 16: function f_osmo_repo(template charstring ver) return boolean { f_osmo_repo_is() f_osmo_repo() looks like returning the value instead. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 23:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 23:11:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Nov 2021 23:11:04 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > Then why not having some sort of per-paging-req counter which is incremented for each BTS where it is scheduled, and decreased when it expires? > > Then if all fail and reaches 0, the expired counter is incremented. If one succeeds, the refcound is dropped. > > So in other words (to make sure I understood you correctly): > * instead of bsc_T3113, add a counter of active pagings to struct bsc_subscr > * decrease by 1 if one BTS paging fails > * if it is going from 1 to 0 because a BTS failed, also increase bsc.paging:expired > * if paging is successful for any BTS, set it to 0, don't increase bsc.paging:expired > ACK > Should work as well. What's the advantage over the approach in the current patch? Not having an extra timer made up of several timers for each paging in process. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 26 Nov 2021 23:11:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Nov 26 23:34:10 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Fri, 26 Nov 2021 23:34:10 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc: disable encryption for iu/utran tests References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 ) Change subject: msc: disable encryption for iu/utran tests ...................................................................... msc: disable encryption for iu/utran tests Add seperate UEA1/2 tests later. Change-Id: Id98038e1d92942b55480a60821088d4a445b7b28 --- M msc/osmo-msc.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/26389/1 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 61b146e..f3006c4 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -62,6 +62,7 @@ short name OsmoMSC long name OsmoMSC encryption a5 0 + encryption uea 0 authentication optional rrlp mode none mm info 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id98038e1d92942b55480a60821088d4a445b7b28 Gerrit-Change-Number: 26389 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 01:51:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Nov 2021 01:51:38 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: Hello Jenkins Builder, neels, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 to look at the new patch set (#2). Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS Below is an example output: """ Received SIGNAL S_NM_GET_ATTR_REP { "primary_oml_ip": "192.168.100.100", "primary_oml_port": "0", "unit_id": "6969/0/0", "nv_flags": { "static-ip": "no", "static-gw": "no", "no-dhcp-vsi": "no", "dhcp-enabled": "yes", "led-enabled": "yes", "secondary-oml-enabled": "yes", "diag-enabled": "yes", "cli-enabled": "yes", "http-enabled": "no", "post-enabled": "yes", "snmp-enabled": "yes" } } """ Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 --- M src/ipaccess/ipaccess-config.c 1 file changed, 30 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/26150/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 01:51:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Nov 2021 01:51:50 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Reviewer: roox Gerrit-Comment-Date: Sat, 27 Nov 2021 01:51:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 03:32:50 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 03:32:50 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require ciphering into an own function In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 to look at the new patch set (#4). Change subject: libmsc/gsm_04_08: refactor require ciphering into an own function ...................................................................... libmsc/gsm_04_08: refactor require ciphering into an own function Make it more readable. Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 4 files changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/08/26108/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 03:32:51 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 03:32:51 +0000 Subject: Change in osmo-msc[master]: msc: always require ciphering for UTRAN References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26390 ) Change subject: msc: always require ciphering for UTRAN ...................................................................... msc: always require ciphering for UTRAN OsmoMSC treats UTRAN SecurityCommand as ciphering and UTRAN requires the SecurityCommand even when not requiring any encryption. Fixes: 505a94a610fc ("Make UTRAN encryption algorithms configurable") Change-Id: I8896ecc2f23c8fdb2b3e83b3aeabd55a0911a612 --- M src/libmsc/msc_a.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/26390/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index cb7566a..424248a 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -109,8 +109,10 @@ bool msc_a_require_ciphering(const struct msc_a *msc_a) { struct gsm_network *net = msc_a_net(msc_a); bool is_utran = (msc_a->c.ran->type == OSMO_RAT_UTRAN_IU); + /* UTRAN requires a SecurityCommand which OsmoMSC treats as Ciphering. + * Depending on the uea_encryption_mask there might be no encryption. */ if (is_utran) - return net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0); + return true; else return net->a5_encryption_mask > 0x1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8896ecc2f23c8fdb2b3e83b3aeabd55a0911a612 Gerrit-Change-Number: 26390 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 03:32:51 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 03:32:51 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() Since ranap_new_msg_sec_mod_cmd2() doesn't support UEA0 we must not pass it to it. The reason behind is that UEA0 can't passed in the TLV of a SecurityCommand and is implicit UEA0 if the TLV is not present. Fixes: 505a94a610fc ("Make UTRAN encryption algorithms configurable") Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e --- M src/libmsc/ran_msg_iu.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/26391/1 diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 8ffdd93..9a37e5c 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -382,7 +382,7 @@ /* TODO: Do we need to check if the UE supports all of the algorithms and build an intersection like * in the case of A5? */ return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? cm->vec->ck : NULL, - RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask); + RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask & ~(1 << OSMO_UTRAN_UEA0)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 03:39:49 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 03:39:49 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require ciphering into an own function In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 to look at the new patch set (#5). Change subject: libmsc/gsm_04_08: refactor require ciphering into an own function ...................................................................... libmsc/gsm_04_08: refactor require ciphering into an own function Make it more readable. Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 4 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/08/26108/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 04:41:21 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 04:41:21 +0000 Subject: Change in osmo-msc[master]: NOT_FOR_MASTER: test commit References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26392 ) Change subject: NOT_FOR_MASTER: test commit ...................................................................... NOT_FOR_MASTER: test commit Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d --- M src/libmsc/msc_a.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/26392/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 583f9e7..acbd38c 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1798,6 +1798,10 @@ osmo_fsm_inst_dispatch(msc_a->c.fi, MSC_A_EV_CN_CLOSE, NULL); } +void msc_a_release_mo(struct msc_a *msc_a, enum gsm48_gsm_cause gsm_cause) { + ;; +} + void msc_a_release_mo(struct msc_a *msc_a, enum gsm48_gsm_cause gsm_cause) { osmo_fsm_inst_dispatch(msc_a->c.fi, MSC_A_EV_MO_CLOSE, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d Gerrit-Change-Number: 26392 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 04:47:48 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 04:47:48 +0000 Subject: Change in osmo-msc[master]: NOT_FOR_MASTER: test commit In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 to look at the new patch set (#2). Change subject: NOT_FOR_MASTER: test commit ...................................................................... NOT_FOR_MASTER: test commit Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d --- M src/libmsc/msc_a.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/26392/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d Gerrit-Change-Number: 26392 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 04:49:02 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 04:49:02 +0000 Subject: Change in osmo-msc[master]: NOT_FOR_MASTER: test commit In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 to look at the new patch set (#3). Change subject: NOT_FOR_MASTER: test commit ...................................................................... NOT_FOR_MASTER: test commit Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d --- M src/libmsc/msc_a.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/26392/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d Gerrit-Change-Number: 26392 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 04:51:11 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 04:51:11 +0000 Subject: Change in osmo-msc[master]: NOT_FOR_MASTER: test commit In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 to look at the new patch set (#4). Change subject: NOT_FOR_MASTER: test commit ...................................................................... NOT_FOR_MASTER: test commit Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d --- M src/libmsc/msc_a.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/26392/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d Gerrit-Change-Number: 26392 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 05:01:57 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 05:01:57 +0000 Subject: Change in osmo-msc[master]: NOT_FOR_MASTER: test commit In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26392 ) Change subject: NOT_FOR_MASTER: test commit ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/26392/4/src/libmsc/msc_a.c File src/libmsc/msc_a.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-msc-lint-70): https://gerrit.osmocom.org/c/osmo-msc/+/26392/4/src/libmsc/msc_a.c at 1801 PS4, Line 1801: void msc_a_release_mo(struct msc_a *msc_a, enum gsm48_gsm_cause gsm_cause) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-msc-lint-70): https://gerrit.osmocom.org/c/osmo-msc/+/26392/4/src/libmsc/msc_a.c at 1802 PS4, Line 1802: ;; Statements terminations use 1 semicolon -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d Gerrit-Change-Number: 26392 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 27 Nov 2021 05:01:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 05:06:04 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 05:06:04 +0000 Subject: Change in osmo-ci[master]: RFC: lint: annotate lines in gerrit References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: RFC: lint: annotate lines in gerrit ...................................................................... RFC: lint: annotate lines in gerrit Use robot comments to add line based comments for the lint output. Add checkpatch_json from coreboot to parse the checkpatch output and convert it into a gerrit parsable format. The jenkins nodes needs to access the gerrit via ssh. It might be more secure to put this into a second job. Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 --- A lint/checkpatch/checkpatch_json.py M lint/lint_diff.sh 2 files changed, 66 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/93/26393/1 diff --git a/lint/checkpatch/checkpatch_json.py b/lint/checkpatch/checkpatch_json.py new file mode 100755 index 0000000..c693809 --- /dev/null +++ b/lint/checkpatch/checkpatch_json.py @@ -0,0 +1,61 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0-only +# from coreboot rev 9cae17d028d4bd3b278fc89ada8e06287917e213 + +""" +This utilty generate json output to post comment in gerrit. + +INPUT: output of checkpatch.pl. +OUTPUT: json format output that can be used to post comment in gerrit +""" +import os +import sys +import json + +data = {} +data['comments'] = [] +list_temp = {} + +def update_struct( file_path, msg_output, line_number): + if file_path not in list_temp: + list_temp[file_path] = [] + list_temp[file_path].append({ + "robot_id" : "checkpatch", + "robot_run_id" : sys.argv[3], + "url" : sys.argv[4], + "line" : line_number, + "message" : msg_output,} + ) + +def parse_file(input_file): + fp = open (input_file, "r") + for line in fp: + if line.startswith("ERROR:"): + msg_output = line.split("ERROR:")[1].strip() + elif line.startswith("WARNING:"): + msg_output = line.split("WARNING:")[1].strip() + elif ": FILE:" in line: + temp = line.split("FILE:") + file_path = temp[1].split(":")[0] + line_number = temp[1].split(":")[1] + update_struct( file_path.strip(), msg_output, str(line_number) ) + else: + continue + fp.close() + +def main(): + if (len(sys.argv) < 5) or (sys.argv[1] == "-h"): + print("HELP:") + print(sys.argv[0] + " ") + sys.exit() + + print(sys.argv[1]) + parse_file(sys.argv[1]) + data['robot_comments'] = list_temp + print(json.dumps(data)) + out_file = open( sys.argv[2] , "w") + json.dump(data, out_file, sort_keys=True, indent=4) + out_file.close() + +if __name__ == "__main__": + main() diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index f8daab7..3532454 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -31,6 +31,11 @@ exit 0 fi +if ! git diff -U0 "$COMMIT" | "$SCRIPT_DIR/checkpatch/checkpatch_osmo.sh" > gerrit_report ; then + "$SCRIPT_DIR/checkpatch/checkpatch_json.py" gerrit_report gerrit_report.json "$BUILD_TAG" "$BUILD_URL" + ssh -p "$GERRIT_PORT" -l jenkins "$GERRIT_HOST" gerrit review "$GERRIT_PATCHSET_REVISION" --json < gerrit_report.json +fi + echo echo "Please fix the linting errors above. More information:" echo "https://osmocom.org/projects/cellular-infrastructure/wiki/Linting" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 05:06:50 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 05:06:50 +0000 Subject: Change in osmo-ci[master]: RFC: lint: annotate lines in gerrit In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: RFC: lint: annotate lines in gerrit ...................................................................... Patch Set 1: See https://gerrit.osmocom.org/c/osmo-msc/+/26392/4/src/libmsc/msc_a.c how it would look like. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Sat, 27 Nov 2021 05:06:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 05:07:08 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 05:07:08 +0000 Subject: Change in osmo-msc[master]: NOT_FOR_MASTER: test commit In-Reply-To: References: Message-ID: lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26392 ) Change subject: NOT_FOR_MASTER: test commit ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaacb12ff7f538cdd8b4145e41d53d0836990ad5d Gerrit-Change-Number: 26392 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:42:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sat, 27 Nov 2021 07:42:28 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc: disable encryption for iu/utran tests In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 ) Change subject: msc: disable encryption for iu/utran tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id98038e1d92942b55480a60821088d4a445b7b28 Gerrit-Change-Number: 26389 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 27 Nov 2021 07:42:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:44:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 07:44:30 +0000 Subject: Change in osmo-ci[master]: RFC: lint: annotate lines in gerrit In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: RFC: lint: annotate lines in gerrit ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ci/+/26393/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/26393/1//COMMIT_MSG at 13 PS1, Line 13: The jenkins nodes needs to access the gerrit via ssh I would expect one can createa gerrit user that has permission only to provide review and thereby limit the potential damage. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Sat, 27 Nov 2021 07:44:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:44:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 07:44:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc: disable encryption for iu/utran tests In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 ) Change subject: msc: disable encryption for iu/utran tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id98038e1d92942b55480a60821088d4a445b7b28 Gerrit-Change-Number: 26389 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 27 Nov 2021 07:44:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:44:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 07:44:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc: disable encryption for iu/utran tests In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 ) Change subject: msc: disable encryption for iu/utran tests ...................................................................... msc: disable encryption for iu/utran tests Add seperate UEA1/2 tests later. Change-Id: Id98038e1d92942b55480a60821088d4a445b7b28 --- M msc/osmo-msc.cfg 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 61b146e..f3006c4 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -62,6 +62,7 @@ short name OsmoMSC long name OsmoMSC encryption a5 0 + encryption uea 0 authentication optional rrlp mode none mm info 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id98038e1d92942b55480a60821088d4a445b7b28 Gerrit-Change-Number: 26389 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:45:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 07:45:24 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require ciphering into an own function In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require ciphering into an own function ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Sat, 27 Nov 2021 07:45:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:45:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 07:45:31 +0000 Subject: Change in osmo-msc[master]: libmsc/gsm_04_08: refactor require ciphering into an own function In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26108 ) Change subject: libmsc/gsm_04_08: refactor require ciphering into an own function ...................................................................... libmsc/gsm_04_08: refactor require ciphering into an own function Make it more readable. Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 4 files changed, 16 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 2a64c53..34d42db 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -13,6 +13,7 @@ #include #include #include +#include #include diff --git a/include/osmocom/msc/msc_a.h b/include/osmocom/msc/msc_a.h index 18973f9..f94420a 100644 --- a/include/osmocom/msc/msc_a.h +++ b/include/osmocom/msc/msc_a.h @@ -180,6 +180,7 @@ void msc_a_pending_cm_service_req_add(struct msc_a *msc_a, enum osmo_cm_service_type type); unsigned int msc_a_pending_cm_service_req_count(struct msc_a *msc_a, enum osmo_cm_service_type type); void msc_a_pending_cm_service_req_del(struct msc_a *msc_a, enum osmo_cm_service_type type); +bool msc_a_require_ciphering(const struct msc_a *msc_a); #define msc_a_ran_down(A,B,C) \ _msc_a_ran_down(A,B,C, __FILE__, __LINE__) diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 075ef0f..b5d46fd 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -415,7 +415,7 @@ net->vlr, msc_a, vlr_lu_type, tmsi, imsi, &old_lai, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + msc_a_require_ciphering(msc_a), lu->key_seq, osmo_gsm48_classmark1_is_r99(&lu->classmark1), is_utran, @@ -806,7 +806,7 @@ req->cm_service_type, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + msc_a_require_ciphering(msc_a), req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -932,7 +932,7 @@ VLR_PR_ARQ_T_CM_RE_ESTABLISH_REQ, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + msc_a_require_ciphering(msc_a), req->cipher_key_seq, osmo_gsm48_classmark2_is_r99(cm2, cm2_len), is_utran); @@ -1294,7 +1294,7 @@ net->vlr, msc_a, VLR_PR_ARQ_T_PAGING_RESP, 0, &mi, &msc_a->via_cell.lai, is_utran || net->authentication_required, - is_utran ? net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) : net->a5_encryption_mask > 0x01, + msc_a_require_ciphering(msc_a), pr->key_seq, osmo_gsm48_classmark2_is_r99(cm2, classmark2_len), is_utran); diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 583f9e7..74721d2 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -106,6 +106,16 @@ return fi->priv; } +bool msc_a_require_ciphering(const struct msc_a *msc_a) +{ + struct gsm_network *net = msc_a_net(msc_a); + bool is_utran = (msc_a->c.ran->type == OSMO_RAT_UTRAN_IU); + if (is_utran) + return net->uea_encryption_mask > (1 << OSMO_UTRAN_UEA0); + else + return net->a5_encryption_mask > 0x1; +} + static void update_counters(struct osmo_fsm_inst *fi, bool conn_accepted) { struct msc_a *msc_a = fi->priv; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e407f65b282e645feabe714f7f4c3e44fae21e9 Gerrit-Change-Number: 26108 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:46:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sat, 27 Nov 2021 07:46:11 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 27 Nov 2021 07:46:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:46:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 07:46:40 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 2: Code-Review+1 AFAIR pespin had some concerns about osmo-gsm-tester relying on existing output, please do a grep in the osmo-gsm-tester repo to find out and make sure it is updated, too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Reviewer: roox Gerrit-Comment-Date: Sat, 27 Nov 2021 07:46:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:46:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 07:46:54 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 2: Code-Review+1 AFAIR pespin had some concerns about osmo-gsm-tester relying on existing output, please do a grep in the osmo-gsm-tester repo to find out and make sure it is updated, too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 27 Nov 2021 07:46:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 07:49:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sat, 27 Nov 2021 07:49:12 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Reviewer: roox Gerrit-Comment-Date: Sat, 27 Nov 2021 07:49:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 09:42:58 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sat, 27 Nov 2021 09:42:58 +0000 Subject: Change in osmo-ci[master]: RFC: lint: annotate lines in gerrit In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: RFC: lint: annotate lines in gerrit ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ci/+/26393/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/26393/1//COMMIT_MSG at 13 PS1, Line 13: The jenkins nodes needs to access the gerrit via ssh > I would expect one can createa gerrit user that has permission only to provide review and thereby li [?] the gerrit-lint isn't a problem to give ssh access since it will only execute reviewed code from osmo-ci. So we could just add ssh-key to jenkins and enable ssh-agent in jenkins. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Sat, 27 Nov 2021 09:42:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 11:55:16 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 11:55:16 +0000 Subject: Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 ) Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... logging: make LIBOSMOCORE_NO_LOGGING work as expected The macro introduced in d02090bba538158c36fd838d4e50c47e40f11449 was not enough: the actual logging macros are being used, i.e. by the fsm, so wrap those as well, and provide a flag to disable this at build time. Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 --- M configure.ac M include/osmocom/core/logging.h 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/26394/1 diff --git a/configure.ac b/configure.ac index b36bd6f..a69f793 100644 --- a/configure.ac +++ b/configure.ac @@ -366,6 +366,17 @@ AC_DEFINE([PANIC_INFLOOP],[1],[Use infinite loop on panic rather than fprintf/abort]) fi +AC_ARG_ENABLE(log_macros, + [AS_HELP_STRING( + [--disable-log-macros], + [Disable logging macros that are also used internally to print information] + )], + [log_macros="yes"], [log_macros="no"]) +if test x"$log_macros" == x"yes" +then + AC_DEFINE([LIBOSMOCORE_NO_LOGGING],[1],[Disable logging macros]) +fi + AC_ARG_ENABLE(sanitize, [AS_HELP_STRING( [--enable-sanitize], diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index a95c478..44ff77b 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -53,11 +53,15 @@ * \param[in] fmt format string * \param[in] args variable argument list */ +#ifdef DEBUG #define LOGPC(ss, level, fmt, args...) \ do { \ if (log_check_level(ss, level)) \ logp2(ss, level, __FILE__, __LINE__, 1, fmt, ##args); \ } while(0) +#else +#define LOGPC(ss, level, fmt, args...) +#endif /*! Log through the Osmocom logging framework with explicit source. * If caller_file is passed as NULL, __FILE__ and __LINE__ are used @@ -87,6 +91,7 @@ * \param[in] fmt format string * \param[in] args variable argument list */ +#ifdef DEBUG #define LOGPSRCC(ss, level, caller_file, caller_line, cont, fmt, args...) \ do { \ if (log_check_level(ss, level)) {\ @@ -96,6 +101,9 @@ logp2(ss, level, __FILE__, __LINE__, cont, fmt, ##args); \ }\ } while(0) +#else +#define LOGPSRCC(ss, level, caller_file, caller_line, cont, fmt, args...) +#endif /*! different log levels */ #define LOGL_DEBUG 1 /*!< debugging information */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:31 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:31 +0000 Subject: Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 ) Change subject: sim slots: omit interrupt disabling for status polling ...................................................................... sim slots: omit interrupt disabling for status polling Doesn't matter here, we don't care if we get interrupted. Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb --- M sysmoOCTSIM/ncn8025.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/95/26395/1 diff --git a/sysmoOCTSIM/ncn8025.c b/sysmoOCTSIM/ncn8025.c index 74d3b39..bcce2ad 100644 --- a/sysmoOCTSIM/ncn8025.c +++ b/sysmoOCTSIM/ncn8025.c @@ -98,7 +98,10 @@ bool ncn8025_interrupt_level(uint8_t slot) { uint8_t pin = slot2int_pin(slot); - return gpio_get_pin_level(pin); + enum gpio_port port = ((enum gpio_port)GPIO_PORT(pin)) & (0x01U << GPIO_PIN(pin)); + uint32_t dir_tmp = hri_port_read_DIR_reg(PORT, port); + + return (bool)(hri_port_read_IN_reg(PORT, port) & ~dir_tmp); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb Gerrit-Change-Number: 26395 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:32 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:32 +0000 Subject: Change in osmo-ccid-firmware[master]: ccid usb handler: fix init flag References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 ) Change subject: ccid usb handler: fix init flag ...................................................................... ccid usb handler: fix init flag Change-Id: I2a1d13b26c578ce3a343e06c2756dd07befcdb7f --- M sysmoOCTSIM/usb/class/ccid/device/ccid_df.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/96/26396/1 diff --git a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c index 665f0fc..e418010 100644 --- a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c +++ b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c @@ -129,7 +129,7 @@ usb_d_ep_deinit(func_data->func_ep_irq); } - _ccid_df_funcd.enabled = true; + _ccid_df_funcd.enabled = false; return ERR_NONE; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2a1d13b26c578ce3a343e06c2756dd07befcdb7f Gerrit-Change-Number: 26396 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:33 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:33 +0000 Subject: Change in osmo-ccid-firmware[master]: makefile: disable libosmocore logging functions References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26397 ) Change subject: makefile: disable libosmocore logging functions ...................................................................... makefile: disable libosmocore logging functions Change-Id: Ic4a55639cd5ace0ef8325d903b0a6b5b41781073 --- M sysmoOCTSIM/gcc/Makefile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/97/26397/1 diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile index 9df0c01..b9e89f9 100644 --- a/sysmoOCTSIM/gcc/Makefile +++ b/sysmoOCTSIM/gcc/Makefile @@ -13,6 +13,8 @@ CFLAGS=-x c -mthumb -DDEBUG -Os -ffunction-sections -fdata-sections -mlong-calls \ -g3 -Wall -c -std=gnu99 $(CFLAGS_CPU) -DOCTSIMFWBUILD -DDISABLE_DFU_DETACH=$(DISABLE_DFU_DETACH) +CFLAGS += -DLIBOSMOCORE_NO_LOGGING + CC = $(CROSS_COMPILE)gcc LD = $(CROSS_COMPILE)ld SIZE = $(CROSS_COMPILE)size -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic4a55639cd5ace0ef8325d903b0a6b5b41781073 Gerrit-Change-Number: 26397 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:33 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:33 +0000 Subject: Change in osmo-ccid-firmware[master]: debug usb-cdc uart: disable it. References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 ) Change subject: debug usb-cdc uart: disable it. ...................................................................... debug usb-cdc uart: disable it. Currently unused. Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb --- M sysmoOCTSIM/main.c M sysmoOCTSIM/usb_descriptors.c M sysmoOCTSIM/usb_descriptors.h M sysmoOCTSIM/usb_start.c 4 files changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/98/26398/1 diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 101af30..bf145cd 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -506,8 +506,10 @@ usb_start(); board_init(); - command_init("sysmoOCTSIM> "); +#ifdef WITH_DEBUG_CDC + command_init("sysmoOCTSIM> "); +#endif /* boost uart priority by setting all other irqs to uartprio+1 */ for(int i = 0; i < PERIPH_COUNT_IRQn; i++) NVIC_SetPriority(i, 2); diff --git a/sysmoOCTSIM/usb_descriptors.c b/sysmoOCTSIM/usb_descriptors.c index 7652bf6..94a473e 100644 --- a/sysmoOCTSIM/usb_descriptors.c +++ b/sysmoOCTSIM/usb_descriptors.c @@ -46,17 +46,24 @@ .bLength = sizeof(struct usb_config_desc), .bDescriptorType = USB_DT_CONFIG, .wTotalLength = sizeof(usb_fs_descs.cfg) + +#ifdef WITH_DEBUG_CDC sizeof(usb_fs_descs.cdc) + +#endif sizeof(usb_fs_descs.ccid) + sizeof(usb_fs_descs.dfu_rt) + sizeof(usb_fs_descs.func_dfu), +#ifdef WITH_DEBUG_CDC .bNumInterfaces = 4, +#else + .bNumInterfaces = 2, +#endif .bConfigurationValue = CONF_USB_CDCD_ACM_BCONFIGVAL, .iConfiguration = STR_DESC_CONFIG, .bmAttributes = CONF_USB_CDCD_ACM_BMATTRI, /* FIXME: The device should offer at least one 100mA configuration. */ .bMaxPower = 250, /* request 500mA */ }, +#ifdef WITH_DEBUG_CDC .cdc = { .comm = { .iface = { @@ -139,6 +146,7 @@ }, }, }, +#endif .ccid = { .iface = { .bLength = sizeof(struct usb_iface_desc), @@ -208,7 +216,11 @@ }, }, }, +#ifdef WITH_DEBUG_CDC DFURT_IF_DESCRIPTOR(3, STR_DESC_INTF_DFURT), +#else + DFURT_IF_DESCRIPTOR(1, STR_DESC_INTF_DFURT), +#endif .str = { #if 0 CDCD_ACM_STR_DESCES diff --git a/sysmoOCTSIM/usb_descriptors.h b/sysmoOCTSIM/usb_descriptors.h index ba879f7..8733b2c 100644 --- a/sysmoOCTSIM/usb_descriptors.h +++ b/sysmoOCTSIM/usb_descriptors.h @@ -43,6 +43,7 @@ struct usb_dev_desc dev; struct usb_config_desc cfg; +#ifdef WITH_DEBUG_CDC /* CDC-ACM: Two interfaces, one with IRQ EP and one with BULK IN + OUT */ struct { struct { @@ -59,6 +60,7 @@ } data; } cdc; +#endif /* CCID: One interface with CCID class descriptor and three endpoints */ struct { struct usb_iface_desc iface; diff --git a/sysmoOCTSIM/usb_start.c b/sysmoOCTSIM/usb_start.c index a4b787e..c4aebd4 100644 --- a/sysmoOCTSIM/usb_start.c +++ b/sysmoOCTSIM/usb_start.c @@ -132,14 +132,14 @@ usbdc_init(ctrl_buffer); usbdc_register_handler(USBDC_HDL_REQ, &string_req_h); +#ifdef WITH_DEBUG_CDC /* usbdc_register_funcion inside */ cdcdf_acm_init(); - +#endif dfudf_init(); printf("usb_descs_size=%u\r\n", usb_descs[0].eod - usb_descs[0].sod); - usbdc_start((struct usbd_descriptors *) usb_descs); - usbdc_attach(); + } /** @@ -147,15 +147,22 @@ */ void usb_start(void) { + +#ifdef WITH_DEBUG_CDC while (!cdcdf_acm_is_enabled()) { // wait cdc acm to be installed }; cdcdf_acm_register_callback(CDCDF_ACM_CB_STATE_C, (FUNC_PTR)usb_device_cb_state_c); +#endif + while(!ccid_df_is_enabled()); } void usb_init(void) { cdc_device_acm_init(); ccid_df_init(); + usbdc_start((struct usbd_descriptors *) usb_descs); + usbdc_attach(); + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb Gerrit-Change-Number: 26398 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:33 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:33 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 ) Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... slot fsm: rearrange fsm cb events to make debugging easier Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b --- M ccid_common/ccid_slot_fsm.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/99/26399/1 diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 8dccfa5..f77081b 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -148,6 +148,10 @@ /* continues in iso_fsm_clot_user_cb once ATR is received */ } +#ifndef __NOP() +#define __NOP() +#endif + static void iso_fsm_clot_user_cb(struct osmo_fsm_inst *fi, int event, int cause, void *data) { struct iso_fsm_slot *ss = iso7816_fsm_get_user_priv(fi); @@ -159,14 +163,16 @@ case ISO7816_E_HW_ERR_IND: card_uart_ctrl(ss->cuart, CUART_CTL_NO_RXTX, true); break; - case ISO7816_E_ATR_DONE_IND: case ISO7816_E_ATR_ERR_IND: - case ISO7816_E_TPDU_DONE_IND: case ISO7816_E_TPDU_FAILED_IND: - case ISO7816_E_PPS_DONE_IND: case ISO7816_E_PPS_FAILED_IND: case ISO7816_E_PPS_UNSUPPORTED_IND: case ISO7816_E_WTIME_EXP: + __NOP(); + /* no break */ + case ISO7816_E_ATR_DONE_IND: + case ISO7816_E_TPDU_DONE_IND: + case ISO7816_E_PPS_DONE_IND: cs->event_data = data; #ifdef OCTSIMFWBUILD asm volatile("dmb st": : :"memory"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:34 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:34 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... slot fsm: fake ccid setparameter response This secretly disables the PPS exchange to set a different baud rate and ensures proper multislot operation at the default rate @ 2.5Mhz. Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/00/26400/1 diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index f77081b..5401bf3 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -32,6 +32,8 @@ #include "iso7816_fsm.h" #include "iso7816_3.h" +#define FAKE_CCID_SETPARAMETERS + struct iso_fsm_slot { /* CCID slot above us */ struct ccid_slot *cs; @@ -280,11 +282,20 @@ * - after ATR while card is idle * - after PPS while card is idle */ +#ifndef FAKE_CCID_SETPARAMETERS card_uart_ctrl(ss->cuart, CUART_CTL_SET_CLOCK_FREQ, fmax); card_uart_ctrl(ss->cuart, CUART_CTL_SET_FD, F/D); card_uart_ctrl(ss->cuart, CUART_CTL_WTIME, cs->proposed_pars.t0.waiting_integer * 960 * D_or_one); cs->pars = cs->proposed_pars; +#else + //card_uart_ctrl(ss->cuart, CUART_CTL_SET_CLOCK_FREQ, fmax); + card_uart_ctrl(ss->cuart, CUART_CTL_SET_FD, F/D); + //card_uart_ctrl(ss->cuart, CUART_CTL_WTIME, cs->proposed_pars.t0.waiting_integer); + + cs->pars.fi = cs->proposed_pars.fi; + cs->pars.di = cs->proposed_pars.di; +#endif resp = ccid_gen_parameters_t0(cs, ss->seq, CCID_CMD_STATUS_OK, 0); ccid_slot_send_unbusy(cs, resp); @@ -408,8 +419,13 @@ LOGPCS(cs, LOGL_DEBUG, "scheduling PPS transfer, PPS1: %2x\n", PPS1); +#if FAKE_CCID_SETPARAMETERS + ccid_slot_send_unbusy(cs, ccid_gen_parameters_t0(cs, ss->seq, CCID_CMD_STATUS_OK, 0)); +#else /* pass PPS1 instead of msgb */ osmo_fsm_inst_dispatch(ss->fi, ISO7816_E_XCEIVE_PPS_CMD, (void*)PPS1); +#endif + /* continues in iso_fsm_clot_user_cb once response/error/timeout is received */ return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:35 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:35 +0000 Subject: Change in osmo-ccid-firmware[master]: 7816 fsm: emphasize the inner workings of the static msgb macro References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26401 ) Change subject: 7816 fsm: emphasize the inner workings of the static msgb macro ...................................................................... 7816 fsm: emphasize the inner workings of the static msgb macro Change-Id: I37226d1fe2c14adb2b2d97608496dbb1661be543 --- M ccid_common/iso7816_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/01/26401/1 diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c index 7ea842d..d82380b 100644 --- a/ccid_common/iso7816_fsm.c +++ b/ccid_common/iso7816_fsm.c @@ -46,9 +46,9 @@ memset(name, 0x00, sizeof(name ## _msgbuf)); \ name->data_len = sizeof(name ## _msgbuf) - sizeof(struct msgb); \ name->len = 0; \ - name->data = name->_data; \ - name->head = name->_data; \ - name->tail = name->_data; \ + name->data = &name->_data[0]; \ + name->head = &name->_data[0]; \ + name->tail = &name->_data[0]; \ } #define COPY_TO_STATIC_MSGB(src, dst) { \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I37226d1fe2c14adb2b2d97608496dbb1661be543 Gerrit-Change-Number: 26401 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 12:15:35 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 12:15:35 +0000 Subject: Change in osmo-ccid-firmware[master]: jenkins: build libosmocore without logging References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 ) Change subject: jenkins: build libosmocore without logging ...................................................................... jenkins: build libosmocore without logging Depends-On: Ia4c78abe5f198139f96ffa289998855be2477585 Change-Id: I5e8ce681e557c41c920959e3651910203f1d527a --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/02/26402/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fec91e5..7877dcf 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -41,7 +41,7 @@ mkdir -p "$inst/stow" autoreconf --install --force ./configure --enable-static --prefix="$inst/stow/libosmocore" --host=arm-none-eabi \ - --enable-embedded --disable-doxygen --disable-shared --disable-pseudotalloc \ + --enable-embedded --disable-log-macros --disable-doxygen --disable-shared --disable-pseudotalloc \ --disable-libsctp --disable-libusb --disable-gb --enable-external-tests \ --disable-libmnl \ CFLAGS="-Os -ffunction-sections -fdata-sections -nostartfiles -nodefaultlibs -Werror -Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp -mthumb -Os -mlong-calls -g3 -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 -I /home/laforge/projects/git/osmo-ccid-firmware/sysmoOCTSIM -Wno-error=format" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5e8ce681e557c41c920959e3651910203f1d527a Gerrit-Change-Number: 26402 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:23:10 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 14:23:10 +0000 Subject: Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 to look at the new patch set (#2). Change subject: sim slots: omit interrupt disabling for status polling ...................................................................... sim slots: omit interrupt disabling for status polling Doesn't matter here, we don't care if we get interrupted. Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb --- M sysmoOCTSIM/ncn8025.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/95/26395/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb Gerrit-Change-Number: 26395 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:25:21 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 14:25:21 +0000 Subject: Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 to look at the new patch set (#3). Change subject: sim slots: omit interrupt disabling for status polling ...................................................................... sim slots: omit interrupt disabling for status polling Doesn't matter here, we don't care if we get interrupted. Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb --- M sysmoOCTSIM/ncn8025.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/95/26395/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb Gerrit-Change-Number: 26395 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:29:30 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 14:29:30 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 to look at the new patch set (#4). Change subject: slot fsm: fake ccid setparameter response ...................................................................... slot fsm: fake ccid setparameter response This secretly disables the PPS exchange to set a different baud rate and ensures proper multislot operation at the default rate @ 2.5Mhz. Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/00/26400/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:30:04 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 14:30:04 +0000 Subject: Change in osmo-ccid-firmware[master]: debug usb-cdc uart: disable it. In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 to look at the new patch set (#4). Change subject: debug usb-cdc uart: disable it. ...................................................................... debug usb-cdc uart: disable it. Currently unused. Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb --- M sysmoOCTSIM/main.c M sysmoOCTSIM/usb_descriptors.c M sysmoOCTSIM/usb_descriptors.h M sysmoOCTSIM/usb_start.c 4 files changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/98/26398/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb Gerrit-Change-Number: 26398 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:46:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:46:26 +0000 Subject: Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 ) Change subject: sim slots: omit interrupt disabling for status polling ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395/3/sysmoOCTSIM/ncn8025.c File sysmoOCTSIM/ncn8025.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395/3/sysmoOCTSIM/ncn8025.c at 101 PS3, Line 101: uint32_t pin_values = hri_port_read_IN_reg(PORT, GPIO_PORT(pin)); : : return (bool)(pin_values & (0x01U << GPIO_PIN(pin))); might be worth to create an [inline?] function for this if we need it more often, something like __gpio_get_pin_level() if we want to use Linux customs for functios that bypass locking. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb Gerrit-Change-Number: 26395 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:46:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:46:56 +0000 Subject: Change in osmo-ccid-firmware[master]: ccid usb handler: fix init flag In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 ) Change subject: ccid usb handler: fix init flag ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2a1d13b26c578ce3a343e06c2756dd07befcdb7f Gerrit-Change-Number: 26396 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:46:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:47:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:47:05 +0000 Subject: Change in osmo-ccid-firmware[master]: makefile: disable libosmocore logging functions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26397 ) Change subject: makefile: disable libosmocore logging functions ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic4a55639cd5ace0ef8325d903b0a6b5b41781073 Gerrit-Change-Number: 26397 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:47:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:47:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:47:27 +0000 Subject: Change in osmo-ccid-firmware[master]: debug usb-cdc uart: disable it. In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 ) Change subject: debug usb-cdc uart: disable it. ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb Gerrit-Change-Number: 26398 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Sat, 27 Nov 2021 14:47:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:48:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:48:26 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 ) Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... Patch Set 4: not entirely sure why this makes debugging easier, one more line in the commit log and/or code comment might help. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:48:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:49:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:49:18 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... Patch Set 5: (1 comment) not sure we want this in master? https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c File ccid_common/ccid_slot_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c at 153 PS5, Line 153: #ifndef __NOP unrelated change -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:49:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:49:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:49:37 +0000 Subject: Change in osmo-ccid-firmware[master]: 7816 fsm: emphasize the inner workings of the static msgb macro In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26401 ) Change subject: 7816 fsm: emphasize the inner workings of the static msgb macro ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I37226d1fe2c14adb2b2d97608496dbb1661be543 Gerrit-Change-Number: 26401 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:49:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:49:49 +0000 Subject: Change in osmo-ccid-firmware[master]: jenkins: build libosmocore without logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 ) Change subject: jenkins: build libosmocore without logging ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5e8ce681e557c41c920959e3651910203f1d527a Gerrit-Change-Number: 26402 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:49:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:52:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 27 Nov 2021 14:52:03 +0000 Subject: Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 ) Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... Patch Set 1: I think you are confusing two different things: a) disabling logging altogether (this is new) b) disabling only DEBUG level logging while keeping the higher level logging 'b' was what I had originally in mind with the DEBUG define when writing the logging code ages ago, and which is also what I believe you recently wanted to support by an external #define? In any case, whatever we do, the existence of the "DEBUG" #define should only toggle LOGL_DEBUG / DEBUGP and not normal LOGP calls. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:52:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:55:59 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 14:55:59 +0000 Subject: Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 ) Change subject: sim slots: omit interrupt disabling for status polling ...................................................................... Patch Set 3: This is a fairly unique function, because we know the pins we're interested in are configured for input, we don't care about intermittent pin state manipulation by interrupts, and the state changes are fairly slow. The atmel functions are mostly very generic and inefficient, there is already a few cycles delay for every port state access unless you run those in the high-power modes, and then there is a critical section wrapped around the atmel function because it uses multiple accesses to check per-pin direction and also gets the state for pins set to output, none of which is necessary here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb Gerrit-Change-Number: 26395 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:55:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:56:15 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 14:56:15 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 ) Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... Patch Set 4: because i can break on it.. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:56:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 14:58:04 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 14:58:04 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c File ccid_common/ccid_slot_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c at 153 PS5, Line 153: #ifndef __NOP > unrelated change there is no change here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 14:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 15:02:44 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 15:02:44 +0000 Subject: Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 ) Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... Patch Set 1: No, this was always about getting rid of logging related calls and especially the infinite log level checks, I just got the first patch wrong. The fsm will try to log every single event in _osmo_fsm_inst_dispatch using LOGPFSMSRC for example, which adds up if we have a lot of events... like for every single byte.. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 15:02:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 15:06:11 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sat, 27 Nov 2021 15:06:11 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... Patch Set 5: > Patch Set 5: > > (1 comment) > > not sure we want this in master? Well it makes it work, the only other and slightly less well tested way would be to fix the frequency to 2.5mhz and still do the pps, but limit bMaxCCIDBusySlots to 4... The actual fix here with this approach is obviously to move the atr and baud rate handling to the firmware, as pointed out multiple times. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 27 Nov 2021 15:06:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 23:14:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Nov 2021 23:14:14 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 2: Verified+1 > Patch Set 2: Code-Review+1 > > AFAIR pespin had some concerns about osmo-gsm-tester relying on existing output, please do a grep in the osmo-gsm-tester repo to find out and make sure it is updated, too. I checked the code, and as far as I can see we parse the output using Python's JSON library. I just fixed trailing commas in my code, so the parser is happy. I also did some tests, and everything appears to work fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Reviewer: roox Gerrit-Comment-Date: Sat, 27 Nov 2021 23:14:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 23:14:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Nov 2021 23:14:24 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... Patch Set 2: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 27 Nov 2021 23:14:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 23:14:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Nov 2021 23:14:28 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 ) Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... ipaccess-config: improve readability of printed attribute response Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 --- M src/ipaccess/ipaccess-config.c 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 2d72d0e..c06a7cc 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -281,6 +281,7 @@ char oml_ip[20] = {0}; uint16_t oml_port = 0; char unit_id[40] = {0}; + unsigned int indent = 0; abis_nm_tlv_parse(&tp, bts, foh->data, oh->length-sizeof(*foh)); @@ -290,8 +291,23 @@ abis_nm_tlv_attr_unit_id(&tp, unit_id, sizeof(unit_id)); - fprintf(stdout, "{ \"primary_oml_ip\": \"%s\", \"primary_oml_port\": %" PRIu16 ", \"unit_id\": \"%s\" }\n", - oml_ip, oml_port, unit_id); +#define ENDL(last) \ + fprintf(stdout, "%s\n", last ? "" : ",") +#define print_offset(fmt, args...) \ + fprintf(stdout, "%*s" fmt, indent * 4, "", ## args) +#define print_field(field, fmt, args...) \ + print_offset("\"%s\": \"" fmt "\"", field, ## args) + + print_offset("{\n"); + indent++; + + print_field("primary_oml_ip", "%s", oml_ip); ENDL(false); + print_field("primary_oml_port", "%u", oml_port); ENDL(false); + print_field("unit_id", "%s", unit_id); ENDL(true); + + indent--; + print_offset("}\n"); + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Reviewer: roox Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Nov 27 23:14:29 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Nov 2021 23:14:29 +0000 Subject: Change in osmo-bsc[master]: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26150 ) Change subject: ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS ...................................................................... ipaccess-config: request and print NM_ATT_IPACC_NV_FLAGS Below is an example output: """ Received SIGNAL S_NM_GET_ATTR_REP { "primary_oml_ip": "192.168.100.100", "primary_oml_port": "0", "unit_id": "6969/0/0", "nv_flags": { "static-ip": "no", "static-gw": "no", "no-dhcp-vsi": "no", "dhcp-enabled": "yes", "led-enabled": "yes", "secondary-oml-enabled": "yes", "diag-enabled": "yes", "cli-enabled": "yes", "http-enabled": "no", "post-enabled": "yes", "snmp-enabled": "yes" } } """ Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 --- M src/ipaccess/ipaccess-config.c 1 file changed, 30 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index c06a7cc..06fc9eb 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -268,6 +268,8 @@ return 0; } +static const struct value_string ipa_nvflag_strs[]; + static int print_attr_rep(struct msgb *mb) { /* Parse using nanoBTS own formatting for Get Attribute Response */ @@ -303,7 +305,33 @@ print_field("primary_oml_ip", "%s", oml_ip); ENDL(false); print_field("primary_oml_port", "%u", oml_port); ENDL(false); - print_field("unit_id", "%s", unit_id); ENDL(true); + print_field("unit_id", "%s", unit_id); ENDL(false); + + uint16_t Fx = (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[2] << 8) + | (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[0] << 0); + uint16_t Mx = (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[3] << 8) + | (TLVP_VAL(&tp, NM_ATT_IPACC_NV_FLAGS)[1] << 0); + const struct value_string *nvflag = ipa_nvflag_strs; + + print_offset("\"nv_flags\": {\n"); + indent++; + + while (nvflag->value && nvflag->str) { + const char *val = (Fx & nvflag->value) ? "yes" : "no"; + if (~Mx & nvflag->value) + val = "unknown"; + print_field(nvflag->str, "%s", val); + + nvflag++; + + if (nvflag->value && nvflag->str) + ENDL(false); /* more fields to print */ + else + ENDL(true); /* this was the last field */ + } + + indent--; + print_offset("}\n"); indent--; print_offset("}\n"); @@ -559,6 +587,7 @@ if (get_attr) { msgb_put_u8(nmsg_get, NM_ATT_IPACC_PRIM_OML_CFG); msgb_put_u8(nmsg_get, NM_ATT_IPACC_UNIT_ID); + msgb_put_u8(nmsg_get, NM_ATT_IPACC_NV_FLAGS); } if (unit_id) { len = strlen(unit_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic901910878529e6d8b152b3417463bae60644b82 Gerrit-Change-Number: 26150 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 00:45:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 00:45:08 +0000 Subject: Change in osmo-msc[master]: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26403 ) Change subject: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd ...................................................................... VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd Change-Id: I95636a7713cd90956e46a5b6f8f7ded3bf4f5f0a --- M src/libmsc/msc_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/03/26403/1 diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 6be09d8..4dd834b 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -297,8 +297,8 @@ int minutes = atoi(argv[0]); int rc; - vty_out(vty, "%% 'periodic location update' is now deprecated: " - "use 'timer T3212' to change subscriber expiration " + vty_out(vty, "%% 'periodic location update' is now deprecated. " + "Use 'msc' / 'timer vlr T3212' to change subscriber expiration " "timeout.%s", VTY_NEWLINE); /* We used to double this value and add a minute when scheduling the -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I95636a7713cd90956e46a5b6f8f7ded3bf4f5f0a Gerrit-Change-Number: 26403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 13:02:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 13:02:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnectionHandler: refactor and split f_mm_common() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 ) Change subject: msc/BSC_ConnectionHandler: refactor and split f_mm_common() ...................................................................... msc/BSC_ConnectionHandler: refactor and split f_mm_common() Reduce nesting and improve readability by splitting GERAN/UTRAN specific CMC/SMC message handling into separate functions. Change-Id: Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Related: OS#5333 --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 69 insertions(+), 57 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/26404/1 diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 2f270ca..873ec5b 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -611,68 +611,80 @@ } +private function f_mm_ciph_geran() runs on BSC_ConnHdlr +{ + var template BSSMAP_IE_EncryptionInformation encryptionInformation; + var template BSSMAP_IE_ChosenEncryptionAlgorithm chosenEncryptionAlgorithm; + var template BSSMAP_IE_KC128 kC128; + var OCT1 a5_perm_alg; + var PDU_BSSAP pdu; + + if (g_pars.net.expect_ciph) { + /* There is nothing to do */ + return; + } + + f_get_expected_encryption(encryptionInformation, chosenEncryptionAlgorithm, kC128, a5_perm_alg); + alt { + [] BSSAP.receive(tr_BSSMAP_CipherModeCmd2(encryptionInformation, kC128)) -> value pdu { + var OCT1 a5_chosen := f_best_alg_from_mask(a5_perm_alg); + var integer a5_nr := f_alg_from_mask(a5_chosen); + BSSAP.send(ts_BSSMAP_CipherModeCompl(int2oct(a5_nr+1, 1))); + } + [] BSSAP.receive(tr_BSSMAP_CipherModeCmd2) -> value pdu { + log("Error: Ciphering Mode Command with unexpected content. Expected: ", + tr_BSSMAP_CipherModeCmd2(encryptionInformation, kC128), " got: ", pdu); + setverdict(fail, "Ciphering Mode Command with unexpected content."); + mtc.stop; + } + [] BSSAP.receive(tr_BSSMAP_ClassmarkRequest) { + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)) + repeat; + } + } + /* FIXME: Send the best available algorithm */ +} + +private function f_mm_ciph_utran() runs on BSC_ConnHdlr +{ + alt { + [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(uia_algs := ?, + uia_key := oct2bit(g_pars.vec.ik), + key_sts := ?, + uea_algs := ?, + uea_key := oct2bit(g_pars.vec.ck))) { + var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1*/ + var EncryptionAlgorithm uea_chosen := 1; /*standard_UMTS_encryption_algorith_UEA1*/ + BSSAP.send(ts_RANAP_SecurityModeCompleteEnc(uia_chosen, uea_chosen)); + } + [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(?,?,?,?,?)) { + setverdict(fail, "Invalid SecurityModeCommand (ciphering case)"); + mtc.stop; + } + [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, + uia_key := oct2bit(g_pars.vec.ik), + key_sts := ?)) { + var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/ + BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen)); + } + [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(?,?,?)) { + setverdict(fail, "Invalid SecurityModeCommand (non-ciphering case)"); + mtc.stop; + } + } +} + function f_mm_common() runs on BSC_ConnHdlr { f_mm_auth(); - if (g_pars.ran_is_geran) { - if (g_pars.net.expect_ciph) { - var template BSSMAP_IE_EncryptionInformation encryptionInformation; - var template BSSMAP_IE_ChosenEncryptionAlgorithm chosenEncryptionAlgorithm; - var template BSSMAP_IE_KC128 kC128; - var OCT1 a5_perm_alg; - f_get_expected_encryption(encryptionInformation, chosenEncryptionAlgorithm, kC128, a5_perm_alg); - var PDU_BSSAP pdu; - var template PDU_BSSAP expect_ciph_mode_cmd := tr_BSSMAP_CipherModeCmd2(encryptionInformation, kC128); - alt { - [] BSSAP.receive(expect_ciph_mode_cmd) -> value pdu { - var OCT1 a5_chosen := f_best_alg_from_mask(a5_perm_alg); - var integer a5_nr := f_alg_from_mask(a5_chosen); - BSSAP.send(ts_BSSMAP_CipherModeCompl(int2oct(a5_nr+1, 1))); - } - [] BSSAP.receive(tr_BSSMAP_CipherModeCmd2) -> value pdu { - log("Error: Ciphering Mode Command with unexpected content. Expected: ", - expect_ciph_mode_cmd, " got: ", pdu); - setverdict(fail, "Ciphering Mode Command with unexpected content."); - mtc.stop; - } - [] BSSAP.receive(tr_BSSMAP_ClassmarkRequest) { - BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)) - repeat; - } - } - /* FIXME: Send the best available algorithm */ - } - f_expect_common_id(); - } else { /* UTRAN */ - alt { - [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(uia_algs := ?, - uia_key := oct2bit(g_pars.vec.ik), - key_sts := ?, - uea_algs := ?, - uea_key := oct2bit(g_pars.vec.ck))) { - var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1*/ - var EncryptionAlgorithm uea_chosen := 1; /*standard_UMTS_encryption_algorith_UEA1*/ - BSSAP.send(ts_RANAP_SecurityModeCompleteEnc(uia_chosen, uea_chosen)); - f_expect_common_id(); - } - [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(?,?,?,?,?)) { - setverdict(fail, "Invalid SecurityModeCommand (ciphering case)"); - mtc.stop; - } - [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, - uia_key := oct2bit(g_pars.vec.ik), - key_sts := ?)) { - var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/ - BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen)); - f_expect_common_id(); - } - [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(?,?,?)) { - setverdict(fail, "Invalid SecurityModeCommand (non-ciphering case)"); - mtc.stop; - } - } + if (g_pars.ran_is_geran) { + f_mm_ciph_geran(); + } else { + f_mm_ciph_utran(); } + + f_expect_common_id(); } function f_expect_mm_info() runs on BSC_ConnHdlr { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Gerrit-Change-Number: 26404 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 13:23:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 13:23:46 +0000 Subject: Change in osmo-msc[master]: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd In-Reply-To: References: Message-ID: fixeria has removed fixeria from this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26403 ) Change subject: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd ...................................................................... Removed reviewer fixeria. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I95636a7713cd90956e46a5b6f8f7ded3bf4f5f0a Gerrit-Change-Number: 26403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: deleteReviewer -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 16:56:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 16:56:26 +0000 Subject: Change in osmo-msc[master]: libvlr: vlr_set_ciph_mode(): avoid redundant check References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26405 ) Change subject: libvlr: vlr_set_ciph_mode(): avoid redundant check ...................................................................... libvlr: vlr_set_ciph_mode(): avoid redundant check This function is never called when ciph_required is false, so there is no need for an additional check in this function. Change-Id: I900ddd5f1882f8cee234ab1074adcf25830a092c --- M include/osmocom/msc/vlr.h M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_lu_fsm.c 4 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/05/26405/1 diff --git a/include/osmocom/msc/vlr.h b/include/osmocom/msc/vlr.h index f12e906..d752dfb 100644 --- a/include/osmocom/msc/vlr.h +++ b/include/osmocom/msc/vlr.h @@ -472,7 +472,6 @@ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool ciph_required, bool umts_aka, bool retrieve_imeisv); diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 23bd671..fc23b37 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1382,13 +1382,9 @@ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool ciph_required, bool umts_aka, bool retrieve_imeisv) { - if (!ciph_required) - return 0; - LOGPFSML(fi, LOGL_DEBUG, "Set Ciphering Mode\n"); return vlr->ops.set_ciph_mode(msc_conn_ref, umts_aka, retrieve_imeisv); } diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index b3660ff..b880fcf 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -299,7 +299,6 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, par->msc_conn_ref, - par->ciphering_required, umts_aka, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 53e614d..41e5608 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -878,7 +878,6 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, lfp->msc_conn_ref, - lfp->ciphering_required, umts_aka, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I900ddd5f1882f8cee234ab1074adcf25830a092c Gerrit-Change-Number: 26405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 16:56:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 16:56:27 +0000 Subject: Change in osmo-msc[master]: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26406 ) Change subject: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN ...................................................................... libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN Ciphering is optional in both GERAN and UTRAN, however for the later it's *required* to enable integrity protection for the signalling. Thus we must always send Security Mode Command in UTRAN, even in case if ciphering is disabled (UEA0) in the configuration. The actual decision whether to send CMC/SMC or not is taken in: * vlr_access_req_fsm.c / _proc_arq_vlr_node2(), and * vlr_lu_fsm.c / vlr_loc_upd_post_auth(). depending on the value returned by is_ciph_required(). Let's rename this function to is_cmc_smc_required() and ensure that it always returns true in UTRAN. This change fixes the Iu test cases in ttcn3-msc-test. Change-Id: I6205f13453eff7afbf25e013d72ae98a78fcd31b Fixes: OS#5333 --- M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_test_umts_authen.err 4 files changed, 178 insertions(+), 111 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/26406/1 diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index b880fcf..8daaaad 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -267,9 +267,12 @@ _proc_arq_vlr_node2_post_vlr(fi); } -static bool is_ciph_required(struct proc_arq_priv *par) +/* Determine if sending of CMC/SMC is required */ +static bool is_cmc_smc_required(struct proc_arq_priv *par) { - return par->ciphering_required; + /* UTRAN: always send SecModeCmd, even if ciphering is not required. + * GERAN: avoid sending CiphModeCmd if ciphering is not required. */ + return par->is_utran || par->ciphering_required; } static void _proc_arq_vlr_node2(struct osmo_fsm_inst *fi) @@ -280,7 +283,7 @@ LOGPFSM(fi, "%s()\n", __func__); - if (!is_ciph_required(par)) { + if (!is_cmc_smc_required(par)) { _proc_arq_vlr_node2_post_ciph(fi); return; } diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 41e5608..4f603b3 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -702,10 +702,12 @@ (lfp->ciphering_required && !auth_try_reuse_tuple(lfp->vsub, lfp->key_seq)); } -/* Determine if ciphering is required */ -static bool is_ciph_required(struct lu_fsm_priv *lfp) +/* Determine if sending of CMC/SMC is required */ +static bool is_cmc_smc_required(struct lu_fsm_priv *lfp) { - return lfp->ciphering_required; + /* UTRAN: always send SecModeCmd, even if ciphering is not required. + * GERAN: avoid sending CiphModeCmd if ciphering is not required. */ + return lfp->is_utran || lfp->ciphering_required; } /* Determine if a HLR Update is required */ @@ -853,7 +855,7 @@ OSMO_ASSERT(vsub); - if (!is_ciph_required(lfp)) { + if (!is_cmc_smc_required(lfp)) { vlr_loc_upd_post_ciph(fi); return; } diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index f132cdf..0a2a446 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -124,31 +124,38 @@ VERBOSE_ASSERT(auth_request_sent, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "27497388b6cb044648f396aa155b95ef"); - ms_sends_msg("0554" "e229c19e" "2104" "791f2e41"); - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); - gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(1); - VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0554" "e229c19e" "2104" "791f2e41"); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "27497388b6cb044648f396aa155b95ef"); + ms_sends_msg("0554" "e229c19e" "2104" "791f2e41"); + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); + gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } btw("HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT"); @@ -198,28 +205,35 @@ EXPECT_ACCEPTED(false); thwart_rx_non_initial_requests(); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "1159ec926a50e98c034a6b7d7c9f418d"); - ms_sends_msg("0554" "7db47cf7" "2104" "f81e4dc7"); /* 2nd vector's res, s.a. */ - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(1); - VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts with a CM Service Accept"); gsup_expect_tx(NULL); ms_sends_msg("0554" "7db47cf7" "2104" "f81e4dc7"); /* 2nd vector's res, s.a. */ VERBOSE_ASSERT(cm_service_result_sent, == RES_ACCEPT, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "1159ec926a50e98c034a6b7d7c9f418d"); + ms_sends_msg("0554" "7db47cf7" "2104" "f81e4dc7"); /* 2nd vector's res, s.a. */ + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } /* Release connection */ @@ -265,27 +279,34 @@ EXPECT_ACCEPTED(false); thwart_rx_non_initial_requests(); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "eb50e770ddcc3060101d2f43b6c2b884"); - ms_sends_msg("0554" "706f9967" "2104" "19ba609c"); /* 3nd vector's res, s.a. */ - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts and sends SMS"); - dtap_expect_tx(sms); - ms_sends_security_mode_complete(1); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts and sends pending SMS"); dtap_expect_tx(sms); ms_sends_msg("0554" "706f9967" "2104" "19ba609c"); /* 3nd vector's res, s.a. */ VERBOSE_ASSERT(dtap_tx_confirmed, == true, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "eb50e770ddcc3060101d2f43b6c2b884"); + ms_sends_msg("0554" "706f9967" "2104" "19ba609c"); /* 3nd vector's res, s.a. */ + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts and sends SMS"); + dtap_expect_tx(sms); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } btw("SMS was delivered, no requests pending for subscr"); @@ -516,31 +537,38 @@ VERBOSE_ASSERT(auth_request_sent, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "8a90c769b7272f3bb7a1c1fbb1ea9349"); - ms_sends_msg("0554" "1df5f0b4" "2104" "f22b696e"); - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); - gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(1); - VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0554" "1df5f0b4" "2104" "f22b696e"); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "8a90c769b7272f3bb7a1c1fbb1ea9349"); + ms_sends_msg("0554" "1df5f0b4" "2104" "f22b696e"); + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); + gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } btw("HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT"); diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.err b/tests/msc_vlr/msc_vlr_test_umts_authen.err index 76f822f..543c9d3 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.err +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.err @@ -660,7 +660,7 @@ <-- GSUP rx OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT: vlr_gsupc_read_cb() returns 0 auth_request_sent == 1 lu_result_sent == 0 -- Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (lu,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -675,18 +675,28 @@ DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_RES DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_auth() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_ciph() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=27497388b6cb044648f396aa155b95ef +DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) + security_mode_ctrl_sent == 1 + lu_result_sent == 0 +- MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR +DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: Received Event VLR_ULA_E_CIPH_RES +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_post_ciph() DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_node_4() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_node_4() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Allocated DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: is child of vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Received Event UPD_HLR_VLR_E_START GSUP --> HLR: OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST: 04010809710000000156f02801020a0101 DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: state_chg to UPD_HLR_VLR_S_WAIT_FOR_DATA -DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) gsup_tx_confirmed == 1 lu_result_sent == 0 - HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT @@ -864,7 +874,7 @@ DRLL msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Dispatching 04.08 message: SMS SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Message not permitted for initial conn: SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN decode error (rc=-13) for DTAP from MSC-I -- Encryption disabled. MS sends Authen Response, VLR accepts with a CM Service Accept +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (cm_service_sms,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -879,25 +889,31 @@ DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){VLR_SUB_AS_AUTHENTICATED}: Removing from parent Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ) DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: Received Event PR_ARQ_E_AUTH_RES DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_ciph() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=1159ec926a50e98c034a6b7d7c9f418d +DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (cm_service_sms) + security_mode_ctrl_sent == 1 + cm_service_result_sent == 0 +- MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept +DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: Received Event PR_ARQ_E_CIPH_RES +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_ciph() DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_vlr() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_pres() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_trace() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_imei() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: proc_arq_fsm_done(PASSED) -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_DONE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_vlr() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_pres() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_trace() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_imei() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: proc_arq_fsm_done(PASSED) +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: state_chg to PR_ARQ_S_DONE DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_DONE}: Process Access Request result: PASSED -DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Sending DTAP: MM GSM48_MT_MM_CM_SERV_ACC -DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN encode: DTAP on UTRAN-Iu -- DTAP --UTRAN-Iu--> MS: GSM48_MT_MM_CM_SERV_ACC: 0521 -DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Received Event MSC_A_EV_AUTHENTICATED DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: state_chg to MSC_A_ST_AUTHENTICATED -DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTHENTICATED}: - rx_from_ms: now used by 1 (cm_service_sms) - cm_service_result_sent == 1 + cm_service_result_sent == 0 - Concluding CM Service Request DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTHENTICATED}: - cm_service_sms: now used by 0 (-) DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTHENTICATED}: Received Event MSC_A_EV_UNUSED @@ -1020,7 +1036,7 @@ DRLL msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: Dispatching 04.08 message: SMS SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: Message not permitted for initial conn: SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN decode error (rc=-13) for DTAP from MSC-I -- Encryption disabled. MS sends Authen Response, VLR accepts and sends pending SMS +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (paging-response,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -1035,22 +1051,33 @@ DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){VLR_SUB_AS_AUTHENTICATED}: Removing from parent Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP) DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: Received Event PR_ARQ_E_AUTH_RES DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_ciph() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=eb50e770ddcc3060101d2f43b6c2b884 +DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (paging-response) + security_mode_ctrl_sent == 1 +- MS sends SecurityModeControl acceptance, VLR accepts and sends SMS +DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: Received Event PR_ARQ_E_CIPH_RES +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_ciph() DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_vlr() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_pres() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_trace() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_imei() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: proc_arq_fsm_done(PASSED) -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_DONE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_vlr() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_pres() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_trace() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_imei() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: proc_arq_fsm_done(PASSED) +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: state_chg to PR_ARQ_S_DONE DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_DONE}: Process Access Request result: PASSED DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: Received Event MSC_A_EV_AUTHENTICATED DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: state_chg to MSC_A_ST_AUTHENTICATED DPAG Paging: IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 for MT-SMS: Paging Response action (success) DPAG Paging: IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 for MT-SMS: Removing Paging Request DLSMS trans(SMS IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 callref-0x40000002 tid-0) mmsms_paging_cb(success) -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: + sms: now used by 3 (paging-response,rx_from_ms,sms) +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: + sms: now used by 2 (paging-response,sms) DLSMS SMC(0) message MMSMS-EST-CNF received in state MM_CONN_PENDING DLSMS SMC(0) send CP data DLSMS SMC(0) new CP state MM_CONN_PENDING -> WAIT_CP_ACK @@ -1062,10 +1089,7 @@ - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 - Paging: now used by 4 (attached,SMS-receiver,SMS,active-conn) -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: - paging-response: now used by 2 (rx_from_ms,sms) -DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: - rx_from_ms: now used by 1 (sms) - dtap_tx_confirmed == 1 +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: - paging-response: now used by 1 (sms) - SMS was delivered, no requests pending for subscr DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 + _test_umts_authen: now used by 5 (attached,SMS-receiver,SMS,active-conn,_test_umts_authen) llist_count(&vsub->cs.requests) == 0 @@ -1136,7 +1160,7 @@ DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_DONE}: Removing from parent msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP) DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_DONE}: Deferring: will deallocate with msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP) DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_RELEASED}: Removing from parent msub_fsm -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_RELEASED}: max total use count was 3 +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_RELEASED}: max total use count was 2 DMSC msub_fsm{active}: Received Event MSUB_EV_ROLE_TERMINATED DMSC msub(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100) MSC-A terminated DMSC msub(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100) 1 MSC-I still active @@ -2158,7 +2182,7 @@ <-- GSUP rx OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT: vlr_gsupc_read_cb() returns 0 auth_request_sent == 1 lu_result_sent == 0 -- Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (lu,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -2173,18 +2197,28 @@ DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_RES DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_auth() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_ciph() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=8a90c769b7272f3bb7a1c1fbb1ea9349 +DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) + security_mode_ctrl_sent == 1 + lu_result_sent == 0 +- MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR +DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: Received Event VLR_ULA_E_CIPH_RES +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_post_ciph() DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_node_4() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_node_4() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Allocated DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: is child of vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Received Event UPD_HLR_VLR_E_START GSUP --> HLR: OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST: 04010809710000000156f02801020a0101 DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: state_chg to UPD_HLR_VLR_S_WAIT_FOR_DATA -DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) gsup_tx_confirmed == 1 lu_result_sent == 0 - HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6205f13453eff7afbf25e013d72ae98a78fcd31b Gerrit-Change-Number: 26406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 19:19:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 19:19:38 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 ) Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report ...................................................................... ttcn3-tcpdump-stop.sh: order the SUT to print talloc report This might be useful when trying to find which of the test cases causes a memlek in the SUT. This feature relies on the contents of '/tmp/sut.pid', which is expected contain PID of the SUT. Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Related: Icd4c2d80db934535d499598282ed9416d8088163 Related: OS#5328 --- M ttcn3-tcpdump-stop.sh 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/26407/1 diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index b2a3a3e..18fdb43 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -1,5 +1,6 @@ #!/bin/sh +PIDFILE_SUT=/tmp/sut.pid PIDFILE_PCAP=/tmp/pcap.pid PIDFILE_NETCAT=/tmp/netcat.pid TESTCASE=$1 @@ -19,6 +20,14 @@ fi } +# Order the SUT to print a talloc report +if [ -f "$PIDFILE_SUT" ]; then + PID=$(cat "$PIDFILE_SUT") + if [ -e /proc/$PID/status ]; then + kill -s USR1 $PID || true + fi +fi + date if [ x"$VERDICT" = x"pass" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Gerrit-Change-Number: 26407 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 19:20:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 19:20:32 +0000 Subject: Change in docker-playground[master]: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid ...................................................................... ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Related: I1b03b17426d8760c55976e3b78ca2f3af248c055 Related: OS#5328 --- M ttcn3-bsc-test-vamos/jenkins.sh M ttcn3-bsc-test/jenkins-sccplite.sh M ttcn3-bsc-test/jenkins.sh M ttcn3-bts-test/jenkins.sh M ttcn3-cbc-test/jenkins.sh M ttcn3-gbproxy-test/jenkins.sh M ttcn3-ggsn-test/jenkins.sh M ttcn3-hlr-test/jenkins.sh M ttcn3-hnodeb-test/jenkins.sh M ttcn3-mgw-test/jenkins.sh M ttcn3-msc-test/jenkins.sh M ttcn3-pcu-test/jenkins.sh M ttcn3-sgsn-test/jenkins.sh M ttcn3-sip-test/jenkins.sh M ttcn3-smlc-test/jenkins.sh M ttcn3-stp-test/jenkins.sh 16 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/08/26408/1 diff --git a/ttcn3-bsc-test-vamos/jenkins.sh b/ttcn3-bsc-test-vamos/jenkins.sh index 6462977..dc6e868 100755 --- a/ttcn3-bsc-test-vamos/jenkins.sh +++ b/ttcn3-bsc-test-vamos/jenkins.sh @@ -43,6 +43,7 @@ --name ${BUILD_TAG}-bsc -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bsc-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-bsc "pidof osmo-bsc > /tmp/sut.pid" for i in `seq 0 2`; do echo Starting container with OML for BTS$i diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index bc6eaa0..4ebdaa0 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -30,6 +30,7 @@ --name ${BUILD_TAG}-bsc -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bsc-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-bsc "pidof osmo-bsc > /tmp/sut.pid" for i in `seq 0 2`; do echo Starting container with OML for BTS$i diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index 18236a2..3f9ec4f 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -43,6 +43,7 @@ --name ${BUILD_TAG}-bsc -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bsc-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-bsc "pidof osmo-bsc > /tmp/sut.pid" for i in `seq 0 2`; do echo Starting container with OML for BTS$i diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 67c6d07..70a258b 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -52,6 +52,7 @@ $DOCKER_ARGS \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.cfg >>/data/osmo-bts.log 2>&1" + docker exec ${BUILD_TAG}-bts "pidof osmo-bts-$variant > /tmp/sut.pid" } start_fake_trx() { diff --git a/ttcn3-cbc-test/jenkins.sh b/ttcn3-cbc-test/jenkins.sh index 347623f..6236dfb 100755 --- a/ttcn3-cbc-test/jenkins.sh +++ b/ttcn3-cbc-test/jenkins.sh @@ -26,6 +26,7 @@ --name ${BUILD_TAG}-cbc -d \ $DOCKER_ARGS \ $REPO_USER/osmo-cbc-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-cbc "pidof osmo-cbc > /tmp/sut.pid" echo Starting container with CBC testsuite docker run --rm \ diff --git a/ttcn3-gbproxy-test/jenkins.sh b/ttcn3-gbproxy-test/jenkins.sh index 3595c16..8827e3c 100755 --- a/ttcn3-gbproxy-test/jenkins.sh +++ b/ttcn3-gbproxy-test/jenkins.sh @@ -32,6 +32,7 @@ $DOCKER_ARGS \ $REPO_USER/osmo-gbproxy-$IMAGE_SUFFIX \ /bin/sh -c "osmo-gbproxy -c /data/osmo-gbproxy.cfg >/data/osmo-gbproxy.log 2>&1" +docker exec ${BUILD_TAG}-gbproxy "pidof osmo-gbproxy > /tmp/sut.pid" echo Starting container with gbproxy testsuite docker run --rm \ diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index ba5e76d..86be888 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -66,6 +66,8 @@ kernel_test_wait_for_vm "$VOL_BASE_DIR/ggsn/osmo-ggsn.log" +docker exec ${BUILD_TAG}-ggsn "pidof osmo-ggsn > /tmp/sut.pid" + # start docker container with testsuite in foreground docker run --rm \ --sysctl net.ipv6.conf.all.disable_ipv6=0 \ diff --git a/ttcn3-hlr-test/jenkins.sh b/ttcn3-hlr-test/jenkins.sh index e003e03..cf5ae12 100755 --- a/ttcn3-hlr-test/jenkins.sh +++ b/ttcn3-hlr-test/jenkins.sh @@ -27,6 +27,7 @@ $DOCKER_ARGS \ $REPO_USER/osmo-hlr-$IMAGE_SUFFIX \ /bin/sh -c "osmo-hlr -c /data/osmo-hlr.cfg >/data/osmo-hlr.log 2>&1" +docker exec ${BUILD_TAG}-hlr "pidof osmo-hlr > /tmp/sut.pid" echo Starting container with HLR testsuite docker run --rm \ diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh index 6ffa98a..baba524 100755 --- a/ttcn3-hnodeb-test/jenkins.sh +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -26,6 +26,7 @@ --name ${BUILD_TAG}-hnodeb -d \ $DOCKER_ARGS \ $REPO_USER/osmo-hnodeb-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-hnodeb "pidof osmo-hnodeb > /tmp/sut.pid" echo Starting container with HNodeB testsuite docker run --rm \ diff --git a/ttcn3-mgw-test/jenkins.sh b/ttcn3-mgw-test/jenkins.sh index f9d0133..98cdaec 100755 --- a/ttcn3-mgw-test/jenkins.sh +++ b/ttcn3-mgw-test/jenkins.sh @@ -26,6 +26,7 @@ --name ${BUILD_TAG}-mgw -d \ $DOCKER_ARGS \ $REPO_USER/osmo-mgw-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-mgw "pidof osmo-mgw > /tmp/sut.pid" # start docker container with testsuite in foreground docker run --rm \ diff --git a/ttcn3-msc-test/jenkins.sh b/ttcn3-msc-test/jenkins.sh index dd91e24..4927ae8 100755 --- a/ttcn3-msc-test/jenkins.sh +++ b/ttcn3-msc-test/jenkins.sh @@ -44,6 +44,7 @@ $DOCKER_ARGS \ $REPO_USER/osmo-msc-$IMAGE_SUFFIX \ /bin/sh -c "osmo-msc -c /data/osmo-msc.cfg >>/data/osmo-msc.log 2>&1" +docker exec ${BUILD_TAG}-msc "pidof osmo-msc > /tmp/sut.pid" echo Starting container with MSC testsuite docker run --rm \ diff --git a/ttcn3-pcu-test/jenkins.sh b/ttcn3-pcu-test/jenkins.sh index 11c77ad..a22d784 100755 --- a/ttcn3-pcu-test/jenkins.sh +++ b/ttcn3-pcu-test/jenkins.sh @@ -32,6 +32,7 @@ $DOCKER_ARGS \ $REPO_USER/osmo-pcu-$IMAGE_SUFFIX \ /bin/sh -c "/usr/local/bin/respawn.sh osmo-pcu -c /data/osmo-pcu.cfg -i 172.18.13.10 >>/data/osmo-pcu.log 2>&1" +docker exec ${BUILD_TAG}-pcu "pidof osmo-pcu > /tmp/sut.pid" echo Starting container with PCU testsuite docker run --rm \ diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh index df500af..b58b5d5 100755 --- a/ttcn3-sgsn-test/jenkins.sh +++ b/ttcn3-sgsn-test/jenkins.sh @@ -42,6 +42,7 @@ $DOCKER_ARGS \ $REPO_USER/osmo-sgsn-$IMAGE_SUFFIX \ /bin/sh -c "osmo-sgsn -c /data/osmo-sgsn.cfg >/data/osmo-sgsn.log 2>&1" +docker exec ${BUILD_TAG}-sgsn "pidof osmo-sgsn > /tmp/sut.pid" echo Starting container with SGSN testsuite docker run --rm \ diff --git a/ttcn3-sip-test/jenkins.sh b/ttcn3-sip-test/jenkins.sh index ffec3d2..10849a7 100755 --- a/ttcn3-sip-test/jenkins.sh +++ b/ttcn3-sip-test/jenkins.sh @@ -32,6 +32,7 @@ $DOCKER_ARGS \ $REPO_USER/osmo-sip-$IMAGE_SUFFIX \ /bin/sh -c "osmo-sip-connector -c /data/osmo-sip-connector.cfg >>/data/osmo-sip-connector.log 2>&1" +docker exec ${BUILD_TAG}-sip-connector "pidof osmo-sip-connector > /tmp/sut.pid" echo Starting container with SIP testsuite docker run --rm \ diff --git a/ttcn3-smlc-test/jenkins.sh b/ttcn3-smlc-test/jenkins.sh index f16536f..004c89a 100755 --- a/ttcn3-smlc-test/jenkins.sh +++ b/ttcn3-smlc-test/jenkins.sh @@ -40,6 +40,7 @@ --name ${BUILD_TAG}-smlc -d \ $DOCKER_ARGS \ $REPO_USER/osmo-smlc-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-smlc "pidof osmo-smlc > /tmp/sut.pid" echo Starting container with SMLC testsuite docker run --rm \ diff --git a/ttcn3-stp-test/jenkins.sh b/ttcn3-stp-test/jenkins.sh index db2ffdd..763fd15 100755 --- a/ttcn3-stp-test/jenkins.sh +++ b/ttcn3-stp-test/jenkins.sh @@ -26,6 +26,7 @@ --name ${BUILD_TAG}-stp -d \ $DOCKER_ARGS \ $REPO_USER/osmo-stp-$IMAGE_SUFFIX +docker exec ${BUILD_TAG}-stp "pidof osmo-stp > /tmp/sut.pid" echo Starting container with STP testsuite docker run --rm \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 22:00:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 22:00:22 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... libmsc: ran_iu_make_security_mode_command(): improve readability Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d --- M src/libmsc/ran_msg_iu.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/09/26409/1 diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 8ffdd93..6705ab8 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -375,13 +375,15 @@ static struct msgb *ran_iu_make_security_mode_command(struct osmo_fsm_inst *caller_fi, const struct ran_cipher_mode_command *cm) { + bool use_encryption = cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0); LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, IK=%s, CK=%s\n", osmo_hexdump_nospc(cm->vec->ik, 16), - cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? osmo_hexdump_nospc(cm->vec->ck, 16) : "NONE"); + use_encryption ? osmo_hexdump_nospc(cm->vec->ck, 16) : "NONE"); /* TODO: Do we need to check if the UE supports all of the algorithms and build an intersection like * in the case of A5? */ - return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? cm->vec->ck : NULL, + return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, + use_encryption ? cm->vec->ck : NULL, RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 22:00:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 22:00:23 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... libmsc: ran_iu_make_security_mode_command(): clarify UIA mask Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a --- M src/libmsc/ran_msg_iu.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/10/26410/1 diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 6705ab8..d604f89 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -384,7 +384,10 @@ * in the case of A5? */ return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, use_encryption ? cm->vec->ck : NULL, - RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask); + RANAP_KeyStatus_new, + /* TODO: make it configurable via the VTY? */ + (1 << OSMO_UTRAN_UIA1) | (1 << OSMO_UTRAN_UIA2), + cm->utran.uea_encryption_mask); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 22:36:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 22:36:39 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 to look at the new patch set (#2). Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... libmsc: ran_iu_make_security_mode_command(): clarify UIA mask Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a --- M src/libmsc/ran_msg_iu.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/10/26410/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 23:13:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 23:13:41 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() If a MO SMS gets successfully routed through SMPP, we return early in gsm340_rx_tpdu() and leak a chunk of type 'struct gsm_sms'. Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Fixes: [1] Ic34d398e0a850856e20380ae35e5c2ae5e3c539b Fixes: OS#5334 --- M src/libmsc/gsm_04_11.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/26411/1 diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 199fdc1..bd7cf1f 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -631,7 +631,8 @@ /* This SMS got routed through SMPP and we are waiting on the response. */ if (gsms->smpp.esme) { - return -EINPROGRESS; + rc = -EINPROGRESS; + goto out; } /* This SMS got routed through SMPP, but the configured ESME was -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Nov 28 23:19:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 28 Nov 2021 23:19:26 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c at 644 PS1, Line 644: if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER) Looks like we also have a memory leak here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 28 Nov 2021 23:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 02:24:27 2021 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Mon, 29 Nov 2021 02:24:27 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c at 644 PS1, Line 644: if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER) > Looks like we also have a memory leak here. Will you upload another patchset? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 02:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:00:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 09:00:35 +0000 Subject: Change in osmo-ci[master]: RFC: lint: annotate lines in gerrit In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: RFC: lint: annotate lines in gerrit ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Thanks, I think this is a good improvement. https://gerrit.osmocom.org/c/osmo-ci/+/26393/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/26393/1//COMMIT_MSG at 13 PS1, Line 13: The jenkins nodes needs to access the gerrit via ssh > I would expect one can createa gerrit user that has permission only to provide review and thereby limit the potential damage. Yes, I would recommend this even if we can ensure that only reviewed osmo-ci.git code gets ssh access. > the gerrit-lint isn't a problem to give ssh access since it will only execute reviewed code from osmo-ci. So we could just add ssh-key to jenkins and enable ssh-agent in jenkins. Currently there's an exception: when modifying osmo-ci.git, the linter code gets executed from the repository state submitted to gerrit: https://git.osmocom.org/osmo-ci/tree/jobs/gerrit-lint.yml?id=cccd0cdd084a68b67d22a903540d4a699ac376db#n32 So that needs to be removed. Probably best to remove the "cmd" variable from https://git.osmocom.org/osmo-ci/tree/jobs/gerrit-lint.yml?id=cccd0cdd084a68b67d22a903540d4a699ac376db#n8 to avoid setting another cmd in the future that points to the repository modified in gerrit, without thinking about ssh access the script would get. I suggest we put cmd here instead https://git.osmocom.org/osmo-ci/tree/jobs/gerrit-lint.yml?id=cccd0cdd084a68b67d22a903540d4a699ac376db#n90 so it cannot be overridden per project. https://gerrit.osmocom.org/c/osmo-ci/+/26393/1/lint/lint_diff.sh File lint/lint_diff.sh: https://gerrit.osmocom.org/c/osmo-ci/+/26393/1/lint/lint_diff.sh at 34 PS1, Line 34: if ! git diff -U0 "$COMMIT" | "$SCRIPT_DIR/checkpatch/checkpatch_osmo.sh" > gerrit_report ; then This condition doesn't need to check if errors were found or not, because above it does "exit 0" if there are no errors. But this should not run by default, only if sending comments to gerrit is explicitly enabled. So it does not run if used locally as git pre-commit hook. I suggest changing this to: if [ -n "$GERRIT_COMMENT" ]; then git diff -U0 "$COMMIT" | "$SCRIPT_DIR/checkpatch/checkpatch_osmo.sh" > gerrit_report And in jobs/gerrit-lint.yml, add GERRIT_COMMENT=1 before calling lint_diff.sh here: https://git.osmocom.org/osmo-ci/tree/jobs/gerrit-lint.yml?id=cccd0cdd084a68b67d22a903540d4a699ac376db#n8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 29 Nov 2021 09:00:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:03:13 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 09:03:13 +0000 Subject: Change in osmo-msc[master]: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26403 ) Change subject: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I95636a7713cd90956e46a5b6f8f7ded3bf4f5f0a Gerrit-Change-Number: 26403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 29 Nov 2021 09:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:37:02 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 09:37:02 +0000 Subject: Change in docker-playground[master]: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/26408/1/ttcn3-bsc-test/jenkins.sh File ttcn3-bsc-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/26408/1/ttcn3-bsc-test/jenkins.sh at 46 PS1, Line 46: docker exec ${BUILD_TAG}-bsc "pidof osmo-bsc > /tmp/sut.pid" Doesn't work for me: + docker exec nonjenkins-bsc pidof osmo-bsc > /tmp/sut.pid OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: exec: "pidof osmo-bsc > /tmp/sut.pid": stat pidof osmo-bsc > /tmp/sut.pid: no such file or directory: unknown Because of "set -e" we do above, the script calls the clean up hook and exits here. I think this is a race condition, osmo-bsc may not have started at this point? However, the SUT runs in a different docker container than the testsuite. It uses a different pid namespace, so ttcn3-tcpdump-stop.sh can't run "kill -s USR1". At least in my setup it doesn't work, osmo-bsc has pid 7 in its own container, and then running in the testsuite docker container: $ kill -s USR1 7 bash: kill: (7) - No such process Maybe an alternative approach could be to get the talloc report via ttcn-3 + CTRL/VTY port right before closing that connection at the end of the test, and print it there / write it to a file with the test name? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 29 Nov 2021 09:37:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:39:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:39:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnectionHandler: refactor and split f_mm_common() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 ) Change subject: msc/BSC_ConnectionHandler: refactor and split f_mm_common() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Gerrit-Change-Number: 26404 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:39:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:41:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:41:19 +0000 Subject: Change in osmo-msc[master]: libvlr: vlr_set_ciph_mode(): avoid redundant check In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26405 ) Change subject: libvlr: vlr_set_ciph_mode(): avoid redundant check ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I900ddd5f1882f8cee234ab1074adcf25830a092c Gerrit-Change-Number: 26405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:41:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:45:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:45:01 +0000 Subject: Change in osmo-msc[master]: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26406 ) Change subject: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26406/1/src/libvlr/vlr_access_req_fsm.c File src/libvlr/vlr_access_req_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/26406/1/src/libvlr/vlr_access_req_fsm.c at 273 PS1, Line 273: /* UTRAN: always send SecModeCmd, even if ciphering is not required. maybe some spec reference or explanation here on why is always sent on UTRAN. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6205f13453eff7afbf25e013d72ae98a78fcd31b Gerrit-Change-Number: 26406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:45:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:48:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:48:46 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 ) Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report ...................................................................... Patch Set 1: I'm not really convinced about this: * You assume any program we run will have a talloc report on USR1 * I don't think it's necessary to print it by default each time, specially when not looking into it, since it adds stuff to the output (potentially long) which I'm not interested in and may cause confusion thinking some stuff crashed or similar. So I'm fine with having it conditionally enabled by some param, or simply have it there commented out, so that if someone wants to check it cans simply uncomment those. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Gerrit-Change-Number: 26407 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:49:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 09:49:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo_is() In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 to look at the new patch set (#4). Change subject: library/Misc_Helpers: add f_osmo_repo_is() ...................................................................... library/Misc_Helpers: add f_osmo_repo_is() Create functions to check which from Osmocom repository the SUT is running. Put it in Misc_Helpers instead of a new library file since Misc_Helpers is already available in many/all? tests and it fits there too. Depends: docker-playground Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Related: OS#5327 Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 --- M library/Misc_Helpers.ttcn 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/26386/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:49:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 09:49:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 to look at the new patch set (#4). Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... BSC_Tests: TC_paging_counter: add bsc pag expired Test the new bsc.N.paging:expired stat in TC_paging_counter too. Depends: osmo-bsc I9c118e7e3d61ed8c9f1951111255b196905eba4d Related: SYS#4878 Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/26387/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:49:44 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 09:49:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo_is() In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_osmo_repo_is() ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/3/library/Misc_Helpers.ttcn File library/Misc_Helpers.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386/3/library/Misc_Helpers.ttcn at 16 PS3, Line 16: function f_osmo_repo(template charstring ver) return boolean { > f_osmo_repo_is() [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:49:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:49:45 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c at 386 PS1, Line 386: use_encryption ? cm->vec->ck : NULL, you can move this to the upper line. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:49:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:52:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:52:08 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 390 PS2, Line 390: (uia_mask << 1), /* API treats LSB as UIA0 */ I indeed see that OSMO_UTRAN_UIA1 is 0, but this all looks really weird and confusing. Probably no easy way to fix it now though. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:54:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:54:30 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c at 633 PS1, Line 633: if (gsms->smpp.esme) { Are you sure it is leaked if it got routed? It could be that the sms is added to some wqueue or similar. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:55:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:55:34 +0000 Subject: Change in osmo-msc[master]: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26403 ) Change subject: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I95636a7713cd90956e46a5b6f8f7ded3bf4f5f0a Gerrit-Change-Number: 26403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:55:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 09:56:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 09:56:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo_is() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_osmo_repo_is() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 09:56:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:07:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 10:07:28 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Nov 2021 10:07:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:28:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 10:28:17 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 to look at the new patch set (#2). Change subject: stats: add bsc.paging:expired ...................................................................... stats: add bsc.paging:expired Similar to paging:attempted, count paging:expired not only per BTS, but also for the whole BSC. Add active_paging_requests to struct bsc_subscr, to increase the counter only once if paging expires, and not once per BTS where paging expired. Related: SYS#4878 Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bsc_subscriber.h M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/paging.c 4 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/26384/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:29:18 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 10:29:18 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 2: > > Should work as well. What's the advantage over the approach in the current patch? > > Not having an extra timer made up of several timers for each paging in process. Done. This is much simpler now, thanks :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 10:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:29:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 10:29:26 +0000 Subject: Change in osmo-hnodeb[master]: WIP: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: WIP: Initial implementation of LowerLayer UD Socket ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Nov 2021 10:29:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:29:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 10:29:29 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#4). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTp-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/nas.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_ctl.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/nas.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 22 files changed, 1,507 insertions(+), 83 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:32:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 10:32:18 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26384/2/src/osmo-bsc/paging.c File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26384/2/src/osmo-bsc/paging.c at 288 PS2, Line 288: if (req->bsub->active_paging_requests == 1) Worth adding a comment: /* If last BTS paging times out (active_paging_requests will be decremented in paging_remove_request below): */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 10:32:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:33:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 10:33:39 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 to look at the new patch set (#3). Change subject: stats: add bsc.paging:expired ...................................................................... stats: add bsc.paging:expired Similar to paging:attempted, count paging:expired not only per BTS, but also for the whole BSC. Add active_paging_requests to struct bsc_subscr, to increase the counter only once if paging expires, and not once per BTS where paging expired. Related: SYS#4878 Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bsc_subscriber.h M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/paging.c 4 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/26384/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:33:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 10:33:58 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 10:33:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:47:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 10:47:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 to look at the new patch set (#3). Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... hnodeb: Add initial infra to emulate HNB LL socket iface Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.default M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh A library/HNBLLIF_CodecPort.ttcn A library/HNBLLIF_Templates.ttcn A library/HNBLLIF_Types.ttcn M library/Iuh_CodecPort.ttcn M library/rua/RUA_Templates.ttcn 10 files changed, 965 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/26373/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 10:54:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 10:54:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 to look at the new patch set (#4). Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... hnodeb: Add initial infra to emulate HNB LL socket iface Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.default M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh A library/HNBLLIF_CodecPort.ttcn A library/HNBLLIF_Templates.ttcn A library/HNBLLIF_Types.ttcn M library/Iuh_CodecPort.ttcn M library/rua/RUA_Templates.ttcn 10 files changed, 964 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/26373/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 11:56:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 11:56:22 +0000 Subject: Change in docker-playground[master]: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-*-test/jenkins.sh: write the SUT's PID to /tmp/sut.pid ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/26408/1/ttcn3-bsc-test/jenkins.sh File ttcn3-bsc-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/26408/1/ttcn3-bsc-test/jenkins.sh at 46 PS1, Line 46: docker exec ${BUILD_TAG}-bsc "pidof osmo-bsc > /tmp/sut.pid" Hey Oliver, thanks for your feedback! I haven't tested this patch yet, it's more like a proposal (forgot to make it WIP). > exec: "pidof osmo-bsc > /tmp/sut.pid": stat pidof osmo-bsc > /tmp/sut.pid: no such file or directory: unknown Ah, for some reason Docker treats the command as a file, because of the quotes. If I remove them, it seems to work. > I think this is a race condition, osmo-bsc may not have started at this point? Could be the case, but then pidof would simply return nothing. > However, the SUT runs in a different docker container than the testsuite. It uses a different pid namespace, so ttcn3-tcpdump-stop.sh can't run "kill -s USR1". At least in my setup it doesn't work, osmo-bsc has pid 7 in its own container, and then running in the testsuite docker container: Good point. This renders the current approach wrong. > Maybe an alternative approach could be to get the talloc report via ttcn-3 + CTRL/VTY port right before closing that connection at the end of the test, and print it there / write it to a file with the test name? Yep, I am also thinking of this approach. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 29 Nov 2021 11:56:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 11:56:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 11:56:42 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#5). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_ctl.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 20 files changed, 1,499 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 11:56:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 11:56:43 +0000 Subject: Change in osmo-hnodeb[master]: Drop NAS and RANAP code and VTY commands References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 ) Change subject: Drop NAS and RANAP code and VTY commands ...................................................................... Drop NAS and RANAP code and VTY commands The higher level bits were used in originally imported hnb-test code in order to control interaction with the HNBGW over the VTY. This is no longer needed in osmo-hnodeb, as NAS is in layers above the ones being handled by an hNodeB. Regarding RANAP, most if it is going to be handled by the LowerLayer UD socket peer to be introduced in the future, so we can drop most of it, as in osmo-hnodeb we'll basically be speaking RUA to the HNBGW and passing RANAP buffers transparently. We keep the .c/.h files since some small helpers functions will be ntroduced later on when adding support for the mentioned LL socket. Related: SYS#5516 Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 --- M include/osmocom/hnodeb/Makefile.am D include/osmocom/hnodeb/nas.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c D src/osmo-hnodeb/nas.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 11 files changed, 2 insertions(+), 549 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/12/26412/1 diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index b1acb7e..6fa587d 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -3,7 +3,6 @@ hnbap.h \ hnodeb.h \ iuh.h \ - nas.h \ ranap.h \ rua.h \ vty.h \ diff --git a/include/osmocom/hnodeb/nas.h b/include/osmocom/hnodeb/nas.h deleted file mode 100644 index f6a7976..0000000 --- a/include/osmocom/hnodeb/nas.h +++ /dev/null @@ -1,24 +0,0 @@ -/* (C) 2015 by Daniel Willmann - * (C) 2021 by sysmocom - s.f.m.c. GmbH - * Author: Pau Espin Pedrol - * All Rights Reserved - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#pragma once - -struct hnb; -void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len); diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h index 15e0609..474de70 100644 --- a/include/osmocom/hnodeb/ranap.h +++ b/include/osmocom/hnodeb/ranap.h @@ -19,15 +19,4 @@ */ #pragma once -struct hnb; -struct ranap_message_s; -#include -void hnb_rx_iu_release(struct hnb *hnb); -void hnb_rx_paging(struct hnb *hnb, const char *imsi); -void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); - -void hnb_rua_dt_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg); -void hnb_rua_cl_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg); -void hnb_tx_iu_release_req(struct hnb *hnb); -struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi); diff --git a/include/osmocom/hnodeb/rua.h b/include/osmocom/hnodeb/rua.h index 52221be..ea7e81c 100644 --- a/include/osmocom/hnodeb/rua.h +++ b/include/osmocom/hnodeb/rua.h @@ -25,4 +25,3 @@ struct msgb; int hnb_rua_rx(struct hnb *hnb, struct msgb *msg); -int hnb_tx_dt(struct hnb *hnb, struct msgb *txm); diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h index 7144d3f..e30019e 100644 --- a/include/osmocom/hnodeb/vty.h +++ b/include/osmocom/hnodeb/vty.h @@ -27,7 +27,6 @@ enum hnb_vty_nodes { HNODEB_NODE = _LAST_OSMOVTY_NODE, IUH_NODE, - CHAN_NODE, }; void hnb_vty_init(void); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 7325728..82ccd37 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -35,7 +35,6 @@ hnb.c \ hnb_shutdown_fsm.c \ iuh.c \ - nas.c \ ranap.c \ rua.c \ vty.c \ diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index 10d1655..45ccc0c 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -47,11 +47,6 @@ .color = "\033[1;36m", .description = "SCTP connection on the Iuh link", }, - [DNAS] = { - .name = "NAS", .loglevel = LOGL_NOTICE, .enabled = 1, - .color = "\033[1;32m", - .description = "Non-Access Stratum", - }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/nas.c b/src/osmo-hnodeb/nas.c deleted file mode 100644 index 293c46e..0000000 --- a/src/osmo-hnodeb/nas.c +++ /dev/null @@ -1,268 +0,0 @@ -/* (C) 2015 by Daniel Willmann - * (C) 2021 by sysmocom - s.f.m.c. GmbH - * Author: Pau Espin Pedrol - * All Rights Reserved - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#include "config.h" - -#include -#include -#include - -#include -#include -#include -#include -#include - -#include - -#include -#include -#include -#include - -static struct msgb *gen_nas_id_resp() -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - GSM48_MT_MM_ID_RESP, - /* IMEISV */ - 0x09, /* len */ - 0x03, /* first digit (0000) + even (0) + id IMEISV (011) */ - 0x31, 0x91, 0x06, 0x00, 0x28, 0x47, 0x11, /* digits */ - 0xf2, /* filler (1111) + last digit (0010) */ - }; - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct msgb *gen_nas_tmsi_realloc_compl() -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - GSM48_MT_MM_TMSI_REALL_COMPL, - }; - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct msgb *gen_nas_auth_resp(uint8_t *sres) -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - 0x80 | GSM48_MT_MM_AUTH_RESP, /* simulate sequence nr 2 */ - 0x61, 0xb5, 0x69, 0xf5 /* hardcoded SRES */ - }; - - memcpy(id_resp + 2, sres, 4); - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct tlv_parsed *parse_mm(struct gsm48_hdr *gh, int len) -{ - static struct tlv_parsed tp; - int parse_res; - - len -= (const char *)&gh->data[0] - (const char *)gh; - - OSMO_ASSERT(gsm48_hdr_pdisc(gh) == GSM48_PDISC_MM); - - parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); - if (parse_res <= 0) { - uint8_t msg_type = gsm48_hdr_msg_type(gh); - LOGP(DNAS, LOGL_ERROR, "Error parsing MM message 0x%hhx: %d\n", msg_type, parse_res); - return NULL; - } - - return &tp; -} - -int hnb_nas_rx_lu_accept(struct gsm48_hdr *gh, int len, int *sent_tmsi) -{ - LOGP(DNAS, LOGL_INFO, " :D Location Update Accept :D\n"); - struct gsm48_loc_area_id *lai; - - lai = (struct gsm48_loc_area_id *)&gh->data[0]; - - struct osmo_location_area_id laid; - gsm48_decode_lai2(lai, &laid); - LOGP(DNAS, LOGL_INFO, "LU: mcc %s mnc %s lac %hd\n", - osmo_mcc_name(laid.plmn.mcc), osmo_mnc_name(laid.plmn.mnc, laid.plmn.mnc_3_digits), - laid.lac); - - struct tlv_parsed tp; - int parse_res; - - len -= (const char *)&gh->data[0] - (const char *)gh; - parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); - if (parse_res <= 0) { - LOGP(DNAS, LOGL_ERROR, "Error parsing Location Update Accept message: %d\n", parse_res); - return -1; - } - - if (TLVP_PRESENT(&tp, GSM48_IE_MOBILE_ID)) { - uint8_t type = TLVP_VAL(&tp, GSM48_IE_NAME_SHORT)[0] & 0x0f; - if (type == GSM_MI_TYPE_TMSI) - *sent_tmsi = 1; - else *sent_tmsi = 0; - } - return 0; -} - -void hnb_nas_rx_mm_info(struct gsm48_hdr *gh, int len) -{ - LOGP(DNAS, LOGL_INFO, " :) MM Info :)\n"); - struct tlv_parsed *tp = parse_mm(gh, len); - if (!tp) - return; - - if (TLVP_PRESENT(tp, GSM48_IE_NAME_SHORT)) { - char name[128] = {0}; - gsm_7bit_decode_n(name, 127, - TLVP_VAL(tp, GSM48_IE_NAME_SHORT)+1, - (TLVP_LEN(tp, GSM48_IE_NAME_SHORT)-1)*8/7); - LOGP(DNAS, LOGL_INFO, "Info: Short Network Name: %s\n", name); - } - - if (TLVP_PRESENT(tp, GSM48_IE_NAME_LONG)) { - char name[128] = {0}; - gsm_7bit_decode_n(name, 127, - TLVP_VAL(tp, GSM48_IE_NAME_LONG)+1, - (TLVP_LEN(tp, GSM48_IE_NAME_LONG)-1)*8/7); - LOGP(DNAS, LOGL_INFO, "Info: Long Network Name: %s\n", name); - } -} - -static int hnb_nas_rx_auth_req(struct hnb *hnb, struct gsm48_hdr *gh, - int len) -{ - struct gsm48_auth_req *ar; - - len -= (const char *)&gh->data[0] - (const char *)gh; - - if (len < sizeof(*ar)) { - LOGP(DNAS, LOGL_ERROR, "GSM48 Auth Req does not fit.\n"); - return -1; - } - - LOGP(DNAS, LOGL_INFO, " :) Authentication Request :)\n"); - - ar = (struct gsm48_auth_req*) &gh->data[0]; - int seq = ar->key_seq; - - /* Generate SRES from *HARDCODED* Ki for Iuh testing */ - struct osmo_auth_vector vec; - /* Ki 000102030405060708090a0b0c0d0e0f */ - struct osmo_sub_auth_data auth = { - .type = OSMO_AUTH_TYPE_GSM, - .algo = OSMO_AUTH_ALG_COMP128v1, - .u.gsm.ki = { - 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, - 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, - 0x0e, 0x0f - }, - }; - - memset(&vec, 0, sizeof(vec)); - osmo_auth_gen_vec(&vec, &auth, ar->rand); - - LOGP(DNAS, LOGL_DEBUG, "seq %d rand %s", - seq, osmo_hexdump(ar->rand, sizeof(ar->rand))); - LOGP(DNAS, LOGL_DEBUG, " --> sres %s\n", - osmo_hexdump(vec.sres, 4)); - - return hnb_tx_dt(hnb, gen_nas_auth_resp(vec.sres)); -} - -static int hnb_nas_rx_mm(struct hnb *hnb, struct gsm48_hdr *gh, int len) -{ - struct hnb_chan *chan; - - chan = hnb->cs.chan; - if (!chan) { - LOGP(DNAS, LOGL_ERROR, "hnb_nas_rx_mm(): No CS channel established yet.\n"); - return -1; - } - - OSMO_ASSERT(!chan->is_ps); - - uint8_t msg_type = gsm48_hdr_msg_type(gh); - int sent_tmsi; - - switch (msg_type) { - case GSM48_MT_MM_ID_REQ: - return hnb_tx_dt(hnb, gen_nas_id_resp()); - - case GSM48_MT_MM_LOC_UPD_ACCEPT: - if (hnb_nas_rx_lu_accept(gh, len, &sent_tmsi)) - return -1; - if (sent_tmsi) - return hnb_tx_dt(hnb, gen_nas_tmsi_realloc_compl()); - else - return 0; - - case GSM48_MT_MM_LOC_UPD_REJECT: - LOGP(DNAS, LOGL_INFO, "Received Location Update Reject\n"); - return 0; - - case GSM48_MT_MM_INFO: - hnb_nas_rx_mm_info(gh, len); - hnb_tx_iu_release_req(hnb); - return 0; - - case GSM48_MT_MM_AUTH_REQ: - return hnb_nas_rx_auth_req(hnb, gh, len); - - default: - LOGP(DNAS, LOGL_INFO, "04.08 message type not handled by hnb-test: 0x%x\n", - msg_type); - return 0; - } - -} - -void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len) -{ - int rc; - LOGP(DNAS, LOGL_INFO, "got %d bytes: %s\n", len, osmo_hexdump(data, len)); - - // nas_pdu == '05 08 12' ==> IMEI Identity request - // '05 04 0d' ==> LU reject - - struct gsm48_hdr *gh = data; - if (len < sizeof(*gh)) { - LOGP(DNAS, LOGL_ERROR, "hnb_nas_rx_dtap(): NAS PDU is too short: %d. Ignoring.\n", - len); - return; - } - uint8_t pdisc = gsm48_hdr_pdisc(gh); - - switch (pdisc) { - case GSM48_PDISC_MM: - rc = hnb_nas_rx_mm(hnb, gh, len); - if (rc != 0) - LOGP(DNAS, LOGL_ERROR, "Error receiving MM message: %d\n", rc); - return; - default: - LOGP(DNAS, LOGL_NOTICE, "04.08 discriminator not handled by hnb-test: %d\n", - pdisc); - return; - } -} diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c index b5b7b9c..99c4bab 100644 --- a/src/osmo-hnodeb/ranap.c +++ b/src/osmo-hnodeb/ranap.c @@ -25,152 +25,5 @@ #include #include -#include #include #include - -static const char *printstr(OCTET_STRING_t *s) -{ - return osmo_hexdump((const unsigned char*)s->buf, s->size); -} - -#define PP(octet_string_t) \ - LOGP(DRANAP, LOGL_INFO, #octet_string_t " = %s\n",\ - printstr(&octet_string_t)) - -void hnb_rua_dt_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg) -{ - struct hnb *hnb = (struct hnb *)ctx; - int len; - uint8_t *data; - RANAP_PermittedIntegrityProtectionAlgorithms_t *algs; - RANAP_IntegrityProtectionAlgorithm_t *first_alg; - - LOGP(DRANAP, LOGL_INFO, "rx ranap_msg->procedureCode %d\n", - ranap_msg->procedureCode); - - switch (ranap_msg->procedureCode) { - case RANAP_ProcedureCode_id_DirectTransfer: - LOGP(DRANAP, LOGL_INFO, "rx DirectTransfer: presence = %hx\n", - ranap_msg->msg.directTransferIEs.presenceMask); - PP(ranap_msg->msg.directTransferIEs.nas_pdu); - - len = ranap_msg->msg.directTransferIEs.nas_pdu.size; - data = ranap_msg->msg.directTransferIEs.nas_pdu.buf; - - hnb_nas_rx_dtap(hnb, data, len); - return; - - case RANAP_ProcedureCode_id_SecurityModeControl: - LOGP(DRANAP, LOGL_INFO, "rx SecurityModeControl: presence = %hx\n", - ranap_msg->msg.securityModeCommandIEs.presenceMask); - - /* Just pick the first available IP alg, don't care about - * encryption (yet?) */ - algs = &ranap_msg->msg.securityModeCommandIEs.integrityProtectionInformation.permittedAlgorithms; - if (algs->list.count < 1) { - LOGP(DRANAP, LOGL_INFO, "Security Mode Command: No permitted algorithms.\n"); - return; - } - first_alg = *algs->list.array; - - hnb_rx_secmode_cmd(hnb, *first_alg); - return; - - case RANAP_ProcedureCode_id_Iu_Release: - hnb_rx_iu_release(hnb); - return; - } -} - -void hnb_rua_cl_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg) -{ - struct hnb *hnb = (struct hnb *)ctx; - char imsi[16]; - - LOGP(DRANAP, LOGL_INFO, "rx ranap_msg->procedureCode %d\n", - ranap_msg->procedureCode); - - switch (ranap_msg->procedureCode) { - case RANAP_ProcedureCode_id_Paging: - if (ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.present == RANAP_PermanentNAS_UE_ID_PR_iMSI) { - ranap_bcd_decode(imsi, sizeof(imsi), - ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.choice.iMSI.buf, - ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.choice.iMSI.size); - } else imsi[0] = '\0'; - - LOGP(DRANAP, LOGL_INFO, "rx Paging: presence=%hx domain=%ld IMSI=%s\n", - ranap_msg->msg.pagingIEs.presenceMask, - ranap_msg->msg.pagingIEs.cN_DomainIndicator, - imsi - ); - - hnb_rx_paging(hnb, imsi); - return; - } -} - -struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi) -{ - uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST, - 0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57, - /* len, IMSI/type, IMSI-------------------------------- */ - 0x08, 0x29, 0x26, 0x24, 0x10, 0x32, 0x54, 0x76, 0x98, - 0x33, 0x03, 0x57, 0x18 , 0xb2 }; - uint8_t plmn_id[3]; - osmo_plmn_to_bcd(plmn_id, &hnb->plmn); - RANAP_GlobalRNC_ID_t rnc_id = { - .rNC_ID = g_hnb->rnc_id, - .pLMNidentity.buf = plmn_id, - .pLMNidentity.size = sizeof(plmn_id), - }; - - /* FIXME: patch imsi */ - /* Note: the Mobile Identitiy IE's IMSI data has the identity type and - * an even/odd indicator bit encoded in the first octet. So the first - * octet looks like this: - * - * 8 7 6 5 | 4 | 3 2 1 - * IMSI-digit | even/odd | type - * - * followed by the remaining IMSI digits. - * If digit count is even (bit 4 == 0), that first high-nibble is 0xf. - * (derived from Iu pcap Location Update Request msg and TS 25.413) - * - * TODO I'm only 90% sure about this - */ - - return ranap_new_msg_initial_ue(conn_id, is_ps, &rnc_id, lu, sizeof(lu)); -} - -void hnb_tx_iu_release_req(struct hnb *hnb) -{ - RANAP_Cause_t cause = { - .present = RANAP_Cause_PR_radioNetwork, - .choice.transmissionNetwork = RANAP_CauseRadioNetwork_release_due_to_UE_generated_signalling_connection_release, - }; - hnb_tx_dt(hnb, ranap_new_msg_iu_rel_req(&cause)); -} - -void hnb_tx_iu_release_compl(struct hnb *hnb) -{ - hnb_tx_dt(hnb, ranap_new_msg_iu_rel_compl()); -} - -void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg) -{ - LOGP(DRANAP, LOGL_INFO, " :) Security Mode Command :)\n"); - /* not caring about encryption yet, just pass 0 for No Encryption. */ - hnb_tx_dt(hnb, ranap_new_msg_sec_mod_compl(ip_alg, 0)); -} - -void hnb_rx_iu_release(struct hnb *hnb) -{ - hnb_tx_iu_release_compl(hnb); -} - -void hnb_rx_paging(struct hnb *hnb, const char *imsi) -{ - LOGP(DRANAP, LOGL_INFO, " :) Paging Request for %s :)\n", imsi); - /* TODO reply */ -} diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 907cd60..9bf5403 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -21,6 +21,7 @@ #include #include +#include #include #include @@ -29,22 +30,7 @@ #include #include #include - -int hnb_tx_dt(struct hnb *hnb, struct msgb *txm) -{ - struct hnb_chan *chan; - struct msgb *rua; - - chan = hnb->cs.chan; - if (!chan) { - LOGP(DRUA, LOGL_INFO, "hnb_nas_tx_tmsi_realloc_compl(): No CS channel established yet.\n"); - return -1; - } - - rua = rua_new_dt(chan->is_ps, chan->conn_id, txm); - hnb_iuh_send(hnb, rua); - return 0; -} +#include static void hnb_rua_dt_handle(struct hnb *hnb, ANY_t *in) { @@ -57,7 +43,6 @@ return; } - rc = ranap_cn_rx_co(hnb_rua_dt_handle_ranap, hnb, ies.ranaP_Message.buf, ies.ranaP_Message.size); /* FIXME: what to do with the asn1c-allocated memory */ rua_free_directtransferies(&ies); @@ -74,7 +59,6 @@ return; } - rc = ranap_cn_rx_cl(hnb_rua_cl_handle_ranap, hnb, ies.ranaP_Message.buf, ies.ranaP_Message.size); /* FIXME: what to do with the asn1c-allocated memory */ rua_free_connectionlesstransferies(&ies); diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index e11fc2d..93ec25f 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -270,41 +270,9 @@ } -static struct cmd_node chan_node = { - CHAN_NODE, - "%s(chan)> ", - 1, -}; - -#define HNBAP_STR "HNBAP related commands\n" -#define HNB_STR "HomeNodeB commands\n" -#define UE_STR "User Equipment commands\n" #define RANAP_STR "RANAP related commands\n" #define CSPS_STR "Circuit Switched\n" "Packet Switched\n" -DEFUN(hnb_register, hnb_register_cmd, - "hnbap hnb register", HNBAP_STR HNB_STR "Send HNB-REGISTER REQUEST") -{ - hnb_send_register_req(g_hnb); - - return CMD_SUCCESS; -} - -DEFUN(hnb_deregister, hnb_deregister_cmd, - "hnbap hnb deregister", HNBAP_STR HNB_STR "Send HNB-DEREGISTER REQUEST") -{ - hnb_send_deregister_req(g_hnb); - - return CMD_SUCCESS; -} - -DEFUN(ue_register, ue_register_cmd, - "hnbap ue register IMSI", HNBAP_STR UE_STR "Send UE-REGISTER REQUEST") -{ - hnb_ue_register_tx(g_hnb, argv[0]); - - return CMD_SUCCESS; -} DEFUN(asn_dbg, asn_dbg_cmd, "asn-debug (1|0)", "Enable or disable libasn1c debugging") @@ -336,40 +304,6 @@ return CMD_SUCCESS; } -DEFUN(chan, chan_cmd, - "channel (cs|ps) lu imsi IMSI", - "Open a new Signalling Connection\n" - "To Circuit-Switched CN\n" - "To Packet-Switched CN\n" - "Performing a Location Update\n" - ) -{ - struct hnb_chan *chan; - struct msgb *msg, *rua; - static uint16_t conn_id = 42; - - chan = talloc_zero(tall_hnb_ctx, struct hnb_chan); - if (!strcmp(argv[0], "ps")) - chan->is_ps = 1; - chan->imsi = talloc_strdup(chan, argv[1]); - chan->conn_id = conn_id; - conn_id++; - - msg = gen_initue_lu(g_hnb, chan->is_ps, chan->conn_id, chan->imsi); - rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); - - hnb_iuh_send(g_hnb, rua); - - vty->index = chan; - vty->node = CHAN_NODE; - - if (!chan->is_ps) - g_hnb->cs.chan = chan; - - - return CMD_SUCCESS; -} - void hnb_vty_init(void) { install_element(CONFIG_NODE, &cfg_hnodeb_cmd); @@ -389,11 +323,5 @@ install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_port_cmd); install_element_ve(&asn_dbg_cmd); - install_element_ve(&hnb_register_cmd); - install_element_ve(&hnb_deregister_cmd); - install_element_ve(&ue_register_cmd); install_element_ve(&ranap_reset_cmd); - install_element_ve(&chan_cmd); - - install_node(&chan_node, NULL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 Gerrit-Change-Number: 26412 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:00:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:00:22 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c at 386 PS1, Line 386: use_encryption ? cm->vec->ck : NULL, > you can move this to the upper line. I specifically want each argument to be on its own line. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:13:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 12:13:42 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c at 386 PS1, Line 386: use_encryption ? cm->vec->ck : NULL, > I specifically want each argument to be on its own line. you mean this argument, because the ones below don't, that's why I'm saying :P -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:13:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:36:25 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 12:36:25 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c at 1349 PS1, Line 1349: rxlev2dbm(mrc->rxlev) > RXLEV is the GSM mnemonic for a value that is not normalized to 0 dBm but to -110 dBm. [?] in handover configuration, logging and vty outputs, we consistently use the term "RXLEV" and usually print the negative dBm value (based on -110dBm), indicated by adding a "dBm" unit in the printout. In some places we may still print the actual on-the-wire rxlev value (0..63); this is also used in handover tests (that we got from jolly). I'm not familiar with the term RSSI, but from what i found it seems to be the correct term for that negative dBm representation. But, we use "rxlev" as label everywhere in osmo-bsc, and either we stick with that here, or we change all of osmo-bsc to use "rssi" instead, including VTY commands -- i do not see us doing that. The discussion on this trivial patch goes a bit out of proportion, should we just abandon this? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Nov 2021 12:36:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:37:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:37:52 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 390 PS2, Line 390: (uia_mask << 1), /* API treats LSB as UIA0 */ > I indeed see that OSMO_UTRAN_UIA1 is 0, but this all looks really weird and confusing. [?] OSMO_UTRAN_UIA1 is 0 because 3GPP TS 25.413 ? 9.2.1.11 defines it this way. I also don't like this inconsistency, but AFAICS there is no UIA0 in the specs. We can actually fix OSMO_UTRAN_UIA{1,2} definitions in libosmocore because they were introduced recently and this is gonna be the first place in the code base using them. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:39:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:39:04 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26409/1/src/libmsc/ran_msg_iu.c at 386 PS1, Line 386: use_encryption ? cm->vec->ck : NULL, > you mean this argument, because the ones below don't, that's why I'm saying :P This is done in the next change. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:39:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:46:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:46:24 +0000 Subject: Change in osmo-msc[master]: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26413 ) Change subject: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7 Fixes: I2c50904349dd4ed229b60b8468d776b817c0bd44 --- M src/libmsc/gsm_04_11.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/13/26413/1 diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index bd7cf1f..722973e 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -642,7 +642,7 @@ * attempt re-submission to the ESME) */ if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER) - return rc; + goto out; /* free() the message */ /* * This SMS got routed through SMPP or no receiver exists. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7 Gerrit-Change-Number: 26413 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:46:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:46:46 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c at 633 PS1, Line 633: if (gsms->smpp.esme) { > Are you sure it is leaked if it got routed? It could be that the sms is added to some wqueue or simi [?] Nope, I spent quite some time checking the code branches. The given 'gsms' is merely used to compose an SMPP message, but never gets free()d or queued. And actually we did free() it before Ic34d398e0a850856e20380ae35e5c2ae5e3c539b was merged. https://gerrit.osmocom.org/c/osmo-msc/+/26411/1/src/libmsc/gsm_04_11.c at 644 PS1, Line 644: if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER) > Will you upload another patchset? https://gerrit.osmocom.org/c/osmo-msc/+/26413 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:46:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:47:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:47:35 +0000 Subject: Change in osmo-msc[master]: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26403 ) Change subject: VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd ...................................................................... VTY: clarify deprecation message for cfg_net_per_loc_upd_cmd Change-Id: I95636a7713cd90956e46a5b6f8f7ded3bf4f5f0a --- M src/libmsc/msc_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 6be09d8..4dd834b 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -297,8 +297,8 @@ int minutes = atoi(argv[0]); int rc; - vty_out(vty, "%% 'periodic location update' is now deprecated: " - "use 'timer T3212' to change subscriber expiration " + vty_out(vty, "%% 'periodic location update' is now deprecated. " + "Use 'msc' / 'timer vlr T3212' to change subscriber expiration " "timeout.%s", VTY_NEWLINE); /* We used to double this value and add a minute when scheduling the -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I95636a7713cd90956e46a5b6f8f7ded3bf4f5f0a Gerrit-Change-Number: 26403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:48:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:48:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo_is() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_osmo_repo_is() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:49:01 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:49:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:49:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:55:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:55:17 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26353/1/src/osmo-bsc/abis_rsl.c at 1349 PS1, Line 1349: rxlev2dbm(mrc->rxlev) > in handover configuration, logging and vty outputs, we consistently use the term "RXLEV" and usually [?] I think it's fine to print RxLev in dBm units. What we have on the wire is also dBm, it's just shifted into a specific range and limited. In the end, RxLev stands for received signal level. RSSI stands for received signal level indication. Same thing, just different abbreviations. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Nov 2021 12:55:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:57:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:57:12 +0000 Subject: Change in osmo-hnodeb[master]: Drop NAS and RANAP code and VTY commands In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 ) Change subject: Drop NAS and RANAP code and VTY commands ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 Gerrit-Change-Number: 26412 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 29 Nov 2021 12:57:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 12:59:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 12:59:25 +0000 Subject: Change in osmo-bsc[master]: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26383 ) Change subject: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc4947e68fa46aab180f2047231e51b997cca71b Gerrit-Change-Number: 26383 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 12:59:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:02:02 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 13:02:02 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom repository to configs In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom repository to configs ...................................................................... Patch Set 2: Ping, would be great if the updated version could get a review. The patches depending on this one already got +2. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:02:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:02:37 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 13:02:37 +0000 Subject: Change in osmo-bsc[master]: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26383 ) Change subject: Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting ...................................................................... Cosmetic: osmo-bsc/osmo_bsc_bssap: fix formatting Change-Id: Icc4947e68fa46aab180f2047231e51b997cca71b --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 7 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index aab2514..904da62 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -114,8 +114,7 @@ /* Page a subscriber based on TMSI and LAC via the specified BTS. * The msc parameter is the MSC which issued the corresponding paging request. * Log an error if paging failed. */ -static void -page_subscriber(const struct bsc_paging_params *params, struct gsm_bts *bts, uint32_t lac) +static void page_subscriber(const struct bsc_paging_params *params, struct gsm_bts *bts, uint32_t lac) { int ret; @@ -132,16 +131,14 @@ "Paging request failed, or repeated paging on LAC %u\n", lac); } -static void -page_all_bts(const struct bsc_paging_params *params) +static void page_all_bts(const struct bsc_paging_params *params) { struct gsm_bts *bts; llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) page_subscriber(params, bts, GSM_LAC_RESERVED_ALL_BTS); } -static void -page_cgi(const struct bsc_paging_params *params) +static void page_cgi(const struct bsc_paging_params *params) { int i; for (i = 0; i < params->cil.id_list_len; i++) { @@ -170,8 +167,7 @@ } } -static void -page_lac_and_ci(const struct bsc_paging_params *params) +static void page_lac_and_ci(const struct bsc_paging_params *params) { int i; @@ -193,8 +189,7 @@ } } -static void -page_ci(const struct bsc_paging_params *params) +static void page_ci(const struct bsc_paging_params *params) { int i; @@ -214,8 +209,7 @@ } } -static void -page_lai_and_lac(const struct bsc_paging_params *params) +static void page_lai_and_lac(const struct bsc_paging_params *params) { int i; @@ -242,8 +236,7 @@ } } -static void -page_lac(const struct bsc_paging_params *params) +static void page_lac(const struct bsc_paging_params *params) { int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc4947e68fa46aab180f2047231e51b997cca71b Gerrit-Change-Number: 26383 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:02:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 13:02:40 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:02:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:02:57 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 13:02:57 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... Patch Set 3: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:02:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:02:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 13:02:59 +0000 Subject: Change in osmo-bsc[master]: stats: add bsc.paging:expired In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26384 ) Change subject: stats: add bsc.paging:expired ...................................................................... stats: add bsc.paging:expired Similar to paging:attempted, count paging:expired not only per BTS, but also for the whole BSC. Add active_paging_requests to struct bsc_subscr, to increase the counter only once if paging expires, and not once per BTS where paging expired. Related: SYS#4878 Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d --- M include/osmocom/bsc/bsc_stats.h M include/osmocom/bsc/bsc_subscriber.h M src/osmo-bsc/bsc_stats.c M src/osmo-bsc/paging.c 4 files changed, 11 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bsc_stats.h b/include/osmocom/bsc/bsc_stats.h index 9140f85..801a2c1 100644 --- a/include/osmocom/bsc/bsc_stats.h +++ b/include/osmocom/bsc/bsc_stats.h @@ -76,6 +76,7 @@ BSC_CTR_PAGING_ATTEMPTED, BSC_CTR_PAGING_DETACHED, BSC_CTR_PAGING_RESPONDED, + BSC_CTR_PAGING_EXPIRED, BSC_CTR_PAGING_NO_ACTIVE_PAGING, BSC_CTR_UNKNOWN_UNIT_ID, BSC_CTR_MSCPOOL_SUBSCR_NO_MSC, diff --git a/include/osmocom/bsc/bsc_subscriber.h b/include/osmocom/bsc/bsc_subscriber.h index 6fffafd..f9e8eb2 100644 --- a/include/osmocom/bsc/bsc_subscriber.h +++ b/include/osmocom/bsc/bsc_subscriber.h @@ -17,6 +17,8 @@ char imsi[GSM23003_IMSI_MAX_DIGITS+1]; uint32_t tmsi; + + uint32_t active_paging_requests; }; const char *bsc_subscr_name(struct bsc_subscr *bsub); diff --git a/src/osmo-bsc/bsc_stats.c b/src/osmo-bsc/bsc_stats.c index c789aea..b48c90a 100644 --- a/src/osmo-bsc/bsc_stats.c +++ b/src/osmo-bsc/bsc_stats.c @@ -93,6 +93,7 @@ [BSC_CTR_PAGING_ATTEMPTED] = {"paging:attempted", "Paging attempts for a subscriber"}, [BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging request send failures because no responsible BTS was found"}, [BSC_CTR_PAGING_RESPONDED] = {"paging:responded", "Paging attempts with successful response"}, + [BSC_CTR_PAGING_EXPIRED] = {"paging:expired", "Paging Request expired because of timeout T3113"}, [BSC_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)"}, [BSC_CTR_UNKNOWN_UNIT_ID] = {"abis:unknown_unit_id", "Connection attempts from unknown IPA CCM Unit ID"}, diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 04512be..721ea31 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -66,6 +66,7 @@ static void paging_remove_request(struct gsm_bts_paging_state *paging_bts, struct gsm_paging_request *to_be_deleted) { + to_be_deleted->bsub->active_paging_requests--; osmo_timer_del(&to_be_deleted->T3113); llist_del(&to_be_deleted->entry); bsc_subscr_put(to_be_deleted->bsub, BSUB_USE_PAGING_REQUEST); @@ -284,6 +285,11 @@ /* must be destroyed before calling cbfn, to prevent double free */ rate_ctr_inc(rate_ctr_group_get_ctr(req->bts->bts_ctrs, BTS_CTR_PAGING_EXPIRED)); + /* If last BTS paging times out (active_paging_requests will be + * decremented in paging_remove_request below): */ + if (req->bsub->active_paging_requests == 1) + rate_ctr_inc(rate_ctr_group_get_ctr(bsc_gsmnet->bsc_ctrs, BSC_CTR_PAGING_EXPIRED)); + /* destroy it now. Do not access req afterwards */ paging_remove_request(&req->bts->paging, req); @@ -341,6 +347,7 @@ } LOG_PAGING_BTS(params, bts, DPAG, LOGL_DEBUG, "Start paging\n"); + params->bsub->active_paging_requests++; req = talloc_zero(tall_paging_ctx, struct gsm_paging_request); OSMO_ASSERT(req); req->reason = params->reason; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c118e7e3d61ed8c9f1951111255b196905eba4d Gerrit-Change-Number: 26384 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:13:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 13:13:54 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom repository to configs In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom repository to configs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/26385/2/jenkins-common.sh File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/26385/2/jenkins-common.sh at 387 PS2, Line 387: sed \ Instead of replacing, you could use the append operator: sed -i "/\[MODULE_PARAMETERS\]/a $line" "$config" This looks cleaner to me, but you can keep it as it is. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:13:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:28:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 13:28:03 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 2: -Code-Review (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 390 PS2, Line 390: (uia_mask << 1), /* API treats LSB as UIA0 */ > OSMO_UTRAN_UIA1 is 0 because 3GPP TS 25.413 ? 9.2.1.11 defines it this way. [?] Ah then they refer to values in the spec, they are not expected to be used specifically for the bitmask. Not sure if it then makes really sense to use them the way you do here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:28:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:29:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 13:29:55 +0000 Subject: Change in osmo-msc[master]: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26413 ) Change subject: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7 Gerrit-Change-Number: 26413 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:29:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:30:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 13:30:09 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:30:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:30:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 13:30:36 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 390 PS2, Line 390: (uia_mask << 1), /* API treats LSB as UIA0 */ > Ah then they refer to values in the spec, they are not expected to be used specifically for the bitm [?] Well, because it's cleaner than a magic number. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:30:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:36:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 13:36:02 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 390 PS2, Line 390: (uia_mask << 1), /* API treats LSB as UIA0 */ > Well, because it's cleaner than a magic number. I think it's confusing using those values that way, because they are to be used in the protocol code, not in our bitmasks. You can still move that do and describe it with a comment: const uint8_t uia_mas = 0x02 | 0x01; /* Allow UIA1 and UIA2. TODO: Make it configurable? */ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:38:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 13:38:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: tune logging configuration References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 ) Change subject: msc/osmo-{msc,stp}.cfg: tune logging configuration ...................................................................... msc/osmo-{msc,stp}.cfg: tune logging configuration Change-Id: Ic74014a3509f913c5668639e02b9306d73bb219d --- M msc/osmo-msc.cfg M msc/osmo-stp.cfg 2 files changed, 12 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/26414/1 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index f3006c4..2af4d7e 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -4,9 +4,14 @@ ! log stderr logging filter all 1 - logging color 0 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 + logging color 1 +! + logging level set-all notice logging level rll notice logging level cc debug logging level mm debug @@ -23,23 +28,6 @@ logging level ranap debug logging level vlr debug logging level iucs debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl info - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp debug ! stats interval 5 ! diff --git a/msc/osmo-stp.cfg b/msc/osmo-stp.cfg index 101b525..727119d 100644 --- a/msc/osmo-stp.cfg +++ b/msc/osmo-stp.cfg @@ -4,26 +4,18 @@ ! log stderr logging filter all 1 - logging color 0 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice + logging color 1 +! + logging level set-all notice logging level lss7 debug logging level lsccp debug logging level lsua debug logging level lm3ua debug - logging level lmgcp notice ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic74014a3509f913c5668639e02b9306d73bb219d Gerrit-Change-Number: 26414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:38:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 13:38:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-msc.cfg: remove deprecated 'periodic location update' References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 ) Change subject: msc/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... msc/osmo-msc.cfg: remove deprecated 'periodic location update' T3212 is set to 60 min. by default in osmo-msc. There is no need to set the value explicitly, so let's use the default. Change-Id: I4a053af23ae9371c945c7634053827bb3813a67a --- M msc/osmo-msc.cfg 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/26415/1 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 2af4d7e..79ffa04 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -54,7 +54,6 @@ authentication optional rrlp mode none mm info 0 - periodic location update 30 msc assign-tmsi cs7-instance-a 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a053af23ae9371c945c7634053827bb3813a67a Gerrit-Change-Number: 26415 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Stefan Sperling Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:41:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 13:41:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: tune logging configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 ) Change subject: msc/osmo-{msc,stp}.cfg: tune logging configuration ...................................................................... Patch Set 1: Code-Review+1 I personally don't like the "last" part of the log config that much, but fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic74014a3509f913c5668639e02b9306d73bb219d Gerrit-Change-Number: 26414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:41:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 13:42:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 13:42:10 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-msc.cfg: remove deprecated 'periodic location update' In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 ) Change subject: msc/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a053af23ae9371c945c7634053827bb3813a67a Gerrit-Change-Number: 26415 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 13:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:03:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 15:03:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: cosmetic cleanup for f_ctrs_*_init() References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 ) Change subject: bsc: cosmetic cleanup for f_ctrs_*_init() ...................................................................... bsc: cosmetic cleanup for f_ctrs_*_init() Related: SYS#4878 Change-Id: I357bfa811a07336ca57dac2d49bf80189047916d --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/26416/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index b34ad29..d54ffac 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -764,18 +764,17 @@ private function f_ctrs_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, counternames); + log("initial bts rate counters: ", g_ctr_bts); } function f_ctrs_bsc_and_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { f_ctrs_bts_init(bts_count, counternames); - log("initial bts rate counters: ", g_ctr_bts); f_ctrs_bsc_init(counternames); } private function f_ctrs_bsc_and_bts_handover_init(integer bts_count := NUM_BTS) runs on test_CT { var CounterNameVals bts_names := counternames_bsc_bts_handover & counternames_bts_handover; - g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, bts_names); - log("initial bts rate counters: ", g_ctr_bts); + f_ctrs_bts_init(bts_count, bts_names); f_ctrs_bsc_init(counternames_bsc_bts_handover); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I357bfa811a07336ca57dac2d49bf80189047916d Gerrit-Change-Number: 26416 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:03:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 15:03:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test various bts.N.chreq:* counters References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 ) Change subject: bsc: properly test various bts.N.chreq:* counters ...................................................................... bsc: properly test various bts.N.chreq:* counters Related: SYS#4878 Depends: I1fde77d5d5920093ab037184eb3518876804353d (osmo-bsc) Change-Id: I17a7702b151ac03fd9f7ecd6927ef42133aad953 --- M bsc/BSC_Tests.ttcn 1 file changed, 75 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/26417/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index d54ffac..780e512 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1279,7 +1279,57 @@ f_shutdown_helper(); } -/* verify if the "chreq:total" counter increments as expected */ +const CounterNameVals counternames_bts_chreq := { + { "chreq:total", 0 }, + { "chreq:attempted_emerg", 0 }, + { "chreq:attempted_call", 0 }, + { "chreq:attempted_location_upd", 0 }, + { "chreq:attempted_pag", 0 }, + { "chreq:attempted_pdch", 0 }, + { "chreq:attempted_other", 0 }, + { "chreq:attempted_unknown", 0 }, + { "chreq:successful", 0 }, + { "chreq:successful_emerg", 0 }, + { "chreq:successful_call", 0 }, + { "chreq:successful_location_upd", 0 }, + { "chreq:successful_pag", 0 }, + { "chreq:successful_pdch", 0 }, + { "chreq:successful_other", 0 }, + { "chreq:successful_unknown", 0 }, + { "chreq:no_channel", 0 }, + { "chreq:max_delay_exceeded", 0 } +}; + +/* verify the "chreq:*" counters */ +private function f_chan_act_counter(OCT1 ra, charstring chreq_ctr_suffix) runs on test_CT +{ + var GsmFrameNumber fn := 23; + + f_logp(BSCVTY, "f_chan_act_counter(" & chreq_ctr_suffix & ")"); + + var RSL_Message rx_rsl; + f_ipa_tx(0, ts_RSL_CHAN_RQD(ra, fn)); + rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); + var RslChannelNr chan_nr := rx_rsl.ies[0].body.chan_nr; + + f_ctrs_bts_add(0, "chreq:total"); + f_ctrs_bts_add(0, "chreq:attempted_" & chreq_ctr_suffix); + f_ctrs_bts_verify(); + + f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, fn+10)); + rx_rsl := f_exp_ipa_rx(0, tr_RSL_IMM_ASSIGN(0)); + + f_ctrs_bts_add(0, "chreq:successful"); + f_ctrs_bts_add(0, "chreq:successful_" & chreq_ctr_suffix); + f_ctrs_bts_verify(); + + /* test is done, release RSL Conn Fail Ind to clean up */ + f_ipa_tx(0, ts_RSL_CONN_FAIL_IND(chan_nr, RSL_ERR_RADIO_LINK_FAIL)); + rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL), 10.0); + f_ipa_tx(0, ts_RSL_RF_CHAN_REL_ACK(chan_nr)); + f_sleep(1.0); +} + testcase TC_chan_act_counter() runs on test_CT { var BSSAP_N_UNITDATA_ind ud_ind; var integer chreq_total; @@ -1287,10 +1337,30 @@ f_init(1); - chreq_total := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total"); - IPA_RSL[0].send(ts_ASP_RSL_UD(ts_RSL_CHAN_RQD('23'O, 23))); - rsl_unused := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); - f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total", chreq_total+1); + f_vty_allow_emerg_bts(true, 0); + + f_ctrs_bts_init(1, counternames_bts_chreq); + + /* emergency call: RA & 0xe0 == 0xa0 --> CHREQ_T_EMERG_CALL */ + f_chan_act_counter('a3'O, "emerg"); + + /* voice TCH/H: RA & 0xf0 == 0x40 --> CHREQ_T_VOICE_CALL_TCH_H */ + f_chan_act_counter('43'O, "call"); + + /* LU: RA & 0xf0 == 0x00 --> CHREQ_T_LOCATION_UPD */ + f_chan_act_counter('03'O, "location_upd"); + + /* Paging: RA & 0xf0 == 0x20 --> CHREQ_T_PAG_R_TCH_F */ + f_chan_act_counter('23'O, "pag"); + /* Paging: RA & 0xf0 == 0x30 --> CHREQ_T_PAG_R_TCH_FH */ + f_chan_act_counter('33'O, "pag"); + + /* LU: RA & 0xfc == 0x78 --> CHREQ_T_PDCH_TWO_PHASE */ + /* no PCU, so PDCH not allowed. Skip this test for now. */ + /* f_chan_act_counter('7b'O, "pdch"); */ + + /* LU: RA & 0xf0 == 0x10 --> CHREQ_T_SDCCH */ + f_chan_act_counter('13'O, "other"); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17a7702b151ac03fd9f7ecd6927ef42133aad953 Gerrit-Change-Number: 26417 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:04:00 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 15:04:00 +0000 Subject: Change in osmo-bsc[master]: fix chreq:* counters: typos in chreq:successful_* constants References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26418 ) Change subject: fix chreq:* counters: typos in chreq:successful_* constants ...................................................................... fix chreq:* counters: typos in chreq:successful_* constants Related: SYS#4878 Related: I17a7702b151ac03fd9f7ecd6927ef42133aad953 (osmo-ttcn3-hacks) Change-Id: I1fde77d5d5920093ab037184eb3518876804353d --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/26418/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 52008a5..81ec980 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2220,25 +2220,25 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL)); switch (lchan->activate.info.chreq_reason) { case GSM_CHREQ_REASON_EMERG: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_EMERG)); break; case GSM_CHREQ_REASON_CALL: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_CALL)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_CALL)); break; case GSM_CHREQ_REASON_LOCATION_UPD: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_LOCATION_UPD)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_LOCATION_UPD)); break; case GSM_CHREQ_REASON_PAG: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PAG)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_PAG)); break; case GSM_CHREQ_REASON_PDCH: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PDCH)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_PDCH)); break; case GSM_CHREQ_REASON_OTHER: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_OTHER)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_OTHER)); break; default: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_UNKNOWN)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_UNKNOWN)); break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fde77d5d5920093ab037184eb3518876804353d Gerrit-Change-Number: 26418 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:05:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 15:05:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: cosmetic cleanup for f_ctrs_*_init() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 ) Change subject: bsc: cosmetic cleanup for f_ctrs_*_init() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I357bfa811a07336ca57dac2d49bf80189047916d Gerrit-Change-Number: 26416 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 15:05:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:06:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 15:06:46 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test various bts.N.chreq:* counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 ) Change subject: bsc: properly test various bts.N.chreq:* counters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17a7702b151ac03fd9f7ecd6927ef42133aad953 Gerrit-Change-Number: 26417 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 15:06:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:07:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 15:07:46 +0000 Subject: Change in osmo-bsc[master]: fix chreq:* counters: typos in chreq:successful_* constants In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26418 ) Change subject: fix chreq:* counters: typos in chreq:successful_* constants ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26418/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26418/1/src/osmo-bsc/abis_rsl.c at 2217 PS1, Line 2217: static void imm_ass_rate_ctr(struct gsm_lchan *lchan) it may be a good idea to also rename this function to contain "successful" somewhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fde77d5d5920093ab037184eb3518876804353d Gerrit-Change-Number: 26418 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Nov 2021 15:07:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:10:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 15:10:49 +0000 Subject: Change in osmo-bsc[master]: dbg log: abis_rsl print_meas_rep(): clarify rxlev In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26353 ) Change subject: dbg log: abis_rsl print_meas_rep(): clarify rxlev ...................................................................... dbg log: abis_rsl print_meas_rep(): clarify rxlev Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb --- M src/osmo-bsc/abis_rsl.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified Objections: pespin: I would prefer this is not merged as is diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 52008a5..629d50b 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1345,7 +1345,7 @@ && log_check_level(DMEAS, LOGL_DEBUG)) { for (i = 0; i < mr->num_cell; i++) { const struct gsm_meas_rep_cell *mrc = &mr->cell[i]; - DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u => %d dBm\n", + DEBUGP(DMEAS, "IDX=%u ARFCN=%u BSIC=%u RXLEV=%ddBm\n", mrc->neigh_idx, mrc->arfcn, mrc->bsic, rxlev2dbm(mrc->rxlev)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26353 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2c1d59eac556b8f6a56c39abf12b35a3ba807eb Gerrit-Change-Number: 26353 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:34:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 15:34:22 +0000 Subject: Change in sandbox[master]: b: new empty file References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/sandbox/+/26419 ) Change subject: b: new empty file ...................................................................... b: new empty file Change-Id: Ic4a3f57a8f804f289e7ed33d5e07e84a408594b4 --- A b 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/sandbox refs/changes/19/26419/1 diff --git a/b b/b new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/b -- To view, visit https://gerrit.osmocom.org/c/sandbox/+/26419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: sandbox Gerrit-Branch: master Gerrit-Change-Id: Ic4a3f57a8f804f289e7ed33d5e07e84a408594b4 Gerrit-Change-Number: 26419 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:34:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 15:34:34 +0000 Subject: Change in sandbox[master]: b: new empty file In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/sandbox/+/26419 ) Change subject: b: new empty file ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/sandbox/+/26419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: sandbox Gerrit-Branch: master Gerrit-Change-Id: Ic4a3f57a8f804f289e7ed33d5e07e84a408594b4 Gerrit-Change-Number: 26419 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 29 Nov 2021 15:34:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:34:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 15:34:39 +0000 Subject: Change in sandbox[master]: b: new empty file In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/sandbox/+/26419 ) Change subject: b: new empty file ...................................................................... b: new empty file Change-Id: Ic4a3f57a8f804f289e7ed33d5e07e84a408594b4 --- A b 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/b b/b new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/b -- To view, visit https://gerrit.osmocom.org/c/sandbox/+/26419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: sandbox Gerrit-Branch: master Gerrit-Change-Id: Ic4a3f57a8f804f289e7ed33d5e07e84a408594b4 Gerrit-Change-Number: 26419 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:36:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 15:36:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 to look at the new patch set (#5). Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... hnodeb: Add initial infra to emulate HNB LL socket iface Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.default M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh A library/HNBLLIF_CodecPort.ttcn A library/HNBLLIF_Templates.ttcn A library/HNBLLIF_Types.ttcn M library/Iuh_CodecPort.ttcn M library/rua/RUA_Templates.ttcn 10 files changed, 964 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/26373/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:46:52 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 15:46:52 +0000 Subject: Change in osmo-bsc[master]: dbg log: also log assignment counters on BTS level References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26420 ) Change subject: dbg log: also log assignment counters on BTS level ...................................................................... dbg log: also log assignment counters on BTS level Change-Id: I68b3e794ddf97c80f647c3536ec466217b338af9 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/20/26420/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 656bd3e..a3ec55b 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -88,11 +88,19 @@ switch (gsm48_chan_mode_to_non_vamos(conn->assignment.req.ch_mode_rate_list[0].chan_mode)) { \ case GSM48_CMODE_SIGN: \ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_##counter##_SIGN)); \ + LOG_ASSIGNMENT(conn, LOGL_DEBUG, "incrementing rate counter: bts%u %s %s\n", \ + bts->nr, \ + bts_ctr_description[BTS_##counter##_SIGN].name, \ + bts_ctr_description[BTS_##counter##_SIGN].description); \ break; \ case GSM48_CMODE_SPEECH_V1: \ case GSM48_CMODE_SPEECH_EFR: \ case GSM48_CMODE_SPEECH_AMR: \ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_##counter##_SPEECH)); \ + LOG_ASSIGNMENT(conn, LOGL_DEBUG, "incrementing rate counter: bts%u %s %s\n", \ + bts->nr, \ + bts_ctr_description[BTS_##counter##_SPEECH].name, \ + bts_ctr_description[BTS_##counter##_SPEECH].description); \ break; \ default: \ break; \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I68b3e794ddf97c80f647c3536ec466217b338af9 Gerrit-Change-Number: 26420 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:46:53 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 15:46:53 +0000 Subject: Change in osmo-bsc[master]: fix assignment success counters: count *before* cleanup of fsm state References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26421 ) Change subject: fix assignment success counters: count *before* cleanup of fsm state ...................................................................... fix assignment success counters: count *before* cleanup of fsm state Counting the Assignment success after osmo_fsm_inst_term() meant that we were counting a cleared out channel mode, which always yielded speech mode. Count the Assignment success *before* terminating, so that we correctly count the successful assignment as speech mode. Related: SYS#4878 Related: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 (osmo-ttcn3-hacks) Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/26421/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index a3ec55b..0243058 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -295,10 +295,10 @@ conn->user_plane.msc_assigned_rtp_port = conn->assignment.req.msc_rtp_port; } + assignment_count_result(CTR_ASSIGNMENT_COMPLETED); + LOG_ASSIGNMENT(conn, LOGL_DEBUG, "Assignment successful\n"); osmo_fsm_inst_term(conn->assignment.fi, OSMO_FSM_TERM_REGULAR, 0); - - assignment_count_result(CTR_ASSIGNMENT_COMPLETED); } static void assignment_fsm_update_id(struct gsm_subscriber_connection *conn) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 Gerrit-Change-Number: 26421 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:48:03 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 15:48:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test assignment counters References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 ) Change subject: bsc: properly test assignment counters ...................................................................... bsc: properly test assignment counters Verify the BTS level assignment:attempted_speech / _sign as well as assignment:completed_speech / _sign counters, in four selected assignment tests (fr, hr, amr_f, amr_h). Shows a bug where we counted a speech assignment as assignment:completed_sign. Related: SYS#4878 Depends: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 (osmo-bsc) Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 --- M bsc/BSC_Tests.ttcn 1 file changed, 48 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/26422/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 780e512..5947061 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -4146,16 +4146,42 @@ f_establish_fully(ass_cmd, exp_fail); } +const CounterNameVals counternames_bsc_bts_assignment := { + { "assignment:attempted", 0 }, + { "assignment:completed", 0 } +}; + +const CounterNameVals counternames_bts_assignment := { + { "assignment:attempted_sign", 0 }, + { "assignment:attempted_speech", 0 }, + { "assignment:completed_sign", 0 }, + { "assignment:completed_speech", 0 } +}; + +function f_ctrs_bsc_and_bts_assignment_init(integer bts_count := NUM_BTS) runs on test_CT { + var CounterNameVals bts_names := counternames_bsc_bts_assignment & counternames_bts_assignment; + f_ctrs_bts_init(bts_count, bts_names); + f_ctrs_bsc_init(counternames_bsc_bts_assignment); +} + testcase TC_assignment_codec_fr() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; f_init(1, true); f_sleep(1.0); + f_ctrs_bsc_and_bts_assignment_init(1); pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_shutdown_helper(); } @@ -4165,10 +4191,18 @@ f_init(1, true); f_sleep(1.0); + f_ctrs_bsc_and_bts_assignment_init(1); pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR})); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_shutdown_helper(); } @@ -4251,10 +4285,17 @@ f_init(1, true); f_sleep(1.0); f_vty_amr_start_mode_set(true, "1"); + f_ctrs_bsc_and_bts_assignment_init(1); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_vty_amr_start_mode_restore(true); f_shutdown_helper(); } @@ -4279,10 +4320,17 @@ f_init(1, true); f_sleep(1.0); f_vty_amr_start_mode_set(false, "1"); + f_ctrs_bsc_and_bts_assignment_init(1); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_vty_amr_start_mode_restore(false); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 Gerrit-Change-Number: 26422 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:53:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 15:53:14 +0000 Subject: Change in osmo-hnodeb[master]: Drop NAS and RANAP code and VTY commands In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 to look at the new patch set (#2). Change subject: Drop NAS and RANAP code and VTY commands ...................................................................... Drop NAS and RANAP code and VTY commands The higher level bits were used in originally imported hnb-test code in order to control interaction with the HNBGW over the VTY. This is no longer needed in osmo-hnodeb, as NAS is in layers above the ones being handled by an hNodeB. Regarding RANAP, most if it is going to be handled by the LowerLayer UD socket peer to be introduced in the future, so we can drop most of it, as in osmo-hnodeb we'll basically be speaking RUA to the HNBGW and passing RANAP buffers transparently. We keep the .c/.h files since some small helpers functions will be ntroduced later on when adding support for the mentioned LL socket. Related: SYS#5516 Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h D include/osmocom/hnodeb/nas.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c D src/osmo-hnodeb/nas.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 12 files changed, 2 insertions(+), 550 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/12/26412/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 Gerrit-Change-Number: 26412 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:53:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 15:53:14 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#6). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_ctl.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 20 files changed, 1,499 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:53:57 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 15:53:57 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... jobs/redmine-fetch: close issues on gerrit merge Add a job that is triggered by every gerrit merge, which translates the GERRIT_PROJECT to the redmine project + repository and then triggers a repository fetch by downloading the repository view url. Redmine will then also parse the "Closes: OS#..." tags from commit messages and mark related issues as resolved. Redmine does not have a setting to fetch the repositories periodically by itself, the redmine wiki recommends setting up a cron job or a serverside git hook that also triggers the repository fetch. I have considered implementing such a hook in gerrit instead, but then we would not be able to see the logs as easily and notice failures. Another consideration was fetching all redmine projects and associated git repositories via redmine API and then just triggering a repository fetch on all of them, in order to avoid the mapping from gerrit <> redmine. However, the redmine API apparently doesn't list the repositories and one would need to iterate through the projects, recursively. I have tested this job and verified that GERRIT_PROJECT gets set as expected. Related: https://www.redmine.org/projects/redmine/wiki/RedmineSettings#Fetch-commits-automatically Related: OS#5331 Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 --- A jobs/redmine-fetch.yml 1 file changed, 105 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/23/26423/1 diff --git a/jobs/redmine-fetch.yml b/jobs/redmine-fetch.yml new file mode 100644 index 0000000..59903b3 --- /dev/null +++ b/jobs/redmine-fetch.yml @@ -0,0 +1,105 @@ +# Fetch repositories in redmine, in order to mark issues as resolved where +# mentioned in commit messages (OS#5331). + +- job: + name: redmine-fetch + project-type: freestyle + node: osmocom-gerrit-debian9 + properties: + - build-discarder: + days-to-keep: 30 + num-to-keep: 120 + description: | + Fetch repositories in redmine, in order to mark issues as resolved where + mentioned in commit messages. +

+ Related issue: OS#5331 + triggers: + - gerrit: + trigger-on: + - change-merged-event + projects: + - project-compare-type: 'ANT' + project-pattern: '**' + branches: + - branch-compare-type: 'ANT' + branch-pattern: '**' + builders: + - shell: |- + # When triggered from gerrit, GERRIT_PROJECT is set. Use "osmo-bts" + # as dummy value for manual triggers. + if [ -z "$GERRIT_PROJECT" ]; then + GERRIT_PROJECT="erlang/mgw_nat" + fi + + # Translate GERRIT_PROJECT name to redmine project name and + # repository. One redmine project can have multiple repositories. + PROJECT="$GERRIT_PROJECT" + REPO="$GERRIT_PROJECT" + + case "$GERRIT_PROJECT" in + # Git repo not in redmine (multiple lines for readability) + asn1c|erlang/osmo_dia2gsup|erlang/osmo_gsup|titan.*|gr-gsm) + exit 0 + ;; + gtp-load-gen|libasn1c|libgtpnl|libtelnet|libusrp|meta-telephony) + exit 0 + ;; + mncc-python|openbsc|openggsn|openpcd|osmo-sdf4-dfu|osmo-dev) + exit 0 + ;; + osmo-e2ltpd|osmo-el2tpd|osmo-gsm-manuals|osmo-gsm-tester|osmo-iuh) + exit 0 + ;; + osmo-sysmon|osmo-upf|osmocom-lcs|python/osmo-python-tests|sandbox) + exit 0 + ;; + + # Git repo or project name not the same as gerrit project + docker-playground|osmo-ttcn3-hacks|osmo-ci) + PROJECT="core-testing-infra" + ;; + erlang/*) + PROJECT="$(echo "$GERRIT_PROJECT" | tr '/' '-')" + REPO="$PROJECT" + ;; + osmo-bsc) + PROJECT="osmobsc" + ;; + osmo-bts) + PROJECT="osmobts" + ;; + osmo-e1-hardware|osmo-e1d) + PROJECT="e1-t1-adapter" + ;; + osmo-ggsn) + PROJECT="openggsn" + ;; + osmo-msc) + PROJECT="osmomsc" + ;; + osmo-pcu) + PROJECT="osmopcu" + ;; + osmo-sgsn) + PROJECT="osmosgsn" + ;; + osmo-sip-connector) + PROJECT="osmo-sip-conector" + ;; + osmo-tetra) + PROJECT="tetra" + REPO="osmotetra" + ;; + osmo-trx) + PROJECT="osmotrx" + ;; + osmocom-bb) + PROJECT="baseband" + REPO="osmocombb" + ;; + esac + + wget \ + -O /dev/null \ + "https://osmocom.org/projects/$PROJECT/repository/$REPO" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 15:57:11 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 15:57:11 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 to look at the new patch set (#2). Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... jobs/redmine-fetch: close issues on gerrit merge Add a job that is triggered by every gerrit merge, which translates the GERRIT_PROJECT to the redmine project + repository and then triggers a repository fetch by downloading the repository view url. Redmine will then also parse the "Closes: OS#..." tags from commit messages and mark related issues as resolved. Redmine does not have a setting to fetch the repositories periodically by itself, the redmine wiki recommends setting up a cron job or a serverside git hook that also triggers the repository fetch. I have considered implementing such a hook in gerrit instead, but then we would not be able to see the logs as easily and notice failures. Another consideration was fetching all redmine projects and associated git repositories via redmine API and then just triggering a repository fetch on all of them, in order to avoid the mapping from gerrit <> redmine. However, the redmine API apparently doesn't list the repositories and one would need to iterate through the projects, recursively. I have tested this job and verified that GERRIT_PROJECT gets set as expected. Closes: OS#5331 Related: https://www.redmine.org/projects/redmine/wiki/RedmineSettings#Fetch-commits-automatically Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 --- A jobs/redmine-fetch.yml 1 file changed, 105 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/23/26423/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 16:00:42 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 16:00:42 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 to look at the new patch set (#3). Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... jobs/redmine-fetch: close issues on gerrit merge Add a job that is triggered by every gerrit merge, which translates the GERRIT_PROJECT to the redmine project + repository and then triggers a repository fetch by downloading the repository view url. Redmine will then also parse the "Closes: OS#..." tags from commit messages and mark related issues as resolved. Redmine does not have a setting to fetch the repositories periodically by itself, the redmine wiki recommends setting up a cron job or a serverside git hook that also triggers the repository fetch. I have considered implementing such a hook in gerrit instead, but then we would not be able to see the logs as easily and notice failures. Another consideration was fetching all redmine projects and associated git repositories via redmine API and then just triggering a repository fetch on all of them, in order to avoid the mapping from gerrit <> redmine. However, the redmine API apparently doesn't list the repositories and one would need to iterate through the projects, recursively. I have tested this job and verified that GERRIT_PROJECT gets set as expected. Closes: OS#5331 Related: https://jenkins.osmocom.org/jenkins/job/redmine-fetch/ Related: https://www.redmine.org/projects/redmine/wiki/RedmineSettings#Fetch-commits-automatically Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 --- A jobs/redmine-fetch.yml 1 file changed, 105 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/23/26423/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 16:05:27 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Nov 2021 16:05:27 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 to look at the new patch set (#4). Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... jobs/redmine-fetch: close issues on gerrit merge Add a job that is triggered by every gerrit merge, which translates the GERRIT_PROJECT to the redmine project + repository and then triggers a repository fetch by downloading the repository view url. Redmine will then also parse the "Closes: OS#..." tags from commit messages and mark related issues as resolved. Redmine does not have a setting to fetch the repositories periodically by itself, the redmine wiki recommends setting up a cron job or a serverside git hook that also triggers the repository fetch. I have considered implementing such a hook in gerrit instead, but then we would not be able to see the logs as easily and notice failures. Another consideration was fetching all redmine projects and associated git repositories via redmine API and then just triggering a repository fetch on all of them, in order to avoid the mapping from gerrit <> redmine. However, the redmine API apparently doesn't list the repositories and one would need to iterate through the projects, recursively. I have tested this job and verified that GERRIT_PROJECT gets set as expected. Closes: OS#5331 Related: https://jenkins.osmocom.org/jenkins/job/redmine-fetch/ Related: https://www.redmine.org/projects/redmine/wiki/RedmineSettings#Fetch-commits-automatically Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 --- A jobs/redmine-fetch.yml 1 file changed, 110 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/23/26423/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 17:01:03 2021 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Mon, 29 Nov 2021 17:01:03 +0000 Subject: Change in osmo-msc[master]: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26413 ) Change subject: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7 Gerrit-Change-Number: 26413 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 17:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 17:01:40 2021 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Mon, 29 Nov 2021 17:01:40 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 17:01:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 17:12:03 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Nov 2021 17:12:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test assignment counters In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 to look at the new patch set (#2). Change subject: bsc: properly test assignment counters ...................................................................... bsc: properly test assignment counters Verify the BTS level assignment:attempted_speech / _sign as well as assignment:completed_speech / _sign counters, in four selected assignment tests (fr, hr, amr_f, amr_h). Shows a bug where we counted a speech assignment as assignment:completed_sign. Related: SYS#4878 Depends: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 (osmo-bsc) Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 --- M bsc/BSC_Tests.ttcn 1 file changed, 63 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/26422/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 Gerrit-Change-Number: 26422 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 17:38:09 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Nov 2021 17:38:09 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372/4/gbproxy/GBProxy_Tests.ttcn File gbproxy/GBProxy_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372/4/gbproxy/GBProxy_Tests.ttcn at 3677 PS4, Line 3677: if (Misc_Helpers.f_is_osmocom_nightly()) { > That got adopted quickly :D [?] Yeah, I already updated it. Will rebase and push once the dependency is merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 17:38:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 17:53:38 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 17:53:38 +0000 Subject: Change in osmo-bsc[master]: dbg log: also log assignment counters on BTS level In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26420 ) Change subject: dbg log: also log assignment counters on BTS level ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I68b3e794ddf97c80f647c3536ec466217b338af9 Gerrit-Change-Number: 26420 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 17:53:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 17:54:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 17:54:13 +0000 Subject: Change in osmo-bsc[master]: fix assignment success counters: count *before* cleanup of fsm state In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26421 ) Change subject: fix assignment success counters: count *before* cleanup of fsm state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 Gerrit-Change-Number: 26421 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 17:54:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 17:54:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Nov 2021 17:54:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test assignment counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 ) Change subject: bsc: properly test assignment counters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 Gerrit-Change-Number: 26422 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 17:54:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 18:05:32 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Nov 2021 18:05:32 +0000 Subject: Change in osmo-bsc[master]: fix assignment success counters: count *before* cleanup of fsm state In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26421 ) Change subject: fix assignment success counters: count *before* cleanup of fsm state ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 Gerrit-Change-Number: 26421 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 18:05:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:05:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 20:05:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test various bts.N.chreq:* counters In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 ) Change subject: bsc: properly test various bts.N.chreq:* counters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17a7702b151ac03fd9f7ecd6927ef42133aad953 Gerrit-Change-Number: 26417 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:05:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:06:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 20:06:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: cosmetic cleanup for f_ctrs_*_init() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 ) Change subject: bsc: cosmetic cleanup for f_ctrs_*_init() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I357bfa811a07336ca57dac2d49bf80189047916d Gerrit-Change-Number: 26416 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:06:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:09:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 20:09:28 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test assignment counters In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 ) Change subject: bsc: properly test assignment counters ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 Gerrit-Change-Number: 26422 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:09:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:10:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 20:10:13 +0000 Subject: Change in osmo-bsc[master]: fix chreq:* counters: typos in chreq:successful_* constants In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26418 ) Change subject: fix chreq:* counters: typos in chreq:successful_* constants ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fde77d5d5920093ab037184eb3518876804353d Gerrit-Change-Number: 26418 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:10:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:10:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 20:10:33 +0000 Subject: Change in osmo-bsc[master]: dbg log: also log assignment counters on BTS level In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26420 ) Change subject: dbg log: also log assignment counters on BTS level ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I68b3e794ddf97c80f647c3536ec466217b338af9 Gerrit-Change-Number: 26420 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:10:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:11:06 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 29 Nov 2021 20:11:06 +0000 Subject: Change in osmo-bsc[master]: fix assignment success counters: count *before* cleanup of fsm state In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26421 ) Change subject: fix assignment success counters: count *before* cleanup of fsm state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 Gerrit-Change-Number: 26421 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:11:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:33:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:33:24 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: tune logging configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 ) Change subject: msc/osmo-{msc,stp}.cfg: tune logging configuration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic74014a3509f913c5668639e02b9306d73bb219d Gerrit-Change-Number: 26414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:33:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:33:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:33:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-msc.cfg: remove deprecated 'periodic location update' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 ) Change subject: msc/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a053af23ae9371c945c7634053827bb3813a67a Gerrit-Change-Number: 26415 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:33:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:33:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:33:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: tune logging configuration In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 ) Change subject: msc/osmo-{msc,stp}.cfg: tune logging configuration ...................................................................... msc/osmo-{msc,stp}.cfg: tune logging configuration Change-Id: Ic74014a3509f913c5668639e02b9306d73bb219d --- M msc/osmo-msc.cfg M msc/osmo-stp.cfg 2 files changed, 12 insertions(+), 32 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index f3006c4..2af4d7e 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -4,9 +4,14 @@ ! log stderr logging filter all 1 - logging color 0 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 + logging color 1 +! + logging level set-all notice logging level rll notice logging level cc debug logging level mm debug @@ -23,23 +28,6 @@ logging level ranap debug logging level vlr debug logging level iucs debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl info - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp debug ! stats interval 5 ! diff --git a/msc/osmo-stp.cfg b/msc/osmo-stp.cfg index 101b525..727119d 100644 --- a/msc/osmo-stp.cfg +++ b/msc/osmo-stp.cfg @@ -4,26 +4,18 @@ ! log stderr logging filter all 1 - logging color 0 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice + logging color 1 +! + logging level set-all notice logging level lss7 debug logging level lsccp debug logging level lsua debug logging level lm3ua debug - logging level lmgcp notice ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic74014a3509f913c5668639e02b9306d73bb219d Gerrit-Change-Number: 26414 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:33:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:33:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-msc.cfg: remove deprecated 'periodic location update' In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 ) Change subject: msc/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... msc/osmo-msc.cfg: remove deprecated 'periodic location update' T3212 is set to 60 min. by default in osmo-msc. There is no need to set the value explicitly, so let's use the default. Change-Id: I4a053af23ae9371c945c7634053827bb3813a67a --- M msc/osmo-msc.cfg 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 2af4d7e..79ffa04 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -54,7 +54,6 @@ authentication optional rrlp mode none mm info 0 - periodic location update 30 msc assign-tmsi cs7-instance-a 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a053af23ae9371c945c7634053827bb3813a67a Gerrit-Change-Number: 26415 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:36:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:36:26 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:36:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:36:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:36:33 +0000 Subject: Change in osmo-msc[master]: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26413 ) Change subject: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7 Gerrit-Change-Number: 26413 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 20:36:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:36:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:36:35 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26411 ) Change subject: libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... libmsc: fix memory leak (struct gsm_sms) in gsm340_rx_tpdu() If a MO SMS gets successfully routed through SMPP, we return early in gsm340_rx_tpdu() and leak a chunk of type 'struct gsm_sms'. Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Fixes: [1] Ic34d398e0a850856e20380ae35e5c2ae5e3c539b Fixes: OS#5334 --- M src/libmsc/gsm_04_11.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved keith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 199fdc1..bd7cf1f 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -631,7 +631,8 @@ /* This SMS got routed through SMPP and we are waiting on the response. */ if (gsms->smpp.esme) { - return -EINPROGRESS; + rc = -EINPROGRESS; + goto out; } /* This SMS got routed through SMPP, but the configured ESME was -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a745d747f06baa7109418ffe600b27b3c0a5228 Gerrit-Change-Number: 26411 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:36:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:36:36 +0000 Subject: Change in osmo-msc[master]: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26413 ) Change subject: libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() ...................................................................... libmsc: fix another memleak (struct gsm_sms) in gsm340_rx_tpdu() Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7 Fixes: I2c50904349dd4ed229b60b8468d776b817c0bd44 --- M src/libmsc/gsm_04_11.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved keith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index bd7cf1f..722973e 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -642,7 +642,7 @@ * attempt re-submission to the ESME) */ if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER) - return rc; + goto out; /* free() the message */ /* * This SMS got routed through SMPP or no receiver exists. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42e819fb83096c1432df16f501b9d1f6a6160ae7 Gerrit-Change-Number: 26413 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:41:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:41:00 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Patch Set 4: (5 comments) I think in general it would be better if we could have a textual config file containing the mappings of redmine project name vs. git repository. Or, obviously, any method that doesn't require manually kept configuration which will soon be outdated as somebody forgets about it... https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml File jobs/redmine-fetch.yml: https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 45 PS4, Line 45: libgtpnl should be added as secondary repo to osmo-ggsn? https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 45 PS4, Line 45: libusrp libusrp could be secondary repo of osmo-trx? https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 51 PS4, Line 51: osmo-iuh this is certainly a but, the repository should be added to redmine https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 54 PS4, Line 54: osmocom-lcs osmocom-lcs can be added as secondary repo to the osmo-bsc redmine project, in case there is no smlc related project https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 54 PS4, Line 54: osmo-upf a related redmine project with repository should be created -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Nov 2021 20:41:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:42:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:42:23 +0000 Subject: Change in osmo-hnodeb[master]: Drop NAS and RANAP code and VTY commands In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 ) Change subject: Drop NAS and RANAP code and VTY commands ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412/2//COMMIT_MSG at 13 PS2, Line 13: if of -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 Gerrit-Change-Number: 26412 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Nov 2021 20:42:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 20:45:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 20:45:27 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnb_prim.h at 35 PS6, Line 35: struct hnb_prim_hdr { : uint32_t sap; /*!< Service Access Point Identifier */ : uint32_t primitive; /*!< Primitive number */ : uint32_t operation; /*! Primitive Operation */ : } __attribute__ ((packed)); maybe add a todo that this header should be moved to libosmocore as a general 'serialized osmo_prim header'? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnodeb.h File include/osmocom/hnodeb/hnodeb.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/6/include/osmocom/hnodeb/hnodeb.h at 57 PS6, Line 57: chan_cs I think 'connection' is more applicable than 'channel' here, as there is no notion of a 'channel' on Iu? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Nov 2021 20:45:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 21:15:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 21:15:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo_is() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_osmo_repo_is() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 21:15:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 21:15:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 21:15:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 21:15:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 21:15:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 21:15:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Misc_Helpers: add f_osmo_repo_is() In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 ) Change subject: library/Misc_Helpers: add f_osmo_repo_is() ...................................................................... library/Misc_Helpers: add f_osmo_repo_is() Create functions to check which from Osmocom repository the SUT is running. Put it in Misc_Helpers instead of a new library file since Misc_Helpers is already available in many/all? tests and it fits there too. Depends: docker-playground Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Related: OS#5327 Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 --- M library/Misc_Helpers.ttcn 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/Misc_Helpers.ttcn b/library/Misc_Helpers.ttcn index a402525..e01c170 100644 --- a/library/Misc_Helpers.ttcn +++ b/library/Misc_Helpers.ttcn @@ -1,5 +1,22 @@ module Misc_Helpers { +modulepar { + charstring mp_osmo_repo := "nightly"; +} + +/* Test the Osmocom repository (nightly, latest, 2021q4, ...), from which the + * SUT is running (OS#4878). Usage examples: + * if (Misc_Helpers.f_osmo_repo_is("nightly")) { + * ... + * } + * if (Misc_Helpers.f_osmo_repo_is(("nightly", "2021q4"))) { + * ... + * } + */ +function f_osmo_repo_is(template charstring ver) return boolean { + return match(mp_osmo_repo, ver); +} + /* Try to properly shutdown a testcase. * The reliable method to stop a testcase without running into dynamic * testcase errors due to unconnected ports receiving messages is to call -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33d08992ea84af006d133db6aec508a7b7c7f28 Gerrit-Change-Number: 26386 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 21:15:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 21:15:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: TC_paging_counter: add bsc pag expired In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 ) Change subject: BSC_Tests: TC_paging_counter: add bsc pag expired ...................................................................... BSC_Tests: TC_paging_counter: add bsc pag expired Test the new bsc.N.paging:expired stat in TC_paging_counter too. Depends: osmo-bsc I9c118e7e3d61ed8c9f1951111255b196905eba4d Related: SYS#4878 Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index b34ad29..d8e2ab1 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3312,6 +3312,7 @@ var integer i; var integer paging_attempted_bsc; var integer paging_attempted_bts[NUM_BTS]; + var integer paging_expired_bsc; var integer paging_expired_bts[NUM_BTS]; cid_list := valueof(ts_BSSMAP_CIL_noCell); @@ -3319,6 +3320,9 @@ /* read counters before paging */ paging_attempted_bsc := f_ctrl_get_ratectr_abs(IPA_CTRL, "bsc", 0, "paging:attempted"); + if (Misc_Helpers.f_osmo_repo_is("nightly")) { /* osmo-bsc > 1.8.0 */ + paging_expired_bsc := f_ctrl_get_ratectr_abs(IPA_CTRL, "bsc", 0, "paging:expired"); + } for (i := 0; i < NUM_BTS; i := i+1) { paging_attempted_bts[i] := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", i, "paging:attempted"); paging_expired_bts[i] := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", i, "paging:expired"); @@ -3335,6 +3339,9 @@ /* assume that 12s later the paging on all BTSs have expired and hence incremented by 1 */ f_sleep(12.0); + if (Misc_Helpers.f_osmo_repo_is("nightly")) { /* osmo-bsc > 1.8.0 */ + f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bsc", 0, "paging:expired", paging_expired_bsc+1); + } for (i := 0; i < NUM_BTS; i := i+1) { f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bts", i, "paging:expired", paging_expired_bts[i]+1); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8931bf1bc2f4e0d4b168168cdb83683bb350d961 Gerrit-Change-Number: 26387 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 21:18:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 21:18:08 +0000 Subject: Change in osmo-msc[master]: libvlr: vlr_set_ciph_mode(): avoid redundant check In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26405 ) Change subject: libvlr: vlr_set_ciph_mode(): avoid redundant check ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I900ddd5f1882f8cee234ab1074adcf25830a092c Gerrit-Change-Number: 26405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 21:18:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Nov 29 21:18:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Nov 2021 21:18:37 +0000 Subject: Change in osmo-msc[master]: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26406 ) Change subject: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6205f13453eff7afbf25e013d72ae98a78fcd31b Gerrit-Change-Number: 26406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Nov 2021 21:18:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:16:32 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 07:16:32 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom repository to configs In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom repository to configs ...................................................................... Patch Set 2: Verified+1 Code-Review+2 (1 comment) Patches depending on this one have been merged already, so merging this too. Different versions of this patch have seen 3 reviews. https://gerrit.osmocom.org/c/docker-playground/+/26385/2/jenkins-common.sh File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/26385/2/jenkins-common.sh at 387 PS2, Line 387: sed \ > Instead of replacing, you could use the append operator: [?] Thanks. Since this is not a blocker for you, I'll leave as-is here since I tested the previous version and I think we should merge this now, given that patches depending on this one have already been merged. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 07:16:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:16:47 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 07:16:47 +0000 Subject: Change in docker-playground[master]: ttcn3: write Osmocom repository to configs In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26385 ) Change subject: ttcn3: write Osmocom repository to configs ...................................................................... ttcn3: write Osmocom repository to configs Write a line like 'Misc_Helpers.mp_osmo_repo := "nightly"' into the TTCN-3 config file (e.g. BSC_Tests.cfg), before starting the testsuite. This allows executing different code paths in the tests based on the repository. Related: OS#5327 Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 --- M jenkins-common.sh M ttcn3-bsc-test-vamos/jenkins.sh M ttcn3-bsc-test/jenkins-sccplite.sh M ttcn3-bsc-test/jenkins.sh M ttcn3-bscnat-test/jenkins.sh M ttcn3-bts-test/jenkins.sh M ttcn3-cbc-test/jenkins.sh M ttcn3-fr-test/jenkins.sh M ttcn3-gbproxy-test-fr/jenkins.sh M ttcn3-gbproxy-test/jenkins.sh M ttcn3-ggsn-test/jenkins.sh M ttcn3-hlr-test/jenkins.sh M ttcn3-hnodeb-test/jenkins.sh M ttcn3-mgw-test/jenkins.sh M ttcn3-msc-test/jenkins.sh M ttcn3-ns-test/jenkins-fr.sh M ttcn3-ns-test/jenkins-sgsn-sns.sh M ttcn3-ns-test/jenkins-sns.sh M ttcn3-ns-test/jenkins.sh M ttcn3-pcap-client-test/jenkins.sh M ttcn3-pcu-test/jenkins-sns.sh M ttcn3-pcu-test/jenkins.sh M ttcn3-remsim-test/jenkins.sh M ttcn3-sccp-test/jenkins.sh M ttcn3-sgsn-test/jenkins.sh M ttcn3-sip-test/jenkins.sh M ttcn3-smlc-test/jenkins.sh M ttcn3-stp-test/jenkins.sh 28 files changed, 67 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/jenkins-common.sh b/jenkins-common.sh index ef6fad9..d4258d2 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -355,6 +355,41 @@ esac } +# Write the Osmocom repository to the TTCN3 config file, so the tests may take +# different code paths (OS#5327) +# $1: path to TTCN3 config file (e.g. BSC_Tests.cfg) +write_mp_osmo_repo() { + local repo="nightly" + local config="$1" + local line + + if ! [ -e "$config" ]; then + set +x + echo + echo "ERROR: TTCN3 config file '$config' not found in $PWD" + echo + exit 1 + fi + + case "$IMAGE_SUFFIX" in + latest*) + repo="latest" + ;; + 20*q*-*) # e.g. 2021q1-centos8 + repo="$(echo "$IMAGE_SUFFIX" | cut -d- -f 1)" # e.g. 2021q1 + ;; + *) + ;; + esac + + line="Misc_Helpers.mp_osmo_repo := \"$repo\"" + + sed \ + -i \ + "s/\[MODULE_PARAMETERS\]/\[MODULE_PARAMETERS\]\n$line/g" \ + "$config" +} + set -x # non-jenkins execution: assume local user name diff --git a/ttcn3-bsc-test-vamos/jenkins.sh b/ttcn3-bsc-test-vamos/jenkins.sh index 6462977..e8ec34d 100755 --- a/ttcn3-bsc-test-vamos/jenkins.sh +++ b/ttcn3-bsc-test-vamos/jenkins.sh @@ -13,6 +13,7 @@ mkdir $VOL_BASE_DIR/bsc-tester cp BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index bc6eaa0..7565a8d 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/bsc-tester cp sccplite/BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg" mkdir $VOL_BASE_DIR/bsc cp sccplite/osmo-bsc.cfg $VOL_BASE_DIR/bsc/ diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index 18236a2..3898491 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -13,6 +13,7 @@ mkdir $VOL_BASE_DIR/bsc-tester cp BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-bscnat-test/jenkins.sh b/ttcn3-bscnat-test/jenkins.sh index 1182df0..a63cdad 100755 --- a/ttcn3-bscnat-test/jenkins.sh +++ b/ttcn3-bscnat-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/bscnat-tester cp BSCNAT_Tests.cfg $VOL_BASE_DIR/bscnat-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/bscnat-tester/BSCNAT_Tests.cfg" mkdir $VOL_BASE_DIR/bscnat cp osmo-bsc-nat.cfg $VOL_BASE_DIR/bscnat/ diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 67c6d07..4ce333e 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -119,12 +119,16 @@ mkdir $VOL_BASE_DIR/bts-tester-generic cp BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-generic/ +write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-generic/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-virtphy cp virtphy/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-virtphy/ +write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-virtphy/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-oml cp oml/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-oml/ +write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-oml/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-hopping cp fh/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-hopping/ +write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg" cp $VOL_BASE_DIR/bts-tester-generic/BTS_Tests.cfg \ $VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg.inc diff --git a/ttcn3-cbc-test/jenkins.sh b/ttcn3-cbc-test/jenkins.sh index 347623f..63bf3f9 100755 --- a/ttcn3-cbc-test/jenkins.sh +++ b/ttcn3-cbc-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/cbc-tester cp CBC_Tests.cfg $VOL_BASE_DIR/cbc-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/cbc-tester/CBC_Tests.cfg" mkdir $VOL_BASE_DIR/cbc cp osmo-cbc.cfg $VOL_BASE_DIR/cbc/ diff --git a/ttcn3-fr-test/jenkins.sh b/ttcn3-fr-test/jenkins.sh index c878000..6dbc6f1 100755 --- a/ttcn3-fr-test/jenkins.sh +++ b/ttcn3-fr-test/jenkins.sh @@ -16,6 +16,7 @@ chmod a+w $VOL_BASE_DIR/fr-tester cp FR_Tests.cfg $VOL_BASE_DIR/fr-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/fr-tester/FR_Tests.cfg" mkdir $VOL_BASE_DIR/frnet cp FRNET_Tests.cfg $VOL_BASE_DIR/frnet/ diff --git a/ttcn3-gbproxy-test-fr/jenkins.sh b/ttcn3-gbproxy-test-fr/jenkins.sh index d1ecb0a..f4827a8 100755 --- a/ttcn3-gbproxy-test-fr/jenkins.sh +++ b/ttcn3-gbproxy-test-fr/jenkins.sh @@ -29,6 +29,7 @@ # if we don't change permissions, dumpcap fails to write (despite starting it as root!) chmod a+w $VOL_BASE_DIR/gbproxy-tester cp GBProxy_Tests.cfg $VOL_BASE_DIR/gbproxy-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/gbproxy-tester/GBProxy_Tests.cfg" mkdir $VOL_BASE_DIR/gbproxy cp osmo-gbproxy.cfg $VOL_BASE_DIR/gbproxy/ diff --git a/ttcn3-gbproxy-test/jenkins.sh b/ttcn3-gbproxy-test/jenkins.sh index 3595c16..f8fae0f 100755 --- a/ttcn3-gbproxy-test/jenkins.sh +++ b/ttcn3-gbproxy-test/jenkins.sh @@ -17,6 +17,7 @@ chmod a+w $VOL_BASE_DIR/gbproxy-tester cp GBProxy_Tests.cfg $VOL_BASE_DIR/gbproxy-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/gbproxy-tester/GBProxy_Tests.cfg" mkdir $VOL_BASE_DIR/gbproxy cp osmo-gbproxy.cfg $VOL_BASE_DIR/gbproxy/ diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index ba5e76d..cdf9bf8 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -19,6 +19,7 @@ mkdir $VOL_BASE_DIR/ggsn-tester cp GGSN_Tests.cfg $VOL_BASE_DIR/ggsn-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/ggsn-tester/GGSN_Tests.cfg" mkdir $VOL_BASE_DIR/ggsn diff --git a/ttcn3-hlr-test/jenkins.sh b/ttcn3-hlr-test/jenkins.sh index e003e03..6702e40 100755 --- a/ttcn3-hlr-test/jenkins.sh +++ b/ttcn3-hlr-test/jenkins.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/hlr-tester cp HLR_Tests.cfg $VOL_BASE_DIR/hlr-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/hlr-tester/HLR_Tests.cfg" mkdir $VOL_BASE_DIR/hlr cp osmo-hlr.cfg $VOL_BASE_DIR/hlr/ diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh index 6ffa98a..8bcfbf4 100755 --- a/ttcn3-hnodeb-test/jenkins.sh +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/hnodeb-tester cp HNB_Tests.cfg $VOL_BASE_DIR/hnodeb-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/hnodeb-tester/HNB_Tests.cfg" mkdir $VOL_BASE_DIR/hnodeb cp osmo-hnodeb.cfg $VOL_BASE_DIR/hnodeb/ diff --git a/ttcn3-mgw-test/jenkins.sh b/ttcn3-mgw-test/jenkins.sh index f9d0133..c0cf2f5 100755 --- a/ttcn3-mgw-test/jenkins.sh +++ b/ttcn3-mgw-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/mgw-tester cp MGCP_Test.cfg $VOL_BASE_DIR/mgw-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/mgw-tester/MGCP_Test.cfg" mkdir $VOL_BASE_DIR/mgw cp osmo-mgw.cfg $VOL_BASE_DIR/mgw/ diff --git a/ttcn3-msc-test/jenkins.sh b/ttcn3-msc-test/jenkins.sh index dd91e24..937b91f 100755 --- a/ttcn3-msc-test/jenkins.sh +++ b/ttcn3-msc-test/jenkins.sh @@ -16,6 +16,7 @@ mkdir $VOL_BASE_DIR/msc-tester mkdir $VOL_BASE_DIR/msc-tester/unix cp MSC_Tests.cfg $VOL_BASE_DIR/msc-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/msc-tester/MSC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-ns-test/jenkins-fr.sh b/ttcn3-ns-test/jenkins-fr.sh index df23a35..e30f6f9 100755 --- a/ttcn3-ns-test/jenkins-fr.sh +++ b/ttcn3-ns-test/jenkins-fr.sh @@ -27,6 +27,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp fr/NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp fr/osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-ns-test/jenkins-sgsn-sns.sh b/ttcn3-ns-test/jenkins-sgsn-sns.sh index 4460380..4f90421 100755 --- a/ttcn3-ns-test/jenkins-sgsn-sns.sh +++ b/ttcn3-ns-test/jenkins-sgsn-sns.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp sgsn-sns/NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp sgsn-sns/osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-ns-test/jenkins-sns.sh b/ttcn3-ns-test/jenkins-sns.sh index 7fb899e..c2fd651 100755 --- a/ttcn3-ns-test/jenkins-sns.sh +++ b/ttcn3-ns-test/jenkins-sns.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp sns/NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp sns/osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-ns-test/jenkins.sh b/ttcn3-ns-test/jenkins.sh index aeb1ba9..af0552c 100755 --- a/ttcn3-ns-test/jenkins.sh +++ b/ttcn3-ns-test/jenkins.sh @@ -14,6 +14,7 @@ mkdir $VOL_BASE_DIR/ns-tester cp NS_Tests.cfg $VOL_BASE_DIR/ns-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/ns-tester/NS_Tests.cfg" mkdir $VOL_BASE_DIR/ns cp osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ diff --git a/ttcn3-pcap-client-test/jenkins.sh b/ttcn3-pcap-client-test/jenkins.sh index 60d44e6..253b6c2 100755 --- a/ttcn3-pcap-client-test/jenkins.sh +++ b/ttcn3-pcap-client-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/pcap-client-tester cp OPCAP_CLIENT_Tests.cfg $VOL_BASE_DIR/pcap-client-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/pcap-client-tester/OPCAP_CLIENT_Tests.cfg" mkdir $VOL_BASE_DIR/pcap-client cp osmo-pcap-client.cfg $VOL_BASE_DIR/pcap-client/ diff --git a/ttcn3-pcu-test/jenkins-sns.sh b/ttcn3-pcu-test/jenkins-sns.sh index aaed27a..4bd2480 100755 --- a/ttcn3-pcu-test/jenkins-sns.sh +++ b/ttcn3-pcu-test/jenkins-sns.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/pcu-tester mkdir $VOL_BASE_DIR/pcu-tester/unix cp sns/PCU_Tests.cfg $VOL_BASE_DIR/pcu-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" mkdir $VOL_BASE_DIR/pcu mkdir $VOL_BASE_DIR/pcu/unix diff --git a/ttcn3-pcu-test/jenkins.sh b/ttcn3-pcu-test/jenkins.sh index 11c77ad..dd5b924 100755 --- a/ttcn3-pcu-test/jenkins.sh +++ b/ttcn3-pcu-test/jenkins.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/pcu-tester mkdir $VOL_BASE_DIR/pcu-tester/unix cp PCU_Tests.cfg $VOL_BASE_DIR/pcu-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/pcu-tester/PCU_Tests.cfg" mkdir $VOL_BASE_DIR/pcu mkdir $VOL_BASE_DIR/pcu/unix diff --git a/ttcn3-remsim-test/jenkins.sh b/ttcn3-remsim-test/jenkins.sh index ae013d6..2a6a9d8 100755 --- a/ttcn3-remsim-test/jenkins.sh +++ b/ttcn3-remsim-test/jenkins.sh @@ -75,6 +75,7 @@ # 1) server test suite start_server cp REMSIM_Tests.cfg $VOL_BASE_DIR/remsim-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/remsim-tester/REMSIM_Tests.cfg" start_testsuite docker container kill ${BUILD_TAG}-server @@ -82,6 +83,7 @@ echo "Changing to bankd configuration" start_bankd cp bankd/REMSIM_Tests.cfg $VOL_BASE_DIR/remsim-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/remsim-tester/REMSIM_Tests.cfg" start_testsuite docker container kill ${BUILD_TAG}-bankd @@ -89,4 +91,5 @@ echo "Changing to client configuration" start_client cp client/REMSIM_Tests.cfg $VOL_BASE_DIR/remsim-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/remsim-tester/REMSIM_Tests.cfg" start_testsuite diff --git a/ttcn3-sccp-test/jenkins.sh b/ttcn3-sccp-test/jenkins.sh index 40ff1f1..687e746 100755 --- a/ttcn3-sccp-test/jenkins.sh +++ b/ttcn3-sccp-test/jenkins.sh @@ -12,6 +12,7 @@ mkdir $VOL_BASE_DIR/sccp-tester cp SCCP_Tests.cfg $VOL_BASE_DIR/sccp-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/scpp-tester/SCCP_Tests.cfg" mkdir $VOL_BASE_DIR/sccp cp sccp_demo_user.cfg $VOL_BASE_DIR/sccp/ diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh index df500af..24869c5 100755 --- a/ttcn3-sgsn-test/jenkins.sh +++ b/ttcn3-sgsn-test/jenkins.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/sgsn-tester cp SGSN_Tests.cfg $VOL_BASE_DIR/sgsn-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/sgsn-tester/SGSN_Tests.cfg" mkdir $VOL_BASE_DIR/sgsn cp osmo-sgsn.cfg $VOL_BASE_DIR/sgsn/ diff --git a/ttcn3-sip-test/jenkins.sh b/ttcn3-sip-test/jenkins.sh index ffec3d2..334f791 100755 --- a/ttcn3-sip-test/jenkins.sh +++ b/ttcn3-sip-test/jenkins.sh @@ -15,6 +15,7 @@ mkdir $VOL_BASE_DIR/sip-tester mkdir $VOL_BASE_DIR/sip-tester/unix cp SIP_Tests.cfg $VOL_BASE_DIR/sip-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/sip-tester/SIP_Tests.cfg" mkdir $VOL_BASE_DIR/sip mkdir $VOL_BASE_DIR/sip/unix diff --git a/ttcn3-smlc-test/jenkins.sh b/ttcn3-smlc-test/jenkins.sh index f16536f..8aeed92 100755 --- a/ttcn3-smlc-test/jenkins.sh +++ b/ttcn3-smlc-test/jenkins.sh @@ -12,6 +12,7 @@ mkdir $VOL_BASE_DIR/smlc-tester cp SMLC_Tests.cfg $VOL_BASE_DIR/smlc-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/smlc-tester/SMLC_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ diff --git a/ttcn3-stp-test/jenkins.sh b/ttcn3-stp-test/jenkins.sh index db2ffdd..23434f3 100755 --- a/ttcn3-stp-test/jenkins.sh +++ b/ttcn3-stp-test/jenkins.sh @@ -11,6 +11,7 @@ mkdir $VOL_BASE_DIR/stp-tester cp STP_Tests.cfg $VOL_BASE_DIR/stp-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/stp-tester/STP_Tests.cfg" mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic06532f7a67e59458652c5cf4c8f6fee8113e703 Gerrit-Change-Number: 26385 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:35:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:35:06 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 07:35:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:35:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:35:42 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 07:35:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:36:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:36:31 +0000 Subject: Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 ) Change subject: sim slots: omit interrupt disabling for status polling ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb Gerrit-Change-Number: 26395 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 07:36:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:36:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:36:39 +0000 Subject: Change in osmo-ccid-firmware[master]: ccid usb handler: fix init flag In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 ) Change subject: ccid usb handler: fix init flag ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2a1d13b26c578ce3a343e06c2756dd07befcdb7f Gerrit-Change-Number: 26396 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 07:36:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:36:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:36:47 +0000 Subject: Change in osmo-ccid-firmware[master]: debug usb-cdc uart: disable it. In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 ) Change subject: debug usb-cdc uart: disable it. ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb Gerrit-Change-Number: 26398 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 30 Nov 2021 07:36:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:37:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:37:05 +0000 Subject: Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 ) Change subject: sim slots: omit interrupt disabling for status polling ...................................................................... sim slots: omit interrupt disabling for status polling Doesn't matter here, we don't care if we get interrupted. Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb --- M sysmoOCTSIM/ncn8025.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/ncn8025.c b/sysmoOCTSIM/ncn8025.c index 74d3b39..04d0ebe 100644 --- a/sysmoOCTSIM/ncn8025.c +++ b/sysmoOCTSIM/ncn8025.c @@ -98,7 +98,9 @@ bool ncn8025_interrupt_level(uint8_t slot) { uint8_t pin = slot2int_pin(slot); - return gpio_get_pin_level(pin); + uint32_t pin_values = hri_port_read_IN_reg(PORT, GPIO_PORT(pin)); + + return (bool)(pin_values & (0x01U << GPIO_PIN(pin))); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb Gerrit-Change-Number: 26395 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:37:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:37:06 +0000 Subject: Change in osmo-ccid-firmware[master]: ccid usb handler: fix init flag In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 ) Change subject: ccid usb handler: fix init flag ...................................................................... ccid usb handler: fix init flag Change-Id: I2a1d13b26c578ce3a343e06c2756dd07befcdb7f --- M sysmoOCTSIM/usb/class/ccid/device/ccid_df.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c index 665f0fc..e418010 100644 --- a/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c +++ b/sysmoOCTSIM/usb/class/ccid/device/ccid_df.c @@ -129,7 +129,7 @@ usb_d_ep_deinit(func_data->func_ep_irq); } - _ccid_df_funcd.enabled = true; + _ccid_df_funcd.enabled = false; return ERR_NONE; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2a1d13b26c578ce3a343e06c2756dd07befcdb7f Gerrit-Change-Number: 26396 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:37:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:37:06 +0000 Subject: Change in osmo-ccid-firmware[master]: makefile: disable libosmocore logging functions In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26397 ) Change subject: makefile: disable libosmocore logging functions ...................................................................... makefile: disable libosmocore logging functions Change-Id: Ic4a55639cd5ace0ef8325d903b0a6b5b41781073 --- M sysmoOCTSIM/gcc/Makefile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile index 9df0c01..b9e89f9 100644 --- a/sysmoOCTSIM/gcc/Makefile +++ b/sysmoOCTSIM/gcc/Makefile @@ -13,6 +13,8 @@ CFLAGS=-x c -mthumb -DDEBUG -Os -ffunction-sections -fdata-sections -mlong-calls \ -g3 -Wall -c -std=gnu99 $(CFLAGS_CPU) -DOCTSIMFWBUILD -DDISABLE_DFU_DETACH=$(DISABLE_DFU_DETACH) +CFLAGS += -DLIBOSMOCORE_NO_LOGGING + CC = $(CROSS_COMPILE)gcc LD = $(CROSS_COMPILE)ld SIZE = $(CROSS_COMPILE)size -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic4a55639cd5ace0ef8325d903b0a6b5b41781073 Gerrit-Change-Number: 26397 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:37:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:37:06 +0000 Subject: Change in osmo-ccid-firmware[master]: debug usb-cdc uart: disable it. In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 ) Change subject: debug usb-cdc uart: disable it. ...................................................................... debug usb-cdc uart: disable it. Currently unused. Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb --- M sysmoOCTSIM/main.c M sysmoOCTSIM/usb_descriptors.c M sysmoOCTSIM/usb_descriptors.h M sysmoOCTSIM/usb_start.c 4 files changed, 27 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 101af30..bf145cd 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -506,8 +506,10 @@ usb_start(); board_init(); - command_init("sysmoOCTSIM> "); +#ifdef WITH_DEBUG_CDC + command_init("sysmoOCTSIM> "); +#endif /* boost uart priority by setting all other irqs to uartprio+1 */ for(int i = 0; i < PERIPH_COUNT_IRQn; i++) NVIC_SetPriority(i, 2); diff --git a/sysmoOCTSIM/usb_descriptors.c b/sysmoOCTSIM/usb_descriptors.c index 7652bf6..94a473e 100644 --- a/sysmoOCTSIM/usb_descriptors.c +++ b/sysmoOCTSIM/usb_descriptors.c @@ -46,17 +46,24 @@ .bLength = sizeof(struct usb_config_desc), .bDescriptorType = USB_DT_CONFIG, .wTotalLength = sizeof(usb_fs_descs.cfg) + +#ifdef WITH_DEBUG_CDC sizeof(usb_fs_descs.cdc) + +#endif sizeof(usb_fs_descs.ccid) + sizeof(usb_fs_descs.dfu_rt) + sizeof(usb_fs_descs.func_dfu), +#ifdef WITH_DEBUG_CDC .bNumInterfaces = 4, +#else + .bNumInterfaces = 2, +#endif .bConfigurationValue = CONF_USB_CDCD_ACM_BCONFIGVAL, .iConfiguration = STR_DESC_CONFIG, .bmAttributes = CONF_USB_CDCD_ACM_BMATTRI, /* FIXME: The device should offer at least one 100mA configuration. */ .bMaxPower = 250, /* request 500mA */ }, +#ifdef WITH_DEBUG_CDC .cdc = { .comm = { .iface = { @@ -139,6 +146,7 @@ }, }, }, +#endif .ccid = { .iface = { .bLength = sizeof(struct usb_iface_desc), @@ -208,7 +216,11 @@ }, }, }, +#ifdef WITH_DEBUG_CDC DFURT_IF_DESCRIPTOR(3, STR_DESC_INTF_DFURT), +#else + DFURT_IF_DESCRIPTOR(1, STR_DESC_INTF_DFURT), +#endif .str = { #if 0 CDCD_ACM_STR_DESCES diff --git a/sysmoOCTSIM/usb_descriptors.h b/sysmoOCTSIM/usb_descriptors.h index ba879f7..8733b2c 100644 --- a/sysmoOCTSIM/usb_descriptors.h +++ b/sysmoOCTSIM/usb_descriptors.h @@ -43,6 +43,7 @@ struct usb_dev_desc dev; struct usb_config_desc cfg; +#ifdef WITH_DEBUG_CDC /* CDC-ACM: Two interfaces, one with IRQ EP and one with BULK IN + OUT */ struct { struct { @@ -59,6 +60,7 @@ } data; } cdc; +#endif /* CCID: One interface with CCID class descriptor and three endpoints */ struct { struct usb_iface_desc iface; diff --git a/sysmoOCTSIM/usb_start.c b/sysmoOCTSIM/usb_start.c index a4b787e..d4057be 100644 --- a/sysmoOCTSIM/usb_start.c +++ b/sysmoOCTSIM/usb_start.c @@ -132,14 +132,14 @@ usbdc_init(ctrl_buffer); usbdc_register_handler(USBDC_HDL_REQ, &string_req_h); +#ifdef WITH_DEBUG_CDC /* usbdc_register_funcion inside */ cdcdf_acm_init(); - +#endif dfudf_init(); printf("usb_descs_size=%u\r\n", usb_descs[0].eod - usb_descs[0].sod); - usbdc_start((struct usbd_descriptors *) usb_descs); - usbdc_attach(); + } /** @@ -147,15 +147,22 @@ */ void usb_start(void) { + +#ifdef WITH_DEBUG_CDC while (!cdcdf_acm_is_enabled()) { // wait cdc acm to be installed }; cdcdf_acm_register_callback(CDCDF_ACM_CB_STATE_C, (FUNC_PTR)usb_device_cb_state_c); +#endif + while (!ccid_df_is_enabled()); } void usb_init(void) { cdc_device_acm_init(); ccid_df_init(); + usbdc_start((struct usbd_descriptors *) usb_descs); + usbdc_attach(); + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb Gerrit-Change-Number: 26398 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:42:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:42:28 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... Patch Set 5: (1 comment) If I read this correctly, you are preventing a PPS from happening by spoofing the response at CCID level. Why is it then that the actual code performing PPS still needs to be modified? https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c File ccid_common/ccid_slot_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400/5/ccid_common/ccid_slot_fsm.c at 153 PS5, Line 153: #ifndef __NOP > there is no change here? you go from __NOP() to __NOP ? at least that's what gerrit shows. Looks like somethign that should be in the previous commit? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 07:42:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:42:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:42:43 +0000 Subject: Change in osmo-ccid-firmware[master]: jenkins: build libosmocore without logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 ) Change subject: jenkins: build libosmocore without logging ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5e8ce681e557c41c920959e3651910203f1d527a Gerrit-Change-Number: 26402 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 07:42:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:44:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:44:18 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 ) Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... Patch Set 4: > because i can break on it.. this is exactly the kind of information that should then be in a comment in the code (and optionally also in the commit log). -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 07:44:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:44:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:44:31 +0000 Subject: Change in osmo-ccid-firmware[master]: 7816 fsm: emphasize the inner workings of the static msgb macro In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26401 ) Change subject: 7816 fsm: emphasize the inner workings of the static msgb macro ...................................................................... 7816 fsm: emphasize the inner workings of the static msgb macro Change-Id: I37226d1fe2c14adb2b2d97608496dbb1661be543 --- M ccid_common/iso7816_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c index 7ea842d..d82380b 100644 --- a/ccid_common/iso7816_fsm.c +++ b/ccid_common/iso7816_fsm.c @@ -46,9 +46,9 @@ memset(name, 0x00, sizeof(name ## _msgbuf)); \ name->data_len = sizeof(name ## _msgbuf) - sizeof(struct msgb); \ name->len = 0; \ - name->data = name->_data; \ - name->head = name->_data; \ - name->tail = name->_data; \ + name->data = &name->_data[0]; \ + name->head = &name->_data[0]; \ + name->tail = &name->_data[0]; \ } #define COPY_TO_STATIC_MSGB(src, dst) { \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I37226d1fe2c14adb2b2d97608496dbb1661be543 Gerrit-Change-Number: 26401 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:44:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:44:31 +0000 Subject: Change in osmo-ccid-firmware[master]: jenkins: build libosmocore without logging In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 ) Change subject: jenkins: build libosmocore without logging ...................................................................... jenkins: build libosmocore without logging Depends-On: Ia4c78abe5f198139f96ffa289998855be2477585 Change-Id: I5e8ce681e557c41c920959e3651910203f1d527a --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fec91e5..7877dcf 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -41,7 +41,7 @@ mkdir -p "$inst/stow" autoreconf --install --force ./configure --enable-static --prefix="$inst/stow/libosmocore" --host=arm-none-eabi \ - --enable-embedded --disable-doxygen --disable-shared --disable-pseudotalloc \ + --enable-embedded --disable-log-macros --disable-doxygen --disable-shared --disable-pseudotalloc \ --disable-libsctp --disable-libusb --disable-gb --enable-external-tests \ --disable-libmnl \ CFLAGS="-Os -ffunction-sections -fdata-sections -nostartfiles -nodefaultlibs -Werror -Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp -mthumb -Os -mlong-calls -g3 -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 -I /home/laforge/projects/git/osmo-ccid-firmware/sysmoOCTSIM -Wno-error=format" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5e8ce681e557c41c920959e3651910203f1d527a Gerrit-Change-Number: 26402 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 07:49:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 07:49:57 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 6: I'm not sure if it made sense to alrady "factor out" some of the core/generic osmo_prim-socket related handling and make osmo-hnodeb directly start with just being a user. I'm thinking roughly of the level of abstraction that libosmo-netif provides for creating a server and client around a SEQ_PACKET unix domain socket, and making the related send/receive functions already aware there is something with a primitive header passed around. In fact, the user API could directly work with osmo_prim as we know it, hiding the serialization/deserialization inside the API. Yes, it's easier doing it "flat" here in the application, but I'm afraid if we postpone the "generic socket" part for too long there will be ugly fall-out later when migrating due to some subtle difference here or there. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 07:49:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:28:08 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Nov 2021 08:28:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, pespin, lynxis lazus, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 to look at the new patch set (#5). Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... gbproxy: Add flush_ll test without new bvci Depends: Ic33d08992ea84af006d133db6aec508a7b7c7f28 (osmo-ttcn3-hacks) Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Related: OS#5332 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 39 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/26372/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:28:08 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Nov 2021 08:28:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Update expected-results.xml In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 to look at the new patch set (#2). Change subject: gbproxy: Update expected-results.xml ...................................................................... gbproxy: Update expected-results.xml Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 --- M gbproxy/expected-results.xml 1 file changed, 10 insertions(+), 37 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/88/26388/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:30:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 08:30:34 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Patch Set 4: (5 comments) > Patch Set 4: > > (5 comments) > > I think in general it would be better if we could have a textual config file containing the mappings of redmine project name vs. git repository. Would we use this text file for something else? I could create an extra text file and put the mapping there, but I'm not sure if we should add the logic to fetch and interpret that if nothing else is using it. Isn't the mapping inside the jenkins job very readable and easy to update if needed? Note that also this is for the special cases, it seems that newer projects are created with the same gerrit project name, redmine project name and redmine repository name. For OsmoHLR for example, no mapping entry is needed: https://osmocom.org/projects/osmo-hlr/repository/osmo-hlr > Or, obviously, any method that doesn't require manually kept configuration which will soon be outdated as somebody forgets about it... The jenkins job will fail if the URL downloaded at the end returns a 404. So if the mapping is wrong somewhere, or we add a new project that doesn't have the standard naming scheme, I will get a mail and can fix it. I think updating this mapping is low maintenance, and errors will get noticed quickly. As mentioned in the commit message, I have considered other approaches too but they seemed like more effort. It is not like there's one redmine api call that lists all repositories in all projects. https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml File jobs/redmine-fetch.yml: https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 45 PS4, Line 45: libusrp > libusrp could be secondary repo of osmo-trx? I don't think I have all needed permissions to add them. For some redmine projects, I can edit the listed repositories. But they require a local path, and - following the existing naming scheme - /usr/local/git/repositories/libusrp.git does apparently not exist. When adding the repository as such, it gives a 404. Can you create those? https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 45 PS4, Line 45: libgtpnl > should be added as secondary repo to osmo-ggsn? Same, /usr/local/git/repositories/libgtpnl.git does not exist https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 51 PS4, Line 51: osmo-iuh > this is certainly a but, the repository should be added to redmine I've missed that it's here, patch updated: https://osmocom.org/projects/osmohnbgw/repository/osmo-iuh/ https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 54 PS4, Line 54: osmocom-lcs > osmocom-lcs can be added as secondary repo to the osmo-bsc redmine project, in case there is no smlc [?] Added successfully to osmo-smlc: https://osmocom.org/projects/osmo-smlc/repository/osmocom-lcs https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 54 PS4, Line 54: osmo-upf > a related redmine project with repository should be created There's a redmine project: https://osmocom.org/projects/osmo-upf But I don't have permissions to modify the repositories. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 08:30:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:30:49 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 08:30:49 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 to look at the new patch set (#5). Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... jobs/redmine-fetch: close issues on gerrit merge Add a job that is triggered by every gerrit merge, which translates the GERRIT_PROJECT to the redmine project + repository and then triggers a repository fetch by downloading the repository view url. Redmine will then also parse the "Closes: OS#..." tags from commit messages and mark related issues as resolved. Redmine does not have a setting to fetch the repositories periodically by itself, the redmine wiki recommends setting up a cron job or a serverside git hook that also triggers the repository fetch. I have considered implementing such a hook in gerrit instead, but then we would not be able to see the logs as easily and notice failures. Another consideration was fetching all redmine projects and associated git repositories via redmine API and then just triggering a repository fetch on all of them, in order to avoid the mapping from gerrit <> redmine. However, the redmine API apparently doesn't list the repositories and one would need to iterate through the projects, recursively. I have tested this job and verified that GERRIT_PROJECT gets set as expected. Closes: OS#5331 Related: https://jenkins.osmocom.org/jenkins/job/redmine-fetch/ Related: https://www.redmine.org/projects/redmine/wiki/RedmineSettings#Fetch-commits-automatically Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 --- A jobs/redmine-fetch.yml 1 file changed, 116 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/23/26423/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:33:08 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Nov 2021 08:33:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Update expected-results.xml In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 ) Change subject: gbproxy: Update expected-results.xml ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388/1/gbproxy/osmo-gbproxy.cfg-client File gbproxy/osmo-gbproxy.cfg-client: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388/1/gbproxy/osmo-gbproxy.cfg-client at 1 PS1, Line 1: ! > configs added on purpose? if so, I'd put them in a separate commit or at least mention it in the com [?] Thanks, seems I added those by mistake. Removed -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Tue, 30 Nov 2021 08:33:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:38:58 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 08:38:58 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Patch Set 5: Or maybe I'm thinking too complicated... we could set up a cronjob that calls "bin/rails runner "Repository.fetch_changesets" -e production" in the redmine docker container every 10 minutes or so, it seems that then we don't need to set up a mapping. https://www.redmine.org/projects/redmine/wiki/RedmineSettings#Fetch-commits-automatically The "downside" is that it doesn't close issues immediately after merging gerrit patches, but that's probably not important. If you prefer that solution, I'll try to put this in docker-playground.git/redmine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 08:38:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:40:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 08:40:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 08:40:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 08:41:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 08:41:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Update expected-results.xml In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 ) Change subject: gbproxy: Update expected-results.xml ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 08:41:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:19:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 09:19:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Update expected-results.xml In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 ) Change subject: gbproxy: Update expected-results.xml ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 09:19:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:20:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 09:20:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 09:20:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:36:12 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 30 Nov 2021 09:36:12 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... Abandoned in favor of https://gerrit.osmocom.org/c/osmo-msc/+/26406/ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:36:22 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 30 Nov 2021 09:36:22 +0000 Subject: Change in osmo-msc[master]: msc: always require ciphering for UTRAN In-Reply-To: References: Message-ID: lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26390 ) Change subject: msc: always require ciphering for UTRAN ...................................................................... Abandoned in favor of https://gerrit.osmocom.org/c/osmo-msc/+/26406/ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8896ecc2f23c8fdb2b3e83b3aeabd55a0911a612 Gerrit-Change-Number: 26390 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:36:40 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 30 Nov 2021 09:36:40 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: lynxis lazus has restored this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: restore -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:38:58 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Nov 2021 09:38:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Add flush_ll test without new bvci In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 ) Change subject: gbproxy: Add flush_ll test without new bvci ...................................................................... gbproxy: Add flush_ll test without new bvci Depends: Ic33d08992ea84af006d133db6aec508a7b7c7f28 (osmo-ttcn3-hacks) Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Related: OS#5332 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 39 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index f569eaf..5f5d835 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -2357,7 +2357,7 @@ * FLUSH-LL procedure ***********************************************************************/ -private function f_TC_flush_ll(charstring id) runs on BSSGP_ConnHdlr { +private function f_TC_flush_ll_bvci_new(charstring id) runs on BSSGP_ConnHdlr { var BssgpBvci bvci := g_pars.pcu[0].cfg.bvc[0].bvci; var integer i; for (i := 0; i < 10; i := i+1) { @@ -2367,18 +2367,46 @@ f_sgsn2pcu(pdu_tx, pdu_rx, use_sig := true); - pdu_tx := ts_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(0, 1), 23, bvci_new := bvci); + pdu_tx := ts_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(1, 1), 23, bvci_new := bvci); /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */ - pdu_rx := tr_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(0, 1), 23, bvci_new := bvci); + pdu_rx := tr_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(1, 1), 23, bvci_new := bvci); f_pcu2sgsn(pdu_tx, pdu_rx, use_sig := true); } setverdict(pass); } -testcase TC_flush_ll() runs on test_CT + +testcase TC_flush_ll_bvci_new() runs on test_CT { f_init(); - f_start_handlers(refers(f_TC_flush_ll), testcasename(), 6); + f_start_handlers(refers(f_TC_flush_ll_bvci_new), testcasename(), 6); + /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */ + f_cleanup(); +} + +private function f_TC_flush_ll_no_bvci_new(charstring id) runs on BSSGP_ConnHdlr { + var BssgpBvci bvci := g_pars.pcu[0].cfg.bvc[0].bvci; + var integer i; + for (i := 0; i < 10; i := i+1) { + var template (value) PDU_BSSGP pdu_tx := ts_BSSGP_FLUSH_LL(g_pars.tlli, bvci); + /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */ + var template (present) PDU_BSSGP pdu_rx := tr_BSSGP_FLUSH_LL(g_pars.tlli, bvci); + + f_sgsn2pcu(pdu_tx, pdu_rx, use_sig := true); + + pdu_tx := ts_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(0, 1), 23); + /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */ + pdu_rx := tr_BSSGP_FLUSH_LL_ACK(g_pars.tlli, int2oct(0, 1), 23); + + f_pcu2sgsn(pdu_tx, pdu_rx, use_sig := true); + } + setverdict(pass); +} + +testcase TC_flush_ll_no_bvci_new() runs on test_CT +{ + f_init(); + f_start_handlers(refers(f_TC_flush_ll_no_bvci_new), testcasename(), 6); /* TODO: start multiple handlers (UEs) on various cells on same and other NSEs */ f_cleanup(); } @@ -3643,7 +3671,12 @@ execute( TC_rim_from_eutran() ); - execute( TC_flush_ll() ); + execute( TC_flush_ll_bvci_new() ); + + /* Depends on osmo-gbproxy > 0.2.0 */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_flush_ll_no_bvci_new() ); + } execute( TC_fc_bvc() ); execute( TC_fc_ms() ); execute( TC_ms_reg_enq() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af6f0829bf10031b86e587529b86706fea3a413 Gerrit-Change-Number: 26372 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:38:59 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Nov 2021 09:38:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Update expected-results.xml In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 ) Change subject: gbproxy: Update expected-results.xml ...................................................................... gbproxy: Update expected-results.xml Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 --- M gbproxy/expected-results.xml 1 file changed, 10 insertions(+), 37 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/gbproxy/expected-results.xml b/gbproxy/expected-results.xml index e2e4918..6221f10 100644 --- a/gbproxy/expected-results.xml +++ b/gbproxy/expected-results.xml @@ -20,6 +20,7 @@ + @@ -63,44 +64,16 @@ - + + - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN[0] side: { pDU_BSSGP_MS_REGISTRATION_ENQUIRY := { bssgpPduType := '14'O, iMSI := { iEI := '0D'O (\"\\r\"), ext := '1'B, lengthIndicator := ?, type_of_Identity := '001'B, oddevenIndicator := ?, digits := '262420000000000'H }, mME_Query := * } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_ms_reg_enq testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '2A1F84C218002304820926'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_sig_ul_tlli testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '070D8809101010325476980A82000004824E2B208442180023'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_sig_ul_tmsi testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '00C21800230050001682FFFF0E822342'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_ptp_ul_tlli testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on SGSN side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '070D8809101010325476980A82000004824E2B208442180023'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_ptp_ul_tmsi testcase - - - - "/osmo-ttcn3-hacks/gbproxy/GBProxy_Tests.ttcn:MASKED : Timeout waiting for BSSGP on PCU side: { pDU_BSSGP_STATUS := { bssgpPduType := '41'O (\"A\"), cause := { iEI := '07'O (\"\\a\"), ext := '1'B, lengthIndicator := { length1 := 1 }, cause_Value := '01'O }, bVCI := omit, pDU_in_Error := { iEI := '15'O, ext := '1'B, lengthIndicator := { length1 := ? }, erroneous_BSSGP_PDU := '2C1F84123456780F811004824E2B2583000017'O } } }" - GBProxy_Tests.ttcn:MASKED GBProxy_Tests control part - GBProxy_Tests.ttcn:MASKED TC_status_sig_dl_bvci testcase - - + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id987d1c8e4a901ff9397f0e58072bc039de4e030 Gerrit-Change-Number: 26388 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:50:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 09:50:39 +0000 Subject: Change in osmo-msc[master]: msc: always require ciphering for UTRAN In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26390 ) Change subject: msc: always require ciphering for UTRAN ...................................................................... Patch Set 2: > Abandoned in favor of https://gerrit.osmocom.org/c/osmo-msc/+/26406/ Sorry, I wish I saw this patch before I started fixing it myself. Took me a while to fix the unit tests :) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8896ecc2f23c8fdb2b3e83b3aeabd55a0911a612 Gerrit-Change-Number: 26390 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 30 Nov 2021 09:50:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:53:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 09:53:26 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 2: Code-Review+1 Good catch. Can we rebase it on top of https://gerrit.osmocom.org/c/osmo-msc/+/26409? Or vice versa, I can rabase my patches on top of this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 09:53:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 09:53:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 09:53:47 +0000 Subject: Change in osmo-msc[master]: libvlr: vlr_set_ciph_mode(): avoid redundant check In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26405 ) Change subject: libvlr: vlr_set_ciph_mode(): avoid redundant check ...................................................................... libvlr: vlr_set_ciph_mode(): avoid redundant check This function is never called when ciph_required is false, so there is no need for an additional check in this function. Change-Id: I900ddd5f1882f8cee234ab1074adcf25830a092c --- M include/osmocom/msc/vlr.h M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_lu_fsm.c 4 files changed, 0 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/msc/vlr.h b/include/osmocom/msc/vlr.h index f12e906..d752dfb 100644 --- a/include/osmocom/msc/vlr.h +++ b/include/osmocom/msc/vlr.h @@ -472,7 +472,6 @@ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool ciph_required, bool umts_aka, bool retrieve_imeisv); diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 23bd671..fc23b37 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1382,13 +1382,9 @@ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool ciph_required, bool umts_aka, bool retrieve_imeisv) { - if (!ciph_required) - return 0; - LOGPFSML(fi, LOGL_DEBUG, "Set Ciphering Mode\n"); return vlr->ops.set_ciph_mode(msc_conn_ref, umts_aka, retrieve_imeisv); } diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index b3660ff..b880fcf 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -299,7 +299,6 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, par->msc_conn_ref, - par->ciphering_required, umts_aka, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 53e614d..41e5608 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -878,7 +878,6 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, lfp->msc_conn_ref, - lfp->ciphering_required, umts_aka, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I900ddd5f1882f8cee234ab1074adcf25830a092c Gerrit-Change-Number: 26405 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:03:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 10:03:03 +0000 Subject: Change in osmo-hnodeb[master]: Drop NAS and RANAP code and VTY commands In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 to look at the new patch set (#3). Change subject: Drop NAS and RANAP code and VTY commands ...................................................................... Drop NAS and RANAP code and VTY commands The higher level bits were used in originally imported hnb-test code in order to control interaction with the HNBGW over the VTY. This is no longer needed in osmo-hnodeb, as NAS is in layers above the ones being handled by an hNodeB. Regarding RANAP, most of it is going to be handled by the LowerLayer UD socket peer to be introduced in the future, so we can drop most of it, as in osmo-hnodeb we'll basically be speaking RUA to the HNBGW and passing RANAP buffers transparently. We keep the .c/.h files since some small helpers functions will be ntroduced later on when adding support for the mentioned LL socket. Related: SYS#5516 Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h D include/osmocom/hnodeb/nas.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c D src/osmo-hnodeb/nas.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 12 files changed, 2 insertions(+), 550 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/12/26412/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 Gerrit-Change-Number: 26412 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:05:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 10:05:55 +0000 Subject: Change in osmo-hnodeb[master]: Drop NAS and RANAP code and VTY commands In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 ) Change subject: Drop NAS and RANAP code and VTY commands ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 Gerrit-Change-Number: 26412 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 10:05:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:05:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 10:05:57 +0000 Subject: Change in osmo-hnodeb[master]: Drop NAS and RANAP code and VTY commands In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 ) Change subject: Drop NAS and RANAP code and VTY commands ...................................................................... Drop NAS and RANAP code and VTY commands The higher level bits were used in originally imported hnb-test code in order to control interaction with the HNBGW over the VTY. This is no longer needed in osmo-hnodeb, as NAS is in layers above the ones being handled by an hNodeB. Regarding RANAP, most of it is going to be handled by the LowerLayer UD socket peer to be introduced in the future, so we can drop most of it, as in osmo-hnodeb we'll basically be speaking RUA to the HNBGW and passing RANAP buffers transparently. We keep the .c/.h files since some small helpers functions will be ntroduced later on when adding support for the mentioned LL socket. Related: SYS#5516 Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 --- M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnodeb.h D include/osmocom/hnodeb/nas.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c D src/osmo-hnodeb/nas.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 12 files changed, 2 insertions(+), 550 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index b1acb7e..6fa587d 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -3,7 +3,6 @@ hnbap.h \ hnodeb.h \ iuh.h \ - nas.h \ ranap.h \ rua.h \ vty.h \ diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 3bc2fb3..a629b4e 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -34,7 +34,6 @@ DRUA, DRANAP, DSCTP, - DNAS, }; extern const struct log_info hnb_log_info; diff --git a/include/osmocom/hnodeb/nas.h b/include/osmocom/hnodeb/nas.h deleted file mode 100644 index f6a7976..0000000 --- a/include/osmocom/hnodeb/nas.h +++ /dev/null @@ -1,24 +0,0 @@ -/* (C) 2015 by Daniel Willmann - * (C) 2021 by sysmocom - s.f.m.c. GmbH - * Author: Pau Espin Pedrol - * All Rights Reserved - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#pragma once - -struct hnb; -void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len); diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h index 15e0609..474de70 100644 --- a/include/osmocom/hnodeb/ranap.h +++ b/include/osmocom/hnodeb/ranap.h @@ -19,15 +19,4 @@ */ #pragma once -struct hnb; -struct ranap_message_s; -#include -void hnb_rx_iu_release(struct hnb *hnb); -void hnb_rx_paging(struct hnb *hnb, const char *imsi); -void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg); - -void hnb_rua_dt_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg); -void hnb_rua_cl_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg); -void hnb_tx_iu_release_req(struct hnb *hnb); -struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi); diff --git a/include/osmocom/hnodeb/rua.h b/include/osmocom/hnodeb/rua.h index 52221be..ea7e81c 100644 --- a/include/osmocom/hnodeb/rua.h +++ b/include/osmocom/hnodeb/rua.h @@ -25,4 +25,3 @@ struct msgb; int hnb_rua_rx(struct hnb *hnb, struct msgb *msg); -int hnb_tx_dt(struct hnb *hnb, struct msgb *txm); diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h index 7144d3f..e30019e 100644 --- a/include/osmocom/hnodeb/vty.h +++ b/include/osmocom/hnodeb/vty.h @@ -27,7 +27,6 @@ enum hnb_vty_nodes { HNODEB_NODE = _LAST_OSMOVTY_NODE, IUH_NODE, - CHAN_NODE, }; void hnb_vty_init(void); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 7325728..82ccd37 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -35,7 +35,6 @@ hnb.c \ hnb_shutdown_fsm.c \ iuh.c \ - nas.c \ ranap.c \ rua.c \ vty.c \ diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index 10d1655..45ccc0c 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -47,11 +47,6 @@ .color = "\033[1;36m", .description = "SCTP connection on the Iuh link", }, - [DNAS] = { - .name = "NAS", .loglevel = LOGL_NOTICE, .enabled = 1, - .color = "\033[1;32m", - .description = "Non-Access Stratum", - }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/nas.c b/src/osmo-hnodeb/nas.c deleted file mode 100644 index 293c46e..0000000 --- a/src/osmo-hnodeb/nas.c +++ /dev/null @@ -1,268 +0,0 @@ -/* (C) 2015 by Daniel Willmann - * (C) 2021 by sysmocom - s.f.m.c. GmbH - * Author: Pau Espin Pedrol - * All Rights Reserved - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see . - * - */ - -#include "config.h" - -#include -#include -#include - -#include -#include -#include -#include -#include - -#include - -#include -#include -#include -#include - -static struct msgb *gen_nas_id_resp() -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - GSM48_MT_MM_ID_RESP, - /* IMEISV */ - 0x09, /* len */ - 0x03, /* first digit (0000) + even (0) + id IMEISV (011) */ - 0x31, 0x91, 0x06, 0x00, 0x28, 0x47, 0x11, /* digits */ - 0xf2, /* filler (1111) + last digit (0010) */ - }; - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct msgb *gen_nas_tmsi_realloc_compl() -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - GSM48_MT_MM_TMSI_REALL_COMPL, - }; - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct msgb *gen_nas_auth_resp(uint8_t *sres) -{ - uint8_t id_resp[] = { - GSM48_PDISC_MM, - 0x80 | GSM48_MT_MM_AUTH_RESP, /* simulate sequence nr 2 */ - 0x61, 0xb5, 0x69, 0xf5 /* hardcoded SRES */ - }; - - memcpy(id_resp + 2, sres, 4); - - return ranap_new_msg_dt(0, id_resp, sizeof(id_resp)); -} - -static struct tlv_parsed *parse_mm(struct gsm48_hdr *gh, int len) -{ - static struct tlv_parsed tp; - int parse_res; - - len -= (const char *)&gh->data[0] - (const char *)gh; - - OSMO_ASSERT(gsm48_hdr_pdisc(gh) == GSM48_PDISC_MM); - - parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); - if (parse_res <= 0) { - uint8_t msg_type = gsm48_hdr_msg_type(gh); - LOGP(DNAS, LOGL_ERROR, "Error parsing MM message 0x%hhx: %d\n", msg_type, parse_res); - return NULL; - } - - return &tp; -} - -int hnb_nas_rx_lu_accept(struct gsm48_hdr *gh, int len, int *sent_tmsi) -{ - LOGP(DNAS, LOGL_INFO, " :D Location Update Accept :D\n"); - struct gsm48_loc_area_id *lai; - - lai = (struct gsm48_loc_area_id *)&gh->data[0]; - - struct osmo_location_area_id laid; - gsm48_decode_lai2(lai, &laid); - LOGP(DNAS, LOGL_INFO, "LU: mcc %s mnc %s lac %hd\n", - osmo_mcc_name(laid.plmn.mcc), osmo_mnc_name(laid.plmn.mnc, laid.plmn.mnc_3_digits), - laid.lac); - - struct tlv_parsed tp; - int parse_res; - - len -= (const char *)&gh->data[0] - (const char *)gh; - parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, &gh->data[0], len, 0, 0); - if (parse_res <= 0) { - LOGP(DNAS, LOGL_ERROR, "Error parsing Location Update Accept message: %d\n", parse_res); - return -1; - } - - if (TLVP_PRESENT(&tp, GSM48_IE_MOBILE_ID)) { - uint8_t type = TLVP_VAL(&tp, GSM48_IE_NAME_SHORT)[0] & 0x0f; - if (type == GSM_MI_TYPE_TMSI) - *sent_tmsi = 1; - else *sent_tmsi = 0; - } - return 0; -} - -void hnb_nas_rx_mm_info(struct gsm48_hdr *gh, int len) -{ - LOGP(DNAS, LOGL_INFO, " :) MM Info :)\n"); - struct tlv_parsed *tp = parse_mm(gh, len); - if (!tp) - return; - - if (TLVP_PRESENT(tp, GSM48_IE_NAME_SHORT)) { - char name[128] = {0}; - gsm_7bit_decode_n(name, 127, - TLVP_VAL(tp, GSM48_IE_NAME_SHORT)+1, - (TLVP_LEN(tp, GSM48_IE_NAME_SHORT)-1)*8/7); - LOGP(DNAS, LOGL_INFO, "Info: Short Network Name: %s\n", name); - } - - if (TLVP_PRESENT(tp, GSM48_IE_NAME_LONG)) { - char name[128] = {0}; - gsm_7bit_decode_n(name, 127, - TLVP_VAL(tp, GSM48_IE_NAME_LONG)+1, - (TLVP_LEN(tp, GSM48_IE_NAME_LONG)-1)*8/7); - LOGP(DNAS, LOGL_INFO, "Info: Long Network Name: %s\n", name); - } -} - -static int hnb_nas_rx_auth_req(struct hnb *hnb, struct gsm48_hdr *gh, - int len) -{ - struct gsm48_auth_req *ar; - - len -= (const char *)&gh->data[0] - (const char *)gh; - - if (len < sizeof(*ar)) { - LOGP(DNAS, LOGL_ERROR, "GSM48 Auth Req does not fit.\n"); - return -1; - } - - LOGP(DNAS, LOGL_INFO, " :) Authentication Request :)\n"); - - ar = (struct gsm48_auth_req*) &gh->data[0]; - int seq = ar->key_seq; - - /* Generate SRES from *HARDCODED* Ki for Iuh testing */ - struct osmo_auth_vector vec; - /* Ki 000102030405060708090a0b0c0d0e0f */ - struct osmo_sub_auth_data auth = { - .type = OSMO_AUTH_TYPE_GSM, - .algo = OSMO_AUTH_ALG_COMP128v1, - .u.gsm.ki = { - 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, - 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, - 0x0e, 0x0f - }, - }; - - memset(&vec, 0, sizeof(vec)); - osmo_auth_gen_vec(&vec, &auth, ar->rand); - - LOGP(DNAS, LOGL_DEBUG, "seq %d rand %s", - seq, osmo_hexdump(ar->rand, sizeof(ar->rand))); - LOGP(DNAS, LOGL_DEBUG, " --> sres %s\n", - osmo_hexdump(vec.sres, 4)); - - return hnb_tx_dt(hnb, gen_nas_auth_resp(vec.sres)); -} - -static int hnb_nas_rx_mm(struct hnb *hnb, struct gsm48_hdr *gh, int len) -{ - struct hnb_chan *chan; - - chan = hnb->cs.chan; - if (!chan) { - LOGP(DNAS, LOGL_ERROR, "hnb_nas_rx_mm(): No CS channel established yet.\n"); - return -1; - } - - OSMO_ASSERT(!chan->is_ps); - - uint8_t msg_type = gsm48_hdr_msg_type(gh); - int sent_tmsi; - - switch (msg_type) { - case GSM48_MT_MM_ID_REQ: - return hnb_tx_dt(hnb, gen_nas_id_resp()); - - case GSM48_MT_MM_LOC_UPD_ACCEPT: - if (hnb_nas_rx_lu_accept(gh, len, &sent_tmsi)) - return -1; - if (sent_tmsi) - return hnb_tx_dt(hnb, gen_nas_tmsi_realloc_compl()); - else - return 0; - - case GSM48_MT_MM_LOC_UPD_REJECT: - LOGP(DNAS, LOGL_INFO, "Received Location Update Reject\n"); - return 0; - - case GSM48_MT_MM_INFO: - hnb_nas_rx_mm_info(gh, len); - hnb_tx_iu_release_req(hnb); - return 0; - - case GSM48_MT_MM_AUTH_REQ: - return hnb_nas_rx_auth_req(hnb, gh, len); - - default: - LOGP(DNAS, LOGL_INFO, "04.08 message type not handled by hnb-test: 0x%x\n", - msg_type); - return 0; - } - -} - -void hnb_nas_rx_dtap(struct hnb *hnb, void *data, int len) -{ - int rc; - LOGP(DNAS, LOGL_INFO, "got %d bytes: %s\n", len, osmo_hexdump(data, len)); - - // nas_pdu == '05 08 12' ==> IMEI Identity request - // '05 04 0d' ==> LU reject - - struct gsm48_hdr *gh = data; - if (len < sizeof(*gh)) { - LOGP(DNAS, LOGL_ERROR, "hnb_nas_rx_dtap(): NAS PDU is too short: %d. Ignoring.\n", - len); - return; - } - uint8_t pdisc = gsm48_hdr_pdisc(gh); - - switch (pdisc) { - case GSM48_PDISC_MM: - rc = hnb_nas_rx_mm(hnb, gh, len); - if (rc != 0) - LOGP(DNAS, LOGL_ERROR, "Error receiving MM message: %d\n", rc); - return; - default: - LOGP(DNAS, LOGL_NOTICE, "04.08 discriminator not handled by hnb-test: %d\n", - pdisc); - return; - } -} diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c index b5b7b9c..99c4bab 100644 --- a/src/osmo-hnodeb/ranap.c +++ b/src/osmo-hnodeb/ranap.c @@ -25,152 +25,5 @@ #include #include -#include #include #include - -static const char *printstr(OCTET_STRING_t *s) -{ - return osmo_hexdump((const unsigned char*)s->buf, s->size); -} - -#define PP(octet_string_t) \ - LOGP(DRANAP, LOGL_INFO, #octet_string_t " = %s\n",\ - printstr(&octet_string_t)) - -void hnb_rua_dt_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg) -{ - struct hnb *hnb = (struct hnb *)ctx; - int len; - uint8_t *data; - RANAP_PermittedIntegrityProtectionAlgorithms_t *algs; - RANAP_IntegrityProtectionAlgorithm_t *first_alg; - - LOGP(DRANAP, LOGL_INFO, "rx ranap_msg->procedureCode %d\n", - ranap_msg->procedureCode); - - switch (ranap_msg->procedureCode) { - case RANAP_ProcedureCode_id_DirectTransfer: - LOGP(DRANAP, LOGL_INFO, "rx DirectTransfer: presence = %hx\n", - ranap_msg->msg.directTransferIEs.presenceMask); - PP(ranap_msg->msg.directTransferIEs.nas_pdu); - - len = ranap_msg->msg.directTransferIEs.nas_pdu.size; - data = ranap_msg->msg.directTransferIEs.nas_pdu.buf; - - hnb_nas_rx_dtap(hnb, data, len); - return; - - case RANAP_ProcedureCode_id_SecurityModeControl: - LOGP(DRANAP, LOGL_INFO, "rx SecurityModeControl: presence = %hx\n", - ranap_msg->msg.securityModeCommandIEs.presenceMask); - - /* Just pick the first available IP alg, don't care about - * encryption (yet?) */ - algs = &ranap_msg->msg.securityModeCommandIEs.integrityProtectionInformation.permittedAlgorithms; - if (algs->list.count < 1) { - LOGP(DRANAP, LOGL_INFO, "Security Mode Command: No permitted algorithms.\n"); - return; - } - first_alg = *algs->list.array; - - hnb_rx_secmode_cmd(hnb, *first_alg); - return; - - case RANAP_ProcedureCode_id_Iu_Release: - hnb_rx_iu_release(hnb); - return; - } -} - -void hnb_rua_cl_handle_ranap(void *ctx, struct ranap_message_s *ranap_msg) -{ - struct hnb *hnb = (struct hnb *)ctx; - char imsi[16]; - - LOGP(DRANAP, LOGL_INFO, "rx ranap_msg->procedureCode %d\n", - ranap_msg->procedureCode); - - switch (ranap_msg->procedureCode) { - case RANAP_ProcedureCode_id_Paging: - if (ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.present == RANAP_PermanentNAS_UE_ID_PR_iMSI) { - ranap_bcd_decode(imsi, sizeof(imsi), - ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.choice.iMSI.buf, - ranap_msg->msg.pagingIEs.permanentNAS_UE_ID.choice.iMSI.size); - } else imsi[0] = '\0'; - - LOGP(DRANAP, LOGL_INFO, "rx Paging: presence=%hx domain=%ld IMSI=%s\n", - ranap_msg->msg.pagingIEs.presenceMask, - ranap_msg->msg.pagingIEs.cN_DomainIndicator, - imsi - ); - - hnb_rx_paging(hnb, imsi); - return; - } -} - -struct msgb *gen_initue_lu(const struct hnb *hnb, int is_ps, uint32_t conn_id, const char *imsi) -{ - uint8_t lu[] = { GSM48_PDISC_MM, GSM48_MT_MM_LOC_UPD_REQUEST, - 0x70, 0x62, 0xf2, 0x30, 0xff, 0xf3, 0x57, - /* len, IMSI/type, IMSI-------------------------------- */ - 0x08, 0x29, 0x26, 0x24, 0x10, 0x32, 0x54, 0x76, 0x98, - 0x33, 0x03, 0x57, 0x18 , 0xb2 }; - uint8_t plmn_id[3]; - osmo_plmn_to_bcd(plmn_id, &hnb->plmn); - RANAP_GlobalRNC_ID_t rnc_id = { - .rNC_ID = g_hnb->rnc_id, - .pLMNidentity.buf = plmn_id, - .pLMNidentity.size = sizeof(plmn_id), - }; - - /* FIXME: patch imsi */ - /* Note: the Mobile Identitiy IE's IMSI data has the identity type and - * an even/odd indicator bit encoded in the first octet. So the first - * octet looks like this: - * - * 8 7 6 5 | 4 | 3 2 1 - * IMSI-digit | even/odd | type - * - * followed by the remaining IMSI digits. - * If digit count is even (bit 4 == 0), that first high-nibble is 0xf. - * (derived from Iu pcap Location Update Request msg and TS 25.413) - * - * TODO I'm only 90% sure about this - */ - - return ranap_new_msg_initial_ue(conn_id, is_ps, &rnc_id, lu, sizeof(lu)); -} - -void hnb_tx_iu_release_req(struct hnb *hnb) -{ - RANAP_Cause_t cause = { - .present = RANAP_Cause_PR_radioNetwork, - .choice.transmissionNetwork = RANAP_CauseRadioNetwork_release_due_to_UE_generated_signalling_connection_release, - }; - hnb_tx_dt(hnb, ranap_new_msg_iu_rel_req(&cause)); -} - -void hnb_tx_iu_release_compl(struct hnb *hnb) -{ - hnb_tx_dt(hnb, ranap_new_msg_iu_rel_compl()); -} - -void hnb_rx_secmode_cmd(struct hnb *hnb, long ip_alg) -{ - LOGP(DRANAP, LOGL_INFO, " :) Security Mode Command :)\n"); - /* not caring about encryption yet, just pass 0 for No Encryption. */ - hnb_tx_dt(hnb, ranap_new_msg_sec_mod_compl(ip_alg, 0)); -} - -void hnb_rx_iu_release(struct hnb *hnb) -{ - hnb_tx_iu_release_compl(hnb); -} - -void hnb_rx_paging(struct hnb *hnb, const char *imsi) -{ - LOGP(DRANAP, LOGL_INFO, " :) Paging Request for %s :)\n", imsi); - /* TODO reply */ -} diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 907cd60..9bf5403 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -21,6 +21,7 @@ #include #include +#include #include #include @@ -29,22 +30,7 @@ #include #include #include - -int hnb_tx_dt(struct hnb *hnb, struct msgb *txm) -{ - struct hnb_chan *chan; - struct msgb *rua; - - chan = hnb->cs.chan; - if (!chan) { - LOGP(DRUA, LOGL_INFO, "hnb_nas_tx_tmsi_realloc_compl(): No CS channel established yet.\n"); - return -1; - } - - rua = rua_new_dt(chan->is_ps, chan->conn_id, txm); - hnb_iuh_send(hnb, rua); - return 0; -} +#include static void hnb_rua_dt_handle(struct hnb *hnb, ANY_t *in) { @@ -57,7 +43,6 @@ return; } - rc = ranap_cn_rx_co(hnb_rua_dt_handle_ranap, hnb, ies.ranaP_Message.buf, ies.ranaP_Message.size); /* FIXME: what to do with the asn1c-allocated memory */ rua_free_directtransferies(&ies); @@ -74,7 +59,6 @@ return; } - rc = ranap_cn_rx_cl(hnb_rua_cl_handle_ranap, hnb, ies.ranaP_Message.buf, ies.ranaP_Message.size); /* FIXME: what to do with the asn1c-allocated memory */ rua_free_connectionlesstransferies(&ies); diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index e11fc2d..93ec25f 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -270,41 +270,9 @@ } -static struct cmd_node chan_node = { - CHAN_NODE, - "%s(chan)> ", - 1, -}; - -#define HNBAP_STR "HNBAP related commands\n" -#define HNB_STR "HomeNodeB commands\n" -#define UE_STR "User Equipment commands\n" #define RANAP_STR "RANAP related commands\n" #define CSPS_STR "Circuit Switched\n" "Packet Switched\n" -DEFUN(hnb_register, hnb_register_cmd, - "hnbap hnb register", HNBAP_STR HNB_STR "Send HNB-REGISTER REQUEST") -{ - hnb_send_register_req(g_hnb); - - return CMD_SUCCESS; -} - -DEFUN(hnb_deregister, hnb_deregister_cmd, - "hnbap hnb deregister", HNBAP_STR HNB_STR "Send HNB-DEREGISTER REQUEST") -{ - hnb_send_deregister_req(g_hnb); - - return CMD_SUCCESS; -} - -DEFUN(ue_register, ue_register_cmd, - "hnbap ue register IMSI", HNBAP_STR UE_STR "Send UE-REGISTER REQUEST") -{ - hnb_ue_register_tx(g_hnb, argv[0]); - - return CMD_SUCCESS; -} DEFUN(asn_dbg, asn_dbg_cmd, "asn-debug (1|0)", "Enable or disable libasn1c debugging") @@ -336,40 +304,6 @@ return CMD_SUCCESS; } -DEFUN(chan, chan_cmd, - "channel (cs|ps) lu imsi IMSI", - "Open a new Signalling Connection\n" - "To Circuit-Switched CN\n" - "To Packet-Switched CN\n" - "Performing a Location Update\n" - ) -{ - struct hnb_chan *chan; - struct msgb *msg, *rua; - static uint16_t conn_id = 42; - - chan = talloc_zero(tall_hnb_ctx, struct hnb_chan); - if (!strcmp(argv[0], "ps")) - chan->is_ps = 1; - chan->imsi = talloc_strdup(chan, argv[1]); - chan->conn_id = conn_id; - conn_id++; - - msg = gen_initue_lu(g_hnb, chan->is_ps, chan->conn_id, chan->imsi); - rua = rua_new_conn(chan->is_ps, chan->conn_id, msg); - - hnb_iuh_send(g_hnb, rua); - - vty->index = chan; - vty->node = CHAN_NODE; - - if (!chan->is_ps) - g_hnb->cs.chan = chan; - - - return CMD_SUCCESS; -} - void hnb_vty_init(void) { install_element(CONFIG_NODE, &cfg_hnodeb_cmd); @@ -389,11 +323,5 @@ install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_port_cmd); install_element_ve(&asn_dbg_cmd); - install_element_ve(&hnb_register_cmd); - install_element_ve(&hnb_deregister_cmd); - install_element_ve(&ue_register_cmd); install_element_ve(&ranap_reset_cmd); - install_element_ve(&chan_cmd); - - install_node(&chan_node, NULL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6aae54734c1c4607beede19169f16bafe35b3a61 Gerrit-Change-Number: 26412 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:05:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 10:05:59 +0000 Subject: Change in osmo-bts[master]: debian/control: add osmo-bts meta-package References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26424 ) Change subject: debian/control: add osmo-bts meta-package ...................................................................... debian/control: add osmo-bts meta-package Add an osmo-bts meta-package that depends on the subpackages osmo-bts-trx and osmo-bts-virtual. This is important, because the downstream packaging of debian does not split osmo-bts in subpackages, it has only one osmo-bts package. So without this, when installing "osmo-bts" in debian while having the Osmocom binary package repository installed and expecting to get the newer version, the user will actually get the older version from debian. Closes: OS#5319 Related: https://salsa.debian.org/debian-mobcom-team/osmo-bts/-/blob/master/debian/control Change-Id: I1a6edf2eb146616ac51b7957368a8d057caa685f --- M debian/control 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/24/26424/1 diff --git a/debian/control b/debian/control index 0bdf48c..2cb152d 100644 --- a/debian/control +++ b/debian/control @@ -17,9 +17,25 @@ Vcs-Git: git://git.osmocom.org/osmo-bts Homepage: https://projects.osmocom.org/projects/osmobts +Package: osmo-bts +Architecture: any +Depends: osmo-bts-trx, osmo-bts-virtual, ${misc:Depends} +Description: Base Transceiver Station for GSM + OsmoBTS is a software implementation of Layer2/3 of a BTS. It implements the + following protocols/interfaces: + LAPDm (GSM 04.06) + RTP + A-bis/IP in IPA multiplex + OML (GSM TS 12.21) + RSL (GSM TS 08.58) + . + OsmoBTS is modular and has support for multiple back-ends. A back-end talks to + a specific L1/PHY implementation of the respective BTS hardware. Based on this + architecture, it should be relatively easy to add a new back-end to support + so-far unsupported GSM PHY/L1 and associated hardware. + Package: osmo-bts-trx Architecture: any -Conflicts: osmo-bts Depends: ${shlibs:Depends}, ${misc:Depends} Description: osmo-bts-trx GSM BTS with osmo-trx osmo-bts-trx to be used with the osmo-trx application @@ -34,7 +50,6 @@ Package: osmo-bts-virtual Architecture: any -Conflicts: osmo-bts Depends: ${shlibs:Depends}, ${misc:Depends} Description: Virtual Osmocom GSM BTS (no RF hardware; GSMTAP/UDP) This version of OsmoBTS doesn't use actual GSM PHY/Hardware/RF, but -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a6edf2eb146616ac51b7957368a8d057caa685f Gerrit-Change-Number: 26424 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:15:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 10:15:34 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Patch Set 5: (1 comment) I'll remove the job from jenkins for now, until it's clear how to move forward https://gerrit.osmocom.org/c/osmo-ci/+/26423/5/jobs/redmine-fetch.yml File jobs/redmine-fetch.yml: https://gerrit.osmocom.org/c/osmo-ci/+/26423/5/jobs/redmine-fetch.yml at 106 PS5, Line 106: ;; osmo-hnodeb: /usr/local/git/repositories/osmo-hnodeb.git does not exist either, can this be fixed? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 10:15:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:42:50 2021 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Tue, 30 Nov 2021 10:42:50 +0000 Subject: Change in osmo-ccid-firmware[master]: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b8... References: Message-ID: roh has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 ) Change subject: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb ...................................................................... update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb Change-Id: I0d4a072d18011ffb00d6251481473b19d5a97c50 --- M tests/sysmo-octsim/03_check_lsusb.out 1 file changed, 3 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/25/26425/1 diff --git a/tests/sysmo-octsim/03_check_lsusb.out b/tests/sysmo-octsim/03_check_lsusb.out index bdc7672..2dc3f09 100644 --- a/tests/sysmo-octsim/03_check_lsusb.out +++ b/tests/sysmo-octsim/03_check_lsusb.out @@ -18,8 +18,8 @@ Configuration Descriptor: bLength 9 bDescriptorType 2 - wTotalLength 0x00a9 - bNumInterfaces 4 + wTotalLength 0x006f + bNumInterfaces 2 bConfigurationValue 1 iConfiguration 3 A bmAttributes 0x80 @@ -28,68 +28,6 @@ Interface Descriptor: bLength 9 bDescriptorType 4 - bInterfaceNumber 1 - bAlternateSetting 0 - bNumEndpoints 1 - bInterfaceClass 2 Communications - bInterfaceSubClass 2 Abstract (modem) - bInterfaceProtocol 0 - iInterface 4 debug UART - CDC Header: - bcdCDC 10.01 - CDC Call Management: - bmCapabilities 0x01 - call management - bDataInterface 0 - CDC ACM: - bmCapabilities 0x02 - line coding and serial state - CDC Union: - bMasterInterface 1 - bSlaveInterface 2 - Endpoint Descriptor: - bLength 7 - bDescriptorType 5 - bEndpointAddress 0x82 EP 2 IN - bmAttributes 3 - Transfer Type Interrupt - Synch Type None - Usage Type Data - wMaxPacketSize 0x0040 1x 64 bytes - bInterval 10 - Interface Descriptor: - bLength 9 - bDescriptorType 4 - bInterfaceNumber 2 - bAlternateSetting 0 - bNumEndpoints 2 - bInterfaceClass 10 CDC Data - bInterfaceSubClass 0 - bInterfaceProtocol 0 - iInterface 5 debug UART - Endpoint Descriptor: - bLength 7 - bDescriptorType 5 - bEndpointAddress 0x01 EP 1 OUT - bmAttributes 2 - Transfer Type Bulk - Synch Type None - Usage Type Data - wMaxPacketSize 0x0040 1x 64 bytes - bInterval 0 - Endpoint Descriptor: - bLength 7 - bDescriptorType 5 - bEndpointAddress 0x81 EP 1 IN - bmAttributes 2 - Transfer Type Bulk - Synch Type None - Usage Type Data - wMaxPacketSize 0x0040 1x 64 bytes - bInterval 0 - Interface Descriptor: - bLength 9 - bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 3 @@ -157,7 +95,7 @@ Interface Descriptor: bLength 9 bDescriptorType 4 - bInterfaceNumber 3 + bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 254 Application Specific Interface -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0d4a072d18011ffb00d6251481473b19d5a97c50 Gerrit-Change-Number: 26425 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:47:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 10:47:26 +0000 Subject: Change in osmo-ccid-firmware[master]: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b8... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 ) Change subject: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0d4a072d18011ffb00d6251481473b19d5a97c50 Gerrit-Change-Number: 26425 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 10:47:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 10:50:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 10:50:26 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Patch Set 5: > Patch Set 5: > > Or maybe I'm thinking too complicated... we could set up a cronjob that calls "bin/rails runner "Repository.fetch_changesets" -e production" in the redmine docker container every 10 minutes or so, it seems that then we don't need to set up a mapping. excellent. > The "downside" is that it doesn't close issues immediately after merging gerrit patches, but that's probably not important. no, the exact time is not important, 10mins is fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 10:50:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 11:30:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 11:30:35 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml File jobs/redmine-fetch.yml: https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 45 PS4, Line 45: libgtpnl > Same, /usr/local/git/repositories/libgtpnl. [?] both exist. weird. root at c37eaef71382:/usr/local/git/repositories# ls -l osmo-ggsn.git/ -d drwxr-xr-x+ 7 _apt ssh 4096 Nov 22 15:22 osmo-ggsn.git/ root at c37eaef71382:/usr/local/git/repositories# ls -ld libgtpnl.git/ drwxr-xr-x+ 7 _apt ssh 4096 Nov 22 15:22 libgtpnl.git/ also "find libgtpnl.git \! -readable" doesn't return any non-readable files. https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 54 PS4, Line 54: osmo-upf > There's a redmine project: https://osmocom.org/projects/osmo-upf [?] done, but same strange permissiosn problem -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 11:30:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:07:09 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:07:09 +0000 Subject: Change in osmo-msc[master]: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26406 ) Change subject: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6205f13453eff7afbf25e013d72ae98a78fcd31b Gerrit-Change-Number: 26406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 13:07:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:14:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 13:14:13 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 13:14:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:14:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 13:14:16 +0000 Subject: Change in osmo-msc[master]: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26406 ) Change subject: libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN ...................................................................... libvlr: fix is_ciph_required(): always send SecModeCmd for UTRAN Ciphering is optional in both GERAN and UTRAN, however for the later it's *required* to enable integrity protection for the signalling. Thus we must always send Security Mode Command in UTRAN, even in case if ciphering is disabled (UEA0) in the configuration. The actual decision whether to send CMC/SMC or not is taken in: * vlr_access_req_fsm.c / _proc_arq_vlr_node2(), and * vlr_lu_fsm.c / vlr_loc_upd_post_auth(). depending on the value returned by is_ciph_required(). Let's rename this function to is_cmc_smc_required() and ensure that it always returns true in UTRAN. This change fixes the Iu test cases in ttcn3-msc-test. Change-Id: I6205f13453eff7afbf25e013d72ae98a78fcd31b Fixes: OS#5333 --- M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_test_umts_authen.err 4 files changed, 178 insertions(+), 111 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index b880fcf..8daaaad 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -267,9 +267,12 @@ _proc_arq_vlr_node2_post_vlr(fi); } -static bool is_ciph_required(struct proc_arq_priv *par) +/* Determine if sending of CMC/SMC is required */ +static bool is_cmc_smc_required(struct proc_arq_priv *par) { - return par->ciphering_required; + /* UTRAN: always send SecModeCmd, even if ciphering is not required. + * GERAN: avoid sending CiphModeCmd if ciphering is not required. */ + return par->is_utran || par->ciphering_required; } static void _proc_arq_vlr_node2(struct osmo_fsm_inst *fi) @@ -280,7 +283,7 @@ LOGPFSM(fi, "%s()\n", __func__); - if (!is_ciph_required(par)) { + if (!is_cmc_smc_required(par)) { _proc_arq_vlr_node2_post_ciph(fi); return; } diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 41e5608..4f603b3 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -702,10 +702,12 @@ (lfp->ciphering_required && !auth_try_reuse_tuple(lfp->vsub, lfp->key_seq)); } -/* Determine if ciphering is required */ -static bool is_ciph_required(struct lu_fsm_priv *lfp) +/* Determine if sending of CMC/SMC is required */ +static bool is_cmc_smc_required(struct lu_fsm_priv *lfp) { - return lfp->ciphering_required; + /* UTRAN: always send SecModeCmd, even if ciphering is not required. + * GERAN: avoid sending CiphModeCmd if ciphering is not required. */ + return lfp->is_utran || lfp->ciphering_required; } /* Determine if a HLR Update is required */ @@ -853,7 +855,7 @@ OSMO_ASSERT(vsub); - if (!is_ciph_required(lfp)) { + if (!is_cmc_smc_required(lfp)) { vlr_loc_upd_post_ciph(fi); return; } diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index f132cdf..0a2a446 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -124,31 +124,38 @@ VERBOSE_ASSERT(auth_request_sent, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "27497388b6cb044648f396aa155b95ef"); - ms_sends_msg("0554" "e229c19e" "2104" "791f2e41"); - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); - gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(1); - VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0554" "e229c19e" "2104" "791f2e41"); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "27497388b6cb044648f396aa155b95ef"); + ms_sends_msg("0554" "e229c19e" "2104" "791f2e41"); + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); + gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } btw("HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT"); @@ -198,28 +205,35 @@ EXPECT_ACCEPTED(false); thwart_rx_non_initial_requests(); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "1159ec926a50e98c034a6b7d7c9f418d"); - ms_sends_msg("0554" "7db47cf7" "2104" "f81e4dc7"); /* 2nd vector's res, s.a. */ - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); - ms_sends_security_mode_complete(1); - VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts with a CM Service Accept"); gsup_expect_tx(NULL); ms_sends_msg("0554" "7db47cf7" "2104" "f81e4dc7"); /* 2nd vector's res, s.a. */ VERBOSE_ASSERT(cm_service_result_sent, == RES_ACCEPT, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "1159ec926a50e98c034a6b7d7c9f418d"); + ms_sends_msg("0554" "7db47cf7" "2104" "f81e4dc7"); /* 2nd vector's res, s.a. */ + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept"); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d"); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } /* Release connection */ @@ -265,27 +279,34 @@ EXPECT_ACCEPTED(false); thwart_rx_non_initial_requests(); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "eb50e770ddcc3060101d2f43b6c2b884"); - ms_sends_msg("0554" "706f9967" "2104" "19ba609c"); /* 3nd vector's res, s.a. */ - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts and sends SMS"); - dtap_expect_tx(sms); - ms_sends_security_mode_complete(1); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts and sends pending SMS"); dtap_expect_tx(sms); ms_sends_msg("0554" "706f9967" "2104" "19ba609c"); /* 3nd vector's res, s.a. */ VERBOSE_ASSERT(dtap_tx_confirmed, == true, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "eb50e770ddcc3060101d2f43b6c2b884"); + ms_sends_msg("0554" "706f9967" "2104" "19ba609c"); /* 3nd vector's res, s.a. */ + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts and sends SMS"); + dtap_expect_tx(sms); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } btw("SMS was delivered, no requests pending for subscr"); @@ -516,31 +537,38 @@ VERBOSE_ASSERT(auth_request_sent, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - if (encryption) { - if (via_ran == OSMO_RAT_GERAN_A) { + switch (via_ran) { + case OSMO_RAT_GERAN_A: + if (encryption) { btw("Test code not implemented"); OSMO_ASSERT(false); - } else { - /* On UTRAN */ - btw("Encryption enabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl"); - expect_security_mode_ctrl(NULL, "8a90c769b7272f3bb7a1c1fbb1ea9349"); - ms_sends_msg("0554" "1df5f0b4" "2104" "f22b696e"); - VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); - - btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); - gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); - ms_sends_security_mode_complete(1); - VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); - VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); } - } else { - /* Encryption disabled */ + btw("Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR"); gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0554" "1df5f0b4" "2104" "f22b696e"); VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + case OSMO_RAT_UTRAN_IU: + /* Even if encryption is disabled (UEA0), we still expect a SecurityModeControl + * message indicating UIA, because integrity protection is mandatory in UTRAN. */ + btw("Encryption %sabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl", + encryption ? "en" : "dis"); + expect_security_mode_ctrl(NULL, "8a90c769b7272f3bb7a1c1fbb1ea9349"); + ms_sends_msg("0554" "1df5f0b4" "2104" "f22b696e"); + VERBOSE_ASSERT(security_mode_ctrl_sent, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + + btw("MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR"); + gsup_expect_tx("04010809710000000156f0" CN_DOMAIN VLR_TO_HLR); + ms_sends_security_mode_complete(encryption ? 0x01 : 0x00); + VERBOSE_ASSERT(gsup_tx_confirmed, == true, "%d"); + VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); + break; + default: + btw("Unhandled RAT %s", osmo_rat_type_name(via_ran)); + OSMO_ASSERT(false); } btw("HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT"); diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.err b/tests/msc_vlr/msc_vlr_test_umts_authen.err index 76f822f..543c9d3 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.err +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.err @@ -660,7 +660,7 @@ <-- GSUP rx OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT: vlr_gsupc_read_cb() returns 0 auth_request_sent == 1 lu_result_sent == 0 -- Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (lu,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -675,18 +675,28 @@ DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_RES DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_auth() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_ciph() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=27497388b6cb044648f396aa155b95ef +DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) + security_mode_ctrl_sent == 1 + lu_result_sent == 0 +- MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR +DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: Received Event VLR_ULA_E_CIPH_RES +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_post_ciph() DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_node_4() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_node_4() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Allocated DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: is child of vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Received Event UPD_HLR_VLR_E_START GSUP --> HLR: OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST: 04010809710000000156f02801020a0101 DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: state_chg to UPD_HLR_VLR_S_WAIT_FOR_DATA -DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) gsup_tx_confirmed == 1 lu_result_sent == 0 - HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT @@ -864,7 +874,7 @@ DRLL msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Dispatching 04.08 message: SMS SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Message not permitted for initial conn: SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN decode error (rc=-13) for DTAP from MSC-I -- Encryption disabled. MS sends Authen Response, VLR accepts with a CM Service Accept +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (cm_service_sms,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -879,25 +889,31 @@ DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){VLR_SUB_AS_AUTHENTICATED}: Removing from parent Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ) DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: Received Event PR_ARQ_E_AUTH_RES DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_ciph() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=1159ec926a50e98c034a6b7d7c9f418d +DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (cm_service_sms) + security_mode_ctrl_sent == 1 + cm_service_result_sent == 0 +- MS sends SecurityModeControl acceptance, VLR accepts; above Ciphering is an implicit CM Service Accept +DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: Received Event PR_ARQ_E_CIPH_RES +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_ciph() DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_vlr() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_pres() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_trace() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_imei() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: proc_arq_fsm_done(PASSED) -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_DONE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_vlr() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_pres() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_trace() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_imei() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: proc_arq_fsm_done(PASSED) +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_WAIT_CIPH}: state_chg to PR_ARQ_S_DONE DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){PR_ARQ_S_DONE}: Process Access Request result: PASSED -DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Sending DTAP: MM GSM48_MT_MM_CM_SERV_ACC -DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: RAN encode: DTAP on UTRAN-Iu -- DTAP --UTRAN-Iu--> MS: GSM48_MT_MM_CM_SERV_ACC: 0521 -DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: Received Event MSC_A_EV_AUTHENTICATED DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTH_CIPH}: state_chg to MSC_A_ST_AUTHENTICATED -DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTHENTICATED}: - rx_from_ms: now used by 1 (cm_service_sms) - cm_service_result_sent == 1 + cm_service_result_sent == 0 - Concluding CM Service Request DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTHENTICATED}: - cm_service_sms: now used by 0 (-) DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:CM_SERVICE_REQ){MSC_A_ST_AUTHENTICATED}: Received Event MSC_A_EV_UNUSED @@ -1020,7 +1036,7 @@ DRLL msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: Dispatching 04.08 message: SMS SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: Message not permitted for initial conn: SMS:0x01 DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN decode error (rc=-13) for DTAP from MSC-I -- Encryption disabled. MS sends Authen Response, VLR accepts and sends pending SMS +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (paging-response,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -1035,22 +1051,33 @@ DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){VLR_SUB_AS_AUTHENTICATED}: Removing from parent Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP) DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: Received Event PR_ARQ_E_AUTH_RES DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_ciph() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=eb50e770ddcc3060101d2f43b6c2b884 +DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (paging-response) + security_mode_ctrl_sent == 1 +- MS sends SecurityModeControl acceptance, VLR accepts and sends SMS +DIUCS msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: Received Event PR_ARQ_E_CIPH_RES +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_ciph() DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_node2_post_vlr() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_pres() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_trace() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: _proc_arq_vlr_post_imei() -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: proc_arq_fsm_done(PASSED) -DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_AUTH}: state_chg to PR_ARQ_S_DONE +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_node2_post_vlr() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_pres() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_trace() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: _proc_arq_vlr_post_imei() +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: proc_arq_fsm_done(PASSED) +DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_WAIT_CIPH}: state_chg to PR_ARQ_S_DONE DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_DONE}: Process Access Request result: PASSED DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: Received Event MSC_A_EV_AUTHENTICATED DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTH_CIPH}: state_chg to MSC_A_ST_AUTHENTICATED DPAG Paging: IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 for MT-SMS: Paging Response action (success) DPAG Paging: IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 for MT-SMS: Removing Paging Request DLSMS trans(SMS IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 callref-0x40000002 tid-0) mmsms_paging_cb(success) -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: + sms: now used by 3 (paging-response,rx_from_ms,sms) +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: + sms: now used by 2 (paging-response,sms) DLSMS SMC(0) message MMSMS-EST-CNF received in state MM_CONN_PENDING DLSMS SMC(0) send CP data DLSMS SMC(0) new CP state MM_CONN_PENDING -> WAIT_CP_ACK @@ -1062,10 +1089,7 @@ - DTAP matches expected message DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 - Paging: now used by 4 (attached,SMS-receiver,SMS,active-conn) -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: - paging-response: now used by 2 (rx_from_ms,sms) -DVLR VLR_Authenticate(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: - rx_from_ms: now used by 1 (sms) - dtap_tx_confirmed == 1 +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_AUTHENTICATED}: - paging-response: now used by 1 (sms) - SMS was delivered, no requests pending for subscr DREF VLR subscr IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100 + _test_umts_authen: now used by 5 (attached,SMS-receiver,SMS,active-conn,_test_umts_authen) llist_count(&vsub->cs.requests) == 0 @@ -1136,7 +1160,7 @@ DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_DONE}: Removing from parent msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP) DVLR Process_Access_Request_VLR(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){PR_ARQ_S_DONE}: Deferring: will deallocate with msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP) DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_RELEASED}: Removing from parent msub_fsm -DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_RELEASED}: max total use count was 3 +DREF msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_RELEASED}: max total use count was 2 DMSC msub_fsm{active}: Received Event MSUB_EV_ROLE_TERMINATED DMSC msub(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100) MSC-A terminated DMSC msub(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100) 1 MSC-I still active @@ -2158,7 +2182,7 @@ <-- GSUP rx OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT: vlr_gsupc_read_cb() returns 0 auth_request_sent == 1 lu_result_sent == 0 -- Encryption disabled. MS sends Authen Response, VLR accepts and sends GSUP LU Req to HLR +- Encryption disabled. MS sends Authen Response, VLR accepts and sends SecurityModeControl MSC <--UTRAN-Iu-- MS: GSM48_MT_MM_AUTH_RESP DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: + rx_from_ms: now used by 2 (lu,rx_from_ms) DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: DTAP @@ -2173,18 +2197,28 @@ DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_RES DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_auth() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_post_ciph() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Set Ciphering Mode +DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: CIPHER_MODE_COMMAND on UTRAN-Iu +- sending SecurityModeControl: ik=8a90c769b7272f3bb7a1c1fbb1ea9349 +DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_CIPH +DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated +DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) + security_mode_ctrl_sent == 1 + lu_result_sent == 0 +- MS sends SecurityModeControl acceptance, VLR accepts and sends GSUP LU Req to HLR +DIUCS msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN decode: CIPHER_MODE_COMPLETE +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: Received Event VLR_ULA_E_CIPH_RES +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_post_ciph() DMSC msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: RAN encode: COMMON_ID on UTRAN-Iu DMSC dummy_msc_i(IMSI-901700000010650:UTRAN-Iu:LU){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: vlr_loc_upd_node_4() -DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: vlr_loc_upd_node_4() +DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_CIPH}: state_chg to VLR_ULA_S_WAIT_HLR_UPD DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Allocated DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: is child of vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: Received Event UPD_HLR_VLR_E_START GSUP --> HLR: OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST: 04010809710000000156f02801020a0101 DVLR upd_hlr_vlr_fsm(IMSI-901700000010650:UTRAN-Iu:LU){UPD_HLR_VLR_S_INIT}: state_chg to UPD_HLR_VLR_S_WAIT_FOR_DATA -DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTHENTICATED}: Deallocated -DREF msc_a(IMSI-901700000010650:UTRAN-Iu:LU){MSC_A_ST_AUTH_CIPH}: - rx_from_ms: now used by 1 (lu) gsup_tx_confirmed == 1 lu_result_sent == 0 - HLR sends _INSERT_DATA_REQUEST, VLR responds with _INSERT_DATA_RESULT -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6205f13453eff7afbf25e013d72ae98a78fcd31b Gerrit-Change-Number: 26406 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:14:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 13:14:17 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): improve readability In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26409 ) Change subject: libmsc: ran_iu_make_security_mode_command(): improve readability ...................................................................... libmsc: ran_iu_make_security_mode_command(): improve readability Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d --- M src/libmsc/ran_msg_iu.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 8ffdd93..6705ab8 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -375,13 +375,15 @@ static struct msgb *ran_iu_make_security_mode_command(struct osmo_fsm_inst *caller_fi, const struct ran_cipher_mode_command *cm) { + bool use_encryption = cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0); LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, IK=%s, CK=%s\n", osmo_hexdump_nospc(cm->vec->ik, 16), - cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? osmo_hexdump_nospc(cm->vec->ck, 16) : "NONE"); + use_encryption ? osmo_hexdump_nospc(cm->vec->ck, 16) : "NONE"); /* TODO: Do we need to check if the UE supports all of the algorithms and build an intersection like * in the case of A5? */ - return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0) ? cm->vec->ck : NULL, + return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, + use_encryption ? cm->vec->ck : NULL, RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I14f4f9617f91ed17fb7614f218cb023a0231866d Gerrit-Change-Number: 26409 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:16:10 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:16:10 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 380 PS2, Line 380: | (1 << OSMO_UTRAN_UIA2); (would prefer the comment on its own line, and replace "it" with something explanatory like "make the choice of available UIA algorithms configurable", if that's what you mean) https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 390 PS2, Line 390: (uia_mask << 1), /* API treats LSB as UIA0 */ > I think it's confusing using those values that way, because they are to be used in the protocol code [?] here I prefer the patch as-is, and also prefer keeping the value as in the spec. if we make up a "weird" bitmask then converting explicitly is best, i.e. exactly as it is in the patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 13:16:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:18:27 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:18:27 +0000 Subject: Change in osmo-bsc[master]: fix chreq:* counters: typos in chreq:successful_* constants In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26418 ) Change subject: fix chreq:* counters: typos in chreq:successful_* constants ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26418/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26418/1/src/osmo-bsc/abis_rsl.c at 2217 PS1, Line 2217: static void imm_ass_rate_ctr(struct gsm_lchan *lchan) > it may be a good idea to also rename this function to contain "successful" somewhere. sending IMM ASS *is* success of the Chan Req. Hence keeping it as is. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fde77d5d5920093ab037184eb3518876804353d Gerrit-Change-Number: 26418 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 13:18:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:19:23 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:19:23 +0000 Subject: Change in osmo-bsc[master]: fix assignment success counters: count *before* cleanup of fsm state In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 to look at the new patch set (#2). Change subject: fix assignment success counters: count *before* cleanup of fsm state ...................................................................... fix assignment success counters: count *before* cleanup of fsm state Counting the Assignment success after osmo_fsm_inst_term() meant that we were counting a cleared out channel mode, which always yielded signalling mode. Count the Assignment success *before* terminating, so that we correctly count the successful assignment as speech mode. Related: SYS#4878 Related: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 (osmo-ttcn3-hacks) Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/26421/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 Gerrit-Change-Number: 26421 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:20:08 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:20:08 +0000 Subject: Change in osmo-bsc[master]: fix assignment success counters: count *before* cleanup of fsm state In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26421 ) Change subject: fix assignment success counters: count *before* cleanup of fsm state ...................................................................... Patch Set 2: Code-Review+2 re-add vote after fixing typo in commit log -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 Gerrit-Change-Number: 26421 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 13:20:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:21:16 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:21:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: cosmetic cleanup for f_ctrs_*_init() In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 ) Change subject: bsc: cosmetic cleanup for f_ctrs_*_init() ...................................................................... bsc: cosmetic cleanup for f_ctrs_*_init() Related: SYS#4878 Change-Id: I357bfa811a07336ca57dac2d49bf80189047916d --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index d8e2ab1..5f742b2 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -764,18 +764,17 @@ private function f_ctrs_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, counternames); + log("initial bts rate counters: ", g_ctr_bts); } function f_ctrs_bsc_and_bts_init(integer bts_count := NUM_BTS, CounterNameVals counternames := counternames_bsc_bts_handover) runs on test_CT { f_ctrs_bts_init(bts_count, counternames); - log("initial bts rate counters: ", g_ctr_bts); f_ctrs_bsc_init(counternames); } private function f_ctrs_bsc_and_bts_handover_init(integer bts_count := NUM_BTS) runs on test_CT { var CounterNameVals bts_names := counternames_bsc_bts_handover & counternames_bts_handover; - g_ctr_bts := f_counter_name_vals_get_n(IPA_CTRL, "bts", bts_count, bts_names); - log("initial bts rate counters: ", g_ctr_bts); + f_ctrs_bts_init(bts_count, bts_names); f_ctrs_bsc_init(counternames_bsc_bts_handover); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I357bfa811a07336ca57dac2d49bf80189047916d Gerrit-Change-Number: 26416 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:21:16 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:21:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test various bts.N.chreq:* counters In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 ) Change subject: bsc: properly test various bts.N.chreq:* counters ...................................................................... bsc: properly test various bts.N.chreq:* counters Related: SYS#4878 Depends: I1fde77d5d5920093ab037184eb3518876804353d (osmo-bsc) Change-Id: I17a7702b151ac03fd9f7ecd6927ef42133aad953 --- M bsc/BSC_Tests.ttcn 1 file changed, 75 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 5f742b2..0c03bde 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1279,7 +1279,57 @@ f_shutdown_helper(); } -/* verify if the "chreq:total" counter increments as expected */ +const CounterNameVals counternames_bts_chreq := { + { "chreq:total", 0 }, + { "chreq:attempted_emerg", 0 }, + { "chreq:attempted_call", 0 }, + { "chreq:attempted_location_upd", 0 }, + { "chreq:attempted_pag", 0 }, + { "chreq:attempted_pdch", 0 }, + { "chreq:attempted_other", 0 }, + { "chreq:attempted_unknown", 0 }, + { "chreq:successful", 0 }, + { "chreq:successful_emerg", 0 }, + { "chreq:successful_call", 0 }, + { "chreq:successful_location_upd", 0 }, + { "chreq:successful_pag", 0 }, + { "chreq:successful_pdch", 0 }, + { "chreq:successful_other", 0 }, + { "chreq:successful_unknown", 0 }, + { "chreq:no_channel", 0 }, + { "chreq:max_delay_exceeded", 0 } +}; + +/* verify the "chreq:*" counters */ +private function f_chan_act_counter(OCT1 ra, charstring chreq_ctr_suffix) runs on test_CT +{ + var GsmFrameNumber fn := 23; + + f_logp(BSCVTY, "f_chan_act_counter(" & chreq_ctr_suffix & ")"); + + var RSL_Message rx_rsl; + f_ipa_tx(0, ts_RSL_CHAN_RQD(ra, fn)); + rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); + var RslChannelNr chan_nr := rx_rsl.ies[0].body.chan_nr; + + f_ctrs_bts_add(0, "chreq:total"); + f_ctrs_bts_add(0, "chreq:attempted_" & chreq_ctr_suffix); + f_ctrs_bts_verify(); + + f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, fn+10)); + rx_rsl := f_exp_ipa_rx(0, tr_RSL_IMM_ASSIGN(0)); + + f_ctrs_bts_add(0, "chreq:successful"); + f_ctrs_bts_add(0, "chreq:successful_" & chreq_ctr_suffix); + f_ctrs_bts_verify(); + + /* test is done, release RSL Conn Fail Ind to clean up */ + f_ipa_tx(0, ts_RSL_CONN_FAIL_IND(chan_nr, RSL_ERR_RADIO_LINK_FAIL)); + rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL), 10.0); + f_ipa_tx(0, ts_RSL_RF_CHAN_REL_ACK(chan_nr)); + f_sleep(1.0); +} + testcase TC_chan_act_counter() runs on test_CT { var BSSAP_N_UNITDATA_ind ud_ind; var integer chreq_total; @@ -1287,10 +1337,30 @@ f_init(1); - chreq_total := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total"); - IPA_RSL[0].send(ts_ASP_RSL_UD(ts_RSL_CHAN_RQD('23'O, 23))); - rsl_unused := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); - f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total", chreq_total+1); + f_vty_allow_emerg_bts(true, 0); + + f_ctrs_bts_init(1, counternames_bts_chreq); + + /* emergency call: RA & 0xe0 == 0xa0 --> CHREQ_T_EMERG_CALL */ + f_chan_act_counter('a3'O, "emerg"); + + /* voice TCH/H: RA & 0xf0 == 0x40 --> CHREQ_T_VOICE_CALL_TCH_H */ + f_chan_act_counter('43'O, "call"); + + /* LU: RA & 0xf0 == 0x00 --> CHREQ_T_LOCATION_UPD */ + f_chan_act_counter('03'O, "location_upd"); + + /* Paging: RA & 0xf0 == 0x20 --> CHREQ_T_PAG_R_TCH_F */ + f_chan_act_counter('23'O, "pag"); + /* Paging: RA & 0xf0 == 0x30 --> CHREQ_T_PAG_R_TCH_FH */ + f_chan_act_counter('33'O, "pag"); + + /* LU: RA & 0xfc == 0x78 --> CHREQ_T_PDCH_TWO_PHASE */ + /* no PCU, so PDCH not allowed. Skip this test for now. */ + /* f_chan_act_counter('7b'O, "pdch"); */ + + /* LU: RA & 0xf0 == 0x10 --> CHREQ_T_SDCCH */ + f_chan_act_counter('13'O, "other"); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17a7702b151ac03fd9f7ecd6927ef42133aad953 Gerrit-Change-Number: 26417 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 13:21:17 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Nov 2021 13:21:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly test assignment counters In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 ) Change subject: bsc: properly test assignment counters ...................................................................... bsc: properly test assignment counters Verify the BTS level assignment:attempted_speech / _sign as well as assignment:completed_speech / _sign counters, in four selected assignment tests (fr, hr, amr_f, amr_h). Shows a bug where we counted a speech assignment as assignment:completed_sign. Related: SYS#4878 Depends: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 (osmo-bsc) Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 --- M bsc/BSC_Tests.ttcn 1 file changed, 63 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 0c03bde..22df0cb 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -4153,16 +4153,57 @@ f_establish_fully(ass_cmd, exp_fail); } +const CounterNameVals counternames_bsc_bts_assignment := { + { "assignment:attempted", 0 }, + { "assignment:completed", 0 }, + { "assignment:stopped", 0 }, + { "assignment:no_channel", 0 }, + { "assignment:timeout", 0 }, + { "assignment:failed", 0 }, + { "assignment:error", 0 } +}; + +const CounterNameVals counternames_bts_assignment := { + { "assignment:attempted_sign", 0 }, + { "assignment:attempted_speech", 0 }, + { "assignment:completed_sign", 0 }, + { "assignment:completed_speech", 0 }, + { "assignment:stopped_sign", 0 }, + { "assignment:stopped_speech", 0 }, + { "assignment:no_channel_sign", 0 }, + { "assignment:no_channel_speech", 0 }, + { "assignment:timeout_sign", 0 }, + { "assignment:timeout_speech", 0 }, + { "assignment:failed_sign", 0 }, + { "assignment:failed_speech", 0 }, + { "assignment:error_sign", 0 }, + { "assignment:error_speech", 0 } +}; + +function f_ctrs_bsc_and_bts_assignment_init(integer bts_count := NUM_BTS) runs on test_CT { + var CounterNameVals bts_names := counternames_bsc_bts_assignment & counternames_bts_assignment; + f_ctrs_bts_init(bts_count, bts_names); + f_ctrs_bsc_init(counternames_bsc_bts_assignment); +} + testcase TC_assignment_codec_fr() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; f_init(1, true); f_sleep(1.0); + f_ctrs_bsc_and_bts_assignment_init(1); pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_shutdown_helper(); } @@ -4172,10 +4213,18 @@ f_init(1, true); f_sleep(1.0); + f_ctrs_bsc_and_bts_assignment_init(1); pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR})); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_shutdown_helper(); } @@ -4258,10 +4307,17 @@ f_init(1, true); f_sleep(1.0); f_vty_amr_start_mode_set(true, "1"); + f_ctrs_bsc_and_bts_assignment_init(1); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_vty_amr_start_mode_restore(true); f_shutdown_helper(); } @@ -4286,10 +4342,17 @@ f_init(1, true); f_sleep(1.0); f_vty_amr_start_mode_set(false, "1"); + f_ctrs_bsc_and_bts_assignment_init(1); vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + f_vty_amr_start_mode_restore(false); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 Gerrit-Change-Number: 26422 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 14:01:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 14:01:16 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Introduce osmo_prim_srv APIs This new module allows easy exchange of osmo_prim based data types over IPC communication (UD socket supported only so far), by replacing the osmo_prim_hdr struct with a serialized header when submitting/receiving it from the IPC socket. This patch introduces the server side of the UD socket, but the client side can easily be introduced in the same file whenever needed. Related: SYS#5516 Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 --- M TODO-RELEASE M include/osmocom/netif/Makefile.am A include/osmocom/netif/prim.h M src/Makefile.am A src/prim.c 5 files changed, 432 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/26/26426/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 1c9a2a6..b146231 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line sctp.h new APIs +prim.h new data type, APIs diff --git a/include/osmocom/netif/Makefile.am b/include/osmocom/netif/Makefile.am index d9d030b..92712a9 100644 --- a/include/osmocom/netif/Makefile.am +++ b/include/osmocom/netif/Makefile.am @@ -4,6 +4,7 @@ osmux.h \ ipa.h \ ipa_unit.h \ + prim.h \ rs232.h \ rtp.h \ stream.h diff --git a/include/osmocom/netif/prim.h b/include/osmocom/netif/prim.h new file mode 100644 index 0000000..eb2cd9e --- /dev/null +++ b/include/osmocom/netif/prim.h @@ -0,0 +1,46 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +#include +#include +#include + +struct osmo_prim_srv; + +/*! Must return -EBADF if the srv struct is destroyed during call. oph and + * related msgb is owned by srv and wll be freed after the callback returns. */ +typedef int (*osmo_prim_srv_rx_cb)(struct osmo_prim_srv *srv, struct osmo_prim_hdr *oph); + +struct osmo_prim_hdr *osmo_prim_pkt_alloc(unsigned int sap, unsigned int primitive, + enum osmo_prim_operation operation, size_t alloc_len); + +struct osmo_prim_srv *osmo_prim_srv_alloc(void *ctx); +void osmo_prim_srv_free(struct osmo_prim_srv *srv); +bool osmo_prim_srv_connected(const struct osmo_prim_srv *srv); +int osmo_prim_srv_set_addr(struct osmo_prim_srv *srv, const char *path); +const char *osmo_prim_srv_get_addr(struct osmo_prim_srv *srv); +void osmo_prim_srv_set_priv(struct osmo_prim_srv *srv, void *priv); +void *osmo_prim_srv_get_priv(const struct osmo_prim_srv *srv); +void osmo_prim_srv_set_log_category(struct osmo_prim_srv *srv, int log_cat); +void osmo_prim_srv_set_rx_cb(struct osmo_prim_srv *srv, osmo_prim_srv_rx_cb rx_cb); +int osmo_prim_srv_open(struct osmo_prim_srv *srv); +int osmo_prim_srv_send(struct osmo_prim_srv *srv, struct msgb *msg); diff --git a/src/Makefile.am b/src/Makefile.am index 438b58e..5c23896 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -17,6 +17,7 @@ ipa_unit.c \ jibuf.c \ osmux.c \ + prim.c \ rs232.c \ rtp.c \ stream.c diff --git a/src/prim.c b/src/prim.c new file mode 100644 index 0000000..050fe90 --- /dev/null +++ b/src/prim.c @@ -0,0 +1,383 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +#include + +struct osmo_prim_pkt_hdr { + uint32_t sap; /*!< Service Access Point Identifier */ + uint16_t primitive; /*!< Primitive number */ + uint16_t operation; /*! Primitive Operation (enum osmo_prim_operation) */ +} __attribute__ ((packed)); + +/* Here we take advantage of the fact that sizeof(struct + * osmo_prim_pkt_hdr) <= sizeof(struct osmo_prim_hdr), so we don't need + * to allocate headroom when serializing later. + */ +osmo_static_assert(sizeof(struct osmo_prim_pkt_hdr) <= sizeof(struct osmo_prim_hdr), + osmo_prim_pkt_alloc_validate_headroom); + +/*! Allocate a primitive of given type and its associated msgb. +* \param[in] sap Service Access Point +* \param[in] primitive Primitive Number +* \param[in] operation Primitive Operation (REQ/RESP/IND/CONF) +* \param[in] alloc_len Total length (including struct osmo_prim_hdr) to allocate for the primitive +* \returns Pointer to allocated prim_hdr inisde its own msgb. The osmo_prim_hdr +* is pre-alocated & pre-filled. +*/ +struct osmo_prim_hdr *osmo_prim_pkt_alloc(unsigned int sap, unsigned int primitive, + enum osmo_prim_operation operation, size_t alloc_len) +{ + struct msgb *msg; + struct osmo_prim_hdr *oph; + + if (alloc_len < sizeof(*oph)) + return NULL; + + msg = msgb_alloc(alloc_len, "osmo_prim_pkt_alloc"); + oph = (struct osmo_prim_hdr *)msgb_put(msg, sizeof(*oph)); + osmo_prim_init(oph, sap, primitive, operation, msg); + msg->l2h = msg->tail; + + return oph; +} + +/****************************** + * osmo_prim_srv + ******************************/ + +struct osmo_prim_srv { + void *priv; + char *addr; + int log_cat; /* Defaults to DLGLOBAL */ + struct osmo_fd listen_bfd; /* fd for listen socket */ + struct osmo_fd conn_bfd; /* fd for connection to lcr */ + struct llist_head upqueue; /* queue for sending messages */ + osmo_prim_srv_rx_cb rx_cb; +}; + +#define LOGSRV(srv, lvl, fmt, args...) LOGP((srv)->log_cat, lvl, fmt, ## args) + +static void _osmo_prim_srv_close(struct osmo_prim_srv *srv) +{ + struct osmo_fd *bfd = &srv->conn_bfd; + + close(bfd->fd); + bfd->fd = -1; + osmo_fd_unregister(bfd); + + /* re-enable the generation of ACCEPT for new connections */ + osmo_fd_read_enable(&srv->listen_bfd); + + /* flush the queue */ + while (!llist_empty(&srv->upqueue)) { + struct msgb *msg = msgb_dequeue(&srv->upqueue); + msgb_free(msg); + } +} + +static int _osmo_prim_srv_read(struct osmo_fd *bfd) +{ + struct osmo_prim_srv *srv = (struct osmo_prim_srv *)bfd->data; + struct osmo_prim_pkt_hdr *pkth; + struct msgb *msg; + struct osmo_prim_hdr oph; + int rc; + + msg = msgb_alloc(1600, "osmo_prim_srv_rx"); + if (!msg) + return -ENOMEM; + rc = recv(bfd->fd, msg->tail, msgb_tailroom(msg), 0); + if (rc == 0) + goto close; + + if (rc < 0) { + if (errno == EAGAIN) { + msgb_free(msg); + return 0; + } + goto close; + } + + if (rc < sizeof(struct osmo_prim_pkt_hdr)) { + LOGSRV(srv, LOGL_ERROR, "Received %d bytes on UD Socket, but primitive hdr size " + "is %zu, discarding\n", rc, sizeof(struct osmo_prim_pkt_hdr)); + msgb_free(msg); + return 0; + } + pkth = (struct osmo_prim_pkt_hdr *)msgb_put(msg, rc); + + /* De-serialize message: */ + osmo_prim_init(&oph, pkth->sap, pkth->primitive, pkth->operation, msg); + msgb_pull(msg, sizeof(*pkth)); + + if (srv->rx_cb) + rc = srv->rx_cb(srv, &oph); + + /* as we always synchronously process the message in _osmo_prim_srv_rx() and + * its callbacks, we can free the message here. */ + msgb_free(msg); + + return rc; + +close: + msgb_free(msg); + _osmo_prim_srv_close(srv); + return -1; +} + +static int _osmo_prim_srv_write(struct osmo_fd *bfd) +{ + struct osmo_prim_srv *srv = bfd->data; + int rc; + + while (!llist_empty(&srv->upqueue)) { + struct msgb *msg, *msg2; + + /* peek at the beginning of the queue */ + msg = llist_entry(srv->upqueue.next, struct msgb, list); + + osmo_fd_write_disable(bfd); + + if (!msgb_length(msg)) { + LOGSRV(srv, LOGL_ERROR, "message with ZERO " + "bytes!\n"); + goto dontsend; + } + + /* try to send it over the socket */ + rc = write(bfd->fd, msgb_data(msg), msgb_length(msg)); + if (rc == 0) + goto close; + if (rc < 0) { + if (errno == EAGAIN) { + osmo_fd_write_enable(bfd); + break; + } + goto close; + } + +dontsend: + /* _after_ we send it, we can deueue */ + msg2 = msgb_dequeue(&srv->upqueue); + assert(msg == msg2); + msgb_free(msg); + } + return 0; + +close: + _osmo_prim_srv_close(srv); + + return -1; +} + +static int _osmo_prim_srv_bfd_cb(struct osmo_fd *bfd, unsigned int flags) +{ + int rc = 0; + + if (flags & OSMO_FD_READ) + rc = _osmo_prim_srv_read(bfd); + if (rc == -EBADF) /* socket is gone, return and don't access it */ + return rc; + + if (flags & OSMO_FD_WRITE) + rc = _osmo_prim_srv_write(bfd); + + return rc; +} + +/* accept connection coming from PCU */ +static int _osmo_prim_srv_accept(struct osmo_fd *bfd, unsigned int flags) +{ + struct osmo_prim_srv *srv = (struct osmo_prim_srv *)bfd->data; + struct osmo_fd *conn_bfd = &srv->conn_bfd; + struct sockaddr_un un_addr; + socklen_t len; + int rc; + + len = sizeof(un_addr); + rc = accept(bfd->fd, (struct sockaddr *) &un_addr, &len); + if (rc < 0) { + LOGSRV(srv, LOGL_ERROR, "Failed to accept a new connection\n"); + return -1; + } + + if (conn_bfd->fd >= 0) { + LOGSRV(srv, LOGL_NOTICE, "UD Socket connects but we already have " + "another active connection ?!?\n"); + /* We already have one LLSK connected, this is all we support */ + srv->listen_bfd.when &= ~OSMO_FD_READ; + close(rc); + return 0; + } + + osmo_fd_setup(conn_bfd, rc, OSMO_FD_READ, _osmo_prim_srv_bfd_cb, srv, 0); + + if (osmo_fd_register(conn_bfd) != 0) { + LOGSRV(srv, LOGL_ERROR, "Failed to register new connection fd\n"); + close(conn_bfd->fd); + conn_bfd->fd = -1; + return -1; + } + + LOGSRV(srv, LOGL_NOTICE, "UD socket connected\n"); + + return 0; +} + +struct osmo_prim_srv *osmo_prim_srv_alloc(void *ctx) +{ + struct osmo_prim_srv *srv; + srv = talloc_zero(ctx, struct osmo_prim_srv); + if (!srv) + return NULL; + + srv->log_cat = DLGLOBAL; + INIT_LLIST_HEAD(&srv->upqueue); + srv->conn_bfd.fd = -1; + srv->listen_bfd.fd = -1; + return srv; +} + +void osmo_prim_srv_free(struct osmo_prim_srv *srv) +{ + struct osmo_fd *bfd, *conn_bfd; + + if (!srv) + return; + + conn_bfd = &srv->conn_bfd; + if (conn_bfd->fd > 0) + _osmo_prim_srv_close(srv); + bfd = &srv->listen_bfd; + close(bfd->fd); + osmo_fd_unregister(bfd); + talloc_free(srv); +} + +bool osmo_prim_srv_connected(const struct osmo_prim_srv *srv) +{ + if (!srv) + return false; + if (srv->conn_bfd.fd <= 0) + return false; + return true; +} +int osmo_prim_srv_set_addr(struct osmo_prim_srv *srv, const char *path) +{ + osmo_talloc_replace_string(srv, &srv->addr, path); + return 0; +} + +const char *osmo_prim_srv_get_addr(struct osmo_prim_srv *srv) +{ + return srv->addr; +} + +void osmo_prim_srv_set_priv(struct osmo_prim_srv *srv, void *priv) +{ + srv->priv = priv; +} + +void *osmo_prim_srv_get_priv(const struct osmo_prim_srv *srv) +{ + return srv->priv; +} + +void osmo_prim_srv_set_log_category(struct osmo_prim_srv *srv, int log_cat) +{ + srv->log_cat = log_cat; +} + +void osmo_prim_srv_set_rx_cb(struct osmo_prim_srv *srv, osmo_prim_srv_rx_cb rx_cb) +{ + srv->rx_cb = rx_cb; +} + +int osmo_prim_srv_open(struct osmo_prim_srv *srv) +{ + struct osmo_fd *bfd = &srv->listen_bfd; + int rc; + + if (!srv->addr) { + LOGSRV(srv, LOGL_ERROR, "Cannot open, Address not configured\n"); + return -1; + } + + rc = osmo_sock_unix_init(SOCK_SEQPACKET, 0, srv->addr, OSMO_SOCK_F_BIND); + if (rc < 0) { + LOGSRV(srv, LOGL_ERROR, "Could not create %s unix socket: %s\n", + srv->addr, strerror(errno)); + return -1; + } + + osmo_fd_setup(bfd, rc, OSMO_FD_READ, _osmo_prim_srv_accept, srv, 0); + + rc = osmo_fd_register(bfd); + if (rc < 0) { + LOGSRV(srv, LOGL_ERROR, "Could not register listen fd: %d\n", + rc); + close(bfd->fd); + bfd->fd = -1; + return rc; + } + + LOGSRV(srv, LOGL_INFO, "Started listening on Lower Layer Unix Domain Socket: %s\n", srv->addr); + + return 0; +} + +/*! Allocate a primitive of given type and its associated msgb. +* \param[in] srv The osmo_prim_srv instance where message is to be sent through +* \param[in] msg msgb containing osmo_prim_hdr plus extra content, allocated through \ref osmo_prim_pkt_alloc() +* \returns zero on success, negative on error */ +int osmo_prim_srv_send(struct osmo_prim_srv *srv, struct msgb *msg) +{ + struct osmo_fd *conn_bfd; + struct osmo_prim_hdr *oph; + struct osmo_prim_pkt_hdr *pkth; + unsigned int sap; + unsigned int primitive; + enum osmo_prim_operation operation; + + if (!srv) { + LOGSRV(srv, LOGL_INFO, "UD socket not created, dropping message\n"); + msgb_free(msg); + return -EINVAL; + } + conn_bfd = &srv->conn_bfd; + if (conn_bfd->fd <= 0) { + LOGSRV(srv, LOGL_NOTICE, "UD socket not connected, dropping message\n"); + msgb_free(msg); + return -EIO; + } + + /* Serialize the oph: */ + oph = (struct osmo_prim_hdr *)msgb_data(msg); + OSMO_ASSERT(oph && msgb_length(msg) >= sizeof(*oph)); + sap = oph->sap; + primitive = oph->primitive; + operation = oph->operation; + msgb_pull(msg, sizeof(*oph)); + pkth = (struct osmo_prim_pkt_hdr *)msgb_push(msg, sizeof(*pkth)); + pkth->sap = sap; + pkth->primitive = primitive; + pkth->operation = operation; + + /* Finally enqueue the msg */ + msgb_enqueue(&srv->upqueue, msg); + osmo_fd_write_enable(conn_bfd); + + return 0; +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 14:13:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 14:13:07 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c File src/prim.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c at 1 PS1, Line 1: #include could use some copyright / license header https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c at 39 PS1, Line 39: osmo_prim_pkt_alloc not sure what a prim_pkt is? I don't think we've used this so far? >From the body of the function it looks like a normal msgb-wrapped osmo_prim? https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c at 65 PS1, Line 65: lcr lcr? also, this seems to imply that there can only be one client for every server? I think we might need to split that up. There are other existing unix-domain-socket using sub-systems that we may want to migrate that support multiple clients. Also, especially some of those that I would expect that could be migrated (SCCP user SAP) support multiple users (clients) connected to one provider (server). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 14:13:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 14:16:29 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 30 Nov 2021 14:16:29 +0000 Subject: Change in osmo-ccid-firmware[master]: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b8... In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 ) Change subject: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0d4a072d18011ffb00d6251481473b19d5a97c50 Gerrit-Change-Number: 26425 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 14:16:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 14:16:31 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 30 Nov 2021 14:16:31 +0000 Subject: Change in osmo-ccid-firmware[master]: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b8... In-Reply-To: References: Message-ID: Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 ) Change subject: update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb ...................................................................... update test expectations to follow Change-Id: I5f39c0fe82cbfa6f2bc4b84784a7142b461b64fb Change-Id: I0d4a072d18011ffb00d6251481473b19d5a97c50 --- M tests/sysmo-octsim/03_check_lsusb.out 1 file changed, 3 insertions(+), 65 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/tests/sysmo-octsim/03_check_lsusb.out b/tests/sysmo-octsim/03_check_lsusb.out index bdc7672..2dc3f09 100644 --- a/tests/sysmo-octsim/03_check_lsusb.out +++ b/tests/sysmo-octsim/03_check_lsusb.out @@ -18,8 +18,8 @@ Configuration Descriptor: bLength 9 bDescriptorType 2 - wTotalLength 0x00a9 - bNumInterfaces 4 + wTotalLength 0x006f + bNumInterfaces 2 bConfigurationValue 1 iConfiguration 3 A bmAttributes 0x80 @@ -28,68 +28,6 @@ Interface Descriptor: bLength 9 bDescriptorType 4 - bInterfaceNumber 1 - bAlternateSetting 0 - bNumEndpoints 1 - bInterfaceClass 2 Communications - bInterfaceSubClass 2 Abstract (modem) - bInterfaceProtocol 0 - iInterface 4 debug UART - CDC Header: - bcdCDC 10.01 - CDC Call Management: - bmCapabilities 0x01 - call management - bDataInterface 0 - CDC ACM: - bmCapabilities 0x02 - line coding and serial state - CDC Union: - bMasterInterface 1 - bSlaveInterface 2 - Endpoint Descriptor: - bLength 7 - bDescriptorType 5 - bEndpointAddress 0x82 EP 2 IN - bmAttributes 3 - Transfer Type Interrupt - Synch Type None - Usage Type Data - wMaxPacketSize 0x0040 1x 64 bytes - bInterval 10 - Interface Descriptor: - bLength 9 - bDescriptorType 4 - bInterfaceNumber 2 - bAlternateSetting 0 - bNumEndpoints 2 - bInterfaceClass 10 CDC Data - bInterfaceSubClass 0 - bInterfaceProtocol 0 - iInterface 5 debug UART - Endpoint Descriptor: - bLength 7 - bDescriptorType 5 - bEndpointAddress 0x01 EP 1 OUT - bmAttributes 2 - Transfer Type Bulk - Synch Type None - Usage Type Data - wMaxPacketSize 0x0040 1x 64 bytes - bInterval 0 - Endpoint Descriptor: - bLength 7 - bDescriptorType 5 - bEndpointAddress 0x81 EP 1 IN - bmAttributes 2 - Transfer Type Bulk - Synch Type None - Usage Type Data - wMaxPacketSize 0x0040 1x 64 bytes - bInterval 0 - Interface Descriptor: - bLength 9 - bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 3 @@ -157,7 +95,7 @@ Interface Descriptor: bLength 9 bDescriptorType 4 - bInterfaceNumber 3 + bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 254 Application Specific Interface -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0d4a072d18011ffb00d6251481473b19d5a97c50 Gerrit-Change-Number: 26425 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 15:26:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 15:26:15 +0000 Subject: Change in docker-playground[master]: debian-stretch-titan/Dockerfile: install osmo-python-tests References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26427 ) Change subject: debian-stretch-titan/Dockerfile: install osmo-python-tests ...................................................................... debian-stretch-titan/Dockerfile: install osmo-python-tests We need osmo_interact_vty.py in order to obtain talloc reports for each test case automatically. See [1] for more details. Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Related: [1] I1b03b17426d8760c55976e3b78ca2f3af248c055 --- M debian-stretch-titan/Dockerfile 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/27/26427/1 diff --git a/debian-stretch-titan/Dockerfile b/debian-stretch-titan/Dockerfile index 5b6b134..d348914 100644 --- a/debian-stretch-titan/Dockerfile +++ b/debian-stretch-titan/Dockerfile @@ -32,9 +32,14 @@ wireshark-common \ vim \ netcat-openbsd \ + python3-setuptools \ + python3-pip \ && \ apt-get clean +# This is required for obtaining talloc reports from the SUT +RUN pip3 install git+git://git.osmocom.org/python/osmo-python-tests + # somehow Debian folks updated the gcc version but not titan :/ RUN sed -i 's/^#error/\/\/#error/' /usr/include/titan/cversion.h -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Gerrit-Change-Number: 26427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 15:28:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 15:28:11 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 30 Nov 2021 15:28:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 15:28:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 15:28:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 ) Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Gerrit-Change-Number: 26407 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 15:28:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 15:29:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 15:29:15 +0000 Subject: Change in docker-playground[master]: redmine: process changelogs every 10 minutes References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26428 ) Change subject: redmine: process changelogs every 10 minutes ...................................................................... redmine: process changelogs every 10 minutes Wrap the original entrypoint script with a custom one that also runs a loop in the background, which periodically lets redmine fetch git repositories. When repositories are fetched, redmine interpretes "closes" etc. in commit messages to mark issues as resolved. Closes: OS#5331 Change-Id: I2a65fd6be22ae541a93c08c71cf286e4b5ad370f --- M redmine/Dockerfile A redmine/docker-entrypoint-osmo.sh 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/28/26428/1 diff --git a/redmine/Dockerfile b/redmine/Dockerfile index 2d8eb11..fc1ba89 100644 --- a/redmine/Dockerfile +++ b/redmine/Dockerfile @@ -17,3 +17,7 @@ ADD commitlog-references-oshash.diff /tmp/commitlog-references-oshash.diff RUN cd /usr/src/redmine && patch -p1 < /tmp/commitlog-references-oshash.diff + +ADD docker-entrypoint-osmo.sh / +ENTRYPOINT ["/docker-entrypoint-osmo.sh"] +CMD ["passenger", "start"] diff --git a/redmine/docker-entrypoint-osmo.sh b/redmine/docker-entrypoint-osmo.sh new file mode 100755 index 0000000..aff8183 --- /dev/null +++ b/redmine/docker-entrypoint-osmo.sh @@ -0,0 +1,17 @@ +#!/bin/sh + +# Periodically fetch git repositories +# https://www.redmine.org/projects/redmine/wiki/RedmineRepositories +# Double fork, so it still runs after the exec below +(while :; do + sleep 10m + echo + echo "=== Fetching git repositories (OS#5331) ===" + su redmine -c 'rails runner "Repository.fetch_changesets" -e production' + echo +done &) & + +# Run the original docker-entrypoint.sh script. Exec is important, so "tini" +# inside the original script becomes pid 1 to clean up zombies from redmine. +# https://github.com/docker-library/redmine/ +exec /docker-entrypoint.sh "$@" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a65fd6be22ae541a93c08c71cf286e4b5ad370f Gerrit-Change-Number: 26428 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 15:29:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 15:29:25 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Patch Set 5: (2 comments) New version submitted: https://gerrit.osmocom.org/c/docker-playground/+/26428 https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml File jobs/redmine-fetch.yml: https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 45 PS4, Line 45: libgtpnl > both exist. weird. [?] Hmm, now it works o_O * https://osmocom.org/projects/osmotrx/repository/libusrp * https://osmocom.org/projects/openggsn/repository/libgtpnl https://gerrit.osmocom.org/c/osmo-ci/+/26423/4/jobs/redmine-fetch.yml at 54 PS4, Line 54: osmo-upf > done, but same strange permissiosn problem works now: https://osmocom.org/projects/osmo-upf/repository/osmo-upf -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 15:29:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 15:29:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 15:29:45 +0000 Subject: Change in osmo-ci[master]: jobs/redmine-fetch: close issues on gerrit merge In-Reply-To: References: Message-ID: osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26423 ) Change subject: jobs/redmine-fetch: close issues on gerrit merge ...................................................................... Abandoned => https://gerrit.osmocom.org/c/docker-playground/+/26428 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia7c6c8426e5ca0de04378cedd0360c368e9d5027 Gerrit-Change-Number: 26423 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 15:33:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Nov 2021 15:33:55 +0000 Subject: Change in docker-playground[master]: redmine: process changelogs every 10 minutes In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26428 ) Change subject: redmine: process changelogs every 10 minutes ...................................................................... Patch Set 1: Verified+1 I've verified that the script runs periodically, attempts to fetch repositories and that redmine works normally. I did not test if "Closes: OS#..." leads to closing the issues on fetch, but assuming that this code path gets executed with the fetch, then it should work. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a65fd6be22ae541a93c08c71cf286e4b5ad370f Gerrit-Change-Number: 26428 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 30 Nov 2021 15:33:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 16:55:05 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 16:55:05 +0000 Subject: Change in osmo-bts[master]: debian/control: add osmo-bts meta-package In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26424 ) Change subject: debian/control: add osmo-bts meta-package ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a6edf2eb146616ac51b7957368a8d057caa685f Gerrit-Change-Number: 26424 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 16:55:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 16:57:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 16:57:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 ) Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Gerrit-Change-Number: 26407 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 16:57:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 16:58:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 16:58:12 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 16:58:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 16:58:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 16:58:19 +0000 Subject: Change in docker-playground[master]: debian-stretch-titan/Dockerfile: install osmo-python-tests In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26427 ) Change subject: debian-stretch-titan/Dockerfile: install osmo-python-tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Gerrit-Change-Number: 26427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 16:58:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 17:56:23 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 17:56:23 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c File src/prim.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c at 39 PS1, Line 39: osmo_prim_pkt_alloc > not sure what a prim_pkt is? I don't think we've used this so far? [?] Yes, this makes sure though that nobody passes a wrongly allocated struct to osmo_prim_srv_send() later on, since there are several ways to allocate + pass/handle osmo_prim + msg. In this case, we want to make sure that the oph is put in front of the msg, since we access it inside the API and we also require headroom to replace it with the serialized osmo_prim_pkt_hdr when sending over the IPC. https://gerrit.osmocom.org/c/libosmo-netif/+/26426/1/src/prim.c at 65 PS1, Line 65: lcr > lcr? [?] lcr: typo, I'll fix. Yes, current implementation (I took pcuif sock in osmo-bts/osmo-bsc as a reference) supports only 1 client. I could add a "conn_id" param to the rx_cb to identify which user sent the prim. In this case, the conn_id would basically be internally the created fd for that specific UD socket. typedef int (*osmo_prim_srv_rx_cb)(struct osmo_prim_srv *srv, int conn_id, struct osmo_prim_hdr *oph); Not sure if we need conn_opened(struct osmo_prim_srv *srv, int conn_id) and conn_closed(struct osmo_prim_srv *srv, int conn_id) callbacks too. I guess we do if the server is the one to first send a message whenever the client connects (not our current case, but possible). I'd probably have to add also some new APIs like osmo_priv_srv_close_conn(srv, conn_id). Finally, osmo_prim_srv_send(struct osmo_prim_srv *srv, struct msgb *msg) would become: osmo_prim_srv_send(struct osmo_prim_srv *srv, int conn_id, struct msgb *msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 17:56:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 17:57:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 17:57:47 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#7). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_ctl.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 20 files changed, 1,209 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 18:19:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 18:19:47 +0000 Subject: Change in docker-playground[master]: redmine: process changelogs every 10 minutes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26428 ) Change subject: redmine: process changelogs every 10 minutes ...................................................................... Patch Set 1: Code-Review+1 did you test it whether it runs as expected? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a65fd6be22ae541a93c08c71cf286e4b5ad370f Gerrit-Change-Number: 26428 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 30 Nov 2021 18:19:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:33:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 19:33:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 ) Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Gerrit-Change-Number: 26407 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 19:33:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:33:46 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 19:33:46 +0000 Subject: Change in docker-playground[master]: debian-stretch-titan/Dockerfile: install osmo-python-tests In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26427 ) Change subject: debian-stretch-titan/Dockerfile: install osmo-python-tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Gerrit-Change-Number: 26427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 19:33:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:34:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 19:34:58 +0000 Subject: Change in osmo-bts[master]: debian/control: add osmo-bts meta-package In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26424 ) Change subject: debian/control: add osmo-bts meta-package ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a6edf2eb146616ac51b7957368a8d057caa685f Gerrit-Change-Number: 26424 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 19:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:35:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 19:35:01 +0000 Subject: Change in osmo-bts[master]: debian/control: add osmo-bts meta-package In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26424 ) Change subject: debian/control: add osmo-bts meta-package ...................................................................... debian/control: add osmo-bts meta-package Add an osmo-bts meta-package that depends on the subpackages osmo-bts-trx and osmo-bts-virtual. This is important, because the downstream packaging of debian does not split osmo-bts in subpackages, it has only one osmo-bts package. So without this, when installing "osmo-bts" in debian while having the Osmocom binary package repository installed and expecting to get the newer version, the user will actually get the older version from debian. Closes: OS#5319 Related: https://salsa.debian.org/debian-mobcom-team/osmo-bts/-/blob/master/debian/control Change-Id: I1a6edf2eb146616ac51b7957368a8d057caa685f --- M debian/control 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/control b/debian/control index 0bdf48c..2cb152d 100644 --- a/debian/control +++ b/debian/control @@ -17,9 +17,25 @@ Vcs-Git: git://git.osmocom.org/osmo-bts Homepage: https://projects.osmocom.org/projects/osmobts +Package: osmo-bts +Architecture: any +Depends: osmo-bts-trx, osmo-bts-virtual, ${misc:Depends} +Description: Base Transceiver Station for GSM + OsmoBTS is a software implementation of Layer2/3 of a BTS. It implements the + following protocols/interfaces: + LAPDm (GSM 04.06) + RTP + A-bis/IP in IPA multiplex + OML (GSM TS 12.21) + RSL (GSM TS 08.58) + . + OsmoBTS is modular and has support for multiple back-ends. A back-end talks to + a specific L1/PHY implementation of the respective BTS hardware. Based on this + architecture, it should be relatively easy to add a new back-end to support + so-far unsupported GSM PHY/L1 and associated hardware. + Package: osmo-bts-trx Architecture: any -Conflicts: osmo-bts Depends: ${shlibs:Depends}, ${misc:Depends} Description: osmo-bts-trx GSM BTS with osmo-trx osmo-bts-trx to be used with the osmo-trx application @@ -34,7 +50,6 @@ Package: osmo-bts-virtual Architecture: any -Conflicts: osmo-bts Depends: ${shlibs:Depends}, ${misc:Depends} Description: Virtual Osmocom GSM BTS (no RF hardware; GSMTAP/UDP) This version of OsmoBTS doesn't use actual GSM PHY/Hardware/RF, but -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a6edf2eb146616ac51b7957368a8d057caa685f Gerrit-Change-Number: 26424 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:35:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 19:35:40 +0000 Subject: Change in osmo-bsc[master]: fix chreq:* counters: typos in chreq:successful_* constants In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26418 ) Change subject: fix chreq:* counters: typos in chreq:successful_* constants ...................................................................... fix chreq:* counters: typos in chreq:successful_* constants Related: SYS#4878 Related: I17a7702b151ac03fd9f7ecd6927ef42133aad953 (osmo-ttcn3-hacks) Change-Id: I1fde77d5d5920093ab037184eb3518876804353d --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 629d50b..402ea27 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2220,25 +2220,25 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL)); switch (lchan->activate.info.chreq_reason) { case GSM_CHREQ_REASON_EMERG: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_EMERG)); break; case GSM_CHREQ_REASON_CALL: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_CALL)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_CALL)); break; case GSM_CHREQ_REASON_LOCATION_UPD: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_LOCATION_UPD)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_LOCATION_UPD)); break; case GSM_CHREQ_REASON_PAG: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PAG)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_PAG)); break; case GSM_CHREQ_REASON_PDCH: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_PDCH)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_PDCH)); break; case GSM_CHREQ_REASON_OTHER: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_OTHER)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_OTHER)); break; default: - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_UNKNOWN)); + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_SUCCESSFUL_UNKNOWN)); break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fde77d5d5920093ab037184eb3518876804353d Gerrit-Change-Number: 26418 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:35:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 19:35:40 +0000 Subject: Change in osmo-bsc[master]: dbg log: also log assignment counters on BTS level In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26420 ) Change subject: dbg log: also log assignment counters on BTS level ...................................................................... dbg log: also log assignment counters on BTS level Change-Id: I68b3e794ddf97c80f647c3536ec466217b338af9 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 656bd3e..a3ec55b 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -88,11 +88,19 @@ switch (gsm48_chan_mode_to_non_vamos(conn->assignment.req.ch_mode_rate_list[0].chan_mode)) { \ case GSM48_CMODE_SIGN: \ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_##counter##_SIGN)); \ + LOG_ASSIGNMENT(conn, LOGL_DEBUG, "incrementing rate counter: bts%u %s %s\n", \ + bts->nr, \ + bts_ctr_description[BTS_##counter##_SIGN].name, \ + bts_ctr_description[BTS_##counter##_SIGN].description); \ break; \ case GSM48_CMODE_SPEECH_V1: \ case GSM48_CMODE_SPEECH_EFR: \ case GSM48_CMODE_SPEECH_AMR: \ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_##counter##_SPEECH)); \ + LOG_ASSIGNMENT(conn, LOGL_DEBUG, "incrementing rate counter: bts%u %s %s\n", \ + bts->nr, \ + bts_ctr_description[BTS_##counter##_SPEECH].name, \ + bts_ctr_description[BTS_##counter##_SPEECH].description); \ break; \ default: \ break; \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I68b3e794ddf97c80f647c3536ec466217b338af9 Gerrit-Change-Number: 26420 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:35:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Nov 2021 19:35:40 +0000 Subject: Change in osmo-bsc[master]: fix assignment success counters: count *before* cleanup of fsm state In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26421 ) Change subject: fix assignment success counters: count *before* cleanup of fsm state ...................................................................... fix assignment success counters: count *before* cleanup of fsm state Counting the Assignment success after osmo_fsm_inst_term() meant that we were counting a cleared out channel mode, which always yielded signalling mode. Count the Assignment success *before* terminating, so that we correctly count the successful assignment as speech mode. Related: SYS#4878 Related: Icb1386ec2ccd70eb3c026301b9b08ad7177278f7 (osmo-ttcn3-hacks) Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index a3ec55b..0243058 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -295,10 +295,10 @@ conn->user_plane.msc_assigned_rtp_port = conn->assignment.req.msc_rtp_port; } + assignment_count_result(CTR_ASSIGNMENT_COMPLETED); + LOG_ASSIGNMENT(conn, LOGL_DEBUG, "Assignment successful\n"); osmo_fsm_inst_term(conn->assignment.fi, OSMO_FSM_TERM_REGULAR, 0); - - assignment_count_result(CTR_ASSIGNMENT_COMPLETED); } static void assignment_fsm_update_id(struct gsm_subscriber_connection *conn) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie9fcd1e86f27ecb2f11e2e8813faac365cb470b8 Gerrit-Change-Number: 26421 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:37:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 19:37:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 ) Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report ...................................................................... ttcn3-tcpdump-stop.sh: order the SUT to print talloc report The idea is to generate a talloc report after execution of a test case and store it together with PCAP files. This might be useful for detecting memory leaks and finding the relevant test cases. To enable this feature, make sure that osmo_interact_vty.py from osmo-python-tests is installed (see [1]), and the following variables are set (see [2]): * OSMO_SUT_HOST (e.g. "127.0.0.1"), and * OSMO_SUT_PORT (e.g. 4242). Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Depends: [1] Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Related: [2] Icd4c2d80db934535d499598282ed9416d8088163 Related: OS#5328 --- M ttcn3-tcpdump-stop.sh 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index b2a3a3e..4fbc53f 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -32,6 +32,19 @@ TTCN3_PCAP_PATH=/tmp fi +# Order the SUT to print a talloc report +if [ "z$OSMO_SUT_HOST" != "z" ] && [ "z$OSMO_SUT_PORT" != "z" ]; then + if [ -x "$(command -v osmo_interact_vty.py)" ]; then + osmo_interact_vty.py \ + -H $OSMO_SUT_HOST -p $OSMO_SUT_PORT \ + -c "en; show talloc-context application full" \ + > "$TTCN3_PCAP_PATH/$TESTCASE.talloc" + else + echo "Missing osmo_interact_vty.py from osmo-python-tests!" + echo " -> Unable to obtain talloc report from the SUT" + fi +fi + # Wait for up to 2 seconds if we keep receiving traffinc from packet dumper, # otherwise we might lose last packets from test. i=0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Gerrit-Change-Number: 26407 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:39:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 30 Nov 2021 19:39:50 +0000 Subject: Change in docker-playground[master]: debian-stretch-titan/Dockerfile: install osmo-python-tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26427 ) Change subject: debian-stretch-titan/Dockerfile: install osmo-python-tests ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Gerrit-Change-Number: 26427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Nov 2021 19:39:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 19:55:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Nov 2021 19:55:04 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 ) Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... stream: Factor out sctp_recvmg long code chunk This makes it easier to follow the general path selection based on protocol type. It will also make it easier when we add new paths based on socket domain. Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a --- M src/stream.c 1 file changed, 51 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/29/26429/1 diff --git a/src/stream.c b/src/stream.c index e4fb668..a36ea9e 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1290,6 +1290,56 @@ osmo_fd_write_enable(&conn->ofd); } +#ifdef HAVE_LIBSCTP +static int _sctp_recvmg_wrapper(int fd, struct msgb *msg) +{ + struct sctp_sndrcvinfo sinfo; + int flags = 0; + int ret; + + ret = sctp_recvmsg(fd, msgb_data(msg), msgb_tailroom(msg), + NULL, NULL, &sinfo, &flags); + if (flags & MSG_NOTIFICATION) { + union sctp_notification *notif = (union sctp_notification *)msgb_data(msg); + LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); + switch (notif->sn_header.sn_type) { + case SCTP_ASSOC_CHANGE: + LOGP(DLINP, LOGL_DEBUG, "===> ASSOC CHANGE:"); + switch (notif->sn_assoc_change.sac_state) { + case SCTP_COMM_UP: + LOGPC(DLINP, LOGL_DEBUG, " UP\n"); + break; + case SCTP_COMM_LOST: + LOGPC(DLINP, LOGL_DEBUG, " LOST\n"); + break; + case SCTP_RESTART: + LOGPC(DLINP, LOGL_DEBUG, " RESTART\n"); + break; + case SCTP_SHUTDOWN_COMP: + LOGPC(DLINP, LOGL_DEBUG, " SHUTDOWN COMP\n"); + break; + case SCTP_CANT_STR_ASSOC: + LOGPC(DLINP, LOGL_DEBUG, " CANT STR ASSOC\n"); + break; + } + break; + case SCTP_PEER_ADDR_CHANGE: + LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE\n"); + break; + case SCTP_SHUTDOWN_EVENT: + LOGP(DLINP, LOGL_DEBUG, "===> SHUTDOWN EVT\n"); + /* Handle this like a regular disconnect */ + return 0; + break; + } + return -EAGAIN; + } + msgb_sctp_ppid(msg) = ntohl(sinfo.sinfo_ppid); + msgb_sctp_stream(msg) = sinfo.sinfo_stream; + return ret; +} +#endif + /*! \brief Receive data via Osmocom stream server * \param[in] conn Stream Server from which to receive * \param msg pre-allocate message buffer to which received data is appended @@ -1297,10 +1347,6 @@ */ int osmo_stream_srv_recv(struct osmo_stream_srv *conn, struct msgb *msg) { -#ifdef HAVE_LIBSCTP - struct sctp_sndrcvinfo sinfo; - int flags = 0; -#endif int ret; if (!msg) @@ -1309,45 +1355,7 @@ switch (conn->srv->proto) { #ifdef HAVE_LIBSCTP case IPPROTO_SCTP: - ret = sctp_recvmsg(conn->ofd.fd, msgb_data(msg), msgb_tailroom(msg), - NULL, NULL, &sinfo, &flags); - if (flags & MSG_NOTIFICATION) { - union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); - LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); - switch (notif->sn_header.sn_type) { - case SCTP_ASSOC_CHANGE: - LOGP(DLINP, LOGL_DEBUG, "===> ASSOC CHANGE:"); - switch (notif->sn_assoc_change.sac_state) { - case SCTP_COMM_UP: - LOGPC(DLINP, LOGL_DEBUG, " UP\n"); - break; - case SCTP_COMM_LOST: - LOGPC(DLINP, LOGL_DEBUG, " LOST\n"); - break; - case SCTP_RESTART: - LOGPC(DLINP, LOGL_DEBUG, " RESTART\n"); - break; - case SCTP_SHUTDOWN_COMP: - LOGPC(DLINP, LOGL_DEBUG, " SHUTDOWN COMP\n"); - break; - case SCTP_CANT_STR_ASSOC: - LOGPC(DLINP, LOGL_DEBUG, " CANT STR ASSOC\n"); - break; - } - break; - case SCTP_PEER_ADDR_CHANGE: - LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE\n"); - break; - case SCTP_SHUTDOWN_EVENT: - LOGP(DLINP, LOGL_DEBUG, "===> SHUTDOWN EVT\n"); - /* Handle this like a regular disconnect */ - return 0; - break; - } - return -EAGAIN; - } - msgb_sctp_ppid(msg) = ntohl(sinfo.sinfo_ppid); - msgb_sctp_stream(msg) = sinfo.sinfo_stream; + ret = _sctp_recvmg_wrapper(conn->ofd.fd, msg); break; #endif case IPPROTO_TCP: -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Nov 30 20:58:38 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Nov 2021 20:58:38 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 ) Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c at 1333 PS1, Line 1333: break; The lint complains about this break, I don't agree with it though. Without we're one (or two) refactors away from an unintended fall-through https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c at 1358 PS1, Line 1358: recvmg recvm*s*g? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Nov 2021 20:58:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: