Change in osmo-bsc[master]: handover: apply meas report BS Power to RXLEV, fix ho oscillation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon May 31 15:14:57 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24425 )

Change subject: handover: apply meas report BS Power to RXLEV, fix ho oscillation
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24425/5/src/osmo-bsc/meas_rep.c 
File src/osmo-bsc/meas_rep.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24425/5/src/osmo-bsc/meas_rep.c@37 
PS5, Line 37: 		return rep->dl.full.rx_lev + (rep->bs_power * 2);
> We could rename the enum values to MEAS_REP_DL_RXLEV_AND_BS_POWER_FULL

actually can't, for some strange reason this enum value is defined in libosmocore and kind of cast in stone...
I do get the point of your feedback, just it makes no sense to use the raw rxlev value that is not bs-power adjusted anywhere. So it seems most appropriate to imply the BS power everywhere.

Consider the rxlev averaging window: Each measurement report may send a different BS Power value.
when averaging the rxlev values across the window, we need each one adjusted by its individual BS Power.
Otherwise we get a complete random result without any meaning.
Same when comparing cells' rxlev values: the numbers are not comparable when ignoring the BS power.
So we want the BS power adjusted into the rxlev value as implicitly as possible.
Just a bummer that we can't easily rename the enum value to its more concise meaning.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24425
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifcf59964b5e2d550d79e4ba14d90962808f79dae
Gerrit-Change-Number: 24425
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 31 May 2021 15:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210531/062e2e22/attachment.htm>


More information about the gerrit-log mailing list