This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24430 ) Change subject: RSL: rx and tx VAMOS Channel Number cbits for VAMOS lchans ...................................................................... Patch Set 9: (1 comment) Please think about inbound message parsing in context of what I wrote below in the example of lchan lookup by chan_nr. https://gerrit.osmocom.org/c/osmo-bsc/+/24430/9/src/osmo-bsc/bts_trx.c File src/osmo-bsc/bts_trx.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24430/9/src/osmo-bsc/bts_trx.c@165 PS9, Line 165: case ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Bm_ACCHs: I don't see anything that ensures those new osmocom-specific cbits are only used if the bts model is of type osmo-bts and has advertised VAMOS capability. I think your statement may be true for outbound messages that the BSC generates, but this kind of code change to generic/common code that is not guarded by a certain BTS model / feature flag is what I'm worried about. ASsuming some other BTS model/vendor has a different use of those cbits, we are no longer running into the "return NULL" but we're going to compute an index into the lchan array on something we don't know what it might be. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I957eff0d2c33ec795eda75a4bff21965b0179f73 Gerrit-Change-Number: 24430 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 31 May 2021 10:08:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210531/d8a59d4e/attachment.htm>