This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24380 )
Change subject: VTY: add 'vamos-subslot' to activate a secondary lchan
......................................................................
Patch Set 13:
(2 comments)
https://gerrit.osmocom.org/c/osmo-bsc/+/24380/13/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/24380/13/src/osmo-bsc/bsc_vty.c@6276
PS13, Line 6276: AMOS secondary shadow subslot, range <0-1>
> I don't see this 0-1 range being enforced in the code below? Shouldn't there be something to make s […]
the enforcing of this range is done ...
https://gerrit.osmocom.org/c/osmo-bsc/+/24380/13/src/osmo-bsc/bsc_vty.c@6299
PS13, Line 6299: if (ss_nr >= ts->max_primary_lchans) {
...over here. For TCH/F max_primary_lchans == 1,
and for TCH/H it is 2. If the number is above 0 for TCH/F or above 1 for TCH/H we get below err msg.
When we should one day also add mixed-pchan VAMOS shadows (TCH/F + 2x VAMOS TCH/H), then a TCH/F could also allow vamos-sub-slot up to 1. So far we only support non-mixed pchan, so limiting by max_primary_lchans is what we currently want.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24380
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If44b6bdb78046502eb0b66529ae190a955d9978c
Gerrit-Change-Number: 24380
Gerrit-PatchSet: 13
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 31 May 2021 00:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210531/b8342290/attachment.htm>