This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 ) Change subject: implement Channel Mode Modify to VAMOS mode ...................................................................... Patch Set 10: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2174 PS10, Line 2174: modify lchan > I would use modify-lchan as one word/token here, unless you are plannning to add other alternatiuves […] multiple words: then what about "handover1 power budget interval <1-99>"? ;) (only adopted that from earlier ho config code, i did not invent this cmd myself) i have the pattern ".* lchan 0 0 1 0 .*" consistently re-appearing across VTY commands that I'm adding. (I found the "bts 0 trx 0 ts 1 ss 0" too long and less readable, but at least i'm using my own favorite vty cmd style *consistently*) i think it's nicer to use space, because there is no drawback of having separate words, and indeed it opens the option of introducing other keywords at any place in future. wouldn't be a big thing to add the dash there if you insist. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c Gerrit-Change-Number: 24374 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sun, 30 May 2021 23:58:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210530/a112d2fb/attachment.htm>