Change in osmo-bsc[master]: VTY: add 'vamos-subslot' to activate a secondary lchan

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 30 09:09:12 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24380 )

Change subject: VTY: add 'vamos-subslot' to activate a secondary lchan
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24380/13/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24380/13/src/osmo-bsc/bsc_vty.c@6276 
PS13, Line 6276: AMOS secondary shadow subslot, range <0-1>
I don't see this 0-1 range being enforced in the code below?  Shouldn't there be something to make sure that only <0-1> are valid values if vamos-sub-slot is used?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24380
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If44b6bdb78046502eb0b66529ae190a955d9978c
Gerrit-Change-Number: 24380
Gerrit-PatchSet: 13
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 30 May 2021 09:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210530/32a90c87/attachment.htm>


More information about the gerrit-log mailing list