Change in osmo-bsc[master]: VTY: dump TSC Set and TSC for each timeslot

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 30 07:10:39 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24370 )

Change subject: VTY: dump TSC Set and TSC for each timeslot
......................................................................


Patch Set 9: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24370/9/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24370/9/src/osmo-bsc/bsc_vty.c@1631 
PS9, Line 1631: 		vty_out(vty, "  Training Sequence: Set %d Code %u%s", (lchan->tsc_set > 0 ? lchan->tsc_set : 1), lchan->tsc, VTY_NEWLINE);
the above lines use comma between parameters (connection/state, bs power/ms power). I see teat below for thge IP addresses this is not respected, so I will not hold it against this patch.   However, we definitely should submit a clean-up p atch to unify the formatting after we ahve the series merged.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24370
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7842ff89bece6d88387dae056e350529bae6fc38
Gerrit-Change-Number: 24370
Gerrit-PatchSet: 9
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 30 May 2021 07:10:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210530/f0057e24/attachment.htm>


More information about the gerrit-log mailing list