Change in osmo-bts[master]: sysmobts-mgr: Fix path to hwmon in /sys

[keith]

keith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24433 )

Change subject: sysmobts-mgr: Fix path to hwmon in /sys
......................................................................

sysmobts-mgr: Fix path to hwmon in /sys

The path to the temperature sensor was wrong which
results in the SysmoBTS manager always considering
that the state is critical and hence powering OFF
the PA on startup. (with the default config)

As a further side-effect, the temperatures were not
available in the vty 'show manager' command.

Redacted log previous to this patch:

  sysmobts_misc.c:128 Error reading temperature
  sysmobts_mgr_2050.c:323 Going to enable the PA.
  sysmobts_mgr_temp.c:252 Failed to read the digital temperature. rc=-1
  sysmobts_mgr_temp.c:267 Failed to read the RF temperature. rc=-1
  sysmobts_mgr_temp.c:203 Moving from state NORMAL to CRITICAL.
  sysmobts_mgr_temp.c:185 System has reached critical warning.
  sysmobts_mgr_temp.c:236 OML alert sent: 0

and in the vty:

  Temperature control state: CRITICAL
  Current Temperatures
   Digital: -0.001000 Celsius
   RF:      -0.001000 Celsius

With this patch we correctly enable the PA and now can show in the vty:

  Temperature control state: NORMAL
  Current Temperatures
   Digital: 39.000000 Celsius
   RF:      35.125000 Celsius

Change-Id: Iac8e9a866ad6326874af91bd12a981f39a9a24c7
---
M src/osmo-bts-sysmo/misc/sysmobts_misc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  keith: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-sysmo/misc/sysmobts_misc.c b/src/osmo-bts-sysmo/misc/sysmobts_misc.c
index 8c93979..ae59d78 100644
--- a/src/osmo-bts-sysmo/misc/sysmobts_misc.c
+++ b/src/osmo-bts-sysmo/misc/sysmobts_misc.c
@@ -46,7 +46,7 @@
  * Temperature handling
  *********************************************************************/
 
-#define TEMP_PATH	"/sys/class/hwmon/hwmon0/device/temp%u_%s"
+#define TEMP_PATH	"/sys/class/hwmon/hwmon0/device/hwmon/hwmon0/temp%u_%s"
 
 static const char *temp_type_str[_NUM_TEMP_TYPES] = {
 	[SYSMOBTS_TEMP_INPUT] = "input",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24433
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iac8e9a866ad6326874af91bd12a981f39a9a24c7
Gerrit-Change-Number: 24433
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210528/13ec3cb4/attachment.htm>