This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/24434 ) Change subject: Fix regression in 'osmo-bts-trx: rework and split up bts_sched_fn()' ...................................................................... Fix regression in 'osmo-bts-trx: rework and split up bts_sched_fn()' In [1] I forgot to update tx_fcch_fn(), where we assume that the burst buffer is already zero-initialized and do not call memset(). This results in sending dummy bursts on FCCH (instead of zeros). Change-Id: I491b3b5702b3cfca45c12c002b41e60c629b05b9 Fixes: [1] Iec78989517865b3275a9784d1042a5ebd1d2815f --- M src/osmo-bts-trx/sched_lchan_fcch_sch.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/24434/1 diff --git a/src/osmo-bts-trx/sched_lchan_fcch_sch.c b/src/osmo-bts-trx/sched_lchan_fcch_sch.c index eaf140f..44da04c 100644 --- a/src/osmo-bts-trx/sched_lchan_fcch_sch.c +++ b/src/osmo-bts-trx/sched_lchan_fcch_sch.c @@ -40,8 +40,8 @@ { LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "Transmitting FCCH\n"); - /* A frequency correction burst is basically a sequence of zeros. - * Since br->burst is already zero-initialized, just set the length. */ + /* A frequency correction burst is basically a sequence of zeros */ + memset(br->burst, 0x00, GSM_BURST_LEN); br->burst_len = GSM_BURST_LEN; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I491b3b5702b3cfca45c12c002b41e60c629b05b9 Gerrit-Change-Number: 24434 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210527/eeb04a57/attachment.htm>