Change in osmo-bsc[master]: change bs_power to bs_power_db

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu May 27 14:40:33 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24421 )

Change subject: change bs_power to bs_power_db
......................................................................


Patch Set 6:

> I'm not really sure we really gain something with this patch, specially since ms_power is probably also stored the same way and you are then leaving each one with different metrics.

In my opinion we should not store weird wire encoded formats, requiring code duplication of numeric conversion calculations all over the place. The conversions should be at those places that define that they require a weird format, as it is now: the RSL encoding needs divided-by-two, so apply it there. The meas_vis is (unfortunately) defined as div-two, so apply it there, and so on. But internally we now just store the plain dB value and calculate with it without duplicating the wire decoding step everywhere.

Vadim tells me that ms_power is some magic weird value and I'm not going to take that one on now, because I am working on BS Power.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24421
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I229db1d6bcf532af95aff56b2ad18b5ed9d81616
Gerrit-Change-Number: 24421
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 May 2021 14:40:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210527/9217747f/attachment.htm>


More information about the gerrit-log mailing list