This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24425 ) Change subject: handover: apply meas report BS Power to RXLEV, fix ho oscillation ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/24425/5/src/osmo-bsc/meas_rep.c File src/osmo-bsc/meas_rep.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24425/5/src/osmo-bsc/meas_rep.c@37 PS5, Line 37: return rep->dl.full.rx_lev + (rep->bs_power * 2); > Shouldn't this be doe by the caller of get_field and not this getter itself? looks weird asking for […] i specifically picked this place to apply the BS Power effect, because all of our code expects RXLEV to be the actual practical DL power; fixing the RXLEV value here makes sure that all of the handover and congestion resolution code everywhere uses the value adjusted for practical relevance. We could apply the BS Power to all of the callers separately, but IMHO that would be a bad choice. We could rename the enum values to MEAS_REP_DL_RXLEV_AND_BS_POWER_FULL and *_SUB? or introduce a separate MEAS_REP_DL_RXLEV_RAW (which then no code would use, ever). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifcf59964b5e2d550d79e4ba14d90962808f79dae Gerrit-Change-Number: 24425 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 27 May 2021 14:35:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210527/a1faa606/attachment.htm>