Change in osmo-bsc[master]: AMR config cleanup step 2: filter modes also for VTY

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue May 25 15:55:12 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24357 )

Change subject: AMR config cleanup step 2: filter modes also for VTY
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c 
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c@575 
PS2, Line 575: 	/* If activated for VTY, there may not be a conn indicating an MSC AMR configuration. */
> the user entered some VTY command on telnet which ended up activating/modifying/re-assigning this lc […]
I just wanted to make sure I understood correctly. I wouldn't say "for" and "from" mean exactly the same, they are more like indicating opposite causalities here imho :) "from vty" means to me it was triggered through the VTY, so the VTY originated it, while "for VTY", seems like targeting or aiming at the VTY somehow, hence resolving into some VTY action afterwards, which is a bit weird imho. Not important though.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24357
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
Gerrit-Change-Number: 24357
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 25 May 2021 15:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/0a59fbb1/attachment.htm>


More information about the gerrit-log mailing list