This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24357 ) Change subject: AMR config cleanup step 2: filter modes also for VTY ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c@575 PS2, Line 575: /* If activated for VTY, there may not be a conn indicating an MSC AMR configuration. */ > You mean "activated from VTY" or "activated by VTY" here? the user entered some VTY command on telnet which ended up activating/modifying/re-assigning this lchan. So we are probably activating an lchan for a VTY command. For me all of "for VTY" "from VTY" "by VTY" mean exactly the same. Where is the difference for you? The point in this patch however is to not care about VTY, but pivot on the lack of a BSSAP conn. (incidentally this case happens only when some action was taken on the VTY without an MSC involved) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9 Gerrit-Change-Number: 24357 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 25 May 2021 14:26:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/ec8038cd/attachment.htm>