This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24391 ) Change subject: ctrl: Avoid fclose() on NULL pointer ...................................................................... ctrl: Avoid fclose() on NULL pointer Fixes: 25ff634b5eb06bc1411125dd01efae246e976c4a Related: Coverity CID#236128 Change-Id: Ib23614c77ec039dd0812196fa4e5d1c3f8408087 --- M src/osmo-bsc/bsc_ctrl_commands.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c index 9038404..2d37b5d 100644 --- a/src/osmo-bsc/bsc_ctrl_commands.c +++ b/src/osmo-bsc/bsc_ctrl_commands.c @@ -62,7 +62,7 @@ LOGP(DCTRL, LOGL_NOTICE, "Applying VTY snippet from %s: fopen() failed: %d\n", cmd->value, errno); cmd->reply = "NoFile"; - goto close_ret; + return cmd_ret; } rc = vty_read_config_filep(cfile, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib23614c77ec039dd0812196fa4e5d1c3f8408087 Gerrit-Change-Number: 24391 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210525/945983ca/attachment.htm>