This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24314 ) Change subject: mgcp_common, mgcp_udp_send: make parameter buf const ...................................................................... mgcp_common, mgcp_udp_send: make parameter buf const When mgcp_udp_send() is called, the memory where *buf is pointing to is never modified. It should be marked as const. Change-Id: Iac90de5beb19bf52586ac6ffeab9eb5152edf339 --- M include/osmocom/mgcp/mgcp.h M src/libosmo-mgcp/mgcp_network.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/mgcp/mgcp.h b/include/osmocom/mgcp/mgcp.h index 1de579a..29963cc 100644 --- a/include/osmocom/mgcp/mgcp.h +++ b/include/osmocom/mgcp/mgcp.h @@ -211,4 +211,4 @@ int mgcp_create_bind(const char *source_addr, struct osmo_fd *fd, int port, uint8_t dscp, uint8_t prio); -int mgcp_udp_send(int fd, struct osmo_sockaddr *addr, int port, char *buf, int len); +int mgcp_udp_send(int fd, struct osmo_sockaddr *addr, int port, const char *buf, int len); diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index abe01c9..e03c100 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -177,7 +177,7 @@ * \param[in] buf buffer that holds the data to be send. * \param[in] len length of the data to be sent. * \returns bytes sent, -1 on error. */ -int mgcp_udp_send(int fd, struct osmo_sockaddr *addr, int port, char *buf, int len) +int mgcp_udp_send(int fd, struct osmo_sockaddr *addr, int port, const char *buf, int len) { char ipbuf[INET6_ADDRSTRLEN]; size_t addr_len; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iac90de5beb19bf52586ac6ffeab9eb5152edf339 Gerrit-Change-Number: 24314 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/871ebf54/attachment.htm>