Change in osmo-bsc[master]: ipaccess-config: Clean up sign_link setup helper

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 23 10:30:44 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24267 )

Change subject: ipaccess-config: Clean up sign_link setup helper
......................................................................

ipaccess-config: Clean up sign_link setup helper

Change-Id: I7a5231690c9f2f1c2378b1035900c6c246deb994
---
M src/ipaccess/ipaccess-config.c
1 file changed, 9 insertions(+), 8 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c
index c9264d7..cf649bd 100644
--- a/src/ipaccess/ipaccess-config.c
+++ b/src/ipaccess/ipaccess-config.c
@@ -144,17 +144,18 @@
 	}
 	line->ops = &ipaccess_e1inp_line_ops;
 
-	/* create E1 timeslots for signalling and TRAU frames */
-	e1inp_ts_config_sign(&line->ts[1-1], line);
-	e1inp_ts_config_sign(&line->ts[2-1], line);
+	sign_ts = e1inp_line_ipa_oml_ts(line);
+	rsl_ts = e1inp_line_ipa_rsl_ts(line, 0);
 
-	/* create signalling links for TS1 */
-	sign_ts = &line->ts[1-1];
-	rsl_ts = &line->ts[2-1];
+	/* create E1 timeslots for signalling and TRAU frames */
+	e1inp_ts_config_sign(sign_ts, line);
+	e1inp_ts_config_sign(rsl_ts, line);
+
+	/* create signalling links for TRX0 */
 	oml_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_OML,
-					  bts->c0, 0xff, 0);
+					  bts->c0, IPAC_PROTO_OML, 0);
 	rsl_link = e1inp_sign_link_create(rsl_ts, E1INP_SIGN_RSL,
-					  bts->c0, 0, 0);
+					  bts->c0, IPAC_PROTO_RSL, 0);
 
 	/* create back-links from bts/trx */
 	bts->oml_link = oml_link;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7a5231690c9f2f1c2378b1035900c6c246deb994
Gerrit-Change-Number: 24267
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210523/0a61c717/attachment.htm>


More information about the gerrit-log mailing list