This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/24332 ) Change subject: ipa: do not open socket in nonblocking mode ...................................................................... Patch Set 1: This patch may be a bit controversial, I might need a little help here. The problem is that I am able to open sockets non existing IP-addresses with ipa_client_conn_open(). The reason for this is that the OSMO_SOCK_F_NONBLOCK is set. (see also https://linux.die.net/man/3/connect, "O_NONBLOCK is set for the file descriptor for the socket and the connection cannot be immediately established; the connection shall be established asynchronously.") This means at the moment where I call ipa_client_conn_open(), the connection is not yet made when the call returns. In this patch I remove OSMO_SOCK_F_NONBLOCK. This fixes the problem I have in osmo-bts at the moment. Everything appears to be fine, I also think that since everything in the osmo-world is controlled via a select loop the nonblocking mode is not even necessary but I am not sure. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I926a75920f7a15c670f7445f2e74e876c5fad7be Gerrit-Change-Number: 24332 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 21 May 2021 20:29:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210521/5db323b1/attachment.htm>