Change in osmo-bsc[master]: add missing arg braces in LOG_LCHAN macro

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Fri May 21 16:50:22 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24322 )

Change subject: add missing arg braces in LOG_LCHAN macro
......................................................................

add missing arg braces in LOG_LCHAN macro

Change-Id: Ifd9f868636fda3298bb19c061d3ef194fd941fc3
---
M include/osmocom/bsc/lchan_fsm.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h
index 2d5307a..99964a4 100644
--- a/include/osmocom/bsc/lchan_fsm.h
+++ b/include/osmocom/bsc/lchan_fsm.h
@@ -6,8 +6,8 @@
 
 /* This macro automatically includes a final \n, if omitted. */
 #define LOG_LCHAN(lchan, level, fmt, args...) do { \
-	if (lchan->fi) \
-		LOGPFSML(lchan->fi, level, "(type=%s) " fmt, gsm_lchant_name(lchan->type), ## args); \
+	if ((lchan)->fi) \
+		LOGPFSML((lchan)->fi, level, "(type=%s) " fmt, gsm_lchant_name((lchan)->type), ## args); \
 	else \
 		LOGP(DRSL, level, "%s (not initialized) " fmt, gsm_lchan_name(lchan), ## args); \
 	} while(0)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24322
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd9f868636fda3298bb19c061d3ef194fd941fc3
Gerrit-Change-Number: 24322
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210521/643f0434/attachment.htm>


More information about the gerrit-log mailing list