Change in osmo-bsc[master]: gsm48_send_rr_ass_cmd(): rename dest_lchan to current_lchan

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri May 21 14:14:14 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24296 )

Change subject: gsm48_send_rr_ass_cmd(): rename dest_lchan to current_lchan
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24296/1/src/osmo-bsc/gsm_04_08_rr.c 
File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24296/1/src/osmo-bsc/gsm_04_08_rr.c@569 
PS1, Line 569: int gsm48_send_rr_ass_cmd(struct gsm_lchan *current_lchan, struct gsm_lchan *lchan, uint8_t power_command)
> so what's "lchan" then? I'd really welcome some documentation above the function ,or at least perhap […]
I agree with Pau, it should be clarified somehow. But AFAICS, the 'lchan' is actually the _new_ (destination) lchan that is getting assigned, and this patch just fixes the wrong naming. Further clarification can be done in a separate patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If2c102a8f1d45f84b6a765555abf7cd7a4749b0f
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 21 May 2021 14:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210521/e5ea4b0d/attachment.htm>


More information about the gerrit-log mailing list