This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24235 ) Change subject: tbf: Move existing tbf_state implementation to osmo_fsm ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/24235/3/src/tbf_fsm.h File src/tbf_fsm.h: https://gerrit.osmocom.org/c/osmo-pcu/+/24235/3/src/tbf_fsm.h@30 PS3, Line 30: TBF_EV_FOOBAR This looks a bit odd to me. If you don't have any meaningful events at the moment, can you simply have this enumerated type empty? What's the point of having TBF_EV_FOOBAR? https://gerrit.osmocom.org/c/osmo-pcu/+/24235/3/src/tbf_fsm.c File src/tbf_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/24235/3/src/tbf_fsm.c@83 PS3, Line 83: //.onenter = st_assign_on_enter, Are you planning to implement these commented out handlers any time soon? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6bb4baea2dee191ba5bbcbec2ea9dcf681aa1237 Gerrit-Change-Number: 24235 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Fri, 21 May 2021 12:23:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210521/84320d6b/attachment.htm>