Change in osmo-gsm-tester[master]: srs-enb: sets the remote directory to the given one.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 20 12:55:36 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24282 )

Change subject: srs-enb: sets the remote directory to the given one.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24282/1/src/osmo_gsm_tester/obj/enb_srs.py 
File src/osmo_gsm_tester/obj/enb_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24282/1/src/osmo_gsm_tester/obj/enb_srs.py@101 
PS1, Line 101:         
trailing whitespace


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24282/1/src/osmo_gsm_tester/obj/enb_srs.py@107 
PS1, Line 107:                 return
return not needed here after raise


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24282/1/src/osmo_gsm_tester/obj/enb_srs.py@110 
PS1, Line 110:             srsENB.REMOTE_DIR = path
so you are changing a static field here? meaning you are changing the path for ALL instances. Not sure what you are trying to achieve here but doesn't look like the proper way of doing it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24282
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I77a56835a4054b86d1d3f7da823a013b3370f767
Gerrit-Change-Number: 24282
Gerrit-PatchSet: 1
Gerrit-Owner: Alejandro Leal <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 May 2021 12:55:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/a97d5f56/attachment.htm>


More information about the gerrit-log mailing list