Change in osmo-gsm-tester[master]: srs-enb: patches the binary in fapi rf device with the given library_...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 20 12:53:42 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281 )

Change subject: srs-enb: patches the binary in fapi rf device with the given library_path.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py 
File src/osmo_gsm_tester/obj/enb_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py@398 
PS1, Line 398:                 path = self._conf.get('library_path', None)
So this is some library in some rando path in the system? why is it not in the trial? I think all this deserves proper description of the setup and why is it done this way.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py@401 
PS1, Line 401:                     return 
trailing whitespace


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281/1/src/osmo_gsm_tester/obj/enb_srs.py@404 
PS1, Line 404:                 self.rem_host.change_elf_force_rpath(remote_binary, path)
why is the usual change_elf_rpath() working here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24281
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Icd7689a41a1c5fe8e4c427f3b9bc69b3f2b0f8ac
Gerrit-Change-Number: 24281
Gerrit-PatchSet: 1
Gerrit-Owner: Alejandro Leal <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 May 2021 12:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/e3444da6/attachment.htm>


More information about the gerrit-log mailing list