Change in osmo-sgsn[master]: add support for multiple encryption algorithms + a5/4

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 20 12:09:59 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/24304 )

Change subject: add support for multiple encryption algorithms + a5/4
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/1/src/sgsn/gprs_llc.c 
File src/sgsn/gprs_llc.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/1/src/sgsn/gprs_llc.c@718 
PS1, Line 718: 
Non-related


https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/1/src/sgsn/gprs_sgsn.c 
File src/sgsn/gprs_sgsn.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/1/src/sgsn/gprs_sgsn.c@296 
PS1, Line 296: 	ctx->ciph_algo = GPRS_ALGO_GEA4; // overwritten on attach
We does it need to be set here if it's overwritten later?
(In general we use /* */ style for comments.)


https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/1/src/sgsn/sgsn_vty.c 
File src/sgsn/sgsn_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/1/src/sgsn/sgsn_vty.c@1710 
PS1, Line 1710: 	g_cfg->cipher_support_mask = 1; // default to GEA0 support
/* */



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/24304
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie6700c4e9d2df1eb5fde1b971e287b62668cc2de
Gerrit-Change-Number: 24304
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 May 2021 12:09:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/33d8cc7a/attachment.htm>


More information about the gerrit-log mailing list