Change in osmo-bts[2021q1]: osmo-bts-trx: remove redundant assert() in bts_sched_fn()

[osmith]

Hello fixeria,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/osmo-bts/+/24312

to review the following change.


Change subject: osmo-bts-trx: remove redundant assert() in bts_sched_fn()
......................................................................

osmo-bts-trx: remove redundant assert() in bts_sched_fn()

trx_phy_instance() does assert() that the given TRX pointer is
not NULL.  In bts_sched_fn() it can never be NULL, so drop it.

Change-Id: I896ff5117588f2229cc54619ce62fd027a9ef25f
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/24312/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 5937b85..7d5cbfc 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -107,7 +107,7 @@
 
 	/* process every TRX */
 	llist_for_each_entry(trx, &bts->trx_list, list) {
-		struct phy_instance *pinst = trx_phy_instance(trx);
+		struct phy_instance *pinst = trx->pinst;
 		struct phy_link *plink = pinst->phy_link;
 		struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
 		struct l1sched_trx *l1t = &l1h->l1s;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24312
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: 2021q1
Gerrit-Change-Id: I896ff5117588f2229cc54619ce62fd027a9ef25f
Gerrit-Change-Number: 24312
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210520/9358be34/attachment.htm>