Change in osmo-pcu[master]: sched: Clean up param passing and improve logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 13 11:40:32 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23994 )

Change subject: sched: Clean up param passing and improve logging
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/23994/3/src/gprs_rlcmac_sched.cpp 
File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23994/3/src/gprs_rlcmac_sched.cpp@485 
PS3, Line 485: 
> As far as I can see, the calling function gprs_rlcmac_rcv_rts_block() basically does resolve a point […]
pdch object is obtained from exactly those trx and ts params in line 428:
"pdch = &bts->trx[trx].pdch[ts];"

"I have difficulties see why..." That's exactly why I'm doing all this clean up, it also happened to me. I'm rearranging code to soon obtain the PDCH and then simply pass the PDCH object around instead of trx+ts and and other information (and we gain the object to standarize logging for free while doing so).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If137a2aaac7744e60564ca833a1b5564ed7d93bb
Gerrit-Change-Number: 23994
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 13 May 2021 11:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210513/3cdb5470/attachment.htm>


More information about the gerrit-log mailing list