Change in osmo-pcu[master]: sched: Clean up param passing and improve logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed May 12 21:42:40 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23994 )

Change subject: sched: Clean up param passing and improve logging
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

I am fine with this change, but would be good to add commit message as was asked by @dexter.

https://gerrit.osmocom.org/c/osmo-pcu/+/23994/3/src/gprs_rlcmac_sched.cpp 
File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23994/3/src/gprs_rlcmac_sched.cpp@485 
PS3, Line 485: 
> The patch looks logical to me but I have difficulties see why the ts and trx values in pdch are equi […]
As far as I can see, the calling function gprs_rlcmac_rcv_rts_block() basically does resolve a pointer to PDCH from 'trx' and 'ts' values it gets in the RTS message. In this function we basically do the opposite: getting 'trx' and 'ts' values back from PDCH. This could have been the commit message ;)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If137a2aaac7744e60564ca833a1b5564ed7d93bb
Gerrit-Change-Number: 23994
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 12 May 2021 21:42:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210512/e0ec7a7d/attachment.htm>


More information about the gerrit-log mailing list