This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24210 ) Change subject: ul_tbf: Simplify function rcv_data_block_acknowledged ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/24210/2/src/tbf_ul.cpp File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/24210/2/src/tbf_ul.cpp@437 PS2, Line 437: continue; > The original code would not "continue" here. […] Yes, it's part of the change, to keep same behavior. See how this branchdoesn't set need_rlc_data to true, and hence it would anyway hit the "continue" below which was removed. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I77afaa617d7ce045c0f6d994fc0d8e03fe69de53 Gerrit-Change-Number: 24210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Wed, 12 May 2021 17:31:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210512/704738a9/attachment.htm>