Change in libosmo-sccp[master]: m3ua/sua: Add new snm_inactive quirk

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue May 11 19:09:34 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/24216 )

Change subject: m3ua/sua: Add new snm_inactive quirk
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

I can not say so much about the technical background but the logic looks correct to me.

https://gerrit.osmocom.org/c/libosmo-sccp/+/24216/1/src/m3ua.c 
File src/m3ua.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/24216/1/src/m3ua.c@937 
PS1, Line 937: 	    !(asp->fi->state == XUA_ASP_S_INACTIVE && asp->cfg.quirks & OSMO_SS7_ASP_QUIRK_SNM_INACTIVE)) {
I don't know what your policy is with those spec deviations, but I would put a log message that a violation happened.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/24216
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I193dd546b3e3c00e29f192d0d1bf7819b3e194be
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 May 2021 19:09:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210511/ededd381/attachment.htm>


More information about the gerrit-log mailing list