Change in osmo-pcu[master]: Drop existing tbf->ms() check condition

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue May 11 12:24:35 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24205 )


Change subject: Drop existing tbf->ms() check condition
......................................................................

Drop existing tbf->ms() check condition

Since a while ago, tbf should always have an MS attached since its
creation, so there's no sense to check for it here.

Change-Id: If056a3fb83b43a48c2a6382fc30c6c81fe2b2651
---
M src/tbf_ul.cpp
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/24205/1

diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index 9d984a6..272d8b3 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -407,8 +407,7 @@
 	gprs_rlcmac_rssi(this, rssi);
 
 	/* store measurement values */
-	if (ms())
-		ms_update_l1_meas(ms(), meas);
+	ms_update_l1_meas(ms(), meas);
 
 	uint32_t new_tlli = GSM_RESERVED_TMSI;
 	unsigned int block_idx;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24205
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If056a3fb83b43a48c2a6382fc30c6c81fe2b2651
Gerrit-Change-Number: 24205
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210511/bbf7ff3c/attachment.htm>


More information about the gerrit-log mailing list