Change in osmo-ttcn3-hacks[master]: msc: Verify CommonID contains LastUsedEutranPLMNId when in CSFB

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969 )

Change subject: msc: Verify CommonID contains LastUsedEutranPLMNId when in CSFB
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/2/library/BSSMAP_Templates.ttcn 
File library/BSSMAP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969/2/library/BSSMAP_Templates.ttcn@1184 
PS2, Line 1184: 	} else if (not istemplatekind(mcc_mnc, "omit")) {
Why not switch this and the else and avoid "not istemplatekind"?

  } else if (istemplatekind(mcc_mnc, "omit")) {

That's slightly more readable IMHO.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23969
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I161529fd9c8cacb7d17ea18660998df06bb0b575
Gerrit-Change-Number: 23969
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 May 2021 12:16:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210511/1ab8e16a/attachment.htm>