This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24202 ) Change subject: encoding: Use gsm48_ta_is_valid() API ...................................................................... encoding: Use gsm48_ta_is_valid() API Change-Id: Ieaa4c2f926611576e22eaac8a7ac595135809e2c --- M src/encoding.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/02/24202/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index 136532c..22da6ab 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -661,7 +661,7 @@ } /* Packet Timing Advance (if known) */ - if (tbf->ta() <= 63) { /* { 0 | 1 < TIMING_ADVANCE_VALUE : bit (6) > } */ + if (gsm48_ta_is_valid(tbf->ta())) { /* { 0 | 1 < TIMING_ADVANCE_VALUE : bit (6) > } */ pta->Exist_TIMING_ADVANCE_VALUE = 0x01; // Present pta->TIMING_ADVANCE_VALUE = tbf->ta(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ieaa4c2f926611576e22eaac8a7ac595135809e2c Gerrit-Change-Number: 24202 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210511/54a61d33/attachment.htm>