Change in osmo-bts[master]: [VAMOS] Merge bts_trx_init() into gsm_bts_trx_alloc()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue May 11 02:02:23 UTC 2021


Hello Jenkins Builder, pespin, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-bts/+/24177

to look at the new patch set (#3).

Change subject: [VAMOS] Merge bts_trx_init() into gsm_bts_trx_alloc()
......................................................................

[VAMOS] Merge bts_trx_init() into gsm_bts_trx_alloc()

gsm_bts_trx_alloc() already does initialize some fields of the
allocated 'struct gsm_bts_trx' instance, and having an additional
function for initializing the other fields makes no sense.

Note that I intentionally didn't merge a call to bts_model_trx_init()
into gsm_bts_trx_alloc(), because this would break some assumptions
regarding the order of initialization and cause regressions.

This also allows us to not call bts_model_trx_init() from tests.

Change-Id: I4aefaf47b05a67ec0c4774c1ee7abcc95e04cc13
---
M include/osmo-bts/bts_trx.h
M src/common/bts.c
M src/common/bts_trx.c
M src/common/vty.c
M tests/handover/handover_test.c
M tests/meas/meas_test.c
6 files changed, 11 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/77/24177/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24177
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4aefaf47b05a67ec0c4774c1ee7abcc95e04cc13
Gerrit-Change-Number: 24177
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210511/af961ac7/attachment.htm>


More information about the gerrit-log mailing list