Change in osmo-gsm-tester[master]: open5gs: fix stopping of open5gs components after test finishes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon May 10 17:21:58 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24185 )

Change subject: open5gs: fix stopping of open5gs components after test finishes
......................................................................

open5gs: fix stopping of open5gs components after test finishes

use RemoteProcessSafeExit() for launching all open5gs components
to make sure they are stopped at the end as well.

Change-Id: Ia1439577d60f9694da70c4e42c621100c8ef295e
---
M src/osmo_gsm_tester/obj/hss_open5gs.py
M src/osmo_gsm_tester/obj/mme_open5gs.py
M src/osmo_gsm_tester/obj/pcrf_open5gs.py
M src/osmo_gsm_tester/obj/sgwc_open5gs.py
M src/osmo_gsm_tester/obj/sgwu_open5gs.py
M src/osmo_gsm_tester/obj/smf_open5gs.py
M src/osmo_gsm_tester/obj/upf_open5gs.py
7 files changed, 14 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/obj/hss_open5gs.py b/src/osmo_gsm_tester/obj/hss_open5gs.py
index 211d09a..8ffb3b0 100644
--- a/src/osmo_gsm_tester/obj/hss_open5gs.py
+++ b/src/osmo_gsm_tester/obj/hss_open5gs.py
@@ -75,8 +75,9 @@
         remote_binary = self.remote_inst.child('bin', Open5gsHSS.BINFILE)
 
         args = (remote_binary, '-c', self.remote_config_file)
+        remote_run_dir = util.Dir(util.Dir(Open5gsHSS.REMOTE_DIR).child(Open5gsHSS.BINFILE))
 
-        self.process = self.rem_host.RemoteProcess(Open5gsHSS.BINFILE, args, remote_env=remote_env)
+        self.process = self.rem_host.RemoteProcessSafeExit(Open5gsHSS.BINFILE, remote_run_dir, args, remote_env=remote_env)
         self.testenv.remember_to_stop(self.process)
         self.process.launch()
 
diff --git a/src/osmo_gsm_tester/obj/mme_open5gs.py b/src/osmo_gsm_tester/obj/mme_open5gs.py
index 0b3d633..25202f5 100644
--- a/src/osmo_gsm_tester/obj/mme_open5gs.py
+++ b/src/osmo_gsm_tester/obj/mme_open5gs.py
@@ -81,8 +81,9 @@
         self.rem_host.setcap_net_admin(remote_binary)
 
         args = (remote_binary, '-c', self.remote_config_file)
+        remote_run_dir = util.Dir(util.Dir(Open5gsMME.REMOTE_DIR).child(Open5gsMME.BINFILE))
 
-        self.process = self.rem_host.RemoteProcess(Open5gsMME.BINFILE, args)
+        self.process = self.rem_host.RemoteProcessSafeExit(Open5gsMME.BINFILE, remote_run_dir, args)
         self.testenv.remember_to_stop(self.process)
         self.process.launch()
 
diff --git a/src/osmo_gsm_tester/obj/pcrf_open5gs.py b/src/osmo_gsm_tester/obj/pcrf_open5gs.py
index 4f93a47..5383b4f 100644
--- a/src/osmo_gsm_tester/obj/pcrf_open5gs.py
+++ b/src/osmo_gsm_tester/obj/pcrf_open5gs.py
@@ -75,8 +75,9 @@
         remote_binary = self.remote_inst.child('bin', Open5gsPCRF.BINFILE)
 
         args = (remote_binary, '-c', self.remote_config_file)
+        remote_run_dir = util.Dir(util.Dir(Open5gsPCRF.REMOTE_DIR).child(Open5gsPCRF.BINFILE))
 
-        self.process = self.rem_host.RemoteProcess(Open5gsPCRF.BINFILE, args, remote_env=remote_env)
+        self.process = self.rem_host.RemoteProcessSafeExit(Open5gsPCRF.BINFILE, remote_run_dir, args, remote_env=remote_env)
         self.testenv.remember_to_stop(self.process)
         self.process.launch()
 
diff --git a/src/osmo_gsm_tester/obj/sgwc_open5gs.py b/src/osmo_gsm_tester/obj/sgwc_open5gs.py
index efc4568..394f1e7 100644
--- a/src/osmo_gsm_tester/obj/sgwc_open5gs.py
+++ b/src/osmo_gsm_tester/obj/sgwc_open5gs.py
@@ -72,8 +72,9 @@
         remote_binary = self.remote_inst.child('bin', Open5gsSGWC.BINFILE)
 
         args = (remote_binary, '-c', self.remote_config_file)
+        remote_run_dir = util.Dir(util.Dir(Open5gsSGWC.REMOTE_DIR).child(Open5gsSGWC.BINFILE))
 
-        self.process = self.rem_host.RemoteProcess(Open5gsSGWC.BINFILE, args, remote_env=remote_env)
+        self.process = self.rem_host.RemoteProcessSafeExit(Open5gsSGWC.BINFILE, remote_run_dir, args, remote_env=remote_env)
         self.testenv.remember_to_stop(self.process)
         self.process.launch()
 
diff --git a/src/osmo_gsm_tester/obj/sgwu_open5gs.py b/src/osmo_gsm_tester/obj/sgwu_open5gs.py
index b97dd92..79fab8d 100644
--- a/src/osmo_gsm_tester/obj/sgwu_open5gs.py
+++ b/src/osmo_gsm_tester/obj/sgwu_open5gs.py
@@ -72,8 +72,9 @@
         remote_binary = self.remote_inst.child('bin', Open5gsSGWU.BINFILE)
 
         args = (remote_binary, '-c', self.remote_config_file)
+        remote_run_dir = util.Dir(util.Dir(Open5gsSGWU.REMOTE_DIR).child(Open5gsSGWU.BINFILE))
 
-        self.process = self.rem_host.RemoteProcess(Open5gsSGWU.BINFILE, args, remote_env=remote_env)
+        self.process = self.rem_host.RemoteProcessSafeExit(Open5gsSGWU.BINFILE, remote_run_dir, args, remote_env=remote_env)
         self.testenv.remember_to_stop(self.process)
         self.process.launch()
 
diff --git a/src/osmo_gsm_tester/obj/smf_open5gs.py b/src/osmo_gsm_tester/obj/smf_open5gs.py
index 5241dc2..eda1aa2 100644
--- a/src/osmo_gsm_tester/obj/smf_open5gs.py
+++ b/src/osmo_gsm_tester/obj/smf_open5gs.py
@@ -75,8 +75,9 @@
         remote_binary = self.remote_inst.child('bin', Open5gsSMF.BINFILE)
 
         args = (remote_binary, '-c', self.remote_config_file)
+        remote_run_dir = util.Dir(util.Dir(Open5gsSMF.REMOTE_DIR).child(Open5gsSMF.BINFILE))
 
-        self.process = self.rem_host.RemoteProcess(Open5gsSMF.BINFILE, args, remote_env=remote_env)
+        self.process = self.rem_host.RemoteProcessSafeExit(Open5gsSMF.BINFILE, remote_run_dir, args, remote_env=remote_env)
         self.testenv.remember_to_stop(self.process)
         self.process.launch()
 
diff --git a/src/osmo_gsm_tester/obj/upf_open5gs.py b/src/osmo_gsm_tester/obj/upf_open5gs.py
index f22a6d7..78a520f 100644
--- a/src/osmo_gsm_tester/obj/upf_open5gs.py
+++ b/src/osmo_gsm_tester/obj/upf_open5gs.py
@@ -79,8 +79,9 @@
         self.rem_host.setcap_net_admin(remote_binary)
 
         args = (remote_binary, '-c', self.remote_config_file)
+        remote_run_dir = util.Dir(util.Dir(Open5gsUPF.REMOTE_DIR).child(Open5gsUPF.BINFILE))
 
-        self.process = self.rem_host.RemoteProcess(Open5gsUPF.BINFILE, args)
+        self.process = self.rem_host.RemoteProcessSafeExit(Open5gsUPF.BINFILE, remote_run_dir, args)
         self.testenv.remember_to_stop(self.process)
         self.process.launch()
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ia1439577d60f9694da70c4e42c621100c8ef295e
Gerrit-Change-Number: 24185
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210510/a024465b/attachment.htm>


More information about the gerrit-log mailing list