Change in pysim[master]: commands: pad short data input in update_record()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon May 10 16:39:23 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24008 )

Change subject: commands: pad short data input in update_record()
......................................................................


Patch Set 6:

> doesn't this break the partial update of a record?
> 
> I would think it's legal to say "I want to updte only the first two bytes of a record" without writing the entire record (which can be long).
> 
> Wouldn't your patch now overwrite the remainder of the record with padding?

This is something I do not know for sure, I never managed to partially update a record, the card always rejected that. Only updating the record as a whole worked for me. I have now checked ETSI TS 102 221, section 11.1.6.1, it reads "This function updates one specific, complete record in the current linear fixed or cyclic EF.", so it seems that it is not possible to partially update a record.

In any case, maybe it makes sense to read the record and use that data as padding? I am not convinced by this, if we for instance encode TLV data the resulting length may vary, if the data is sorter than the data that was in that record before it will leave trash at the end of the new TLV data.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24008
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9a5df0e46c3dd2e87d447c5c01cf15844b0eed07
Gerrit-Change-Number: 24008
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 10 May 2021 16:39:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210510/f87aec98/attachment.htm>


More information about the gerrit-log mailing list