This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24141 ) Change subject: cards: get rid of "kls" parameter in autodetect methods ...................................................................... Patch Set 2: Code-Review-2 (1 comment) https://gerrit.osmocom.org/c/pysim/+/24141/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/pysim/+/24141/2//COMMIT_MSG@10 PS2, Line 10: for unknown reason Well, there is a reason: it's defined as a '@classmethod'. This means that you can call it directly without insinuating MagicSimBase, i.e. MagicSimBase.autodetect(). As far as I can see, this is what the code is supposed to do and this method returns an instance itself. So your change is wrong, there is no 'self' in classmethods (you can still use any arbitrary name though). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e5defee394e1301bad8f04853fab8e9ded84335 Gerrit-Change-Number: 24141 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 06 May 2021 18:43:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210506/eb033d0e/attachment.htm>