Change in pysim[master]: ts_102_221: fix unknown TLV key '9B' on SysmoSIM-SJS1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu May 6 16:24:39 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24159 )

Change subject: ts_102_221: fix unknown TLV key '9B' on SysmoSIM-SJS1
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/24159/1/pySim/ts_102_221.py 
File pySim/ts_102_221.py:

https://gerrit.osmocom.org/c/pysim/+/24159/1/pySim/ts_102_221.py@186 
PS1, Line 186:     tlv_map['9B'] = 'unknown_9B' # found on SysmoSIM-SJS1; seems to mirror the file path
Please call it sysmoUSIM-SJS1 in both the commit log and here.  Theren were sysmoSIM-* cards, but not SJS1. Thanks.

Please call the attribute 'target_ef'.  It refers to linked files.  Think of symlinks on a linux machine: you can have multiple directory entries pointing to the same file (e.g. from ADF.USIM/DF_GSM_ACCESS to files in DF_GSM.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24159
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8131bfbbdeb50ddb4d6a06c16586238a36582b5e
Gerrit-Change-Number: 24159
Gerrit-PatchSet: 1
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 06 May 2021 16:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210506/e049163a/attachment.htm>


More information about the gerrit-log mailing list