Change in libosmocore[master]: gb: Fix naming and export symbol bssgp_enc_rim_pdu

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 6 16:14:19 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24162 )

Change subject: gb: Fix naming and export symbol bssgp_enc_rim_pdu
......................................................................

gb: Fix naming and export symbol bssgp_enc_rim_pdu

The symbol was not in the list of exported symbols.
Take the chance that it was not used anywhere outside libosmocore to
rename it in order to follow similar naming as other existing APIs.

Change-Id: I534db7d8bc5ceb19a2a6866f07d5f5c70e456c5c
---
M include/osmocom/gprs/gprs_bssgp_rim.h
M src/gb/gprs_bssgp_rim.c
M src/gb/libosmogb.map
3 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, approved



diff --git a/include/osmocom/gprs/gprs_bssgp_rim.h b/include/osmocom/gprs/gprs_bssgp_rim.h
index 5f397c9..41d7982 100644
--- a/include/osmocom/gprs/gprs_bssgp_rim.h
+++ b/include/osmocom/gprs/gprs_bssgp_rim.h
@@ -267,6 +267,6 @@
 };
 
 int bssgp_parse_rim_pdu(struct bssgp_ran_information_pdu *pdu, const struct msgb *msg);
-struct msgb *bssgp_encode_rim_pdu(const struct bssgp_ran_information_pdu *pdu);
+struct msgb *bssgp_enc_rim_pdu(const struct bssgp_ran_information_pdu *pdu);
 
 int bssgp_tx_rim(const struct bssgp_ran_information_pdu *pdu, uint16_t nsei);
diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index 63b303e..00b3826 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -1059,7 +1059,7 @@
 /*! Encode a given rim-pdu struct into a message buffer.
  *  \param[out] pdu user provided memory that contains the RAN INFORMATION PDU to encode.
  *  \returns BSSGP message buffer on sccess, NULL on error. */
-struct msgb *bssgp_encode_rim_pdu(const struct bssgp_ran_information_pdu *pdu)
+struct msgb *bssgp_enc_rim_pdu(const struct bssgp_ran_information_pdu *pdu)
 {
 	struct msgb *msg = bssgp_msgb_alloc();
 	struct bssgp_normal_hdr *bgph;
@@ -1160,7 +1160,7 @@
 	char ri_dest_str[64];
 
 	/* Encode RIM PDU into mesage buffer */
-	msg = bssgp_encode_rim_pdu(pdu);
+	msg = bssgp_enc_rim_pdu(pdu);
 	if (!msg) {
 		LOGP(DLBSSGP, LOGL_ERROR,
 		     "BSSGP RIM (NSEI=%u) unable to encode BSSGP RIM PDU\n", nsei);
diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map
index db638f9..44e622c 100644
--- a/src/gb/libosmogb.map
+++ b/src/gb/libosmogb.map
@@ -20,6 +20,7 @@
 bssgp_enc_ran_inf_app_cont_nacc;
 bssgp_enc_ran_inf_app_err_rim_cont;
 bssgp_enc_ran_inf_rim_cont;
+bssgp_enc_rim_pdu;
 bssgp_fc_in;
 bssgp_fc_init;
 bssgp_fc_ms_init;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24162
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I534db7d8bc5ceb19a2a6866f07d5f5c70e456c5c
Gerrit-Change-Number: 24162
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210506/1e26f378/attachment.htm>


More information about the gerrit-log mailing list