Change in osmo-mgw[master]: add osmo_mgcpc_ep_ci_get_remote_rtp_info()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 6 12:59:14 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24145 )

Change subject: add osmo_mgcpc_ep_ci_get_remote_rtp_info()
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/24145/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c 
File src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24145/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c@511 
PS1, Line 511: /*! Return the RTP port information that MGW is receiving on for this connection, as returned by the last CRCX-OK /
> "the RTP port where MGW is receiving on" is IMHO the clearest description... […]
Yes please, "local" and "remote" is a usual terminology which helps understanding quickly.


https://gerrit.osmocom.org/c/osmo-mgw/+/24145/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c@523 
PS1, Line 523: /*! Return the RTP port information that the MGW is sending to for this connection, as sent to the MGW by the last
> hmm "MGW's remote RTP port" is again a bit weird, because it is the port of the MGW's peer, not belo […]
"MGW's remote RTP port".

The problem seems to be that in libosmo-mgcp-client, the "local" port would be the one bound in the client, and the remote would be the one listening on the MGW. So it may actually may sense to change the API name here...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24145
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibb488925827d9dc0ccb1f8d6d84728745d086793
Gerrit-Change-Number: 24145
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 06 May 2021 12:59:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210506/730d252a/attachment.htm>


More information about the gerrit-log mailing list