Change in osmo-mgw[master]: Add vty command 'show mgcp active'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Wed May 5 19:02:47 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24131 )

Change subject: Add vty command 'show mgcp active'
......................................................................


Patch Set 3:

(3 comments)

> Patch Set 2: Verified+1 Code-Review+1
> 
> (3 comments)
> 
> Looks good to me. I wonder if show mgcp active [stats] makes sense, but apparently multiple optional non exclusive flags are not easy to model.

I did have show mgcp active [stats], but decided to remove it, as I wondered if it would mean show stats for active connection or something, which doesn't really make sense. Maybe a "show mgcp stats" command that does not also iterate and dump all the endpoints would be better?

thanks.

https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c@324 
PS2, Line 324: 		}
> maybe print something when no calls are active, otherwise the user only sees: […]
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c@355 
PS2, Line 355:       "Include Statistics\n")
> I think it should be "Include statistics"
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/24131/2/src/libosmo-mgcp/mgcp_vty.c@365 
PS2, Line 365:       "Show only Endpoints with Active Connections\n")
> I am not an expert in spelling, but I think "Show only endpoints with active connections" is better. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I23a26b4fdc03d8b2469d293dd6c06ed83ce739e9
Gerrit-Change-Number: 24131
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 05 May 2021 19:02:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210505/c50c10ea/attachment.htm>


More information about the gerrit-log mailing list