This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24145 ) Change subject: add osmo_mgcpc_ep_ci_get_remote_rtp_info() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/24145/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c File src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24145/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c@511 PS1, Line 511: /*! Return the RTP port information that MGW is receiving on for this connection, as returned by the last CRCX-OK / > What about "Return the RTP local port information". "the RTP port where MGW is receiving on" is IMHO the clearest description... "local" is not clear at all: >From the perspective of the MGCP client, 'local' would mean e.g. osmo-bsc, 'remote' would mean MGW. >From the MGW perspective, 'local' would be MGW and 'remote' would be BTS/SIP/other MGW... "MGW's local RTP port" would work. should I change that? https://gerrit.osmocom.org/c/osmo-mgw/+/24145/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c@523 PS1, Line 523: /*! Return the RTP port information that the MGW is sending to for this connection, as sent to the MGW by the last > RTP remote port hmm "MGW's remote RTP port" is again a bit weird, because it is the port of the MGW's peer, not belonging to the MGW at all. "MGW's remote port" may sound a bit like it is the port where the peer is sending RTP to. Are you sure that changing the wording improves the doc? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb488925827d9dc0ccb1f8d6d84728745d086793 Gerrit-Change-Number: 24145 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 05 May 2021 16:40:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210505/78243249/attachment.htm>