Change in libosmocore[master]: gprs_ns2_sns: move selection of the next bind into own function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed May 5 09:26:36 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24122 )

Change subject: gprs_ns2_sns: move selection of the next bind into own function
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24122/2/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/24122/2/src/gb/gprs_ns2_sns.c@889 
PS2, Line 889: 	if (!gss->initial_bind) {
this can be furhter simplified to:
if (!gss->initial_bind || ss->initial_bind->list.next == &gss->binds) {
  gss->initial_bind = llist_first_entry(&gss->binds, struct ns2_sns_bind, list);
} else {
  gss->initial_bind = llist_entry(gss->initial_bind->list.next, struct ns2_sns_bind, list);
}



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24122
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic39f0e5474ecc055d9a1b6a7b30777574d8b741d
Gerrit-Change-Number: 24122
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 05 May 2021 09:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210505/b726c765/attachment.htm>


More information about the gerrit-log mailing list